P4Error when click on View Diff
Hello, We are using RB-Beta version integrated with Perforce. Suddendly, from yesterday evening, for all of the reviews in RB, when someone clicks on View Diff, we get below error. Any pointers to debug this issue? Traceback (most recent call last): File /usr/local/lib64/python2.5/site-packages/reviewboard/ diffviewer/views.py, line 82, in view_diff files = get_diff_files(diffset, None, interdiffset, highlighting) File /usr/local/lib64/python2.5/site-packages/reviewboard/ diffviewer/diffutils.py, line 561, in get_diff_files enable_syntax_highlighting) File /usr/local/lib64/python2.5/site-packages/reviewboard/ diffviewer/diffutils.py, line 500, in generate_files lambda: get_chunks(filediff.diffset, File /usr/local/lib64/python2.5/site-packages/djblets/util/ misc.py, line 47, in cache_memoize data = lookup_callable() File /usr/local/lib64/python2.5/site-packages/reviewboard/ diffviewer/diffutils.py, line 503, in lambda enable_syntax_highlighting)) File /usr/local/lib64/python2.5/site-packages/reviewboard/ diffviewer/diffutils.py, line 297, in get_chunks old = get_original_file(filediff) File /usr/local/lib64/python2.5/site-packages/reviewboard/ diffviewer/diffutils.py, line 208, in get_original_file return cache_memoize(key, lambda: [tool.get_file(file, revision)]) [0] File /usr/local/lib64/python2.5/site-packages/djblets/util/ misc.py, line 47, in cache_memoize data = lookup_callable() File /usr/local/lib64/python2.5/site-packages/reviewboard/ diffviewer/diffutils.py, line 208, in lambda return cache_memoize(key, lambda: [tool.get_file(file, revision)]) [0] File /usr/local/lib64/python2.5/site-packages/reviewboard/scmtools/ perforce.py, line 89, in get_file raise P4Error('\n'.join(line[1:] for line in error[1:])) P4Error -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to confiure EMAILS for Reviews
On Nov 6, 9:40 am, zinou zinou...@gmail.com wrote: Hello, i've installed reviewboard 1.0.5 and i configuredsmtpserver correctly and checked Send e-mails for review requests and reviews, the problem is when i post a new reveiew or comment, i got an error due to enability to send emails to reviewers, i know this because i I ran into this same email (using our Exchange server as the SMTP server) On the mail settings page it asks for server, port, username and password. I had entered my username and password there and had the same behaviour you do - error messages would go out but I'd get 500 error messages. Taking my username/password out of the mail settings seems to have fixed things for me. Jim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Binary Files handling in RB 1.0.5
Assuming that the files are marked as Binary files in Perforce, Review-Board should ignore them and properly say something along the lines of Binary files differ. -Tom On Tue, Dec 1, 2009 at 6:51 PM, Kunjal kunjal.par...@gmail.com wrote: Hello, In our development environment, we have lot of reviews only with Binary files. For example, If I post the review with 4 binary files, what should happen when I click on View Diff? For now, I just try with one binary file, and I get below message when I click on View Diff. Is there any work-around for binary files? The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/ reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: Traceback (most recent call last): File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 153, in view_diff interdiffset, highlighting, True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Binary Files handling in RB 1.0.5
The perforce has marked them as binary file. Why I get error message instead of some standard message saying this is binary file or similar? Do I need to install some patch ? On Dec 1, 5:04 pm, Tom Sakkos nasis...@gmail.com wrote: Assuming that the files are marked as Binary files in Perforce, Review-Board should ignore them and properly say something along the lines of Binary files differ. -Tom On Tue, Dec 1, 2009 at 6:51 PM, Kunjal kunjal.par...@gmail.com wrote: Hello, In our development environment, we have lot of reviews only with Binary files. For example, If I post the review with 4 binary files, what should happen when I click on View Diff? For now, I just try with one binary file, and I get below message when I click on View Diff. Is there any work-around for binary files? The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/ reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: Traceback (most recent call last): File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 153, in view_diff interdiffset, highlighting, True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RB and Browser Compatibilty.
We are on verge of rolling out RB 1.0.5 to 300+ developers. Some of our developers use IE and some of them use FireFox. Does RB 1.0.5 work with both browser seamless? During my testing I did not find the difference but I might have missed something. Pl. let me know if there is any preference of browser we should enforce to our developers. Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB and Browser Compatibilty.
IE6 support is a little rocky, but IE7, IE8, and all similarly recent versions of firefox are supported. -David On Tue, Dec 1, 2009 at 5:18 PM, Kunjal kunjal.par...@gmail.com wrote: We are on verge of rolling out RB 1.0.5 to 300+ developers. Some of our developers use IE and some of them use FireFox. Does RB 1.0.5 work with both browser seamless? During my testing I did not find the difference but I might have missed something. Pl. let me know if there is any preference of browser we should enforce to our developers. Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Binary Files handling in RB 1.0.5
Tom is right, they should be filtered so long as Perforce has them listed as binary files. How recent is your post-review? I'd recommend trying a nightly and seeing if the problem goes away. I seem to recall a corrupt patch issue that was fixed when using binary files, which may trigger this. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Dec 1, 2009 at 5:16 PM, Kunjal kunjal.par...@gmail.com wrote: The perforce has marked them as binary file. Why I get error message instead of some standard message saying this is binary file or similar? Do I need to install some patch ? On Dec 1, 5:04 pm, Tom Sakkos nasis...@gmail.com wrote: Assuming that the files are marked as Binary files in Perforce, Review-Board should ignore them and properly say something along the lines of Binary files differ. -Tom On Tue, Dec 1, 2009 at 6:51 PM, Kunjal kunjal.par...@gmail.com wrote: Hello, In our development environment, we have lot of reviews only with Binary files. For example, If I post the review with 4 binary files, what should happen when I click on View Diff? For now, I just try with one binary file, and I get below message when I click on View Diff. Is there any work-around for binary files? The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/ reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: Traceback (most recent call last): File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 153, in view_diff interdiffset, highlighting, True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB and Browser Compatibilty.
On Wednesday 02 December 2009 02:18:17 Kunjal wrote: We are on verge of rolling out RB 1.0.5 to 300+ developers. Some of our developers use IE and some of them use FireFox. Does RB 1.0.5 work with both browser seamless? During my testing I did not find the difference but I might have missed something. There is one noticeable difference: For IE, lines do not wrap for diffs wider than your screen. Firefox wraps those lines. At least that's my observation. I do, however, run a couple of extensions, which may have an influence on this behavior. I like the wrapped lines better, but that's just my personal preference. IE6 tends to freeze when executing RB's JavaScript from time to time. Pl. let me know if there is any preference of browser we should enforce to our developers. You might want to ask your developers what they prefer instead of enforcing something... Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB and Browser Compatibilty.
Yeah, that's an IE rendering issue. It should wrap so long as there isn't a single block of text in a line without spaces in it. If there's just one, it will cause an increase in the page width. IE6's JavaScript engine is just really slow, and there's not much we can do about that. We recognize that many companies absolutely need IE6 support, so we're not blocking IE6, but IE6 really is generations behind and we strongly encourage companies to upgrade to something newer. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Dec 1, 2009 at 11:01 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Wednesday 02 December 2009 02:18:17 Kunjal wrote: We are on verge of rolling out RB 1.0.5 to 300+ developers. Some of our developers use IE and some of them use FireFox. Does RB 1.0.5 work with both browser seamless? During my testing I did not find the difference but I might have missed something. There is one noticeable difference: For IE, lines do not wrap for diffs wider than your screen. Firefox wraps those lines. At least that's my observation. I do, however, run a couple of extensions, which may have an influence on this behavior. I like the wrapped lines better, but that's just my personal preference. IE6 tends to freeze when executing RB's JavaScript from time to time. Pl. let me know if there is any preference of browser we should enforce to our developers. You might want to ask your developers what they prefer instead of enforcing something... Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en