Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram


Thanks for the reply. I will check the same.

Regards,
Kalai


On Wednesday, July 23, 2014 1:21:05 AM UTC+5:30, Christian Hammond wrote:

 Your best bet is to look at the source code for RBSeverity and see how it 
 does it.


 https://github.com/reviewboard/rb-extension-pack/blob/master/rbseverity/rbseverity/static/js/severity.js

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On July 20, 2014 at 10:53:21 PM, Kalaiyarasi Singaram (
 kalaiyaras...@gmail.com javascript:) wrote:

  Hi,

  I want to add a button/field to CommentDialog using 
 CommentDialogHook.Can 
 u give me a sample?
  
  Regards,
  Kalai
  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Need help for adding drop down button in comment window ---- customization of rbsevrity 0.5.1 plugin

2014-07-24 Thread Christian Hammond
I wouldn't recommend modifying the file itself. If you want to have a
custom extension, it's best to write your own extension, copying what you
need from rbseverity.

Christian


On Wednesday, July 23, 2014, Rama krishna imr...@gmail.com wrote:

 ok after modifying severity.js file we need to re-install again?

 On Wednesday, July 23, 2014 2:23:36 PM UTC+5:30, Christian Hammond wrote:

 There’s nothing built-in to do this. You would have to write it yourself
 from scratch. You can refer to the source code for rbseverity to see how
 modifications are made, but other than that, it’s all up to you.

 Christian

 --
 Christian Hammond - chri...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On July 23, 2014 at 1:52:09 AM, Rama krishna (imr...@gmail.com) wrote:

  Hi All,
 I have successfully installed rbsevrity 0.5.1 plugin. I am able to see
 Major, Minor and Info button on comment window, Could you please me how to
 add drop down button on comment window.
  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com
 javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com');
 .
 For more options, visit https://groups.google.com/d/optout.



-- 
-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Search doesn't seem to work, when I try to index it says Indexing 0 review requests

2014-07-24 Thread Ian
Hmm.  My instance doesn't need multiple levels of security, is there a way 
other than using review groups?  If we could somehow limit overall 
authentication to a particular LDAP group then we could make all our 
repositories public.

Ian

On Tuesday, July 22, 2014 1:04:26 PM UTC-7, Christian Hammond wrote:

 Right now, no. I spent some time with this and the search backend we’re 
 using makes it hard in ways. Right now, search has to be limited to 
 publicly visible review requests.

 I’m happy to take a patch if someone can get this working cleanly, though. 
 The trick is going to be doing the right thing despite the fact that a 
 user’s access to a private group/repository may change over time.

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On July 18, 2014 at 3:42:53 PM, Ian (iand...@mac.com javascript:) wrote:

 It's not really practical for our organization to basically make our 
 reviews public, is there anything else we can do? 

 Ian

 On Monday, July 14, 2014 9:47:41 PM UTC-7, Christian Wuerdig wrote: 


 I had similar troubles with the search. After making the repository public 
 it worked fine. It would be good to add a note to the documentation that 
 the search indexing (currently) doesn't work on private repositories. Or 
 alternatively add some documentation on how to make it work (if it's 
 possible at all).

 Cheers
 Christian

 On Wednesday, 2 July 2014 14:07:02 UTC+12, Christian Hammond wrote: 

  What are the review requests like on your server? Are they all against a 
 private repository or invite-only group?
  
  Christian
  
   -- 
  Christian Hammond - chri...@beanbaginc.com
  Review Board - http://www.reviewboard.org 
 Beanbag, Inc. - http://www.beanbaginc.com
  
 On July 1, 2014 at 7:05:49 PM, Ian (iand...@mac.com) wrote:

  Ah, OK that looks like this. 

  $ sudo rb-site manage /Library/Server/Web/Data/WebApps/ReviewBoard shell
 Password:
 Python 2.7.5 (default, Mar  9 2014, 22:15:05) 
 [GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] on darwin
 Type help, copyright, credits or license for more information.
 (InteractiveConsole)
  from reviewboard.reviews.models import ReviewRequest
  from django.db.models import Q
  qs = ReviewRequest.objects.public(status=None, 
 extra_query=Q(status='P') | Q(status='S'))
  qs = qs.select_related('submitter', 'diffset_history')
  qs = qs.prefetch_related('diffset_history__diffsets__files')
  print qs.count()
 0

 On Tuesday, July 1, 2014 4:39:20 PM UTC-7, Christian Hammond wrote: 

  Oops, my fault. That should be extra_query.
  
  Christian
  
   -- 
  Christian Hammond - chri...@beanbaginc.com
  Review Board - http://www.reviewboard.org 
 Beanbag, Inc. - http://www.beanbaginc.com
  
 On July 1, 2014 at 2:15:19 PM, Ian (iand...@mac.com) wrote:

  I'm getting an error making qs.  Did I type it wrong? 

  $ sudo rb-site manage /Library/Server/Web/Data/WebApps/ReviewBoard shell
 Python 2.7.5 (default, Mar  9 2014, 22:15:05) 
 [GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] on darwin
 Type help, copyright, credits or license for more information.
 (InteractiveConsole)
  from reviewboard.reviews.models import ReviewRequest
  from django.db.models import Q
  qs = ReviewRequest.objects.public(status=None, 
 extra_status=Q(status='P') | Q(status='S'))
 Traceback (most recent call last):
   File console, line 1, in module
   File 
 /Library/Python/2.7/site-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/reviews/managers.py,
  
 line 247, in public
 return self._query(filter_private=filter_private, *args, **kwargs)
 TypeError: _query() got an unexpected keyword argument 'extra_status'

 On Tuesday, July 1, 2014 11:30:55 AM UTC-7, Christian Hammond wrote: 

  Can you see what happens when you run this:
  
  $ rb-site manage /path/to/site shell
   from reviewboard.reviews.models import ReviewRequest
   from django.db.models import Q
   qs = ReviewRequest.objects.public(status=None, 
 extra_status=Q(status=‘P’) | Q(status=’S’))
   qs = qs.select_related(‘submitter’, ‘diffset_history’)
   qs = qs.prefetch_related(‘diffset_history__diffsets__files’)
   print qs.count()
  
  This is what it’s running when it’s trying to index the review requests, 
 but it’s claiming it’s finding 0 results. I want to sanity-check this.
  
  Christian
  
   -- 
  Christian Hammond - chri...@beanbaginc.com
  Review Board - http://www.reviewboard.org 
 Beanbag, Inc. - http://www.beanbaginc.com
  
 On July 1, 2014 at 11:25:02 AM, Ian (iand...@mac.com) wrote:

  Anyone have any ideas?  =\

 On Thursday, June 26, 2014 4:25:29 PM UTC-7, Ian wrote: 

  $ sudo -u _www rb-site manage 
 /Library/Server/Web/Data/WebApps/ReviewBoard rebuild_index -- -v 3
 WARNING: This will irreparably remove EVERYTHING from your search index in 
 connection 'default'.
 Your choices after this are to restore from backups or rebuild via the 
 

Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram
Hi,



On Monday, July 21, 2014 11:04:26 AM UTC+5:30, Kalaiyarasi Singaram wrote:

 Hi,

  I want to add a button/field to CommentDialog using 
 CommentDialogHook.Can 
 u give me a sample?

 Regards,
 Kalai


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram
Hi,

   I checked the java script.RbSeverity is working fine.But if change 
the button name from minor to medium it is not reflecting.Steps i followed 
are,

1) Disabled extension in reviewboard.
2) Modified severity.js lines as following (in Red color minor to medium),


   buttonsTemplate: _.template([
'span class=severity-actions',
'  input type=button class=save-major value=Major ',
' disabled=true /',
'  input type=button class=save-minor value=Medium ',
' disabled=true /',
'  input type=button class=save-info value=Info ',
' disabled=true /',
'/span'
].join('')),   


3) Installed plugin using easy_install rbseverity-0.5.1-py2.7.egg
4) Enabled extension.

Regards,
Kalai


On Thursday, July 24, 2014 11:31:03 AM UTC+5:30, Kalaiyarasi Singaram wrote:



 Thanks for the reply. I will check the same.

 Regards,
 Kalai


 On Wednesday, July 23, 2014 1:21:05 AM UTC+5:30, Christian Hammond wrote:

 Your best bet is to look at the source code for RBSeverity and see how it 
 does it.


 https://github.com/reviewboard/rb-extension-pack/blob/master/rbseverity/rbseverity/static/js/severity.js

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On July 20, 2014 at 10:53:21 PM, Kalaiyarasi Singaram (
 kalaiyaras...@gmail.com) wrote:

  Hi,

  I want to add a button/field to CommentDialog using 
 CommentDialogHook.Can 
 u give me a sample?
  
  Regards,
  Kalai
  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram
Hi,

   It is reflecting now. Instead of using EGG, i installed the package 
from scratch using python setup.py install.Now it is working fine.

Thanks  Regards,
Kalai



On Thursday, July 24, 2014 3:03:06 PM UTC+5:30, Kalaiyarasi Singaram wrote:

 Hi,

I checked the java script.RbSeverity is working fine.But if change 
 the button name from minor to medium it is not reflecting.Steps i followed 
 are,

 1) Disabled extension in reviewboard.
 2) Modified severity.js lines as following (in Red color minor to medium),
 

buttonsTemplate: _.template([
 'span class=severity-actions',
 '  input type=button class=save-major value=Major ',
 ' disabled=true /',
 '  input type=button class=save-minor value=Medium ',
 ' disabled=true /',
 '  input type=button class=save-info value=Info ',
 ' disabled=true /',
 '/span'
 ].join('')),   


 3) Installed plugin using easy_install rbseverity-0.5.1-py2.7.egg
 4) Enabled extension.

 Regards,
 Kalai


 On Thursday, July 24, 2014 11:31:03 AM UTC+5:30, Kalaiyarasi Singaram 
 wrote:



 Thanks for the reply. I will check the same.

 Regards,
 Kalai


 On Wednesday, July 23, 2014 1:21:05 AM UTC+5:30, Christian Hammond wrote:

 Your best bet is to look at the source code for RBSeverity and see how 
 it does it.


 https://github.com/reviewboard/rb-extension-pack/blob/master/rbseverity/rbseverity/static/js/severity.js

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On July 20, 2014 at 10:53:21 PM, Kalaiyarasi Singaram (
 kalaiyaras...@gmail.com) wrote:

  Hi,

  I want to add a button/field to CommentDialog using 
 CommentDialogHook.Can 
 u give me a sample?
  
  Regards,
  Kalai
  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


RBTools 0.6.2 revision range and file path

2014-07-24 Thread Yu-Kai Tseng
Hi Developers,

I updated my rbtools to 0.6.2 and encountered the following problem. (my 
repo is SVN)

When I use rbtools 0.5.x, I can use commands such as
rbt post --revision-range=: /path/to/file1 path/to/file2
to indicate that I want to upload diffs of version  and version  of 
file1 and file2 .

However, after I updated to 0.6.2, commands such as

rbt post : /path/to/file1 path/to/file2 failed to upload diffs and 
shows the following error msg

E:\MXviewrbt post src 29486:29527
CRITICAL: Could not parse specified revisions: ['src', '29486:29527']

I tried to substitute parameter orders but still not worked.

Do I miss something? I can't find an example in rbtools document. Please 
help.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Migrating Reviewboard from 1.5 to 2.0.4

2014-07-24 Thread Bogdan Berezovyi

Hi,

I'm having trouble upgrading existing reviewboard 1.5.3 to the new release 
2.0.4. 
After importing mysql dump and running rb-site upgrade I get the following 
error:

CommandError: Error applying evolution: (1061, Duplicate key name 
'scmtools_repository_97c59b73')

I tried removing index as per one of earlier thread with similar error by 
running 

drop index scmtools_repository_97c59b73 on scmtools_repository;

But this didn't help.
If I rerun upgrade it crashes with traceback. 

Any help would be much appreciated.

Bogdan

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Migrating Reviewboard from 1.5 to 2.0.4

2014-07-24 Thread Christian Hammond
Hi,

Do you have a backup of your 1.5.3 database? You’ll need one at this point, 
since the new database is in an inconsistent state.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On July 24, 2014 at 11:48:49 AM, Bogdan Berezovyi (bod...@gmail.com) wrote:


Hi,

I'm having trouble upgrading existing reviewboard 1.5.3 to the new release 
2.0.4.
After importing mysql dump and running rb-site upgrade I get the following 
error:

CommandError: Error applying evolution: (1061, Duplicate key name 
'scmtools_repository_97c59b73')

I tried removing index as per one of earlier thread with similar error by 
running

drop index scmtools_repository_97c59b73 on scmtools_repository;

But this didn't help.
If I rerun upgrade it crashes with traceback.

Any help would be much appreciated.

Bogdan
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools 0.6.2 revision range and file path

2014-07-24 Thread David Trowbridge
Under the new command-line syntax, each file path that you want to include
should be prefixed with -I. So your command would be:

rbt post -I src 29486:29527

or

rbt post -I /path/to/file1 -I /path/to/file2 :

-David


On Thu, Jul 24, 2014 at 4:03 AM, Yu-Kai Tseng tanists...@gmail.com wrote:

 Hi Developers,

 I updated my rbtools to 0.6.2 and encountered the following problem. (my
 repo is SVN)

 When I use rbtools 0.5.x, I can use commands such as
 rbt post --revision-range=: /path/to/file1 path/to/file2
 to indicate that I want to upload diffs of version  and version 
 of file1 and file2 .

 However, after I updated to 0.6.2, commands such as

 rbt post : /path/to/file1 path/to/file2 failed to upload diffs and
 shows the following error msg

 E:\MXviewrbt post src 29486:29527
 CRITICAL: Could not parse specified revisions: ['src', '29486:29527']

 I tried to substitute parameter orders but still not worked.

 Do I miss something? I can't find an example in rbtools document. Please
 help.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


how to reopen a discarded review?

2014-07-24 Thread Ngsquare
Hi Guys,

I have a discarded review that i want it to be reopened.  Is there a way to 
do that?  

I have login as admin but still i couldn't do it

please advise

thnx

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: how to reopen a discarded review?

2014-07-24 Thread Christian Hammond
Hi,

All you need to do is click Reopen on the review request page. So long as you 
own it or have sufficient permissions, it will work.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On July 24, 2014 at 2:29:35 PM, Ngsquare (warren.man...@gmail.com) wrote:

Hi Guys,

I have a discarded review that i want it to be reopened.  Is there a way to do 
that? 

I have login as admin but still i couldn't do it

please advise

thnx

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: how to reopen a discarded review?

2014-07-24 Thread Ngsquare
that's what i thought, but i don't see the reopen button as i was also 
expecting.

I am login as admin with superuser status checked   

what else i need

On Thursday, July 24, 2014 2:32:10 PM UTC-7, Christian Hammond wrote:

 Hi,

 All you need to do is click Reopen on the review request page. So long as 
 you own it or have sufficient permissions, it will work.

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On July 24, 2014 at 2:29:35 PM, Ngsquare (warren...@gmail.com 
 javascript:) wrote:

 Hi Guys,

 I have a discarded review that i want it to be reopened.  Is there a way 
 to do that? 

 I have login as admin but still i couldn't do it

 please advise

 thnx

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: how to reopen a discarded review?

2014-07-24 Thread Christian Hammond
What version of Review Board are you using?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On July 24, 2014 at 2:35:22 PM, Ngsquare (warren.man...@gmail.com) wrote:

that's what i thought, but i don't see the reopen button as i was also 
expecting.

I am login as admin with superuser status checked  

what else i need

On Thursday, July 24, 2014 2:32:10 PM UTC-7, Christian Hammond wrote:
Hi,

All you need to do is click Reopen on the review request page. So long as you 
own it or have sufficient permissions, it will work.

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On July 24, 2014 at 2:29:35 PM, Ngsquare (warren...@gmail.com) wrote:

Hi Guys,

I have a discarded review that i want it to be reopened.  Is there a way to do 
that? 

I have login as admin but still i couldn't do it

please advise

thnx

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: how to reopen a discarded review?

2014-07-24 Thread Ngsquare
1.7.26

On Thursday, July 24, 2014 2:35:49 PM UTC-7, Christian Hammond wrote:

 What version of Review Board are you using?

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On July 24, 2014 at 2:35:22 PM, Ngsquare (warren...@gmail.com 
 javascript:) wrote:

 that's what i thought, but i don't see the reopen button as i was also 
 expecting.

 I am login as admin with superuser status checked  

 what else i need

 On Thursday, July 24, 2014 2:32:10 PM UTC-7, Christian Hammond wrote: 

  Hi,
  
  All you need to do is click Reopen on the review request page. So long 
 as you own it or have sufficient permissions, it will work.
  
  Christian
  
   -- 
  Christian Hammond - chri...@beanbaginc.com
  Review Board - http://www.reviewboard.org 
 Beanbag, Inc. - http://www.beanbaginc.com
  
 On July 24, 2014 at 2:29:35 PM, Ngsquare (warren...@gmail.com) wrote:

  Hi Guys,

 I have a discarded review that i want it to be reopened.  Is there a way 
 to do that? 

 I have login as admin but still i couldn't do it

 please advise

 thnx

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.
  
   --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Issue 3497 in reviewboard: rbt tools not posting deleted files for perforce

2014-07-24 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3497 by jco...@gmail.com: rbt tools not posting deleted files for  
perforce

http://code.google.com/p/reviewboard/issues/detail?id=3497

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

1.7.22

What's the URL of the page containing the problem?

Private system.


What steps will reproduce the problem?
1. Submit a perforce change containing one or more deleted files
2. Run rbt post change list no (where the change list no is the one  
submitted in step 1)
3. On the generate review you will see that the deleted files are NOT  
present.


What is the expected output? What do you see instead?

The deleted files should be present in the diff report.

What operating system are you using? What browser?

Linux on the server, Windows 7 on the client with Firefox

Please provide any additional information below.

I think the issue is this:-

The most recent version of the file in the submitted change list output  
from perforce is the delete.


I think the issue begins in _compute_range_changes in perforce.py

What I believe happens is the code in perforce.py runs p4  
filelog //...@changeno,changeno to get the list of changes from the  
change list I supplied.


It iterates through the list of changes, parsing out the depot files,  
action and locations.


_accumulate_range_change is called for each file. If old_action is edit,  
then it decrements initialRev. This is therefore not done for a delete, so  
the value of initialRev remains as the last (deleted) version of the file:-


def _accumulate_range_change(self, file_entry, change):
Compute the effects of a given change on a given file
old_action = file_entry['action']
current_action = change['action']

if old_action == 'none':
# This is the first entry for this file.
new_action = current_action
file_entry['depotFile'] = file_entry['initialDepotFile']

# If the first action was an edit, then the initial revision
# (that we'll use to generate the diff) is n-1
if current_action == 'edit':
file_entry['initialRev'] -= 1

It then iterates through the built list of files and if action is delete,  
does this:-


elif action == 'delete':
try:
old_file, new_file = self._extract_delete_files(
initial_depot_file, initial_rev)
except ValueError:
logging.warning('Skipping file %s: %s', depot_file, e)
continue

diff_lines += self._do_diff(
old_file, new_file, initial_depot_file, initial_rev,
depot_file, 'D', ignore_unmodified=True)

In this case the value passed to extract_delete_files is the deleted  
revision of the file (I.E. the version output from p4 filelog).


def _extract_delete_files(self, depot_file, revision):
Extract the 'old' and 'new' files for a delete operation.

Returns a tuple of (old filename, new filename). This can raise a
ValueError if extraction fails.

# Get the old version out of perforce
old_filename = make_tempfile()
self._write_file('%s#%s' % (depot_file, revision), old_filename)

# Make an empty tempfile for the new file
new_filename = make_tempfile()

return old_filename, new_filename

The _write_file method then causes it to execute this command:-

p4 print -o /tmp/tmp-9Bncr -q  //depot//DeletedFile#2 (where #2 is the  
deleted revision of the file)


In this case if the temp file did not already exist, perforce does not  
create it. But it was already created by make_tempfile (and was empty). So  
the result is we still have an empty file. The new file is also created  
with make_tempfile and hence is empty.


This means that when the diff is run, it ends up comparing two empty files.  
It then of course says there is no change and so the file that is deleted  
ends up NOT getting included in the diff that rbt uploads. I think this is  
an error and in the old_filename code above the depot revision needs to be  
decreased by 1. This will cause p4 print to output the old version of the  
file (prior to the delete). Then when the diff runs, it compares the old  
(pre 

Issue 3498 in reviewboard: Command line configuration dump/restore

2014-07-24 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3498 by blueazsk...@gmail.com: Command line configuration  
dump/restore

http://code.google.com/p/reviewboard/issues/detail?id=3498

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this enhancement request!


What version are you running? 1.7.24


What's the URL of the page this enhancement relates to, if any? N/A


Describe the enhancement and the motivation for it.  It would be nice to  
enable Active Directory from a chef install script rather than a gui page.   
That leads to dumping/restoring the configuration from the command line.



What operating system are you using? What browser? Linux Ubuntu 12.04,  
Firefox



Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3498 in reviewboard: Command line configuration dump/restore

2014-07-24 Thread reviewboard


Comment #1 on issue 3498 by trowb...@gmail.com: Command line configuration  
dump/restore

http://code.google.com/p/reviewboard/issues/detail?id=3498

While there's no explicit dump/restore, you can use the list-siteconfig,  
get-siteconfig and set-siteconfig management commands to do this from your  
chef configuration.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3498 in reviewboard: Command line configuration dump/restore

2014-07-24 Thread reviewboard


Comment #2 on issue 3498 by andrewm@gmail.com: Command line  
configuration dump/restore

http://code.google.com/p/reviewboard/issues/detail?id=3498

I'm not 100% sure, but this might be related:  
https://groups.google.com/forum/#!topic/reviewboard-dev/ZWJsfyJz_nw


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3402 in reviewboard: Include revision of the commits shown in the repository listing of a branch

2014-07-24 Thread reviewboard

Updates:
Status: PendingReview
Owner: trowb...@gmail.com

Comment #2 on issue 3402 by trowb...@gmail.com: Include revision of the  
commits shown in the repository listing of a branch

http://code.google.com/p/reviewboard/issues/detail?id=3402

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3383 in reviewboard: Upload file form doesn't detect errors

2014-07-24 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3383 by trowb...@gmail.com: Upload file form doesn't  
detect errors

http://code.google.com/p/reviewboard/issues/detail?id=3383

Fixed in release-2.0.x (76caaa7).

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories

2014-07-24 Thread reviewboard

Updates:
Status: ThirdParty

Comment #28 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when  
using with RhodeCode for mercurial repositories

http://code.google.com/p/reviewboard/issues/detail?id=2445

Until RhodeCode supports the necessary APIs, there's nothing we can do here.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3311 in reviewboard: Not able to integrate LDAP with Review Board

2014-07-24 Thread reviewboard

Updates:
Status: SetupIssue

Comment #1 on issue 3311 by trowb...@gmail.com: Not able to integrate LDAP  
with Review Board

http://code.google.com/p/reviewboard/issues/detail?id=3311

I believe that this is just a misconfiguration. The LDAP config UI in 2.0.x  
is much less confusing.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3436 in reviewboard: Clicking and dragging on linenumbers in diffviewer doesn't allow user to comment

2014-07-24 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3436 by trowb...@gmail.com: Clicking and dragging on  
linenumbers in diffviewer doesn't allow user to comment

http://code.google.com/p/reviewboard/issues/detail?id=3436

Backed out change in 8bfbcf0.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3470 in reviewboard: Unable to set groups/people on a review request

2014-07-24 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 3470 by trowb...@gmail.com: Unable to set groups/people  
on a review request

http://code.google.com/p/reviewboard/issues/detail?id=3470

This is fixed in djblets (85eb686), which you should get if you upgrade to  
the latest Review Board 2.0.x


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 1556 in reviewboard: Add the ability to pass SVN username and password on post-review command line

2014-07-24 Thread reviewboard

Updates:
Labels: EasyFix

Comment #6 on issue 1556 by trowb...@gmail.com: Add the ability to pass SVN  
username and password on post-review command line

http://code.google.com/p/reviewboard/issues/detail?id=1556

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 2733 in reviewboard: Avoid review creation if diff upload fails

2014-07-24 Thread reviewboard


Comment #3 on issue 2733 by trowb...@gmail.com: Avoid review creation if  
diff upload fails

http://code.google.com/p/reviewboard/issues/detail?id=2733

This is quite doable now that we have the diff validation resource.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 46 in reviewboard: 80-column indicator in diff view

2014-07-24 Thread reviewboard


Comment #19 on issue 46 by trowb...@gmail.com: 80-column indicator in diff  
view

http://code.google.com/p/reviewboard/issues/detail?id=46

Mike has some CSS that works for this:

table.sidebyside tr[line]  td:before {
  content: '';
  position: absolute;
  transform: translateX(80ch);
  border-left: 1px solid red;
  height: 18px;
}

We'll have to figure out the best way to expose this.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 46 in reviewboard: 80-column indicator in diff view

2014-07-24 Thread reviewboard


Comment #20 on issue 46 by chip...@gmail.com: 80-column indicator in diff  
view

http://code.google.com/p/reviewboard/issues/detail?id=46

A few notes on the CSS, after playing with it, that we'll need to address:

1. The red lines end up overflowing from the left-hand side to the  
right-hand side. This can be sort of prevented by adding 'position:  
relative; overflow: hidden;' to the parent td, but I'm not sure that fully  
worked.


2. If your window width isn't wide enough to show two columns of 80  
characters, you'll never see red lines and never have any indication where  
the wrap point is.


3. Similarly, if text wraps due to being too long to show the full block of  
text (such as a long variable name) on the first line, and that text hits  
the 80 column boundary, then it'll wrap and you won't see where the red  
line was supposed to be within that text.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3462 in reviewboard: Ability to take back a ship-it.

2014-07-24 Thread reviewboard


Comment #2 on issue 3462 by trowb...@gmail.com: Ability to take back a  
ship-it.

http://code.google.com/p/reviewboard/issues/detail?id=3462

I'm curious if this is fixed by the new ship-it column in 2.0.x. If you add  
a new review that has issues, the ship-it won't be shown, and instead the  
issue count will be.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3318 in reviewboard: Allow rbt to post from previously submitted changes without a perforce client

2014-07-24 Thread reviewboard

Updates:
	Summary: Allow rbt to post from previously submitted changes without a  
perforce client

Labels: Project-RBTools Component-RBTools

Comment #1 on issue 3318 by trowb...@gmail.com: Allow rbt to post from  
previously submitted changes without a perforce client

http://code.google.com/p/reviewboard/issues/detail?id=3318

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 1570 in reviewboard: Diff-Upload UI: Usability Enhancement

2014-07-24 Thread reviewboard


Comment #4 on issue 1570 by fbeach...@gmail.com: Diff-Upload UI:  Usability  
Enhancement

http://code.google.com/p/reviewboard/issues/detail?id=1570

Thanks to the RB team for thorough and patient attention to this report.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3462 in reviewboard: Ability to take back a ship-it.

2014-07-24 Thread reviewboard


Comment #3 on issue 3462 by vlov...@gmail.com: Ability to take back a  
ship-it.

http://code.google.com/p/reviewboard/issues/detail?id=3462

Not really.  A review may have larger issues (e.g. architectural) that are  
not issues related to any specific line.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3462 in reviewboard: Ability to take back a ship-it.

2014-07-24 Thread reviewboard


Comment #4 on issue 3462 by vlov...@gmail.com: Ability to take back a  
ship-it.

http://code.google.com/p/reviewboard/issues/detail?id=3462

Also, someone may mark all the single line issues as fixed/dropped without  
addressing larger issues that may be raised that invalidate the ship-it.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3499 in reviewboard: on submitting the RB request, i am seeing internal server error 500 (my username sushilk)

2014-07-24 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3499 by sushilku...@gmail.com: on submitting the RB request, i am  
seeing internal server error 500 (my username sushilk)

http://code.google.com/p/reviewboard/issues/detail?id=3499

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.