Issue 3866 in reviewboard: mxml source file patches fail to get applied
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? 1.6.6 What's the URL of the page containing the problem? 'View diff' for an mxml source file What steps will reproduce the problem? 1. Make changes to an mxml source file (Flex Application) 2. Post the changes for review to reviewboard 3. The following error trace is observed: Diff currently unavailable. Error: The patch to '//projects/flash-client-dev/hdcore/v3.8/support-players/ZoroDebugPlayer/src/ZoroDebugPlayer.mxml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Mwxe1l' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.Mwxe1l/tmpKE4shz patch: malformed patch at line 5: s:Application xmlns:fx=http://ns.adobe.com/mxml/2009; Details Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/views.py, line 217, in view_diff_fragment file = get_requested_diff_file() File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/views.py, line 193, in get_requested_diff_file get_chunks) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 1072, in get_diff_files large_data=True) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.16-py2.6.egg/djblets/util/misc.py, line 157, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 1071, in lambda enable_syntax_highlighting)), File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 553, in get_chunks new = get_patched_file(old, filediff) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 375, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 243, in patch (filename, tempdir, patch_output)) Exception: The patch to '//projects/flash-client-dev/hdcore/v3.8/support-players/ZoroDebugPlayer/src/ZoroDebugPlayer.mxml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Mwxe1l' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.Mwxe1l/tmpKE4shz patch: malformed patch at line 5: s:Application xmlns:fx=http://ns.adobe.com/mxml/2009; What is the expected output? What do you see instead? I should see the diff of the new commit vs. the previous commit What operating system are you using? What browser? Mac OS X 10.10.3 on Chrome 42. Also Safari 8.0.5. Please provide any additional information below. Here is the opening line causing the problem: s:Application xmlns:fx=http://ns.adobe.com/mxml/2009; xmlns:s=library://ns.adobe.com/flex/spark xmlns:mx=library://ns.adobe.com/flex/mx xmlns:metadata=org.osmf.metadata.* xmlns:local=* width=100% height=100% applicationComplete=init() backgroundAlpha=0 backgroundColor=#444242 currentState=videotracestats preloaderChromeColor=#BB stateChangeComplete=startDelayedResize() -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Integration of gitlab and reviewboard error
Hi Sri, When authenticating a repository, we do so through the GitLab API, and not SSH. This error means exactly what it means: Your username or password you provided doesn't match what's configured in GitLab. I'd make sure you're using the exact same credentials to log into GitLab, and that you're using your username, not e-mail address, to do so. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Sri Ram Kannan sriram.ss...@gmail.com Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com Date: May 7, 2015 at 12:19:35 PM To: reviewboard@googlegroups.com reviewboard@googlegroups.com Subject: Integration of gitlab and reviewboard error Hi, I'm trying to connect the gitlab and reviewboard together by addina a gitlab repository into the reviewboard. Initially, I faced error : Unable to link Unable to link the account: The username or password is incorrect. After reading one the topic in this group, I added the ssh key from reviewboard (removing the line breaks, new lines) and pasted it in the gitlab successfully. And I also created a symbolic link of rbssh from /usr/local/bin to /usr/bin/ Still I face the same error as Unable to link the account: The username or password is incorrect. I don't know where the logs are generated to check. I request someone to help me on this. Note: I usually log-in to gitlab using LDAP . Regards, sri. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Integration of gitlab and reviewboard error
Hi, I'm trying to connect the gitlab and reviewboard together by addina a gitlab repository into the reviewboard. Initially, I faced error : Unable to link Unable to link the account: The username or password is incorrect. After reading one the topic in this group, I added the ssh key from reviewboard (removing the line breaks, new lines) and pasted it in the gitlab successfully. And I also created a symbolic link of rbssh from /usr/local/bin to /usr/bin/ Still I face the same error as Unable to link the account: The username or password is incorrect. I don't know where the logs are generated to check. I request someone to help me on this. Note: I usually log-in to gitlab using LDAP . Regards, sri. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #8 on issue 3866 by chip...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 It's a bit more complex than that. We don't just shell out to diff. Rather, we use that as a base, and generate a more thorough diff that Review Board can read. This is custom to us, and requires RBTools. post-review is old, and hasn't been part of RBTools for a couple years now, so it's not a safe bet for future use. If you're still hitting trouble with using RBTools to post the change, run it with --debug and show us the output. We'll see what may be going wrong. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Integration of gitlab and reviewboard error
Hi Chris, Thanks for your reply. I tried numerous time to login with the same credentials that I use it for gitlab. Still it fails. Wondering what I'm missing here ! Is there any way to check the error logs anywhere ? Regards, Sri. On Thursday, May 7, 2015 at 3:21:32 PM UTC-4, Christian Hammond wrote: Hi Sri, When authenticating a repository, we do so through the GitLab API, and not SSH. This error means exactly what it means: Your username or password you provided doesn't match what's configured in GitLab. I'd make sure you're using the exact same credentials to log into GitLab, and that you're using your username, not e-mail address, to do so. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Sri Ram Kannan sriram...@gmail.com javascript: Reply: revie...@googlegroups.com javascript: revie...@googlegroups.com javascript: Date: May 7, 2015 at 12:19:35 PM To: revie...@googlegroups.com javascript: revie...@googlegroups.com javascript: Subject: Integration of gitlab and reviewboard error Hi, I'm trying to connect the gitlab and reviewboard together by addina a gitlab repository into the reviewboard. Initially, I faced error : Unable to link Unable to link the account: The username or password is incorrect. After reading one the topic in this group, I added the ssh key from reviewboard (removing the line breaks, new lines) and pasted it in the gitlab successfully. And I also created a symbolic link of rbssh from /usr/local/bin to /usr/bin/ Still I face the same error as Unable to link the account: The username or password is incorrect. I don't know where the logs are generated to check. I request someone to help me on this. Note: I usually log-in to gitlab using LDAP . Regards, sri. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Integration of gitlab and reviewboard error
Hi chris, Thanks a lot. It works .. I apologize for creating a topic for such trivial issue. Regards, Sri. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
RE: can't pip install RBTools - no packages on pypi?
If the Pillow wheels contain support for all the image formats, and those get pulled in automatically through pip, then yes. Otherwise, the situation would be the same as it is today. We don't have really any control of how that's built, which is difficult. Unfortunately, none of the packaging stuff we're doing will affect the image libraries. Basically, if 'easy_install Pillow' doesn't do the right thing, but 'pip install Pillow' does, then it should work. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Dunnigan, Terrence J terrence.j.dunni...@boeing.com Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com Date: May 7, 2015 at 2:15:26 PM To: reviewboard@googlegroups.com reviewboard@googlegroups.com, kswee...@twitter.com kswee...@twitter.com Subject: RE: can't pip install RBTools - no packages on pypi? Great news! What about Review Board Power Pack? Will this resolve the issue (for some of us) of obtaining the correct imaging libraries? Terry -Original Message- From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Thursday, May 07, 2015 4:06 PM To: reviewboard@googlegroups.com; kswee...@twitter.com Subject: Re: can't pip install RBTools - no packages on pypi? Hi Kevin, The next releases of RBTools and Review Board will ship Wheels, which are pip-compatible. We have everything in place for this already. We've also moved to a better scheme for verified URLs, meaning that pip won't need the `--allow-unverified` stuff anymore. Every single download URL and file checksum is now registered with PyPI, so that clients can download the package and be absolutely sure the contents are what they should be. What we're still missing is the support for registered external indexes, which pip and PyPI don't yet have. So, it'll still be necessary to do `--allow-all-external`. As soon as they introduce compatibility for PEP 470, we'll be able to implement that last bit, finally giving everyone the ability to do a simple 'pip install RBTools'. We don't have any issue in our tracker for this, but we're waiting for this particular issue: https://github.com/pypa/warehouse/issues/431 Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: kswee...@twitter.com Reply: kswee...@twitter.com Date: May 7, 2015 at 1:54:11 PM To: reviewboard@googlegroups.com Cc: chip...@chipx86.com Subject: Re: can't pip install RBTools - no packages on pypi? Hi Christian, Has there been any progress on these plans? Is there an issue I can watch? Thanks, Kevin On Wednesday, October 22, 2014 at 6:02:03 PM UTC-7, Christian Hammond wrote: Hi Kevin, There's been some ongoing discussions about changes to pip and the strategy for verification/external packages. We're waiting to see how those impact us. In the meantime, we've made some of the changes needed to get us closer to not needing allow-unverified, but we're not fully there yet. There's no plan to move everything onto PyPI's hosting. It shouldn't matter down the road, from my understanding, but it does depend on the future plans for pip/PyPI. Christian On Wednesday, October 22, 2014, wrote: Apologies if this is already answered somewhere in history, but are there any plans to revisit this change? We (Apache Aurora) use rbt in our development workflow via pip to no apparent ill effect. We'd like to avoid the use of --allow-unverified RBTools The currently-published version is only available via HTTP on a server external to PyPI. That means it's vulnerable to MITMs and it doesn't benefit from PyPI's caching infrastructure. Thanks, Kevin On Thursday, August 14, 2014 6:55:47 PM UTC-7, Buck Evan wrote: For the record, the below command does result in a correctly-working rbt command. rbtools really should become compatible with the pip default options. On Wednesday, August 6, 2014 2:17:37 PM UTC-7, David Trowbridge wrote: That will install the package, but I believe pip still doesn't properly register python entry points, which means that rbt won't work right. -David On Aug 6, 2014, at 2:04 PM, Edward Delaporte wrote: For what it's worth, there seems to be a combination of command line flags that works as a workaround: pip install rbtools --allow-external rbtools --allow-unverified rbtools On Wednesday, May 7, 2014 8:03:11 AM UTC-5, Jason Antman wrote: I'm aware that pip is not a supported installation method for ReviewBoard itself. However, I have
Re: can't pip install RBTools - no packages on pypi?
Hi Kevin, The next releases of RBTools and Review Board will ship Wheels, which are pip-compatible. We have everything in place for this already. We've also moved to a better scheme for verified URLs, meaning that pip won't need the `--allow-unverified` stuff anymore. Every single download URL and file checksum is now registered with PyPI, so that clients can download the package and be absolutely sure the contents are what they should be. What we're still missing is the support for registered external indexes, which pip and PyPI don't yet have. So, it'll still be necessary to do `--allow-all-external`. As soon as they introduce compatibility for PEP 470, we'll be able to implement that last bit, finally giving everyone the ability to do a simple 'pip install RBTools'. We don't have any issue in our tracker for this, but we're waiting for this particular issue: https://github.com/pypa/warehouse/issues/431 Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: kswee...@twitter.com kswee...@twitter.com Reply: kswee...@twitter.com kswee...@twitter.com Date: May 7, 2015 at 1:54:11 PM To: reviewboard@googlegroups.com reviewboard@googlegroups.com Cc: chip...@chipx86.com chip...@chipx86.com Subject: Re: can't pip install RBTools - no packages on pypi? Hi Christian, Has there been any progress on these plans? Is there an issue I can watch? Thanks, Kevin On Wednesday, October 22, 2014 at 6:02:03 PM UTC-7, Christian Hammond wrote: Hi Kevin, There's been some ongoing discussions about changes to pip and the strategy for verification/external packages. We're waiting to see how those impact us. In the meantime, we've made some of the changes needed to get us closer to not needing allow-unverified, but we're not fully there yet. There's no plan to move everything onto PyPI's hosting. It shouldn't matter down the road, from my understanding, but it does depend on the future plans for pip/PyPI. Christian On Wednesday, October 22, 2014, wrote: Apologies if this is already answered somewhere in history, but are there any plans to revisit this change? We (Apache Aurora) use rbt in our development workflow via pip to no apparent ill effect. We'd like to avoid the use of --allow-unverified RBTools The currently-published version is only available via HTTP on a server external to PyPI. That means it's vulnerable to MITMs and it doesn't benefit from PyPI's caching infrastructure. Thanks, Kevin On Thursday, August 14, 2014 6:55:47 PM UTC-7, Buck Evan wrote: For the record, the below command does result in a correctly-working rbt command. rbtools really should become compatible with the pip default options. On Wednesday, August 6, 2014 2:17:37 PM UTC-7, David Trowbridge wrote: That will install the package, but I believe pip still doesn't properly register python entry points, which means that rbt won't work right. -David On Aug 6, 2014, at 2:04 PM, Edward Delaporte wrote: For what it's worth, there seems to be a combination of command line flags that works as a workaround: pip install rbtools --allow-external rbtools --allow-unverified rbtools On Wednesday, May 7, 2014 8:03:11 AM UTC-5, Jason Antman wrote: I'm aware that pip is not a supported installation method for ReviewBoard itself. However, I have a number of cases where pip installation is the only method I can do, and I only need access to RBTools for the API client. As of a few months ago, I was able to `pip install RBTools==0.5.2` without a problem, and I have this in a number of requirements.txt files. This morning I tried re-deploying one of the applications that uses this, and got an error from pip saying No distributions at all found - there don't seem to be any valid packages on pypi itself, and even having it allow external URLs doesn't seem to work. Is this an intentional change in behavior? Thanks, Jason -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To
Re: Issue 1395 in reviewboard: Exporting review comments
Comment #11 on issue 1395 by rohithra...@gmail.com: Exporting review comments https://code.google.com/p/reviewboard/issues/detail?id=1395 It's been 5+ years now. using Reviewboard. Thanks a lot to the developers. Unfortunately, there was no response to: liannela...@gmail.com's question. I believe csv file is fine. Of course, Someone has to decide the fields that are required in the report. As someone mentioned: It's helpful for reporting (Without providing access to the repository) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 1395 in reviewboard: Exporting review comments
Comment #10 on issue 1395 by namrata@gmail.com: Exporting review comments https://code.google.com/p/reviewboard/issues/detail?id=1395 We need this feature too. It will be really useful extension. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3814 in reviewboard: AttributeError: 'Namespace' object has no attribute 'revision_range'
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-RBTools Comment #2 on issue 3814 by trowb...@gmail.com: AttributeError: 'Namespace' object has no attribute 'revision_range' https://code.google.com/p/reviewboard/issues/detail?id=3814 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Customize Administrator Dashboard
In Review Board 2.5, you'll be able to add new admin widgets via the extension interfaces: https://www.reviewboard.org/docs/manual/2.5/extending/extensions/hooks/admin-widget-hook/ I'll also take this opportunity to plug the Power Pack ( https://www.reviewboard.org/powerpack/), which has some very nice built-in reports. -David On Thu, May 7, 2015 at 10:05 AM Tanuj Sharma askta...@gmail.com wrote: Hello, First of all, I would like to appreciate your work. ReviewBoard is a very solution for online code reviews. I want to know if there some way I can customize administrator dashboard to show me more graphs like for a particular user how many comments were given on a review package? How many minor major comments reported on a review? This is something I need to present in our project meetings. Any help on this will be appreciated. Thanks, Tanuj Sharma -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #2 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 This code is protected under license, but I can share the initial few lines if it helps. If not, I can just create a new mxml application to demonstrate this. Whichever is better: --- //.../ZoroDebugPlayer/src/ZoroDebugPlayer.mxml //.../ZoroDebugPlayer/src/ZoroDebugPlayer.mxml#2 +++ //.../ZoroDebugPlayer/src/ZoroDebugPlayer.mxml 2015-04-15 16:03:45 @@ -1,6 +1,6 @@ -?xml version=1.0 encoding=utf-8? s:Application xmlns:fx=http://ns.adobe.com/mxml/2009; xmlns:s=library://ns.adobe.com/flex/spark xmlns:mx=library://ns.adobe.com/flex/mx xmlns:metadata=org.osmf.metadata.* xmlns:local=* width=100% height=100% applicationComplete=init() backgroundAlpha=0 backgroundColor=#444242 currentState=videotracestats preloaderChromeColor=#BB stateChangeComplete=startDelayedResize() !-- width=1250 height=770 viewSourceURL=srcview/index.html-- fx:Style source=Main.css/ s:states s:State name=State1/ s:State name=video/ s:State name=videochart/ s:State name=videochartstats/ s:State name=videostats/ s:State name=videotrace/ s:State name=videotracechart/ s:State name=videotracestats/ s:State name=justPlayer/ /s:states -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #4 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 Nope, fails. $ patch -p2 ZoroDebugPlayer.mxml ~/zdp.diff patching file ZoroDebugPlayer.mxml patch: malformed patch at line 5: s:Application xmlns:fx=http://ns.adobe.com/mxml/2009; -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3863 in reviewboard: Web API should provide an id field for a review request's every depends_on entry
Comment #2 on issue 3863 by csipak.a...@ardinsys.eu: Web API should provide an id field for a review request's every depends_on entry https://code.google.com/p/reviewboard/issues/detail?id=3863 Thanks for the tip, but that would still mean a big payload and a lot of processing on the server side for just a couple of bytes of relevant result. I'm going with unelegant solution a) for now, and shall wait for a fix. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #7 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 I am using a post-review script built on top of RBTools. I looked in the source and the way diff is done is using the unix diff command under the clients/perforce.py script. diff_cmd = ['diff', '-urNp', old_file, new_file] However, I installed RBTools and used rbt diff with my reviewboard server URL. These diff produces patchable files. But the diff was not accurate. The line additions do not seem to be the same as I expect. Let me look at this a bit more to confirm. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: can't pip install RBTools - no packages on pypi?
Hi Christian, Has there been any progress on these plans? Is there an issue I can watch? Thanks, Kevin On Wednesday, October 22, 2014 at 6:02:03 PM UTC-7, Christian Hammond wrote: Hi Kevin, There's been some ongoing discussions about changes to pip and the strategy for verification/external packages. We're waiting to see how those impact us. In the meantime, we've made some of the changes needed to get us closer to not needing allow-unverified, but we're not fully there yet. There's no plan to move everything onto PyPI's hosting. It shouldn't matter down the road, from my understanding, but it does depend on the future plans for pip/PyPI. Christian On Wednesday, October 22, 2014, kswe...@twitter.com javascript: wrote: Apologies if this is already answered somewhere in history, but are there any plans to revisit this change? We (Apache Aurora) use rbt in our development workflow via pip to no apparent ill effect. We'd like to avoid the use of --allow-unverified RBTools The currently-published version is only available via HTTP on a server external to PyPI. That means it's vulnerable to MITMs and it doesn't benefit from PyPI's caching infrastructure. Thanks, Kevin On Thursday, August 14, 2014 6:55:47 PM UTC-7, Buck Evan wrote: For the record, the below command does result in a correctly-working rbt command. rbtools really should become compatible with the pip default options. On Wednesday, August 6, 2014 2:17:37 PM UTC-7, David Trowbridge wrote: That will install the package, but I believe pip still doesn't properly register python entry points, which means that rbt won't work right. -David On Aug 6, 2014, at 2:04 PM, Edward Delaporte edth...@gmail.com wrote: For what it's worth, there seems to be a combination of command line flags that works as a workaround: pip install rbtools --allow-external rbtools --allow-unverified rbtools On Wednesday, May 7, 2014 8:03:11 AM UTC-5, Jason Antman wrote: I'm aware that pip is not a supported installation method for ReviewBoard itself. However, I have a number of cases where pip installation is the only method I can do, and I only need access to RBTools for the API client. As of a few months ago, I was able to `pip install RBTools==0.5.2` without a problem, and I have this in a number of requirements.txt files. This morning I tried re-deploying one of the applications that uses this, and got an error from pip saying No distributions at all found - there don't seem to be any valid packages on pypi itself, and even having it allow external URLs doesn't seem to work. Is this an intentional change in behavior? Thanks, Jason -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
RE: can't pip install RBTools - no packages on pypi?
Great news! What about Review Board Power Pack? Will this resolve the issue (for some of us) of obtaining the correct imaging libraries? Terry -Original Message- From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Thursday, May 07, 2015 4:06 PM To: reviewboard@googlegroups.com; kswee...@twitter.com Subject: Re: can't pip install RBTools - no packages on pypi? Hi Kevin, The next releases of RBTools and Review Board will ship Wheels, which are pip-compatible. We have everything in place for this already. We've also moved to a better scheme for verified URLs, meaning that pip won't need the `--allow-unverified` stuff anymore. Every single download URL and file checksum is now registered with PyPI, so that clients can download the package and be absolutely sure the contents are what they should be. What we're still missing is the support for registered external indexes, which pip and PyPI don't yet have. So, it'll still be necessary to do `--allow-all-external`. As soon as they introduce compatibility for PEP 470, we'll be able to implement that last bit, finally giving everyone the ability to do a simple 'pip install RBTools'. We don't have any issue in our tracker for this, but we're waiting for this particular issue: https://github.com/pypa/warehouse/issues/431 Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: kswee...@twitter.com kswee...@twitter.com Reply: kswee...@twitter.com kswee...@twitter.com Date: May 7, 2015 at 1:54:11 PM To: reviewboard@googlegroups.com reviewboard@googlegroups.com Cc: chip...@chipx86.com chip...@chipx86.com Subject: Re: can't pip install RBTools - no packages on pypi? Hi Christian, Has there been any progress on these plans? Is there an issue I can watch? Thanks, Kevin On Wednesday, October 22, 2014 at 6:02:03 PM UTC-7, Christian Hammond wrote: Hi Kevin, There's been some ongoing discussions about changes to pip and the strategy for verification/external packages. We're waiting to see how those impact us. In the meantime, we've made some of the changes needed to get us closer to not needing allow-unverified, but we're not fully there yet. There's no plan to move everything onto PyPI's hosting. It shouldn't matter down the road, from my understanding, but it does depend on the future plans for pip/PyPI. Christian On Wednesday, October 22, 2014, wrote: Apologies if this is already answered somewhere in history, but are there any plans to revisit this change? We (Apache Aurora) use rbt in our development workflow via pip to no apparent ill effect. We'd like to avoid the use of --allow-unverified RBTools The currently-published version is only available via HTTP on a server external to PyPI. That means it's vulnerable to MITMs and it doesn't benefit from PyPI's caching infrastructure. Thanks, Kevin On Thursday, August 14, 2014 6:55:47 PM UTC-7, Buck Evan wrote: For the record, the below command does result in a correctly-working rbt command. rbtools really should become compatible with the pip default options. On Wednesday, August 6, 2014 2:17:37 PM UTC-7, David Trowbridge wrote: That will install the package, but I believe pip still doesn't properly register python entry points, which means that rbt won't work right. -David On Aug 6, 2014, at 2:04 PM, Edward Delaporte wrote: For what it's worth, there seems to be a combination of command line flags that works as a workaround: pip install rbtools --allow-external rbtools --allow-unverified rbtools On Wednesday, May 7, 2014 8:03:11 AM UTC-5, Jason Antman wrote: I'm aware that pip is not a supported installation method for ReviewBoard itself. However, I have a number of cases where pip installation is the only method I can do, and I only need access to RBTools for the API client. As of a few months ago, I was able to `pip install RBTools==0.5.2` without a problem, and I have this in a number of requirements.txt files. This morning I tried re-deploying one of the applications that uses this, and got an error from pip saying No distributions at all found - there don't seem to be any valid packages on pypi itself, and even having it allow external URLs doesn't seem to work. Is this an intentional change in behavior? Thanks, Jason -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it,
Re: Integration of gitlab and reviewboard error
Hi, You'd have to see if GitLab has any logs on this, but I doubt you'll find any detailed information on why those credentials are wrong. We don't have anything more detailed on our end. We're just taking what gets provided in the form and trying to use their API to authenticate. The only information we get back is whether that succeeded or failed. What version of GitLab are you running? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Sri Ram Kannan sriram.ss...@gmail.com Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com Date: May 7, 2015 at 12:40:39 PM To: reviewboard@googlegroups.com reviewboard@googlegroups.com Cc: christ...@beanbaginc.com christ...@beanbaginc.com Subject: Re: Integration of gitlab and reviewboard error Hi Chris, Thanks for your reply. I tried numerous time to login with the same credentials that I use it for gitlab. Still it fails. Wondering what I'm missing here ! Is there any way to check the error logs anywhere ? Regards, Sri. On Thursday, May 7, 2015 at 3:21:32 PM UTC-4, Christian Hammond wrote: Hi Sri, When authenticating a repository, we do so through the GitLab API, and not SSH. This error means exactly what it means: Your username or password you provided doesn't match what's configured in GitLab. I'd make sure you're using the exact same credentials to log into GitLab, and that you're using your username, not e-mail address, to do so. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Sri Ram Kannan Reply: revie...@googlegroups.com Date: May 7, 2015 at 12:19:35 PM To: revie...@googlegroups.com Subject: Integration of gitlab and reviewboard error Hi, I'm trying to connect the gitlab and reviewboard together by addina a gitlab repository into the reviewboard. Initially, I faced error : Unable to link Unable to link the account: The username or password is incorrect. After reading one the topic in this group, I added the ssh key from reviewboard (removing the line breaks, new lines) and pasted it in the gitlab successfully. And I also created a symbolic link of rbssh from /usr/local/bin to /usr/bin/ Still I face the same error as Unable to link the account: The username or password is incorrect. I don't know where the logs are generated to check. I request someone to help me on this. Note: I usually log-in to gitlab using LDAP . Regards, sri. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com . For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3858 in reviewboard: rbt post --username does not always authenticate properly
Updates: Status: Fixed Comment #1 on issue 3858 by bar...@beanbaginc.com: rbt post --username does not always authenticate properly https://code.google.com/p/reviewboard/issues/detail?id=3858 The fix for this issue has landed on the release-0.7.x and master branches as commit 6419501d88b5ce313e8a7e13316c9afae0b3ead5. It will be released in RBTool 0.7.3, as well as all later versions. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3857 in reviewboard: Problem with displaying java diffs of maven projects in clearcase
Updates: Status: NeedInfo Comment #2 on issue 3857 by trowb...@gmail.com: Problem with displaying java diffs of maven projects in clearcase https://code.google.com/p/reviewboard/issues/detail?id=3857 Is there a reason why you discarded the above-mentioned review request? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #6 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 You created your diff via `p4 diff`? Could you try with `rbt diff`? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Updates: Status: NeedInfo Comment #1 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 It would be very helpful to see the patch file in question, not just the source file. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #3 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 Hrmph, ok. I really don't know why `patch` would say that it's malformed. If you try applying that patch manually (by executing the patch command), does it work? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #5 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 The generated diff file does not look correct. I use perforce. The edited lines are not in the patch at all. Maybe this is a p4 diff issue and not a ReviewBoard one? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
