Re: Cleartool missing + Svn access issue ?
By the way .reviewboardrc for the filename of config name is not good for portability because under windows you can't '.reviewboardrc' It absolutely want somthin like .yy or :( perhaps alowing a second name for windows could be a good idea too. somethong like reviewboardrc.conf. If you want I can modify the script to work under windows (with .conf + try catch for subprocess) and send it back to you. 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com More like an active state like: http://www.pythonxy.com/foreword_fr.php I think this is more because of i'm under vista business SP1. I've run in same bug under ipython wednesday. A subprocess couldn't be called due to UAC (other issue but related to subprocess) and it raised Windows Error. So seems subprocess rise this sort of error when it see that the subprocess call exist with failure. Perhpas more related to Vista vs XP? 2009/3/20 Christian Hammond chip...@chipx86.com post-review doesn't require clearcase, and the code that was being run there is the test for whether or not you had it. What should have happened is that we'd see the failure (as a return code, not an exception) and then we'd just silently skip it. The thing is, on your Windows Python install for whatever reason, we're getting the exception instead of the return code. We can definitely do a try/except around the subprocess.Popen call, and then just fake an error return code. I'm just wondering why this is happening in the first place on your system, since I know many other people use post-review on Windows and haven't complained about it. When you say the python(x,y) distribution, do you mean specifically the Python installer on python.org, or are you using something like ActiveState's Python install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou laurent.dufrec...@gmail.com wrote: python - from python(x,y) distribution. this is a python 2.5.2. Json as been installed from setuptools. The fact is as I don't have clearcase on my computer, it could not detetc the tool, so it should warn the user that it could'nt do the test I think. This is not related to python, but more dur to the fact taht my windows clinet knows nothing about clearcase. (you can catch it with try: except WindowsError: but then I don't now how to says there was a failure, perhpas raisng another exeption and cathcing it in higher level?) I will definitvely read the doc, and setup a property for svn. will come after some tries. Laurent 2009/3/20 Christian Hammond chip...@chipx86.com The .reviewboardrc is needed for specifying which server to use, but really this should be done through a property on the SVN server. See the docs in the script for details on setting this up. However, .reviewboardrc isn't related to this. The problem is that we're attempting to execute the clearcase tool in order to see if 1) it's available and 2) this is a clearcase repository. We do these scans with lots of tools. What's odd about this one is that we're actually getting an error back that we don't expect. The call we use *should* return an error code, not an exception. Where did you install your Python from? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Mar 20, 2009 at 12:29 PM, Laurent Dufrechou laurent.dufrec...@gmail.com wrote: It means File not found By the way taking a look @ python script I've seen that it look after a .reviewboardrc file. the fact is i use the script on windows pc client that is not the server. So perhaps someone could say me where i can find this file that must me configured I think? Sorry I fall in all the newbies trap :) 2009/3/20 Christian Hammond chip...@chipx86.com I imagine we're trying to detect if it's a clearcase repository and something with the locale is causing us to fail incorrectly. Possibly a locale-related issue. What does Le fichier spÚcifiÚ est introuvable translate to in English? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Mar 20, 2009 at 10:07 AM, Laurent Dufréchou laurent.dufrec...@gmail.com wrote: Hum yeah... I've set up a svn repos in the web interface. But I access it usually via svn:// (I never heard of Clear Case SCM until now :) ) -Message d'origine- De : reviewboard@googlegroups.com [mailto: reviewbo...@googlegroups.com] De la part de Bartlomiej Celary Envoyé : vendredi 20 mars 2009 14:33 À : reviewboard@googlegroups.com Objet : Re: Cleartool missing + Svn access issue ? Are you using a Clear Case SCM? Cleartool is the tool needed to manage this kind of repo. If not that means
Re: Cleartool missing + Svn access issue ?
Just tested under linux got this execption: Traceback (most recent call last): File ./post-review, line 2312, in module main(sys.argv[1:]) File ./post-review, line 2253, in main repository_info, tool = determine_client() File ./post-review, line 2205, in determine_client repository_info = tool.get_repository_info() File ./post-review, line 744, in get_repository_info self.viewinfo = execute([cleartool, pwv, -short]) File ./post-review, line 1897, in execute env=env) File /usr/lib/python2.5/subprocess.py, line 594, in __init__ errread, errwrite) File /usr/lib/python2.5/subprocess.py, line 1147, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory So under linux it raise an OSError. To be clear I really misuse the script as I launch it on a directory where there is nothing else, but well it should catch the exception I think. 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com By the way .reviewboardrc for the filename of config name is not good for portability because under windows you can't '.reviewboardrc' It absolutely want somthin like .yy or :( perhaps alowing a second name for windows could be a good idea too. somethong like reviewboardrc.conf. If you want I can modify the script to work under windows (with .conf + try catch for subprocess) and send it back to you. 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com More like an active state like: http://www.pythonxy.com/foreword_fr.php I think this is more because of i'm under vista business SP1. I've run in same bug under ipython wednesday. A subprocess couldn't be called due to UAC (other issue but related to subprocess) and it raised Windows Error. So seems subprocess rise this sort of error when it see that the subprocess call exist with failure. Perhpas more related to Vista vs XP? 2009/3/20 Christian Hammond chip...@chipx86.com post-review doesn't require clearcase, and the code that was being run there is the test for whether or not you had it. What should have happened is that we'd see the failure (as a return code, not an exception) and then we'd just silently skip it. The thing is, on your Windows Python install for whatever reason, we're getting the exception instead of the return code. We can definitely do a try/except around the subprocess.Popen call, and then just fake an error return code. I'm just wondering why this is happening in the first place on your system, since I know many other people use post-review on Windows and haven't complained about it. When you say the python(x,y) distribution, do you mean specifically the Python installer on python.org, or are you using something like ActiveState's Python install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou laurent.dufrec...@gmail.com wrote: python - from python(x,y) distribution. this is a python 2.5.2. Json as been installed from setuptools. The fact is as I don't have clearcase on my computer, it could not detetc the tool, so it should warn the user that it could'nt do the test I think. This is not related to python, but more dur to the fact taht my windows clinet knows nothing about clearcase. (you can catch it with try: except WindowsError: but then I don't now how to says there was a failure, perhpas raisng another exeption and cathcing it in higher level?) I will definitvely read the doc, and setup a property for svn. will come after some tries. Laurent 2009/3/20 Christian Hammond chip...@chipx86.com The .reviewboardrc is needed for specifying which server to use, but really this should be done through a property on the SVN server. See the docs in the script for details on setting this up. However, .reviewboardrc isn't related to this. The problem is that we're attempting to execute the clearcase tool in order to see if 1) it's available and 2) this is a clearcase repository. We do these scans with lots of tools. What's odd about this one is that we're actually getting an error back that we don't expect. The call we use *should* return an error code, not an exception. Where did you install your Python from? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Mar 20, 2009 at 12:29 PM, Laurent Dufrechou laurent.dufrec...@gmail.com wrote: It means File not found By the way taking a look @ python script I've seen that it look after a .reviewboardrc file. the fact is i use the script on windows pc client that is not the server. So perhaps someone could say me where i can find this file that must me configured I think? Sorry I fall in all the newbies trap :) 2009/3/20 Christian Hammond chip...@chipx86.com I imagine we're trying
Re: Cleartool missing + Svn access issue ?
Yeah yeah for sure 2009/3/20 Gary M. Josack g...@byoteki.com I'm going to guess you got that error because cleartool isn't installed. Laurent Dufrechou wrote: Just tested under linux got this execption: Traceback (most recent call last): File ./post-review, line 2312, in module main(sys.argv[1:]) File ./post-review, line 2253, in main repository_info, tool = determine_client() File ./post-review, line 2205, in determine_client repository_info = tool.get_repository_info() File ./post-review, line 744, in get_repository_info self.viewinfo = execute([cleartool, pwv, -short]) File ./post-review, line 1897, in execute env=env) File /usr/lib/python2.5/subprocess.py, line 594, in __init__ errread, errwrite) File /usr/lib/python2.5/subprocess.py, line 1147, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory So under linux it raise an OSError. To be clear I really misuse the script as I launch it on a directory where there is nothing else, but well it should catch the exception I think. 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com mailto:laurent.dufrec...@gmail.com By the way .reviewboardrc for the filename of config name is not good for portability because under windows you can't '.reviewboardrc' It absolutely want somthin like .yy or :( perhaps alowing a second name for windows could be a good idea too. somethong like reviewboardrc.conf. If you want I can modify the script to work under windows (with .conf + try catch for subprocess) and send it back to you. 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com mailto:laurent.dufrec...@gmail.com More like an active state like: http://www.pythonxy.com/foreword_fr.php I think this is more because of i'm under vista business SP1. I've run in same bug under ipython wednesday. A subprocess couldn't be called due to UAC (other issue but related to subprocess) and it raised Windows Error. So seems subprocess rise this sort of error when it see that the subprocess call exist with failure. Perhpas more related to Vista vs XP? 2009/3/20 Christian Hammond chip...@chipx86.com mailto:chip...@chipx86.com post-review doesn't require clearcase, and the code that was being run there is the test for whether or not you had it. What should have happened is that we'd see the failure (as a return code, not an exception) and then we'd just silently skip it. The thing is, on your Windows Python install for whatever reason, we're getting the exception instead of the return code. We can definitely do a try/except around the subprocess.Popen call, and then just fake an error return code. I'm just wondering why this is happening in the first place on your system, since I know many other people use post-review on Windows and haven't complained about it. When you say the python(x,y) distribution, do you mean specifically the Python installer on python.org http://python.org, or are you using something like ActiveState's Python install? Christian -- Christian Hammond - chip...@chipx86.com mailto:chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou laurent.dufrec...@gmail.com mailto:laurent.dufrec...@gmail.com wrote: python - from python(x,y) distribution. this is a python 2.5.2. Json as been installed from setuptools. The fact is as I don't have clearcase on my computer, it could not detetc the tool, so it should warn the user that it could'nt do the test I think. This is not related to python, but more dur to the fact taht my windows clinet knows nothing about clearcase. (you can catch it with try: except WindowsError: but then I don't now how to says there was a failure, perhpas raisng another exeption and cathcing it in higher level?) I will definitvely read the doc, and setup a property for svn. will come after some tries. Laurent 2009/3/20 Christian Hammond chip...@chipx86.com mailto:chip...@chipx86.com The .reviewboardrc is needed
Re: How post-review must be used?
Hi christian your mail helps me!
svn info gave the URL. I didn't get for what it was used while reading the
doc.
The fact is there is a ' ' space in my repos URL, and it add to be
translated to %20 ... teah I know (I didn't choose the path name ;) )
so I changed the name from svn://www.xxx.com/mypath with space/etc/ by the
one taht svn info gave me:
svn://www.xxx.com/mypath%20with%20space/etc/ and now I got a traceback in
the web interface! Good
File
/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4-py2.5.egg/reviewboard/scmtools/svn.py,
line 115, in get_file
raise SCMError('Login to the SCM server failed.')
SCMError: Login to the SCM server failed.
So now I have to double check my user/password and I think it will be ok :)
2009/3/20 Christian Hammond chip...@chipx86.com
You must set either the REVIEWBOARD_URL variable within .reviewboardrc or
set the reviewboard:url property on your SVN directory for the project.
The property is preferred, and there are instructions for this within the
post-review script.
The repository URL provided by running `svn info` is what you must use in
Review Board itself in the repository entry.
Did you create a Repository entry in the admin UI in Review Board, and what
is it set to?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Fri, Mar 20, 2009 at 2:37 PM, laurent.dufrec...@gmail.com
laurent.dufrec...@gmail.com wrote:
Hello,
Just another thread because this is not related to the exception
handling.
It seems that I misuse post-review.
I was thinking that I had to launch it (wherever I was), and it would
ask me what was my SVN repos, what was my diff file, ans it would send
the update to the server.
Seems it does no do that. It seems it is looking for some info about
the repos.
Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/
reviews?
If yes, admitting I have misconfigured my server (because it does not
detect the SVN repos. How can I check my repos config?
In fact I've also tried to declare a review via the web interface
sending it a .diff.
But trying to see diff, it show me a blank page. So what, Snv repos
declaration is misconfigured. If yes, where could I find a log to
check this?
I must admit I'm a little bit lost. For the moment I haven't set the
svn properties, just using .reviewboardrc but it doesn't seems to have
any effect.
REVIEWBOARD_URL = http://192.168.1.200/reviews;
So what, more a server repos misconfig?
Laurent
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Need some help with apache2 configuration...
Yep, I've seen the previous thread about debian :) Thx, it seems to work now :) 2009/3/20 Christian Hammond chip...@chipx86.com Default Ubuntu installs of Apache have a /etc/apache2/sites-enabled/default or 000-default file that shares /var/www itself as the website for all URLs. Try removing this file and restarting Apache. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Mar 19, 2009 at 4:04 PM, laurent.dufrec...@gmail.com laurent.dufrec...@gmail.com wrote: Hello, I'm trying to install reviewboard i've followed the insatll book but apache don't want to show up review board. :( I've asked to insatll reviewboard @localhost/reviews but when i go there i see the directory listing and not reviewboard python web interface. So i suspect something is missing. At below of the page there is written: Apache/2.2.8 (Ubuntu) mod_python/3.3.1 Python/2.5.2 Server at localhost Port 80 I've copied /var/www/reviews/conf/apache-modpython.conf to /etc/ apache2/sites-available and done a2ensite apache-modpython.conf I needed to modify it: VirtualHost * -- removed : 80 becasue get an apache warning ServerName 127.0.0.1 DocumentRoot /var/www/reviews/htdocs Done sudo /etc/apache2 restart But well nothing happens when i go to http://localhost/reviews/ Does any of us can give me a little idea to try? thx! Laurent --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
