Re: Django still uses Python 2.4 instead of 2.6
Do you have easy_install-2.6 installed? You'll need a different version of easy_install for each Python 2.x version you have. The easy_install script is linked to a specific version. You can find the correct egg at the bottom of this page: http://pypi.python.org/pypi/setuptools On Thu, Nov 1, 2012 at 7:27 AM, Zhu Wayne zhuw.chic...@gmail.com wrote: Thanks Stephen for looking into my problem.I used easy_install and python is linked to 2.6. $ pwd /usr/bin $ ls -al python* lrwxrwxrwx 1 root root 18 Oct 31 19:14 python - /usr/bin/python2.6 lrwxrwxrwx 1 root root6 Jul 21 2011 python2 - python -rwxr-xr-x 1 root root 8304 Nov 3 2010 python2.4 -rwxr-xr-x 2 root root 8328 Apr 12 2012 python26 -rwxr-xr-x 2 root root 8328 Apr 12 2012 python2.6 $ diff python26 python2.6 My boxes have both 2.4 (default) and 2.6 Python. Is the issue caused by httpd? Since I have installed ReviewBoard twice - one for 2.4 and one for 2.6. On Thursday, November 1, 2012 7:50:00 AM UTC-5, Stephen Gallagher wrote: On Wed 31 Oct 2012 10:01:51 PM EDT, Zhu Wayne wrote: I am not sure why httpd still user Python 2.4 instead of 2.6? I have to point /usr/bin/python - python2.6 instead of python2.4. Linux wihadoopn302p.dev.ch3.s.com 2.6.18-308.13.1.el5 #1 SMP Thu Jul 26 05:45:09 EDT 2012 x86_64 x86_64 x86_64 GNU/Linux How did you install ReviewBoard? Did you install it with the EPEL 5 RPMs I produced? If so, those were compiled against python 2.4 because that is the standard version shipped with RHEL/CentOS 5.x. The main reason for this is that the dependent packages (such as Django) are also built against that version and therefore all need to remain compatible. If you installed ReviewBoard with easy_install, you need to first ensure that the default 'python' binary on your system is python26 (such as via the symlink) *before* running easy_install. Otherwise it will pick the default, which as mentioned above is python 2.4. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Debugging Git repo on 1.6.13
Please ignore me. I was just doing it wrong. On Fri, Nov 2, 2012 at 12:54 PM, Tucker j...@gmail.com wrote: I've trying to add a Git repo to our existing Review Board instance. Until now, everything has been SVN and been simple. When I tried to add the Git repo, I received a complaint about bad SSL certs. Since they're locally generated, this makes sense. I've set a global config option to not validate SSL (sslVerify = false) and that's gone away but not all I get is a spinner in the web page. It doesn't seem to be doing anything now. I've done some testing with the URL to invoke errors and they work (bad hostname, bad path, bad URI handler) but the valid path (which I can clone) doesn't work and there's nothing in the logs. I've enabled debugging in the local settings but all I get is this: 012-11-02 12:39:29,039 - DEBUG - Logging to /var/log/httpd/sites/reviewboard.log with a minimum level of DEBUG 2012-11-02 12:39:29,039 - DEBUG - Log file for Review Board v1.6.13 (PID 14192) Is there additional debugging I can enable or testing I can do? -- --tucker -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem with new install of ReviewBoard 1.6
In case anyone was watching, I'll close this out. After many
permutations and keyboard head smashing, we blew away the VM and spun
up a new one. Problem solved. Not sure if there was a corrupt lib or
something else but I couldn't find any permutation of the install(s)
that would work, despite identical steps working fine on the dev box.
Things are rolling along happily now.
On Wed, Oct 17, 2012 at 3:36 PM, Tucker j...@gmail.com wrote:
Found the list. I'll keep working on this.
On Wed, Oct 17, 2012 at 2:40 PM, Tucker j...@gmail.com wrote:
Is there some place I could find that dependency mapping? The only
things I had to handle compile are wsgi, pysvn and Django (only with
2.7 because it doesn't like https right now). Everything else came
from the easy_install script.
Thanks for taking your time on this. I really appreciate it.
On Wed, Oct 17, 2012 at 2:31 PM, Christian Hammond chip...@chipx86.com
wrote:
Looking again, the traceback you're seeing is due to not using the version
of Djblets required by that version of Review Board. Review Board 1.6.x
requires hard-coded versions of Djblets. Uninstalling Djblets and then
re-installing the ReviewBoard package will fetch the right version.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Oct 17, 2012 at 2:24 PM, Tucker j...@gmail.com wrote:
Tested against Python2.6 as well and get the same strack trace
(pointed to python2.6 install though).
Interestingly, my ReviewBoard 1.7RC2 install works fine with a dev
server using Python2.7 built the same way.
On Wed, Oct 17, 2012 at 2:06 PM, Tucker j...@gmail.com wrote:
I'm pretty confident with the Python install, since it's something
I've had to do a lot. I'm actually a little suspect of the wsgi
module that I had to build.
Traceback:
'
Environment:
Request Method: GET
Request URL: http://reviews.sre.zynga.com/account/login/
Django Version: 1.4.1
Python Version: 2.7.0
Installed Applications:
('django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.gravatars',
'djblets.log',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.attachments',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.notifications',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.site',
'reviewboard.webapi',
'django_evolution')
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
'reviewboard.admin.middleware.X509AuthMiddleware',
'reviewboard.site.middleware.LocalSiteMiddleware')
Traceback:
File /usr/lib/python2.7/site-packages/django/core/handlers/base.py
in get_response
89. response = middleware_method(request)
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
process_request
21. check_path = self.is_language_prefix_patterns_used()
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
is_language_prefix_patterns_used
54. for url_pattern in get_resolver(None).url_patterns:
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
url_patterns
328. patterns = getattr(self.urlconf_module, urlpatterns,
self.urlconf_module)
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
urlconf_module
323. self._urlconf_module =
import_module(self.urlconf_name)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/util/rooturl.py
in module
40. (r'^%s' % settings.SITE_ROOT[1:],
include(settings.SITE_ROOT_URLCONF)),
File /usr/lib/python2.7/site-packages/django/conf/urls/__init__.py in
include
24. urlconf_module = import_module(urlconf_module)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/urls.py
in module
5. from reviewboard.webapi.resources
Problem with new install of ReviewBoard 1.6
I'm trying to setup a new ReviewBoard 1.6 instance and running into
some problems. I have Python 2.7 installed, on CentOS 5.4, by way of
Python's altinstall method. Here are the steps I'm executing.
sudo easy_install-2.7 -U ReviewBoard
# This complains about not knowing how to handle https: for getting Django.-
wget https://www.djangoproject.com/m/releases/1.3/Django-1.3.3.tar.gz
# extract, build, install goes fine
sudo easy_install-2.7 -U ReviewBoard
# Success!
$ sudo rb-site install --domain-name='reviews.sre.company.com'
--site-root='/' --media-url='media/' --db-type='mysql'
--db-name='reviewboard' --db-host='localhost' --db-user='reviewboard'
--db-pass='password' --cache-type='memcached'
--web-server-type='apache' --python-loader='wsgi' --admin-user='admin'
--admin-password='password' --admin-email='j...@company.com'
/var/www/sites/reviews.sre.company.com/
# This all works fine and I get the installed message.
$ sudo chown -R apache
/var/www/sites/reviews.sre.company.com/htdocs/media/uploaded
$ sudo chown -R apache /var/www/sites/reviews.sre.company.com/data
Copy config from conf/ dir into /etc/httpd/conf.d/ dir. Restart
apache and memcached. The site comes up fine but then I try import
the dump from my old site. The old site is 1.6 and the new site is
running 1.6.13. ReviewBoard tells me I need to upgrade. When I run
the upgrade, this is what I get:
Rebuilding directory structure
Updating database. This may take a while.
Creating tables ...
Creating table hostingsvcs_hostingserviceaccount
Traceback (most recent call last):
File /usr/bin/rb-site, line 8, in module
load_entry_point('ReviewBoard==1.6.13', 'console_scripts', 'rb-site')()
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 1745, in main
command.run()
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 1642, in run
site.sync_database()
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 346, in sync_database
self.run_manage_command(syncdb, params)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 469, in run_manage_command
execute_manager(reviewboard.settings, [__file__, cmd] + params)
File /usr/lib/python2.7/site-packages/django/core/management/__init__.py,
line 438, in execute_manager
utility.execute()
File /usr/lib/python2.7/site-packages/django/core/management/__init__.py,
line 379, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 191, in run_from_argv
self.execute(*args, **options.__dict__)
File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 220, in execute
output = self.handle(*args, **options)
File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 351, in handle
return self.handle_noargs(**options)
File
/usr/lib/python2.7/site-packages/django/core/management/commands/syncdb.py,
line 101, in handle_noargs
cursor.execute(statement)
File /usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py,
line 86, in execute
return self.cursor.execute(query, args)
File
/usr/lib/python2.7/site-packages/MySQL_python-1.2.4b4-py2.7-linux-x86_64.egg/MySQLdb/cursors.py,
line 202, in execute
File
/usr/lib/python2.7/site-packages/MySQL_python-1.2.4b4-py2.7-linux-x86_64.egg/MySQLdb/connections.py,
line 36, in defaulterrorhandler
_mysql_exceptions.OperationalError: (1005, Can't create table
'./reviewboard/#sql-4eed_51.frm' (errno: 150))
To make sure it's not a problem with credentials or permissions, I
attempted the install using the mysql root account as well and no
dice.
If I run the upgrade a second time, I get this:
Updating database. This may take a while.
Creating tables ...
Upgrading Review Board from 1.6 to 1.6.13
There are unapplied evolutions for scmtools.
Adding baseline version for new models
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
No fixtures found.
Evolution successful.
Resetting in-database caches.
Upgrade complete.
Unfortunately, when I try and login, Apache segfaults:
[Wed Oct 17 14:38:53 2012] [notice] child pid 3210 exit signal
Segmentation fault (11)
Any one have any ideas?
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Problem with new install of ReviewBoard 1.6
/importlib.py,
line 35, in import_module
__import__(name)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/urls.py,
line 5, in module
from reviewboard.webapi.resources import root_resource
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/webapi/resources.py,
line 1532, in module
diffset_resource = DiffResource()
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/webapi/resources.py,
line 361, in __init__
item_mimetypes.append(mime['item'])
TypeError: string indices must be integers, not str
Trust me, if there was any way I could get a more modern version of a
Linux distro in our environment, I'd be all over it. My alternative
is to use ReviewBoard 1.6.x, with Python 2.4.3, and live with it
forever.
On Wed, Oct 17, 2012 at 12:45 PM, Christian Hammond chip...@chipx86.com wrote:
Wow, you're having all sorts of strange problems there.
I'm thinking it all boils down to whatever altinstall is. I recommend just
using the system-packaged Python (assuming it' 2.6) for now. It'll be a good
while before that's deprecated.
If easy_install can't recognize https, you're going to have much, much
bigger problems down the road. Maybe the Apache segfault is a part of that.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Oct 17, 2012 at 11:39 AM, Tucker j...@gmail.com wrote:
I'm trying to setup a new ReviewBoard 1.6 instance and running into
some problems. I have Python 2.7 installed, on CentOS 5.4, by way of
Python's altinstall method. Here are the steps I'm executing.
sudo easy_install-2.7 -U ReviewBoard
# This complains about not knowing how to handle https: for getting
Django.-
wget https://www.djangoproject.com/m/releases/1.3/Django-1.3.3.tar.gz
# extract, build, install goes fine
sudo easy_install-2.7 -U ReviewBoard
# Success!
$ sudo rb-site install --domain-name='reviews.sre.company.com'
--site-root='/' --media-url='media/' --db-type='mysql'
--db-name='reviewboard' --db-host='localhost' --db-user='reviewboard'
--db-pass='password' --cache-type='memcached'
--web-server-type='apache' --python-loader='wsgi' --admin-user='admin'
--admin-password='password' --admin-email='j...@company.com'
/var/www/sites/reviews.sre.company.com/
# This all works fine and I get the installed message.
$ sudo chown -R apache
/var/www/sites/reviews.sre.company.com/htdocs/media/uploaded
$ sudo chown -R apache /var/www/sites/reviews.sre.company.com/data
Copy config from conf/ dir into /etc/httpd/conf.d/ dir. Restart
apache and memcached. The site comes up fine but then I try import
the dump from my old site. The old site is 1.6 and the new site is
running 1.6.13. ReviewBoard tells me I need to upgrade. When I run
the upgrade, this is what I get:
Rebuilding directory structure
Updating database. This may take a while.
Creating tables ...
Creating table hostingsvcs_hostingserviceaccount
Traceback (most recent call last):
File /usr/bin/rb-site, line 8, in module
load_entry_point('ReviewBoard==1.6.13', 'console_scripts',
'rb-site')()
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 1745, in main
command.run()
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 1642, in run
site.sync_database()
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 346, in sync_database
self.run_manage_command(syncdb, params)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6.13-py2.7.egg/reviewboard/cmdline/rbsite.py,
line 469, in run_manage_command
execute_manager(reviewboard.settings, [__file__, cmd] + params)
File
/usr/lib/python2.7/site-packages/django/core/management/__init__.py,
line 438, in execute_manager
utility.execute()
File
/usr/lib/python2.7/site-packages/django/core/management/__init__.py,
line 379, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 191, in run_from_argv
self.execute(*args, **options.__dict__)
File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 220, in execute
output = self.handle(*args, **options)
File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 351, in handle
return self.handle_noargs(**options)
File
/usr/lib/python2.7/site-packages/django/core/management/commands/syncdb.py,
line 101, in handle_noargs
cursor.execute(statement)
File
/usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py,
line 86, in execute
return self.cursor.execute(query, args)
File
/usr/lib/python2.7/site-packages/MySQL_python-1.2.4b4-py2.7-linux-x86_64.egg/MySQLdb/cursors.py,
line 202
Re: Problem with new install of ReviewBoard 1.6
This is an it's not me, it's them moment. I'm limited by the offerings we have in our datacenters. Since run a large production network, we sacrifice flexibility for predictability. That means I don't have anything available to me other than Cent OS 5.2 and 5.4. My desktop runs Xubuntu quite nicely. For what it's worth, I enable debugging in settings_local.py and it looks like there's something about the login page that Djblets-0.7.2-py27 doesn't like. This is after the stack trace I put in the above email. Exception Type: TypeError at /account/login/ Exception Value: string indices must be integers, not str Hopefully I'll be able to narrow this down. On Wed, Oct 17, 2012 at 1:22 PM, Christian Hammond chip...@chipx86.com wrote: Have you given Ubuntu a try? We've found them to be our best host for Review Board when not using system packages. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Oct 17, 2012 at 1:10 PM, Tucker j...@gmail.com wrote: altinstall is a make option for Python. It allows you to run multiple versions of Python in parallel. Unfortunately, Cent OS 5.4 still ships with Python 2.4 and, since I'm building a new machine, I'm trying to make sure it's possible to upgrade it in the future. What if I have a different error, by trying a slightly different method? This is an attempt at installing 1.6 (not 1.6.13) and not doing anything to the DB. From the apache error log: mod_wsgi (pid=11867): Exception occurred processing WSGI script '/var/www/sites/reviews.sre.company.com/htdocs/reviewboard.wsgi'., referer: http://reviews.sre.company.com/account/ login/ Traceback (most recent call last):, referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/django/core/handlers/wsgi.py, line 241, in __call__, referer: http://reviews.sre.company.com/account/login/ response = self.get_response(request), referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/django/core/handlers/base.py, line 179, in get_response, referer: http://reviews.sre.company.com/account/login/ response = self.handle_uncaught_exception(request, resolver, sys.exc_info()), referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/django/core/handlers/base.py, line 224, in handle_uncaught_exception, referer: http://reviews.sre.company.com/account/login/ if resolver.urlconf_module is None:, referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py, line 323, in urlconf_module, referer: http://reviews.sre.company.com/account/login/ self._urlconf_module = import_module(self.urlconf_name), referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/django/utils/importlib.py, line 35, in import_module, referer: http://reviews.sre.company.com/account/login/ __import__(name), referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/util/rooturl.py, line 40, in module, referer: http://reviews.sre.company.com/account/login/ (r'^%s' % settings.SITE_ROOT[1:], include(settings.SITE_ROOT_URLCONF)),, referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/django/conf/urls/__init__.py, line 24, in include, referer: http://reviews.sre.company.com/account/login/ urlconf_module = import_module(urlconf_module), referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/django/utils/importlib.py, line 35, in import_module, referer: http://reviews.sre.company.com/account/login/ __import__(name), referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/urls.py, line 5, in module, referer: http://reviews.sre.company.com/account/login/ from reviewboard.webapi.resources import root_resource, referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/webapi/resources.py, line 1532, in module, referer: http://reviews.sre.company.com/account/login/ diffset_resource = DiffResource(), referer: http://reviews.sre.company.com/account/login/ File /usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/webapi/resources.py, line 361, in __init__, referer: http://reviews.sre.company.com/account/login/ item_mimetypes.append(mime['item']), referer: http://reviews.sre.company.com/account/login/ TypeError: string indices must be integers, not str, referer: http://reviews.sre.company.com/account/login/ mod_wsgi (pid=11860): Exception occurred processing WSGI script '/var/www/sites/reviews.sre.company.com/htdocs/reviewboard.wsgi
Re: Problem with new install of ReviewBoard 1.6
I'm pretty confident with the Python install, since it's something
I've had to do a lot. I'm actually a little suspect of the wsgi
module that I had to build.
Traceback:
'
Environment:
Request Method: GET
Request URL: http://reviews.sre.zynga.com/account/login/
Django Version: 1.4.1
Python Version: 2.7.0
Installed Applications:
('django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.gravatars',
'djblets.log',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.attachments',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.notifications',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.site',
'reviewboard.webapi',
'django_evolution')
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
'reviewboard.admin.middleware.X509AuthMiddleware',
'reviewboard.site.middleware.LocalSiteMiddleware')
Traceback:
File /usr/lib/python2.7/site-packages/django/core/handlers/base.py
in get_response
89. response = middleware_method(request)
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
process_request
21. check_path = self.is_language_prefix_patterns_used()
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
is_language_prefix_patterns_used
54. for url_pattern in get_resolver(None).url_patterns:
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
url_patterns
328. patterns = getattr(self.urlconf_module, urlpatterns,
self.urlconf_module)
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
urlconf_module
323. self._urlconf_module = import_module(self.urlconf_name)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/util/rooturl.py
in module
40. (r'^%s' % settings.SITE_ROOT[1:],
include(settings.SITE_ROOT_URLCONF)),
File /usr/lib/python2.7/site-packages/django/conf/urls/__init__.py in include
24. urlconf_module = import_module(urlconf_module)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/urls.py
in module
5. from reviewboard.webapi.resources import root_resource
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/webapi/resources.py
in module
1532. diffset_resource = DiffResource()
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/webapi/resources.py
in __init__
361. item_mimetypes.append(mime['item'])
Exception Type: TypeError at /account/login/
Exception Value: string indices must be integers, not str
On Wed, Oct 17, 2012 at 1:35 PM, Christian Hammond chip...@chipx86.com wrote:
Can you show the full backtrace?
Still, no crash here can affect Apache. This is a crash in Python or a
Python module. I'm highly suspect of the Python install.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Oct 17, 2012 at 1:33 PM, Tucker j...@gmail.com wrote:
This is an it's not me, it's them moment. I'm limited by the
offerings we have in our datacenters. Since run a large production
network, we sacrifice flexibility for predictability. That means I
don't have anything available to me other than Cent OS 5.2 and 5.4.
My desktop runs Xubuntu quite nicely.
For what it's worth, I enable debugging in settings_local.py and it
looks like there's something about the login page that
Djblets-0.7.2-py27 doesn't like. This is after the stack trace I put
in the above email.
Exception Type: TypeError at /account/login/
Exception Value: string indices must be integers, not str
Hopefully I'll be able to narrow this down.
On Wed, Oct 17, 2012 at 1:22 PM, Christian Hammond chip...@chipx86.com
wrote:
Have you given Ubuntu a try? We've found them to be our best host for
Review
Board when not using system packages.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc
Re: Problem with new install of ReviewBoard 1.6
Tested against Python2.6 as well and get the same strack trace
(pointed to python2.6 install though).
Interestingly, my ReviewBoard 1.7RC2 install works fine with a dev
server using Python2.7 built the same way.
On Wed, Oct 17, 2012 at 2:06 PM, Tucker j...@gmail.com wrote:
I'm pretty confident with the Python install, since it's something
I've had to do a lot. I'm actually a little suspect of the wsgi
module that I had to build.
Traceback:
'
Environment:
Request Method: GET
Request URL: http://reviews.sre.zynga.com/account/login/
Django Version: 1.4.1
Python Version: 2.7.0
Installed Applications:
('django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.gravatars',
'djblets.log',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.attachments',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.notifications',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.site',
'reviewboard.webapi',
'django_evolution')
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
'reviewboard.admin.middleware.X509AuthMiddleware',
'reviewboard.site.middleware.LocalSiteMiddleware')
Traceback:
File /usr/lib/python2.7/site-packages/django/core/handlers/base.py
in get_response
89. response = middleware_method(request)
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
process_request
21. check_path = self.is_language_prefix_patterns_used()
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
is_language_prefix_patterns_used
54. for url_pattern in get_resolver(None).url_patterns:
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
url_patterns
328. patterns = getattr(self.urlconf_module, urlpatterns,
self.urlconf_module)
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
urlconf_module
323. self._urlconf_module = import_module(self.urlconf_name)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/util/rooturl.py
in module
40. (r'^%s' % settings.SITE_ROOT[1:],
include(settings.SITE_ROOT_URLCONF)),
File /usr/lib/python2.7/site-packages/django/conf/urls/__init__.py in
include
24. urlconf_module = import_module(urlconf_module)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/urls.py
in module
5. from reviewboard.webapi.resources import root_resource
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/webapi/resources.py
in module
1532. diffset_resource = DiffResource()
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/webapi/resources.py
in __init__
361. item_mimetypes.append(mime['item'])
Exception Type: TypeError at /account/login/
Exception Value: string indices must be integers, not str
On Wed, Oct 17, 2012 at 1:35 PM, Christian Hammond chip...@chipx86.com
wrote:
Can you show the full backtrace?
Still, no crash here can affect Apache. This is a crash in Python or a
Python module. I'm highly suspect of the Python install.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Oct 17, 2012 at 1:33 PM, Tucker j...@gmail.com wrote:
This is an it's not me, it's them moment. I'm limited by the
offerings we have in our datacenters. Since run a large production
network, we sacrifice flexibility for predictability. That means I
don't have anything available to me other than Cent OS 5.2 and 5.4.
My desktop runs Xubuntu quite nicely.
For what it's worth, I enable debugging in settings_local.py and it
looks like there's something about the login page that
Djblets-0.7.2-py27 doesn't like. This is after the stack trace I put
in the above email.
Exception Type: TypeError at /account/login/
Exception Value: string indices must be integers, not str
Re: Problem with new install of ReviewBoard 1.6
Is there some place I could find that dependency mapping? The only
things I had to handle compile are wsgi, pysvn and Django (only with
2.7 because it doesn't like https right now). Everything else came
from the easy_install script.
Thanks for taking your time on this. I really appreciate it.
On Wed, Oct 17, 2012 at 2:31 PM, Christian Hammond chip...@chipx86.com wrote:
Looking again, the traceback you're seeing is due to not using the version
of Djblets required by that version of Review Board. Review Board 1.6.x
requires hard-coded versions of Djblets. Uninstalling Djblets and then
re-installing the ReviewBoard package will fetch the right version.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Oct 17, 2012 at 2:24 PM, Tucker j...@gmail.com wrote:
Tested against Python2.6 as well and get the same strack trace
(pointed to python2.6 install though).
Interestingly, my ReviewBoard 1.7RC2 install works fine with a dev
server using Python2.7 built the same way.
On Wed, Oct 17, 2012 at 2:06 PM, Tucker j...@gmail.com wrote:
I'm pretty confident with the Python install, since it's something
I've had to do a lot. I'm actually a little suspect of the wsgi
module that I had to build.
Traceback:
'
Environment:
Request Method: GET
Request URL: http://reviews.sre.zynga.com/account/login/
Django Version: 1.4.1
Python Version: 2.7.0
Installed Applications:
('django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.gravatars',
'djblets.log',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.attachments',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.notifications',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.site',
'reviewboard.webapi',
'django_evolution')
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
'reviewboard.admin.middleware.X509AuthMiddleware',
'reviewboard.site.middleware.LocalSiteMiddleware')
Traceback:
File /usr/lib/python2.7/site-packages/django/core/handlers/base.py
in get_response
89. response = middleware_method(request)
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
process_request
21. check_path = self.is_language_prefix_patterns_used()
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
is_language_prefix_patterns_used
54. for url_pattern in get_resolver(None).url_patterns:
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
url_patterns
328. patterns = getattr(self.urlconf_module, urlpatterns,
self.urlconf_module)
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
urlconf_module
323. self._urlconf_module =
import_module(self.urlconf_name)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/util/rooturl.py
in module
40. (r'^%s' % settings.SITE_ROOT[1:],
include(settings.SITE_ROOT_URLCONF)),
File /usr/lib/python2.7/site-packages/django/conf/urls/__init__.py in
include
24. urlconf_module = import_module(urlconf_module)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/urls.py
in module
5. from reviewboard.webapi.resources import root_resource
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/webapi/resources.py
in module
1532. diffset_resource = DiffResource()
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/webapi/resources.py
in __init__
361. item_mimetypes.append(mime['item'])
Exception Type: TypeError at /account/login/
Exception Value: string indices must be integers, not str
On Wed, Oct 17, 2012 at 1:35 PM, Christian Hammond chip...@chipx86.com
wrote:
Can you show the full
Re: Problem with new install of ReviewBoard 1.6
Found the list. I'll keep working on this.
On Wed, Oct 17, 2012 at 2:40 PM, Tucker j...@gmail.com wrote:
Is there some place I could find that dependency mapping? The only
things I had to handle compile are wsgi, pysvn and Django (only with
2.7 because it doesn't like https right now). Everything else came
from the easy_install script.
Thanks for taking your time on this. I really appreciate it.
On Wed, Oct 17, 2012 at 2:31 PM, Christian Hammond chip...@chipx86.com
wrote:
Looking again, the traceback you're seeing is due to not using the version
of Djblets required by that version of Review Board. Review Board 1.6.x
requires hard-coded versions of Djblets. Uninstalling Djblets and then
re-installing the ReviewBoard package will fetch the right version.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Oct 17, 2012 at 2:24 PM, Tucker j...@gmail.com wrote:
Tested against Python2.6 as well and get the same strack trace
(pointed to python2.6 install though).
Interestingly, my ReviewBoard 1.7RC2 install works fine with a dev
server using Python2.7 built the same way.
On Wed, Oct 17, 2012 at 2:06 PM, Tucker j...@gmail.com wrote:
I'm pretty confident with the Python install, since it's something
I've had to do a lot. I'm actually a little suspect of the wsgi
module that I had to build.
Traceback:
'
Environment:
Request Method: GET
Request URL: http://reviews.sre.zynga.com/account/login/
Django Version: 1.4.1
Python Version: 2.7.0
Installed Applications:
('django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.gravatars',
'djblets.log',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.attachments',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.notifications',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.site',
'reviewboard.webapi',
'django_evolution')
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
'reviewboard.admin.middleware.X509AuthMiddleware',
'reviewboard.site.middleware.LocalSiteMiddleware')
Traceback:
File /usr/lib/python2.7/site-packages/django/core/handlers/base.py
in get_response
89. response = middleware_method(request)
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
process_request
21. check_path = self.is_language_prefix_patterns_used()
File /usr/lib/python2.7/site-packages/django/middleware/locale.py in
is_language_prefix_patterns_used
54. for url_pattern in get_resolver(None).url_patterns:
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
url_patterns
328. patterns = getattr(self.urlconf_module, urlpatterns,
self.urlconf_module)
File /usr/lib/python2.7/site-packages/django/core/urlresolvers.py in
urlconf_module
323. self._urlconf_module =
import_module(self.urlconf_name)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/util/rooturl.py
in module
40. (r'^%s' % settings.SITE_ROOT[1:],
include(settings.SITE_ROOT_URLCONF)),
File /usr/lib/python2.7/site-packages/django/conf/urls/__init__.py in
include
24. urlconf_module = import_module(urlconf_module)
File /usr/lib/python2.7/site-packages/django/utils/importlib.py in
import_module
35. __import__(name)
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/urls.py
in module
5. from reviewboard.webapi.resources import root_resource
File
/usr/lib/python2.7/site-packages/ReviewBoard-1.6-py2.7.egg/reviewboard/webapi/resources.py
in module
1532. diffset_resource = DiffResource()
File
/usr/lib/python2.7/site-packages/Djblets-0.7.2-py2.7.egg/djblets/webapi/resources.py
in __init__
361. item_mimetypes.append(mime['item'])
Exception Type: TypeError at /account/login/
Exception Value: string indices must be integers, not str
Re: Upgrading python versions?
Should I do a whole new install and migrate the DB? On Tue, Feb 28, 2012 at 2:43 PM, Tucker j...@gmail.com wrote: I decided to try and build pylucene again on CentOs 5.2. I kept running into problems with python2.4, so I built jcc against python2.6 (ActivePython). I eventually got it working (using openjdk-1.6 and a modern version of ant) but ReviewBoard doesn't seem to agree and I can't enable search. Since I built jcc with python2.6 and installed ReviewBoard using python2.4. this makes sense. Anyone have any suggestions on how to either cheat the enable search setting or upgrade the python version ReviewBoard is using? -- --tucker -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Upgrading python versions?
I decided to try and build pylucene again on CentOs 5.2. I kept running into problems with python2.4, so I built jcc against python2.6 (ActivePython). I eventually got it working (using openjdk-1.6 and a modern version of ant) but ReviewBoard doesn't seem to agree and I can't enable search. Since I built jcc with python2.6 and installed ReviewBoard using python2.4. this makes sense. Anyone have any suggestions on how to either cheat the enable search setting or upgrade the python version ReviewBoard is using? -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to get people to close off reviews
Any chance you could share your diff for updating your tracker? We're using JIRA and I've had to become plenty familiar with the SOAP API. As I'm lazy and you've already done a bit of the work, I was hoping I could piggy back of your efforts. I've not had the time to dive in and find out how to extend the close function. If I have time this weekend, I'm going to work on automating the stick portion. On Fri, Nov 4, 2011 at 3:55 PM, Scott Quesnelle scott.quesne...@gmail.com wrote: I personally do two things. One carrot, one stick. Stick first. I just sort reviews based on last updated time and look for anyone that has more then 2 or 3 reviews of more then a certain age. I then have a somewhat standard form letter that I mail them. It reminds them of the process needs of this. It seems to work well. The carrot is that we keep a record of all of our code reviews in our defect tracking system. I have done a modification to review board, where when a review is closed as 'submitted' it will generate a summary which is then added to the defect ticket. This step saves developers time and removes this manual step. A variation on my stick system is to also sort by user based on the # of open reviews. Scott On Thu, Oct 27, 2011 at 5:41 AM, Jeremy Poulter jeremy.poul...@oregan.net wrote: Hi, As one of the key reviewers my list of open reviews is quite large and the majority of them are inactive as they have either been committed or abandoned. I am after suggestions on how to manage this (I have tried the big stick approach already ;-) Is there a way to query old reviews? Is there a way to limit the number open reviews per user? Cheers, Jeremy -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to get people to close off reviews
I actually have a similar problem. Since there's no connection between a commit and an open review (by design and it makes sense), people tend to leave their reviews open. I have yet to take the time to do this but my long term plan is two fold: 1. Nag System Stale reviews (over 48 hours... or something to be decided later) will result in an email to the author. If there have been review comments posted, that will be called out. If there are no review comments, as suggestion about resolving it as abandoned or committed will be made. A simple cron talking to the RB API would take care of this. 2. Custom post-commit I'm either going to wrap post-commit, extend it for in house use or rewrite it. All three methods have advantages an disadvantages. * Wrapping it would be simple and I could pass all non custom commands straight to the post-commit script. I already have Python code that I can use as a basis and I'd only have to customize commit and closure. * Extending it to handle the actual commit would be useful outside of my org but would take a lot of work to do right and be flexible enough to handle all the repos RB works with. * Rewriting a custom version would allow for a smaller script and I could strip out unneeded functionality. This would likely be number two in order of complexity. Unfortunately, I don't have any code to share for any of this right now. If/When I make some progress, I'll be sure to publish it here. On Thu, Oct 27, 2011 at 2:41 AM, Jeremy Poulter jeremy.poul...@oregan.net wrote: Hi, As one of the key reviewers my list of open reviews is quite large and the majority of them are inactive as they have either been committed or abandoned. I am after suggestions on how to manage this (I have tried the big stick approach already ;-) Is there a way to query old reviews? Is there a way to limit the number open reviews per user? Cheers, Jeremy -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: PyLucene and JCC on CentOS 5.[2,3]
I actually haven't had any more time to play with it. Glad to hear you got it working. I'll have to give that a shot. On Mon, Oct 10, 2011 at 10:36 AM, dmaraio dmar...@gmail.com wrote: I got this to compile properly today. This does not seem to compile against jdk1.7, I dropped back to 1.6u25 and it compiles correctly. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board at scale
I do have memcached configured and the machine is running fine. Thank you (and Christian) for your responses. When they decide to go through a system review, it'll be nice to have these numbers as a reference. On Thu, Oct 6, 2011 at 12:45 PM, David Trowbridge trowb...@gmail.com wrote: When configured correctly, review board should easily handle that. The largest deployment I know of has 4000 users and over 27 review requests on a single 4-CPU system with 4G of RAM. Do you have memcached configured? - David On Oct 6, 2011, at 12:14 PM, Tucker j...@gmail.com wrote: Within the company where I work, there have been murmurs of popularizing the Review Board instance my team is using. This is good and bad news. The good news is that people are looking harder at code review becoming a more formal part of how we work. The bad news is that I don't know anything about running Review Board at scale. The 1.0 release blog post states there was, at the time, a company with 83k+ reviews and 2k+ users. Assuming said company kept using Review Board, this number has likely increased drastically. I'm curious how this was accomplished. A single, massive, machine? Clustering? I don't have a count of the number of commits over time that we'd should expect but the number of users is in the 1k-2k range for the next few quarters. The current Review Board machine specs are as follows: * CentOS 5.2 * Python 2.4.3 * 35G+ of available disk * Quad Xeon 2.27GHz * 16G RAM For the sake of argument, let's assume something in the ~100k commit range. Should I worry? -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Review Board at scale
Within the company where I work, there have been murmurs of popularizing the Review Board instance my team is using. This is good and bad news. The good news is that people are looking harder at code review becoming a more formal part of how we work. The bad news is that I don't know anything about running Review Board at scale. The 1.0 release blog post states there was, at the time, a company with 83k+ reviews and 2k+ users. Assuming said company kept using Review Board, this number has likely increased drastically. I'm curious how this was accomplished. A single, massive, machine? Clustering? I don't have a count of the number of commits over time that we'd should expect but the number of users is in the 1k-2k range for the next few quarters. The current Review Board machine specs are as follows: * CentOS 5.2 * Python 2.4.3 * 35G+ of available disk * Quad Xeon 2.27GHz * 16G RAM For the sake of argument, let's assume something in the ~100k commit range. Should I worry? -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP Authentication
Are you really using example in your base DN?
On Fri, Sep 30, 2011 at 7:48 AM, purushoth purushot...@gmail.com wrote:
hello,
i am a newbie to reviewboard. below are the details of my server:
os : ubuntu 11.04 server
version : ReviewBoard 1.6.1 using wsgi method in Apache2
i am trying to configure the ldap authentication and getting the below
error:
19:59:30 WARNING LDAP error: {'desc': 'Bad search filter'}.
my settings are:
LDAP Server: ldap://mydomain.com:389
LDAP Base DN : dc=example,dc=com
E-Mail LDAP Attribute: mail
Use TLS for authentication: unchecked
User Mask:uid=sAMAccountName=%s,dc=mydomain,dc=com
Anonymous User
Mask:cn=administrator,cn=Users,dc=server,dc=mydomain,dc=com
Anonymous User Password:
please guide me on setting this up
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: PyLucene and JCC on CentOS 5.[2,3]
Currently, when trying to compile lucene, it ends with this: build/_lucene/__wrap04__.cpp:5994:1: error: pasting ; and $$Type does not give a valid preprocessing token build/_lucene/__wrap04__.cpp: In function ‘PyObject* java::lang::t_Thread_getAllStackTraces(PyTypeObject*)’: build/_lucene/__wrap04__.cpp:5994: error: expected id-expression before ‘[’ token build/_lucene/__wrap04__.cpp:5994: error: ‘Ljava’ has not been declared build/_lucene/__wrap04__.cpp:5994: error: expected `]' before ‘;’ token build/_lucene/__wrap04__.cpp:5994: error: ‘$$Type’ was not declared in this scope build/_lucene/__wrap04__.cpp:5994: error: expected `;' before ‘)’ token error: command 'gcc' failed with exit status 1 gmake: *** [compile] Error 1 I'm still monkeying around with it but this is as far as I've gotten today. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
PyLucene and JCC on CentOS 5.[2,3]
Has anyone managed to install PyLucene on CentOS 5.2 and/or CentOS 5.3? The company I work for is stuck on this version and I'm having trouble getting all the right packages together (lack of time being a major factor). I miss search. :( If anyone has a writeup or some steps they'd like to share, I'd be grateful. -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Failed upgrade to RC2
I don't quite think I'm groking your request. You want screen caps of
Home › Django_evolution › Versions › Hinted version, updated on
2011-06-30 20:16:00 and Home › Django_evolution › Versions › Stored
version, updated on 2011-06-30 20:16:00? I just looked at those and
they look rather uninteresting, due to the default text field size.
The text field is only 10 rows tall.
As for DB dumps, what are the chances that they could contain
identifying or interesting information about my company? If greater
than 0, we'll have to discuss that off list.
On Fri, Jul 29, 2011 at 2:52 AM, Christian Hammond chip...@chipx86.com wrote:
I have a script now that can simulate various database upgrade scenarios,
and have spent lots of time with it now. I've yet to be able to reproduce
this. I've tried sqlite and MySQL, Python versions 2.4 through 2.6, and
various combinations of Review Board versions.
I am curious about the Hinted entry. I would very much like to be able to
get a dump of the contents of that, straight from the database if possible.
Same with the Stored of the same date.
Could you provide a screenshot from the admin UI too for both?
To be quite frank, it looks very much like unintentional user error at some
point caused by playing with versions. However, given that there have been a
few reports (3, maybe 4) of similar things, I'm eager to figure out exactly
what is happening. These aren't problems we've encountered in the past from
a user's typical upgrade.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Jul 27, 2011 at 10:44 PM, Christian Hammond chip...@chipx86.com
wrote:
I wouldn't expect a hint + stored evolutions to be updated at the same
time. Usually it's one or the other.
The common denominators in the cases I've seen where people have hit this
are Python 2.4 and MySQL, so I'll run some tests and see if I can reproduce
this somehow.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Jul 27, 2011 at 7:25 PM, Tucker j...@gmail.com wrote:
I don't recall having run that but it doesn't mean I didn't. I
believe the upgrade from beta1 to RC1 may have complained. It's
possible reran the upgrade script or, if it told me to run evolve
--hint --execute, I did. I'm almost positive I never rolled back to
a previous revision. Is it normal that the stored version and hinted
version were updated at identical times?
If there's anything potentially destructive you'd like me to try, to
assist in investigation, I can do this. This is my test server and my
production server won't be upgraded from beta1 until the next full
release.
On Wed, Jul 27, 2011 at 4:30 PM, Christian Hammond chip...@chipx86.com
wrote:
Okay, I suspect this is somehow due to you having at some point ran
evolve
--hint --execute. The Versions list shows a hint was applied, and I'd
be
interested in seeing what the contents of that was (it'll be mostly
giberish
though).
You do, however, appear to have migrations for the changes listed in
the
error. So that's confusing.
Do you remember ever running evolve --hint --execute? Did you at any
point
go back to a previous release/commit?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Jul 27, 2011 at 2:34 PM, Tucker j...@gmail.com wrote:
It actually is my address. It matches what used to be my @google.com
address.
* Started with 1.6RC1.
* Using MySQL
* Output of --hint
$ sudo rb-site manage /var/www/sites/reviews-dev evolve -- --hint
Password:
#- Evolution for accounts
from django_evolution.mutations import *
from django.db import models
MUTATIONS = [
AddField('Profile', 'is_private', models.BooleanField,
initial=False)
]
#--
#- Evolution for reviews
from django_evolution.mutations import *
from django.db import models
MUTATIONS = [
AddField('ReviewRequest', 'inactive_file_attachments',
models.ManyToManyField, related_model='attachments.FileAttachment'),
AddField('ReviewRequest', 'file_attachments',
models.ManyToManyField, related_model='attachments.FileAttachment'),
AddField('Review', 'file_attachment_comments',
models.ManyToManyField,
related_model='reviews.FileAttachmentComment'),
AddField('ReviewRequestDraft', 'inactive_file_attachments',
models.ManyToManyField, related_model='attachments.FileAttachment'),
AddField('ReviewRequestDraft', 'file_attachments',
models.ManyToManyField, related_model='attachments.FileAttachment')
]
#--
Trial evolution successful.
Run './manage.py evolve --hint --execute' to apply evolution.
* Dump attached
* Screenshots attached
* Python
Failed upgrade to RC2
Attempted an upgrade from RC1 to RC2. 1. easy_install -U ReviewBoard 2. easy_install -U RBTools 3. rb-site upgrade /var/www/sites/reviews-dev.zynga.com/ And this is where it broke: # rb-site upgrade /var/www/sites/reviews-dev.zynga.com/ Rebuilding directory structure Updating database. This may take a while. Creating tables ... There are unapplied evolutions for diffviewer. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. /usr/lib/python2.4/site-packages/pycrypto-2.3-py2.4-linux-x86_64.egg/Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken Unable to load SCMTool perforce = reviewboard.scmtools.perforce:PerforceTool: invalid syntax (perforce.py, line 155) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model reviews.ReviewRequest: Field 'inactive_file_attachments' has been added Field 'file_attachments' has been added In model reviews.Review: Field 'file_attachment_comments' has been added In model reviews.ReviewRequestDraft: Field 'inactive_file_attachments' has been added Field 'file_attachments' has been added In model accounts.Profile: Field 'is_private' has been added Error: Your models contain changes that Django Evolution cannot resolve automatically. I haven't run the evolve script at all, which was a question I saw come up in a similar thread. The host is running CentOS 5.2 and python2.4. This machine was originally running beta1 and was then upgraded to RC1, without a problem. It is a dev host, so there's a possibility that something was done to the machine that was unrelated but had an impact. -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Subversion post-commit not working
From the same directory, what does svn status say? The post-review script uses the same pathing concept as the svn command. Have to be in an active work space (which the response implies you aren't) and be in or above the location with active changes. On Jul 21, 2011 1:57 PM, David davidkazuh...@gmail.com wrote: I'm trying to get post-review to create a review for me from Subversion's post-commit script. However, no matter what options I pass, post-review tries svn info and obviously fails to detect a repository. I'm doing it from the server so there isn't any working copy on the server. For example post-review --username=user --password=password --submit-as=submitter - d RBTools 0.3.2 Home = /home/david svn info git rev-parse --git-dir The current directory does not contain a checkout from a supported source code repository. Even passing a diff file has the same result post-review --diff-filename=test.diff -d RBTools 0.3.2 Home = /home/david svn info git rev-parse --git-dir The current directory does not contain a checkout from a supported source code repository. What am I missing? I'm running from Ubuntu 10.04 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Query about LDAP authentication in reviewboard
Try dropping in the parentheses. I have this: LDAP Base DN: ou=People,dc=org,dc=com User Mask: uid=%s On Tue, Jul 19, 2011 at 2:59 PM, Akash Nawani akash.naw...@gmail.com wrote: Hi everybody! I wanted to use LDAP authentication for my reviewboard installation. I filled in following details in the settings-authentication page: LDAP server : ldap://myorg.com:389 LDAP Base DN : dc=myorg,dc=com E-mail LDAP attribute : mail User Mask : (uid=%s) But everytime it responds with an error message : Incorrect username or password. Can you please tell me if I'm providing wrong information and what should be the correct values. Thanks a lot in advance. -- Cheers, Aki -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-reviews: The requested URL could not be retrieved
You appear to have a DNS problem:
Unable to determine IP address from host name for server_name.
What does nslookup server_name say?
On Thu, Jun 9, 2011 at 7:12 PM, ptrchen ptrc...@gmail.com wrote:
Hi,
We've been trying to run post-review but have been running into a
requested URL could not be retrieved error
We're running:
ReviewBoard 1.5.5 on Windows XP
Python 2.5.x
Apache 2.2.x
Subversion 1.6.16, running on a sparc-solaris2.10
Here is the output after adding the --debug option:
--
post-review --server=server_name/rb_site --username= --
password= --revision-range=8325 --debug
RBTools 0.3.2
Home = C:\Documents and Settings\\Application Data
svn info
diff --version
repository info: Path: svn-server/ParentPath/RepoName, Base pa
th: /trunk, Supports changesets: False
HTTP GETting api/
Got HTTP error: 503: !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01
Transition
al//EN http://www.w3.org/TR/html4/loose.dtd;
HTMLHEADMETA HTTP-EQUIV=Content-Type CONTENT=text/html;
charset=iso-8859
-1
TITLEERROR: The requested URL could not be retrieved/TITLE
STYLE type=text/css!--BODY{background-color:#ff;font-
family:verdana,san
s-serif}PRE{font-family:sans-serif}--/STYLE
/HEADBODY
H2The requested URL could not be retrieved/H2
HR noshade size=1px
P
While trying to retrieve the URL:
A HREF=server_name/rb_site/api/server_name/rb_site/api//
A
P
The following error was encountered:
BLOCKQUOTE
Unable to determine IP address from host name for
Iserver_name/I
/BLOCKQUOTE
P
The dnsserver returned:
BLOCKQUOTE
Name Error: The domain name does not exist.
/BLOCKQUOTE
P
This means that:
PRE
The cache was not able to resolve the hostname presented in the URL.
Check if the address is correct.
--
Thanks!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: post-reviews: The requested URL could not be retrieved
Does the error actually only list the hostname and not the fully
qualified name? If so, that may be part of your problem (throwing out
guesses). Have you tried using the fully qualified name?
On Fri, Jun 10, 2011 at 11:22 AM, ptrchen ptrc...@gmail.com wrote:
Hi Tucker,
Thanks for the reply.
I ran nslookup server_name from both server_name (XP server) and
from a sparc-solaris2.10 machine.
Both return
Name: server_name.domain
Address: ip_address
On Jun 10, 11:15 am, Tucker j...@gmail.com wrote:
You appear to have a DNS problem:
Unable to determine IP address from host name for server_name.
What does nslookup server_name say?
On Thu, Jun 9, 2011 at 7:12 PM, ptrchen ptrc...@gmail.com wrote:
Hi,
We've been trying to run post-review but have been running into a
requested URL could not be retrieved error
We're running:
ReviewBoard 1.5.5 on Windows XP
Python 2.5.x
Apache 2.2.x
Subversion 1.6.16, running on a sparc-solaris2.10
Here is the output after adding the --debug option:
--
post-review --server=server_name/rb_site --username= --
password= --revision-range=8325 --debug
RBTools 0.3.2
Home = C:\Documents and Settings\\Application Data
svn info
diff --version
repository info: Path: svn-server/ParentPath/RepoName, Base pa
th: /trunk, Supports changesets: False
HTTP GETting api/
Got HTTP error: 503: !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01
Transition
al//EN http://www.w3.org/TR/html4/loose.dtd;
HTMLHEADMETA HTTP-EQUIV=Content-Type CONTENT=text/html;
charset=iso-8859
-1
TITLEERROR: The requested URL could not be retrieved/TITLE
STYLE type=text/css!--BODY{background-color:#ff;font-
family:verdana,san
s-serif}PRE{font-family:sans-serif}--/STYLE
/HEADBODY
H2The requested URL could not be retrieved/H2
HR noshade size=1px
P
While trying to retrieve the URL:
A HREF=server_name/rb_site/api/server_name/rb_site/api//
A
P
The following error was encountered:
BLOCKQUOTE
Unable to determine IP address from host name for
Iserver_name/I
/BLOCKQUOTE
P
The dnsserver returned:
BLOCKQUOTE
Name Error: The domain name does not exist.
/BLOCKQUOTE
P
This means that:
PRE
The cache was not able to resolve the hostname presented in the URL.
Check if the address is correct.
--
Thanks!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Access controls
I'm curious, what is your expected work flow? As, I assume, the submitter is also going to be the person who commits the change, how would the reviewer know when it is OK to mark a review closed? For my use, I would like to make a review unable to be Closed-Submitted without someone first having marked it Ship It! Marking something Closed-Discarded should be allowed without a Ship It! though. This is basically what I'm talking about: close: if reviewer: if discarded: pass elif approved and submitted: pass else: fail On Fri, Jun 3, 2011 at 2:28 AM, Madhavi madhavii.gu...@gmail.com wrote: Hi, We are using ReviewBoard 1.5.5 Currently, the submitter can close the generated review request. We want to control that. Submitter should not be able to close his/her own review requests. Only reviewers should be able to do so. Please let me know whether it is possible and if yes how can I achieve this? Regards -Madhavi -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Profile matching query error
I'm running RB1.6b2.1 and have been getting traceback emails. I
haven't had a chance to reproduce but I figured it wouldn't hurt to
try and send this out early. Has anyone seen this?
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/accounts/decorators.py,
line 25, in _check
return login_required(view_func)(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/djblets/auth/util.py,
line 46, in _checklogin
return view_func(request, *args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/reviews/views.py,
line 296, in review_detail
starred = review_request in \
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/contrib/auth/models.py,
line 383, in get_profile
self._profile_cache =
model._default_manager.using(self._state.db).get(user__id__exact=self.id)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/models/query.py,
line 348, in get
raise self.model.DoesNotExist(%s matching query does not exist.
DoesNotExist: Profile matching query does not exist.
ModPythonRequest
path:/r/3/,
GET:QueryDict: {},
POST:QueryDict: {},
COOKIES:{'rbsessionid': 'd8a08f65a3ed3e0c4e733b1a1f512a33'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': 0,
'CONTENT_TYPE': None,
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT':
'application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8',
'HTTP_CACHE_CONTROL': 'max-age=0',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'rbsessionid=d8a08f65a3ed3e0c4e733b1a1f512a33',
'HTTP_HOST': 'reviews.omitted.com',
'HTTP_REFERER': 'http://reviews.omitted.com/account/login/?next_page=/r/3/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_7)
AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.68
Safari/534.24',
'PATH_INFO': u'/r/3/',
'PATH_TRANSLATED': None,
'QUERY_STRING': None,
'REMOTE_ADDR': '10.6.241.148',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'GET',
'SCRIPT_NAME': '',
'SERVER_NAME': 'reviews.omitted.com',
'SERVER_PORT': 80,
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SOFTWARE': 'mod_python'}
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Profile matching query error
Using LDAP auth and anonymous access is disabled.
On Wed, May 25, 2011 at 12:37 PM, Christian Hammond chip...@chipx86.com wrote:
This may be a regression in 1.6 beta 2 caused by some of changes we made to
when profiles are created.
Can you tell me whether you have anonymous access turned on, and what
authentication method you use?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 25, 2011 at 12:35 PM, Tucker j...@gmail.com wrote:
I'm running RB1.6b2.1 and have been getting traceback emails. I
haven't had a chance to reproduce but I figured it wouldn't hurt to
try and send this out early. Has anyone seen this?
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/accounts/decorators.py,
line 25, in _check
return login_required(view_func)(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/djblets/auth/util.py,
line 46, in _checklogin
return view_func(request, *args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/reviews/views.py,
line 296, in review_detail
starred = review_request in \
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/contrib/auth/models.py,
line 383, in get_profile
self._profile_cache =
model._default_manager.using(self._state.db).get(user__id__exact=self.id)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/models/query.py,
line 348, in get
raise self.model.DoesNotExist(%s matching query does not exist.
DoesNotExist: Profile matching query does not exist.
ModPythonRequest
path:/r/3/,
GET:QueryDict: {},
POST:QueryDict: {},
COOKIES:{'rbsessionid': 'd8a08f65a3ed3e0c4e733b1a1f512a33'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': 0,
'CONTENT_TYPE': None,
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT':
'application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8',
'HTTP_CACHE_CONTROL': 'max-age=0',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'rbsessionid=d8a08f65a3ed3e0c4e733b1a1f512a33',
'HTTP_HOST': 'reviews.omitted.com',
'HTTP_REFERER':
'http://reviews.omitted.com/account/login/?next_page=/r/3/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_7)
AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.68
Safari/534.24',
'PATH_INFO': u'/r/3/',
'PATH_TRANSLATED': None,
'QUERY_STRING': None,
'REMOTE_ADDR': '10.6.241.148',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'GET',
'SCRIPT_NAME': '',
'SERVER_NAME': 'reviews.omitted.com',
'SERVER_PORT': 80,
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SOFTWARE': 'mod_python'}
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Profile matching query error
Not a problem. I'll do some tests and see if I can reproduce the
failure case. I'll get something opened today.
On Wed, May 25, 2011 at 12:42 PM, Christian Hammond chip...@chipx86.com wrote:
Okay thanks. Would you mind filing a bug so we can track it for 1.6?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 25, 2011 at 12:40 PM, Tucker j...@gmail.com wrote:
Using LDAP auth and anonymous access is disabled.
On Wed, May 25, 2011 at 12:37 PM, Christian Hammond chip...@chipx86.com
wrote:
This may be a regression in 1.6 beta 2 caused by some of changes we made
to
when profiles are created.
Can you tell me whether you have anonymous access turned on, and what
authentication method you use?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 25, 2011 at 12:35 PM, Tucker j...@gmail.com wrote:
I'm running RB1.6b2.1 and have been getting traceback emails. I
haven't had a chance to reproduce but I figured it wouldn't hurt to
try and send this out early. Has anyone seen this?
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/accounts/decorators.py,
line 25, in _check
return login_required(view_func)(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/djblets/auth/util.py,
line 46, in _checklogin
return view_func(request, *args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/reviews/views.py,
line 296, in review_detail
starred = review_request in \
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/contrib/auth/models.py,
line 383, in get_profile
self._profile_cache =
model._default_manager.using(self._state.db).get(user__id__exact=self.id)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/models/query.py,
line 348, in get
raise self.model.DoesNotExist(%s matching query does not exist.
DoesNotExist: Profile matching query does not exist.
ModPythonRequest
path:/r/3/,
GET:QueryDict: {},
POST:QueryDict: {},
COOKIES:{'rbsessionid': 'd8a08f65a3ed3e0c4e733b1a1f512a33'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': 0,
'CONTENT_TYPE': None,
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT':
'application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8',
'HTTP_CACHE_CONTROL': 'max-age=0',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'rbsessionid=d8a08f65a3ed3e0c4e733b1a1f512a33',
'HTTP_HOST': 'reviews.omitted.com',
'HTTP_REFERER':
'http://reviews.omitted.com/account/login/?next_page=/r/3/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_7)
AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.68
Safari/534.24',
'PATH_INFO': u'/r/3/',
'PATH_TRANSLATED': None,
'QUERY_STRING': None,
'REMOTE_ADDR': '10.6.241.148',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'GET',
'SCRIPT_NAME': '',
'SERVER_NAME': 'reviews.omitted.com',
'SERVER_PORT': 80,
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SOFTWARE': 'mod_python'}
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--tucker
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard
Re: Can't post subversion diff using post-review
There appears to have been an auth problem with my installation. Since this is still in testing, I blew it away and started over. I'll likely step through the same changes I made prior and see if I can nail down what caused the actual issue. If I figure it out, I'll post here so that there's an archive in case someone else sees the same problem. On Tue, May 17, 2011 at 11:19 PM, junk j...@gmail.com wrote: I'm working on a brand new instance of Review Board that I'd like to demo. I got Review Board 1.6 beta 2 up and running but I can't get post-review to work. The server is configured to use LDAP auth (working) and fastcgi. Here's the trace I'm getting when trying to run post-review: $ post-review -d -n RBTools 0.3.2 Home = /home/me svn info diff --version repository info: Path: https://svn.redacted/svn/ops, Base path: /sv, Supports changesets: False HTTP GETting api/ HTTP GETting http://reviews.redacted/api/info/ == HTTP Authentication Required Enter authorization information for Web API at reviews.redacted Username: me Password: Traceback (most recent call last): File /usr/bin/post-review, line 7, in ? sys.exit( File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/ rbtools/postreview.py, line 3741, in main File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/ rbtools/postreview.py, line 434, in check_api_version File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/ rbtools/postreview.py, line 876, in api_get File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/ rbtools/postreview.py, line 846, in http_get File /usr/lib64/python2.4/urllib2.py, line 130, in urlopen return _opener.open(url, data) File /usr/lib64/python2.4/urllib2.py, line 364, in open response = meth(req, response) File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/ rbtools/postreview.py, line 317, in http_response File /usr/lib64/python2.4/urllib2.py, line 396, in error result = self._call_chain(*args) File /usr/lib64/python2.4/urllib2.py, line 337, in _call_chain result = func(*args) File /usr/lib64/python2.4/urllib2.py, line 741, in http_error_401 host, req, headers) File /usr/lib64/python2.4/urllib2.py, line 720, in http_error_auth_reqed return self.retry_http_basic_auth(host, req, realm) File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/ rbtools/postreview.py, line 339, in retry_http_basic_auth File /usr/lib64/python2.4/urllib2.py, line 730, in retry_http_basic_auth return self.parent.open(req) File /usr/lib64/python2.4/urllib2.py, line 364, in open response = meth(req, response) File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/ rbtools/postreview.py, line 317, in http_response File /usr/lib64/python2.4/urllib2.py, line 396, in error result = self._call_chain(*args) File /usr/lib64/python2.4/urllib2.py, line 337, in _call_chain result = func(*args) File /usr/lib64/python2.4/urllib2.py, line 916, in http_error_401 host, req, headers) File /usr/lib64/python2.4/urllib2.py, line 807, in http_error_auth_reqed raise ValueError(AbstractDigestAuthHandler doesn't know ValueError: AbstractDigestAuthHandler doesn't know about Basic I've verified the username and password are correct but post-review doesn't seem to care. Enabling logging and profiling doesn't make a difference. Nothing showing in the httpd logs beyond the GET request for api/info/. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- --tucker -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
