Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49291/#review140069
---


Ship it!




Ship It!

- Sid Wagle


On June 29, 2016, 9:43 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49291/
> ---
> 
> (Updated June 29, 2016, 9:43 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Aravindan Vijayan, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-17455
> https://issues.apache.org/jira/browse/AMBARI-17455
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector 
> after upgrade to 2.4.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  153289e40cfe67bba0931548b282416de453a980 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  e029aea0e8f03a234907845b88339fbcc521bdbe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  0e4b4ebae0a9c00af41a0a619b3c3823183b3657 
> 
> Diff: https://reviews.apache.org/r/49291/diff/
> 
> 
> Testing
> ---
> 
> **1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [8.253s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.039s]
> [INFO] Ambari Web  SUCCESS [26.604s]
> [INFO] Ambari Views .. SUCCESS [1.359s]
> [INFO] Ambari Admin View . SUCCESS [7.969s]
> [INFO] ambari-metrics  SUCCESS [0.732s]
> [INFO] Ambari Metrics Common . SUCCESS [0.889s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.330s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.623s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.661s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.646s]
> [INFO] Ambari Metrics Collector .. SUCCESS [11.730s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.428s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.000s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:30.749s]
> [INFO] Ambari Server . SUCCESS [3:20.686s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.301s]
> [INFO] Ambari Agent .. SUCCESS [28.486s]
> [INFO] Ambari Client . SUCCESS [0.064s]
> [INFO] Ambari Python Client .. SUCCESS [1.076s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.448s]
> [INFO] Ambari Shell .. SUCCESS [0.046s]
> [INFO] Ambari Python Shell ... SUCCESS [0.814s]
> [INFO] Ambari Groovy Shell ... SUCCESS [1.108s]
> [INFO] ambari-logsearch .. SUCCESS [0.313s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.435s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.190s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [6.929s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.005s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.123s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:44.743s
> [INFO] Finished at: Tue Jun 28 12:49:06 PDT 2016
> [INFO] Final Memory: 326M/1346M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipPythonTests -Dtest=UpgradeCatalog240Test **
> 
> ---
>  T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.447 sec - 
> in org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> 
> Results :
> 
> Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 

Re: Review Request 49221: AMBARI-17221. Smart configs for Atlas to setup authentication as either LDAP or AD

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49221/#review140056
---


Ship it!




Ship It!

- Swapan Shridhar


On June 29, 2016, 9:56 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49221/
> ---
> 
> (Updated June 29, 2016, 9:56 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Abhay Kulkarni, Robert Levas, Swapan 
> Shridhar, and Suma Shivaprasad.
> 
> 
> Bugs: AMBARI-17221
> https://issues.apache.org/jira/browse/AMBARI-17221
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LDAP/AD authentication to Atlas was added in ATLAS-869. Ambari should support 
> Smart configs for Atlas to either use LDAP or AD.
> 
> Following configurations should be shown only when 
> "atlas.authentication.method.ldap.type" is set to "ldap":
> 
> * atlas.authentication.method.ldap.url=
> * atlas.authentication.method.ldap.userDNpattern=uid=
> * atlas.authentication.method.ldap.groupSearchBase=
> * atlas.authentication.method.ldap.groupSearchFilter=
> * atlas.authentication.method.ldap.groupRoleAttribute=cn
> * atlas.authentication.method.ldap.base.dn=
> * atlas.authentication.method.ldap.bind.dn=
> * atlas.authentication.method.ldap.bind.password=
> * atlas.authentication.method.ldap.referral=ignore
> * atlas.authentication.method.ldap.user.searchfilter=
> * atlas.authentication.method.ldap.default.role=ROLE_USER
> 
> Following configurations should be shown only when 
> "atlas.authentication.method.ldap.type" is set to "ad":
> 
> * atlas.authentication.method.ldap.ad.domain=
> * atlas.authentication.method.ldap.ad.url=
> * atlas.authentication.method.ldap.ad.base.dn=
> * atlas.authentication.method.ldap.ad.bind.dn=
> * atlas.authentication.method.ldap.ad.bind.password=
> * atlas.authentication.method.ldap.ad.referral=ignore
> * atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
> * atlas.authentication.method.ldap.ad.default.role=ROLE_USER
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  25df1c5 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> 9ff4090 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/themes/theme.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  f2f733d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  8b523d3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 3dcb426 
> 
> Diff: https://reviews.apache.org/r/49221/diff/
> 
> 
> Testing
> ---
> 
> Installed Atlas with HDP 2.5
> 
> Python unit tests passed.
> 
> ---
> Total run:1061
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 49221: AMBARI-17221. Smart configs for Atlas to setup authentication as either LDAP or AD

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49221/
---

(Updated June 29, 2016, 9:56 p.m.)


Review request for Ambari, Jaimin Jetly, Abhay Kulkarni, Robert Levas, Swapan 
Shridhar, and Suma Shivaprasad.


Summary (updated)
-

AMBARI-17221. Smart configs for Atlas to setup authentication as either LDAP or 
AD


Bugs: AMBARI-17221
https://issues.apache.org/jira/browse/AMBARI-17221


Repository: ambari


Description
---

LDAP/AD authentication to Atlas was added in ATLAS-869. Ambari should support 
Smart configs for Atlas to either use LDAP or AD.

Following configurations should be shown only when 
"atlas.authentication.method.ldap.type" is set to "ldap":

* atlas.authentication.method.ldap.url=
* atlas.authentication.method.ldap.userDNpattern=uid=
* atlas.authentication.method.ldap.groupSearchBase=
* atlas.authentication.method.ldap.groupSearchFilter=
* atlas.authentication.method.ldap.groupRoleAttribute=cn
* atlas.authentication.method.ldap.base.dn=
* atlas.authentication.method.ldap.bind.dn=
* atlas.authentication.method.ldap.bind.password=
* atlas.authentication.method.ldap.referral=ignore
* atlas.authentication.method.ldap.user.searchfilter=
* atlas.authentication.method.ldap.default.role=ROLE_USER

Following configurations should be shown only when 
"atlas.authentication.method.ldap.type" is set to "ad":

* atlas.authentication.method.ldap.ad.domain=
* atlas.authentication.method.ldap.ad.url=
* atlas.authentication.method.ldap.ad.base.dn=
* atlas.authentication.method.ldap.ad.bind.dn=
* atlas.authentication.method.ldap.ad.bind.password=
* atlas.authentication.method.ldap.ad.referral=ignore
* atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
* atlas.authentication.method.ldap.ad.default.role=ROLE_USER


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 25df1c5 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
9ff4090 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/themes/theme.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
 f2f733d 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 8b523d3 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
3dcb426 

Diff: https://reviews.apache.org/r/49221/diff/


Testing
---

Installed Atlas with HDP 2.5

Python unit tests passed.

---
Total run:1061
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49291/#review140054
---


Ship it!




Ship It!

- Sumit Mohanty


On June 29, 2016, 9:43 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49291/
> ---
> 
> (Updated June 29, 2016, 9:43 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Aravindan Vijayan, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-17455
> https://issues.apache.org/jira/browse/AMBARI-17455
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector 
> after upgrade to 2.4.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  153289e40cfe67bba0931548b282416de453a980 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  e029aea0e8f03a234907845b88339fbcc521bdbe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  0e4b4ebae0a9c00af41a0a619b3c3823183b3657 
> 
> Diff: https://reviews.apache.org/r/49291/diff/
> 
> 
> Testing
> ---
> 
> **1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [8.253s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.039s]
> [INFO] Ambari Web  SUCCESS [26.604s]
> [INFO] Ambari Views .. SUCCESS [1.359s]
> [INFO] Ambari Admin View . SUCCESS [7.969s]
> [INFO] ambari-metrics  SUCCESS [0.732s]
> [INFO] Ambari Metrics Common . SUCCESS [0.889s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.330s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.623s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.661s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.646s]
> [INFO] Ambari Metrics Collector .. SUCCESS [11.730s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.428s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.000s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:30.749s]
> [INFO] Ambari Server . SUCCESS [3:20.686s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.301s]
> [INFO] Ambari Agent .. SUCCESS [28.486s]
> [INFO] Ambari Client . SUCCESS [0.064s]
> [INFO] Ambari Python Client .. SUCCESS [1.076s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.448s]
> [INFO] Ambari Shell .. SUCCESS [0.046s]
> [INFO] Ambari Python Shell ... SUCCESS [0.814s]
> [INFO] Ambari Groovy Shell ... SUCCESS [1.108s]
> [INFO] ambari-logsearch .. SUCCESS [0.313s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.435s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.190s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [6.929s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.005s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.123s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:44.743s
> [INFO] Finished at: Tue Jun 28 12:49:06 PDT 2016
> [INFO] Final Memory: 326M/1346M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipPythonTests -Dtest=UpgradeCatalog240Test **
> 
> ---
>  T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.447 sec - 
> in org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> 
> Results :
> 
> Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49291/
---

(Updated June 29, 2016, 2:43 p.m.)


Review request for Ambari, Ajit Kumar, Aravindan Vijayan, Sumit Mohanty, and 
Sid Wagle.


Changes
---

Fixed CR comments. If both enabled and disabled components are empty in 
ambari.properties, disable everything.


Bugs: AMBARI-17455
https://issues.apache.org/jira/browse/AMBARI-17455


Repository: ambari


Description
---

AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after 
upgrade to 2.4.0


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 153289e40cfe67bba0931548b282416de453a980 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 e029aea0e8f03a234907845b88339fbcc521bdbe 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 0e4b4ebae0a9c00af41a0a619b3c3823183b3657 

Diff: https://reviews.apache.org/r/49291/diff/


Testing
---

**1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [8.253s]
[INFO] Apache Ambari Project POM . SUCCESS [0.039s]
[INFO] Ambari Web  SUCCESS [26.604s]
[INFO] Ambari Views .. SUCCESS [1.359s]
[INFO] Ambari Admin View . SUCCESS [7.969s]
[INFO] ambari-metrics  SUCCESS [0.732s]
[INFO] Ambari Metrics Common . SUCCESS [0.889s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.330s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.623s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.661s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.646s]
[INFO] Ambari Metrics Collector .. SUCCESS [11.730s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.428s]
[INFO] Ambari Metrics Grafana  SUCCESS [1.000s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:30.749s]
[INFO] Ambari Server . SUCCESS [3:20.686s]
[INFO] Ambari Functional Tests ... SUCCESS [1.301s]
[INFO] Ambari Agent .. SUCCESS [28.486s]
[INFO] Ambari Client . SUCCESS [0.064s]
[INFO] Ambari Python Client .. SUCCESS [1.076s]
[INFO] Ambari Groovy Client .. SUCCESS [2.448s]
[INFO] Ambari Shell .. SUCCESS [0.046s]
[INFO] Ambari Python Shell ... SUCCESS [0.814s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.108s]
[INFO] ambari-logsearch .. SUCCESS [0.313s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.435s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.190s]
[INFO] Ambari Logsearch Portal ... SUCCESS [6.929s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.005s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.123s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:44.743s
[INFO] Finished at: Tue Jun 28 12:49:06 PDT 2016
[INFO] Final Memory: 326M/1346M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=UpgradeCatalog240Test **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.upgrade.UpgradeCatalog240Test
Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.447 sec - 
in org.apache.ambari.server.upgrade.UpgradeCatalog240Test

Results :

Tests run: 28, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 39.379s
[INFO] Finished at: Tue Jun 28 13:04:18 PDT 2016
[INFO] Final Memory: 55M/908M
[INFO] 

** 3. Manual tests **

Installed a single node cluster with ambari 2.2.2 and upgraded it to ambari 
2.4.0 with the 

Re: Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49222/#review140052
---



Pushed to trunk, commit 278e442adf07bed539c842945607cae0968f1afe
branch-2.4, commit 8964b5a9b215408c40a4c8ea3073aa6de64540e7

- Alejandro Fernandez


On June 25, 2016, 1:27 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49222/
> ---
> 
> (Updated June 25, 2016, 1:27 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17436
> https://issues.apache.org/jira/browse/AMBARI-17436
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Description
> Add one new property to oozie-site.xml
> change permissions for the extension folders
> change the hive location from /apps/data-mirroring to 
> extensions-dir/mirroring/
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  6cb4089 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49222/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Review Request 49387: Support password type for custom properties

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49387/
---

Review request for Ambari, Alexandr Antonenko, Di Li, and Dmitro Lisnichenko.


Bugs: AMBARI-17041
https://issues.apache.org/jira/browse/AMBARI-17041


Repository: ambari


Description
---

Currently, services can define properties in the XML configuration files that 
is flagged as type password:
  
my.special.password

PASSWORD
Password to be masked
 
and it will be masked properly in the UI as well as blueprint.

Custom property should also support this option so that password can be added 
as custom property and treat accordingly.


==
Proposed Design for the fix:
==
At present only the key-value information of the service properties is stored 
in the DB ("clusterconfig" table in the "config_data" column). 
The "config_attributes" column stores only certain attributes like "final" 
indicating the list of properties set with the Final flag = true. 
The information about the property-type (i.e PASSWORD, USER, GROUP, 
ADDITIONAL_USER_PROPERTY, VALUE_FROM_PROPERTY_FILE, NOT_MANAGED_HDFS_PATH, etc) 
is extracted from the corresponding service's property file (e.g. 
hive-site.xml, core-site.xml, webhcat-env.xml, etc). These files contain 
information of the existing properties only. Custom Properties added by ambari 
user have no provision to store their additional attributes. 

Since, for this Jira we are concerned with only  attribute for 
Custom Properties, we could add an additional field called "Property Type" in 
the "Add Property" pop-up which shows up on clicking "Add Property ..." in the 
Custom property section for a service. For now, only 2 options are shown in the 
drop-down list: NONE and PASSWORD .
A few sample test properties are created using the new "Add Property" pop-up as 
can be seen in the following attachments. 
Attachments: 
"add_property_pop_up.tiff"
"custom_property_password_type.tiff"
"custom_property_regular_type.tiff"
"custom_properties_after_save.tiff"

The  information for these Custom properties is stored in the DB 
in "clusterconfig" table, "config_attributes" column.
The schema for "clusterconfig" table can be seen in the attachment:
"schema_of_clusterconfig_table.tiff"

The content of the "config_attributes" column with the  
information from the new Custom properties can be seen in the attachment:
"cluster_config_with_password_type_in_config_attributes_column.tiff"


Note: The fix so far is performed only for new Custom properties. The 
 information for existing properties is extracted from the 
corresponding property xml files for the service.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java
 eef3474 
  
ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 
84f3109 
  ambari-web/app/messages.js d40a84a 
  ambari-web/app/mixins/common/configs/configs_saver.js 43a77ce 
  ambari-web/app/models/configs/objects/service_config_property.js 73960b3 
  ambari-web/app/templates/common/configs/addPropertyWindow.hbs 659435c 
  ambari-web/app/utils/config.js a9cb5e9 
  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
bdd0530 
  ambari-web/test/mixins/common/configs/configs_saver_test.js 4baf303 

Diff: https://reviews.apache.org/r/49387/diff/


Testing
---

No new test cases are written in the patch apart from the fix required in 
"configs_saver_test.js" to avoid test failure of existing tests.
If the proposed solution is acceptable, I will create a new patch with the 
necessary new tests.

The existing ambari-web tests after applying the patch:

  28977 tests complete (37 seconds)
  154 tests pending


Thanks,

Keta Patel

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49324/#review140050
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 29, 2016, 8:49 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49324/
> ---
> 
> (Updated June 29, 2016, 8:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17352
> https://issues.apache.org/jira/browse/AMBARI-17352
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a new utility Python script that I would like to include as part of 
> the contrib project.
> 
> Ambari web UI runs host checks during host (ambari agent) registration. For 
> users that run blueprint install, it would be nice if Ambari ships with a 
> command line script that runs host checks and summarize the results.
> 
> 
> Diffs
> -
> 
>   contrib/utils/preinstall-check/src/main/python/preinstall_checker.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49324/diff/
> 
> 
> Testing
> ---
> 
> run python script against a cluster with only ambari server and agents 
> installed. the python script prints out the same check results as the UI on 
> the host registration page.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

[Di Li]

> On June 29, 2016, 6:48 p.m., Alejandro Fernandez wrote:
> >

Hello Alejandro,

Thanks for the review. I have renamed the non pythonic var name and added 
pydocstring as requested. 
The new patch is uploaded. Please review and let me know of any issues.

Di.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49324/#review140035
---


On June 29, 2016, 8:49 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49324/
> ---
> 
> (Updated June 29, 2016, 8:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17352
> https://issues.apache.org/jira/browse/AMBARI-17352
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a new utility Python script that I would like to include as part of 
> the contrib project.
> 
> Ambari web UI runs host checks during host (ambari agent) registration. For 
> users that run blueprint install, it would be nice if Ambari ships with a 
> command line script that runs host checks and summarize the results.
> 
> 
> Diffs
> -
> 
>   contrib/utils/preinstall-check/src/main/python/preinstall_checker.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49324/diff/
> 
> 
> Testing
> ---
> 
> run python script against a cluster with only ambari server and agents 
> installed. the python script prints out the same check results as the UI on 
> the host registration page.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49324/
---

(Updated June 29, 2016, 8:49 p.m.)


Review request for Ambari, Alejandro Fernandez and Yusaku Sako.


Bugs: AMBARI-17352
https://issues.apache.org/jira/browse/AMBARI-17352


Repository: ambari


Description
---

This is a new utility Python script that I would like to include as part of the 
contrib project.

Ambari web UI runs host checks during host (ambari agent) registration. For 
users that run blueprint install, it would be nice if Ambari ships with a 
command line script that runs host checks and summarize the results.


Diffs (updated)
-

  contrib/utils/preinstall-check/src/main/python/preinstall_checker.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/49324/diff/


Testing
---

run python script against a cluster with only ambari server and agents 
installed. the python script prints out the same check results as the UI on the 
host registration page.


Thanks,

Di Li

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49393/#review140043
---


Ship it!




Ship It!

- Di Li


On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49393/
> ---
> 
> (Updated June 29, 2016, 7:31 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-16785
> https://issues.apache.org/jira/browse/AMBARI-16785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The create url UI flags an error about minimum length required for URL name 
> being 2 characters even if the URL name specified is 2 characters long.
> The create url UI flags an error about maximum length allowed for URL name 
> being 25 characters when the length of the URL name specified is greater than 
> 20 characters long.
> The create/edit url UI flags an error about minimum length required for short 
> URL being 2 characters even if the short URL specified is 2 characters long.
> 
> This seems to be because the minimum length for URL name is set to 3 via 
> ng-minlength="3" instead of 2 as the error message indicates.
> Also, the maximum length for URL name is set to 20 via ng-maxlength="20" 
> instead of 25 as the error message indicates.
> Also, the minimum length for short URL is set to 3 via ng-minlength="3" 
> instead of 2 as the error message indicates.
> 
> Fix involves updating the html files with values that match the error message 
> displayed.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
> a01024d 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 
> 1d0ff8c 
> 
> Diff: https://reviews.apache.org/r/49393/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Ran mvn test.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 49393: Incorrect error message for view URL name and short URL validation

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49393/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-16785
https://issues.apache.org/jira/browse/AMBARI-16785


Repository: ambari


Description
---

The create url UI flags an error about minimum length required for URL name 
being 2 characters even if the URL name specified is 2 characters long.
The create url UI flags an error about maximum length allowed for URL name 
being 25 characters when the length of the URL name specified is greater than 
20 characters long.
The create/edit url UI flags an error about minimum length required for short 
URL being 2 characters even if the short URL specified is 2 characters long.

This seems to be because the minimum length for URL name is set to 3 via 
ng-minlength="3" instead of 2 as the error message indicates.
Also, the maximum length for URL name is set to 20 via ng-maxlength="20" 
instead of 25 as the error message indicates.
Also, the minimum length for short URL is set to 3 via ng-minlength="3" instead 
of 2 as the error message indicates.

Fix involves updating the html files with values that match the error message 
displayed.


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
a01024d 
  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 1d0ff8c 

Diff: https://reviews.apache.org/r/49393/diff/


Testing
---

Manual testing.
Ran mvn test.


Thanks,

Sangeeta Ravindran

Re: Review Request 49386: RU: 'Write Client configs' - step failed

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49386/#review140042
---


Ship it!




Ship It!

- Jonathan Hurley


On June 29, 2016, 1:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49386/
> ---
> 
> (Updated June 29, 2016, 1:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17485
> https://issues.apache.org/jira/browse/AMBARI-17485
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is just a case of a bad merge.  branch-2.4 did not bring over the 
> "import os" line for a couple of files.
> 
> However, trunk also has the "has_attr" bug, so that will get fixed there.  
> Also added tests.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 77228a9 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
>  bade06e 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
>  01940d7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  7b166ba 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 0083d75 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py 73615a4 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py a8e580a 
> 
> Diff: https://reviews.apache.org/r/49386/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> --
> Total run:1089
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 49362: Add additional parameters to hawq-site.xml

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49362/#review140036
---


Ship it!




Ship It!

- Alexander Denissov


On June 29, 2016, 10:04 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49362/
> ---
> 
> (Updated June 29, 2016, 10:04 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-17473
> https://issues.apache.org/jira/browse/AMBARI-17473
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add additional parameters to hawq-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  6e21d84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  1d27052 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> d7940a1 
> 
> Diff: https://reviews.apache.org/r/49362/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49324/#review140035
---




contrib/utils/preinstall-check/src/main/python/preinstall_checker.py (line 146)


Use pythonic_variable_names



contrib/utils/preinstall-check/src/main/python/preinstall_checker.py (line 267)


Please add PyDoc for longer functions



contrib/utils/preinstall-check/src/main/python/preinstall_checker.py (line 822)


python comments are double quoted inside the function


- Alejandro Fernandez


On June 28, 2016, 4:15 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49324/
> ---
> 
> (Updated June 28, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17352
> https://issues.apache.org/jira/browse/AMBARI-17352
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a new utility Python script that I would like to include as part of 
> the contrib project.
> 
> Ambari web UI runs host checks during host (ambari agent) registration. For 
> users that run blueprint install, it would be nice if Ambari ships with a 
> command line script that runs host checks and summarize the results.
> 
> 
> Diffs
> -
> 
>   contrib/utils/preinstall-check/src/main/python/preinstall_checker.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49324/diff/
> 
> 
> Testing
> ---
> 
> run python script against a cluster with only ambari server and agents 
> installed. the python script prints out the same check results as the UI on 
> the host registration page.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 49328: AMBARI-17465 - Management packs should be able to install extensions

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49328/#review140034
---




ambari-server/src/main/python/ambari_server/setupMpacks.py (line 326)


Please add some more comments for what this does.


- Alejandro Fernandez


On June 28, 2016, 5:11 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49328/
> ---
> 
> (Updated June 28, 2016, 5:11 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Mahadev Konar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17465
> https://issues.apache.org/jira/browse/AMBARI-17465
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently management packs (AMBARI-14854) can only add stacks and addon 
> services. Now that AMBARI-12885 has been resolved, the management packs 
> should be able to add extensions as well.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py e868f96 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 98811f5 
> 
> Diff: https://reviews.apache.org/r/49328/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> ambari-server install-mpack --mpack=/root/mpacks/my-extension-1.0.0.0.tar.gz 
> -v
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

[Alejandro Fernandez]

> On June 27, 2016, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java,
> >  line 288
> > 
> >
> > What's the root cause of more than 1k rows being returned?
> > RU/EU?
> 
> Daniel Gergely wrote:
> The number of returned lines is irrelevant here. The problem is the 
> number of parameters in the prepared statement. The query above has "task_id 
> IN ?1" part and "?1" is replaced with a collection. If that collection has 
> many elements, the prepared statement looks like "task_id IN 
> (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,...)". There is an upper limit 
> for the number of parameters on the sql server side. This was handled for 
> oracle only, but mssql has a limit as well, so it has no point to apply the 
> logic only for oracle, rather now it is configurable.
> The number of parameteres is high when stage summaries are being created 
> and cache is empty (e.g.: because of an earlier host removal or an ambari 
> server restart). That case all tasks are in the collection, so in the case of 
> a 200 nodes cluster the number of tasks can be over 2200. (mssql rejected the 
> request, because the upper limit for number of parameteres in this case was 
> 2100)
> 
> What does "RU/EU" mean?
> 
> Sebastian Toader wrote:
> RU - rolling upgrade, EU - express upgrade
> 
> Daniel Gergely wrote:
> I see. It is not related to upgrade process at all.

My point is that we need to know what actually made this request.
I understand why it is being segmented, but I'm curious if the caller is 
inefficient and actually queries sequential task_ids, in which case we can use 
task_id >= x and task_id <= y.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49265/#review139611
---


On June 27, 2016, 2:01 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49265/
> ---
> 
> (Updated June 27, 2016, 2:01 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17449
> https://issues.apache.org/jira/browse/AMBARI-17449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the case of a larger cluster, the number of host role commands can be high 
> (magnitude of thousands). Database servers usually have a limit on the number 
> of parameters, so reaching this limit causes a failure.
> Paging should be introduced to have only a smaller number of parameters in a 
> single query and do multiple queries to obtain the final result.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2eb0734 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/DaoUtils.java 
> 7f157ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  1768f21 
> 
> Diff: https://reviews.apache.org/r/49265/diff/
> 
> 
> Testing
> ---
> 
> Running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review140029
---




ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 (line 377)


Please use a constant at least and a code comment that it is currently 
hardcoded (including the file and line number on the backend side).

We should make it easier to change any hardcodings we introduce.


- Alejandro Fernandez


On June 28, 2016, 6:08 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> ---
> 
> (Updated June 28, 2016, 6:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
> https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> c633230 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  a4a38c1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  26e9c8b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/#review140027
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 27, 2016, 10:37 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49188/
> ---
> 
> (Updated June 27, 2016, 10:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-17419
> https://issues.apache.org/jira/browse/AMBARI-17419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trying do disable auto-start for ambari-server by executing update-rc.d 
> ambari-server disable is failing with update-rc.d: error: ambari-server 
> Default-Start contains no runlevels, aborting.
> 
> Added LSB to ambari-server and amabri-agent to define the default start and 
> stop levels
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent b2c3109 
>   ambari-server/sbin/ambari-server 72d94ed 
> 
> Diff: https://reviews.apache.org/r/49188/diff/
> 
> 
> Testing
> ---
> 
> Manual testing disabeling/enabling ambari-server via 'update-rc.d 
> ambari-server disable/enable'
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 49162: Update Zeppelin service definition

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review140026
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 203)


Use os.path.join



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 204)


Use a try except and always close the file in the finally block



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 144)


Just check for len > 0



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 148)


We should really give these default values right before the if-block to 
make sure if anyone refactors this code that these variables are always 
initialized


- Alejandro Fernandez


On June 28, 2016, 5:28 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 28, 2016, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  770f8f5 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49386: RU: 'Write Client configs' - step failed

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49386/#review140021
---


Ship it!




Thanks Nate!

- Alejandro Fernandez


On June 29, 2016, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49386/
> ---
> 
> (Updated June 29, 2016, 5:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17485
> https://issues.apache.org/jira/browse/AMBARI-17485
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is just a case of a bad merge.  branch-2.4 did not bring over the 
> "import os" line for a couple of files.
> 
> However, trunk also has the "has_attr" bug, so that will get fixed there.  
> Also added tests.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 77228a9 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
>  bade06e 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
>  01940d7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  7b166ba 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 0083d75 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py 73615a4 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py a8e580a 
> 
> Diff: https://reviews.apache.org/r/49386/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> --
> Total run:1089
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49385/
---

Review request for Ambari, Alexandr Antonenko and Andrii Tkach.


Bugs: AMBARI-17469
https://issues.apache.org/jira/browse/AMBARI-17469


Repository: ambari


Description
---

During Hive install, in the review page, the default value of 
hive_admin_database (MySQL) is concatenated to the selected database type, no 
matter which database is selected.  For e.g. if Existing PostgreSQL Database is 
selected as the Hive database, the review page displays the following for Hive 
database: 

Database : MySQL (Existing PostgreSQL Database)
 
In case of Oozie, because there is no oozie_admin_database property, a blank is 
displayed for database although an existing database was selected
 
Database :  
 
This seems to be because of the logic in the method that determines the 
database value to be displayed.
 
var dbFull = serviceConfigProperties.findProperty('name', 
serviceName.toLowerCase() + '_database'),
 db = serviceConfigProperties.findProperty('name', 
serviceName.toLowerCase() + '_ambari_database');
return db && dbFull ? db.value + ' (' + dbFull.value + ')' : '';

The value of hive_ambari_database returns MySQL and hence in case of Hive, 
MySQL always gets appended.
 
There is no oozie_ambari_database property defined. Hence db is undefined and 
an emtpy string is returned instead of the actual database type selected.
 
Fix involves changing the logic to not include the value of 
serviceName_ambari_database since it will not have the right value unless the 
default value is selected for Hive/Oozie database.


Diffs
-

  ambari-web/app/controllers/wizard/step8_controller.js 3971cf5 
  ambari-web/test/controllers/wizard/step8_test.js 74e042b 

Diff: https://reviews.apache.org/r/49385/diff/


Testing
---

Manual testing.
Added a test case to verify the value displayed for database.
Ran mvn test

28979 tests complete (48 seconds)
154 tests pending


Thanks,

Sangeeta Ravindran

Review Request 49386: RU: 'Write Client configs' - step failed

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49386/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-17485
https://issues.apache.org/jira/browse/AMBARI-17485


Repository: ambari


Description
---

This is just a case of a bad merge.  branch-2.4 did not bring over the "import 
os" line for a couple of files.

However, trunk also has the "has_attr" bug, so that will get fixed there.  Also 
added tests.


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
77228a9 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
 bade06e 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
 01940d7 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 7b166ba 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
0083d75 
  ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py 73615a4 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py a8e580a 

Diff: https://reviews.apache.org/r/49386/diff/


Testing
---

Manual.  Automated:

--
Total run:1089
Total errors:0
Total failures:0
OK


Thanks,

Nate Cole

Review Request 49383: Add a validation of required services during a blueprint deployment

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49383/
---

Review request for Ambari and Vitalyi Brodetskyi.


Repository: ambari


Description
---

Add a validation of required services during a blueprint deployment.  
Currently a blueprint deployment allows to install YARN without HDFS.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
 16f75ee 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 de5e2b3 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
 b85d454 

Diff: https://reviews.apache.org/r/49383/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49379: Hive2 view : port changes of following 10 bugs in hive2 view

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49379/#review139998
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On June 29, 2016, 2:46 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49379/
> ---
> 
> (Updated June 29, 2016, 2:46 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17480
> https://issues.apache.org/jira/browse/AMBARI-17480
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> port following change in hive2
> AMBARI-16266
> AMBARI-16424
> AMBARI-16425
> AMBARI-16422
> AMBARI-16726
> AMBARI-16675
> AMBARI-16429
> AMBARI-16242
> AMBARI-16418
> AMBARI-16428
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/persistence/DataStoreStorage.java
>  9adf129 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  4293b1b 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
>  975036e 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java
>  7a7f77c 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  59e969d 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java
>  6edc97c 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java
>  401ef48 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
>  fefacce 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  79c5482 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java
>  74cc060 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/json/JSONParser.java
>  772b6fd 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/xml/XMLParser.java
>  51671e5 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/file-upload.js
>  1bd8eee 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/upload-table.js
>  ef4df43 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/file-upload.js
>  1cd05ae 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  4f3261c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  cb267a0 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  b3630c1 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/history.js 
> 848bee8 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/job.js 
> 6cb4170 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  b7d9011 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/JsonParserTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/TableDataReaderTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/XMLParserTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49379/diff/
> 
> 
> Testing
> ---
> 
> added test cases and also manual testing where 

Re: Review Request 49379: Hive2 view : port changes of following 10 bugs in hive2 view

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49379/#review139995
---


Ship it!




Since these are pre approved changes.

- Ashwin Rajeev


On June 29, 2016, 2:46 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49379/
> ---
> 
> (Updated June 29, 2016, 2:46 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17480
> https://issues.apache.org/jira/browse/AMBARI-17480
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> port following change in hive2
> AMBARI-16266
> AMBARI-16424
> AMBARI-16425
> AMBARI-16422
> AMBARI-16726
> AMBARI-16675
> AMBARI-16429
> AMBARI-16242
> AMBARI-16418
> AMBARI-16428
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/persistence/DataStoreStorage.java
>  9adf129 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  4293b1b 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
>  975036e 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java
>  7a7f77c 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  59e969d 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java
>  6edc97c 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java
>  401ef48 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
>  fefacce 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  79c5482 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java
>  74cc060 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/json/JSONParser.java
>  772b6fd 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/xml/XMLParser.java
>  51671e5 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/file-upload.js
>  1bd8eee 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/upload-table.js
>  ef4df43 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/file-upload.js
>  1cd05ae 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  4f3261c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  cb267a0 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  b3630c1 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/history.js 
> 848bee8 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/job.js 
> 6cb4170 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  b7d9011 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/JsonParserTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/TableDataReaderTest.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/XMLParserTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49379/diff/
> 
> 
> Testing
> ---
> 
> added test cases and also 

Review Request 49379: Hive2 view : port changes of following 10 bugs in hive2 view

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49379/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17480
https://issues.apache.org/jira/browse/AMBARI-17480


Repository: ambari


Description
---

port following change in hive2
AMBARI-16266
AMBARI-16424
AMBARI-16425
AMBARI-16422
AMBARI-16726
AMBARI-16675
AMBARI-16429
AMBARI-16242
AMBARI-16418
AMBARI-16428


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/persistence/DataStoreStorage.java
 9adf129 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
 4293b1b 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
 975036e 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java
 7a7f77c 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
 59e969d 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java
 6edc97c 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java
 401ef48 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
 fefacce 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
 79c5482 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java
 74cc060 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/json/JSONParser.java
 772b6fd 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/xml/XMLParser.java
 51671e5 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/file-upload.js
 1bd8eee 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/upload-table.js
 ef4df43 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/file-upload.js
 1cd05ae 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
 PRE-CREATION 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js 
4f3261c 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 cb267a0 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js 
b3630c1 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/history.js 
848bee8 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/job.js 
6cb4170 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
8f60595 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
 PRE-CREATION 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 b7d9011 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/JsonParserTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/TableDataReaderTest.java
 PRE-CREATION 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/XMLParserTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49379/diff/


Testing
---

added test cases and also manual testing where required.


Thanks,

Nitiraj Rathore

Re: Review Request 49372: Ambari try to find old jdbc etc despite reset and resetuping with another DB

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49372/#review139989
---


Ship it!




Ship It!

- Dmytro Sen


On Июнь 29, 2016, 2:24 п.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49372/
> ---
> 
> (Updated Июнь 29, 2016, 2:24 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17475
> https://issues.apache.org/jira/browse/AMBARI-17475
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR: **172.22.85.22**  
> 1) Try to run deploy cluster on sles12  
> 2) Install ambari-server  
> 3) Try to setup ambari-server with mysql  
> Do not have mysql db (server etc ), in this case ambari-server start is 
> failed  
> 4) Try to start ambari-server . It is failed as mysql server and connector are
> absent.  
> 5) Make ambari server reset. Do not use DDL script as db was absent
> 
> 
> 
> 
> ambari-server reset -s
> 
> 
> 6) Try to setup ambari-server with another db ( PostgreSQL (Embedded) as
> example) - passed successfully
> 
> 
> 
> 
> nat-os-s12-mysql-slava7-5:~ # ambari-server setup   
> Using python  /usr/bin/python
> Setup ambari-server
> Checking SELinux...
> WARNING: Could not run /usr/sbin/sestatus: OK
> Customize user account for ambari-server daemon [y/n] (n)? 
> Adjusting ambari-server permissions and ownership...
> Checking firewall status...
> Checking JDK...
> Do you want to change Oracle JDK [y/n] (n)? 
> Completing setup...
> Configuring database...
> Enter advanced database configuration [y/n] (n)? y
> Configuring database...
> 
> ==
> Choose one of the following options:
> [1] - PostgreSQL (Embedded)
> [2] - Oracle
> [3] - MySQL / MariaDB
> [4] - PostgreSQL
> [5] - Microsoft SQL Server (Tech Preview)
> [6] - SQL Anywhere
> 
> ==
> Enter choice (3): 1
> Database name (ambaricustom): 
> Postgres schema (ambaricustom): 
> Username (ambaricustomuser): 
> Enter Database Password (bigdatacustom): 
> Default properties detected. Using built-in database.
> Configuring ambari database...
> Checking PostgreSQL...
> Running initdb: This may take up to a minute.
> About to start PostgreSQL
> Configuring local database...
> Connecting to local database...done.
> Configuring PostgreSQL...
> Restarting PostgreSQL
> Extracting system views...
> ..
> Adjusting ambari-server permissions and ownership...
> Ambari Server 'setup' completed successfully
> 
> 
> 7) Try to start ambari-server
> 
> **Actual result:**  
> Ambari try to find old DB conector etc despite reset and resetuping with
> another DB
> 
> 
> 
> 
> 23 Jun 2016 14:09:36,426 ERROR [main] DBAccessorImpl:107 - Error while 
> creating database accessor 
> java.lang.ClassNotFoundException: com.mysql.jdbc.Driver
>   at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:264)
>   at 
> org.apache.ambari.server.orm.DBAccessorImpl.(DBAccessorImpl.java:85)
>   at 
> org.apache.ambari.server.orm.DBAccessorImpl$$FastClassByGuice$$86dbc63e.newInstance()
>   at 
> com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
>   at 
> com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60)
>   at 
> com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
>   at 
> com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
>   at com.google.inject.internal.FactoryProxy.get(FactoryProxy.java:54)
>   at 
> com.google.inject.internal.SingleFieldInjector.inject(SingleFieldInjector.java:53)
>   at 
> com.google.inject.internal.MembersInjectorImpl.injectMembers(MembersInjectorImpl.java:110)
>   at 
> com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:94)
>   at 
> com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
>   at 
> 

Re: Review Request 49309: AMBARI-17462 Install Log search client package with Ranger Service

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49309/
---

(Updated June 29, 2016, 1:11 p.m.)


Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Gautam Borad, 
Oliver Szabo, Srimanth Gunturi, and Velmurugan Periasamy.


Changes
---

Updated Alejandro Fernandez comment


Bugs: AMBARI-17462
https://issues.apache.org/jira/browse/AMBARI-17462


Repository: ambari


Description
---

>From Ambari installation, install Log search client package with Ranger 
>Service for stack 2.5 onwards


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 e708843 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 6367281 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 23bb764 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 9b2ef3f 

Diff: https://reviews.apache.org/r/49309/diff/


Testing
---

Running tests for stack:2.5 service:RANGER
test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok
test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok
test_start_default (test_ranger_admin.TestRangerAdmin) ... ok
test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok
test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok
test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok
test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok
test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok
test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok
test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok
test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok
test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok
test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok

--
Ran 13 tests in 0.330s

OK


Thanks,

Mugdha Varadkar

Re: Review Request 49362: Add additional parameters to hawq-site.xml

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49362/#review139977
---


Ship it!




Ship It!

- Lav Jain


On June 29, 2016, 10:04 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49362/
> ---
> 
> (Updated June 29, 2016, 10:04 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-17473
> https://issues.apache.org/jira/browse/AMBARI-17473
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add additional parameters to hawq-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  6e21d84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  1d27052 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> d7940a1 
> 
> Diff: https://reviews.apache.org/r/49362/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 49260: Update desired states in case of service restarts

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49260/#review139973
---


Ship it!




Ship It!

- Sandor Magyari


On June 29, 2016, 9:10 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49260/
> ---
> 
> (Updated June 29, 2016, 9:10 a.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-17313
> https://issues.apache.org/jira/browse/AMBARI-17313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> In case services / components are restarted, their desired states are not 
> changed. As during restart -per definition- services are expected to be in 
> STARTED state this should be OK, however if the restart is triggered for 
> services in STOPPED state this causes problems (The UI allows triggering 
> restart for stopped services). (Eg.: recovery manager doesn't bring them back 
> to running state)
> 
> Solution:
> When assembling the RESTART custom command desired states of affected 
> services are updated to STARTED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b60592d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  68b31c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  fd70df5 
> 
> Diff: https://reviews.apache.org/r/49260/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on dev-env.
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 49162: Update Zeppelin service definition

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review139970
---


Ship it!




Ship It!

- Prabhjyot Singh


On June 28, 2016, 5:28 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 28, 2016, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  770f8f5 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?
> 
> Akhil PB wrote:
> queues.hbs has id="versions-table-wrap" and css also (line:217 in 
> application.less).
> versionPanel.hbs has class="versions-table-wrap" and css are defined at 
> line:1259.
> So the new changes would not break old code.
> 
> Sreenath Somarajapuram wrote:
> Well, as-per your patch there are only 1252 line in application.less!
> 
> Akhil PB wrote:
> line:1239 has css for versionPanel, but not complete. This would not 
> break old UI since there is seperate css at line:216.

class "versions-table-wrap" is not used as of now.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 49309: AMBARI-17462 Install Log search client package with Ranger Service

[Mugdha Varadkar]

> On June 29, 2016, 12:01 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 277
> > 
> >
> > Should assign a default value since can still be None.

@Alejandro Fernandez This has been already committed. I have attached the patch 
AMBARI-17462.1.patch on https://issues.apache.org/jira/browse/AMBARI-17462. 
Please review attached patch on Jira. Thanks


> On June 29, 2016, 12:01 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 279
> > 
> >
> > Shouldn't access index 1 without first checking the length

Same as above


> On June 29, 2016, 12:01 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 284
> > 
> >
> > this is equivalent to just custom_log4j = has_logsearch

Same as above


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49309/#review139904
---


On June 28, 2016, 11:47 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49309/
> ---
> 
> (Updated June 28, 2016, 11:47 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Gautam 
> Borad, Oliver Szabo, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17462
> https://issues.apache.org/jira/browse/AMBARI-17462
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From Ambari installation, install Log search client package with Ranger 
> Service for stack 2.5 onwards
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c46309e 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  ecc4f49 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  bab65dc 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml 
> 40ad69f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  817d3f7 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  f48720c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e1b5bc5 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jass_conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  eff0cd2 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> adfb8ff 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  789c5ba 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 
> 9b3c631 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 
> 53da262 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
> 14571bd 
> 
> Diff: https://reviews.apache.org/r/49309/diff/
> 
> 
> Testing
> ---
> 
> Running tests for stack:2.5 service:RANGER
> test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok
> test_start_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok
> test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok
> test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok
> test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok
> test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok
> 
> --
> Ran 13 tests in 0.330s
> 
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/#review139961
---


Ship it!




Ship It!

- Andrew Onischuk


On June 27, 2016, 10:37 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49188/
> ---
> 
> (Updated June 27, 2016, 10:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-17419
> https://issues.apache.org/jira/browse/AMBARI-17419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trying do disable auto-start for ambari-server by executing update-rc.d 
> ambari-server disable is failing with update-rc.d: error: ambari-server 
> Default-Start contains no runlevels, aborting.
> 
> Added LSB to ambari-server and amabri-agent to define the default start and 
> stop levels
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent b2c3109 
>   ambari-server/sbin/ambari-server 72d94ed 
> 
> Diff: https://reviews.apache.org/r/49188/diff/
> 
> 
> Testing
> ---
> 
> Manual testing disabeling/enabling ambari-server via 'update-rc.d 
> ambari-server disable/enable'
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 49260: Update desired states in case of service restarts

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49260/
---

(Updated June 29, 2016, 9:10 a.m.)


Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, and 
Sandor Magyari.


Bugs: AMBARI-17313
https://issues.apache.org/jira/browse/AMBARI-17313


Repository: ambari


Description
---

Problem:
In case services / components are restarted, their desired states are not 
changed. As during restart -per definition- services are expected to be in 
STARTED state this should be OK, however if the restart is triggered for 
services in STOPPED state this causes problems (The UI allows triggering 
restart for stopped services). (Eg.: recovery manager doesn't bring them back 
to running state)

Solution:
When assembling the RESTART custom command desired states of affected services 
are updated to STARTED.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b60592d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 68b31c0 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 fd70df5 

Diff: https://reviews.apache.org/r/49260/diff/


Testing (updated)
---

Manually tested on dev-env.

Unit tests passed.


Thanks,

Laszlo Puskas

Re: Review Request 49260: Update desired states in case of service restarts

[Laszlo Puskas]

> On June 29, 2016, 1:20 a.m., Sumit Mohanty wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java,
> >  line 20
> > 
> >
> > Are changes to this file purely refactoring or addition of new tests? 
> > If its just refactoring then lets do it in trunk or branch-2.4 only.

As the initial code change was in the AmbariCustomCommandExecutionHelper i 
thougth this test class needs to be modified / extended with new tests. As it 
was easier / quicker to add assertions to the existing test i gave up adding a 
new test here, but i have already removed mockito dependencies and used 
easymock instead (afaik easymock is what we use for testing)


> On June 29, 2016, 1:20 a.m., Sumit Mohanty wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java,
> >  line 324
> > 
> >
> > Any reason the verify construct was removed?

I have changed the test framework from Mockito to EasyMock. The test "logic" 
didn't change at all.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49260/#review139909
---


On June 28, 2016, 2:09 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49260/
> ---
> 
> (Updated June 28, 2016, 2:09 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-17313
> https://issues.apache.org/jira/browse/AMBARI-17313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> In case services / components are restarted, their desired states are not 
> changed. As during restart -per definition- services are expected to be in 
> STARTED state this should be OK, however if the restart is triggered for 
> services in STOPPED state this causes problems (The UI allows triggering 
> restart for stopped services). (Eg.: recovery manager doesn't bring them back 
> to running state)
> 
> Solution:
> When assembling the RESTART custom command desired states of affected 
> services are updated to STARTED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b60592d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  68b31c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  fd70df5 
> 
> Diff: https://reviews.apache.org/r/49260/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on dev-env.
> 
> Unit tests running 
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?
> 
> Akhil PB wrote:
> queues.hbs has id="versions-table-wrap" and css also (line:217 in 
> application.less).
> versionPanel.hbs has class="versions-table-wrap" and css are defined at 
> line:1259.
> So the new changes would not break old code.
> 
> Sreenath Somarajapuram wrote:
> Well, as-per your patch there are only 1252 line in application.less!

line:1239 has css for versionPanel, but not complete. This would not break old 
UI since there is seperate css at line:216.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> 

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Sreenath Somarajapuram]

> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?
> 
> Akhil PB wrote:
> queues.hbs has id="versions-table-wrap" and css also (line:217 in 
> application.less).
> versionPanel.hbs has class="versions-table-wrap" and css are defined at 
> line:1259.
> So the new changes would not break old code.

Well, as-per your patch there are only 1252 line in application.less!


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> 

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

[Mugdha Varadkar]

> On June 28, 2016, 12:53 p.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py,
> >  line 348
> > 
> >
> > Is `keyadmin` a hardcoded username on the server-side of this URL, or 
> > is this configurable?  Should `keyadmin` be a variable instead?

keyadmin is hardcoded username on server-side


> On June 28, 2016, 12:53 p.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py,
> >  line 377
> > 
> >
> > Is `keyadmin` a hardcoded username on the server-side of this URL, or 
> > is this configurable?  Should `keyadmin` be a variable instead?

same as above


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review139773
---


On June 28, 2016, 6:08 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> ---
> 
> (Updated June 28, 2016, 6:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
> https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> c633230 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  a4a38c1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  26e9c8b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?

queues.hbs has id="versions-table-wrap" and css also (line:217 in 
application.less).
versionPanel.hbs has class="versions-table-wrap" and css are defined at 
line:1259.
So the new changes would not break old code.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> 

Re: Review Request 49332: Use root/sudoer user for Logfeeder

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49332/#review139953
---


Ship it!




Ship It!

- Miklos Gergely


On June 28, 2016, 6:54 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49332/
> ---
> 
> (Updated June 28, 2016, 6:54 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Miklos Gergely, Robert Nettleton, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17170
> https://issues.apache.org/jira/browse/AMBARI-17170
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use root/sudoer user for Logfeeder -> in the near future we will read 
> /var/logs/messages and /var/log/secure too so its needed anyway.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  9a6f32c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  7920f4d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
>  e92db10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  7ac57ad 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  c41d2b8 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 63afcac 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json f57f26d 
>   ambari-web/app/data/HDP2/site_properties.js 28cc4e8 
> 
> Diff: https://reviews.apache.org/r/49332/diff/
> 
> 
> Testing
> ---
> 
> FT: 4 node secure/unsecure cluster
> 
> UT:
> Total run:1086
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49256: Upload table- data after upload different from data shown in preview

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49256/#review139944
---


Ship it!




Ship It!

- Gaurav Nagar


On June 27, 2016, 9:49 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49256/
> ---
> 
> (Updated June 27, 2016, 9:49 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17421
> https://issues.apache.org/jira/browse/AMBARI-17421
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ealier user defined delimiters in CSV were not supported : 
> In this patch : 
> Following support has been added to upload feature.
> 1. when "File type" is selected there will be a settings button which can be 
> clicked to open following CSV specific configurations
> Column delimiter: select from dropdown : printable and non printable ascii 
> characters supported.
> Escape Character: select from dropdown : printable and non printable ascii 
> characters supported.
> Quote Character: select from dropdown : printable and non printable ascii 
> characters supported.
> Is first row header ?: checkbox to specify if the first row of CSV is header
> 2. when "Stored As" is TEXTFILE the setting button next to it will be enabled 
> for further settings
> Fields Terminated By: the field terminator for hive table
> Escape By: the escape character for hive table.
> 3. When "Stored As" is not TEXTFILE a field called "Contains endlines?" will 
> be visible.
> User has to check this field if the they field values contains endline (\n) 
> characters. If this is checked the temporary table is created with Hex 
> encoding of fields with datatype STRING, VARCHAR and CHAR to preserve endline 
> characters properly. If user does not select this and fields contain endline 
> characters then behaviour of upload is unexpected. Endline characters are not 
> supported in TEXTFILE hive storage type.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive/pom.xml 444cd98 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
>  5164a4d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  a540ca0 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java
>  2e5f0f7 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/CSVParams.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/TableDataReader.java
>  e9bdb92 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/TableInput.java
>  f7fbbba 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadFromHdfsInput.java
>  14bd27a 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  ad10751 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java
>  d03dd7e 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java
>  8b75c04 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseOptions.java
>  e592b5f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
>  49f47c7 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/RowIterator.java
>  69fe864 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVIterator.java
>  3342f49 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java
>  a48041c 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/commonscsv/CSVIterator.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/commonscsv/CSVParser.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/opencsv/OpenCSVIterator.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/opencsv/OpenCSVParser.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/InsertFromQueryInput.java
>  5befc51 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/QueryGenerator.java
>  6bab229 
>   
>