date:20170504

Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-04 Thread Anita Jebaraj



> On May 5, 2017, 5:10 a.m., belliraj hb wrote:
> > Ship It!

can you please help in pushing the changes, thanks in advance


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review174001
---


On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 4, 2017, 7:09 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-04 Thread Jayush Luniya



> On May 4, 2017, 7:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 221 (patched)
> > 
> >
> > We should use stack_root and avoid harcoding HDP or HDF.
> 
> Vishal Suvagia wrote:
> Hi Alejandro,
> As Nifi will be an HDP add-on service, and bits for Nifi will 
> be installed under path /usr/hdf/{stack-version} from HDF repos even in an 
> HDP stack cluster. So to differentiate between HDF(for Nifi) and HDP, we will 
> need to keep the stack-checks.

Can you pass cred_lib_path_override and cred_setup_prefix_override parameters 
to this function and in NIFI pass these parameters explicit;y. That way we can 
get rid of both the hardcodings.
if service_name == 'nifi': 
 AND
if stack_name == 'HDP':  

Let NIFI explicitly handle this in their service definition and pass in the 
override parameters, instead of the utility function in resource_management 
library having these hardcodings.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
---


On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> ---
> 
> (Updated May 4, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support to enable Ranger Nifi plugin.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  661089a 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  87fccbe 
> 
> 
> Diff: https://reviews.apache.org/r/58995/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-04 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review174001
---


Ship it!




Ship It!

- belliraj hb


On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 4, 2017, 7:09 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-04 Thread Vishal Suvagia via Review Board



> On May 4, 2017, 7:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 221 (patched)
> > 
> >
> > We should use stack_root and avoid harcoding HDP or HDF.

Hi Alejandro,
As Nifi will be an HDP add-on service, and bits for Nifi will be 
installed under path /usr/hdf/{stack-version} from HDF repos even in an HDP 
stack cluster. So to differentiate between HDF(for Nifi) and HDP, we will need 
to keep the stack-checks.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
---


On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> ---
> 
> (Updated May 4, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support to enable Ranger Nifi plugin.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  661089a 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  87fccbe 
> 
> 
> Diff: https://reviews.apache.org/r/58995/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread venkat sairam



> On May 4, 2017, 4:49 p.m., Yusaku Sako wrote:
> > contrib/views/files/pom.xml
> > Lines 183 (patched)
> > 
> >
> > I tested the patch locally.  
> > 
> > This is a general comment that applies to all pom.xml file changes.
> > We can't have two arguments tags here like this, because the last one 
> > will overwrite the first one.  So essentially, yarn is being run with "yarn 
> > --ignore-engines".
> > 
> > Also, --pure-lockfile argument is missing in this particular pom.xml.

The --pure-lockfile argument is present in files/pom.xml and the arguments tag 
have been fixed in the similar manner how other tags are written.


- venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173924
---


On May 5, 2017, 3:42 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> ---
> 
> (Updated May 5, 2017, 3:42 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> npm package manager have been replaced with yarn manager and front-end 
> plugins, node versions have been updated as per the requirements.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/pom.xml 181deb4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
>   contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock 
> PRE-CREATION 
>   contrib/views/files/pom.xml 8e691b1 
>   contrib/views/files/src/main/resources/ui/package.json 24da458 
>   contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hawq/pom.xml e4ed54a 
>   contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hive-next/pom.xml a1e116d 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock 
> PRE-CREATION 
>   contrib/views/hive/pom.xml de83dbc 
>   contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
>   contrib/views/hueambarimigration/pom.xml f7a42dd 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
>  64b3270 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
>  PRE-CREATION 
>   contrib/views/jobs/pom.xml a8f44f3 
>   contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/pig/pom.xml cf2ed37 
>   contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
>   contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
>   contrib/views/pom.xml 0a1a77f 
>   contrib/views/wfmanager/pom.xml bcb9572 
>   contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
>   contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
>   pom.xml db3d457 
> 
> 
> Diff: https://reviews.apache.org/r/58984/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread venkat sairam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/
---

(Updated May 5, 2017, 3:42 a.m.)


Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-20928
https://issues.apache.org/jira/browse/AMBARI-20928


Repository: ambari


Description
---

npm package manager have been replaced with yarn manager and front-end plugins, 
node versions have been updated as per the requirements.


Diffs (updated)
-

  contrib/views/capacity-scheduler/pom.xml 181deb4 
  contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
  contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/files/pom.xml 8e691b1 
  contrib/views/files/src/main/resources/ui/package.json 24da458 
  contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hawq/pom.xml e4ed54a 
  contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hive-next/pom.xml a1e116d 
  contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hive/pom.xml de83dbc 
  contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hueambarimigration/pom.xml f7a42dd 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
 64b3270 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
 PRE-CREATION 
  contrib/views/jobs/pom.xml a8f44f3 
  contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/pig/pom.xml cf2ed37 
  contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
  contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
  contrib/views/pom.xml 0a1a77f 
  contrib/views/wfmanager/pom.xml bcb9572 
  contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
  contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
  pom.xml db3d457 


Diff: https://reviews.apache.org/r/58984/diff/2/

Changes: https://reviews.apache.org/r/58984/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 59004: HDP 3.0 TP - create service definition for Kafka with configs, kerberos, widgets, etc

2017-05-04 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59004/#review173962
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 4, 2017, 9:21 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59004/
> ---
> 
> (Updated May 4, 2017, 9:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20939
> https://issues.apache.org/jira/browse/AMBARI-20939
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka_client_jaas_conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka_jaas_conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metrics.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka_broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/utils.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/input.config-kafka.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/kafka.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/kafka_client_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/kafka_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/tools-log4j.properties.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/widgets.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/KAFKA/metainfo.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59004/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 59004: HDP 3.0 TP - create service definition for Kafka with configs, kerberos, widgets, etc

2017-05-04 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59004/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-20939
https://issues.apache.org/jira/browse/AMBARI-20939


Repository: ambari


Description
---

.


Diffs
-

  ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-broker.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka_client_jaas_conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka_jaas_conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-audit.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-plugin-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-policymgr-ssl.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/ranger-kafka-security.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/kerberos.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metrics.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka_broker.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/upgrade.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/utils.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/input.config-kafka.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/kafka.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/kafka_client_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/kafka_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/templates/tools-log4j.properties.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/widgets.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/3.0/services/KAFKA/metainfo.xml 
PRE-CREATION 


Diff: https://reviews.apache.org/r/59004/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-04 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
---




ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
Lines 221 (patched)


We should use stack_root and avoid harcoding HDP or HDF.


- Alejandro Fernandez


On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> ---
> 
> (Updated May 4, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support to enable Ranger Nifi plugin.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  661089a 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  87fccbe 
> 
> 
> Diff: https://reviews.apache.org/r/58995/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

2017-05-04 Thread Robert Levas



> On May 3, 2017, 2:54 p.m., Robert Levas wrote:
> > Ship It!
> 
> Anita Jebaraj wrote:
> Thank you Robert, please help in pushing the changes

Committed to trunk
```
commit 7cc5e9e220b82052256a352f0e65323f2b1bc962
Author: Anita Jebaraj 
Date:   Thu May 4 15:43:33 2017 -0400
```

Committed to branch-2.5
```
commit f8f8aad230c574d8bcdb971ea59900a8dc7a
Author: Anita Jebaraj 
Date:   Thu May 4 15:45:37 2017 -0400
```


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173790
---


On May 3, 2017, 2:24 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 2:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/2/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> File Attachments
> 
> 
> Ambari-20909-Branch2.5.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/03/3899b0bb-110a-449b-a401-4ba0576957fc__AMBARI-20909-Branch2.5.patch
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58993: AMBARI-20930 : stackadvisor recommendations for atlas hooks should be disabled for external Atlas

2017-05-04 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58993/#review173949
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py
Lines 235 (patched)


This should also be included in Hive's Service Advisor for 3.0


- Alejandro Fernandez


On May 4, 2017, 2:29 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58993/
> ---
> 
> (Updated May 4, 2017, 2:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20930
> https://issues.apache.org/jira/browse/AMBARI-20930
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In cases where Atlas is not setup on the cluster but the Atlas hooks are 
> enabled for external Atlas.
> Ambari recommendations show to disable the Atlas hooks.
> This behaviour needs to be changed to support externally used Atlas service.
> 
> PS: Attached patch is for trunk, patch for branch-2.5 is attached to 
> AMBARI-20930 Apache JIRA.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> eb7389d 
> 
> 
> Diff: https://reviews.apache.org/r/58993/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

2017-05-04 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/#review173947
---




ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
Line 344 (original)


I thought Ranger had to be upgraded before HDFS due to the plugins.


- Alejandro Fernandez


On May 4, 2017, 1:36 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58989/
> ---
> 
> (Updated May 4, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20779
> https://issues.apache.org/jira/browse/AMBARI-20779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need 
> to upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set 
> to true, WebHDFS RESTAPI tries to create audit directory in HDFS this will 
> fail RANGER-KMS restart task during upgrade as HDFS service will not be 
> started.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  e111dbf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  6230921 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  47a7094 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  18c0c15 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 19031a8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 8cfaa52 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> f7192ae 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> d98bb53 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  5120740 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  358fb6e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  368bbe2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 80436bf 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> ad9ae33 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 1eb9836 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml 
> c180b61 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  3ceea8f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  c3436b9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> f3b1fa6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 0470b7a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml 
> f923702 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  a74d085 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 35d3da2 
> 
> 
> Diff: https://reviews.apache.org/r/58989/diff/1/
> 
> 
> Testing
> ---
> 
> Tested EU upgrade to stack 2.6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367

2017-05-04 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58983/#review173946
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 4, 2017, 6:21 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58983/
> ---
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20929
> https://issues.apache.org/jira/browse/AMBARI-20929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After ZEPPELIN-2367 there are configuration parameter changes that required 
> to make user impersonation for JDBC interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  c2f816399b 
> 
> 
> Diff: https://reviews.apache.org/r/58983/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on Cent6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-04 Thread Anita Jebaraj



> On May 3, 2017, 10:30 a.m., belliraj hb wrote:
> > I guess "clear filter" takes lot of space. I think clear filter should be a 
> > simpler icon (may be a X) and it should be before refresh.

Thank you for the comments, I have updated the icon, please review the new patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review173719
---


On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 4, 2017, 7:09 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-04 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review173941
---


Ship it!




Ship It!

- Di Li


On May 1, 2017, 10:15 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 1, 2017, 10:15 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread Yusaku Sako


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173924
---



In all the pom.xml's, there are two


contrib/views/files/pom.xml
Lines 183 (patched)


I tested the patch locally.  

This is a general comment that applies to all pom.xml file changes.
We can't have two arguments tags here like this, because the last one will 
overwrite the first one.  So essentially, yarn is being run with "yarn 
--ignore-engines".

Also, --pure-lockfile argument is missing in this particular pom.xml.


- Yusaku Sako


On May 4, 2017, 6:36 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> ---
> 
> (Updated May 4, 2017, 6:36 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> npm package manager have been replaced with yarn manager and front-end 
> plugins, node versions have been updated as per the requirements.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/pom.xml 181deb4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
>   contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock 
> PRE-CREATION 
>   contrib/views/files/pom.xml 8e691b1 
>   contrib/views/files/src/main/resources/ui/package.json 24da458 
>   contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hawq/pom.xml e4ed54a 
>   contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hive-next/pom.xml a1e116d 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock 
> PRE-CREATION 
>   contrib/views/hive/pom.xml de83dbc 
>   contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
>   contrib/views/hueambarimigration/pom.xml f7a42dd 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
>  64b3270 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
>  PRE-CREATION 
>   contrib/views/jobs/pom.xml a8f44f3 
>   contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/pig/pom.xml cf2ed37 
>   contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
>   contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
>   contrib/views/pom.xml 0a1a77f 
>   contrib/views/wfmanager/pom.xml bcb9572 
>   contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
>   contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
>   pom.xml db3d457 
> 
> 
> Diff: https://reviews.apache.org/r/58984/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-04 Thread Vishal Suvagia via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-20932
https://issues.apache.org/jira/browse/AMBARI-20932


Repository: ambari


Description
---

Add support to enable Ranger Nifi plugin.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 c510dac 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
 661089a 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
 87fccbe 


Diff: https://reviews.apache.org/r/58995/diff/1/


Testing
---

Verified fresh installation on Cent-OS 6.


Thanks,

Vishal Suvagia

Re: Review Request 58845: AMBARI-20891 - Allow extensions to auto-link with supported stack versions

2017-05-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review173909
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 5456 (original), 5457-5460 (patched)


Maybe use StringUtils.isNotBlank for these.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
Lines 43 (patched)


This class can be made a Singleton and be injected as a dependency.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
Lines 105 (patched)


Use {} notatation



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
Lines 111-112 (patched)


Use {} notatation



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
Lines 116 (patched)


Use {} notatation



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
Lines 123 (patched)


Use {} notatation



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
Lines 128 (patched)


Documentation



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
Lines 146-153 (patched)


Should this really be an exception if they are aleady linked, or can it be 
a information message with a NOOP?



ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java
Line 229 (original), 240-263 (patched)


Documentation on this. Also, what about the exception being logged if the 
extension could not be created. Should this be thrown as well?


- Jonathan Hurley


On April 28, 2017, 1:48 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58845/
> ---
> 
> (Updated April 28, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-20891
> https://issues.apache.org/jira/browse/AMBARI-20891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It would possible to link extensions to supported stack versions while 
> parsing the stacks, extensions and common-services directories.
> 
> This would allow extensions to avoid making rest API calls to set up the link.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
>  3df1cd5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java
>  12b3ce0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java
>  ce92ecf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 20e28fc 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> d3ad351 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java 
> 656a8ce 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 353dd86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java
>  77a7250 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
>  9900eb5 
>   ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c 
>   ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c 
>   ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml
>  PRE-CREATION 
>   
>

Re: Review Request 58993: AMBARI-20930 : stackadvisor recommendations for atlas hooks should be disabled for external Atlas

2017-05-04 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58993/#review173907
---


Ship it!




Ship It!

- Sumit Mohanty


On May 4, 2017, 2:29 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58993/
> ---
> 
> (Updated May 4, 2017, 2:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20930
> https://issues.apache.org/jira/browse/AMBARI-20930
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In cases where Atlas is not setup on the cluster but the Atlas hooks are 
> enabled for external Atlas.
> Ambari recommendations show to disable the Atlas hooks.
> This behaviour needs to be changed to support externally used Atlas service.
> 
> PS: Attached patch is for trunk, patch for branch-2.5 is attached to 
> AMBARI-20930 Apache JIRA.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> eb7389d 
> 
> 
> Diff: https://reviews.apache.org/r/58993/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 58993: AMBARI-20930 : stackadvisor recommendations for atlas hooks should be disabled for external Atlas

2017-05-04 Thread Vishal Suvagia via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58993/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-20930
https://issues.apache.org/jira/browse/AMBARI-20930


Repository: ambari


Description
---

In cases where Atlas is not setup on the cluster but the Atlas hooks are 
enabled for external Atlas.
Ambari recommendations show to disable the Atlas hooks.
This behaviour needs to be changed to support externally used Atlas service.

PS: Attached patch is for trunk, patch for branch-2.5 is attached to 
AMBARI-20930 Apache JIRA.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
eb7389d 


Diff: https://reviews.apache.org/r/58993/diff/1/


Testing
---

Verified fresh installation on Cent-OS 6.


Thanks,

Vishal Suvagia

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-04 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/#review173901
---




ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
Lines 38 (patched)


Aren' there some password properities that are required when installing a 
service? If so, shouldn't the existance of the property be tested?  Being that 
the fill set of configs is used when validating, I would expect that a required 
password property would have been set in the Cluster Creation Template.



ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
Lines 89 (patched)


Isn't it possible for host groups to have different sets of configuations.  
This method appears to combine all hosts group-specific configs into one 
_common_ configuration map.



ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
Lines 96 (patched)


This will overwrite the _global_ configration map entries with the host 
group-specific configration map entries.  So if the _global_ configiration map 
contains:

```
foo-type: {property1:a, property2:b}
```

And a host group configuration map contains:

```
foo-type: {property1:c, property3:d}
```

The end result will contain:

```
foo-type: {property1:c, property3:d}
```

Not
```
foo-type: {property1:c, property2:b, property3:d}
```

Which would still be incorrect for the scenarip where multipe host groups 
specifiy a property map for `foo-type`.


- Robert Levas


On May 4, 2017, 9:38 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58990/
> ---
> 
> (Updated May 4, 2017, 9:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20872
> https://issues.apache.org/jira/browse/AMBARI-20872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validating required properties for services listed in the blueprint can't be 
> accurate as further configurtion can be added in the cluster creation 
> template.
> (Where the configuration is added varies by use cases and usage)
> 
> This patch contains the change that defers this validation till all the 
> configuration is together, namely till the cluster creation template is 
> posted.
> The validation logic is the same as it was before (provided config entries 
> are checked against those marked as required in the stack) the way the 
> properties are collected has slightly changed:
> 
> - before the properties were retrieved by traversing hostgroups
> - in the current implementation required properties are retrieved by 
> traversing the services listed in the blueprint
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  45a8c5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
>  146b424 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  0e77301 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58990/diff/1/
> 
> 
> Testing
> ---
> 
> Tested successfully on local environment.
> Added unit tests.
> 
> Unit tests running ...
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-04 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173904
---


Ship it!




Ship It!

- Mugdha Varadkar


On May 4, 2017, 1:27 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated May 4, 2017, 1:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  a8b7f24 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ad44033 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/3/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-04 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173900
---


Ship it!




Ship It!

- Oliver Szabo


On máj. 4, 2017, 1:27 du, Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated máj. 4, 2017, 1:27 du)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  a8b7f24 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ad44033 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/3/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58991: AMBARI-20931. Wrong equality check in ValueAttributesInfo

2017-05-04 Thread Laszlo Puskas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58991/#review173898
---


Ship it!




Ship It!

- Laszlo Puskas


On May 4, 2017, 1:41 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58991/
> ---
> 
> (Updated May 4, 2017, 1:41 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sandor Magyari, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20931
> https://issues.apache.org/jira/browse/AMBARI-20931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix typo in equals
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  c41cd9ae621ba4887af45fe001806cee25d009b2 
> 
> 
> Diff: https://reviews.apache.org/r/58991/diff/1/
> 
> 
> Testing
> ---
> 
> Ran relevant unit tests
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 58991: AMBARI-20931. Wrong equality check in ValueAttributesInfo

2017-05-04 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58991/
---

Review request for Ambari, Laszlo Puskas, Sandor Magyari, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20931
https://issues.apache.org/jira/browse/AMBARI-20931


Repository: ambari


Description
---

Fix typo in equals


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 c41cd9ae621ba4887af45fe001806cee25d009b2 


Diff: https://reviews.apache.org/r/58991/diff/1/


Testing
---

Ran relevant unit tests


Thanks,

Attila Doroszlai

Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-04 Thread Laszlo Puskas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/
---

Review request for Ambari, Attila Doroszlai, Robert Levas, and Robert Nettleton.


Bugs: AMBARI-20872
https://issues.apache.org/jira/browse/AMBARI-20872


Repository: ambari


Description
---

Validating required properties for services listed in the blueprint can't be 
accurate as further configurtion can be added in the cluster creation template.
(Where the configuration is added varies by use cases and usage)

This patch contains the change that defers this validation till all the 
configuration is together, namely till the cluster creation template is posted.
The validation logic is the same as it was before (provided config entries are 
checked against those marked as required in the stack) the way the properties 
are collected has slightly changed:

- before the properties were retrieved by traversing hostgroups
- in the current implementation required properties are retrieved by traversing 
the services listed in the blueprint


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 45a8c5c 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
 146b424 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
 0e77301 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58990/diff/1/


Testing
---

Tested successfully on local environment.
Added unit tests.

Unit tests running ...


Thanks,

Laszlo Puskas

Re: Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

2017-05-04 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/
---

(Updated May 4, 2017, 1:36 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
and Velmurugan Periasamy.


Bugs: AMBARI-20779
https://issues.apache.org/jira/browse/AMBARI-20779


Repository: ambari


Description (updated)
---

Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to 
upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to 
true, WebHDFS RESTAPI tries to create audit directory in HDFS this will fail 
RANGER-KMS restart task during upgrade as HDFS service will not be started.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 e111dbf 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 6230921 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 47a7094 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 18c0c15 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
19031a8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
8cfaa52 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
f7192ae 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 5120740 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 358fb6e 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 368bbe2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
80436bf 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
ad9ae33 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml 
c180b61 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 3ceea8f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 c3436b9 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
f3b1fa6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
0470b7a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml 
f923702 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 a74d085 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
35d3da2 


Diff: https://reviews.apache.org/r/58989/diff/1/


Testing
---

Tested EU upgrade to stack 2.6


Thanks,

Mugdha Varadkar

Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

2017-05-04 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
and Velmurugan Periasamy.


Bugs: AMBARI-20779
https://issues.apache.org/jira/browse/AMBARI-20779


Repository: ambari


Description
---

Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to 
upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to 
true, WebHDFS RESTAPI tries to create audit directory in hadoop this will fail 
as HDFS service will not be started.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 e111dbf 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 6230921 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 47a7094 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 18c0c15 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
19031a8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
8cfaa52 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
f7192ae 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 5120740 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 358fb6e 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 368bbe2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
80436bf 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
ad9ae33 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml 
c180b61 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 3ceea8f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 c3436b9 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
f3b1fa6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
0470b7a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml 
f923702 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 a74d085 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
35d3da2 


Diff: https://reviews.apache.org/r/58989/diff/1/


Testing
---

Tested EU upgrade to stack 2.6


Thanks,

Mugdha Varadkar

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-04 Thread Vishal Suvagia via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/
---

(Updated May 4, 2017, 1:27 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, and Velmurugan Periasamy.


Changes
---

Updated patch to handle errors using ExecutionFailure instead of Exceptions.


Bugs: AMBARI-20868
https://issues.apache.org/jira/browse/AMBARI-20868


Repository: ambari


Description
---

Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
need to handle errors and ensure Ranger start works, despite solr service being 
down.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 a8b7f24 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
 34ce70d 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
ad44033 


Diff: https://reviews.apache.org/r/58797/diff/3/

Changes: https://reviews.apache.org/r/58797/diff/2-3/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia

Re: Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367

2017-05-04 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58983/#review173889
---


Ship it!




Ship It!

- Gaurav Nagar


On May 4, 2017, 6:21 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58983/
> ---
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20929
> https://issues.apache.org/jira/browse/AMBARI-20929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After ZEPPELIN-2367 there are configuration parameter changes that required 
> to make user impersonation for JDBC interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  c2f816399b 
> 
> 
> Diff: https://reviews.apache.org/r/58983/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on Cent6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367

2017-05-04 Thread venkat sairam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58983/#review173888
---


Ship it!




Ship It!

- venkat sairam


On May 4, 2017, 6:21 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58983/
> ---
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20929
> https://issues.apache.org/jira/browse/AMBARI-20929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After ZEPPELIN-2367 there are configuration parameter changes that required 
> to make user impersonation for JDBC interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  c2f816399b 
> 
> 
> Diff: https://reviews.apache.org/r/58983/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on Cent6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367

2017-05-04 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58983/#review173887
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 4, 2017, 6:21 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58983/
> ---
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20929
> https://issues.apache.org/jira/browse/AMBARI-20929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After ZEPPELIN-2367 there are configuration parameter changes that required 
> to make user impersonation for JDBC interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  c2f816399b 
> 
> 
> Diff: https://reviews.apache.org/r/58983/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on Cent6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173882
---


Ship it!




Ship It!

- Gaurav Nagar


On May 4, 2017, 6:36 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> ---
> 
> (Updated May 4, 2017, 6:36 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> npm package manager have been replaced with yarn manager and front-end 
> plugins, node versions have been updated as per the requirements.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/pom.xml 181deb4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
>   contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock 
> PRE-CREATION 
>   contrib/views/files/pom.xml 8e691b1 
>   contrib/views/files/src/main/resources/ui/package.json 24da458 
>   contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hawq/pom.xml e4ed54a 
>   contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hive-next/pom.xml a1e116d 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock 
> PRE-CREATION 
>   contrib/views/hive/pom.xml de83dbc 
>   contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
>   contrib/views/hueambarimigration/pom.xml f7a42dd 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
>  64b3270 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
>  PRE-CREATION 
>   contrib/views/jobs/pom.xml a8f44f3 
>   contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/pig/pom.xml cf2ed37 
>   contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
>   contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
>   contrib/views/pom.xml 0a1a77f 
>   contrib/views/wfmanager/pom.xml bcb9572 
>   contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
>   contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
>   pom.xml db3d457 
> 
> 
> Diff: https://reviews.apache.org/r/58984/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 58981: Service Auto-Start behavior is incorrect for Service Administrator and Service Operator Roles

2017-05-04 Thread Sangeeta Ravindran


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58981/
---

Review request for Ambari, Alexandr Antonenko and Robert Levas.


Bugs: AMBARI-20925
https://issues.apache.org/jira/browse/AMBARI-20925


Repository: ambari


Description
---

As per the Role based access control list, users with Service Administrator 
role should be able to manage service auto-start while users with Service 
Operator role should not have this privilege.

Currently, the following 2 issues are seen:

1. Service Operators can view Service Auto Start menu item which is not as per 
the accesss control list.
2. Service Administrators cannot enable or disable auto-start at service level 
because clicking on the Service Auto Start menu item returns them to the main 
services dashboard.

The menu item is displayed incorrectly fot Service Operators because we are 
checking for SERVICE.START_STOP and CLUSTER.MODIFY_CONFIGS privileges. If user 
has either privilege, we display the menu. To fix this, we need to add a check 
for SERVICE.MANAGE_AUTO_START and CLUSTER.MANAGE_AUTO_START. If the user has 
either of these privileges, then the menu item should be enabled.

Also, when the menu is clicked, we are checking only for 
CLUSTER.MANAGE_AUTO_START privilege but not for SERVICE.MANAGE_AUTO_START 
(which is the privilege that Service Administrators have). Hence, for Service 
Administrators, clicking on the menu results in incorrect navigation to the 
dashboard instead of displaying the Service Auto Start page. To fix this, we 
need to add a check for SERVICE.MANAGE_AUTO_START privilege as well.


Diffs
-

  ambari-web/app/routes/main.js 1f881e0 
  ambari-web/app/views/main/admin.js 0fa84e8 
  ambari-web/app/views/main/menu.js 6e79aba 


Diff: https://reviews.apache.org/r/58981/diff/1/


Testing
---

Manual Testing with all 5 roles and Ambari admin.
mvn clean test.


Thanks,

Sangeeta Ravindran

Re: Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367

2017-05-04 Thread Renjith Kamath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58983/#review173876
---


Ship it!




Ship It!

- Renjith Kamath


On May 4, 2017, 6:21 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58983/
> ---
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20929
> https://issues.apache.org/jira/browse/AMBARI-20929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After ZEPPELIN-2367 there are configuration parameter changes that required 
> to make user impersonation for JDBC interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  c2f816399b 
> 
> 
> Diff: https://reviews.apache.org/r/58983/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on Cent6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread venkat sairam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Yusaku Sako.


Bugs: AMBARI-20928
https://issues.apache.org/jira/browse/AMBARI-20928


Repository: ambari


Description
---

npm package manager have been replaced with yarn manager and front-end plugins, 
node versions have been updated as per the requirements.


Diffs
-

  contrib/views/capacity-scheduler/pom.xml 181deb4 
  contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
  contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/files/pom.xml 8e691b1 
  contrib/views/files/src/main/resources/ui/package.json 24da458 
  contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hawq/pom.xml e4ed54a 
  contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hive-next/pom.xml a1e116d 
  contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hive/pom.xml de83dbc 
  contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hueambarimigration/pom.xml f7a42dd 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
 64b3270 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
 PRE-CREATION 
  contrib/views/jobs/pom.xml a8f44f3 
  contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/pig/pom.xml cf2ed37 
  contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
  contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
  contrib/views/pom.xml 0a1a77f 
  contrib/views/wfmanager/pom.xml bcb9572 
  contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
  contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
  pom.xml db3d457 


Diff: https://reviews.apache.org/r/58984/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam

Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367

2017-05-04 Thread Prabhjyot Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58983/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and 
Sumit Mohanty.


Bugs: AMBARI-20929
https://issues.apache.org/jira/browse/AMBARI-20929


Repository: ambari


Description
---

After ZEPPELIN-2367 there are configuration parameter changes that required to 
make user impersonation for JDBC interpreter.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 c2f816399b 


Diff: https://reviews.apache.org/r/58983/diff/1/


Testing
---

Manually tested on Cent6.6


Thanks,

Prabhjyot Singh

37 matches

Mail list logo