Re: Review Request 61998: Update Ambari Metrics service check to support HTTP SPNEGO authentication

[Qin Liu]

> On Sept. 8, 2017, 3:46 a.m., Aravindan Vijayan wrote:
> > Ship It!

Hi Aravindan, Thank you so much!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61998/#review184933
---


On Sept. 5, 2017, 7:50 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61998/
> ---
> 
> (Updated Sept. 5, 2017, 7:50 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Eric Yang, Robert 
> Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21821
> https://issues.apache.org/jira/browse/AMBARI-21821
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Ambari Metrics service check currently does not support Kerberos HTTP SPNEGO 
> authentication.
> 
> 2017-08-24 16:13:44,078 - Ambari Metrics service check was started.
> 2017-08-24 16:13:44,109 - Generated metrics for host amshost.example.com :
> {
> "metrics": [
> {
> "metricname": "AMBARI_METRICS.SmokeTest.FakeMetric",
> "appid": "amssmoketestfake",
> "hostname": "host.example.com",
> "timestamp": 1503616424000,
> "starttime": 1503616424000,
> "metrics":
> { "1503616424000": 0.164134766408, "1503616425000": 1503616424000 }
> 
> }
> ]
> }
> 2017-08-24 16:13:44,114 - Connecting (POST) to 
> amshost.example.com:6188/ws/v1/timeline/metrics/
> 2017-08-24 16:13:44,117 - Http response for host amshost.example.com: 401 
> Authentication required
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  6975bec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  2b3dfa9 
> 
> 
> Diff: https://reviews.apache.org/r/61998/diff/2/
> 
> 
> Testing
> ---
> 
> 1. run the Hadoop QA testing twice and the testcase failures has nothing to 
> do with the patch
> 
> 2. manually tested AMS service check on HDP/trunk cluster with combination of 
> HTTP SPNEGO/Non-HTTP SPNEGO, SSL/Non-SSL, AMS distributed/embedded.
> 
> 
> File Attachments
> 
> 
> AMBARI-21821_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/05/7241c0b4-7c48-47b1-b45c-c1ec1d71d4e0__AMBARI-21821_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 61998: Update Ambari Metrics service check to support HTTP SPNEGO authentication

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61998/#review184933
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 5, 2017, 7:50 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61998/
> ---
> 
> (Updated Sept. 5, 2017, 7:50 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Eric Yang, Robert 
> Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21821
> https://issues.apache.org/jira/browse/AMBARI-21821
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Ambari Metrics service check currently does not support Kerberos HTTP SPNEGO 
> authentication.
> 
> 2017-08-24 16:13:44,078 - Ambari Metrics service check was started.
> 2017-08-24 16:13:44,109 - Generated metrics for host amshost.example.com :
> {
> "metrics": [
> {
> "metricname": "AMBARI_METRICS.SmokeTest.FakeMetric",
> "appid": "amssmoketestfake",
> "hostname": "host.example.com",
> "timestamp": 1503616424000,
> "starttime": 1503616424000,
> "metrics":
> { "1503616424000": 0.164134766408, "1503616425000": 1503616424000 }
> 
> }
> ]
> }
> 2017-08-24 16:13:44,114 - Connecting (POST) to 
> amshost.example.com:6188/ws/v1/timeline/metrics/
> 2017-08-24 16:13:44,117 - Http response for host amshost.example.com: 401 
> Authentication required
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  6975bec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  2b3dfa9 
> 
> 
> Diff: https://reviews.apache.org/r/61998/diff/2/
> 
> 
> Testing
> ---
> 
> 1. run the Hadoop QA testing twice and the testcase failures has nothing to 
> do with the patch
> 
> 2. manually tested AMS service check on HDP/trunk cluster with combination of 
> HTTP SPNEGO/Non-HTTP SPNEGO, SSL/Non-SSL, AMS distributed/embedded.
> 
> 
> File Attachments
> 
> 
> AMBARI-21821_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/05/7241c0b4-7c48-47b1-b45c-c1ec1d71d4e0__AMBARI-21821_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 61998: Update Ambari Metrics service check to support HTTP SPNEGO authentication

[Qin Liu]

> On Sept. 7, 2017, 10:21 p.m., Eric Yang wrote:
> > Ship It!

Hi Eric, Thank you so much!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61998/#review184894
---


On Sept. 5, 2017, 7:50 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61998/
> ---
> 
> (Updated Sept. 5, 2017, 7:50 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Eric Yang, Robert 
> Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21821
> https://issues.apache.org/jira/browse/AMBARI-21821
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Ambari Metrics service check currently does not support Kerberos HTTP SPNEGO 
> authentication.
> 
> 2017-08-24 16:13:44,078 - Ambari Metrics service check was started.
> 2017-08-24 16:13:44,109 - Generated metrics for host amshost.example.com :
> {
> "metrics": [
> {
> "metricname": "AMBARI_METRICS.SmokeTest.FakeMetric",
> "appid": "amssmoketestfake",
> "hostname": "host.example.com",
> "timestamp": 1503616424000,
> "starttime": 1503616424000,
> "metrics":
> { "1503616424000": 0.164134766408, "1503616425000": 1503616424000 }
> 
> }
> ]
> }
> 2017-08-24 16:13:44,114 - Connecting (POST) to 
> amshost.example.com:6188/ws/v1/timeline/metrics/
> 2017-08-24 16:13:44,117 - Http response for host amshost.example.com: 401 
> Authentication required
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  6975bec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  2b3dfa9 
> 
> 
> Diff: https://reviews.apache.org/r/61998/diff/2/
> 
> 
> Testing
> ---
> 
> 1. run the Hadoop QA testing twice and the testcase failures has nothing to 
> do with the patch
> 
> 2. manually tested AMS service check on HDP/trunk cluster with combination of 
> HTTP SPNEGO/Non-HTTP SPNEGO, SSL/Non-SSL, AMS distributed/embedded.
> 
> 
> File Attachments
> 
> 
> AMBARI-21821_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/05/7241c0b4-7c48-47b1-b45c-c1ec1d71d4e0__AMBARI-21821_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 61998: Update Ambari Metrics service check to support HTTP SPNEGO authentication

[Eric Yang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61998/#review184894
---


Ship it!




Ship It!

- Eric Yang


On Sept. 5, 2017, 7:50 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61998/
> ---
> 
> (Updated Sept. 5, 2017, 7:50 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Eric Yang, Robert 
> Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21821
> https://issues.apache.org/jira/browse/AMBARI-21821
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Ambari Metrics service check currently does not support Kerberos HTTP SPNEGO 
> authentication.
> 
> 2017-08-24 16:13:44,078 - Ambari Metrics service check was started.
> 2017-08-24 16:13:44,109 - Generated metrics for host amshost.example.com :
> {
> "metrics": [
> {
> "metricname": "AMBARI_METRICS.SmokeTest.FakeMetric",
> "appid": "amssmoketestfake",
> "hostname": "host.example.com",
> "timestamp": 1503616424000,
> "starttime": 1503616424000,
> "metrics":
> { "1503616424000": 0.164134766408, "1503616425000": 1503616424000 }
> 
> }
> ]
> }
> 2017-08-24 16:13:44,114 - Connecting (POST) to 
> amshost.example.com:6188/ws/v1/timeline/metrics/
> 2017-08-24 16:13:44,117 - Http response for host amshost.example.com: 401 
> Authentication required
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  6975bec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  2b3dfa9 
> 
> 
> Diff: https://reviews.apache.org/r/61998/diff/2/
> 
> 
> Testing
> ---
> 
> 1. run the Hadoop QA testing twice and the testcase failures has nothing to 
> do with the patch
> 
> 2. manually tested AMS service check on HDP/trunk cluster with combination of 
> HTTP SPNEGO/Non-HTTP SPNEGO, SSL/Non-SSL, AMS distributed/embedded.
> 
> 
> File Attachments
> 
> 
> AMBARI-21821_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/05/7241c0b4-7c48-47b1-b45c-c1ec1d71d4e0__AMBARI-21821_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/
---

(Updated Sept. 7, 2017, 9:56 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

use flag to indicate line delimited json file creation


Bugs: AMBARI-21810
https://issues.apache.org/jira/browse/AMBARI-21810


Repository: ambari


Description
---

This script allows the user to set an end date, and save all the previous log 
entries into HDFS or S3


Diffs (updated)
-

  ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
  ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
  
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
 PRE-CREATION 
  ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61898/diff/6/

Changes: https://reviews.apache.org/r/61898/diff/5-6/


Testing
---

Tested on local cluster with
- SSL
- kerberos
- interrupted, then restarted script
- HDFS
- S3
- the combinations of the above


Thanks,

Miklos Gergely

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review184889
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 7, 2017, 8:33 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Sept. 7, 2017, 8:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/5/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review184886
---




ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py
Lines 68 (patched)


this could be --line-delimited (by default would be the one json per line)


- Oliver Szabo


On Sept. 7, 2017, 8:33 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Sept. 7, 2017, 8:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/5/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62169: Server returns 500 error for create config group request

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62169/#review184881
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 7, 2017, 3:49 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62169/
> ---
> 
> (Updated Sept. 7, 2017, 3:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-21908
> https://issues.apache.org/jira/browse/AMBARI-21908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cannot create config group, server returns 500 error.
> 
> Form data:
> {code}
> {noformat}
> [{"ConfigGroup":{"group_name":"11","tag":"HDFS","description":"","desired_configs":[],"hosts":[]},"serviceName":"HDFS"}]
> {noformat}
> {code}
> 
> Exception:
> {noformat}
> {
>   "status" : 400,
>   "message" : "The properties [ConfigGroup/serviceName] specified in the 
> request or predicate are not supported for the resource type ConfigGroup."
> }
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigGroupRequest.java
>  efa1a7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  0ea54cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  da517f3 
>   ambari-server/src/main/resources/properties.json 80a86b8 
> 
> 
> Diff: https://reviews.apache.org/r/62169/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified.
> Affected unit tests are green.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Vitalyi Brodetskyi]

> On Вер. 7, 2017, 8:55 після полудня, Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml
> > Lines 95 (patched)
> > 
> >
> > We dont need to change it for HDP. For HDP the distribution should 
> > remain HDP. 
> > i.e. 
> > deb http://public-repo-1/ HDP main
> > 
> > KIBANA service in Metron mpack requires setting distribution=stable.
> > 
> > "distribution" should be an optional parameter.

sure, i understand this. This patch is draft, to show for reviewers and get 
some notes.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review184878
---


On Вер. 7, 2017, 8:40 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Вер. 7, 2017, 8:40 після полудня)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  3d96122 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1a022af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/2/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review184878
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
Line 22 (original), 22 (patched)


_UBUNTU_REPO_COMPONENTS_POSTFIX is hardcoded to "main" but it is possible 
that some debian repo for a custom service uses a different component name

For example:
deb http://url mydistro mycomponent

We should see if we can parameterize component names as well (default being 
"main" if it is not defined).



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
Line 48 (original), 48 (patched)


If repo['distribution'] is not defined then we should use repo['repoName'] 
as the distrbution. This will maintain compatibility for HDP deployments



ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml
Lines 95 (patched)


We dont need to change it for HDP. For HDP the distribution should remain 
HDP. 
i.e. 
deb http://public-repo-1/ HDP main

KIBANA service in Metron mpack requires setting distribution=stable.

"distribution" should be an optional parameter.


- Jayush Luniya


On Sept. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  3d96122 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1a022af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/2/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62169: Server returns 500 error for create config group request

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62169/#review184877
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 7, 2017, 7:49 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62169/
> ---
> 
> (Updated Sept. 7, 2017, 7:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-21908
> https://issues.apache.org/jira/browse/AMBARI-21908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cannot create config group, server returns 500 error.
> 
> Form data:
> {code}
> {noformat}
> [{"ConfigGroup":{"group_name":"11","tag":"HDFS","description":"","desired_configs":[],"hosts":[]},"serviceName":"HDFS"}]
> {noformat}
> {code}
> 
> Exception:
> {noformat}
> {
>   "status" : 400,
>   "message" : "The properties [ConfigGroup/serviceName] specified in the 
> request or predicate are not supported for the resource type ConfigGroup."
> }
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigGroupRequest.java
>  efa1a7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  0ea54cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  da517f3 
>   ambari-server/src/main/resources/properties.json 80a86b8 
> 
> 
> Diff: https://reviews.apache.org/r/62169/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified.
> Affected unit tests are green.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/
---

(Updated Sept. 7, 2017, 8:33 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

configurable file format, compression method


Bugs: AMBARI-21810
https://issues.apache.org/jira/browse/AMBARI-21810


Repository: ambari


Description
---

This script allows the user to set an end date, and save all the previous log 
entries into HDFS or S3


Diffs (updated)
-

  ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
  ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
  
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
 PRE-CREATION 
  ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61898/diff/5/

Changes: https://reviews.apache.org/r/61898/diff/4-5/


Testing
---

Tested on local cluster with
- SSL
- kerberos
- interrupted, then restarted script
- HDFS
- S3
- the combinations of the above


Thanks,

Miklos Gergely

Re: Review Request 62169: Server returns 500 error for create config group request

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62169/#review184870
---


Ship it!




LGTM.

- Swapan Shridhar


On Sept. 7, 2017, 7:49 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62169/
> ---
> 
> (Updated Sept. 7, 2017, 7:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-21908
> https://issues.apache.org/jira/browse/AMBARI-21908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cannot create config group, server returns 500 error.
> 
> Form data:
> {code}
> {noformat}
> [{"ConfigGroup":{"group_name":"11","tag":"HDFS","description":"","desired_configs":[],"hosts":[]},"serviceName":"HDFS"}]
> {noformat}
> {code}
> 
> Exception:
> {noformat}
> {
>   "status" : 400,
>   "message" : "The properties [ConfigGroup/serviceName] specified in the 
> request or predicate are not supported for the resource type ConfigGroup."
> }
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigGroupRequest.java
>  efa1a7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  0ea54cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  da517f3 
>   ambari-server/src/main/resources/properties.json 80a86b8 
> 
> 
> Diff: https://reviews.apache.org/r/62169/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified.
> Affected unit tests are green.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 62169: Server returns 500 error for create config group request

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62169/
---

Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Swapan 
Shridhar.


Bugs: AMBARI-21908
https://issues.apache.org/jira/browse/AMBARI-21908


Repository: ambari


Description
---

Cannot create config group, server returns 500 error.

Form data:
{code}
{noformat}
[{"ConfigGroup":{"group_name":"11","tag":"HDFS","description":"","desired_configs":[],"hosts":[]},"serviceName":"HDFS"}]
{noformat}
{code}

Exception:
{noformat}
{
  "status" : 400,
  "message" : "The properties [ConfigGroup/serviceName] specified in the 
request or predicate are not supported for the resource type ConfigGroup."
}
{noformat}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigGroupRequest.java
 efa1a7e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 0ea54cb 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 da517f3 
  ambari-server/src/main/resources/properties.json 80a86b8 


Diff: https://reviews.apache.org/r/62169/diff/1/


Testing
---

Manually verified.
Affected unit tests are green.


Thanks,

Sid Wagle

Re: Review Request 62167: Consider Not Scheduling ConfigureAction Tasks During PATCH/MAINT Upgrades

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62167/
---

(Updated Sept. 7, 2017, 3:35 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Changes
---

Update for comments and test issue


Bugs: AMBARI-21906
https://issues.apache.org/jira/browse/AMBARI-21906


Repository: ambari


Description
---

Skip orchestration of configuration types.  Add the ability to xsd just in case 
we ever need to do such configs without hardcoding the behavior.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 3d72a6ec7e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 b7be2ec1fd 
  ambari-server/src/main/resources/upgrade-pack.xsd aa7ddd8c80 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 856f2faa67 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 9c961daeba 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 616139c5bf 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_force_config_change.xml
 PRE-CREATION 
  ambari-server/src/test/resources/version_definition_test_patch_config.xml 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62167/diff/2/

Changes: https://reviews.apache.org/r/62167/diff/1-2/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 62167: Consider Not Scheduling ConfigureAction Tasks During PATCH/MAINT Upgrades

[Nate Cole]

> On Sept. 7, 2017, 2:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
> > Lines 1239 (patched)
> > 
> >
> > You can use RepositoryType.REVERTABLE here.

Will do.


> On Sept. 7, 2017, 2:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
> > Lines 1242 (patched)
> > 
> >
> > Can you just use RepositoryType.isRevertable() here?

Really? Two issues on the same code block?


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62167/#review184849
---


On Sept. 7, 2017, 1:52 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62167/
> ---
> 
> (Updated Sept. 7, 2017, 1:52 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21906
> https://issues.apache.org/jira/browse/AMBARI-21906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Skip orchestration of configuration types.  Add the ability to xsd just in 
> case we ever need to do such configs without hardcoding the behavior.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  3d72a6ec7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  b7be2ec1fd 
>   ambari-server/src/main/resources/upgrade-pack.xsd aa7ddd8c80 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  856f2faa67 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  9c961daeba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  616139c5bf 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_force_config_change.xml
>  PRE-CREATION 
>   ambari-server/src/test/resources/version_definition_test_patch_config.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62167/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62134: Property provider in-memory maps are refreshed too slowly after config updates

[Sid Wagle]

> On Sept. 7, 2017, 6:23 p.m., Jonathan Hurley wrote:
> > We need an @WTF annotation for stuff like this ...

:D +1


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62134/#review184854
---


On Sept. 7, 2017, 6:19 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62134/
> ---
> 
> (Updated Sept. 7, 2017, 6:19 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21898
> https://issues.apache.org/jira/browse/AMBARI-21898
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Building the hostComponentMap map for ProviderModule seems does unnecessary 
> computation going through the ResourceProvider layer. On every configuration 
> update, we call the reset on these maps which takes a long time to refresh. 
> Instead, relying on 
> org.apache.ambari.server.state.cluster.ClusterImpl#serviceComponentHosts will 
> lead to faster computation without overhead like stale config calculations 
> for every SCH.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  5fc4c31 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> ee18fdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  2f858b8 
> 
> 
> Diff: https://reviews.apache.org/r/62134/diff/3/
> 
> 
> Testing
> ---
> 
> PropertyProvider tests are all green
> Pending unit tests and manual testing.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62134: Property provider in-memory maps are refreshed too slowly after config updates

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62134/#review184854
---


Ship it!




We need an @WTF annotation for stuff like this ...

- Jonathan Hurley


On Sept. 7, 2017, 2:19 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62134/
> ---
> 
> (Updated Sept. 7, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21898
> https://issues.apache.org/jira/browse/AMBARI-21898
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Building the hostComponentMap map for ProviderModule seems does unnecessary 
> computation going through the ResourceProvider layer. On every configuration 
> update, we call the reset on these maps which takes a long time to refresh. 
> Instead, relying on 
> org.apache.ambari.server.state.cluster.ClusterImpl#serviceComponentHosts will 
> lead to faster computation without overhead like stale config calculations 
> for every SCH.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  5fc4c31 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> ee18fdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  2f858b8 
> 
> 
> Diff: https://reviews.apache.org/r/62134/diff/3/
> 
> 
> Testing
> ---
> 
> PropertyProvider tests are all green
> Pending unit tests and manual testing.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62134: Property provider in-memory maps are refreshed too slowly after config updates

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62134/
---

(Updated Sept. 7, 2017, 6:19 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
Sebastian Toader.


Changes
---

Fixed the NPE caused due to the fact that DefaultProviderModule is not 
instantiated trough guice and thereby the field injections do not really work. 
The contructor actually initializes these fields explcitily. Verified the fix 
manually and also added a TODO for future.


Bugs: AMBARI-21898
https://issues.apache.org/jira/browse/AMBARI-21898


Repository: ambari


Description
---

Building the hostComponentMap map for ProviderModule seems does unnecessary 
computation going through the ResourceProvider layer. On every configuration 
update, we call the reset on these maps which takes a long time to refresh. 
Instead, relying on 
org.apache.ambari.server.state.cluster.ClusterImpl#serviceComponentHosts will 
lead to faster computation without overhead like stale config calculations for 
every SCH.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 5fc4c31 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
ee18fdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 2f858b8 


Diff: https://reviews.apache.org/r/62134/diff/3/

Changes: https://reviews.apache.org/r/62134/diff/2-3/


Testing
---

PropertyProvider tests are all green
Pending unit tests and manual testing.


Thanks,

Sid Wagle

Re: Review Request 62167: Consider Not Scheduling ConfigureAction Tasks During PATCH/MAINT Upgrades

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62167/#review184849
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
Lines 1239 (patched)


You can use RepositoryType.REVERTABLE here.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
Lines 1242 (patched)


Can you just use RepositoryType.isRevertable() here?


- Jonathan Hurley


On Sept. 7, 2017, 1:52 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62167/
> ---
> 
> (Updated Sept. 7, 2017, 1:52 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21906
> https://issues.apache.org/jira/browse/AMBARI-21906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Skip orchestration of configuration types.  Add the ability to xsd just in 
> case we ever need to do such configs without hardcoding the behavior.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  3d72a6ec7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  b7be2ec1fd 
>   ambari-server/src/main/resources/upgrade-pack.xsd aa7ddd8c80 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  856f2faa67 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  9c961daeba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  616139c5bf 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_force_config_change.xml
>  PRE-CREATION 
>   ambari-server/src/test/resources/version_definition_test_patch_config.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62167/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 62167: Consider Not Scheduling ConfigureAction Tasks During PATCH/MAINT Upgrades

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62167/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-21906
https://issues.apache.org/jira/browse/AMBARI-21906


Repository: ambari


Description
---

Skip orchestration of configuration types.  Add the ability to xsd just in case 
we ever need to do such configs without hardcoding the behavior.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 3d72a6ec7e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 b7be2ec1fd 
  ambari-server/src/main/resources/upgrade-pack.xsd aa7ddd8c80 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 856f2faa67 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 9c961daeba 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 616139c5bf 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_force_config_change.xml
 PRE-CREATION 
  ambari-server/src/test/resources/version_definition_test_patch_config.xml 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62167/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 62157: AMBARI-21904 Remove redundant smokeuser entry from Ranger KMS Kerberos descriptor

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62157/#review184846
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/kerberos.json
Lines 37-39 (original), 34-36 (patched)


Shouldn't this be removed as well?


- Robert Levas


On Sept. 7, 2017, 10:33 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62157/
> ---
> 
> (Updated Sept. 7, 2017, 10:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-21904
> https://issues.apache.org/jira/browse/AMBARI-21904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> /smokeuser entry in RANGER_KMS_SERVER component section is not needed. It 
> wont break anything, but it is redundant and should eventually be removed.
> (Feedback from review request - https://reviews.apache.org/r/34561/)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  f2eac97 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/kerberos.json
>  69d6b6c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  427cadd 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_ranger_kms.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62157/diff/1/
> 
> 
> Testing
> ---
> 
> mvn -DskipPythonTests -Drat.skip -Dtest=UpgradeCatalog260Test test 
> 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running org.apache.ambari.server.upgrade.UpgradeCatalog260Test
> [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.772 
> s - in org.apache.ambari.server.upgrade.UpgradeCatalog260Test
> [INFO] 
> [INFO] Results:
> [INFO] 
> [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> [INFO] 
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
> [INFO] RAT will not execute since it is configured to be skipped via system 
> property 'rat.skip'.
> [INFO] 
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO] 
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 42.247 s
> [INFO] Finished at: 2017-09-07T14:28:04+00:00
> [INFO] Final Memory: 52M/803M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/
---

(Updated Вер. 7, 2017, 4:04 після полудня)


Review request for Ambari, Jayush Luniya and Sid Wagle.


Bugs: AMBARI-21856
https://issues.apache.org/jira/browse/AMBARI-21856


Repository: ambari


Description
---

The problem is that Ambari is using the reponame name field as the distribution 
when it creates the repo definition file. Since both of these repos use same 
distribution (which is a common Debian pattern), they collide.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
 3d96122 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1a022af 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
 0735e27 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
 bad8195 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
854f03f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
 5e1d5d3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
 17ded10 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
 058c45b 
  ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
 3a7b19b 


Diff: https://reviews.apache.org/r/61994/diff/2/

Changes: https://reviews.apache.org/r/61994/diff/1-2/


Testing
---

test will be fixed after solution will be approved


Thanks,

Vitalyi Brodetskyi

Re: Review Request 62159: Log Search UI: implement combo search filter

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62159/#review184822
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Сен. 7, 2017, 3:14 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62159/
> ---
> 
> (Updated Сен. 7, 2017, 3:14 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-21905
> https://issues.apache.org/jira/browse/AMBARI-21905
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Implement logs filtering item similar to 'Include Search' in current version.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/package.json 96733eb 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c08cb3a 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts
>  87e82f6 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.less
>  d47160f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.html
>  3f00e8b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.less
>  1395959 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.spec.ts
>  71039ed 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.ts
>  2b6bfea 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
>  6df6988 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less
>  9ab09ef 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
>  b1cf990 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
>  e407021 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 
> f72183c 
>   ambari-logsearch/ambari-logsearch-web/src/app/models/app-state.model.ts 
> 2995002 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
> 5b9e90d 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
>  702deab 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts 
> 9f6cacd 
>   ambari-logsearch/ambari-logsearch-web/yarn.lock 291b489 
> 
> 
> Diff: https://reviews.apache.org/r/62159/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 84 of 84 SUCCESS (1.985 secs / 1.906 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 62159: Log Search UI: implement combo search filter

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62159/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-21905
https://issues.apache.org/jira/browse/AMBARI-21905


Repository: ambari


Description
---

Implement logs filtering item similar to 'Include Search' in current version.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/package.json 96733eb 
  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c08cb3a 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts
 87e82f6 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.less
 d47160f 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.html
 3f00e8b 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.less
 1395959 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.spec.ts
 71039ed 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.ts
 2b6bfea 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
 6df6988 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less
 9ab09ef 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
 b1cf990 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
 e407021 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 
f72183c 
  ambari-logsearch/ambari-logsearch-web/src/app/models/app-state.model.ts 
2995002 
  ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
5b9e90d 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
 702deab 
  ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts 
9f6cacd 
  ambari-logsearch/ambari-logsearch-web/yarn.lock 291b489 


Diff: https://reviews.apache.org/r/62159/diff/1/


Testing
---

Executed 84 of 84 SUCCESS (1.985 secs / 1.906 secs)


Thanks,

Andrii Babiichuk

Review Request 62157: AMBARI-21904 Remove redundant smokeuser entry from Ranger KMS Kerberos descriptor

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62157/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Robert Levas.


Bugs: AMBARI-21904
https://issues.apache.org/jira/browse/AMBARI-21904


Repository: ambari


Description
---

/smokeuser entry in RANGER_KMS_SERVER component section is not needed. It wont 
break anything, but it is redundant and should eventually be removed.
(Feedback from review request - https://reviews.apache.org/r/34561/)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 f2eac97 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/kerberos.json
 69d6b6c 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 427cadd 
  
ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_ranger_kms.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62157/diff/1/


Testing
---

mvn -DskipPythonTests -Drat.skip -Dtest=UpgradeCatalog260Test test 

[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.ambari.server.upgrade.UpgradeCatalog260Test
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.772 s 
- in org.apache.ambari.server.upgrade.UpgradeCatalog260Test
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
[INFO] RAT will not execute since it is configured to be skipped via system 
property 'rat.skip'.
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
[INFO] skipping execute as per configuraion
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 42.247 s
[INFO] Finished at: 2017-09-07T14:28:04+00:00
[INFO] Final Memory: 52M/803M
[INFO] 


Thanks,

Mugdha Varadkar

Re: Review Request 62117: AMBARI-21889 MaxBackupIndex does not work with DailyRollingFileAppender in Ranger

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62117/#review184816
---


Ship it!




Ship It!

- Gautam Borad


On Sept. 6, 2017, 11:48 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62117/
> ---
> 
> (Updated Sept. 6, 2017, 11:48 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Gautam Borad.
> 
> 
> Bugs: AMBARI-21889
> https://issues.apache.org/jira/browse/AMBARI-21889
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger uses DailyRollingFileAppender and "maxbackupindex" is not in that 
> class so need to remove the same from admin-log4j config.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml
>  6108c36 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml
>  6384302 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml
>  8843a2a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
>  bac2e84 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  4b53c7c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  29fcac0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 0c4106e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 3e62fb1 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 970e19f 
> 
> 
> Diff: https://reviews.apache.org/r/62117/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Ranger Installation.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 62081: AMBARI-21878. Implement STOMP endpoint to handle alerts from agent

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62081/
---

(Updated Sept. 7, 2017, 2:02 p.m.)


Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor 
Magyari, Sebastian Toader, and Sid Wagle.


Changes
---

removed `Alert.cluster` (cluster name) in favor of `clusterId`


Bugs: AMBARI-21878
https://issues.apache.org/jira/browse/AMBARI-21878


Repository: ambari


Description
---

* Process alerts from agent at `/reports/alerts_status`
* Add `clusterId` to alert reports since cluster name is empty


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 
76d83908883a1ad1c5ee44534592e86e6b75451a 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 fce6be6a92104d775e5105c2056b05ff89abcfdf 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentReportsController.java
 0152d89c80d5ef63850d3a9211ca7a6c7bcb72b5 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnable.java
 41be01e12f596ec6229ccbbc44e54f93827a2328 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
 a35e6fd44a134658284113725dfd8706e470353c 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java
 503ad9281feb82a4523cb4f5ed7e9b74740d7d13 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertReceivedEvent.java
 b17071c7f384dba1cb508066fa5f808ada7487e4 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java
 1ed19a4e46d2008f0aba05b19bdbdc160b0b3437 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 23a547fbdd7e1b1fb8b6c6e660daade1e51cb4e1 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
1caa0e3221ac1452aa4822ad78e690f737dc878a 
  ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
aa53564661c49f9198d0c89ba14595258af8259b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 aecfabe52abf448fc8782992f1dd85c2767a3cc7 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
 9a6391ca33f783847ccd79352d196515be7737b3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
 68395b5cb7d23a6b37b51660aec2aeb8d20e7130 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
 890464da368b658dfb5448419917699c8e1f9c6d 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
 8d7d8ad85dcc1ec97d10b089976b5d9f20549cb7 


Diff: https://reviews.apache.org/r/62081/diff/2/

Changes: https://reviews.apache.org/r/62081/diff/1-2/


Testing
---

Manually tested on local cluster.


Thanks,

Attila Doroszlai

Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for alert definitions

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
---

(Updated Sept. 7, 2017, 1:59 p.m.)


Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor 
Magyari, Sebastian Toader, and Sid Wagle.


Changes
---

* added @JsonProperty for all attributes (to explicitly specify names)
* added @JsonInclude to avoid `null` values
* simplified some equals()/hashCode() methods


Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803


Repository: ambari


Description
---

* Added endpoint
* Created data structure to match expected JSON format
* Extracted some common logic to parent classes


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
d3ab48e4da79cc7615bd5dedfec3754ffe5accc2 
  ambari-agent/src/main/python/ambari_agent/Constants.py 
e36eda577d0195055ebe89e3eeac5c63aa4a460b 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java
 0f0a4919ba7e1343c31c8397d5309542c2463287 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java
 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java
 7035f38cfbb7a75bd4cb5721a542ef832a805c99 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java
 635611bf6d325deb33cde671556647b9c264a716 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java
 792f10ef33363fd57579792f51901681ad83aa0b 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java
 db093f85a7f304e895bad098a3ca5a62d7a3859d 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java
 b7e680627f3fd42e87b7152f9ab9de29f63a44fa 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java
 0da5d831d546da98e2284b048b914f972cacfc05 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java
 3ee5ad6d00b4c4374cba48e80d1cb410500ee586 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java
 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java
 e820401d460bc672596a4ede60abcd39646be49e 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java
 cbe6e3703960ce0af9563f41b63d2a71427b4267 
  
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java
 66ab38ea39bea2c100a2245ad422a4c6a037d7ed 
  
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java
 239b5b8184a02a057c2dc9d4a53c671dc06d9806 
  
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java
 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a 
  
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java
 1b5b90b562babe4cea18a1bd93104d72922d31fa 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
 25bc8136510574cc54fa2f3365c755e6a9426547 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java
 46ddd355b67e75da9cf98b365d830bd8cd7e20bd 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
 e197cd0050c97fa655ceefa21a5763227c1890ec 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 
c2ef5e7859464c22ce64a90a6c771eeff803ba38 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java 
21cf81c8cd0abd91940b73e60c40db4a68496637 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
 25734cd496a3d3fa2f7f89716c1080ca2798c069 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java
 92c49203a44bfd5d829f7f1835e97116029f1ee6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java
 57bba06d723470e6f8c26a4961c7e37db05ebdfa 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
 e972c621d7361538105cb54734cb2c0b582daef8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 
4aaefab33713c7641cab3775c615e87c1d96d82c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java
 d1b70701ae26c3117f7b9fb8ece2676c0f3d45cb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
 d5a69abcbb36bebd2776e61f5aa3ebcc3724df63 
  

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/#review184809
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Sept. 7, 2017, 11:12 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62119/
> ---
> 
> (Updated Sept. 7, 2017, 11:12 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.
> 
> 
> Bugs: AMBARI-21890
> https://issues.apache.org/jira/browse/AMBARI-21890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A configurable limit have been imposed on the no of files being retrieved 
> from the server and the limit by default is set to 5000.
> Search has been provided to find the file faster.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
>  d6e484d 
>   contrib/views/files/src/main/resources/ui/app/components/file-search.js 
> b65749c 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
>   contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs
>  72ed840 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
>  298d672 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
>   
> contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
>  f431f66 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
>  90fa483 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62119/diff/5/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/#review184808
---


Ship it!




Ship It!

- Padma Priya N


On Sept. 7, 2017, 10:59 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62119/
> ---
> 
> (Updated Sept. 7, 2017, 10:59 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.
> 
> 
> Bugs: AMBARI-21890
> https://issues.apache.org/jira/browse/AMBARI-21890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A configurable limit have been imposed on the no of files being retrieved 
> from the server and the limit by default is set to 5000.
> Search has been provided to find the file faster.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
>  d6e484d 
>   contrib/views/files/src/main/resources/ui/app/components/file-search.js 
> b65749c 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
>   contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs
>  72ed840 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
>  298d672 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
>   
> contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
>  f431f66 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
>  90fa483 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62119/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 62155: Add 0.7.x stack definition for Zeppelin

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62155/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21901
https://issues.apache.org/jira/browse/AMBARI-21901


Repository: ambari


Description
---

Currently, in Zeppelin, there are two stack definitions 0.6.0.2.5 and 
0.6.0.3.0. The ideas of this Jira are following:
 - rename 0.6.0.2.5 to 0.6.0
 - delete redundant 0.6.0.3.0
 - create another defination for 0.7.x as 0.7.0


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json 
8e9b6e7f4b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 e29eae321a 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/spark2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/templates/input.config-zeppelin.json.j2
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/quicklinks/quicklinks.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/role_command_order.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/alerts.json 
8e9b6e7f4b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
 b393def227 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-log4j-properties.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/kerberos.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
 7f2f57025f 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/alert_check_zeppelin.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/livy2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/master.py
 ab798ec60c 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/params.py
 2340df9dea 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/service_check.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/spark2_config_template.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/status_params.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/templates/input.config-zeppelin.json.j2
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/quicklinks/quicklinks.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/role_command_order.json
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/service_advisor.py
  
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62155/diff/1/


Testing
---

Manually on local


Thanks,

Prabhjyot Singh

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 11:12 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs 
72ed840 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/5/

Changes: https://reviews.apache.org/r/62119/diff/4-5/


Testing
---

Manual testing done.


Thanks,

venkat sairam

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/#review184807
---


Ship it!




Ship It!

- Padma Priya N


On Sept. 7, 2017, 10:59 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62119/
> ---
> 
> (Updated Sept. 7, 2017, 10:59 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.
> 
> 
> Bugs: AMBARI-21890
> https://issues.apache.org/jira/browse/AMBARI-21890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A configurable limit have been imposed on the no of files being retrieved 
> from the server and the limit by default is set to 5000.
> Search has been provided to find the file faster.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
>  d6e484d 
>   contrib/views/files/src/main/resources/ui/app/components/file-search.js 
> b65749c 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
>   contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs
>  72ed840 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
>  298d672 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
>   
> contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
>  f431f66 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
>  90fa483 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62119/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 10:59 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs 
72ed840 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/4/

Changes: https://reviews.apache.org/r/62119/diff/3-4/


Testing
---

Manual testing done.


Thanks,

venkat sairam

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/#review184806
---


Ship it!




Ship It!

- Padma Priya N


On Sept. 7, 2017, 10:59 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62119/
> ---
> 
> (Updated Sept. 7, 2017, 10:59 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.
> 
> 
> Bugs: AMBARI-21890
> https://issues.apache.org/jira/browse/AMBARI-21890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A configurable limit have been imposed on the no of files being retrieved 
> from the server and the limit by default is set to 5000.
> Search has been provided to find the file faster.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
>  d6e484d 
>   contrib/views/files/src/main/resources/ui/app/components/file-search.js 
> b65749c 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
>   contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs
>  72ed840 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
>  298d672 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
>   
> contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
>  f431f66 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
>  90fa483 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62119/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 10:51 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs 
72ed840 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/3/

Changes: https://reviews.apache.org/r/62119/diff/2-3/


Testing
---

Manual testing done.


Thanks,

venkat sairam

Re: Review Request 62151: Component status reports are sent for the components which are not on the host

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62151/#review184803
---


Ship it!




Ship It!

- Attila Doroszlai


On Sept. 7, 2017, 10:34 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62151/
> ---
> 
> (Updated Sept. 7, 2017, 10:34 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-21899
> https://issues.apache.org/jira/browse/AMBARI-21899
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py e35b219 
>   ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 
> 4ccd815 
> 
> 
> Diff: https://reviews.apache.org/r/62151/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62151: Component status reports are sent for the components which are not on the host

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62151/
---

(Updated Sept. 7, 2017, 8:34 a.m.)


Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21899
https://issues.apache.org/jira/browse/AMBARI-21899


Repository: ambari


Description (updated)
---

.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py e35b219 
  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 4ccd815 


Diff: https://reviews.apache.org/r/62151/diff/2/

Changes: https://reviews.apache.org/r/62151/diff/1-2/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 62151: Component status reports are sent for the components which are not on the host

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62151/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21899
https://issues.apache.org/jira/browse/AMBARI-21899


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 4ccd815 


Diff: https://reviews.apache.org/r/62151/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62081: AMBARI-21878. Implement STOMP endpoint to handle alerts from agent

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62081/#review184800
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 5, 2017, 2:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62081/
> ---
> 
> (Updated Sept. 5, 2017, 2:43 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor 
> Magyari, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21878
> https://issues.apache.org/jira/browse/AMBARI-21878
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Process alerts from agent at `/reports/alerts_status`
> * Add `clusterId` to alert reports since cluster name is empty
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 
> 76d83908883a1ad1c5ee44534592e86e6b75451a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  fce6be6a92104d775e5105c2056b05ff89abcfdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentReportsController.java
>  0152d89c80d5ef63850d3a9211ca7a6c7bcb72b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertReceivedEvent.java
>  b17071c7f384dba1cb508066fa5f808ada7487e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  23a547fbdd7e1b1fb8b6c6e660daade1e51cb4e1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 1caa0e3221ac1452aa4822ad78e690f737dc878a 
> 
> 
> Diff: https://reviews.apache.org/r/62081/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on local cluster.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for alert definitions

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/#review184799
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 5, 2017, 8:20 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61886/
> ---
> 
> (Updated Sept. 5, 2017, 8:20 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor 
> Magyari, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21803
> https://issues.apache.org/jira/browse/AMBARI-21803
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Added endpoint
> * Created data structure to match expected JSON format
> * Extracted some common logic to parent classes
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
> d3ab48e4da79cc7615bd5dedfec3754ffe5accc2 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 
> e36eda577d0195055ebe89e3eeac5c63aa4a460b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java
>  0f0a4919ba7e1343c31c8397d5309542c2463287 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java
>  0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java
>  7035f38cfbb7a75bd4cb5721a542ef832a805c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java
>  635611bf6d325deb33cde671556647b9c264a716 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java
>  792f10ef33363fd57579792f51901681ad83aa0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java
>  db093f85a7f304e895bad098a3ca5a62d7a3859d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java
>  b7e680627f3fd42e87b7152f9ab9de29f63a44fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java
>  0da5d831d546da98e2284b048b914f972cacfc05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java
>  3ee5ad6d00b4c4374cba48e80d1cb410500ee586 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java
>  640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java
>  e820401d460bc672596a4ede60abcd39646be49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java
>  cbe6e3703960ce0af9563f41b63d2a71427b4267 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java
>  66ab38ea39bea2c100a2245ad422a4c6a037d7ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java
>  239b5b8184a02a057c2dc9d4a53c671dc06d9806 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java
>  1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java
>  1b5b90b562babe4cea18a1bd93104d72922d31fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
>  25bc8136510574cc54fa2f3365c755e6a9426547 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java
>  46ddd355b67e75da9cf98b365d830bd8cd7e20bd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
>  e197cd0050c97fa655ceefa21a5763227c1890ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  c2ef5e7859464c22ce64a90a6c771eeff803ba38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java
>  21cf81c8cd0abd91940b73e60c40db4a68496637 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  25734cd496a3d3fa2f7f89716c1080ca2798c069 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java
>  92c49203a44bfd5d829f7f1835e97116029f1ee6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java
>  57bba06d723470e6f8c26a4961c7e37db05ebdfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
>  e972c621d7361538105cb54734cb2c0b582daef8 
> 
> 
> Diff: 

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/#review184790
---




contrib/views/files/src/main/resources/ui/app/controllers/files.js
Line 81 (original), 74 (patched)


I guess you donot need to have a computed property on validSearchText and 
sortedContent.



contrib/views/files/src/main/resources/ui/app/routes/files.js
Line 46 (original), 46 (patched)


Please use a query parameter and reload the route.


- DIPAYAN BHOWMICK


On Sept. 7, 2017, 6:36 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62119/
> ---
> 
> (Updated Sept. 7, 2017, 6:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.
> 
> 
> Bugs: AMBARI-21890
> https://issues.apache.org/jira/browse/AMBARI-21890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A configurable limit have been imposed on the no of files being retrieved 
> from the server and the limit by default is set to 5000.
> Search has been provided to find the file faster.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
>  d6e484d 
>   contrib/views/files/src/main/resources/ui/app/components/file-search.js 
> b65749c 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
>   contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
>  298d672 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
>   
> contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
>  f431f66 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
>  PRE-CREATION 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
>  90fa483 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62119/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 6:36 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/2/

Changes: https://reviews.apache.org/r/62119/diff/1-2/


Testing
---

Manual testing done.


Thanks,

venkat sairam