date:20170913

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/#review185358
---


Ship it!




Ship It!

- Sid Wagle


On Sept. 13, 2017, 10:54 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62294/
> ---
> 
> (Updated Sept. 13, 2017, 10:54 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21944
> https://issues.apache.org/jira/browse/AMBARI-21944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Batch requests(Rolling Restart, HSI enable/disable, 
> decommission/recommission) not working when Ambari is configured with Knox 
> proxy
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
>  f3b3c415ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
>  f901bda2b7 
>   ambari-web/app/controllers/main/host/details.js ad2ac98498 
>   ambari-web/app/controllers/main/service/item.js 224f83bdd9 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 140e7de641 
>   ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
>   
> ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
>  9a73a9a3e1 
> 
> 
> Diff: https://reviews.apache.org/r/62294/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster.
> verified that ambari-web unit test and ExecutionScheduleManagerTest test 
> passes successfully:
> 
>   30490 passing (20s)
>   157 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/
---

(Updated Sept. 13, 2017, 10:54 p.m.)


Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-21944
https://issues.apache.org/jira/browse/AMBARI-21944


Repository: ambari


Description
---

Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) 
not working when Ambari is configured with Knox proxy


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
 f3b3c415ee 
  
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
 f901bda2b7 
  ambari-web/app/controllers/main/host/details.js ad2ac98498 
  ambari-web/app/controllers/main/service/item.js 224f83bdd9 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
140e7de641 
  ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
  
ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
 9a73a9a3e1 


Diff: https://reviews.apache.org/r/62294/diff/2/

Changes: https://reviews.apache.org/r/62294/diff/1-2/


Testing
---

Tested manually on a cluster.
verified that ambari-web unit test and ExecutionScheduleManagerTest test passes 
successfully:

  30490 passing (20s)
  157 pending


Thanks,

Jaimin Jetly

Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

2017-09-13 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/#review185343
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 13, 2017, 2:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62289/
> ---
> 
> (Updated Sept. 13, 2017, 2:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21950
> https://issues.apache.org/jira/browse/AMBARI-21950
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The check for services in the VDF is being done AFTER setting all the hosts 
> to INSTALLING.
> 
> Added assertions to verify that is or is not happening.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  c2084b6954 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  06e8dfa8ba 
> 
> 
> Diff: https://reviews.apache.org/r/62289/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [WARNING] Tests run: 4861, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:08.786s
> [INFO] Finished at: Wed Sep 13 15:20:51 EDT 2017
> [INFO] Final Memory: 68M/1910M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 60358: Hivesevers's status shows issue for the thrift's port conflict, when hiveservers and spark thrift server installed in the same host.

2017-09-13 Thread Nate Cole



> On Sept. 12, 2017, 10:23 a.m., Nate Cole wrote:
> > What is the status of this review?

Ping


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60358/#review185187
---


On June 22, 2017, 1:55 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60358/
> ---
> 
> (Updated June 22, 2017, 1:55 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro 
> Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-21305
> https://issues.apache.org/jira/browse/AMBARI-21305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hivesevers's status shows issue for the thrift's port conflict, when 
> hiveservers and spark thrift server installed in the same host.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  74fd76a 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_service.py
>  31a296a 
> 
> 
> Diff: https://reviews.apache.org/r/60358/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/#review185336
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
Line 665 (original), 669 (patched)


If ambariWebResource is a class level reference why make it a param?



ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
Lines 803 (patched)


Why static?


- Sid Wagle


On Sept. 13, 2017, 8:25 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62294/
> ---
> 
> (Updated Sept. 13, 2017, 8:25 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21944
> https://issues.apache.org/jira/browse/AMBARI-21944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Batch requests(Rolling Restart, HSI enable/disable, 
> decommission/recommission) not working when Ambari is configured with Knox 
> proxy
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
>  f3b3c415ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
>  f901bda2b7 
>   ambari-web/app/controllers/main/host/details.js ad2ac98498 
>   ambari-web/app/controllers/main/service/item.js 224f83bdd9 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 140e7de641 
>   ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
>   
> ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
>  9a73a9a3e1 
> 
> 
> Diff: https://reviews.apache.org/r/62294/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster.
> verified that ambari-web unit test and ExecutionScheduleManagerTest test 
> passes successfully:
> 
>   30490 passing (20s)
>   157 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 62291: Last Run Service Check for SPARK Picks up SPARK2

2017-09-13 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62291/#review185337
---


Ship it!




Ship It!

- Nate Cole


On Sept. 13, 2017, 3:15 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62291/
> ---
> 
> (Updated Sept. 13, 2017, 3:15 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21951
> https://issues.apache.org/jira/browse/AMBARI-21951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install a cluster with Spark and Spark2
> - Remove Spark2
> - Change a Spark configuration
> - Run the Spark Service check
> - Attempt to perform an upgrade
> 
> The upgrade pre-checks will stop you saying something like: 
> {code}
> 02 Aug 2017 10:17:23,701  INFO [ambari-client-thread-28] 
> ServiceCheckValidityCheck:149 - Service SPARK latest config change is 
> 08-02-2017 09:45:16, latest service check executed at 12-31-1969 03:59:59
> {code}
> 
> The start time suggests a value of -1 in my cluster. The problem is that I 
> aborted my SPARK2 service check and then removed the service. However, the 
> pre-check seems to be matching on the name an incorrectly detecting the old 
> SPARK2 check as the one for SPARK:
> 
> {code}
>   boolean serviceCheckWasExecuted = false;
>   for (HostRoleCommandEntity command : latestTimestamps.values()) {
> if (null !=  command.getCommandDetail() && 
> command.getCommandDetail().contains(serviceName)) {
> {code}
> 
> Because {{contains()}} is finding {{SPARK}} in {{SPARK2_SERVICE_CHECK}}, it's 
> incorrectly picking up the wrong values...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  2a8e23fd56 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  14c8443fee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  7ac60a9dd4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  1ba0d70b57 
> 
> 
> Diff: https://reviews.apache.org/r/62291/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/
---

Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-21944
https://issues.apache.org/jira/browse/AMBARI-21944


Repository: ambari


Description (updated)
---

Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) 
not working when Ambari is configured with Knox proxy


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
 f3b3c415ee 
  
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
 f901bda2b7 
  ambari-web/app/controllers/main/host/details.js ad2ac98498 
  ambari-web/app/controllers/main/service/item.js 224f83bdd9 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
140e7de641 
  ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
  
ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
 9a73a9a3e1 


Diff: https://reviews.apache.org/r/62294/diff/1/


Testing (updated)
---

Tested manually on a cluster.
verified that ambari-web unit test and ExecutionScheduleManagerTest test passes 
successfully:

  30490 passing (20s)
  157 pending


Thanks,

Jaimin Jetly

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

2017-09-13 Thread Aravindan Vijayan



> On Sept. 13, 2017, 7:56 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
> > Lines 873 (patched)
> > 
> >
> > Is this left behind artifact?

Yes, just a missed print line. I will remove it before the commit.


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62292/#review185333
---


On Sept. 13, 2017, 7:49 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62292/
> ---
> 
> (Updated Sept. 13, 2017, 7:49 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21952
> https://issues.apache.org/jira/browse/AMBARI-21952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Refined stack advisor recommendations for AMS heap sizing.
> Added validation for 'distributed' mode when number of sinks > 1000.
> Added validation for HBase heapsizes > 32G
> Removed unneeded validations for gouging unused memory on metrics collector 
> host.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 7992c95 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 35af503 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 9c6bef1 
> 
> 
> Diff: https://reviews.apache.org/r/62292/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Python unit tests passed.
> 
> 
> File Attachments
> 
> 
> Heap estimates for various size clusters
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/13/ce769beb-f026-4d9e-9530-3218327584be__Screen_Shot_2017-09-13_at_12.13.24_PM.png
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

2017-09-13 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62292/#review185333
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
Lines 873 (patched)


Is this left behind artifact?


- Sid Wagle


On Sept. 13, 2017, 7:49 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62292/
> ---
> 
> (Updated Sept. 13, 2017, 7:49 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21952
> https://issues.apache.org/jira/browse/AMBARI-21952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Refined stack advisor recommendations for AMS heap sizing.
> Added validation for 'distributed' mode when number of sinks > 1000.
> Added validation for HBase heapsizes > 32G
> Removed unneeded validations for gouging unused memory on metrics collector 
> host.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 7992c95 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 35af503 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 9c6bef1 
> 
> 
> Diff: https://reviews.apache.org/r/62292/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Python unit tests passed.
> 
> 
> File Attachments
> 
> 
> Heap estimates for various size clusters
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/13/ce769beb-f026-4d9e-9530-3218327584be__Screen_Shot_2017-09-13_at_12.13.24_PM.png
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-13 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/
---

(Updated Sept. 13, 2017, 3:52 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian Toader.


Bugs: AMBARI-21938
https://issues.apache.org/jira/browse/AMBARI-21938


Repository: ambari


Description
---

Validate kerberos.json files to ensure they meet the expected schema.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
 0d1da9c743 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 5658133c9b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
 768a17e3b3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
 7930e38f39 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 0eb3733584 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 911723b80b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
 a17caadda0 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
 74254e3fe3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
 5da33997ab 
  ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
c9d8c91372 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
 0f1dd55044 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
 09699c6fd6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
 e891fdea4e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
 7fb56248e5 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
 d11962b9a3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
 8cdb39e02e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
 b84223f421 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
 e4d3c90767 


Diff: https://reviews.apache.org/r/62290/diff/2/

Changes: https://reviews.apache.org/r/62290/diff/1-2/


Testing
---

Ensured the following unit tests passed:

- org.apache.ambari.server.stack.KerberosDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest


Thanks,

Robert Levas

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

2017-09-13 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62292/
---

(Updated Sept. 13, 2017, 7:49 p.m.)


Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.


Bugs: AMBARI-21952
https://issues.apache.org/jira/browse/AMBARI-21952


Repository: ambari


Description
---

Refined stack advisor recommendations for AMS heap sizing.
Added validation for 'distributed' mode when number of sinks > 1000.
Added validation for HBase heapsizes > 32G
Removed unneeded validations for gouging unused memory on metrics collector 
host.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
7992c95 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
35af503 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9c6bef1 


Diff: https://reviews.apache.org/r/62292/diff/1/


Testing
---

Manually tested.
Python unit tests passed.


File Attachments (updated)


Heap estimates for various size clusters
  
https://reviews.apache.org/media/uploaded/files/2017/09/13/ce769beb-f026-4d9e-9530-3218327584be__Screen_Shot_2017-09-13_at_12.13.24_PM.png


Thanks,

Aravindan Vijayan

Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

2017-09-13 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62292/
---

Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.


Bugs: AMBARI-21952
https://issues.apache.org/jira/browse/AMBARI-21952


Repository: ambari


Description
---

Refined stack advisor recommendations for AMS heap sizing.
Added validation for 'distributed' mode when number of sinks > 1000.
Added validation for HBase heapsizes > 32G
Removed unneeded validations for gouging unused memory on metrics collector 
host.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
7992c95 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
35af503 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9c6bef1 


Diff: https://reviews.apache.org/r/62292/diff/1/


Testing
---

Manually tested.
Python unit tests passed.


Thanks,

Aravindan Vijayan

Re: Review Request 62291: Last Run Service Check for SPARK Picks up SPARK2

2017-09-13 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62291/#review185329
---




ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
Lines 75-83 (original)


Don't get back every servick check from the dawn of time - use SQL to 
produce GROUP'd results for us.



ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
Lines 117-120 (patched)


ActionMetadata basically turns "FOO" into "FOO_SERVICE_CHECK" ... but it 
also knows that ZOOKEEPER -> ZOOKEEPER_QUORUM_SERVICE_CHECK. Since this logic 
is centralized here, we should re-use it instead of trying to calculate the 
role ourselves.



ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
Lines 108-110 (patched)


Reformatted this block of NamedQuerys ... This is the only new one.


- Jonathan Hurley


On Sept. 13, 2017, 3:15 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62291/
> ---
> 
> (Updated Sept. 13, 2017, 3:15 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21951
> https://issues.apache.org/jira/browse/AMBARI-21951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install a cluster with Spark and Spark2
> - Remove Spark2
> - Change a Spark configuration
> - Run the Spark Service check
> - Attempt to perform an upgrade
> 
> The upgrade pre-checks will stop you saying something like: 
> {code}
> 02 Aug 2017 10:17:23,701  INFO [ambari-client-thread-28] 
> ServiceCheckValidityCheck:149 - Service SPARK latest config change is 
> 08-02-2017 09:45:16, latest service check executed at 12-31-1969 03:59:59
> {code}
> 
> The start time suggests a value of -1 in my cluster. The problem is that I 
> aborted my SPARK2 service check and then removed the service. However, the 
> pre-check seems to be matching on the name an incorrectly detecting the old 
> SPARK2 check as the one for SPARK:
> 
> {code}
>   boolean serviceCheckWasExecuted = false;
>   for (HostRoleCommandEntity command : latestTimestamps.values()) {
> if (null !=  command.getCommandDetail() && 
> command.getCommandDetail().contains(serviceName)) {
> {code}
> 
> Because {{contains()}} is finding {{SPARK}} in {{SPARK2_SERVICE_CHECK}}, it's 
> incorrectly picking up the wrong values...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  2a8e23fd56 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  14c8443fee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  7ac60a9dd4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  1ba0d70b57 
> 
> 
> Diff: https://reviews.apache.org/r/62291/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 62291: Last Run Service Check for SPARK Picks up SPARK2

2017-09-13 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62291/
---

Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-21951
https://issues.apache.org/jira/browse/AMBARI-21951


Repository: ambari


Description
---

STR:

- Install a cluster with Spark and Spark2
- Remove Spark2
- Change a Spark configuration
- Run the Spark Service check
- Attempt to perform an upgrade

The upgrade pre-checks will stop you saying something like: 
{code}
02 Aug 2017 10:17:23,701  INFO [ambari-client-thread-28] 
ServiceCheckValidityCheck:149 - Service SPARK latest config change is 
08-02-2017 09:45:16, latest service check executed at 12-31-1969 03:59:59
{code}

The start time suggests a value of -1 in my cluster. The problem is that I 
aborted my SPARK2 service check and then removed the service. However, the 
pre-check seems to be matching on the name an incorrectly detecting the old 
SPARK2 check as the one for SPARK:

{code}
  boolean serviceCheckWasExecuted = false;
  for (HostRoleCommandEntity command : latestTimestamps.values()) {
if (null !=  command.getCommandDetail() && 
command.getCommandDetail().contains(serviceName)) {
{code}

Because {{contains()}} is finding {{SPARK}} in {{SPARK2_SERVICE_CHECK}}, it's 
incorrectly picking up the wrong values...


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 2a8e23fd56 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 14c8443fee 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
 7ac60a9dd4 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
 1ba0d70b57 


Diff: https://reviews.apache.org/r/62291/diff/1/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-13 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian Toader.


Bugs: AMBARI-21938
https://issues.apache.org/jira/browse/AMBARI-21938


Repository: ambari


Description
---

Validate kerberos.json files to ensure they meet the expected schema.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
 0d1da9c743 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 5658133c9b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
 768a17e3b3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java
 7930e38f39 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 0eb3733584 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 911723b80b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
 a17caadda0 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
 74254e3fe3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
 5da33997ab 
  ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
c9d8c91372 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
 0f1dd55044 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
 09699c6fd6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
 e891fdea4e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
 7fb56248e5 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
 d11962b9a3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
 8cdb39e02e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
 b84223f421 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
 e4d3c90767 


Diff: https://reviews.apache.org/r/62290/diff/1/


Testing
---

Ensured the following unit tests passed:

- org.apache.ambari.server.stack.KerberosDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest


Thanks,

Robert Levas

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

2017-09-13 Thread Jason Golieb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62242/
---

(Updated Sept. 13, 2017, 6:31 p.m.)


Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako.


Changes
---

Updated summary


Summary (updated)
-

AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal


Bugs: AMBARI-21933
https://issues.apache.org/jira/browse/AMBARI-21933


Repository: ambari


Description
---

Implement breadcrumb navigation in the Background Operations modal and the 
drill-down views within it. This also affects the use of these views in the 
High Availability wizard. The breadcrumbs will provide a better navigation 
experience within this series of dialogs, helping the user to see the context 
of the current view and to navigate back up the hierarchy more easily. It will 
also be more consistent with the overall UX of Ambari 3.0.0.


Diffs
-

  ambari-web/app/controllers/global/background_operations_controller.js 
de420b5a131 
  
ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js
 4cbe59b020c 
  ambari-web/app/messages.js 87a5e97a68d 
  ambari-web/app/styles/modal_popups.less f7fe88be71d 
  ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 
  ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 
  ambari-web/app/utils/host_progress_popup.js 5bd02cd76de 
  ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 
  ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 
  ambari-web/test/controllers/global/background_operations_test.js 4a8235c484b 
  
ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js
 364d9b0b451 
  ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 
  ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 
  ambari-web/test/views/common/host_progress_popup_body_view_test.js 
5ccc0245101 


Diff: https://reviews.apache.org/r/62242/diff/2/


Testing
---

21293 passing


Thanks,

Jason Golieb

Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

2017-09-13 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-21950
https://issues.apache.org/jira/browse/AMBARI-21950


Repository: ambari


Description
---

The check for services in the VDF is being done AFTER setting all the hosts to 
INSTALLING.

Added assertions to verify that is or is not happening.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 c2084b6954 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 06e8dfa8ba 


Diff: https://reviews.apache.org/r/62289/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 62245: Preview. Auto fix enhancement to remove more than 1 selected configs

2017-09-13 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62245/
---

(Updated Sept. 13, 2017, 9:10 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Fixed tests


Bugs: AMBARI-21935
https://issues.apache.org/jira/browse/AMBARI-21935


Repository: ambari


Description
---

Sometimes Ambari is coming up with issues like more than 1 selected configs.

Error:
{noformat}
ERROR - You have config(s), in cluster BMOHDPQA01, that is(are) selected more 
than once in clusterconfigmapping table: 
falcon-startup.properties,zoo.cfg,zeppelin-config,zookeeper-log4j,tagsync-application-properties,storm-worker-log4j,hive-log4j2,admin-properties,oozie-env,ssl-server,hadoop-policy,infra-solr-log4j,oozie-log4j,core-site,mahout-log4j,kafka-broker,pig-log4j,livy-env,zeppelin-env,hive-log4j,slider-client,tez-env,storm-env,ranger-storm-plugin-properties,oozie-site,falcon-env,beeline-log4j2,ranger-storm-policymgr-ssl,falcon-runtime.properties,ranger-storm-security,hbase-policy,ams-env,capacity-scheduler,webhcat-log4j,atlas-log4j,livy-log4j-properties,spark-metrics-properties,hbase-env,ranger-atlas-security,flume-env,sqoop-atlas-application.properties,admin-log4j,hiveserver2-interactive-site,ranger-tagsync-site,application-properties,ranger-kafka-policymgr-ssl,ranger-admin-site,ranger-env,ranger-storm-audit,ranger-hbase-policymgr-ssl,hdfs-log4j
{noformat}

It is very difficult to fix these kind of issues with queries. including auto 
fix for this will be very helpful.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 575485bd54 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
a23b914f34 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
 9bf03b343f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 6c6c00f947 


Diff: https://reviews.apache.org/r/62245/diff/3/

Changes: https://reviews.apache.org/r/62245/diff/2-3/


Testing (updated)
---

mvn clean test
live check on cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 62259: Upgrade to IOP 4.2.5 from IOP 4.1 failed with combined Solr host names longer than item_text column size in table upgrade_item

2017-09-13 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62259/#review185308
---


Ship it!




Ship It!

- Robert Levas


On Sept. 12, 2017, 9:03 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62259/
> ---
> 
> (Updated Sept. 12, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Jayush Luniya, 
> Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21942
> https://issues.apache.org/jira/browse/AMBARI-21942
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Basically the problem here happens when Ambari is attempting to insert
> into the following upgrade_itme:item_text table:column,
> INSERT INTO upgrade_item (upgrade_item_id, hosts, item_text, stage_id,
> state, tasks, upgrade_group_id) VALUES (?, ?, ?, ?, ?, ?, ?)
> 
> The message string for SOLR includes all the SOLR node hostnames whose 
> combined string length exceeds the column length defined for "item_text" of 
> 1024 characters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 9564934 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  35ea769 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  9e145c0 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b9c6985 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c53cd7b 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6f754bb 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 19c0214 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8567d09 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql fdbad09 
> 
> 
> Diff: https://reviews.apache.org/r/62259/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified the upgrade resulted in expansion on PostgreSQL.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62259: Upgrade to IOP 4.2.5 from IOP 4.1 failed with combined Solr host names longer than item_text column size in table upgrade_item

2017-09-13 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62259/#review185307
---


Ship it!




Ship It!

- Nate Cole


On Sept. 12, 2017, 9:03 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62259/
> ---
> 
> (Updated Sept. 12, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Jayush Luniya, 
> Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21942
> https://issues.apache.org/jira/browse/AMBARI-21942
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Basically the problem here happens when Ambari is attempting to insert
> into the following upgrade_itme:item_text table:column,
> INSERT INTO upgrade_item (upgrade_item_id, hosts, item_text, stage_id,
> state, tasks, upgrade_group_id) VALUES (?, ?, ?, ?, ?, ?, ?)
> 
> The message string for SOLR includes all the SOLR node hostnames whose 
> combined string length exceeds the column length defined for "item_text" of 
> 1024 characters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 9564934 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  35ea769 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  9e145c0 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b9c6985 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c53cd7b 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6f754bb 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 19c0214 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8567d09 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql fdbad09 
> 
> 
> Diff: https://reviews.apache.org/r/62259/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified the upgrade resulted in expansion on PostgreSQL.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Nate Cole



> On Sept. 13, 2017, 10:35 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
> > Line 142 (original), 150 (patched)
> > 
> >
> > Maybe ConcurrentHashMap here? If we put tasks from another thread

This map is not added-to in a concurrent fashion


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62258/#review185295
---


On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62258/
> ---
> 
> (Updated Sept. 12, 2017, 4:10 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-21941
> https://issues.apache.org/jira/browse/AMBARI-21941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Starting Ambari will load all the hdp_urlinfo.json and files and VDF in a 
> sequential manner.  This is all in a single-threaded Executor.  When that 
> happens, the data can take upwards of a full minute to be populated in some 
> cases.  This should be multi-threaded.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021059 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> cbbe92e8cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> f1412f543e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  c43ce7c628 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62258/diff/1/
> 
> 
> Testing
> ---
> 
> This is a refactor only.  Existing tests cover the functionality needed while 
> just adding a performance boost to loading VDF.
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62258/#review185295
---




ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
Line 142 (original), 150 (patched)


Maybe ConcurrentHashMap here? If we put tasks from another thread



ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
Lines 79 (patched)


obsolete?



ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
Lines 204 (patched)


formatting



ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
Lines 212 (patched)


formatting


- Dmitro Lisnichenko


On Sept. 12, 2017, 11:10 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62258/
> ---
> 
> (Updated Sept. 12, 2017, 11:10 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-21941
> https://issues.apache.org/jira/browse/AMBARI-21941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Starting Ambari will load all the hdp_urlinfo.json and files and VDF in a 
> sequential manner.  This is all in a single-threaded Executor.  When that 
> happens, the data can take upwards of a full minute to be populated in some 
> cases.  This should be multi-threaded.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021059 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> cbbe92e8cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> f1412f543e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  c43ce7c628 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62258/diff/1/
> 
> 
> Testing
> ---
> 
> This is a refactor only.  Existing tests cover the functionality needed while 
> just adding a performance boost to loading VDF.
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62245: Preview. Auto fix enhancement to remove more than 1 selected configs

2017-09-13 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62245/
---

(Updated Sept. 13, 2017, 5:15 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Addressed Jonathans comment. Also, changed checks to warn instead of failure 
(according to Should only WARN column in table from jira)


Summary (updated)
-

Preview. Auto fix enhancement to remove more than 1 selected configs


Bugs: AMBARI-21935
https://issues.apache.org/jira/browse/AMBARI-21935


Repository: ambari


Description
---

Sometimes Ambari is coming up with issues like more than 1 selected configs.

Error:
{noformat}
ERROR - You have config(s), in cluster BMOHDPQA01, that is(are) selected more 
than once in clusterconfigmapping table: 
falcon-startup.properties,zoo.cfg,zeppelin-config,zookeeper-log4j,tagsync-application-properties,storm-worker-log4j,hive-log4j2,admin-properties,oozie-env,ssl-server,hadoop-policy,infra-solr-log4j,oozie-log4j,core-site,mahout-log4j,kafka-broker,pig-log4j,livy-env,zeppelin-env,hive-log4j,slider-client,tez-env,storm-env,ranger-storm-plugin-properties,oozie-site,falcon-env,beeline-log4j2,ranger-storm-policymgr-ssl,falcon-runtime.properties,ranger-storm-security,hbase-policy,ams-env,capacity-scheduler,webhcat-log4j,atlas-log4j,livy-log4j-properties,spark-metrics-properties,hbase-env,ranger-atlas-security,flume-env,sqoop-atlas-application.properties,admin-log4j,hiveserver2-interactive-site,ranger-tagsync-site,application-properties,ranger-kafka-policymgr-ssl,ranger-admin-site,ranger-env,ranger-storm-audit,ranger-hbase-policymgr-ssl,hdfs-log4j
{noformat}

It is very difficult to fix these kind of issues with queries. including auto 
fix for this will be very helpful.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 575485bd54 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
a23b914f34 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
 9bf03b343f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 6c6c00f947 


Diff: https://reviews.apache.org/r/62245/diff/2/

Changes: https://reviews.apache.org/r/62245/diff/1-2/


Testing (updated)
---

still updating tests


Thanks,

Dmitro Lisnichenko

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Nate Cole



> On Sept. 13, 2017, 9:21 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
> > Lines 204 (patched)
> > 
> >
> > Should we log a warning here (not exception, but just message?

Thanks for reviewing.  Will do.


> On Sept. 13, 2017, 9:21 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
> > Lines 156 (patched)
> > 
> >
> > How many of these calls are there usually? If only like 10, then maybe 
> > log to INFO since it only happens on startup? If 100, I guess debug is 
> > right.

Yeah, I thought of that - the issue I have is that it will give you an idea of 
an individual VDF, but not how long it takes as a whole.  And since versions 
are loaded in their own threads, you'll see mixed VDF messages interspersed 
with one another.  The most I've seen is around 120


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62258/#review185284
---


On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62258/
> ---
> 
> (Updated Sept. 12, 2017, 4:10 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-21941
> https://issues.apache.org/jira/browse/AMBARI-21941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Starting Ambari will load all the hdp_urlinfo.json and files and VDF in a 
> sequential manner.  This is all in a single-threaded Executor.  When that 
> happens, the data can take upwards of a full minute to be populated in some 
> cases.  This should be multi-threaded.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021059 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> cbbe92e8cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> f1412f543e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  c43ce7c628 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62258/diff/1/
> 
> 
> Testing
> ---
> 
> This is a refactor only.  Existing tests cover the functionality needed while 
> just adding a performance boost to loading VDF.
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Nate Cole



> On Sept. 12, 2017, 5:14 p.m., Dmytro Grinenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
> > Line 151 (original), 159 (patched)
> > 
> >
> > can we move amount of threads to constant, to make it more easy to tune 
> > in the future?

Will do.


> On Sept. 12, 2017, 5:14 p.m., Dmytro Grinenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
> > Lines 219 (patched)
> > 
> >
> > Looks like not used assign

Thanks for reviewing.  Will fix this - it was part of debugging.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62258/#review185235
---


On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62258/
> ---
> 
> (Updated Sept. 12, 2017, 4:10 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-21941
> https://issues.apache.org/jira/browse/AMBARI-21941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Starting Ambari will load all the hdp_urlinfo.json and files and VDF in a 
> sequential manner.  This is all in a single-threaded Executor.  When that 
> happens, the data can take upwards of a full minute to be populated in some 
> cases.  This should be multi-threaded.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021059 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> cbbe92e8cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> f1412f543e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  c43ce7c628 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62258/diff/1/
> 
> 
> Testing
> ---
> 
> This is a refactor only.  Existing tests cover the functionality needed while 
> just adding a performance boost to loading VDF.
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62258/#review185284
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
Lines 204 (patched)


Should we log a warning here (not exception, but just message?



ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
Lines 156 (patched)


How many of these calls are there usually? If only like 10, then maybe log 
to INFO since it only happens on startup? If 100, I guess debug is right.


- Jonathan Hurley


On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62258/
> ---
> 
> (Updated Sept. 12, 2017, 4:10 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-21941
> https://issues.apache.org/jira/browse/AMBARI-21941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Starting Ambari will load all the hdp_urlinfo.json and files and VDF in a 
> sequential manner.  This is all in a single-threaded Executor.  When that 
> happens, the data can take upwards of a full minute to be populated in some 
> cases.  This should be multi-threaded.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021059 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> cbbe92e8cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> f1412f543e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  c43ce7c628 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62258/diff/1/
> 
> 
> Testing
> ---
> 
> This is a refactor only.  Existing tests cover the functionality needed while 
> just adding a performance boost to loading VDF.
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62277: Log Search UI: reorganize generated files structure

2017-09-13 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62277/#review185283
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Сен. 13, 2017, 1:16 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62277/
> ---
> 
> (Updated Сен. 13, 2017, 1:16 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-21946
> https://issues.apache.org/jira/browse/AMBARI-21946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the resources (scripts/styles/fonts) for ```dist/index.html``` should be 
> placed into ```resources``` directory.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 
>   ambari-logsearch/ambari-logsearch-web/README.md ff1456e 
>   ambari-logsearch/ambari-logsearch-web/package.json 0892d85 
>   ambari-logsearch/ambari-logsearch-web/pom.xml 075527b 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc 
>   ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62277/diff/3/
> 
> 
> Testing
> ---
> 
> Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Re: Review Request 62277: Log Search UI: reorganize generated files structure

2017-09-13 Thread Andrii Babiichuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62277/
---

(Updated Вер. 13, 2017, 1:16 після полудня)


Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-21946
https://issues.apache.org/jira/browse/AMBARI-21946


Repository: ambari


Description
---

All the resources (scripts/styles/fonts) for ```dist/index.html``` should be 
placed into ```resources``` directory.


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 
  ambari-logsearch/ambari-logsearch-web/README.md ff1456e 
  ambari-logsearch/ambari-logsearch-web/package.json 0892d85 
  ambari-logsearch/ambari-logsearch-web/pom.xml 075527b 
  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc 
  ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION 


Diff: https://reviews.apache.org/r/62277/diff/3/

Changes: https://reviews.apache.org/r/62277/diff/2-3/


Testing
---

Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 62277: Log Search UI: reorganize generated files structure

2017-09-13 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62277/#review185281
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Сен. 13, 2017, 12:06 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62277/
> ---
> 
> (Updated Сен. 13, 2017, 12:06 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-21946
> https://issues.apache.org/jira/browse/AMBARI-21946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the resources (scripts/styles/fonts) for ```dist/index.html``` should be 
> placed into ```resources``` directory.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 
>   ambari-logsearch/ambari-logsearch-web/README.md ff1456e 
>   ambari-logsearch/ambari-logsearch-web/package.json 0892d85 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc 
>   ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62277/diff/2/
> 
> 
> Testing
> ---
> 
> Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Re: Review Request 62277: Log Search UI: reorganize generated files structure

2017-09-13 Thread Andrii Babiichuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62277/
---

(Updated Вер. 13, 2017, 12:06 після полудня)


Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-21946
https://issues.apache.org/jira/browse/AMBARI-21946


Repository: ambari


Description
---

All the resources (scripts/styles/fonts) for ```dist/index.html``` should be 
placed into ```resources``` directory.


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 
  ambari-logsearch/ambari-logsearch-web/README.md ff1456e 
  ambari-logsearch/ambari-logsearch-web/package.json 0892d85 
  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc 
  ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION 


Diff: https://reviews.apache.org/r/62277/diff/2/

Changes: https://reviews.apache.org/r/62277/diff/1-2/


Testing
---

Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 62278: Ambari updates database/tables location from intended remote HDFS to local HDFS

2017-09-13 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62278/#review185279
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 13, 2017, 11:17 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62278/
> ---
> 
> (Updated Вер. 13, 2017, 11:17 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21947
> https://issues.apache.org/jira/browse/AMBARI-21947
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  05b395d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  956438e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  eb16778 
> 
> 
> Diff: https://reviews.apache.org/r/62278/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62277: Log Search UI: reorganize generated files structure

2017-09-13 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62277/#review185278
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Сен. 13, 2017, 11:19 д.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62277/
> ---
> 
> (Updated Сен. 13, 2017, 11:19 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-21946
> https://issues.apache.org/jira/browse/AMBARI-21946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the resources (scripts/styles/fonts) for ```dist/index.html``` should be 
> placed into ```resources``` directory.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 
>   ambari-logsearch/ambari-logsearch-web/package.json 0892d85 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc 
>   ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62277/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 62277: Log Search UI: reorganize generated files structure

2017-09-13 Thread Andrii Babiichuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62277/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-21946
https://issues.apache.org/jira/browse/AMBARI-21946


Repository: ambari


Description
---

All the resources (scripts/styles/fonts) for ```dist/index.html``` should be 
placed into ```resources``` directory.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 
  ambari-logsearch/ambari-logsearch-web/package.json 0892d85 
  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc 
  ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION 


Diff: https://reviews.apache.org/r/62277/diff/1/


Testing
---

Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)


Thanks,

Andrii Babiichuk

Review Request 62278: Ambari updates database/tables location from intended remote HDFS to local HDFS

2017-09-13 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62278/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21947
https://issues.apache.org/jira/browse/AMBARI-21947


Repository: ambari


Description
---


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 05b395d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 956438e 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
eb16778 


Diff: https://reviews.apache.org/r/62278/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-09-13 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review185274
---


Ship it!




Ship It!

- Oliver Szabo


On Sept. 12, 2017, 3:30 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Sept. 12, 2017, 3:30 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/7/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62182: Ambari is setting "atlas.graph.storage.hostname" to hbase hostname, instead it should set the zookeeper quorum.

2017-09-13 Thread Sebastian Toader



> On Sept. 12, 2017, 5:09 p.m., Ayub Pathan wrote:
> > I dont see UTs added for BlueprintConfigurationProcessor.java. But the 
> > patch attached to the jira has the tests changes as well. Please check.

Thanks for pointing it out. I uploaded the wrong patch.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62182/#review185192
---


On Sept. 12, 2017, 5:18 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62182/
> ---
> 
> (Updated Sept. 12, 2017, 5:18 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Ayub Pathan, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-21902
> https://issues.apache.org/jira/browse/AMBARI-21902
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari is setting "atlas.graph.storage.hostname" to hbase hostname, instead 
> it should set to zookeeper quorum. The property updater in the blueprint 
> processor responsible for resolving this property needed to be reconfigured 
> to set this property to zookeeper server host name.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  3538945 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  734dd7e 
> 
> 
> Diff: https://reviews.apache.org/r/62182/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing cluster creation using blueprints.
> Testing Blueprint export.
> 
> Unit tests:
> [INFO] Results:
> [INFO] 
> [WARNING] Tests run: 4870, Failures: 0, Errors: 0, Skipped: 37
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

Re: Review Request 60358: Hivesevers's status shows issue for the thrift's port conflict, when hiveservers and spark thrift server installed in the same host.

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

Re: Review Request 62291: Last Run Service Check for SPARK Picks up SPARK2

Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

Re: Review Request 62291: Last Run Service Check for SPARK Picks up SPARK2

Review Request 62291: Last Run Service Check for SPARK Picks up SPARK2

Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

Re: Review Request 62245: Preview. Auto fix enhancement to remove more than 1 selected configs

Re: Review Request 62259: Upgrade to IOP 4.2.5 from IOP 4.1 failed with combined Solr host names longer than item_text column size in table upgrade_item

Re: Review Request 62259: Upgrade to IOP 4.2.5 from IOP 4.1 failed with combined Solr host names longer than item_text column size in table upgrade_item

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

Re: Review Request 62245: Preview. Auto fix enhancement to remove more than 1 selected configs

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

Re: Review Request 62277: Log Search UI: reorganize generated files structure

Re: Review Request 62277: Log Search UI: reorganize generated files structure

Re: Review Request 62277: Log Search UI: reorganize generated files structure

Re: Review Request 62277: Log Search UI: reorganize generated files structure

Re: Review Request 62278: Ambari updates database/tables location from intended remote HDFS to local HDFS

Re: Review Request 62277: Log Search UI: reorganize generated files structure

Review Request 62277: Log Search UI: reorganize generated files structure

Review Request 62278: Ambari updates database/tables location from intended remote HDFS to local HDFS

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

Re: Review Request 62182: Ambari is setting "atlas.graph.storage.hostname" to hbase hostname, instead it should set the zookeeper quorum.

36 matches

Site Navigation

Mail list logo

Footer information