Re: Review Request 44487: AMBARI-15327 Combo Search: Query for multiple facets and display label instead of value in search box
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44487/#review122782 --- Ship it! Ship It! - Richard Zang On March 9, 2016, 2:20 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44487/ > --- > > (Updated March 9, 2016, 2:20 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-15327 > https://issues.apache.org/jira/browse/AMBARI-15327 > > > Repository: ambari > > > Description > --- > > Currently we allow only one component state facet but can be > supported using .in(). Add query support for multiple facet. > Display label instead of value in search box > > > Diffs > - > > ambari-web/app/controllers/main/host.js b473c59 > ambari-web/app/controllers/main/host/combo_search_box.js 9fa6851 > ambari-web/app/mixins/common/table_server_view_mixin.js eca17d6 > ambari-web/app/views/main/host/combo_search_box.js 17c0a6d > ambari-web/test/controllers/main/host_test.js 06a4813 > > Diff: https://reviews.apache.org/r/44487/diff/ > > > Testing > --- > > Modified unit test. Local ambari-web test passed. > 24565 tests complete (21 seconds) > 145 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 44598: AMBARI-15362 Combo Search: use component models instead of host component model to populate dropdown list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44598/#review122831 --- Ship it! Ship It! - Richard Zang On March 9, 2016, 11:18 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44598/ > --- > > (Updated March 9, 2016, 11:18 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-15362 > https://issues.apache.org/jira/browse/AMBARI-15362 > > > Repository: ambari > > > Description > --- > > Use MasterComponent, SlaveComponent and ClientComponent instead of > HostComponent to populate dropdown list, as they have complete info. > Make Rack filter to interactive based on input > Cleanup some unused template: component_filter, version_filter > > > Diffs > - > > ambari-web/app/controllers/main/host/combo_search_box.js 6f64170 > ambari-web/app/templates/main/host/component_filter.hbs d212533 > ambari-web/app/templates/main/host/version_filter.hbs f16e8b5 > ambari-web/app/views/main/host/combo_search_box.js 3ccacf2 > > Diff: https://reviews.apache.org/r/44598/diff/ > > > Testing > --- > > Local ambari-web test passed. > 24565 tests complete (21 seconds) > 145 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 44681: AMBARI-15378 Create multiple version state filters instead of one combined one on host page for version page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44681/#review123024 --- Ship it! Ship It! - Richard Zang On March 10, 2016, 10:58 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44681/ > --- > > (Updated March 10, 2016, 10:58 p.m.) > > > Review request for Ambari, Andrii Tkach, Jaimin Jetly, Richard Zang, Srimanth > Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15378 > https://issues.apache.org/jira/browse/AMBARI-15378 > > > Repository: ambari > > > Description > --- > > On version detail of versions page, if click the number of Not Installed > hosts, it will try to create filter "Version State: Installing, Installing, > Out of Sync", which is not a supported format of combo search box. > It should create 3 individual filters. > > > Diffs > - > > ambari-web/app/controllers/main/host.js efc0ba2 > > Diff: https://reviews.apache.org/r/44681/diff/ > > > Testing > --- > > Local ambari-web test passed. > 24562 tests complete (21 seconds) > 145 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 44683: AMBARI-14456. Role based access control UX fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44683/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-14456 https://issues.apache.org/jira/browse/AMBARI-14456 Repository: ambari Description --- Role based access control UX fixes Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 45130f7 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 50a2dab ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 2579a38 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js af77596 ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c435914 ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html c0e8f1e ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html 8c12a25 ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 3bb89ba ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js 8239653 Diff: https://reviews.apache.org/r/44683/diff/ Testing --- Manually tested on live cluster. Skipped old ui test. Will add tests for new UI in furture. Thanks, Richard Zang
Re: Review Request 44683: AMBARI-14456. Role based access control UX fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44683/ --- (Updated March 11, 2016, 1:18 a.m.) Review request for Ambari and Xi Wang. Changes --- Filter/Value list adjustment. UI adjustment. Bugs: AMBARI-14456 https://issues.apache.org/jira/browse/AMBARI-14456 Repository: ambari Description --- Role based access control UX fixes Diffs (updated) - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 45130f7 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 50a2dab ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 2579a38 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js af77596 ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c435914 ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html c0e8f1e ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html 8c12a25 ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 3bb89ba ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js 8239653 Diff: https://reviews.apache.org/r/44683/diff/ Testing --- Manually tested on live cluster. Skipped old ui test. Will add tests for new UI in furture. Thanks, Richard Zang
Re: Review Request 44683: AMBARI-14556. Role based access control UX fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44683/ --- (Updated March 11, 2016, 1:20 a.m.) Review request for Ambari and Xi Wang. Summary (updated) - AMBARI-14556. Role based access control UX fixes Bugs: AMBARI-14556 https://issues.apache.org/jira/browse/AMBARI-14556 Repository: ambari Description --- Role based access control UX fixes Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 45130f7 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 50a2dab ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 2579a38 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js af77596 ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c435914 ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html c0e8f1e ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html 8c12a25 ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 3bb89ba ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js 8239653 Diff: https://reviews.apache.org/r/44683/diff/ Testing --- Manually tested on live cluster. Skipped old ui test. Will add tests for new UI in furture. Thanks, Richard Zang
Review Request 44809: RBAC: Name filter does not work for user with no role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44809/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15411 https://issues.apache.org/jira/browse/AMBARI-15411 Repository: ambari Description --- When user has no role, principle_name does not exist, so we have to fix url building logic to user either user or group name. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js d01646a Diff: https://reviews.apache.org/r/44809/diff/ Testing --- Manually tested on live cluster. All unit test passed. Thanks, Richard Zang
Re: Review Request 44814: Version Register/manage: UX edits #1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44814/#review123544 --- Ship it! Ship It! - Richard Zang On March 14, 2016, 11:57 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44814/ > --- > > (Updated March 14, 2016, 11:57 p.m.) > > > Review request for Ambari, Jaimin Jetly and Richard Zang. > > > Bugs: AMBARI-15414 > https://issues.apache.org/jira/browse/AMBARI-15414 > > > Repository: ambari > > > Description > --- > > see attached images > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 544e282 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 4b42f2e > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 07eb607 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > 1eac23f > ambari-web/app/styles/stack_versions.less 458a32e > > ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_column.hbs > c343151 > > ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js > 346c10c > > Diff: https://reviews.apache.org/r/44814/diff/ > > > Testing > --- > > All UT passed > > > Thanks, > > Xi Wang > >
Review Request 44960: AMBARI-15466. RBAC: Add dialog popup to explain roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44960/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15466 https://issues.apache.org/jira/browse/AMBARI-15466 Repository: ambari Description --- Add dialog popup to show access control list which is based on back-end role & authorization data. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/index.html 6557b55 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 8f932e1 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 228be5c ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js 806247a ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RoleDetailsModal.js PRE-CREATION ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css b705a90 ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html fd5285e ambari-admin/src/main/resources/ui/admin-web/app/views/modals/RoleDetailsModal.html PRE-CREATION ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js e63f34e Diff: https://reviews.apache.org/r/44960/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Review Request 45138: Fix Spark version display
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45138/ --- Review request for Ambari and Yusaku Sako. Bugs: AMBARI-15497 https://issues.apache.org/jira/browse/AMBARI-15497 Repository: ambari Description --- Fix Spark version display 1.6.1.4.5 => 1.6.X.2.4 Diffs - ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 2214bdf Diff: https://reviews.apache.org/r/45138/diff/ Testing --- Manually tested on live cluster with spark version changed in HDP-2.4 definition. Spark installed successfully. Thanks, Richard Zang
Review Request 45143: AMBARI-15504. Host filter: minor UX edits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45143/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15504 https://issues.apache.org/jira/browse/AMBARI-15504 Repository: ambari Description --- Various UI fixes for combo search box. Diffs - ambari-web/app/messages.js 421143a ambari-web/app/styles/application.less 7bf94e2 ambari-web/app/templates/main/host/combo_search_box.hbs ea6e2b4 ambari-web/app/views/main/host/combo_search_box.js 2f86485 Diff: https://reviews.apache.org/r/45143/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 24635 tests complete (22 seconds) 145 tests pending Thanks, Richard Zang
Re: Review Request 45143: AMBARI-15504. Host filter: minor UX edits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45143/ --- (Updated March 22, 2016, 9:09 p.m.) Review request for Ambari and Xi Wang. Changes --- Fix unit test Bugs: AMBARI-15504 https://issues.apache.org/jira/browse/AMBARI-15504 Repository: ambari Description --- Various UI fixes for combo search box. Diffs (updated) - ambari-web/app/messages.js 52e3b8e ambari-web/app/styles/application.less 7bf94e2 ambari-web/app/templates/main/host/combo_search_box.hbs ea6e2b4 ambari-web/app/views/main/host/combo_search_box.js 2f86485 ambari-web/test/views/main/host/combo_search_box_test.js 9c2e7b6 Diff: https://reviews.apache.org/r/45143/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 24635 tests complete (22 seconds) 145 tests pending Thanks, Richard Zang
Re: Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45187/#review124923 --- Ship it! Ship It! - Richard Zang On March 22, 2016, 11:42 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45187/ > --- > > (Updated March 22, 2016, 11:42 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, > Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15520 > https://issues.apache.org/jira/browse/AMBARI-15520 > > > Repository: ambari > > > Description > --- > > Add more warning on Pause button saying no topology changes. > > Really need to warn folks on not making any add hosts/RM HA/others. > > > Diffs > - > > ambari-web/app/messages.js 1aaa112 > ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs > 35c3617 > ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js > 08f86f3 > > Diff: https://reviews.apache.org/r/45187/diff/ > > > Testing > --- > > Local ambari-web test passed. > 10488 tests complete (10 seconds) > 121 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45187/#review125065 --- Ship it! Ship It! - Richard Zang On March 23, 2016, 5:09 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45187/ > --- > > (Updated March 23, 2016, 5:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, > Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15520 > https://issues.apache.org/jira/browse/AMBARI-15520 > > > Repository: ambari > > > Description > --- > > Add more warning on Pause button saying no topology changes. > > Really need to warn folks on not making any add hosts/RM HA/others. > > > Diffs > - > > ambari-web/app/messages.js b4ca9b0 > > Diff: https://reviews.apache.org/r/45187/diff/ > > > Testing > --- > > Local ambari-web test passed. > 10488 tests complete (10 seconds) > 121 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 45295: AMBARI-15547: User names in the List view of Roles are displayed with URI encoding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45295/#review125312 --- Ship it! Ship It! - Richard Zang On March 24, 2016, 4:32 p.m., Keta Patel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45295/ > --- > > (Updated March 24, 2016, 4:32 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, and Richard Zang. > > > Bugs: AMBARI-15547 > https://issues.apache.org/jira/browse/AMBARI-15547 > > > Repository: ambari > > > Description > --- > > Under the List view of Roles, the name of Users with special characters, like > '@', are displayed with URI encoding. (please see attachment "names with URI > encoding.tiff" on Jira) > The names should be displayed without any encoding. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html > 656425b > > Diff: https://reviews.apache.org/r/45295/diff/ > > > Testing > --- > > The fix for this issue is to replace the displayed name with the correct name > attribute, which is not URI encoded. This attribute is already present in the > User's object. > The attachment "names with No URI encoding.tiff" shows the corrected User > names. > > TEST: > Since the change is in html file, I couldn't write a test cases for it. > But the UI shows the changes in the User's name in the List view of Roles as > seen in attachment "names with No URI encoding.tiff" on the Jira. > > Ambari-Web tests (orginal): > 24689 tests complete (28 seconds) > 145 tests pending > > Ambari-Web tests (after fix): > 24689 tests complete (27 seconds) > 145 tests pending > > > Thanks, > > Keta Patel > >
Re: Review Request 44724: AMBARI-12906: Alert notifications are created even if credential fields are left empty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44724/#review125330 --- Ship it! Ship It! - Richard Zang On March 20, 2016, 5:50 a.m., Qin Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44724/ > --- > > (Updated March 20, 2016, 5:50 a.m.) > > > Review request for Ambari, Di Li and Jonathan Hurley. > > > Bugs: AMBARI-12906 > https://issues.apache.org/jira/browse/AMBARI-12906 > > > Repository: ambari > > > Description > --- > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > 79e524e > ambari-web/app/messages.js 421143a > ambari-web/app/templates/main/alerts/create_alert_notification.hbs 0a83f63 > ambari-web/app/utils/validator.js 6426163 > > ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js > f16bf4d > > Diff: https://reviews.apache.org/r/44724/diff/ > > > Testing > --- > > FIX: > 1. With the fix, user won't be allowd to to save changes if Email is selected > for alert notification and Use authentication is chosen and the credential > fields are left empty when creating new Alert Notifications or editing > existing Alert Notifications. > 2. The error message "Username is required" will be shown if the Username is > empty. > 3. The error message "Password is required" will be shown if the password is > empty. > The fix here uses a similar approach that was used for the Password > Confirmation error handling. > > TESTS: > The fix has been tested with HDP UI. > manage_alert_notifications_controller_test.js has also been modified to test > changes. > > The following is the result of running ambari-web tests: > > 24957 tests complete (31 seconds) > 145 tests pending > > > Thanks, > > Qin Liu > >
Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45413/ --- Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako. Bugs: AMBARI-15611 https://issues.apache.org/jira/browse/AMBARI-15611 Repository: ambari Description --- When some services like Timeline service get moved to another host, unneeded services get shut down because of not exact mapping. Diffs - ambari-web/app/controllers/main/service/reassign/step4_controller.js 1d28834 ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 4406bb0 Diff: https://reviews.apache.org/r/45413/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25630 tests complete (25 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable
> On March 29, 2016, 5:39 p.m., Alejandro Fernandez wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 85 > > <https://reviews.apache.org/r/45413/diff/1/?file=1317425#file1317425line85> > > > > Why is the UI tracking this and not the stack? We are fixing this issue at FE for 2.4. We do plan to make it stack driven in future release. - Richard --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45413/#review125916 --- On March 29, 2016, 1:30 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45413/ > --- > > (Updated March 29, 2016, 1:30 a.m.) > > > Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Srimanth > Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-15611 > https://issues.apache.org/jira/browse/AMBARI-15611 > > > Repository: ambari > > > Description > --- > > When some services like Timeline service get moved to another host, unneeded > services get shut down because of not exact mapping. > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > 1d28834 > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 4406bb0 > > Diff: https://reviews.apache.org/r/45413/diff/ > > > Testing > --- > > Manually tested on live cluster. All unit tests passed. > 25630 tests complete (25 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Review Request 45459: AMBARI-15622. 'phoenix.query.spoolThresholdBytes' property doesn't have a description on UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45459/ --- Review request for Ambari and Sid Wagle. Bugs: AMBARI-15622 https://issues.apache.org/jira/browse/AMBARI-15622 Repository: ambari Description --- Fix duplicated definition. Make related definitions consistent. Diffs - ambari-metrics/ambari-metrics-timelineservice/src/main/conf/hbase-site-metrics-service.xml dabef50 ambari-metrics/ambari-metrics-timelineservice/src/test/conf/hbase-site.xml 15ade07 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml 815b126 Diff: https://reviews.apache.org/r/45459/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Review Request 45516: AMBARI-15639. Expose MariaDB option for Hive, Oozie and Ranger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45516/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-15639 https://issues.apache.org/jira/browse/AMBARI-15639 Repository: ambari Description --- MariaDB related label changes. Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 07eb7c4 ambari-web/app/data/HDP2/site_properties.js 40676df Diff: https://reviews.apache.org/r/45516/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25625 tests complete (25 seconds) 154 tests pending Thanks, Richard Zang
Review Request 45568: AMBARI-15658. If there is a host with no components then host page spins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45568/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15658 https://issues.apache.org/jira/browse/AMBARI-15658 Repository: ambari Description --- Handle no host component case in host mapper. Diffs - ambari-web/app/mappers/hosts_mapper.js 3eb99bf Diff: https://reviews.apache.org/r/45568/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Re: Review Request 45593: AMBARI-15138 SCRIPT params should support visibility attribute
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45593/#review126645
---
Ship it!
Ship It!
- Richard Zang
On April 1, 2016, 5:41 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45593/
> ---
>
> (Updated April 1, 2016, 5:41 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg
> Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15138
> https://issues.apache.org/jira/browse/AMBARI-15138
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Need an attribute "visibility" that can optionally be included in SCRIPT
> params.
>
> 1) If omitted, the param is shown in the UI
> 2) If set "visibility":"HIDDEN", the param is hidden in the UI
> 3) If set "visibility":"READ_ONLY", the param is shown in the UI but not
> edtiable
>
> "parameters": [
> {
> "name": "connection.timeout",
> "display_name": "Connection Timeout",
> "value": 5.0,
> "type": "NUMERIC",
> "description": "The maximum time before this alert is
> considered to be CRITICAL",
> "units": "seconds",
> "threshold": "CRITICAL"
> },
>
>
> Diffs
> -
>
> ambari-web/app/controllers/main/alerts/definition_configs_controller.js
> a927b59
> ambari-web/app/mappers/alert_definitions_mapper.js 0bf534e
> ambari-web/app/models/alerts/alert_definition.js a730572
> ambari-web/app/templates/main/alerts/configs.hbs dff1b53
>
> Diff: https://reviews.apache.org/r/45593/diff/
>
>
> Testing
> ---
>
> Local ambari-web test passed.
> 25602 tests complete (22 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Review Request 45609: AMBARI-15675. Hosts page filtering: error if we filter component by Upgrade Failed state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45609/ --- Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, and Zhe (Joe) Wang. Bugs: AMBARI-15675 https://issues.apache.org/jira/browse/AMBARI-15675 Repository: ambari Description --- Remove 'UPGRADE_FAILED' from the list for now since it's representing multiple possible internal states. Diffs - ambari-web/app/views/main/host/combo_search_box.js 9cc1023 Diff: https://reviews.apache.org/r/45609/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25602 tests complete (23 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45612/#review126934
---
Ship it!
Ship It!
- Richard Zang
On April 4, 2016, 8:23 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45612/
> ---
>
> (Updated April 4, 2016, 8:23 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley,
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15605
> https://issues.apache.org/jira/browse/AMBARI-15605
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Alert repeat tolerance values should be captured and exposed via the API. The
> rules for capturing the occurrences of an alert are:
>
> - Alert instances always start at 1
> - Alerts with an {{OK}} state always reset the counter
> - When transitioning from {{OK}} to non-{{OK}}, the counter is reset
> - When transitioning within non-{{OK}} states (such as back and forth between
> {{WARNING}} and {{CRITICAL}}, the counter is merely incremented.
>
> GET api/v1/clusters/c1/alerts/1
> {
> "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1";,
> "Alert": {
> "cluster_name": "c1",
> ...
> "repeat_tolerance": 1,
> "repeat_tolerance_remaining": 0,
> "occurrences": 8,
>
>
> - {{OK}} alert instances will *always* have a value of {{0}} for
> {{repeat_tolerance_remaining}} since they do not honor repeat tolerance. An
> {{OK}} alert is considered to be correct always.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/global/update_controller.js dcef1a2
> ambari-web/app/mappers/alert_instances_mapper.js 349d94d
> ambari-web/app/messages.js 1b2a02f
> ambari-web/app/models/alerts/alert_instance.js d8710a0
> ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 4debe10
> ambari-web/app/templates/main/alerts/alert_instance/status.hbs d82bc7b
> ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d
> ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1
>
> Diff: https://reviews.apache.org/r/45612/diff/
>
>
> Testing
> ---
>
> Local ambari-web test passed.
> 25602 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 45692: AMBARI-15603 Exposure of Global Alert Repeat Tolerance Value in Web Client
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45692/#review126937
---
Ship it!
Ship It!
- Richard Zang
On April 4, 2016, 5:58 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45692/
> ---
>
> (Updated April 4, 2016, 5:58 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley,
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15603
> https://issues.apache.org/jira/browse/AMBARI-15603
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The global repeat tolerance value for all alert definitions is set on the
> cluster-env configuration. Unless an alert definition overrides this value,
> it will be used for any definition in the system. By default, this value will
> be set to 1, indicating that there is no tolerance and the alert state should
> be taken at face value.
>
> GET api/v1/clusters//configurations?type=cluster-env&tag=
>
> "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
> },
> "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
>...
> }
>
> The web client should expose a way to update the {{cluster-env}} to set this
> value.
>
> *UI Warning of Delayed Alerts*
> When changing the value of the global of definition-specific repeat
> tolerance, a warning should be presented to the user to indicate that it will
> now take longer for the alert notifications to be sent. This is because
> notifications are delayed until the interval multiplied by the repeat
> tolerance is reached. Consider the case where the check against an alert
> happens every 5 minutes and the repeat tolerance is set to 5. It will be at
> least 25 minutes before any outbound notifications are dispatched. This
> warning can be on a per-alert definition basis as well as when setting the
> global value.
>
>
> Diffs
> -
>
>
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
> dc9f78c
> ambari-web/app/messages.js 1b2a02f
> ambari-web/app/styles/application.less a6b79ce
> ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65
>
> Diff: https://reviews.apache.org/r/45692/diff/
>
>
> Testing
> ---
>
> Local ambari-web test passed.
> 25600 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Review Request 45710: AMBARI-15701. Host filter: minor UX edits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45710/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-15701 https://issues.apache.org/jira/browse/AMBARI-15701 Repository: ambari Description --- Add solid background style to facet. Change "Health Status" to "Host Status" Diffs - ambari-web/app/styles/application.less a6b79ce ambari-web/app/views/main/host/combo_search_box.js b31fe81 Diff: https://reviews.apache.org/r/45710/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25600 tests complete (26 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45612/#review126961
---
Ship it!
Ship It!
- Richard Zang
On April 4, 2016, 10:02 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45612/
> ---
>
> (Updated April 4, 2016, 10:02 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley,
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15605
> https://issues.apache.org/jira/browse/AMBARI-15605
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Alert repeat tolerance values should be captured and exposed via the API. The
> rules for capturing the occurrences of an alert are:
>
> - Alert instances always start at 1
> - Alerts with an {{OK}} state always reset the counter
> - When transitioning from {{OK}} to non-{{OK}}, the counter is reset
> - When transitioning within non-{{OK}} states (such as back and forth between
> {{WARNING}} and {{CRITICAL}}, the counter is merely incremented.
>
> GET api/v1/clusters/c1/alerts/1
> {
> "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1";,
> "Alert": {
> "cluster_name": "c1",
> ...
> "repeat_tolerance": 1,
> "repeat_tolerance_remaining": 0,
> "occurrences": 8,
>
>
> - {{OK}} alert instances will *always* have a value of {{0}} for
> {{repeat_tolerance_remaining}} since they do not honor repeat tolerance. An
> {{OK}} alert is considered to be correct always.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/global/update_controller.js dcef1a2
> ambari-web/app/mappers/alert_instances_mapper.js 349d94d
> ambari-web/app/messages.js 1b2a02f
> ambari-web/app/models/alerts/alert_instance.js d8710a0
> ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 4debe10
> ambari-web/app/templates/main/alerts/alert_instance/status.hbs d82bc7b
> ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d
> ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1
>
> Diff: https://reviews.apache.org/r/45612/diff/
>
>
> Testing
> ---
>
> Local ambari-web test passed.
> 25602 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance Values Exposed In Web Client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45462/#review126964 --- Ship it! Ship It! - Richard Zang On April 4, 2016, 10:44 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45462/ > --- > > (Updated April 4, 2016, 10:44 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, > Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15604 > https://issues.apache.org/jira/browse/AMBARI-15604 > > > Repository: ambari > > > Description > --- > > Alert definitions will now expose two properties to control repeat tolerance > values on an individual based (overriding those from > cluster-env/alerts_repeat_tolerance) > > > Diffs > - > > ambari-web/app/controllers/global/update_controller.js dcef1a2 > ambari-web/app/controllers/main/alerts/definition_details_controller.js > fe17732 > ambari-web/app/mappers/alert_definitions_mapper.js 0bf534e > ambari-web/app/messages.js 1653eeb > ambari-web/app/models/alerts/alert_definition.js a730572 > ambari-web/app/styles/alerts.less 50246e6 > ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d > ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1 > ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b > > Diff: https://reviews.apache.org/r/45462/diff/ > > > Testing > --- > > Local ambari-web test passed. > 25642 tests complete (22 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 45774: AMBARI-15720 AGGREGATE Alerts Should Not Expose Repeat Tolerance or Tolerance Enabled Settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45774/#review127208 --- Ship it! Ship It! - Richard Zang On April 5, 2016, 8:46 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45774/ > --- > > (Updated April 5, 2016, 8:46 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg > Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15720 > https://issues.apache.org/jira/browse/AMBARI-15720 > > > Repository: ambari > > > Description > --- > > AGGREGATE type alerts should not expose a repeat_tolerance or > repeat_tolerance_enabled setting in the web client. This is because of the > nature of how AGGREGATE alerts functions. They respond to HARD alert events > and are therefore simply a summary of the known alerts which have already > reached their repeat tolerance levels. > These types of alerts will not honor a global repeat tolerance value > (cluster-env/alerts_repeat_tolerance nor will they honor changes to alert > definitions of source type AGGREGATE. > They effectively have a tolerance of 1 always. > > > Diffs > - > > ambari-web/app/models/alerts/alert_definition.js bdc8431 > ambari-web/app/templates/main/alerts/definition_details.hbs 95a8a08 > > Diff: https://reviews.apache.org/r/45774/diff/ > > > Testing > --- > > Local ambari-web test passed. > 25609 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 45791: AMBARI-15725: RBAC: Help page UI edits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45791/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-15725 https://issues.apache.org/jira/browse/AMBARI-15725 Repository: ambari Description --- Make RBAC help page table header fixed and content scrollable. Fix role listing page selector UI font issue. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css e5ebb68 ambari-admin/src/main/resources/ui/admin-web/app/views/modals/RoleDetailsModal.html ea8 Diff: https://reviews.apache.org/r/45791/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Re: Review Request 45825: AMBARI-15136 Alert definitions: Percentage params are shown incrrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45825/#review127393 --- Ship it! Ship It! - Richard Zang On April 6, 2016, 6:02 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45825/ > --- > > (Updated April 6, 2016, 6:02 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Eugene Chekanskiy, Jaimin > Jetly, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-15136 > https://issues.apache.org/jira/browse/AMBARI-15136 > > > Repository: ambari > > > Description > --- > > Percentage params need to be shown as whatever sent from BE. > > > Diffs > - > > ambari-web/app/controllers/main/alerts/definition_configs_controller.js > 0141c11 > ambari-web/app/models/alerts/alert_config.js 66ff2fb > ambari-web/test/models/alerts/alert_config_test.js 56f1577 > > Diff: https://reviews.apache.org/r/45825/diff/ > > > Testing > --- > > Modified unit tests. > Local ambari-web test passed. > 25634 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 46061: AMBARI-15816: EU/RU - cannot resume upgrade after pausing on a manual task
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46061/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15816 https://issues.apache.org/jira/browse/AMBARI-15816 Repository: ambari Description --- Wait for the promise object of the suspend upgrade request to be resolved and then do close wizard and reload. Diffs - ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js ff1cd7c Diff: https://reviews.apache.org/r/46061/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25640 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 46039: AMBARI-15809 Web Client Does Not Expose Parameters For All Alert Types
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46039/#review128518 --- Ship it! Ship It! - Richard Zang On April 11, 2016, 5:37 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46039/ > --- > > (Updated April 11, 2016, 5:37 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, > Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15809 > https://issues.apache.org/jira/browse/AMBARI-15809 > > > Repository: ambari > > > Description > --- > > AMBARI-15745 added a new SERVER type alert which exposes several parameters. > However, these parameters are not exposed via the web client. It seems like > only parameters for SCRIPT alerts are exposed. > > > Diffs > - > > ambari-web/app/controllers/main/alerts/definition_configs_controller.js > d5b27c5 > > Diff: https://reviews.apache.org/r/46039/diff/ > > > Testing > --- > > Local ambari-web test passed. > 25640 tests complete (23 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits v1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46226/#review129014 --- ambari-web/app/controllers/main/alerts/definition_details_controller.js (line 301) <https://reviews.apache.org/r/46226/#comment192478> Hide tooltip instead of removing the dom. - Richard Zang On April 14, 2016, 10:12 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46226/ > --- > > (Updated April 14, 2016, 10:12 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, > Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15899 > https://issues.apache.org/jira/browse/AMBARI-15899 > > > Repository: ambari > > > Description > --- > > Change the way to present the relation between global and individual alert > check. > Other UX edits. > > > Diffs > - > > ambari-web/app/config.js 06afa49 > ambari-web/app/controllers/global/cluster_controller.js 327bd45 > ambari-web/app/controllers/global/update_controller.js e13fe41 > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > 1712b6f > ambari-web/app/controllers/main/alerts/definition_details_controller.js > 8e716bc > ambari-web/app/messages.js 14c957c > ambari-web/app/styles/alerts.less 24b29b2 > ambari-web/app/styles/application.less 61ccbfa > ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb > ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7 > ambari-web/app/views/main/alerts/definition_details_view.js 606c955 > ambari-web/test/controllers/global/update_controller_test.js 2c679c6 > ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6 > > Diff: https://reviews.apache.org/r/46226/diff/ > > > Testing > --- > > Modified unit tests. > Local ambari-web test passed. > 25683 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits v1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46226/#review129046 --- Ship it! Ship It! - Richard Zang On April 15, 2016, 12:14 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46226/ > --- > > (Updated April 15, 2016, 12:14 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, > Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15899 > https://issues.apache.org/jira/browse/AMBARI-15899 > > > Repository: ambari > > > Description > --- > > Change the way to present the relation between global and individual alert > check. > Other UX edits. > > > Diffs > - > > ambari-web/app/config.js 06afa49 > ambari-web/app/controllers/global/cluster_controller.js 327bd45 > ambari-web/app/controllers/global/update_controller.js e13fe41 > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > 1712b6f > ambari-web/app/controllers/main/alerts/definition_details_controller.js > 8e716bc > ambari-web/app/messages.js 14c957c > ambari-web/app/styles/alerts.less 24b29b2 > ambari-web/app/styles/application.less 61ccbfa > ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb > ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7 > ambari-web/app/views/main/alerts/definition_details_view.js 606c955 > ambari-web/test/controllers/global/update_controller_test.js 2c679c6 > ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6 > > Diff: https://reviews.apache.org/r/46226/diff/ > > > Testing > --- > > Modified unit tests. > Local ambari-web test passed. > 25683 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 46338: AMBARI-15949 Tweaks to Alerts hyperlink display
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46338/#review129406 --- Ship it! Ship It! - Richard Zang On April 18, 2016, 6:12 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46338/ > --- > > (Updated April 18, 2016, 6:12 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-15949 > https://issues.apache.org/jira/browse/AMBARI-15949 > > > Repository: ambari > > > Description > --- > > Change the way the hyperlink to an external alert detail URL is shown. > > > Diffs > - > > ambari-web/app/messages.js 8d73bb3 > ambari-web/app/templates/main/alerts/configs.hbs 4259be8 > ambari-web/app/templates/main/alerts/definition_details.hbs 15cf168 > > Diff: https://reviews.apache.org/r/46338/diff/ > > > Testing > --- > > Local ambari-web test passed. > 25681 tests complete (23 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 46408: AMBARI-15983: Host filter: minor UX edits #3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46408/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-15983 https://issues.apache.org/jira/browse/AMBARI-15983 Repository: ambari Description --- Adjust combo search box border. Fix facet position shift when selected. Diffs - ambari-web/app/styles/application.less 5ca8683 Diff: https://reviews.apache.org/r/46408/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25679 tests complete (25 seconds) 154 tests pending Thanks, Richard Zang
Review Request 46467: AMBARI-16003: JS error on hosts filtering when filter for same field is used twice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46467/ --- Review request for Ambari, Zhe (Joe) Wang and Oleg Nechiporenko. Bugs: AMBARI-16003 https://issues.apache.org/jira/browse/AMBARI-16003 Repository: ambari Description --- For filters with operator support, do not allow multiple facets. Diffs - ambari-web/app/views/main/host/combo_search_box.js d8e5abf Diff: https://reviews.apache.org/r/46467/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25660 tests complete (25 seconds) 154 tests pending Thanks, Richard Zang
Review Request 46651: AMBARI-16102: Inconsistency between grid and list view of roles page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46651/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-16102 https://issues.apache.org/jira/browse/AMBARI-16102 Repository: ambari Description --- In the grid view, a user can be assigned more than one role just by typing the user name in 2 different role fields. But in list view you see/can choose only one role. Attached : Screenshots. The RMP suggested that the UI must allow just one role per user. We should add a check while adding users to roles in the grid view to check that a user is assigned only one role Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js e95ebdb ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js 6560f51 Diff: https://reviews.apache.org/r/46651/diff/ Testing --- Manually tested on live cluster. Thanks, Richard Zang
Re: Review Request 46128: AMBARI-15724 Integrate Version Registration in Select Stack Page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46128/#review130486 --- Ship it! Ship It! - Richard Zang On April 25, 2016, 6:36 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46128/ > --- > > (Updated April 25, 2016, 6:36 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-15724 > https://issues.apache.org/jira/browse/AMBARI-15724 > > > Repository: ambari > > > Description > --- > > Implement New "Select Stack Page". > Should have two main options : use local repo & use public repo. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 5596a7f > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > 3da088b > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > e95ebdb > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > fd3a8ba > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css edf8524 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > 8e9d3e2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > a78af6e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java > c9fa9a3 > ambari-web/app/assets/data/wizard/stack/HDP_version_definitions.json > PRE-CREATION > ambari-web/app/controllers/installer.js 73f9801 > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > a056d3b > ambari-web/app/controllers/main/service/add_controller.js 73abd59 > ambari-web/app/controllers/wizard.js f242523 > ambari-web/app/controllers/wizard/step1_controller.js c357bf4 > ambari-web/app/controllers/wizard/step8_controller.js a5eb949 > ambari-web/app/mappers/repository_version_mapper.js 67cfe64 > ambari-web/app/mappers/stack_mapper.js 75245e0 > ambari-web/app/messages.js 907d9ae > ambari-web/app/models/stack.js 0b1c9d2 > ambari-web/app/models/stack_version/repository_version.js e02999f > ambari-web/app/routes/add_service_routes.js ad256f5 > ambari-web/app/styles/application.less 890a43c > ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs > 35677ab > ambari-web/app/templates/main/admin/stack_upgrade/services.hbs a87c50c > ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs a9fc440 > ambari-web/app/templates/wizard/step1.hbs ab9a0dd > ambari-web/app/templates/wizard/step4.hbs cc4c68f > ambari-web/app/utils/ajax/ajax.js 1cb70c5 > ambari-web/app/utils/db.js 865839c > ambari-web/app/views/main/admin/stack_upgrade/services_view.js 8805c47 > ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js > 88bfec2 > ambari-web/app/views/wizard/step1_view.js 452e676 > ambari-web/test/controllers/installer_test.js 353129b > ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js > 00d7ce8 > ambari-web/test/controllers/wizard/step8_test.js e93e001 > ambari-web/test/mappers/stack_mapper_test.js 0bc0f3c > ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js > 9a42c42 > ambari-web/test/views/wizard/step1_view_test.js 0dacad8 > > Diff: https://reviews.apache.org/r/46128/diff/ > > > Testing > --- > > Add and modified test cases. > ambari-web: > 27544 tests complete (24 seconds) > 154 tests pending > ambari-admin: > Executed 64 of 64 SUCCESS (0.086 secs / 0.308 secs) > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 46861: AMBARI-16193 Message with "null" shows up in showRestartRequiredPopup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46861/#review131346 --- Ship it! Ship It! - Richard Zang On April 30, 2016, 12:59 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46861/ > --- > > (Updated April 30, 2016, 12:59 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg > Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-16193 > https://issues.apache.org/jira/browse/AMBARI-16193 > > > Repository: ambari > > > Description > --- > > It happens when we have large amount of hosts. > > > Diffs > - > > ambari-web/app/controllers/global/update_controller.js 223376b > ambari-web/app/mappers/component_config_mapper.js 8ff3416 > > Diff: https://reviews.apache.org/r/46861/diff/ > > > Testing > --- > > Local ambari-web test passed. > 27451 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 46953: AMBARI-16239: Incorrect warning for not selecting nfs_gateway_hosts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46953/ --- Review request for Ambari, Andriy Babiichuk and Zhe (Joe) Wang. Bugs: AMBARI-16239 https://issues.apache.org/jira/browse/AMBARI-16239 Repository: ambari Description --- Fix empty value check for [] case; Diffs - ambari-web/app/models/configs/objects/service_config_property.js a244dfd Diff: https://reviews.apache.org/r/46953/diff/ Testing --- Manually tested for live cluster. All unit tests passed. 27526 tests complete (26 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 46987: Show the connect string with the HiveServer instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46987/#review131728 --- Ship it! Ship It! - Richard Zang On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46987/ > --- > > (Updated May 4, 2016, 5:52 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi. > > > Bugs: AMBARI-16244 > https://issues.apache.org/jira/browse/AMBARI-16244 > > > Repository: ambari > > > Description > --- > > If Zookeeper based service discovery is used, then Hive summary page should > show JDBC connect string for HiveServer2 and HiveServer2 Interactive > instances. > The semantics for this will be > jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace= > > > Diffs > - > > LICENSE.txt f92b489 > ambari-web/app/assets/img/clippy.svg PRE-CREATION > ambari-web/app/controllers/global/configuration_controller.js 1f5675f > ambari-web/app/controllers/main/service/info/summary.js f1740a7 > ambari-web/app/messages.js c5e1145 > ambari-web/app/templates/main/service/services/hive.hbs 617f6ce > ambari-web/app/views/main/service/info/summary.js 7e0d0bb > ambari-web/app/views/main/service/services/hive.js c1a0f58 > ambari-web/test/views/main/service/services/hive_test.js a31ba62 > ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/46987/diff/ > > > Testing > --- > > Verified the patch to work manually. > Verified that ambari-web unit tests passes with the patch: > 27525 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review131773
---
After applying the patch.
Created a group "mygroup", assigned role "Cluster User" to this group.
Created user "aaa", "bbb", "ccc" and assigned all users to "mygroup"
Changed user "aaa"'s role to Cluster Administrator. (Success)
Changed user "aaa"'s role back to None. (Failed)
Refresh browser aaa's role went back to Cluster User.
- Richard Zang
On April 29, 2016, 12:41 a.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> -------
>
> (Updated April 29, 2016, 12:41 a.m.)
>
>
> Review request for Ambari, Di Li and Richard Zang.
>
>
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it.
> (I have created "mygroup" with "user1", "user2", "user3")
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a
> role, say "Cluster User".
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows
> the role "Cluster User" for each user in "mygroup".
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users,
> say "user3".
> (attachments "list_view_add_role_to_user_step1.tiff",
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case
> "user3"), but the roles from other users in its group gets removed. Also, the
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view.
> (attachment "block_view_after_step3.tiff")
>
> So, the problem here lies with the List view where it is not able to process
> the changes in the Roles correctly. A change in the Role of a user causes the
> following:
>
> CASE-1: The displayed role (effective privilege) comes from an explicitly
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower
> privilege than the role that got replaced, are still displayed in the Block
> view (because those roles are still in the database). So, if the new selected
> role happened to be of a lower privilege than and existing role of the user,
> then even though the user sees a success Alert message, the effective
> privileg he sees is different. For the Ambari user, this behavior is not
> easily understandable.
>
> CASE-2: The displayed role (effective privilege) comes from a group the user
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege
> coming from the user's group(s), then the newly selected role replaces this
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege,
> the Alert message shows a success of role change but the effective privilge
> is still not the one that the Ambari user selected.
>
>
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by
> allowing only a user to have just one role assigned to it, there could be
> cases where the earlier version of Block view has already allowed users to
> have multiple roles.
Re: Review Request 47079: Disabling and enabling back HiveServer2 Interactive does not show Assign Master popup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47079/#review132110 --- Ship it! Ship It! - Richard Zang On May 6, 2016, 10:34 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47079/ > --- > > (Updated May 6, 2016, 10:34 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi. > > > Bugs: AMBARI-16294 > https://issues.apache.org/jira/browse/AMBARI-16294 > > > Repository: ambari > > > Description > --- > > *STR:* > # Deploy a cluster with Hive service and Interactive query enabled > # Post deployment navigate to Hive service config page and Disable > interactive query > # Wait for all operations to complete > # Enable it again > > *Expected Result:* UI should show "Assign Master" popup for HSI selection > *Actual Result:* UI does not show assign master popup and takes the previous > selection of the HSI > > *Reason of the bug:* App.HostComponent model is not updated on the service > summary/config pages. So although HSI is deleted on disabling interactive > query on server, UI does not know about this via App.HostComponent model > > > Diffs > - > > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 93cac29 > > Diff: https://reviews.apache.org/r/47079/diff/ > > > Testing > --- > > Manually verified that patch resolves the issue > Verified that ambari-web unit tests passes with the patch: > 27718 tests complete (36 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132335
---
File Attachment: AMBARI-15552-May-05.patch - AMBARI-15552-May-05.patch
<https://reviews.apache.org//r/46808/#fcomment93>
Coding style needs to be fixed(many places). Also, could you please attach
the latest patch to JIRA after the fix?
- Richard Zang
On May 5, 2016, 5:59 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
>
> (Updated May 5, 2016, 5:59 p.m.)
>
>
> Review request for Ambari, Di Li and Richard Zang.
>
>
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it.
> (I have created "mygroup" with "user1", "user2", "user3")
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a
> role, say "Cluster User".
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows
> the role "Cluster User" for each user in "mygroup".
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users,
> say "user3".
> (attachments "list_view_add_role_to_user_step1.tiff",
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case
> "user3"), but the roles from other users in its group gets removed. Also, the
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view.
> (attachment "block_view_after_step3.tiff")
>
> So, the problem here lies with the List view where it is not able to process
> the changes in the Roles correctly. A change in the Role of a user causes the
> following:
>
> CASE-1: The displayed role (effective privilege) comes from an explicitly
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower
> privilege than the role that got replaced, are still displayed in the Block
> view (because those roles are still in the database). So, if the new selected
> role happened to be of a lower privilege than and existing role of the user,
> then even though the user sees a success Alert message, the effective
> privileg he sees is different. For the Ambari user, this behavior is not
> easily understandable.
>
> CASE-2: The displayed role (effective privilege) comes from a group the user
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege
> coming from the user's group(s), then the newly selected role replaces this
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege,
> the Alert message shows a success of role change but the effective privilge
> is still not the one that the Ambari user selected.
>
>
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by
> allowing only a user to have just one role assigned to it, there could be
> cases where the earlier version of Block view has already allowed users to
> have multiple roles. So, taking this into consideration, the fix must address
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the R
Re: Review Request 47139: Ranger issues on summary page and config page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47139/#review132349 --- Ship it! Ship It! - Richard Zang On May 9, 2016, 11:30 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47139/ > --- > > (Updated May 9, 2016, 11:30 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi. > > > Bugs: AMBARI-16409 > https://issues.apache.org/jira/browse/AMBARI-16409 > > > Repository: ambari > > > Description > --- > > # Ranger Admin Tab shows incorrect red badge with 1 error count > # Ranger summary page shows Kafka plugin status twice > > > Diffs > - > > ambari-web/app/controllers/main/service/info/summary.js 3a71cb3 > ambari-web/app/models/configs/objects/service_config_property.js 24f648b > > Diff: https://reviews.apache.org/r/47139/diff/ > > > Testing > --- > > Verified that patch resolves the issues on cluster > Verified that ambari-web unit tests passes with the patch: > 27721 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 47152: AMBARI-16414: Clients are not present in Hosts filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47152/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-16414 https://issues.apache.org/jira/browse/AMBARI-16414 Repository: ambari Description --- Deploy a cluster with default configs for Ambari-2.4.0.0 Navigate to Hosts Page In the new filter there is no choice to filter a Client component filtering client components was possible in old design of dropdown action menu (Ambari-2.2.2 and earlier). After the page is redesigned, this feature is missing. Diffs - ambari-web/app/views/main/host/combo_search_box.js 0b8c95b Diff: https://reviews.apache.org/r/47152/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27721 tests complete (31 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132555
---
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
(line 162)
<https://reviews.apache.org/r/46808/#comment196770>
effectivePrivilegeFromGroups has been calculated on line 152 already.
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
(line 181)
<https://reviews.apache.org/r/46808/#comment196771>
loadUser() needs to be called strictly after delete/add operation to have
the up-to-date roles loaded. It's better to put it in the then block. This can
be tested in the case I mentioned earlier: mygroup has "cluster user" role and
aaa bbb ccc are in mygroup. Change aaa to "cluster administrator", confirm,
then change aaa back to None, aaa stays at "cluster administrator" because
loadUser() happens before delete finishes.
- Richard Zang
On May 10, 2016, 7:49 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
>
> (Updated May 10, 2016, 7:49 p.m.)
>
>
> Review request for Ambari, Di Li and Richard Zang.
>
>
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it.
> (I have created "mygroup" with "user1", "user2", "user3")
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a
> role, say "Cluster User".
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows
> the role "Cluster User" for each user in "mygroup".
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users,
> say "user3".
> (attachments "list_view_add_role_to_user_step1.tiff",
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case
> "user3"), but the roles from other users in its group gets removed. Also, the
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view.
> (attachment "block_view_after_step3.tiff")
>
> So, the problem here lies with the List view where it is not able to process
> the changes in the Roles correctly. A change in the Role of a user causes the
> following:
>
> CASE-1: The displayed role (effective privilege) comes from an explicitly
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower
> privilege than the role that got replaced, are still displayed in the Block
> view (because those roles are still in the database). So, if the new selected
> role happened to be of a lower privilege than and existing role of the user,
> then even though the user sees a success Alert message, the effective
> privileg he sees is different. For the Ambari user, this behavior is not
> easily understandable.
>
> CASE-2: The displayed role (effective privilege) comes from a group the user
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege
> coming from the user's group(s), then the newly selected role replaces this
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege,
> the Alert message shows a success of role change but the effective privilge
> is still not the one that the Ambari use
Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132558
---
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
(line 165)
<https://reviews.apache.org/r/46808/#comment196772>
if user change permission to None, currentIndex will be -1. I would
recommend creating a function like getRoleRank which will give out a rank for
all roles including None and View User.
- Richard Zang
On May 10, 2016, 7:49 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
>
> (Updated May 10, 2016, 7:49 p.m.)
>
>
> Review request for Ambari, Di Li and Richard Zang.
>
>
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it.
> (I have created "mygroup" with "user1", "user2", "user3")
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a
> role, say "Cluster User".
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows
> the role "Cluster User" for each user in "mygroup".
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users,
> say "user3".
> (attachments "list_view_add_role_to_user_step1.tiff",
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case
> "user3"), but the roles from other users in its group gets removed. Also, the
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view.
> (attachment "block_view_after_step3.tiff")
>
> So, the problem here lies with the List view where it is not able to process
> the changes in the Roles correctly. A change in the Role of a user causes the
> following:
>
> CASE-1: The displayed role (effective privilege) comes from an explicitly
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower
> privilege than the role that got replaced, are still displayed in the Block
> view (because those roles are still in the database). So, if the new selected
> role happened to be of a lower privilege than and existing role of the user,
> then even though the user sees a success Alert message, the effective
> privileg he sees is different. For the Ambari user, this behavior is not
> easily understandable.
>
> CASE-2: The displayed role (effective privilege) comes from a group the user
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege
> coming from the user's group(s), then the newly selected role replaces this
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege,
> the Alert message shows a success of role change but the effective privilge
> is still not the one that the Ambari user selected.
>
>
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by
> allowing only a user to have just one role assigned to it, there could be
> cases where the earlier version of Block view has already allowed users to
> have multiple roles. So, taking this into consideration, the fix must address
> remo
Review Request 47206: AMBARI-16441: RBAC UI Edits #6
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47206/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-16441 https://issues.apache.org/jira/browse/AMBARI-16441 Repository: ambari Description --- Add help page popup on user listing page as well. Add close button on help page header. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js c92374b ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 32f46c1 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RoleDetailsModal.js eced664 ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html e3bbcdc ambari-admin/src/main/resources/ui/admin-web/app/views/modals/RoleDetailsModal.html 74a1807 Diff: https://reviews.apache.org/r/47206/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 64 of 64 SUCCESS (0.211 secs / 0.418 secs) Thanks, Richard Zang
Re: Review Request 47211: AMBARI-16442 VDF UI edits and bugs: #2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47211/#review132592 --- Ship it! Ship It! - Richard Zang On May 11, 2016, 1:11 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47211/ > --- > > (Updated May 11, 2016, 1:11 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-16442 > https://issues.apache.org/jira/browse/AMBARI-16442 > > > Repository: ambari > > > Description > --- > > Various bugs in the UI and other issues. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > f406b1a > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 4c81507 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > 8fc0f89 > ambari-web/app/controllers/installer.js 8981845 > ambari-web/app/mappers/repository_version_mapper.js 04b9d73 > ambari-web/app/models/stack_version/repository_version.js 4141c14 > ambari-web/app/styles/application.less 31bc1f9 > ambari-web/app/styles/stack_versions.less 052ae4d > > ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js > facba5e > > Diff: https://reviews.apache.org/r/47211/diff/ > > > Testing > --- > > ambari-web: > 27794 tests complete (24 seconds) > 154 tests pending > ambari-admin: > Executed 64 of 64 SUCCESS (0.325 secs / 0.323 secs) > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly
> On May 10, 2016, 10:28 p.m., Richard Zang wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js,
> > line 181
> > <https://reviews.apache.org/r/46808/diff/2/?file=1378440#file1378440line181>
> >
> > loadUser() needs to be called strictly after delete/add operation to
> > have the up-to-date roles loaded. It's better to put it in the then block.
> > This can be tested in the case I mentioned earlier: mygroup has "cluster
> > user" role and aaa bbb ccc are in mygroup. Change aaa to "cluster
> > administrator", confirm, then change aaa back to None, aaa stays at
> > "cluster administrator" because loadUser() happens before delete finishes.
>
> Keta Patel wrote:
> As per your suggestion, I have added "addPrivilege(user)" to the then
> clause of the deletePrivilege calls. Since I use individual delete calls for
> the various privilege IDs, I make use of "Prromise.all().then()" to ensure
> that addPrivilege() gets called only after all the delete calls are complete.
> The patch "AMBARI-15552-May-11.patch" contains these changes.
> I couldn't figure out using "deletePrivileges()" to delete a set of
> privileges and so made use of these individual calls. If you think using the
> individual "deletePrivileges()" call is workable in this case, could you
> please provide me with the information on the valid attributes for the body.
>
> Thank you!
Please try DELETE
http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/privileges?PrivilegeInfo/privilege_id.in(12,13)
- Richard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132555
---
On May 11, 2016, 10:08 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
>
> (Updated May 11, 2016, 10:08 p.m.)
>
>
> Review request for Ambari, Di Li and Richard Zang.
>
>
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it.
> (I have created "mygroup" with "user1", "user2", "user3")
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a
> role, say "Cluster User".
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows
> the role "Cluster User" for each user in "mygroup".
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users,
> say "user3".
> (attachments "list_view_add_role_to_user_step1.tiff",
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case
> "user3"), but the roles from other users in its group gets removed. Also, the
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view.
> (attachment "block_view_after_step3.tiff")
>
> So, the problem here lies with the List view where it is not able to process
> the changes in the Roles correctly. A change in the Role of a user causes the
> following:
>
> CASE-1: The displayed role (effective privilege) comes from an explicitly
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower
> privilege than the role that got replaced, are still displayed in the Block
> view (because those roles are still in the database). So, if the new selected
> role happened to be of a lower privilege than and existing role of the user,
> then even though the user sees a su
Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132985
---
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
(line 188)
<https://reviews.apache.org/r/46808/#comment197275>
Please move hard-coded texts like this to i18n.config.js
- Richard Zang
On May 12, 2016, 7:57 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
>
> (Updated May 12, 2016, 7:57 p.m.)
>
>
> Review request for Ambari, Di Li and Richard Zang.
>
>
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it.
> (I have created "mygroup" with "user1", "user2", "user3")
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a
> role, say "Cluster User".
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows
> the role "Cluster User" for each user in "mygroup".
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users,
> say "user3".
> (attachments "list_view_add_role_to_user_step1.tiff",
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case
> "user3"), but the roles from other users in its group gets removed. Also, the
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view.
> (attachment "block_view_after_step3.tiff")
>
> So, the problem here lies with the List view where it is not able to process
> the changes in the Roles correctly. A change in the Role of a user causes the
> following:
>
> CASE-1: The displayed role (effective privilege) comes from an explicitly
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower
> privilege than the role that got replaced, are still displayed in the Block
> view (because those roles are still in the database). So, if the new selected
> role happened to be of a lower privilege than and existing role of the user,
> then even though the user sees a success Alert message, the effective
> privileg he sees is different. For the Ambari user, this behavior is not
> easily understandable.
>
> CASE-2: The displayed role (effective privilege) comes from a group the user
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege
> coming from the user's group(s), then the newly selected role replaces this
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege,
> the Alert message shows a success of role change but the effective privilge
> is still not the one that the Ambari user selected.
>
>
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by
> allowing only a user to have just one role assigned to it, there could be
> cases where the earlier version of Block view has already allowed users to
> have multiple roles. So, taking this into consideration, the fix must address
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other u
Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review133219
---
Ship it!
Ship It!
- Richard Zang
On May 13, 2016, 5:29 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
>
> (Updated May 13, 2016, 5:29 p.m.)
>
>
> Review request for Ambari, Di Li and Richard Zang.
>
>
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it.
> (I have created "mygroup" with "user1", "user2", "user3")
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a
> role, say "Cluster User".
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows
> the role "Cluster User" for each user in "mygroup".
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users,
> say "user3".
> (attachments "list_view_add_role_to_user_step1.tiff",
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case
> "user3"), but the roles from other users in its group gets removed. Also, the
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view.
> (attachment "block_view_after_step3.tiff")
>
> So, the problem here lies with the List view where it is not able to process
> the changes in the Roles correctly. A change in the Role of a user causes the
> following:
>
> CASE-1: The displayed role (effective privilege) comes from an explicitly
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower
> privilege than the role that got replaced, are still displayed in the Block
> view (because those roles are still in the database). So, if the new selected
> role happened to be of a lower privilege than and existing role of the user,
> then even though the user sees a success Alert message, the effective
> privileg he sees is different. For the Ambari user, this behavior is not
> easily understandable.
>
> CASE-2: The displayed role (effective privilege) comes from a group the user
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege
> coming from the user's group(s), then the newly selected role replaces this
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege,
> the Alert message shows a success of role change but the effective privilge
> is still not the one that the Ambari user selected.
>
>
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by
> allowing only a user to have just one role assigned to it, there could be
> cases where the earlier version of Block view has already allowed users to
> have multiple roles. So, taking this into consideration, the fix must address
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to
> None". This may not reflect the correct privileg
Review Request 47422: AMBARI-16688: Ambari users page is not showing type for users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47422/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-16688 https://issues.apache.org/jira/browse/AMBARI-16688 Repository: ambari Description --- Login to ambari Navigate to Users page Add few users Verify type is displayed for each User Actual: Type is displayed as blank for users currently. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js c6765d0 Diff: https://reviews.apache.org/r/47422/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 70 of 70 SUCCESS (0.502 secs / 0.499 secs) Thanks, Richard Zang
Review Request 47508: AMBARI-16721 - Host Filters : 'Alerts' value for 'HOST STATUS' filter is absent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47508/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-16721 https://issues.apache.org/jira/browse/AMBARI-16721 Repository: ambari Description --- Add "Alert" option back. Refactor existing filter logic. Move specific filter logic out of common mixin. Diffs - ambari-web/app/controllers/main/host/combo_search_box.js 2fa4479 ambari-web/app/data/host/categories.js 03e2fee ambari-web/app/mixins/common/table_server_view_mixin.js 66f886a ambari-web/app/views/main/host/combo_search_box.js caf200f Diff: https://reviews.apache.org/r/47508/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27819 tests complete (33 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 47517: AMBARI-16724 Allow customizing Connection Timeout for METRIC Alerts
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47517/#review133821
---
Ship it!
Ship It!
- Richard Zang
On May 18, 2016, 6:10 a.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47517/
> ---
>
> (Updated May 18, 2016, 6:10 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Richard Zang, Xi
> Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-16724
> https://issues.apache.org/jira/browse/AMBARI-16724
>
>
> Repository: ambari
>
>
> Description
> ---
>
> METRIC alert types have a connection timeout in their definition but that
> value is not exposed in the Ambari Web UI (like WEB alerts are).
> "uri" : {
> "http" : "{{ams-hbase-site/hbase.master.info.port}}",
> "default_port" : 61310.0,
> "connection_timeout" : 5.0
> }
>
> Include exposing the Connection Timeout critical threshold in Ambari Web for
> METRIC alert types.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/main/alerts/definition_configs_controller.js
> 617f7cc
>
> ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js
> f3cf28c
>
> Diff: https://reviews.apache.org/r/47517/diff/
>
>
> Testing
> ---
>
> Modified unit test.
> Local ambari-web test passed.
> 27819 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 47523: AMBARI-16725 Alert type = RECOVERY does not have connection timeout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47523/#review133822 --- Ship it! Ship It! - Richard Zang On May 18, 2016, 6:10 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47523/ > --- > > (Updated May 18, 2016, 6:10 a.m.) > > > Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-16725 > https://issues.apache.org/jira/browse/AMBARI-16725 > > > Repository: ambari > > > Description > --- > > RECOVERY alert types do not have a connection timeout, therefore, this should > not be shown in the UI (and not have an error because it's blank). > > > Diffs > - > > ambari-web/app/controllers/main/alerts/definition_configs_controller.js > 617f7cc > > Diff: https://reviews.apache.org/r/47523/diff/ > > > Testing > --- > > Local ambari-web test passed. > 27819 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 47677: AMBARI-16804 - Refactor Move Master Wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47677/ --- Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako. Bugs: AMBARI-16804 https://issues.apache.org/jira/browse/AMBARI-16804 Repository: ambari Description --- Refactor Move Master wizard. Extract configurable texts and stack related definitions into a separate JS file. Diffs - ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7 ambari-web/app/controllers/main/service/reassign/step4_controller.js d8f0394 ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c ambari-web/app/data/wizards/move_master.js PRE-CREATION ambari-web/app/routes/reassign_master_routes.js f079432 ambari-web/app/templates/main/service/reassign.hbs 2477229 ambari-web/app/templates/main/service/reassign/step1.hbs 9862cbe ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 ambari-web/app/views/main/service/reassign/step1_view.js ddabf14 ambari-web/app/views/main/service/reassign/step2_view.js 0eae84b ambari-web/app/views/main/service/reassign/step4_view.js 4e1282a ambari-web/app/views/main/service/reassign/step5_view.js 066b23b ambari-web/app/views/main/service/reassign/step6_view.js 33f8851 ambari-web/app/views/main/service/reassign/step7_view.js 60b357a ambari-web/test/controllers/main/service/reassign/step1_controller_test.js a43d91f ambari-web/test/controllers/main/service/reassign/step4_controller_test.js d6ef9dc Diff: https://reviews.apache.org/r/47677/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27828 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Review Request 47751: AMBARI-16831 - Atlas metadaserver doesn't show up in warning popup while deleting a host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47751/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-16831 https://issues.apache.org/jira/browse/AMBARI-16831 Repository: ambari Description --- Include deletable master components. Diffs - ambari-web/app/controllers/main/host/details.js b16ef46 ambari-web/app/messages.js fe5a301 Diff: https://reviews.apache.org/r/47751/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27834 tests complete (33 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 47677: AMBARI-16804 - Refactor Move Master Wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47677/ --- (Updated May 25, 2016, 9:32 p.m.) Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako. Changes --- Change place holder from numeric to variable name based. Bugs: AMBARI-16804 https://issues.apache.org/jira/browse/AMBARI-16804 Repository: ambari Description --- Refactor Move Master wizard. Extract configurable texts and stack related definitions into a separate JS file. Diffs (updated) - ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7 ambari-web/app/controllers/main/service/reassign/step4_controller.js d8f0394 ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c ambari-web/app/data/wizards/move_master.js PRE-CREATION ambari-web/app/routes/reassign_master_routes.js f079432 ambari-web/app/templates/main/service/reassign.hbs 2477229 ambari-web/app/templates/main/service/reassign/step1.hbs 9862cbe ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 ambari-web/app/utils/helper.js 7ab131c ambari-web/app/views/main/service/reassign/step1_view.js ddabf14 ambari-web/app/views/main/service/reassign/step2_view.js 0eae84b ambari-web/app/views/main/service/reassign/step4_view.js 4e1282a ambari-web/app/views/main/service/reassign/step5_view.js 066b23b ambari-web/app/views/main/service/reassign/step6_view.js 33f8851 ambari-web/app/views/main/service/reassign/step7_view.js 60b357a ambari-web/test/controllers/main/service/reassign/step1_controller_test.js a43d91f ambari-web/test/controllers/main/service/reassign/step4_controller_test.js d6ef9dc Diff: https://reviews.apache.org/r/47677/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27828 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 47836: User/Group with no Cluster Role assigned but having View Permissions of "VIEW.USER" are shown as not editable in the List View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47836/#review134858 --- Ship it! Ship It! - Richard Zang On May 25, 2016, 5:48 p.m., Keta Patel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47836/ > --- > > (Updated May 25, 2016, 5:48 p.m.) > > > Review request for Ambari, Di Li and Richard Zang. > > > Bugs: AMBARI-16861 > https://issues.apache.org/jira/browse/AMBARI-16861 > > > Repository: ambari > > > Description > --- > > Steps to reproduce this issue: > 1. Create a few local users. I have created users "aaa", "bbb", "ccc" in my > case. > 2. Create a view instance of your choice and assign one of the local users to > this view instance. I have assigned user "aaa" to the a Jobs view instance. > 3. Go to Manage Ambari -> Roles -> List View > 4. You see the user "aaa" showing Cluster Role of "View User" and is not > editable from this page. (attachment "view_user_for_user.tiff" on the JIRA) > > I had recreated this issue using group also. Please find attachment > "view_user_for_group.tiff" on JIRA showing the List View for the case of > group assigned with View User permission alone. > > Since View Permissions must not be mixed with the Cluster Permissions, the > proposed fix should show Cluster Permission of "None" for users who have only > "View User" permissions and no Cluster Permissions. This would allow the > ambari user to edit the Cluster Permissions of the local users from the List > View page. > Note: A workaround found to edit such users' Cluster Permissions is to go to > the Block View and assign some Cluster Permission. Then the List View shows > the Cluster Permission and is editable. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js > 19fb971 > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js > fb327c7 > > Diff: https://reviews.apache.org/r/47836/diff/ > > > Testing > --- > > I have added a test case for the function "pickEffectivePrivilege" which > checks if the effective privilege of a user/group is "VIEW.USER". If it is, > then the privilege returned is "CLUSTER.NONE", otherwise the calculated > effective privilege is returned. > > I have attached the result of tests run for ambari-admin in the attachments > "ambari_admin_test_cases_before_fix.tiff" and > "ambari_admin_test_cases_after_fix.tiff" on the JIRA. > > > Thanks, > > Keta Patel > >
Re: Review Request 47993: VDF: support for selecting enabled + default Stacks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47993/#review135360 --- Ship it! Ship It! - Richard Zang On May 28, 2016, 12:13 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47993/ > --- > > (Updated May 28, 2016, 12:13 a.m.) > > > Review request for Ambari, Richard Zang, Srimanth Gunturi, Xi Wang, and > Yusaku Sako. > > > Bugs: AMBARI-16940 > https://issues.apache.org/jira/browse/AMBARI-16940 > > > Repository: ambari > > > Description > --- > > The work revamps the UX for leveraging VDF(Version Definition File) feature > of ambari. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/index.html 9344f15 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 47b72e6 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > 22ec5ae > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 3a8233a > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 2d51ece > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/ConfirmationModal.js > 4576a40 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > 96f9c9f > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Utility.js > PRE-CREATION > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 4434908 > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddVersionModal.html > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/ConfirmationModal.html > b11f6bb > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/publicRepoDisabled.html > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 3de92c1 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > f3f2d86 > ambari-web/app/assets/test/tests.js c654dac > ambari-web/app/controllers/installer.js 43a5e4a > ambari-web/app/controllers/wizard/step0_controller.js aa3541a > ambari-web/app/controllers/wizard/step1_controller.js 3eb5d1b > ambari-web/app/controllers/wizard/step3_controller.js 38bb5d7 > ambari-web/app/controllers/wizard/step4_controller.js 0575f07 > ambari-web/app/controllers/wizard/step7_controller.js c3b98b5 > ambari-web/app/mappers/stack_mapper.js ab1d6a8 > ambari-web/app/messages.js 29ca44c > ambari-web/app/models/repository.js 8ad20ce > ambari-web/app/models/stack.js 6023566 > ambari-web/app/models/stack_version/service_simple.js 13ca381 > ambari-web/app/routes/installer.js b8b9532 > ambari-web/app/styles/application.less 32c88fd > ambari-web/app/styles/common.less 326d404 > ambari-web/app/templates/wizard/step1.hbs 56c62a2 > > ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs > PRE-CREATION > ambari-web/app/templates/wizard/step1/vdf_upload.hbs PRE-CREATION > ambari-web/app/utils/array_utils.js 643ed67 > ambari-web/app/views/wizard/step1_view.js a7af383 > ambari-web/karma.conf.js 1a03381 > ambari-web/test/controllers/installer_test.js 303c8a4 > ambari-web/test/controllers/wizard/step1_test.js PRE-CREATION > ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js > 8572772 > ambari-web/test/utils/array_utils_test.js ec7c5d8 > ambari-web/test/views/common/host_progress_popup_body_view_test.js 282d31c > ambari-web/test/views/wizard/step1_view_test.js 070cb59 > > Diff: https://reviews.apache.org/r/47993/diff/ > > > Testing > --- > > Tested ambari-web and ambari-admin view manually: > Verified that unit tests for ambari-web and ambari-admin passes successfully > > ambari-web: > 27900 tests complete (29 seconds) > 154 tests pending > > ambari-admin: > phantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.467 secs / 0.454 > secs) > > > Thanks, > > Jaimin Jetly > >
Review Request 48242: Takes long time to start or fail to start service after enabling SSL due to "dfs.https.enable"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48242/ --- Review request for Ambari, Alejandro Fernandez and Andrew Onischuk. Bugs: AMBARI-17039 https://issues.apache.org/jira/browse/AMBARI-17039 Repository: ambari Description --- Check both dfs.http.policy and deprecated dfs.https.enable Diffs - ambari-common/src/main/python/resource_management/libraries/functions/hdfs_utils.py PRE-CREATION ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py 919ccb5 ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py de46c1c ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py b634ce9 Diff: https://reviews.apache.org/r/48242/diff/ Testing --- mvn clean test Thanks, Richard Zang
Re: Review Request 48242: Takes long time to start or fail to start service after enabling SSL due to "dfs.https.enable"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48242/ --- (Updated June 6, 2016, 8:29 p.m.) Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit Mohanty. Changes --- Add missing import Bugs: AMBARI-17039 https://issues.apache.org/jira/browse/AMBARI-17039 Repository: ambari Description --- Check both dfs.http.policy and deprecated dfs.https.enable Diffs - ambari-common/src/main/python/resource_management/libraries/functions/hdfs_utils.py PRE-CREATION ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py 919ccb5 ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py de46c1c ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py b634ce9 Diff: https://reviews.apache.org/r/48242/diff/ Testing --- mvn clean test File Attachments (updated) AMBARI-17039.fix1.patch https://reviews.apache.org/media/uploaded/files/2016/06/06/c63b17eb-27e1-4039-b79c-ed8e49063fe7__AMBARI-17039.fix1.patch Thanks, Richard Zang
Review Request 48306: AMBARI-17077 - Unable to change user role in list view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48306/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17077 https://issues.apache.org/jira/browse/AMBARI-17077 Repository: ambari Description --- Fix role update logic Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js cd72ca6 Diff: https://reviews.apache.org/r/48306/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.151 secs / 0.399 secs) Thanks, Richard Zang
Re: Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48296/#review136493 --- Ship it! Ship It! - Richard Zang On June 7, 2016, 12:36 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48296/ > --- > > (Updated June 7, 2016, 12:36 a.m.) > > > Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, > and Yusaku Sako. > > > Bugs: AMBARI-17073 > https://issues.apache.org/jira/browse/AMBARI-17073 > > > Repository: ambari > > > Description > --- > > To fulfill the requirement of enforcing users to choose local repo when they > don’t have internet access, in FE we use the logic of checking whether all > versions are stack_default versions. That logic is true for HDP for now, but > not for HDF. > > > Diffs > - > > ambari-web/app/messages.js e8ca9ae > ambari-web/app/templates/wizard/step1.hbs 72a2099 > > ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs > 25cf49f > ambari-web/app/views/wizard/step1_view.js 503d5ef > > Diff: https://reviews.apache.org/r/48296/diff/ > > > Testing > --- > > Local ambari-web test passed. > 28646 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/#review136512 --- Ship it! Ship It! - Richard Zang On June 6, 2016, 6:22 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48289/ > --- > > (Updated June 6, 2016, 6:22 p.m.) > > > Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, > and Yusaku Sako. > > > Bugs: AMBARI-10908 > https://issues.apache.org/jira/browse/AMBARI-10908 > > > Repository: ambari > > > Description > --- > > On Hosts page, provide ability to delete hosts in bulk. > > > Diffs > - > > ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 > ambari-web/app/messages.js e8ca9ae > ambari-web/app/styles/application.less 5ee09cc > ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs > PRE-CREATION > ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION > ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs > PRE-CREATION > ambari-web/app/utils/ajax/ajax.js 195dab4 > ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 > > Diff: https://reviews.apache.org/r/48289/diff/ > > > Testing > --- > > Local ambari-web test passed. > 28648 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 48451: AMBARI-17132 - Typing the whole component name vs selecting drop down filter in hosts page gives 2 different results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48451/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17132 https://issues.apache.org/jira/browse/AMBARI-17132 Repository: ambari Description --- Add facet validation check before search Diffs - ambari-web/app/messages.js 02da1f6 ambari-web/app/templates/main/host/combo_search_box.hbs 6ff9640 ambari-web/app/views/main/host/combo_search_box.js c6ac3bd Diff: https://reviews.apache.org/r/48451/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28664 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 48456: AMBARI-17134 - Add support flag for user type 'JWT'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48456/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17134 https://issues.apache.org/jira/browse/AMBARI-17134 Repository: ambari Description --- Add support flag for user type 'JWT' Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 47b87c4 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js 4eb3633 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js 3c5e7b2 Diff: https://reviews.apache.org/r/48456/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.12 secs / 0.368 secs) Thanks, Richard Zang
Review Request 48517: AMBARI-17154 - Typo in SmartSense Warning Dialog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48517/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17154 https://issues.apache.org/jira/browse/AMBARI-17154 Repository: ambari Description --- Fix warning text Diffs - ambari-web/app/messages.js 6c25357 Diff: https://reviews.apache.org/r/48517/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28649 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Review Request 48709: Nothing shows on the role section when user has the same role as its group
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48709/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17239 https://issues.apache.org/jira/browse/AMBARI-17239 Repository: ambari Description --- Only show highest role. Fix ng-repeat usage to avoid error caused by duplicated items. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 69a15bd ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 18df5fa Diff: https://reviews.apache.org/r/48709/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.409 secs) Thanks, Richard Zang
Review Request 48809: AMBARI-17266 - StackDeploys: Suse: after enabling ranger plugin save button is always present
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48809/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-17266 https://issues.apache.org/jira/browse/AMBARI-17266 Repository: ambari Description --- This issue is caused by mergeWithStackProperties creating extra config with attribute isNotSaved=true Filter out 'test-db-connection' since it's only related to enhanced config theme. Diffs - ambari-web/app/utils/config.js 840e3c2 Diff: https://reviews.apache.org/r/48809/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28635 tests complete (26 seconds) 154 tests pending Thanks, Richard Zang
Review Request 48888: AMBARI-17305 - Local User not displaying in View All option in Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17305 https://issues.apache.org/jira/browse/AMBARI-17305 Repository: ambari Description --- JWT type will be supported from 2.4 so remove support flag. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 39a8e9c ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js 6318814 Diff: https://reviews.apache.org/r/4/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.13 secs / 0.379 secs) Thanks, Richard Zang
Re: Review Request 48834: AMBARI-17289 VDF: UI Edits #2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48834/#review138649 --- Ship it! Ship It! - Richard Zang On June 17, 2016, 1:40 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48834/ > --- > > (Updated June 17, 2016, 1:40 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17289 > https://issues.apache.org/jira/browse/AMBARI-17289 > > > Repository: ambari > > > Description > --- > > The CSS styling for Name on Register Version cleanup > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 542177d > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > e7bf01d > > Diff: https://reviews.apache.org/r/48834/diff/ > > > Testing > --- > > ambari-admin: > Executed 76 of 76 SUCCESS (0.15 secs / 0.358 secs) > Manual testing done > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 48966: AMBARI-17322 No alerts on Select Version page when selected stack 2.2 with JDK 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48966/#review138707 --- Ship it! Ship It! - Richard Zang On June 20, 2016, 9:11 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48966/ > --- > > (Updated June 20, 2016, 9:11 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17322 > https://issues.apache.org/jira/browse/AMBARI-17322 > > > Repository: ambari > > > Description > --- > > 1) Install Ambari with Oracle JDK 1.8 > 2) Go to Select Version page > 3) Select HDP 2.2 > Expected: Alert concering jdk mismatch > Actually: there is no alert > > > Diffs > - > > ambari-web/app/models/stack.js 5081f19 > ambari-web/app/utils/ajax/ajax.js 03a77ef > > Diff: https://reviews.apache.org/r/48966/diff/ > > > Testing > --- > > Local ambari-web test passed. > 28646 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 48998: AMBARI-17326 - Mark the role "(from group)" if there is no specific user level role set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48998/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17326 https://issues.apache.org/jira/browse/AMBARI-17326 Repository: ambari Description --- Mark the role "(from group)" if there is no specific user level role set. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js b4138b3 ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html c0f6144 Diff: https://reviews.apache.org/r/48998/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Review Request 49126: AMBARI-17388 - Add Service Wizard stuck on Customize Services step
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49126/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17388 https://issues.apache.org/jira/browse/AMBARI-17388 Repository: ambari Description --- Add null check. Diffs - ambari-web/app/controllers/wizard/step7_controller.js 3211974 Diff: https://reviews.apache.org/r/49126/diff/ Testing --- Manually tested on live cluster. All unit test passed. 28972 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49475: Hosts filter works incorrect with Flume
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49475/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17511 https://issues.apache.org/jira/browse/AMBARI-17511 Repository: ambari Description --- Add separate map for services. Diffs - ambari-web/app/views/main/host/combo_search_box.js 29a35ef Diff: https://reviews.apache.org/r/49475/diff/ Testing --- Manually tested on live cluster. 28939 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49664: HDFS Summary Panel is not showing the NameNode heap size correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49664/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17572 https://issues.apache.org/jira/browse/AMBARI-17572 Repository: ambari Description --- Fix parameter name. Diffs - ambari-web/app/views/main/service/services/hdfs.js 4bc2cce Diff: https://reviews.apache.org/r/49664/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28941 tests complete (30 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49677: YARN Summary Panel shows ResourceManager heap incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49677/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17574 https://issues.apache.org/jira/browse/AMBARI-17574 Repository: ambari Description --- Use correct template. Diffs - ambari-web/app/messages.js dcf0426 ambari-web/app/views/main/service/services/yarn.js 7ccbfcf Diff: https://reviews.apache.org/r/49677/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28941 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49931: AMBARI-17663 - Hosts page: JS error when sorting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49931/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17663 https://issues.apache.org/jira/browse/AMBARI-17663 Repository: ambari Description --- Fix undefined reference. Diffs - ambari-web/app/views/common/sort_view.js bbb6004 Diff: https://reviews.apache.org/r/49931/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 29018 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 50014: AMBARI-17703 - Hosts page: after component filter hosts have wrong list of components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50014/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17703 https://issues.apache.org/jira/browse/AMBARI-17703 Repository: ambari Description --- Enable preload for host component related filters Diffs - ambari-web/app/controllers/global/update_controller.js 98f528f ambari-web/app/controllers/main/host.js cea40cb Diff: https://reviews.apache.org/r/50014/diff/ Testing --- Manually tested on live cluster, all unit tests passed. 29021 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 50100: AMBARI-17754 - Issue with modify configs for hive service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50100/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-17754 https://issues.apache.org/jira/browse/AMBARI-17754 Repository: ambari Description --- Fix reference to undefined. Diffs - ambari-web/app/mixins/common/configs/enhanced_configs.js 46744ba Diff: https://reviews.apache.org/r/50100/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 29285 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 50165: AMBARI-17777 Unexpected behavior on Select Version page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50165/#review142796 --- Ship it! Ship It! - Richard Zang On July 18, 2016, 10:20 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50165/ > --- > > (Updated July 18, 2016, 10:20 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-1 > https://issues.apache.org/jira/browse/AMBARI-1 > > > Repository: ambari > > > Description > --- > > STR: > # Go to SelectVersion page > # Clear any input with Base URL (for ex. ubuntu14) > # Click on next button > > Expected: input has now red borders and warning message appears below > "Attention: All repo URLs are required before you can proceed." > > Actually: Next button became to disabled state. Next page wasn't loaded. > > > Diffs > - > > ambari-web/app/controllers/installer.js 037e555 > ambari-web/app/models/operating_system.js c2588fe > > Diff: https://reviews.apache.org/r/50165/diff/ > > > Testing > --- > > Local ambari-web test passed. > 29285 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 50275: AMBARI-17821 Atlas: Add Service Customize Services Page Issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50275/ --- Review request for Ambari, Andrii Tkach and Zhe (Joe) Wang. Bugs: AMBARI-17821 https://issues.apache.org/jira/browse/AMBARI-17821 Repository: ambari Description --- Push UI after recommendation finish Diffs - ambari-web/app/views/common/configs/service_config_container_view.js 8b6a9ce ambari-web/test/views/common/configs/service_config_container_view_test.js e7aaa62 Diff: https://reviews.apache.org/r/50275/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 29292 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 51356: AMBARI-18247 Capacity scheduler's dependent config suggestion is incomprehensible
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51356/#review146871 --- Ship it! Ship It! - Richard Zang On Aug. 24, 2016, 1 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51356/ > --- > > (Updated Aug. 24, 2016, 1 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18247 > https://issues.apache.org/jira/browse/AMBARI-18247 > > > Repository: ambari > > > Description > --- > > Dependent configs dialog shows recommended values for capacity scheduler > which is incomprehensible to read. It will be good to breakdown the specific > changes into separate rows. > > > Diffs > - > > ambari-web/app/mixins/common/configs/config_recommendations.js 398cf55 > ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs > 0fe073c > ambari-web/app/utils/config.js 7e1f5b8 > ambari-web/config.coffee 4a29e73 > ambari-web/karma.conf.js 013cc2e > ambari-web/test/mixins/common/configs/config_recommendations_test.js > 3f7d6b1 > ambari-web/vendor/scripts/difflib.js PRE-CREATION > ambari-web/vendor/scripts/diffview.js PRE-CREATION > ambari-web/vendor/styles/diffview.css PRE-CREATION > > Diff: https://reviews.apache.org/r/51356/diff/ > > > Testing > --- > > Modified unit test. > Local ambari-web test passed. > 29244 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 51463: Compare versions does not work in some cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51463/ --- Review request for Ambari, Andrii Tkach, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18268 https://issues.apache.org/jira/browse/AMBARI-18268 Repository: ambari Description --- Add a null check in case some of the final configs does not exist. Diffs - ambari-web/app/mixins/common/configs/configs_comparator.js 79820c0 Diff: https://reviews.apache.org/r/51463/diff/ Testing --- Manually test on live cluster. All unit tests passed. 30013 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 51440: AMBARI-15309 UI: ability to perform bulk delete host components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51440/#review147032 --- Ship it! Ship It! - Richard Zang On Aug. 25, 2016, 10:50 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51440/ > --- > > (Updated Aug. 25, 2016, 10:50 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15309 > https://issues.apache.org/jira/browse/AMBARI-15309 > > > Repository: ambari > > > Description > --- > > UI: ability to perform bulk delete host components > > > Diffs > - > > ambari-web/app/controllers/main/host/bulk_operations_controller.js 0e73c0c > ambari-web/app/messages.js 4cf3564 > ambari-web/app/utils/ajax/ajax.js 5538e6d > ambari-web/app/views/main/host/hosts_table_menu_view.js dccffaa > > Diff: https://reviews.apache.org/r/51440/diff/ > > > Testing > --- > > Local ambari-web test passed. > 30014 tests complete (26 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/ --- Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18389 https://issues.apache.org/jira/browse/AMBARI-18389 Repository: ambari Description --- "placeholder" only make sense when config is editable. Diffs - ambari-web/app/models/configs/objects/service_config_property.js 0c7673d ambari-web/test/models/configs/objects/service_config_property_test.js a6772d3 Diff: https://reviews.apache.org/r/51897/diff/ Testing --- Manually tested on live cluster, all unit tests passed. Thanks, Richard Zang
Re: Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/ --- (Updated Sept. 14, 2016, 8:40 p.m.) Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Changes --- Add all related fields to dependency. Bugs: AMBARI-18389 https://issues.apache.org/jira/browse/AMBARI-18389 Repository: ambari Description --- "placeholder" only make sense when config is editable. Diffs (updated) - ambari-web/app/models/configs/objects/service_config_property.js 0c7673d ambari-web/test/models/configs/objects/service_config_property_test.js a6772d3 Diff: https://reviews.apache.org/r/51897/diff/ Testing --- Manually tested on live cluster, all unit tests passed. Thanks, Richard Zang
Review Request 52102: UI for user home directory creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-15059 https://issues.apache.org/jira/browse/AMBARI-15059 Repository: ambari Description --- Add extra handling logic for navigating out and save button. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js 582b68b ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html ee5d860 Diff: https://reviews.apache.org/r/52102/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 secs) Thanks, Richard Zang
Re: Review Request 52102: UI for user home directory creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/ --- (Updated Sept. 21, 2016, 12:04 a.m.) Review request for Ambari and Zhe (Joe) Wang. Changes --- remove IDE related indentation Bugs: AMBARI-15059 https://issues.apache.org/jira/browse/AMBARI-15059 Repository: ambari Description --- Add extra handling logic for navigating out and save button. Diffs (updated) - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js 582b68b ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html ee5d860 Diff: https://reviews.apache.org/r/52102/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 secs) Thanks, Richard Zang
Re: Review Request 51702: Ambari UI: Memory leak while adding and removing property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51702/#review150776 --- Ship it! Ship It! - Richard Zang On Sept. 27, 2016, 11:42 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51702/ > --- > > (Updated Sept. 27, 2016, 11:42 p.m.) > > > Review request for Ambari, Andrii Tkach, Zhe (Joe) Wang, Richard Zang, and > Yusaku Sako. > > > Bugs: AMBARI-18308 > https://issues.apache.org/jira/browse/AMBARI-18308 > > > Repository: ambari > > > Description > --- > > Go to any of the service config screen ( for e.x Hive ) and add and remove > multiple properties one after another (without using bulk add). > This results in javascript memory leak. > > > Diffs > - > > ambari-web/app/views/common/configs/service_configs_by_category_view.js > ad1a2f9 > > ambari-web/test/views/common/configs/service_configs_by_category_view_test.js > 7b6c451 > > Diff: https://reviews.apache.org/r/51702/diff/ > > > Testing > --- > > tested the patch manually to resolve the issue. > verified that all ambari-web unit tests passes with the patch: > > 29244 tests complete (29 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 52497: Enable Add/Remove JournalNode on NNHA Wizard Step 2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52497/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18519 https://issues.apache.org/jira/browse/AMBARI-18519 Repository: ambari Description --- Enable Add/Remove JournalNode on NNHA Wizard Step 2 Diffs - ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js b8d7978 ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs 27653d3 Diff: https://reviews.apache.org/r/52497/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 30366 tests complete (30 seconds) 151 tests pending Thanks, Richard Zang
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151604 --- Ship it! Ship It! - Richard Zang On Oct. 4, 2016, 12:51 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 4, 2016, 12:51 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-web/app/styles/common.less bc11d4d > ambari-web/package.json 6702471 > ambari-web/pom.xml 759b63e > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration SUCCESS [20.801s] > [INFO] Hive Jdbc . SUCCESS [1:00.664s] > [INFO] WF Manager View ... SUCCESS [32.911s] > [INFO] Hive .
Re: Review Request 52710: AMBARI-18566 Installer wizard-> Select Versions page: Selecting Red Hat Satellite option and clicking next button makes wizard stuck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52710/#review152231 --- Ship it! Ship It! - Richard Zang On Oct. 12, 2016, 12:07 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52710/ > --- > > (Updated Oct. 12, 2016, 12:07 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18566 > https://issues.apache.org/jira/browse/AMBARI-18566 > > > Repository: ambari > > > Description > --- > > *STR:* > # Got to select versions page > # Choose "Use Local Repository" option and then choose "Use RedHat > Satellite/Spacewalk" option > # Next button will get enabled. click on next button. > > *Expected Result:* wizard goes to next page > *Actual Result:* On clicking next button, next button gets disabled and > wizard does not go to next page. > > > Diffs > - > > ambari-web/app/controllers/installer.js f8f70a0 > ambari-web/app/views/wizard/step1_view.js 2b80ad5 > > Diff: https://reviews.apache.org/r/52710/diff/ > > > Testing > --- > > Local ambari-web test passed. > 30374 tests complete (27 seconds) > 151 tests pending > Manual testing done > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 52555: AMBARI-18535 Ambari is not picking up the latest repo for HDP-2.4
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52555/#review152392 --- Ship it! Ship It! - Richard Zang On Oct. 5, 2016, 3:25 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52555/ > --- > > (Updated Oct. 5, 2016, 3:25 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18535 > https://issues.apache.org/jira/browse/AMBARI-18535 > > > Repository: ambari > > > Description > --- > > During fresh deployment, if HDP-2.4 is chosen then Ambari does not default to > the latest 2.4 release, HDP-2.4.2. This is likely because VDF files do not > exist for HDP-2.4 release and the older mechanism of picking the latest repo > URL form the hdp_urlinfo.json does not work. HDP-2.4.0 is chosen where as the > latest is HDP-2.4.2 > > > Diffs > - > > ambari-web/app/controllers/installer.js f8f70a0 > > Diff: https://reviews.apache.org/r/52555/diff/ > > > Testing > --- > > Local ambari-web test passed. > 30374 tests complete (27 seconds) > 151 tests pending > Manual testing done > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review153220 --- Ship it! Ship It! - Richard Zang On Oct. 18, 2016, 11:37 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 18, 2016, 11:37 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-admin/src/main/resources/ui/admin-web/package.json 42f584e > ambari-web/app/styles/common.less a053d28 > ambari-web/karma.conf.js 7442b95 > ambari-web/package.json 94ded60 > ambari-web/pom.xml d3de055 > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration SUCCESS [20.801s] > [INFO] Hive Jdbc . SUCCESS [1:00.664s] > [INFO] WF Manager View ... SUCCESS [32.91
