[Impala-ASF-CR] IMPALA-6650: Add fine-grained DROP privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9911 )

Change subject: IMPALA-6650: Add fine-grained DROP privilege
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
File fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java:

http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java@191
PS1, Line 191: if (privilegeLevel_ != TPrivilegeLevel.ALL &&
> I'm not sure what the behavior of Hive is. I can look into it and create a
Exactly. I also think it makes sense to have INSERT and/or SELECT on SERVER. 
Might be good to confirm with Adam/Steve also.


http://gerrit.cloudera.org:8080/#/c/9911/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/9911/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@2479
PS3, Line 2479: withTestFunction(ctx_.catalog, "functional_text_lzo", "f",
I think it's better to follow the existing addTestDb() addTestTable() pattern 
for consistency. We already have the @Test scope for these test 
dbs/tables/functions. It's not clear to me we need a finer-grained scope.

We can talk about changing the pattern for all addTestSomething() methods, but 
let's leave that for later.

In many cases a single db/table/function is used in several tests, so it's not 
clear to me that this pattern produces simpler code in that case (nesting and 
indirection is harder to read).



--
To view, visit http://gerrit.cloudera.org:8080/9911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Wed, 04 Apr 2018 04:25:30 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6650: Add fine-grained DROP privilege

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/9911 )

Change subject: IMPALA-6650: Add fine-grained DROP privilege
..

IMPALA-6650: Add fine-grained DROP privilege

Add support for executing DROP statements by granting DROP privilege.

These are the new GRANT/REVOKE statements introduced at server,
database, and table scopes.

GRANT DROP on SERVER svr TO ROLE testrole;
GRANT DROP on DATABASE db TO ROLE testrole;
GRANT DROP on TABLE tbl TO ROLE testrole;

REVOKE DROP on SERVER svr FROM ROLE testrole;
REVOKE DROP on DATABASE db FROM ROLE testrole;
REVOKE DROP on TABLE tbl FROM ROLE testrole;

Testing:
- Added new front-end tests
- Ran front-end tests

Cherry-picks: not for 2.x

Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
---
M common/thrift/CatalogObjects.thrift
M fe/.gitignore
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationChecker.java
M fe/src/main/java/org/apache/impala/authorization/Privilege.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/resources/authz-policy.ini.template
12 files changed, 187 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/9911/4
--
To view, visit http://gerrit.cloudera.org:8080/9911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc@551
PS3, Line 551: failure_detector_->UpdateHeartbeat(subscriber_id, true);
> I think we should update the header statestore.h that failure_detector_ is
Yeah good idea.


http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc@873
PS3, Line 873: if (state == FailureDetector::FAILED) {
> I had the same question for Tim over chat (after reading the commit message
Yeah there was some context in the JIRA that wasn't super-clear in the commit 
message - the problematic case is when you restart an impala daemon and the 
failure info is left over from the previous subscription.



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 04:05:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Hello Bharath Vissapragada, Tianyi Wang, Sailesh Mukil,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9913

to look at the new patch set (#4).

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..

IMPALA-6785: reset failed heartbeat count when re-registering

When a subscriber re-registers with the same subscriber ID, we need
to reset failure detection info so that we don't erroneously think
that the subscriber has failed.

The bug is a mix-up between whether the subscriber or registration ID is
the key for the failure detected. The symptom was that, if the first
topic update won the race with the first heartbeat, no subsequent topic
updates were delivered. It was introduced when IMPALA-3613 updated some,
but not all, places to use the subscriber ID as the key. It wasn't
detected because we had no tests directly testing this code path, and
it appears that the race almost never happens on smaller clusters.

This patch fixes the problem in two places. Fixing either place is
actually sufficient to fix the bug.

Testing:
Add a regression that reliably reproduces the issue by delaying the
heartbeat and checking that topic updates continue to be sent. The
test reliably fails before the fix and passes after.

Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
---
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M tests/statestore/test_statestore.py
3 files changed, 37 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9913/4
--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Bharath Vissapragada (Code Review)]

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc@873
PS3, Line 873: if (state == FailureDetector::FAILED) {
> If the topic update is processed first, GetPeerState() will return UNKNOWN.
I had the same question for Tim over chat (after reading the commit message), 
but it appears that the logging here is intended for resubscription of 
subscribers that are already marked FAILED. I got that after reading the added 
test (test_heartbeat_failure_reset). Tim, please correct me if I'm wrong.



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 03:48:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Mostafa Mokhtar (Code Review)]

Mostafa Mokhtar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc@260
PS2, Line 260: if (i < 2) SleepForMs(100);
I would feel more comfortable if the 100ms is under a flag as this might 
uncover false positives on large clusters with busy coordinators.


http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc@274
PS2, Line 274:  << "Query " << PrintId(query_id()) << " may 
hang. See IMPALA-2990.";
> Should we include the reason for the abort here? Otherwise the large number
Can't connect to coordinator Vs. Can't report status?



--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 02:41:34 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6650: Add fine-grained DROP privilege

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/9911 )

Change subject: IMPALA-6650: Add fine-grained DROP privilege
..

IMPALA-6650: Add fine-grained DROP privilege

Add support for executing DROP statements by granting DROP privilege.

These are the new GRANT/REVOKE statements introduced at server,
database, and table scopes.

GRANT DROP on SERVER svr TO ROLE testrole;
GRANT DROP on DATABASE db TO ROLE testrole;
GRANT DROP on TABLE tbl TO ROLE testrole;

REVOKE DROP on SERVER svr FROM ROLE testrole;
REVOKE DROP on DATABASE db FROM ROLE testrole;
REVOKE DROP on TABLE tbl FROM ROLE testrole;

Testing:
- Added new front-end tests
- Ran front-end tests

Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
---
M common/thrift/CatalogObjects.thrift
M fe/.gitignore
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationChecker.java
M fe/src/main/java/org/apache/impala/authorization/Privilege.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/resources/authz-policy.ini.template
12 files changed, 187 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/9911/3
--
To view, visit http://gerrit.cloudera.org:8080/9911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 

[Impala-ASF-CR](2.x) IMPALA-6753: Update CDH versions in asf/2.x/impala-config.sh

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9914 )

Change subject: IMPALA-6753: Update CDH versions in asf/2.x/impala-config.sh
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5f041dc5f0d7eda87c2a2b95925bd99f3bd62e
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Wed, 04 Apr 2018 02:16:17 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 2:

(1 comment)

Just a thought passing by, no need to hold the change up for this.

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc@274
PS2, Line 274:  << "Query " << PrintId(query_id()) << " may 
hang. See IMPALA-2990.";
Should we include the reason for the abort here? Otherwise the large number of 
cases that possibly lead to this error could make debugging unnecessarily hard.



--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 02:14:14 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..

IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces

Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Reviewed-on: http://gerrit.cloudera.org:8080/9385
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 20 insertions(+), 7 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 7: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 01:48:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tianyi Wang (Code Review)]

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc@873
PS3, Line 873: if (state == FailureDetector::FAILED) {
If the topic update is processed first, GetPeerState() will return UNKNOWN. How 
could it get into this branch?



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 01:43:23 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Bharath Vissapragada (Code Review)]

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 3: Code-Review+1

(1 comment)

Patch lgtm

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/9913/3/be/src/statestore/statestore.cc@551
PS3, Line 551: failure_detector_->UpdateHeartbeat(subscriber_id, true);
I think we should update the header statestore.h that failure_detector_ is 
based on subscriber_id



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 01:27:18 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

[Tianyi Wang (Code Review)]

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1157
PS3, Line 1157: oldDbNames.remove(BUILTINS_DB);
> what is it about this change that requires this additional precaution?
I haven't figured out. I spent some time on it and what I know is that without 
this patch the remove operation is sent out by catalog but somehow not received 
by impalad. I suppose removing it in this fix is safe.


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py
File tests/custom_cluster/test_restart_services.py:

http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@42
PS2, Line 42: return
> is there a metric to wait on, for example number of subscribers at the stat
I don't think existing metrics can do that. The query is guaranteed to succeed 
after the first 1) *non-empty* catalog update from the 2) *new statestore* is 
received by impala. We can check who the current statestore is, whether the 
current catalog is empty, but nothing more.


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@44
PS2, Line 44: sleep(10)
> just checking, what error do you get without your fix?
AnalysisException: Database does not exist: functional


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@47
PS2, Line 47:
> what's this sleep for in the catch?
We don't know when the non-empty update from the new statestore will come. This 
sleep tries to wait for it.



--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 04 Apr 2018 01:12:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

[Vuk Ercegovac (Code Review)]

Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1157
PS3, Line 1157: oldDbNames.remove(BUILTINS_DB);
what is it about this change that requires this additional precaution?



--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 04 Apr 2018 01:00:51 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9030 )

Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for 
INSERT/UPSERT
..

IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9
Reviewed-on: http://gerrit.cloudera.org:8080/9030
Reviewed-by: Alex Rodoni 
Reviewed-by: Kim Jin Chul 
Reviewed-by: John Russell 
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_upsert.xml
3 files changed, 48 insertions(+), 5 deletions(-)

Approvals:
  Alex Rodoni: Looks good to me, but someone else must approve
  Kim Jin Chul: Looks good to me, but someone else must approve
  John Russell: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9
Gerrit-Change-Number: 9030
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Vuk Ercegovac 

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9030 )

Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for 
INSERT/UPSERT
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9
Gerrit-Change-Number: 9030
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:55:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9922 )

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:55:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9922 )

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..

IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by default

- Marked IMPALA-5500 as fixed in Impala 2.10 in the impala_known_issues.
xml
- In the same section, removed the mention of default setting being false.
- Added a section in impala_upgrading.xml for default setting Changes.
- Added new keydefs for 2.12 and 3.0 version strings.

Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Reviewed-on: http://gerrit.cloudera.org:8080/9922
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_known_issues.xml
M docs/topics/impala_upgrading.xml
3 files changed, 42 insertions(+), 11 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..

IMPALA-6793: Fix empty metadata after statestore restarts

IMPALA-5990 introduced a bug where restarting the statestore
deterministically clears the metadata without ever coming back. The
cause of the bug is a wrong condition used by catalog to detect the
restart of statestore.

A custom cluster regression test is added.

Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
A tests/custom_cluster/test_restart_services.py
4 files changed, 59 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/9921/3
--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vuk Ercegovac 

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

[Vuk Ercegovac (Code Review)]

Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py
File tests/custom_cluster/test_restart_services.py:

http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@42
PS2, Line 42: for retry in range(0, 10):
is there a metric to wait on, for example number of subscribers at the 
statestore and backends at the impalads (instead of a retry)?


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@44
PS2, Line 44: cursor.execute("describe database functional")
just checking, what error do you get without your fix?


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@47
PS2, Line 47: sleep(10)
what's this sleep for in the catch?



--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:42:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9030 )

Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for 
INSERT/UPSERT
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/222/


--
To view, visit http://gerrit.cloudera.org:8080/9030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9
Gerrit-Change-Number: 9030
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:40:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9922 )

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/221/


--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:34:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9922 )

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:33:11 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9030 )

Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for 
INSERT/UPSERT
..


Patch Set 2:

Could a committer start the jenkins job, please?


--
To view, visit http://gerrit.cloudera.org:8080/9030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9
Gerrit-Change-Number: 9030
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:22:47 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9891 )

Change subject: IMPALA-6771: Fix in-predicate set up bug
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9891/2/be/src/exprs/in-predicate.h
File be/src/exprs/in-predicate.h:

http://gerrit.cloudera.org:8080/#/c/9891/2/be/src/exprs/in-predicate.h@354
PS2, Line 354: - 1
> Thanks, didn't notice that.
This seems ok but I think we be restrained with use of reserve() calls outside 
of hot code paths since the performance benefit is minimal. It's ok in this 
function but in more complex code it adds noise that could make code less 
readable.



--
To view, visit http://gerrit.cloudera.org:8080/9891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e776dbcb7ee4a9b64e1295134a27d332f5415b6
Gerrit-Change-Number: 9891
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:20:04 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 2: Code-Review+2

I'm fine with merging this as-is but I'd feel better if we followed up with a 
regression test.


--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:14:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Alex Rodoni (Code Review)]

Hello John Russell, Alex Behm, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9922

to look at the new patch set (#2).

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..

IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by default

- Marked IMPALA-5500 as fixed in Impala 2.10 in the impala_known_issues.
xml
- In the same section, removed the mention of default setting being false.
- Added a section in impala_upgrading.xml for default setting Changes.
- Added new keydefs for 2.12 and 3.0 version strings.

Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_known_issues.xml
M docs/topics/impala_upgrading.xml
3 files changed, 42 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/9922/2
--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9884 )

Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for 
HBase tables
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:12:29 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9884 )

Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for 
HBase tables
..

IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

This patch fixes the NullPointerException in SHOW CREATE TABLE for HBase
tables.

Testing:
- Moved the content of back hbase-show-create-table.test to
  show-create-table.test
- Ran show-create-table end-to-end tests

Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Reviewed-on: http://gerrit.cloudera.org:8080/9884
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
D 
testdata/workloads/functional-query/queries/QueryTest/hbase-show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M tests/metadata/test_show_create_table.py
4 files changed, 33 insertions(+), 29 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

[Dimitris Tsirogiannis (Code Review)]

Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9921/2/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

http://gerrit.cloudera.org:8080/#/c/9921/2/be/src/catalog/catalog-server.cc@231
PS2, Line 231: // If not generating a delta update and 'pending_topic_updates_' 
doesn't already contain
 :   // the full catalog (beginning with version 0), then force 
GatherCatalogUpdatesThread()
 :   // to reload the full catalog.
Can you expand the comment a bit to describe what happens in the case when 
delta.from_version == 0?


http://gerrit.cloudera.org:8080/#/c/9921/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/9921/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1155
PS2, Line 1155:   oldDbNames.remove(BUILTINS_DB);
This is not intuitive. Plz explain what is happening here and how the 
builtins_db will be reconstructed.



--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:53:53 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9913/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9913/2//COMMIT_MSG@16
PS2, Line 16:
> nit: Add that this is an extension of IMPALA-3613, so it's easier to unders
Done



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:47:41 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Hello Bharath Vissapragada, Tianyi Wang, Sailesh Mukil,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9913

to look at the new patch set (#3).

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..

IMPALA-6785: reset failed heartbeat count when re-registering

The bug is a mix-up between whether the subscriber or registration ID is
the key for the failure detected. The symptom was that, if the first
topic update won the race with the first heartbeat, no subsequent topic
updates were delivered. It was introduced when IMPALA-3613 updated some,
but not all, places to use the subscriber ID as the key. It wasn't
detected because we had no tests directly testing this code path, and
it appears that the race almost never happens on smaller clusters.

This patch fixes the problem in two places. Fixing either place is
actually sufficient to fix the bug.

Testing:
Add a regression that reliably reproduces the issue by delaying the
heartbeat and checking that topic updates continue to be sent. The
test reliably fails before the fix and passes after.

Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
---
M be/src/statestore/statestore.cc
M tests/statestore/test_statestore.py
2 files changed, 32 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9913/3
--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Tim Armstrong (Code Review)]

Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..

IMPALA-6791: distcc server setup script

Adds a script that can be run to configure a working distcc server with
ccache. This is based roughly on the manual steps in the README.

Testing:
Tested the scripts on Ubuntu and CentOS 6 systems. They resulted in a
working distcc server.

Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Reviewed-on: http://gerrit.cloudera.org:8080/9901
Reviewed-by: Taras Bobrovytsky 
Tested-by: Tim Armstrong 
---
M bin/distcc/README.md
A bin/distcc/distcc_server_setup.sh
2 files changed, 131 insertions(+), 1 deletion(-)

Approvals:
  Taras Bobrovytsky: Looks good to me, approved
  Tim Armstrong: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..


Patch Set 7: Verified+1

Manually tested. We don't exercise this code in precommit so going ahead and 
merging.


--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:45:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 2:

(2 comments)

I don't understand the catalog part of this but took a look at the test.

http://gerrit.cloudera.org:8080/#/c/9921/1/tests/custom_cluster/test_restart_services.py
File tests/custom_cluster/test_restart_services.py:

http://gerrit.cloudera.org:8080/#/c/9921/1/tests/custom_cluster/test_restart_services.py@41
PS1, Line 41: sleep(60)
> This test looks flaky but I haven't found find a better way to do it. The b
Is there a metric we can poll that would indicate the expected state?


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py
File tests/custom_cluster/test_restart_services.py:

http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@38
PS2, Line 38: os.system("kill -9 $(pidof statestored)")
We should be able to use the Process.restart() method 
(https://github.com/apache/impala/blob/master/tests/common/impala_cluster.py#L175),
 something like below. Just running the shell commands directly leaves the 
ImpalaCluster object in a weird state.

  self.cluster.statestored.restart()



--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:44:31 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9913/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9913/2//COMMIT_MSG@16
PS2, Line 16:
nit: Add that this is an extension of IMPALA-3613, so it's easier to understand 
the context.



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:42:30 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9300 )

Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3
..


Patch Set 10:

I think it would be good to have Michael Ho do a review in addition to Sailesh 
(who I see has completed his).


--
To view, visit http://gerrit.cloudera.org:8080/9300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6
Gerrit-Change-Number: 9300
Gerrit-PatchSet: 10
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:39:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Taras Bobrovytsky (Code Review)]

Taras Bobrovytsky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..


Patch Set 7: Code-Review+2

lgtm


--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:31:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Taras Bobrovytsky (Code Review)]

Taras Bobrovytsky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9901/6/bin/distcc/distcc_server_setup.sh
File bin/distcc/distcc_server_setup.sh:

http://gerrit.cloudera.org:8080/#/c/9901/6/bin/distcc/distcc_server_setup.sh@62
PS6, Line 62:  a
nit: 6 and 7


http://gerrit.cloudera.org:8080/#/c/9901/6/bin/distcc/distcc_server_setup.sh@81
PS6, Line 81: # Configure ccache for distccd user
Do you think it's a good idea to turn these comments into echos? I saw that 
Phil Z has been doing this in some of our bash scripts.



--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:19:49 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded a new patch set (#10). ( 
http://gerrit.cloudera.org:8080/9300 )

Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3
..

IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

Dependency changes:
- BE and python use thrift 0.9.3-p3 from native-toolchain.
- FE uses thrift 0.9.3 from apache maven repo.
- Fb303 and http components dependencies are no longer needed in FE and
  are removed.
- The minimum openssl version requirement is increased to 1.0.1.

Configuration change:
- Thrift codegen option movable_type is enabled. New code no longer
  needs to use std::swap to avoid copying.

Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6
---
M CMakeLists.txt
M be/src/common/init.cc
M be/src/rpc/TAcceptQueueServer.cpp
M be/src/rpc/TAcceptQueueServer.h
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-thread.h
M be/src/rpc/thrift-util.cc
M bin/impala-config.sh
M buildall.sh
M common/thrift/CMakeLists.txt
M fe/pom.xml
M infra/python/deps/compiled-requirements.txt
14 files changed, 77 insertions(+), 174 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/9300/10
--
To view, visit http://gerrit.cloudera.org:8080/9300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6
Gerrit-Change-Number: 9300
Gerrit-PatchSet: 10
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: anujphadke 

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded a new patch set (#13). ( 
http://gerrit.cloudera.org:8080/9168 )

Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types
..

IMPALA-5690: Part 1: Rename ostream operators for thrift types

Thrift 0.9.3 implements "ostream& operator<<(ostream&, T)" for thrift
data types while impala did the same to enums and special types
including TNetworkAddress and TUniqueId. To prepare for the upgrade of
thrift 0.9.3, this patch renames these impala defined functions. In the
absence of operator<<, assertion macros like DCHECK_EQ can no longer be
used on non-enum thrift defined types.

Change-Id: I9c303997411237e988ef960157f781776f6fcb60
---
M be/src/benchmarks/scheduler-benchmark.cc
M be/src/codegen/llvm-codegen.cc
M be/src/exec/exchange-node.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/parquet-metadata-utils.cc
M be/src/rpc/rpc-trace.cc
M be/src/rpc/thrift-client.cc
M be/src/rpc/thrift-util.cc
M be/src/rpc/thrift-util.h
M be/src/runtime/client-cache.cc
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/data-stream-mgr.cc
M be/src/runtime/data-stream-recvr.cc
M be/src/runtime/data-stream-sender.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/mem-tracker.cc
M be/src/runtime/query-exec-mgr.cc
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-state.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/scheduler.cc
M be/src/service/child-query.cc
M be/src/service/client-request-state.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-internal-service.cc
M be/src/service/impala-server.cc
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
M be/src/service/query-result-set.cc
M be/src/statestore/statestore.cc
M be/src/util/collection-metrics.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M be/src/util/histogram-metric.h
M be/src/util/metrics.h
M be/src/util/network-util.cc
M be/src/util/network-util.h
M be/src/util/webserver.cc
M testdata/workloads/functional-query/queries/QueryTest/set.test
M tests/shell/test_shell_commandline.py
49 files changed, 280 insertions(+), 288 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/9168/13
--
To view, visit http://gerrit.cloudera.org:8080/9168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c303997411237e988ef960157f781776f6fcb60
Gerrit-Change-Number: 9168
Gerrit-PatchSet: 13
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tianyi Wang 

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9922 )

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..


Patch Set 1:

Works for me.


--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:57:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9922 )

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..


Patch Set 1:

We could add a section, Upgrade Considerations, in upgrading_impala.xml. Will 
that work?


--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:56:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9891 )

Change subject: IMPALA-6771: Fix in-predicate set up bug
..


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9891/2/be/src/exprs/in-predicate.h
File be/src/exprs/in-predicate.h:

http://gerrit.cloudera.org:8080/#/c/9891/2/be/src/exprs/in-predicate.h@354
PS2, Line 354: - 1
> the for loop below this goes from i = 1 to i < ctx->GetNumArgs(), which is
Thanks, didn't notice that.



--
To view, visit http://gerrit.cloudera.org:8080/9891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e776dbcb7ee4a9b64e1295134a27d332f5415b6
Gerrit-Change-Number: 9891
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:55:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

[Bikramjeet Vig (Code Review)]

Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9891 )

Change subject: IMPALA-6771: Fix in-predicate set up bug
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9891/2/be/src/exprs/in-predicate.h
File be/src/exprs/in-predicate.h:

http://gerrit.cloudera.org:8080/#/c/9891/2/be/src/exprs/in-predicate.h@354
PS2, Line 354: - 1
> Why - 1 ? Couldn't there be at most 'ctx->GetNumArgs()' entries ? Or are we
the for loop below this goes from i = 1 to i < ctx->GetNumArgs(), which is a 
total of ctx->GetNumArgs() - 1 entries



--
To view, visit http://gerrit.cloudera.org:8080/9891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e776dbcb7ee4a9b64e1295134a27d332f5415b6
Gerrit-Change-Number: 9891
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:53:44 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in bootstrap *.sh

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9873 )

Change subject: IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in 
bootstrap_*.sh
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d63c9713cc93a786f82e086feca1a91937e16
Gerrit-Change-Number: 9873
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:52:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9922 )

Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..


Patch Set 1:

Should we introduce a new section for "changed default configurations" or 
similar? For example, we will also enable the file handle cache, and change 
several other default configuration and/or query options values.

What do you think?


--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:51:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in bootstrap *.sh

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9873 )

Change subject: IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in 
bootstrap_*.sh
..

IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in bootstrap_*.sh

Since it's not straight-forward to get Java 8 for Ubuntu 14.04, I'm
removing it from the setups supported by the bootstrap scripts.

Change-Id: I4b6d63c9713cc93a786f82e086feca1a91937e16
Reviewed-on: http://gerrit.cloudera.org:8080/9873
Reviewed-by: Thomas Tauber-Marshall 
Tested-by: Impala Public Jenkins
---
M bin/bootstrap_development.sh
M bin/bootstrap_system.sh
2 files changed, 6 insertions(+), 16 deletions(-)

Approvals:
  Thomas Tauber-Marshall: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b6d63c9713cc93a786f82e086feca1a91937e16
Gerrit-Change-Number: 9873
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Thomas Tauber-Marshall 

[Impala-ASF-CR] IMPALA-6688: [DOCS] compact catalog topic setting is enabled by default

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9922


Change subject: IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by 
default
..

IMPALA-6688: [DOCS] compact_catalog_topic setting is enabled by default

- Marked IMPALA-5500 as fixed in Impala 2.10 in the impala_known_issues.
xml
- In the same section, removed the mention of default setting being false.

Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
---
M docs/topics/impala_known_issues.xml
1 file changed, 11 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/9922/1
--
To view, visit http://gerrit.cloudera.org:8080/9922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6e9eef7e20fcc520865f3d6d065ed508b2917bb
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9857 )

Change subject: IMPALA-6389: Make '\0' delimited text files work
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2190c57681f29f34ee1eb393e30dfdda5839098c
Gerrit-Change-Number: 9857
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:42:31 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..

IMPALA-6793: Fix empty metadata after statestore restarts

IMPALA-5990 introduced a bug where restarting the statestore
deterministically clears the metadata without ever coming back. The
cause of the bug is a wrong condition used by catalog to detect the
restart of statestore.

A custom cluster regression test is added.

Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
A tests/custom_cluster/test_restart_services.py
4 files changed, 51 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/9921/2
--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restart

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9921


Change subject: IMPALA-6793: Fix empty metadata after statestore restart
..

IMPALA-6793: Fix empty metadata after statestore restart

IMPALA-5990 introduced a bug where restarting the statestore
deterministically clears the metadata without ever coming back. The
cause of the bug is a wrong condition used by catalog to detect the
restart of statestore.

A custom cluster regression test is added.

Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
A tests/custom_cluster/test_restart_services.py
4 files changed, 51 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/9921/1
--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Tianyi Wang 

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 2: Code-Review+1

Please get a second review.


--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:32:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9916/1/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

http://gerrit.cloudera.org:8080/#/c/9916/1/be/src/runtime/query-state.cc@269
PS1, Line 269: !client_status.o
> shouldn't we check client_status here too?
Good catch. Done.



--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:31:07 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Sailesh Mukil (Code Review)]

Hello Tim Armstrong, Dan Hecht,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9916

to look at the new patch set (#2).

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..

IMPALA-6792: Fail status reporting if coordinator refuses connections

The ReportExecStatusAux() function is run on a dedicated thread per
fragment instance. This thread will run until the fragment instance
completes executing.

On every attempt to send a report to the coordinator, it will attempt
to send up to 3 RPCs. If all 3 of them fail, then the fragment instance
will cancel itself.

However, there is one case where a failure to send the RPC will not
be considered a failed RPC. If when we attempt to obtain a new
connection, we end up creating a new connection
(via ClientCache::CreateClient()) instead of getting a previously
cached connection, and this new connection fails to even Open(),
it will not be counted as a RPC failure.

This patch counts such an error as a failed RPC too.

Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
---
M be/src/runtime/query-state.cc
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/9916/2
--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9916/1/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

http://gerrit.cloudera.org:8080/#/c/9916/1/be/src/runtime/query-state.cc@269
PS1, Line 269: !rpc_status.ok()
shouldn't we check client_status here too?



--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:27:15 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..


Patch Set 5: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:17:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Taras Bobrovytsky (Code Review)]

Taras Bobrovytsky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9901/4/bin/distcc/distcc_server_setup.sh
File bin/distcc/distcc_server_setup.sh:

http://gerrit.cloudera.org:8080/#/c/9901/4/bin/distcc/distcc_server_setup.sh@20
PS4, Line 20: Ubuntu
Also CentOS


http://gerrit.cloudera.org:8080/#/c/9901/4/bin/distcc/distcc_server_setup.sh@60
PS4, Line 60:   DISTCCD_USER=nobody
Do we need to check the version of the OS here, like we do for Ubuntu?



--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:12:40 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Tim Armstrong (Code Review)]

Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9901

to look at the new patch set (#5).

Change subject: IMPALA-6791: distcc server setup script
..

IMPALA-6791: distcc server setup script

Adds a script that can be run to configure a working distcc server with
ccache. This is based roughly on the manual steps in the README.

Testing:
Tested the scripts on Ubuntu and CentOS 6 systems. They resulted in a
working distcc server.

Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
---
M bin/distcc/README.md
A bin/distcc/distcc_server_setup.sh
2 files changed, 128 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/9901/5
--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 1:

Something to add. This patch means that when previously we would have succeeded 
sending a report after many many iterations of trying, now we'll end up failing 
after 3 tries, which in all fairness was the original intent.

A comprehensive redesign of status reporting will be done as part of 
IMPALA-2990.


--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:11:44 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Tim Armstrong (Code Review)]

Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9901

to look at the new patch set (#4).

Change subject: IMPALA-6791: distcc server setup script
..

IMPALA-6791: distcc server setup script

Adds a script that can be run to configure a working distcc server with
ccache. This is based roughly on the manual steps in the README.

Testing:
Tested the scripts on Ubuntu and CentOS 6 systems. They resulted in a
working distcc server.

Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
---
M bin/distcc/README.md
A bin/distcc/distcc_server_setup.sh
2 files changed, 127 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/9901/4
--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh
File bin/distcc/distcc_server_setup.sh:

http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh@54
PS2, Line 54:   echo "This script only supports Ubuntu" >&2
> This seems untrue given line 49-52
Done


http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh@76
PS2, Line 76: ALLOWED_NETS=${ALLOWED_NETS:-172.16.0.0/12}
> This one seems weird to have a default for.
Yeah, I guess so. I convinced myself that it sort-of made sense since it was a 
common private network, but that still doesn't really make sense. I changed it 
to be a required argument.


http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh@83
PS2, Line 83:   # CCACHE_DIR is picked up by ccache from environment.
> Does this work on reboot? I'm surprised this doesn't need to be in /etc/def
This line is inside a string that is appended to /etc/default/distcc (it's 
within the EOF delimiters).

I also realised that it would be useful to include some comments in the config 
files stating where they came from.



--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:08:42 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Tim Armstrong (Code Review)]

Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9901

to look at the new patch set (#3).

Change subject: IMPALA-6791: distcc server setup script
..

IMPALA-6791: distcc server setup script

Adds a script that can be run to configure a working distcc server with
ccache. This is based roughly on the manual steps in the README.

Testing:
Tested the scripts on Ubuntu and CentOS 6 systems. They resulted in a
working distcc server.

Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
---
M bin/distcc/README.md
A bin/distcc/distcc_server_setup.sh
2 files changed, 123 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/9901/3
--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-6457: [DOCS] DECIMAL support for Kudu tables

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9918


Change subject: IMPALA-6457: [DOCS] DECIMAL support for Kudu tables
..

IMPALA-6457: [DOCS] DECIMAL support for Kudu tables

Removed DECIMAL from the unsupported data types for Kudu.

Change-Id: I5a2498b4a28c2a53a3fec9b634a770e42dcac499
---
M docs/shared/impala_common.xml
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/9918/1
--
To view, visit http://gerrit.cloudera.org:8080/9918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a2498b4a28c2a53a3fec9b634a770e42dcac499
Gerrit-Change-Number: 9918
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 7: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:55:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2232/


--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:55:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:55:09 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9915


Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..

IMPALA-6667: [DOCS] max_cached_file_handles is enabled by default

Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
---
M docs/topics/impala_scalability.xml
1 file changed, 11 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9915/1
--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9913/1/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/9913/1/be/src/statestore/statestore.cc@880
PS1, Line 880:   }
We're also missing logging here that would have made it much easier to narrow 
down the issue.



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:50:17 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..

IMPALA-6785: reset failed heartbeat count when re-registering

The bug is a mix-up between whether the subscriber or registration ID is
the key for the failure detected. The symptom was that, if the first
topic update won the race with the first heartbeat, no subsequent topic
updates were delivered.

This patch fixes the problem in two places. Fixing either place is
actually sufficient to fix the bug.

Testing:
Add a regression that reliably reproduces the issue by delaying the
heartbeat and checking that topic updates continue to be sent. The
test reliably fails before the fix and passes after.

Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
---
M be/src/statestore/statestore.cc
M tests/statestore/test_statestore.py
2 files changed, 32 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9913/2
--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8894 )

Change subject: IMPALA-6372: Go parallel for Hive dataload
..


Patch Set 9:

(2 comments)

I've now read through this. I think this is a very welcome change, nice work. I 
don't think there's anything major in my comments; this all seems like a nice 
incremental step.

http://gerrit.cloudera.org:8080/#/c/8894/9/testdata/bin/load_nested.py
File testdata/bin/load_nested.py:

http://gerrit.cloudera.org:8080/#/c/8894/9/testdata/bin/load_nested.py@254
PS9, Line 254:   with cluster.hive.cursor(db_name=target_db) as hive:
Should these be run in parallel? (Feel free to do separately.)


http://gerrit.cloudera.org:8080/#/c/8894/9/testdata/bin/load_nested.py@303
PS9, Line 303: impala.compute_stats()
I think compute_stats runs serially rather than in parallel.



--
To view, visit http://gerrit.cloudera.org:8080/8894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34b71e6df3c8f23a5a31451280e35f4dc015a2fd
Gerrit-Change-Number: 8894
Gerrit-PatchSet: 9
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:42:59 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9892 )

Change subject: IMPALA-6776: Increase region move timeout.
..

IMPALA-6776: Increase region move timeout.

Some builds are experiencing slow HBase region moves in the
test minicluster. Trying to increase the timeout from 10s to 60s.

Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Reviewed-on: http://gerrit.cloudera.org:8080/9892
Reviewed-by: Zach Amsden 
Tested-by: Impala Public Jenkins
---
M 
testdata/src/compat-minicluster-profile-3/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssigment.java
1 file changed, 13 insertions(+), 6 deletions(-)

Approvals:
  Zach Amsden: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Zach Amsden 

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9892 )

Change subject: IMPALA-6776: Increase region move timeout.
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:41:55 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6650: Add fine-grained DROP privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9911 )

Change subject: IMPALA-6650: Add fine-grained DROP privilege
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@91
PS1, Line 91:   //   SELECT, REFRESH, DROP permissions on 
'functional.alltypesagg' (no INSERT
> I think we can remove the "(no INSERT permissions)" part here elsewhere in
... are now obsolete.



--
To view, visit http://gerrit.cloudera.org:8080/9911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:31:39 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

[Bikramjeet Vig (Code Review)]

Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9891 )

Change subject: IMPALA-6771: Fix in-predicate set up bug
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9891/1/be/src/exprs/in-predicate.h
File be/src/exprs/in-predicate.h:

http://gerrit.cloudera.org:8080/#/c/9891/1/be/src/exprs/in-predicate.h@353
PS1, Line 353: element_list
> Also, you may want to do a reserve() since you know the number of elements
Done


http://gerrit.cloudera.org:8080/#/c/9891/1/be/src/exprs/in-predicate.h@353
PS1, Line 353: vector element_list;
> It would make sense to explicitly qualify the type of vector you're using h
Done


http://gerrit.cloudera.org:8080/#/c/9891/1/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:

http://gerrit.cloudera.org:8080/#/c/9891/1/tests/query_test/test_exprs.py@65
PS1, Line 65:   def test_in_predicate(self, vector, unique_database):
> I agree that we have to be a bit careful to design the query so that the ex
Done. Moved it to exprs.test



--
To view, visit http://gerrit.cloudera.org:8080/9891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e776dbcb7ee4a9b64e1295134a27d332f5415b6
Gerrit-Change-Number: 9891
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:27:57 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

[Bikramjeet Vig (Code Review)]

Hello Sailesh Mukil, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9891

to look at the new patch set (#2).

Change subject: IMPALA-6771: Fix in-predicate set up bug
..

IMPALA-6771: Fix in-predicate set up bug

Fixes a bug that introduced default initialized values in the set data
structure used to check for set membership that can cause wrong results.

Testing:
Added a test case that checks for the same.

Change-Id: I7e776dbcb7ee4a9b64e1295134a27d332f5415b6
---
M be/src/exprs/in-predicate.h
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
2 files changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/9891/2
--
To view, visit http://gerrit.cloudera.org:8080/9891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e776dbcb7ee4a9b64e1295134a27d332f5415b6
Gerrit-Change-Number: 9891
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR](2.x) IMPALA-6753: Update CDH versions in asf/2.x/impala-config.sh

[David Knupp (Code Review)]

David Knupp has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9914


Change subject: IMPALA-6753: Update CDH versions in asf/2.x/impala-config.sh
..

IMPALA-6753: Update CDH versions in asf/2.x/impala-config.sh

Updates from 5.15.0-SNAPSHOT to 5.16.0-SNAPSHOT

Change-Id: I3d5f041dc5f0d7eda87c2a2b95925bd99f3bd62e
---
M bin/impala-config.sh
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/9914/1
--
To view, visit http://gerrit.cloudera.org:8080/9914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d5f041dc5f0d7eda87c2a2b95925bd99f3bd62e
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9913 )

Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9913/1/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/9913/1/be/src/statestore/statestore.cc@909
PS1, Line 909:   
failure_detector_->EvictPeer(PrintId(subscriber->registration_id()));
Hmm, this is also suspicious



--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:21:49 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9913


Change subject: IMPALA-6785: reset failed heartbeat count when re-registering
..

IMPALA-6785: reset failed heartbeat count when re-registering

The bug is a mix-up between whether the subscriber or registration ID is
the key for the failure detected. The symptom was that, if the first
topic update won the race with the first heartbeat, no subsequent topic
updates were delivered.

Testing:
Add a regression that reliably reproduces the issue by delaying the
heartbeat and checking that topic updates continue to be sent. The
test reliably fails before the fix and passes after.

Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
---
M be/src/statestore/statestore.cc
M tests/statestore/test_statestore.py
2 files changed, 28 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9913/1
--
To view, visit http://gerrit.cloudera.org:8080/9913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07
Gerrit-Change-Number: 9913
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require ALTER privilege

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require ALTER 
privilege
..

IMPALA-6800: Add test cases for statements that require ALTER privilege

Testing:
- Added new test cases
- Ran front-end tests

Cherry-picks: not for 2.x

Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Reviewed-on: http://gerrit.cloudera.org:8080/9905
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require ALTER privilege

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require ALTER 
privilege
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:20:43 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6650: Add fine-grained DROP privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9911 )

Change subject: IMPALA-6650: Add fine-grained DROP privilege
..


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
File fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java:

http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java@191
PS1, Line 191: if (privilegeLevel_ != TPrivilegeLevel.ALL &&
Not specifically related to this patch: Is this behavior consistent with Hive? 
Can INSERT/SELECT not be granted on SERVER? Any idea why?


http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@91
PS1, Line 91:   //   SELECT, REFRESH, DROP permissions on 
'functional.alltypesagg' (no INSERT
I think we can remove the "(no INSERT permissions)" part here elsewhere in this 
comment block. Those comments made sense when we had INSERT/SELECT only, but 
are not obsolete.


http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@110
PS1, Line 110:   //   REFRESH, INSERT, CREATE, ALTER, DROP permissions on 
'functional_text_lzo' database
For any of these new privileges we also need to test that *only* that privilege 
allows the corresponding statements.

So ideally, we'd also have negative tests where all privileges except one are 
granted and the statements are not allowed.

Now that we have most of the FGP we want in the short term, it might be worth 
doing a cleanup pass over these tests in a separate JIRA. There are several 
things that can be condensed/refactored/shrunk. What do you think?


http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1288
PS1, Line 1288: AuthzOk("drop database if exists functional_text_lzo");
Also test the cascade/restrict clauses.


http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@2469
PS1, Line 2469: "User '%s' does not have privileges to CREATE/DROP 
functions in: notdb.f()");
This error msg needs to be changed since CREATE/DROP are separate privileges.


http://gerrit.cloudera.org:8080/#/c/9911/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@2473
PS1, Line 2473:   
ctx_.catalog.addFunction(ScalarFunction.createForTesting("functional_text_lzo",
We have a FrontendTestBase.addTestFunction() for this purpose. perhaps you can 
extend that mechanism to automatically clean up the test functions?

Similar to what we do in FrontendTestBase.addTestDb() and 
FrontendTestBase.addTestTable().

Probably best to do that cleanup in a separate JIRA.



--
To view, visit http://gerrit.cloudera.org:8080/9911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:10:05 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6650: Add fine-grained DROP privilege

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9911


Change subject: IMPALA-6650: Add fine-grained DROP privilege
..

IMPALA-6650: Add fine-grained DROP privilege

Add support for executing DROP statements by granting DROP privilege.

These are the new GRANT/REVOKE statements introduced at server,
database, and table scopes.

GRANT DROP on SERVER svr TO ROLE testrole;
GRANT DROP on DATABASE db TO ROLE testrole;
GRANT DROP on TABLE tbl TO ROLE testrole;

REVOKE DROP on SERVER svr FROM ROLE testrole;
REVOKE DROP on DATABASE db FROM ROLE testrole;
REVOKE DROP on TABLE tbl FROM ROLE testrole;

Testing:
- Added new front-end tests
- Ran front-end tests

Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
---
M common/thrift/CatalogObjects.thrift
M fe/.gitignore
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/authorization/Privilege.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/resources/authz-policy.ini.template
10 files changed, 145 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/9911/1
--
To view, visit http://gerrit.cloudera.org:8080/9911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya 

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9884 )

Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for 
HBase tables
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2231/


--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 03 Apr 2018 20:17:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9884 )

Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for 
HBase tables
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 03 Apr 2018 20:16:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9884 )

Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for 
HBase tables
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 03 Apr 2018 20:16:42 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5310: [DOCS] Document TABLESAMPLE clause for COMPUTE STATS

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded a new patch set (#2) to the change originally created 
by John Russell. ( http://gerrit.cloudera.org:8080/8975 )

Change subject: IMPALA-5310: [DOCS] Document TABLESAMPLE clause for COMPUTE 
STATS
..

IMPALA-5310: [DOCS] Document TABLESAMPLE clause for COMPUTE STATS

Change-Id: I214b63db391bd35562f5ea9091508005f83b2fcc
---
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_tablesample.xml
2 files changed, 31 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/8975/2
--
To view, visit http://gerrit.cloudera.org:8080/8975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I214b63db391bd35562f5ea9091508005f83b2fcc
Gerrit-Change-Number: 8975
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 

[Impala-ASF-CR] IMPALA-6779: [DOCS] Improve the REPLICA PREFERENCE doc

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9877 )

Change subject: IMPALA-6779: [DOCS] Improve the REPLICA_PREFERENCE doc
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38f9c881f553568c2516ecc23ec501f23ee1f28
Gerrit-Change-Number: 9877
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Tue, 03 Apr 2018 19:44:59 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6779: [DOCS] Improve the REPLICA PREFERENCE doc

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9877 )

Change subject: IMPALA-6779: [DOCS] Improve the REPLICA_PREFERENCE doc
..

IMPALA-6779: [DOCS] Improve the REPLICA_PREFERENCE doc

Added detail usage notes for REPLICA_PREFERENCE.

Change-Id: If38f9c881f553568c2516ecc23ec501f23ee1f28
Reviewed-on: http://gerrit.cloudera.org:8080/9877
Reviewed-by: John Russell 
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_replica_preference.xml
1 file changed, 39 insertions(+), 12 deletions(-)

Approvals:
  John Russell: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If38f9c881f553568c2516ecc23ec501f23ee1f28
Gerrit-Change-Number: 9877
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-6779: [DOCS] Improve the REPLICA PREFERENCE doc

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9877 )

Change subject: IMPALA-6779: [DOCS] Improve the REPLICA_PREFERENCE doc
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/220/


--
To view, visit http://gerrit.cloudera.org:8080/9877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38f9c881f553568c2516ecc23ec501f23ee1f28
Gerrit-Change-Number: 9877
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Tue, 03 Apr 2018 19:39:44 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in bootstrap *.sh

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9873 )

Change subject: IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in 
bootstrap_*.sh
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2230/


--
To view, visit http://gerrit.cloudera.org:8080/9873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d63c9713cc93a786f82e086feca1a91937e16
Gerrit-Change-Number: 9873
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Tue, 03 Apr 2018 18:54:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9857 )

Change subject: IMPALA-6389: Make '\0' delimited text files work
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2229/


--
To view, visit http://gerrit.cloudera.org:8080/9857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2190c57681f29f34ee1eb393e30dfdda5839098c
Gerrit-Change-Number: 9857
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Tue, 03 Apr 2018 18:51:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in bootstrap *.sh

[Thomas Tauber-Marshall (Code Review)]

Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9873 )

Change subject: IMPALA-6773: Remove Ubuntu 14.04 from supported platforms in 
bootstrap_*.sh
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d63c9713cc93a786f82e086feca1a91937e16
Gerrit-Change-Number: 9873
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Tue, 03 Apr 2018 18:16:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require ALTER privilege

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require ALTER 
privilege
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2227/


--
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 03 Apr 2018 17:20:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require DROP privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require DROP 
privilege
..


Patch Set 1: Code-Review+2

(1 comment)

Good catch, thanks for adding these!

http://gerrit.cloudera.org:8080/#/c/9905/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9905/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-6800: Add test cases for statements that require DROP 
privilege
ALTER privilege?



--
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Comment-Date: Tue, 03 Apr 2018 17:17:09 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require DROP privilege

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9905


Change subject: IMPALA-6800: Add test cases for statements that require DROP 
privilege
..

IMPALA-6800: Add test cases for statements that require DROP privilege

Testing:
- Added new test cases
- Ran front-end tests

Cherry-picks: not for 2.x

Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/9905/1
--
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 

[Impala-ASF-CR] IMPALA-6791: distcc server setup script

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
..

IMPALA-6791: distcc server setup script

Adds a script that can be run to configure a working distcc server with
ccache. This is based roughly on the manual steps in the README.

Testing:
Tested the scripts on Ubuntu and CentOS 6 systems. They resulted in a
working distcc server.

Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
---
M bin/distcc/README.md
A bin/distcc/distcc_server_setup.sh
2 files changed, 114 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/9901/2
--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

[Csaba Ringhofer (Code Review)]

Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8747 )

Change subject: IMPALA-5993: Fix the file offset in value parsing error
..


Patch Set 1:

(12 comments)

I looked through the change. I can't say that I completely understand the 
design of the C++ part, so my comments for that part are simple local ones.

http://gerrit.cloudera.org:8080/#/c/8747/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8747/7//COMMIT_MSG@11
PS7, Line 11: hit an error, it always prints the end of the file as the
nit: hits


http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.h
File be/src/exec/hdfs-scanner.h:

http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.h@365
PS7, Line 365:
typo: calculated


http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.h@373
PS7, Line 373: ers to ex
typo: difference


http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.h@373
PS7, Line 373: aths in Parquet scanner. Returns the status
Do you mean "taking read_bytes as argument instead of calculating it"?


http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.h@375
PS7, Line 375:   Status ScannerDebugAction() WARN_UNUSED_RESULT {
nit: remove extra space


http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.cc@497
PS7, Line 497:   // In this branch, we've just materialized slots not 
referenced by any conjunct.
Checking LogHasSpace() is not necessary here - LogError() checks if there is 
space for the log anyway, so the check is only useful to avoid the runtime cost 
of creating the error message if it would be dropped anyway. This is important 
if the logic is called a lot of time, for example for millions of rows. This 
part will be called only once (per fragment), as the function returns on the 
first error.


http://gerrit.cloudera.org:8080/#/c/8747/7/be/src/exec/hdfs-scanner.cc@675
PS7, Line 675:   stream_->filename(), line, pos, offset);
 :   state_->LogError(ErrorMsg(TErrorCode::GENERAL, s));
 : }
The Substitute should be moved inside the if block - as I mentioned in line 
497, the reason to call LogHasSpace() is to avoid the runtime cost of creating 
the error message.


http://gerrit.cloudera.org:8080/#/c/8747/7/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/8747/7/tests/query_test/test_scanners.py@847
PS7, Line 847:
 :
 :
 : 
 :
 :
 :
 :
 :
Can you explain why this function is needed? Other scanner test classes do not 
seem to do similar initialization.


http://gerrit.cloudera.org:8080/#/c/8747/7/tests/query_test/test_scanners.py@875
PS7, Line 875:
This step could be skipped, if the the table was created first (which creates 
an HDFS directory) and the data was copied afterwards.


http://gerrit.cloudera.org:8080/#/c/8747/7/tests/query_test/test_scanners.py@890
PS7, Line 890:
Why not use the default location ( /test-warehouse/$db_name.db/$table_name )? 
This line could be removed in that case.

Note that assuming that the databases are in /test-warehouse/ makes the tests 
less flexible, but other tests already rely on that, and the tests are expected 
to run on the Impala minicluster - many tests would fail on a different 
cluster, for example planner tests are sensitive to many cluster parameters. So 
I think that it is not a goal at the moment to make the tests runnable on other 
clusters. If it will be a goal, then a general solution should be created 
(probably in ImpalaTestSuite), not custom solutions for different tests.


http://gerrit.cloudera.org:8080/#/c/8747/7/tests/query_test/test_scanners.py@893
PS7, Line 893:
 :
nit: indentation and spaces around '='

In Impala, new blocks are indented with 2 spaces, while continuations of broken 
lines are intended with 4 spaces (most of the times...). This is a difference 
compared to PEP8, but makes the python code more consistent with C++ and Java 
code in Impala.

See the python part of 
https://cwiki.apache.org/confluence/display/IMPALA/Impala+Style+Guide for the 
list differences from PEP8.


http://gerrit.cloudera.org:8080/#/c/8747/7/tests/query_test/test_scanners.py@899
PS7, Line 899:
I would prefer to use self.execute_query(). The result it returns has a .log 
member, which can be split by "\n" to get the list of warnings.

Another way to do this is to create a .test file in testdata/workloads, list 
the warnings in the " ERRORS" section and run it with self.run_test_case(). 
See 
https://github.com/apache/impala/blob/89b29d3a89cca041c541476e25435dc0d34344c1/tests/common/test_result_verifier.py#L314
 for the way it processes the logs.



--
To view, visit 

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

[Quanlong Huang (Code Review)]

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9134 )

Change subject: IMPALA-5717: Support for reading ORC data files
..


Patch Set 11:

Just find that test_codegen.py is broken. Will fix it tomorrow.


--
To view, visit http://gerrit.cloudera.org:8080/9134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4
Gerrit-Change-Number: 9134
Gerrit-PatchSet: 11
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 15:08:23 +
Gerrit-HasComments: No