[Impala-ASF-CR] IMPALA-9669: Fix wrong table types for GET TABLES in LocalCatalog
Hello Anurag Mantripragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15887 to look at the new patch set (#5). Change subject: IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog .. IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog Coordinator can be in two modes: legacy mode or LocalCatalog mode. Before IMPALA-8606, GET_TABLES required all tables to be loaded in LocalCatalog-mode coordinator’s cache, which is a performance regression compared to legacy mode coordinators. IMPALA-8606 changes the behavior to only load the table names and create LocalIncompleteTable for each table, which boosts the performance but results in all views being returned with the default table type (TABLE). Besides this, all returned comments are empty even if the table/view is loaded. This is a regression since in legacy coordinators, loaded tables/views are shown with correct table types and comments. This is fixed by loading table types and comments along with table names from catalogd. The cached list of table names of a DB is changed to be a map containing the brief table metadata (name, type, comment). In case of stale types or comments in the list, when loading the msTable of a table, coordinator checks the type and comment and invalidates the table list if any of them are stale. Tests - Add tests in test_hs2.test_get_tables - Run CORE tests Change-Id: I2180c603f061838347936f718cd4a0257d82e633 --- M common/thrift/CatalogService.thrift M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java M fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java M fe/src/main/java/org/apache/impala/service/MetadataOp.java M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java M tests/hs2/test_hs2.py 11 files changed, 199 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/15887/5 -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d Gerrit-Change-Number: 15818 Gerrit-PatchSet: 13 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 15 May 2020 14:28:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Sahil Takiar has posted comments on this change. (
http://gerrit.cloudera.org:8080/14824 )
Change subject: IMPALA-9199: Add support for single query retries on cluster
membership changes
..
Patch Set 32:
(1 comment)
Fixing a few issues that are causing the test failures:
(1) Removed a DCHECK (see comment below)
(2) Fixed a bug where GetQueryHandle was not passing return_unregistered to
GetQueryDriver
Ran a bunch of more tests locally, and things look good:
* Re-ran the stress tests for tpcds and tpch
* Looped the new tests overnight and no failures
Did some additional cleanup of code comments, removing unnecessary imports,
minor-refactoring, etc.
http://gerrit.cloudera.org:8080/#/c/14824/26/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/14824/26/be/src/runtime/coordinator.cc@511
PS26, Line 511: if (!failed_backend_states.empty()) {
> Done
I had to remove the DCHECK because it caused a crash. Turns out that because of
the IsAborted() check above, its possible for this list to be empty. Tests that
use the EXEC_SERIALIZE_FRAGMENT_INFO Debug Action trigger the DCHECK.
--
To view, visit http://gerrit.cloudera.org:8080/14824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd
Gerrit-Change-Number: 14824
Gerrit-PatchSet: 32
Gerrit-Owner: Sahil Takiar
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Comment-Date: Fri, 15 May 2020 14:47:57 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9669: Fix wrong table types for GET TABLES in LocalCatalog
Hello Anurag Mantripragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15887 to look at the new patch set (#4). Change subject: IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog .. IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog Coordinator can be in two modes: legacy mode or LocalCatalog mode. Before IMPALA-8606, GET_TABLES required all tables to be loaded in LocalCatalog-mode coordinator’s cache, which is a performance regression compared to legacy mode coordinators. IMPALA-8606 changes the behavior to only load the table names and create LocalIncompleteTable for each table, which boosts the performance but results in all views being returned with the default table type (TABLE). Besides this, all returned comments are empty even if the table/view is loaded. This is a regression since in legacy coordinators, loaded tables/views are shown with correct table types and comments. This is fixed by loading table types and comments along with table names from catalogd. The cached list of table names of a DB is changed to be a map containing the brief table metadata (name, type, comment). In case of stale types or comments in the list, when loading the msTable of a table, coordinator checks the type and comment and invalidates the table list if any of them are stale. Tests - Add tests in test_hs2.test_get_tables - Run CORE tests Change-Id: I2180c603f061838347936f718cd4a0257d82e633 --- M common/thrift/CatalogService.thrift M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java M fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java M fe/src/main/java/org/apache/impala/service/MetadataOp.java M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java M tests/hs2/test_hs2.py 11 files changed, 199 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/15887/4 -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9725: incorrect spilling join results for wide keys
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15904 ) Change subject: IMPALA-9725: incorrect spilling join results for wide keys .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5841/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7e5871c35a90e8cf24b8dded04775ee1eae9d8 Gerrit-Change-Number: 15904 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 15 May 2020 11:32:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9725: incorrect spilling join results for wide keys
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15904 ) Change subject: IMPALA-9725: incorrect spilling join results for wide keys .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7e5871c35a90e8cf24b8dded04775ee1eae9d8 Gerrit-Change-Number: 15904 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 15 May 2020 11:32:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredi
Martin Zink has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15877 Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) .. IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze. CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly so its needs to be replaced by its CompoundPredicate or FunctionCallExpr member variable by ExtractCompoundVerticalBarExprRule. Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf --- M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/Analyzer.java A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java 7 files changed, 189 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/3 -- To view, visit http://gerrit.cloudera.org:8080/15877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf Gerrit-Change-Number: 15877 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Zink Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredi
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/15877 )
Change subject: IMPALA-452 Add support for string concatenation operator using
|| construct Separated "||" and "OR" into different tokens. -OR (KW_OR)
remains the same. (it creates CompoundPredicate and expects two BOOLEAN
operands)
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java:
http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@94
PS3, Line 94: throw new AnalysisException(String.format("Operand '%s'
part of CompoundVerticalBarExpr " +
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java:
http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@830
PS3, Line 830: ExprRewriteRule extractCompoundVerticalBarExprRule =
ExtractCompoundVerticalBarExprRule.INSTANCE;
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@842
PS3, Line 842: RewritesOk("string_col || 'TEST'",
extractCompoundVerticalBarExprRule, "concat(string_col, 'TEST')");
line too long (105 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Zink
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 15 May 2020 12:46:49 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredi
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5842/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf Gerrit-Change-Number: 15877 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Zink Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 15 May 2020 12:46:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5844/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 15 May 2020 14:20:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Hello Anurag Mantripragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15887 to look at the new patch set (#6). Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog Coordinator can be in two modes: legacy mode or LocalCatalog mode. Before IMPALA-8606, GET_TABLES required all tables to be loaded in LocalCatalog-mode coordinator’s cache, which is a performance regression compared to legacy mode coordinators. IMPALA-8606 changes the behavior to only load the table names and create LocalIncompleteTable for each table, which boosts the performance but results in all views being returned with the default table type (TABLE). Besides this, all returned comments are empty even if the table/view is loaded. This is a regression since in legacy coordinators, loaded tables/views are shown with correct table types and comments. This is fixed by loading table types and comments along with table names from catalogd. The cached list of table names of a DB is changed to be a map containing the brief table metadata (name, type, comment). In case of stale types or comments in the list, when loading the msTable of a table, coordinator checks the type and comment and invalidates the table list if any of them are stale. Tests - Add tests in test_hs2.test_get_tables - Run CORE tests Change-Id: I2180c603f061838347936f718cd4a0257d82e633 --- M common/thrift/CatalogService.thrift M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java M fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java M fe/src/main/java/org/apache/impala/service/MetadataOp.java M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java M tests/hs2/test_hs2.py 11 files changed, 199 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/15887/6 -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6080/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 15 May 2020 13:46:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6081/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 15 May 2020 13:56:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 ) Change subject: IMPALA-8860: Improve /log_level usability on WebUI .. Patch Set 4: Hi Zoltan, thank you for updating the change. This comment became a bit long because it contains 'page design' in text :). The BE log level part looking good, additionally one slight change could help the users better understand the levels, the meaning of the numbers could be printed as well: https://impala.apache.org/docs/build/html/topics/impala_logging.html#log_levels ie.: 1: Default 2: Debug 3: All The FE log4j log levels could be collected as well, then there would be no need for the get log level part there. It can be cumbersome to get the levels one-by-one for every class manually. The 'LogManager.getCurrentLoggers()' can get all the loggers, then 'logger.getLevel()' should return 'null' or the log level if it is set. With the Java part it would be lot nicer and we could standardize the page layout a bit, ie (concept in text :) ).: [Text: Frontend log level configuration (log4j)] [Text: Current log level:] [Text or Textbox: Log4j level values class and level] [Text box: class] [Text: Log level:] [Combobox: level] [Button: Set Java Log Level] [Button: Reset Frontend Log Level] [Text: Backend log level configuration (glog)] [Text: Current log level:] [Glog level value] [Text: Log level] [Combobox: level] [Button: Set Glog Level] [Button: Reset Backend Log Level] Also, I am adding Zoltan Borok-Nagy as a reviewer, hope you have some time to take look at it. -- To view, visit http://gerrit.cloudera.org:8080/15903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33 Gerrit-Change-Number: 15903 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Garaguly Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Garaguly Gerrit-Comment-Date: Fri, 15 May 2020 14:04:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9597: Eliminate redundant Ranger audits for column masking
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15854 ) Change subject: IMPALA-9597: Eliminate redundant Ranger audits for column masking .. Patch Set 11: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15854/11/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java: http://gerrit.cloudera.org:8080/#/c/15854/11/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java@69 PS11, Line 69: StringUtils.equalsIgnoreCase(event.getAccessType(), "MASK") || : StringUtils.equalsIgnoreCase(event.getAccessType(), "MASK_SHOW_LAST_4") || : StringUtils.equalsIgnoreCase(event.getAccessType(), "MASK_SHOW_FIRST_4") || : StringUtils.equalsIgnoreCase(event.getAccessType(), "MASK_HASH") || : StringUtils.equalsIgnoreCase(event.getAccessType(), "MASK_NULL") || : StringUtils.equalsIgnoreCase(event.getAccessType(), "SELECT") || : StringUtils.equalsIgnoreCase(event.getAccessType(), "MASK_DATE_SHOW_YEAR") || : StringUtils.equalsIgnoreCase(event.getAccessType(), "CUSTOM")); Are these constant strings somewhere in Ranger's code base? It'd be more maintainable than hard coding them here if we can use a string set of Ranger for this. So when Ranger adds a new mask type in the future, we don't need to add a new check here. -- To view, visit http://gerrit.cloudera.org:8080/15854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42d60130fba93d63fbc36949f2bf746b7ae2497d Gerrit-Change-Number: 15854 Gerrit-PatchSet: 11 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 15 May 2020 14:33:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Hello Thomas Tauber-Marshall, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14824
to look at the new patch set (#32).
Change subject: IMPALA-9199: Add support for single query retries on cluster
membership changes
..
IMPALA-9199: Add support for single query retries on cluster membership changes
Adds the core logic for transparently retrying queries that fail due to
cluster membership changes (IMPALA-9124).
Query retries are triggered if (1) a node has been removed from the
cluster membership by a statestore update (rather than cancelling all
queries running on the removed node, queries are retried), or (2) if a
query fails and as a result, blacklists a node. Either event is
considered a cluster membership change as it affects what nodes a query
will be scheduled on. The assumption is that a retry of the query with
the updated cluster membership will succeed.
A query retry is modelled as a brand new query, with its own query id.
This simplifies the implementation and the resulting runtime profiles
when queries are retried.
Core Features:
* Retries are transparent to the user; no modification to client
libraries are necessary to support query retries
* Retried queries skip all fe/ parsing, planning, authorization, etc.
* Retries are configurable ('retry_failed_queries') and are off by
default
Implementation:
* When a query is retried, the original query is cancelled, the new
query is created, registered, and started, and then the original query
is closed
* A new layer of abstraction between the ImpalaServer and
ClientRequestState has been added; it is called the QueryDriver
* Each ClientRequestState is treated as a single attempt of a query, and
the QueryDriver owns all ClientRequestStates for a query
* ClientRequestState has a new state object called RetryState; a
ClientRequestState can either be NOT_RETRIED, RETRYING, or RETRIED
* The QueryDriver owns the TExecRequest for the query as well, it is
re-used for each query retry
* QueryDrivers and ClientRequestStates are now referenced using a
QueryHandle
Observability:
* Users can tell if a query is retried using runtime profiles and the
Impala Web UI
* Runtime profiles of queries that fail and then are retried will have:
* "Retry Status: RETRIED"
* "Retry Cause: [the error that triggered the retry]"
* "Retried Query Id: [the query id of the retried query]"
* Runtime profiles of the retried query (e.g. the second attempt of the
query) will include:
* "Original Query Id: [the query id of the original query]"
* The Impala Web UI will list all retried queries as being in the
"RETRIED" state
Testing:
* Added E2E tests in test_query_retries.py; looped tests for a few days
* Added a stress test query_retries_stress_runner.py that runs concurrent
streams of a TPC-{H,DS} workload and randomly kills impalads
* Ran the stress test with various configurations: tpch on parquet,
tpcds on parquet, tpch 30 GB on parquet (one stream), tpcds 30 GB on
parquet (one stream), tpch on text, tpcds on text
* Ran exhaustive tests
* Ran exhaustive tests with 'retry_failed_queries' set to true, no
unexpected failures
* Ran 30 GB TPC-DS workload on a 3 node cluster, randomly restarted
impalads, and manually verified that queries were retried
* Manually tested retries work with various clients, specifically the
impala-shell and Hue
* Ran core tests and query retry stress test against an ASAN build
* Ran concurrent_select.py to stress query cancellation
* Ran be/ tests against a TSAN build
Limitations:
* There are several limitations that are listed out in the parent JIRA
Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd
---
M be/src/benchmarks/process-wide-locks-benchmark.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
A be/src/runtime/query-driver.cc
A be/src/runtime/query-driver.h
M be/src/service/CMakeLists.txt
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/control-service.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
R be/src/service/query-driver-map.cc
A be/src/service/query-driver-map.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
M be/src/testutil/impalad-query-executor.cc
M be/src/testutil/impalad-query-executor.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M tests/common/impala_cluster.py
M tests/common/impala_service.py
A tests/custom_cluster/test_query_retries.py
A tests/stress/query_retries_stress_runner.py
27 files changed, 2,700 insertions(+), 696 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/14824/32
--
To view, visit
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 32: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5845/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd Gerrit-Change-Number: 14824 Gerrit-PatchSet: 32 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 14:44:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredi
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6079/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf Gerrit-Change-Number: 15877 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Zink Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 15 May 2020 13:38:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 ) Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter .. Patch Set 12: Code-Review+2 Merge failed due to IMPALA-8124 -- To view, visit http://gerrit.cloudera.org:8080/15676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 12 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 15 May 2020 17:02:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 ) Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter .. Patch Set 13: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5847/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 13 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 15 May 2020 17:02:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 ) Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 13 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 15 May 2020 17:02:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15887/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15887/2//COMMIT_MSG@21 PS2, Line 21: his patch fixes : the problem by adding an additional lookup in the local cache for the : table meta (hmsTable) of each table when creating the : LocalIncompleteTables > Good point! Load-balancers will cause the inconsistent results. I planned t Thanks. For now, this solution is better than what we have until we have the fix for IMPALA-9670. -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 15 May 2020 17:02:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 32: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6082/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd Gerrit-Change-Number: 14824 Gerrit-PatchSet: 32 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 15:26:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9091: Fix flaky query test.test scanners.TestScannerReservation.test scanners
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15923 ) Change subject: IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners .. Patch Set 1: Code-Review+2 Thanks for fixing! -- To view, visit http://gerrit.cloudera.org:8080/15923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Gerrit-Change-Number: 15923 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 16:23:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9091: Fix flaky query test.test scanners.TestScannerReservation.test scanners
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15923 ) Change subject: IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5846/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Gerrit-Change-Number: 15923 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 16:24:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9091: Fix flaky query test.test scanners.TestScannerReservation.test scanners
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15923 ) Change subject: IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Gerrit-Change-Number: 15923 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 16:24:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9725: incorrect spilling join results for wide keys
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15904 ) Change subject: IMPALA-9725: incorrect spilling join results for wide keys .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7e5871c35a90e8cf24b8dded04775ee1eae9d8 Gerrit-Change-Number: 15904 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 15 May 2020 16:49:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9725: incorrect spilling join results for wide keys
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15904 ) Change subject: IMPALA-9725: incorrect spilling join results for wide keys .. IMPALA-9725: incorrect spilling join results for wide keys The control flow was broken if the join operator hit the end of the expression values cache before the end of the probe batch, immediately after processing a row for a spilled partition. In NextProbeRow(), the problematic code path was: * The last row in the expression values cache was for a spilled partition, so skip_row=true and it falls out of the loop with 'current_probe_row_' pointing to that row. * probe_batch_iterator->AtEnd() is false, because the expression value cache is smaller than the probe batch, so 'current_probe_row_' is not nulled out. Thus we end up in a state where 'current_probe_row_' is set, but 'hash_table_iterator_' is unset. In the case of a left anti join, this was interpreted by ProcessProbeRowLeftSemiJoins() as meaning that there was no hash table match for 'current_probe_row_', and it therefore returned the row. This bug could only occur under specific circumstances: * The join key takes up > 256 bytes in the expression values cache (assuming the default batch size of 1024). * The join spilled. * The join operator returns rows that were unmatched in the right input, i.e. LEFT OUTER JOIN, LEFT ANTI JOIN, FULL OUTER JOIN. The core of the fix is to null out 'current_probe_row_' when falling out the bottom of the loop in NextProbeRow(). Related DCHECKS were fixed and some control flow was slightly simplified. Testing: Added a test query on TPC-H that reproduces the problem reliably. Ran exhaustive tests. Change-Id: I9d7e5871c35a90e8cf24b8dded04775ee1eae9d8 Reviewed-on: http://gerrit.cloudera.org:8080/15904 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/partitioned-hash-join-node-ir.cc M be/src/exec/partitioned-hash-join-node.cc M testdata/workloads/functional-query/queries/QueryTest/spilling.test 3 files changed, 68 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9d7e5871c35a90e8cf24b8dded04775ee1eae9d8 Gerrit-Change-Number: 15904 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredi
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf Gerrit-Change-Number: 15877 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Zink Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 15 May 2020 18:12:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. Patch Set 6: (1 comment) The latest patch looks good to me except for the comment below. Also, curious to know if we still need IMPALA-9670 given now we will always fetch the type and comments. http://gerrit.cloudera.org:8080/#/c/15887/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/15887/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@721 PS6, Line 721: invalidateStaleTableList(dbName.toLowerCase(), ref); Why do we need this? If the table type or comment has changed since we loaded the tablelist shouldn't we have received a invalidation topic update for that table? -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 15 May 2020 17:19:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5848/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 17:09:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 17:09:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 16:56:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15926 Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. IMPALA-9655: Dynamic intra-node load balancing for HDFS scans This patch ameliorates intra node execution skew for multithreaded HDFS scans by implementing a shared queue of scan ranges for all instances. Some points to highlight: - The scan node's PlanNode will go through all the TScanRanges assigned to all instances and aggregate them into file descriptors. - These files will be statically and evenly distributed among the instances. - The instances would then pick up their set of files and issue initial ranges by adding them to a shared queue. - Instances would then fetch their next range to read from this shared queue. - Other relevant data structures that will also be shared are: * remaining_scan_range_submissions_ * partition_template_tuple_map_ * per_file_metadata_ This approach guarantees the following: - All shared data structures are allocated at the FragmentState level ensuring they'll stick around till the query is closed. - All instance local buffers for reading a scan range will be allocated after it has been taken off the shared queue. - Since the scheduler can assign ranges from the same file to different instances, aggregating them into file descriptors early will ensure the initial footer or header range (depending on file format) for it will only be issued once. Limitation: - For HDFS MT scans we lose out on the optimization within ReaderContext which ensures cached ranges are read first. Testing: - added a regression test which would almost always fail without this patch TODO: - Run core tests on ASAN build - Run exhaustive tests - Do perf analysis to ensure there is no regression Change-Id: I9a101d0d98dff6e3779f85bc466e4c0bdb38094b --- M be/src/exec/base-sequence-scanner.cc M be/src/exec/hdfs-orc-scanner.h M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h M be/src/exec/hdfs-scan-node-mt.cc M be/src/exec/hdfs-scan-node-mt.h M be/src/exec/hdfs-scan-node.cc M be/src/exec/hdfs-scan-node.h M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-text-scanner.cc M be/src/exec/parquet/hdfs-parquet-scanner.cc M be/src/exec/parquet/hdfs-parquet-scanner.h M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc M tests/query_test/test_mt_dop.py 15 files changed, 613 insertions(+), 311 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/15926/1 -- To view, visit http://gerrit.cloudera.org:8080/15926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9a101d0d98dff6e3779f85bc466e4c0bdb38094b Gerrit-Change-Number: 15926 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15926/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/15926/1/tests/query_test/test_mt_dop.py@110 PS1, Line 110: v flake8: E131 continuation line unaligned for hanging indent -- To view, visit http://gerrit.cloudera.org:8080/15926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a101d0d98dff6e3779f85bc466e4c0bdb38094b Gerrit-Change-Number: 15926 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 21:18:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9091: Fix flaky query test.test scanners.TestScannerReservation.test scanners
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15923 ) Change subject: IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Gerrit-Change-Number: 15923 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 21:46:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9091: Fix flaky query test.test scanners.TestScannerReservation.test scanners
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15923 ) Change subject: IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners .. IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners query_test.test_scanners.TestScannerReservation.test_scanners was flaky. It checks the average value of ParquetRowGroupIdealReservation which is almost always 3.50 MB. However, very rarely it's a bit different than that, e.g. 3.88 MB, or 4.12 MB, and so on. I wasn't able to reproduce this problem, probably it is due to some randomness during data loading. I modified the test to accept any value between 3.0 and 4.99. I think values in this range are acceptable for this test. Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Reviewed-on: http://gerrit.cloudera.org:8080/15923 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/scanner-reservation.test 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Gerrit-Change-Number: 15923 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5844/ -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 15 May 2020 19:41:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 32: Code-Review+2 Carrying +2. -- To view, visit http://gerrit.cloudera.org:8080/14824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd Gerrit-Change-Number: 14824 Gerrit-PatchSet: 32 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 20:10:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Sahil Takiar has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/14824 )
Change subject: IMPALA-9199: Add support for single query retries on cluster
membership changes
..
IMPALA-9199: Add support for single query retries on cluster membership changes
Adds the core logic for transparently retrying queries that fail due to
cluster membership changes (IMPALA-9124).
Query retries are triggered if (1) a node has been removed from the
cluster membership by a statestore update (rather than cancelling all
queries running on the removed node, queries are retried), or (2) if a
query fails and as a result, blacklists a node. Either event is
considered a cluster membership change as it affects what nodes a query
will be scheduled on. The assumption is that a retry of the query with
the updated cluster membership will succeed.
A query retry is modelled as a brand new query, with its own query id.
This simplifies the implementation and the resulting runtime profiles
when queries are retried.
Core Features:
* Retries are transparent to the user; no modification to client
libraries are necessary to support query retries
* Retried queries skip all fe/ parsing, planning, authorization, etc.
* Retries are configurable ('retry_failed_queries') and are off by
default
Implementation:
* When a query is retried, the original query is cancelled, the new
query is created, registered, and started, and then the original query
is closed
* A new layer of abstraction between the ImpalaServer and
ClientRequestState has been added; it is called the QueryDriver
* Each ClientRequestState is treated as a single attempt of a query, and
the QueryDriver owns all ClientRequestStates for a query
* ClientRequestState has a new state object called RetryState; a
ClientRequestState can either be NOT_RETRIED, RETRYING, or RETRIED
* The QueryDriver owns the TExecRequest for the query as well, it is
re-used for each query retry
* QueryDrivers and ClientRequestStates are now referenced using a
QueryHandle
Observability:
* Users can tell if a query is retried using runtime profiles and the
Impala Web UI
* Runtime profiles of queries that fail and then are retried will have:
* "Retry Status: RETRIED"
* "Retry Cause: [the error that triggered the retry]"
* "Retried Query Id: [the query id of the retried query]"
* Runtime profiles of the retried query (e.g. the second attempt of the
query) will include:
* "Original Query Id: [the query id of the original query]"
* The Impala Web UI will list all retried queries as being in the
"RETRIED" state
Testing:
* Added E2E tests in test_query_retries.py; looped tests for a few days
* Added a stress test query_retries_stress_runner.py that runs concurrent
streams of a TPC-{H,DS} workload and randomly kills impalads
* Ran the stress test with various configurations: tpch on parquet,
tpcds on parquet, tpch 30 GB on parquet (one stream), tpcds 30 GB on
parquet (one stream), tpch on text, tpcds on text
* Ran exhaustive tests
* Ran exhaustive tests with 'retry_failed_queries' set to true, no
unexpected failures
* Ran 30 GB TPC-DS workload on a 3 node cluster, randomly restarted
impalads, and manually verified that queries were retried
* Manually tested retries work with various clients, specifically the
impala-shell and Hue
* Ran core tests and query retry stress test against an ASAN build
* Ran concurrent_select.py to stress query cancellation
* Ran be/ tests against a TSAN build
Limitations:
* There are several limitations that are listed out in the parent JIRA
Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd
Reviewed-on: http://gerrit.cloudera.org:8080/14824
Tested-by: Impala Public Jenkins
Reviewed-by: Sahil Takiar
---
M be/src/benchmarks/process-wide-locks-benchmark.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
A be/src/runtime/query-driver.cc
A be/src/runtime/query-driver.h
M be/src/service/CMakeLists.txt
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/control-service.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
R be/src/service/query-driver-map.cc
A be/src/service/query-driver-map.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
M be/src/testutil/impalad-query-executor.cc
M be/src/testutil/impalad-query-executor.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M tests/common/impala_cluster.py
M tests/common/impala_service.py
A tests/custom_cluster/test_query_retries.py
A tests/stress/query_retries_stress_runner.py
27 files changed, 2,700 insertions(+), 696 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Sahil Takiar: Looks good to me, approved
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 32: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd Gerrit-Change-Number: 14824 Gerrit-PatchSet: 32 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 20:06:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6083/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a101d0d98dff6e3779f85bc466e4c0bdb38094b Gerrit-Change-Number: 15926 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 22:08:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15676 ) Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter .. IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter Ported BlockBloomFilter related source files from Kudu upstream to Impala be/src/kudu/util. The git hash of Kudu to take these files is 389d4f1e1c. Testing: Passed core tests. Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357 Reviewed-on: http://gerrit.cloudera.org:8080/15676 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/kudu/util/CMakeLists.txt M be/src/kudu/util/block_bloom_filter-test.cc M be/src/kudu/util/block_bloom_filter.cc M be/src/kudu/util/block_bloom_filter.h A be/src/kudu/util/block_bloom_filter.proto M be/src/kudu/util/block_bloom_filter_avx2.cc M be/src/kudu/util/hash.proto M be/src/kudu/util/hash_util-test.cc M be/src/kudu/util/hash_util.h M be/src/kudu/util/memory/arena-test.cc M be/src/kudu/util/memory/arena.cc M be/src/kudu/util/memory/arena.h 12 files changed, 785 insertions(+), 101 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 14 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5849/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcc2d95e2ca4d9819a6cc0b4eb2865d60e21f153 Gerrit-Change-Number: 15845 Gerrit-PatchSet: 5 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 15 May 2020 22:37:33 + Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcc2d95e2ca4d9819a6cc0b4eb2865d60e21f153 Gerrit-Change-Number: 15845 Gerrit-PatchSet: 5 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 15 May 2020 22:37:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 ) Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 13 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 15 May 2020 22:25:54 + Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5849/ -- To view, visit http://gerrit.cloudera.org:8080/15845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcc2d95e2ca4d9819a6cc0b4eb2865d60e21f153 Gerrit-Change-Number: 15845 Gerrit-PatchSet: 5 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sat, 16 May 2020 04:01:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5848/ -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 22:32:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9382: part 1: transposed profile prototype
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15798 )
Change subject: IMPALA-9382: part 1: transposed profile prototype
..
Patch Set 6:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/15798/6/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:
http://gerrit.cloudera.org:8080/#/c/15798/6/be/src/util/runtime-profile-counters.h@416
PS6, Line 416: int64_t min_value() const { return min_value_; }
I think maintaining the min and max value on each update is a mistake - it is
not correct if the counter is updated more than once, and it adds complexity to
the code. I think we should instead compute these stats on demand when
pretty-printing the profile.
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile-counters.h@392
PS4, Line 392: /// TODO: IMPALA-9382: rename counter. CounterVector?
AggregatedCounter?
> Update comment
Done
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile-counters.h@499
PS4, Line 499:
> This
Done
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.h
File be/src/util/runtime-profile.h:
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.h@370
PS4, Line 370:
> Update this
Done
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.h@744
PS4, Line 744: int idx);
> pluralise
Done
http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.h
File be/src/util/runtime-profile.h:
http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.h@193
PS2, Line 193: /// Return the number of input instances that contributed to
this profile.
> Do this
Done
http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.h@349
PS2, Line 349: };
> typo
Done
http://gerrit.cloudera.org:8080/#/c/15798/1/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:
http://gerrit.cloudera.org:8080/#/c/15798/1/be/src/util/runtime-profile.cc@2203
PS1, Line 2203: return distinct_vals;
> Move aggregated logic down here?
Done
http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:
http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc@222
PS2, Line 222: bool indent = nodes[*idx].indent;
> bad comment
Done
http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc@570
PS2, Line 570: double local_time_frac =
> Why was it the old way?
Done
http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc@1056
PS2, Line 1056: profile->PrettyPrint(s, prefix + (indent ? " " : ""));
> ADd todo
Done
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.cc@541
PS4, Line 541: for (int i = 0; i < children_.size(); ++i) {
> remove logs
Done
http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.cc@1871
PS4, Line 1871: tcounter->min_value[i] = counter->min_;
> thisnn
Done
http://gerrit.cloudera.org:8080/#/c/15798/4/common/thrift/RuntimeProfile.thrift
File common/thrift/RuntimeProfile.thrift:
http://gerrit.cloudera.org:8080/#/c/15798/4/common/thrift/RuntimeProfile.thrift@183
PS4, Line 183: // These fields are not used in aggregated profile nodes, i.e.
profile V2,
> This isn't really accurate
Done
http://gerrit.cloudera.org:8080/#/c/15798/4/common/thrift/RuntimeProfile.thrift@226
PS4, Line 226: // for the fragment is also included with averaged counter
values.
> Mention this is experimental
Done
--
To view, visit http://gerrit.cloudera.org:8080/15798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0838c6a0872f57c696267ff4e92d29c08748eb7a
Gerrit-Change-Number: 15798
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Sat, 16 May 2020 01:08:53 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9679: Remove some jars from Docker images
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15753 ) Change subject: IMPALA-9679: Remove some jars from Docker images .. Patch Set 11: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5850/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I030e7cd28e29cd4e077c0b4addd4d14a8599eed6 Gerrit-Change-Number: 15753 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 16 May 2020 01:06:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9679: Remove some jars from Docker images
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15753 ) Change subject: IMPALA-9679: Remove some jars from Docker images .. Patch Set 10: Failure is unrelated to patch - https://issues.apache.org/jira/browse/IMPALA-9755 -- To view, visit http://gerrit.cloudera.org:8080/15753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I030e7cd28e29cd4e077c0b4addd4d14a8599eed6 Gerrit-Change-Number: 15753 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 16 May 2020 01:07:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9679: Remove some jars from Docker images
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15753 ) Change subject: IMPALA-9679: Remove some jars from Docker images .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I030e7cd28e29cd4e077c0b4addd4d14a8599eed6 Gerrit-Change-Number: 15753 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 16 May 2020 01:06:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET TABLES in LocalCatalog
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog .. Patch Set 6: (1 comment) > Patch Set 6: > > (1 comment) > > The latest patch looks good to me except for the comment below. Also, curious > to know if we still need IMPALA-9670 given now we will always fetch the type > and comments. We still need IMPALA-9670. After this patch, if the table is loaded in catalogd, coordinators can show its correct type and comment regardless whether it is loaded in local catalog. But if the table is unloaded in catalogd, we are still using the default table type and comment. http://gerrit.cloudera.org:8080/#/c/15887/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/15887/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@721 PS6, Line 721: invalidateStaleTableList(dbName.toLowerCase(), ref); > Why do we need this? If the table type or comment has changed since we load Sorry for not leaving a comment. This is the only point that makes this patch a little complex: We will receive a topic update in 2s (default statestore update frequency). After the table is loaded here and before the invalidation arrives, the stale tablelist will still be used. So GetTable op right after a DESCRIBE query will still get the stale type and comment. This can be reflected by test failure of test_hs2.test_get_tables. There are some test failures due to this. Will add the comment and fix the tests. -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sat, 16 May 2020 02:00:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9679: Remove some jars from Docker images
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15753 ) Change subject: IMPALA-9679: Remove some jars from Docker images .. Patch Set 10: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5838/ -- To view, visit http://gerrit.cloudera.org:8080/15753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I030e7cd28e29cd4e077c0b4addd4d14a8599eed6 Gerrit-Change-Number: 15753 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 06:29:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 31: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5839/ -- To view, visit http://gerrit.cloudera.org:8080/14824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd Gerrit-Change-Number: 14824 Gerrit-PatchSet: 31 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 May 2020 08:27:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9091: Fix flaky query test.test scanners.TestScannerReservation.test scanners
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15923 Change subject: IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners .. IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners query_test.test_scanners.TestScannerReservation.test_scanners was flaky. It checks the average value of ParquetRowGroupIdealReservation which is almost always 3.50 MB. However, very rarely it's a bit different than that, e.g. 3.88 MB, or 4.12 MB, and so on. I wasn't able to reproduce this problem, probably it is due to some randomness during data loading. I modified the test to accept any value between 3.0 and 4.99. I think values in this range are acceptable for this test. Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb --- M testdata/workloads/functional-query/queries/QueryTest/scanner-reservation.test 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/15923/1 -- To view, visit http://gerrit.cloudera.org:8080/15923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Gerrit-Change-Number: 15923 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 13: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5840/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d Gerrit-Change-Number: 15818 Gerrit-PatchSet: 13 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 15 May 2020 09:08:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9725: incorrect spilling join results for wide keys
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15904 ) Change subject: IMPALA-9725: incorrect spilling join results for wide keys .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7e5871c35a90e8cf24b8dded04775ee1eae9d8 Gerrit-Change-Number: 15904 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 15 May 2020 09:58:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9091: Fix flaky query test.test scanners.TestScannerReservation.test scanners
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15923 ) Change subject: IMPALA-9091: Fix flaky query_test.test_scanners.TestScannerReservation.test_scanners .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6078/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I668d0ccd77a62059284e76fee51efb08bef580eb Gerrit-Change-Number: 15923 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 May 2020 10:12:59 + Gerrit-HasComments: No
