[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Update scripts in benchmark folder to store 
workload and few minor updates
..


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:

http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@735
PS5, Line 735: if not first_exec_summary:
> Add comment.
Done


http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@1058
PS5, Line 1058:   if exec_summaries[0] is None:
> Same as comment above, please add a comment line explaining what this does.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Mon, 14 May 2018 23:59:14 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Update scripts in benchmark folder to store 
workload and few minor updates
..


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG@7
PS8, Line 7: Update
> Please add a space in front of this.
Done


http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py
File tests/benchmark/perf_result_datastore.py:

http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py@298
PS5, Line 298: LOG.debug('Inserting File Type: {0}, {1}, {2}'.format(
> Fix indentation
Done


http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:

http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@141
PS8, Line 141: Dont
> I think either "Don't" or "Do not" is better than Dont. This is used for us
Done


http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@1058
PS8, Line 1058:   if exec_summaries[0] is None:
  : return ""
> I think this is a redundant special handling.  I believe L1054-1055 can be
Done



--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Mon, 14 May 2018 23:52:05 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6923:Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#8). ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923:Update scripts in benchmark folder to store 
workload and few minor updates
..

IMPALA-6923:Update scripts in benchmark folder to store workload and few minor 
updates

Updates to the scripts in benchmark folder to
 - Store test execution results to ExecutionResults table
 - Store workload metrics to WorkloadMetrics
 - Option to mark a performance run as official
 - Option to skip saving of profiles

Testing: Executed these script to create the database and
populate the tables with the above mentioned data

Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
---
M tests/benchmark/create_database.py
M tests/benchmark/perf_result_datastore.py
M tests/benchmark/report_benchmark_results.py
3 files changed, 252 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10100/8
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10381 )

Change subject: IMPALA-6983: stress: don't write a null runtime profile
..


Patch Set 1: Code-Review+1

I don't have permissions to give +2
Looks good to me


--
To view, visit http://gerrit.cloudera.org:8080/10381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8299a8a97ad1f2bd1f2927e3111db8df1d3a3e5
Gerrit-Change-Number: 10381
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Fri, 11 May 2018 22:23:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6819: Add new performance test workload - tpcds-unmodified used by Impala Performance Tests

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9973 )

Change subject: IMPALA-6819: Add new performance test workload - 
tpcds-unmodified used by Impala Performance Tests
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9973/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9973/6//COMMIT_MSG@7
PS6, Line 7: Add new performance test workload - tpcds-unmodified used by 
Impala Performance Tests
> Please reference IMPALA-6819.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3957621d88b80fffc8fc89fd8104a58137b86e92
Gerrit-Change-Number: 9973
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Tue, 08 May 2018 16:57:23 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6819: Add new performance test workload - tpcds-unmodified used by Impala Performance Tests

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/9973 )

Change subject: IMPALA-6819: Add new performance test workload - 
tpcds-unmodified used by Impala Performance Tests
..

IMPALA-6819: Add new performance test workload - tpcds-unmodified used by 
Impala Performance Tests

Description:
Impala versions prior to 2.5 didn't have Runtimefilters, which made TPC-DS 
queries run very slow,
so queries under tpcds have explicit partition filters to workaround the 
limitation.
Post Impala 2.5 adding tpcds-unmodified which has the unmodified version of the
workload to provide more coverage

Testing:
Ran the performance tests using the new workload
and all tests passed

Change-Id: I3957621d88b80fffc8fc89fd8104a58137b86e92
---
A testdata/workloads/tpcds-unmodified/queries/tpcds-q1.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q10.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q11.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q12.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q13.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q14.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q15.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q16.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q17.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q18.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q19.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q2.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q20.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q21.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q22.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q23.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q25.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q26.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q27.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q28.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q29.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q3.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q30.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q31.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q32.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q33.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q34.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q35.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q36.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q37.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q38.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q39.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q4.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q40.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q41.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q42.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q43.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q44.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q45.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q46.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q47.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q48.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q49.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q5.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q50.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q51.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q52.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q53.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q54.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q55.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q56.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q57.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q58.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q59.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q6.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q60.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q61.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q62.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q63.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q64.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q65.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q66.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q68.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q69.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q7.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q70.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q71.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q72.test
A 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..

IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b

Address David's review comment

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
---
M bin/impala-config.sh
M bin/mvn-quiet.sh
2 files changed, 16 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9273/4
--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9303


Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..

IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b

Address David's review comment

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b

remove white space

Change-Id: I37f27788410e8aab8c41266329556103a92864e3
---
M bin/impala-config.sh
M bin/mvn-quiet.sh
2 files changed, 15 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/9303/1
--
To view, visit http://gerrit.cloudera.org:8080/9303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37f27788410e8aab8c41266329556103a92864e3
Gerrit-Change-Number: 9303
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has abandoned this change. ( 
http://gerrit.cloudera.org:8080/9303 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/9303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I37f27788410e8aab8c41266329556103a92864e3
Gerrit-Change-Number: 9303
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9308


Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..

IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b

Address David's review comment

remove white space

Update comments

code and comments cleanup mvn-quiet.sh

Change-Id: I83034a879643f74cfab141a50fba22e5fb07ab17
---
M bin/impala-config.sh
M bin/mvn-quiet.sh
2 files changed, 15 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/9308/1
--
To view, visit http://gerrit.cloudera.org:8080/9308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83034a879643f74cfab141a50fba22e5fb07ab17
Gerrit-Change-Number: 9308
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has abandoned this change. ( 
http://gerrit.cloudera.org:8080/9308 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/9308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I83034a879643f74cfab141a50fba22e5fb07ab17
Gerrit-Change-Number: 9308
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..

IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

Address David's review comment

remove white space

Update comments

code and comments cleanup mvn-quiet.sh

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
---
M bin/impala-config.sh
M bin/mvn-quiet.sh
2 files changed, 15 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9273/5
--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Patch Set 5:

> Patch Set 1:
>
> I think this is a good start, but this patch be improved again. I concede too 
> that the IMPALA-5139 description doesn't provide full context. Let me provide 
> some now:
>
> - I think mvn-quiet.sh capturing of mvn INFO output should go into one or 
> more files rooted in $IMPALA_LOG_DIR. This will let Jenkins jobs which tend 
> to look in that place collect the mvn logs, too.
>
> - The working directory and args matter. You can see that's already captured 
> L25-26 of this file, but I think we need that info alongside all the maven 
> output and be written to the log.
>
> - More than one thing calls mvn-quiet.sh. You need a strategy for appending 
> to a log file or writing multiple log files. tee -a might be of assistance 
> here.

Adding my responses to the review comments long after I have addressed them,

- Thanks Michael. I have addressed your comments to
  --- Write the mvn outputs to a single log file
  --- log file located in $IMPALA_HOME/logs/mvn


--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 15 Feb 2018 14:45:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Patch Set 5:

> Patch Set 3:
>
> (2 comments)Line 26 :  I have addressed this comment by keeping the exports 
> in impala-config.sh

Line 38: I have tried to make the code more readable now


--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 15 Feb 2018 14:47:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh
File bin/mvn-quiet.sh:

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@25
PS5, Line 25: "$IMPALA_MVN_LOGS_DI
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@27
PS5, Line 27: cat << EOF | tee -a "$LOG_FILE"
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@29
PS5, Line 29: Running mvn $IMPALA_MAVEN_OPTIONS $@
: Directory $(pwd)
: 

: EOF
> Sure...will do
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@35
PS5, Line 35:   echo "mvn $IMPALA_MAVEN_OPTIONS $@ exited with code $?"
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@35
PS5, Line 35: ho "mvn $
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/6/bin/mvn-quiet.sh
File bin/mvn-quiet.sh:

http://gerrit.cloudera.org:8080/#/c/9273/6/bin/mvn-quiet.sh@34
PS6, Line 34:
> Same as above will remove it before publishing it
Done


http://gerrit.cloudera.org:8080/#/c/9273/6/bin/mvn-quiet.sh@34
PS6, Line 34: if ! mvn $IMPALA_MAVEN_OPTIONS "$@" | tee -a "$LOG_FILE" | grep 
-E -e WARNING -e ERROR -e SUCCESS -e FAILURE -e Test;
> Yep...noticed itwas going to fix it before publishing the review.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 20 Feb 2018 23:43:37 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@25
PS2, Line 25: Excuting directory/IMPALA_HOME
> Yes...will fix the comment
I meant the message



--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 22 Feb 2018 21:02:33 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9385/1/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/9385/1/buildall.sh@24
PS1, Line 24: export IMPALA_HOME="$ROOT"
> Why move this line? Can't we hold off on export IMPALA_HOME to the environm
Done



--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 22 Feb 2018 19:59:28 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Fix review comments

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9399


Change subject: Fix review comments
..

Fix review comments

Change-Id: I31f5f36bafa9ca29e05729af9904c8d9838c1d93
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/9399/1
--
To view, visit http://gerrit.cloudera.org:8080/9399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31f5f36bafa9ca29e05729af9904c8d9838c1d93
Gerrit-Change-Number: 9399
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@23
PS2, Line 23: if [[ ( "'$PWD'" =~ [[:blank:]] ) || ("'$IMPALA_HOME'" =~ 
[[:blank:]] ) ]]
> I guess I was specifically wondering if this would work:
Yes. This should work since it checks $ROOT to not have space which is then 
used as IMPALA_HOME

But this might need to be moved before the trap statement to ensure PWD , ROOT 
and IMPALA_HOME are same



--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:37:09 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9385/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/9385/1/bin/impala-config.sh@57
PS1, Line 57: IMPALA HOME
> IMPALA_HOME
Done



--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 22 Feb 2018 19:59:16 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Fix review comments

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has abandoned this change. ( 
http://gerrit.cloudera.org:8080/9399 )

Change subject: Fix review comments
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/9399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I31f5f36bafa9ca29e05729af9904c8d9838c1d93
Gerrit-Change-Number: 9399
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..

IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces

Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 18 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/9385/2
--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@25
PS2, Line 25: Excuting directory/IMPALA_HOME
> "Executing"? Though I'm actually not sure how this whole line is supposed t
Yes...will fix the comment



--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 22 Feb 2018 21:01:58 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9385


Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..

IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces

Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 21 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/9385/1
--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh
File bin/mvn-quiet.sh:

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@25
PS5, Line 25: $IMPALA_MVN_LOGS_DIR
> This should be quoted in case a parent directory has a space.
Sure...will do


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@27
PS5, Line 27: #Print the output of mvn commands to a dedicated log file in 
$IMPALA_HOME/logs/mvn/mvn.log
> I'm not sure this comment is needed. Typically comments should say why is s
ok


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@29
PS5, Line 29: echo -e " 
\
:  \n Running mvn $IMPALA_MAVEN_OPTIONS $@ \
:  \n Directory: $(pwd) \
:  \n 
" >> 
$LOG_FILE
> I find this to be a little cluttered, with the backslashes and the \n at th
Sure...will do


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@35
PS5, Line 35: mvn "$@" | tee -a $LOG_FILE | grep -E -e WARNING -e ERROR -e 
SUCCESS -e FAILURE -e Test; then
> > * I still think mvn being piped to mvn is an odd construction, and probab
Working on the review comments



--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 15 Feb 2018 19:28:47 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh
File bin/mvn-quiet.sh:

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@35
PS5, Line 35: mvn "$@"
Regarding the pipe to mvn - my bad...I though I had removed it in the previous 
match I was trying to move around things to see the output and forgot to 
remove this.
Fixed the rest of the comments. Will push the changes soon.



--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 15 Feb 2018 21:54:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..


Patch Set 7:

https://jenkins.impala.io/job/gerrit-verify-dryrun-external/83/console - Gerrit 
dry run was successful


--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Wed, 21 Feb 2018 17:17:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#6). ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..

IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

Address David's review comment

remove white space

Update comments

code and comments cleanup mvn-quiet.sh

Fixed review comments

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
---
M bin/impala-config.sh
M bin/mvn-quiet.sh
2 files changed, 15 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9273/6
--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
..

IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

Verified the changes to mvn-quiet.sh by trigerring an impala build by
running bootstrap_development.sh which invokes mvn-quiet at multiple
places. Verified the creation of mvn log file with the relevant content
in the $IMPALA_HOME/logs/mvn folder

Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
---
M bin/impala-config.sh
M bin/mvn-quiet.sh
2 files changed, 15 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9273/7
--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has removed Mostafa Mokhtar from this change.  ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Update scripts in benchmark folder to store 
workload and few minor updates
..


Removed reviewer Mostafa Mokhtar.
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 15
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has removed Jim Apple from this change.  ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Update scripts in benchmark folder to store 
workload and few minor updates
..


Removed reviewer Jim Apple.
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 15
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jinchul Kim 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has removed Jinchul Kim from this change.  ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Update scripts in benchmark folder to store 
workload and few minor updates
..


Removed reviewer Jinchul Kim.
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 15
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6923: Remove create database.py and perf result datastore.py

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#22). ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Remove create_database.py and 
perf_result_datastore.py
..

IMPALA-6923: Remove create_database.py and perf_result_datastore.py

Description:
The current upstream usage indicates that report_benchmark_results.py script
is the only script in this folder that is used to generate a report comparing
performance between two given runs of the performance tests. The other two
scripts create_database.py and perf_result_datastore.py store some metrics
from a performance test run to database on a specified impala instance.
However they rely on some Internal resources not available to
external apache community to generate a meaningful interpretation/report of the
metrics stored in the performance database.

This change also removes lines of code from report_benchmark_results.py
that were previously parsing command line options, that were being used by the
two scripts that are being removed.

Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
---
D tests/benchmark/create_database.py
D tests/benchmark/perf_result_datastore.py
M tests/benchmark/report_benchmark_results.py
3 files changed, 15 insertions(+), 417 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10100/22
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 22
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6923: Remove create database.py and perf result datastore.py

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has abandoned this change. ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Remove create_database.py and 
perf_result_datastore.py
..


Abandoned

Abandoning this request to start a new one
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 22
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6923: Remove create database.py and perf result datastore.py

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11315


Change subject: IMPALA-6923: Remove create_database.py and 
perf_result_datastore.py
..

IMPALA-6923: Remove create_database.py and perf_result_datastore.py

Description:
The current upstream usage indicates that report_benchmark_results.py script
is the only script in this folder that is used to generate a report comparing
performance between two given runs of the performance tests. The other two
scripts create_database.py and perf_result_datastore.py store some metrics
from a performance test run to database on a specified impala instance.
However they rely on some Internal resources not available to
external apache community to generate a meaningful interpretation/report of the
metrics stored in the performance database.

This change also removes lines of code from report_benchmark_results.py
that were previously parsing command line options, that were being used by the
two scripts that are being removed.

Change-Id: I2c9b04f0d0e8ca221e383aab2ba3ee53d968dd10
---
D tests/benchmark/create_database.py
D tests/benchmark/perf_result_datastore.py
M tests/benchmark/report_benchmark_results.py
3 files changed, 15 insertions(+), 417 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/11315/1
--
To view, visit http://gerrit.cloudera.org:8080/11315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c9b04f0d0e8ca221e383aab2ba3ee53d968dd10
Gerrit-Change-Number: 11315
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Update scripts in benchmark folder to store 
workload and few minor updates
..


Patch Set 12:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/10100/12/tests/benchmark/perf_result_datastore.py
File tests/benchmark/perf_result_datastore.py:

http://gerrit.cloudera.org:8080/#/c/10100/12/tests/benchmark/perf_result_datastore.py@23
PS12, Line 23: from subprocess import *
> "*" is an antipattern for imports. It is better to be explicit about import
Done

Removed this import since it is not used in the file


http://gerrit.cloudera.org:8080/#/c/10100/12/tests/benchmark/perf_result_datastore.py@63
PS12, Line 63:   def insert_workload_summary(self, run_info_id):
 : self._insert_workload_summary(run_info_id)
> This doesn't seem to do anything useful, so just rename _insert_workload_su
Done. Good catch


http://gerrit.cloudera.org:8080/#/c/10100/12/tests/benchmark/perf_result_datastore.py@85
PS12, Line 85:   dont_save_profiles):
> Negatives are weird. It would be better to call this save_profiles and flip
Done


http://gerrit.cloudera.org:8080/#/c/10100/12/tests/benchmark/perf_result_datastore.py@88
PS12, Line 88: temp_profile_folder = 
os.path.join(home_dir,"workspace","impala-workload-runner","profiles")
> This is badly formated. There should be spaces between parameters. impala-f
Done


http://gerrit.cloudera.org:8080/#/c/10100/12/tests/benchmark/perf_result_datastore.py@155
PS12, Line 155: self._cache: Dictionary of with run_info/user as 
key/value
> This isn't quite right. self._cache appears to be a hash in which a tuple o
Done



--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 12
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Jinchul Kim 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Fri, 20 Jul 2018 18:11:01 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#12). ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923: Update scripts in benchmark folder to store 
workload and few minor updates
..

IMPALA-6923: Update scripts in benchmark folder to store workload and few minor 
updates

Updates to the scripts in benchmark folder to
 - Store test execution results to ExecutionResults table
 - Store workload metrics to WorkloadMetrics
 - Option to mark a performance run as official
 - Option to skip saving of profiles

Testing: Executed these script to create the database and
populate the tables with the above mentioned data

Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
---
M tests/benchmark/create_database.py
M tests/benchmark/perf_result_datastore.py
M tests/benchmark/report_benchmark_results.py
3 files changed, 303 insertions(+), 76 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10100/12
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 12
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Jinchul Kim 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10931


Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
..

IMPALA-7228: Add tpcds-unmodified to single-node-perf-run

Description:
tpcds-unmodified workload was added as a part of IMPALA-6819
This change allows tpcds-unmodified workload to be available
for single node perf run

Testing:
Ran single node perf run using the following parameters and the
test run was successful

--iterations 2 --scale 2 --table_formats "parquet/none" \
--num_impalads 1 --workload "tpcds-unmodified" \
--load --query_names "TPCDS-Q17.*" --start_minicluster

Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
---
M bin/single_node_perf_run.py
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10931/4
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 

[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10931 )

Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10931/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10931/4//COMMIT_MSG@10
PS4, Line 10: tpcds-unmodified workload was added as a part of IMPALA-6819
> nits: period at end of both sentences.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:08:42 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/10931 )

Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
..

IMPALA-7228: Add tpcds-unmodified to single-node-perf-run

Description:
tpcds-unmodified workload was added as a part of IMPALA-6819.
This change allows tpcds-unmodified workload to be available
for the single node perf run.

Testing:
Ran single node perf run using the following parameters and the
test run was successful

--iterations 2 --scale 2 --table_formats "parquet/none" \
--num_impalads 1 --workload "tpcds-unmodified" \
--load --query_names "TPCDS-Q17.*" --start_minicluster

Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
---
M bin/single_node_perf_run.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10931/5
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 

[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/10931 )

Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
..

IMPALA-7228: Add tpcds-unmodified to single-node-perf-run

Description:
tpcds-unmodified workload was added as a part of IMPALA-6819.
This change allows tpcds-unmodified workload to be available
for the single node perf run.

Testing:
Ran single node perf run using the following parameters and the
test run was successful

--iterations 2 --scale 2 --table_formats "parquet/none" \
--num_impalads 1 --workload "tpcds-unmodified" \
--load --query_names "TPCDS-Q17.*" --start_minicluster

Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
---
M bin/single_node_perf_run.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10931/7
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle exit code for EE tests when no tests are collected.After this change return code will be either 0 if no tests are expecte

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9494


Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle 
exit_code for EE tests when no tests are collected.After this change 
return_code will be either 0 if no tests are expected to be collected (dry-run) 
and 1 if tests are expected to be collected
..

IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle
exit_code for EE tests when no tests are collected.After this
change return_code will be either 0 if no tests are expected
to be collected (dry-run) and 1 if tests are expected to be
collected but are not collected due to some error

Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
---
M tests/run-tests.py
1 file changed, 58 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9494/4
--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@100
PS4, Line 100: if exit_code == 5:
> I wonder if this would work?
Done



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 08 Mar 2018 00:50:39 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@30
PS4, Line 30: from _pytest.runner import runtestprotocol
> Again...handled in the last patch
Done



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Wed, 07 Mar 2018 23:21:14 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@244
PS4, Line 244: print_metrics('connections')
> Please make sure to maintain consistent print_metrics() usage. I think you
Done



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 08 Mar 2018 00:41:29 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle exit code for EE tests when no tests are collected.After this change return code will be either 0 if no tests are expecte

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle 
exit_code for EE tests when no tests are collected.After this change 
return_code will be either 0 if no tests are expected to be collected (dry-run) 
and 1 if tests are expected to be collected
..


Patch Set 4:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@65
PS4, Line 65: class TestStatisticsPlugin:
> Use 2 spaces to follow Impala Python convention.
I see what you are saying. But the other classes (Class Testexecutor) in 
run-test.py  don't follow the 2 spaces convention.

What would you recommend ?


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@71
PS4, Line 71: # items represents the list of collected test items
> Use Python's docstring comment instead.
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@87
PS4, Line 87:
> Remove extra new line.
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@96
PS4, Line 96: if "--collect-only" in args:
> In general, we use single quotes for strings in Python.
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@100
PS4, Line 100: if exit_code == 5:
> Some documentation on what exit_code 5 means?
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@240
PS4, Line 240: collect_mode = True
> I don't see where collect_mode is declared or used.
Yes...It is not needed. It is from some debugging I was doing. removed now


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@243
PS4, Line 243:   if '--collect-only' not in sys.argv:
> Isn't it just an else statement for the if statement in line: 239?
you are right...fixed it now



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Wed, 07 Mar 2018 22:48:09 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#8). ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..

IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5

exit_code for EE tests when no tests are collected.After this
change return_code will be either 0 if no tests are expected
to be collected (dry-run) and 1 if tests are expected to be
collected but are not collected due to some error

Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
---
M tests/run-tests.py
1 file changed, 65 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9494/8
--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9494/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9494/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle
> The commit convention is:
Done



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Wed, 07 Mar 2018 22:50:03 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 4:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/9494/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9494/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle
> Agreed. And also, please explain testing done.
It has been handled in the latest patch


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@30
PS4, Line 30: from _pytest.runner import runtestprotocol
> Is this used?
Again...handled in the last patch


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@65
PS4, Line 65: class TestStatisticsPlugin:
> Please use new-style classes, and inherit from object.
Done.

I would prefer to keep the name as TestStatistics , so  any functions related 
to pytest data can be added here


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@65
PS4, Line 65: class TestStatisticsPlugin:
> I see what you are saying. But the other classes (Class Testexecutor) in ru
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@67
PS4, Line 67:   def __init__(self):
:   self.tests_collected = []
:   self.tests_executed = []
> 2 spaces, please.
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@71
PS4, Line 71: # items represents the list of collected test items
> Agreed.
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@72
PS4, Line 72:   def pytest_collection_modifyitems(self, items):
> For these special hooks I think it's important to note that the name is sig
Done


http://gerrit.cloudera.org:8080/#/c/9494/4/tests/run-tests.py@97
PS4, Line 97:   for test in plugin.tests_collected:
: print(test)
> Not sure this is necessary. It looks like you're printing tests twice: once
I have kept this to allow suppressing of pytest verbose messages and just see 
the list of collected tests by

run-tests.py shell --collect-only -p no:terminal



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Wed, 07 Mar 2018 23:20:34 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#1). ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..

IMPALA-5886 Update run-tests.py script to handle exit_code for EE tests when no 
tests are collected
After this change return_code will be either 0 if no tests are expected to be 
collected (dry-run) and 1 if tests are expected to be collected but are not 
collected due
to come error

Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
---
M tests/run-tests.py
1 file changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9494/1
--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 11:

https://jenkins.impala.io/job/gerrit-verify-dryrun-external/90/console - 
gerrit-dry-run was successful


--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 11
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Fri, 09 Mar 2018 22:13:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#11). ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..

IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5

exit_code for EE tests when no tests are collected.After this
change return_code will be either 0 if no tests are expected
to be collected (dry-run) and 1 if tests are expected to be
collected but are not collected due to some error

Testing:
 - Ran end-to-end shell, hs2 tests for IMPALA-5886 with debug
   statements to verify the exit_codes
 - Ran end-to-end shell tests with collect-only for IMPALA-4812

Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
---
M tests/run-tests.py
1 file changed, 66 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9494/11
--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 11
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9494/11/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/11/tests/run-tests.py@112
PS11, Line 112: len(testcounterplugin.tests_executed) <= 0
> I think this comment was missed from before as well. I don't thinks len(tes
Hi David,

I think the current placement of this logic is fine because we are handling the 
non-zero exit code of 5 inside the test_executor. Lets say for example 
pytest.main gets invoked for "serially" and there were no tests to run, it 
would default the exit_code to 0 and then after that when parallel gets called 
and there were tests to execute and they pass then the exit_code would be 0 and 
1 if they fail, While before for the same sequence of events RC would be a 5 
and 0 or 5 and 1 , but now it would be 0 or 1.

So I don't think we need to move this logic to be inside main

So going forward systest will exit(1) only when the tests have genuinely failed 
and not when no tests were collected

if exit_code == EXIT_NOTESTSCOLLECTED:
  if len(testcounterplugin.tests_executed) <= 0 :
exit_code = 0
  else:
exit_code = 1

This would take care of setting the exit_code accordingly thereby avoiding 
run-tests exiting because there was a pytest RC of 5 (no tests collected)



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 11
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Sat, 10 Mar 2018 14:18:41 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#12). ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..

IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5

exit_code for EE tests when no tests are collected.After this
change return_code will be either 0 if no tests are expected
to be collected (dry-run) and 1 if tests are expected to be
collected but are not collected due to some error

Testing:
 - Ran end-to-end shell, hs2 tests for IMPALA-5886 with debug
   statements to verify the exit_codes
 - Ran end-to-end shell tests with collect-only for IMPALA-4812

Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
---
M tests/run-tests.py
1 file changed, 70 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9494/12
--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 12
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9494/9/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/9/tests/run-tests.py@63
PS9, Line 63: class TestCounterPlugin(object):
> Extend from (object) just like TestExecutor definition. In general it's pre
Done


http://gerrit.cloudera.org:8080/#/c/9494/11/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/9494/11/tests/run-tests.py@107
PS11, Line 107: #though 5 is a normal return code, our jenkins handles 
non-zero RC as error in
> This is odd wording in this context. Don't forget that this code goes into
Done



--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 11
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Sat, 10 Mar 2018 15:38:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 8:

> Thanks Tim and David for reviewing the changes


--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 17:36:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 8:

Thanks Tm and David for reviewing the changes


--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 17:32:42 +
Gerrit-HasComments: No

[Impala-ASF-CR] Add new performance test workload - tpcds-unmodified

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9973 )

Change subject: Add new performance test workload - tpcds-unmodified
..


Patch Set 2:

Sure will doWill create an upstream JIRA and add details of the testing


--
To view, visit http://gerrit.cloudera.org:8080/9973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3957621d88b80fffc8fc89fd8104a58137b86e92
Gerrit-Change-Number: 9973
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Wed, 18 Apr 2018 17:42:43 +
Gerrit-HasComments: No

[Impala-ASF-CR] Add new performance test workload - tpcds-unmodified used by Impala Performance Tests

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#6). ( 
http://gerrit.cloudera.org:8080/9973 )

Change subject: Add new performance test workload - tpcds-unmodified used by 
Impala Performance Tests
..

Add new performance test workload - tpcds-unmodified used by Impala Performance 
Tests

Description:
Impala versions prior to 2.5 didn't have Runtimefilters, which made TPC-DS 
queries run very slow,
so queries under tpcds have explicit partition filters to workaround the 
limitation.
Post Impala 2.5 adding tpcds-unmodified which has the unmodified version of the
workload to provide more coverage

Testing:
Ran the performance tests using the new workload
and all tests passed

Change-Id: I3957621d88b80fffc8fc89fd8104a58137b86e92
---
A testdata/workloads/tpcds-unmodified/queries/tpcds-q1.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q10.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q11.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q12.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q13.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q14.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q15.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q16.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q17.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q18.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q19.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q2.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q20.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q21.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q22.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q23.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q25.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q26.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q27.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q28.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q29.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q3.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q30.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q31.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q32.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q33.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q34.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q35.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q36.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q37.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q38.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q39.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q4.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q40.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q41.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q42.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q43.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q44.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q45.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q46.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q47.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q48.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q49.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q5.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q50.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q51.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q52.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q53.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q54.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q55.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q56.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q57.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q58.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q59.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q6.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q60.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q61.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q62.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q63.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q64.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q65.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q66.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q68.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q69.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q7.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q70.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q71.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q72.test
A 

[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/9979 )

Change subject: IMPALA-6819: Add new queries to targeted-perf workload
..

IMPALA-6819: Add new queries to targeted-perf workload

Description:
Adding new queries to the targeted-perf workload that is
used by Impala performance tests run via $IMPALA_HOME/bin/run-workload.py

Testing:
Ran the performance tests for the targeted-perf workload
and all the tests passed

Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
---
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_1.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_2.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_3.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_4.test
A testdata/workloads/targeted-perf/queries/primitive_count_star.test
A testdata/workloads/targeted-perf/queries/primitive_decimal_arithmetic.test
A testdata/workloads/targeted-perf/queries/primitive_filter_bigint_in_list.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_appx_median.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_to_date.test
M testdata/workloads/targeted-perf/queries/primitive_long_predicate.test
A testdata/workloads/targeted-perf/queries/primitive_many_fragments.test
A 
testdata/workloads/targeted-perf/queries/primitive_many_independent_fragments.test
A 
testdata/workloads/targeted-perf/queries/primitive_orderby_bigint_expression.test
A testdata/workloads/targeted-perf/queries/primitive_shuffle_1mb_rows.test
14 files changed, 675 insertions(+), 171 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9979/4
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 

[Impala-ASF-CR] CDH-65183 Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10100


Change subject: CDH-65183 Update scripts in benchmark folder to store workload 
and few minor updates
..

CDH-65183 Update scripts in benchmark folder to store workload and few minor 
updates

Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
---
M tests/benchmark/create_database.py
M tests/benchmark/perf_result_datastore.py
M tests/benchmark/report_benchmark_results.py
3 files changed, 180 insertions(+), 58 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10100/5
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Mostafa Mokhtar 

[Impala-ASF-CR] IMPALA-6923:Update scripts in benchmark folder to store workload and few minor updates

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10100 )

Change subject: IMPALA-6923:Update scripts in benchmark folder to store 
workload and few minor updates
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10100/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10100/5//COMMIT_MSG@7
PS5, Line 7: CDH-65183 Update scripts in benchmark folder to store workload and 
few minor updates
> Please use IMPALA tickets. People who do not work at Cloudera cannot read C
Done



--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Tue, 24 Apr 2018 22:36:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add new performance test workload - tpcds-unmodified

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9973


Change subject: Add new performance test workload - tpcds-unmodified
..

Add new performance test workload - tpcds-unmodified

Description:
Impala versions prior to 2.5 didn't have Runtimefilters, which made TPC-DS 
queries run very slow,
so queries under tpcds have explicit partition filters to workaround the 
limitation.
Post Impala 2.5 adding tpcds-unmodified which has the unmodified version of the
workload to provide more coverage

Change-Id: I3957621d88b80fffc8fc89fd8104a58137b86e92
---
A testdata/workloads/tpcds-unmodified/queries/tpcds-q1.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q10.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q11.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q12.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q13.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q14.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q15.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q16.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q17.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q18.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q19.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q2.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q20.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q21.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q22.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q23.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q25.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q26.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q27.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q28.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q29.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q3.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q30.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q31.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q32.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q33.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q34.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q35.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q36.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q37.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q38.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q39.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q4.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q40.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q41.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q42.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q43.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q44.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q45.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q46.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q47.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q48.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q49.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q5.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q50.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q51.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q52.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q53.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q54.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q55.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q56.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q57.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q58.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q59.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q6.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q60.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q61.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q62.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q63.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q64.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q65.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q66.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q68.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q69.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q7.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q70.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q71.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q72.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q73.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q74.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q75.test
A 

[Impala-ASF-CR] Add new queries to targeted-perf workload

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9979


Change subject: Add new queries to targeted-perf workload
..

Add new queries to targeted-perf workload

Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
---
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_1.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_2.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_3.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_4.test
A testdata/workloads/targeted-perf/queries/primitive_count_star.test
A testdata/workloads/targeted-perf/queries/primitive_decimal_arithmetic.test
A testdata/workloads/targeted-perf/queries/primitive_filter_bigint_in_list.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_appx_median.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_to_date.test
M testdata/workloads/targeted-perf/queries/primitive_long_predicate.test
A testdata/workloads/targeted-perf/queries/primitive_many_fragments.test
A 
testdata/workloads/targeted-perf/queries/primitive_many_independent_fragments.test
A 
testdata/workloads/targeted-perf/queries/primitive_orderby_bigint_expression.test
A testdata/workloads/targeted-perf/queries/primitive_shuffle_1mb_rows.test
14 files changed, 675 insertions(+), 171 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9979/3
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 3
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Mostafa Mokhtar 

[Impala-ASF-CR] IMPALA-6760: Fix for py2.7-ism in run-tests.py.

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9843 )

Change subject: IMPALA-6760: Fix for py2.7-ism in run-tests.py.
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81928d1880a493b91abb13b3a8149568c9789f66
Gerrit-Change-Number: 9843
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 28 Mar 2018 22:20:24 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 5:

Yes. Have one last patch I need to put
Got pulled in to CDH-64539will put the patch asap


--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 29 Mar 2018 22:22:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#14). ( 
http://gerrit.cloudera.org:8080/9494 )

Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle 
exit_code 5
..

IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5

exit_code for EE tests when no tests are collected.After this
change return_code will be either 0 if no tests are expected
to be collected (dry-run) and 1 if tests are expected to be
collected but are not collected due to some error

Testing:
 - Ran end-to-end shell, hs2 tests for IMPALA-5886 with debug
   statements to verify the exit_codes
 - Ran end-to-end shell tests with collect-only for IMPALA-4812

Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
---
M tests/run-tests.py
1 file changed, 69 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9494/14
--
To view, visit http://gerrit.cloudera.org:8080/9494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 14
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..

IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces

Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 18 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/9385/5
--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..

IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces

Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 18 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/9385/3
--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 3
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] Review comments

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9464


Change subject: Review comments
..

Review comments

Change-Id: I15fcab44052aa98e19343746bc07bfdffe663a0e
---
M buildall.sh
1 file changed, 5 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/9464/1
--
To view, visit http://gerrit.cloudera.org:8080/9464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15fcab44052aa98e19343746bc07bfdffe663a0e
Gerrit-Change-Number: 9464
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] Review comments

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has abandoned this change. ( 
http://gerrit.cloudera.org:8080/9464 )

Change subject: Review comments
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/9464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I15fcab44052aa98e19343746bc07bfdffe663a0e
Gerrit-Change-Number: 9464
Gerrit-PatchSet: 1
Gerrit-Owner: Nithya Janarthanan 

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@23
PS2, Line 23: if [[ ( "'$PWD'" =~ [[:blank:]] ) || ("'$IMPALA_HOME'" =~ 
[[:blank:]] ) ]]
> Yes. This should work since it checks $ROOT to not have space which is then
Done


http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@25
PS2, Line 25: Excuting directory/IMPALA_HOME
> Yes...will fix the comment
Done



--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 
Gerrit-Comment-Date: Thu, 01 Mar 2018 18:27:30 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
..

IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces

Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 18 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/9385/4
--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Nithya Janarthanan 

[Impala-ASF-CR] IMPALA-6976: Parser to parse Impala query profiles

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has abandoned this change. ( 
http://gerrit.cloudera.org:8080/10309 )

Change subject: IMPALA-6976: Parser to parse Impala query profiles
..


Abandoned

A decision has been made to not have this script here. Hence abandoning the 
review
--
To view, visit http://gerrit.cloudera.org:8080/10309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I30e9443e87a500c081892d670ed49c7393826c59
Gerrit-Change-Number: 10309
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Mostafa Mokhtar 

[Impala-ASF-CR] IMPALA-6976: Parser to parse Impala query profiles

[Nithya Janarthanan (Code Review)]

Nithya Janarthanan has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10309


Change subject: IMPALA-6976: Parser to parse Impala query profiles
..

IMPALA-6976: Parser to parse Impala query profiles

Script to parse Query profiles to generate a one line summary for
each of the profiles, which can then be used for generating reports

Testing:
Tested by running the script on a few profiles to generate the summary

Change-Id: I30e9443e87a500c081892d670ed49c7393826c59
---
A tests/benchmark/ParseQueryProfile.py
1 file changed, 668 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/10309/2
--
To view, visit http://gerrit.cloudera.org:8080/10309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30e9443e87a500c081892d670ed49c7393826c59
Gerrit-Change-Number: 10309
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Mostafa Mokhtar