[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4492

Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..

[client-test] one more test for AUTO_FLUSH_BACKGROUND

An additional test for the AUTO_FLUSH_BACKGROUND flush mode:
verify that it's safe to perform synchronous and/or asynchronous
flush while having the auto-flusher thread running in the background.

Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257
---
M src/kudu/client/client-test.cc
1 file changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/4492/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java client] Improve and hide 
OperationResponse#getWriteTimestamp
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-client/src/main/java/org/apache/kudu/client/OperationResponse.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/OperationResponse.java:

PS1, Line 85: @InterfaceAudience.Private
Should probably add this to the release notes for 1.1.0.


-- 
To view, visit http://gerrit.cloudera.org:8080/4487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cfc6fcc1d0607a94bb8be9e5a0d53a4987920af
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java client] Few ITClient improvements

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java client] Few ITClient improvements
..


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4489/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:

Line 155: scanner.close();
Hmm, didn't know we need to explicitly close. Guess I'm too used to the C++ 
client.


PS1, Line 173: KuduScanner scanner = scanBuilder.build();
 : while (scanner.hasMoreRows()) {
 :   count += scanner.nextRows().getNumRows();
 : }
 : return count;
Can you use countRowsInScan() here? Maybe elsewhere too?


http://gerrit.cloudera.org:8080/#/c/4489/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java:

PS1, Line 107:   
thread.setUncaughtExceptionHandler(uncaughtExceptionHandler);
You find this cleaner than explicitly catching RuntimeException in writerThread 
and scannerThread (is this an issue for chaosThread too)?


PS1, Line 290:   if (resp == null) {
 : return false;
 :   }
Why would the result of session.apply() be null, or session.flush() include a 
null in the list?


Line 295:   if (writeTimestamp != 0) {
Under what conditions will it be 0? The very first write?


PS1, Line 419: so when we get back with the same one
Nit: this fragment is confusing. What does it mean to "get back with the same 
one"?


-- 
To view, visit http://gerrit.cloudera.org:8080/4489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5ddca26b66e9fc1f737aaacf98df340f0b9024
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [tests] fix tests - two cpus and fresh install

[Brock Noland (Code Review)]

Brock Noland has posted comments on this change.

Change subject: [tests] fix tests - two cpus and fresh install
..


Patch Set 2:

That does look similar. I can look into this more. It's actually bothering me 
that I cannot explain exactly why it fails.

-- 
To view, visit http://gerrit.cloudera.org:8080/4446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81b70f63923078d449f6541a61b292517e49877d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Brock Noland 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [java client] Fix an NPE in KuduException

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: [java client] Fix an NPE in KuduException
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4488/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java:

PS1, Line 83: // Message is allowed to be null, so if we let it go through 
we'll NPE building the Status
: // down the line.
> Nit: second part of the sentence is self-evident. I'd just say "The message
> Where do these null messages come from?

InterruptedException when created via thread.interrupt has a null message. 
Here's another instance that's less clear:

java.lang.NullPointerException
at 
org.apache.kudu.WireProtocol$AppStatusPB$Builder.setMessage(WireProtocol.java:847)
at org.apache.kudu.client.Status.(Status.java:43)
at org.apache.kudu.client.Status.(Status.java:52)
at org.apache.kudu.client.Status.IOError(Status.java:128)
at 
org.apache.kudu.client.KuduException.transformException(KuduException.java:96)
at org.apache.kudu.client.KuduSession.apply(KuduSession.java:88)
at org.apache.kudu.client.ITClient$WriterThread.run(ITClient.java:240)


-- 
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java client] Fix an NPE in KuduException

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java client] Fix an NPE in KuduException
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4488/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java:

PS1, Line 83: // Message is allowed to be null, so if we let it go through 
we'll NPE building the Status
: // down the line.
Nit: second part of the sentence is self-evident. I'd just say "The message may 
be null." (since that is surprising).

Where do these null messages come from?


-- 
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [tests] fix tests - two cpus and fresh install

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [tests] fix tests - two cpus and fresh install
..


Patch Set 2:

Is this related to KUDU-1590?

-- 
To view, visit http://gerrit.cloudera.org:8080/4446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81b70f63923078d449f6541a61b292517e49877d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Brock Noland 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4471

to look at the new patch set (#5).

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..

[tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND

In tests, run KuduSession in AUTO_FLUSH_BACKGROUND instead of
MANUAL_FLUSH mode where appropriate.

Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
---
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/tools/ksck_remote-test.cc
11 files changed, 90 insertions(+), 100 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/4471/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4471/3/src/kudu/integration-tests/all_types-itest.cc
File src/kudu/integration-tests/all_types-itest.cc:

Line 218:   // Set the flush threshold low so that there are flush events 
which
> grammar changes like this are subjective, we usually avoid doing them if yo
ok, that makes sense -- will return it back then.


Line 222:   // Set the major delta compaction ratio low enough so that the 
test
> I'm ambivalent whether the grammar change is justified.
Done


Line 227:   // once KUDU-1631/KUDU-1346 is fixed. It's necessary to change 
the default
> you mean KUDU-1632, not KUDU-1631. Maybe mark KUDU-1632 as a dup of KUDU-13
Done


PS3, Line 231: --consensus_max_batch_size_bytes=2097152
> have you tested that this doens't trigger the check. How big can single tab
Yes, I've tested that.  As you could see from the stack trace of the debug 
assert, it was slightly bigger than 1MiB:

request->ByteSize() <= FLAGS_consensus_max_batch_size_bytes (1168286 vs. 
1048576)
*** Check failure stack trace: ***


-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4487

Change subject: [java client] Improve and hide 
OperationResponse#getWriteTimestamp
..

[java client] Improve and hide OperationResponse#getWriteTimestamp

That method was returning a HT-encoded ts, not a ts in microseconds. It's
also not meant for public consumption just yet, the same way
AbstractKuduScannerBuilder#snapshotTimestampRaw is.

Change-Id: I8cfc6fcc1d0607a94bb8be9e5a0d53a4987920af
---
M java/kudu-client/src/main/java/org/apache/kudu/client/OperationResponse.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
2 files changed, 9 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/4487/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cfc6fcc1d0607a94bb8be9e5a0d53a4987920af
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 

[kudu-CR] [java client] Fix an NPE in KuduException

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4488

Change subject: [java client] Fix an NPE in KuduException
..

[java client] Fix an NPE in KuduException

Saw this in a Jenkins run and also running ITClient on my machine.

Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4488/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 

[kudu-CR] [java client] Few ITClient improvements

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4489

Change subject: [java client] Few ITClient improvements
..

[java client] Few ITClient improvements

ITClient has been flaky for a while now, mostly due to the "Row count regressed"
issue. I fixed it by using snapshot timestamps, which made me refactor how we 
build
scanners, which made me add a new counting method in BaseKuduTest.

I continued running the test and saw other issues. Some unchecked errors were 
not
killing the test, so I added an UncaughtExceptionHandler. I also saw invalid
scanner sequence ID errors that are normal due to how this test runs that were 
killing
the test. Finally, I converted some plain Exceptions into KuduExceptions which 
gave
us access to their Status.

Change-Id: I3b5ddca26b66e9fc1f737aaacf98df340f0b9024
---
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
2 files changed, 70 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/4489/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b5ddca26b66e9fc1f737aaacf98df340f0b9024
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 

[kudu-CR] [tests] fix tests - two cpus and fresh install

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change.

Change subject: [tests] fix tests - two cpus and fresh install
..


Patch Set 2:

I don't know much of anything about the codegen portion of Kudu, so I don't 
feel OK'ing even just bumping up the cache size in the test, especially without 
any understanding from the patch of why it failed with the lower size. I'm 
adding Todd to the review, who'll either know about this or know who knows 
about this.

-- 
To view, visit http://gerrit.cloudera.org:8080/4446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81b70f63923078d449f6541a61b292517e49877d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4471

to look at the new patch set (#4).

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..

[tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND

In tests, run KuduSession in AUTO_FLUSH_BACKGROUND instead of
MANUAL_FLUSH mode where appropriate.

Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
---
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/tools/ksck_remote-test.cc
11 files changed, 92 insertions(+), 100 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/4471/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4471

to look at the new patch set (#3).

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..

[tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND

In tests, run KuduSession in AUTO_FLUSH_BACKGROUND instead of
MANUAL_FLUSH mode where appropriate.

Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
---
M src/kudu/client/client-test.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/tools/ksck_remote-test.cc
11 files changed, 92 insertions(+), 97 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/4471/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-861 Support changing default, storage attributes

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-861 Support changing default, storage attributes
..


Patch Set 6:

Still going through the code changes, but wanted to note that you should add 
the new alteration types to alter_table-randomized-test.cc.  That's our alter 
table fuzz test, and tends to catch the most bugs with the alter table code 
path.

-- 
To view, visit http://gerrit.cloudera.org:8080/4310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I457d99ba2188ef6e439df47c0d94f2dc1a62ea6c
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'
..


Patch Set 7:

Just looked at the output / formatting, but LGTM

-- 
To view, visit http://gerrit.cloudera.org:8080/4440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] refactor schema-design guide

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: refactor schema-design guide
..


Patch Set 1:

rendered: 
https://github.com/danburkert/kudu/blob/schema-design/docs/schema_design.adoc

-- 
To view, visit http://gerrit.cloudera.org:8080/4485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4d91043d72e816a930d50927bf9441bd6b30b9b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] Add support for clang from XCode 8 in macOS

[David Ribeiro Alves (Code Review)]

Hello Dan Burkert,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4482

to look at the new patch set (#2).

Change subject: Add support for clang from XCode 8 in macOS
..

Add support for clang from XCode 8 in macOS

Since upgrading XCode to 8 (even in El Capitan), cmake has outputted an
unsupported compiler message:

  Unknown compiler.  Version info:

  Apple LLVM version 8.0.0 (clang-800.0.38)

  Target: x86_64-apple-darwin16.0.0

  Thread model: posix

  InstalledDir:
  
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

This is also the default version in the new macOS Sierra.
This patch fixes this by adding it to the list of supported
compilers.

Note that this patch, by itself, won't allow to fully compile Kudu in
macOS Sierra, as the current version of tcmalloc is incompatible:
https://github.com/gperftools/gperftools/issues/827

We need to wait until the issue above is fixed in order to fully support
building with the default toolchain in macOS Sierra. In the meanwhile this
patch is still valuable. It's still possible to build Kudu with the clang
toolchain we ship and CLion users can still use the default toolchain,
as long as they don't actually run the CLion build's binaries.

Were we to change to jemalloc, that issue is solved there:
https://github.com/jemalloc/jemalloc/pull/427

Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/4482/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 3:

> did you test this manually? I'm not sure whether jenkins even
 > builds this (needs oauth) and pretty sure there are no tests.

Yes, sure -- I built it on MacOS X (installed liboauth from ports).  It worked 
for me.

Or you mentioned running that demo app?  I haven't tried to run that.  Will try 
to do that.

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link

[Ninad Shringarpure (Code Review)]

Ninad Shringarpure has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4483

Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and 
not actual link
..

[doc] KUDU-1630 impala_tables.html link is showing as text and not actual link

Missing space before the hyperlink was causing this issue.
Please check the resultant html here:
https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html

Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
---
M docs/kudu_impala_integration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 

[kudu-CR] Add support for clang from XCode 8 in macOS

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add support for clang from XCode 8 in macOS
..


Patch Set 1:

It seems this is missing a gperftools side update to work with tcmalloc: 
https://github.com/gperftools/gperftools/issues/827

Interestingly this is working jemalloc, were we to change to it: 
https://github.com/jemalloc/jemalloc/pull/427

I suggest that we still merge this. I won't break previous versions and, though 
it won't fully work yet, it will at least allow to use CLion, while still 
building on a terminal.

-- 
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Add support for clang from XCode 8 in macOS

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add support for clang from XCode 8 in macOS
..


Patch Set 1: -Code-Review

-- 
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

[Dinesh Bhat (Code Review)]

Dinesh Bhat has posted comments on this change.

Change subject: [tools]: Keep the verbosity of CLI at FATAL and above
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

PS1, Line 215: FLAGS_minloglevel = google::GLOG_FATAL;
 :   }
 :   return show_help;
 : }
 : 
 : int main(int argc, char** argv) {
 :   bool show_help = ParseCommandLineFlags(, );
 :   FLAGS_logtostderr = true;
 :   k
> What it we could set up different level of logging for different components
@alexey: currently one of the gflags '--vmodule' lets us achieve what you are 
describing above. http://rpg.ifi.uzh.ch/docs/glog.html#verbose


-- 
To view, visit http://gerrit.cloudera.org:8080/4447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Add support for clang from XCode 8 in macOS

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add support for clang from XCode 8 in macOS
..


Patch Set 1: Code-Review-1

Hum, turns out there's a malloc issue with the new compiler. Sorting that out 
first.

-- 
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

[Dinesh Bhat (Code Review)]

Hello Dan Burkert, Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4440

to look at the new patch set (#7).

Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'
..

cli tool: List all tablets/replica_uuids with 'kudu table list'

I noticed that given a tablet or replica_uuid we need to execute
multiple nested commands and also need to correlate tablets and
their replica uuids and their relation to tables. Added a verbose
flag to 'kudu table list' to make this simpler.

This lists tablet/replica uuids irrespective of their states.

Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 89 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/4440/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

[Dinesh Bhat (Code Review)]

Dinesh Bhat has abandoned this change.

Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/4481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic2207c5984beaeda6d1dcef700e20f61d1f26e77
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

[Dinesh Bhat (Code Review)]

Hello Dan Burkert, Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4481

to review the following change.

Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'
..

cli tool: List all tablets/replica_uuids with 'kudu table list'

I noticed that given a tablet or replica_uuid we need to execute
multiple nested commands and also need to correlate tablets and
their replica uuids and their relation to tables. Added a verbose
flag to 'kudu table list' to make this simpler.

This lists tablet/replica uuids irrespective of their states.

Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7

ver 2

Change-Id: Ic2207c5984beaeda6d1dcef700e20f61d1f26e77
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 89 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/4481/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2207c5984beaeda6d1dcef700e20f61d1f26e77
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

[Dinesh Bhat (Code Review)]

Hello Dan Burkert, Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4440

to look at the new patch set (#6).

Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'
..

cli tool: List all tablets/replica_uuids with 'kudu table list'

I noticed that given a tablet or replica_uuid we need to execute
multiple nested commands and also need to correlate tablets and
their replica uuids and their relation to tables. Added a verbose
flag to 'kudu table list' to make this simpler.

Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 89 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/4440/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/integration-tests/alter_table-test.cc
File src/kudu/integration-tests/alter_table-test.cc:

Line 878
> Yep, it's passing.  I thought it would be enough to call inserted_idx_.Stor
Oh, that's clear -- what happens is that all the inserts are reported in the 
very end of the AlterTableTest::InserterThread() routine/method.  So, this test 
boiled down to making a single update in the very end, and it does not update a 
single row (since 'inserted_idx' points to the next index which would be 
inserted if the test continued to run).

OK, what I will do is the following:
1.  Return back periodic flushes every 50 rows (it works with the 
AUTO_FLUSH_BACKGROUND mode as well)
2.  Check that at least one update operations is applied to the session.

Let me know if you think some more sanity checks are required.


-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/integration-tests/alter_table-test.cc
File src/kudu/integration-tests/alter_table-test.cc:

Line 878
> again, you removed the update of the atomic variable. How is this test stil
Yep, it's passing.  I thought it would be enough to call inserted_idx_.Store() 
after flushing the operations.  I will clarify on this.


Line 914
> What I'm trying to figure out is why the test didn't fail on jenkins. Are w
Yes, you are right -- even without increment of the 'i' counter, the tests pass 
(at least in release, ASAN  and TSAN configurations).

>From what I can see, passing the tests with missing increment for the counter 
>is not surprising -- there isn't unique constraint on the second columns 
>(column idx 1), so there should not be an issue if the counter stays the same. 
> Basically, it means that counter is not crucial here.


-- 
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

[Ninad Shringarpure (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4480

to look at the new patch set (#2).

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..

[doc] KUDU-1627 Potentially Missing words in the quick start doc

Asciidoc was considering  as special markup for formatted
text and highlighting text in between.

Removed the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change
--
Added formatting as `{asterisk}` as suggested.

Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4480/1//COMMIT_MSG
Commit Message:

PS1, Line 9:   a
did you miss a letter in your commit message? ironic :)


http://gerrit.cloudera.org:8080/#/c/4480/1/docs/quickstart.adoc
File docs/quickstart.adoc:

PS1, Line 168:  *
would the asciidoc syntax: `{asterisk}` work? See 
http://asciidoctor.org/docs/user-manual/#charref-attributes


-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 3:

did you test this manually? I'm not sure whether jenkins even builds this 
(needs oauth) and pretty sure there are no tests.

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] Update kudu-lint to latest LLVM APIs

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Update kudu-lint to latest LLVM APIs
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4475/1/build-support/tools/kudu-lint/CMakeLists.txt
File build-support/tools/kudu-lint/CMakeLists.txt:

PS1, Line 22: # Find LLVM
> This isn't actually getting LLVM/clang from thirdparty, is it? I think we'd
You know, I'm not sure. It "just worked" on my machine and I dont really want 
to spend time to investigate it. At least this patch makes it more likely to 
work than it used to (which didn't work at all)


PS1, Line 63:   curses
:   dl
:   pthread
:   z
> Should we do some find_library() or find_package() calls for these?
I suppose so but again I dont think it's worth spending the time since this 
tool should probably go away.


http://gerrit.cloudera.org:8080/#/c/4475/1/build-support/tools/kudu-lint/README
File build-support/tools/kudu-lint/README:

PS1, Line 28: 3.8
> Nit: can we drop or reword this? Otherwise it's stale once clang in thirdpa
OK, I'll make a note that this tool isn't actively maintained and may not work 
with versions other than 3.8. (it seems to work with 3.9 for me as well though)


PS1, Line 44: -extra-arg
> Doesn't your change drop support for the -extra-arg argument?
nope, it's actually part of the standard tooling infrastructure now.


-- 
To view, visit http://gerrit.cloudera.org:8080/4475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c69be84cad56df71cc1bb2a3a89ada5d2167665
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Update kudu-lint to latest LLVM APIs

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Update kudu-lint to latest LLVM APIs
..


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4475/1/build-support/tools/kudu-lint/CMakeLists.txt
File build-support/tools/kudu-lint/CMakeLists.txt:

PS1, Line 22: # Find LLVM
This isn't actually getting LLVM/clang from thirdparty, is it? I think we'd 
need to alter CMAKE_MODULE_PATH for that to work.


PS1, Line 63:   curses
:   dl
:   pthread
:   z
Should we do some find_library() or find_package() calls for these?


PS1, Line 69: # Disable RTTI since we have to inherit from Clang-provided 
classes,
: # and Clang does not enable RTTI.
Maybe update this comment?


http://gerrit.cloudera.org:8080/#/c/4475/1/build-support/tools/kudu-lint/README
File build-support/tools/kudu-lint/README:

PS1, Line 28: 3.8
Nit: can we drop or reword this? Otherwise it's stale once clang in thirdparty 
is upgraded.


Line 43: $ find src -name \*.cc | xargs -n1 -P8 
./build-support/tools/kudu-lint/kudu-lint \
Shouldn't there be a make step after cmake? Or is the cmake step under 
"Running" somehow different than the one in "Building"?


PS1, Line 44: -extra-arg
Doesn't your change drop support for the -extra-arg argument?


-- 
To view, visit http://gerrit.cloudera.org:8080/4475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c69be84cad56df71cc1bb2a3a89ada5d2167665
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: c++ client: use entire deadline when retrying single-master DDL 
operations
..


c++ client: use entire deadline when retrying single-master DDL operations

I was perplexed when I saw a new test that uses TestWorkload timeout in
CreateTable() after only 10s when the default admin operation timeout is
30s. Turns out, it's an actual bug in the client.

Of course, if CreateTable() is retried after 10s of waiting, it'll get
either ServiceUnavailable() or AlreadyPresent() until KUDU-1537 is fixed.

Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Reviewed-on: http://gerrit.cloudera.org:8080/4435
Tested-by: Adar Dembo 
Reviewed-by: Jean-Daniel Cryans 
---
M src/kudu/client/client-internal.cc
M src/kudu/integration-tests/test_workload.cc
2 files changed, 11 insertions(+), 7 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Adar Dembo: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] Document Impala and Spark integration known issues & limitations

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Document Impala and Spark integration known issues & limitations
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4443/2/docs/developing.adoc
File docs/developing.adoc:

Line 163: - `NULL`, `NOT NULL`, `<>`, and `OR` predicates are not pushed to 
Kudu, and
> What about 'LIKE', 'IN' and 'BETWEEN' predicates?  Can they be pushed to Ku
Done, except for BETWEEN predicates since we do push those down.


http://gerrit.cloudera.org:8080/#/c/4443/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

Line 1104: - Impala can not create Kudu tables with bounded range partitions, 
and can not
> Is it possible to add hash partitions for already existing Kudu table in Im
No, Kudu itself doesn't support that.


-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

[Ninad Shringarpure (Code Review)]

Ninad Shringarpure has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4480

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..

[doc] KUDU-1627 Potentially Missing words in the quick start doc

Asciidoc was considering  as special markup for formatted
text and highlighting text in between.

Removed the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 

[kudu-CR](gh-pages) Add blog post for 1.0.0

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: Add blog post for 1.0.0
..


Add blog post for 1.0.0

Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
Reviewed-on: http://gerrit.cloudera.org:8080/4478
Reviewed-by: Dan Burkert 
Tested-by: Todd Lipcon 
---
A _posts/2016-09-20-apache-kudu-1-0-0-released.md
1 file changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR](gh-pages) Add blog post for 1.0.0

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Add blog post for 1.0.0
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add blog post for 1.0.0

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change.

Change subject: Add blog post for 1.0.0
..


Patch Set 1:

> Patch Set 1: -Code-Review -Verified

Dan found a typo

-- 
To view, visit http://gerrit.cloudera.org:8080/4478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add blog post for 1.0.0

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change.

Change subject: Add blog post for 1.0.0
..


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add blog post for 1.0.0

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Add blog post for 1.0.0
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4478/1/_posts/2016-09-20-apache-kudu-1-0-0-released.md
File _posts/2016-09-20-apache-kudu-1-0-0-released.md:

PS1, Line 21: 1
typo


-- 
To view, visit http://gerrit.cloudera.org:8080/4478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add blog post for 1.0.0

[Todd Lipcon (Code Review)]

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4478

Change subject: Add blog post for 1.0.0
..

Add blog post for 1.0.0

Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
---
A _posts/2016-09-20-apache-kudu-1-0-0-released.md
1 file changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/4478/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I052ee5dea2d7a4ef3942ca3f7f93085b86d9d82e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4477

to look at the new patch set (#2).

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND
..

[twitter-demo] use AUTO_FLUSH_BACKGROUND

Changed the twitter demo application to use sessions in
AUTO_FLUSH_BACKGROUND instead of sessions in MANUAL_FLUSH mode.

Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 57 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

[Ninad Shringarpure (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4450

to look at the new patch set (#4).

Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers 
on /tablet-servers
..

[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 27 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon