[kudu-CR] [webui] Add rudimentary balance info to /table
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10461 Change subject: [webui] Add rudimentary balance info to /table .. [webui] Add rudimentary balance info to /table See what it looks like at: https://github.com/wdberkeley/kudu/blob/rbweb/www/tablebalancesection.png Clicking the (?) pops out a quick explanation of what skew is, the same way as the (?)'s work on /config. Change-Id: Ieb6e29c10e7d5a3a48ea11438c54576664703bb9 --- M src/kudu/master/master_path_handlers.cc M www/table.mustache 2 files changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/10461/1 -- To view, visit http://gerrit.cloudera.org:8080/10461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb6e29c10e7d5a3a48ea11438c54576664703bb9 Gerrit-Change-Number: 10461 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley
[kudu-CR] [webui] Convert /tablets page to mustache
Will Berkeley has removed a vote on this change. Change subject: [webui] Convert /tablets page to mustache .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] [webui] Convert /tablets page to mustache
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Sat, 19 May 2018 06:14:20 + Gerrit-HasComments: No
[kudu-CR] [webui] Convert /tablets page to mustache
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 4: Code-Review+2 LGTM. Maybe it's worth to wait for Andrew's feedback. -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Sat, 19 May 2018 05:59:42 + Gerrit-HasComments: No
[kudu-CR] [rebalancing] Add a rebalancing algorithm
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Patch Set 10: Code-Review+1 (1 comment) Thank you for improving this patch! http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc File src/kudu/tools/rebalance-algo.cc: http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc@313 PS8, Line 313: yep, that was a typo, indeed -- To view, visit http://gerrit.cloudera.org:8080/10336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 Gerrit-Change-Number: 10336 Gerrit-PatchSet: 10 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Sat, 19 May 2018 05:50:44 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10443 to look at the new patch set (#2). Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky It's possible for a tablet to be RUNNING with working consensus but still have its "creating" transition live in the tablet manager. This makes deleting a tablet immediately after it is created flaky, so we simply retry. In addition to the original report from tablet_server-test.cc, I also saw a test in tablet_copy_client_session-itest.cc fail because of the same issue. Change-Id: Ib8dc7acc4c39f9d9b067a52df4bd6732f545a8de --- M src/kudu/integration-tests/tablet_copy_client_session-itest.cc M src/kudu/tserver/tablet_server-test.cc 2 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/10443/2 -- To view, visit http://gerrit.cloudera.org:8080/10443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8dc7acc4c39f9d9b067a52df4bd6732f545a8de Gerrit-Change-Number: 10443 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/10419/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10419/6//COMMIT_MSG@14 PS6, Line 14: Check failed: _s.ok() Bad status: IO error: Failed to load FS : layout: Could not lock block_manager_instance file: Could not : lock block_manager_instance file: lock block_manager_instance : file: Resource temporarily unavailable (error 35) This should be what it was in PS4 I think -- To view, visit http://gerrit.cloudera.org:8080/10419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0 Gerrit-Change-Number: 10419 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Sat, 19 May 2018 01:35:02 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10217 to look at the new patch set (#7). Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. KUDU-2191: HMS Metadata Consistency Check Tool This commit introduces a metadata consistency check CLI tool for Hive Metastore integration. It checks metadata (table ID, table name, Kudu master addresses, and colnum name and type) between Kudu and HMS, and report inconsistent metadata to the user if any. It adds test case using external mini cluster to ensure the tool works as expected. Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 --- M src/kudu/hms/hms_catalog.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_hms.cc 3 files changed, 276 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/10217/7 -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/kudu-tool-test.cc@1919 PS6, Line 1919: Status CreateLegacyHmsTable(HmsClient* client, > Might be more straightforward to split this into two methods, since there i Done http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@271 PS6, Line 271: > Might be easier to make a copy of 'hive_table', then call PopulateTable wit Done http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@293 PS6, Line 293: kudu_table > should this be 'unsynchronized tables:' Done http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@348 PS6, Line 348: > remove period to be consistent Done -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 19 May 2018 00:55:39 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2191: Metadata Upgrade Tool
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. KUDU-2191: Metadata Upgrade Tool This commit introduces an upgrade tool to allows backward compatibility. It provides support to upgrade the metadata format of existing Impala managed/external tables in HMS entries, as well as rename the existing tables in Kudu to adapt to the new naming rules. To run this tool, it requires to turn off the HMS integration feature. It adds test case using external mini cluster to ensure the upgrade tool works as expected. Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 Reviewed-on: http://gerrit.cloudera.org:8080/10075 Reviewed-by: Dan Burkert Tested-by: Kudu Jenkins --- M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java M src/kudu/client/client-test-util.cc M src/kudu/client/client-test-util.h M src/kudu/client/schema.h M src/kudu/common/common.proto M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_catalog.h M src/kudu/hms/hms_client.cc M src/kudu/hms/hms_client.h M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/mini-cluster/external_mini_cluster-test.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action.h A src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_test.cc M src/kudu/tools/tool_main.cc M src/kudu/tools/tool_test_util.cc M src/kudu/tools/tool_test_util.h 26 files changed, 775 insertions(+), 59 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 Gerrit-Change-Number: 10075 Gerrit-PatchSet: 21 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2191: Metadata Upgrade Tool
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 Gerrit-Change-Number: 10075 Gerrit-PatchSet: 20 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 19 May 2018 00:37:57 + Gerrit-HasComments: No
[kudu-CR] KUDU-2191: Metadata Upgrade Tool
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/10075 )
Change subject: KUDU-2191: Metadata Upgrade Tool
..
Patch Set 20:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/kudu-tool-test.cc@2043
PS19, Line 2043:
> repeated just below
Done
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@69
PS19, Line 69: DEFINE_bool(enable_input, true,
> I think true would be a better default here, since it's more annoying to ha
Done
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@124
PS19, Line 124: Found orphan table $
> nit: 'Found orphan table $0.$1...'
Done
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@159
PS19, Line 159: Failed to upgrade legacy Impala table
> I think something along the lines of
Done
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@165
PS19, Line 165: } else {
> I think this lambda is obscuring things a bit. For instance the SchemaFrom
Done
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@170
PS19, Line 170: while (!s.ok() && FLAGS_enable_input &&
> Would be good to have a test of this loop, just to have some coverage of th
Done
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@188
PS19, Line 188: if (!failures.empty()) {
> LOG(WARNING) the other errors so they get surfaced
Done
--
To view, visit http://gerrit.cloudera.org:8080/10075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3
Gerrit-Change-Number: 10075
Gerrit-PatchSet: 20
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Sat, 19 May 2018 00:15:34 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2191: Metadata Upgrade Tool
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#20). Change subject: KUDU-2191: Metadata Upgrade Tool .. KUDU-2191: Metadata Upgrade Tool This commit introduces an upgrade tool to allows backward compatibility. It provides support to upgrade the metadata format of existing Impala managed/external tables in HMS entries, as well as rename the existing tables in Kudu to adapt to the new naming rules. To run this tool, it requires to turn off the HMS integration feature. It adds test case using external mini cluster to ensure the upgrade tool works as expected. Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 --- M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java M src/kudu/client/client-test-util.cc M src/kudu/client/client-test-util.h M src/kudu/client/schema.h M src/kudu/common/common.proto M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_catalog.h M src/kudu/hms/hms_client.cc M src/kudu/hms/hms_client.h M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/mini-cluster/external_mini_cluster-test.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action.h A src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_test.cc M src/kudu/tools/tool_main.cc M src/kudu/tools/tool_test_util.cc M src/kudu/tools/tool_test_util.h 26 files changed, 775 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/10075/20 -- To view, visit http://gerrit.cloudera.org:8080/10075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 Gerrit-Change-Number: 10075 Gerrit-PatchSet: 20 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2314 Add wal and metadata directories info to FsReport
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10456 ) Change subject: KUDU-2314 Add wal and metadata directories info to FsReport .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10456/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/10456/1/src/kudu/fs/log_block_manager.cc@1825 PS1, Line 1825: // Record the wal and metadata directory paths > If this is the right place to insert wal and md dirs, maybe we need to do s I think it makes sense to handle this reporting at the FsManager layer instead, since it already knows about the WALs and metadata directories. Doing it in the block managers and piping these down here seems a bit odd since the block managers are kind of unrelated to WALs and metadata. -- To view, visit http://gerrit.cloudera.org:8080/10456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1fd362582ea84696db2aa64a83c6d3e86c78ae Gerrit-Change-Number: 10456 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 23:59:43 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Add wal and metadata directories info to FsReport
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10456 ) Change subject: KUDU-2314 Add wal and metadata directories info to FsReport .. Patch Set 1: (1 comment) There are probably quite a few things left to do for this patch. But I'm not sure if I'm on the right track, so I pushed this minimum patch and I'm waiting for suggestions. There's no dedicated test for now. And I verified the result by hand, only for FBM. (Cannot verify it on LBM cuz I'm using MAC) Thanks! http://gerrit.cloudera.org:8080/#/c/10456/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/10456/1/src/kudu/fs/log_block_manager.cc@1825 PS1, Line 1825: // Record the wal and metadata directory paths If this is the right place to insert wal and md dirs, maybe we need to do some path checking just like what's done in FsManager::Init? Same for FBM. -- To view, visit http://gerrit.cloudera.org:8080/10456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1fd362582ea84696db2aa64a83c6d3e86c78ae Gerrit-Change-Number: 10456 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 18 May 2018 23:44:59 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Add wal and metadata directories info to FsReport
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10456 Change subject: KUDU-2314 Add wal and metadata directories info to FsReport .. KUDU-2314 Add wal and metadata directories info to FsReport I added wal and metadata directories info in BlockManagerOptions just like what was done in FsManagerOptions, and refactored FBM, LBM, and related tests so that the these two directories info can be reflected on the FsReport. Change-Id: I3c1fd362582ea84696db2aa64a83c6d3e86c78ae --- M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/file_block_manager.cc M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc 8 files changed, 34 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/10456/1 -- To view, visit http://gerrit.cloudera.org:8080/10456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3c1fd362582ea84696db2aa64a83c6d3e86c78ae Gerrit-Change-Number: 10456 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang
[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10453 to look at the new patch set (#3). Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. [rebalancing] Add a randomized rebalancing algorithm test This adds a randomized test of the rebalancing algorithm. Instead of checking the specific sequence of moves is correct it expects the algorithm to balance the cluster within a certain number of moves, set generously high. I ran the randomized test about 1 times over several runs using dist_test.py, and saw no failures. Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 --- M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tools/rebalance_algo.h 2 files changed, 93 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/10453/3 -- To view, visit http://gerrit.cloudera.org:8080/10453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 Gerrit-Change-Number: 10453 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 1: Saw the same problem on another precommit: http://jenkins.kudu.apache.org/job/kudu-gerrit/13536/BUILD_TYPE=ASAN/testReport/junit/(root)/TabletCopyClientSessionITest/TestCopyFromCrashedSource/ -- To view, visit http://gerrit.cloudera.org:8080/10443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8dc7acc4c39f9d9b067a52df4bd6732f545a8de Gerrit-Change-Number: 10443 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 23:29:57 + Gerrit-HasComments: No
[kudu-CR] [webui] Convert /tablets page to mustache
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10422 to look at the new patch set (#4). Change subject: [webui] Convert /tablets page to mustache .. [webui] Convert /tablets page to mustache Originally I wanted to add a message to the /tablets page if there were no tablet replicas on the server, just so it wouldn't be blank, but here we are. Also, since our pre-commit test machines don't have templates, I had to adjust some tests to search for substrings of the JSON rather than the template-generated HTML. Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tserver_path_handlers.cc M src/kudu/tserver/tserver_path_handlers.h A www/tablets.mustache 4 files changed, 255 insertions(+), 179 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/10422/4 -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/kudu-tool-test.cc@1919 PS6, Line 1919: Status CreateHmsTable(bool legacy, Might be more straightforward to split this into two methods, since there isn't a lot of overlap and the arguments don't apply to all cases. http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@271 PS6, Line 271: bool schema_synced = true; Might be easier to make a copy of 'hive_table', then call PopulateTable with it, and compare it back to itself. If the tables are synced then they should be equal. Makes it a bit more resilient to changes to PopulateTable (like if we add additional fields or metadata to the entry). http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@293 PS6, Line 293: sync table should this be 'unsynchronized tables:' http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@348 PS6, Line 348: . remove period to be consistent -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 18 May 2018 23:10:13 + Gerrit-HasComments: Yes
[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10453/1/src/kudu/tools/rebalance_algo-test.cc File src/kudu/tools/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/10453/1/src/kudu/tools/rebalance_algo-test.cc@63 PS1, Line 63: using std::sort; > warning: using decl 'sort' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/10453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 Gerrit-Change-Number: 10453 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 22:58:05 + Gerrit-HasComments: Yes
[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10453/1/src/kudu/tools/rebalance_algo-test.cc File src/kudu/tools/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/10453/1/src/kudu/tools/rebalance_algo-test.cc@38 PS1, Line 38: #include "kudu/util/random.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/10453/1/src/kudu/tools/rebalance_algo-test.cc@672 PS1, Line 672: } > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done -- To view, visit http://gerrit.cloudera.org:8080/10453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 Gerrit-Change-Number: 10453 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 22:47:27 + Gerrit-HasComments: Yes
[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10453 to look at the new patch set (#2). Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. [rebalancing] Add a randomized rebalancing algorithm test This adds a randomized test of the rebalancing algorithm. Instead of checking the specific sequence of moves is correct it expects the algorithm to balance the cluster within a certain number of moves, set generously high. I ran the randomized test about 1 times over several runs using dist_test.py, and saw no failures. Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 --- M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tools/rebalance_algo.h 2 files changed, 93 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/10453/2 -- To view, visit http://gerrit.cloudera.org:8080/10453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 Gerrit-Change-Number: 10453 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] [webui] Convert /tablets page to mustache
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10422 to look at the new patch set (#3). Change subject: [webui] Convert /tablets page to mustache .. [webui] Convert /tablets page to mustache Originally I wanted to add a message to the /tablets page if there were no tablet replicas on the server, just so it wouldn't be blank, but here we are. Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tserver_path_handlers.cc M src/kudu/tserver/tserver_path_handlers.h A www/tablets.mustache 4 files changed, 244 insertions(+), 166 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/10422/3 -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] [webui] Convert /tablets page to mustache
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 2: > Hm.. To Alexey's point, maybe we should meet in the middle with > "tablet replicas" or something? "replicas" or "tablet replicas" are correct..."tablets" is an abuse of language. Developers know from context whether "tablet" means "tablet" or "replica", but not random users, so it's worth changing everything to be accurate. -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 21:50:46 + Gerrit-HasComments: No
[kudu-CR] [webui] Convert /tablets page to mustache
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 2: The test failures indicate the templates in www/ were not available, not a problem with the patch. I will retry the tests when I update the patch to fix the IWYU failure. -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 21:48:57 + Gerrit-HasComments: No
[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10453 Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. [rebalancing] Add a randomized rebalancing algorithm test This adds a randomized test of the rebalancing algorithm. Instead of checking the specific sequence of moves is correct it expects the algorithm to balance the cluster within a certain number of moves, set generously high. Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 --- M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tools/rebalance_algo.h 2 files changed, 93 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/10453/1 -- To view, visit http://gerrit.cloudera.org:8080/10453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 Gerrit-Change-Number: 10453 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley
[kudu-CR] [rebalancing] Add a rebalancing algorithm
Will Berkeley has uploaded a new patch set (#10) to the change originally created by Alexey Serbin. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. [rebalancing] Add a rebalancing algorithm This changelist introduces the high-level rebalancing algorithm and corresponding unit tests. It contains both an abstraction for rebalancing algorithms in general and an implementation of a greedy algorithm that rebalances a cluster by trying to equalize the number of replicas per tablet server for each table and for the cluster as a whole. The algorithm just identifies what moves should be done given an arrangment of a cluster. The 'engine' that performs moves will be added in a subsequent changelist. Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 --- M src/kudu/tools/CMakeLists.txt A src/kudu/tools/rebalance_algo-test.cc A src/kudu/tools/rebalance_algo.cc A src/kudu/tools/rebalance_algo.h 4 files changed, 1,162 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/10336/10 -- To view, visit http://gerrit.cloudera.org:8080/10336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 Gerrit-Change-Number: 10336 Gerrit-PatchSet: 10 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. KUDU-2035 Enable HTTP compression for all webserver's paths This patch enables HTTP compression when gzip compression is accepted by the client. Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Reviewed-on: http://gerrit.cloudera.org:8080/10332 Reviewed-by: Alexey Serbin Tested-by: Will Berkeley --- M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/server/webserver-test.cc M src/kudu/server/webserver.cc M src/kudu/util/curl_util.cc M src/kudu/util/curl_util.h 5 files changed, 113 insertions(+), 7 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Will Berkeley: Verified -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 14 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths
Will Berkeley has removed a vote on this change. Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 13 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 13 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 21:23:07 + Gerrit-HasComments: No
[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 13 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 21:18:34 + Gerrit-HasComments: No
[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG@22 PS5, Line 22: a > Maybe I'm too picky, but this bugs me. Can you rephrase as a statement rath Done -- To view, visit http://gerrit.cloudera.org:8080/10419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0 Gerrit-Change-Number: 10419 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 20:23:31 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10419 to look at the new patch set (#6). Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log This improvement removes the double "Could not lock.." and the double file paths and adds a descriptive message for the cause of the error. Before: Check failed: _s.ok() Bad status: IO error: Failed to load FS layout: Could not lock block_manager_instance file: Could not lock block_manager_instance file: lock block_manager_instance file: Resource temporarily unavailable (error 35) After: Check failed: _s.ok() Bad status: IO error: Failed to load FS layout: Could not lock block_manager_instance file. Make sure that Kudu is not already running and you are not trying to run Kudu with a different user than before: lock /private/tmp/kudu/ data/master/0/1/data/block_manager_instance: Resource temporarily unavailable (error 35) Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0 --- M src/kudu/fs/block_manager_util.cc M src/kudu/fs/data_dirs.cc 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/6 -- To view, visit http://gerrit.cloudera.org:8080/10419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0 Gerrit-Change-Number: 10419 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/util/curl_util.h@44 PS9, Line 44: // The optional param 'headers' holds additional headers. > No quite sure whether it was worth moving the comment from this place to th Opps sorry. It was a typo when I was trying to rebase. -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 9 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 19:42:17 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10332 to look at the new patch set (#13). Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. KUDU-2035 Enable HTTP compression for all webserver's paths This patch enables HTTP compression when gzip compression is accepted by the client. Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 --- M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/server/webserver-test.cc M src/kudu/server/webserver.cc M src/kudu/util/curl_util.cc M src/kudu/util/curl_util.h 5 files changed, 113 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10332/13 -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 13 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1889: support openssl 1.1
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: KUDU-1889: support openssl 1.1 .. Patch Set 4: Tested this on a Fedora 27 box I have laying around all all tests pass in debug mode. Should put us in a good spot for supporting EL8 when it's released. -- To view, visit http://gerrit.cloudera.org:8080/10436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1e1c57b5563d1a4cd926b4c4a9a3c271460be04 Gerrit-Change-Number: 10436 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 18 May 2018 19:28:15 + Gerrit-HasComments: No
[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/util/curl_util.h@44 PS9, Line 44: Status FetchURL(const std::string& url, No quite sure whether it was worth moving the comment from this place to the DoRequest() doc? Any rationale behind? -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 12 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 19:21:58 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1889: support openssl 1.1
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: KUDU-1889: support openssl 1.1 .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/ca/cert_management.cc@345 PS3, Line 345: if (!req->req_info || > I was mostly asking to understand why we bothered reaching into the struct Yep, it seems we have no other choice here but get rid of this ugly piece for 1.1.0. I would be happy to remove it for 1.0.0, but I need to double-check. Anyway, this part looks OK to me. http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/openssl_util.cc@117 PS3, Line 117: // In case the user's thread has left some error around, clear it. : ERR_clear_error(); : SCOPED_OPENSSL_NO_PENDING_ERRORS; > Okay. But we can't do that for 1.1; the library must be initialized before Ah, I see. There is no choice then :) -- To view, visit http://gerrit.cloudera.org:8080/10436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1e1c57b5563d1a4cd926b4c4a9a3c271460be04 Gerrit-Change-Number: 10436 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 18 May 2018 19:18:42 + Gerrit-HasComments: Yes
[kudu-CR] [rebalancing] Add a rebalancing algorithm
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Patch Set 9: Ah, just noticed that to fit with the current convention we should use _ to separate words in source file names, except when separating words identifying the file as a test file: rebalance_algo-test.cc rebalance_algo.h rebalance_algo.cc -- To view, visit http://gerrit.cloudera.org:8080/10336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 Gerrit-Change-Number: 10336 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 18:54:09 + Gerrit-HasComments: No
[kudu-CR] KUDU-2191: Metadata Upgrade Tool
Dan Burkert has posted comments on this change. (
http://gerrit.cloudera.org:8080/10075 )
Change subject: KUDU-2191: Metadata Upgrade Tool
..
Patch Set 19:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/kudu-tool-test.cc@2043
PS19, Line 2043: One with hive incompatible name.
repeated just below
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@69
PS19, Line 69: DEFINE_bool(enable_input, false,
I think true would be a better default here, since it's more annoying to have
to set flags in interactive mode than in batch mode typically.
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@124
PS19, Line 124: Find an orphan table
nit: 'Found orphan table $0.$1...'
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@159
PS19, Line 159: Table $0 already exists before upgrade
I think something along the lines of
'Failed to upgrade legacy Impala table 'foo.bar' (Kudu table name: 'fuzz')
because a Kudu table with name 'foo.bar' already exists'
would be more clear
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@165
PS19, Line 165: auto create_hms_table = [&](const string& name) -> Status
{
I think this lambda is obscuring things a bit. For instance the
SchemaFromKuduSchema call really only needs to happen once, and then after that
it's a pretty simple function call.
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@170
PS19, Line 170: while (!s.ok() && FLAGS_enable_input &&
Would be good to have a test of this loop, just to have some coverage of the
match, since it's brittle WRT Hive changing error messages.
http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@188
PS19, Line 188: return failures.front();
LOG(WARNING) the other errors so they get surfaced
--
To view, visit http://gerrit.cloudera.org:8080/10075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3
Gerrit-Change-Number: 10075
Gerrit-PatchSet: 19
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 18 May 2018 18:51:15 +
Gerrit-HasComments: Yes
[kudu-CR] [rebalancing] Add a rebalancing algorithm
Will Berkeley has uploaded a new patch set (#9) to the change originally created by Alexey Serbin. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. [rebalancing] Add a rebalancing algorithm This changelist introduces the high-level rebalancing algorithm and corresponding unit tests. It contains both an abstraction for rebalancing algorithms in general and an implementation of a greedy algorithm that rebalances a cluster by trying to equalize the number of replicas per tablet server for each table and for the cluster as a whole. The algorithm just identifies what moves should be done given an arrangment of a cluster. The 'engine' that performs moves will be added in a subsequent changelist. Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 --- M src/kudu/tools/CMakeLists.txt A src/kudu/tools/rebalance-algo-test.cc A src/kudu/tools/rebalance-algo.cc A src/kudu/tools/rebalance-algo.h 4 files changed, 1,162 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/10336/9 -- To view, visit http://gerrit.cloudera.org:8080/10336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 Gerrit-Change-Number: 10336 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2191: Metadata Upgrade Tool
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/10075 )
Change subject: KUDU-2191: Metadata Upgrade Tool
..
Patch Set 19: Verified+1
(9 comments)
Unrelated flaky test failure.
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/hms/hms_catalog.h
File src/kudu/hms/hms_catalog.h:
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/hms/hms_catalog.h@21
PS16, Line 21: #include
> looks like this is no longer needed? Curious that IWYU didn't catch this.
Yeah, it looks like this file is filtered to not run
IWYU?https://github.com/apache/kudu/blob/master/build-support/iwyu.py#L65
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/hms/hms_catalog.h@103
PS16, Line 103: SL gflags.
> I'd drop this last part of the sentence, I think it's clear from the signat
Done
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc@75
PS16, Line 75: "table should reside
in";
> Might be simpler to return the map instead of taking it as an out param.
Done
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc@121
PS16, Line 121: bool exist;
> Check the return status.
Done
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc@123
PS16, Line 123: if (!exist) {
> This could cause problems for installations which have two Kudu clusters po
Done
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc@135
PS16, Line 135:
> What do you think about re-organizing this so that the failure to upgrade a
Done
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc@146
PS16, Line 146: if (hms_table->parameters[HmsClient::kStorageHandlerKey]
==
> Maybe worth doing a check that 'new_table_name' isn't contained in table_na
Done
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc@148
PS16, Line 148: string new_table_name = Substitute("$0.$1",
hms_table->dbName, hms_table->tableName);
> Since this will probably land before the listener, just add a TODO for me t
Done
http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/tools/tool_action_hms.cc@156
PS16, Line 156:
client::SchemaFromKuduSchema(kudu_table->schema()));
> As we discussed offline, I think we should just assume the table has alread
Done
--
To view, visit http://gerrit.cloudera.org:8080/10075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3
Gerrit-Change-Number: 10075
Gerrit-PatchSet: 19
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 18 May 2018 18:29:43 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2191: Metadata Upgrade Tool
Hao Hao has removed a vote on this change. Change subject: KUDU-2191: Metadata Upgrade Tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 Gerrit-Change-Number: 10075 Gerrit-PatchSet: 19 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1889: support openssl 1.1
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: KUDU-1889: support openssl 1.1 .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/ca/cert_management.cc@345 PS3, Line 345: if (!req->req_info || > Whether or not it's safe is somewhat orthogonal: in OpenSSL 1.1 we can't ac I was mostly asking to understand why we bothered reaching into the struct in the old version. Sounds like it was due to a bug in X509_REQ_get_pubkey which has since been fixed. -- To view, visit http://gerrit.cloudera.org:8080/10436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1e1c57b5563d1a4cd926b4c4a9a3c271460be04 Gerrit-Change-Number: 10436 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 18 May 2018 17:54:22 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22 PS4, Line 22: n before?: lock block_manager_instance file: Resource : temporarily unavailabl > Oops sorry, I misunderstood your previous comment. So do you mean we don't Yup. http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG@14 PS5, Line 14: Could not : lock block_manager_instance file: lock block_manager_instance : file: Resource temporarily unavailable (error 35) Yeah the filename should be in here. http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG@22 PS5, Line 22: ?: Maybe I'm too picky, but this bugs me. Can you rephrase as a statement rather than a question, i.e. Make sure that... -- To view, visit http://gerrit.cloudera.org:8080/10419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0 Gerrit-Change-Number: 10419 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 16:27:46 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22 PS4, Line 22: n before?: lock block_manager_instance file: Resource : temporarily unavailabl > Oops sorry, I misunderstood your previous comment. So do you mean we don't Yep, exactly! Sorry I wasn't clearer. -- To view, visit http://gerrit.cloudera.org:8080/10419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0 Gerrit-Change-Number: 10419 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 16:27:35 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22 PS4, Line 22: Could not lock /private/tmp/kudu/data/master/0/2/data/ : block_manager_instance > I don't see the changes in PS5. Also from PS5's commit message, it seems li Oops sorry, I misunderstood your previous comment. So do you mean we don't need to expose the filename in upper log layer cuz there's lower level log that also prints out this filename? So will the log be like: Check failed: _s.ok() Bad status: IO error: Failed to load FS layout: Could not lock the block_manager_instance. Is Kudu already running or are you trying to run Kudu with a different user than before?: lock /private/tmp/kudu/data/master/0/2/data/block_manager_instance: Resourcetemporarily unavailable (error 35) -- To view, visit http://gerrit.cloudera.org:8080/10419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0 Gerrit-Change-Number: 10419 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 16:18:41 + Gerrit-HasComments: Yes
[kudu-CR] WIP [rebalancing] high-level rebalancing algorithm
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: WIP [rebalancing] high-level rebalancing algorithm .. Patch Set 3: (2 comments) FYI Alexey I am revising this patch while you work on the "engine" part, as we spoke about. http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc File src/kudu/tools/rebalance-algo.cc: http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc@217 PS8, Line 217: } This isn't the max server skew, it's the number of replicas on the most loaded server. http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc@244 PS8, Line 244: auto min_range = cnt_by_server.equal_r This is the same as checking if max_table_skew == 0 above. -- To view, visit http://gerrit.cloudera.org:8080/10336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 Gerrit-Change-Number: 10336 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 18 May 2018 08:40:58 + Gerrit-HasComments: Yes
