[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

[Anupama Gupta (Code Review)]

Anupama Gupta has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10983 )

Change subject: KUDU-1291. Efficiently support predicates on non-prefix key 
components
..


Patch Set 15:

(7 comments)

I have addressed all the open comments. PTAL.

http://gerrit.cloudera.org:8080/#/c/10983/10/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:

http://gerrit.cloudera.org:8080/#/c/10983/10/src/kudu/cfile/cfile_reader.h@59
PS10, Line 59:
> Yep, it would be nice to have a test with super-wide primary key (multiple
Added a test case where the encoded primary key size is equal to the max 
allowable encoded PK size (16MB), stored as max_encoded_key_size_bytes.

Also, verified that any insertions that violate this size constraint results in 
failure.


http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc
File src/kudu/tablet/cfile_set.cc:

http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc@444
PS12, Line 444: col_id =
> If that's something we expect to happen, I would simply disable the skip sc
Done


http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc@462
PS12, Line 462:   }
  :
  :   if (nonfirst_key_pred_exists) {
  : use_skip_scan_ = true;
  :
  : // Store the predicate column id.
  : skip_scan_predicate_column_id_ = min_col_id;
  :
  :
> I think it's better to keep it as Andrew requested.  After some considerati
Sure. Done.


http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/cfile_set.cc
File src/kudu/tablet/cfile_set.cc:

http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/cfile_set.cc@414
PS14, Line 414: id CFileSet::Ite
> nit: since this is not to change in the code below, add 'const'
Done


http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/cfile_set.cc@576
PS14, Line 576:
> style nit: keep the brace with the name of the method
Done


http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/cfile_set.cc@699
PS14, Line 699:
  :   skip_scan_num_seeks_++
> I think it makes sense to introduce a metric to capture cases when skip sca
Added this info in VLOG(1).


http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/index_skipscan-test.cc
File src/kudu/tablet/index_skipscan-test.cc:

http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/index_skipscan-test.cc@189
PS14, Line 189: break;
  :   }
  :   case kMaxSizedEncodedKey: {
  : CHECK_OK(builder.AddKeyColumn("P1", STRING));
  : CHECK_OK(builder.AddKeyColumn
> nit: all there might be constexpr:
Done



--
To view, visit http://gerrit.cloudera.org:8080/10983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f
Gerrit-Change-Number: 10983
Gerrit-PatchSet: 15
Gerrit-Owner: Anupama Gupta 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Anupama Gupta 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 15 Aug 2018 04:55:52 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

[Anupama Gupta (Code Review)]

Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10983

to look at the new patch set (#15).

Change subject: KUDU-1291. Efficiently support predicates on non-prefix key 
components
..

KUDU-1291. Efficiently support predicates on non-prefix key components

This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.

This feature uses the following approach:
1. Seek at the first unique prefix key in the ad-hoc index tree.
2. Seek to the relevant entry corresponding to the unique prefix key
   found in 1. and the predicate value on the suffix key column.
3. To handle the case where multiple entries exist with respect to
   a unique prefix key, store the upper bound index of these entries.
4. Repeat steps 1-3, till all the unique prefix keys are scanned.

Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
10 files changed, 1,069 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/10983/15
--
To view, visit http://gerrit.cloudera.org:8080/10983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f
Gerrit-Change-Number: 10983
Gerrit-PatchSet: 15
Gerrit-Owner: Anupama Gupta 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Anupama Gupta 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2538: [docs] Document how to manually recover from Cfile corruption

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11218 )

Change subject: KUDU-2538: [docs] Document how to manually recover from Cfile 
corruption
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc@655
PS2, Line 655: remote_replica delete
> nit: surround in backticks
Done


http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc@667
PS2, Line 667: unsafe_replace_tablet
> nit: surround in backticks
Done


http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc@666
PS2, Line 666: You can repair the table by replacing the corrupt tablet with an 
empty one using the
 : 
link:https://kudu.apache.org/docs/command_line_tools_reference.html#tablet-unsafe_replace_tablet[unsafe_replace_tablet
 tool].
> nit: hmm this seems kind of tricky since we're not actually repairing the t
Done



--
To view, visit http://gerrit.cloudera.org:8080/11218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
Gerrit-Change-Number: 11218
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 15 Aug 2018 03:17:30 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2538: [docs] Document how to manually recover from Cfile corruption

[Grant Henke (Code Review)]

Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11218

to look at the new patch set (#3).

Change subject: KUDU-2538: [docs] Document how to manually recover from Cfile 
corruption
..

KUDU-2538: [docs] Document how to manually recover from Cfile corruption

Adds troubleshooting documentation showing the
steps to manually recover from Cfile corruption.

Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
---
M docs/troubleshooting.adoc
1 file changed, 40 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/11218/3
--
To view, visit http://gerrit.cloudera.org:8080/11218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
Gerrit-Change-Number: 11218
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2538: [docs] Document how to manually recover from Cfile corruption

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11218 )

Change subject: KUDU-2538: [docs] Document how to manually recover from Cfile 
corruption
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc@655
PS2, Line 655: remote_replica delete
nit: surround in backticks


http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc@667
PS2, Line 667: unsafe_replace_tablet
nit: surround in backticks


http://gerrit.cloudera.org:8080/#/c/11218/2/docs/troubleshooting.adoc@666
PS2, Line 666: You can repair the table by replacing the corrupt tablet with an 
empty one using the
 : 
link:https://kudu.apache.org/docs/command_line_tools_reference.html#tablet-unsafe_replace_tablet[unsafe_replace_tablet
 tool].
nit: hmm this seems kind of tricky since we're not actually repairing the 
table. Perhaps rephrase to something along the lines of: "If data loss has 
occurred, queries run against the table may fail. To restore reads to this 
table, run the `unsafe_replace_tablet` tool." ?



--
To view, visit http://gerrit.cloudera.org:8080/11218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
Gerrit-Change-Number: 11218
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 15 Aug 2018 02:43:38 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2538: [docs] Document how to manually recover from Cfile corruption

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11218 )

Change subject: KUDU-2538: [docs] Document how to manually recover from Cfile 
corruption
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/11218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
Gerrit-Change-Number: 11218
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 15 Aug 2018 02:32:33 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2538: [docs] Document how to manually recover from Cfile corruption

[Grant Henke (Code Review)]

Grant Henke has removed a vote on this change.

Change subject: KUDU-2538: [docs] Document how to manually recover from Cfile 
corruption
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
Gerrit-Change-Number: 11218
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [master] replica selection honors placement policy

[Alexey Serbin (Code Review)]

Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11207

to look at the new patch set (#3).

Change subject: [master] replica selection honors placement policy
..

[master] replica selection honors placement policy

This patch introduces placement policy into the catalog manager's
replica selection process.  The replica selection logic
is factored out into the new PlacementPolicy class.

Added few test scenarios for the new functionality.

Change-Id: I4169098abf17d5591d4c1675561afc15b5477fcd
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
A src/kudu/master/placement_policy-test.cc
A src/kudu/master/placement_policy.cc
A src/kudu/master/placement_policy.h
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
10 files changed, 1,052 insertions(+), 187 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/11207/3
--
To view, visit http://gerrit.cloudera.org:8080/11207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4169098abf17d5591d4c1675561afc15b5477fcd
Gerrit-Change-Number: 11207
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] Implement BloomFilter Predicate in server side.

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11100 )

Change subject: Implement BloomFilter Predicate in server side.
..


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h
File src/kudu/common/column_predicate.h:

http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h@67
PS4, Line 67:   InBloomFilter,
nit: I think 'BloomFilter' is shorter and just as clear.  The 'In' part of 
InList comes from the SQL IN syntax, which isn't at play here.


http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h@286
PS4, Line 286:   // Returns the nhash of bloom filter if this is a bloom filter 
predicate.
Add a space above.  Is the comment correct, what's 'nhash'?


http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc
File src/kudu/common/column_predicate.cc:

http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@42
PS4, Line 42: ColumnPredicate::ColumnPredicate(PredicateType predicate_type,
(meta-comment) If I understand the changes to this file correctly, Range 
predicates can now have an attached set of bloom filters?  If so I think this 
may be the wrong way to go about it, instead I think it would be cleaner to say 
that BloomFilter predicates can have an optional upper and lower bound.  In 
other words, if the bfs vector is non-empty then it must be a BloomFilter 
predicate type.


http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@460
PS4, Line 460: for (auto value : values_) {
Simplify with std::copy_if or something equivalent.


http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@563
PS4, Line 563:   for (auto value : values_) {
likewise



-- 
To view, visit http://gerrit.cloudera.org:8080/11100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62c2de42667d0255d94e19db773240f7f9ee636c
Gerrit-Change-Number: 11100
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: ZhangYao 
Gerrit-Comment-Date: Wed, 15 Aug 2018 00:32:30 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11077 )

Change subject: [KUDU-2521] Java Implementation for BloomFilter
..


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11077/1/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java
File java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java:

http://gerrit.cloudera.org:8080/#/c/11077/1/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java@139
PS1, Line 139: obe.mixH
> I think it's necessary to make the hashing consistent with the blooms on PK 
> lookups in TServer.

Could you expand on why it's necessary to make the PK bloom filters use the 
same hash function as this predicate bloom filter?  Off the top of my head I'm 
not sure what the necessity or even upside of doing that would be (besides code 
re-use, but as pointed out we could get code-reuse in the client if we went 
with murmur).  We currently have the ability (in theory) of being flexible 
about what hash function we use, which means we can switch out city hash in the 
future if we want.  I'd be reluctant to lose that flexibility because we add a 
new mostly unrelated public API.

Related note - what do you think about making this API be 'hash agile' from the 
start?  E.g. build in a hash algorithm selector from the start, using feature 
flags or something similar.  It would be fine to have just a single 
implementation (murmur or city) at first.


http://gerrit.cloudera.org:8080/#/c/11077/4/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java
File java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java:

http://gerrit.cloudera.org:8080/#/c/11077/4/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java@29
PS4, Line 29: public class BloomFilter {
The public API surface are of this class is much bigger than necessary. In 
particular the membership methods and the BloomKeyProbe class aren't necessary. 
 I'm thinking something along these lines (modeled more closely on the Guava 
BloomFilter class):

public class BloomFilter {

  public BloomFilter(int expectedInsertions, double fpp) { .. }

  public BloomFilter(int size, double fpp) { .. }

  public put(int value) { .. }

  public put(long value) { .. }

  ...

}


http://gerrit.cloudera.org:8080/#/c/11077/4/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java@57
PS4, Line 57:   bytes = new byte[]{1};
Lots of shortlived allocations happening here.  Given that the new hash API 
appears to take offset and len parameters, maybe the BloomFilter could allocate 
a length 8 byte[] upfront and just use that?


http://gerrit.cloudera.org:8080/#/c/11077/4/java/kudu-client/src/main/java/org/apache/kudu/util/CityHash.java
File java/kudu-client/src/main/java/org/apache/kudu/util/CityHash.java:

http://gerrit.cloudera.org:8080/#/c/11077/4/java/kudu-client/src/main/java/org/apache/kudu/util/CityHash.java@18
PS4, Line 18: package org.apache.kudu.util;
Was this implementation copied from somewhere?  Please include a comment if so, 
and retain the original header.


http://gerrit.cloudera.org:8080/#/c/11077/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java:

http://gerrit.cloudera.org:8080/#/c/11077/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java@38
PS4, Line 38: ,n
missing space here and below



--
To view, visit http://gerrit.cloudera.org:8080/11077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50c5dce4d24707c068c5ab94e5d311b12b3251b8
Gerrit-Change-Number: 11077
Gerrit-PatchSet: 4
Gerrit-Owner: jinxing6...@126.com
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: jinxing6...@126.com
Gerrit-Comment-Date: Tue, 14 Aug 2018 23:58:44 +
Gerrit-HasComments: Yes

[kudu-CR](branch-1.7.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11219 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..

KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

See the associated JIRA for bug details. The fix follows a slightly
different approach than suggested by Todd, namely initialization of the
RPC tracker in the RPC context is delayed until after authorization.
This allows the error path code to remain unchanged, and allows the one
caller of the RpcContext constructor to be slightly cleaned up.

Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Reviewed-on: http://gerrit.cloudera.org:8080/11216
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/11219
Reviewed-by: Adar Dembo 
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/service_if.cc
4 files changed, 47 insertions(+), 22 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/11219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11219
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.6.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11220 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..

KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

See the associated JIRA for bug details. The fix follows a slightly
different approach than suggested by Todd, namely initialization of the
RPC tracker in the RPC context is delayed until after authorization.
This allows the error path code to remain unchanged, and allows the one
caller of the RpcContext constructor to be slightly cleaned up.

Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Reviewed-on: http://gerrit.cloudera.org:8080/11216
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/11220
Reviewed-by: Adar Dembo 
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/service_if.cc
4 files changed, 47 insertions(+), 22 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/11220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11220
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2538: [docs] Document how to manually recover from Cfile corruption

[Grant Henke (Code Review)]

Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11218

to look at the new patch set (#2).

Change subject: KUDU-2538: [docs] Document how to manually recover from Cfile 
corruption
..

KUDU-2538: [docs] Document how to manually recover from Cfile corruption

Adds troubleshooting documentation showing the
steps to manually recover from Cfile corruption.

Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
---
M docs/troubleshooting.adoc
1 file changed, 39 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/11218/2
--
To view, visit http://gerrit.cloudera.org:8080/11218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
Gerrit-Change-Number: 11218
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR](branch-1.7.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11219 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11219
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 21:39:51 +
Gerrit-HasComments: No

[kudu-CR](branch-1.6.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11220 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11220
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 21:32:51 +
Gerrit-HasComments: No

[kudu-CR](branch-1.7.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11219 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11219
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 21:32:28 +
Gerrit-HasComments: No

[kudu-CR](branch-1.7.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11219 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 1:

Had a merge conflict on a formatting change, so had to do the cherry-pick 
manually.  Should be no functional changes between this and the master version.


--
To view, visit http://gerrit.cloudera.org:8080/11219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11219
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 21:31:23 +
Gerrit-HasComments: No

[kudu-CR](branch-1.7.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/11219

to review the following change.


Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..

KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

See the associated JIRA for bug details. The fix follows a slightly
different approach than suggested by Todd, namely initialization of the
RPC tracker in the RPC context is delayed until after authorization.
This allows the error path code to remain unchanged, and allows the one
caller of the RpcContext constructor to be slightly cleaned up.

Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Reviewed-on: http://gerrit.cloudera.org:8080/11216
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/service_if.cc
4 files changed, 47 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/11219/1
--
To view, visit http://gerrit.cloudera.org:8080/11219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11219
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.6.x) KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Dan Burkert has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11220


Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..

KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

See the associated JIRA for bug details. The fix follows a slightly
different approach than suggested by Todd, namely initialization of the
RPC tracker in the RPC context is delayed until after authorization.
This allows the error path code to remain unchanged, and allows the one
caller of the RpcContext constructor to be slightly cleaned up.

Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Reviewed-on: http://gerrit.cloudera.org:8080/11216
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/service_if.cc
4 files changed, 47 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/11220/1
--
To view, visit http://gerrit.cloudera.org:8080/11220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11220
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 

[kudu-CR] KUDU-2538: [docs] Document how to manually recover from Cfile corruption

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11218


Change subject: KUDU-2538: [docs] Document how to manually recover from Cfile 
corruption
..

KUDU-2538: [docs] Document how to manually recover from Cfile corruption

Adds troubleshooting documentation showing the
steps to manually recover from Cfile corruption.

Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
---
M docs/troubleshooting.adoc
1 file changed, 39 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/11218/1
--
To view, visit http://gerrit.cloudera.org:8080/11218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieefd472bef104921de7cab442fd49ab32c0fe81b
Gerrit-Change-Number: 11218
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 

[kudu-CR] KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11216 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..

KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

See the associated JIRA for bug details. The fix follows a slightly
different approach than suggested by Todd, namely initialization of the
RPC tracker in the RPC context is delayed until after authorization.
This allows the error path code to remain unchanged, and allows the one
caller of the RpcContext constructor to be slightly cleaned up.

Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Reviewed-on: http://gerrit.cloudera.org:8080/11216
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/service_if.cc
4 files changed, 47 insertions(+), 22 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/11216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR](gh-pages) [site] Add http to https redirect

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11162 )

Change subject: [site] Add http to https redirect
..


Patch Set 1:

> Patch Set 1:
>
> > Patch Set 1: Code-Review-1
> >
> > I know I was the one that suggested this approach, however after doing more 
> > research I think it's the wrong way to do it. There is a good article by 
> > Google about how to enable HTTPS @ 
> > https://developers.google.com/web/fundamentals/security/encrypt-in-transit/enable-https
> >
> > In the section of that article titled "Turn on Strict Transport Security 
> > and secure cookies" they recommend using HSTS 
> >  instead of a 
> > 301 redirect, and in the section "Redirect HTTP to HTTPS" they recommend 
> > using https://...;> tags in the page header to 
> > gently redirect search engines to using https.
>
> The HSTS approach is definitely something I'd like to look into, but as it's 
> something that's hard to go back once enabled (we need to wait until max-age 
> secnods), I thought this should be added as a next step once we are 
> reasonably certain it's working fine for everyone (we can ask around on Slack 
> and the mailing lists maybe).
>
> As for the canonical link approach, it's nice to have for search engines, but 
> it doesn't actually redirect, so 301 still should be used here. The Google 
> article you linked seems inconsistent about this point too, maybe it has been 
> updated at some point, but they failed to update all references:
>
> "This defeats attacks such as SSL Stripping, and also avoids the round-trip 
> cost of the 301 redirect that we enabled in Redirect HTTP to HTTPS." <- it 
> talks about 301 redirect instead of the canonical link tag.
>
> The HSTS RFC itself says a permanent redirect such as response code 301 
> SHOULD be used when the request is made over a non-secure HTTP transport[1]. 
> It also says the STS header MUST NOT be included on such requests, only on 
> HTTPS.
>
> >
> > Sending a hard 301 redirect from http seems undesirable because it locks 
> > out clients that can't speak https, whereas the above approaches are both 
> > backward-and forward-compatible.
>
> You're right that it might lock out some clients with the current settings. 
> According to Qualys SSL Labs tests, there's a protocol mismatch with IE 10 
> and earlier, Android 4.3 and earlier, and Safari 6.0.4 and earlier[2]. Do we 
> have any data on whether we have any visitors using any of these browsers? 
> I'd assume it would be near impossible to use any modern websites with them, 
> so I'm not sure whether we need to take them into consideration. I imagine 
> enabling old cipher suites/protocols they understand would result in a very 
> low grade on this report.
>
> Anyway, if we want to make kudu.apache.org accessible on these old browsers, 
> I believe TLS 1.0, and RSA with 3DES should be enabled instead of allowing 
> everyone else to access the page over non-secure HTTP.
>
> [1] https://tools.ietf.org/html/rfc6797#section-7.2
> [2] 
> https://www.ssllabs.com/ssltest/analyze.html?d=kudu.apache.org=40.79.78.1

Yeah I'd err on the side of not enabling HSTS at this point.  Perhaps it's just 
my inexperience with these web technologiges, but the known cons as well as 
unknowns definitely outweigh the pros. It should always be possible to enable 
HSTS in the future.


--
To view, visit http://gerrit.cloudera.org:8080/11162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a060a419466ec4b16840347d387262ca8a4199
Gerrit-Change-Number: 11162
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:58:04 +
Gerrit-HasComments: No

[kudu-CR] [hms] disable direct SQL in MiniHms

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11198 )

Change subject: [hms] disable direct SQL in MiniHms
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11198/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/11198/1/src/kudu/hms/mini_hms.cc@256
PS1, Line 256: hive.metastore.try.direct.sql
I think the idea here is that direct SQL never works with derby, right?  If so, 
it would be good to add a note to the comment above to that effect, ideally 
with a link to supporting Hive documentation if that exists.



--
To view, visit http://gerrit.cloudera.org:8080/11198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If48fb2551fae739e2f1548bb5ca2187364064703
Gerrit-Change-Number: 11198
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:55:13 +
Gerrit-HasComments: Yes

[kudu-CR] [hms] disable direct SQL in MiniHms

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11198 )

Change subject: [hms] disable direct SQL in MiniHms
..


Patch Set 1:

+1 on the premise of this patch, but the test failures look worrying.


--
To view, visit http://gerrit.cloudera.org:8080/11198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If48fb2551fae739e2f1548bb5ca2187364064703
Gerrit-Change-Number: 11198
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:54:27 +
Gerrit-HasComments: No

[kudu-CR] Add delete external catalogs flag to table delete tool

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11197 )

Change subject: Add delete_external_catalogs flag to table delete tool
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/client/client.h@547
PS1, Line 547:   Status KUDU_NO_EXPORT DeleteTableWithOption(const std::string& 
table_name,
Could this just be called DeleteTable?  'WithOption' implies there would be an 
options struct or something similar.


http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/client/client.cc
File src/kudu/client/client.cc:

http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/client/client.cc@400
PS1, Line 400:   return data_->DeleteTable(this, table_name, deadline);
Could simplify this by forwarding to the new API.


http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/master/master.proto
File src/kudu/master/master.proto:

http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/master/master.proto@449
PS1, Line 449:   optional bool delete_external_catalogs = 2 [default = true];
What do you think about unifying the names of 'delete_external_catalogs' and 
'alter_external_catalogs', perhaps to 'modify_external_catalogs'?  I think it 
may be easier to understand that way, since they affect the DDL ops in the same 
way.  It would also mean only one CLI flag is needed.


http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/tools/tool_action_table.cc@129
PS1, Line 129:   return client->DeleteTableWithOption(table_name, 
FLAGS_delete_external_catalogs);
Add a CLI test.



--
To view, visit http://gerrit.cloudera.org:8080/11197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a128fb53c974a5c839786204d56408681b434e8
Gerrit-Change-Number: 11197
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:53:50 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] add links required by ASF

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11209 )

Change subject: [site] add links required by ASF
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: https://www.apache.org/security/; 
target="_blank">Security
> Interesting. I see that we handle community by having a community page that
It feels a bit weird to me to create a landing page to list 4 links so mobile 
viewers can look into it. Do you have any suggestions about what could be there 
on the ASF landing page aside from the links?



--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:52:11 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Switch to sha512 checksum for releases

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11217 )

Change subject: [build] Switch to sha512 checksum for releases
..


Patch Set 1:

(1 comment)

> Patch Set 1:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/11217/1/build-support/build_source_release.py
File build-support/build_source_release.py:

http://gerrit.cloudera.org:8080/#/c/11217/1/build-support/build_source_release.py@134
PS1, Line 134:
> Sorry, should've clarified in the commit message...
Should I put this in the commit message by the way?



--
To view, visit http://gerrit.cloudera.org:8080/11217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7646b4559bf39d2415b32a1dcdd4cd7ecde41531
Gerrit-Change-Number: 11217
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:50:30 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Switch to sha512 checksum for releases

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11217 )

Change subject: [build] Switch to sha512 checksum for releases
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11217/1/build-support/build_source_release.py
File build-support/build_source_release.py:

http://gerrit.cloudera.org:8080/#/c/11217/1/build-support/build_source_release.py@134
PS1, Line 134:
> why switch away from a tab here? I think the tabs made things nicely line u
Sorry, should've clarified in the commit message...

On MacOS shasum the tab version doesn't work. I verified the double white space 
on Linux as well and it works on both OSes. The Linux version of sha512sum also 
uses double-space to separate the checksum from the filename:

$ sha512sum apache-kudu-1.8.0-SNAPSHOT.tar.gz | xxd
# ...
070: 3065 3132 3666 3463 3664 6332 3065 6338  0e126f4c6dc20ec8
080: 2020 6170 6163 6865 2d6b 7564 752d 312eapache-kudu-1.
# ...



--
To view, visit http://gerrit.cloudera.org:8080/11217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7646b4559bf39d2415b32a1dcdd4cd7ecde41531
Gerrit-Change-Number: 11217
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:50:06 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11216 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:42:57 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11216 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 2:

(1 comment)

> Patch Set 1: Code-Review+2
>
> Are you going to backport this to all affected branches?

I'm planning on backporting back at least two releases.  If you think we should 
do more let me know, I don't expect there to be conflicts.

http://gerrit.cloudera.org:8080/#/c/11216/1/src/kudu/rpc/service_if.cc
File src/kudu/rpc/service_if.cc:

http://gerrit.cloudera.org:8080/#/c/11216/1/src/kudu/rpc/service_if.cc@121
PS1, Line 121: ResultTracker::RpcState state = ctx->result_tracker(
> nit while you are here: is this variable needed?
Done



--
To view, visit http://gerrit.cloudera.org:8080/11216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:38:38 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11216

to look at the new patch set (#2).

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..

KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

See the associated JIRA for bug details. The fix follows a slightly
different approach than suggested by Todd, namely initialization of the
RPC tracker in the RPC context is delayed until after authorization.
This allows the error path code to remain unchanged, and allows the one
caller of the RpcContext constructor to be slightly cleaned up.

Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/service_if.cc
4 files changed, 47 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11216/2
--
To view, visit http://gerrit.cloudera.org:8080/11216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11216 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11216/1/src/kudu/rpc/service_if.cc
File src/kudu/rpc/service_if.cc:

http://gerrit.cloudera.org:8080/#/c/11216/1/src/kudu/rpc/service_if.cc@121
PS1, Line 121: RequestIdPB request_id(call->header().request_id());
nit while you are here: is this variable needed?



--
To view, visit http://gerrit.cloudera.org:8080/11216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:31:23 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11216 )

Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..


Patch Set 1: Code-Review+2

Are you going to backport this to all affected branches?


--
To view, visit http://gerrit.cloudera.org:8080/11216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:30:54 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10983 )

Change subject: KUDU-1291. Efficiently support predicates on non-prefix key 
components
..


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10983/10/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:

http://gerrit.cloudera.org:8080/#/c/10983/10/src/kudu/cfile/cfile_reader.h@59
PS10, Line 59: static const int kEncodedCompositeKeyMaxSize =
> Can we test what happens when someone violates this?
Yep, it would be nice to have a test with super-wide primary key (multiple 
columns, big cells) and try to run scans with skip scan enabled.  As for the 
desired behavior, at least tservers should not crash, and the logic of the skip 
scan optimizations should behave predictably, not outright failing the whole 
scan operation.


http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/cfile_set.cc
File src/kudu/tablet/cfile_set.cc:

http://gerrit.cloudera.org:8080/#/c/10983/14/src/kudu/tablet/cfile_set.cc@699
PS14, Line 699: use_skip_scan_ = false;
  : return Status::OK();
I think it makes sense to introduce a metric to capture cases when skip scan 
decided to bail due to the seek cutoff condition.

For examples, please looks for examples in the code: check for  
METRIC_DEFINE_gauge_int64 and INSTANTIATE_METRIC patterns.



--
To view, visit http://gerrit.cloudera.org:8080/10983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f
Gerrit-Change-Number: 10983
Gerrit-PatchSet: 14
Gerrit-Owner: Anupama Gupta 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Anupama Gupta 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:18:45 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] add links required by ASF

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11209 )

Change subject: [site] add links required by ASF
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: https://www.apache.org/security/; 
target="_blank">Security
> Actually that's how I tried first, but then it wouldn't show on mobile. I c
Interesting. I see that we handle community by having a community page that is 
linked to on mobile. Maybe we could add an Apache landing page? All of these 
links at the top bar feels like a lot even though it fits. I know it's a 
stylistic choice, so I am okay to be overridden on this.



--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:16:28 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Switch to sha512 checksum for releases

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11217 )

Change subject: [build] Switch to sha512 checksum for releases
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11217/1/build-support/build_source_release.py
File build-support/build_source_release.py:

http://gerrit.cloudera.org:8080/#/c/11217/1/build-support/build_source_release.py@134
PS1, Line 134:
why switch away from a tab here? I think the tabs made things nicely line up in 
the output. Do we need two tabs elsewhere so it lines up?



--
To view, visit http://gerrit.cloudera.org:8080/11217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7646b4559bf39d2415b32a1dcdd4cd7ecde41531
Gerrit-Change-Number: 11217
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:07:59 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Switch to sha512 checksum for releases

[Attila Bukor (Code Review)]

Hello Grant Henke, Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/11217

to review the following change.


Change subject: [build] Switch to sha512 checksum for releases
..

[build] Switch to sha512 checksum for releases

According to the current release distribution guide[1] the checksum file
SHOULD be SHA-256 and/or SHA-512 and SHOULD NOT be SHA-1

SHA-512 seemed more future-proof than SHA-256

[1] http://www.apache.org/dev/release-distribution#sigs-and-sums

Change-Id: I7646b4559bf39d2415b32a1dcdd4cd7ecde41531
---
M build-support/build_source_release.py
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/11217/1
--
To view, visit http://gerrit.cloudera.org:8080/11217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7646b4559bf39d2415b32a1dcdd4cd7ecde41531
Gerrit-Change-Number: 11217
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11214 )

Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 19:53:22 +
Gerrit-HasComments: No

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11214 )

Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..

[gradle] Aggressively retry downloading the gradle wrapper jar

When downloading the Gradle wrapper jar via curl
builds could fail because we didn’t retry. This patch
adds various ways to retry:

- Adds `—retry 3` to retry transient errors.
- Adds -L to handle when the requested page has
moved to a different location
- Adds -S to show the errors.
- Adds a manual retry loop to retry errors that
curl doesn’t think are transient.
- Replaces raw.githubusercontent.com usage with
a github.com raw url.

Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Reviewed-on: http://gerrit.cloudera.org:8080/11214
Reviewed-by: Adar Dembo 
Tested-by: Grant Henke 
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 23 insertions(+), 7 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Grant Henke: Verified

--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Grant Henke (Code Review)]

Grant Henke has removed a vote on this change.

Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [Java] Upgrade Dependencies

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11213 )

Change subject: [Java] Upgrade Dependencies
..

[Java] Upgrade Dependencies

Upgrades the Java dependencies and Gradle versions.

Minor version upgrades:
- Guava 25.1-android -> 26.0-android

Maintenance version upgrades:
- Protobuf 3.6.0 -> 3.6.1

Gradle upgrades:
- SpotBugs 3.1.5 -> 3.1.6

Change-Id: I42637a2466ceea5de33b44fcda2fe7086d9dd79e
Reviewed-on: http://gerrit.cloudera.org:8080/11213
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M java/gradle/dependencies.gradle
M java/pom.xml
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/11213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I42637a2466ceea5de33b44fcda2fe7086d9dd79e
Gerrit-Change-Number: 11213
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

[Dan Burkert (Code Review)]

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/11216

to review the following change.


Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause 
FATAL
..

KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL

See the associated JIRA for bug details. The fix follows a slightly
different approach than suggested by Todd, namely initialization of the
RPC tracker in the RPC context is delayed until after authorization.
This allows the error path code to remain unchanged, and allows the one
caller of the RpcContext constructor to be slightly cleaned up.

Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/service_if.cc
4 files changed, 47 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11216/1
--
To view, visit http://gerrit.cloudera.org:8080/11216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11214 )

Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG@19
PS2, Line 19: - Replaces raw.githubusercontent.com usage with
: a github.com raw url.
> So this is effectively the same thing?
Yeah, it actually redirects to raw.githubusercontent.com, but the url is less 
surprising.



--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 19:08:33 +
Gerrit-HasComments: Yes

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11214 )

Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG@19
PS2, Line 19: - Replaces raw.githubusercontent.com usage with
: a github.com raw url.
So this is effectively the same thing?



--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 18:56:27 +
Gerrit-HasComments: Yes

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Grant Henke (Code Review)]

Hello Dan Burkert, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11214

to look at the new patch set (#2).

Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..

[gradle] Aggressively retry downloading the gradle wrapper jar

When downloading the Gradle wrapper jar via curl
builds could fail because we didn’t retry. This patch
adds various ways to retry:

- Adds `—retry 3` to retry transient errors.
- Adds -L to handle when the requested page has
moved to a different location
- Adds -S to show the errors.
- Adds a manual retry loop to retry errors that
curl doesn’t think are transient.
- Replaces raw.githubusercontent.com usage with
a github.com raw url.

Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 23 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11214/2
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11214 )

Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 18:35:22 +
Gerrit-HasComments: No

[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11214


Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
..

[gradle] Aggressively retry downloading the gradle wrapper jar

When downloading the Gradle wrapper jar via curl
builds could fail because we didn’t retry. This patch
adds various ways to retry:

- Adds `—retry 3` to retry transient errors.
- Adds -L to handle when the requested page has
moved to a different location
- Adds -S to show the errors.
- Adds a manual retry loop to retry errors that
curl doesn’t think are transient.

Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 22 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11214/1
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 

[kudu-CR] [Java] Upgrade Dependencies

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11213 )

Change subject: [Java] Upgrade Dependencies
..


Patch Set 1:

This is mainly to reducing security risk by keeping our dependencies up to date.


--
To view, visit http://gerrit.cloudera.org:8080/11213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42637a2466ceea5de33b44fcda2fe7086d9dd79e
Gerrit-Change-Number: 11213
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 18:04:29 +
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade Dependencies

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11213 )

Change subject: [Java] Upgrade Dependencies
..


Patch Set 1: Code-Review+2

Just curious: what's motivating these changes?


--
To view, visit http://gerrit.cloudera.org:8080/11213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42637a2466ceea5de33b44fcda2fe7086d9dd79e
Gerrit-Change-Number: 11213
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 17:49:08 +
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade Dependencies

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11213


Change subject: [Java] Upgrade Dependencies
..

[Java] Upgrade Dependencies

Upgrades the Java dependencies and Gradle versions.

Minor version upgrades:
- Guava 25.1-android -> 26.0-android

Maintenance version upgrades:
- Protobuf 3.6.0 -> 3.6.1

Gradle upgrades:
- SpotBugs 3.1.5 -> 3.1.6

Change-Id: I42637a2466ceea5de33b44fcda2fe7086d9dd79e
---
M java/gradle/dependencies.gradle
M java/pom.xml
2 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/11213/1
--
To view, visit http://gerrit.cloudera.org:8080/11213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42637a2466ceea5de33b44fcda2fe7086d9dd79e
Gerrit-Change-Number: 11213
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 

[kudu-CR](gh-pages) [site] add links required by ASF

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11209 )

Change subject: [site] add links required by ASF
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: https://www.apache.org/security/; 
target="_blank">Security
> Think this can go under an "Apache" drop down similar to the community one
Actually that's how I tried first, but then it wouldn't show on mobile. I 
checked it btw, this menu bar is still narrower than the actual page content so 
I think we should be fine. Let me know what you think



--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 15:45:33 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] Add current Apache event

[Attila Bukor (Code Review)]

Hello Mike Percy, Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/11211

to review the following change.


Change subject: [site] Add current Apache event
..

[site] Add current Apache event

It's a best practice to add ApacheCon and other ASF-sponsored events to
the homepage.

According to the events README[1] there's an easy way to do it by
adding a link to https://www.apache.org/events/current-event.html

There's also an image that changes based on the current-event:
https://www.apache.org/events/current-event-234x60.png

[1] https://www.apache.org/events/README.txt

Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
---
M index.html
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11211/1
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR](gh-pages) [site] add links required by ASF

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11209 )

Change subject: [site] add links required by ASF
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:

http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: https://www.apache.org/security/; 
target="_blank">Security
Think this can go under an "Apache" drop down similar to the community one 
above? Otherwise the top nav could be pretty wide.



--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 Aug 2018 15:25:28 +
Gerrit-HasComments: Yes

[kudu-CR] Supporting Spark streaming DataFrame in KuduContext.

[Attila Piros (Code Review)]

Attila Piros has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11199 )

Change subject: Supporting Spark streaming DataFrame in KuduContext.
..


Patch Set 4:

> Patch Set 4:
>
> > Could you add tests to demonstrate and prove the functionality this
>  > change is supporting? Also to ensure it doesn't break with future
>  > changes.
>

So I have tried: 
https://gist.github.com/attilapiros/3b5ef42c0f7aa08b0e2c834fbadfc574

But there is an unexpected problem StreamTest is a Scalatest but KuduTestSuite 
is a JUnitSuite and they cannot be mixed:

```
[ERROR] 
/home/systest/kudu-public/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/StreamingSuite.scala:27:
 error: illegal inheritance; superclass QueryTest
[ERROR]  is not a subclass of the superclass JUnitSuite
[ERROR]  of the mixin trait KuduTestSuite
[ERROR] class StreamingSuite extends StreamTest with KuduTestSuite {
[ERROR]  ^
```

Moreover runtime both would create a spark session :(

As StreamTest is quite complex the easier solution would be to remove the "with 
KuduTestSuite" and create the Kudu cluster and simple test table here.

Or using composition instead of inheritance via a new class extending 
KudutestSuite and call before and after methods accordingly.

In both cases here would be a scalatest. Is there any reason why JUnitSuite is 
used here? What is your suggestion?


--
To view, visit http://gerrit.cloudera.org:8080/11199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iead04539d3514920a5d6803c34715e5686124572
Gerrit-Change-Number: 11199
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Piros 
Gerrit-Reviewer: Attila Piros 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 15:22:20 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10983 )

Change subject: KUDU-1291. Efficiently support predicates on non-prefix key 
components
..


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10983/10/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:

http://gerrit.cloudera.org:8080/#/c/10983/10/src/kudu/cfile/cfile_reader.h@59
PS10, Line 59: static const int kEncodedCompositeKeyMaxSize =
> Refactored this name to: kEncodedCompositeKeyMaxSize as it makes more sense
Can we test what happens when someone violates this?



--
To view, visit http://gerrit.cloudera.org:8080/10983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f
Gerrit-Change-Number: 10983
Gerrit-PatchSet: 14
Gerrit-Owner: Anupama Gupta 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Anupama Gupta 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Tue, 14 Aug 2018 14:43:04 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] Fix site building

[Attila Bukor (Code Review)]

Hello Mike Percy, Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/11210

to review the following change.


Change subject: [site] Fix site building
..

[site] Fix site building

- add build and thirdparty to exclude list in Jekyll front matter,
because if switching between master and gh-pages, these remain there and
breaking the builds

- update Gemfile.lock to current releases as json had some conflicting
dependencies. Everything failed with the old Gemfile.lock on a fresh
install bundle install (on MacOS at least).

Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
---
M Gemfile.lock
M _config.yml
2 files changed, 56 insertions(+), 45 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11210/1
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR](gh-pages) [site] add links required by ASF

[Attila Bukor (Code Review)]

Hello Mike Percy, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11209

to look at the new patch set (#2).

Change subject: [site] add links required by ASF
..

[site] add links required by ASF

ASF requires the following links to be included in the navigation
system[1]:

---
* "License" should link to: http://www.apache.org/licenses/

* "Sponsorship" or "Donate" should link to:
http://www.apache.org/foundation/sponsorship.html

* "Thanks" should link to: http://www.apache.org/foundation/thanks.html

* "Security" should link to either to a project-specific page detailing
how users may securely report potential vulnerabilities, or to the main
http://www.apache.org/security/ page

* All projects must feature some prominent link back to the main ASF
homepage at http://www.apache.org/
---

It also requires a trademark notice[2].

This commit adds all of these.

[1] https://www.apache.org/foundation/marks/pmcs#navigation
[2] https://www.apache.org/foundation/marks/pmcs#attributions

Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
---
M _includes/bottom_common.html
M _includes/top_common.html
M index.html
3 files changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11209/2
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR](gh-pages) [site] add links required by ASF

[Attila Bukor (Code Review)]

Hello Mike Percy, Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/11209

to review the following change.


Change subject: [site] add links required by ASF
..

[site] add links required by ASF

ASF requires the following links to be included in the navigation
system[1]:

---
* "License" should link to: http://www.apache.org/licenses/

* "Sponsorship" or "Donate" should link to:
http://www.apache.org/foundation/sponsorship.html

* "Thanks" should link to: http://www.apache.org/foundation/thanks.html

* "Security" should link to either to a project-specific page detailing
how users may securely report potential vulnerabilities, or to the main
http://www.apache.org/security/ page

* All projects must feature some prominent link back to the main ASF
homepage at http://www.apache.org/
---

This commit adds all of these.

[1] https://www.apache.org/foundation/marks/pmcs#navigation

Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
---
M _includes/bottom_common.html
M _includes/top_common.html
M index.html
3 files changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11209/1
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Implement BloomFilter Predicate in server side.

[ZhangYao (Code Review)]

ZhangYao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11100 )

Change subject: Implement BloomFilter Predicate in server side.
..


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/common/column_predicate.h
File src/kudu/common/column_predicate.h:

http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/common/column_predicate.h@97
PS2, Line 97:   // Either (but not both) of the bounds may be a nullptr to 
indicate an
:   // unbounded range on that end.
> I'm not sure range queries should be able to support BloomFilters. Is InBlo
Actually users are not suppose to use both range and bloomfilter for the same 
column , but this is possible to happen so I should handle this case and merge 
all the predicates for the same column.


http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/common/common.proto
File src/kudu/common/common.proto:

http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/common/common.proto@351
PS2, Line 351: // The bloomfilter fo
> One of the things that I think might be confusing in the future is there is
I name it BloomFilter to be consistent with other predicates message such as 
Range.


http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/common/common.proto@352
PS2, Line 352: ssage BloomFilter {
 : optional int32 nhash = 1;
 : // We currently use CityHash backend
> It's a bit unclear what these fields are. Mind adding comments explaining?
Done


http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/common/wire_protocol.cc@412
PS2, Line 412: // Copies a predicate bloom filter data from 'bf_src' into 
'bf_dst'.
 : void CopyPredicateBloomFilterToPB(const 
ColumnPredicate::BloomFilterInner& bf_src,
 :   
ColumnPredicatePB::BloomFilter* bf_dst) {
 :   bf_dst->set_nhash(bf_src.nhash());
 :   const void* src;
 :   size_t size;
 :   src = bf_src.bloom_data().data();
 :
> This would be clearer if it took a BloomFilterInner instead of a Slice. Sam
Done


http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/tablet/cfile_set-test.cc
File src/kudu/tablet/cfile_set-test.cc:

http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/tablet/cfile_set-test.cc@104
PS2, Line 104:
 : ASSERT_OK(rsw.Finish());
 :   }
 :
> Can you comment what these variables do and how they should be used? Same w
Done


http://gerrit.cloudera.org:8080/#/c/11100/2/src/kudu/tablet/cfile_set-test.cc@451
PS2, Line 451:   DoTestRangeScan(fileset, 2001, 2009);
> Would you mind adding a high-level summary of what this test is testing and
Done



--
To view, visit http://gerrit.cloudera.org:8080/11100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62c2de42667d0255d94e19db773240f7f9ee636c
Gerrit-Change-Number: 11100
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: ZhangYao 
Gerrit-Comment-Date: Tue, 14 Aug 2018 10:45:31 +
Gerrit-HasComments: Yes

[kudu-CR] [WIP] [tools] KUDU-2461 Add election metrics to ksck

[Attila Bukor (Code Review)]

Hello Will Berkeley, Mike Percy, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10588

to look at the new patch set (#6).

Change subject: [WIP] [tools] KUDU-2461 Add election metrics to ksck
..

[WIP] [tools] KUDU-2461 Add election metrics to ksck

KUDU-2287 added two new metrics:
* failed_elections_since_stable_leader
* time_since_last_leader_heartbeat

This commit adds two ksck configuration options:

* failed_elections_warn_limit (default 3)
* millis_since_heartbeat_warn_limit (default 5000)

If any of them is reached, a warning is added to the ksck output:

Replica 39d3ec2c1f9541e18162a344645a4cdc of
e996c2436f3149eba8f7207bb6281a0d has not heard from the leader in 275991
ms and has called 33 failed election(s) since then.

Change-Id: I16fa6f32e6df7698365e908c7b48e63b0e52c745
---
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
11 files changed, 154 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/10588/6
--
To view, visit http://gerrit.cloudera.org:8080/10588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16fa6f32e6df7698365e908c7b48e63b0e52c745
Gerrit-Change-Number: 10588
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] Implement BloomFilter Predicate in server side.

[ZhangYao (Code Review)]

Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11100

to look at the new patch set (#4).

Change subject: Implement BloomFilter Predicate in server side.
..

Implement BloomFilter Predicate in server side.

Change-Id: I62c2de42667d0255d94e19db773240f7f9ee636c
---
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/common.proto
M src/kudu/common/key_util.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/tablet/cfile_set-test.cc
9 files changed, 1,020 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/11100/4
--
To view, visit http://gerrit.cloudera.org:8080/11100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I62c2de42667d0255d94e19db773240f7f9ee636c
Gerrit-Change-Number: 11100
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon