[kudu-CR] [compile] fix a compile warning
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. Patch Set 4: > In my opinion, using pragma statements to avoid compilation > warnings may be more concise, and it minimally invades the existing > code, which may be the best way. However, the downside of this > approach is that developers need to have enough development > experience, at least to understand the existence of this method of > fixing. By the way, I also searched for this fix only after your > suggestion. And it may cause confusion for some beginners when they > read this segment. Overall, I think this is a good approach, and I > will also use this method to fix similar issues in the future. > Thank you for teaching me this method. That makes sense to me. Thank you for the feedback! -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 21 Jul 2023 21:16:38 + Gerrit-HasComments: No
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during the compile process: ` /data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function ‘virtual void kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’: /data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: ‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized] update_immu_col_to_null_ ? nullopt : optional(999)); ` Although it does not involve functional defects, it still needs to be fixed. As it does not involve any logic changes, no new unit tests have been added. Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Reviewed-on: http://gerrit.cloudera.org:8080/20183 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/client/client-test.cc 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [compile] fix a compile warning
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. Patch Set 3: In my opinion, using pragma statements to avoid compilation warnings may be more concise, and it minimally invades the existing code, which may be the best way. However, the downside of this approach is that developers need to have enough development experience, at least to understand the existence of this method of fixing. By the way, I also searched for this fix only after your suggestion. And it may cause confusion for some beginners when they read this segment. Overall, I think this is a good approach, and I will also use this method to fix similar issues in the future. Thank you for teaching me this method. -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 21 Jul 2023 01:50:30 + Gerrit-HasComments: No
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. Patch Set 3: Code-Review+2 > (1 comment) > > Thank you very much for your comment. I have made changes to the > code based on your suggestion, and I kindly ask you to confirm > whether this modification approach meets expectations. Thanks a lot for addressing my comment! Yes, the code in PS3 looks good to me. BTW, about this approach using pragmas: does it look good enough to you, or you think it's better to update the code without using pragmas? Just curious to get more input on this from people. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 20 Jul 2023 18:49:32 + Gerrit-HasComments: No
[kudu-CR] [compile] fix a compile warning
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. Patch Set 3: (1 comment) Thank you very much for your comment. I have made changes to the code based on your suggestion, and I kindly ask you to confirm whether this modification approach meets expectations. http://gerrit.cloudera.org:8080/#/c/20183/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20183/2//COMMIT_MSG@16 PS2, Line 16: Although it does not involve functional defects, it : still needs to be fixed. > While it's good to have no warnings during compilation, I'm not sure it mak Done -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 20 Jul 2023 06:34:44 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20183 to look at the new patch set (#3). Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during the compile process: ` /data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function ‘virtual void kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’: /data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: ‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized] update_immu_col_to_null_ ? nullopt : optional(999)); ` Although it does not involve functional defects, it still needs to be fixed. As it does not involve any logic changes, no new unit tests have been added. Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 --- M src/kudu/client/client-test.cc 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/20183/3 -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20183/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20183/2//COMMIT_MSG@16 PS2, Line 16: Although it does not involve functional defects, it : still needs to be fixed. While it's good to have no warnings during compilation, I'm not sure it makes sense to fix every bogus warnings like this by actually modifying the code. IIUC, that's just a bug in particular GCC version, so the compiler warns about an issue that doesn't exist in reality. Did you explore other, less invasive alternatives to quell this bogus warning, like pragma statements? Or you'd rather prefer updating the code like that for some reason? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 20 Jul 2023 03:56:08 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
Hello Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20183 to look at the new patch set (#2). Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during the compile process: ` /data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function ‘virtual void kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’: /data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: ‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized] update_immu_col_to_null_ ? nullopt : optional(999)); ` Although it does not involve functional defects, it still needs to be fixed. As it does not involve any logic changes, no new unit tests have been added. Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 --- M src/kudu/client/client-test.cc 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/20183/2 -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [compile] fix a compile warning
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. Patch Set 2: (1 comment) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/20183/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20183/1/src/kudu/client/client-test.cc@9499 PS1, Line 9499: > Move to the else-statement, because here is 'update_immu_col_to_null_' ? Done -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 20 Jul 2023 03:18:03 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 ) Change subject: [compile] fix a compile warning .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20183/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20183/1/src/kudu/client/client-test.cc@9499 PS1, Line 9499: optional(999) Move to the else-statement, because here is 'update_immu_col_to_null_' ? -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 20 Jul 2023 02:47:55 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20182 ) Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during the compile process: ` /data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc: In member function ‘virtual void kudu::itest::AutoIncrementingItest_BootstrapWalsDiverge_Test::TestBody()’: /data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc:530:7: warning: operation on ‘j’ may be undefined [-Wsequence-point] j = ++j % kNumTabletServers; ~~^ ` Although it does not involve functional defects, it still needs to be fixed. As it does not involve any logic changes, no new unit tests have been added. Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Reviewed-on: http://gerrit.cloudera.org:8080/20182 Reviewed-by: Alexey Serbin Tested-by: Alexey Serbin --- M src/kudu/integration-tests/auto_incrementing-itest.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has removed a vote on this change. Change subject: [compile] fix a compile warning .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20182 ) Change subject: [compile] fix a compile warning .. Patch Set 2: Verified+1 unrelated test failures (ASAN, DEBUG). -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jul 2023 16:22:46 + Gerrit-HasComments: No
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20182 ) Change subject: [compile] fix a compile warning .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc@530 PS1, Line 530: j = (j + 1) % kNumTabletServers; : } > > However, this implementation would cause the variable j to remain No problem. Thank you for addressing this! -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jul 2023 14:13:18 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20182 ) Change subject: [compile] fix a compile warning .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc@530 PS1, Line 530: j = (j + 1) % kNumTabletServers; : } > However, this implementation would cause the variable j to remain > unchanged in the next loop. I am very sorry that my previous reply was not well thought out, but the message cannot be deleted now. I have made the modifications according to your suggestion, and I really appreciate your review. http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc@530 PS1, Line 530: j = (j + 1) % kNumTabletServers; : } > Would it be more readable if written simply as Done -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jul 2023 14:00:23 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20182 to look at the new patch set (#2). Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during the compile process: ` /data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc: In member function ‘virtual void kudu::itest::AutoIncrementingItest_BootstrapWalsDiverge_Test::TestBody()’: /data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc:530:7: warning: operation on ‘j’ may be undefined [-Wsequence-point] j = ++j % kNumTabletServers; ~~^ ` Although it does not involve functional defects, it still needs to be fixed. As it does not involve any logic changes, no new unit tests have been added. Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 --- M src/kudu/integration-tests/auto_incrementing-itest.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/20182/2 -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [compile] fix a compile warning
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20182 ) Change subject: [compile] fix a compile warning .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc@530 PS1, Line 530: ++j; : j = j % kNumTabletServers; > Would it be more readable if written simply as However, this implementation would cause the variable j to remain unchanged in the next loop. -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jul 2023 08:02:11 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20183 Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during the compile process: ` /data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function ‘virtual void kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’: /data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: ‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized] update_immu_col_to_null_ ? nullopt : optional(999)); ` Although it does not involve functional defects, it still needs to be fixed. As it does not involve any logic changes, no new unit tests have been added. Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 --- M src/kudu/client/client-test.cc 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/20183/1 -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20182 ) Change subject: [compile] fix a compile warning .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jul 2023 07:17:31 + Gerrit-HasComments: No
[kudu-CR] [compile] fix a compile warning
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20182 ) Change subject: [compile] fix a compile warning .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc@530 PS1, Line 530: ++j; : j = j % kNumTabletServers; Would it be more readable if written simply as j = (j + 1) % kNumTabletServers; ? -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jul 2023 07:16:34 + Gerrit-HasComments: Yes
[kudu-CR] [compile] fix a compile warning
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20182 Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during the compile process: ` /data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc: In member function ‘virtual void kudu::itest::AutoIncrementingItest_BootstrapWalsDiverge_Test::TestBody()’: /data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc:530:7: warning: operation on ‘j’ may be undefined [-Wsequence-point] j = ++j % kNumTabletServers; ~~^ ` Although it does not involve functional defects, it still needs to be fixed. As it does not involve any logic changes, no new unit tests have been added. Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 --- M src/kudu/integration-tests/auto_incrementing-itest.cc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/20182/1 -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng
