Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/#review119424
---



Patch looks great!

Reviews applied: [43041, 43593]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 3:01 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43593/
> ---
> 
> (Updated Feb. 17, 2016, 3:01 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
> Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2646
> https://issues.apache.org/jira/browse/MESOS-2646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add test for spliting revocable resources in separate offer.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
> 
> Diff: https://reviews.apache.org/r/43593/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review119420
---



Patch looks great!

Reviews applied: [43552]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 12:31 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 17, 2016, 12:31 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, line 139
> > 
> >
> > You need to EXPECT_SOME on the find first, other wise it's basically an 
> > assert.

Do you mean -
EXPECT_SOME(json.get().find("Config.Labels.foo"));
EXPECT_EQ("bar",  json.get().find("Config.Labels.foo").get());


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review119039
---


On Feb. 5, 2016, 10:52 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Feb. 5, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/docker_tests.cpp 
> f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 536
> > 
> >
> > Seems like we're increasing trying to find docker versions in our code 
> > base. How about let's capture the docker version and save it in the Docker 
> > class, so we can re-use it and don't have to compute it every time?

How about we store the docker version in docker class inside validateVersion() 
method?


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review119039
---


On Feb. 5, 2016, 10:52 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Feb. 5, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/docker_tests.cpp 
> f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119413
---




src/tests/fetcher_cache_tests.cpp (line 194)


Can you please summary the discussion of you and  bernd-mesos for why not 
using `Clock::settle()` so as to let everyone know the detail?


- Guangya Liu


On 二月 17, 2016, 2:11 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated 二月 17, 2016, 2:11 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43636: Cleaned up various code in a test file.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43636/#review119412
---



Patch looks great!

Reviews applied: [43635, 43636]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 11:29 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43636/
> ---
> 
> (Updated Feb. 16, 2016, 11:29 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up various code in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 
> 
> Diff: https://reviews.apache.org/r/43636/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review119405
---



Patch looks great!

Reviews applied: [43634]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/
---

(Updated Feb. 17, 2016, 3:01 a.m.)


Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
Jian Qiu, and Vinod Kone.


Changes
---

Remove the duplicate check.


Bugs: MESOS-2646
https://issues.apache.org/jira/browse/MESOS-2646


Repository: mesos


Description
---

Add test for spliting revocable resources in separate offer.


Diffs (updated)
-

  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43593/diff/


Testing
---

Make && Make check.


Thanks,

Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43041/
---

(Updated Feb. 17, 2016, 3 a.m.)


Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
Jian Qiu, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-2646
https://issues.apache.org/jira/browse/MESOS-2646


Repository: mesos


Description
---

Update Master to send revocable resources in separate offers.


Diffs (updated)
-

  src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43041/diff/


Testing
---

Make && Make check
 
Test: https://reviews.apache.org/r/43593/


Thanks,

Yongqiao Wang

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/#review119400
---




docs/attributes-resources.md (line 39)


s/e.g., reserving "1.5001 CPUs" is considered equivalent to reserving "1.5 
CPUs"/e.g., reserving "1.5123 CPUs" is considered equivalent to reserving 
"1.512 CPUs" ?

This is more clear to reflect that three decimal digits of precision are 
supportted.

You may also want to mention the logic here:
1) Trailing zeros (1.500 -> 1.5).
2) Round up (1.5015 -> 1.502)



src/tests/resources_tests.cpp (line 856)


add a period to the end and same as following.



src/tests/resources_tests.cpp (line 1622)


s/We //


- Guangya Liu


On 二月 17, 2016, 12:49 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43635/
> ---
> 
> (Updated 二月 17, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4687
> https://issues.apache.org/jira/browse/MESOS-4687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Scalar resource values are represented using floating point. As a result, 
> users
> could see unexpected results when accepting offers and making reservations for
> fractional resources: values like "0.1" cannot be precisely represented using
> standard floating point, and the resource values returned to frameworks might
> contain an unpredictable amount of roundoff error.
> 
> This commit adjusts the master to use fixed-point when doing internal
> computations on scalar resource values. The fixed-point format only supports
> three decimal digits of precision: that is, fractional resource values like
> "0.001" will be supported, but "0.0001" will not be.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
>   src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
>   src/master/allocator/mesos/hierarchical.cpp 
> a9d2c23162892e0f97d89a076d2311091d91 
>   src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
>   src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
>   src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 
> 
> Diff: https://reviews.apache.org/r/43635/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually verified that some of the floating point oddities in 
> https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
> is applied, although I wasn't able to reproduce the crash described in that 
> ticket.
> 
> REVIEW NOTES:
> 
> * We don't currently emit a warning when discarding additional digits of 
> precision from input scalar resource values. Should we? That would require 
> identifying all the points where a resource value is seemed to be 
> "user-provided", and also runs the risk of generating a ton of log messages 
> when an old framework is used.
> * Similarly, if the user gives us a resource value and we don't do anything 
> to it, we won't discard any additional precision that appears in the value -- 
> the precision only gets discarded when we apply an operator like `+` or `-`. 
> Unclear if we should trim additional precision from all scalar resource 
> values more aggressively.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/
---

(Updated Feb. 17, 2016, 2:10 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase


Bugs: MESOS-4685
https://issues.apache.org/jira/browse/MESOS-4685


Repository: mesos


Description
---

Speed up FetcherCache test cases by disable framework checkpoint.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 

Diff: https://reviews.apache.org/r/43608/diff/


Testing
---

When we enable checkpoint for frameworks, StatusUpdateManager would waiting for 
write StatusUpdateRecord to file and then boardcast it. This cause uncessary 
disk operations and bring unstable delay if our test cases don't depends on 
recovery.  

Before
```
[   OK ] FetcherCacheTest.LocalUncached (2645 ms)
[   OK ] FetcherCacheTest.LocalCached (2653 ms)
[   OK ] FetcherCacheTest.CachedFallback (1110 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
[   OK ] FetcherCacheTest.SimpleEviction (5059 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
```

After
```
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2516 ms)
[   OK ] FetcherCacheTest.CachedFallback (957 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
[   OK ] FetcherCacheTest.SimpleEviction (4532 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
```

And test the recovery test manually:
```
./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 17, 2016, 2:11 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Feb. 17, 2016, 2:10 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test by reduce loop.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
---

Before
```
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2516 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
```

After
```
[   OK ] FetcherCacheTest.LocalUncached (977 ms)
[   OK ] FetcherCacheTest.LocalCached (1731 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (975 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1713 ms)
```


Thanks,

haosdent huang

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119399
---




include/mesos/mesos.proto (line 598)


s/Labels/One label?

I think that here we should use `one label` but not `labels`, becauase this 
can only happen if one label include duplicate key-value pairs.


- Guangya Liu


On 二月 16, 2016, 7:15 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43616/
> ---
> 
> (Updated 二月 16, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The implementation of the equality operator for `Labels` is buggy for labels
> that contain duplicates. We might want to revisit fixing the implementation of
> that operator (which might be expensive; MESOS-4445), but in the short-term we
> should document that duplicates should not be specified.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
> 
> Diff: https://reviews.apache.org/r/43616/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Klaus Ma]

> On Feb. 17, 2016, 8:30 a.m., Klaus Ma wrote:
> > src/common/values.cpp, line 67
> > 
> >
> > Let's add check on overflow; it will be helpful if scalar value was 
> > big. Scalar is a general type, there maybe used with a big value, e.g. 
> > total size of distributed filesystem.
> 
> Neil Conway wrote:
> What should we do in case of overflow?
> 
> Note that we don't check for overflow in operator+ (or for negative 
> result values in operator-)...

`CHECK` or warning log should be fine, it only improves the debugability; it 
different with `operator+` because `max_double/2` should be big enough for us; 
but for `double * 1000 -> long`, I'm not sure of that.

And I think we need to use `long long` or `int64` instead of `long`; `long` is 
not garantee to be 64bit in c++.


> On Feb. 17, 2016, 8:30 a.m., Klaus Ma wrote:
> > docs/attributes-resources.md, line 7
> > 
> >
> > Any related to this patches?
> 
> Neil Conway wrote:
> Not really, just a minor doc cleanup I made along the way. Happy to split 
> into a separate patch if you'd prefer.

It's OK to handle it in this patches.


> On Feb. 17, 2016, 8:30 a.m., Klaus Ma wrote:
> > docs/attributes-resources.md, line 39
> > 
> >
> > There seems two space before "Those are used to ..." in review board; 
> > but it's OK drop this issues if it's one in the code.
> 
> Neil Conway wrote:
> Two spaces after a period is considered good style in English prose 
> according to some people (this style is used in various places throughout the 
> comments and docs, but we aren't consistent). I don't have a strong view, but 
> it will require changing a lot more places than just here to adopt a single 
> style.

Yes, seems both styles are accepted in comments & document. I'm OK with that.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/#review119382
---


On Feb. 17, 2016, 8:49 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43635/
> ---
> 
> (Updated Feb. 17, 2016, 8:49 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4687
> https://issues.apache.org/jira/browse/MESOS-4687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Scalar resource values are represented using floating point. As a result, 
> users
> could see unexpected results when accepting offers and making reservations for
> fractional resources: values like "0.1" cannot be precisely represented using
> standard floating point, and the resource values returned to frameworks might
> contain an unpredictable amount of roundoff error.
> 
> This commit adjusts the master to use fixed-point when doing internal
> computations on scalar resource values. The fixed-point format only supports
> three decimal digits of precision: that is, fractional resource values like
> "0.001" will be supported, but "0.0001" will not be.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
>   src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
>   src/master/allocator/mesos/hierarchical.cpp 
> a9d2c23162892e0f97d89a076d2311091d91 
>   src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
>   src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
>   src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 
> 
> Diff: https://reviews.apache.org/r/43635/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually verified that some of the floating point oddities in 
> https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
> is applied, although I wasn't able to reproduce the crash described in that 
> ticket.
> 
> REVIEW NOTES:
> 
> * We don't currently emit a warning when discarding additional digits of 
> precision from input scalar resource values. Should we? That would require 
> identifying all the points where a resource value is seemed to be 
> "user-provided", and also runs the risk of generating a ton of log messages 
> when an old framework is used.
> * Similarly, if the user gives us a resource value and we don't do anything 
> to it, we won't discard any additi

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/#review119395
---



Patch looks great!

Reviews applied: [43613, 43614, 43629, 43630, 43615]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 10:43 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43615/
> ---
> 
> (Updated Feb. 16, 2016, 10:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Includes the following changes:
> 
> * Added the `` header where appropriate.
> * Added the namespace `using process::Owned;` where appropriate.
> * Generally replaced `Try>` with `Owned`.  And 
> `Try>` with `Owned`.
> * Added the (now required) `MasterDetector` argument to all slaves.  Before, 
> this was fetched from the first master in `Cluster`.
> * Removed `Shutdown();` from all tests.
> * Replaced `Stop(...)` with the appropriate master/slave destruction calls.
> * Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
> launchers, etc).
> * Replace `CHECK` in tests with `ASSERT`.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
>   src/tests/container_logger_tests.cpp 
> e161fd671972d365a25a5f2e238e11815e574164 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 1e6cb05144995c1cc12e3caa9825761fd9a0e21a 
>   src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
>   src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
>   src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
>   src/tests/executor_http_api_tests.cpp 
> 36a042ed103271ca873450236f39a8152fbbf07e 
>   src/tests/fault_tolerance_tests.cpp 
> 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
>   src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/master_contender_detector_tests.cpp 
> 255ab8119a04b55bb4f1b61dee19c4be64499376 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
>   src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d41178eb41df519073fc0890c5716bbc9fed6ad2 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 
>   src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
>   src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 6069ca1e9ed278459c5182e438417e95955b1924 
>   src/tests/persistent_volume_tests.cpp 
> e169e1b141a38dc389eefd42c11a078c413123d5 
>   src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
>   src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
>   src/tests/registrar_zookeeper_tests.cpp 
> 3df9779ee5d076e16f6a538326693a36f986b6d0 
>   src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
>   src/tests/resource_offers_tests.cpp 
> 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
>   src/tests/role_tests.cpp f

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Neil Conway]

> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote:
> > docs/attributes-resources.md, line 7
> > 
> >
> > Any related to this patches?

Not really, just a minor doc cleanup I made along the way. Happy to split into 
a separate patch if you'd prefer.


> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote:
> > docs/attributes-resources.md, line 39
> > 
> >
> > There seems two space before "Those are used to ..." in review board; 
> > but it's OK drop this issues if it's one in the code.

Two spaces after a period is considered good style in English prose according 
to some people (this style is used in various places throughout the comments 
and docs, but we aren't consistent). I don't have a strong view, but it will 
require changing a lot more places than just here to adopt a single style.


> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote:
> > src/common/values.cpp, line 52
> > 
> >
> > remove empty line.

I'd prefer to keep the newline: without a newline, it suggests that the comment 
is specific to the function that follows (operator<<), which would be 
misleading: the comment applies to the following ~7 functions.


> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote:
> > src/common/values.cpp, line 60
> > 
> >
> > Regarnding `lround`, it maybe overcommit resources, if framework keep 
> > launching task with smaller CPU usage; I'd suggest to discard the 
> > additional precission directly (e.g. 1.2345 -> 1.234). If there's any idle 
> > resources because of discarding, oversubscription will help.
> > 
> > And we need to reject operation request with small resources which is 
> > handled in MESOS-1807.

Truncation rather than rounding might also be reasonable behavior; I'm curious 
what other people think.


> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote:
> > src/common/values.cpp, line 61
> > 
> >
> > Should we `setprecision`?

I didn't use setprecision, because:

1. There is value in making sure we use the same rounding method in this 
operator as elsewhere, e.g, for corner-cases like 1.2345
2. setprecision is side-effecting and modifying the caller's ostream seems 
problematic.


> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote:
> > src/common/values.cpp, line 67
> > 
> >
> > Let's add check on overflow; it will be helpful if scalar value was 
> > big. Scalar is a general type, there maybe used with a big value, e.g. 
> > total size of distributed filesystem.

What should we do in case of overflow?

Note that we don't check for overflow in operator+ (or for negative result 
values in operator-)...


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/#review119382
---


On Feb. 16, 2016, 11:29 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43635/
> ---
> 
> (Updated Feb. 16, 2016, 11:29 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4687
> https://issues.apache.org/jira/browse/MESOS-4687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Scalar resource values are represented using floating point. As a result, 
> users
> could see unexpected results when accepting offers and making reservations for
> fractional resources: values like "0.1" cannot be precisely represented using
> standard floating point, and the resource values returned to frameworks might
> contain an unpredictable amount of roundoff error.
> 
> This commit adjusts the master to use fixed-point when doing internal
> computations on scalar resource values. The fixed-point format only supports
> three decimal digits of precision: that is, fractional resource values like
> "0.001" will be supported, but "0.0001" will not be.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
>   src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
>   src/master/allocator/mesos/hierarchical.cpp 
> a9d2c23162892e0f97d89a076d2311091d91 
>   src

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/
---

(Updated Feb. 17, 2016, 12:49 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Address some of Klaus' comments.


Bugs: MESOS-4687
https://issues.apache.org/jira/browse/MESOS-4687


Repository: mesos


Description
---

Scalar resource values are represented using floating point. As a result, users
could see unexpected results when accepting offers and making reservations for
fractional resources: values like "0.1" cannot be precisely represented using
standard floating point, and the resource values returned to frameworks might
contain an unpredictable amount of roundoff error.

This commit adjusts the master to use fixed-point when doing internal
computations on scalar resource values. The fixed-point format only supports
three decimal digits of precision: that is, fractional resource values like
"0.001" will be supported, but "0.0001" will not be.


Diffs (updated)
-

  docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
  src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
  src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
  src/master/allocator/mesos/hierarchical.cpp 
a9d2c23162892e0f97d89a076d2311091d91 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
  src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
  src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 

Diff: https://reviews.apache.org/r/43635/diff/


Testing
---

make check

Manually verified that some of the floating point oddities in 
https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
is applied, although I wasn't able to reproduce the crash described in that 
ticket.

REVIEW NOTES:

* We don't currently emit a warning when discarding additional digits of 
precision from input scalar resource values. Should we? That would require 
identifying all the points where a resource value is seemed to be 
"user-provided", and also runs the risk of generating a ton of log messages 
when an old framework is used.
* Similarly, if the user gives us a resource value and we don't do anything to 
it, we won't discard any additional precision that appears in the value -- the 
precision only gets discarded when we apply an operator like `+` or `-`. 
Unclear if we should trim additional precision from all scalar resource values 
more aggressively.


Thanks,

Neil Conway

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/#review119393
---




docs/attributes-resources.md (line 7)


Not really, just a minor doc cleanup I made along the way. Happy to split 
into a separate patch if you'd prefer.



docs/attributes-resources.md (line 39)


Two spaces after a period is considered good style in English prose 
according to some people (this style is used in various places throughout the 
comments and docs, but we aren't consistent). I don't have a strong view, but 
it will require changing a lot more places than just here to adopt a single 
style.



src/common/values.cpp (line 52)


I'd prefer to keep the newline: without a newline, it suggests that the 
comment is specific to the function that follows (`operator<<`), which would be 
misleading: the comment applies to the following ~7 functions.



src/common/values.cpp (line 60)


Truncation rather than rounding might also be reasonable behavior; I'm 
curious what other people think.



src/common/values.cpp (line 61)


I didn't use `setprecision`, because:

1. There is value in making sure we use the same rounding method in this 
operator as elsewhere, e.g, for corner-cases like 1.2345
2. `setprecision` is a side-effecting operation, so modifying the caller's 
`ostream` seems problematic.



src/common/values.cpp (line 67)


What should we do in case of overflow?

Note that we don't check for overflow in `operator+` (or for negative 
result values in `operator-`)...


- Neil Conway


On Feb. 16, 2016, 11:29 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43635/
> ---
> 
> (Updated Feb. 16, 2016, 11:29 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4687
> https://issues.apache.org/jira/browse/MESOS-4687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Scalar resource values are represented using floating point. As a result, 
> users
> could see unexpected results when accepting offers and making reservations for
> fractional resources: values like "0.1" cannot be precisely represented using
> standard floating point, and the resource values returned to frameworks might
> contain an unpredictable amount of roundoff error.
> 
> This commit adjusts the master to use fixed-point when doing internal
> computations on scalar resource values. The fixed-point format only supports
> three decimal digits of precision: that is, fractional resource values like
> "0.001" will be supported, but "0.0001" will not be.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
>   src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
>   src/master/allocator/mesos/hierarchical.cpp 
> a9d2c23162892e0f97d89a076d2311091d91 
>   src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
>   src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
>   src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 
> 
> Diff: https://reviews.apache.org/r/43635/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually verified that some of the floating point oddities in 
> https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
> is applied, although I wasn't able to reproduce the crash described in that 
> ticket.
> 
> REVIEW NOTES:
> 
> * We don't currently emit a warning when discarding additional digits of 
> precision from input scalar resource values. Should we? That would require 
> identifying all the points where a resource value is seemed to be 
> "user-provided", and also runs the risk of generating a ton of log messages 
> when an old framework is used.
> * Similarly, if the user gives us a resource value and we don't do anything 
> to it, we won't discard any additional precision that appears in the value -- 
> the precision only gets discarded when we apply an operator like `+` or `-`. 
> Unclear if we should trim additional precision from all scalar resource 
> values more aggressively.
> 
> 
> Thanks,
> 
> Ne

Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/
---

Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.


Bugs: MESOS-3929
https://issues.apache.org/jira/browse/MESOS-3929


Repository: mesos


Description
---

This script allows committers to push locally applied review chain to the ASF
git repo and mark the reviews as submitted.


Diffs
-

  support/push-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/43552/diff/


Testing
---

Tested locally.


Thanks,

Vinod Kone

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/#review119382
---




docs/attributes-resources.md (line 7)


Any related to this patches?



docs/attributes-resources.md (line 39)


There seems two space before "Those are used to ..." in review board; but 
it's OK drop this issues if it's one in the code.



include/mesos/mesos.proto (line 513)


Remove one space before "Any additional precision"



src/common/values.cpp (line 52)


remove empty line.



src/common/values.cpp (line 59)


Replace 1000 with const integer



src/common/values.cpp (line 60)


Regarnding `lround`, it maybe overcommit resources, if framework keep 
launching task with smaller CPU usage; I'd suggest to discard the additional 
precission directly (e.g. 1.2345 -> 1.234). If there's any idle resources 
because of discarding, oversubscription will help.

And we need to reject operation request with small resources which is 
handled in MESOS-1807.



src/common/values.cpp (line 61)


Should we `setprecision`?



src/common/values.cpp (line 67)


Let's add check on overflow; it will be helpful if scalar value was big. 
Scalar is a general type, there maybe used with a big value, e.g. total size of 
distributed filesystem.



src/tests/resources_tests.cpp (line 23)


Seems those two headers are not necessary.


- Klaus Ma


On Feb. 17, 2016, 7:29 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43635/
> ---
> 
> (Updated Feb. 17, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4687
> https://issues.apache.org/jira/browse/MESOS-4687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Scalar resource values are represented using floating point. As a result, 
> users
> could see unexpected results when accepting offers and making reservations for
> fractional resources: values like "0.1" cannot be precisely represented using
> standard floating point, and the resource values returned to frameworks might
> contain an unpredictable amount of roundoff error.
> 
> This commit adjusts the master to use fixed-point when doing internal
> computations on scalar resource values. The fixed-point format only supports
> three decimal digits of precision: that is, fractional resource values like
> "0.001" will be supported, but "0.0001" will not be.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
>   src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
>   src/master/allocator/mesos/hierarchical.cpp 
> a9d2c23162892e0f97d89a076d2311091d91 
>   src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
>   src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
>   src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 
> 
> Diff: https://reviews.apache.org/r/43635/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually verified that some of the floating point oddities in 
> https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
> is applied, although I wasn't able to reproduce the crash described in that 
> ticket.
> 
> REVIEW NOTES:
> 
> * We don't currently emit a warning when discarding additional digits of 
> precision from input scalar resource values. Should we? That would require 
> identifying all the points where a resource value is seemed to be 
> "user-provided", and also runs the risk of generating a ton of log messages 
> when an old framework is used.
> * Similarly, if the user gives us a resource value and we don't do anything 
> to it, we won't discard any additional precision that appears in the value -- 
> the precision only gets discarded when we apply an operator like `+` or `-`. 
> Unclear if we should trim additional precision from all scalar resource 
> values more aggressively.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43618: Added examples for documentation on master/slave state.json.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43618/#review119389
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 16, 2016, 9:59 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43618/
> ---
> 
> (Updated Feb. 16, 2016, 9:59 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-3568
> https://issues.apache.org/jira/browse/MESOS-3568
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We are working on a more standardized way of representing (and thus
> more easily documenting) our internal JSON objects. Until we have
> this, there is no point in trying to exhaustively document the
> state.json (or any other JSON) endpoints. Including an example and
> noting that it is not exhaustive is better than it was before though.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
>   src/slave/http.cpp 523e8dc5d5cc435aaba463a17520237a6c7b192c 
> 
> Diff: https://reviews.apache.org/r/43618/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 43619: Added generated docs from updates to state.json documentation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43619/#review119390
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 16, 2016, 10 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43619/
> ---
> 
> (Updated Feb. 16, 2016, 10 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-3568
> https://issues.apache.org/jira/browse/MESOS-3568
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added generated docs from updates to state.json documentation.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/state.json.md 
> e13993e12526cba47ea7bd1e6f53acc62305250d 
>   docs/endpoints/master/state.md 7571d31bc0d653644fda7c0cfa2fbf3e414314d7 
>   docs/endpoints/slave/state.json.md 10f7a7487c3ab76af7d46c5e7deddf724a3df2c1 
>   docs/endpoints/slave/state.md 40df6a810b3fd2cae113959d4f42a0c19afbd5d2 
> 
> Diff: https://reviews.apache.org/r/43619/diff/
> 
> 
> Testing
> ---
> 
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints/slave/state.json
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints/master/state.json
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 43638: Fixed minor style issues in command_utils.cpp.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43638/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Made return statements and lambdas consistent throughout the file.


Diffs
-

  src/common/command_utils.cpp 68b7facf62b867ac831ae616dad6623ac271110e 

Diff: https://reviews.apache.org/r/43638/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/#review119387
---


Ship it!




Ship It!

- Jie Yu


On Feb. 14, 2016, 4:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43565/
> ---
> 
> (Updated Feb. 14, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
> https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method will be used by the agent to retrieve `ContainerStatus`
> from the `Containerizer`, that was responsible for launching the
> container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
> 
> Diff: https://reviews.apache.org/r/43565/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43564: Defined `status` method for `ComposingContainerizer`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43564/#review119386
---


Ship it!




Ship It!

- Jie Yu


On Feb. 14, 2016, 4:26 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43564/
> ---
> 
> (Updated Feb. 14, 2016, 4:26 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
> https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Defined `status` method for `ComposingContainerizer`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.hpp 
> 6b8757ebc75710b612f6ea5854ee2ff0ca0083ec 
> 
> Diff: https://reviews.apache.org/r/43564/diff/
> 
> 
> Testing
> ---
> 
> make, make check, and sudo make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---




src/slave/containerizer/docker.cpp (lines 161 - 162)


Can you wrap using 70 char width here?



src/slave/containerizer/docker.cpp (lines 413 - 414)


Should we ignore those volumes that have absolute/nested container path 
(like we did in linux fs isolator). What's the reason removing it?



src/slave/containerizer/docker.cpp (line 419)


Indentation.



src/slave/containerizer/docker.cpp (line 442)


indentation



src/slave/containerizer/docker.cpp (lines 457 - 458)


Ditto. Why remove the container_path check?



src/slave/containerizer/docker.cpp (lines 473 - 488)


There's a os::exists check in linux fs isolator which you removed. This is 
fine because we won't update volumes when containerizer->update is called. I 
think we should at least drop a TODO here
so that we don't forget that when we want to support containerizer->update.

Alternatively, we can kill updatePersistentVolumes and inline it into 
mountPersistentVolumes.



src/slave/containerizer/docker.cpp (line 881)


Can you add a TODO stating that this is a hack for now. We need to revisit 
if docker containers have other mounts that may container 'containerId'



src/slave/containerizer/docker.cpp (lines 918 - 921)


Indentation.
```
futures.push_back(
docker->stop(
container.id,
flags.docker_stop_timeout,
true)
  .then([id]() { return id.get(); }));
```



src/slave/containerizer/docker.cpp (lines 1701 - 1708)


Why do you need to do this? Looks like we don't mount until pulling is 
done. Am I missing something?



src/slave/containerizer/docker.cpp (lines 1785 - 1790)


Hum, I think we shouldn't remove the volumes if the container might be 
still running. So can we move the cleanup logics to `___destroy()`?



src/tests/containerizer/docker_containerizer_tests.cpp (lines 1178 - 1217)


ok, can you instead, launch a slave to do that. This is pretty hacky to me.

You can split this test into two: 1) for running containers 2) for orphan 
containers.

Take a look at SlaveRecoveryTest see how to simulate slave failover.



src/tests/containerizer/docker_containerizer_tests.cpp (lines 3217 - 3221)


You can do CREATE+LAUNCH in the same offer cycle, right?



src/tests/containerizer/docker_containerizer_tests.cpp (line 3236)


I might want to write some data to the persistent volume and make sure that 
file exists in the end. See AccessPersistentVolume in PersistentVolumeTest.



src/tests/containerizer/docker_containerizer_tests.cpp (line 3268)


insert a blank line above.



src/tests/containerizer/docker_containerizer_tests.cpp (line 3270)


insert a blank line above.



src/tests/containerizer/docker_containerizer_tests.cpp (line 3285)


Does this still work? Looks like you're not doing rmdir anymore. Am i 
missing something?


- Jie Yu


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43336: Introduced Appc image fetcher.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43336/
---

(Updated Feb. 16, 2016, 11:36 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Review addressed.


Bugs: MESOS-3193
https://issues.apache.org/jira/browse/MESOS-3193


Repository: mesos


Description
---

Added implementation for simple image discovery for Appc images.

TODO: Add tests.


Diffs (updated)
-

  src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
  src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
  src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 

Diff: https://reviews.apache.org/r/43336/diff/


Testing
---

Tested with local http(s) server.


Thanks,

Jojy Varghese

Re: Review Request 43583: Added documentation for multiple-disk support.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119380
---



Open issues were adressed by https://reviews.apache.org/r/43633.

- Joerg Schad


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 43636: Cleaned up various code in a test file.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43636/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Cleaned up various code in a test file.


Diffs
-

  src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 

Diff: https://reviews.apache.org/r/43636/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 43635: Changed scalar resources to use fixed-point internally.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4687
https://issues.apache.org/jira/browse/MESOS-4687


Repository: mesos


Description
---

Scalar resource values are represented using floating point. As a result, users
could see unexpected results when accepting offers and making reservations for
fractional resources: values like "0.1" cannot be precisely represented using
standard floating point, and the resource values returned to frameworks might
contain an unpredictable amount of roundoff error.

This commit adjusts the master to use fixed-point when doing internal
computations on scalar resource values. The fixed-point format only supports
three decimal digits of precision: that is, fractional resource values like
"0.001" will be supported, but "0.0001" will not be.


Diffs
-

  docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
  src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
  src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
  src/master/allocator/mesos/hierarchical.cpp 
a9d2c23162892e0f97d89a076d2311091d91 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
  src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
  src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 

Diff: https://reviews.apache.org/r/43635/diff/


Testing
---

make check

Manually verified that some of the floating point oddities in 
https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
is applied, although I wasn't able to reproduce the crash described in that 
ticket.

REVIEW NOTES:

* We don't currently emit a warning when discarding additional digits of 
precision from input scalar resource values. Should we? That would require 
identifying all the points where a resource value is seemed to be 
"user-provided", and also runs the risk of generating a ton of log messages 
when an old framework is used.
* Similarly, if the user gives us a resource value and we don't do anything to 
it, we won't discard any additional precision that appears in the value -- the 
precision only gets discarded when we apply an operator like `+` or `-`. 
Unclear if we should trim additional precision from all scalar resource values 
more aggressively.


Thanks,

Neil Conway

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review119379
---


Ship it!




Ship It!

- Neil Conway


On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119378
---



Bad patch!

Reviews applied: [43616]

Failed command: ./support/apply-review.sh -n -r 43616

Error:
2016-02-16 23:24:02 URL:https://reviews.apache.org/r/43616/diff/raw/ 
[4159/4159] -> "43616.patch" [1]
error: patch failed: include/mesos/mesos.proto:594
error: include/mesos/mesos.proto: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11479/console

- Mesos ReviewBot


On Feb. 16, 2016, 7:15 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43616/
> ---
> 
> (Updated Feb. 16, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The implementation of the equality operator for `Labels` is buggy for labels
> that contain duplicates. We might want to revisit fixing the implementation of
> that operator (which might be expensive; MESOS-4445), but in the short-term we
> should document that duplicates should not be specified.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
> 
> Diff: https://reviews.apache.org/r/43616/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 43634: Consistent markdown code style in persistent-volumes.md.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/
---

Review request for mesos, Michael Park and Neil Conway.


Repository: mesos


Description
---

Consistent markdown code style in persistent-volumes.md.


Diffs
-

  docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 

Diff: https://reviews.apache.org/r/43634/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 43633: Improved Multiple Disk documentation.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43633/#review119373
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 16, 2016, 10:48 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43633/
> ---
> 
> (Updated Feb. 16, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved Multiple Disk documentation.
> 
> 
> Diffs
> -
> 
>   docs/multiple-disk.md 4fc5327f131fe571357b93569e167be0c858913e 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43633/diff/
> 
> 
> Testing
> ---
> 
> viewed via docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43633: Improved Multiple Disk documentation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43633/#review119370
---


Ship it!




Ship It!

- Neil Conway


On Feb. 16, 2016, 10:48 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43633/
> ---
> 
> (Updated Feb. 16, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved Multiple Disk documentation.
> 
> 
> Diffs
> -
> 
>   docs/multiple-disk.md 4fc5327f131fe571357b93569e167be0c858913e 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43633/diff/
> 
> 
> Testing
> ---
> 
> viewed via docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43633: Improved Multiple Disk documentation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43633/
---

(Updated Feb. 16, 2016, 10:48 p.m.)


Review request for mesos, Joris Van Remoortere and Neil Conway.


Bugs: MESOS-4531
https://issues.apache.org/jira/browse/MESOS-4531


Repository: mesos


Description (updated)
---

Improved Multiple Disk documentation.


Diffs (updated)
-

  docs/multiple-disk.md 4fc5327f131fe571357b93569e167be0c858913e 
  docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 

Diff: https://reviews.apache.org/r/43633/diff/


Testing
---

viewed via docker website container.


Thanks,

Joerg Schad

Review Request 43633: Improved Multiple Disk documentation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43633/
---

Review request for mesos, Joris Van Remoortere and Neil Conway.


Bugs: MESOS-4531
https://issues.apache.org/jira/browse/MESOS-4531


Repository: mesos


Description
---

Adressed open issues from https://reviews.apache.org/r/43583/.


Diffs
-

  docs/multiple-disk.md 4fc5327f131fe571357b93569e167be0c858913e 
  docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 

Diff: https://reviews.apache.org/r/43633/diff/


Testing
---

viewed via docker website container.


Thanks,

Joerg Schad

Re: Review Request 43490: Added testcase for TASK_KILLING state.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/#review119369
---



Patch looks great!

Reviews applied: [43487, 43488, 43489, 43490]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43490/
> ---
> 
> (Updated Feb. 16, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added testcase for TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43490/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/
---

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Includes the following changes:

* Added the `` header where appropriate.
* Added the namespace `using process::Owned;` where appropriate.
* Generally replaced `Try>` with `Owned`.  And 
`Try>` with `Owned`.
* Added the (now required) `MasterDetector` argument to all slaves.  Before, 
this was fetched from the first master in `Cluster`.
* Removed `Shutdown();` from all tests.
* Replaced `Stop(...)` with the appropriate master/slave destruction calls.
* Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
launchers, etc).
* Replace `CHECK` in tests with `ASSERT`.


Diffs
-

  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/container_logger_tests.cpp e161fd671972d365a25a5f2e238e11815e574164 
  src/tests/containerizer/docker_containerizer_tests.cpp 
645bdcf095145097d8b8c65d592c787417883145 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 
  src/tests/containerizer/isolator_tests.cpp 
653b037c489072f43e53dec01a811a9249dcd660 
  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
  src/tests/containerizer/port_mapping_tests.cpp 
1e6cb05144995c1cc12e3caa9825761fd9a0e21a 
  src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
  src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
  src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
  src/tests/executor_http_api_tests.cpp 
36a042ed103271ca873450236f39a8152fbbf07e 
  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 
  src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 
  src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
  src/tests/persistent_volume_endpoints_tests.cpp 
6069ca1e9ed278459c5182e438417e95955b1924 
  src/tests/persistent_volume_tests.cpp 
e169e1b141a38dc389eefd42c11a078c413123d5 
  src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/registrar_zookeeper_tests.cpp 
3df9779ee5d076e16f6a538326693a36f986b6d0 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 
  src/tests/scheduler_event_call_tests.cpp 
bd8920fa9d5475e5f6533c8424ebff1588bfe645 
  src/tests/scheduler_http_api_tests.cpp 
9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
  src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 
  src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a 
  src/tests/status_update_manager_tests.cpp 
d64d3b8c96270478f6b681c038de77c3a9eb68fe 
  src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 

Diff: https://reviews.apache.org/r/43615/diff/


Testing
---

sudo make check

 | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
Ubuntu 1

Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
---

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some 
local variables due to the order of destruction.


Diffs
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 
  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43630/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43629/
---

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with a slightly different 
pattern.


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 

Diff: https://reviews.apache.org/r/43629/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Review Request 43613: Refactor cluster test helpers into self-contained objects.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43613/
---

Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
Harutyunyan.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope of 
test objects to the test body.

Changes the `Cluster` class into two RAII objects (`Master` and `Slave`).  The 
`Slave` object performs cleanup originally found in `cluster::Slave::stop`.  
`cluster::Master::start` and `cluster::Slave::start` were changed to factory 
methods.


Diffs
-

  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 

Diff: https://reviews.apache.org/r/43613/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Review Request 43614: Refactor MesosTest and remove cleanup logic.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43614/
---

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Updates `StartMaster` and `StartSlave` test helpers to use the reworked 
`cluster` helpers.  Removes all `MesosTest` cleanup logic and as well as the 
helpers that accept a `MockExecutor` pointer.


Diffs
-

  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
  src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 

Diff: https://reviews.apache.org/r/43614/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Review Request 43619: Added generated docs from updates to state.json documentation.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43619/
---

Review request for mesos, Michael Park and Vinod Kone.


Bugs: MESOS-3568
https://issues.apache.org/jira/browse/MESOS-3568


Repository: mesos


Description
---

Added generated docs from updates to state.json documentation.


Diffs
-

  docs/endpoints/master/state.json.md e13993e12526cba47ea7bd1e6f53acc62305250d 
  docs/endpoints/master/state.md 7571d31bc0d653644fda7c0cfa2fbf3e414314d7 
  docs/endpoints/slave/state.json.md 10f7a7487c3ab76af7d46c5e7deddf724a3df2c1 
  docs/endpoints/slave/state.md 40df6a810b3fd2cae113959d4f42a0c19afbd5d2 

Diff: https://reviews.apache.org/r/43619/diff/


Testing
---

http://c99.millennium.berkeley.edu/documentation/latest/endpoints/slave/state.json
http://c99.millennium.berkeley.edu/documentation/latest/endpoints/master/state.json


Thanks,

Kevin Klues

Re: Review Request 43618: Added examples for documentation on master/slave state.json.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43618/
---

(Updated Feb. 16, 2016, 9:59 p.m.)


Review request for mesos, Michael Park and Vinod Kone.


Changes
---

Add newline between "Example:" and the JSON to generate proper markdown.  Also, 
make the word NOTE in bold, not italics.


Bugs: MESOS-3568
https://issues.apache.org/jira/browse/MESOS-3568


Repository: mesos


Description
---

We are working on a more standardized way of representing (and thus
more easily documenting) our internal JSON objects. Until we have
this, there is no point in trying to exhaustively document the
state.json (or any other JSON) endpoints. Including an example and
noting that it is not exhaustive is better than it was before though.


Diffs (updated)
-

  src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
  src/slave/http.cpp 523e8dc5d5cc435aaba463a17520237a6c7b192c 

Diff: https://reviews.apache.org/r/43618/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 43583: Added documentation for multiple-disk support.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119364
---


Fix it, then Ship it!





docs/multiple-disk.md (line 54)


s/multiple-disk/multiple disk
for consistency?



docs/multiple-disk.md (line 80)


What happends if a framework attemps to do so?



docs/multiple-disk.md (line 95)


maybe: the `posix/disk` isolator is disabled?
quota enforcements could be confused with Mesos quota



docs/multiple-disk.md (line 129)


s/for/by ?



docs/persistent-volume.md (line 29)


s/Multiple Disk/multiple disk
consistent capitalization with the above doc.


- Joerg Schad


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119258
---




docs/multiple-disk.md (line 31)


According to the styleguide we currently use indentation for json code (see 
quota.md).



docs/multiple-disk.md (line 58)


According to the styleguide we currently use indentation for json code (see 
quota.md).


- Joerg Schad


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119363
---




docs/multiple-disk.md (line 138)


This sentence is a bit vague/confusing.


- Neil Conway


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/
---

(Updated Feb. 16, 2016, 9:43 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-4531
https://issues.apache.org/jira/browse/MESOS-4531


Repository: mesos


Description
---

Added documentation for multiple-disk support.


Diffs (updated)
-

  docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
  docs/multiple-disk.md PRE-CREATION 
  docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 

Diff: https://reviews.apache.org/r/43583/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43583: Added documentation for multiple-disk support.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119357
---


Fix it, then Ship it!





docs/multiple-disk.md (line 83)


"write-ahead logs"



docs/multiple-disk.md (line 87)


"mount a physical disk" seems a bit better, since we talk about a single 
mount point later in the sentence.



docs/multiple-disk.md (line 92)


"over-run" => "exceed"



docs/multiple-disk.md (line 93)


"file-system mounted" => "file system in use"



docs/multiple-disk.md (line 125)


I'd say "destroyed" w/o backticks.



docs/multiple-disk.md (line 127)


"destroying"

"strongly encouraged"



docs/multiple-disk.md (line 128)


"do not get penalized" => "are not penalized"


- Neil Conway


On Feb. 16, 2016, 1:58 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43159/#review119351
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 3, 2016, 11:11 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43159/
> ---
> 
> (Updated Feb. 3, 2016, 11:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4582
> https://issues.apache.org/jira/browse/MESOS-4582
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new `jsonify` library is a writer-based approach, and does not keep track 
> of the fields that have been written out so far.
> The previous version of `summarize(framework)` and `model(framework)` had a 
> duplicate `"active"` field which was de-duplicated since they simply get 
> inserted to a `std::map`, overriding the previous value.
> 
> In the `jsonify` case, this pattern results in duplicate key in the JSON 
> output. Although the presence of duplicate keys is technically not 
> __invalid__ according to the JSON specification, some JSON libraries disallow 
> them.
> As such, we should generate JSON outputs without duplicate keys.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c 
> 
> Diff: https://reviews.apache.org/r/43159/diff/
> 
> 
> Testing
> ---
> 
> Verified that `make check` __with__ https://reviews.apache.org/r/43160/ + 
> https://reviews.apache.org/r/43161/ and __without__ this patch breaks.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 43618: Added examples for documentation on master/slave state.json.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43618/
---

Review request for mesos, Michael Park and Vinod Kone.


Bugs: MESOS-3568
https://issues.apache.org/jira/browse/MESOS-3568


Repository: mesos


Description
---

We are working on a more standardized way of representing (and thus
more easily documenting) our internal JSON objects. Until we have
this, there is no point in trying to exhaustively document the
state.json (or any other JSON) endpoints. Including an example and
noting that it is not exhaustive is better than it was before though.


Diffs
-

  src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
  src/slave/http.cpp 523e8dc5d5cc435aaba463a17520237a6c7b192c 
  src/slave/monitor.cpp 5c1dd354595e67e5eb603c5d49850f84b84b 

Diff: https://reviews.apache.org/r/43618/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 43617: Synchronized v1/ and unversioned copies of `mesos.proto`.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43617/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

No functional changes, but various comments were slightly out of sync.


Diffs
-

  include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
  include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
  src/v1/values.cpp 86094b305965ec6798721a14b85c60da6c77bd93 

Diff: https://reviews.apache.org/r/43617/diff/


Testing
---


Thanks,

Neil Conway

Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

The implementation of the equality operator for `Labels` is buggy for labels
that contain duplicates. We might want to revisit fixing the implementation of
that operator (which might be expensive; MESOS-4445), but in the short-term we
should document that duplicates should not be specified.


Diffs
-

  include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
  include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 

Diff: https://reviews.apache.org/r/43616/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 543
> > 
> >
> > Does label.value() return a Try? What kind of error do we expect from 
> > it?

No, it does not return Try. But I thought to check if there is value inside 
label. So, used Try. Should I use Result instead?


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review119039
---


On Feb. 5, 2016, 10:52 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Feb. 5, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/docker_tests.cpp 
> f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43490: Added testcase for TASK_KILLING state.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/
---

(Updated Feb. 16, 2016, 6:23 p.m.)


Review request for mesos, Ben Mahler and Qian Zhang.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Added testcase for TASK_KILLING state.


Diffs (updated)
-

  src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43490/diff/


Testing
---

make check


Thanks,

Abhishek Dasgupta

Re: Review Request 43490: Added testcase for TASK_KILLING state.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/
---

(Updated Feb. 16, 2016, 6:20 p.m.)


Review request for mesos, Ben Mahler and Qian Zhang.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Added testcase for TASK_KILLING state.


Diffs (updated)
-

  src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43490/diff/


Testing
---

make check


Thanks,

Abhishek Dasgupta

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

[haosdent huang]

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?
> 
> haosdent huang wrote:
> Sure!
> 
> Bernd Mathiske wrote:
> Not writing to disk costs less time.
> 
> If a test does not attempt recovery, then whatever would be checkpointed 
> never gets used.
> 
> Only one test attempts/tests recovery so far. In this test we do apply 
> checkpointing. So it does get tested, but we don't need to test the writing 
> part of it in every other test.
> 
> Alexander Rukletsov wrote:
> I'm a bit confused about what contributes most here. Is it checkpointing 
> or rather the other change? It's a bit strange to me that checkpointing 
> significantly influences the test duration. If so, I would like to understand 
> why, of not, them maybe we can pull it out of the change to avoid 
> distraction. Also It's not clear at the first glance why it's ok to reduce 
> some loops in the tests and why they were there in the first place.
> 
> it would be great to have one fix per patch with explanation why it helps 
> and how much.
> 
> haosdent huang wrote:
> >it would be great to have one fix per patch with explanation why it 
> helps and how much.
> 
> Sure. My test machine is use SATA disk. And becsue we write to disk when 
> status_update, would cause >100 ms delay when I testing. I agree with you. 
> Let me split up them and explain why it helps and how much.

@alex-mesos @bernd-mesos @bbannier Thank you very much for your great review 
and comments. I finish updated this round. Could you help review them again if 
you have time? Thank you very much.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 16, 2016, 5:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 16, 2016, 5:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test by reduce loop.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2516 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (977 ms)
> [   OK ] FetcherCacheTest.LocalCached (1731 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (975 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1713 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/
---

(Updated Feb. 16, 2016, 6:12 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Add explanation in testing done.


Bugs: MESOS-4685
https://issues.apache.org/jira/browse/MESOS-4685


Repository: mesos


Description
---

Speed up FetcherCache test cases by disable framework checkpoint.


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43608/diff/


Testing (updated)
---

When we enable checkpoint for frameworks, StatusUpdateManager would waiting for 
write StatusUpdateRecord to file and then boardcast it. This cause uncessary 
disk operations and bring unstable delay if our test cases don't depends on 
recovery.  

Before
```
[   OK ] FetcherCacheTest.LocalUncached (2645 ms)
[   OK ] FetcherCacheTest.LocalCached (2653 ms)
[   OK ] FetcherCacheTest.CachedFallback (1110 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
[   OK ] FetcherCacheTest.SimpleEviction (5059 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
```

After
```
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2516 ms)
[   OK ] FetcherCacheTest.CachedFallback (957 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
[   OK ] FetcherCacheTest.SimpleEviction (4532 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
```

And test the recovery test manually:
```
./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 16, 2016, 6:03 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Add explanation in testing done.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing (updated)
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

[Neil Conway]

> On Feb. 16, 2016, 2:09 p.m., Joris Van Remoortere wrote:
> > src/tests/group_tests.cpp, line 492
> > 
> >
> > Do you mean `Ensure that no pending messages are delivered.`?
> > Or `if any`, then what?

i.e., we want to check that if there are any pending messages, those messages 
are delivered. I clarified the comment to this effect.


> On Feb. 16, 2016, 2:09 p.m., Joris Van Remoortere wrote:
> > src/tests/group_tests.cpp, lines 450-456
> > 
> >
> > Can you explain why you needed to move this?

Can't recall :) I reverted this change.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review119309
---


On Feb. 16, 2016, 5:59 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Feb. 16, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Feb. 16, 2016, 5:59 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Address code review comments.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs (updated)
-

  src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 16, 2016, 5:58 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Rebase


Summary (updated)
-

Speed up FetcherCache test cases by reduce allocation_interval.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description (updated)
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Feb. 16, 2016, 5:55 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase


Summary (updated)
-

Speed up FetcherCacheTest.Local* test by reduce loop.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description (updated)
---

Speed up FetcherCacheTest.Local* test by reduce loop.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/42696/diff/


Testing (updated)
---

Before
```
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2516 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
```

After
```
[   OK ] FetcherCacheTest.LocalUncached (977 ms)
[   OK ] FetcherCacheTest.LocalCached (1731 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (975 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1713 ms)
```


Thanks,

haosdent huang

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

(Updated Feb. 16, 2016, 5:55 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing (updated)
---

Before
```
[   OK ] FetcherCacheTest.SimpleEviction (4536 ms)
```

After
```
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 16, 2016, 5:55 p.m.)


Review request for mesos and Bernd Mathiske.


Summary (updated)
-

Speed up FetcherCache test cases by advance allocation_interval.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by advance allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing (updated)
---

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/
---

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Bugs: MESOS-4685
https://issues.apache.org/jira/browse/MESOS-4685


Repository: mesos


Description
---

Speed up FetcherCache test cases by disable framework checkpoint.


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43608/diff/


Testing
---

Before
```
[   OK ] FetcherCacheTest.LocalUncached (2645 ms)
[   OK ] FetcherCacheTest.LocalCached (2653 ms)
[   OK ] FetcherCacheTest.CachedFallback (1110 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
[   OK ] FetcherCacheTest.SimpleEviction (5059 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
```

After
```
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2516 ms)
[   OK ] FetcherCacheTest.CachedFallback (957 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
[   OK ] FetcherCacheTest.SimpleEviction (4532 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
```

And test the recovery test manually:
```
./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[haosdent huang]

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?
> 
> haosdent huang wrote:
> Sure!
> 
> Bernd Mathiske wrote:
> Not writing to disk costs less time.
> 
> If a test does not attempt recovery, then whatever would be checkpointed 
> never gets used.
> 
> Only one test attempts/tests recovery so far. In this test we do apply 
> checkpointing. So it does get tested, but we don't need to test the writing 
> part of it in every other test.
> 
> Alexander Rukletsov wrote:
> I'm a bit confused about what contributes most here. Is it checkpointing 
> or rather the other change? It's a bit strange to me that checkpointing 
> significantly influences the test duration. If so, I would like to understand 
> why, of not, them maybe we can pull it out of the change to avoid 
> distraction. Also It's not clear at the first glance why it's ok to reduce 
> some loops in the tests and why they were there in the first place.
> 
> it would be great to have one fix per patch with explanation why it helps 
> and how much.

>it would be great to have one fix per patch with explanation why it helps and 
>how much.

Sure. My test machine is use SATA disk. And becsue we write to disk when 
status_update, would cause >100 ms delay when I testing. I agree with you. Let 
me split up them and explain why it helps and how much.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 16, 2016, 11:39 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 16, 2016, 11:39 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119326
---



Patch looks great!

Reviews applied: [43583]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 1:58 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

[Klaus Ma]

> On Feb. 16, 2016, 6:24 p.m., Klaus Ma wrote:
> > include/mesos/mesos.proto, line 261
> > 
> >
> > Do you mean framework can filter `killing` state? I thinke this's not 
> > necessary.
> 
> Abhishek Dasgupta wrote:
> No. This is framework capability. We intend to use TASK_KILLING state 
> when a killTask is issued. So the framework that doesn't understand 
> TASK_KILLING, for them only TASK_KILLED will be issued. But the frameworks 
> that has TASK_KILLING_STATE capability, for them TASK_KILLING will be issued 
> before a TASK_KILLED is issued.

I think you can sync up with shepherd on this. We add new task state 
`TASK_KILLING` and update it to framework; if framework does not want to handle 
it, just ignore it. And in the following patches, only docker and CLI executor 
are updated to handle this flag; how about other customer's executor?


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43488/#review119288
---


On Feb. 16, 2016, 11:30 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43488/
> ---
> 
> (Updated Feb. 16, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding framework capability for TASK_KILLING.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Alexander Rukletsov]

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?
> 
> haosdent huang wrote:
> Sure!
> 
> Bernd Mathiske wrote:
> Not writing to disk costs less time.
> 
> If a test does not attempt recovery, then whatever would be checkpointed 
> never gets used.
> 
> Only one test attempts/tests recovery so far. In this test we do apply 
> checkpointing. So it does get tested, but we don't need to test the writing 
> part of it in every other test.

I'm a bit confused about what contributes most here. Is it checkpointing or 
rather the other change? It's a bit strange to me that checkpointing 
significantly influences the test duration. If so, I would like to understand 
why, of not, them maybe we can pull it out of the change to avoid distraction. 
Also It's not clear at the first glance why it's ok to reduce some loops in the 
tests and why they were there in the first place.

it would be great to have one fix per patch with explanation why it helps and 
how much.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 16, 2016, 11:39 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 16, 2016, 11:39 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43490: Added testcase for TASK_KILLING state.

[Abhishek Dasgupta]

> On Feb. 16, 2016, 10:27 a.m., Guangya Liu wrote:
> > src/tests/scheduler_tests.cpp, lines 575-576
> > 
> >
> > one line

I think this the common style adapted across all of the test cases, so I am 
keeping them as it is in two lines. So I am dropping the issue.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/#review119285
---


On Feb. 16, 2016, 8:29 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43490/
> ---
> 
> (Updated Feb. 16, 2016, 8:29 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added testcase for TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43490/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43490: Added testcase for TASK_KILLING state.

[Abhishek Dasgupta]

> On Feb. 16, 2016, 10:27 a.m., Guangya Liu wrote:
> > src/tests/scheduler_tests.cpp, lines 578-579
> > 
> >
> > one line

Dropping the issue for the same reason like above.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/#review119285
---


On Feb. 16, 2016, 8:29 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43490/
> ---
> 
> (Updated Feb. 16, 2016, 8:29 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added testcase for TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43490/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43488/
---

(Updated Feb. 16, 2016, 3:30 p.m.)


Review request for mesos, Ben Mahler and Qian Zhang.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Adding framework capability for TASK_KILLING.


Diffs (updated)
-

  include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
  include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
  src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 

Diff: https://reviews.apache.org/r/43488/diff/


Testing
---

make check


Thanks,

Abhishek Dasgupta

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43488/
---

(Updated Feb. 16, 2016, 3:22 p.m.)


Review request for mesos, Ben Mahler and Qian Zhang.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Adding framework capability for TASK_KILLING.


Diffs (updated)
-

  include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
  include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
  src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 

Diff: https://reviews.apache.org/r/43488/diff/


Testing
---

make check


Thanks,

Abhishek Dasgupta

Re: Review Request 42516: Add support for user-defined networks.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119315
---



Patch looks great!

Reviews applied: [42516]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 12:39 p.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 43065: Fixed a leak of a `ZooKeeperMasterContender` in a test case.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43065/#review119312
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 1, 2016, 9:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43065/
> ---
> 
> (Updated Feb. 1, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a leak of a `ZooKeeperMasterContender` in a test case.
> 
> 
> Diffs
> -
> 
>   src/tests/master_contender_detector_tests.cpp 
> 6375586c31b1fd406529bf299dad6e321b945de8 
> 
> Diff: https://reviews.apache.org/r/43065/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Note that the new test in https://reviews.apache.org/r/43035 fails if this 
> leak is not fixed, because advancing the clock causes the leaked 
> `GroupProcess` to fire an `expired` event.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43034: Added EXPECT_NO_FUTURE_DISPATCHES to libprocess.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43034/#review119313
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 1, 2016, 10:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43034/
> ---
> 
> (Updated Feb. 1, 2016, 10:04 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows a unit test to assert that a given libprocess message
> will not be dispatched.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 22a0eac37b16f2ed6afd249f5ea911d81970ba6b 
> 
> Diff: https://reviews.apache.org/r/43034/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review119309
---




src/tests/group_tests.cpp (lines 450 - 454)


Can you explain why you needed to move this?



src/tests/group_tests.cpp (line 483)


backticks for GroupProcess?



src/tests/group_tests.cpp (line 490)


Do you mean `Ensure that no pending messages are delivered.`?
Or `if any`, then what?


- Joris Van Remoortere


On Feb. 1, 2016, 9:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Feb. 1, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43033: Cleaned up code style and fixed typos in comments.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43033/#review119308
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 31, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43033/
> ---
> 
> (Updated Jan. 31, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up code style and fixed typos in comments.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 
>   src/tests/zookeeper_tests.cpp 0665d916760da7550dae9a85e797cee337a0490d 
>   src/zookeeper/group.hpp db8a120e114bea0a22e25114f0795580576ffcca 
>   src/zookeeper/group.cpp ded1458a52d899437b53650524501a3fc09600fe 
>   src/zookeeper/zookeeper.hpp a29a0049568cc1963bf6727f20791ed467cb8403 
> 
> Diff: https://reviews.apache.org/r/43033/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/
---

(Updated Feb. 16, 2016, 1:58 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-4531
https://issues.apache.org/jira/browse/MESOS-4531


Repository: mesos


Description (updated)
---

Added documentation for multiple-disk support.


Diffs (updated)
-

  docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
  docs/multiple-disk.md PRE-CREATION 
  docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 

Diff: https://reviews.apache.org/r/43583/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 42516: Add support for user-defined networks.

[Ezra Silvera]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/
---

(Updated Feb. 16, 2016, 12:39 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Fixing typos


Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369


Repository: mesos


Description
---

Signed-off-by: Ezra Silvera 


Diffs (updated)
-

  include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
  include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 

Diff: https://reviews.apache.org/r/42516/diff/


Testing
---

Using Swarm running on Mesos create a network with "docker  network create 
--driver=bridge myNetwork"   and then create a container on that network:  
"docker run --net=myNetwork"


Thanks,

Ezra Silvera

Re: Review Request 42516: Add support for user-defined networks.

[Ezra Silvera]

> On Feb. 16, 2016, 4:04 a.m., Timothy Chen wrote:
> > Thinking about it a bit more I think it's fine without a unit test as it 
> > requires docker network create. Did you test this manually and made sure it 
> > worked?
> > Once you update the comments I can merge it.

I fixed all the typos and committed the changes.  BTW, I rebased my code to the 
latest mesos code here:

https://github.com/ezrasilvera/mesos/tree/dockerUserNetwork

We tested the code against Docker 1.8.0 and got the excepted error (require 
version greater then 1.9.0) and  verified that it's working against Docker 
1.9.0 and 1.10 
Once you merge it we can also go ahead and make the needed changes in SWARM to 
support this.


- Ezra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119266
---


On Feb. 11, 2016, 1:51 p.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated Feb. 11, 2016, 1:51 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119303
---



Patch looks great!

Reviews applied: [42696, 43316, 43367]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 11:42 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 16, 2016, 11:42 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by advance allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> Before this patch:
> ```
> [   OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [   OK ] FetcherCacheTest.LocalCached (1728 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
> 
> After this patch:
> ```
> [   OK ] FetcherCacheTest.LocalUncached (984 ms)
> [   OK ] FetcherCacheTest.LocalCached (1750 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1043 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2723 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/
---

(Updated Feb. 16, 2016, 12:02 p.m.)


Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
Jian Qiu, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-2646
https://issues.apache.org/jira/browse/MESOS-2646


Repository: mesos


Description
---

Add test for spliting revocable resources in separate offer.


Diffs (updated)
-

  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43593/diff/


Testing
---

Make && Make check.


Thanks,

Yongqiao Wang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119302
---


Ship it!




- Benjamin Bannier


On Feb. 16, 2016, 12:39 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/#review119301
---


Ship it!




Ship It!

- Benjamin Bannier


On Feb. 16, 2016, 12:39 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43316/
> ---
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43316/diff/
> 
> 
> Testing
> ---
> 
> Before
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
> [--] 1 test from FetcherCacheTest (4516 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (4527 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
> [--] 1 test from FetcherCacheTest (3602 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (3612 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43041/
---

(Updated Feb. 16, 2016, 11:57 a.m.)


Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
Jian Qiu, and Vinod Kone.


Changes
---

Addressed DA's comments.


Bugs: MESOS-2646
https://issues.apache.org/jira/browse/MESOS-2646


Repository: mesos


Description
---

Update Master to send revocable resources in separate offers.


Diffs (updated)
-

  src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43041/diff/


Testing
---

Make && Make check
 
Test: https://reviews.apache.org/r/43593/


Thanks,

Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

[Yongqiao Wang]

> On Feb. 16, 2016, 10:08 a.m., Klaus Ma wrote:
> > src/master/master.cpp, line 5285
> > 
> >
> > Use `Resources::nonRevocable()`
> > 
> > Maybe use `Try createOffer(...)` is better; so we can check the 
> > parameters in `createOffer()`.

Use 'Try' except some error happened in createOffer function, in this 
patch use 'Offer' is enough due to no any error happened.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43041/#review119279
---


On Feb. 16, 2016, 8:52 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43041/
> ---
> 
> (Updated Feb. 16, 2016, 8:52 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
> Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2646
> https://issues.apache.org/jira/browse/MESOS-2646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Master to send revocable resources in separate offers.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
> 
> Diff: https://reviews.apache.org/r/43041/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check
>  
> Test: https://reviews.apache.org/r/43593/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[Bernd Mathiske]

> On Feb. 16, 2016, 3:02 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 422
> > 
> >
> > In some fetcher cache tests, we specifically want to find out if 
> > concurrent execution of launching taks works. Settling the clock serializes 
> > this and thus disables some of desired the testing.
> > 
> > How about shortening the allocation interval and not playing with the 
> > clock?
> 
> haosdent huang wrote:
> Got it, how about change to 500ms?

Worth a try :-)


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119293
---


On Feb. 16, 2016, 3:42 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 16, 2016, 3:42 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by advance allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> Before this patch:
> ```
> [   OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [   OK ] FetcherCacheTest.LocalCached (1728 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
> 
> After this patch:
> ```
> [   OK ] FetcherCacheTest.LocalUncached (984 ms)
> [   OK ] FetcherCacheTest.LocalCached (1750 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1043 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2723 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 16, 2016, 11:42 a.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by advance allocation_interval.


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

Before this patch:
```
[   OK ] FetcherCacheTest.LocalUncached (1065 ms)
[   OK ] FetcherCacheTest.LocalCached (1728 ms)
[   OK ] FetcherCacheTest.CachedFallback (1105 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```

After this patch:
```
[   OK ] FetcherCacheTest.LocalUncached (984 ms)
[   OK ] FetcherCacheTest.LocalCached (1750 ms)
[   OK ] FetcherCacheTest.CachedFallback (1043 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2723 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 16, 2016, 11:41 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Change the allocation interval to 500 ms.


Summary (updated)
-

Speed up FetcherCache test cases by reduce allocation_interval.


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
---

Speed up FetcherCache test cases by advance allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing (updated)
---

Before this patch:
```
[   OK ] FetcherCacheTest.LocalUncached (1065 ms)
[   OK ] FetcherCacheTest.LocalCached (1728 ms)
[   OK ] FetcherCacheTest.CachedFallback (1105 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```

After this patch:
```
[   OK ] FetcherCacheTest.LocalUncached (984 ms)
[   OK ] FetcherCacheTest.LocalCached (1750 ms)
[   OK ] FetcherCacheTest.CachedFallback (1043 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2723 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
```


Thanks,

haosdent huang

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

(Updated Feb. 16, 2016, 11:39 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Rebase


Summary (updated)
-

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description (updated)
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
---

Before

```
[   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[--] 1 test from FetcherCacheTest (4516 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[--] 1 test from FetcherCacheTest (3602 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Feb. 16, 2016, 11:39 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Address @bbannier and @alex-mesos comments.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
---

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2524 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (873 ms)
[   OK ] FetcherCacheTest.LocalCached (1609 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```

Also test the recovery test manually:

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Bernd Mathiske]

> On Feb. 16, 2016, 3:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?
> 
> haosdent huang wrote:
> Sure!

Not writing to disk costs less time.

If a test does not attempt recovery, then whatever would be checkpointed never 
gets used.

Only one test attempts/tests recovery so far. In this test we do apply 
checkpointing. So it does get tested, but we don't need to test the writing 
part of it in every other test.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 9, 2016, 4:48 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 9, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[haosdent huang]

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?

Sure!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 10, 2016, 12:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 10, 2016, 12:48 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119291
---




src/tests/fetcher_cache_tests.cpp (line 115)


Please add a virtual dtr here for completeness, i.e., `virtual 
~FetcherCacheTest() = default;`.



src/tests/fetcher_cache_tests.cpp (line 147)


Maybe something like "Whether to checkpoint frameworks." instead?



src/tests/fetcher_cache_tests.cpp (line 148)


This should be `const`, i.e., `virtual bool checkpoint() const`.



src/tests/fetcher_cache_tests.cpp (line 199)


`this->` is redundant, please remove.


- Benjamin Bannier


On Feb. 10, 2016, 1:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 10, 2016, 1:48 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

[haosdent huang]

> On Feb. 16, 2016, 11:02 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 422
> > 
> >
> > In some fetcher cache tests, we specifically want to find out if 
> > concurrent execution of launching taks works. Settling the clock serializes 
> > this and thus disables some of desired the testing.
> > 
> > How about shortening the allocation interval and not playing with the 
> > clock?

Got it, how about change to 500ms?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119293
---


On Feb. 10, 2016, 4:17 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 10, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by advance allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> Before this patch:
> ```
> [   OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [   OK ] FetcherCacheTest.LocalCached (1728 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
> 
> After this patch:
> ```
> [   OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [   OK ] FetcherCacheTest.LocalCached (1693 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

[Abhishek Dasgupta]

> On Feb. 16, 2016, 10:24 a.m., Klaus Ma wrote:
> > include/mesos/mesos.proto, line 261
> > 
> >
> > Do you mean framework can filter `killing` state? I thinke this's not 
> > necessary.

No. This is framework capability. We intend to use TASK_KILLING state when a 
killTask is issued. So the framework that doesn't understand TASK_KILLING, for 
them only TASK_KILLED will be issued. But the frameworks that has 
TASK_KILLING_STATE capability, for them TASK_KILLING will be issued before a 
TASK_KILLED is issued.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43488/#review119288
---


On Feb. 16, 2016, 8:25 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43488/
> ---
> 
> (Updated Feb. 16, 2016, 8:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding framework capability for TASK_KILLING.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>