Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120273
---



Some doc may also need to be changed by removing the ssl related 
configurations, such as 

https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.json.md
https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.md
https://github.com/apache/mesos/blob/master/docs/configuration.md


src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 158)


what about highlighting the words with `` but not ''?



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (lines 236 
- 237)


What about keep this log but update it to "Fetching layer "



src/tests/containerizer/provisioner_docker_tests.cpp (line 325)


most of the test with docker images are now using `alpine`


- Guangya Liu


On 二月 23, 2016, 12:54 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> ---
> 
> (Updated 二月 23, 2016, 12:54 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the second step of cleaning/simplying the docker registry puller code.
> 
> The new code uses the uri::Fetcher to download docker manifest and blobs 
> (instead of writting our own http logic which requires enabling of SSL for 
> Mesos).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 5b2d72c22fcbcc379b4901607cf3eb682de66206 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> a239b97557ad20353c67050dbc89ef16da898330 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> bccbac3357cf942446604e6cf5d16c3d594b 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 3fcf1471a035e35a2cac22442655ad65a84a9793 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 2f1d3e002140f34c646aab445a419c9c3d712f99 
>   src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
>   src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
>   src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4db6793a21abbb7ea4de0d0fca0431237d38d013 
> 
> Diff: https://reviews.apache.org/r/43860/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43816/#review120272
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 22, 2016, 3:11 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43816/
> ---
> 
> (Updated Feb. 22, 2016, 3:11 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/frameworks` master endpoint to use jsonify.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
> 
> Diff: https://reviews.apache.org/r/43816/diff/
> 
> 
> Testing
> ---
> 
> 1. make check
> 2. Verified that after introducing a bug into the jsonify version of 
> `frameworks()`, `make check` fails (i.e., the test suite covers the 
> `/frameworks` endpoint).
> 3. Compared output of `/frameworks` with old and new implementation on a test 
> Mesos installation to try to gauge correctness visually.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43801/#review120271
---




src/slave/containerizer/mesos/provisioner/docker/paths.hpp (line 32)


Why removing this? I think that this still exist as a temp directory when 
pulling docker image?



src/slave/containerizer/mesos/provisioner/docker/paths.hpp (lines 34 - 36)


Do we need to add layer.tar here?


- Guangya Liu


On 二月 20, 2016, 6:09 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43801/
> ---
> 
> (Updated 二月 20, 2016, 6:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Bugs: MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step of cleaning up the docker registry puller/client code 
> base. I did the following simplications:
> 
> 1) Simplify the paths functions. The getImageArchiveXXX functions are 
> redundant.
> 2) Simplify the Puller::pull interface. We just need to return layer ids and 
> no need to return path.
> 3) Used untar from command utils, and kill the same function in puller.cpp.
> 4) A lot of consistency fixes, including using the same type and name.
> 5) A lot of style fixes.
> 
> The next step will be to cleanup and refactor registry_puller to use uri 
> Fetcher (docker plugin) to download manifest and blobs (and kill registry 
> client).
> 
> Reviewers are recommended to look at the end version, instead of the diff.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 811c24b43f7aec9db406dd521770c6cd82097c92 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f3e7c042f2c9980f6274c8185ee8bb89a8b02002 
>   src/slave/containerizer/mesos/provisioner/docker/paths.hpp 
> d2b0cf95e5ed7664071484a27a2a1f9bafff70d6 
>   src/slave/containerizer/mesos/provisioner/docker/paths.cpp 
> 82d92a2a9cce181eb283395a32e93cbb1586703b 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 5b2d72c22fcbcc379b4901607cf3eb682de66206 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> a239b97557ad20353c67050dbc89ef16da898330 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> bccbac3357cf942446604e6cf5d16c3d594b 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 3fcf1471a035e35a2cac22442655ad65a84a9793 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 880e216e33dd178d0baa47d3958c84cda4d9e25e 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 2f1d3e002140f34c646aab445a419c9c3d712f99 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4db6793a21abbb7ea4de0d0fca0431237d38d013 
> 
> Diff: https://reviews.apache.org/r/43801/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43588/#review120270
---



Patch looks great!

Reviews applied: [43588]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 11:55 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43588/
> ---
> 
> (Updated Feb. 22, 2016, 11:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Klaus Ma.
> 
> 
> Bugs: MESOS-3986
> https://issues.apache.org/jira/browse/MESOS-3986
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator recovery tests in presence of quota.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43588/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43855: Added Appc fetcher support to store.

[Guangya Liu]

> On 二月 23, 2016, 5:21 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 288
> > 
> >
> > What about using a uuid like dir here? There might be duplicate 
> > "XX" under /tmp

The docker provisioner is also using same logic, it is reasonable as this will 
be managed by mesos provisioner.


> On 二月 23, 2016, 5:21 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 291
> > 
> >
> > If a uuid like dir, then it is better add it to the log message when 
> > error happens

Does it make sense to put the temporary fetch directory in the error message 
for better trouble shooting?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43855/#review120260
---


On 二月 22, 2016, 11:50 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43855/
> ---
> 
> (Updated 二月 22, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows store to fetch an image using Appc image fetcher when an
> image is not found in the cache. It also recursively fetches the dependencies
> for the image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 4b3829175f57fb9aea2478040d96f2f127cbc551 
> 
> Diff: https://reviews.apache.org/r/43855/diff/
> 
> 
> Testing
> ---
> 
> make check; local image server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 43854: Fixed chdir to an empty directory error.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/#review120268
---




src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 354)


Do we have tests to test the docker runtime isolator?


- Timothy Chen


On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43854/
> ---
> 
> (Updated Feb. 22, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed chdir to an empty directory error.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 
> 
> Diff: https://reviews.apache.org/r/43854/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> Tested with /mesos-execute --docker_image=busybox
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43855: Added Appc fetcher support to store.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43855/#review120260
---




src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 214)


What about using `` to highlight move/rename?

Same comments for others highlight.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 227)


s/We expect/Expect

Can you please add more comments for why only one directory is expected?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 240)


What about adding the image dir the log message for better trouble shooting?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 281)


What about using a uuid like dir here? There might be duplicate "XX" 
under /tmp



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 284)


If a uuid like dir, then it is better add it to the log message when error 
happens



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 296)


detailed failure here including both tmp and dest.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 327)


s/Fetches/Fetch



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 346)


alignment


- Guangya Liu


On 二月 22, 2016, 11:50 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43855/
> ---
> 
> (Updated 二月 22, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows store to fetch an image using Appc image fetcher when an
> image is not found in the cache. It also recursively fetches the dependencies
> for the image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 4b3829175f57fb9aea2478040d96f2f127cbc551 
> 
> Diff: https://reviews.apache.org/r/43855/diff/
> 
> 
> Testing
> ---
> 
> make check; local image server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 43854: Fixed chdir to an empty directory error.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/#review120261
---



Patch looks great!

Reviews applied: [43854]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43854/
> ---
> 
> (Updated Feb. 22, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed chdir to an empty directory error.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 
> 
> Diff: https://reviews.apache.org/r/43854/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> Tested with /mesos-execute --docker_image=busybox
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43868: Add a getter for master::Flags.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43868/
---

(Updated Feb. 23, 2016, 5:16 a.m.)


Review request for mesos, Guangya Liu and Qian Zhang.


Bugs: MESOS-3481
https://issues.apache.org/jira/browse/MESOS-3481


Repository: mesos


Description
---

MESOS-3481 Add const accessor to Master flags.


Diffs
-

  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 

Diff: https://reviews.apache.org/r/43868/diff/


Testing (updated)
---

Added one new unit test MasterTest::Flags

`make check` passed


Thanks,

Jay Guo

Review Request 43868: Add a getter for master::Flags.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43868/
---

Review request for mesos.


Repository: mesos


Description
---

MESOS-3481 Add const accessor to Master flags.


Diffs
-

  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 

Diff: https://reviews.apache.org/r/43868/diff/


Testing
---


Thanks,

Jay Guo

Re: Review Request 43868: Add a getter for master::Flags.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43868/
---

(Updated Feb. 23, 2016, 5:13 a.m.)


Review request for mesos.


Bugs: MESOS-3481
https://issues.apache.org/jira/browse/MESOS-3481


Repository: mesos


Description
---

MESOS-3481 Add const accessor to Master flags.


Diffs
-

  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 

Diff: https://reviews.apache.org/r/43868/diff/


Testing
---


Thanks,

Jay Guo

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/#review120256
---



Bad patch!

Reviews applied: [43615, 43630, 43629, 43614, 43613]

Failed command: ./support/apply-review.sh -n -r 43615

Error:
2016-02-23 04:03:48 URL:https://reviews.apache.org/r/43615/diff/raw/ 
[768554/768554] -> "43615.patch" [1]
error: patch failed: src/tests/reservation_endpoints_tests.cpp:1319
error: src/tests/reservation_endpoints_tests.cpp: patch does not apply
error: patch failed: src/tests/reservation_tests.cpp:53
error: src/tests/reservation_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11597/console

- Mesos ReviewBot


On Feb. 22, 2016, 9:33 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43615/
> ---
> 
> (Updated Feb. 22, 2016, 9:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Includes the following changes:
> 
> * Added the `` header where appropriate.
> * Added the namespace `using process::Owned;` where appropriate.
> * Generally replaced `Try` with `Owned`.  And 
> `Try` with `Owned`.
> * Added the (now required) `MasterDetector` argument to all slaves.  Before, 
> this was fetched from the first master in `Cluster`.
> * Removed `Shutdown();` from all tests.
> * Replaced `Stop(...)` with the appropriate master/slave destruction calls.
> * Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
> launchers, etc).
> * Replace `CHECK` in tests with `ASSERT`.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
>   src/tests/command_executor_tests.cpp 
> 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 
>   src/tests/container_logger_tests.cpp 
> 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 6a60962b4593b3521c182c7320331743ccffd4ba 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 983a6be160aefe5a32acb6111bb3c85230ec 
>   src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
>   src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
>   src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
>   src/tests/executor_http_api_tests.cpp 
> 36a042ed103271ca873450236f39a8152fbbf07e 
>   src/tests/fault_tolerance_tests.cpp 
> 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
>   src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/master_contender_detector_tests.cpp 
> 255ab8119a04b55bb4f1b61dee19c4be64499376 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
>   src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d41178eb41df519073fc0890c5716bbc9fed6ad2 
>   src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 
>   src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
>   src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 6069ca1e9ed278459c5182e438417e95955b1924 
>   src/tests/persistent_volume_tests.cpp 
> e169e1b141a38dc389eefd42c11a078c413123d5 
>   src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
>   src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
>   

Re: Review Request 43849: Fixed typos in subprocess.cpp comments.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43849/#review120255
---



Patch looks great!

Reviews applied: [43849]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 8:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43849/
> ---
> 
> (Updated Feb. 22, 2016, 8:24 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in subprocess.cpp comments.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
> 
> Diff: https://reviews.apache.org/r/43849/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 43864: Fix typo of roles doc.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/
---

Review request for mesos and Neil Conway.


Repository: mesos


Description
---

Fix typo of roles doc.


Diffs
-

  docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
  docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 

Diff: https://reviews.apache.org/r/43864/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 43838: Added note about not implemented requestResources call.

[Joerg Schad]

> On Feb. 23, 2016, 3 a.m., Klaus Ma wrote:
> > docs/app-framework-development-guide.md, line 172
> > 
> >
> > It seems scheduler did not send `ResourceRequestMessage` to the master; 
> > so other allocator also can not handle it. I'd like to say Master ignore 
> > this call.

What exectly are you referring to as Scheduler? The SchedulerDriver? I believe 
the java one might ignore it but not sure for all others. I will check.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120253
---


On Feb. 22, 2016, 4:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated Feb. 22, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43838: Added note about not implemented requestResources call.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120253
---




docs/app-framework-development-guide.md (line 172)


It seems scheduler did not send `ResourceRequestMessage` to the master; so 
other allocator also can not handle it. I'd like to say Master ignore this call.


- Klaus Ma


On Feb. 23, 2016, 12:54 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated Feb. 23, 2016, 12:54 a.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

[Guangya Liu]

> On 二月 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 135
> > 
> >
> > Why not merge this and above `Scheduler API` into one section?
> 
> Joerg Schad wrote:
> I wanted to keep the Scheduler API i.e. the callbacks the scheduler has 
> to implement and the calls it can make (i.e. SchedulerDriver API) seperate. 
> Does that make sense?

What about name this part as Scheduler Driver API?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43819/#review120091
---


On 二月 22, 2016, 3 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43819/
> ---
> 
> (Updated 二月 22, 2016, 3 a.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Scheduler-Driver API to app-framework-development-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
> 
> Diff: https://reviews.apache.org/r/43819/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and 
> via docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43838: Added note about not implemented requestResources call.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120251
---



Seems you are losing python interface.

- Guangya Liu


On 二月 22, 2016, 4:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated 二月 22, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

> On Feb. 19, 2016, 10:24 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp, lines 1530-1531
> > 
> >
> > Let's pull at least the implementation out of the header. You may look 
> > at maintenance and quota for inspiration : ).
> > 
> > Going further, how about extracting registry part into a separate 
> > patch? It will make reviewing easier. Also, it would be great to see some 
> > registry tests as well.
> 
> Yongqiao Wang wrote:
> Thanks Alex. Personally, I find it more difficult to review a chain of 
> commits than a single, a single patch can give a whole picture of a feature 
> at a time. In addition, the main reason is Adam has completed to review this 
> patch, if I split it into some small patches, then maybe Adam needs to review 
> them again before commiting them. Can we keep this patch except make the 
> smaller chagnes for addressing comments? can you just review the changes to 
> each file one at a time in the this commit? Based on your comments, I will 
> post another patch for registery test later.
> 
> For moving the implementation out of the header, I will update this 
> patches later.
> 
> Adam B wrote:
> I agree with Yongqioa. While patches with <100 lines are quicker/easier 
> to review, this patch is only about 300 new/changed lines, and I like to 
> think I've reviewed it pretty thoroughly already. Please review the patch as 
> is, and let us know if there's anything for which we should block the commit.
> We can pull the implementation out of the header in a separate, follow-up 
> patch.
> We can also add additional registry tests and/or authz tests in a 
> follow-up patch, if they aren't already covered in 
> https://reviews.apache.org/r/41790/
> In the future, we can encourage Yongqiao to break up larger patches 
> earlier in the review process.

I have posted another patch https://reviews.apache.org/r/43863/ to move the 
implementation of updateWeights operation out of the header.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review119857
---


On Feb. 14, 2016, 12:02 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
> 
> (Updated Feb. 14, 2016, 12:02 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduce HTTP endpoint /weights for updating weight.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 5ee3c7afadd131802c93febbb6b4dbad069c2d81 
>   include/mesos/authorizer/authorizer.proto 
> 226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
>   src/authorizer/local/authorizer.hpp 
> c7321c276d566eca6a91f45c546468bea1b0da15 
>   src/authorizer/local/authorizer.cpp 
> 9557bbdf68ff182c4538bbf70cee576d717abc05 
>   src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
>   src/master/weights_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/41681/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
> --weights="role1=4.2,role2=3.1" --authenticate_http 
> --credentials=/opt/credentials.json  >> /tmp/mesos-master.log 2>&1 &)
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [ ], 
> "name": "*", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role1", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 4.2
> }, 
> {
> "frameworks": [ ], 
> "name": "role2", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 3.1
>

Review Request 43863: Move the implementation of updateWeights out of header.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43863/
---

Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Move the implementation of updateWeights out of header.


Diffs
-

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
  src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
  src/master/weights.hpp PRE-CREATION 
  src/master/weights.cpp PRE-CREATION 
  src/master/weights_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43863/diff/


Testing
---

make && make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/#review120244
---



Patch looks great!

Reviews applied: [43657, 43658, 43659, 43660, 43661, 43662, 43664, 43667, 
39372, 43846, 43847]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 8:20 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43847/
> ---
> 
> (Updated Feb. 22, 2016, 8:20 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. This are a follow up to the patches for MESOS-3570 around 
> modifying the scheduler library to use HTTP Pipelining.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43847/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review120238
---


Fix it, then Ship it!





src/tests/reservation_tests.cpp (line 2000)


one period


- Guangya Liu


On 二月 23, 2016, 12:16 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated 二月 23, 2016, 12:16 a.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> It may be desirable to remove this requirement; this improvement is tracked 
> in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> A new test case was added to `ReservationTest.NoAuthentication`.
> 
> `make check` was used to test on OSX, both with and without SSL enabled.
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Guangya Liu]

> On 二月 18, 2016, 6:57 a.m., Guangya Liu wrote:
> > src/master/validation.cpp, lines 692-711
> > 
> >
> > Can you please add some test cases to cover those scenarios?
> > 
> > 1) authentication is enabled and reservation does not have principal.
> > 2) authentication is enabled and reservation pricipal does not same as 
> > authentication principal.
> > 3) authentication is disabled but reservation has principal.
> 
> Guangya Liu wrote:
> Seems 2) was covered by `ReservationEndpointsTest, NonMatchingPrincipal`, 
> but 1) and 3) was not covered for now.
> 
> Greg Mann wrote:
> Good call, I added a test case to the `ReservationTest` tests for #3.
> 
> Due to the way authentication works, I'm not sure that test case #1 is 
> necessary. When authentication is enabled, HTTP endpoints require a principal 
> and frameworks must supply a principal to register. The best we could do to 
> test #1 is to have a request with an authenticated principal but no principal 
> in `ReservationInfo`, which is really just testing that a request with 
> non-matching principals will fail. The non-matching principal case is covered 
> by `ReservationEndpointsTest.NonMatchingPrincipal`. What do you think?

fair enough, thanks Greg.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review119589
---


On 二月 23, 2016, 12:16 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated 二月 23, 2016, 12:16 a.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> It may be desirable to remove this requirement; this improvement is tracked 
> in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> A new test case was added to `ReservationTest.NoAuthentication`.
> 
> `make check` was used to test on OSX, both with and without SSL enabled.
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review120233
---


Ship it!




Ship It!

- Michael Park


On Feb. 23, 2016, 12:16 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated Feb. 23, 2016, 12:16 a.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> It may be desirable to remove this requirement; this improvement is tracked 
> in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> A new test case was added to `ReservationTest.NoAuthentication`.
> 
> `make check` was used to test on OSX, both with and without SSL enabled.
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43641: Removed unnecessary parameter from validation function.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120232
---


Ship it!




Ship It!

- Michael Park


On Feb. 22, 2016, 6:43 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43641/
> ---
> 
> (Updated Feb. 22, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary parameter from validation function.
> 
> Since unreserve operations are now possible without a principal, the `bool 
> hasPrincipal` parameter to the Unreserve operation validation function is no 
> longer necessary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
>   src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
>   src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
> 
> Diff: https://reviews.apache.org/r/43641/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120231
---


Ship it!




Ship It!

- Michael Park


On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> ---
> 
> (Updated Feb. 22, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
> 
> Diff: https://reviews.apache.org/r/43642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/
---

Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-4261 and MESOS-4499
https://issues.apache.org/jira/browse/MESOS-4261
https://issues.apache.org/jira/browse/MESOS-4499


Repository: mesos


Description
---

This is the second step of cleaning/simplying the docker registry puller code.

The new code uses the uri::Fetcher to download docker manifest and blobs 
(instead of writting our own http logic which requires enabling of SSL for 
Mesos).


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
5b2d72c22fcbcc379b4901607cf3eb682de66206 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
a239b97557ad20353c67050dbc89ef16da898330 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
bccbac3357cf942446604e6cf5d16c3d594b 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
3fcf1471a035e35a2cac22442655ad65a84a9793 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
2f1d3e002140f34c646aab445a419c9c3d712f99 
  src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
  src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
  src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
4db6793a21abbb7ea4de0d0fca0431237d38d013 

Diff: https://reviews.apache.org/r/43860/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 43859: Fix invalid usage of ATOMIC_FLAG_INIT (MESOS-4602).

[Yong Tang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43859/
---

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-4602
https://issues.apache.org/jira/browse/MESOS-4602


Repository: mesos


Description
---

Fix invalid usage of ATOMIC_FLAG_INIT (MESOS-4602).


Diffs
-

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
5a987ea04ce8f1ebab8e1cc1d796e5243532271d 

Diff: https://reviews.apache.org/r/43859/diff/


Testing
---


Thanks,

Yong Tang

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review120223
---




support/push-reviews.py (lines 14 - 15)


I would at least pass this as a flag right now rather than jsut adding a 
TODO. Otherwise people that prefer to close with the commit message won't be 
able to use your script at all.



support/push-reviews.py (lines 123 - 125)


Shouldn't this also be protected by the `if not options['dry_run']` check?


- Kevin Klues


On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 22, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Kevin Klues]

> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > In general, I prefer scripts with a bunch of helper functions and a compact 
> > main() that steps through each of them. I'm not sure what the general 
> > concensus for the Mesos code base is, but I generally find this easier to 
> > walk through.  Example: support/generate-endpoint-help.py
> 
> Vinod Kone wrote:
> In our C++ code base we generally prefer procedural style as it requires 
> fewer context switches. We haven't officially defined the style for Python 
> code in our code base, but I would guess we want to be similar. 
> 
> That said if something makes sense to be a function (e.g, reuse) we 
> should extract it into a function. I've added a main and refactored a bit. 
> Let me know if it looks ok.

Looks great.


> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 27-30
> > 
> >
> > Do we have guidelines for indentation here?  When writing the 
> > support/generate-endpoints-help.py script, bmahler suggested something 
> > different than what you have here.
> 
> Vinod Kone wrote:
> I'm trying to be close to our C++ style. This is how it is in 
> apply-reviews.py too. 
> 
> What did bmahler suggest?

He had suggested putting all parameters on the next line, indedented by 4 
spaces instead of directly after the pranthesis. e.g.

```
parser.add_argument(
'-n',
'--dry-run',
action='store_true',
help='Perform a dry run.')
```


> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 32-39
> > 
> >
> > If the tracking branch is reauired to be of the form `remote/branch` 
> > (as mentioned in a later comment), what do we need the `remote` flag for?
> 
> Vinod Kone wrote:
> "tracking branch" is mainly required to figure out the new commits to 
> push. Technically it can be just "master". "remote" is to figure out the 
> upstream to push to. If remote is not specified, we try to deduce it from 
> "tracking branch", in which case we expect it to be a "remote tracking 
> branch". 
> 
> But I agree it's all confusing. I will kill both "--remote" and 
> "--tracking_branch" and expect users to run this from "master" branch for 
> simplicity.

Yeah, this is simpler because otherwise you could run into a situation where 
tracking branch was something like "klueska/my-branch" and remote was set to 
"origin", causing a conflict that we would need to check for.  It's hard for me 
to imagine a situation where you would be wanting to run this script anywhere 
other than master, so this change makes sense.


> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 108-112
> > 
> >
> > As we close the review, we should also post a comment to reviewboard 
> > with the commit message we actually pushed to master.
> > 
> > You can use the --description flag:
> > 
> > https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/close/
> 
> Vinod Kone wrote:
> I'll make a TODO for now as committers don't currently/always set the 
> commit message on RB.

I think we should add the option as a command line flag now, so that people who 
like to include the commit message when closing can still take advantage of 
this script.  If we later decide that *everyone* should always include the 
commit message, we can remove the flag and force it to be set.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review119507
---


On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 22, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43858: Updated the website for 0.27.1 release.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43858/#review120221
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 23, 2016, 12:25 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43858/
> ---
> 
> (Updated Feb. 23, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
>   site/source/blog/2016-02-22-mesos-0-27-1-released.md PRE-CREATION 
>   site/source/downloads.html.md ba5fe732b70a6fbad50a94fdd227e94108cf2009 
>   site/source/index.html.md 3988fa044a264d988b832494490be3956078ff90 
> 
> Diff: https://reviews.apache.org/r/43858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 43858: Updated the website for 0.27.1 release.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43858/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs
-

  docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
  site/source/blog/2016-02-22-mesos-0-27-1-released.md PRE-CREATION 
  site/source/downloads.html.md ba5fe732b70a6fbad50a94fdd227e94108cf2009 
  site/source/index.html.md 3988fa044a264d988b832494490be3956078ff90 

Diff: https://reviews.apache.org/r/43858/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/
---

(Updated Feb. 23, 2016, 12:16 a.m.)


Review request for mesos, Michael Park and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Allowed dynamic reservation without a principal.

The `ReservationInfo.principal` field has been migrated to `optional`, which 
means we can now allow dynamic reservation and unreservation without a 
principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
endpoints when HTTP authentication is disabled.

Note that we still require that frameworks/operators set the 
`ReservationInfo.principal` field to match their own principal, if present. It 
may be desirable to remove this requirement; this improvement is tracked in 
MESOS-4696.


Diffs (updated)
-

  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 

Diff: https://reviews.apache.org/r/43639/diff/


Testing
---

A new test case was added to `ReservationTest.NoAuthentication`.

`make check` was used to test on OSX, both with and without SSL enabled.

Also manually reserved/unreserved resources using curl, with a command like 
this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
"role": "ads", "reservation": { } } ]'  -X POST 
http://127.0.0.1:5050/master/reserve`

Inspecting `/master/state` before & after these operations confirmed that the 
reserve/unreserve operations were successful.


Thanks,

Greg Mann

Re: Review Request 43658: Modified the received callback argument to be ref.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43658/#review120218
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 17, 2016, 7:23 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43658/
> ---
> 
> (Updated Feb. 17, 2016, 7:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
> 
> Diff: https://reviews.apache.org/r/43658/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43657/#review120217
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 18, 2016, 4:54 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43657/
> ---
> 
> (Updated Feb. 18, 2016, 4:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the detector pointer to `process::Owned` so that it is cleaned up later.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
> 
> Diff: https://reviews.apache.org/r/43657/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43588/
---

(Updated Feb. 22, 2016, 11:51 p.m.)


Review request for mesos, Alexander Rukletsov and Klaus Ma.


Changes
---

Addressed reviews.


Bugs: MESOS-3986
https://issues.apache.org/jira/browse/MESOS-3986


Repository: mesos


Description
---

Added allocator recovery tests in presence of quota.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43588/diff/


Testing
---

make check


Thanks,

Joerg Schad

Review Request 43855: Added Appc fetcher support to store.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43855/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

This change allows store to fetch an image using Appc image fetcher when an
image is not found in the cache. It also recursively fetches the dependencies
for the image.


Diffs
-

  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
4b3829175f57fb9aea2478040d96f2f127cbc551 

Diff: https://reviews.apache.org/r/43855/diff/


Testing
---

make check; local image server.


Thanks,

Jojy Varghese

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120215
---



Patch looks great!

Reviews applied: [43639, 43641, 43642]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> ---
> 
> (Updated Feb. 22, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
> 
> Diff: https://reviews.apache.org/r/43642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120214
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> ---
> 
> (Updated Feb. 22, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
> 
> Diff: https://reviews.apache.org/r/43642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43641: Removed unnecessary parameter from validation function.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120213
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 22, 2016, 6:43 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43641/
> ---
> 
> (Updated Feb. 22, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary parameter from validation function.
> 
> Since unreserve operations are now possible without a principal, the `bool 
> hasPrincipal` parameter to the Unreserve operation validation function is no 
> longer necessary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
>   src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
>   src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
> 
> Diff: https://reviews.apache.org/r/43641/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review120207
---




src/tests/reservation_endpoints_tests.cpp (line 1269)


s/No/Without/ ?



src/tests/reservation_tests.cpp (lines 1860 - 1866)


can you split this into 2 tests, one with principal and another without 
principal?



src/tests/reservation_tests.cpp (line 1876)


this doesnt have to change?



src/tests/reservation_tests.cpp (line 1979)


offer with reserved resources?



src/tests/reservation_tests.cpp (line 1997)


offer without reserved resources.


- Vinod Kone


On Feb. 22, 2016, 6:39 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated Feb. 22, 2016, 6:39 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> It may be desirable to remove this requirement; this improvement is tracked 
> in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> A new test case was added to `ReservationTest.NoAuthentication`.
> 
> `make check` was used to test on OSX, both with and without SSL enabled.
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 37168: Added example for dynamic reservation features.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review120212
---




src/examples/dynamic_reservation_framework.cpp (line 94)


Does it make sense to add a comment somewhere explaing the different states 
and transitions between them?



src/examples/dynamic_reservation_framework.cpp (line 217)


LOG(ERROR) << message; or at least add output indicating this is an error.



src/tests/dynamic_reservation_framework_test.sh (line 28)


Thy do we need this? Comparing to persistent_volume_framework_test.sh



src/tests/dynamic_reservation_framework_test.sh (line 30)


Thy do we need this? Comparing to persistent_volume_framework_test.sh



src/tests/examples_tests.cpp (line 36)


additional blank line.


- Joerg Schad


On Feb. 21, 2016, 2:07 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated Feb. 21, 2016, 2:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120211
---


Ship it!




Ship It!

- Neil Conway


On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> ---
> 
> (Updated Feb. 22, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
> 
> Diff: https://reviews.apache.org/r/43642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review120209
---


Fix it, then Ship it!





src/tests/reservation_tests.cpp (line 1851)


This should probably be split into two test cases, since AFAICS the first 
and second halves of the test don't share any state.



src/tests/reservation_tests.cpp (line 1949)


Not yours, but I would probably opt for `using Process::Clock;` at the top 
of the file.


- Neil Conway


On Feb. 22, 2016, 6:39 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated Feb. 22, 2016, 6:39 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> It may be desirable to remove this requirement; this improvement is tracked 
> in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> A new test case was added to `ReservationTest.NoAuthentication`.
> 
> `make check` was used to test on OSX, both with and without SSL enabled.
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43641: Removed unnecessary parameter from validation function.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120210
---


Ship it!




Ship It!

- Neil Conway


On Feb. 22, 2016, 6:43 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43641/
> ---
> 
> (Updated Feb. 22, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary parameter from validation function.
> 
> Since unreserve operations are now possible without a principal, the `bool 
> hasPrincipal` parameter to the Unreserve operation validation function is no 
> longer necessary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
>   src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
>   src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
> 
> Diff: https://reviews.apache.org/r/43641/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43801/#review120208
---


Ship it!




Ship It!

- Gilbert Song


On Feb. 19, 2016, 10:09 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43801/
> ---
> 
> (Updated Feb. 19, 2016, 10:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Bugs: MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step of cleaning up the docker registry puller/client code 
> base. I did the following simplications:
> 
> 1) Simplify the paths functions. The getImageArchiveXXX functions are 
> redundant.
> 2) Simplify the Puller::pull interface. We just need to return layer ids and 
> no need to return path.
> 3) Used untar from command utils, and kill the same function in puller.cpp.
> 4) A lot of consistency fixes, including using the same type and name.
> 5) A lot of style fixes.
> 
> The next step will be to cleanup and refactor registry_puller to use uri 
> Fetcher (docker plugin) to download manifest and blobs (and kill registry 
> client).
> 
> Reviewers are recommended to look at the end version, instead of the diff.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 811c24b43f7aec9db406dd521770c6cd82097c92 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f3e7c042f2c9980f6274c8185ee8bb89a8b02002 
>   src/slave/containerizer/mesos/provisioner/docker/paths.hpp 
> d2b0cf95e5ed7664071484a27a2a1f9bafff70d6 
>   src/slave/containerizer/mesos/provisioner/docker/paths.cpp 
> 82d92a2a9cce181eb283395a32e93cbb1586703b 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 5b2d72c22fcbcc379b4901607cf3eb682de66206 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> a239b97557ad20353c67050dbc89ef16da898330 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> bccbac3357cf942446604e6cf5d16c3d594b 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 3fcf1471a035e35a2cac22442655ad65a84a9793 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 880e216e33dd178d0baa47d3958c84cda4d9e25e 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 2f1d3e002140f34c646aab445a419c9c3d712f99 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4db6793a21abbb7ea4de0d0fca0431237d38d013 
> 
> Diff: https://reviews.apache.org/r/43801/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 43854: Fixed chdir to an empty directory error.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Fixed chdir to an empty directory error.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 

Diff: https://reviews.apache.org/r/43854/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)

Tested with /mesos-execute --docker_image=busybox


Thanks,

Gilbert Song

Re: Review Request 43854: Fixed chdir to an empty directory error.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/
---

(Updated Feb. 22, 2016, 2:52 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Fixed chdir to an empty directory error.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 

Diff: https://reviews.apache.org/r/43854/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)

Tested with /mesos-execute --docker_image=busybox


Thanks,

Gilbert Song

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/#review120201
---



Patch looks great!

Reviews applied: [43796]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 6:26 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43796/
> ---
> 
> (Updated Feb. 22, 2016, 6:26 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4660
> https://issues.apache.org/jira/browse/MESOS-4660
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `cgroups/net_cls` isolator.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
> 
> Diff: https://reviews.apache.org/r/43796/diff/
> 
> 
> Testing
> ---
> 
> Built the web-site using docker, and proof read the website and links on 
> localhost.
> 
> Verified all the links embedded in markdown work.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43850: Added a wait for killed tast to prevent misscount of events.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/#review120196
---




src/tests/containerizer/memory_pressure_tests.cpp (line 231)


Maybe rename this to runningStatus?



src/tests/containerizer/memory_pressure_tests.cpp (line 292)


Do we still need this at this point?


- Joerg Schad


On Feb. 22, 2016, 9:12 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43850/
> ---
> 
> (Updated Feb. 22, 2016, 9:12 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because
> the tracker of the cgroups pressure counter is not finished by the time the
> expectations are set.
> 
> This patch ensures that the killed status has arrived before checking for the
> pressure values.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
> 
> Diff: https://reviews.apache.org/r/43850/diff/
> 
> 
> Testing
> ---
> 
> On a CentOS 6.7 virtual box machine:
> 
> ```bash
> MESOS_VERBOSE=1 sudo .libs/mesos-tests 
> --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
> --gtest_repeat=300 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/
---

(Updated Feb. 22, 2016, 1:33 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rebase and...

* Addressed renaming of MasterTest.FrameworkWebUIUrlandCapabilities -> 
MasterTest.StateEndpointFrameworkInfo.
* Modified new CommandExecutorTests.
* Modified new DockerContainerizerTest.ROOT_DOCKER_TaskKillingCapability.

Re-ran tests and updated results.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Includes the following changes:

* Added the `` header where appropriate.
* Added the namespace `using process::Owned;` where appropriate.
* Generally replaced `Try` with `Owned`.  And 
`Try` with `Owned`.
* Added the (now required) `MasterDetector` argument to all slaves.  Before, 
this was fetched from the first master in `Cluster`.
* Removed `Shutdown();` from all tests.
* Replaced `Stop(...)` with the appropriate master/slave destruction calls.
* Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
launchers, etc).
* Replace `CHECK` in tests with `ASSERT`.


Diffs (updated)
-

  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/command_executor_tests.cpp 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 
  src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f 
  src/tests/containerizer/docker_containerizer_tests.cpp 
a299c9e0744b5657984e5bb0afbe4874a266ddb6 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
6a60962b4593b3521c182c7320331743ccffd4ba 
  src/tests/containerizer/isolator_tests.cpp 
653b037c489072f43e53dec01a811a9249dcd660 
  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
  src/tests/containerizer/port_mapping_tests.cpp 
983a6be160aefe5a32acb6111bb3c85230ec 
  src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
  src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
  src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
  src/tests/executor_http_api_tests.cpp 
36a042ed103271ca873450236f39a8152fbbf07e 
  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 
  src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 
  src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
  src/tests/persistent_volume_endpoints_tests.cpp 
6069ca1e9ed278459c5182e438417e95955b1924 
  src/tests/persistent_volume_tests.cpp 
e169e1b141a38dc389eefd42c11a078c413123d5 
  src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/registrar_zookeeper_tests.cpp 
3df9779ee5d076e16f6a538326693a36f986b6d0 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 
  src/tests/scheduler_event_call_tests.cpp 
bd8920fa9d5475e5f6533c8424ebff1588bfe645 
  src/tests/scheduler_http_api_tests.cpp 
9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
  src/tests/slave_recovery_tests.cpp 

Review Request 43850: Added a wait for killed tast to prevent misscount of events.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/
---

Review request for mesos, Bernd Mathiske and Joseph Wu.


Repository: mesos


Description
---

Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because
the tracker of the cgroups pressure counter is not finished by the time the
expectations are set.

This patch ensures that the killed status has arrived before checking for the
pressure values.


Diffs
-

  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 

Diff: https://reviews.apache.org/r/43850/diff/


Testing
---

On a CentOS 6.7 virtual box machine:

```bash
MESOS_VERBOSE=1 sudo .libs/mesos-tests 
--gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
--gtest_repeat=300 --gtest_break_on_failure
```


Thanks,

Alexander Rojas

Re: Review Request 43798: Added overview section to upgrades.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43798/#review120195
---



Patch looks great!

Reviews applied: [43792, 43798]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 6:20 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43798/
> ---
> 
> (Updated Feb. 22, 2016, 6:20 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-4381
> https://issues.apache.org/jira/browse/MESOS-4381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overview section to upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43798/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and 
> docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 43849: Fixed typos in subprocess.cpp comments.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43849/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Fixed typos in subprocess.cpp comments.


Diffs
-

  3rdparty/libprocess/src/subprocess.cpp 
44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 

Diff: https://reviews.apache.org/r/43849/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 43846: Added support for specifying detector to the callback interface.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/
---

(Updated Feb. 22, 2016, 8:24 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added JIRA issue.


Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686


Repository: mesos


Description
---

This change adds support for passing in a master detector object to the 
callback interface. This can be used for testing master failover scenarios 
similar to how the driver already does it.


Diffs
-

  include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1 
  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 

Diff: https://reviews.apache.org/r/43846/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43629/
---

(Updated Feb. 22, 2016, 12:22 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rebase and address conflict in FetcherCacheTests.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with a slightly different 
pattern.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp e10b3f7ebc21c8c1095564fc40f123087dcf320e 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 

Diff: https://reviews.apache.org/r/43629/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Review Request 43847: Added master/scheduler failover tests for scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686


Repository: mesos


Description
---

See summary. This are a follow up to the patches for MESOS-3570 around 
modifying the scheduler library to use HTTP Pipelining.


Diffs
-

  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43847/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43846: Added support for specifying detector to the callback interface.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

This change adds support for passing in a master detector object to the 
callback interface. This can be used for testing master failover scenarios 
similar to how the driver already does it.


Diffs
-

  include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1 
  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 

Diff: https://reviews.apache.org/r/43846/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39372: Introduced a callback interface for testing the scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39372/
---

(Updated Feb. 22, 2016, 8:19 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Make this stale review for scheduler callbacks alive again.


Summary (updated)
-

Introduced a callback interface for testing the scheduler library.


Bugs: MESOS-3339
https://issues.apache.org/jira/browse/MESOS-3339


Repository: mesos


Description (updated)
---

This change adds a new callback based testing interface for the scheduler 
library similar to the already existing one for the executor library.

This gets rid of the following hack:
```cpp

// Enqueues all received events into a libprocess queue.
ACTION_P(Enqueue, queue)
{
  std::queue events = arg0;
  while (!events.empty()) {
// Note that we currently drop HEARTBEATs because most of these tests
// are not designed to deal with heartbeats.
// TODO(vinod): Implement DROP_HTTP_CALLS that can filter heartbeats.
if (events.front().type() == Event::HEARTBEAT) {
  VLOG(1) << "Ignoring HEARTBEAT event";
} else {
  queue->put(events.front());
}
events.pop();
  }
}

```

New way ( similar to what we do for the driver implementation )
```cpp

EXPECT_CALL(callbacks, heartbeat())
.WillRepeatedly(Return()); // Ignore heartbeats.

```


Diffs (updated)
-

  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 

Diff: https://reviews.apache.org/r/39372/diff/


Testing (updated)
---

make check (Would modify the tests to use the new interface in a subsequent 
change)


Thanks,

Anand Mazumdar

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43662/
---

(Updated Feb. 22, 2016, 8:19 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

Previously, the scheduler library used to chain calls on previous call 
responses. This was inherently slow. This change adds support for pipelining 
all calls to the master on a single connection via the `http::Connection` 
abstraction in libprocess.

This change also adds support for handling various error scenarios when we 
notice a disconnection instead of just relying on the master detector for 
invoking the `disconnected` callback.


Diffs (updated)
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43662/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

[Neil Conway]

> On Feb. 22, 2016, 7:30 p.m., Neil Conway wrote:
> > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 286
> > 
> >
> > "Remembering all of these rules is simply too complicated, so we opt to 
> > use a more clever solution."
> 
> Benjamin Bannier wrote:
> Stongly disagree: *clever* carries a negative connotation, while *solve 
> properly* is positive.

"So we opt to solve the problem in a different manner." is fine with me also -- 
I was more suggesting the sentence flow be rephrased.


> On Feb. 22, 2016, 7:30 p.m., Neil Conway wrote:
> > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 292
> > 
> >
> > The usage "a control flow" is a bit unusual (at least to me). What 
> > about "a program fragment that is easier for the compiler to reason about"?
> 
> Benjamin Bannier wrote:
> IamNotAComputerScientist, but I believe this is standard compiler lingo 
> (cf. *control flow graph*).

"control flow" is certainly standard, I just haven't seen it usually referred 
to as "a control flow" (in CFG, the object is a "graph"; a CFG is a type of 
graph).


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43826/#review120166
---


On Feb. 22, 2016, 7:48 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43826/
> ---
> 
> (Updated Feb. 22, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joerg Schad, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/source/blog/2016-02-16-synchronized-statements-in-mesos.md 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43826/diff/
> 
> 
> Testing
> ---
> 
> Locally rendered with `rake && rake dev` from `/site`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

[Benjamin Bannier]

> On Feb. 22, 2016, 8:30 p.m., Neil Conway wrote:
> > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 286
> > 
> >
> > "Remembering all of these rules is simply too complicated, so we opt to 
> > use a more clever solution."

Stongly disagree: *clever* carries a negative connotation, while *solve 
properly* is positive.


> On Feb. 22, 2016, 8:30 p.m., Neil Conway wrote:
> > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 292
> > 
> >
> > The usage "a control flow" is a bit unusual (at least to me). What 
> > about "a program fragment that is easier for the compiler to reason about"?

IamNotAComputerScientist, but I believe this is standard compiler lingo (cf. 
*control flow graph*).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43826/#review120166
---


On Feb. 22, 2016, 8:48 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43826/
> ---
> 
> (Updated Feb. 22, 2016, 8:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joerg Schad, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/source/blog/2016-02-16-synchronized-statements-in-mesos.md 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43826/diff/
> 
> 
> Testing
> ---
> 
> Locally rendered with `rake && rake dev` from `/site`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/
---

(Updated Feb. 22, 2016, 7:59 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Addressed comments, added new ACL examples.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Updated authorization docs for '/reserve' and '/create-volumes'.

This updates the authorization documentation to include the new `roles` object 
for the `CreateVolume` and `ReserveResources` ACLs.


Diffs (updated)
-

  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 

Diff: https://reviews.apache.org/r/43800/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43779/
---

(Updated Feb. 22, 2016, 7:58 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Added '/reserve' tests with multiple roles.

Operators may reserve resources for multiple roles in the same operation; this 
patch adds tests to confirm correct behavior of authorization in this case. The 
tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and 
`ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.


Diffs (updated)
-

  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 

Diff: https://reviews.apache.org/r/43779/diff/


Testing
---

Ran `configure && make check` and `configure --enable-libevent --enable-ssl && 
make check` on OSX; all tests passed.


Thanks,

Greg Mann

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/
---

(Updated Feb. 22, 2016, 7:58 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Rebase.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Added '/create-volumes' tests with multiple roles.

Operators may create volumes for multiple roles in the same operation; this 
patch adds tests to confirm correct behavior of authorization in this case. The 
tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and 
`ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.


Diffs (updated)
-

  src/tests/persistent_volume_endpoints_tests.cpp 
6069ca1e9ed278459c5182e438417e95955b1924 

Diff: https://reviews.apache.org/r/43778/diff/


Testing
---

Ran `configure && make check` and `configure --enable-libevent --enable-ssl && 
make check` on OSX; all tests passed.


Thanks,

Greg Mann

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

[Greg Mann]

> On Feb. 20, 2016, 8:19 a.m., Guangya Liu wrote:
> > src/tests/master_validation_tests.cpp, lines 238-240
> > 
> >
> > I think that we need to clarify that the `role` checking except "*" 
> > will be checked in `authorize`, the validation will not check roles except 
> > "*" now.
> > 
> > Otherwise, someone might confused that why a framework with `roleA` can 
> > reserve resoures for `roleB`?

Actually, after looking at this test again, it is no longer necessary once the 
`role` parameter is removed from this validation function. With that parameter 
gone, this test does nothing at all :-)

I updated the subsequent patch, https://reviews.apache.org/r/43777/, to remove 
this test.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43776/#review120028
---


On Feb. 22, 2016, 7:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43776/
> ---
> 
> (Updated Feb. 22, 2016, 7:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed object of the `ReserveResources` ACL to `roles`.
> 
> This solves a problem in which any principal could reserve resources for any 
> role using the '/reserve' operator endpoint. A new test, 
> `ReserveOperationValidationTest.DisallowReserveForStarRole`, was added.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> 226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
>   src/authorizer/local/authorizer.cpp 
> 9557bbdf68ff182c4538bbf70cee576d717abc05 
>   src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/authorization_tests.cpp 9d046e8d53cbb6c065a23ca3f7832021ec7faadc 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43776/diff/
> 
> 
> Testing
> ---
> 
> Tests were altered to accomodate the new ACL object, and the test 
> `ReserveOperationValidationTest.DisallowReserveForStarRole` was added.
> 
> Ran `configure && make check` and `configure --enable-libevent --enable-ssl 
> && make check` on OSX; all tests passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43838: Added note about not implemented requestResources call.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120188
---



Patch looks great!

Reviews applied: [43819, 43838]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 4:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated Feb. 22, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43782/
---

(Updated Feb. 22, 2016, 7:55 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Changed object of `CreateVolume` ACL to `roles`.

This solves a problem in which any principal could create volumes for any role 
using the '/create-volumes' operator endpoint.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.proto 
226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
  src/authorizer/local/authorizer.cpp 9557bbdf68ff182c4538bbf70cee576d717abc05 
  src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
  src/tests/authorization_tests.cpp 9d046e8d53cbb6c065a23ca3f7832021ec7faadc 
  src/tests/persistent_volume_endpoints_tests.cpp 
6069ca1e9ed278459c5182e438417e95955b1924 
  src/tests/persistent_volume_tests.cpp 
e169e1b141a38dc389eefd42c11a078c413123d5 

Diff: https://reviews.apache.org/r/43782/diff/


Testing
---

Persistent volume tests and operation validation tests were altered to 
accomodate the new ACL object, and some new principal/role combinations were 
added to `AuthorizationTest.CreateVolume`.

Ran `configure && make check` and `configure --enable-libevent --enable-ssl && 
make check` on OSX; all tests passed.


Thanks,

Greg Mann

Re: Review Request 43777: Removed unnecessary parameter from validation function.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43777/
---

(Updated Feb. 22, 2016, 7:54 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Removed unnecessary validation test.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Removed unnecessary parameter from validation function.

Now that Reserve operations are authorized for particular roles, it is 
unnecessary to pass the framework's role into the validation function for 
Reserve operations. The function previously ensured that a framework could only 
reserve resources for its own role, but this check has been removed.


Diffs (updated)
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
  src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 

Diff: https://reviews.apache.org/r/43777/diff/


Testing
---

Ran `configure && make check` and `configure --enable-libevent --enable-ssl && 
make check` on OSX; all tests passed.


Thanks,

Greg Mann

Review Request 43848: Used `size_t` to track number of frameworks per role.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43848/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Per informal project style, we prefer using unsigned types to
represent non-negative quantities.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
0d39d3f3b5f4ff7f62f9de7200d062845c71818a 

Diff: https://reviews.apache.org/r/43848/diff/


Testing
---

make check on OSX

Compilation on Linux with GCC 5.3


Thanks,

Neil Conway

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43776/
---

(Updated Feb. 22, 2016, 7:47 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Changed object of the `ReserveResources` ACL to `roles`.

This solves a problem in which any principal could reserve resources for any 
role using the '/reserve' operator endpoint. A new test, 
`ReserveOperationValidationTest.DisallowReserveForStarRole`, was added.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.proto 
226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
  src/authorizer/local/authorizer.cpp 9557bbdf68ff182c4538bbf70cee576d717abc05 
  src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/authorization_tests.cpp 9d046e8d53cbb6c065a23ca3f7832021ec7faadc 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 

Diff: https://reviews.apache.org/r/43776/diff/


Testing
---

Tests were altered to accomodate the new ACL object, and the test 
`ReserveOperationValidationTest.DisallowReserveForStarRole` was added.

Ran `configure && make check` and `configure --enable-libevent --enable-ssl && 
make check` on OSX; all tests passed.


Thanks,

Greg Mann

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43826/#review120166
---




site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 15)


"Java language feature" -- or in any case I'd probably drop the hyphen.



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 35)


"class and"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 42)


I'm a little confused by the semantics of the proposed `if` statement -- 
you're saying the enclosing block only executes if `condition` is true? 
Syntactically it seems weird as well.

How about

```
{
  if_guard my_if(condition);

  // Block only executes if `condition` is true
}
```



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 54)


No comma



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 57)


Remove the comma.



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 64)


Seems a little unclear what you're referring to by "the patterns involving 
other RAII classes such as `std::vector`"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 115)


"scope and then destroyed"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 121)


Remove comma.



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 276)


"If"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 286)


"Remembering all of these rules is simply too complicated, so we opt to use 
a more clever solution."



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 292)


The usage "a control flow" is a bit unusual (at least to me). What about "a 
program fragment that is easier for the compiler to reason about"?


- Neil Conway


On Feb. 22, 2016, 7:50 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43826/
> ---
> 
> (Updated Feb. 22, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/source/blog/2016-02-16-synchronized-statements-in-mesos.md 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43826/diff/
> 
> 
> Testing
> ---
> 
> Locally rendered with `rake && rake dev` from `/site`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43801/#review120156
---




src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (lines 233 - 
240)


Could we change `parentLayerId` as a `JSON::Value`, which might be more 
safe. And we may want to add one more `else if`:

```
else if (parentLayerId.get().is()) {
  return None();
}
```



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 213)


should be
`Future future = puller->pull(reference, staging.get())`?



src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 290 - 296)


Is this(skipping pulling/untar a layer) possible?

When we do a store->get, we firstly look at metadata manager. If found 
none, we start pulling, so a layer should be untarred to a staging dir.


- Gilbert Song


On Feb. 19, 2016, 10:09 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43801/
> ---
> 
> (Updated Feb. 19, 2016, 10:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Bugs: MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step of cleaning up the docker registry puller/client code 
> base. I did the following simplications:
> 
> 1) Simplify the paths functions. The getImageArchiveXXX functions are 
> redundant.
> 2) Simplify the Puller::pull interface. We just need to return layer ids and 
> no need to return path.
> 3) Used untar from command utils, and kill the same function in puller.cpp.
> 4) A lot of consistency fixes, including using the same type and name.
> 5) A lot of style fixes.
> 
> The next step will be to cleanup and refactor registry_puller to use uri 
> Fetcher (docker plugin) to download manifest and blobs (and kill registry 
> client).
> 
> Reviewers are recommended to look at the end version, instead of the diff.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 811c24b43f7aec9db406dd521770c6cd82097c92 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f3e7c042f2c9980f6274c8185ee8bb89a8b02002 
>   src/slave/containerizer/mesos/provisioner/docker/paths.hpp 
> d2b0cf95e5ed7664071484a27a2a1f9bafff70d6 
>   src/slave/containerizer/mesos/provisioner/docker/paths.cpp 
> 82d92a2a9cce181eb283395a32e93cbb1586703b 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 5b2d72c22fcbcc379b4901607cf3eb682de66206 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> a239b97557ad20353c67050dbc89ef16da898330 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> bccbac3357cf942446604e6cf5d16c3d594b 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 3fcf1471a035e35a2cac22442655ad65a84a9793 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 880e216e33dd178d0baa47d3958c84cda4d9e25e 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 2f1d3e002140f34c646aab445a419c9c3d712f99 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4db6793a21abbb7ea4de0d0fca0431237d38d013 
> 
> Diff: https://reviews.apache.org/r/43801/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/#review120175
---



Patch looks great!

Reviews applied: [43487, 43488, 43489, 43490, 43827]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 10:18 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43827/
> ---
> 
> (Updated Feb. 22, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introducing TASK_KILLING state on WebUI.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 
> 
> Diff: https://reviews.apache.org/r/43827/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/
---

(Updated Feb. 22, 2016, 6:44 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Changes
---

Rebase.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Updated comments and docs for '/reserve' and '/unreserve' without principal.


Diffs (updated)
-

  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
  include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 

Diff: https://reviews.apache.org/r/43642/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43641: Removed unnecessary parameter from validation function.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/
---

(Updated Feb. 22, 2016, 6:43 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Changes
---

Rebase.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Removed unnecessary parameter from validation function.

Since unreserve operations are now possible without a principal, the `bool 
hasPrincipal` parameter to the Unreserve operation validation function is no 
longer necessary.


Diffs (updated)
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
  src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 

Diff: https://reviews.apache.org/r/43641/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Greg Mann]

> On Feb. 18, 2016, 6:57 a.m., Guangya Liu wrote:
> > src/master/validation.cpp, lines 692-711
> > 
> >
> > Can you please add some test cases to cover those scenarios?
> > 
> > 1) authentication is enabled and reservation does not have principal.
> > 2) authentication is enabled and reservation pricipal does not same as 
> > authentication principal.
> > 3) authentication is disabled but reservation has principal.
> 
> Guangya Liu wrote:
> Seems 2) was covered by `ReservationEndpointsTest, NonMatchingPrincipal`, 
> but 1) and 3) was not covered for now.

Good call, I added a test case to the `ReservationTest` tests for #3.

Due to the way authentication works, I'm not sure that test case #1 is 
necessary. When authentication is enabled, HTTP endpoints require a principal 
and frameworks must supply a principal to register. The best we could do to 
test #1 is to have a request with an authenticated principal but no principal 
in `ReservationInfo`, which is really just testing that a request with 
non-matching principals will fail. The non-matching principal case is covered 
by `ReservationEndpointsTest.NonMatchingPrincipal`. What do you think?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review119589
---


On Feb. 22, 2016, 6:39 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated Feb. 22, 2016, 6:39 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> It may be desirable to remove this requirement; this improvement is tracked 
> in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> A new test case was added to `ReservationTest.NoAuthentication`.
> 
> `make check` was used to test on OSX, both with and without SSL enabled.
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43716: Endpoint documents with title.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review120170
---



Looks like you need to title each page as "Apache Mesos" instead of just 
"Mesos" (as mentioned in AdamB's review from your other RR).
https://reviews.apache.org/r/43328/

- Kevin Klues


On Feb. 21, 2016, 8:04 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 21, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Autometically generated markdown files with corresponding titles.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff: https://reviews.apache.org/r/43716/diff/
> 
> 
> Testing
> ---
> 
> This patch includes all the endpoint documents with title generated from 
> generated-endpoint-help.py file.
> 

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/
---

(Updated Feb. 22, 2016, 6:26 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-4660
https://issues.apache.org/jira/browse/MESOS-4660


Repository: mesos


Description
---

Added documentation for `cgroups/net_cls` isolator.


Diffs (updated)
-

  docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 

Diff: https://reviews.apache.org/r/43796/diff/


Testing
---

Built the web-site using docker, and proof read the website and links on 
localhost.

Verified all the links embedded in markdown work.


Thanks,

Avinash sridharan

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

[Joerg Schad]

> On Feb. 16, 2016, 3:28 a.m., Klaus Ma wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2417
> > 
> >
> > No allocation because there is no slaves. We have trigger allocation by 
> > `Clock::advance(flags.allocation_interval);`.

This is done above, not sure what you are looking for.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43588/#review119257
---


On Feb. 15, 2016, 9:23 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43588/
> ---
> 
> (Updated Feb. 15, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Klaus Ma.
> 
> 
> Bugs: MESOS-3986
> https://issues.apache.org/jira/browse/MESOS-3986
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator recovery tests in presence of quota.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0acfc098750ff8ff9505207b983a34c1ccf3ad06 
> 
> Diff: https://reviews.apache.org/r/43588/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43798: Added overview section to upgrades.md.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43798/
---

(Updated Feb. 22, 2016, 6:20 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Changes
---

Addressed comments.


Summary (updated)
-

Added overview section to upgrades.md.


Bugs: MESOS-4381
https://issues.apache.org/jira/browse/MESOS-4381


Repository: mesos


Description (updated)
---

Added overview section to upgrades.md.


Diffs (updated)
-

  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 

Diff: https://reviews.apache.org/r/43798/diff/


Testing
---

Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and 
docker website container.


Thanks,

Joerg Schad

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

[Joerg Schad]

> On Feb. 22, 2016, 8:43 a.m., Michael Park wrote:
> > Upon looking through the pattern, it seems like the evolution of this has 
> > been:
> > 
> > ```
> > In order to upgrade a running cluster:
> > 
> > * ...
> > * ...
> > ```
> > 
> > then came some `NOTE`s:
> > 
> > ```
> > __NOTE__: ...
> > 
> > __NOTE__: ...
> > 
> > In order to upgrade a running cluster:
> > 
> > * ...
> > * ...
> > ```
> > 
> > Now that we're changing __NOTE__ to bullets, I think we can
> > 
> >   1. Keep the "In order to upgrade a running cluster" at the same level as 
> > the bullets
> >   2. Replace the bullets under "In order to upgrade a running cluster" to 
> > numbers.
> > 
> > __NOTE__: I noticed that the "upgrading a running cluster" section is 
> > missing for 0.25 -> 0.26
> >   as well as 0.26 -> 0.27, so I created JIRAs to track those as 
> > well.
> >   [MESOS-4734](https://issues.apache.org/jira/browse/MESOS-4734)

Adapted to your proposed format.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/#review120129
---


On Feb. 22, 2016, 6 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43792/
> ---
> 
> (Updated Feb. 22, 2016, 6 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made bullet point structure consistent in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43792/diff/
> 
> 
> Testing
> ---
> 
> Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and 
> via docker website renderer.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/
---

(Updated Feb. 22, 2016, 6 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Changes
---

Adressed comment.


Repository: mesos


Description
---

Made bullet point structure consistent in upgrades.md.


Diffs (updated)
-

  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 

Diff: https://reviews.apache.org/r/43792/diff/


Testing
---

Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and via 
docker website renderer.


Thanks,

Joerg Schad

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43826/#review120162
---



Patch looks great!

Reviews applied: [43826]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 7:50 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43826/
> ---
> 
> (Updated Feb. 22, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/source/blog/2016-02-16-synchronized-statements-in-mesos.md 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43826/diff/
> 
> 
> Testing
> ---
> 
> Locally rendered with `rake && rake dev` from `/site`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/
---

(Updated Feb. 22, 2016, 5:18 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Repository: mesos


Description
---

Consistent markdown code style in persistent-volumes.md.


Diffs (updated)
-

  docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 

Diff: https://reviews.apache.org/r/43634/diff/


Testing (updated)
---

Viewed via gist (https://gist.github.com/joerg84/74e065fbcfd130d90cf7) and 
Docker website container.


Thanks,

Joerg Schad

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

[Joerg Schad]

> On Feb. 22, 2016, 8:16 a.m., Michael Park wrote:
> > docs/persistent-volume.md, line 56
> > 
> >
> > Do you know if we actually have a good reason for the 8 space indent 
> > here as opposed to 4? I noticed that `docs/reservation.md` has 8 spaces as 
> > well, but I don't remember why I did that nor where I got it from :(

You are right 4 is enough and consistent with the markdown styleguide but not 
with other files (reservation, quota).
I updated this file and follow up by making the other files consistent.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review120127
---


On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 43838: Added note about not implemented requestResources call.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/
---

Review request for mesos, Adam B and Guangya Liu.


Repository: mesos


Description
---

Added note about not implemented requestResources call.


Diffs
-

  docs/app-framework-development-guide.md 
e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
bf866f5ebece2505eaa27bf39a1382cd1a2a069a 

Diff: https://reviews.apache.org/r/43838/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

[Joerg Schad]

> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 135
> > 
> >
> > Why not merge this and above `Scheduler API` into one section?

I wanted to keep the Scheduler API i.e. the callbacks the scheduler has to 
implement and the calls it can make (i.e. SchedulerDriver API) seperate. Does 
that make sense?


> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, lines 174-178
> > 
> >
> > Do we need to mention this here? The API was not implemented by the 
> > built-in allocator, so the framework cannot leverage this if using built-in 
> > allocator.

It is part of the interface so I believe yes, but I added a note 
https://reviews.apache.org/r/43838/ stating that the default allocator 
currently does not implement this call.


> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 17
> > 
> >
> > s/interface/interfaces

a) this is equivalent to the description in scheduler.hpp.
b) For me this is a single interface (specifying several callbacks), what makes 
you feel this should be plural?


> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 137
> > 
> >
> > s/Interface/Interfaces

see above.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43819/#review120091
---


On Feb. 22, 2016, 3 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43819/
> ---
> 
> (Updated Feb. 22, 2016, 3 a.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Scheduler-Driver API to app-framework-development-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
> 
> Diff: https://reviews.apache.org/r/43819/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and 
> via docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43824: Addressed comments of 41672.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review120150
---



Patch looks great!

Reviews applied: [43824]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 7:23 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43824/
> ---
> 
> (Updated Feb. 22, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Addressed comments of 41672.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43824/diff/
> 
> 
> Testing
> ---
> 
> make && make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 22, 2016, 3:48 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

address @tillt's comment


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review120143
---


Fix it, then Ship it!





src/tests/fetcher_cache_tests.cpp (line 190)


s/serializes/serialize/
s/will/would/
s/this/task execution/


- Till Toenshoff


On Feb. 18, 2016, 2:54 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 18, 2016, 2:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[Bernd Mathiske]

> On Feb. 19, 2016, 1:02 a.m., Alexander Rukletsov wrote:
> > src/tests/fetcher_cache_tests.cpp, lines 189-191
> > 
> >
> > Will it be more clear to explicitly advance clock in those tests? I 
> > think keeping changes local, i.e. making them only there where they are 
> > necessary, serves educational purposes. People often read tests to 
> > understand how things work, hence it's valuable not to distract them with 
> > irrelevant actions, nor to hide meaningful steps.
> 
> haosdent huang wrote:
> Do you mean move
> 
> ```
>   Future offers;
>   EXPECT_CALL(scheduler, resourceOffers(driver, _))
> .WillOnce(FutureArg<1>())
> .WillRepeatedly(DeclineOffers());
> 
>   // The default timeout in AWAIT_READY is 15 seconds,
>   // so we use that amount here.
>   // TODO(bernd-mesos): Make this a symbolic constant in "gtest.hpp"
>   // that we can reference here.
>   offers.await(Seconds(15));
>   if (!offers.isReady()) {
> return Error("Failed to wait for resource offers: " +
>(offers.isFailed() ? offers.failure() : "discarded"));
>   }
> 
>   CHECK_NE(0u, offers.get().size());
>   const Offer offer = offers.get()[0];
> ```
> 
> out and use advance clock according to different test cases?
> 
> Or pass a new param
> ```
> Try FetcherCacheTest::launchTask(
> const CommandInfo& commandInfo,
> const size_t taskIndex,
> const bool& advanceAllocation)
> ```

This change applies to all these tests, so one global change instead of many 
local ones seems OK to me. Dropping the issue.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119838
---


On Feb. 18, 2016, 6:54 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 18, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43817: Removed no-longer-used model functions.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/#review120140
---



Patch looks great!

Reviews applied: [43816, 43822, 43823, 43817]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 7:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43817/
> ---
> 
> (Updated Feb. 22, 2016, 7:13 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These `model()` variants provided functionality that is now
> implemented via jsonify; no more call-sites of the old functions
> remain.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
> 
> Diff: https://reviews.apache.org/r/43817/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also updated a few comments to not refer to `summarize`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review120137
---



Patch looks great!

Reviews applied: [43032]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 6:37 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Feb. 22, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
>   src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43821/#review120135
---



Patch looks great!

Reviews applied: [43821]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 5:19 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43821/
> ---
> 
> (Updated Feb. 22, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta and Neil Conway.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 0d9c483985d61b512339f50f395f9360de034e2d 
> 
> Diff: https://reviews.apache.org/r/43821/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review120133
---



Patch looks great!

Reviews applied: [43552]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 22, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/
---

(Updated Feb. 22, 2016, 10:18 a.m.)


Review request for mesos, Ben Mahler and Neil Conway.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Introducing TASK_KILLING state on WebUI.


Diffs
-

  src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 

Diff: https://reviews.apache.org/r/43827/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/
---

(Updated Feb. 22, 2016, 10:17 a.m.)


Review request for mesos, Ben Mahler and Neil Conway.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Introducing TASK_KILLING state on WebUI.


Diffs
-

  src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 

Diff: https://reviews.apache.org/r/43827/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Review Request 43827: Introducing TASK_KILLING state on WebUI.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/
---

Review request for mesos.


Repository: mesos


Description
---

Introducing TASK_KILLING state on WebUI.


Diffs
-

  src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 

Diff: https://reviews.apache.org/r/43827/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Re: Review Request 43761: Replaced an exit status numeral with the appropriate constant.

[Alexander Rukletsov]

> On Feb. 21, 2016, 12:52 p.m., Ben Mahler wrote:
> > I'll commit this, any reason you didn't do the broader sweep?

Tried to stay focused and not deviate from the current task. I can do the 
broader sweep later.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43761/#review120070
---


On Feb. 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43761/
> ---
> 
> (Updated Feb. 19, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1 
> 
> Diff: https://reviews.apache.org/r/43761/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/43764/ .
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>