Re: Review Request 51023: Added `PortMapping` for frameworks in v1 API as well.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51023/#review145592
---


Ship it!




Ship It!

- Jie Yu


On Aug. 12, 2016, 1:24 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51023/
> ---
> 
> (Updated Aug. 12, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6017
> https://issues.apache.org/jira/browse/MESOS-6017
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `PortMapping` for frameworks in v1 API as well.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto 85468f80379b42426df6a80b4b04075b983fd3ec 
> 
> Diff: https://reviews.apache.org/r/51023/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[Jie Yu]

> On Aug. 12, 2016, 4:37 a.m., Jie Yu wrote:
> > Ship It!

Did a few adjustments. Please take a look.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/#review145590
---


On Aug. 11, 2016, 2:18 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49817/
> ---
> 
> (Updated Aug. 11, 2016, 2:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `CgroupsIsolatorProcess::recover`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> b191b2a52a9645fc902a35ed52909b2142f0b4c0 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
> 
> Diff: https://reviews.apache.org/r/49817/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 51026: Update ELFIO from 3.1 to 3.2

[KOTA UENISHI]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51026/
---

Review request for mesos.


Bugs: MESOS-5979
https://issues.apache.org/jira/browse/MESOS-5979


Repository: mesos


Description
---

Update ELFIO from 3.1 to 3.2


Diffs
-

  3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 
  3rdparty/elfio-3.1.patch 3d85394c77e3389433678ebbefa25661db842190 
  3rdparty/elfio-3.1.tar.gz c0e60f33a413b7832034fe81275c8edf8819fff9 
  3rdparty/elfio-3.2.tar.gz PRE-CREATION 

Diff: https://reviews.apache.org/r/51026/diff/


Testing
---


Thanks,

KOTA UENISHI

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

[Guangya Liu]

> On 八月 4, 2016, 3:04 p.m., Guangya Liu wrote:
> > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp, line 758
> > 
> >
> > Do you need this with docker containerizer?
> 
> Yubo Li wrote:
> Currently we need. When I remove this line, the test reports error:
> resources: '--nvidia_gpus_devices' can only be specified if the 
> `--isolation` flag contains 'gpu/nvidia'.
> 
> Actually, docker containerizer does not need `--isolation`, but currently 
> `--nvidia_gpus_devices` forces us to do this. We would talk with Ben and 
> Kevin to remove this retriction for docker containerizer soon.
> 
> Guangya Liu wrote:
> I see, did you initate any discussion with them?

This was fixed in https://reviews.apache.org/r/50947/


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review144762
---


On 八月 10, 2016, 10:32 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> ---
> 
> (Updated 八月 10, 2016, 10:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4e5b1fd1628504d346cced545f7911d6b6443773 
> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j 
> check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Review Request 51024: Updating TOC for CNI documentation.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51024/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5985
https://issues.apache.org/jira/browse/MESOS-5985


Repository: mesos


Description
---

Updating TOC for CNI documentation.


Diffs
-

  docs/cni.md 36f2a7569322a79c71ee0019f48efa782c961ec7 

Diff: https://reviews.apache.org/r/51024/diff/


Testing
---

Launched the website and verified the links.


Thanks,

Avinash sridharan

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50910/#review145581
---



Patch looks great!

Reviews applied: [50907, 50910]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 9:54 p.m., Haris Choudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50910/
> ---
> 
> (Updated Aug. 11, 2016, 9:54 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: Mesos-6006
> https://issues.apache.org/jira/browse/Mesos-6006
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It currently doesn't run over any files in the code base, but we will
> be adding the new python CLI in a subsequent commit, which will use
> this new linter.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 
> 
> Diff: https://reviews.apache.org/r/50910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>

Re: Review Request 50846: Added more assertions to the master.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50846/
---

(Updated Aug. 12, 2016, 12:33 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5949
https://issues.apache.org/jira/browse/MESOS-5949


Repository: mesos


Description
---

Added more assertions to the master.


Diffs (updated)
-

  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 

Diff: https://reviews.apache.org/r/50846/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50702/
---

(Updated Aug. 12, 2016, 12:32 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Keep old metric names for backward compatibility.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description (updated)
---

The master will shortly be changed to no longer shutdown unhealthy
agents, so the previous metric name is no longer accurate. The old
metric names have been kept for backwards compatibility, but they
are no longer updated (i.e., they will always be set to zero).


Diffs (updated)
-

  docs/monitoring.md e19ecd0ad23538da288577da0237d067459aa7ba 
  src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
  src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
  src/master/metrics.cpp 88a752dc2b4b73ccb919e99478b9ea2bd83842a0 
  src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 
  src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 

Diff: https://reviews.apache.org/r/50702/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50705/
---

(Updated Aug. 12, 2016, 12:33 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Tweak comment.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description (updated)
---

The previous behavior was to shutdown partitioned agents that attempt to
reregister---unless the master has failed over, in which case the
reregistration is allowed (when running in "non-strict" mode).

The new behavior is always to allow partitioned agents to reregister.
This is part of a longer-term project to allow frameworks to define
their own policies for handling tasks running on partitioned agents.

In particular, if a framework has the PARTITION_AWARE capability, any
tasks running on the partitioned agent will continue to run after
reregistration. If the framework is not PARTITION_AWARE, any tasks that
were running on such an agent will be killed after the agent reregisters
(unless the master has failed over). This is for backward compatibility
with the previous ("non-strict") behavior. Note that regardless of the
PARTITION_AWARE capability, the agent will not be shutdown, which is a
change from the previous Mesos behavior.

This commit also changes the master so that if an agent is removed and
then the master receives a message from that agent, the master will no
longer attempt to shutdown the agent. This is consistent with the goal
of getting the master out of the business of shutting down agents that
we suspect are unhealthy. Such an agent will eventually realize it is
not registered with the master (e.g., because it won't receive any pings
from the master), which will cause it to reregister.


Diffs (updated)
-

  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
  src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 
  src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 

Diff: https://reviews.apache.org/r/50705/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 50703: Removed a no-longer-relevant test.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50703/
---

(Updated Aug. 12, 2016, 12:32 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

The behavior this test is trying to validate (slaves receive a
`ShutdownMessage` if they attempt to reregister after failing health
checks) will be changed shortly. Moreover, the new behavior is already
covered by other test cases.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 59859f5bc249fbef916d6dfeafdc396a4c037117 

Diff: https://reviews.apache.org/r/50703/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 50701: Added registrar operations for marking agents (un-)reachable.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50701/
---

(Updated Aug. 12, 2016, 12:22 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase, tweaks.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

Added registrar operations for marking agents (un-)reachable.


Diffs (updated)
-

  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/tests/registrar_tests.cpp 9a71d8fd0c8d8e662a5e364015d144396a0b1a4c 

Diff: https://reviews.apache.org/r/50701/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 50700: Added a list of "unreachable" agents to the registry.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50700/
---

(Updated Aug. 12, 2016, 12:22 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Only store SlaveID.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

These are agents that have failed health checks.


Diffs (updated)
-

  src/master/registry.proto 9bf9998bcf521b962f3fe8741d02620b1907f577 

Diff: https://reviews.apache.org/r/50700/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 51016: Updated includes to follow the split.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51016/
---

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Repository: mesos


Description
---

see summary.


Diffs
-

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
05c2bd4c3014296edacbdac17da7f0aa1f2c21fd 
  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 
  3rdparty/libprocess/src/socket.cpp 668f26d85cf3097ff9b90a10be14c5833fafd558 
  3rdparty/libprocess/src/tests/ssl_client.cpp 
dffd9ffa9e57fccf6e25207e163bea5803b65255 

Diff: https://reviews.apache.org/r/51016/diff/


Testing
---

make check

NOTE: No functional changes involved.


Thanks,

Till Toenshoff

Re: Review Request 51001: Added ability for frameworks to specify port mapping for CNI networks.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51001/#review145575
---




include/mesos/mesos.proto (lines 1807 - 1812)


So we only add this message to `include/mesos/mesos.proto`? What about 
`include/mesos/v1/mesos.proto`?


- Qian Zhang


On Aug. 12, 2016, 3:02 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51001/
> ---
> 
> (Updated Aug. 12, 2016, 3:02 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6017
> https://issues.apache.org/jira/browse/MESOS-6017
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ability for frameworks to specify port mapping for CNI networks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
> 
> Diff: https://reviews.apache.org/r/51001/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50941/
---

(Updated Aug. 11, 2016, 10:58 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Addressed Jie's comments.


Bugs: MESOS-5985
https://issues.apache.org/jira/browse/MESOS-5985


Repository: mesos


Description
---

Added a section on "Adding/Modifying/Deleting CNI configuration".


Diffs (updated)
-

  docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 

Diff: https://reviews.apache.org/r/50941/diff/


Testing
---

Launched the webiste and verified the changes.


Thanks,

Avinash sridharan

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50941/#review145573
---



Patch looks great!

Reviews applied: [50769, 50940, 50941]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 10:58 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50941/
> ---
> 
> (Updated Aug. 11, 2016, 10:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5985
> https://issues.apache.org/jira/browse/MESOS-5985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a section on "Adding/Modifying/Deleting CNI configuration".
> 
> 
> Diffs
> -
> 
>   docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 
> 
> Diff: https://reviews.apache.org/r/50941/diff/
> 
> 
> Testing
> ---
> 
> Launched the webiste and verified the changes.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51008/
---

Review request for mesos, Haris Choudhary and Joseph Wu.


Bugs: MESOS-6032
https://issues.apache.org/jira/browse/MESOS-6032


Repository: mesos


Description
---

Added infrastructure for unit tests in the new python-based CLI.


Diffs
-

  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/cli_new/pip-requirements.txt PRE-CREATION 
  src/cli_new/tests/main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/51008/diff/


Testing
---

GTEST_FILTER="" make -j check


Thanks,

Kevin Klues

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51009/#review145567
---




src/slave/containerizer/docker.cpp (line 1744)


Note: Existing code seems to always assume `cpu` and `cpuacct` is mounted 
at the same location, but I doubt this is a linux rule.

Happy to undo these changes if someone can confirm.


- Zhitao Li


On Aug. 11, 2016, 10:17 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51009/
> ---
> 
> (Updated Aug. 11, 2016, 10:17 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, Gilbert Song, Jie Yu, and Steve 
> Niemitz.
> 
> 
> Bugs: MESOS-6031
> https://issues.apache.org/jira/browse/MESOS-6031
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Collect throttle related cpu.stat for Docker Containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
> 
> Diff: https://reviews.apache.org/r/51009/diff/
> 
> 
> Testing
> ---
> 
> Run agent with cfs quota enabled, and observe that throttle related metrics 
> are in `/containers` and `/monitoring/statistics`
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51009/
---

Review request for mesos, Xiaojian Huang, Gilbert Song, Jie Yu, and Steve 
Niemitz.


Bugs: MESOS-6031
https://issues.apache.org/jira/browse/MESOS-6031


Repository: mesos


Description
---

Collect throttle related cpu.stat for Docker Containerizer.


Diffs
-

  src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 

Diff: https://reviews.apache.org/r/51009/diff/


Testing
---

Run agent with cfs quota enabled, and observe that throttle related metrics are 
in `/containers` and `/monitoring/statistics`


Thanks,

Zhitao Li

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

[Haris Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50910/
---

(Updated Aug. 11, 2016, 9:54 p.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: Mesos-6006
https://issues.apache.org/jira/browse/Mesos-6006


Repository: mesos


Description
---

It currently doesn't run over any files in the code base, but we will
be adding the new python CLI in a subsequent commit, which will use
this new linter.


Diffs (updated)
-

  support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 

Diff: https://reviews.apache.org/r/50910/diff/


Testing
---


Thanks,

Haris Choudhary

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50910/#review145560
---




support/mesos-style.py (line 215)


Since this is an internal function, I would prefix it with "`__`".



support/mesos-style.py (line 217)


Do you really need this temporary variable if you just use it once. Why not 
do the `os.path.join()` directly in the `isdir()` call?



support/mesos-style.py (line 244)


You don't use this variable anywhere.



support/mesos-style.py (lines 250 - 251)


I would either call the format strings in here "virtualenv_dir", "lib_dir", 
and "bin_dir" or just "virtualenv", "bin", and "lib". Having a "p" at the end 
of the variable names is confusing and inconsistent (at least with the name 
"virtualenv").



support/mesos-style.py (line 251)


There seems to be an extra space here.



support/mesos-style.py (line 258)


It looks like there is 1 extra space here.


- Kevin Klues


On Aug. 11, 2016, 8:02 p.m., Haris Choudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50910/
> ---
> 
> (Updated Aug. 11, 2016, 8:02 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: Mesos-6006
> https://issues.apache.org/jira/browse/Mesos-6006
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It currently doesn't run over any files in the code base, but we will
> be adding the new python CLI in a subsequent commit, which will use
> this new linter.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 
> 
> Diff: https://reviews.apache.org/r/50910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>

Re: Review Request 50996: Dispatched health check by type.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50996/#review145561
---



Patch looks great!

Reviews applied: [50994, 50996]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 5:35 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50996/
> ---
> 
> (Updated Aug. 11, 2016, 5:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Dispatched health check by type.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 7bc345bbc835f31feb2114cba434ab544451dbb0 
>   src/health-check/health_checker.cpp 
> d43cb0568c120cbcec6a73d232396ccc54cf3e58 
> 
> Diff: https://reviews.apache.org/r/50996/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

[Anindya Sinha]

> On Aug. 10, 2016, 7:23 p.m., Benjamin Mahler wrote:
> > src/examples/persistent_volume_framework.cpp, lines 402-410
> > 
> >
> > Can you give some context on why lowering these speeds up the test? How 
> > much does it speed it up?
> 
> haosdent huang wrote:
> Hi, @bmahler The most effective snippet is
> 
> ```
> export MESOS_AUTHENTICATION_TIMEOUT=200ms
> ```
> 
> which we committed before. I test this patch again, seems only bring 
> little speed up.
> 
> Before apply the patch,
> 
> ```
> [   OK ] ExamplesTest.PersistentVolumeFramework (3505 ms)
> [--] 1 test from ExamplesTest (3510 ms total)
> ```
> 
> After apply the patch,
> 
> ```
> [   OK ] ExamplesTest.PersistentVolumeFramework (2493 ms)
> [--] 1 test from ExamplesTest (2497 ms total)
> ```
> 
> Do you think we should discard this?
> 
> Anindya Sinha wrote:
> I think the improvement is not due to the reduction in number of shards 
> (since the ACCEPT call consolidates offer operations for all shards), but due 
> to the reduction in number of tasks per shard (since each of the tasks are 
> launched in separate ACCEPT calls).
> 
> Benjamin Mahler wrote:
> Why not have defaults of 1 shard and 1 task per shard? Seems the default 
> should either be: 1 or run forever. Also, we should probably explicitly set 
> these in the persistent_volume_framework_test.sh.

Default of 1 shard is fine, but the way is structured I think default for tasks 
per shard should be 2. I think the 1st task in a shard does a "touch 
volume/persisted", and subsequent tasks does a "test -f volume/persisted". So 
with 2 tasks per shard, we can test content of persistent volume (which have a 
life cycle across task boundaries).


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43558/#review145390
---


On Aug. 10, 2016, 5:21 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43558/
> ---
> 
> (Updated Aug. 10, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-4663
> https://issues.apache.org/jira/browse/MESOS-4663
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up ExamplesTest.PersistentVolumeFramework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
> 
> Diff: https://reviews.apache.org/r/43558/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 
> --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[Jie Yu]

> On Aug. 9, 2016, 9 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 195-197
> > 
> >
> > what you need here is essentially the top level cgroups, right?
> > 
> > We should improve cgroups::get to take an additional `recursive` flag.

Is this addressed? I don't see it being addressed.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/#review145259
---


On Aug. 11, 2016, 2:18 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49817/
> ---
> 
> (Updated Aug. 11, 2016, 2:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `CgroupsIsolatorProcess::recover`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> b191b2a52a9645fc902a35ed52909b2142f0b4c0 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
> 
> Diff: https://reviews.apache.org/r/49817/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50940: Removed a limitation.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50940/#review145554
---


Ship it!




Ship It!

- Jie Yu


On Aug. 10, 2016, 1:12 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50940/
> ---
> 
> (Updated Aug. 10, 2016, 1:12 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5985
> https://issues.apache.org/jira/browse/MESOS-5985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed a limitation.
> 
> 
> Diffs
> -
> 
>   docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 
> 
> Diff: https://reviews.apache.org/r/50940/diff/
> 
> 
> Testing
> ---
> 
> Launched website and verfied the changes.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50941/#review145553
---




docs/cni.md (lines 241 - 243)


This is inconsistent with the previous paragraph.

```
Whenever the `network/cni` isolator needs to attach a container to a CNI 
network, it reads the corresponding configuration from the disk and invokes the 
appropriate plugin with the specified JSON configuration.
```

Why restart is needed? I think the current semantics is not good. We should 
keep an in-memory copy of CNI config. Any config change should require an agent 
restart.


- Jie Yu


On Aug. 10, 2016, 1:41 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50941/
> ---
> 
> (Updated Aug. 10, 2016, 1:41 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5985
> https://issues.apache.org/jira/browse/MESOS-5985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a section on "Adding/Modifying/Deleting CNI configuration".
> 
> 
> Diffs
> -
> 
>   docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 
> 
> Diff: https://reviews.apache.org/r/50941/diff/
> 
> 
> Testing
> ---
> 
> Launched the webiste and verified the changes.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 51001: Added ability for frameworks to specify port mapping for CNI networks.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51001/#review145552
---


Ship it!




Ship It!

- Jie Yu


On Aug. 11, 2016, 7:02 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51001/
> ---
> 
> (Updated Aug. 11, 2016, 7:02 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6017
> https://issues.apache.org/jira/browse/MESOS-6017
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ability for frameworks to specify port mapping for CNI networks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
> 
> Diff: https://reviews.apache.org/r/51001/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

[Haris Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50910/
---

(Updated Aug. 11, 2016, 8:02 p.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: Mesos-6006
https://issues.apache.org/jira/browse/Mesos-6006


Repository: mesos


Description
---

It currently doesn't run over any files in the code base, but we will
be adding the new python CLI in a subsequent commit, which will use
this new linter.


Diffs (updated)
-

  support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 

Diff: https://reviews.apache.org/r/50910/diff/


Testing
---


Thanks,

Haris Choudhary

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145549
---



Still hunting down the rogue `ConnectionProcess` that sometimes crashes the 
test during finalization...


src/tests/scheduler_tests.cpp (line 1526)


This is already called in `MesosTest::SetUp()`.



src/tests/scheduler_tests.cpp (lines 1540 - 1551)


Since we're already reinitializing in the `SetUp`, we don't need to 
reinitialize in `TearDown`.

Instead, change this cleanup to `TearDownTestCase`.


- Joseph Wu


On Aug. 10, 2016, 3:37 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Aug. 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and will 
> produce a segfault on my OSX machine after 50-100 repetitions. To reproduce, 
> try:
> 
> `GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145546
---



Patch looks great!

Reviews applied: [50992]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> ---
> 
> (Updated Aug. 11, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris 
> Van Remoortere, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4638
> https://issues.apache.org/jira/browse/MESOS-4638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This makes version based conditional compiling much easier for
> module writers.
> 
> 
> Diffs
> -
> 
>   include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 
> 
> Diff: https://reviews.apache.org/r/50992/diff/
> 
> 
> Testing
> ---
> 
> make on Mac OS and Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 51001: Added ability for frameworks to specify port mapping for CNI networks.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51001/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-6017
https://issues.apache.org/jira/browse/MESOS-6017


Repository: mesos


Description
---

Added ability for frameworks to specify port mapping for CNI networks.


Diffs
-

  include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 

Diff: https://reviews.apache.org/r/51001/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

[Benjamin Mahler]

> On Aug. 10, 2016, 7:23 p.m., Benjamin Mahler wrote:
> > src/examples/persistent_volume_framework.cpp, lines 402-410
> > 
> >
> > Can you give some context on why lowering these speeds up the test? How 
> > much does it speed it up?
> 
> haosdent huang wrote:
> Hi, @bmahler The most effective snippet is
> 
> ```
> export MESOS_AUTHENTICATION_TIMEOUT=200ms
> ```
> 
> which we committed before. I test this patch again, seems only bring 
> little speed up.
> 
> Before apply the patch,
> 
> ```
> [   OK ] ExamplesTest.PersistentVolumeFramework (3505 ms)
> [--] 1 test from ExamplesTest (3510 ms total)
> ```
> 
> After apply the patch,
> 
> ```
> [   OK ] ExamplesTest.PersistentVolumeFramework (2493 ms)
> [--] 1 test from ExamplesTest (2497 ms total)
> ```
> 
> Do you think we should discard this?
> 
> Anindya Sinha wrote:
> I think the improvement is not due to the reduction in number of shards 
> (since the ACCEPT call consolidates offer operations for all shards), but due 
> to the reduction in number of tasks per shard (since each of the tasks are 
> launched in separate ACCEPT calls).

Why not have defaults of 1 shard and 1 task per shard? Seems the default should 
either be: 1 or run forever. Also, we should probably explicitly set these in 
the persistent_volume_framework_test.sh.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43558/#review145390
---


On Aug. 10, 2016, 5:21 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43558/
> ---
> 
> (Updated Aug. 10, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-4663
> https://issues.apache.org/jira/browse/MESOS-4663
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up ExamplesTest.PersistentVolumeFramework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
> 
> Diff: https://reviews.apache.org/r/43558/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 
> --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50907: Abstracted mesos-style.py to wrap the cpp linter in a class.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50907/
---

(Updated Aug. 11, 2016, 6:26 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
---

Addressed Joseph's comments.


Bugs: MESOS-6006
https://issues.apache.org/jira/browse/MESOS-6006


Repository: mesos


Description
---

Previously, mesos-style.py was just a collection of functions that
checked the style of relevant files in the mesos code base.  However,
the script assumed that we always wanted to run cpplint over every
file we were checking. Since we are planning on adding a python linter
to the codebase soon, it makes sense to abstract the common
functionality from this script into a class so that a cpp-based linter
and a python-based linter can inherit the same set of common
functionality.

This commit builds this abstraction and implements a 'CppLinter()' in
terms of it.


Diffs (updated)
-

  support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 

Diff: https://reviews.apache.org/r/50907/diff/


Testing
---

Ran `support/mesos-style.py` over the whole code base.


Thanks,

Kevin Klues

Re: Review Request 46822: Avoided slicing of flags in subprocess.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46822/
---

(Updated Aug. 11, 2016, 8:24 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Michael 
Park, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While `FlagsBase` internally stores just maps of names and
flags, the functions stored in a `Flag` rely on the original type of
the `Flags` containing them (e.g., we perform dynamic casts to detect
their types).

Since `Option` stores `T` as a value (i.e., it cannot contain
reference types) any interface taking an `Option` cannot rely on
polymorphic behavior of `T`. To make use of polymorphism we should
instead store e.g., a pointer type to avoid slicing.

Here we change `Flags` arguments of `subprocess` to allow preserving
the original type so `Flag` functions can work reliably; we do this by
passing a non-owning pointer to a `Flags` so we do not restrict copying.


Diffs (updated)
-

  src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
  src/health-check/health_checker.cpp d43cb0568c120cbcec6a73d232396ccc54cf3e58 
  src/launcher/posix/executor.cpp 43573cacee4e681d4327a7ed7c43b4ee263aa175 
  src/linux/perf.cpp 9455210064779b59ad56637d846fe7584b21340f 
  src/slave/container_loggers/lib_logrotate.cpp 
1fca4864457388b265779fbca72296336f1aa5a9 
  src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
842f2b5d4037e076cac4fd9c2eeb8f69786cffa7 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
760d32bf3dc09f3b715b378f5ded41556f15fe41 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
92f3c07e285ad3b8ef26692aa6475d755188b469 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
f97ace9579879b35cb8050c56e968a31bb741c55 
  src/slave/containerizer/mesos/launcher.hpp 
bf435e3a9c150648336a1becf2f075fa183428bd 
  src/slave/containerizer/mesos/launcher.cpp 
9efe8474a2210957ce256fc08cb35694194213c3 
  src/slave/containerizer/mesos/linux_launcher.hpp 
c1852226c74bc611d045be721e284141e59adcd9 
  src/slave/containerizer/mesos/linux_launcher.cpp 
95dee95c5e6e613e526c92d8729ae5583c8b58f1 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
  src/tests/containerizer/launch_tests.cpp 
ef0c87c96e6a8379d119246a8ad044248522e67e 
  src/tests/containerizer/launcher.hpp 7e5c243efad11d04e70b36876b2ed4db82666d31 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
  src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31 
  src/tests/containerizer/port_mapping_tests.cpp 
fd181cae5540de1fdd631367aba5cce249f1b72c 

Diff: https://reviews.apache.org/r/46822/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review145534
---



Bad patch!

Reviews applied: [46825, 46824, 46823, 46822, 46821]

Failed command: ./support/apply-review.sh -n -r 46822

Error:
2016-08-11 18:01:48 URL:https://reviews.apache.org/r/46822/diff/raw/ 
[16997/16997] -> "46822.patch" [1]
error: patch failed: src/health-check/health_checker.hpp:224
error: src/health-check/health_checker.hpp: patch does not apply
error: patch failed: src/tests/containerizer/launcher.hpp:65
error: src/tests/containerizer/launcher.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14755/console

- Mesos ReviewBot


On Aug. 11, 2016, 4:33 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated Aug. 11, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags.hpp 
> bc4684d499bad6e409953f608330325c4a13d6a6 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 4ca6c69aeb1e3343e9b0ae2562c450c4c645890c 
>   3rdparty/stout/tests/flags_tests.cpp 
> 94ba915c40836e476cf6097274a85c55acd4d73b 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

[Anindya Sinha]

> On Aug. 10, 2016, 7:23 p.m., Benjamin Mahler wrote:
> > src/examples/persistent_volume_framework.cpp, lines 402-410
> > 
> >
> > Can you give some context on why lowering these speeds up the test? How 
> > much does it speed it up?
> 
> haosdent huang wrote:
> Hi, @bmahler The most effective snippet is
> 
> ```
> export MESOS_AUTHENTICATION_TIMEOUT=200ms
> ```
> 
> which we committed before. I test this patch again, seems only bring 
> little speed up.
> 
> Before apply the patch,
> 
> ```
> [   OK ] ExamplesTest.PersistentVolumeFramework (3505 ms)
> [--] 1 test from ExamplesTest (3510 ms total)
> ```
> 
> After apply the patch,
> 
> ```
> [   OK ] ExamplesTest.PersistentVolumeFramework (2493 ms)
> [--] 1 test from ExamplesTest (2497 ms total)
> ```
> 
> Do you think we should discard this?

I think the improvement is not due to the reduction in number of shards (since 
the ACCEPT call consolidates offer operations for all shards), but due to the 
reduction in number of tasks per shard (since each of the tasks are launched in 
separate ACCEPT calls).


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43558/#review145390
---


On Aug. 10, 2016, 5:21 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43558/
> ---
> 
> (Updated Aug. 10, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-4663
> https://issues.apache.org/jira/browse/MESOS-4663
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up ExamplesTest.PersistentVolumeFramework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
> 
> Diff: https://reviews.apache.org/r/43558/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 
> --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

[Michael Park]

> On Aug. 11, 2016, 10:16 a.m., Michael Park wrote:
> > Hi Klaus, could you explain what the motivation is for this patch?
> > Currently, your analysis seems correct that reserved resources are always 
> > non-revocable.
> > However, the current code seems that it'll be more future-proof.
> > That is, even after reserved resources becomes revocable it would remain 
> > correct.
> > 
> > Anyway, I'm curiuos as to why this patch is being suggested. Thanks!
> 
> Klaus Ma wrote:
> Try to improve the performance by avoid unnecessary operation :).

That would've been my guess. Are there any numbers to support the patch?


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45081/#review145489
---


On April 19, 2016, 4:01 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45081/
> ---
> 
> (Updated April 19, 2016, 4:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and 
> Michael Park.
> 
> 
> Bugs: MESOS-4988
> https://issues.apache.org/jira/browse/MESOS-4988
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allocator will only allocate non-revocable resources to satify quota. As the 
> reserved resources can not be revocable, it's not necessary to call 
> `nonRevocable()` for reserved resources.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 70291075c00a9a557529c2562dedcfc6c6c3ec32 
> 
> Diff: https://reviews.apache.org/r/45081/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 50994: Updated 'HealthCheck' protobuf validation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50994/#review145529
---



I think we need to update `launchHealthCheck` in `src/docker/executor.cpp` as 
well. But I feel it would better to update it when adding HTTP health check and 
do it in a sperate patch.

- haosdent huang


On Aug. 11, 2016, 5:35 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50994/
> ---
> 
> (Updated Aug. 11, 2016, 5:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6025
> https://issues.apache.org/jira/browse/MESOS-6025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated 'HealthCheck' protobuf validation.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 7bc345bbc835f31feb2114cba434ab544451dbb0 
>   src/health-check/health_checker.cpp 
> d43cb0568c120cbcec6a73d232396ccc54cf3e58 
>   src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
>   src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c 
>   src/tests/health_check_tests.cpp 3b44d80fd079f216896f9386fb22d518061938ab 
> 
> Diff: https://reviews.apache.org/r/50994/diff/
> 
> 
> Testing
> ---
> 
> Test via `sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="*HealthCheckTest*" --verbose`
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50994: Updated 'HealthCheck' protobuf validation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50994/
---

(Updated Aug. 11, 2016, 5:35 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Bugs: MESOS-6025
https://issues.apache.org/jira/browse/MESOS-6025


Repository: mesos


Description
---

Updated 'HealthCheck' protobuf validation.


Diffs
-

  src/health-check/health_checker.hpp 7bc345bbc835f31feb2114cba434ab544451dbb0 
  src/health-check/health_checker.cpp d43cb0568c120cbcec6a73d232396ccc54cf3e58 
  src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
  src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c 
  src/tests/health_check_tests.cpp 3b44d80fd079f216896f9386fb22d518061938ab 

Diff: https://reviews.apache.org/r/50994/diff/


Testing (updated)
---

Test via `sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest*" 
--verbose`


Thanks,

haosdent huang

Review Request 50996: Dispatched health check by type.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50996/
---

Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Repository: mesos


Description
---

Dispatched health check by type.


Diffs
-

  src/health-check/health_checker.hpp 7bc345bbc835f31feb2114cba434ab544451dbb0 
  src/health-check/health_checker.cpp d43cb0568c120cbcec6a73d232396ccc54cf3e58 

Diff: https://reviews.apache.org/r/50996/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50994: Updated 'HealthCheck' protobuf validation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50994/
---

Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Bugs: MESOS-6025
https://issues.apache.org/jira/browse/MESOS-6025


Repository: mesos


Description
---

Updated 'HealthCheck' protobuf validation.


Diffs
-

  src/health-check/health_checker.hpp 7bc345bbc835f31feb2114cba434ab544451dbb0 
  src/health-check/health_checker.cpp d43cb0568c120cbcec6a73d232396ccc54cf3e58 
  src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
  src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c 
  src/tests/health_check_tests.cpp 3b44d80fd079f216896f9386fb22d518061938ab 

Diff: https://reviews.apache.org/r/50994/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.

[haosdent huang]

> On Aug. 11, 2016, 5:12 p.m., James Peach wrote:
> > As mentioned on chat, I think this will break some external module builds. 
> > I'm fine with that, just pointing it out for posterity.
> > 
> > I noticed that the Java bindings use these in the 
> > MesosNativeLibrary.Version class. The Java side of the bindings says this 
> > is a ``jlong``, but prior to this change it would have been a string 
> > AFAICT. So I guess this fixes that too?
> 
> Zhitao Li wrote:
> I added as many people who might know what existing module already exists 
> as I can think of, but feel free to suggest more.
> 
> If we want to provide a upgrade cycle, we can keep current macros 
> unchanged and define new ones like
> 
> ```
> // TODO: Remove after migration cycle.
> #define MESOS_MAJOR_VERSION "@MESOS_MAJOR_VERSION@"
> #define MESOS_MAJOR_VERSION_INT @MESOS_MAJOR_VERSION@
> ```
> 
> Just decided to roll forward faster until someone told me this could 
> actually break something.
> 
> James Peach wrote:
> Yup, good plan. +1

+1 for this changes.

And I think we need to sending a seprate email about

```
I think this will break some external module builds
```

to modu...@mesos.apache.org and d...@mesos.apache.org


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145522
---


On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> ---
> 
> (Updated Aug. 11, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris 
> Van Remoortere, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4638
> https://issues.apache.org/jira/browse/MESOS-4638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This makes version based conditional compiling much easier for
> module writers.
> 
> 
> Diffs
> -
> 
>   include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 
> 
> Diff: https://reviews.apache.org/r/50992/diff/
> 
> 
> Testing
> ---
> 
> make on Mac OS and Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45698: Minor cleanups in Disk Quota tests.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45698/#review145525
---


Ship it!




Ship It!

- Michael Park


On Aug. 11, 2016, 5:21 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45698/
> ---
> 
> (Updated Aug. 11, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial patch cleans up the disk quota tests:
> 
> - Removed some extraneous extra blank lines.
> - Modified some variables to be captured by reference.
> - Removed `.get()` and replaced it with `->` operator.
> 
> 
> Diffs
> -
> 
>   src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 
> 
> Diff: https://reviews.apache.org/r/45698/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.

[James Peach]

> On Aug. 11, 2016, 5:12 p.m., James Peach wrote:
> > As mentioned on chat, I think this will break some external module builds. 
> > I'm fine with that, just pointing it out for posterity.
> > 
> > I noticed that the Java bindings use these in the 
> > MesosNativeLibrary.Version class. The Java side of the bindings says this 
> > is a ``jlong``, but prior to this change it would have been a string 
> > AFAICT. So I guess this fixes that too?
> 
> Zhitao Li wrote:
> I added as many people who might know what existing module already exists 
> as I can think of, but feel free to suggest more.
> 
> If we want to provide a upgrade cycle, we can keep current macros 
> unchanged and define new ones like
> 
> ```
> // TODO: Remove after migration cycle.
> #define MESOS_MAJOR_VERSION "@MESOS_MAJOR_VERSION@"
> #define MESOS_MAJOR_VERSION_INT @MESOS_MAJOR_VERSION@
> ```
> 
> Just decided to roll forward faster until someone told me this could 
> actually break something.

Yup, good plan. +1


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145522
---


On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> ---
> 
> (Updated Aug. 11, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris 
> Van Remoortere, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4638
> https://issues.apache.org/jira/browse/MESOS-4638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This makes version based conditional compiling much easier for
> module writers.
> 
> 
> Diffs
> -
> 
>   include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 
> 
> Diff: https://reviews.apache.org/r/50992/diff/
> 
> 
> Testing
> ---
> 
> make on Mac OS and Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.

[Zhitao Li]

> On Aug. 11, 2016, 5:12 p.m., James Peach wrote:
> > As mentioned on chat, I think this will break some external module builds. 
> > I'm fine with that, just pointing it out for posterity.
> > 
> > I noticed that the Java bindings use these in the 
> > MesosNativeLibrary.Version class. The Java side of the bindings says this 
> > is a ``jlong``, but prior to this change it would have been a string 
> > AFAICT. So I guess this fixes that too?

I added as many people who might know what existing module already exists as I 
can think of, but feel free to suggest more.

If we want to provide a upgrade cycle, we can keep current macros unchanged and 
define new ones like

```
// TODO: Remove after migration cycle.
#define MESOS_MAJOR_VERSION "@MESOS_MAJOR_VERSION@"
#define MESOS_MAJOR_VERSION_INT @MESOS_MAJOR_VERSION@
```

Just decided to roll forward faster until someone told me this could actually 
break something.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145522
---


On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> ---
> 
> (Updated Aug. 11, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris 
> Van Remoortere, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4638
> https://issues.apache.org/jira/browse/MESOS-4638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This makes version based conditional compiling much easier for
> module writers.
> 
> 
> Diffs
> -
> 
>   include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 
> 
> Diff: https://reviews.apache.org/r/50992/diff/
> 
> 
> Testing
> ---
> 
> make on Mac OS and Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145522
---



As mentioned on chat, I think this will break some external module builds. I'm 
fine with that, just pointing it out for posterity.

I noticed that the Java bindings use these in the MesosNativeLibrary.Version 
class. The Java side of the bindings says this is a ``jlong``, but prior to 
this change it would have been a string AFAICT. So I guess this fixes that too?

- James Peach


On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> ---
> 
> (Updated Aug. 11, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris 
> Van Remoortere, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4638
> https://issues.apache.org/jira/browse/MESOS-4638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This makes version based conditional compiling much easier for
> module writers.
> 
> 
> Diffs
> -
> 
>   include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 
> 
> Diff: https://reviews.apache.org/r/50992/diff/
> 
> 
> Testing
> ---
> 
> make on Mac OS and Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 50981: Fix volumes help message example mistake.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50981/#review145521
---



Patch looks great!

Reviews applied: [50981]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 2:54 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50981/
> ---
> 
> (Updated Aug. 11, 2016, 2:54 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-6028
> https://issues.apache.org/jira/browse/MESOS-6028
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed docker_options to driver_options.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 
> 
> Diff: https://reviews.apache.org/r/50981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/
---

Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris 
Van Remoortere, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-4638
https://issues.apache.org/jira/browse/MESOS-4638


Repository: mesos


Description (updated)
---

This makes version based conditional compiling much easier for
module writers.


Diffs (updated)
-

  include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 

Diff: https://reviews.apache.org/r/50992/diff/


Testing (updated)
---

make on Mac OS and Linux.


Thanks,

Zhitao Li

Re: Review Request 49435: Added test cases for http health check.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49435/#review145518
---




src/tests/health_check_tests.cpp (lines 1340 - 1343)


You actually health check the agent instead of health checking the task : 
). This needs to be at least documented!


- Alexander Rukletsov


On Aug. 1, 2016, 1:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49435/
> ---
> 
> (Updated Aug. 1, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test cases for http health check.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp 47c35d15a259d470f21f81303879077787c125e7 
> 
> Diff: https://reviews.apache.org/r/49435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated Aug. 11, 2016, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov, Michael Park, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/disk_full_framework.cpp ad304fee94d443125a0dec2b2820267c69508621 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp 441e86c88b035d9a268b8b51b95da3e1eb842a62 
  src/launcher/executor.cpp 7967684e42c97326770bd83a41c2d4b1338a511f 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
  src/slave/container_loggers/lib_logrotate.hpp 
f216548ef37f5c2245ef64d21e84e06100e8e5ae 
  src/slave/container_loggers/logrotate.hpp 
96697d46ca71e7f62119f2fe669230cf5a04242f 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
760d32bf3dc09f3b715b378f5ded41556f15fe41 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
92f3c07e285ad3b8ef26692aa6475d755188b469 
  src/slave/containerizer/mesos/launch.cpp 
2db8db5ac2f4614d406b950a1b4e8098a0d90e7b 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated Aug. 11, 2016, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags.hpp 
bc4684d499bad6e409953f608330325c4a13d6a6 
  3rdparty/stout/include/stout/flags/flags.hpp 
4ca6c69aeb1e3343e9b0ae2562c450c4c645890c 
  3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier

Re: Review Request 50914: Removed the external containerizer.

[Jie Yu]

> On Aug. 10, 2016, 7:21 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 2263
> > 
> >
> > this should be deleted as well. this is causing the ASF CI to fail.
> 
> Vinod Kone wrote:
> I pushed the fix.

Thanks vinod. Some how this is not exposed in our own CI :(


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50914/#review145389
---


On Aug. 9, 2016, 8:12 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50914/
> ---
> 
> (Updated Aug. 9, 2016, 8:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-3370
> https://issues.apache.org/jira/browse/MESOS-3370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the external containerizer.
> 
> 
> Diffs
> -
> 
>   configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 
>   docs/committers.md a4cf837e3058686347bc721dc7f0745f88c4fa81 
>   docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
>   docs/containerizer-internals.md 1839c7290c2c7681c516b3514face7496ffb2521 
>   docs/external-containerizer.md eece9e73d47c13cc50074ef77235147f09cd380a 
>   docs/fetcher.md 688984552ae243eb59a3c1bfb7abd3898e4fac67 
>   docs/home.md 80451f4a9b2327dc728b9454938b6205043bebbb 
>   docs/sandbox.md db973e311b8562aa25fcdcdabefa1f342d25e26e 
>   include/mesos/containerizer/containerizer.proto 
> 4d8e82791c263c6578bf06f4e94ebe853042be59 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
>   src/examples/python/test-containerizer.in 
> 5066b45d11ce0418d6c8ae8374b5103cb0eaa249 
>   src/examples/python/test_containerizer.py 
> 8e154b0e8e0db3cfc5d3f695d509b0e49bcec652 
>   src/slave/containerizer/containerizer.cpp 
> ba3b3f62fe0cf755fdbebf52350d9069cb2efca8 
>   src/slave/containerizer/external_containerizer.hpp 
> feeb0278a3d8fec8c7177a9a3dc443ee0c198c5c 
>   src/slave/containerizer/external_containerizer.cpp 
> 9ee137a7731e66754bbf86424071765962423969 
>   src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 
>   src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 226eac56725e908040abda306a2e5e3c96bce9d7 
> 
> Diff: https://reviews.apache.org/r/50914/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/#review145511
---



Patch looks great!

Reviews applied: [49819, 49820, 49821, 49823, 49824, 49825, 49827, 50627, 
50642, 50643, 49817, 49828, 49849, 49850, 49851, 49852, 49853, 49854, 49855, 
50758, 50733, 50748, 50749, 50750, 50751]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 2:21 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50751/
> ---
> 
> (Updated Aug. 11, 2016, 2:21 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5975
> https://issues.apache.org/jira/browse/MESOS-5975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsPerfEventIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
>   src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 4abde12af68a26b94b3706cdb38bf9890d811039 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
> 31f35385691681ef5da14be747edfb5f57c5d05a 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
>   src/tests/containerizer/isolator_tests.cpp 
> 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
> 
> Diff: https://reviews.apache.org/r/50751/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50841/#review145507
---




src/slave/containerizer/docker.hpp (lines 215 - 218)


How about kill this and add two new functions as following:

```
process::Future deallocateNvidiaGpu(
const ContainerID& containerId);

process::Future allocateNvidiaGpu(
size_t requestedNvidiaGpu,
const ContainerID& containerId);
```



src/slave/containerizer/docker.cpp (lines 1325 - 1355)


What about adding a new function named as 
`DockerContainerizerProcess::allocateNvidiaGpu`.

```
Future DockerContainerizerProcess::allocateNvidiaGpu(
size_t requestedNvidiaGpu,
const ContainerID& containerId)
{
  if (!containers_.contains(containerId)) {
return Failure("Container is already destroyed");
  }

  Container* container = containers_[containerId];

  if (requestedNvidiaGpu <= 0) {
return Nothing();
  }

  return nvidiaGpuAllocator->allocate(requestedNvidiaGpu)
.then(defer(self(), [=](set allocated) -> Future {
  foreach (const Gpu& gpu, allocated) {
container->gpuAllocated.push_back(gpu);
  }

  return Nothing();
}));
}
```

Then return followingn in the end of 
`DockerContainerizerProcess::launchExecutorProcess`:

```
const Resources& resources = taskInfo->resources();

Option gpus = resources.gpus();

// Make sure that the `gpus` resource is not fractional.
// We rely on scala resources only have 3 digits of precision.
if (static_cast(gpus.getOrElse(0.0) * 1000.0) % 1000 != 0) {
  return Failure("The 'gpus' resource must be an unsigned integer");
}

size_t requested = static_cast(gpus.getOrElse(0.0));

return allocateNvidiaGpu(requested, containerId)
  .then(defer(self(), [=]() {
return logger->prepare(container->executor, container->directory);
  }))
  .then(defer(
  self(),
  [=](const ContainerLogger::SubprocessInfo& subprocessInfo)
-> Future {
  // NOTE: The child process will be blocked until all hooks have been
  // executed.
  vector parentHooks;

  // NOTE: Currently we don't care about the order of the hooks, as
  // both hooks are independent.

  // A hook that is executed in the parent process. It attempts to 
checkpoint
  // the process pid.
  //
  // NOTE:
  // - The child process is blocked by the hook infrastructure while
  //   these hooks are executed.
  // - It is safe to bind `this`, as hooks are executed immediately
  //   in a `subprocess` call.
  // - If `checkpoiont` returns an Error, the child process will be killed.
  parentHooks.emplace_back(Subprocess::Hook(lambda::bind(
  ::checkpoint,
  this,
  containerId,
  lambda::_1)));

#ifdef __linux__
// If we are on systemd, then extend the life of the executor. Any
// grandchildren's lives will also be extended.
if (systemd::enabled()) {
  parentHooks.emplace_back(Subprocess::Hook(
  ::mesos::extendLifetime));
}
#endif // __linux__

// Prepare the flags to pass to the mesos docker executor process.
docker::Flags launchFlags = dockerFlags(
flags,
container->name(),
container->directory,
container->taskEnvironment);

VLOG(1) << "Launching 'mesos-docker-executor' with flags '"
<< launchFlags << "'";

// Construct the mesos-docker-executor using the "name" we gave the
// container (to distinguish it from Docker containers not created
// by Mesos).
Try s = subprocess(
path::join(flags.launcher_dir, "mesos-docker-executor"),
argv,
Subprocess::PIPE(),
subprocessInfo.out,
subprocessInfo.err,
SETSID,
launchFlags,
environment,
None(),
parentHooks,
container->directory);

if (s.isError()) {
  return Failure("Failed to fork executor: " + s.error());
}

return s.get().pid();
  }));
}

```



src/slave/containerizer/docker.cpp (lines 1544 - 1559)


What about abstract this to a new function so that this can also be used by 
`DockerContainerizerProcess::destroy`.

```
Future DockerContainerizerProcess::deallocateNvidiaGpu(
  const ContainerID& containerId)
{
  set deallocated;
  if 

Re: Review Request 50981: Fix volumes help message example mistake.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50981/#review145506
---


Ship it!




Thanks @Tomasz, can you please add @jieyu as reviewer so that he can help 
commit your patch?

- Guangya Liu


On 八月 11, 2016, 2:07 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50981/
> ---
> 
> (Updated 八月 11, 2016, 2:07 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-6028
> https://issues.apache.org/jira/browse/MESOS-6028
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed docker_options to driver_options.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 
> 
> Diff: https://reviews.apache.org/r/50981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49853/
---

(Updated Aug. 11, 2016, 2:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Implemented `PerfEventSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49853/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50981: Fix volumes help message example mistake.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50981/#review145505
---


Ship it!




Ship It!

- haosdent huang


On Aug. 11, 2016, 2:07 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50981/
> ---
> 
> (Updated Aug. 11, 2016, 2:07 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-6028
> https://issues.apache.org/jira/browse/MESOS-6028
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed docker_options to driver_options.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 
> 
> Diff: https://reviews.apache.org/r/50981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
  src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49855/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5652
https://issues.apache.org/jira/browse/MESOS-5652


Repository: mesos


Description
---

Enabled cgroups unified isolator in isolation.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 

Diff: https://reviews.apache.org/r/49855/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5973
https://issues.apache.org/jira/browse/MESOS-5973


Repository: mesos


Description
---

Removed CgroupsCpushareIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
  src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
  src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
74982a610b6c0a74734165a0c6aa8c9f72f54deb 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
221e814a448c4b5df9dab98de597451a24e2b89c 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 

Diff: https://reviews.apache.org/r/50733/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/
---

(Updated Aug. 11, 2016, 2:21 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Removed CgroupsPerfEventIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
  src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
4abde12af68a26b94b3706cdb38bf9890d811039 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
31f35385691681ef5da14be747edfb5f57c5d05a 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 

Diff: https://reviews.apache.org/r/50751/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50749/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5977
https://issues.apache.org/jira/browse/MESOS-5977


Repository: mesos


Description
---

Removed CgroupsDevicesIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
  src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/devices.hpp 
7ad96440b21a380c5d9af27b0168e9abf47769af 
  src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 
f1b5e75d23780c0e1d53487852422b02c88de9e8 

Diff: https://reviews.apache.org/r/50749/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50748/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5974
https://issues.apache.org/jira/browse/MESOS-5974


Repository: mesos


Description
---

Removed CgroupsMemIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
  src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
  src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 
b3ce6ed2505312bdd2d800164c2f57cd7625c9fa 
  src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
0a4f38ded5cffd438e2a3b1e7d066c3077557f0d 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 

Diff: https://reviews.apache.org/r/50748/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49850/
---

(Updated Aug. 11, 2016, 2:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Implemented `CpuacctSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49850/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50758/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 

Diff: https://reviews.apache.org/r/50758/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49854: Implemented `DevicesSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49854/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5651
https://issues.apache.org/jira/browse/MESOS-5651


Repository: mesos


Description
---

Implemented `DevicesSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49854/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49852: Implemented `NetClsSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49852/
---

(Updated Aug. 11, 2016, 2:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Implemented `NetClsSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49852/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49851: Implemented `MemorySubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/
---

(Updated Aug. 11, 2016, 2:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Implemented `MemorySubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49851/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49828/
---

(Updated Aug. 11, 2016, 2:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Added default methods implementations for `Subsystem` base class.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49828/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49849: Implemented `CpuSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/
---

(Updated Aug. 11, 2016, 2:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Implemented `CpuSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49849/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated Aug. 11, 2016, 2:18 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Address @jieyu's comments.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50981: Fix volumes help message example mistake.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50981/
---

(Updated Aug. 11, 2016, 2:07 p.m.)


Review request for mesos and Guangya Liu.


Bugs: MESOS-6028
https://issues.apache.org/jira/browse/MESOS-6028


Repository: mesos


Description
---

Changed docker_options to driver_options.


Diffs
-

  src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 

Diff: https://reviews.apache.org/r/50981/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Review Request 50981: Fix volumes help message example mistake.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50981/
---

Review request for mesos and Guangya Liu.


Repository: mesos


Description
---

Changed docker_options to driver_options.


Diffs
-

  src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 

Diff: https://reviews.apache.org/r/50981/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

[Klaus Ma]

> On Aug. 11, 2016, 6:16 p.m., Michael Park wrote:
> > Hi Klaus, could you explain what the motivation is for this patch?
> > Currently, your analysis seems correct that reserved resources are always 
> > non-revocable.
> > However, the current code seems that it'll be more future-proof.
> > That is, even after reserved resources becomes revocable it would remain 
> > correct.
> > 
> > Anyway, I'm curiuos as to why this patch is being suggested. Thanks!

Try to improve the performance by avoid unnecessary operation :).


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45081/#review145489
---


On April 19, 2016, 12:01 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45081/
> ---
> 
> (Updated April 19, 2016, 12:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and 
> Michael Park.
> 
> 
> Bugs: MESOS-4988
> https://issues.apache.org/jira/browse/MESOS-4988
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allocator will only allocate non-revocable resources to satify quota. As the 
> reserved resources can not be revocable, it's not necessary to call 
> `nonRevocable()` for reserved resources.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 70291075c00a9a557529c2562dedcfc6c6c3ec32 
> 
> Diff: https://reviews.apache.org/r/45081/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50270/
---

(Updated Aug. 11, 2016, 2:48 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased onto recent master.


Bugs: MESOS-5303
https://issues.apache.org/jira/browse/MESOS-5303


Repository: mesos


Description
---

This change introduces linux capability based security for unified
containerizer. A new agent flag \`allowed_capabilities\` has been
introduced to override the default capabilities of the user or the
capabilities requested by the user.

This feature is only available on linux.

This patch is based on https://reviews.apache.org/r/46798/.


Diffs (updated)
-

  src/common/parse.hpp 5dc795d7f54209abe64ad48360f538faac7616f0 
  src/launcher/executor.cpp 7967684e42c97326770bd83a41c2d4b1338a511f 
  src/slave/flags.hpp ef2394cae5cb72ae627aaef443ac06a50bcfb16f 
  src/slave/flags.cpp c07d6e5e062b75c9dd867e3dced9e2cc8b69872d 

Diff: https://reviews.apache.org/r/50270/diff/


Testing
---

`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)


Thanks,

Benjamin Bannier

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review145496
---



Patch looks great!

Reviews applied: [41787]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 9:58 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> ---
> 
> (Updated Aug. 11, 2016, 9:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up SlaveRecoveryTest.*, and leave a comment on test cases that relies 
> on MESOS-4111 to speed up.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 59859f5bc249fbef916d6dfeafdc396a4c037117 
> 
> Diff: https://reviews.apache.org/r/41787/diff/
> 
> 
> Testing
> ---
> 
> Previous
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (2237 ms)
> SlaveRecoveryTest/0.ReconnectExecutor (2244 ms)
> SlaveRecoveryTest/0.ReconcileKillTask (3067 ms)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (3287 ms)
> 
> Current
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms)
> SlaveRecoveryTest/0.ReconnectExecutor (308 ms)
> SlaveRecoveryTest/0.ReconcileKillTask (374 ms)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (244 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45081/#review145489
---



Hi Klaus, could you explain what the motivation is for this patch?
Currently, your analysis seems correct that reserved resources are always 
non-revocable.
However, the current code seems that it'll be more future-proof.
That is, even after reserved resources becomes revocable it would remain 
correct.

Anyway, I'm curiuos as to why this patch is being suggested. Thanks!

- Michael Park


On April 19, 2016, 4:01 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45081/
> ---
> 
> (Updated April 19, 2016, 4:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and 
> Michael Park.
> 
> 
> Bugs: MESOS-4988
> https://issues.apache.org/jira/browse/MESOS-4988
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allocator will only allocate non-revocable resources to satify quota. As the 
> reserved resources can not be revocable, it's not necessary to call 
> `nonRevocable()` for reserved resources.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 70291075c00a9a557529c2562dedcfc6c6c3ec32 
> 
> Diff: https://reviews.apache.org/r/45081/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 50851: Decode Protobuf long int form strings.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50851/#review145486
---



Patch looks great!

Reviews applied: [50851]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 8:47 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50851/
> ---
> 
> (Updated Aug. 11, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5995
> https://issues.apache.org/jira/browse/MESOS-5995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> According to Protobuf JSON mapping long integers
> should be stored as strings.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/protobuf.hpp 
> 91305e104c01d649bd435a27b15954036c27 
>   3rdparty/stout/tests/protobuf_tests.cpp 
> 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> Diff: https://reviews.apache.org/r/50851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 八月 11, 2016, 9:58 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

address greg's comments


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Speed up SlaveRecoveryTest.*, and leave a comment on test cases that relies on 
MESOS-4111 to speed up.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 59859f5bc249fbef916d6dfeafdc396a4c037117 

Diff: https://reviews.apache.org/r/41787/diff/


Testing (updated)
---

Previous
SlaveRecoveryTest/0.RecoverStatusUpdateManager (2237 ms)
SlaveRecoveryTest/0.ReconnectExecutor (2244 ms)
SlaveRecoveryTest/0.ReconcileKillTask (3067 ms)
SlaveRecoveryTest/0.ReconcileShutdownFramework (3287 ms)

Current
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms)
SlaveRecoveryTest/0.ReconnectExecutor (308 ms)
SlaveRecoveryTest/0.ReconcileKillTask (374 ms)
SlaveRecoveryTest/0.ReconcileShutdownFramework (244 ms)


Thanks,

Jian Qiu

Re: Review Request 50974: Documented all the API calls for Operator HTTP API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50974/#review145484
---



Patch looks great!

Reviews applied: [50974]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 8:33 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50974/
> ---
> 
> (Updated Aug. 11, 2016, 8:33 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-5992
> https://issues.apache.org/jira/browse/MESOS-5992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented all the API calls for Operator HTTP API.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
> 
> Diff: https://reviews.apache.org/r/50974/diff/
> 
> 
> Testing
> ---
> 
> Checked the generated page through "rake dev".
> Validated and formatted all the JSON snippets with:
> http://jsonlint.com/
> http://jsonviewer.stack.hu/
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/
---

(Updated 八月 11, 2016, 9:09 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
docker and external containerizers do not need it anymore. This removed
the 'gpu/nvidia' isolator check for docker and external containerizers.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
c1a87e9e5c07529bc1d077f68477108a40506806 

Diff: https://reviews.apache.org/r/50947/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50851: Decode Protobuf long int form strings.

[Tomasz Janiszewski]

> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote:
> > Can you add the reason/motivation for this change in your patch description?

@Josheph I added description and fixed/commented issues. Would you like to 
review it one mor time.


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50851/#review145430
---


On Aug. 11, 2016, 8:47 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50851/
> ---
> 
> (Updated Aug. 11, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5995
> https://issues.apache.org/jira/browse/MESOS-5995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> According to Protobuf JSON mapping long integers
> should be stored as strings.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/protobuf.hpp 
> 91305e104c01d649bd435a27b15954036c27 
>   3rdparty/stout/tests/protobuf_tests.cpp 
> 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> Diff: https://reviews.apache.org/r/50851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 50851: Decode Protobuf long int form strings.

[Tomasz Janiszewski]

> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/protobuf.hpp, lines 443-459
> > 
> >
> > I wonder how far we want to follow the protobuf mapping 
> > recommendations.  Technically, protobuf3 takes strings for all types of 
> > numbers :)
> > 
> > I'm fine with just large numbers however.

int32, fixed32, uint32 should be stored as a numbers. With float and double 
there is exception for "NaN" and "Infinity"


> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/protobuf.hpp, line 447
> > 
> >
> > Unfortunately, `std::stoll` and similar functions will throw exceptions 
> > if they fail.  And Mesos does not use exceptions.
> > 
> > You'll need to parse the string some other way (i.e. `strtoimax`) and 
> > return an `Error` if the parsing fails.

Good catch. I used `numify`.


> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote:
> > 3rdparty/stout/tests/protobuf_tests.cpp, lines 334-336
> > 
> >
> > This should be checking for equality, rather than parse success:
> > 
> > EXPECT_SOME_EQ(, json);

In this test I'm not interested in checking if String to JSON works. It's only 
used to generate JSON that will be parsed into message.


> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote:
> > 3rdparty/stout/tests/protobuf_tests.cpp, lines 342-343
> > 
> >
> > This is actually a Protobuf -> JSON -> String conversion.
> > 
> > You'll want to split these two apart and have one comparision for each 
> > step.

I changed it to compare against `Message` object. But since there is no equal 
method for protobuf object I serialise them to JSON.


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50851/#review145430
---


On Aug. 11, 2016, 8:47 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50851/
> ---
> 
> (Updated Aug. 11, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5995
> https://issues.apache.org/jira/browse/MESOS-5995
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> According to Protobuf JSON mapping long integers
> should be stored as strings.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/protobuf.hpp 
> 91305e104c01d649bd435a27b15954036c27 
>   3rdparty/stout/tests/protobuf_tests.cpp 
> 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> Diff: https://reviews.apache.org/r/50851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 50851: Decode Protobuf long int form strings.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50851/
---

(Updated Aug. 11, 2016, 8:47 a.m.)


Review request for mesos, Anand Mazumdar and Joseph Wu.


Changes
---

Use numify to parse strings and handle errors.


Bugs: MESOS-5995
https://issues.apache.org/jira/browse/MESOS-5995


Repository: mesos


Description (updated)
---

According to Protobuf JSON mapping long integers
should be stored as strings.


Diffs (updated)
-

  3rdparty/stout/include/stout/protobuf.hpp 
91305e104c01d649bd435a27b15954036c27 
  3rdparty/stout/tests/protobuf_tests.cpp 
8877e8934e0f7875bfedcfa88b491ce4b13ca44f 

Diff: https://reviews.apache.org/r/50851/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review145480
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines 146 - 149)


```
// Mesos containerizer needs to enable isolator flag "gpu/nvidia" to use
// GPUs, we don't allow the `--nvidia-gpu_devices` flag without the GPU
// isolator; For docker containerizers, this limitation is not set.
```



src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line 147)


s/For docker and external containerizers/For docker containerizers

The external containerizer was already removed.


- Guangya Liu


On 八月 11, 2016, 8:38 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50947/
> ---
> 
> (Updated 八月 11, 2016, 8:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Bugs: MESOS-5975
> https://issues.apache.org/jira/browse/MESOS-5975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
> docker and external containerizers do not need it anymore. This removed
> the 'gpu/nvidia' isolator check for docker and external containerizers.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
> c1a87e9e5c07529bc1d077f68477108a40506806 
> 
> Diff: https://reviews.apache.org/r/50947/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/
---

(Updated 八月 11, 2016, 8:38 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
docker and external containerizers do not need it anymore. This removed
the 'gpu/nvidia' isolator check for docker and external containerizers.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
c1a87e9e5c07529bc1d077f68477108a40506806 

Diff: https://reviews.apache.org/r/50947/diff/


Testing
---

make check


Thanks,

Yubo Li

Review Request 50974: Documented all the API calls for Operator HTTP API.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50974/
---

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-5992
https://issues.apache.org/jira/browse/MESOS-5992


Repository: mesos


Description
---

Documented all the API calls for Operator HTTP API.


Diffs
-

  docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 

Diff: https://reviews.apache.org/r/50974/diff/


Testing
---

Checked the generated page through "rake dev".
Validated and formatted all the JSON snippets with:
http://jsonlint.com/
http://jsonviewer.stack.hu/


Thanks,

Abhishek Dasgupta

Re: Review Request 49707: Replaced raw string with const.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49707/#review145470
---


Ship it!





src/slave/containerizer/fetcher.cpp (lines 199 - 200)


Formatting:

```
  if (!strings::startsWith(uri, FILE_URI_PREFIX) &&
  strings::contains(uri, "://")) {
```


- Michael Park


On July 6, 2016, 3:33 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49707/
> ---
> 
> (Updated July 6, 2016, 3:33 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced raw string with const.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.cpp 
> 8545d9813058e3f7af93ebadccec64a355333b72 
> 
> Diff: https://reviews.apache.org/r/49707/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>