Re: Review Request 66454: Updated the documented release schedule.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66454/#review200535
---


Ship it!




Ship It!

- Gilbert Song


On April 4, 2018, 11:48 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66454/
> ---
> 
> (Updated April 4, 2018, 11:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the documented release schedule.
> 
> 
> Diffs
> -
> 
>   docs/versioning.md 70feb53d68e579a4ec7dd545648caa898cbbf6de 
> 
> 
> Diff: https://reviews.apache.org/r/66454/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66467/#review200534
---



Patch looks great!

Reviews applied: [66458, 66459, 66460, 66461, 66462, 66463, 66464, 66465, 
66466, 66467]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 5, 2018, 12:50 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66467/
> ---
> 
> (Updated April 5, 2018, 12:50 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 
> 
> 
> Diff: https://reviews.apache.org/r/66467/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> The tests added by https://reviews.apache.org/r/66468/ use this helper.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66442/
---

(Updated April 4, 2018, 7:06 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Discarded commit in between.


Bugs: MESOS-8682
https://issues.apache.org/jira/browse/MESOS-8682


Repository: mesos


Description
---

Windows: Fixed `os::abort()` to use `WriteFile()`.


Diffs
-

  3rdparty/stout/include/stout/abort.hpp 
4fd233dfcd4359791dd176820f3a6040947bb291 


Diff: https://reviews.apache.org/r/66442/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66467/#review200533
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66458', '66459', '66460', '66461', '66462', '66463', 
'66464', '66465', '66466', '66467']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66467

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66467/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (118 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1093 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (72 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (803 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (827 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (839 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (867 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (448463 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66467/logs/mesos-tests-stderr.log):

```
I0405 02:01:56.922829  8072 master.cpp:10557] Updating the state of task 
ca1b3829-6022-43bf-87d1-644a54e6f24d of framework 
66b63d09-f4a9-449a-9b5e-0f51c6543bf3- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0405 02:01:56.922829  1732 slave.cpp:3877] Shutting down framework 
66b63d09-f4a9-449a-9b5e-0f51c6543bf3-
I0405 02:01:56.922829  1732 slave.cpp:6574] Shutting down executor 
'ca1b3829-6022-43bf-87d1-644a54e6f24d' of framework 
66b63d09-f4a9-449a-9b5e-0f51c6543bf3- at executor(1)@10.3.1.8:60027
I0405 02:01:56.728843  8892 exec.cpp:162] Version: 1.6.0
I0405 02:01:56.755925 10780 exec.cpp:236] Executor registered on agent 
66b63d09-f4a9-449a-9b5e-0f51c6543bf3-S0
I0405 02:01:56.760844 13684 executor.cpp:176] Received SUBSCRIBED event
I0405 02:01:56.764842 13684 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0405 02:01:56.765851 13684 executor.cpp:176] Received LAUNCH event
I0405 02:01:56.770840 13684 executor.cpp:648] Starting task 
ca1b3829-6022-43bf-87d1-644a54e6f24d
I0405 02:01:56.862841 13684 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0405 02:01:56.891847 13684 executor.cpp:661] Forked command at 3916
I0405 02:01:56.924829  4680 exec.cpp:445] Executor asked to shutdown
I0405 02:01:56.925829 12176 executor.cpp:176] Received SHUTDOWN event
I0405 02:01:56.925829 12176 executor.cpp:758] Shutting down
I0405 02:01:56.925829 12176 executor.cpp:868] Sending SIGTERM to process tree 
at pid 3I0405 02:01:56.923828  1732 slave.cpp:923] Agent terminating
W0405 02:01:56.924829  1732 slave.cpp:3873] Ignoring shutdown framework 
66b63d09-f4a9-449a-9b5e-0f51c6543bf3- because it is terminating
I0405 02:01:56.925829  8072 master.cpp:10656] Removing task 
ca1b3829-6022-43bf-87d1-644a54e6f24d with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 66b63d09-f4a9-449a-9b5e-0f51c6543bf3- on 
agent 66b63d09-f4a9-449a-9b5e-0f51c6543bf3-S0 at slave(418)@10.3.1.8:60006 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0405 02:01:56.927827  1732 containerizer.cpp:2338] Destroying container 
f92c0eff-76be-4e79-ade0-cc3e36cd6017 in RUNNING state
I0405 02:01:56.927827  1732 containerizer.cpp:2952] Transitioning the state of 
container f92c0eff-76be-4e79-ade0-cc3e36cd6017 from RUNNING to DESTROYING
I0405 02:01:56.928830  8072 master.cpp:1295] Agent 
66b63d09-f4a9-449a-9b5e-0f51c6543bf3-S0 at slave(418)@10.3.1.8:60006 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0405 02:01:56.928830  9808 hierarchical.cpp:344] Removed framework 

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66437/
---

(Updated April 4, 2018, 6:58 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Removed `INVALID` enum, replaced `operator int()` with `private: int 
get_valid()`.


Bugs: MESOS-8675 and MESOS-8683
https://issues.apache.org/jira/browse/MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8683


Repository: mesos


Description (updated)
---

After all the CRT APIs were replaced with Windows APIs, we no longer
needed to support the semantics of an `int` file descriptor in
general (in the sense of opening a CRT handle that's associated with
the actual kernel object for the given `HANDLE`). There are specific
use cases (usually third-party code) which still require a CRT
int-like file descriptor, which the `crt()` function explicitly
allocates (this allocation used to be done in the constructor).

Thus the entire `FD_CRT` type was removed from the `WindowsFD`
abstraction. It still acts like an `int` in the sense that it can be
constructed from one and compared to one. However, construction via
`int` only supports the standard file descriptors 0, 1, and 2 for
`stdin`, `stdout`, and `stderr`. Any other construction creates an
`int_fd` which holds an `INVALID_HANDLE` value. When being compared to
an `int`, the abstraction simply returns -1 if it is invalid (based on
the result of the `is_valid()` method) or 0 if it is valid. This is to
support the semantics of checking validity by something like `if (fd <
0)` or `if (fd == -1)`.

With the deletion of the `FD_CRT` type from `WindowsFD`, all the Stout
APIs that switched on the type were simplified, with the last of the
CRT code deleted.

Thanks to the introduction of the private `int get_valid()` function,
and the removal of the `FD_CRT` type, the comparison operators became
much simpler.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/close.hpp 
ff635e44235d63888a210cd68d49f6678a851e31 
  3rdparty/stout/include/stout/os/windows/dup.hpp 
265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 
  3rdparty/stout/include/stout/os/windows/fcntl.hpp 
bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 
  3rdparty/stout/include/stout/os/windows/fd.hpp 
d7f8cdf1ad877eb55589bf5a9e75d295f91990a7 
  3rdparty/stout/include/stout/os/windows/read.hpp 
8047ad590fcc46d3ec46b551472d8c518ae49cc1 
  3rdparty/stout/include/stout/os/windows/write.hpp 
71006489918d9495d37d2fdfdca08b40b419481a 
  3rdparty/stout/tests/os/filesystem_tests.cpp 
c190baa2230298e428d4034b90dccffb59b4e710 


Diff: https://reviews.apache.org/r/66437/diff/2/

Changes: https://reviews.apache.org/r/66437/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66459: Fixed bug in `Master::updateSlave()`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66459/#review200532
---



PASS: Mesos patch 66459 was successfully built and tested.

Reviews applied: `['66458', '66459']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66459

- Mesos Reviewbot Windows


On April 4, 2018, 4:49 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66459/
> ---
> 
> (Updated April 4, 2018, 4:49 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A part of `Master::updateSlave()` doesn't account for operations created
> via the operator API; this patch fixes that.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
> 
> 
> Diff: https://reviews.apache.org/r/66459/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66467/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.


Diffs
-

  src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 


Diff: https://reviews.apache.org/r/66467/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux

The tests added by https://reviews.apache.org/r/66468/ use this helper.


Thanks,

Gaston Kleiman

Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66466/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Updated `RESERVE()` helper to allow specifying an operation ID.


Diffs
-

  src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 


Diff: https://reviews.apache.org/r/66466/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux

The tests added by https://reviews.apache.org/r/66468/ use this helper with an 
`OperationID`.


Thanks,

Gaston Kleiman

Review Request 66465: Updated `using` statements in `tests/mesos.hpp`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66465/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Updated `using` statements in `tests/mesos.hpp`.


Diffs
-

  src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 


Diff: https://reviews.apache.org/r/66465/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux

The tests added by https://reviews.apache.org/r/66468/ use these statements.


Thanks,

Gaston Kleiman

Review Request 66464: Implemented operation status reconciliation.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Implemented operation status reconciliation.


Diffs
-

  src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 


Diff: https://reviews.apache.org/r/66464/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux

https://reviews.apache.org/r/66468/ adds new tests.


Thanks,

Gaston Kleiman

Re: Review Request 66457: Made resource provider API aware of workloads.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66457/#review200531
---



Bad patch!

Reviews applied: [66457, 66418, 66411, 66410, 66409, 66408, 66407, 66398]

Failed command: python support/apply-reviews.py -n -r 66398

Error:
2018-04-05 00:42:06 URL:https://reviews.apache.org/r/66398/diff/raw/ 
[1889/1889] -> "66398.patch" [1]
error: missing binary patch data for '3rdparty/csi-0.2.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.2.0.tar.gz'
error: 3rdparty/csi-0.2.0.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22100/console

- Mesos Reviewbot


On April 4, 2018, 11:22 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66457/
> ---
> 
> (Updated April 4, 2018, 11:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8760
> https://issues.apache.org/jira/browse/MESOS-8760
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch introduces a breaking change to change `PublishResources` to
> `ApplyResourceUsage`, so the resource provider is aware of workloads.
> For local resource providers, a workload is a container, and this call
> is responsible to prepare the resources for each container. For external
> resource providers, a workload is a framework, so this call can bookkeep
> the resource usage for each framework and inform the allocator after a
> failover.
> 
> Note that this call is designed to report ALL resources used by every
> workload on an agent, so it can handle resources without identifiers.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> db7c751bb61fb1ee2421015dcbefc021c3afbdac 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 42bc050ed01a272603a41ab052ed75d799dd76e2 
> 
> 
> Diff: https://reviews.apache.org/r/66457/diff/1/
> 
> 
> Testing
> ---
> 
> This patch cannot be compiled standalone. Tests will be done later in the 
> chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 66463: Added a master metric for operations reconciliation messages.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66463/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Added a master metric for operations reconciliation messages.


Diffs
-

  docs/monitoring.md 12e2103eb041e3e1b99bddafafcf4c615205fb0c 
  docs/operator-http-api.md 10dcac83fa70da5760a5c231665d7498cc168622 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
  src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 
  src/tests/master_tests.cpp be7a3cc6126d2fe7c56c49b3da5f6f4bf29657f5 


Diff: https://reviews.apache.org/r/66463/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 66462: Added new operation states to be used for status reconciliation.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Added new operation states to be used for status reconciliation.


Diffs
-

  include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 
  include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 
  src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 
  src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
  src/slave/slave.cpp b17854788ceb63f3748380c546a13531e86f0dda 


Diff: https://reviews.apache.org/r/66462/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66461/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Added an evolve function for `v1::scheduler::Response`.


Diffs
-

  src/internal/evolve.hpp e00ac7175438f758b10c0aa9485fc29ffa4efa29 
  src/internal/evolve.cpp f598ea11b64bdbface5bf1f124a02ea876196b67 


Diff: https://reviews.apache.org/r/66461/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 66460: Added a `call()` method to the v1 scheduler library.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66460/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

This patch adds a `call()` method to the scheduler library that allows
clients to send a `v1::scheduler::Call` to the master and receive a
`v1::scheduler::Response`.

It is going to be used to test operation state reconciliation.


Diffs
-

  include/mesos/v1/scheduler.hpp d56e08861d5190ef66992d383dc5710d8f6ce661 
  src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
60b17b9be74132c81532d22eba681feb899b22a3 
  src/scheduler/scheduler.cpp ecef916ffd0797a13552525ff2cda0f99ca57e74 


Diff: https://reviews.apache.org/r/66460/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 66459: Fixed bug in `Master::updateSlave()`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66459/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

A part of `Master::updateSlave()` doesn't account for operations created
via the operator API; this patch fixes that.


Diffs
-

  src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 


Diff: https://reviews.apache.org/r/66459/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 66458: Fixed handling of operations in `master::recoverFramework()`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66458/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

`Master::recoverFramework()` only recovers operations affecting agent
default resources. This patch makes it also recover operations affecting
resources managed by resource providers.

It also fixes a bug in which not just the corresponding operations, but
all the ones affecting agent default resources will be added to the
framework.


Diffs
-

  src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 


Diff: https://reviews.apache.org/r/66458/diff/1/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 66412: Fixed flaky agent test.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200529
---



Patch looks great!

Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66322, 66144, 
66346, 66145, 66178, 66323, 66347, 66412]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2018, 12:23 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> ---
> 
> (Updated April 4, 2018, 12:23 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down. Added `AWAIT` calls in other
> tests that use dispatch calls to guard against potential
> similar issues.
> 
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66412/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66457: Made resource provider API aware of workloads.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66457/#review200528
---



FAIL: Failed to apply the dependent review: 66398.

Failed command: `python.exe .\support\apply-reviews.py -n -r 66398`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66457

Relevant logs:

- 
[apply-review-66398-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66457/logs/apply-review-66398-stdout.log):

```
error: missing binary patch data for '3rdparty/csi-0.2.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.2.0.tar.gz'
error: 3rdparty/csi-0.2.0.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On April 4, 2018, 4:22 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66457/
> ---
> 
> (Updated April 4, 2018, 4:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8760
> https://issues.apache.org/jira/browse/MESOS-8760
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch introduces a breaking change to change `PublishResources` to
> `ApplyResourceUsage`, so the resource provider is aware of workloads.
> For local resource providers, a workload is a container, and this call
> is responsible to prepare the resources for each container. For external
> resource providers, a workload is a framework, so this call can bookkeep
> the resource usage for each framework and inform the allocator after a
> failover.
> 
> Note that this call is designed to report ALL resources used by every
> workload on an agent, so it can handle resources without identifiers.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> db7c751bb61fb1ee2421015dcbefc021c3afbdac 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 42bc050ed01a272603a41ab052ed75d799dd76e2 
> 
> 
> Diff: https://reviews.apache.org/r/66457/diff/1/
> 
> 
> Testing
> ---
> 
> This patch cannot be compiled standalone. Tests will be done later in the 
> chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66323: Added tests for failed task launch on agent.

[Greg Mann]

> On April 4, 2018, 12:17 a.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5251-5252 (patched)
> > 
> >
> > Is this needed?
> 
> Meng Zhu wrote:
> To avoid uninteresting mock calls.

The real question here is WHY does this method get called on the scheduler? The 
`failure()` method is invoked whenever an `Event::FAILURE` is received by the 
test v1 scheduler. I didn't realize it, but it turns out we evolve the 
`ExitedExecutorMessage` into an `Event::FAILURE` for v1 schedulers: 
https://github.com/apache/mesos/blob/594ee20c2453dad836313769aef9f8655cd75cd5/src/internal/evolve.cpp#L294-L305

So the exiting executor in this test explains why that method is invoked. 
However, I don't understand why it would be invoked twice, since we only have 
one executor here? I wonder if we're executing some cleanup logic for the 
failed task twice? It's also possible that the event is sent when the agent is 
removed at the end of the test, but I don't recall running into this in other 
tests.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200398
---


On April 4, 2018, 3:32 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> ---
> 
> (Updated April 4, 2018, 3:32 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests verify the agent behavior of launching
> several task groups using the same executor. When
> task groups are launching on the agent (before creating
> any executor), if the first received task group
> fails to launch, later task groups will get dropped.
> If a later received task group fails to launch, the first
> received task group should still launch successfully.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66323/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 66457: Made resource provider API aware of workloads.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66457/
---

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Bugs: MESOS-8760
https://issues.apache.org/jira/browse/MESOS-8760


Repository: mesos


Description
---

This patch introduces a breaking change to change `PublishResources` to
`ApplyResourceUsage`, so the resource provider is aware of workloads.
For local resource providers, a workload is a container, and this call
is responsible to prepare the resources for each container. For external
resource providers, a workload is a framework, so this call can bookkeep
the resource usage for each framework and inform the allocator after a
failover.

Note that this call is designed to report ALL resources used by every
workload on an agent, so it can handle resources without identifiers.


Diffs
-

  include/mesos/resource_provider/resource_provider.proto 
db7c751bb61fb1ee2421015dcbefc021c3afbdac 
  include/mesos/v1/resource_provider/resource_provider.proto 
42bc050ed01a272603a41ab052ed75d799dd76e2 


Diff: https://reviews.apache.org/r/66457/diff/1/


Testing
---

This patch cannot be compiled standalone. Tests will be done later in the chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review200526
---


Ship it!




Ship It!

- Greg Mann


On April 4, 2018, 3:24 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> ---
> 
> (Updated April 4, 2018, 3:24 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
> 
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 
>   src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66178/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66145/#review200525
---


Ship it!




Ship It!

- Greg Mann


On April 3, 2018, 10:08 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66145/
> ---
> 
> (Updated April 3, 2018, 10:08 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
> 
> This test simulates the reordering of the completions
> of unschedule GC step and verify that, despite the
> reordering, tasks can still launch in their original order.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66145/diff/8/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66455/#review200524
---


Ship it!





3rdparty/stout/include/stout/os/windows/ftruncate.hpp
Lines 36 (patched)


I left this comment on a different review, which this was then extracted 
on: "I'm fine with a truncate function not writing null bytes to the part of a 
file that was truncated. Truncate should be a fast operation, in my opinion :)"


- John Kordich


On April 4, 2018, 7:16 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66455/
> ---
> 
> (Updated April 4, 2018, 7:16 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8692
> https://issues.apache.org/jira/browse/MESOS-8692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This previously used the CRT API `_chsize_s()`, which required a CRT
> integer file descriptor. Instead, we can achieve the same behavior by
> first using `os::lseek()` (which uses `SetFilePointerEx()`) to seek
> `length`, and then use `SetEndOfFile()` to truncate. The only
> difference is that the file is not filled with null bytes when
> expanded, but we do not seem to rely on this behavior.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/ftruncate.hpp 
> fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 
> 
> 
> Diff: https://reviews.apache.org/r/66455/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66439/#review200523
---




3rdparty/stout/include/stout/protobuf.hpp
Line 83 (original), 87 (patched)


This comment is kind of confusing. Maybe describe the scenario first, then 
describe what you've implemented to resolve the scenario?

Maybe something like: "Users of 'protobuf::write' will call 'os::close' on 
the original 'HANDLE'. This is a problem because..."


- John Kordich


On April 4, 2018, 5:56 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66439/
> ---
> 
> (Updated April 4, 2018, 5:56 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is another edge case where a third-party library (protobuf)
> requires a CRT integer file descriptor. Thus we duplicate the `int_fd`
> and then explicitly allocate via `crt()`, which requires that we also
> manually close it via `_close()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/protobuf.hpp 
> 2fa5072e3c62c487da0dccffdd38d2fa1a615dc0 
> 
> 
> Diff: https://reviews.apache.org/r/66439/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66435/#review200518
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:52 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66435/
> ---
> 
> (Updated April 4, 2018, 5:52 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These should be refactored to share the common code, and the
> additional overloads added to the other APIs too. However, it is not
> currently necessary, and would go unused.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/stat.hpp 
> 58353742b39bac4fbfcb2ab7708f0f8719ea5b3b 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 
> c04953ee42f45dd80b6362fbeeddf4a0a20e7412 
> 
> 
> Diff: https://reviews.apache.org/r/66435/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66434/#review200517
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 7:18 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66434/
> ---
> 
> (Updated April 4, 2018, 7:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, `os::open()` used the CRT function `_wopen()`, and so this
> file was written to use the `CreateFile()` API directly. Now that
> `os::open()` uses the Windows API, all this duplicate code can be
> deleted in favor of using the `os::open()` and
> `internal::windows::set_inherit()`. The major benefit here is that the
> logic now almost exactly matches the POSIX counterpart in
> `subprocess_posix.cpp`, to the point that we may want to recombine
> these files in the future.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess_windows.cpp 
> 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a 
> 
> 
> Diff: https://reviews.apache.org/r/66434/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

[Andrew Schwartzmeyer]

> On April 4, 2018, 3:28 p.m., John Kordich wrote:
> > 3rdparty/stout/include/stout/os/windows/ftruncate.hpp
> > Lines 36 (patched)
> > 
> >
> > I'm fine with a truncate function not writing null bytes to the part of 
> > a file that was truncated. Truncate should be a fast operation, in my 
> > opinion :)

That shouldn't be in this review any more...


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66431/#review200513
---


On April 4, 2018, 12:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66431/
> ---
> 
> (Updated April 4, 2018, 12:13 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8676
> https://issues.apache.org/jira/browse/MESOS-8676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This can eventually support overlapped I/O.
> 
> The Windows API `ReadFile()` returns an error if the pipe is broken,
> where `_read()` did not, but this is not an error for us as the data
> is still read correctly. So we ignore it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> 8047ad590fcc46d3ec46b551472d8c518ae49cc1 
> 
> 
> Diff: https://reviews.apache.org/r/66431/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66433/#review200515
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 7:18 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66433/
> ---
> 
> (Updated April 4, 2018, 7:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is an edge case where a third-party library (libcurl) requires a
> CRT integer file descriptor. Thus we explicitly allocate one via
> `crt()`, which requires that we also manually close it via `_close()`,
> not `os::close()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/net.hpp 
> d2992c05b221ea90dae1c06d27753932f7411925 
> 
> 
> Diff: https://reviews.apache.org/r/66433/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66432/#review200514
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:50 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66432/
> ---
> 
> (Updated April 4, 2018, 5:50 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8676
> https://issues.apache.org/jira/browse/MESOS-8676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This can eventually support overlapped I/O.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/write.hpp 
> 71006489918d9495d37d2fdfdca08b40b419481a 
> 
> 
> Diff: https://reviews.apache.org/r/66432/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66431/#review200513
---


Ship it!





3rdparty/stout/include/stout/os/windows/ftruncate.hpp
Lines 36 (patched)


I'm fine with a truncate function not writing null bytes to the part of a 
file that was truncated. Truncate should be a fast operation, in my opinion :)


- John Kordich


On April 4, 2018, 7:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66431/
> ---
> 
> (Updated April 4, 2018, 7:13 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8676
> https://issues.apache.org/jira/browse/MESOS-8676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This can eventually support overlapped I/O.
> 
> The Windows API `ReadFile()` returns an error if the pipe is broken,
> where `_read()` did not, but this is not an error for us as the data
> is still read correctly. So we ignore it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> 8047ad590fcc46d3ec46b551472d8c518ae49cc1 
> 
> 
> Diff: https://reviews.apache.org/r/66431/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

[Andrew Schwartzmeyer]

> On April 4, 2018, 3:21 p.m., John Kordich wrote:
> > 3rdparty/stout/include/stout/os/windows/lseek.hpp
> > Lines 36 (patched)
> > 
> >
> > That sounds like it would be user error here if this ever happens!

I agree, and we don't mutex anywhere else either.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66428/#review200508
---


On April 3, 2018, 10:49 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66428/
> ---
> 
> (Updated April 3, 2018, 10:49 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8685
> https://issues.apache.org/jira/browse/MESOS-8685
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note the TODO, we may want to synchronize this code later.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/lseek.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66428/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

[Andrew Schwartzmeyer]

> On April 4, 2018, 3:12 p.m., John Kordich wrote:
> > 3rdparty/stout/include/stout/os/windows/jobobject.hpp
> > Lines 139 (patched)
> > 
> >
> > This is interesting. I understand how you're using this template 
> > function to allocate this structure on the stack which you use a 
> > reinterpret_cast on later as a substitute for the 
> > JOBOBJECT_BASIC_PROCESS_ID_LIST.
> > 
> > But is this really worth doing?  Allocation and deallocation would 
> > happen entirely within this function. I imagine the data we need will be 
> > copied out before deallocation during the insert calls below on the 
> > set object, so the only real issue is the extra time associated 
> > with dynamic memory allocation/deallocation.
> > 
> > What's hairy about the size calculations? I imagine it's not that bad, 
> > probably nothing you wouldn't do normally in C :)
> > 
> > If you do end up staying with this structure, is there a reason the 
> > ProcessIdList member is a DWORD and not a ULONG_PTR, as per 
> > https://msdn.microsoft.com/en-us/library/windows/desktop/ms684150(v=vs.85).aspx
> >  ?
> > 
> > It's probably the case that on x86_64 that they are the same size, but 
> > why not mirror the structure identically?

> probably nothing you wouldn't do normally in C

Precisely. This isn't C, so why manually allocate and calculate and deallocate 
when we don't need to? It's too easy to screw up.

> is there a reason the ProcessIdList member is a DWORD and not a ULONG_PTR

Yes. The type of the identifer in the Windows struct (because it's the pointer 
to the beginning of an "array") is `ULONG_PTR`, but it is not actually an 
array. The arary itself (which you would have to allocate in the correct 
location for this struct) is an array of `DWORD` (since it's an array of PIDs); 
so when we declare an actual array of PIDs, we declare a `DWORD array[n]`.

The C struct in the Windows API ends with a `ULONG_PTR` because the actual 
defined struct does not contain an array. It instead expects you to allocate a 
contiguous block large enough to hold the struct and the array, and then the 
type in the struct is just the array pointer of type `ULONG_PTR`.

And this is why we do it this why, and not Windows's way. It's too easy to get 
wrong.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66420/#review200502
---


On April 3, 2018, 10:46 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66420/
> ---
> 
> (Updated April 3, 2018, 10:46 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The functions written to deal with job objects on Windows had become
> large enough to warrant being refactored into their own file. Also
> was the perfect opportunity to fix formatting issues.
> 
> When including `jobobject.hpp` for `killtree.hpp`, other unnecessary
> headers were removed.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 742bfc44d68d978dd2249ece500d6f64e4d7f02a 
>   3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/killtree.hpp 
> ce8bdcd18305ffb758f22a6c2bbc7393675aebdf 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 739ee4da3f09d2a9597d4451e755e77903e9287d 
> 
> 
> Diff: https://reviews.apache.org/r/66420/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66430/#review200511
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:50 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66430/
> ---
> 
> (Updated April 4, 2018, 5:50 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8684
> https://issues.apache.org/jira/browse/MESOS-8684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that for now we need to keep the original CRT code, as it can't
> be removed until `FD_CRT` is removed too.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/dup.hpp 
> 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 
> 
> 
> Diff: https://reviews.apache.org/r/66430/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66429/#review200509
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 7:17 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66429/
> ---
> 
> (Updated April 4, 2018, 7:17 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The deleted code was purely self-referential.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess_windows.cpp 
> 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a 
> 
> 
> Diff: https://reviews.apache.org/r/66429/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66428/#review200508
---


Ship it!





3rdparty/stout/include/stout/os/windows/lseek.hpp
Lines 36 (patched)


That sounds like it would be user error here if this ever happens!


- John Kordich


On April 4, 2018, 5:49 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66428/
> ---
> 
> (Updated April 4, 2018, 5:49 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8685
> https://issues.apache.org/jira/browse/MESOS-8685
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note the TODO, we may want to synchronize this code later.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/lseek.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66428/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66427/#review200507
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:48 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66427/
> ---
> 
> (Updated April 4, 2018, 5:48 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8685
> https://issues.apache.org/jira/browse/MESOS-8685
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Split `stout/os/lseek.hpp` into Windows and POSIX files.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 742bfc44d68d978dd2249ece500d6f64e4d7f02a 
>   3rdparty/stout/include/stout/os/lseek.hpp 
> 77fe272afc89f41836c2540de42135dc364917ce 
>   3rdparty/stout/include/stout/os/posix/lseek.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/lseek.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66427/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66425/#review200506
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66425/
> ---
> 
> (Updated April 4, 2018, 5:47 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The latter should be used everywhere but in the implementation for
> consistency with the POSIX side of the code.
> 
> Also meant fixing the included header (and spacing).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/inherit.hpp 
> 6da6f8eb1382d226c8b16a8e4cbb454205ef4045 
>   3rdparty/stout/include/stout/os/windows/close.hpp 
> ff635e44235d63888a210cd68d49f6678a851e31 
>   3rdparty/stout/include/stout/os/windows/dup.hpp 
> 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 
>   3rdparty/stout/include/stout/os/windows/fsync.hpp 
> 8405247280b51e74a172317816096ca77fdfd1e7 
>   3rdparty/stout/include/stout/os/windows/ftruncate.hpp 
> fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 
>   3rdparty/stout/include/stout/os/windows/pipe.hpp 
> 365db9480f6258a03ef2e760a19abef8ab177e58 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> 8047ad590fcc46d3ec46b551472d8c518ae49cc1 
>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> fff5872db6b3f69464e41e6d108a107e4eeabd12 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> aacd746922495f994891aa85d3e4fa95e2bd1c44 
>   3rdparty/stout/include/stout/os/windows/socket.hpp 
> 259b05b8c85e399feaccec698d58b7d540cad368 
>   3rdparty/stout/include/stout/os/windows/write.hpp 
> 71006489918d9495d37d2fdfdca08b40b419481a 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 739ee4da3f09d2a9597d4451e755e77903e9287d 
> 
> 
> Diff: https://reviews.apache.org/r/66425/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66424/#review200505
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66424/
> ---
> 
> (Updated April 4, 2018, 5:47 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8673
> https://issues.apache.org/jira/browse/MESOS-8673
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of using the CRT implementation of `_wopen()` for the
> `os::open()` API, we now use the Windows API `CreateFileW()`, mapping
> each of the Linux `open()` flags to their semantic equivalents. This
> will make implementing overlapped I/O possible, and is a step toward
> removing the use of integer file descriptors on Windows.
> 
> Note that instead of redefining the C flags like `O_RDONLY`, we just
> use them directly in our mapping logic, and set the used but
> unsupported flags to zero.
> 
> This change uncovered several bugs such as incorrect access flags, and
> used-but-not-included headers.
> 
> We currently ignore creation permissions as they will be handled in a
> broader project to map permissions to Windows correctly.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/net.hpp 
> d2992c05b221ea90dae1c06d27753932f7411925 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 
>   3rdparty/stout/include/stout/os/windows/mktemp.hpp 
> 5c775c45c415d9ddd6a80ab814fb55475e9f871e 
>   3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/windows.hpp 
> 1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993 
> 
> 
> Diff: https://reviews.apache.org/r/66424/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66423/#review200504
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66423/
> ---
> 
> (Updated April 4, 2018, 5:47 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8673
> https://issues.apache.org/jira/browse/MESOS-8673
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logic remained the same, just with the Windows code removed from
> the POSIX code, and vice versa.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 742bfc44d68d978dd2249ece500d6f64e4d7f02a 
>   3rdparty/stout/include/stout/os/open.hpp 
> 4dc5b087abf40ac9b81f0fd611aca192e5d33ce7 
>   3rdparty/stout/include/stout/os/posix/open.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66423/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66420/#review200503
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:46 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66420/
> ---
> 
> (Updated April 4, 2018, 5:46 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The functions written to deal with job objects on Windows had become
> large enough to warrant being refactored into their own file. Also
> was the perfect opportunity to fix formatting issues.
> 
> When including `jobobject.hpp` for `killtree.hpp`, other unnecessary
> headers were removed.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 742bfc44d68d978dd2249ece500d6f64e4d7f02a 
>   3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/killtree.hpp 
> ce8bdcd18305ffb758f22a6c2bbc7393675aebdf 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 739ee4da3f09d2a9597d4451e755e77903e9287d 
> 
> 
> Diff: https://reviews.apache.org/r/66420/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66420/#review200502
---


Fix it, then Ship it!




Oops. I just realized as I was getting through this code review that it was 
just a code move into jobobject.hpp.  You can read my comment if you'd like. 
But I was going to sign off anyway :)


3rdparty/stout/include/stout/os/windows/jobobject.hpp
Lines 139 (patched)


This is interesting. I understand how you're using this template function 
to allocate this structure on the stack which you use a reinterpret_cast on 
later as a substitute for the JOBOBJECT_BASIC_PROCESS_ID_LIST.

But is this really worth doing?  Allocation and deallocation would happen 
entirely within this function. I imagine the data we need will be copied out 
before deallocation during the insert calls below on the set object, 
so the only real issue is the extra time associated with dynamic memory 
allocation/deallocation.

What's hairy about the size calculations? I imagine it's not that bad, 
probably nothing you wouldn't do normally in C :)

If you do end up staying with this structure, is there a reason the 
ProcessIdList member is a DWORD and not a ULONG_PTR, as per 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms684150(v=vs.85).aspx 
?

It's probably the case that on x86_64 that they are the same size, but why 
not mirror the structure identically?


- John Kordich


On April 4, 2018, 5:46 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66420/
> ---
> 
> (Updated April 4, 2018, 5:46 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The functions written to deal with job objects on Windows had become
> large enough to warrant being refactored into their own file. Also
> was the perfect opportunity to fix formatting issues.
> 
> When including `jobobject.hpp` for `killtree.hpp`, other unnecessary
> headers were removed.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 742bfc44d68d978dd2249ece500d6f64e4d7f02a 
>   3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/killtree.hpp 
> ce8bdcd18305ffb758f22a6c2bbc7393675aebdf 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 739ee4da3f09d2a9597d4451e755e77903e9287d 
> 
> 
> Diff: https://reviews.apache.org/r/66420/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66437/#review200500
---




3rdparty/stout/include/stout/os/windows/close.hpp
Lines 38 (patched)


Note that this will cause an SEH exception for `FsTest.Close` when run 
under a debugger, because it purposefully closes a handle twice. Not sure what 
we can do about that other than delete that part of the test.



3rdparty/stout/include/stout/os/windows/fd.hpp
Line 52 (original), 54 (patched)


This part of the `enum` I don't think is necessary. It made sense for 
default construction, but we can probably get away without it.



3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 120-132 (patched)


I am not a fan of this, as it can cause ambigous types to crop up. Working 
on writing comparison operators that will work without this `operator. int()`


- Andrew Schwartzmeyer


On April 3, 2018, 10:55 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66437/
> ---
> 
> (Updated April 3, 2018, 10:55 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675 and MESOS-8683
> https://issues.apache.org/jira/browse/MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After all the CRT APIs were replaced with Windows APIs, we no longer
> need to support the semantics of an `int` file descriptor in
> general (in the sense of opening a CRT handle that's associated with
> the actual kernel object for the given `HANDLE`). There are specific
> use cases (usually third-party code) which still require a CRT
> int-like file descriptor, which the `crt()` function explicitly
> allocates (this allocation used to be done in the constructor).
> 
> Thus the entire `FD_CRT` type was removed from the `WindowsFD`
> abstraction. It still acts like an `int` in the sense that it can be
> constructed from one and compared to one. However, construction via
> `int` only supports the standard file descriptors 0, 1, and 2 for
> `stdin`, `stdout`, and `stderr`. Any other construction creates an
> `int_fd` which holds an `INVALID_HANDLE` value. When being compared to
> an `int`, the abstraction simply returns -1 if it is invalid (based on
> the result of the `is_valid()` method) or 0 if it is valid. This is to
> support the semantics of checking validity by something like
> `if (fd < 0)` or `if (fd == -1)`.
> 
> With the deletion of the `FD_CRT` type from `WindowsFD`, all the Stout
> APIs that switched on the type were simplified, with the last of the
> CRT code deleted.
> 
> Note that a new enum type `INVALID` was added to support default
> construction semantics, and only exists for that reason. An actual
> "invalid" handle should be constructed via `int_fd fd = -1` (or
> `int_fd fd = INVALID_HANDLE_VALUE` when being explicit on Windows).
> 
> Because `int_fd` is now castable to an `int`, and the `FD_CRT` type
> was removed, the comparison operators became much simpler.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/close.hpp 
> ff635e44235d63888a210cd68d49f6678a851e31 
>   3rdparty/stout/include/stout/os/windows/dup.hpp 
> 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> d7f8cdf1ad877eb55589bf5a9e75d295f91990a7 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> 8047ad590fcc46d3ec46b551472d8c518ae49cc1 
>   3rdparty/stout/include/stout/os/windows/write.hpp 
> 71006489918d9495d37d2fdfdca08b40b419481a 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> c190baa2230298e428d4034b90dccffb59b4e710 
> 
> 
> Diff: https://reviews.apache.org/r/66437/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66412: Fixed flaky agent test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200501
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', 
'66322', '66144', '66346', '66145', '66178', '66323', '66347', '66412']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (114 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1064 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (75 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (828 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (855 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (835 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (863 ms total)

[--] Global test environment tear-down
[==] 954 tests from 94 test cases ran. (460261 ms total)
[  PASSED  ] 953 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stderr.log):

```
I0404 21:45:02.832861  3888 slave.cpp:3973] Shutting down framework 
99588c03-1f27-4200-bd45-625c406a3e02-
I0404 21:45:02.831858 14660 master.cpp:10449] Updating the sI0404 
21:45:02.638871  6128 exec.cpp:162] Version: 1.6.0
I0404 21:45:02.667873  4216 exec.cpp:236] Executor registered on agent 
99588c03-1f27-4200-bd45-625c406a3e02-S0
I0404 21:45:02.671876  8072 executor.cpp:176] Received SUBSCRIBED event
I0404 21:45:02.676874  8072 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 21:45:02.677875  8072 executor.cpp:176] Received LAUNCH event
I0404 21:45:02.682873  8072 executor.cpp:648] Starting task 
a295962d-4f4e-4599-bd8a-33f77efa1514
I0404 21:45:02.774873  8072 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 21:45:02.804880  8072 executor.cpp:661] Forked command at 7240
I0404 21:45:02.834880  5960 exec.cpp:445] Executor asked to shutdown
I0404 21:45:02.834880 11880 executor.cpp:176] Received SHUTDOWN event
I0404 21:45:02.834880 11880 executor.cpp:758] Shutting down
I0404 21:45:02.834880 11880 executor.cpp:868] Sending SIGTERM to process tree 
at pid 7tate of task a295962d-4f4e-4599-bd8a-33f77efa1514 of framework 
99588c03-1f27-4200-bd45-625c406a3e02- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0404 21:45:02.832861  3888 slave.cpp:6670] Shutting down executor 
'a295962d-4f4e-4599-bd8a-33f77efa1514' of framework 
99588c03-1f27-4200-bd45-625c406a3e02- at executor(1)@10.3.1.8:55204
I0404 21:45:02.833878  3888 slave.cpp:923] Agent terminating
W0404 21:45:02.833878  3888 slave.cpp:3969] Ignoring shutdown framework 
99588c03-1f27-4200-bd45-625c406a3e02- because it is terminating
I0404 21:45:02.835871 14660 master.cpp:10548] Removing task 
a295962d-4f4e-4599-bd8a-33f77efa1514 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 99588c03-1f27-4200-bd45-625c406a3e02- on 
agent 99588c03-1f27-4200-bd45-625c406a3e02-S0 at slave(423)@10.3.1.8:55183 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 21:45:02.837882  6484 containerizer.cpp:2338] Destroying container 
52fc0a76-d8b3-4846-9ee9-8c22958172b6 in RUNNING state
I0404 21:45:02.837882 14660 master.cpp:1295] Agent 
99588c03-1f27-4200-bd45-625c406a3e02-S0 at slave(423)@10.3.1.8:55183 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 21:45:02.837882 14660 master.cpp:3286] Disconnecting agent 
99588c03-1f27-4200-bd45-625c406a3e02-S0 at slave(423)@10.3.1.8:55183 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 

Re: Review Request 66441: Fixed mismatched types in `process.cpp`.

[Andrew Schwartzmeyer]

> On April 4, 2018, 2:21 p.m., John Kordich wrote:
> > Ship It!

Actually, I think I can delete with a pending update to `WindowsFD`.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66441/#review200494
---


On April 3, 2018, 10:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66441/
> ---
> 
> (Updated April 3, 2018, 10:57 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Because of the ternary, the primitive integer `-1` must be explicitly
> constructed into an `int_fd` to match the type held in the `sockets`
> container.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd 
> 
> 
> Diff: https://reviews.apache.org/r/66441/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66445/#review200498
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 7:26 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66445/
> ---
> 
> (Updated April 4, 2018, 7:26 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8759
> https://issues.apache.org/jira/browse/MESOS-8759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The set `errno` value in `os::kill()` is never checked (especially on
> Windows), so `_set_errno()` and thus `errno.h` were removed.
> 
> The `fcntl.h` is used only to provide `O_CREAT` etc., and so belonged
> in `open.hpp`, not `windows.hpp`.
> 
> The remaining headers, `direct.h`, `io.h`, `process.h`, and `stdlib.h`
> were no longer used or needed as the respective CRT APIs were
> replaced.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/kill.hpp 
> 9cec1117fac3cf6bd624fc7db524ef1ad10cd55d 
>   3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> 9181429383a991fe2b87701d2bfd0e858ac2537b 
>   3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> a2926dab2c8e219cf5938c4df27f83488198dd6b 
>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> fff5872db6b3f69464e41e6d108a107e4eeabd12 
>   3rdparty/stout/include/stout/windows.hpp 
> 1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993 
>   3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 
> 5b3cbf4f36ea9ac0411df52b4cfea8ef75fecbb5 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 739ee4da3f09d2a9597d4451e755e77903e9287d 
> 
> 
> Diff: https://reviews.apache.org/r/66445/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66443/#review200496
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:58 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66443/
> ---
> 
> (Updated April 4, 2018, 5:58 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This needed to use the Stout API so that the correct Windows
> implementation is used, as `::chdir` is part of the CRT.
> 
> Also included used but not included `stout/os/*` headers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 898326360d6b4f0a50d6ef3f7c86141d0aa70438 
> 
> 
> Diff: https://reviews.apache.org/r/66443/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66442/#review200495
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:57 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66442/
> ---
> 
> (Updated April 4, 2018, 5:57 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed `os::abort()` to use `WriteFile()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/abort.hpp 
> 4fd233dfcd4359791dd176820f3a6040947bb291 
> 
> 
> Diff: https://reviews.apache.org/r/66442/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66444/#review200497
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:58 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66444/
> ---
> 
> (Updated April 4, 2018, 5:58 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This file had never been included before, so it didn't compile. It
> needed to include `unimplemented.hpp`, and because `Suppressor` isn't
> implemented, the initializers had to be deleted.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/signals.hpp 
> 0ed24771625e58c1de8b1aa96b70f5aae1638bd4 
> 
> 
> Diff: https://reviews.apache.org/r/66444/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66441: Fixed mismatched types in `process.cpp`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66441/#review200494
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:57 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66441/
> ---
> 
> (Updated April 4, 2018, 5:57 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Because of the ternary, the primitive integer `-1` must be explicitly
> constructed into an `int_fd` to match the type held in the `sockets`
> container.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd 
> 
> 
> Diff: https://reviews.apache.org/r/66441/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review200493
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:57 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> ---
> 
> (Updated April 4, 2018, 5:57 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http_proxy.cpp 
> 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66438/#review200492
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 7:19 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66438/
> ---
> 
> (Updated April 4, 2018, 7:19 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is an edge case where a third-party library (libevent) requires a
> CRT integer file descriptor. Thus we duplicate the `int_fd` and then
> explicitly allocate via `crt()`, which requires that we also manually
> close it via `_close()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 4de161dbf9198e9c74b1e80838b8a5d52006a562 
> 
> 
> Diff: https://reviews.apache.org/r/66438/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66436/#review200490
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:54 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66436/
> ---
> 
> (Updated April 4, 2018, 5:54 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The functions `os::stat::size()` and `os::stat::isdir()` are now
> overloaded for an `int_fd` type, using `fstat()` on POSIX, and the
> equivalent functions with a `HANDLE` on Windows. This allowed us to
> remove the use of `::fstat()`, which was not abstracted, and not
> supported on Windows without the use of a CRT integer file descriptor.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp 63dd2c1f629ac316d0b31f8a854e482ae6eda634 
>   3rdparty/libprocess/src/http_proxy.cpp 
> 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66436/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66426: Windows: More constness in stout.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66426/#review200489
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:48 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66426/
> ---
> 
> (Updated April 4, 2018, 5:48 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also small fixes such as `reserve` over an allocation, and a bad name
> `si` instead of `info`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/getcwd.hpp 
> f316d618226872b57d950b468352176a7a0cb45a 
>   3rdparty/stout/include/stout/os/windows/getenv.hpp 
> 58012e03aca5dfa2f65fc183b21533dd0ed91d8d 
>   3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/killtree.hpp 
> ce8bdcd18305ffb758f22a6c2bbc7393675aebdf 
>   3rdparty/stout/include/stout/os/windows/mkdir.hpp 
> 8d8d80bee77253086939c28333b0413bd8b8b8b6 
>   3rdparty/stout/include/stout/os/windows/pagesize.hpp 
> ddf23c1c5d15c1dd7de37e98673b70836a0e2c5c 
>   3rdparty/stout/include/stout/os/windows/realpath.hpp 
> c6bad5063c8d8255b29a3a6cb9ea51e13c42275c 
>   3rdparty/stout/include/stout/os/windows/su.hpp 
> 1bfbb261edbd25b4552742fc0597e331012cad98 
>   3rdparty/stout/include/stout/os/windows/temp.hpp 
> 9cf467fd9358cc4de702e0501263abcd28a0fa8c 
> 
> 
> Diff: https://reviews.apache.org/r/66426/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66421/#review200487
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66421/
> ---
> 
> (Updated April 4, 2018, 5:47 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The job object functions were refactored upstream from
> `windows/os.hpp` to `os/windows/jobobject.hpp`.
> 
> Also removed `windows/os.hpp` because `os.hpp` includes it for us.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/windows/jobobject.hpp 
> 0de374d374804c2d4f06a352d80062d3b42ed9b2 
> 
> 
> Diff: https://reviews.apache.org/r/66421/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

[Gilbert Song]

> On April 4, 2018, 11:23 a.m., Gilbert Song wrote:
> > src/tests/containerizer/linux_capabilities_isolator_tests.cpp
> > Lines 747 (patched)
> > 
> >
> > Should we call `slave.get()->terminate()` before `reset()`? See 
> > SlaveRecoveryTest.
> 
> Andrei Budnik wrote:
> I think it's not necessary since we call `terminate()` in `~Slave()`: 
> https://github.com/apache/mesos/blob/594ee20c2453dad836313769aef9f8655cd75cd5/src/tests/cluster.cpp#L630

gotcha.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66449/#review200472
---


On April 4, 2018, 5:17 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66449/
> ---
> 
> (Updated April 4, 2018, 5:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-8489
> https://issues.apache.org/jira/browse/MESOS-8489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Starting more than one agent simultaneously in tests leads to a race
> condition between a linux launcher which calls `cgroups::prepare()` for
> the first slave and `LinuxLauncherProcess::recover()` which iterates
> over cgroups hierarchy for the second slave. Therefore, `mesos/test`
> cgroup that is created to check if the kernel supports nested cgroups
> can be detected by a recovery process as they use same cgroup hierarchy
> path by default. That leads to orphan containers and causes flakiness
> of `ROOT_IsolatorFlags` test. To fix the issue, this patch adds
> termination of an agent before starting a new one.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> 147f2cc09307cf8c9cf6f71d0175f8a3593c0256 
> 
> 
> Diff: https://reviews.apache.org/r/66449/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

[Andrei Budnik]

> On April 4, 2018, 6:23 p.m., Gilbert Song wrote:
> > src/tests/containerizer/linux_capabilities_isolator_tests.cpp
> > Lines 747 (patched)
> > 
> >
> > Should we call `slave.get()->terminate()` before `reset()`? See 
> > SlaveRecoveryTest.

I think it's not necessary since we call `terminate()` in `~Slave()`: 
https://github.com/apache/mesos/blob/594ee20c2453dad836313769aef9f8655cd75cd5/src/tests/cluster.cpp#L630


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66449/#review200472
---


On April 4, 2018, 12:17 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66449/
> ---
> 
> (Updated April 4, 2018, 12:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-8489
> https://issues.apache.org/jira/browse/MESOS-8489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Starting more than one agent simultaneously in tests leads to a race
> condition between a linux launcher which calls `cgroups::prepare()` for
> the first slave and `LinuxLauncherProcess::recover()` which iterates
> over cgroups hierarchy for the second slave. Therefore, `mesos/test`
> cgroup that is created to check if the kernel supports nested cgroups
> can be detected by a recovery process as they use same cgroup hierarchy
> path by default. That leads to orphan containers and causes flakiness
> of `ROOT_IsolatorFlags` test. To fix the issue, this patch adds
> termination of an agent before starting a new one.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> 147f2cc09307cf8c9cf6f71d0175f8a3593c0256 
> 
> 
> Diff: https://reviews.apache.org/r/66449/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66412: Fixed flaky agent test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200477
---



FAIL: Failed to apply the dependent review: 66126.

Failed command: `python.exe .\support\apply-reviews.py -n -r 66126`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412

Relevant logs:

- 
[apply-review-66126-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/apply-review-66126-stdout.log):

```
error: patch failed: src/tests/slave_tests.cpp:4181
error: src/tests/slave_tests.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On April 4, 2018, 7:23 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> ---
> 
> (Updated April 4, 2018, 7:23 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down. Added `AWAIT` calls in other
> tests that use dispatch calls to guard against potential
> similar issues.
> 
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66412/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66454: Updated the documented release schedule.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66454/#review200476
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66454']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66454

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66454/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (113 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1062 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (41 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (79 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (823 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (850 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (841 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (869 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (443218 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66454/logs/mesos-tests-stderr.log):

```
I0404 19:59:17.749002 13628 executor.cpp:176] Received SUBSCRIBED event
I0404 19:59:17.755000 13628 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 19:59:17.756000 13628 executor.cpp:176] Received LAUNCH event
I0404 19:59:17.762661 13628 executor.cpp:648] Starting task 
32556b66-2924-4874-97e5-3c0108bf89b8
I0404 19:59:17.889008 13628 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 19:59:17.919005 13628 executor.cpp:661] Forked command at 11172
I0404 19:59:17.954010 14988 exec.cpp:445] Executor asked to shutdown
I0404 19:59:17.955009 11320 executor.cpp:176] Received SHUTDOWN event
I0404 19:59:17.955009 11320 executor.cpp:758] Shutting down
I0404 19:59:17.955009 11320 executor.cpp:868] Sending SIGTERM to process tree 
at pid  master.cpp:3249] Deactivating framework 
62403817-bf35-4b6f-8033-0629b81293a1- (default) at 
scheduler-a95fd462-e118-4329-8f00-feeda82a92c7@10.3.1.8:52669
I0404 19:59:17.951997 11796 hierarchical.cpp:405] Deactivated framework 
62403817-bf35-4b6f-8033-0629b81293a1-
I0404 19:59:17.953012 10448 slave.cpp:3877] Shutting down framework 
62403817-bf35-4b6f-8033-0629b81293a1-
I0404 19:59:17.953012 12136 master.cpp:10449] Updating the state of task 
32556b66-2924-4874-97e5-3c0108bf89b8 of framework 
62403817-bf35-4b6f-8033-0629b81293a1- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0404 19:59:17.953012 10448 slave.cpp:6574] Shutting down executor 
'32556b66-2924-4874-97e5-3c0108bf89b8' of framework 
62403817-bf35-4b6f-8033-0629b81293a1- at executor(1)@10.3.1.8:52690
I0404 19:59:17.954010 10448 slave.cpp:923] Agent terminating
W0404 19:59:17.954010 10448 slave.cpp:3873] Ignoring shutdown framework 
62403817-bf35-4b6f-8033-0629b81293a1- because it is terminating
I0404 19:59:17.956007 12136 master.cpp:10548] Removing task 
32556b66-2924-4874-97e5-3c0108bf89b8 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 62403817-bf35-4b6f-8033-0629b81293a1- on 
agent 62403817-bf35-4b6f-8033-0629b81293a1-S0 at slave(418)@10.3.1.8:52669 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 19:59:17.958003 10696 containerizer.cpp:2338] Destroying container 
2ba6103d-af3c-4fdb-b49a-7de61dea1fa2 in RUNNING state
I0404 19:59:17.958003 10696 containerizer.cpp:2952] Transitioning the state of 
container 2ba6103d-af3c-4fdb-b49a-7de61dea1fa2 from RUNNING to DESTROYING
I0404 19:59:17.959010 10696 launcher.cpp:156] Asked to destroy container 
2ba6103d-af3c-4fdb-b49a-7de61dea1fa2
I0404 19:59:17.959010 12136 master.cpp:1295] Agent 
62403817-bf35-4b6f-8033-0629b81293a1-S0 at slave(418)@10.3.1.8:52669 

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66445/
---

(Updated April 4, 2018, 12:26 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Added correct bug.


Bugs: MESOS-8759
https://issues.apache.org/jira/browse/MESOS-8759


Repository: mesos


Description
---

The set `errno` value in `os::kill()` is never checked (especially on
Windows), so `_set_errno()` and thus `errno.h` were removed.

The `fcntl.h` is used only to provide `O_CREAT` etc., and so belonged
in `open.hpp`, not `windows.hpp`.

The remaining headers, `direct.h`, `io.h`, `process.h`, and `stdlib.h`
were no longer used or needed as the respective CRT APIs were
replaced.


Diffs
-

  3rdparty/stout/include/stout/os/windows/kill.hpp 
9cec1117fac3cf6bd624fc7db524ef1ad10cd55d 
  3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
9181429383a991fe2b87701d2bfd0e858ac2537b 
  3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/rmdir.hpp 
a2926dab2c8e219cf5938c4df27f83488198dd6b 
  3rdparty/stout/include/stout/os/windows/sendfile.hpp 
fff5872db6b3f69464e41e6d108a107e4eeabd12 
  3rdparty/stout/include/stout/windows.hpp 
1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993 
  3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 
5b3cbf4f36ea9ac0411df52b4cfea8ef75fecbb5 
  3rdparty/stout/include/stout/windows/os.hpp 
739ee4da3f09d2a9597d4451e755e77903e9287d 


Diff: https://reviews.apache.org/r/66445/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66412: Fixed flaky agent test.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/
---

(Updated April 4, 2018, 12:23 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Added extra synchronouzation to guard against potential race conditions.


Repository: mesos


Description (updated)
---

In test `KillTaskGroupBetweenRunTaskParts`, added extra
synchronization to ensure `unmocked__run` finishes before
the test tear down. Added `AWAIT` calls in other
tests that use dispatch calls to guard against potential
similar issues.

Also updated all dispatch calls to capture by value to avoid
potential races where the arguments might be destroyed
while the dispatch call is still running.


Diffs (updated)
-

  src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 


Diff: https://reviews.apache.org/r/66412/diff/3/

Changes: https://reviews.apache.org/r/66412/diff/2-3/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65679/
---

(Updated April 4, 2018, 12:20 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
---

Updated the patch to capture by value and added extra synchronization to avoid 
potential race conditions.


Bugs: MESOS-8611
https://issues.apache.org/jira/browse/MESOS-8611


Repository: mesos


Description
---

Directly invoking unmock calls in the test process can potentially
cause races with the real mock slave process. It is more robust to
dispatch the unmock calls to the real mock slave process.

Also added several mock expectations to avoid "uninteresting mock
call" test warnings.


Diffs (updated)
-

  src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 


Diff: https://reviews.apache.org/r/65679/diff/9/

Changes: https://reviews.apache.org/r/65679/diff/8-9/


Testing
---

`./bin/mesos-tests.sh --gtest_filter=*SlaveTest* --gtest_repeat=-1 
--gtest_break_on_failure` runs forever :)


Thanks,

Meng Zhu

Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66438/
---

(Updated April 4, 2018, 12:19 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Changed ordering.


Bugs: MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
---

This is an edge case where a third-party library (libevent) requires a
CRT integer file descriptor. Thus we duplicate the `int_fd` and then
explicitly allocate via `crt()`, which requires that we also manually
close it via `_close()`.


Diffs
-

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
4de161dbf9198e9c74b1e80838b8a5d52006a562 


Diff: https://reviews.apache.org/r/66438/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66433/
---

(Updated April 4, 2018, 12:18 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Changed ordering.


Bugs: MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
---

This is an edge case where a third-party library (libcurl) requires a
CRT integer file descriptor. Thus we explicitly allocate one via
`crt()`, which requires that we also manually close it via `_close()`,
not `os::close()`.


Diffs
-

  3rdparty/stout/include/stout/net.hpp d2992c05b221ea90dae1c06d27753932f7411925 


Diff: https://reviews.apache.org/r/66433/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66434/
---

(Updated April 4, 2018, 12:18 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Changed ordering.


Bugs: MESOS-8682
https://issues.apache.org/jira/browse/MESOS-8682


Repository: mesos


Description
---

Previously, `os::open()` used the CRT function `_wopen()`, and so this
file was written to use the `CreateFile()` API directly. Now that
`os::open()` uses the Windows API, all this duplicate code can be
deleted in favor of using the `os::open()` and
`internal::windows::set_inherit()`. The major benefit here is that the
logic now almost exactly matches the POSIX counterpart in
`subprocess_posix.cpp`, to the point that we may want to recombine
these files in the future.


Diffs
-

  3rdparty/libprocess/src/subprocess_windows.cpp 
1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a 


Diff: https://reviews.apache.org/r/66434/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66429/
---

(Updated April 4, 2018, 12:17 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Changed ordering.


Bugs: MESOS-8682
https://issues.apache.org/jira/browse/MESOS-8682


Repository: mesos


Description
---

The deleted code was purely self-referential.


Diffs
-

  3rdparty/libprocess/src/subprocess_windows.cpp 
1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a 


Diff: https://reviews.apache.org/r/66429/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66455/
---

Review request for mesos.


Bugs: MESOS-8692
https://issues.apache.org/jira/browse/MESOS-8692


Repository: mesos


Description
---

This previously used the CRT API `_chsize_s()`, which required a CRT
integer file descriptor. Instead, we can achieve the same behavior by
first using `os::lseek()` (which uses `SetFilePointerEx()`) to seek
`length`, and then use `SetEndOfFile()` to truncate. The only
difference is that the file is not filled with null bytes when
expanded, but we do not seem to rely on this behavior.


Diffs
-

  3rdparty/stout/include/stout/os/windows/ftruncate.hpp 
fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 


Diff: https://reviews.apache.org/r/66455/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66431/
---

(Updated April 4, 2018, 12:13 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Split out ftruncate changes.


Bugs: MESOS-8676
https://issues.apache.org/jira/browse/MESOS-8676


Repository: mesos


Description
---

This can eventually support overlapped I/O.

The Windows API `ReadFile()` returns an error if the pipe is broken,
where `_read()` did not, but this is not an error for us as the data
is still read correctly. So we ignore it.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/read.hpp 
8047ad590fcc46d3ec46b551472d8c518ae49cc1 


Diff: https://reviews.apache.org/r/66431/diff/2/

Changes: https://reviews.apache.org/r/66431/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review200474
---



PASS: Mesos patch 66173 was successfully built and tested.

Reviews applied: `['66001', '66173']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173

- Mesos Reviewbot Windows


On April 4, 2018, 5:41 p.m., Harold Dost wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> ---
> 
> (Updated April 4, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-6575
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 
> 
> 
> Diff: https://reviews.apache.org/r/66173/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harold Dost
> 
>

Re: Review Request 66451: Added devolve function for 'ResourceProviderInfo'.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66451/#review200473
---



Patch looks great!

Reviews applied: [66451]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2018, 12:35 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66451/
> ---
> 
> (Updated April 4, 2018, 12:35 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added devolve function for 'ResourceProviderInfo'.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp eb58a90e7fcf9ad1c4d7b41f378cd0b2955cf39b 
>   src/internal/devolve.cpp 5df5d4107fdad5a7333dcd599e9a8292684a817f 
> 
> 
> Diff: https://reviews.apache.org/r/66451/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 66454: Updated the documented release schedule.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66454/
---

Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.


Repository: mesos


Description
---

Updated the documented release schedule.


Diffs
-

  docs/versioning.md 70feb53d68e579a4ec7dd545648caa898cbbf6de 


Diff: https://reviews.apache.org/r/66454/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66449/#review200472
---




src/tests/containerizer/linux_capabilities_isolator_tests.cpp
Lines 747 (patched)


Should we call `slave.get()->terminate()` before `reset()`? See 
SlaveRecoveryTest.


- Gilbert Song


On April 4, 2018, 5:17 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66449/
> ---
> 
> (Updated April 4, 2018, 5:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-8489
> https://issues.apache.org/jira/browse/MESOS-8489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Starting more than one agent simultaneously in tests leads to a race
> condition between a linux launcher which calls `cgroups::prepare()` for
> the first slave and `LinuxLauncherProcess::recover()` which iterates
> over cgroups hierarchy for the second slave. Therefore, `mesos/test`
> cgroup that is created to check if the kernel supports nested cgroups
> can be detected by a recovery process as they use same cgroup hierarchy
> path by default. That leads to orphan containers and causes flakiness
> of `ROOT_IsolatorFlags` test. To fix the issue, this patch adds
> termination of an agent before starting a new one.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> 147f2cc09307cf8c9cf6f71d0175f8a3593c0256 
> 
> 
> Diff: https://reviews.apache.org/r/66449/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/#review200471
---




src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Lines 398 (patched)


No need to return a `Future` here, can be just `void`.



src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Lines 415 (patched)


We don't give any grace period here, its mention should be removed from the 
comment.



src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Lines 417 (patched)


Shouldn't this be `quotaInfo->used > quotaInfo->softLimit`? Why punish 
containers that are within the requested limits.



src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Lines 544 (patched)


I may be missing something here, why do you need this? Are you capturing 
this `PID` in lambdas for something? Object lifetime extension (AFAIK it 
doesn't work like that, though I may be wrong)?


- Ilya Pronin


On April 4, 2018, 10:41 a.m., Harold Dost wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66001/
> ---
> 
> (Updated April 4, 2018, 10:41 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New Flags for disk/xfs isolator:
> - xfs_kill_containers - This will create a 10 MB buffer between the soft
>   and hard limits, and when the soft limit is exceeded it will
>   subsequently be killed.
> 
> Functionality
> - This by default disabled behavior allows for the `disk/xfs` isolator
>   to kill containers which surpass their limit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
> 07e68a777aefba4dd35066f2eb207bba7f199d83 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 8d9f8f846866f9de377c59cb7fb311041283ba70 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> e034133629a9c1cf58b776f8da2a93421332cee0 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> 2708524add1ff693b616d4fb241c4a0a3070520b 
>   src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
>   src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 
> 
> 
> Diff: https://reviews.apache.org/r/66001/diff/12/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harold Dost
> 
>

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

[Harold Dost]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/
---

(Updated April 4, 2018, 5:41 p.m.)


Review request for mesos and James Peach.


Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575


Repository: mesos


Description
---

MESOS-6575


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp 
64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 


Diff: https://reviews.apache.org/r/66173/diff/3/

Changes: https://reviews.apache.org/r/66173/diff/2-3/


Testing
---


Thanks,

Harold Dost

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

[Harold Dost]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/
---

(Updated April 4, 2018, 5:41 p.m.)


Review request for mesos and James Peach.


Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575


Repository: mesos


Description
---

New Flags for disk/xfs isolator:
- xfs_kill_containers - This will create a 10 MB buffer between the soft
  and hard limits, and when the soft limit is exceeded it will
  subsequently be killed.

Functionality
- This by default disabled behavior allows for the `disk/xfs` isolator
  to kill containers which surpass their limit.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
07e68a777aefba4dd35066f2eb207bba7f199d83 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
8d9f8f846866f9de377c59cb7fb311041283ba70 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
e034133629a9c1cf58b776f8da2a93421332cee0 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
2708524add1ff693b616d4fb241c4a0a3070520b 
  src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
  src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
  src/tests/containerizer/xfs_quota_tests.cpp 
64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 


Diff: https://reviews.apache.org/r/66001/diff/12/

Changes: https://reviews.apache.org/r/66001/diff/11-12/


Testing
---


Thanks,

Harold Dost

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66431/#review200469
---




3rdparty/stout/include/stout/os/windows/ftruncate.hpp
Lines 16-33 (original), 16-38 (patched)


This all belongs in its own commit. Oops.


- Andrew Schwartzmeyer


On April 3, 2018, 10:50 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66431/
> ---
> 
> (Updated April 3, 2018, 10:50 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8676
> https://issues.apache.org/jira/browse/MESOS-8676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This can eventually support overlapped I/O.
> 
> The Windows API `ReadFile()` returns an error if the pipe is broken,
> where `_read()` did not, but this is not an error for us as the data
> is still read correctly. So we ignore it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/ftruncate.hpp 
> fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> 8047ad590fcc46d3ec46b551472d8c518ae49cc1 
> 
> 
> Diff: https://reviews.apache.org/r/66431/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66441: Fixed mismatched types in `process.cpp`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66441/#review200468
---




3rdparty/libprocess/src/process.cpp
Line 1387 (original), 1387 (patched)


Oh I know why this is needed now, because `int_fd` is convertable to `int`, 
which I'm not thrilled out. I'll re-examine it...


- Andrew Schwartzmeyer


On April 3, 2018, 10:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66441/
> ---
> 
> (Updated April 3, 2018, 10:57 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Because of the ternary, the primitive integer `-1` must be explicitly
> constructed into an `int_fd` to match the type held in the `sockets`
> container.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd 
> 
> 
> Diff: https://reviews.apache.org/r/66441/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66444/#review200467
---



I think our other option is to just delete this file, and have `os/signals.hpp` 
include the POSIX version, but not the (deleted) Windows version, with a 
comment that none of it is (or will be) implemented.

- Andrew Schwartzmeyer


On April 3, 2018, 10:58 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66444/
> ---
> 
> (Updated April 3, 2018, 10:58 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This file had never been included before, so it didn't compile. It
> needed to include `unimplemented.hpp`, and because `Suppressor` isn't
> implemented, the initializers had to be deleted.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/signals.hpp 
> 0ed24771625e58c1de8b1aa96b70f5aae1638bd4 
> 
> 
> Diff: https://reviews.apache.org/r/66444/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66392/#review200465
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On April 3, 2018, 8:46 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66392/
> ---
> 
> (Updated April 3, 2018, 8:46 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Find sasl2 on non-Windows platforms before trying to link it.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
> 
> 
> Diff: https://reviews.apache.org/r/66392/diff/3/
> 
> 
> Testing
> ---
> 
> make on FreeBSD
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66450: Added missing gmock expectation.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66450/#review200463
---



Patch looks great!

Reviews applied: [66450]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2018, 12:21 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66450/
> ---
> 
> (Updated April 4, 2018, 12:21 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added missing gmock expectation.
> 
> 
> Diffs
> -
> 
>   src/tests/resource_provider_manager_tests.cpp 
> 05ae5defb986103520cf630d5578e8a04e662313 
> 
> 
> Diff: https://reviews.apache.org/r/66450/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66314/#review200458
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66314']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66314

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66314/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (114 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1071 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (766 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (791 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (842 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (868 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (457107 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66314/logs/mesos-tests-stderr.log):

```
I0404 15:34:29.087707  4724 master.cpp:10449] Updating the state of task 
f2abc4a7-0333-48dd-aa68-31c49aa6cb80 of framework 
cd7c7eb7-a02d-457f-902d-bde2d9aebf5a- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0404 15:34:29.087707 11060 slave.cpp:3877] Shutting down framework 
cd7c7eb7-a02d-457f-902d-bde2d9aebf5a-
I0404 15:34:29.088703 11060 slave.cpp:6574] Shutting down executor 
'f2abc4a7-0333-48dd-aa68-31c49aa6cb80' of framework 
cd7c7eb7-a02d-457f-902d-bde2d9aebf5a- at executor(1)@10.3.1.8:64287
I0404 15:34:29.088703 11060 slave.cpp:923] Agent terminating
W0404 15:34:29.089694 11060 slave.cpp:3873] Ignoring shutdown framework 
cd7c7eb7-a02d-457f-902d-bde2d9aebf5a- because it is terminating
I0404 15:34:29.090912  4724 master.cpp:10548] Removing task 
f2abc4a7-0333-48dd-aa68-31c49aa6cb80 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework cd7c7eb7-a02d-457f-902d-bde2d9aebf5a- on 
agent cd7c7eb7-a02d-457f-902d-bde2d9aebf5a-S0 at slave(418)@1I0404 
15:34:28.887692  8764 exec.cpp:162] Version: 1.6.0
I0404 15:34:28.916703  3848 exec.cpp:236] Executor registered on agent 
cd7c7eb7-a02d-457f-902d-bde2d9aebf5a-S0
I0404 15:34:28.920713 13524 executor.cpp:176] Received SUBSCRIBED event
I0404 15:34:28.926687 13524 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 15:34:28.927688 13524 executor.cpp:176] Received LAUNCH event
I0404 15:34:28.933684 13524 executor.cpp:648] Starting task 
f2abc4a7-0333-48dd-aa68-31c49aa6cb80
I0404 15:34:29.029688 13524 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 15:34:29.057710 13524 executor.cpp:661] Forked command at 13908
I0404 15:34:29.089694  2304 exec.cpp:445] Executor asked to shutdown
I0404 15:34:29.090912 11452 executor.cpp:176] Received SHUTDOWN event
I0404 15:34:29.090912 11452 executor.cpp:758] Shutting down
I0404 15:34:29.091694 11452 executor.cpp:868] Sending SIGTERM to process tree 
at pid 0.3.1.8:64266 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 15:34:29.093690 14220 containerizer.cpp:2338] Destroying container 
c09116e7-f435-4624-afac-33f7e1746e84 in RUNNING state
I0404 15:34:29.093690 14220 containerizer.cpp:2952] Transitioning the state of 
container c09116e7-f435-4624-afac-33f7e1746e84 from RUNNING to DESTROYING
I0404 15:34:29.093690  4724 master.cpp:1295] Agent 
cd7c7eb7-a02d-457f-902d-bde2d9aebf5a-S0 at slave(418)@10.3.1.8:64266 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 15:34:29.094696  4724 master.cpp:3286] Disconnecting agent 
cd7c7eb7-a02d-457f-902d-bde2d9aebf5a-S0 at slave(418)@10.3.1.8:64266 

Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.

[Andrei Budnik]

> On April 3, 2018, 7:13 p.m., Gilbert Song wrote:
> > LGTM, before landing this patch, could we verify the nested cgroup is 
> > alwasy supportted after kernel 2.6.23?

Nested freezer cgroup is supported since kernel **2.6.28**
```
freezer (since Linux 2.6.28; CONFIG_CGROUP_FREEZER)
  The freezer cgroup can suspend and restore (resume) all pro?
  cesses in a cgroup.  Freezing a cgroup /A also causes its
  children, for example, processes in /A/B, to be frozen.
```
Note, that we are trying to create a directory using 
`/sys/fs/cgroup/freezer/mesos/test` path.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66404/#review200392
---


On April 3, 2018, 4:19 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66404/
> ---
> 
> (Updated April 3, 2018, 4:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-8489
> https://issues.apache.org/jira/browse/MESOS-8489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, we were checking for nested cgroup support while trying to
> create a linux launcher. This was necessary to make sure that the
> kernel supports creating nested cgroups. As we don't support old
> kernel versions which don't support nested cgroups, this check can be
> safely removed.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 
> 
> 
> Diff: https://reviews.apache.org/r/66404/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66449/#review200453
---



Patch looks great!

Reviews applied: [66449]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2018, 3:17 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66449/
> ---
> 
> (Updated April 4, 2018, 3:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-8489
> https://issues.apache.org/jira/browse/MESOS-8489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Starting more than one agent simultaneously in tests leads to a race
> condition between a linux launcher which calls `cgroups::prepare()` for
> the first slave and `LinuxLauncherProcess::recover()` which iterates
> over cgroups hierarchy for the second slave. Therefore, `mesos/test`
> cgroup that is created to check if the kernel supports nested cgroups
> can be detected by a recovery process as they use same cgroup hierarchy
> path by default. That leads to orphan containers and causes flakiness
> of `ROOT_IsolatorFlags` test. To fix the issue, this patch adds
> termination of an agent before starting a new one.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> 147f2cc09307cf8c9cf6f71d0175f8a3593c0256 
> 
> 
> Diff: https://reviews.apache.org/r/66449/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66314/
---

(Updated April 4, 2018, 2:34 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Changes
---

Changed `EXTERNAL_MAKE` to `MAKE_PROGRAM`.


Bugs: MESOS-4176
https://issues.apache.org/jira/browse/MESOS-4176


Repository: mesos


Description
---

Fix 3rdparty build commands for FreeBSD.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 


Diff: https://reviews.apache.org/r/66314/diff/4/

Changes: https://reviews.apache.org/r/66314/diff/3-4/


Testing
---

make on FreeBSD


Thanks,

David Forsythe

Re: Review Request 66451: Added devolve function for 'ResourceProviderInfo'.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66451/#review200452
---



PASS: Mesos patch 66451 was successfully built and tested.

Reviews applied: `['66451']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66451

- Mesos Reviewbot Windows


On April 4, 2018, 12:35 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66451/
> ---
> 
> (Updated April 4, 2018, 12:35 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added devolve function for 'ResourceProviderInfo'.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp eb58a90e7fcf9ad1c4d7b41f378cd0b2955cf39b 
>   src/internal/devolve.cpp 5df5d4107fdad5a7333dcd599e9a8292684a817f 
> 
> 
> Diff: https://reviews.apache.org/r/66451/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 66450: Added missing gmock expectation.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66450/#review200451
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66450']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66450

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66450/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (116 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1095 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (38 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (79 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (778 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (805 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (835 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (860 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (449675 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66450/logs/mesos-tests-stderr.log):

```
I0404 14:07:49.860273  1312 slave.cpp:3877] Shutting down framework 
c825513f-2f38-457e-8e46-84e18a5adcd3-
I0404 14:07:49.860273 11164 master.cpp:10449] Updating the state of task 
3d7109c1-513e-4035-b806-2d6fcc3d36e1 of framework 
c825513f-2f38-457e-8e46-84e18a5adcd3- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0404 14:07:49.860273  1312 slave.cpp:6574] Shutting down executor 
'3d7109c1-513e-4035-b806-2d6fcc3d36e1' of framework 
c825513f-2f38-457e-8e46-84e18a5adcd3- at executor(1)@10.3.1.8:61899
I0404 14:07:49.862273 10380 slave.cpp:923] Agent terI0404 14:07:49.681278 12564 
exec.cpp:162] Version: 1.6.0
I0404 14:07:49.709280 12740 exec.cpp:236] Executor registered on agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0
I0404 14:07:49.713281  3068 executor.cpp:176] Received SUBSCRIBED event
I0404 14:07:49.718281  3068 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 14:07:49.718281  3068 executor.cpp:176] Received LAUNCH event
I0404 14:07:49.723280  3068 executor.cpp:648] Starting task 
3d7109c1-513e-4035-b806-2d6fcc3d36e1
I0404 14:07:49.804282  3068 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 14:07:49.831276  3068 executor.cpp:661] Forked command at 12432
I0404 14:07:49.862273 13084 exec.cpp:445] Executor asked to shutdown
I0404 14:07:49.862273 12940 executor.cpp:176] Received SHUTDOWN event
I0404 14:07:49.863270 12940 executor.cpp:758] Shutting down
I0404 14:07:49.863270 12940 executor.cpp:868] Sending SIGTERM to process tree 
at pid minating
W0404 14:07:49.863270 10380 slave.cpp:3873] Ignoring shutdown framework 
c825513f-2f38-457e-8e46-84e18a5adcd3- because it is terminating
I0404 14:07:49.863270 11164 master.cpp:10548] Removing task 
3d7109c1-513e-4035-b806-2d6fcc3d36e1 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework c825513f-2f38-457e-8e46-84e18a5adcd3- on 
agent c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 14:07:49.866276 11164 master.cpp:1295] Agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 14:07:49.866276 11164 master.cpp:3286] Disconnecting agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 14:07:49.866276 11164 master.cpp:3305] Deactivating agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 14:07:49.866276 14232 containerizer.cpp:2338] 

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

[Harold Dost]

> On March 27, 2018, 4:35 p.m., James Peach wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp
> > Lines 368 (patched)
> > 
> >
> > Move this into the case statement block.

So if I do that then I will not be able to access it when setting the quota.


- Harold


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/#review25
---


On March 23, 2018, 4:13 p.m., Harold Dost wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66001/
> ---
> 
> (Updated March 23, 2018, 4:13 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New Flags for disk/xfs isolator:
> - xfs_kill_containers - This will create a 10 MB buffer between the soft
>   and hard limits, and when the soft limit is exceeded it will
>   subsequently be killed.
> 
> Functionality
> - This by default disabled behavior allows for the `disk/xfs` isolator
>   to kill containers which surpass their limit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
> 07e68a777aefba4dd35066f2eb207bba7f199d83 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 8d9f8f846866f9de377c59cb7fb311041283ba70 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> e034133629a9c1cf58b776f8da2a93421332cee0 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> 2708524add1ff693b616d4fb241c4a0a3070520b 
>   src/slave/flags.hpp 949a4783caf8aac9a246a98525a5287b0f8256d8 
>   src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 
> 
> 
> Diff: https://reviews.apache.org/r/66001/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harold Dost
> 
>

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66449/#review200449
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66449']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66449

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66449/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (116 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1067 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (38 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (41 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (81 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (807 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (835 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (836 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (860 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (448338 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66449/logs/mesos-tests-stderr.log):

```
I0404 13:15:01.126520  6260 master.cpp:10449] Updating the state of task 
eb30f9c5-e691-4ac4-89de-a00a5f2cea69 of framework 
970932f1-3c0e-4e32-af5d-101b00483f56- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0404 13:15:01.126520 12600 slave.cpp:3877] Shutting down fraI0404 
13:15:00.947546 13736 exec.cpp:162] Version: 1.6.0
I0404 13:15:00.973520  6356 exec.cpp:236] Executor registered on agent 
970932f1-3c0e-4e32-af5d-101b00483f56-S0
I0404 13:15:00.977519 12940 executor.cpp:176] Received SUBSCRIBED event
I0404 13:15:00.982553 12940 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 13:15:00.982553 12940 executor.cpp:176] Received LAUNCH event
I0404 13:15:00.988550 12940 executor.cpp:648] Starting task 
eb30f9c5-e691-4ac4-89de-a00a5f2cea69
I0404 13:15:01.069747 12940 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 13:15:01.098561 12940 executor.cpp:661] Forked command at 5616
I0404 13:15:01.129519  5664 exec.cpp:445] Executor asked to shutdown
I0404 13:15:01.129519 12972 executor.cpp:176] Received SHUTDOWN event
I0404 13:15:01.129519 12972 executor.cpp:758] Shutting down
I0404 13:15:01.129519 12972 executor.cpp:868] Sending SIGTERM to process tree 
at pid 5mework 970932f1-3c0e-4e32-af5d-101b00483f56-
I0404 13:15:01.127542 12600 slave.cpp:6574] Shutting down executor 
'eb30f9c5-e691-4ac4-89de-a00a5f2cea69' of framework 
970932f1-3c0e-4e32-af5d-101b00483f56- at executor(1)@10.3.1.8:59570
I0404 13:15:01.128708 13916 slave.cpp:923] Agent terminating
W0404 13:15:01.128708 13916 slave.cpp:3873] Ignoring shutdown framework 
970932f1-3c0e-4e32-af5d-101b00483f56- because it is terminating
I0404 13:15:01.129519  6260 master.cpp:10548] Removing task 
eb30f9c5-e691-4ac4-89de-a00a5f2cea69 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 970932f1-3c0e-4e32-af5d-101b00483f56- on 
agent 970932f1-3c0e-4e32-af5d-101b00483f56-S0 at slave(418)@10.3.1.8:59549 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 13:15:01.131566  8520 containerizer.cpp:2338] Destroying container 
16a2a12b-8ed1-4d4b-9f8e-66983e83a42c in RUNNING state
I0404 13:15:01.132565  8520 containerizer.cpp:2952] Transitioning the state of 
container 16a2a12b-8ed1-4d4b-9f8e-66983e83a42c from RUNNING to DESTROYING
I0404 13:15:01.133525  6260 master.cpp:1295] Agent 
970932f1-3c0e-4e32-af5d-101b00483f56-S0 at slave(418)@10.3.1.8:59549 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 13:15:01.133525  6260 master.cpp:3286] Disconnecting agent 
970932f1-3c0e-4e32-af5d-101b00483f56-S0 at slave(418)@10.3.1.8:59549 

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

[Harold Dost]

> On March 27, 2018, 4:35 p.m., James Peach wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp
> > Line 362 (original), 414 (patched)
> > 
> >
> > `needed` is still the allocated quota so you don't need to use 
> > `hardLimit` here.

So the reason I did it this way was that the quota which is being shown should 
(I believe) reflect the amount of space which is actually being provided vs 
what is being requested. If not then I can change this.


> On March 27, 2018, 4:35 p.m., James Peach wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp
> > Lines 440 (patched)
> > 
> >
> > I don't think we need this log message.

Yea, this was not supposed to get committed.


> On March 27, 2018, 4:35 p.m., James Peach wrote:
> > src/slave/containerizer/mesos/isolators/xfs/utils.cpp
> > Lines 274 (patched)
> > 
> >
> > Remove whitespace between `(` and `"`. Use a consistent error message, 
> > i.e.:
> > 
> > ```
> > if (hardLimit == 0) {
> >   return Error("Quota hard limit must be greater than 0");
> > }
> > 
> > if (softLimit == 0) {
> >   return Error("Quota soft limit must be greater than 0");
> > }
> > ```

So I know that we aren't using it this way, but I was more thinking from an API 
perspective that it might make to have one or the other to be 0, but not both, 
but I take your point.


- Harold


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/#review25
---


On March 23, 2018, 4:13 p.m., Harold Dost wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66001/
> ---
> 
> (Updated March 23, 2018, 4:13 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New Flags for disk/xfs isolator:
> - xfs_kill_containers - This will create a 10 MB buffer between the soft
>   and hard limits, and when the soft limit is exceeded it will
>   subsequently be killed.
> 
> Functionality
> - This by default disabled behavior allows for the `disk/xfs` isolator
>   to kill containers which surpass their limit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
> 07e68a777aefba4dd35066f2eb207bba7f199d83 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 8d9f8f846866f9de377c59cb7fb311041283ba70 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> e034133629a9c1cf58b776f8da2a93421332cee0 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> 2708524add1ff693b616d4fb241c4a0a3070520b 
>   src/slave/flags.hpp 949a4783caf8aac9a246a98525a5287b0f8256d8 
>   src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 
> 
> 
> Diff: https://reviews.apache.org/r/66001/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harold Dost
> 
>

Review Request 66451: Added devolve function for 'ResourceProviderInfo'.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66451/
---

Review request for mesos and Jan Schlicht.


Repository: mesos


Description
---

Added devolve function for 'ResourceProviderInfo'.


Diffs
-

  src/internal/devolve.hpp eb58a90e7fcf9ad1c4d7b41f378cd0b2955cf39b 
  src/internal/devolve.cpp 5df5d4107fdad5a7333dcd599e9a8292684a817f 


Diff: https://reviews.apache.org/r/66451/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

[Harold Dost]

> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp
> > Line 304 (original), 317-318 (patched)
> > 
> >
> > Keep `infos.contains(containerId)` check here. Otherwise you can just 
> > remove this method, it will be inherited from `MesosIsolatorProcess`.

I believe I addressed this in relation to one of jpeach's comments.


> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp
> > Lines 393 (patched)
> > 
> >
> > This should be configurable.

So I had this configurable previously if you look at previous diff revisions. I 
was asked to remove it.


> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp
> > Lines 411-442 (original), 498-530 (patched)
> > 
> >
> > What's the point of this drive-by change? The only change here is 
> > `info.` removal, right?

This is because I had to add a promise to the info for the functionality of the 
limitation, and the nature of promises is that they cannot be copied. As a 
result I had to grab the specific information needed for this part of the code.


- Harold


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/#review200296
---


On March 23, 2018, 4:13 p.m., Harold Dost wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66001/
> ---
> 
> (Updated March 23, 2018, 4:13 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New Flags for disk/xfs isolator:
> - xfs_kill_containers - This will create a 10 MB buffer between the soft
>   and hard limits, and when the soft limit is exceeded it will
>   subsequently be killed.
> 
> Functionality
> - This by default disabled behavior allows for the `disk/xfs` isolator
>   to kill containers which surpass their limit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
> 07e68a777aefba4dd35066f2eb207bba7f199d83 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 8d9f8f846866f9de377c59cb7fb311041283ba70 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> e034133629a9c1cf58b776f8da2a93421332cee0 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> 2708524add1ff693b616d4fb241c4a0a3070520b 
>   src/slave/flags.hpp 949a4783caf8aac9a246a98525a5287b0f8256d8 
>   src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 
> 
> 
> Diff: https://reviews.apache.org/r/66001/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harold Dost
> 
>

Review Request 66450: Added missing gmock expectation.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66450/
---

Review request for mesos and Jan Schlicht.


Repository: mesos


Description
---

Added missing gmock expectation.


Diffs
-

  src/tests/resource_provider_manager_tests.cpp 
05ae5defb986103520cf630d5578e8a04e662313 


Diff: https://reviews.apache.org/r/66450/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66449/
---

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.


Bugs: MESOS-8489
https://issues.apache.org/jira/browse/MESOS-8489


Repository: mesos


Description
---

Starting more than one agent simultaneously in tests leads to a race
condition between a linux launcher which calls `cgroups::prepare()` for
the first slave and `LinuxLauncherProcess::recover()` which iterates
over cgroups hierarchy for the second slave. Therefore, `mesos/test`
cgroup that is created to check if the kernel supports nested cgroups
can be detected by a recovery process as they use same cgroup hierarchy
path by default. That leads to orphan containers and causes flakiness
of `ROOT_IsolatorFlags` test. To fix the issue, this patch adds
termination of an agent before starting a new one.


Diffs
-

  src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
147f2cc09307cf8c9cf6f71d0175f8a3593c0256 


Diff: https://reviews.apache.org/r/66449/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 66165: Re-fixed many master allocator tests.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66165/#review200448
---


Fix it, then Ship it!





src/tests/master_allocator_tests.cpp
Lines 912-913 (original), 889-891 (patched)


This is a multi-agent test, please restore to its original form.



src/tests/master_allocator_tests.cpp
Lines 968-969 (original), 943-945 (patched)


Also a multi-agent test, please restore to its original form.


- Benjamin Bannier


On March 20, 2018, 9:36 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66165/
> ---
> 
> (Updated March 20, 2018, 9:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8613
> https://issues.apache.org/jira/browse/MESOS-8613
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When the slave has a very short lifetime, its scheduled registration
> retry might occur when the test is tearing down. These unintuitively
> motivated registrations in turn cause additional invocations of
> `AddSlave` on the allocator.
> Additionally, this also reverts the newly introduced Clock pauses as
> they have shown to be problematic.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> 1ceb8e8a57ab300a957931d5ad3d54904e97 
> 
> 
> Diff: https://reviews.apache.org/r/66165/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> Ran the MasterAllocatorTests 10k times without any hiccups.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66314/#review200447
---



Patch looks great!

Reviews applied: [66314]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2018, 6:45 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66314/
> ---
> 
> (Updated April 4, 2018, 6:45 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix 3rdparty build commands for FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
> 
> 
> Diff: https://reviews.apache.org/r/66314/diff/3/
> 
> 
> Testing
> ---
> 
> make on FreeBSD
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66412: Fixed flaky agent test.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200443
---



Patch looks great!

Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66322, 66144, 
66346, 66145, 66178, 66323, 66347, 66412]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 3, 2018, 10:10 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> ---
> 
> (Updated April 3, 2018, 10:10 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down.
> 
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66412/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66314/#review200441
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66314']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66314

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66314/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (113 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1074 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (75 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (814 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (844 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (817 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (842 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (444889 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66314/logs/mesos-tests-stderr.log):

```
I0404 08:24:10.527199  2600 slave.cpp:3877] Shutting down framework 
d27be169-928d-44bf-b9cf-c0b66c4562f5-
I0404 08:24:10.527199  7224 master.cpp:10449] Updating the state of task 
af9512c0-aec1-4dd5-b047-2ec5fb30f3ba of framework d27be169-928d-44bfI0404 
08:24:10.344171  4216 exec.cpp:162] Version: 1.6.0
I0404 08:24:10.372175  5172 exec.cpp:236] Executor registered on agent 
d27be169-928d-44bf-b9cf-c0b66c4562f5-S0
I0404 08:24:10.376562 12312 executor.cpp:176] Received SUBSCRIBED event
I0404 08:24:10.381171 12312 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 08:24:10.382174 12312 executor.cpp:176] Received LAUNCH event
I0404 08:24:10.387174 12312 executor.cpp:648] Starting task 
af9512c0-aec1-4dd5-b047-2ec5fb30f3ba
I0404 08:24:10.472184 12312 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 08:24:10.501168 12312 executor.cpp:661] Forked command at 12424
I0404 08:24:10.529147  4228 exec.cpp:445] Executor asked to shutdown
I0404 08:24:10.530145 13964 executor.cpp:176] Received SHUTDOWN event
I0404 08:24:10.530145 13964 executor.cpp:758] Shutting down
I0404 08:24:10.530145 13964 executor.cpp:868] Sending SIGTERM to process tree 
at pid -b9cf-c0b66c4562f5- (latest state: TASK_KILLED, status update state: 
TASK_KILLED)
I0404 08:24:10.527199  2600 slave.cpp:6574] Shutting down executor 
'af9512c0-aec1-4dd5-b047-2ec5fb30f3ba' of framework 
d27be169-928d-44bf-b9cf-c0b66c4562f5- at executor(1)@10.3.1.8:57096
I0404 08:24:10.529147  7600 slave.cpp:923] Agent terminating
W0404 08:24:10.529147  7600 slave.cpp:3873] Ignoring shutdown framework 
d27be169-928d-44bf-b9cf-c0b66c4562f5- because it is terminating
I0404 08:24:10.530145  7224 master.cpp:10548] Removing task 
af9512c0-aec1-4dd5-b047-2ec5fb30f3ba with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework d27be169-928d-44bf-b9cf-c0b66c4562f5- on 
agent d27be169-928d-44bf-b9cf-c0b66c4562f5-S0 at slave(418)@10.3.1.8:57075 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 08:24:10.532155  1124 containerizer.cpp:2338] Destroying container 
f6b7afe2-2176-4991-a7fc-c15fecf99239 in RUNNING state
I0404 08:24:10.533147  1124 containerizer.cpp:2952] Transitioning the state of 
container f6b7afe2-2176-4991-a7fc-c15fecf99239 from RUNNING to DESTROYING
I0404 08:24:10.533147  7224 master.cpp:1295] Agent 
d27be169-928d-44bf-b9cf-c0b66c4562f5-S0 at slave(418)@10.3.1.8:57075 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 08:24:10.533147  7224 master.cpp:3286] Disconnecting agent 
d27be169-928d-44bf-b9cf-c0b66c4562f5-S0 at slave(418)@10.3.1.8:57075 

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66445/#review200437
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66420', '66421', '66422', '66423', '66424', '66425', 
'66426', '66427', '66428', '66429', '66430', '66431', '66432', '66433', 
'66434', '66435', '66436', '66437', '66438', '66439', '66440', '66441', 
'66442', '66443', '66444', '66445']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66445

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66445/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (111 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1052 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (75 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (856 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (883 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (832 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (859 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (451622 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66445/logs/mesos-tests-stderr.log):

```
I0404 07:31:24.303032 11416 executor.cpp:177] Received SUBSCRIBED event
I0404 07:31:24.308010 11416 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 07:31:24.309013 11416 executor.cpp:177] Received LAUNCH event
I0404 07:31:24.314009 11416 executor.cpp:649] Starting task 
a992b0d2-fb29-4e8d-9e58-fcc4d29c11bd
I0404 07:31:24.406028 11416 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 07:31:24.435024 11416 executor.cpp:662] Forked command at 13220
I0404 07:31:24.467031 13304 exec.cpp:445] Executor asked to shutdown
I0404 07:31:24.468184 11768 executor.cpp:177] Received SHUTDOWN event
I0404 07:31:24.468184 11768 executor.cpp:759] Shutting down
I0404 07:31:24.468184 11768 executor.cpp:869] Sending SIGTERM to process tree 
at pid eduler-212854d1-0a94-48c8-a50c-e2b6cfd3f315@10.3.1.8:54729
I0404 07:31:24.466032  4212 hierarchical.cpp:405] Deactivated framework 
4e219fa7-8ae4-49c7-92ba-c64f0cc8d950-
I0404 07:31:24.466032  1812 master.cpp:10449] Updating the state of task 
a992b0d2-fb29-4e8d-9e58-fcc4d29c11bd of framework 
4e219fa7-8ae4-49c7-92ba-c64f0cc8d950- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0404 07:31:24.466032 12948 slave.cpp:3877] Shutting down framework 
4e219fa7-8ae4-49c7-92ba-c64f0cc8d950-
I0404 07:31:24.466032 12948 slave.cpp:6574] Shutting down executor 
'a992b0d2-fb29-4e8d-9e58-fcc4d29c11bd' of framework 
4e219fa7-8ae4-49c7-92ba-c64f0cc8d950- at executor(1)@10.3.1.8:54750
I0404 07:31:24.467031 12948 slave.cpp:923] Agent terminating
W0404 07:31:24.467031 12948 slave.cpp:3873] Ignoring shutdown framework 
4e219fa7-8ae4-49c7-92ba-c64f0cc8d950- because it is terminating
I0404 07:31:24.469012  1812 master.cpp:10548] Removing task 
a992b0d2-fb29-4e8d-9e58-fcc4d29c11bd with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 4e219fa7-8ae4-49c7-92ba-c64f0cc8d950- on 
agent 4e219fa7-8ae4-49c7-92ba-c64f0cc8d950-S0 at slave(418)@10.3.1.8:54729 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 07:31:24.470022 12948 containerizer.cpp:2338] Destroying container 
74a1724d-206e-4542-8e18-5da7867d39ea in RUNNING state
I0404 07:31:24.471017 12948 containerizer.cpp:2952] Transitioning the state of 
container 74a1724d-206e-4542-8e18-5da7867d39ea from RUNNING to DESTROYING
I0404 07:31:24.472017 12948 launcher.cpp:156] Asked to destroy container 
74a1724d-206e-4542-8e18-5da7867d39ea
I0404 07:31:24.472017  1812 

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66445/#review200436
---



Patch looks great!

Reviews applied: [66420, 66421, 66422, 66423, 66424, 66425, 66426, 66427, 
66428, 66429, 66430, 66431, 66432, 66433, 66434, 66435, 66436, 66437, 66438, 
66439, 66440, 66441, 66442, 66443, 66444, 66445]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2018, 5:58 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66445/
> ---
> 
> (Updated April 4, 2018, 5:58 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The set `errno` value in `os::kill()` is never checked (especially on
> Windows), so `_set_errno()` and thus `errno.h` were removed.
> 
> The `fcntl.h` is used only to provide `O_CREAT` etc., and so belonged
> in `open.hpp`, not `windows.hpp`.
> 
> The remaining headers, `direct.h`, `io.h`, `process.h`, and `stdlib.h`
> were no longer used or needed as the respective CRT APIs were
> replaced.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/kill.hpp 
> 9cec1117fac3cf6bd624fc7db524ef1ad10cd55d 
>   3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> 9181429383a991fe2b87701d2bfd0e858ac2537b 
>   3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> a2926dab2c8e219cf5938c4df27f83488198dd6b 
>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> fff5872db6b3f69464e41e6d108a107e4eeabd12 
>   3rdparty/stout/include/stout/windows.hpp 
> 1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993 
>   3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 
> 5b3cbf4f36ea9ac0411df52b4cfea8ef75fecbb5 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 739ee4da3f09d2a9597d4451e755e77903e9287d 
> 
> 
> Diff: https://reviews.apache.org/r/66445/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66314/
---

(Updated April 4, 2018, 6:45 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Bugs: MESOS-4176
https://issues.apache.org/jira/browse/MESOS-4176


Repository: mesos


Description
---

Fix 3rdparty build commands for FreeBSD.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 


Diff: https://reviews.apache.org/r/66314/diff/3/

Changes: https://reviews.apache.org/r/66314/diff/2-3/


Testing
---

make on FreeBSD


Thanks,

David Forsythe