Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-10 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 10, 2015, 8:49 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
  src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-10 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105852
---

Ship it!



src/master/http.cpp (line 910)


s/Update/update



src/master/quota_handler.cpp (line 20)


Remove extra newline.


- Alexander Rukletsov


On Nov. 10, 2015, 8:49 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 10, 2015, 8:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
>   src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 9, 2015, 4:06 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joris Van Remoortere 


> On Nov. 6, 2015, 2:58 p.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 1
> > 
> >
> > It seems other feature named file without "_handler"; any consideration 
> > for it?
> 
> Joerg Schad wrote:
> In this case the file acutally only includes the handler part (basically 
> in order not to overload the http code) and hence the name seems to be 
> precise.

We can re-visit this later if we find the pattern here doesn't warrant the 
`_handler` extension. Dropping for now.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105425
---


On Nov. 9, 2015, 11:10 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 9, 2015, 11:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
>   src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105798
---

Ship it!



src/master/master.hpp (line 859)


If we want to signify that this is not implemented, let's use the 
`http::NotImplemented` message. Here and below.


- Joris Van Remoortere


On Nov. 9, 2015, 11:10 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 9, 2015, 11:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
>   src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 9, 2015, 11:10 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joerg Schad 


> On Nov. 6, 2015, 2:58 p.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 1
> > 
> >
> > It seems other feature named file without "_handler"; any consideration 
> > for it?

In this case the file acutally only includes the handler part (basically in 
order not to overload the http code) and hence the name seems to be precise.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105425
---


On Nov. 3, 2015, 1:55 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 3, 2015, 1:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 9, 2015, 8:15 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Changes
---

Fixed Typo


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
  src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
  src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-06 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105425
---



src/master/quota_handler.cpp (line 1)


It seems other feature named file without "_handler"; any consideration for 
it?


- Klaus Ma


On Nov. 3, 2015, 9:55 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 3, 2015, 9:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-04 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105190
---

Ship it!



src/master/http.cpp (line 833)


s/seperate/separate


- Joris Van Remoortere


On Nov. 3, 2015, 1:55 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 3, 2015, 1:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-03 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 3, 2015, 1:31 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
  src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
  src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-03 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 3, 2015, 1:55 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
  src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
  src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-25 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103947
---

Ship it!


Ship It!

- Qian Zhang


On Oct. 22, 2015, 9:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 22, 2015, 9:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-22 Thread Guangya Liu 


> On 十月 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 839
> > 
> >
> > what about "return quotaHandler.create(request)"
> 
> Joerg Schad wrote:
> Wanted to make names consistent.
> @alex: any preference?
> 
> Alexander Rukletsov wrote:
> Yes. Naming is hard, we had a long offline discussion about these names 
> and decided the following:
> - Be consistent. Though there are subtle differences between operations 
> depending on the stage in the process, they are minor and will most probably 
> lead to confusion.
> - `set` instead of `add`, `request`, or `create`. You cannot call `set` 
> multiple times, that's why `add` is not good. `request` is too vague, you can 
> request anything. `create` carries the meaning of a creation act, which is 
> not the focus we would like to have. An important message to deliver is that 
> `set` my change the allocation behaviour for the role significantly.
> - `update` (not in MVP).
> - `remove` instead of `release`, `destroy`, or `delete`. `destroy` and 
> `delete` focus on scrapping an object, which is not the most important action 
> in this case. We would like to put accent on the fact that there is no more 
> quota associated with the role. `release` for me implies possession, 
> moreover, it doesn't play nice with `set`.
> - CRUD naming is a reasonable alternative (because it's a standard), 
> however we decided to opt for more specific naming in a hope it will help 
> understanding quota implications better.
> - This is all about internal naming, the operator API uses standard HTTP 
> verbs for these actions.

Thanks Alex, fair enough.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103518
---


On 十月 22, 2015, 1:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated 十月 22, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-22 Thread Alexander Rukletsov 


> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 839
> > 
> >
> > what about "return quotaHandler.create(request)"
> 
> Joerg Schad wrote:
> Wanted to make names consistent.
> @alex: any preference?

Yes. Naming is hard, we had a long offline discussion about these names and 
decided the following:
- Be consistent. Though there are subtle differences between operations 
depending on the stage in the process, they are minor and will most probably 
lead to confusion.
- `set` instead of `add`, `request`, or `create`. You cannot call `set` 
multiple times, that's why `add` is not good. `request` is too vague, you can 
request anything. `create` carries the meaning of a creation act, which is not 
the focus we would like to have. An important message to deliver is that `set` 
my change the allocation behaviour for the role significantly.
- `update` (not in MVP).
- `remove` instead of `release`, `destroy`, or `delete`. `destroy` and `delete` 
focus on scrapping an object, which is not the most important action in this 
case. We would like to put accent on the fact that there is no more quota 
associated with the role. `release` for me implies possession, moreover, it 
doesn't play nice with `set`.
- CRUD naming is a reasonable alternative (because it's a standard), however we 
decided to opt for more specific naming in a hope it will help understanding 
quota implications better.
- This is all about internal naming, the operator API uses standard HTTP verbs 
for these actions.


> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 843
> > 
> >
> > What about return quotaHandler.delete(request);
> > 
> > It is better that the operation API can map to CRUD
> 
> Joerg Schad wrote:
> We wanted to make the name consistent across all calls. @alex: Any 
> preference?

Yep, see above.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103518
---


On Oct. 22, 2015, 1:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 22, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Joerg Schad 


> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 843
> > 
> >
> > What about return quotaHandler.delete(request);
> > 
> > It is better that the operation API can map to CRUD

We wanted to make the name consistent across all calls. @alex: Any preference?


> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 839
> > 
> >
> > what about "return quotaHandler.create(request)"

Wanted to make names consistent.
@alex: any preference?


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103518
---


On Oct. 22, 2015, 1:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 22, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Oct. 21, 2015, 10:41 p.m.)


Review request for Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris 
Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
  src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103518
---



src/master/http.cpp (line 839)


what about "return quotaHandler.create(request)"



src/master/http.cpp (line 843)


What about return quotaHandler.delete(request);

It is better that the operation API can map to CRUD


- Guangya Liu


On 十月 22, 2015, 1:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated 十月 22, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Oct. 14, 2015, 1:28 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Changes
---

Adressed comments.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
  src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 
  src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102630
---



src/master/master.hpp (lines 863 - 878)


I see that there are comments for renaming those functions to add, update, 
delete or addQuota, updateQuta, deleteQuota, I think that add/update/delete may 
be better as all of the functions are already in QuotaHandler, thoughts? Thanks.


- Guangya Liu


On 十月 14, 2015, 1:28 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated 十月 14, 2015, 1:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
>   src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 
>   src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Oct. 14, 2015, 1:07 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Changes
---

Rebased.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
  src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 
  src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Oct. 14, 2015, 2:07 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs
-

  src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
  src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 
  src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Oct. 14, 2015, 2:16 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Changes
---

Rebased on top of 38218.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
  src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d 
  src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-13 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102433
---



src/master/http.cpp (line 787)


Let's add the corresponding HELP function for this.



src/master/http.cpp (lines 790 - 800)


I don't think we need the `else if`s here.

```
if (a) {
  return ...;
}

if (b) {
  return ...;
}
```
This provides the opportunity to comment above each block and makes it 
easier to see each termination block.



src/master/http.cpp (line 799)


Can we mentioned what the method is in this error? You can use the 
maintenance endpoints as an example.



src/master/master.hpp (line 842)


s/actor is/actor. It is/



src/master/master.hpp (line 1020)


Let's add a comment that we are starting to partition some of the Admin 
APIs into classes to keep related endpoints together in a "module".


- Joris Van Remoortere


On Oct. 13, 2015, 8:55 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 13, 2015, 8:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
>   src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-13 Thread Joerg Schad 


> On Oct. 13, 2015, 11:54 a.m., Joris Van Remoortere wrote:
> > src/master/http.cpp, line 787
> > 
> >
> > Let's add the corresponding HELP function for this.

See Alex's earlier comment about providing the Help function once the semantics 
are finalized.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102433
---


On Oct. 13, 2015, 8:55 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 13, 2015, 8:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
>   src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-11 Thread Joerg Schad 


> On Oct. 10, 2015, 10:08 a.m., Alex Clemmer wrote:
> > src/Makefile.am, line 492
> > 
> >
> > Hey, could we please also add this to the `CMakeLists.txt` file in the 
> > `src/` directory? Thanks!

Done, please double-check and reopen if I have to do more :-). Thanks for 
pointing this out!


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102159
---


On Oct. 11, 2015, 4:12 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 11, 2015, 4:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
>   src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-11 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Oct. 11, 2015, 4:12 p.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Changes
---

Added to CMakeList.txt


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
  src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
  src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
  src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f 
  src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-11 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102197
---

Ship it!


Ship It!

- Guangya Liu


On 十月 11, 2015, 4:13 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated 十月 11, 2015, 4:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Alex 
> Clemmer.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
>   src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-10 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102159
---



src/Makefile.am (line 492)


Hey, could we please also add this to the `CMakeLists.txt` file in the 
`src/` directory? Thanks!


- Alex Clemmer


On Oct. 6, 2015, 9:31 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 6, 2015, 9:31 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-08 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review97974
---



src/master/master.hpp (line 901)


Why we add CALL_HELP back?


- Qian Zhang


On Sept. 3, 2015, 12:16 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Sept. 3, 2015, 12:16 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-02 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Sept. 2, 2015, 4:16 p.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
  src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
  src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-02 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Sept. 2, 2015, 1:46 p.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Changes
---

Rebased


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
  src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
  src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-02 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review97455
---


Patch looks great!

Reviews applied: [36908, 36913]

All tests passed.

- Mesos ReviewBot


On Sept. 2, 2015, 1:46 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Sept. 2, 2015, 1:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske 


 On Aug. 4, 2015, 3:08 a.m., Alexander Rukletsov wrote:
  src/master/master.hpp, line 766
  https://reviews.apache.org/r/36913/diff/7/?file=1028501#file1028501line766
 
  s/and /

See my previous review. This is correct syntax IMHO.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94030
---


On Aug. 4, 2015, 2:52 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 2:52 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad 


 On Aug. 4, 2015, 10:08 a.m., Alexander Rukletsov wrote:
  src/master/master.hpp, line 766
  https://reviews.apache.org/r/36913/diff/7/?file=1028501#file1028501line766
 
  s/and /
 
 Bernd Mathiske wrote:
 See my previous review. This is correct syntax IMHO.

See Bernds comment below.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94030
---


On Aug. 4, 2015, 9:52 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 9:52 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Aug. 4, 2015, 10:40 a.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Changes
---

Doxygenized class comment.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94041
---

Ship it!


Pending consistency with subsequent RRs in this chain, this LGTM.

- Bernd Mathiske


On Aug. 4, 2015, 3:40 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 3:40 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94030
---



src/master/master.hpp (line 766)
https://reviews.apache.org/r/36913/#comment148533

s/and /


- Alexander Rukletsov


On Aug. 4, 2015, 9:52 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 9:52 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94058
---


Patch looks great!

Reviews applied: [36913]

All tests passed.

- Mesos ReviewBot


On Aug. 4, 2015, 10:40 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 10:40 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Alexander Rukletsov 


 On Aug. 3, 2015, 2:21 p.m., Alexander Rukletsov wrote:
  src/master/quota_handler.hpp, lines 26-27
  https://reviews.apache.org/r/36913/diff/5/?file=1027610#file1027610line26
 
  I think we should wrap it into `master` namespace as well.

`quota_handler.cpp` still lacks the `master` namespace.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review93905
---


On Aug. 3, 2015, 6:09 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 3, 2015, 6:09 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Aug. 4, 2015, 9:52 a.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94024
---



src/master/master.hpp (line 916)
https://reviews.apache.org/r/36913/#comment148528

I think we don't need this instance any more.


- Alexander Rukletsov


On Aug. 3, 2015, 6:09 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 3, 2015, 6:09 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske 


 On Aug. 4, 2015, 2:39 a.m., Alexander Rukletsov wrote:
  src/master/master.hpp, line 916
  https://reviews.apache.org/r/36913/diff/6/?file=1027735#file1027735line916
 
  I think we don't need this instance any more.

I think so, too.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94024
---


On Aug. 3, 2015, 11:09 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 3, 2015, 11:09 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94033
---



src/master/master.hpp (line 764)
https://reviews.apache.org/r/36913/#comment148537

Let's add something like: Operates inside the Master actor.


- Alexander Rukletsov


On Aug. 4, 2015, 9:52 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 9:52 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94037
---



src/master/master.hpp (line 766)
https://reviews.apache.org/r/36913/#comment148540

See my previous review. This is correct syntax IMHO.


- Bernd Mathiske


On Aug. 4, 2015, 2:52 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 2:52 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94133
---


Patch looks great!

Reviews applied: [36913]

All tests passed.

- Mesos ReviewBot


On Aug. 4, 2015, 2:32 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 4, 2015, 2:32 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review93975
---


Patch looks great!

Reviews applied: [36913]

All tests passed.

- Mesos ReviewBot


On Aug. 3, 2015, 6:09 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated Aug. 3, 2015, 6:09 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
   src/master/quota_handler.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-03 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Aug. 3, 2015, 6:09 p.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Changes
---

Moved QuotaHandler declaration into master.hpp in order to avoid cyclic 
dependency (similar to http class).


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-03 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Aug. 3, 2015, 11:55 a.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Changes
---

Added dummy quota_handler.cpp in order facilitate colaborative work.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
  src/master/quota_handler.hpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-03 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review93890
---



src/master/http.cpp (lines 517 - 521)
https://reviews.apache.org/r/36913/#comment148310

A minor nit: let's sort them as they appear in the RFC: GET POST PUT DELETE


- Alexander Rukletsov


On July 29, 2015, 8:48 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated July 29, 2015, 8:48 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b 
   src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
   src/master/quota_handler.hpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated July 29, 2015, 5:07 p.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Changes
---

Addressed comment.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b 
  src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
  src/master/quota_handler.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review93456
---



src/master/http.cpp (line 524)
https://reviews.apache.org/r/36913/#comment147835

s/Method/method ?


- Alexander Rukletsov


On July 29, 2015, 3:05 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated July 29, 2015, 3:05 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b 
   src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
   src/master/quota_handler.hpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review93530
---


Patch looks great!

Reviews applied: [36913]

All tests passed.

- Mesos ReviewBot


On July 29, 2015, 8:48 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36913/
 ---
 
 (Updated July 29, 2015, 8:48 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
 
 
 Bugs: MESOS-3073
 https://issues.apache.org/jira/browse/MESOS-3073
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added /quota HTTP Endpoint for Quota handling.
 
 
 Diffs
 -
 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
   src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b 
   src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
   src/master/quota_handler.hpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36913/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated July 29, 2015, 3:04 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Addressed comments.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b 
  src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
  src/master/quota_handler.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad