Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
---

(Updated March 7, 2018, 1:44 p.m.)


Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
Joseph Wu.


Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description (updated)
---

The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.

This also simplifies the `GET_BYPRODUCTS` function to set `BYPRODUCTS`
to an empty string when the generator is not Ninja, as it should be a
no-op for other generators.


Diffs (updated)
-

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 


Diff: https://reviews.apache.org/r/65720/diff/4/

Changes: https://reviews.apache.org/r/65720/diff/3-4/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
---

(Updated March 7, 2018, 12:54 p.m.)


Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
Joseph Wu.


Changes
---

Updated per review comments.


Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description
---

The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.


Diffs (updated)
-

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 


Diff: https://reviews.apache.org/r/65720/diff/3/

Changes: https://reviews.apache.org/r/65720/diff/2-3/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Andrew Schwartzmeyer]

> On March 7, 2018, 4:21 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 158-160 (original), 158-165 (patched)
> > 
> >
> > The paths for vs look more specific to me, so I wonder whether it maes 
> > sense to either turn the logic around (`if (VC) ... else ()`), or use 
> > `elseif` instead of a catch all `else`.
> > 
> > Here and below.

I'm not following. There are only two supported generators on Windows: VS and 
Ninja. Flipping this `if` around is just style that doesn't change anything. 
(NOTE: This is all in the WIN32 block.)


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198783
---


On March 6, 2018, 12:05 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> ---
> 
> (Updated March 6, 2018, 12:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198783
---




3rdparty/CMakeLists.txt
Lines 158-160 (original), 158-165 (patched)


The paths for vs look more specific to me, so I wonder whether it maes 
sense to either turn the logic around (`if (VC) ... else ()`), or use `elseif` 
instead of a catch all `else`.

Here and below.



3rdparty/CMakeLists.txt
Lines 229 (patched)


Unneeded empty line here?



3rdparty/CMakeLists.txt
Lines 230-239 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 319-331 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 396-399 (original), 421-430 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 441-444 (original), 472-481 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 557-566 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 648-660 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 725-733 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 796-804 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 872-881 (patched)


Ditto.



3rdparty/CMakeLists.txt
Lines 941-949 (patched)


Ditto.


- Benjamin Bannier


On March 6, 2018, 9:05 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> ---
> 
> (Updated March 6, 2018, 9:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198750
---



Patch looks great!

Reviews applied: [65719, 65721, 65720]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 6, 2018, 8:05 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> ---
> 
> (Updated March 6, 2018, 8:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198748
---


Ship it!




Ship It!

- Akash Gupta


On March 6, 2018, 8:05 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> ---
> 
> (Updated March 6, 2018, 8:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198732
---



PASS: Mesos patch 65720 was successfully built and tested.

Reviews applied: `['65719', '65721', '65720']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65720

- Mesos Reviewbot Windows


On March 6, 2018, 12:05 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> ---
> 
> (Updated March 6, 2018, 12:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
---

(Updated March 6, 2018, 12:05 p.m.)


Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
Joseph Wu.


Changes
---

Set `IMPORTED_LOCATION` for Ninja on Windows explicitly rather than with a hack.


Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description (updated)
---

The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.


Diffs (updated)
-

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 


Diff: https://reviews.apache.org/r/65720/diff/2/

Changes: https://reviews.apache.org/r/65720/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Andrew Schwartzmeyer]

> On Feb. 21, 2018, 5:18 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 169-182 (patched)
> > 
> >
> > Could we generalize this a little bit to whether we are using a multi- 
> > or single config generator (e.g., with `GENERATOR_IS_MULTI_CONFIG` or 
> > similar). This should get us some way to address MESOS-7943.

Possibly... I'd need to see how similar the other multi-config generators are 
to Visual Studio with respect to output build paths.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review197846
---


On Feb. 20, 2018, 11:32 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> ---
> 
> (Updated Feb. 20, 2018, 11:32 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), so we replace this
> assumption with a pair of variables `CONFIG_DEBGUG` and
> `CONFIG_RELEASE` which are correct for each generator. This is
> somewhat ugly, but it's the cost of supporting multiple toolsets.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review197846
---




3rdparty/CMakeLists.txt
Lines 169-182 (patched)


Could we generalize this a little bit to whether we are using a multi- or 
single config generator (e.g., with `GENERATOR_IS_MULTI_CONFIG` or similar). 
This should get us some way to address MESOS-7943.


- Benjamin Bannier


On Feb. 20, 2018, 8:32 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> ---
> 
> (Updated Feb. 20, 2018, 8:32 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), so we replace this
> assumption with a pair of variables `CONFIG_DEBGUG` and
> `CONFIG_RELEASE` which are correct for each generator. This is
> somewhat ugly, but it's the cost of supporting multiple toolsets.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
---

Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
Joseph Wu.


Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description
---

The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), so we replace this
assumption with a pair of variables `CONFIG_DEBGUG` and
`CONFIG_RELEASE` which are correct for each generator. This is
somewhat ugly, but it's the cost of supporting multiple toolsets.


Diffs
-

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 


Diff: https://reviews.apache.org/r/65720/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer