Re: Review Request 46814: Refactored FlagsBase::load().

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46814/
---

(Updated April 29, 2016, 6:43 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

fixed continuation bug.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Made this function more readable. The error strings are still kept the
same as the previous code.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46814/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46813: Update distribute to setuptools.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/
---

(Updated April 29, 2016, 5:05 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5244
https://issues.apache.org/jira/browse/MESOS-5244


Repository: mesos


Description
---

Update distribute to setuptools.


Diffs (updated)
-

  3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
  3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
  3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
  3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
  LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
  configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
  mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
  src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
  src/examples/python/test-containerizer.in 
b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
  src/examples/python/test-executor.in 6be0ad2d339ff43d074e9688978af1ddf956803c 
  src/examples/python/test-framework.in 
59bab82962c5846c6be288f3d392986e146e9da6 
  support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 

Diff: https://reviews.apache.org/r/46813/diff/


Testing
---

make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1

NOTE: I tested on my RHEL 6.6 and failed, because the package 
pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think it's 
ok for this patch.


Thanks,

Zhiwei Chen

Re: Review Request 46813: Update distribute to setuptools.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/
---

(Updated April 29, 2016, 5:13 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5244
https://issues.apache.org/jira/browse/MESOS-5244


Repository: mesos


Description
---

Update distribute to setuptools.


Diffs
-

  3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
  3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
  3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
  3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
  LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
  configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
  mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
  src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
  src/examples/python/test-containerizer.in 
b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
  src/examples/python/test-executor.in 6be0ad2d339ff43d074e9688978af1ddf956803c 
  src/examples/python/test-framework.in 
59bab82962c5846c6be288f3d392986e146e9da6 
  support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 

Diff: https://reviews.apache.org/r/46813/diff/


Testing (updated)
---

make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5.

NOTE: I tested on my RHEL 6.6 and failed, because the package 
pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think it's 
ok for this patch.


Thanks,

Zhiwei Chen

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131066
---



It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we 
could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do you 
want to do it here or follow up with another patch?

- Alexander Rukletsov


On April 29, 2016, 9:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> ---
> 
> (Updated April 29, 2016, 9:13 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed some unused header includes.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77 
> 
> Diff: https://reviews.apache.org/r/46827/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46828: Fixed newline for `--log_dir` flag usage message.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46828/#review131067
---


Ship it!




Ship It!

- Alexander Rukletsov


On April 29, 2016, 9:30 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46828/
> ---
> 
> (Updated April 29, 2016, 9:30 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/logging/flags.cpp f64ad5eebc4a14ee07796b1a1c273397bdf46cdd 
> 
> Diff: https://reviews.apache.org/r/46828/diff/
> 
> 
> Testing
> ---
> 
> Visual inspection
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46828: Fixed newline for `--log_dir` flag usage message.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46828/
---

(Updated April 29, 2016, 9:30 a.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/logging/flags.cpp f64ad5eebc4a14ee07796b1a1c273397bdf46cdd 

Diff: https://reviews.apache.org/r/46828/diff/


Testing
---

Visual inspection


Thanks,

Neil Conway

Re: Review Request 46736: Added authorization description to quota endpoint help.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/
---

(Updated April 29, 2016, 9:40 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.


Repository: mesos


Description
---

see summary.


Diffs (updated)
-

  docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6 
  src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 

Diff: https://reviews.apache.org/r/46736/diff/


Testing
---

make check (OSX) and re-generated endpoint documentation.


Thanks,

Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/#review131064
---


Ship it!




Ship It!

- Alexander Rojas


On April 27, 2016, 5:33 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46735/
> ---
> 
> (Updated April 27, 2016, 5:33 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When adding authorization to endpoint we should also
> document the authorization behavior in the HELP (and
> thereby also in the endpoint documentation).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 3f859803f3096d3161fffb6485ce1ce3cb6b04bc 
>   3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f 
>   3rdparty/libprocess/src/logging.cpp 
> 1cb0f4a1608e15e28d49793d162b62f326cb31df 
> 
> Diff: https://reviews.apache.org/r/46735/diff/
> 
> 
> Testing
> ---
> 
> testing with quota endpoint added (see next review).
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 46823: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46823/
---

Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46823/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Review Request 46821: Avoided slicing of flags in subprocess.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46821/
---

Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While `FlagsBase` internally stores just maps of names and
flags, the functions stored in a `Flag` rely on the original type of
the `Flags` containing them (e.g., we perform dynamic casts to detect
their types).

Since `Option` stores `T` as a value (i.e., it cannot contain
reference types) any interface taking an `Option` cannot rely on
polymorphic behavior of `T`. To make use of polymorphism we should
instead store e.g., a pointer type to avoid slicing.

Here we change `Flags` arguments of `subprocess` to allow preserving
the original type so `Flag` function can work reliably.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6ce1a827e36e0c65985e3928c89f51561fdd70cd 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46821/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46730: Cleanup syscalls logic.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/
---

(Updated April 29, 2016, 8:11 a.m.)


Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.


Bugs: MESOS-5263
https://issues.apache.org/jira/browse/MESOS-5263


Repository: mesos


Description
---

Used `` and removed uncessary condition complie.


Diffs (updated)
-

  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
  src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 

Diff: https://reviews.apache.org/r/46730/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review131062
---




src/master/http.cpp (line 868)


Could you make this capture list explicit (`[this, request]`)?



src/master/http.cpp (line 874)


Not your pattern and a general problem here, but this does not return any 
useful response should we fail to get an answer from the `authorizer` :(



src/tests/master_authorization_tests.cpp (line 1024)


This looks very similar to the `SlaveEndpointTest` suite ;) Should we just 
also make this parameterized from the start?



src/tests/master_authorization_tests.cpp (line 1027)


`s/agent/master/`



src/tests/master_authorization_tests.cpp (lines 1054 - 1057)


Once you have parameterized the fixture on the endpoint you should 
`s/Slave/Master/`. Before that it doesn't really fit.



src/tests/master_authorization_tests.cpp (line 1067)


`s/agent/master/`


- Benjamin Bannier


On April 28, 2016, 4:57 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> ---
> 
> (Updated April 28, 2016, 4:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
> 
> Diff: https://reviews.apache.org/r/46784/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46763: Removed unused include in quota_handler.cpp.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46763/
---

(Updated April 29, 2016, 9:09 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Updated summary, description, and testing done sections.


Summary (updated)
-

Removed unused include in quota_handler.cpp.


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/master/quota_handler.cpp cfa38f9333f17e816d1470c228591504288791a4 

Diff: https://reviews.apache.org/r/46763/diff/


Testing (updated)
---

On Mac OS 10.10.4:
`make check`


Thanks,

Guangya Liu

Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated libprocess tests to work with the new `flag.load()` signature.


Diffs
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated April 29, 2016, 6:47 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

add a new dependency.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated mesos to work with new `flags.load()` signature.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46813: Update distribute to setuptools.

[Zhiwei Chen]

> On April 29, 2016, 2:08 p.m., haosdent huang wrote:
> > I saw we order the dependencies by alphabetically, may you update it to 
> > make sure this?

Thanks, fixed.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/#review131053
---


On April 29, 2016, 4:36 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46813/
> ---
> 
> (Updated April 29, 2016, 4:36 p.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5244
> https://issues.apache.org/jira/browse/MESOS-5244
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update distribute to setuptools.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
>   3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
>   3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
>   LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/examples/python/test-containerizer.in 
> b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
>   src/examples/python/test-executor.in 
> 6be0ad2d339ff43d074e9688978af1ddf956803c 
>   src/examples/python/test-framework.in 
> 59bab82962c5846c6be288f3d392986e146e9da6 
>   support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 
> 
> Diff: https://reviews.apache.org/r/46813/diff/
> 
> 
> Testing
> ---
> 
> make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1
> 
> NOTE: I tested on my RHEL 6.6 and failed, because the package 
> pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
> ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think 
> it's ok for this patch.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46763: Removed unused include in quota_handler.cpp.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46763/#review131063
---


Ship it!




Ship It!

- Alexander Rukletsov


On April 29, 2016, 9:09 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46763/
> ---
> 
> (Updated April 29, 2016, 9:09 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp cfa38f9333f17e816d1470c228591504288791a4 
> 
> Diff: https://reviews.apache.org/r/46763/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `make check`
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 46828: Fixed newline for `--log_dir` flag usage message.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46828/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Fixed newline for `--log_dir` flag usage message.


Diffs
-

  src/logging/flags.cpp f64ad5eebc4a14ee07796b1a1c273397bdf46cdd 

Diff: https://reviews.apache.org/r/46828/diff/


Testing
---

Visual inspection


Thanks,

Neil Conway

Re: Review Request 46813: Update distribute to setuptools.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/#review131053
---



I saw we order the dependencies by alphabetically, may you update it to make 
sure this?

- haosdent huang


On April 29, 2016, 5:09 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46813/
> ---
> 
> (Updated April 29, 2016, 5:09 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, and Joseph Wu.
> 
> 
> Bugs: MESOS-5244
> https://issues.apache.org/jira/browse/MESOS-5244
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update distribute to setuptools.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
>   3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
>   3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
>   LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/examples/python/test-containerizer.in 
> b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
>   src/examples/python/test-executor.in 
> 6be0ad2d339ff43d074e9688978af1ddf956803c 
>   src/examples/python/test-framework.in 
> 59bab82962c5846c6be288f3d392986e146e9da6 
>   support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 
> 
> Diff: https://reviews.apache.org/r/46813/diff/
> 
> 
> Testing
> ---
> 
> make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1
> 
> NOTE: I tested on my RHEL 6.6 and failed, because the package 
> pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
> ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think 
> it's ok for this patch.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Review Request 46827: Replaced CHECK with CHECK_READY.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Also removed some unused header includes.


Diffs
-

  src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77 

Diff: https://reviews.apache.org/r/46827/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 46826: Removed unused header include in libprocess.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46826/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Removed unused header include in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/future.hpp 
9a335d199da2e242ba732ae392e66f86c07cd65d 

Diff: https://reviews.apache.org/r/46826/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 46825: Fully-typed all FlagsBase::add overloads.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 
  3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier

Review Request 46822: Avoided slicing of flags in subprocess.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46822/
---

Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While `FlagsBase` internally stores just maps of names and
flags, the functions stored in a `Flag` rely on the original type of
the `Flags` containing them (e.g., we perform dynamic casts to detect
their types).

Since `Option` stores `T` as a value (i.e., it cannot contain
reference types) any interface taking an `Option` cannot rely on
polymorphic behavior of `T`. To make use of polymorphism we should
instead store e.g., a pointer type to avoid slicing.

Here we change `Flags` arguments of `subprocess` to allow preserving
the original type so `Flag` function can work reliably.


Diffs
-

  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
  src/slave/containerizer/mesos/containerizer.cpp 
8d538954d6e1f13e833d75c2eaa37e700278ee0c 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
ef0bc1092d761804ca6bd73016c0f3dd23719257 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
89bb2958a41dffe4ade9c2492b9a7412f90a432d 
  src/slave/containerizer/mesos/linux_launcher.cpp 
5028854fa003615f158120e030866b7ec4402b66 
  src/tests/containerizer/launch_tests.cpp 
3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
  src/tests/containerizer/launcher.hpp c352634c4766d289706c7cc738677619d7d02ccd 

Diff: https://reviews.apache.org/r/46822/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

[Jan Schlicht]

> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote:
> > src/master/http.cpp, line 868
> > 
> >
> > Could you make this capture list explicit (`[this, request]`)?

The style guide recommends to prefer default capture by value, that's why I'm 
doing it here. The case here is different from the one in `slave/http.cpp`. 
There we explicitly captured by value to be sure not to capture `this`, because 
that would lead to problems there. We don't have this problem here, hence the 
default capture by value.


> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote:
> > src/master/http.cpp, line 874
> > 
> >
> > Not your pattern and a general problem here, but this does not return 
> > any useful response should we fail to get an answer from the `authorizer` :(

It would return a failed future. Don't know what libprocess does with that, by 
I would expect that it would create a "server error" response.


> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote:
> > src/tests/master_authorization_tests.cpp, line 1024
> > 
> >
> > This looks very similar to the `SlaveEndpointTest` suite ;) Should we 
> > just also make this parameterized from the start?

I would like to, but unfortunately a parameterized test in GTest needs at least 
two values, at this point we have only one. It doesn't compile with a single 
parameter.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review131062
---


On April 28, 2016, 4:57 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> ---
> 
> (Updated April 28, 2016, 4:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
> 
> Diff: https://reviews.apache.org/r/46784/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46792: Parameterized agent authorization tests by endpoint.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46792/#review131056
---




src/tests/slave_authorization_tests.cpp (line 65)


Any reason you couldn't make this just a constant? As this isn't externally 
visible I see e.g., not lifetime problems.



src/tests/slave_authorization_tests.cpp (lines 71 - 80)


I am not sure we want to document the behavior of certain tests with the 
fixture since the comment might go out of sync as tests are added/adjusted. 
Could you focus the discussion here on the behavior of the fixture and move 
test-specific notes and todos down to the tests?



src/tests/slave_authorization_tests.cpp (lines 148 - 150)


Please call out that you need to do this since googletest cannot compose 
both type and value parameterized tests out of the box.

The downside of doing this manually is that failures in `testCaseBody` will 
not mention the value of the "parameter" `endpoint`. Please update any checks 
and assertions in there to mention `endpoint` in case of failures.

Note that there's also the possibility to shoehorn values into types, see 
e.g., 
https://groups.google.com/d/msg/googletestframework/3d8H5J5Isnw/RtXYy12SCSgJ, 
but I am not sure this wouldn't be perceived as trying too hard.



src/tests/slave_authorization_tests.cpp (lines 198 - 200)


ditto.



src/tests/slave_authorization_tests.cpp (line 212)


This comment seems redundant since it trivially reiterates what the code 
below says.


- Benjamin Bannier


On April 28, 2016, 7:24 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46792/
> ---
> 
> (Updated April 28, 2016, 7:24 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, only '/flags' endpoint is being tested by the
> `SlaveAuthorizationTest` test fixture. However, the same
> tests can be applied to any endpoint that consults
> authorizer for GET requests.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_authorization_tests.cpp 
> d3ab0835c8d2464a65f382087d914412dc573b44 
> 
> Diff: https://reviews.apache.org/r/46792/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `make check`
> `GTEST_FILTER="*SlaveEndpointTest*:*SlaveAuthorizationTest*" 
> ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/#review131058
---



This target will not be removed until the term 'slave' is completely removed in 
the code, I'm ok to the change

- zhou xing


On 四月 29, 2016, 4:55 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46816/
> ---
> 
> (Updated 四月 29, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix the absolute symlink path issue of include/slave.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
> 
> Diff: https://reviews.apache.org/r/46816/diff/
> 
> 
> Testing
> ---
> 
> Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, 
> should use relative path.
> 
> I am not sure if this copy-template-and-create-symlink should be removed of 
> not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily 
> build.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/#review131059
---



Patch looks great!

Reviews applied: [46816]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 4:55 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46816/
> ---
> 
> (Updated April 29, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix the absolute symlink path issue of include/slave.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
> 
> Diff: https://reviews.apache.org/r/46816/diff/
> 
> 
> Testing
> ---
> 
> Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, 
> should use relative path.
> 
> I am not sure if this copy-template-and-create-symlink should be removed of 
> not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily 
> build.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46826: Removed unused header include in libprocess.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46826/#review131068
---


Ship it!




Ship It!

- Alexander Rukletsov


On April 29, 2016, 9:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46826/
> ---
> 
> (Updated April 29, 2016, 9:13 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused header include in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 9a335d199da2e242ba732ae392e66f86c07cd65d 
> 
> Diff: https://reviews.apache.org/r/46826/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46796: Synced endpoint documentation by running generation script.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/#review131073
---


Ship it!




Ship It!

- haosdent huang


On April 29, 2016, 9:57 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46796/
> ---
> 
> (Updated April 29, 2016, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> https://reviews.apache.org/r/46472/ introduced some manual changed to
> the endpoint documentation. This review syncs the actual endpoint
> documentation with the generated one.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
>   docs/endpoints/monitor/statistics.json.md 
> 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 
> 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
> 
> Diff: https://reviews.apache.org/r/46796/diff/
> 
> 
> Testing
> ---
> 
> make check + viewed endpoint docs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/#review131069
---


Fix it, then Ship it!





3rdparty/libprocess/src/process.cpp (line 976)


2 spaces before 'The'



3rdparty/libprocess/src/process.cpp (line 979)


the second 'the same group' feels a bit redundant, but not a real issue


- Joerg Schad


On April 28, 2016, 11:58 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46806/
> ---
> 
> (Updated April 28, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-5304
> https://issues.apache.org/jira/browse/MESOS-5304
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves `metrics::initialize` below the creation of the `help` process.
> 
> Adds a comment block to explain the ordering of process creation in 
> `process::initialize`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46806/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also double-checked that `/help/metrics/snapshot` shows up on both master and 
> agent.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 46813: Update distribute to setuptools.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/#review131075
---


Ship it!




Having applied this patch to the master branch, I ran builds and tests for 
CentOS 6, CentOS7, Debian 8, Fedora 23, Ubuntu 12/14/15. (With and without SLL 
enabled.) In each case, building with setuptools instead of distribute worked 
equally well. I also tried Ubuntu 16. In this case building works with 
setuptools, but not with distribute. I'd say let's move on and switch to 
setuptools now.

- Bernd Mathiske


On April 29, 2016, 2:13 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46813/
> ---
> 
> (Updated April 29, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5244
> https://issues.apache.org/jira/browse/MESOS-5244
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update distribute to setuptools.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
>   3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
>   3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
>   LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/examples/python/test-containerizer.in 
> b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
>   src/examples/python/test-executor.in 
> 6be0ad2d339ff43d074e9688978af1ddf956803c 
>   src/examples/python/test-framework.in 
> 59bab82962c5846c6be288f3d392986e146e9da6 
>   support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 
> 
> Diff: https://reviews.apache.org/r/46813/diff/
> 
> 
> Testing
> ---
> 
> make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5.
> 
> NOTE: I tested on my RHEL 6.6 and failed, because the package 
> pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
> ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think 
> it's ok for this patch.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

[Benjamin Bannier]

> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote:
> > src/master/http.cpp, line 868
> > 
> >
> > Could you make this capture list explicit (`[this, request]`)?
> 
> Jan Schlicht wrote:
> The style guide recommends to prefer default capture by value, that's why 
> I'm doing it here. The case here is different from the one in 
> `slave/http.cpp`. There we explicitly captured by value to be sure not to 
> capture `this`, because that would lead to problems there. We don't have this 
> problem here, hence the default capture by value.
> 
> Benjamin Bannier wrote:
> Note that `[this, request]` *does* capture by value. I am just asking you 
> to be explicit about what you capture instead of pulling in everything from 
> the current scope.
> 
> Jan Schlicht wrote:
> As does `[=]`, and that's preferred by the style guide.

Hm, I read that part of the style guide differently, but well. I believe we 
value explicit over implicit, but even in this file there seems to be no 
preference either way, so feel free to drop this issue.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review131062
---


On April 29, 2016, 11:49 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> ---
> 
> (Updated April 29, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
> 
> Diff: https://reviews.apache.org/r/46784/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated April 29, 2016, 1:12 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Fixup.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

[Guangya Liu]

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > 
> >
> > How to handle those command parameters contains "," here? For example, 
> > if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
> Yeah, and if the user wants "echo 'hello world'"? I'm fine with 
> consolidating command and arguments flag, but let's make sure we parse it 
> correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", 
> "arg2", ...]`; we can leverage our JSON parser for this, I believe 
> `tockenize()` is not enough. Also, I would like us manually test various 
> inputs and capture them in the testing done section. We may later want to 
> automate these tests in a staging cluster.
> 
> Guangya Liu wrote:
> Yes, I will test more cases. 
> 
> @haosdent, for your case, you should run the command as 
> `--command="cat,/etc/passwd,/etc/passwd"`
> 
> @Alexr, does the strings::tokenize(command.get(), ",") enough? Why need 
> JSON parser?
> 
> Guangya Liu wrote:
> @alexr, one question for your comments above:
> 
> `I.e. ["command", "arg1", "arg2", ...]; we can leverage our JSON parser 
> for this`
> 
> Do you mean using JSON parser parse the `["command", "arg1", "arg2", 
> ...]`? I think that the JSON does not support such format. What about enable 
> `command` flag set the following JSON:
> 
> {
> "command" : "cmd",
> "args": "["arg1", "arg2", "arg3,arg3"]"
> }

Alex, any comments for this? I was blocked here and want to get some comments 
from you. Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126690
---


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos 

Re: Review Request 46796: Synced endpoint documentation by running generation script.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/
---

(Updated April 29, 2016, 9:57 a.m.)


Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and 
Vinod Kone.


Repository: mesos


Description (updated)
---

https://reviews.apache.org/r/46472/ introduced some manual changed to
the endpoint documentation. This review syncs the actual endpoint
documentation with the generated one.


Diffs (updated)
-

  docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
  docs/endpoints/monitor/statistics.json.md 
1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 

Diff: https://reviews.apache.org/r/46796/diff/


Testing (updated)
---

make check + viewed endpoint docs


Thanks,

Joerg Schad

Re: Review Request 46826: Removed unused header include in libprocess.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46826/
---

(Updated April 29, 2016, 9:57 a.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/future.hpp 
9a335d199da2e242ba732ae392e66f86c07cd65d 

Diff: https://reviews.apache.org/r/46826/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 46796: Synced endpoint documentation by running generation script.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/
---

(Updated April 29, 2016, 9:57 a.m.)


Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and 
Vinod Kone.


Repository: mesos


Description
---

https://reviews.apache.org/r/46472/ introduced some manual changed to
the endpoint documentation. This review syncs the actual endpoint
documentation with the generated one.


Diffs
-

  docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
  docs/endpoints/monitor/statistics.json.md 
1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 

Diff: https://reviews.apache.org/r/46796/diff/


Testing
---

make check + viewed endpoint docs


Thanks,

Joerg Schad

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 四月 29, 2016, 9:56 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
---

Rebase


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
53a759ce0ebea87cc564a22cb2d34e54870f782b 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

[Neil Conway]

> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote:
> > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we 
> > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do 
> > you want to do it here or follow up with another patch?

Seems reasonable to me, but I'd prefer to do this as a separate patch.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131066
---


On April 29, 2016, 9:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> ---
> 
> (Updated April 29, 2016, 9:13 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed some unused header includes.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77 
> 
> Diff: https://reviews.apache.org/r/46827/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46813: Update distribute to setuptools.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/#review131078
---



Patch looks great!

Reviews applied: [46813]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:13 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46813/
> ---
> 
> (Updated April 29, 2016, 9:13 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5244
> https://issues.apache.org/jira/browse/MESOS-5244
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update distribute to setuptools.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
>   3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
>   3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
>   LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/examples/python/test-containerizer.in 
> b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
>   src/examples/python/test-executor.in 
> 6be0ad2d339ff43d074e9688978af1ddf956803c 
>   src/examples/python/test-framework.in 
> 59bab82962c5846c6be288f3d392986e146e9da6 
>   support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 
> 
> Diff: https://reviews.apache.org/r/46813/diff/
> 
> 
> Testing
> ---
> 
> make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5.
> 
> NOTE: I tested on my RHEL 6.6 and failed, because the package 
> pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
> ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think 
> it's ok for this patch.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131077
---




src/linux/cgroups.cpp 


May you revert the changes in `cgroups.cpp` as well, we could do this in a 
sperate patch. In additional, we need update the `Summary` and `Description` to 
make them more excactly.


- haosdent huang


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> ---
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
> https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `` and removed uncessary condition complie.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

[Benjamin Bannier]

> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote:
> > src/master/http.cpp, line 868
> > 
> >
> > Could you make this capture list explicit (`[this, request]`)?
> 
> Jan Schlicht wrote:
> The style guide recommends to prefer default capture by value, that's why 
> I'm doing it here. The case here is different from the one in 
> `slave/http.cpp`. There we explicitly captured by value to be sure not to 
> capture `this`, because that would lead to problems there. We don't have this 
> problem here, hence the default capture by value.

Note that `[this, request]` *does* capture by value. I am just asking you to be 
explicit about what you capture instead of pulling in everything from the 
current scope.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review131062
---


On April 29, 2016, 11:49 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> ---
> 
> (Updated April 29, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
> 
> Diff: https://reviews.apache.org/r/46784/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131070
---



Patch looks great!

Reviews applied: [46730]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> ---
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
> https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `` and removed uncessary condition complie.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 46832: Fixed the CMake build.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46832/
---

Review request for mesos and Bernd Mathiske.


Repository: mesos


Description
---

CMake builds failed to compile under Linux because of a missing include.
This was due to a typo in 'src/CMakeLists.txt', resulting in
'state.pb.h' not being created.


Diffs
-

  src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 

Diff: https://reviews.apache.org/r/46832/diff/


Testing
---

mkdir build && cd build && cmake .. && make (with Fedora 23)


Thanks,

Jan Schlicht

Re: Review Request 46730: Cleanup syscalls logic.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/
---

(Updated April 29, 2016, 1:03 p.m.)


Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.


Bugs: MESOS-5263
https://issues.apache.org/jira/browse/MESOS-5263


Repository: mesos


Description
---

Used `` and removed uncessary condition complie.


Diffs (updated)
-

  src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 

Diff: https://reviews.apache.org/r/46730/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131084
---



Patch looks great!

Reviews applied: [46826, 46827]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> ---
> 
> (Updated April 29, 2016, 9:13 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed some unused header includes.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77 
> 
> Diff: https://reviews.apache.org/r/46827/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46735: Added support for Authorization information to HELP.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/#review131090
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/help.hpp (line 47)


I might say "authorization requirements and granularity".


- Neil Conway


On April 27, 2016, 3:33 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46735/
> ---
> 
> (Updated April 27, 2016, 3:33 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When adding authorization to endpoint we should also
> document the authorization behavior in the HELP (and
> thereby also in the endpoint documentation).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 3f859803f3096d3161fffb6485ce1ce3cb6b04bc 
>   3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f 
>   3rdparty/libprocess/src/logging.cpp 
> 1cb0f4a1608e15e28d49793d162b62f326cb31df 
> 
> Diff: https://reviews.apache.org/r/46735/diff/
> 
> 
> Testing
> ---
> 
> testing with quota endpoint added (see next review).
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review131093
---



Patch looks great!

Reviews applied: [46821, 46822, 46823, 46824, 46825]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated April 29, 2016, 9:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 66e16abe914e2a1ee7599bab857ff478b7ec20dc 
>   3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

[Tomasz Janiszewski]

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > Could you also update the testing section? How did you ensure this compiles 
> > on the affected architectures?

What do you mean by "testing section"? Unfortunatelly I've only tested it on 
ARM and x86_64


> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > src/linux/ns.hpp, lines 161-162
> > 
> >
> > This looks like a similar change but it would be great to split it into 
> > a separate patch. It's not immediately obvious to me why `SYS_setns` is 
> > being changed in favor of `__NR_setns`. Can you add some some background 
> > information in the review description?
> 
> haosdent huang wrote:
> +1 For only change `__NR_pivot_root` and update `__NR_setns` in a 
> separate patch. I think why @janisz update to `__NR_setns` here is because he 
> want to keep consistent as he mentioned above.

`SYS_setns` comes from glibc I (and in fact it's map for `__NR_setns`) becouse 
I see condition for old glibc and thought it could be replaced with kernel 
macro. Reverted my change


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
---


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> ---
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
> https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `` and removed uncessary condition complie.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46832: Fixed the CMake build.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46832/#review131091
---


Ship it!




Ship It!

- Bernd Mathiske


On April 29, 2016, 6:31 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46832/
> ---
> 
> (Updated April 29, 2016, 6:31 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake builds failed to compile under Linux because of a missing include.
> This was due to a typo in 'src/CMakeLists.txt', resulting in
> 'state.pb.h' not being created.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 
> 
> Diff: https://reviews.apache.org/r/46832/diff/
> 
> 
> Testing
> ---
> 
> mkdir build && cd build && cmake .. && make (with Fedora 23)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46735: Added support for Authorization information to HELP.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
---

(Updated April 29, 2016, 2:25 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Repository: mesos


Description (updated)
---

When adding authorization to endpoint we should also
 document the authorization behavior in the HELP (and
 thereby also in the endpoint documentaion).


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
3f859803f3096d3161fffb6485ce1ce3cb6b04bc 
  3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f 
  3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df 

Diff: https://reviews.apache.org/r/46735/diff/


Testing
---

testing with quota endpoint added (see next review).


Thanks,

Joerg Schad

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review131104
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:56 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated April 29, 2016, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 53a759ce0ebea87cc564a22cb2d34e54870f782b 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46735: Added support for Authorization information to HELP.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
---

(Updated April 29, 2016, 2:24 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Repository: mesos


Description
---

When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentation).


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
3f859803f3096d3161fffb6485ce1ce3cb6b04bc 
  3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f 
  3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df 
  CHANGELOG 0c5987779e5f0e2cb416dfe885f7ba836e3958eb 
  docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
  include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
  src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f 
  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
  src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
  src/slave/slave.hpp b72438033708de473046d321c493d9fbcd7a9b43 
  src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011 
  src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2 
  src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
  src/tests/slave_authorization_tests.cpp 
d3ab0835c8d2464a65f382087d914412dc573b44 

Diff: https://reviews.apache.org/r/46735/diff/


Testing
---

testing with quota endpoint added (see next review).


Thanks,

Joerg Schad

Re: Review Request 46736: Added authorization description to quota endpoint help.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/
---

(Updated April 29, 2016, 2:26 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.


Repository: mesos


Description
---

see summary.


Diffs (updated)
-

  docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6 
  src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 

Diff: https://reviews.apache.org/r/46736/diff/


Testing
---

make check (OSX) and re-generated endpoint documentation.


Thanks,

Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
---

(Updated April 29, 2016, 2:25 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Repository: mesos


Description (updated)
---

When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentation).


Diffs
-

  3rdparty/libprocess/include/process/help.hpp 
3f859803f3096d3161fffb6485ce1ce3cb6b04bc 
  3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f 
  3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df 

Diff: https://reviews.apache.org/r/46735/diff/


Testing
---

testing with quota endpoint added (see next review).


Thanks,

Joerg Schad

Re: Review Request 46736: Added authorization description to quota endpoint help.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review131100
---


Ship it!




Ship It!

- Neil Conway


On April 29, 2016, 2:26 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> ---
> 
> (Updated April 29, 2016, 2:26 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
> 
> Diff: https://reviews.apache.org/r/46736/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX) and re-generated endpoint documentation.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 46501: Updated authorization.md to reflect current changes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46501/#review131092
---




docs/authorization.md (line 8)


First sentence: I would instead say something like, "In Mesos, the 
authorization subsystem allows the operator to configure the actions that 
certain principals are allowed to perform. For example, the operator can use 
authorization to ensure that principal `foo` can only register frameworks in 
role `bar`, and no other principals can register frameworks in any role."

I'd probably add a newline before "A reference"

You might want to clarify that (a) ACLs are a property of the local 
authorizer only; other authorizers might use different concepts for deciding 
whether a principal is allowed to perform an action, (b) the remainder of the 
document (?) is specific to the local authorizer; other authorizors might 
behave differently.



docs/authorization.md (line 12)


"through a"

"configured with"



docs/authorization.md (line 27)


Did you remove the "Role vs. Principal" discussion deliberately? If so, why?



docs/authorization.md 


The previous text had an example for every ACL action. I think giving an 
example for every ACL action helps the reader understand how to use ACLs more 
concretely.



docs/authorization.md (line 64)


"The order in which the rules are defined is important."

"the acls" => "the ACLs"



docs/authorization.md (line 82)


"ACLs"



docs/authorization.md (line 104)


You might consider presenting this information using a Markdown table, 
rather than a list where every element of the list has the same format.



docs/authorization.md (line 105)


"ACLs entry" is imprecise; I would say it is the thing you're describing is 
the "action", and a single ACL consists of the triple (subject, action, object).



docs/authorization.md (line 114)


For consistency, this needs a newline (``).



docs/authorization.md (line 160)


The actual signature is `process::Future authorized(const 
authorization::Request& request)`, right?

Also, why are we using three back-ticks to denote inline code? AFAIK we 
should use a single back-tick for that; three back-ticks are for code blocks.

I would avoid saying "authorized() should return `false`..." -- 
authorized() returns a future. I'd say something like "authorized() returns a 
future that indicates the result of the (asynchronous) authorization operation. 
If the future is set to `true`, the request was authorized successfully; if it 
was set to `false`, ..."


- Neil Conway


On April 28, 2016, 9:56 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46501/
> ---
> 
> (Updated April 28, 2016, 9:56 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Neil Conway.
> 
> 
> Bugs: MESOS-4785
> https://issues.apache.org/jira/browse/MESOS-4785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The API of the authorization has been changing constantly over the
> last few versions. This patch attempts to update the documentation to
> the those changes into account.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
> 
> Diff: https://reviews.apache.org/r/46501/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 46792: Parameterized agent authorization tests by endpoint.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46792/#review131098
---




src/tests/slave_authorization_tests.cpp (lines 82 - 87)


We only really need the MockAuthorizer in the positive authz test, to see 
that the right request was used. In all of the other tests we know that 
implicitly, because we receive a `Forbidden`. How about we enhance 
`MockAuthorizer` to act as a proxy for the underlying authorizer, similar to 
how it's done for `MockDocker`? We would then only need a single test fixture 
because the whole pipeline as well as the correct calls to the authorizer could 
be cover in its test cases.


- Jan Schlicht


On April 28, 2016, 7:24 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46792/
> ---
> 
> (Updated April 28, 2016, 7:24 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, only '/flags' endpoint is being tested by the
> `SlaveAuthorizationTest` test fixture. However, the same
> tests can be applied to any endpoint that consults
> authorizer for GET requests.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_authorization_tests.cpp 
> d3ab0835c8d2464a65f382087d914412dc573b44 
> 
> Diff: https://reviews.apache.org/r/46792/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `make check`
> `GTEST_FILTER="*SlaveEndpointTest*:*SlaveAuthorizationTest*" 
> ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 46796: Synced endpoint documentation by running generation script.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/#review131119
---



Patch looks great!

Reviews applied: [46796]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:57 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46796/
> ---
> 
> (Updated April 29, 2016, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> https://reviews.apache.org/r/46472/ introduced some manual changed to
> the endpoint documentation. This review syncs the actual endpoint
> documentation with the generated one.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
>   docs/endpoints/monitor/statistics.json.md 
> 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 
> 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
> 
> Diff: https://reviews.apache.org/r/46796/diff/
> 
> 
> Testing
> ---
> 
> make check + viewed endpoint docs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/#review131120
---


Fix it, then Ship it!




Thanks Joseph! LGTM, modulo Joerg's comments and another small one below.


3rdparty/libprocess/src/process.cpp (line 989)


I'm guessing this refers to `new Route("/__processes__", None(), 
__processes__);`? I think it might be helpful to use a more obvious name. Or 
perhaps referencing the `process_route` name in a comment above the `Route()` 
statement would do the trick?


- Greg Mann


On April 28, 2016, 11:58 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46806/
> ---
> 
> (Updated April 28, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-5304
> https://issues.apache.org/jira/browse/MESOS-5304
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves `metrics::initialize` below the creation of the `help` process.
> 
> Adds a comment block to explain the ordering of process creation in 
> `process::initialize`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46806/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also double-checked that `/help/metrics/snapshot` shows up on both master and 
> agent.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

[Vinod Kone]

> On April 29, 2016, 7:27 p.m., Michael Park wrote:
> > (1) Just so I understand, is this a necessary introduction? or is it an 
> > improvement?
> > (2) In some parts, we access the `name.value` directly, and other times we 
> > use `stringify(name)`. From the implementation it looks like they yield the 
> > same result, but are there different semantic intentions behind the uses?

This is a necessary introduction for adding meta data to name (e.g., 
deprecation status).

I killed the output operator overload and used name.value everywhere to avoid 
confusion.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review131166
---


On April 29, 2016, 3:25 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> ---
> 
> (Updated April 29, 2016, 3:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review131242
---


Ship it!




Ship It!

- Greg Mann


On April 30, 2016, 1:56 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> ---
> 
> (Updated April 30, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46858/#review131233
---



Patch looks great!

Reviews applied: [46807, 46858]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 10:19 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46858/
> ---
> 
> (Updated April 29, 2016, 10:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ian Downes, and Timothy Chen.
> 
> 
> Bugs: MESOS-5239
> https://issues.apache.org/jira/browse/MESOS-5239
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In filesystem/linux isolator, we will need to make sure the mount that
> contains the agent's working directory is a shared mount in its own
> peer group so that cloning the host mount table (e.g., when launching
> a container with a new mount namespace) does not create an extra
> reference to the mounts under the agent's work_dir.
> 
> However, if the mount containing the agent's working directory is
> already a shared mount in its own peer group, we don't have to create
> another bind mount for the agent's working directory. This patch
> allows the filesystem/linux isolator to skip the bind mount if
> possible.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> a6e748ae777b6280f5dab0a6fec7305f931f2c22 
> 
> Diff: https://reviews.apache.org/r/46858/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 46621: Added alias support for flags.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/
---

(Updated April 30, 2016, 2 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

mpark's comments.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description (updated)
---

This lets a user to load a flag either by the original name or an
alias.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46621/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46814: Refactored FlagsBase::load().

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46814/
---

(Updated April 30, 2016, 1:59 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

mpark's comments.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Made this function more readable. The error strings are still kept the
same as the previous code.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46814/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/#review131238
---



Bad patch!

Reviews applied: [46863, 46669, 46624, 46623, 46622, 46621, 46814, 46620]

Failed command: ./support/apply-review.sh -n -r 46621

Error:
2016-04-30 02:32:01 URL:https://reviews.apache.org/r/46621/diff/raw/ 
[14455/14455] -> "46621.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp:498:  
Redundant blank line at the start of a code block should be deleted.  
[whitespace/blank_line] [2]
Total errors found: 1
Checking 2 files

Full log: https://builds.apache.org/job/mesos-reviewbot/12815/console

- Mesos ReviewBot


On April 30, 2016, 2:02 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46863/
> ---
> 
> (Updated April 30, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logic is now moved to Flag::load() keep the duplicate checking logic
> for names and aliases in one place.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46863/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
---

Review request for mesos and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46863/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated April 30, 2016, 2:01 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

mpark's comments.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review131239
---



Bad patch!

Reviews applied: [46670, 46815, 46818, 46669, 46624, 46623, 46622, 46621, 
46814, 46620]

Failed command: ./support/apply-review.sh -n -r 46621

Error:
2016-04-30 03:11:56 URL:https://reviews.apache.org/r/46621/diff/raw/ 
[14455/14455] -> "46621.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp:498:  
Redundant blank line at the start of a code block should be deleted.  
[whitespace/blank_line] [2]
Total errors found: 1
Checking 2 files

Full log: https://builds.apache.org/job/mesos-reviewbot/12816/console

- Mesos ReviewBot


On April 30, 2016, 2:03 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated April 30, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecated alias for `--authenticate_frameworks` master flag.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated April 30, 2016, 3:44 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated libprocess tests to work with the new `flag.load()` signature.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46623: Updated libprocess to work with flag alias.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46623/
---

(Updated April 30, 2016, 3:43 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated libprocess to work with flag alias.


Diffs (updated)
-

  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 

Diff: https://reviews.apache.org/r/46623/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46621: Added alias support for flags.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/
---

(Updated April 30, 2016, 3:43 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

fixed blank line.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

This lets a user to load a flag either by the original name or an
alias.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46621/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46622: Added tests for flag aliases.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46622/
---

(Updated April 30, 2016, 3:43 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added tests for flag aliases.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46622/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46624: Added support to mesos to work with flag alias.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46624/
---

(Updated April 30, 2016, 3:43 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added support to mesos to work with flag alias.


Diffs (updated)
-

  src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
  src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 

Diff: https://reviews.apache.org/r/46624/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated April 30, 2016, 3:44 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 30, 2016, 2:03 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased to re-kick reviewbot.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/
---

(Updated April 30, 2016, 1:56 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

deleted the output stream operator for Name.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

This sets up the stage to add metadata to the name (e.g., deprecated).
This will be used to add deprecation support subsequently.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46620/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46621: Added alias support for flags.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/#review131240
---




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 498)


I'm getting the following error when I attempt to apply this patch with 
'apply-review.sh': 
`3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp:498:  
Redundant blank line at the start of a code block should be deleted.  
[whitespace/blank_line] [2]`


- Greg Mann


On April 30, 2016, 2 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46621/
> ---
> 
> (Updated April 30, 2016, 2 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This lets a user to load a flag either by the original name or an
> alias.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated April 30, 2016, 3:44 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated mesos to work with new `flags.load()` signature.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
---

(Updated April 30, 2016, 3:44 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46863/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 30, 2016, 3:45 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46814: Refactored FlagsBase::load().

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46814/#review131243
---


Ship it!




Ship It!

- Greg Mann


On April 30, 2016, 1:59 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46814/
> ---
> 
> (Updated April 30, 2016, 1:59 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made this function more readable. The error strings are still kept the
> same as the previous code.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46814/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review131221
---



Patch looks great!

Reviews applied: [46620, 46814, 46621, 46622, 46623, 46624, 46669, 46818, 
46815, 46670]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 7:10 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated April 29, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecated alias for `--authenticate_frameworks` master flag.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/#review131235
---




3rdparty/libprocess/src/subprocess_windows.cpp (lines 305 - 352)


(1) According to the "Security Remarks" section of 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx,
 it's recommended that we set the `lpApplicationName` parameter, rather than 
embedding the module name inside the `lpCommandLine` parameter since we need to 
make sure that the modulen name in `lpCommandLine` needs to be wrapped in 
quotes in case of spaces in the name. We don't seem to be doing this correctly.

(2) `argumentsEscaped` is `new`ed, but not `delete`d, and according to the 
documentation for `CreateProcess`, it does not call `delete` on 
`lpCommandLine`. It looks like we're leaking?

(3) Are we required to escape the quotes like we're doing here for 
`argumentsEscaped`...? I don't see anything like this in the documentation.

What I would prefer to do here I think is to take a `argv` by value, then 
do:

```cpp
string program = argv[0];
argv.erase(argv.begin());
string args = strings::join(" ", argv);

... = CreateProcess(
  program.data(),
  args.data(),
  ...);
```

If we wanted to avoid using `lpApplicationName` for whatever reason, how 
about:

```cpp
string program = "\"" + argv[0] + "\"";
argv.erase(argv.begin());
string args = strings::join(" ", argv);
string cmd = strings::join(" ", program, args);

... = CreateProcess(
  NULL,
  cmd.data(),
  ...);
```


- Michael Park


On April 23, 2016, 11:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46608/
> ---
> 
> (Updated April 23, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Implemented `subprocess_windows.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46608/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review131244
---



Patch looks great!

Reviews applied: [46620, 46814, 46621, 46622, 46623, 46624, 46669, 46863, 
46818, 46815, 46670]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 30, 2016, 3:45 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated April 30, 2016, 3:45 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecated alias for `--authenticate_frameworks` master flag.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131157
---



Patch looks great!

Reviews applied: [46730]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 1:03 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> ---
> 
> (Updated April 29, 2016, 1:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
> https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `` and removed uncessary condition complie.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review131166
---



(1) Just so I understand, is this a necessary introduction? or is it an 
improvement?
(2) In some parts, we access the `name.value` directly, and other times we use 
`stringify(name)`. From the implementation it looks like they yield the same 
result, but are there different semantic intentions behind the uses?

- Michael Park


On April 29, 2016, 3:25 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> ---
> 
> (Updated April 29, 2016, 3:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46799: Added capabilities support to mesos-execute.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/
---

(Updated April 29, 2016, 6:41 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

This change introduces two flags: `user` and `capabilities`.

   user:  used to specify the user name for the command.
   capabilities: comma separated list of capabilities the task
 requires.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 

Diff: https://reviews.apache.org/r/46799/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131167
---



Patch looks great!

Reviews applied: [46827]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 2:08 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> ---
> 
> (Updated April 29, 2016, 2:08 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed some unused header includes.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77 
> 
> Diff: https://reviews.apache.org/r/46827/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46813: Update distribute to setuptools.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/#review131165
---


Ship it!




Ship It!

- Kapil Arya


On April 29, 2016, 5:13 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46813/
> ---
> 
> (Updated April 29, 2016, 5:13 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5244
> https://issues.apache.org/jira/browse/MESOS-5244
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update distribute to setuptools.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
>   3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
>   3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
>   LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/examples/python/test-containerizer.in 
> b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
>   src/examples/python/test-executor.in 
> 6be0ad2d339ff43d074e9688978af1ddf956803c 
>   src/examples/python/test-framework.in 
> 59bab82962c5846c6be288f3d392986e146e9da6 
>   support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 
> 
> Diff: https://reviews.apache.org/r/46813/diff/
> 
> 
> Testing
> ---
> 
> make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5.
> 
> NOTE: I tested on my RHEL 6.6 and failed, because the package 
> pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
> ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think 
> it's ok for this patch.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review131140
---



Patch looks great!

Reviews applied: [46784]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:49 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> ---
> 
> (Updated April 29, 2016, 9:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
> 
> Diff: https://reviews.apache.org/r/46784/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated April 29, 2016, 7:08 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated testing section.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing (updated)
---

make check


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 29, 2016, 7:10 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased to re-kick reviewbot.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated April 29, 2016, 7:09 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

fixed flags::load() in files that were not compiled in my local machine.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated mesos to work with new `flags.load()` signature.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46814: Refactored FlagsBase::load().

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46814/#review131168
---




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 710 - 
725)


How about:

```cpp
bool is_negated = strings::startsWith(name, "no-");
std::string flag_name = !is_negated ? name : name.substr(3)s
auto iter = flags_.find(flag_name);
if (iter == flags_.end()) {
  if (!unknowns) {
return Error("Failed to load unknown flag '" + flag_name + "'" +
 (!is_negated ? "" : " via '" + name + "'"));
  } else {
continue;
  }
}
```



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 715 - 
720)


This block is indented 3 spaces.



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 727 - 
764)


How about splitting the conditions first by non-boolean vs boolean flags? I 
think this way we can group the logical parts together better. Consider the 
positions of "true" and "false", for example.

```cpp
const Flag& flag = iter->second;
std::string value_;

if (!flag.boolean) {  // non-boolean flag
  if (is_negated) {
return Error("Failed to load non-boolean flag '" + flag_name + "' 
via '" +
 name + "'");
  }

  if (value.isNone()) {
return Error("Failed to load non-boolean flag '" + flag_name +
 "': Missing value");
  }

  value_ = value.get();
} else {  // boolean flag
  if (value.isNone() || value.get() == "") {
value_ = !is_negated ? "true" : "false";
  } else if (!is_negated) {
value_ = value.get();
  } else {
return Error(
"Failed to load boolean flag '" + flag_name + "' via '" + name +
"' with value '" + value.get() + "'");
  }
}

Try load = flag.load(this, value_);
if (load.isError()) {
  return Error("Failed to load flag '" + flag_name + "': " + 
load.error());
}
```


- Michael Park


On April 29, 2016, 6:43 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46814/
> ---
> 
> (Updated April 29, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made this function more readable. The error strings are still kept the
> same as the previous code.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46814/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46799: Added capabilities support to mesos-execute.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/#review131203
---



Patch looks great!

Reviews applied: [46369, 46370, 46371, 46798, 46799]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 6:41 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46799/
> ---
> 
> (Updated April 29, 2016, 6:41 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces two flags: `user` and `capabilities`.
> 
>user:  used to specify the user name for the command.
>capabilities: comma separated list of capabilities the task
>  requires.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
> 
> Diff: https://reviews.apache.org/r/46799/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46858/
---

Review request for mesos, Gilbert Song, Ian Downes, and Timothy Chen.


Bugs: MESOS-5239
https://issues.apache.org/jira/browse/MESOS-5239


Repository: mesos


Description
---

In filesystem/linux isolator, we will need to make sure the mount that
contains the agent's working directory is a shared mount in its own
peer group so that cloning the host mount table (e.g., when launching
a container with a new mount namespace) does not create an extra
reference to the mounts under the agent's work_dir.

However, if the mount containing the agent's working directory is
already a shared mount in its own peer group, we don't have to create
another bind mount for the agent's working directory. This patch
allows the filesystem/linux isolator to skip the bind mount if
possible.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
a6e748ae777b6280f5dab0a6fec7305f931f2c22 

Diff: https://reviews.apache.org/r/46858/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 46813: Update distribute to setuptools.

[Zhiwei Chen]

> On April 30, 2016, 12:20 a.m., haosdent huang wrote:
> > 3rdparty/versions.am, line 25
> > 
> >
> > I saw the latest version of setuptools is `20.10.1` in 
> > https://pypi.python.org/pypi/setuptools Do we have any reasons to use 
> > 20.9.0?

oh, it's latest version is 20.9.0 when I first testing this patch. I will try 
to upgrade to the latest one.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/#review131118
---


On April 29, 2016, 5:13 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46813/
> ---
> 
> (Updated April 29, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5244
> https://issues.apache.org/jira/browse/MESOS-5244
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update distribute to setuptools.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 
>   3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 
>   3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 
>   LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/examples/python/test-containerizer.in 
> b8258e75a3cd5f8d18ab8eff8196c5374db4f629 
>   src/examples/python/test-executor.in 
> 6be0ad2d339ff43d074e9688978af1ddf956803c 
>   src/examples/python/test-framework.in 
> 59bab82962c5846c6be288f3d392986e146e9da6 
>   support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 
> 
> Diff: https://reviews.apache.org/r/46813/diff/
> 
> 
> Testing
> ---
> 
> make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5.
> 
> NOTE: I tested on my RHEL 6.6 and failed, because the package 
> pytz-2010h-2.el6.noarch was installed, when I removed this package verything 
> ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think 
> it's ok for this patch.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46779: Clarified and improved maintenance docs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46779/#review131187
---


Fix it, then Ship it!




Some suggestions below:


docs/maintenance.md (line 184)


s/their/the machine's/



docs/maintenance.md (line 188)


s/Inverse offers/Inverse offers are also used to/



docs/maintenance.md (lines 260 - 264)


I would put this paragraph in a `>NOTE:`


- Joseph Wu


On April 28, 2016, 7:53 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46779/
> ---
> 
> (Updated April 28, 2016, 7:53 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified and improved maintenance docs.
> 
> 
> Diffs
> -
> 
>   docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 
> 
> Diff: https://reviews.apache.org/r/46779/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>