DO NOT REPLY [Bug 14332] - RequestUtils.applicationClass problem with ContextClassLoader
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14332. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14332 RequestUtils.applicationClass problem with ContextClassLoader --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 13:58 --- Actually the fix is not complicated at all, and I would recommend that you simply modify (all of about 3 lines) and recompile the source to fit your needs. That's the beauty of Open Source. -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14471] - validator-rules.xml JavaScript fails when field not present in jsp
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14471. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14471 validator-rules.xml JavaScript fails when field not present in jsp --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 14:22 --- Created an attachment (id=3820) Updated validator-rules.xml -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
Re: RE: Changes for 2.0 (RE: Unclear semantics on form use for wizards)
We really can't agree on anything until we see the patch. Technnically, we can't vote on plans only actual code or text. The best course of action is always to do what *you* need to do for *your* application first, and then share the result with the community. If the Committers decide to apply the patch to the distribution copy, mores the better. If not, we can make it available through the resource page for others to download and try. A great number of features in the current build started out as developer extensions. As more and more people referred to them, they were eventually adopted into the distribution. -Ted. 11/11/2002 11:37:02 PM, Brian Topping [EMAIL PROTECTED] wrote: Oh, okay, same as it was. Point taken on 2.0 now after rereading your initial post, mea culpa. Since ActionForms work with the current reset semantics and DynaActionForms don't, it's follows that it's a bug in DynaActionForms. DynaActionForms are new to 1.1, and 1.1 has not shipped yet, so it's something that can be fixed in 1.1. Make DynaActionForm.reset() the same as ActionForm.reset(), take the code that was there, make it a new routine, call that routine from the constructor. Document the stuff so it's clear what's going on. If there's agreement, I'll submit patches. -b -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
Re: RE: Unclear semantics on form use for wizards
The framework calls reset(), but its an extension point that the developer controls. For ActionForms, the developer has to affirmatively give reset() funcationality. For DynaActionForms, the developer can let the default behavior ride or override the extension point with any preferred behavior. But in either case, the framework is just calling a method. What the method does is up to the developer. I generally don't use reset to clear any fields (except checkboxes in session scope), but I sometimes use it for other things, like snagging the locale object for use by other methods. I'm not crazy about the DynaActionForm's current behavior either. But, if it bothers me, I can override it. If I override it in a particularly clever way, I can propose the change and/or make my patch available to the community. But the framework is not foreclosing any opportunities. -Ted. 11/11/2002 9:56:32 PM, Brian Topping [EMAIL PROTECTED] wrote: -Original Message- From: Craig R. McClanahan [mailto:craigmcc;apache.org] Subject: RE: Unclear semantics on form use for wizards The missing link for a multi-page form is some way to tie which page got submitted to the set of properties that live on that page (and therefore need to be reset. As David Graham said: Interesting, but then you're creating a programming language in XML. I think this logic should be in code. Occam's Razor (oh-so-trendy these days) would have it that the developer knows best when a form needs to be reset and to let them call it. Clearly, reset() needs to be called whenever a form is instantiated to get default values, but it should not be called by the framework. If the form is in request scope, the form will be created on Action invocation, semantically implying reset(). If the form is session based and not a part of the session, it is created and reset() is called. If the form is a part of the session already, it is left alone. Thoughts? -b -- To unsubscribe, e-mail: mailto:struts-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:struts-dev- [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14476] New: - Struts example war does not deploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14476. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14476 Struts example war does not deploy Summary: Struts example war does not deploy Product: Struts Version: Nightly Build Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Example AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I cannot deploy struts-example.war to JBoss-3.0.4-tomcat_4.1.12 During deployment I get ClassNotFoundExceptions 09:56:52,412 INFO [Engine] WebappLoader[/struts-example]: Deploy JAR /WEB-INF/lib/struts.jar to D:\jboss-3.0.4_tomcat-4.1.12\tomcat-4.1.x\work\MainEngine\localhost\struts- example\WEB-INF\lib\struts.jar 09:56:53,794 INFO [Engine] ContextConfig[/struts-example]: Added certificates - request attributeValve 09:56:55,497 INFO [EmbeddedCatalinaService41] Using Java2 parent classloader delegation: true 09:56:55,507 INFO [Engine] StandardManager[/struts-example]: Seeding random number generator class java.security.SecureRandom 09:56:55,507 INFO [Engine] StandardManager[/struts-example]: Seeding of random number generator has been completed 09:56:55,507 INFO [Engine] StandardWrapper[/struts-example:default]: Loading container servlet default 09:56:55,977 INFO [PropertyMessageResources] Initializing, config='org.apache.struts.util.LocalStrings', returnNull=true 09:56:55,977 INFO [PropertyMessageResources] Initializing, config='org.apache.struts.action.ActionResources', returnNull=true 09:56:56,769 INFO [PropertyMessageResources] Initializing, config='org.apache.struts.webapp.example.ApplicationResources', returnNull=true 09:56:56,799 INFO [MemoryDatabasePlugIn] Initializing memory database plug in from '/WEB-INF/database.xml' 09:56:56,919 INFO [ValidatorPlugIn] Loading validation rules file from '/WEB- INF/validator-rules.xml' 09:56:56,929 ERROR [Digester] Begin event threw exception java.lang.ClassNotFoundException: No ClassLoaders found for: org.apache.commons.validator.ValidatorAction at org.jboss.mx.loading.LoadMgr.beginLoadTask(LoadMgr.java:138) at org.jboss.mx.loading.UnifiedClassLoader3.loadClass (UnifiedClassLoader3.java:140) at java.lang.ClassLoader.loadClass(ClassLoader.java:255) at org.apache.commons.digester.ObjectCreateRule.begin (ObjectCreateRule.java:252) at org.apache.commons.digester.Digester.startElement(Digester.java:1237) at org.apache.crimson.parser.Parser2.maybeElement(Parser2.java:1488) at org.apache.crimson.parser.Parser2.content(Parser2.java:1779) at org.apache.crimson.parser.Parser2.maybeElement(Parser2.java:1507) at org.apache.crimson.parser.Parser2.content(Parser2.java:1779) at org.apache.crimson.parser.Parser2.maybeElement(Parser2.java:1507) at org.apache.crimson.parser.Parser2.parseInternal(Parser2.java:500) at org.apache.crimson.parser.Parser2.parse(Parser2.java:305) at org.apache.crimson.parser.XMLReaderImpl.parse(XMLReaderImpl.java:442) at org.apache.commons.digester.Digester.parse(Digester.java:1514) at org.apache.commons.validator.ValidatorResourcesInitializer.initialize (Unknown Source) at org.apache.struts.validator.ValidatorPlugIn.initResources (ValidatorPlugIn.java:224) at org.apache.struts.validator.ValidatorPlugIn.init (ValidatorPlugIn.java:167) at org.apache.struts.action.ActionServlet.initApplicationPlugIns (ActionServlet.java:991) at org.apache.struts.action.ActionServlet.init(ActionServlet.java:458) at javax.servlet.GenericServlet.init(GenericServlet.java:256) at org.apache.catalina.core.StandardWrapper.loadServlet (StandardWrapper.java:924) at org.apache.catalina.core.StandardWrapper.load (StandardWrapper.java:813) at org.apache.catalina.core.StandardContext.loadOnStartup (StandardContext.java:3341) at org.apache.catalina.core.StandardContext.start (StandardContext.java:3534) at org.apache.catalina.core.ContainerBase.addChildInternal (ContainerBase.java:821) at org.apache.catalina.core.ContainerBase.addChild (ContainerBase.java:807) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:579) at org.jboss.web.catalina.EmbeddedCatalinaService41.createWebContext (EmbeddedCatalinaService41.java:432) at org.jboss.web.catalina.EmbeddedCatalinaService41.performDeploy (EmbeddedCatalinaService41.java:306) at org.jboss.web.AbstractWebContainer.start (AbstractWebContainer.java:300) at org.jboss.deployment.MainDeployer.start(MainDeployer.java:807) at
DO NOT REPLY [Bug 14477] New: - MessageResource Bundles
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14477. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14477 MessageResource Bundles Summary: MessageResource Bundles Product: Struts Version: Nightly Build Platform: All OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] What is the correct mechanism to specify the MessageResources Should it be in web.xml with init-param application and then value of ApplicationResources Or should it be in struts-config.xml message-resources parameter=ApplicationResources null=true/ What is the order of processing -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
Re: RE: RE: Unclear semantics on form use for wizards
An HOWTO would be nice =:0) http://jakarta.apache.org/struts/faqs/index.html Over time, I'd like to condense the User Guide into an architechtural overview, and move the sections with signficiant code out, like Accessing Relational Databases out into HOWTOS. This will make it easier for people to scratch an itch without having to figure out where a section fits into the UserGuide. Eventually, I'd also like to have Developer Guides for each of the major packages, as we now have for the taglibs. This will give us a place to talk about how the classes interact that it outside the scope of a JavaDoc, but a little too general for a HOWTO. The nice part about the Developer Guides is that they are actually part of the JavaDocs (the overview.html). -Ted. 11/11/2002 9:53:42 PM, Brian Topping [EMAIL PROTECTED] wrote: Thanks. I'll do what I can. -b -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Monday, November 11, 2002 9:46 PM To: [EMAIL PROTECTED] Subject: RE: RE: Unclear semantics on form use for wizards If the documentation is vague, you can create a patch and post it to bugzilla. I will apply any valid documentation patch ASAP. Thanks, David From: Brian Topping [EMAIL PROTECTED] Reply-To: Struts Developers List struts- [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: RE: Unclear semantics on form use for wizards Date: Mon, 11 Nov 2002 21:43:36 -0500 -Original Message- From: Ted Husted [mailto:husted;apache.org] Subject: Re: RE: Unclear semantics on form use for wizards Checkboxes on a session-scoped form is really the only reason we have a reset() in the first place. When the box is clear, the browser's don't send back the element at all, and so there is no way to turn it off again. Yes, most of my understanding of Struts so far is from the Javadoc, and I would agree with this statement. IOW, I'm trying to come from the perspective of what a user would come from had they simply read the documentation and tried to solve one of their own problems. I might add that this perspective is shaky: With heaps of respect to anyone who takes the time to write documentation, any documentation, the Struts documentation is extremely vague. I remember from six months or so back that this is the meaning of reset() but I can't seem to find where I had learned that from any longer. I saw it once, now I cannot find it. A developer shouldn't have that problem; it should be in the documentation, and the documentation forms the user contract on which the framework is extended. When a contract is unclear, people find in it what they want to find rather than what is actually there. Along the way, we got into the questionable habit of resetting everything whether it needed it or not. But for everything except a checkbox in session scope, there doesn't seem to be a value-add. In request scope, the form is usually newly created. In session scope, the initial property will stick until its overwritten (except for those nasty checkboxes). The practice of resetting everything has created a good number of support mails, since new developers copy the practice by rote, and then wonder why their session-scope properties disappear =:( http://jakarta.apache.org/struts/userGuide/building_model.html makes reference to the technique, and again, there used to be specific discussion of correct use of reset(). But now, and I don't know how long for, reset() is called every time through the controller, and the only way to stop it is to catch the call in a subclass with a null implementation. It says nothing to this effect, you just need to figure it out. It's bad. The javadoc should eliminate the need to open the hood on the source files, and in the alternate case should back each other up, not play hot potato/needle in a haystack with the developer. Personally, I have been concerned by the current behavior of the DynaActionForm. Conventional ActionForms have a empty reset (), but DynaActionForms set everything back to the initial values. IMHO, that's a significant difference in behavior and violates the backwardly compatibility principle. It is what many developers do with their subclasses, but its not what Struts did out of the box. I haven't been able to study the code closely enough to offer an alternative. Ideally, it seems to me that whether to reset a field should be a property specified along with the initial value. But I haven't studied the code, and so I don't know if that's feasible. I had offered a different alternative when I originally started this thread, and if the volume of email on the subject, none authoritative, leads me to the conclusion that this is a real problem. Your observation here is astute. To
DO NOT REPLY [Bug 14477] - MessageResource Bundles
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14477. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14477 MessageResource Bundles [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 16:29 --- Bugzilla is not the appropriate place for user questions. Please post this to the struts-user mailing list. -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
Re: Replacing Action.* with Globals.*
I committed the updates last night because I didn't hear anyone complain. David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 09:41:04 -0600 Well, we're headed toward using Globals instead of Action for this purpose, so I'd think it would be highly desirable for the internal code to use those constants located in Globals. ... The Action constants can't go away yet (at least I believe that's the decision that was arrived at), but I can't see where changing internal code to use Global references over Action references would be a bad thing. David Graham wrote: Is it ok to replace the Action constant references with Globals constant references in the Struts code? I would hate to do this and have to back out the changes. Thanks, Dave -- Eddie Bush -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Replacing Action.* with Globals.*
-Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly checking mail to struts-dev. Given your statement that you would hate to do this and have to back out the changes (which I understand :), I would suggest that you might want to allow more time for people to respond before going ahead with changes like this. Otherwise, you do leave yourself open to having to back out the changes. -- Martin Cooper David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 09:41:04 -0600 Well, we're headed toward using Globals instead of Action for this purpose, so I'd think it would be highly desirable for the internal code to use those constants located in Globals. ... The Action constants can't go away yet (at least I believe that's the decision that was arrived at), but I can't see where changing internal code to use Global references over Action references would be a bad thing. David Graham wrote: Is it ok to replace the Action constant references with Globals constant references in the Struts code? I would hate to do this and have to back out the changes. Thanks, Dave -- Eddie Bush -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14482] New: - html:image
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14482.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14482
html:image
Summary: html:image
Product: Struts
Version: 1.0.2 Final
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Major
Priority: Other
Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
If I place the following code into a jsp...
html:image src=images/btnCheck.png alt=Toggle Select All border=0
onclick=return toggleSelectAll('asrTranList','asr.selected','%
=asrTranForm.getAsrTranListSize()%'); /
input type=image src=images/btnCheck.png alt=Toggle Select All border=0
onclick=return toggleSelectAll
('asrTranList','asr.selected','%=asrTranForm.getAsrTranListSize()%'); /
--
To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14482] - html:image
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14482. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14482 html:image [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14476] - Struts example war does not deploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14476. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14476 Struts example war does not deploy [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 17:05 --- We are aware of this issue. You must remove and deploy the commons-validator.jar before deploying the example war. This is not required on any of Tomcat 3.2 and up (Standalone), so this bug should be placed on the JBoss' bug list. -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14332] - RequestUtils.applicationClass problem with ContextClassLoader
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14332. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14332 RequestUtils.applicationClass problem with ContextClassLoader --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 17:10 --- Hi Erik, Not sure if you saw the long thread on the dev list, but we decided not to change this right now. See thread titled: [Vote] Modify classloading in RequestUtils -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Replacing Action.* with Globals.*
You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 08:49:49 -0800 -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly checking mail to struts-dev. Given your statement that you would hate to do this and have to back out the changes (which I understand :), I would suggest that you might want to allow more time for people to respond before going ahead with changes like this. Otherwise, you do leave yourself open to having to back out the changes. -- Martin Cooper David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 09:41:04 -0600 Well, we're headed toward using Globals instead of Action for this purpose, so I'd think it would be highly desirable for the internal code to use those constants located in Globals. ... The Action constants can't go away yet (at least I believe that's the decision that was arrived at), but I can't see where changing internal code to use Global references over Action references would be a bad thing. David Graham wrote: Is it ok to replace the Action constant references with Globals constant references in the Struts code? I would hate to do this and have to back out the changes. Thanks, Dave -- Eddie Bush -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ Add photos to your messages with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14474] - Digester exception on deploying struts.jar
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14474. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14474 Digester exception on deploying struts.jar [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 17:16 --- Please deploy this on Tomcat-4.1.12 standalone and if you get the same exception reopen and add additional info: JVM version: If this is a custom taglib, please paste it here as well (or at least the offending lines) That will help us in getting this resolved ASAP. Thanks -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Unclear semantics on form use for wizards
On Mon, 11 Nov 2002, Martin Cooper wrote: Date: Mon, 11 Nov 2002 18:49:12 -0800 From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Unclear semantics on form use for wizards -Original Message- From: Ted Husted [mailto:husted;apache.org] Sent: Monday, November 11, 2002 6:18 PM To: Struts Developers List Subject: Re: Unclear semantics on form use for wizards The ActionForm is pluggable, and we have always shipped with one implementation that defaults to session and another that defaults to request. I believe that originally we used session since that was liable to cause the least amount of confusion. Then we got into the habit of using reset to clear everything, which caused all the same confusion session scope might avoid (where did my values go?). Request might be a better default. Since it is pluggable, we might also be able to change it sooner than 2.0.x if we wanted. I don't believe we should be changing this before a 2.x release. It will instantly cause backwards compatibility problems for existing apps which do not override the default, which is a Bad Thing (TM). +1 IMNSHO, breaking backwards compatibility is tolerable on a change in major version number, but not on anything less. +1 I'm open to taking a completely fresh look at the whole architecture in 2.0 (among other things, the underlying servlet and JSP specs have made a *lot* of new things possible), incorporating everything we've learned in the last two years of Struts usage, and create something new -- as long as we'll continue to support 1.x users for a long time with bugfixes. I'm not open to modifying fundamental behavior like this in 1.x, even when the old behavior is demonstrably wrong (as you could probably contend in this scenario). We've made way too many promises that compatibility is an important core value to break them on stuff like this. -- Martin Cooper Craig -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Unclear semantics on form use for wizards
On Mon, 11 Nov 2002, Martin Cooper wrote: [SNIP] The outrageous effort? Just automate it, and it becomes trivial. As Craig mentioned earlier in this thread, using session state also means you have to write code to somehow protect yourself from multiple simultaneous requests (e.g. from frames, or multiple browser windows). I'd say that's more effort (and much more difficult to do) than using hidden fields. Yep -- it's a TANSTAAFL situation (there ain't no such thing as a free lunch) -- Martin Cooper Craig -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 14471] - validator-rules.xml JavaScript fails when field not present in jsp
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14471. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14471 validator-rules.xml JavaScript fails when field not present in jsp --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 19:21 --- Are you using the nightly build ? You may find that it has the behavior you desire. Also when submitting a patch generate is using 'diff -u' and state which version of the CVS file it is a diff against. -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Unclear semantics on form use for wizards
-Original Message- From: Craig R. McClanahan [mailto:craigmcc;apache.org] Sent: Tuesday, November 12, 2002 1:14 PM To: Struts Developers List Subject: RE: Unclear semantics on form use for wizards snip/ I'm open to taking a completely fresh look at the whole architecture in 2.0 (among other things, the underlying servlet and JSP specs have made a *lot* of new things possible), incorporating everything we've learned in the last two years of Struts usage, and create something new -- as long as we'll continue to support 1.x users for a long time with bugfixes. I assume by 2.0, that JSF will be final and Struts will be (should be) the defacto standard for developing to the JSF spec. Everything in life is a tradeoff and as such I'm hoping someone will come up with a library that let's me put together a JSF/Struts app visually or at least in one config file. (yah yah yah...I know.thanks for volunteering) I would be willing to give up look and feel for speed of 'time to deploy' (perhaps a choice from a few plugable templates). Let me setup a single configuration file and be able to deploy my new app immediately. There exists such a thing for gui development (http://www.thinlet.com) I'm not open to modifying fundamental behavior like this in 1.x, even when the old behavior is demonstrably wrong (as you could probably contend in this scenario). We've made way too many promises that compatibility is an important core value to break them on stuff like this. -- Martin Cooper Craig James Ok, ok, I know..I'm dreaming again Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Unclear semantics on form use for wizards
-Original Message- From: Craig R. McClanahan [mailto:craigmcc;apache.org] Sent: Tuesday, November 12, 2002 1:14 PM To: Struts Developers List Subject: RE: Unclear semantics on form use for wizards I'm not open to modifying fundamental behavior like this in 1.x, even when the old behavior is demonstrably wrong (as you could probably contend in this scenario). We've made way too many promises that compatibility is an important core value to break them on stuff like this. Yes, I've been swayed (as if it matters :-) in this regard. +1 as well. **BUT** DynaActionForms have not shipped yet, they are in beta! They are not 1.1 yet. Anyone that is relying on them did so at their own risk. Significantly different semantics for reset() under the different forms is a bug, and it should be fixed, so long as it's a part of the framework. I'm willing to write the howto, but I am going to document this as a misfeature. http://www.mail-archive.com/struts-dev;jakarta.apache.org/msg10846.html Since ActionForms work with the current reset semantics and DynaActionForms don't, it's follows that it's a bug in DynaActionForms. DynaActionForms are new to 1.1, and 1.1 has not shipped yet, so it's something that can be fixed in 1.1. Make DynaActionForm.reset() the same as ActionForm.reset(), take the code that was there, make it a new routine, call that routine from the constructor. Document the stuff so it's clear what's going on. If there's agreement, I'll submit patches. -b -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Replacing Action.* with Globals.******** README *********
Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. Your thoughts? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 08:49:49 -0800 -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly checking mail to struts-dev. Given your statement that you would hate to do this and have to back out the changes (which I understand :), I would suggest that you might want to allow more time for people to respond before going ahead with changes like this. Otherwise, you do leave yourself open to having to back out the changes. -- Martin Cooper David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 09:41:04 -0600 Well, we're headed toward using Globals instead of Action for this purpose, so I'd think it would be highly desirable for the internal code to use those constants located in Globals. ... The Action constants can't go away yet (at least I believe that's the decision that was arrived at), but I can't see where changing internal code to use Global references over Action references would be a bad thing. David Graham wrote: Is it ok to replace the Action constant references with Globals constant references in the Struts code? I would hate to do this and have to back out the changes. Thanks, Dave -- Eddie Bush -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ Add photos to your messages with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
ChainAction class
Over the past year and a half, I have developed using the Struts platform. During this time, my colleagues and I created an Action class which allows other actions to be chained together. This design resembled the Chain of Responsibility pattern. The ChainAction class was well received by the many other developers on our project. Most importantly it helped keep our Action components simple and modular and promoted reuse in our code. In addition, the ChainAction class allowed for different Actions to be executed based on Locale. I have been benefiting from the Struts Model View Controller framework for some time and would like to contribute the ChainAction class to the framework. The addition of the ChainAction class would require no changes to the existing Struts code base and would only offer Struts users an additional Action class implementation. I would like to gauge the interest other Struts developers have in this idea. Thanks. Karl -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: ChainAction class
+1 I have developed my own primitive BatchAction and find it very useful for running non-interactive servlets. Edgar -Original Message- From: Karl Baum [mailto:kbaum;Tallan.com] Sent: Tuesday, November 12, 2002 4:19 PM To: Struts Developers List Subject: ChainAction class Over the past year and a half, I have developed using the Struts platform. During this time, my colleagues and I created an Action class which allows other actions to be chained together. This design resembled the Chain of Responsibility pattern. The ChainAction class was well received by the many other developers on our project. Most importantly it helped keep our Action components simple and modular and promoted reuse in our code. In addition, the ChainAction class allowed for different Actions to be executed based on Locale. I have been benefiting from the Struts Model View Controller framework for some time and would like to contribute the ChainAction class to the framework. The addition of the ChainAction class would require no changes to the existing Struts code base and would only offer Struts users an additional Action class implementation. I would like to gauge the interest other Struts developers have in this idea. Thanks. Karl -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 12185] - HTML tags badly parsed in text/xml mode
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12185. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12185 HTML tags badly parsed in text/xml mode [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|LATER | --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 22:34 --- Actually this is a dup of 5518 Convert HTML Tags to be XHTML-compliant when html:html xhtml=true -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 12185] - HTML tags badly parsed in text/xml mode
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12185. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12185 HTML tags badly parsed in text/xml mode [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 22:35 --- *** This bug has been marked as a duplicate of 5518 *** -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 5518] - Convert HTML Tags to be XHTML-compliant when html:html xhtml=true
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5518. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5518 Convert HTML Tags to be XHTML-compliant when html:html xhtml=true [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Additional Comments From [EMAIL PROTECTED] 2002-11-12 22:53 --- Just two things: 1. Looks like that ImgTag and FrameTag need the results.append(getElementClose(this)); too. 2. The Request attribute aproach by Matt (and Tony) seems more correct than the one committed and the one I proposed in bug 12185, both based on the findAncestorWithClass method, as this only works within one jsp, it will not work if the page is composed with includes. -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Replacing Action.* with Globals.******** README *********
+1, with only one additional reminder -- convert leading tabs to spaces as well. Craig On Tue, 12 Nov 2002, Martin Cooper wrote: Date: Tue, 12 Nov 2002 13:27:24 -0800 (PST) From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * On Tue, 12 Nov 2002, James Mitchell wrote: Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? +1 I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. +1 If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. +1 JBuilder is also a big culprit here. Your thoughts? Basically, I couldn't agree more. ;-) -- Martin Cooper James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 08:49:49 -0800 -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly checking mail to struts-dev. Given your statement that you would hate to do this and have to back out the changes (which I understand :), I would suggest that you might want to allow more time for people to respond before going ahead with changes like this. Otherwise, you do leave yourself open to having to back out the changes. -- Martin Cooper David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 09:41:04 -0600 Well, we're headed toward using Globals instead of Action for this purpose, so I'd think it would be highly desirable for the internal code to use those constants located in Globals. ... The Action constants can't go away yet (at least I believe that's the decision that was arrived at), but I can't see where changing internal code to use Global references over Action references would be a bad thing. David Graham wrote: Is it ok to replace the Action constant references with Globals constant references in the Struts code? I would hate to do this and have to back out the changes. Thanks, Dave -- Eddie Bush -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus -- To unsubscribe, e-mail:
RE: Replacing Action.* with Globals.******** README *********
+1 on separating formatting from code changes. In my defense, several of the files had import javax.servlet.* which violates the current import practice (a practice I disagree with but follow nonetheless). Also, some of the imports were no longer needed and Eclipse removed them. The tiles code in particular did not follow the java standard coding guidelines so I formatted those as well. I apologize for the inconvenience; from now on, I'll commit appropriate formatting changes separately. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 16:06:22 -0500 Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. Your thoughts? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 08:49:49 -0800 -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly checking mail to struts-dev. Given your statement that you would hate to do this and have to back out the changes (which I understand :), I would suggest that you might want to allow more time for people to respond before going ahead with changes like this. Otherwise, you do leave yourself open to having to back out the changes. -- Martin Cooper David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 09:41:04 -0600 Well, we're headed toward using Globals instead of Action for this purpose, so I'd think it would be highly desirable for the internal code to use those constants located in Globals. ... The Action constants can't go away yet (at least I believe that's the decision that was arrived at), but I can't see where changing internal code to use Global references over Action references would be a bad thing. David Graham wrote: Is it ok to replace the Action constant references with Globals constant references in the Struts code? I would hate to do this and have to back out the changes. Thanks, Dave -- Eddie Bush -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail:
[VOTE] How to implement XHMTL support
I've updated that html taglib tags to output xhtml when they are nested in a html:html xhtml=true tag. This was very simple to do and resulted in minor code changes. Users have suggested this approach: 1. Add Globals.XHTML_KEY which is a boolean request scoped attribute 2. html tags check for that request attribute being true and output accordingly. 3. The html:html tag sets this request attribute when it's xhtml attribute is true. The second approach allows the tags to output xhtml without relying on the html:html tag. This allows people to construct pages with jsp includes. The first approach is logically clearer (to me) and you can use tiles to modularly construct the pages like includes. Approach 2 may be confusing because you would have to remember all the places you may have set that request attribute. So, do we go with 1, 2 or both? David _ STOP MORE SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=features/junkmail -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: [VOTE] How to implement XHMTL support
Just so I understand, you're experimenting with making tags generated from a jsp:include be xhtml-compliant even if the original page wasn't specified as being xhtml-compliant? It seems to me that XHTML compliance is an attribute of an html element and its nested elements (including the associated DOCTYPE), and not an attribute of an HTTP request. This would mean that a page that was jsp:included would generate different output depending on what page included it. I'd say that choice 1 (only affecting the elements nested in the html element), which I assume is what you've already done, is preferable to choice 2 (runtime determination). -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] I've updated that html taglib tags to output xhtml when they are nested in a html:html xhtml=true tag. This was very simple to do and resulted in minor code changes. Users have suggested this approach: 1. Add Globals.XHTML_KEY which is a boolean request scoped attribute 2. html tags check for that request attribute being true and output accordingly. 3. The html:html tag sets this request attribute when it's xhtml attribute is true. The second approach allows the tags to output xhtml without relying on the html:html tag. This allows people to construct pages with jsp includes. The first approach is logically clearer (to me) and you can use tiles to modularly construct the pages like includes. Approach 2 may be confusing because you would have to remember all the places you may have set that request attribute. So, do we go with 1, 2 or both? -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: [VOTE] How to implement XHMTL support
Yes, I have already implemented choice 1. Good points David. Dave From: Karr, David [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: [VOTE] How to implement XHMTL support Date: Tue, 12 Nov 2002 16:14:10 -0800 Just so I understand, you're experimenting with making tags generated from a jsp:include be xhtml-compliant even if the original page wasn't specified as being xhtml-compliant? It seems to me that XHTML compliance is an attribute of an html element and its nested elements (including the associated DOCTYPE), and not an attribute of an HTTP request. This would mean that a page that was jsp:included would generate different output depending on what page included it. I'd say that choice 1 (only affecting the elements nested in the html element), which I assume is what you've already done, is preferable to choice 2 (runtime determination). -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] I've updated that html taglib tags to output xhtml when they are nested in a html:html xhtml=true tag. This was very simple to do and resulted in minor code changes. Users have suggested this approach: 1. Add Globals.XHTML_KEY which is a boolean request scoped attribute 2. html tags check for that request attribute being true and output accordingly. 3. The html:html tag sets this request attribute when it's xhtml attribute is true. The second approach allows the tags to output xhtml without relying on the html:html tag. This allows people to construct pages with jsp includes. The first approach is logically clearer (to me) and you can use tiles to modularly construct the pages like includes. Approach 2 may be confusing because you would have to remember all the places you may have set that request attribute. So, do we go with 1, 2 or both? -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: ChainAction class
I would just like to instigate some trouble along with this question since I am a big fan of the Chain Of Repsonsibility pattern and agree that it can do a nice job of creating atomic and reusable code structures. I would also like to say that I think it could be confusing to have a chain action. The example provided for invoking actions based on Locale is handled by implementing someone's own custom RequestProcessor. Fan of the COR pattern I may be but implementing a custom RequestProcessor seems cleaner. One problem if you implement COR is how do you assemble and execute chains? Where do you store this info? Servlet Filters offer another chance to implement COR. Perhaps I'm hallucinating again, but has craig talked about COR and Java Server Faces? I think its' great if the contribution doesn't hurt anything else and pending the design is good. But I think most cases for use in a COR environment can be handled other ways. COR is a nice way to redirect output streams for several transformations of the output stream. Say you had one action that read data from a database and output xml. You could continue to add chain processors until it outputs a PDF file. -Daniel -Original Message- From: Karl Baum [mailto:kbaum;Tallan.com] Sent: Tuesday, November 12, 2002 4:19 PM To: Struts Developers Lis Subject: ChainAction class Over the past year and a half, I have developed using the Struts platform. During this time, my colleagues and I created an Action class which allows other actions to be chained together. This design resembled the Chain of Responsibility pattern. The ChainAction class was well received by the many other developers on our project. Most importantly it helped keep our Action components simple and modular and promoted reuse in our code. In addition, the ChainAction class allowed for different Actions to be executed based on Locale. I have been benefiting from the Struts Model View Controller framework for some time and would like to contribute the ChainAction class to the framework. The addition of the ChainAction class would require no change to the existing Struts code base and would only offer Struts users an additional Action class implementation. I would like to gauge the interest other Struts developers have in this idea. Thanks. Karl -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Replacing Action.* with Globals.******** README *********
Ah yes, I almost forgot about that one. James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: Craig R. McClanahan [mailto:craigmcc;apache.org] Sent: Tuesday, November 12, 2002 6:33 PM To: Struts Developers List Subject: RE: Replacing Action.* with Globals. README * +1, with only one additional reminder -- convert leading tabs to spaces as well. Craig On Tue, 12 Nov 2002, Martin Cooper wrote: Date: Tue, 12 Nov 2002 13:27:24 -0800 (PST) From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * On Tue, 12 Nov 2002, James Mitchell wrote: Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? +1 I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. +1 If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. +1 JBuilder is also a big culprit here. Your thoughts? Basically, I couldn't agree more. ;-) -- Martin Cooper James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 08:49:49 -0800 -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly checking mail to struts-dev. Given your statement that you would hate to do this and have to back out the changes (which I understand :), I would suggest that you might want to allow more time for people to respond before going ahead with changes like this. Otherwise, you do leave yourself open to having to back out the changes. -- Martin Cooper David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 09:41:04 -0600 Well, we're headed toward using Globals instead of Action for this purpose, so I'd think it would be highly desirable for the internal code to use those constants located in Globals. ... The Action constants can't go away yet (at least I believe that's the decision that was arrived at), but I can't see where changing internal code to use Global references over Action references would be a bad thing. David Graham wrote: Is it ok to replace the Action constant
Re: [VOTE] How to implement XHMTL support
We need to ensure that HTML taglib tags in included JSP pages also heed the xhtml attribute. That isn't the case with what's there now, because findAncestorWithClass() will fail for the tags in the included pages. Note that this is why the form tag stores itself in a request attribute. Originally, it also used findAncestorWithClass(), but it was changed to allow forms to span pages. So I see two ways of handling this: A) Have the html:html tag store itself in a request attribute, and change BaseHandlerTag.isXhtml() to grab the tag from there before calling getXhtml(). B) Have the html:html tag store the value of its 'xhtml' attribute as a request attribute, and use that in BaseHandlerTag.isXhtml(). Of these, I prefer the first approach because it makes it harder for people to futz (technical term :) with the value in their pages. -- Martin Cooper On Tue, 12 Nov 2002, David Graham wrote: I've updated that html taglib tags to output xhtml when they are nested in a html:html xhtml=true tag. This was very simple to do and resulted in minor code changes. Users have suggested this approach: 1. Add Globals.XHTML_KEY which is a boolean request scoped attribute 2. html tags check for that request attribute being true and output accordingly. 3. The html:html tag sets this request attribute when it's xhtml attribute is true. The second approach allows the tags to output xhtml without relying on the html:html tag. This allows people to construct pages with jsp includes. The first approach is logically clearer (to me) and you can use tiles to modularly construct the pages like includes. Approach 2 may be confusing because you would have to remember all the places you may have set that request attribute. So, do we go with 1, 2 or both? David _ STOP MORE SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=features/junkmail -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Replacing Action.* with Globals.******** README *********
I must admit. Since the hoopla a few weeks ago about Eclipse this and Eclipse that..I decided to download it and try it out..WOW!!! I was a big NetBeans advocate, but now I'm hooked on Eclipse and I haven't looked back since. Can you believe how it resolves the import statements? Hell, you can just delete them all, then select 'Organize Imports' and it will rip through the classpath and group and fix all imports to what they should have beencome on.you gotta love that. My personal favoriteHierarchy view, just F4 on a class, package, or source folder and you get an instant overview (inheritance hieratical treeview) from java.lang.Object to lowest subclass.who needs a diagram when you've got this? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 6:43 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * +1 on separating formatting from code changes. In my defense, several of the files had import javax.servlet.* which violates the current import practice (a practice I disagree with but follow nonetheless). Also, some of the imports were no longer needed and Eclipse removed them. The tiles code in particular did not follow the java standard coding guidelines so I formatted those as well. I apologize for the inconvenience; from now on, I'll commit appropriate formatting changes separately. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 16:06:22 -0500 Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. Your thoughts? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 08:49:49 -0800 -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly checking mail to struts-dev. Given your statement that you would hate to do this and have to back out the changes (which I understand :), I would suggest that you might want to allow more time for people to respond before going ahead with changes like this. Otherwise, you do leave yourself open to having to back out the changes. -- Martin Cooper David From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts
RE: Replacing Action.* with Globals.******** README *********
I haven't shown Eclipse to one person who didn't like it. I'm a big fan, but before the IDE wars start again, let me say that it doesn't do jsp highlighting or jsp code completion out of the box. I understand NetBeans does and that's a plus. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 20:21:26 -0500 I must admit. Since the hoopla a few weeks ago about Eclipse this and Eclipse that..I decided to download it and try it out..WOW!!! I was a big NetBeans advocate, but now I'm hooked on Eclipse and I haven't looked back since. Can you believe how it resolves the import statements? Hell, you can just delete them all, then select 'Organize Imports' and it will rip through the classpath and group and fix all imports to what they should have beencome on.you gotta love that. My personal favoriteHierarchy view, just F4 on a class, package, or source folder and you get an instant overview (inheritance hieratical treeview) from java.lang.Object to lowest subclass.who needs a diagram when you've got this? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 6:43 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * +1 on separating formatting from code changes. In my defense, several of the files had import javax.servlet.* which violates the current import practice (a practice I disagree with but follow nonetheless). Also, some of the imports were no longer needed and Eclipse removed them. The tiles code in particular did not follow the java standard coding guidelines so I formatted those as well. I apologize for the inconvenience; from now on, I'll commit appropriate formatting changes separately. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 16:06:22 -0500 Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. Your thoughts? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* Date: Tue, 12 Nov 2002 08:49:49 -0800 -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 8:30 AM To: [EMAIL PROTECTED] Subject: Re: Replacing Action.* with Globals.* I committed the updates last night because I didn't hear anyone complain. I don't have a problem with the changes. I would like to point out, however, that you only waited 3 hours for feedback. Not all of us are in the same country, let alone the same time zone. Cedric, for example, had no hope of responding in time, unless he happened to be reading Struts mail at around 3am his time (my estimate). Even those of us in an appropriate time zone are not all constantly
RE: Replacing Action.* with Globals.******** README *********
Yes, I miss those features very much. Although, since I upgraded my laptop to 1/2 a Gig of memory, now I can run them both (or at least I can run two whole instances of Netscape 6.0 ;) James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Wednesday, November 13, 2002 12:37 AM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * I haven't shown Eclipse to one person who didn't like it. I'm a big fan, but before the IDE wars start again, let me say that it doesn't do jsp highlighting or jsp code completion out of the box. I understand NetBeans does and that's a plus. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 20:21:26 -0500 I must admit. Since the hoopla a few weeks ago about Eclipse this and Eclipse that..I decided to download it and try it out..WOW!!! I was a big NetBeans advocate, but now I'm hooked on Eclipse and I haven't looked back since. Can you believe how it resolves the import statements? Hell, you can just delete them all, then select 'Organize Imports' and it will rip through the classpath and group and fix all imports to what they should have beencome on.you gotta love that. My personal favoriteHierarchy view, just F4 on a class, package, or source folder and you get an instant overview (inheritance hieratical treeview) from java.lang.Object to lowest subclass.who needs a diagram when you've got this? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 6:43 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * +1 on separating formatting from code changes. In my defense, several of the files had import javax.servlet.* which violates the current import practice (a practice I disagree with but follow nonetheless). Also, some of the imports were no longer needed and Eclipse removed them. The tiles code in particular did not follow the java standard coding guidelines so I formatted those as well. I apologize for the inconvenience; from now on, I'll commit appropriate formatting changes separately. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 16:06:22 -0500 Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. Your thoughts? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals.* You are right. I didn't wait long enough because I was making other changes and didn't want to get confused about which ones to commit. David From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers
cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html FrameTag.java ImgTag.java
dgraham 2002/11/12 22:10:54 Modified:src/share/org/apache/struts/taglib/html FrameTag.java ImgTag.java Log: Added xhtml support by modifying how the elements are closed. Revision ChangesPath 1.7 +5 -5 jakarta-struts/src/share/org/apache/struts/taglib/html/FrameTag.java Index: FrameTag.java === RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/FrameTag.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- FrameTag.java 26 Oct 2002 15:08:16 - 1.6 +++ FrameTag.java 13 Nov 2002 06:10:54 - 1.7 -243,7 +243,7 results.append(\); } results.append(prepareStyles()); -results.append(); +results.append(getElementClose(this)); ResponseUtils.write(pageContext,results.toString()); // Skip the body of this tag 1.23 +5 -5 jakarta-struts/src/share/org/apache/struts/taglib/html/ImgTag.java Index: ImgTag.java === RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/ImgTag.java,v retrieving revision 1.22 retrieving revision 1.23 diff -u -r1.22 -r1.23 --- ImgTag.java 8 Nov 2002 05:39:24 - 1.22 +++ ImgTag.java 13 Nov 2002 06:10:54 - 1.23 -465,7 +465,7 } results.append(prepareStyles()); results.append(prepareEventHandlers()); -results.append(); +results.append(getElementClose(this)); // Print this element to our output writer ResponseUtils.write(pageContext, results.toString()); -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
DO NOT REPLY [Bug 5518] - Convert HTML Tags to be XHTML-compliant when html:html xhtml=true
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5518. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5518 Convert HTML Tags to be XHTML-compliant when html:html xhtml=true --- Additional Comments From [EMAIL PROTECTED] 2002-11-13 06:19 --- The img and frame tags are fixed. I'll leave this open because there is a difference of opinion among the comitters on the implementation approach. -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: Replacing Action.* with Globals.******** README *********
There are plugins that attempt this feature but they are currently not very good. Find the SolarEclipse project on sourceforge for one of these. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Wed, 13 Nov 2002 01:05:37 -0500 Yes, I miss those features very much. Although, since I upgraded my laptop to 1/2 a Gig of memory, now I can run them both (or at least I can run two whole instances of Netscape 6.0 ;) James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Wednesday, November 13, 2002 12:37 AM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * I haven't shown Eclipse to one person who didn't like it. I'm a big fan, but before the IDE wars start again, let me say that it doesn't do jsp highlighting or jsp code completion out of the box. I understand NetBeans does and that's a plus. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 20:21:26 -0500 I must admit. Since the hoopla a few weeks ago about Eclipse this and Eclipse that..I decided to download it and try it out..WOW!!! I was a big NetBeans advocate, but now I'm hooked on Eclipse and I haven't looked back since. Can you believe how it resolves the import statements? Hell, you can just delete them all, then select 'Organize Imports' and it will rip through the classpath and group and fix all imports to what they should have beencome on.you gotta love that. My personal favoriteHierarchy view, just F4 on a class, package, or source folder and you get an instant overview (inheritance hieratical treeview) from java.lang.Object to lowest subclass.who needs a diagram when you've got this? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 6:43 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * +1 on separating formatting from code changes. In my defense, several of the files had import javax.servlet.* which violates the current import practice (a practice I disagree with but follow nonetheless). Also, some of the imports were no longer needed and Eclipse removed them. The tiles code in particular did not follow the java standard coding guidelines so I formatted those as well. I apologize for the inconvenience; from now on, I'll commit appropriate formatting changes separately. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 16:06:22 -0500 Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of recent commits wink/ was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. Your thoughts? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 12:10 PM
RE: Replacing Action.* with Globals.******** README *********
Yes, I've seen that and others. Even NetBeans cannot help me with taglib completion when working against my local cvs repository (jakarta-struts). Since the tlds are generated by the build, I only get standard jsp code completion. But heck, I'm not complaining. I was using Textpad for the longest time and let me tell you.Mark G. is right, you get to know the APIs quickly. James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Wednesday, November 13, 2002 1:20 AM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * There are plugins that attempt this feature but they are currently not very good. Find the SolarEclipse project on sourceforge for one of these. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Wed, 13 Nov 2002 01:05:37 -0500 Yes, I miss those features very much. Although, since I upgraded my laptop to 1/2 a Gig of memory, now I can run them both (or at least I can run two whole instances of Netscape 6.0 ;) James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Wednesday, November 13, 2002 12:37 AM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * I haven't shown Eclipse to one person who didn't like it. I'm a big fan, but before the IDE wars start again, let me say that it doesn't do jsp highlighting or jsp code completion out of the box. I understand NetBeans does and that's a plus. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 20:21:26 -0500 I must admit. Since the hoopla a few weeks ago about Eclipse this and Eclipse that..I decided to download it and try it out..WOW!!! I was a big NetBeans advocate, but now I'm hooked on Eclipse and I haven't looked back since. Can you believe how it resolves the import statements? Hell, you can just delete them all, then select 'Organize Imports' and it will rip through the classpath and group and fix all imports to what they should have beencome on.you gotta love that. My personal favoriteHierarchy view, just F4 on a class, package, or source folder and you get an instant overview (inheritance hieratical treeview) from java.lang.Object to lowest subclass.who needs a diagram when you've got this? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens? - Seymour Cray (1925-1996), father of supercomputing -Original Message- From: David Graham [mailto:dgraham1980;hotmail.com] Sent: Tuesday, November 12, 2002 6:43 PM To: [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * +1 on separating formatting from code changes. In my defense, several of the files had import javax.servlet.* which violates the current import practice (a practice I disagree with but follow nonetheless). Also, some of the imports were no longer needed and Eclipse removed them. The tiles code in particular did not follow the java standard coding guidelines so I formatted those as well. I apologize for the inconvenience; from now on, I'll commit appropriate formatting changes separately. Dave From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Replacing Action.* with Globals. README * Date: Tue, 12 Nov 2002 16:06:22 -0500 Since we are all bashing David (LOL...just kidding), may I make one more suggestion. Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this
