Re: Should html:file tag have a value attribute?

2003-02-28 Thread Antoni Reus
A Divendres 28 Febrer 2003 20:21, James Mitchell va escriure:
 Does it submit the file if you just hit submit?

It shows a warning message saying that the file input was filled without any 
action of the user, and lets you choose to submit it or not.

-- Antoni 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Does the /do/* will be supported with modules

2002-11-20 Thread Antoni Reus
Hi, question below

A Dimecres 20 Novembre 2002 00:37, Craig R. McClanahan va escriure:
 On Tue, 19 Nov 2002, Emmanuel Boudrant wrote:
  Date: Tue, 19 Nov 2002 13:48:44 +0100 (CET)
  From: Emmanuel Boudrant [EMAIL PROTECTED]
  Reply-To: Struts Developers List [EMAIL PROTECTED]
  To: [EMAIL PROTECTED]
  Subject: Does the /do/* will be supported with modules
 
  Hi,
 
  Actually the /do/* path mapped pattern doesn't work fine with modules,
  does this pattern will work
 
  with final release

 At the moment, it appears that the restriction that extension mapping must
 be used for application modules will remain in the final release.  Two
 things would be necessary to change this:

 * Someone would have to come up with a strategy that resovles
   the problem of how to define path-mapped URLs that still
   include the module prefix in some reasonable fashion that can
   be parsed.


Do you mean, for example if the servlet mapping is /do/* and an action path  
is  /actionPath, the path /do/actionPath should be translated to 
/do/modulePath/actionPath ?


 * Someone would have to implement this strategy.

  ...And, is it a good advice to use /do/* instead of *.do

 For a non-module scenario, this is pretty much a cosmetics issue --
 whichever style creates URLs that you like better is the one you should
 use.

  Thanx,
  -emmanuel

 Craig

Salut!

-- Antoni Reus

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [VOTE] How to implement XHMTL support

2002-11-13 Thread Antoni Reus
Hi, 

A Dimecres 13 Novembre 2002 20:45, Martin Cooper va escriure:
 On Wed, 13 Nov 2002, Eddie Bush wrote:

 big-snip/

  If the outermost document is meant to enforce XHTML, how can an included
  piece *not* conform to XHTML and the entire document still be XHTML?  I
  ... feel like we're attempting to over-design - but maybe I'm just
  showing my own ignorance (which is something I don't think I'll ever
  learn not to do - I learn way too much from being willing to do it).

 It can't, and that's in part what Craig pointed out. Since each included
 page must also be XHTML, each of those pages should state explicitly that
 it is XHTML, instead of having the decision about whether or not to
 generate XHTML be made externally (i.e. on the topmost page). Given that
 the non-Struts tags on the page must also be explicitly XHTML, that makes
 sense.

The document doctype (xhtml1, html401) is global, like the character encoding 
or some response headers. There is no sense in changing the doctype flag in 
included pages.

If you develop a page to be included and you use tags other than struts-html, 
like br or br / there is no way to reuse this page in both xhtml and 
html, with or without html:isXhtml/, html:html xhtml=true, etc 
but if a developer is able to create a  page to be included that only uses 
struts-html and/or other custom tags, with the html:isXhtml/ aproach she 
will not be able to reuse its page to generate xhtml or html


Salut!

-- Antoni Reus

--
To unsubscribe, e-mail:   mailto:struts-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org




Re: [VOTE] How to implement XHMTL support

2002-11-13 Thread Antoni Reus
Hi,

A Dimecres 13 Novembre 2002 23:06, David Graham va escriure:
 The developer must make a choice between html and xhtml.  This choice is
 minor as xhtml is compatible with current browsers.  Included jsps should
 not be influenced by the includer file; they must decide if they're xhtml
 or html.  That's the point behind the html:xhtml tag, to  tell struts
 html library tags to render in xhtml.

 If you want to reuse a jsp in an html project then don't code it with xhtml
 tags.

 David



I don't completely agree with this:

Included jsps should not be influenced by the includer file; they must decide 
if they're xhtml or html.

I think included jsps must not decide a thing that involves the whole request!

Anyway I  think I can see your point, included jsps should always output the 
same, xhtml or html, so you can rely on the output of the jsp, even if you 
are including it from a non-struts jsp page,.. oh well, I think now I 
completely agree with the above :-)

Salut!

-- Antoni Reus





 From: Antoni Reus [EMAIL PROTECTED]

 Reply-To: Struts Developers List [EMAIL PROTECTED]
 To: Struts Developers List [EMAIL PROTECTED]
 Subject: Re: [VOTE] How to implement XHMTL support
 Date: Wed, 13 Nov 2002 22:53:36 +0100
 
 Hi,
 
 A Dimecres 13 Novembre 2002 20:45, Martin Cooper va escriure:
   On Wed, 13 Nov 2002, Eddie Bush wrote:
  
   big-snip/
  
If the outermost document is meant to enforce XHTML, how can an
 
 included
 
piece *not* conform to XHTML and the entire document still be XHTML?
 
 I
 
... feel like we're attempting to over-design - but maybe I'm just
showing my own ignorance (which is something I don't think I'll ever
learn not to do - I learn way too much from being willing to do it).
  
   It can't, and that's in part what Craig pointed out. Since each
   included page must also be XHTML, each of those pages should state
   explicitly
 
 that
 
   it is XHTML, instead of having the decision about whether or not to
   generate XHTML be made externally (i.e. on the topmost page). Given
   that the non-Struts tags on the page must also be explicitly XHTML,
   that
 
 makes
 
   sense.
 
 The document doctype (xhtml1, html401) is global, like the character
 encoding
 or some response headers. There is no sense in changing the doctype flag
  in included pages.
 
 If you develop a page to be included and you use tags other than
 struts-html,
 like br or br / there is no way to reuse this page in both xhtml and
 html, with or without html:isXhtml/, html:html xhtml=true, etc 
 but if a developer is able to create a  page to be included that only uses
 struts-html and/or other custom tags, with the html:isXhtml/ aproach she
 will not be able to reuse its page to generate xhtml or html
 
 
 Salut!
 
 -- Antoni Reus
 
 --
 To unsubscribe, e-mail:
 mailto:struts-dev-unsubscribe;jakarta.apache.org
 For additional commands, e-mail:
 mailto:struts-dev-help;jakarta.apache.org

 _
 Add photos to your e-mail with MSN 8. Get 2 months FREE*.
 http://join.msn.com/?page=features/featuredemail


--
To unsubscribe, e-mail:   mailto:struts-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org




Re: [Vote] Modify classloading in RequestUtils

2002-11-07 Thread Antoni Reus
It seems that this is related with 

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13686

a similar issue with iplanet


A Dijous 07 Novembre 2002 17:13, James Mitchell va escriure:
 Not sure if you caught the thread on the users list, or the bug recently
 posted by Kjeld Froberg:

  http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14332


 Here's the proposed code change:

 RequestUtils.java
 ---
 From:
 public static Class applicationClass(String className)
 throws ClassNotFoundException {

 // Look up the class loader to be used
 ClassLoader classLoader =
 Thread.currentThread().getContextClassLoader();
 if (classLoader == null) {
 classLoader = RequestUtils.class.getClassLoader();
 }

 // Attempt to load the specified class
 return (classLoader.loadClass(className));
 }
 ---
 To:
 public static Class applicationClass(String className)
 throws ClassNotFoundException {
   ClassLoader ctxLoader = null;
   try {
   ctxLoader = Thread.currentThread().getContextClassLoader();
   return Class.forName(className, true, ctxLoader);

   } catch(ClassNotFoundException ex) {
   if(ctxLoader == null) { throw ex; }
   } catch(SecurityException ex) {

   }
   return Class.forName(className);
   }

 By changing these few lines, I am able to run the full test suite without
 error. (And that includes the new test.tomcat.33)

 I'm not sure if this should be a [Vote] or a [commit and wait till they
 complain], so I opted for the former.

 Even though I'm not truly sure of the consequences of this change, I'm +1.


 James Mitchell
 Software Engineer/Struts Evangelist
 http://www.open-tools.org

 Only two things are infinite, the universe and human stupidity, and I'm
 not sure about the former.
 - Albert Einstein (1879-1955)


--
To unsubscribe, e-mail:   mailto:struts-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org




Re: HTML, XML, XHTML and html:html

2002-10-23 Thread Antoni Reus
Hi, sorry for the late answer, but I'm in GMT+1 ;-)

A Dimecres 23 Octubre 2002 04:01, Craig R. McClanahan va escriure:
 On Tue, 22 Oct 2002, Antoni Reus wrote:
  [snip]
  As you could expect I would like to see  this in 1.1 controlled by the
  xhtml attribute!!

 This result has two prerequisites:

 * The developers have to agree to it (I'm personally +0, which
   means I'm OK with it but *I* am not going to do the work), and

 * Somebody has to submit a patch to make all the appropriate changes
   to all the appropriate tags.

 Failing *both* of these things, it's not gonna happen.

 Since this is your itch you want scratched, are you interested in
 preparing such a patch?  If so, the technical details of what's needed are
 on the web site, starting at:

   http://jakarta.apache.org/site/getinvolved.html


Of course, I'm working on it!


  Salut!!
 
  -- Antoni Reus

 Craig


--
To unsubscribe, e-mail:   mailto:struts-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org




Re: HTML formatting of newline characters with bean:write tag

2002-10-23 Thread Antoni Reus
Hi,

The tag replace in the string jakarta taglibs can do this
look at:

http://jakarta.apache.org/taglibs/doc/string-doc/index.html#replace

I used it in a project, was something like:

st:replace replace=\n with=lt;brgt; bean:write ./ /st:replace


Salut,

-- Antoni Reus


A Dimecres 23 Octubre 2002 19:50, Eddie Bush va escriure:
 Let me correct myself.  It does not appear there is such an animal in
 taglibs at this point in time.  There was someone wanting c:out to
 provide this behavior, and the response was that the string taglib may
 provide this functionality in the future.  You may wish to join
 taglibs-user or taglibs-dev to influence this development.

 Eddie Bush wrote:
  There are already taglibs that do this transformation, aren't there?
  Doesn't the taglibs project have things that address this?  Is there a
  way to do this using the JSTL (Martin?)?
 
  David Graham wrote:
  If this is a common problem, maybe we could add a method to Action
  like breakNewLines(String) that does this transformation.  The
  bean:write tag should not do any transformation, just display what
  it's given.
 
  What do you think?
 
  Dave


--
To unsubscribe, e-mail:   mailto:struts-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org




Re: HTML, XML, XHTML and html:html

2002-10-22 Thread Antoni Reus
Hi,

A Dimarts 22 Octubre 2002 19:46, Martin Cooper va escriure:

  I'd rather *not* make this kind of a potentially backwards
  incompatible
  change immediately before a release (unless you make it
  conditional on the
  xhtml attribute of the html:html tag being true).  The
  problem is that
  we have no way to know how many existing Struts apps depend
  on the current
  behavior, and this is a pretty serious change.

 +1

 I believe this is why we introduced the 'xhtml' attribute in the first
 place. The catch is that if we always emit XHTML, there is *no* workaround
 for the apps that we break, short of abandoning the Struts HTML tags.

 We also have to consider that not all clients are browsers. I, for one, am
 not going to claim that all HTML parsers out there are XHTML compatible.


Don't know If my opinion counts for anybody but I will say it anyway.

I'm very interested in xhtml output for struts 1.1 (we are about to begin a 
project and xhtml is a requirement)  BUT  I'm with Craig and Martin.

xhtml output is not the expected behaviour of struts tags, even if all 
browsers on earth support it!

Also, I remeber I've read that some people where using things like:

html:text  //input 

to get xml output. With xhtml output this would result in

input  //input

that's not valid xml


  I'm all for doing it post-1.1 though.

 If we're going to emit only XHTML, I'd prefer to see this in a 2.0 rather
 than a 1.2, because we'd be breaking backwards compatibility with earlier
 1.x apps. Emitting either, though, controlled by the 'xhtml' attribute,
 would be fine in a 1.x - even 1.1.

As you could expect I would like to see  this in 1.1 controlled by the xhtml 
attribute!!


Salut!!

-- Antoni Reus

--
To unsubscribe, e-mail:   mailto:struts-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org




Re: [Resources] XMLMessageResources and Proposal

2002-10-12 Thread Antoni Reus


A Dissabte 12 Octubre 2002 00:25, Craig R. McClanahan va escriure:



  Do *you*
 really want to have to type all those messages in more than once?  Or
 could I use the same source document to produce both the end user docs and
 the message resources file for the webapp?


Is a plain text property=value file so hard to [include|process|transform] to 
fit  in a documentation?

 Earlier, we had discussed and agreed to converting Struts 1.1 to use
 commons-resources (and make the existing MessageResources classes wrappers
 around it, for backwards compatibility).  I'm still +1 on this, and +1 for
 including both XML and DB based implementations in commons-resources.


I'm +1 on this too, this is a good design, that's one of the things that I 
love of struts, good design.

I was only trying to make a joke about how sometimes people misuse a 
technology becuse its [new|cool ] without thinking about the benefits of 
using it.


-- Antoni Reus

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




1.0.x releases. [was Re: DO NOT REPLY [Bug 13278] - accesskey attribute is not printed in html:link tag]

2002-10-06 Thread Antoni Reus

Hi,

Struts 1.0.2 is a very good product, I have used it in some projects and I am 
very happy with it. 

I know struts 1.1beta2 is almost ready for production, and it's backward 
compatible, but it has a beta in his name, and this is a showstopper for 
managers.

I will have to use Struts 1.0.2  (with Cedric Tiles, perhaps) in a few more 
projects (till 1.1 or 1.1.1 is released).

It seems that early bugs in 1.0.2 where fixed in both STRUTS_1_0_BRANCH and 
HEAD, but later bugs have been fixed only in HEAD,  so I'm backporting a few 
anonying issues from HEAD to STRUTS_1_0_BRANCH, so we can remove some 
workarrounds from our code.

If someone is interested, here is the list of bugs resolved:

* src/share/org/apache/struts/actions/IncludeAction.java

10641   IncludeAction should unwrap request if it is a 
MultipartRequestWrapper

* src/share/org/apache/struts/taglib/html/FormTag.java

5726Reusing instance of FormTag class in Resin
10604   Multiple html:form tags incorrectly render form name with 
tag pooling

* src/share/org/apache/struts/taglib/html/LinkTag.java

11554   accesskey attributes do not show up in html:link (LinkTag)
12209   html:link tabindex isn't working

* src/share/org/apache/struts/taglib/html/ResetTag.java
* src/share/org/apache/struts/taglib/html/SubmitTag.java

9594html:submit without property attribute causes JavaScript error 
with form[...].submit();
13322   html:reset with no attributes defaults with a name of reset




El Dom 06 Oct 2002 00:53, Eddie Bush escribió:
 I think Craig has stated on occassion that if glaring issues are found
 to be in 1.0.2 there could easily be a 1.0.3 ... 1.0.4 ...

 Not being familiar with that attribute, I can't speak to what would be
 an appropriate resolution.

 [EMAIL PROTECTED] wrote:
 DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
 RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
 http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13278.
 ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
 INSERTED IN THE BUG DATABASE.
 
 http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13278
 
 accesskey attribute is not printed in html:link tag
 
 
 
 
 
 --- Additional Comments From [EMAIL PROTECTED]  2002-10-05 22:49
  --- I assume there is no intention of further revisions of Struts
  1.0.2, correct? If so, can we mark this as resolved(wontfix)?


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: please, can me somebody explain strength behaviour of method: Req uestUtils.lookup?

2002-09-27 Thread Antoni Reus

Hi,

El Vie 27 Sep 2002 20:29, Juraj Burian escribió:
 Hi,

 I have defined a custom tag and I need obtain some bean object instance.
 The next code is used:
 // trgName have quotes now 
 trgName = trgName.substring(1, trgName.length() - 1); // remove
 quotes
 trgBean = RequestUtils.lookup(pageContext, trgName, trgScope);

 if(null == trgBean)
 {
 // TODO log + error
 throw new JspException(Can't obtain targetBean!);
 }

 and working, but when quotes are not removed from the string trgName
 RequestUtils.lookup return null.
 I am using last beta version of struct library.
 For me is that behaviour really strength, because in for example WriteTag
 (from bean) is practically same code in use and working. :-)


I am not sure to understand you.

I supose trgName is an attribute of your tag, and you use something like

yourTagLib:yourTag  trgName=beanName trgScope=aScope  

Then trgName shouldn't have quotes.

This is the way WriteTag works

 best regards
 Juraj Burian

 p.s. be kindly please, my English is really terrible :-)
 p.s2. I thing that my tag can by used commonly, What is necessary to do,
 for that?

To make your tag avaliable to other struts users you should create a new Bug 
(enhancemet) in http://nagoya.apache.org/bugzilla, and attach your code, so 
struts developers can review it and and add it to the struts/contrib folder 
if they think it's useful.

P.D: My english isn't very good too :-)


Best Regards,

-- Antoni Reus

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: Browser's cache

2002-09-24 Thread Antoni Reus

In this case you would need to subclass of ActionMapping, and specify
'type' in action-mapping or 'className' in every Action.

Then you would need to subclass RequestProcessor to provide the required 
headers.

I could be done by subclassing ActionForward too :

forward name=something path=/some/path  className=CachingActionForward
set property /
/forward


PD: I looks like that in Struts 1.1 ForwardConfig is used instead of 
ActionForward to configure a forward.

Should className in forward / be a subclass of ForwardConfig?



El Lun 23 Sep 2002 17:57, Eddie Bush escribió:
 What I meant is that you will only be able to use the attributes
 declared in the DTD for the action tag.  For any other properties you
 need to set, you'll have to use set-property elements inside of your
 action:

 action ...
 set-property .../
 /action

 I think my first explaination was as clear as mud.  Hopefully this
 states it more clearly (so someone will help me rectify my
 misinterpretation, if nothing else!)

 Eddie Bush wrote:
  It would be simple to subclass Action and add the properties.  The
  only problem is that digester is only going to set the properties for
  the action you subclass (the one in the DTD -- this is how I
  understand it), so you'll have to nest some set-property elements
  into your action to configure your custom attributes.
 
  Someone please correct me if I am wrong :-)
 
  David Graham wrote:
  All browsers do not listen to the nocache meta tag, which is what I
  think you're talking about.  Even IE doesn't read that tag properly.
  So, it may not be worth the effort to add this to struts.  Your
  struts actions classes could add the nocache header to the response
  before sending which would acheive what you want just not through
  struts-config.xml.
 
  Dave


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: Browser's cache

2002-09-24 Thread Antoni Reus

El Mar 24 Sep 2002 22:07, Antoni Reus escribió:
 PD: I looks like that in Struts 1.1 ForwardConfig is used instead of
 ActionForward to configure a forward.

 Should className in forward / be a subclass of ForwardConfig?


I have looked deep into this, ActionForward is now a subclass of ForwardConfig 
and remains for compatibility.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: Invalid Struts manifest file?

2002-09-10 Thread Antoni Reus

El Mar 10 Sep 2002 05:54, Martin Cooper escribió:
 When I run 'ant compile.library', I am getting the following errors:

 --
 compile.library:
 [style] Transforming into C:\src\jakarta\jakarta-struts\target\library
   [jar] Manifest is invalid: The attribute Class-Path may not occur
 more than once in the same section

 BUILD FAILED

 C:\src\jakarta\jakarta-struts\build.xml:343: Invalid Manifest:
 C:\src\jakarta\jakarta-struts\conf\share\MANIFEST.MF
 --

 This looks like a consequence of changes made to the manifest file a week
 or so ago. What I'm unclear about is whether those changes were invalid or
 I'm doing something wrong.

 I'm using Ant 1.4.1 and Sun JDK 1.4.0_01 on Windows.

 Ideas, anyone?

ANT 1.4.1 doesn't support multiple Class-Path headers in manifest
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4683),
It's fixed in 1.5


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]