Re: [Tails-dev] CSS fixes
sajolida: > CSS is notoriously painful to work with in the project because nobody > likes it, our CSS are super messy, ikiwiki is crap in this regard, etc. Taking a step back. I notice that this year again, we're working around ikiwiki limitations for the donation campaign. Of course we haven't much choice given the timing. But it would be nice to translate these limitations into upstream bug reports *at some point*, otherwise we'll keep repeating "ikiwiki is crap in this regard" and inventing new workarounds as long as we use ikiwiki, which makes me sad, makes everyone involved spend time rather pointlessly, and contradicts our "Relationship with upstream" statement. I'd be happy to help translate "ikiwiki is crap in this regard" into actionable bug reports, but I can't do it alone. Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
u: > sajolida: >> u: >>> sajolida: u: > sajolida: >> u: I'm merging your two answers in one. >> So I procrastinated for about one hour on removing the subtitle from our >> canonical logo. This allowed me then to reuse it as such in the banner >> and have the exact same version work on mobile as well. We're down from >> 3 variations to 1! >> >> I pushed that in feature/smallCSSfixes. >> >> Tell me what you think. >> >> The ticket about removing the subtitle from the logo: #14835. >> But I'll raise the issue on tails-project@ as well. >> >> And regarding your branch, I'm fine merging it once we agree on >> something regarding the logo (or even before if you think it will be a >> complicated discussion). > > I find it quite problematic to have this discussion now :( I really > don't want this to stop us from launching our donation campaign. So > let's please not do that. Ok, so I'm backing off. It was pretentious to me to think that my modifications to the logo would be easier to approve than yours :) I push --force (yeah!) a new version of the branch to origin without these changes. > It's been way too complicated already to make > some tiny CSS fixes. Not only is my build wiki setup problematic, but > every time we start moving something somewhere, new issues come up, and > ground discussions are ignited which makes it very very hard for me to > keep my motivation when waiting and working for over three weeks to get > some lines of CSS merged. Yeap. As a workflow recommendation, it's good to always be careful about what kind of changes can be controversial (hint: logo!), and keep an eye on which branch is blocking which. Here for example you could probably have move the more controversial (and not strictly necessary for the donation campaign) changes in a separate branch. CSS is notoriously painful to work with in the project because nobody likes it, our CSS are super messy, ikiwiki is crap in this regard, etc. It's shitty, I know... >> So I procrastinated for about one hour on removing the subtitle from >> our canonical logo. This allowed me then to reuse it as such in the >> banner and have the exact same version work on mobile as well. We're >> down from 3 variations to 1! >> >> I pushed that in feature/smallCSSfixes. >> >> Tell me what you think. > > I think it's nice BUT there needs to be more space on top and bottom. > Stuff needs to breathe.. So please don't add a padding or anything, > because this will break other stuff I did in the donation banner > branch, but instead make the image slightly smaller. > > Now it's 100px in height and the the whole banner is 114px high. I > think we need at least 10-15px on top and below, so the logo should > not be higher than 90px. > > Also, what I find weird is that the USB stick is not horizontally > aligned with the text. You see, the stick is higher than the T and > lower too. I can live with this. > > But I can't live with the missing breathing space. I'm backing off of this proposal, so I'll instead move these comments of yours out to #14835 (and away from the donation campaign) and will work on this more "at some point". Still, I made a commit on top of your branch to remove the subtitle in your logo_mobile.png which was the image that I found problematic and that ignited the ground. After starting the discussion on #14835, I understand that removing the subtitle in the banner is not very controversial, so doing this on the mobile version for now is, I believe, the minimal change that we can do to fix the original issue you raised, and at the same time, avoid having too many versions of the logo proliferate, and not introduce too small text. Again, if this proposal is controversial for you, please ignore it and merge your branch as of fd6c6b2d86 as soon as you want. >> And regarding your branch, I'm fine merging it once we agree on >> something regarding the logo (or even before if you think it will be >> a complicated discussion). >> >> Still, I spotted one little detail (see attachment): in the Farsi >> version the search box is much taller. I narrowed the problem down to >> having a bigger line-height in the input field in there (34px instead >> of 22px reported by Tor Browser). Then I couldn't see where this was >> coming from... But I think we can ignore that, unless you find a >> quick way of solving it. > > I cannot confirm that I see this. And I think you did not push your > modification. My modification was only on the logo and the Farsi bug was already present in your branch (at least on my machine). > Please note that in the donation banner branch I did some other > modifications, like giving a unit to the line-height on body. Which > was actually never taken into account... because of the missing unit > :) ANd I think this fixes quite a lot of stuff. Maybe that's it! Anyway, if you don't see it on your machine and since it's a minor detail I think we can skip that and see what happens once this branch is merged ;)
Re: [Tails-dev] CSS fixes
Hello, sajolida: > u: >> sajolida: >>> u: sajolida: > u: > So I procrastinated for about one hour on removing the subtitle from our > canonical logo. This allowed me then to reuse it as such in the banner > and have the exact same version work on mobile as well. We're down from > 3 variations to 1! > > I pushed that in feature/smallCSSfixes. > > Tell me what you think. I think it's nice BUT there needs to be more space on top and bottom. Stuff needs to breathe.. So please don't add a padding or anything, because this will break other stuff I did in the donation banner branch, but instead make the image slightly smaller. Now it's 100px in height and the the whole banner is 114px high. I think we need at least 10-15px on top and below, so the logo should not be higher than 90px. Also, what I find weird is that the USB stick is not horizontally aligned with the text. You see, the stick is higher than the T and lower too. I can live with this. But I can't live with the missing breathing space. > And regarding your branch, I'm fine merging it once we agree on > something regarding the logo (or even before if you think it will be a > complicated discussion). > > Still, I spotted one little detail (see attachment): in the Farsi > version the search box is much taller. I narrowed the problem down to > having a bigger line-height in the input field in there (34px instead of > 22px reported by Tor Browser). Then I couldn't see where this was coming > from... But I think we can ignore that, unless you find a quick way of > solving it. I cannot confirm that I see this. And I think you did not push your modification. Please note that in the donation banner branch I did some other modifications, like giving a unit to the line-height on body. Which was actually never taken into account... because of the missing unit :) ANd I think this fixes quite a lot of stuff. Please let me know if you need anything else from me before merging this branch. Cheers u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi! sajolida: > u: >> sajolida: >>> u: sajolida: > u: > So I procrastinated for about one hour on removing the subtitle from our > canonical logo. This allowed me then to reuse it as such in the banner > and have the exact same version work on mobile as well. We're down from > 3 variations to 1! > > I pushed that in feature/smallCSSfixes. > > Tell me what you think. > > The ticket about removing the subtitle from the logo: #14835. > But I'll raise the issue on tails-project@ as well. > > And regarding your branch, I'm fine merging it once we agree on > something regarding the logo (or even before if you think it will be a > complicated discussion). I find it quite problematic to have this discussion now :( I really don't want this to stop us from launching our donation campaign. So let's please not do that. It's been way too complicated already to make some tiny CSS fixes. Not only is my build wiki setup problematic, but every time we start moving something somewhere, new issues come up, and ground discussions are ignited which makes it very very hard for me to keep my motivation when waiting and working for over three weeks to get some lines of CSS merged. > Still, I spotted one little detail (see attachment): in the Farsi > version the search box is much taller. I narrowed the problem down to > having a bigger line-height in the input field in there (34px instead of > 22px reported by Tor Browser). Then I couldn't see where this was coming > from... But I think we can ignore that, unless you find a quick way of > solving it. I'll look at that later today. Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
u: > sajolida: >> u: >>> sajolida: u: Also, in your mobile version you pretty much reuse the font size of the logo where "the amnesic incognito live system" is as wide as "Tails" but you also added some extra vertical space that is not present neither in the logo nor on the desktop banner. Is there a reason for that? >>> >>> I did not add any extra vertical space as far as I know. So I don't know >>> where you see that? >> >> See attachment. Compared with our canonical logo: >> >> https://tails.boum.org/contribute/how/promote/material/logo/tails-logo-flat-inverted.png >> >> But that might also mean that our canonical logo is problematic :) > > Actually, what I did: > - the current banner is a gigantic image containing the white text and > image of the USB key and a purple background. > - I wanted to remove this background because > - it makes the image too heavy > - it prevents us from doing a nice :hover on the banner > - it prevents us from resizing the logo on smaller screens Cool! > - The current banner image does not exist as a SVG on the promote page. > - So I took our logo from the promote/ page and exported only the white > parts. I then realized that the banner image's subtitle was much larger > and increased the text to fit this large size. The image I based myself > on was this one: > https://tails.boum.org/contribute/how/promote/material/logo/tails-logo-flat.svg. > > You will also see that the horizontal space between the USB key and the > text has increased. This is because the logo itself contains this space > while this space has been diminished in the current banner. > As a more general note, in terms of style guide (I agree that so far we have none), if we want to spend time on the display of our logo, I'd rather go in the direction of using our logo in more similar ways everywhere than creation new subtle variations. > But I reckon that we're doing this already in the banner so I can't really blame you for continuing doing so :) And I'm not at all saying that you should go edit our logo as part of this but maybe having some discussion about it could be a first step towards and new a better version. > > As hopefully explained in detail above, indeed, the banner is itself > already a modification of the original logo and does not even exist as > part of our promote material. Right. >>> Yes, I figured that the current banner is actually not like what exists >>> on /promote... And I wondered how that version came to life. >> >> Yeah... I (or tchou) probably did some ad hoc fixes on the logo to make >> it fit better. Now I'm thinking that we should instead go in the >> direction of having less logo variations, and maybe fixing the canonical >> logo instead. Anyway, no big deal, low prio, etc. > > We should indeed have less variation. > >>> So I'm fine with keeping the banner as is, and for the mobile version >>> just remove the text below. >> >> Let's try that! >> >> Can you check whether the layout of the canonical logo without the text >> below works well in terms of vertical alignement. And if not propose an >> adjusted layout, maybe for your banner only as a start. >> >> I'm curious to see how it would look like. > > Well, I can make a proposal, but in that case, I will simply use the > original logo with its original spacings and not the banner as it is > now. If you think the original logo has weird spacings, please fix it > before I get into it. > > However, I really do not want this to become a blocker and I don't want > this to eat up more of my time which would be better used to work on the > donation campaign itself. So I procrastinated for about one hour on removing the subtitle from our canonical logo. This allowed me then to reuse it as such in the banner and have the exact same version work on mobile as well. We're down from 3 variations to 1! I pushed that in feature/smallCSSfixes. Tell me what you think. The ticket about removing the subtitle from the logo: #14835. But I'll raise the issue on tails-project@ as well. And regarding your branch, I'm fine merging it once we agree on something regarding the logo (or even before if you think it will be a complicated discussion). Still, I spotted one little detail (see attachment): in the Farsi version the search box is much taller. I narrowed the problem down to having a bigger line-height in the input field in there (34px instead of 22px reported by Tor Browser). Then I couldn't see where this was coming from... But I think we can ignore that, unless you find a quick way of solving it. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi! u: > intrigeri: >> u: >>> intrigeri: >> Given the amount of comments sajolida made + a bunch of new changes >> since he looked at the branch last, I'd like to see him check your >> reply to his review + the current state of the branch, so I'm not >> going to merge this myself. Created https://labs.riseup.net/code/issues/14821 Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi! intrigeri: > u: >> intrigeri: > Indeed, I like it, it's look mch more polished and precise to me! Good! > One comment/question though: in RTL languages, the action toolbar > behaves in a somewhat weird way vs. breadcrumbs. It partly overlays > the breadcrumbs, which produces a weird result in itself, but I can > see some tiny bits of of breadcrumbs text in the empty/transparent > space between actions (e.g. between "Preferences" and "History"), > which is a bit confusing. > I've noticed this on doc/first_steps/persistence/configure.fa.html. I fixed this for RTL languages and some other details while I was at it. > It's a regression compared to what we have on our live website at the > moment. I don't know if that's a blocker, but I want to make sure > you're taking this regression into account when requesting this > merge :) Your call! > > This might also happen on LTR pages if the breadcrumbs are wide > enough, but I didn't check. For LTR languages, this is expected to overlay the breadcrumbs. The actions toolbar being visible only once we hover it I don't see this as a problem, it's a feature :) >> So I hope it is mergeable now :) > > Given the amount of comments sajolida made + a bunch of new changes > since he looked at the branch last, I'd like to see him check your > reply to his review + the current state of the branch, so I'm not > going to merge this myself. Fine with me. > Apart of the aforementioned RTL issue, I personally only have one tiny > comment left on this branch. Commit 7363d4a (that's really not atomic > enough for my taste BTW, but well, whatever) fixes some indentation > but introduces another buggy one: > > @@ -887,7 +883,9 @@ background:#EE; > white-space: nowrap; > font-size: 0.9rem; > line-height: 2.2em; > + height: 31px; > } > + Fixed. I will modify my dotfiles to stop doing this. Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi, u: > intrigeri: >> Done. Everything looks fine to me except the actions toolbar change >> that I've just reported in another sub-thread. > I've fixed this now and made it much cleaner and nice IMO. Indeed, I like it, it's look mch more polished and precise to me! One comment/question though: in RTL languages, the action toolbar behaves in a somewhat weird way vs. breadcrumbs. It partly overlays the breadcrumbs, which produces a weird result in itself, but I can see some tiny bits of of breadcrumbs text in the empty/transparent space between actions (e.g. between "Preferences" and "History"), which is a bit confusing. I've noticed this on doc/first_steps/persistence/configure.fa.html. It's a regression compared to what we have on our live website at the moment. I don't know if that's a blocker, but I want to make sure you're taking this regression into account when requesting this merge :) Your call! This might also happen on LTR pages if the breadcrumbs are wide enough, but I didn't check. > So I hope it is mergeable now :) Given the amount of comments sajolida made + a bunch of new changes since he looked at the branch last, I'd like to see him check your reply to his review + the current state of the branch, so I'm not going to merge this myself. Apart of the aforementioned RTL issue, I personally only have one tiny comment left on this branch. Commit 7363d4a (that's really not atomic enough for my taste BTW, but well, whatever) fixes some indentation but introduces another buggy one: @@ -887,7 +883,9 @@ background:#EE; white-space: nowrap; font-size: 0.9rem; line-height: 2.2em; + height: 31px; } + Thanks, cheers! -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi! intrigeri: > Hi, > > u: >> intrigeri: intrigeri: > Done. Everything looks fine to me except the actions toolbar change > that I've just reported in another sub-thread. I've fixed this now and made it much cleaner and nice IMO. So I hope it is mergeable now :) Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
u: > for the future donation campaign I need a clean start.. > That's why I implemented some small CSS fixes. Please review and merge: > > 451f:tails/feature/smallCSSfixes Hey! It's so cool that you are doing some housekeeping on our CSS. It definitely needs it! Some comments: - I'm not a fan of the mobile version of the logo. I understand that you put the subtitle "the amnesic incognito live system" in a smaller font so that it fits on the screen but now the font is barely readable for me (with my glasses on and no colorblindness). I wonder if we should instead get rid of the subtitle in the mobile version. And I came to wonder whether we should even get rid of it in all versions of the logo or make it optional as it's not very appropriate for smaller rendering like in the banner or on small stickers. Removing it might help us solve what I see as a uneasy tension in the vertical alignment between (Tails + the amnesic incognito live system) and the icon. Also, in your mobile version you pretty much reuse the font size of the logo where "the amnesic incognito live system" is as wide as "Tails" but you also added some extra vertical space that is not present neither in the logo nor on the desktop banner. Is there a reason for that? As a more general note, in terms of style guide (I agree that so far we have none), if we want to spend time on the display of our logo, I'd rather go in the direction of using our logo in more similar ways everywhere than creation new subtle variations. But I reckon that we're doing this already in the banner so I can't really blame you for continuing doing so :) And I'm not at all saying that you should go edit our logo as part of this but maybe having some discussion about it could be a first step towards and new a better version. - I like the fixes on the sidebar and three-blocks for mobiles! - I like the fixes to the breadcrumbs! So after you gave me your take on the logo issue we're ready to merge! ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi! intrigeri: > Hi, > > u: >> intrigeri: intrigeri: > Done. Everything looks fine to me except the actions toolbar change > that I've just reported in another sub-thread. I did not do that on purpose, no, so I have to check what's going on. > Once that last problem (?) is addressed, shall I merge myself or do > you think sajolida should take a look? On the one hand he did not > comment since a week here, but OTOH this branch is modifying a few > tricky bits he implemented in the first place, so I'm a little bit > worried that it could have unintended consequences in corner cases we > didn't think about. But anyway, if anything breaks, we can always > hotfix it, so one option could be that I merge at a time when you're > ready to follow-up if needed during the following week or so. What do > you think? I have the feeling that sajolida does not have time atm for this kind of thing. So I'd rather go for the hotfix option. Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi, intrigeri: > oops, I forgot — please make sure you test the last version of your > changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div > class="actions" that's only displayed when the CGI is enabled has > great potential to mess with the div id="otherlanguages". I've rebuilt the wiki from current master with your proposed branch merged in: $ ./build-website --setup ikiwiki-cgi.setup --rebuild … and the aforementioned actions toolbar is visible on non-translatable pages (e.g. contribute/how/code.html), but I can't see it on translatable pages (e.g. index.en.html). This toolbar seems to be correctly defined in the HTML so I assume the CSS is hiding it. I've compared with our current live website, where this toolbar is visible on all pages as intended so far. Did you change this behavior + functionality on purpose? (I could find no explanation in the commit log, except perhaps commit d2d5d8d aka. "Make other languages stick to the correct place"). Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi, u: > intrigeri: >>> intrigeri: >> I do see a border, both in Chromium 60.0.3112.78-1 and Firefox >> 52.3.0esr-2. [...] > Anyhow, I fixed that now. Confirmed! > Ready for another round of reviewing? :) Done. Everything looks fine to me except the actions toolbar change that I've just reported in another sub-thread. Once that last problem (?) is addressed, shall I merge myself or do you think sajolida should take a look? On the one hand he did not comment since a week here, but OTOH this branch is modifying a few tricky bits he implemented in the first place, so I'm a little bit worried that it could have unintended consequences in corner cases we didn't think about. But anyway, if anything breaks, we can always hotfix it, so one option could be that I merge at a time when you're ready to follow-up if needed during the following week or so. What do you think? Cheers! -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
u: > intrigeri: >> oops, I forgot — please make sure you test the last version of your >> changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div >> class="actions" that's only displayed when the CGI is enabled has >> great potential to mess with the div id="otherlanguages". > I think this is why the border did actually not display when I compiled > the wiki. Do you mean, you did not see the border because you were building with ikiwiki-cgi.setup? (I was building with ikiwiki.setup myself when I saw the border.) If you were building with ikiwiki.setup too but didn't see the border, then I'm concerned that either your build system or mine (or the way we run ikiwiki) is buggy, and then one of us is not evaluating the correct output while developing or reviewing. I'm not sure what to do about this :/ Cheers! -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi!
intrigeri:
> Hi,
>
> u:
>> intrigeri:
>>> u:
>>> commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
>>> border-bottom to the links to translations, while the commit message
>>> says "Make other languages stick to the correct place", so perhaps
>>> that was not intended?
> I do see a border, both in Chromium 60.0.3112.78-1 and Firefox
> 52.3.0esr-2.
>
>> I don't see that border
>
> Weird. So either your website build system / process is buggy, or mine
> is. Unless that's because we run different versions of ikiwiki. I have
> the one from sid.
> Firefox developer tools tell me that the black border comes from
> ikiwiki's style.css, that reads:
>
> .pageheader #otherlanguages {
> border-bottom: 1px solid #000;
> }
Interesting. This did not show up when I compiled ikiwiki.
Anyhow, I fixed that now. Thanks for the screenshot.
> That was last changed on 2009-08-15 so I doubt the "we run different
>> I'll convert all tabs to four spaces. Done.
>
> Thanks! Now I see a new kind of inconsistencies though: 4-spaces vs.
> 8-spaces indentation, sometimes in the same block.
Fixed too and pushed to the same branch and my repository.
> I'm not commenting on each individual fix you did as a follow-up to my
> initial review, but they all look good to me :)
Good.
Ready for another round of reviewing? :)
Cheers!
u.
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to
tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi1 intrigeri: > Hi again, > > oops, I forgot — please make sure you test the last version of your > changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div > class="actions" that's only displayed when the CGI is enabled has > great potential to mess with the div id="otherlanguages". I think this is why the border did actually not display when I compiled the wiki. Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi again, oops, I forgot — please make sure you test the last version of your changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div class="actions" that's only displayed when the CGI is enabled has great potential to mess with the div id="otherlanguages". Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi,
u:
> intrigeri:
>> u:
>> commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
>> border-bottom to the links to translations, while the commit message
>> says "Make other languages stick to the correct place", so perhaps
>> that was not intended?
> Uh, "it *seems* to add a black border-bottom" or it does add a border?
Sorry for being unclear: "seems" only applied to my analysis of the
root cause :)
I do see a border, both in Chromium 60.0.3112.78-1 and Firefox
52.3.0esr-2.
> I don't see that border
Weird. So either your website build system / process is buggy, or mine
is. Unless that's because we run different versions of ikiwiki. I have
the one from sid.
> and git show
> d2d5d8d76449eab066bb1e992724d13b0b24496f shows indeed that I removed a
> border, but there is no border which this div inherits, and thus, this
> line is not necessary.
Firefox developer tools tell me that the black border comes from
ikiwiki's style.css, that reads:
.pageheader #otherlanguages {
border-bottom: 1px solid #000;
}
That was last changed on 2009-08-15 so I doubt the "we run different
versions of ikiwiki" hypothesis can explain the discrepancy.
> Care to send me a screenshot?
Sure, attached.
>> I see a few indentation (e.g. tabs vs. spaces) inconsistencies
>> introduced by this branch.
> I'll convert all tabs to four spaces. Done.
Thanks! Now I see a new kind of inconsistencies though: 4-spaces vs.
8-spaces indentation, sometimes in the same block.
>>> I would appreciate if this
>>> could be merged before starting the donation campaign, that is.. quite
>>> soonish :)
>>
>> I've built the website and noticed no obvious problem, so once these
>> issues have been fixed I'm happy to merge, unless you think it's more
>> reasonable to let sajolida review first. Now, something more specific
>> than "quite soonish" would help me prioritize my work :)
> Soonish was supposed to mean that I'd like to merge this into my
> donation banner branch, which will also have to be reviewed at some
> point early in October latest delay.
> So the earlier the better, without stress though.
OK, sounds doable!
I'm not commenting on each individual fix you did as a follow-up to my
initial review, but they all look good to me :)
Cheers,
--
intrigeri
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to
tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi! intrigeri: > u: > Meta: I'm not a CSS person so I'll only nitpick^Wcomment on stuff I am > at ease with. Very good :) > commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black > border-bottom to the links to translations, while the commit message > says "Make other languages stick to the correct place", so perhaps > that was not intended? Uh, "it *seems* to add a black border-bottom" or it does add a border? I don't see that border and git show d2d5d8d76449eab066bb1e992724d13b0b24496f shows indeed that I removed a border, but there is no border which this div inherits, and thus, this line is not necessary. Care to send me a screenshot? > Please use ./wiki/src/contribute/how/documentation/compress-image.sh > on the new images and rewrite history (so we don't import two > versions of the same image into .git :) Ack. Ok, that's done, rather poorly though, it mixes part of CSS commit with these images. I'm not the queen of rewriting history apparently! But well. I'll do better next time. > It looks like lib/banner.png is not used anymore. Remove it? Right! Done. > I see a few indentation (e.g. tabs vs. spaces) inconsistencies > introduced by this branch. I'll convert all tabs to four spaces. Done. > While you're doing house-cleaning, I see "0,5s" transitions in a few > places you don't touch. Is the comma supported there (as opposed to > "0.5s") or do we have code that doesn't do what one might think? :) No, a comma is indeed not supported, so I will clean this. Done. >> I would appreciate if this >> could be merged before starting the donation campaign, that is.. quite >> soonish :) > > I've built the website and noticed no obvious problem, so once these > issues have been fixed I'm happy to merge, unless you think it's more > reasonable to let sajolida review first. Now, something more specific > than "quite soonish" would help me prioritize my work :) Soonish was supposed to mean that I'd like to merge this into my donation banner branch, which will also have to be reviewed at some point early in October latest delay. So the earlier the better, without stress though. Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
u: > Hi! > for the future donation campaign I need a clean start.. > That's why I implemented some small CSS fixes. Please review and merge: > 451f:tails/feature/smallCSSfixes Thanks! Meta: I'm not a CSS person so I'll only nitpick^Wcomment on stuff I am at ease with. commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black border-bottom to the links to translations, while the commit message says "Make other languages stick to the correct place", so perhaps that was not intended? Please use ./wiki/src/contribute/how/documentation/compress-image.sh on the new images and rewrite history (so we don't import two versions of the same image into .git :) It looks like lib/banner.png is not used anymore. Remove it? I see a few indentation (e.g. tabs vs. spaces) inconsistencies introduced by this branch. While you're doing house-cleaning, I see "0,5s" transitions in a few places you don't touch. Is the comma supported there (as opposed to "0.5s") or do we have code that doesn't do what one might think? :) > I would appreciate if this > could be merged before starting the donation campaign, that is.. quite > soonish :) I've built the website and noticed no obvious problem, so once these issues have been fixed I'm happy to merge, unless you think it's more reasonable to let sajolida review first. Now, something more specific than "quite soonish" would help me prioritize my work :) Cheers! -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] CSS fixes
Hi! u: > Hi! > > for the future donation campaign I need a clean start.. > That's why I implemented some small CSS fixes. Please review and merge: > > 451f:tails/feature/smallCSSfixes I've added some more fixes on topright now. I would appreciate if this could be merged before starting the donation campaign, that is.. quite soonish :) Cheers! u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
