DO NOT REPLY [Bug 12989] - JSTL c:out uses body-default, even if value is not NULL or

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989

JSTL c:out uses body-default, even if value is not NULL or 

[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Servlet  JSP API   |Standard Taglib
Product|Tomcat 4|Taglibs
Version|4.1.12  |1.1



--- Additional Comments From [EMAIL PROTECTED]  2003-02-06 09:34 ---
Actually there are two problems here:
1) Jasper one - if tag implements body tag support and sometimes body is empty
and sometimes not, then we may have next problem:
a)Tag uses body (bodyContent set)
b)Tag sent to pool (bodyContent set)
b)Tag uses empty body (old bodyContent set).
I've resolved this by setting bodyContent attribute to null before sending tag
to pool:
Generator.java, line 1440:
if (ctxt.getOptions().isPoolingEnabled()) {
//We must reset body before sending to pool if it was set before
if (n.implementsBodyTag()  n.getBody() != null)
{
out.printin(tagHandlerVar);
out.println(.setBodyContent(null););
}
out.printin(n.getTagHandlerPoolName());
out.print(.reuse();
out.print(tagHandlerVar);
out.println(););
}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 12989] - JSTL c:out uses body-default, even if value is not NULL or

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989

JSTL c:out uses body-default, even if value is not NULL or 





--- Additional Comments From [EMAIL PROTECTED]  2003-02-06 09:36 ---
Second problem is with standart taglib: it uses needBody variable, but do not
resets it to false in StartTag ( and we may be NOT called release between uses)
Fix is: OutSupport.java, line 122:
public int doStartTag() throws JspException {
  try {
needBody = false;
// print value if available; otherwise, try 'default'
if (value != null) {
out(pageContext, escapeXml, value.toString());
return SKIP_BODY;
} else {

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16830] New: - Jasper do not reset BodyContent for tags with BodySupport and empty content

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16830.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16830

Jasper do not reset BodyContent for tags with BodySupport and empty content

   Summary: Jasper do not reset BodyContent for tags with
BodySupport and empty content
   Product: Tomcat 4
   Version: 4.1.8
  Platform: All
   URL: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989
OS/Version: All
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


This may lead to using old body content, from previous tag usage.
Detailed description and fix is at url above

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 12989] - JSTL c:out uses body-default, even if value is not NULL or

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989

JSTL c:out uses body-default, even if value is not NULL or 

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Critical

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




[GUMP] Build Failure - jakarta-tomcat-jk2-native

2003-02-06 Thread Craig McClanahan

This email is autogenerated from the output from:
http://cvs.apache.org/builds/gump/2003-02-06/jakarta-tomcat-jk2-native.html


Buildfile: build.xml

init.taskdef:

guess.os:
 [echo] build.properties i386.Linux
 [echo] Linux:true Win32:${win32} Netware:${netware} Solaris:${solaris} 
HPUX:${hpux}

init.win32.properties:

init.win32.mc:

init.win32:

init.netware:

init.os:

guess.server:
 [echo] Apache2 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/${env.APACHE2_HOME} 
${apache2.detect}
 [echo] Apache13 /usr true
 [echo] IIS ${iis.home} ${iis.detect}
 [echo] Iplanet ${iplanet.home} ${iplanet.detect}


init:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk2

apache20:

apache13:
[mkdir] Created dir: 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk2/apache13
   [so] Compiling 39 out of 39
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_jni.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_logger_file.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_env.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_apr_socket.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_un.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_config.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_config_file.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_endpoint.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_handler_response.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_handler_logon.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_logger_win32.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_msg_ajp.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_map.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_md5.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_mutex_proc.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_mutex.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_mutex_thread.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_nwmain.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_objCache.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool.c
   [so] Warnings: 
   [so] /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool.c: 
In function `jk2_pool_a_strdup':
   [so] 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool.c:282: 
warning: empty body in an if-statement
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool_apr.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_registry.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_requtil.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_signal.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_user.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c
   [so] Warnings: 
   [so] 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c:449:77:
 warning: backslash and newline separated by space
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_workerEnv.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_jni.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_run.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_status.c
Compiling 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/server/apache13/jk_service_apache13.c
   [so] Warnings: 
   [so] 
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/server/apache13/jk_service_apache13.c:
 In function 

DO NOT REPLY [Bug 16831] New: - Tomcat deletes an .jsp source file!

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16831.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16831

Tomcat deletes an .jsp source file!

   Summary: Tomcat deletes an .jsp source file!
   Product: Tomcat 4
   Version: 4.1.12
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Tomcat deletes an .jsp source file from context's document base, if an OS user, 
under whom Tomcat runs (f.i. SERVICE+SYSTEM) doesn't have file system 
permission to read  execute that .jsp file, but has rights to delete that 
file.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




RE: cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c

2003-02-06 Thread Ignacio J. Ortega
Larry,

 
 Thanks.  The restored mod_jk behavior is the same as
 Tomcat 3.3.x with DecodeInterceptor ... safe=true/,
 the default.  Unsafe escapes give 403's.  We can
 add a similar option to mod_jk to turn off the checking.
 Though, I can't image a situation where it would make
 sense to accept the risks to gain access to these escapes.  

The problem is that i_r2.dll is spitting 403 on any URL that contains
%2F, remeber fuilter do see ALL the request that pass for the IIS
server, we are rejecting URL NOT for tomcat, like in /test%2Ftest.asp,
this is the wrong behaviour the user seeing, and i think it's a little
agressive, dont you? so this needs to be solved..

Saludos, 
Ignacio J. Ortega 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Tomcat ajp13 connector: ajp14 extension how to force apache todo login

2003-02-06 Thread Henri Gomez
Gang Zhang wrote:

Hi:

  I read the ajp faq and noticed that the ajp13 extension allows login to be
performed between apache/IIS and tomcat.  However it was hard for me to find
any information about how to set the password information for apache side.

  I read the java side of the connector, Seems that for tomcat 3.3, the
adaptor do set  the negotion handler, and for tomcat4, I need to add the
negotion handler by myself to the code.  So is the extension already been
done or it is still in its proposal period?


Something to be added in both jk/jk2  A little latter





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 11656] - UTF-8 encoding not supported correctly in included text file or JSP Document

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11656.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11656

UTF-8 encoding not supported correctly in included text file or JSP Document





--- Additional Comments From [EMAIL PROTECTED]  2003-02-06 11:35 ---
A similar (the same?) problem arises if you have a JSP that has UTF8 (or any 
other non-ISO8859-1) encoded content, and that statically includes another JSP 
that has the page directive contentType/charset and pageEncoding attributes set 
for the app.

JSP1.jsp:
--- begin ---
%@ include file=JSP2.jsp %
UTF8 content here
--- end ---


JSP2.jsp
--- begin ---
-- this should set the pageEncoding for JSP1 to UTF-8 but it doesnt --
% page contentType=text/html;charset=UTF-8 pageEncoding=UTF-8 %
--- end ---

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Documentation

2003-02-06 Thread Yann Duponchel
Hello,
I would like to use Tomcat as a Servlet container for non HttpServlets. 
I don't see any problem in doing so but I would like to write a 
specialized Manager, specialized Containers, specialized Connectors and 
maybe other custom components (Valves).  I have been through all the 
documentation I could find:
- proposal.html
- catalina-analysis3_raster.gif
- catalina-analysis1_raster.gif
- catalina-analysis2_raster.gif
but I was wondering if there is a more detailed and up-to-date 
documentation. In particular, the proposal and Javadoc mention that 
configuration is done using a configure method, but looking at the 
source, it seems to indicate that Digesters are used for this purpose 
and the sequence of initialzation defined in the various Rules is rather 
obscur.

So I would be glad if someone could point me to some additional 
documentation, in particular concerning the details of the Tomcat 
architecture (relations between components, functions, implementation, 
invokation sequence, when and how is invoked the SessionManager, ...).

Thank you,

Yann.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Documentation

2003-02-06 Thread Remy Maucherat
Yann Duponchel wrote:

Hello,
I would like to use Tomcat as a Servlet container for non HttpServlets. 
I don't see any problem in doing so but I would like to write a 
specialized Manager, specialized Containers, specialized Connectors and 
maybe other custom components (Valves).  I have been through all the 
documentation I could find:
- proposal.html
- catalina-analysis3_raster.gif
- catalina-analysis1_raster.gif
- catalina-analysis2_raster.gif
but I was wondering if there is a more detailed and up-to-date 
documentation. In particular, the proposal and Javadoc mention that 
configuration is done using a configure method, but looking at the 
source, it seems to indicate that Digesters are used for this purpose 
and the sequence of initialzation defined in the various Rules is rather 
obscur.

So I would be glad if someone could point me to some additional 
documentation, in particular concerning the details of the Tomcat 
architecture (relations between components, functions, implementation, 
invokation sequence, when and how is invoked the SessionManager, ...).

I'm afraid there's only the the documentation bundle distributed with 
Tomcat. In particular, the event system is only documented in the 
javadocs (I recommend browsing the org.apache.catalina package).

Hopefully, that will be enough to get you started ...

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c

2003-02-06 Thread Larry Isaacs


 -Original Message-
 From: Ignacio J. Ortega [mailto:[EMAIL PROTECTED]] 
 Sent: Thursday, February 06, 2003 4:51 AM
 To: 'Tomcat Developers List'
 Subject: RE: cvs commit: 
 jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c
 
 
 Larry,
 
  
  Thanks.  The restored mod_jk behavior is the same as
  Tomcat 3.3.x with DecodeInterceptor ... safe=true/,
  the default.  Unsafe escapes give 403's.  We can
  add a similar option to mod_jk to turn off the checking.
  Though, I can't image a situation where it would make
  sense to accept the risks to gain access to these escapes.  
 
 The problem is that i_r2.dll is spitting 403 on any URL that contains
 %2F, remeber fuilter do see ALL the request that pass for the IIS
 server, we are rejecting URL NOT for tomcat, like in /test%2Ftest.asp,
 this is the wrong behaviour the user seeing, and i think it's a little
 agressive, dont you? so this needs to be solved..
 
 Saludos, 
 Ignacio J. Ortega 
 
 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




RE: cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c

2003-02-06 Thread Larry Isaacs
I'm seem to be getting into a habit of clicking Send instead
of Save. :(

I think this is something that to some degree is a necessary
evil.  Hopefully I will be able to tell more when I can get
back into the code.  The trick is allowing this okay URL
to succeed while preventing malicious uses of %2F from also
succeeding.

Cheers,
Larry

 -Original Message-
 From: Larry Isaacs 
 Sent: Thursday, February 06, 2003 8:02 AM
 To: Tomcat Developers List
 Subject: RE: cvs commit: 
 jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c
 
 
 
 
  -Original Message-
  From: Ignacio J. Ortega [mailto:[EMAIL PROTECTED]] 
  Sent: Thursday, February 06, 2003 4:51 AM
  To: 'Tomcat Developers List'
  Subject: RE: cvs commit: 
  jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c
  
  
  Larry,
  
   
   Thanks.  The restored mod_jk behavior is the same as
   Tomcat 3.3.x with DecodeInterceptor ... safe=true/,
   the default.  Unsafe escapes give 403's.  We can
   add a similar option to mod_jk to turn off the checking.
   Though, I can't image a situation where it would make
   sense to accept the risks to gain access to these escapes.  
  
  The problem is that i_r2.dll is spitting 403 on any URL 
 that contains
  %2F, remeber fuilter do see ALL the request that pass for the IIS
  server, we are rejecting URL NOT for tomcat, like in 
 /test%2Ftest.asp,
  this is the wrong behaviour the user seeing, and i think 
 it's a little
  agressive, dont you? so this needs to be solved..
  
  Saludos, 
  Ignacio J. Ortega 
  
  
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Need review -- WIN32 procrun

2003-02-06 Thread Mladen Turk
Hi,
Something useful for me ;), but would like to hear other people
opinions and sugestions. I've posted that couple of months ago,
but now it's finished.

The sources and binaries are at:
http://jakarta.apache.org/~mturk/

Here is some brief explanation how the thing works:

Procrun

Features:

1. Redirect console applications
2. Running redirected applications as services
3. Console or Windows GUI application mode to avoid any
   temporarily flashing console windows in case the procrun
   is invoked by a GUI program.
4. Running Java applications using default or specified JVM
5. Service management Install/Start/Stop/Delete/Update


Invocation:

procrun [action] [options] [parameters]

Actions:
Actions are two letter codes encapsulated inside double slashes followed
by service name. The service name has to be without spaces.

//IS//serviceName Install the service 
//RS//serviceName Run service
called only when running as service
//SS//serviceName Start the service
//DS//serviceName Delete the service
//TS//serviceName Test the service
Run service as ordinary console application
//US//serviceName Update service
Change services startup parameters


Options:
Options are used for install and update actions and are written to the
serviceName registry parameters.
Options are followed with option parameter. If the option parameter
needs spaces it has to be quoted.

--DisplayName   service display name
This is the name shown in the Windows Services
manager.
--Description   service description
This is the service description shown in the windows
Services manager.

--ImagePath full path to process executable
Full path to the executable to be run as service,
or name of the Java Class Path. In cases when the
service runs JVM or Java binary this is the
parameter passed to -Djava.class.path option.

--Arguments arguments passed to the service
Arguments are enclosed inside double quotation
marks and passed to the service image

--WorkingPath   services working path
Sets the working path to the desired value.

--Java  [auto|java|path to the jvm.dll]
auto:
Auto will cause to load the default JVM read
read from registry.
java[w]:
The default java.exe or javaw.exe will be
located and executed with
-Djava.class.path=ImagePath
If neither java or auto are specified then this
parameter is treated as full path to the jvm.dll

--JavaOptions   list of java options
This is the list of options to be passed to the JVM
The options are separated using hash (#) simbol.
For Example:
-Xmx=100M#-Djava.compiler=NONE

--StartupClass  class name
Class name that will be called if started from JVM
when the applications starts.
The method name is separated by semicolon after the
class name.
The parameters passed to the class method are semicolon
separated values after the method name.
For example:
org/apache/jk/apr/TomcatStarter;Main;start

--ShutdownClass class name
Class name that will be called if started from JVM
when the applications stops. The class has to have
the method Main.
The method name is separated by semicolon after the
class name.
The parameters passed to the class method are semicolon
separated values after the method name.
For example:
 
org/apache/jk/apr/TomcatStarter;Main;stop;some;dummy;params

--StdInputFile  path to the file
The file that will be read an passed as standard
input stream to the redirected application
--StdOutputFile path to the file
Path to the redirected stdout.
--StdErrorFile  path to the file
Path to the redirected stderr.

--Startup   [auto|manual]
The services startup mode Automatic or Manual.
Default value is auto.

Examples:

Installing Tomcat as service:
procrun //IS//Tomcat4 -DisplayName Tomcat 4.1.19 \
--Description Tomcat 4.1.19 LE JDK 1.4
http://jakarta.apache.org; \
--ImagePath c:\devtools\tomcat\41\bin\bootstrap.jar \
--StartupClass
org.apache.catalina.startup.Bootstrap;main;start \
--ShutdownClass
org.apache.catalina.startup.Bootstrap;main;stop \
--Java auto --Startup manual


MT.



Re: Need review -- WIN32 procrun

2003-02-06 Thread Remy Maucherat
Mladen Turk wrote:

Hi,
Something useful for me ;), but would like to hear other people
opinions and sugestions. I've posted that couple of months ago,
but now it's finished.

The sources and binaries are at:
http://jakarta.apache.org/~mturk/

Here is some brief explanation how the thing works:

Procrun

Features:

1. Redirect console applications
2. Running redirected applications as services
3. Console or Windows GUI application mode to avoid any
   temporarily flashing console windows in case the procrun
   is invoked by a GUI program.
4. Running Java applications using default or specified JVM
5. Service management Install/Start/Stop/Delete/Update


Supercool, a replacement for JavaService :)
(well, I didn't try it yet, but the feature list looks great :-D )

Ok, I really think you need to put that code in j-t-c or the commons 
sandbox ;-)

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c

2003-02-06 Thread mturk
mturk   2003/02/06 08:37:47

  Modified:jk/native2/server/isapi jk_isapi_plugin.c
  Log:
  Nacho, we are in the year 2003 ;)
  
  Revision  ChangesPath
  1.56  +2 -2  
jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c
  
  Index: jk_isapi_plugin.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- jk_isapi_plugin.c 5 Feb 2003 22:10:51 -   1.55
  +++ jk_isapi_plugin.c 6 Feb 2003 16:37:47 -   1.56
  @@ -2,7 +2,7 @@
*   *
* The Apache Software License,  Version 1.1 *
*   *
  - *  Copyright (c) 1999-2002 The Apache Software Foundation.  *
  + *  Copyright (c) 1999-2003 The Apache Software Foundation.  *
*   All rights reserved.*
*   *
* = *
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/xdocs build.properties.samples

2003-02-06 Thread mturk
mturk   2003/02/06 08:43:53

  Modified:jk/xdocs build.properties.samples
  Log:
  Remove quotes cause it breaks the geterated style.xsl.
  The style.xsl.in quotes that propery already, so skip
  doubling quote signs.
  
  Revision  ChangesPath
  1.2   +10 -10jakarta-tomcat-connectors/jk/xdocs/build.properties.samples
  
  Index: build.properties.samples
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/build.properties.samples,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- build.properties.samples  1 Jun 2002 21:28:41 -   1.1
  +++ build.properties.samples  6 Feb 2003 16:43:53 -   1.2
  @@ -1,13 +1,13 @@
   #
   # Define the color of html pages.
   #
  -body-bg=#ff
  -body-fg=#00
  -body-link=#525D76
  -banner-bg=#525D76
  -banner-fg=#ff
  -sub-banner-bg=#828DA6
  -sub-banner-fg=#ff
  -table-th-bg=#039acc
  -table-td-bg=#a0ddf0
  -source-color=#023264
  +body-bg=#ff
  +body-fg=#00
  +body-link=#525D76
  +banner-bg=#525D76
  +banner-fg=#ff
  +sub-banner-bg=#828DA6
  +sub-banner-fg=#ff
  +table-th-bg=#039acc
  +table-td-bg=#a0ddf0
  +source-color=#023264
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Need review -- WIN32 procrun

2003-02-06 Thread jean-frederic clere
Remy Maucherat wrote:

Mladen Turk wrote:


Hi,
Something useful for me ;), but would like to hear other people
opinions and sugestions. I've posted that couple of months ago,
but now it's finished.

The sources and binaries are at:
http://jakarta.apache.org/~mturk/

Here is some brief explanation how the thing works:

Procrun

Features:

1. Redirect console applications
2. Running redirected applications as services
3. Console or Windows GUI application mode to avoid any
   temporarily flashing console windows in case the procrun
   is invoked by a GUI program.
4. Running Java applications using default or specified JVM
5. Service management Install/Start/Stop/Delete/Update



Supercool, a replacement for JavaService :)
(well, I didn't try it yet, but the feature list looks great :-D )

Ok, I really think you need to put that code in j-t-c or the commons 
sandbox ;-)

In daemon (jakarta-commons-sandbox/daemon).



Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




RE: Need review -- WIN32 procrun

2003-02-06 Thread Mladen Turk


 -Original Message-
 From: Remy Maucherat [mailto:[EMAIL PROTECTED]] 
  Features:
  
  1. Redirect console applications
  2. Running redirected applications as services
  3. Console or Windows GUI application mode to avoid any
 temporarily flashing console windows in case the procrun
 is invoked by a GUI program.
  4. Running Java applications using default or specified JVM 
 5. Service 
  management Install/Start/Stop/Delete/Update
 
 Supercool, a replacement for JavaService :)
 (well, I didn't try it yet, but the feature list looks great :-D )
 

Glad you like it.

 Ok, I really think you need to put that code in j-t-c or the commons 
 sandbox ;-)
 

Does jakarta-commons-sandbox/src/native/nt/procrun looks good?

MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Need review -- WIN32 procrun

2003-02-06 Thread Remy Maucherat
jean-frederic clere wrote:

Ok, I really think you need to put that code in j-t-c or the commons 
sandbox ;-)


In daemon (jakarta-commons-sandbox/daemon).


+1 :)

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Need review -- WIN32 procrun

2003-02-06 Thread Remy Maucherat
Mladen Turk wrote:


Glad you like it.


Well, maybe you'll have to add one or two features, like being able to 
optionally invoke the stop calls on the running JVM, instead of 
instantiating a new one (at least, I expect that's what you're doing; I 
didn't look at the code). That would allow not using the shutdown 
socket, which is relatively insecure.

Ok, I really think you need to put that code in j-t-c or the commons 
sandbox ;-)



Does jakarta-commons-sandbox/src/native/nt/procrun looks good?


It's jakarta-commons-sandbox/component_name, actually.
As JF proposed, I would see it in 
jakarta-commons-sandbox/daemon/src/native/nt/procrun

BTW, be sure to include the binaries in the CVS (yes, I know it's 
against the rules, but they happen to be impossible to build without 
VC++, so I can't integrate in the build process).

Thanks,
Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 16680] - Internal Server Error on HttpSession.setAttribute()

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16680.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16680

Internal Server Error on HttpSession.setAttribute()

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Major   |Blocker
   Priority|Other   |High



--- Additional Comments From [EMAIL PROTECTED]  2003-02-06 17:14 ---
After converting all the saved state information to be serializable, I now get 
the following, Internal Server Error with the root cause:

java.lang.NoSuchMethodError
at org.apache.catalina.session.StandardSession.setAttribute
(StandardSession.java:1259)
at org.apache.catalina.session.StandardSessionFacade.setAttribute
(StandardSessionFacade.java:191)
at org.apache.catalina.session.StandardSessionFacade.setAttribute
(StandardSessionFacade.java:191)
at javarex.beans.servlet.util.HttpServlet.getPage(HttpServlet.java:576)

The last line is the line number in my servlet corresponding to the following 
line of source code:

session.setAttribute(myName + .stack, form_stack);

where session is defined as:

protected HttpSession session;

and form_stack is a java.util.Stack (which cloneable and serializable).

I've been working on this for week now, and it's blocking me being able to 
release a product -- can't even start a servlet.

-George

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




RE: Need review -- WIN32 procrun

2003-02-06 Thread Mladen Turk


 -Original Message-
 From: Remy Maucherat [mailto:[EMAIL PROTECTED]] 
 
 Well, maybe you'll have to add one or two features, like 
 being able to 
 optionally invoke the stop calls on the running JVM, instead of 
 instantiating a new one (at least, I expect that's what 
 you're doing; I 
 didn't look at the code). That would allow not using the shutdown 
 socket, which is relatively insecure.
 

It works similar to jk2, calling start and stop classes, or injecting
the
java.lang.System.exit(0) if the stop class isn't defined.
So --StartupClassorg.apache.catalina.startup.Bootstrap;main;start,
will call the Bootstrap's main method with arg start.

So it doesn't instatiate the new JVM.
That's for inprocess JVM.

If you install the tc with --Java java or --Java javaw, it will
spawn the
java.exe as redirected process.

 Ok, I really think you need to put that code in j-t-c or the commons
 sandbox ;-)
 
  
  
  Does jakarta-commons-sandbox/src/native/nt/procrun looks good?
 
 It's jakarta-commons-sandbox/component_name, actually.
 As JF proposed, I would see it in 
 jakarta-commons-sandbox/daemon/src/native/nt/procrun
 
 BTW, be sure to include the binaries in the CVS (yes, I know it's 
 against the rules, but they happen to be impossible to build without 
 VC++, so I can't integrate in the build process).
 

OK...

MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Need review -- WIN32 procrun

2003-02-06 Thread jean-frederic clere
Remy Maucherat wrote:

Mladen Turk wrote:



Glad you like it.



Well, maybe you'll have to add one or two features, like being able to 
optionally invoke the stop calls on the running JVM, instead of 
instantiating a new one (at least, I expect that's what you're doing; I 
didn't look at the code). That would allow not using the shutdown 
socket, which is relatively insecure.

Ok, I really think you need to put that code in j-t-c or the commons 
sandbox ;-)



Does jakarta-commons-sandbox/src/native/nt/procrun looks good?



It's jakarta-commons-sandbox/component_name, actually.
As JF proposed, I would see it in 
jakarta-commons-sandbox/daemon/src/native/nt/procrun

BTW, be sure to include the binaries in the CVS (yes, I know it's 
against the rules, but they happen to be impossible to build without 
VC++, so I can't integrate in the build process).

I will try to get it build with cygwin. (at home ;-)).

It would be nice to have --InitClass and --DestroyClass options so that the 
BootstrapService of catalina can be used.


Thanks,
Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




RE: Need review -- WIN32 procrun

2003-02-06 Thread Mladen Turk


 -Original Message-
 From: jean-frederic clere 
 [mailto:[EMAIL PROTECTED]] 
 Sent: Thursday, February 06, 2003 6:48 PM
 To: Tomcat Developers List
 Subject: Re: Need review -- WIN32 procrun
 
 
  
  It's jakarta-commons-sandbox/component_name, actually.
  As JF proposed, I would see it in
  jakarta-commons-sandbox/daemon/src/native/nt/procrun
  

It will be but... :(.

 Access denied: Insufficient Karma
(mturk|jakarta-commons-sandbox/daemon/src/native/nt/procrun/)


  BTW, be sure to include the binaries in the CVS (yes, I know it's
  against the rules, but they happen to be impossible to 
 build without 
  VC++, so I can't integrate in the build process).
 
 I will try to get it build with cygwin. (at home ;-)).


The mingw32 builds that (I've tested it with DevC++). You'll need to
change the intptr_t to int *, and of course add the -lshlwapi and
-DPROCRUN_CONSOLE


 
 It would be nice to have --InitClass and --DestroyClass 
 options so that the 
 BootstrapService of catalina can be used.
 

It has:
--StartupClass - called when hit Service start.
--ShutdownClass - called when you hit Stop service...


MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 12989] - JSTL c:out uses body-default, even if value is not NULL or

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12989

JSTL c:out uses body-default, even if value is not NULL or 

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-02-06 18:36 ---
This has been fixed for JSTL 1.0.3, currently available 
via the nightly builds.

*** This bug has been marked as a duplicate of 16069 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




[TC5] Time to make a release?

2003-02-06 Thread Kin-Man Chung
There has been inquiries about a Tomcat 5 release, both in and out
of the mailing list.  I usually direct them to our nightly builds,
but there is no links from the jakarta page, and they are not always
available.  I think it's time that we make a release, to make it
easier for people to try it out.

I know there are a lot of work still going on, and a lot need to be
done to make it into a stable release.  I am thinking about an alpha
release.  Now that JSP 2.0 PFD2 has been published,

(http://jcp.org/aboutJava/communityprocess/first/jsr152/index2.html)

and the jasper implementation has been complete, we need a release for
people to try it out.

Comment?


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: [TC5] Time to make a release?

2003-02-06 Thread Remy Maucherat
Kin-Man Chung wrote:

There has been inquiries about a Tomcat 5 release, both in and out
of the mailing list.  I usually direct them to our nightly builds,
but there is no links from the jakarta page, and they are not always
available.  I think it's time that we make a release, to make it
easier for people to try it out.

I know there are a lot of work still going on, and a lot need to be
done to make it into a stable release.  I am thinking about an alpha
release.  Now that JSP 2.0 PFD2 has been published,

(http://jcp.org/aboutJava/communityprocess/first/jsr152/index2.html)

and the jasper implementation has been complete, we need a release for
people to try it out.

Comment?


The problem was that we were (and still are) in between feature 
additions (new mapper, new JMX features), and right now the result is 
probably flaky.

I would have wanted to get the JSR 77 lifecylce issues fixed (ie, when 
you remove a context, you should remove the associated MBean, so that 
the mapper gets a notification and can do the mapping correctly) before 
tagging a new 5.0.1 alpha.

On the other tree, I still have the JSPC merging to do before tagging 
4.1.20 (early next week, I'll be too busy tomorrow).

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader StandardClassLoader.java

2003-02-06 Thread costin
costin  2003/02/06 11:59:03

  Modified:catalina/src/share/org/apache/catalina/loader Tag:
tomcat_40_branch StandardClassLoader.java
  Log:
  Cutpaste error...
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.24.2.3  +5 -5  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java
  
  Index: StandardClassLoader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java,v
  retrieving revision 1.24.2.2
  retrieving revision 1.24.2.3
  diff -u -r1.24.2.2 -r1.24.2.3
  --- StandardClassLoader.java  5 Feb 2003 22:44:52 -   1.24.2.2
  +++ StandardClassLoader.java  6 Feb 2003 19:59:03 -   1.24.2.3
  @@ -1198,7 +1198,7 @@
   
   // Validate the manifest of a JAR file repository
   if (!repository.endsWith(File.separator) 
  -!repository.endsWith(File.separator)) {
  +!repository.endsWith(/)) {
   try {
   JarFile jarFile = null;
   Manifest manifest = null;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




RE: Need review -- WIN32 procrun

2003-02-06 Thread Craig R. McClanahan


On Thu, 6 Feb 2003, Mladen Turk wrote:


  Access denied: Insufficient Karma
 (mturk|jakarta-commons-sandbox/daemon/src/native/nt/procrun/)

Fixed -- this should work for you now.

Craig

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardWrapper.java StandardWrapperValve.java

2003-02-06 Thread costin
costin  2003/02/06 14:06:34

  Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java StandardWrapperValve.java
  Log:
  Merge few changes from 5.0.
  This only adds getters and setters and some more statistical info
  for the servlet execution.
  
  Revision  ChangesPath
  1.45  +37 -6 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
  
  Index: StandardWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
  retrieving revision 1.44
  retrieving revision 1.45
  diff -u -r1.44 -r1.45
  --- StandardWrapper.java  10 Dec 2002 12:47:05 -  1.44
  +++ StandardWrapper.java  6 Feb 2003 22:06:33 -   1.45
  @@ -123,7 +123,8 @@
   public StandardWrapper() {
   
   super();
  -pipeline.setBasic(new StandardWrapperValve());
  +swValve=new StandardWrapperValve();
  +pipeline.setBasic(swValve);
   
   }
   
  @@ -172,6 +173,7 @@
*/
   private Servlet instance = null;
   
  +private StandardWrapperValve swValve;
   
   /**
* The support object for our instance listeners.
  @@ -833,7 +835,6 @@
   // Nothing to do if we already have an instance or an instance pool
   if (!singleThreadModel  (instance != null))
   return instance;
  -
   PrintStream out = System.out;
   if (swallowOutput) {
   SystemLogHandler.startCapture();
  @@ -1360,5 +1361,35 @@
   
   }
   
  +public long getProcessingTime() {
  +return swValve.getProcessingTime();
  +}
  +
  +public void setProcessingTime(long processingTime) {
  +swValve.setProcessingTime(processingTime);
  +}
  +
  +public long getMaxTime() {
  +return swValve.getMaxTime();
  +}
  +
  +public void setMaxTime(long maxTime) {
  +swValve.setMaxTime(maxTime);
  +}
   
  +public int getRequestCount() {
  +return swValve.getRequestCount();
  +}
  +
  +public void setRequestCount(int requestCount) {
  +swValve.setRequestCount(requestCount);
  +}
  +
  +public int getErrorCount() {
  +return swValve.getErrorCount();
  +}
  +
  +public void setErrorCount(int errorCount) {
  +   swValve.setErrorCount(errorCount);
  +}
   }
  
  
  
  1.35  +50 -23
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java
  
  Index: StandardWrapperValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- StandardWrapperValve.java 15 Mar 2002 19:12:49 -  1.34
  +++ StandardWrapperValve.java 6 Feb 2003 22:06:33 -   1.35
  @@ -66,34 +66,22 @@
   
   
   import java.io.IOException;
  -import java.io.PrintWriter;
  -import javax.servlet.FilterConfig;
  -import javax.servlet.RequestDispatcher;
   import javax.servlet.Servlet;
  -import javax.servlet.ServletContext;
   import javax.servlet.ServletException;
  -import javax.servlet.ServletOutputStream;
   import javax.servlet.ServletRequest;
   import javax.servlet.ServletResponse;
   import javax.servlet.UnavailableException;
  -import javax.servlet.http.HttpServlet;
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
  -import org.apache.catalina.Container;
   import org.apache.catalina.Context;
   import org.apache.catalina.Globals;
   import org.apache.catalina.HttpRequest;
  -import org.apache.catalina.HttpResponse;
   import org.apache.catalina.Logger;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
   import org.apache.catalina.ValveContext;
  -import org.apache.catalina.Wrapper;
  -import org.apache.catalina.deploy.ErrorPage;
   import org.apache.catalina.deploy.FilterDef;
   import org.apache.catalina.deploy.FilterMap;
  -import org.apache.catalina.util.InstanceSupport;
  -import org.apache.catalina.util.RequestUtil;
   import org.apache.catalina.util.StringManager;
   import org.apache.catalina.valves.ValveBase;
   
  @@ -124,6 +112,13 @@
*/
   private FilterDef filterDef = null;
   
  +// Some JMX statistics. This vavle is associated with a StandardWrapper.
  +// We exponse the StandardWrapper as JMX ( j2eeType=Servlet ). The fields
  +// are here for performance.
  +private long processingTime;
  +private long maxTime;
  +private int requestCount;
  +private int errorCount;
   
   /**
* The descriptive information related to this implementation.
  @@ -169,7 +164,8 @@
   public void invoke(Request request, Response response,
  

Tomcat 5 nightly

2003-02-06 Thread Amy Roh
Where are the nightly builds for tomcat 5 getting uploaded?  I'm trying 
to update jakarta binary page to include tomcat 5 nightly so that more 
people can get a hold of it instead of having to check out and compile 
the source code (although I must say it's very easy check out and 
compile the source now, however, it'll definitely make it more easier 
for people to try it out.)  I found 
http://jakarta.apache.org/builds/jakarta-tomcat/nightly-5.  But it looks 
like it only contains admin classes and api docs.  Are we building 
nightly?

Thanks,
Amy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 5 nightly

2003-02-06 Thread Remy Maucherat
Amy Roh wrote:

Where are the nightly builds for tomcat 5 getting uploaded?  I'm trying 
to update jakarta binary page to include tomcat 5 nightly so that more 
people can get a hold of it instead of having to check out and compile 
the source code (although I must say it's very easy check out and 
compile the source now, however, it'll definitely make it more easier 
for people to try it out.)  I found 
http://jakarta.apache.org/builds/jakarta-tomcat/nightly-5.  But it looks 
like it only contains admin classes and api docs.  Are we building nightly?

I have no idea about those nightlies.

BTW, except for Gump (which is doing it for testing purposes), I really 
don't see the point of having nightlies. Instead, we should focus on 
having even easier and more automated build systems. This could very 
well end up attracting contributors (once they realize it's easy to get 
started).

(Of course, I won't prevent anyone from setting up nightlies if they 
want to)

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-02-06 Thread costin
costin  2003/02/06 14:58:37

  Modified:catalina/src/share/org/apache/catalina/session
StandardManager.java
  Log:
  Add 2 more fields: number of sessions that expired and number of sessions we rejected
  ( because we reached the limit ).
  This gives info about the activity of the session manager.
  
  Revision  ChangesPath
  1.21  +36 -6 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardManager.java
  
  Index: StandardManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardManager.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- StandardManager.java  11 Oct 2002 06:59:35 -  1.20
  +++ StandardManager.java  6 Feb 2003 22:58:37 -   1.21
  @@ -181,6 +181,8 @@
*/
   private String threadName = StandardManager;
   
  +private int rejectedSessions=0;
  +private int expiredSessions=0;
   
   // - Properties
   
  @@ -259,6 +261,31 @@
   
   }
   
  +/** Number of session creations that failed due to maxActiveSessions
  + *
  + * @return
  + */
  +public int getRejectedSessions() {
  +return rejectedSessions;
  +}
  +
  +public void setRejectedSessions(int rejectedSessions) {
  +this.rejectedSessions = rejectedSessions;
  +}
  +
  +/** Number of sessions that expired.
  + *
  + * @return
  + */
  +public int getExpiredSessions() {
  +return expiredSessions;
  +}
  +
  +public void setExpiredSessions(int expiredSessions) {
  +this.expiredSessions = expiredSessions;
  +}
  +
  +
   
   /**
* Set the maximum number of actives Sessions allowed, or -1 for
  @@ -328,9 +355,11 @@
   public Session createSession() {
   
   if ((maxActiveSessions = 0) 
  -  (sessions.size() = maxActiveSessions))
  +  (sessions.size() = maxActiveSessions)) {
  +rejectedSessions++;
   throw new IllegalStateException
   (sm.getString(standardManager.createSession.ise));
  +}
   
   return (super.createSession());
   
  @@ -572,7 +601,7 @@
   
   
   /**
  - * Get the lifecycle listeners associated with this lifecycle. If this 
  + * Get the lifecycle listeners associated with this lifecycle. If this
* Lifecycle has no listeners registered, a zero-length array is returned.
*/
   public LifecycleListener[] findLifecycleListeners() {
  @@ -760,6 +789,7 @@
   (int) ((timeNow - session.getLastAccessedTime()) / 1000L);
   if (timeIdle = maxInactiveInterval) {
   try {
  +expiredSessions++;
   session.expire();
   } catch (Throwable t) {
   log(sm.getString(standardManager.expireException), t);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session ManagerBase.java

2003-02-06 Thread costin
costin  2003/02/06 15:01:41

  Modified:catalina/src/share/org/apache/catalina/session
ManagerBase.java
  Log:
  Another backport from head: more informations about the session creation (to
  be exposed via JMX or used directly ).
  
  This is very usefull in debugging and in finding out what happens in production
  servers.
  
  Revision  ChangesPath
  1.18  +115 -8
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java
  
  Index: ManagerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- ManagerBase.java  1 Jan 2003 06:24:26 -   1.17
  +++ ManagerBase.java  6 Feb 2003 23:01:41 -   1.18
  @@ -73,6 +73,9 @@
   import java.util.ArrayList;
   import java.util.HashMap;
   import java.util.Random;
  +import java.util.Iterator;
  +import java.util.Date;
  +
   import org.apache.catalina.Container;
   import org.apache.catalina.DefaultContext;
   import org.apache.catalina.Engine;
  @@ -135,8 +138,8 @@
* The DefaultContext with which this Manager is associated.
*/
   protected DefaultContext defaultContext = null;
  -
  -
  +
  +
   /**
* Return the MessageDigest implementation to be used when
* creating session identifiers.
  @@ -203,6 +206,14 @@
*/
   protected HashMap sessions = new HashMap();
   
  +// Total number of sessions created by this manager
  +protected int sessionCounter=0;
  +
  +protected int maxActive=0;
  +
  +// number of duplicated session ids - anything 0 means we have problems
  +protected int duplicates=0;
  +
   
   /**
* The string manager for this package.
  @@ -290,8 +301,8 @@
   support.firePropertyChange(defaultContext, oldDefaultContext, 
this.defaultContext);
   
   }
  -
  -
  +
  +
   /**
* Return the debugging detail level for this component.
*/
  @@ -530,6 +541,9 @@
   
   synchronized (sessions) {
   sessions.put(session.getId(), session);
  +if( sessions.size()  maxActive ) {
  +maxActive=sessions.size();
  +}
   }
   
   }
  @@ -588,6 +602,7 @@
   synchronized (sessions) {
   while (sessions.get(sessionId) != null){ // Guarantee uniqueness
   sessionId = generateSessionId();
  +duplicates++;
   // @todo Move appending of jvmRoute generateSessionId()???
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
  @@ -596,6 +611,7 @@
   }
   
   session.setId(sessionId);
  +sessionCounter++;
   
   return (session);
   
  @@ -795,5 +811,96 @@
   
   }
   
  +public void setSessionCounter(int sessionCounter) {
  +this.sessionCounter = sessionCounter;
  +}
  +
  +/** Total sessions created by this manager.
  + *
  + * @return sessions created
  + */
  +public int getSessionCounter() {
  +return sessionCounter;
  +}
  +
  +/** Number of duplicated session IDs generated by the random source.
  + *  Anything bigger than 0 means problems.
  + *
  + * @return
  + */
  +public int getDuplicates() {
  +return duplicates;
  +}
  +
  +public void setDuplicates(int duplicates) {
  +this.duplicates = duplicates;
  +}
  +
  +/** Returns the number of active sessions
  + *
  + * @return number of sessions active
  + */
  +public int getActiveSessions() {
  +return sessions.size();
  +}
  +
  +/** Max number of concurent active sessions
  + *
  + * @return
  + */
  +public int getMaxActive() {
  +return maxActive;
  +}
  +
  +public void setMaxActive(int maxActive) {
  +this.maxActive = maxActive;
  +}
  +
  +/** For debugging: return a list of all session ids currently active
  + *
  + */
  +public String listSessionIds() {
  +StringBuffer sb=new StringBuffer();
  +Iterator keys=sessions.keySet().iterator();
  +while( keys.hasNext() ) {
  +sb.append(keys.next()).append( );
  +}
  +return sb.toString();
  +}
  +
  +/** For debugging: get a session attribute
  + *
  + * @param sessionId
  + * @param key
  + * @return
  + */
  +public String getSessionAttribute( String sessionId, String key ) {
  +Session s=(Session)sessions.get(sessionId);
  +if( s==null ) {
  +log(Session not found  + sessionId);
  +return null;
  +}
  +Object o=s.getSession().getAttribute(key);
  +if( o==null ) return null;
  +return 

[REPOST from -user]: definitive answer on JSPC?

2003-02-06 Thread Brett Porter
Hi,

I didn't really get an answer on -user so I was hoping that it might be 
able to be addressed here. Thanks for your time, and I'd appreciate a CC 
to the -user list on responses so it can end up in those archives.

Regards,
Brett Porter
---BeginMessage---
Hi,

I'm looking for a definitive answer about JSPC in Tomcat 4.1 and 
precompilation. Searching the archives hasn't yielded answers to the 
questions I've been curious about. It'd be great to get definitive 
answers for the archive, and perhaps a FAQ as it is not covered in 
either tomcat-user, the doco, or JGuru.

Background: In TC3.2.4 I currently precompile all JSPs using the ant 
jspc task and the TC3.2 jasper/webserver jars.  I then munged the 
generated java files into the format required by TC3.2.4 and compiled 
them, then renamed them again to match. A little weird, but it worked 
since it used a flat directory structure, formatting the filenames 
with_002f etc. I dropped this into /WEB-INF/classes/precompiled_jsp and 
symlinked it from work/localhost_8080%2Fapps.

The reason this was necessary was that the server choked under the load 
trying to compile the JSPs. There seemed to be no deadlocking so it 
would spawn numerous javacs and start swapping, and you get the picture :)

With TC4.1 I can't take this approach because of the (albeit nicer) 
directory approach. However, because of duplicate names and the same 
package being used, I will need to compile each java file individually, 
complicating the build process considerably.

BTW, I'm aware of ?jsp_precompile=1 and it's not suitable.

Here are my questions regarding jspc from ant/cmd line:
1) is the definitive way to do it supposed to be the web.xml include 
method? If so, shouldn't JSP take a web.xml input and output a processed 
one? Regardless, doesn't this have negative side effects, like not then 
being able to edit the JSPs to make changes? (note that while we 
precompile, we may need to change some, and filtering them out would be 
a fair nuisance).
2) is there a way to do what I am looking for above, generating classes 
for all JSPs that are not fragments (for static include) which can be 
placed in the work dir? Does it have to have the same layout as the 
server to work?
3) what is the reason for the current layout and differences between cmd 
line and server compilation? ie. different dirs but same package.

My desired requirements for JSPC to work would be:
1) both JSPC and server generate the same java files to the same locations.
2) javac can be executed on the base directory on **/*.java, and the 
resulting classes dropped into the work directory. They would be used as 
long as their timestamps were newer than the jsp in question.

To achieve this, I'd suggest this:
1) package name is org.apache.jsp.PATH.TO.FILE (substituting/eliminating 
special characters - eg WEB-INF - WEBINF)
2) class remains myJsp_jsp.java
3) have TC not only look under work but /WEB-INF/classes to avoid the 
symlink (ie if I specified my package as precompiled_jsp I'd get the 
result as I have for 3.2.4).

And a final question: how likely am I to encounter the problems had with 
3.2.4 if I upgrade to 4.1? I believe the jasper2 compiler is designed to 
be much more effecient - will it avoid generating the java files more 
than once and hence compiling them more than once, instead synchronizing 
on the operation? (this is effectively enough, although precompilation 
would still be even faster).

I'd appreciate any responses regarding this, and apologise for the 
verbosity level of the email! :)

Thanks,
Brett



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---End Message---
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c

2003-02-06 Thread nacho
nacho   2003/02/06 15:34:45

  Modified:jk/native2/server/isapi jk_isapi_plugin.c
  Log:
  Fix for Bug#16759 ISAPI_REDIRECTOR Handles %2F improperly
  
  Was refusing any URL with %2F or %00  embedded always,
  now it only refuses request mapped to tomcat..
  
  Revision  ChangesPath
  1.57  +19 -18
jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c
  
  Index: jk_isapi_plugin.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c,v
  retrieving revision 1.56
  retrieving revision 1.57
  diff -u -r1.56 -r1.57
  --- jk_isapi_plugin.c 6 Feb 2003 16:37:47 -   1.56
  +++ jk_isapi_plugin.c 6 Feb 2003 23:34:45 -   1.57
  @@ -315,22 +315,6 @@
   }
   
   rc = jk_requtil_unescapeUrl(uri);
  -if (rc == BAD_REQUEST) {
  -env-l-jkLog(env, env-l,  JK_LOG_ERROR, 
  -   HttpFilterProc [%s] contains one or more invalid escape 
sequences.\n, 
  -   uri);
  -write_error_response(pfc,400 Bad Request, HTML_ERROR_400);
  -workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
  -return SF_STATUS_REQ_FINISHED;
  -}
  -else if(rc == BAD_PATH) {
  -env-l-jkLog(env, env-l,  JK_LOG_EMERG, 
  -   HttpFilterProc [%s] contains forbidden escape 
sequences.\n, 
  -   uri);
  -write_error_response(pfc,403 Forbidden, HTML_ERROR_403);
  -workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
  -return SF_STATUS_REQ_FINISHED;
  -}
   jk_requtil_getParents(uri);
   
   if (pfc-GetServerVariable(pfc, SERVER_NAME, (LPVOID)Host, 
(LPDWORD)szHost)){
  @@ -354,6 +338,23 @@
   char *forwardURI;
   
   /* This is a servlet, should redirect ... */
  +/* First check if the request was invalidated at decode */
  +if (rc == BAD_REQUEST) {
  +env-l-jkLog(env, env-l,  JK_LOG_ERROR, 
  +HttpFilterProc [%s] contains one or more invalid 
escape sequences.\n, 
  +uri);
  +write_error_response(pfc,400 Bad Request, HTML_ERROR_400);
  +workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env 
);
  +return SF_STATUS_REQ_FINISHED;
  +}
  +else if(rc == BAD_PATH) {
  +env-l-jkLog(env, env-l,  JK_LOG_EMERG, 
  +HttpFilterProc [%s] contains forbidden escape 
sequences.\n, 
  +uri);
  +write_error_response(pfc,403 Forbidden, HTML_ERROR_403);
  +workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env 
);
  +return SF_STATUS_REQ_FINISHED;
  +}
   env-l-jkLog(env, env-l,  JK_LOG_DEBUG, 
  HttpFilterProc [%s] is a servlet url - should redirect 
to %s\n, 
  uri, uriEnv-workerName);
  @@ -408,7 +409,7 @@
   workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, 
env );
   return SF_STATUS_REQ_ERROR;
   }
  -SetHeader(pfc, Translate:, NULL);
  +SetHeader(pfc, Translate:, NULL);
   }
   } else {
   env-l-jkLog(env, env-l,  JK_LOG_DEBUG, 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup Embedded.java Catalina.java

2003-02-06 Thread jfarcand
jfarcand2003/02/06 17:07:14

  Modified:catalina/src/share/org/apache/catalina/startup Embedded.java
Catalina.java
  Log:
  Move the security configuration inside Embedded to allow security protection when 
this class is used.
  
  Revision  ChangesPath
  1.5   +15 -5 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Embedded.java
  
  Index: Embedded.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Embedded.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- Embedded.java 14 Jan 2003 22:41:01 -  1.4
  +++ Embedded.java 7 Feb 2003 01:07:13 -   1.5
  @@ -93,6 +93,7 @@
   import org.apache.catalina.logger.SystemOutLogger;
   import org.apache.catalina.net.ServerSocketFactory;
   import org.apache.catalina.realm.MemoryRealm;
  +import org.apache.catalina.security.SecurityConfig;
   import org.apache.catalina.util.LifecycleSupport;
   import org.apache.catalina.util.StringManager;
   import org.apache.commons.logging.LogFactory;
  @@ -185,7 +186,8 @@
   super();
   setLogger(logger);
   setRealm(realm);
  -
  +setSecurityProtection();
  +
   }
   
   
  @@ -1238,5 +1240,13 @@
   
   }
   
  +/**
  + * Set the security package access/protection.
  + */
  +protected void setSecurityProtection(){
  +SecurityConfig securityConfig = SecurityConfig.newInstance();
  +securityConfig.setPackageDefinition();
  +securityConfig.setPackageAccess();
  +}
   
   }
  
  
  
  1.14  +4 -9  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Catalina.java
  
  Index: Catalina.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Catalina.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- Catalina.java 29 Jan 2003 22:32:09 -  1.13
  +++ Catalina.java 7 Feb 2003 01:07:13 -   1.14
  @@ -75,7 +75,6 @@
   import org.apache.catalina.LifecycleException;
   import org.apache.catalina.Server;
   import org.apache.catalina.core.StandardServer;
  -import org.apache.catalina.security.SecurityConfig;
   import org.apache.commons.digester.Digester;
   import org.apache.commons.digester.Rule;
   import org.apache.tomcat.util.log.SystemLogHandler;
  @@ -486,10 +485,6 @@
   long t2 = System.currentTimeMillis();
   log.debug( Server.xml processed  + (t2 - t1));
   
  -// TODO: move to Embedded
  -SecurityConfig securityConfig = SecurityConfig.newInstance();
  -securityConfig.setPackageDefinition();
  -securityConfig.setPackageAccess();
   
   // Replace System.out and System.err with a custom PrintStream
   // TODO: move to Embedded, make it configurable
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16680] - Internal Server Error on HttpSession.setAttribute()

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16680.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16680

Internal Server Error on HttpSession.setAttribute()

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Blocker |Normal
 Status|NEW |RESOLVED
   Priority|High|Other
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-02-07 01:21 ---
I figured out the problem. I was testing my servlet with both 4.0 and 4.1 
using the -config parameter pointing to same server.xml file. And 4.1 uses a 
different Connector class.

If every minor release of Tomcat is going to be using different classes, it's 
going to make life little more difficult for those testing servlets with 
multiple releases...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16865] New: - EL expressions in tag files no longer works

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865

EL expressions in tag files no longer works

   Summary: EL expressions in tag files no longer works
   Product: Tomcat 5
   Version: Nightly Build
  Platform: All
OS/Version: All
Status: NEW
  Severity: Blocker
  Priority: Other
 Component: Jasper2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Something is fundamentally wrong with EL evaluation in tag files, a bug that
must have been introduced recently (a nightly build from last week worked fine).

This tag file:

  %@ taglib prefix=c uri=http://java.sun.com/jstl/core_rt; %
  %@ tag body-content=scriptless %

  Static text and c:out: c:out value=static text /
  br
  EL expr with variable and c:out: 
  c:out value=${pageContext.request.servletPath} /
  br
  EL expr with variable in text: ${pageContext.request.servletPath}
  br
  EL expr with static text: ${'static text'}

produces this output when invoked from a JSP page:

  Static text and c:out: static text
  EL expr with variable and c:out:
  EL expr with variable in text:
  EL expr with static text: static text 

In other words, evaluation of an EL expression that contains variables (I've
tested with other variables than pageContext, used here) results in the empty
string. An EL expression that only contains static text is evaluated correctly.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16865] - EL expressions in tag files no longer works

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865

EL expressions in tag files no longer works





--- Additional Comments From [EMAIL PROTECTED]  2003-02-07 02:08 ---
The cause for this seems to be that in JspContextWrapper (which is used as the
PageContext implementation in a tag file), the getVariableResolver() method
returns null.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16865] - EL expressions in tag files no longer works

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865

EL expressions in tag files no longer works





--- Additional Comments From [EMAIL PROTECTED]  2003-02-07 02:17 ---
Okay, I've verified that relaying getVariableResolver() in JspContextWrapper to
the original JspContext fixes this problem, i.e.:

  public VariableResolver getVariableResolver() {
invokingJspCtxt.getVariableResolver();
  }

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16865] - EL expressions in tag files no longer works

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865

EL expressions in tag files no longer works





--- Additional Comments From [EMAIL PROTECTED]  2003-02-07 02:40 ---
The suggested fix would only work for attributes that are alredy defined in the
invoking context, and not for those that are defined locally in the tag files. 
I have a fix that I am now testing, and would commit that if it works.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16865] - EL expressions in tag files no longer works

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865

EL expressions in tag files no longer works





--- Additional Comments From [EMAIL PROTECTED]  2003-02-07 02:46 ---
Nae, this is not the complete solution. Now the JSP page scope is used when
resolving variables in the tag file. I guess JspContextWrapper needs its own
VariableResolver that knows about the tag file's local page scope, but how fix
that is beyond what I can figure out at the moment ;-)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime JspContextWrapper.java

2003-02-06 Thread kinman
kinman  2003/02/06 18:51:32

  Modified:jasper2/src/share/org/apache/jasper/runtime
JspContextWrapper.java
  Log:
  - Fix 16865: JspContextWrapper needs its own variableResolver
  
  Revision  ChangesPath
  1.14  +13 -11
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspContextWrapper.java
  
  Index: JspContextWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspContextWrapper.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- JspContextWrapper.java28 Jan 2003 22:06:28 -  1.13
  +++ JspContextWrapper.java7 Feb 2003 02:51:32 -   1.14
  @@ -87,6 +87,7 @@
   import javax.servlet.jsp.el.ELException;
   import javax.servlet.jsp.el.ExpressionEvaluator;
   import javax.servlet.jsp.el.VariableResolver;
  +import org.apache.commons.el.VariableResolverImpl;
   
   /**
* Implementation of a JSP Context Wrapper.
  @@ -120,6 +121,12 @@
   
   private Hashtable originalNestedVars;
   
  +/**
  + * The variable resolver, for evaluating EL expressions.
  + */
  +private VariableResolverImpl variableResolver
  += new VariableResolverImpl(this);
  +
   public JspContextWrapper(JspContext jspContext, ArrayList nestedVars,
 ArrayList atBeginVars, ArrayList atEndVars,
 Map aliases) {
  @@ -272,7 +279,7 @@
   }
   
   public VariableResolver getVariableResolver() {
  - return null; // XXX
  + return this;
   }
   
   public BodyContent pushBody() {
  @@ -308,14 +315,9 @@
   /**
* VariableResolver interface
*/
  -public Object resolveVariable( String pName )
  -throws ELException
  +public Object resolveVariable( String pName ) throws ELException
   {
  - if (invokingJspCtxt instanceof PageContextImpl) {
  - return ((PageContextImpl) invokingJspCtxt).resolveVariable(pName);
  - }
  -
  - return ((JspContextWrapper) invokingJspCtxt).resolveVariable(pName);
  +return variableResolver.resolveVariable(pName);
   }
   
   /**
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 16865] - EL expressions in tag files no longer works

2003-02-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16865

EL expressions in tag files no longer works

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-02-07 03:03 ---
Thanks for reporting this problem and pointing me to the right direction.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




cvs commit: jakarta-tomcat-4.0/webapps/admin/realm userDatabaseRealm.jsp

2003-02-06 Thread amyroh
amyroh  2003/02/06 21:53:00

  Modified:webapps/admin/realm userDatabaseRealm.jsp
  Log:
  Fix UserDatabaseRealm jsp page.  It was missing hidden resource attribute.
  
  Revision  ChangesPath
  1.10  +1 -0  jakarta-tomcat-4.0/webapps/admin/realm/userDatabaseRealm.jsp
  
  Index: userDatabaseRealm.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/realm/userDatabaseRealm.jsp,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- userDatabaseRealm.jsp 15 Jan 2003 22:25:20 -  1.9
  +++ userDatabaseRealm.jsp 7 Feb 2003 05:53:00 -   1.10
  @@ -101,6 +101,7 @@
   html:text property=resource size=25 maxlength=25 
styleId=resource/
   /logic:equal
   logic:equal name=userDatabaseRealmForm property=adminAction 
value=Edit
  +html:hidden property=resource/
   bean:write name=userDatabaseRealmForm property=resource 
scope=session/
   /logic:equal
   /controls:data
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]