[GUMP@brutus]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

2005-02-09 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-jk-native has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-jk-native :  Connectors to various web servers


Full details are available at:

http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html
Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: 
Build)
Work ended in a state of : Failed
Elapsed: 
Command Line: make 
[Working Directory: 
/usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native]
-
Making all in common
make[1]: Entering directory 
`/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common'
/bin/sh 
/usr/local/gump/public/workspace/apache-httpd/dest-09022005/build/libtool 
--silent --mode=compile gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-09022005/include -g -O2 -g 
-O2 -pthread -DHAVE_APR 
-I/usr/local/gump/public/workspace/apr/dest-09022005/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp12_worker.c 
/usr/local/gump/public/workspace/apache-httpd/dest-09022005/build/libtool: 
/usr/local/gump/public/workspace/apache-httpd/dest-09022005/build/libtool: No 
such file or directory
make[1]: *** [jk_ajp12_worker.lo] Error 127
make[1]: Leaving directory 
`/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common'
make: *** [all-recursive] Error 1
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/rss.xml
- Atom: 
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.2.
Gump Run 2609022005, brutus:brutus-public:2609022005
Gump E-mail Identifier (unique within run) #28.

--
Apache Gump
http://gump.apache.org/ [Instance: brutus]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33463] New: - Struts PlugIn.destroy() method not called when WebApp stopped in Tomcat 5.5.7

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33463.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33463

   Summary: Struts PlugIn.destroy() method not called when WebApp
stopped in Tomcat 5.5.7
   Product: Tomcat 5
   Version: 5.5.7
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


I have a Struts 1.1 application that has worked fine in Tomcat 4.1.x, 5.0.x, 
but does not function correctly under Tomcat 5.5.7.

Specifically, my Struts application registers a PlugIn class (which just 
implements the 2 methods of the interface, i.e. init() and destroy()).  The 
init() method is called just fine as the app is started, but the destroy() 
method is not called when the app is stopped.  We are using the Manager 
application to start and stop the web app.

This can be reproduced by simply adding a PlugIn implementation to the struts-
examples.war - see example plugin below.

Interestingly, the destroy method of a plain servlet IS called when the app is 
stopped (this is our workaround just now).  It would appear that when the 
Struts ActionServlet.destroyModules() method is called, it performs the 
following:
Enumeration names = getServletContext().getAttributeNames();
This enumeration is empty, and hence it is unable to notify the plugin.

Hope this is detailed enough.

For reference, this is on Win XP SP2, JRE 1.5.0_01, Tomcat 5.5.7, Struts 1.1


Cheers,

Kev Palfreyman
Apama UK Ltd.


Example PlugIn:

From struts-config.xml:

plug-in className=ApamaDebugPlugIn/plug-in


import org.apache.struts.action.PlugIn;
import org.apache.struts.action.ActionServlet;
import javax.servlet.ServletException;
import org.apache.struts.config.ModuleConfig;

public class ApamaDebugPlugIn implements PlugIn {

public void init(ActionServlet servlet, ModuleConfig config) throws 
ServletException {
System.out.println(ApamaDebugPlugin.init());
} 


public void destroy() {
System.out.println(ApamaDebugPlugin.destroy());
}
}

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33463] - Struts PlugIn.destroy() method not called when WebApp stopped in Tomcat 5.5.7

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33463.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33463


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c

2005-02-09 Thread mturk
mturk   2005/02/09 03:46:57

  Modified:jk/native/common jk_lb_worker.c
  Log:
  Use shared memory for worker record data. Now the runtime info
  is shared among all child processes.
  
  Revision  ChangesPath
  1.42  +68 -74jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c
  
  Index: jk_lb_worker.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,v
  retrieving revision 1.41
  retrieving revision 1.42
  diff -u -r1.41 -r1.42
  --- jk_lb_worker.c6 Feb 2005 13:30:34 -   1.41
  +++ jk_lb_worker.c9 Feb 2005 11:46:57 -   1.42
  @@ -29,6 +29,7 @@
   #include jk_worker.h
   #include jk_lb_worker.h
   #include jk_mt.h
  +#include jk_shm.h
   
   /*
* The load balancing code in this 
  @@ -51,25 +52,13 @@
   NULL
   };
   
  -/** 
  - * Worker record should be inside shared
  - * memory for correct behavior.
  - * Right now it operates on 'equal-load'
  - * presumption.
  - */
   struct worker_record
   {
  -const char *name;
  -const char *domain;
  -int lb_factor;
  -int lb_value;
  -int is_local_worker;
  -int is_local_domain;
  -int in_error_state;
  -int in_recovering;
  -time_t error_time;
  -jk_worker_t *w;
  +jk_worker_t *w;
  +/* Shared memory worker data */
  +jk_shm_w_rec_t  *s;
   };
  +
   typedef struct worker_record worker_record_t;
   
   struct lb_worker
  @@ -221,22 +210,22 @@
   {
   switch (search_id) {
   case 1:
  -if (strcmp(search_string, wr-name) == 0) {
  +if (strcmp(search_string, wr-s-name) == 0) {
   return JK_TRUE;
   }
   break;
   case 2:
  -if (strcmp(search_string, wr-domain) == 0) {
  +if (strcmp(search_string, wr-s-domain) == 0) {
   return JK_TRUE;
   }
   break;
   case 3:
  -if (wr-is_local_worker) {
  +if (wr-s-is_local_worker) {
   return JK_TRUE;
   }
   break;
   case 4:
  -if (wr-is_local_domain) {
  +if (wr-s-is_local_domain) {
   return JK_TRUE;
   }
   break;
  @@ -281,39 +270,40 @@
   if (JK_IS_DEBUG_LEVEL(l))
  jk_log(l, JK_LOG_DEBUG,
 found candidate worker %s (%d) for match with %s 
(%s),
  -  p-lb_workers[i].name, i, search_type, search_string);
  +  p-lb_workers[i].s-name, i, search_type, 
search_string);
   if (search_id == 1) {
   *domain_id = i;
   }
  -if (!p-lb_workers[i].in_error_state || 
!p-lb_workers[i].in_recovering) {
  +if (!p-lb_workers[i].s-in_error_state || 
!p-lb_workers[i].s-in_recovering) {
   if (JK_IS_DEBUG_LEVEL(l))
   jk_log(l, JK_LOG_DEBUG,
  found candidate worker %s (%d) with previous 
load %d in search with %s (%s),
  -   p-lb_workers[i].name, i, 
p-lb_workers[i].lb_value, search_type, search_string);
  +   p-lb_workers[i].s-name, i, 
p-lb_workers[i].s-lb_value,
  +   search_type, search_string);
   
  -if (p-lb_workers[i].in_error_state) {
  +if (p-lb_workers[i].s-in_error_state) {
   
   time_t now = time(0);
  -int elapsed = now - p-lb_workers[i].error_time;
  +int elapsed = now - p-lb_workers[i].s-error_time;
   if (elapsed = p-recover_wait_time) {
   if (JK_IS_DEBUG_LEVEL(l))
   jk_log(l, JK_LOG_DEBUG,
  worker candidate %s (%d) is in error 
state - will not yet recover (%d  %d),
  -   p-lb_workers[i].name, i, elapsed, 
p-recover_wait_time);
  +   p-lb_workers[i].s-name, i, elapsed, 
p-recover_wait_time);
   continue;
   }
   }
   
   if (use_lb_factor) {
  -p-lb_workers[i].lb_value += p-lb_workers[i].lb_factor;
  -total_factor += p-lb_workers[i].lb_factor;
  -if (p-lb_workers[i].lb_value  lb_max || !rc) {
  -lb_max = p-lb_workers[i].lb_value;
  +p-lb_workers[i].s-lb_value += 
p-lb_workers[i].s-lb_factor;
  +total_factor += p-lb_workers[i].s-lb_factor;
  +if (p-lb_workers[i].s-lb_value  lb_max || !rc) {
  +lb_max = p-lb_workers[i].s-lb_value;
   rc = (p-lb_workers[i]);
   if (JK_IS_DEBUG_LEVEL(l))
 

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_shm.h

2005-02-09 Thread mturk
mturk   2005/02/09 03:47:33

  Modified:jk/native/common jk_shm.h
  Log:
  Fix worker dara record.
  
  Revision  ChangesPath
  1.4   +5 -5  jakarta-tomcat-connectors/jk/native/common/jk_shm.h
  
  Index: jk_shm.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_shm.h,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- jk_shm.h  7 Feb 2005 19:06:35 -   1.3
  +++ jk_shm.h  9 Feb 2005 11:47:33 -   1.4
  @@ -59,11 +59,11 @@
   /* Maximum number of channels */
   int max_conn;
   /* worker name */
  -charroute[JK_SHM_STR_SIZ+1];
  +charname[JK_SHM_STR_SIZ+1];
   /* worker domain */
   chardomain[JK_SHM_STR_SIZ+1];
   /* worker redirect route */
  -charredirect_route[JK_SHM_STR_SIZ+1];
  +charredirect[JK_SHM_STR_SIZ+1];
   /* current status of the worker */
   int status;
   /* Current lb factor */
  @@ -78,7 +78,7 @@
   int local_worker_only;
   int sticky_session;
   int recover_wait_time;
  -int error_time;
  +time_t  error_time;
   /* Number of bytes read from remote */
   int readed;
   /* Number of bytes transferred to remote */
  @@ -112,7 +112,7 @@
   
   /* allocate shm worker record
*/
  -jk_shm_w_rec_t *jk_shm_alloc();
  +jk_shm_w_rec_t *jk_shm_worker_alloc();
   
   
   #ifdef __cplusplus
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33463] - Struts PlugIn.destroy() method not called when WebApp stopped in Tomcat 5.5.7

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33463.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33463


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|major   |normal




--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 12:58 ---
And where in the specification is it said that attribute removals are not
allowed to be done before (it used to be never, anyway). I am willing to make
the change, however, since I do not even see why notifications should be sent
when artificially removing attributes from the context when stopping a webapp.
This seems wrong to me.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-02-09 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:
markt   2004/12/24 08:50:00
  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  Fix bug 32559. add call to context.clearAttributes()
I think 32559 was actually invalid. I disagree with this fix (which I 
fixed once already), as I think no bug existed in the first place: 
although it is ok to clear the attribute list to be nice for GC (the 
containing context is discarded, so it shouldn't be very useful), no 
notification of attribute removals should be sent.

Similarly, attributes addition notifications are not done on startup, as 
the spec seems to imply they are only to be sent for notifying 
modifications while the application is running.

Another issue caused by this change: 
http://issues.apache.org/bugzilla/show_bug.cgi?id=33463

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-02-09 Thread remm
remm2005/02/09 04:20:41

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  - Fix 33463: remove attributes after context destroy.
  - Fix typo in two event strings.
  - Remove dead code.
  - One small indentation fix.
  
  Revision  ChangesPath
  1.162 +15 -49
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.161
  retrieving revision 1.162
  diff -u -r1.161 -r1.162
  --- StandardContext.java  6 Feb 2005 10:39:32 -   1.161
  +++ StandardContext.java  9 Feb 2005 12:20:40 -   1.162
  @@ -3698,17 +3698,19 @@
   try {
   fireContainerEvent(beforeContextDestroyed, listener);
   listener.contextDestroyed(event);
  -fireContainerEvent(beforeContextDestroyed, listener);
  +fireContainerEvent(afterContextDestroyed, listener);
   } catch (Throwable t) {
  -fireContainerEvent(beforeContextDestroyed, listener);
  +fireContainerEvent(afterContextDestroyed, listener);
   getServletContext().log
   (sm.getString(standardContext.listenerStop,
 listeners[j].getClass().getName()), t);
   ok = false;
   }
   }
  +
   setApplicationEventListeners(null);
   setApplicationLifecycleListeners(null);
  +
   return (ok);
   
   }
  @@ -4032,12 +4034,12 @@
   // if any
   if (pipeline instanceof Lifecycle) {
   ((Lifecycle) pipeline).start();
  - }
  -
  +}
  +
   if(getProcessTlds()) {
  - processTlds();
  - }
  -
  +processTlds();
  +}
  +
   // Notify our interested LifecycleListeners
   lifecycle.fireLifecycleEvent(START_EVENT, null);
   
  @@ -4204,43 +4206,7 @@
   }
   }
   
  -/**
  - * Stop this Context component. Experimental, please ignore.
  - *
  - * @exception LifecycleException if a shutdown error occurs
  - */
  -public synchronized void stopNew() throws LifecycleException {
  -// Mark this application as unavailable while we shut down
  -setAvailable(false);
  -
  -// Binding thread
  -ClassLoader oldCCL = bindThread();
  -
  -try {
  -// Stop our filters
  -filterStop();
  -
  -// Finalize our character set mapper
  -setCharsetMapper(null);
  -
  -// Stop our application listeners
  -listenerStop();
  -
  -// Stop resources
  -resourcesStop();
  -
  -super.stop();
  -} finally {
  -
  -// Unbinding thread
  -unbindThread(oldCCL);
  -
  -}
  -
  -// Reset application context
  -context = null;
  -}
  -
  +
   /**
* Stop this Context component.
*
  @@ -4283,10 +4249,6 @@
   ((Lifecycle) manager).stop();
   }
   
  -// Clear all application-originated servlet context attributes
  -if (context != null)
  -context.clearAttributes();
  -
   // Finalize our character set mapper
   setCharsetMapper(null);
   
  @@ -4314,6 +4276,10 @@
   // Stop our application listeners
   listenerStop();
   
  +// Clear all application-originated servlet context attributes
  +if (context != null)
  +context.clearAttributes();
  +
   // Stop resources
   resourcesStop();
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32559] - ServletContextAttributeEvent.attributeRemoved not called on stop

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32559.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32559


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 13:27 ---
The initial comment quotes portions of the specification which do not exist.
Never in the spec there's something which says that
ServletContextAttributeEvent.attributeRemoved method should be called when
stopping a webapp. As a result, this caused bug 33463.

You definitely had me fooled, good job :(

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32559] - ServletContextAttributeEvent.attributeRemoved not called on stop

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32559.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32559


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33463] - Struts PlugIn.destroy() method not called when WebApp stopped in Tomcat 5.5.7

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33463.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33463


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 13:30 ---
This is now fixed, assuming my interpretation of the specification is right and
other developers accept my changes.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/common jk_shm.h

2005-02-09 Thread mturk
mturk   2005/02/09 04:33:13

  Modified:jk/native/common jk_shm.h
  Log:
  Change size params to use size_t.
  
  Revision  ChangesPath
  1.5   +5 -5  jakarta-tomcat-connectors/jk/native/common/jk_shm.h
  
  Index: jk_shm.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_shm.h,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- jk_shm.h  9 Feb 2005 11:47:33 -   1.4
  +++ jk_shm.h  9 Feb 2005 12:33:13 -   1.5
  @@ -80,13 +80,13 @@
   int recover_wait_time;
   time_t  error_time;
   /* Number of bytes read from remote */
  -int readed;
  +size_t   readed;
   /* Number of bytes transferred to remote */
  -int transferred;
  +size_t   transferred;
   /* Number of times the worker was elected */
  -int elected;
  +size_t   elected;
   /* Number of non 200 responses */
  -int errors;
  +size_t   errors;
   };
   typedef struct jk_shm_w_rec jk_shm_w_rec_t;
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c

2005-02-09 Thread mturk
mturk   2005/02/09 04:34:13

  Modified:jk/native/common jk_lb_worker.c
  Log:
  Use shared memory for lb_worker shared data too. This will allow to
  change sticky session processing at runtime.
  
  Revision  ChangesPath
  1.43  +33 -29jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c
  
  Index: jk_lb_worker.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,v
  retrieving revision 1.42
  retrieving revision 1.43
  diff -u -r1.42 -r1.43
  --- jk_lb_worker.c9 Feb 2005 11:46:57 -   1.42
  +++ jk_lb_worker.c9 Feb 2005 12:34:13 -   1.43
  @@ -70,13 +70,11 @@
   jk_pool_t p;
   jk_pool_atom_t buf[TINY_POOL_SIZE];
   
  -const char *name;
   jk_worker_t worker;
  -int in_local_worker_mode;
  -int local_worker_only;
  -int sticky_session;
  -int recover_wait_time;
   JK_CRIT_SEC cs; 
  +
  +/* Shared memory worker data */
  +jk_shm_w_rec_t  *s;
   };
   
   typedef struct lb_worker lb_worker_t;
  @@ -257,7 +255,7 @@
   if (!i) {
   jk_log(l, JK_LOG_ERROR,
  could not lock load balancer = %s,
  -   p-name);
  +   p-s-name);
   return NULL;
   }
   if (JK_IS_DEBUG_LEVEL(l))
  @@ -285,11 +283,11 @@
   
   time_t now = time(0);
   int elapsed = now - p-lb_workers[i].s-error_time;
  -if (elapsed = p-recover_wait_time) {
  +if (elapsed = p-s-recover_wait_time) {
   if (JK_IS_DEBUG_LEVEL(l))
   jk_log(l, JK_LOG_DEBUG,
  worker candidate %s (%d) is in error 
state - will not yet recover (%d  %d),
  -   p-lb_workers[i].s-name, i, elapsed, 
p-recover_wait_time);
  +   p-lb_workers[i].s-name, i, elapsed, 
p-s-recover_wait_time);
   continue;
   }
   }
  @@ -354,7 +352,7 @@
   int domain_id = -1;
   
   JK_TRACE_ENTER(l);
  -if (p-sticky_session) {
  +if (p-s-sticky_session) {
   sessionid = get_sessionid(s);
   }
   
  @@ -414,7 +412,7 @@
   return rc;
   }
   
  -if (p-local_worker_only) {
  +if (p-s-local_worker_only) {
   JK_TRACE_EXIT(l);
   return NULL;
   }
  @@ -454,7 +452,7 @@
   if (JK_IS_DEBUG_LEVEL(l))
   jk_log(l, JK_LOG_DEBUG,
  service sticky_session=%d,
  -   p-worker-sticky_session);
  +   p-worker-s-sticky_session);
   
   while (1) {
   worker_record_t *rec =
  @@ -561,13 +559,13 @@
   unsigned int num_of_workers;
   unsigned int num_of_local_workers;
   
  -p-in_local_worker_mode = JK_FALSE;
  -p-local_worker_only = jk_get_local_worker_only_flag(props, p-name);
  -p-sticky_session = jk_get_is_sticky_session(props, p-name);
  +p-s-in_local_worker_mode = JK_FALSE;
  +p-s-local_worker_only = jk_get_local_worker_only_flag(props, 
p-s-name);
  +p-s-sticky_session = jk_get_is_sticky_session(props, p-s-name);
   p-num_of_local_workers = 0;
   
   if (jk_get_lb_worker_list(props,
  -  p-name,
  +  p-s-name,
 worker_names,
 num_of_workers)  num_of_workers) {
   unsigned int i = 0;
  @@ -603,7 +601,7 @@
   p-lb_workers[i].s-is_local_worker =
   jk_get_is_local_worker(props, worker_names[i]);
   if (p-lb_workers[i].s-is_local_worker)
  -p-in_local_worker_mode = JK_TRUE;
  +p-s-in_local_worker_mode = JK_TRUE;
   /* 
* Allow using lb in fault-tolerant mode.
* A value of 0 means the worker will be used for all 
requests without
  @@ -633,8 +631,8 @@
   }
   num_of_local_workers = j;
   
  -if (!p-in_local_worker_mode) {
  -p-local_worker_only = JK_FALSE;
  +if (!p-s-in_local_worker_mode) {
  +p-s-local_worker_only = JK_FALSE;
   }
   
   if (i != num_of_workers) {
  @@ -670,10 +668,10 @@
   if (JK_IS_DEBUG_LEVEL(l)) {
   jk_log(l, JK_LOG_DEBUG,
  in_local_worker_mode: %s,
  -   (p-in_local_worker_mode ? true : false));
  +   (p-s-in_local_worker_mode ? true : false));
   jk_log(l, JK_LOG_DEBUG,
  local_worker_only: %s,
  -   

DO NOT REPLY [Bug 33465] New: - StandardSession.removeAttriube throws NullPointerException

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33465.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33465

   Summary: StandardSession.removeAttriube throws
NullPointerException
   Product: Tomcat 4
   Version: 4.1.30
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


from time to time i find the following error messages in the log-files of my
production system:

java.lang.NullPointerException
at
org.apache.catalina.session.StandardSession.removeAttribute(Ljava.lang.String;Z)V(StandardSession.java:1157)
at
org.apache.catalina.session.StandardSession.removeAttribute(Ljava.lang.String;)V(StandardSession.java:1103)
at
org.apache.catalina.session.StandardSessionFacade.removeAttribute(Ljava.lang.String;)V(StandardSessionFacade.java:201)
at
org.apache.catalina.session.StandardSessionFacade.removeAttribute(Ljava.lang.String;)V(StandardSessionFacade.java:201)


unfortunatly i could never cause the error by myself, i just see it happen by
looking in the log-files. digging into the source-code of removeAttribute points
to these lines:

// Notify interested application event listeners
Context context = (Context) manager.getContainer();
Object listeners[] = context.getApplicationListeners();

the null-pointer-exception is thrown in the line that calls
manager.getContainer(), so it seems manager is null, when it comes to the
exception. i don't know how manager can get null -- maybe i have some
miscounfiguration? so without understanding the details or the implementation, i
looked at the other methods that access manager. most of then check the
manager-variable for a null-value before they access it. so maybe this should be
done here too?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32898] - Cluster restart fails

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32898.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32898


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 15:58 ---
During a state transfer, I am now setting the context class loader correctly, so
that static methods like struts can load their classes properly.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33469] New: - OutOfMemoryError when upload a jpg image for process

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33469.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33469

   Summary: OutOfMemoryError when upload a jpg image for process
   Product: Tomcat 5
   Version: 5.5.7
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: critical
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I have an app that uploads a jpg image and converts it to tiff format.  The app
is running fine in tomcat 5.0.28.  When I switch it to tomcat 5.5.7, I got an
error message, 

StandardWrapperValve Servlet.service() for servlet action threw exception
OutOfMemoryError.

I increase the memory allocation, it does not help.

Thanks!

Chao

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33469] - OutOfMemoryError when upload a jpg image for process

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33469.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33469





--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 17:01 ---
Please provide a ready to test .war.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Mladen Turk
[EMAIL PROTECTED] wrote:
Hi,
We need to use Apache to load balance a set of Tomcat servers.
However, we need to use a custom load-balancing algorithm, based on the
usage of those servers.
Is this possible with mod_jk?  Would it be easy to extend it?  Any other
suggestions?
Yes, it's possible, but I doubt it has any practical usage.
Since you are using load balancer, then usage is proportional
to it's balance factors.
If you ment to balance on CPU usage of remote backends,
then that'll be hard or even impossible due to AJP13
protocol limitations. That's why we are trying to make
a AJP14 protocol.
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 33471] New: - Tomcat embedded tag pooling

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33471.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33471

   Summary: Tomcat embedded tag pooling
   Product: Tomcat 5
   Version: Unknown
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet  JSP API
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I attempted to follow the directions for turning off tag pooling for Tomcat 
Embedded.  It doesn't seem to work.  I set the following in my 
tomcat/conf/web.xml.

servlet
  servlet-namejsp/servlet-name 
  servlet-classorg.apache.jasper.servlet.JspServlet/servlet-class 
- init-param
  param-nameenablePooling/param-name 
  param-valuefalse/param-value 
  /init-param
/servlet

When I call my custom tags twice on the same page, with different values for 
the attributes, the same html is generated.  Should this technique work in 
Tomcat Embedded for turning off the pooling?  If not, is there another way to 
turn it off?  If not, is there a way around my problem?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread dhay

Hi,

Thanks very much for the reply.

Ok, how is it possible?  What would we need to extend / where would we plug
it in?

Yes, we'd like to balance on CPU usage of tomcat servers that Apache is
load balancing.  Or, even, by having each tomcat app communicate with the
balancer to tell it how busy it is.

Our problem is that we receive a variety of requests, some of which are
very resource intensive and tie up that tomcat for a good while.  Hence a
round-robin or balance factors algorithm are not very effective.

Do you have any ideas of a possible solution?

Many thanks,

David



|-+
| |   Mladen Turk  |
| |   [EMAIL PROTECTED]|
| |   |
| ||
| |   02/09/2005 12:17 |
| |   PM   |
| |   Please respond to|
| |   Tomcat  |
| |   Developers List |
| ||
|-+
  
|
  | 
   |
  |   To:   Tomcat Developers List tomcat-dev@jakarta.apache.org  
   |
  |   cc:   
   |
  |   Subject:  Re: Custom load balancing algorithm and mod_jk???   
   |
  
|




[EMAIL PROTECTED] wrote:
 Hi,

 We need to use Apache to load balance a set of Tomcat servers.

 However, we need to use a custom load-balancing algorithm, based on the
 usage of those servers.

 Is this possible with mod_jk?  Would it be easy to extend it?  Any other
 suggestions?


Yes, it's possible, but I doubt it has any practical usage.
Since you are using load balancer, then usage is proportional
to it's balance factors.

If you ment to balance on CPU usage of remote backends,
then that'll be hard or even impossible due to AJP13
protocol limitations. That's why we are trying to make
a AJP14 protocol.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33471] - Tomcat embedded tag pooling

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33471.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33471


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 18:27 ---
Please post on tomcat-user for this kind of problems. You need to recompile the
JSP for the setting to be used.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread TECHNICAL DIRECTOR
--- 
HiWill you PLEASE stop sending us copies of all your e-mails!

A.  We don't understand them

B. You are all restricting our available K

C. We don't mind the odd Spam, but 20 per day is a mite  OTT

Mike Hancox...---...G4MJH...---...Technical Director
Satellite Scene Group
http://www.satalogue.com





Mladen Turk [EMAIL PROTECTED] wrote:

 [EMAIL PROTECTED] wrote:
  Hi,
  
  We need to use Apache to load balance a set of Tomcat servers.
  
  However, we need to use a custom load-balancing algorithm, based on
 the
  usage of those servers.
  
  Is this possible with mod_jk?  Would it be easy to extend it?  Any
 other
  suggestions?
  
 
 Yes, it's possible, but I doubt it has any practical usage.
 Since you are using load balancer, then usage is proportional
 to it's balance factors.
 
 If you ment to balance on CPU usage of remote backends,
 then that'll be hard or even impossible due to AJP13
 protocol limitations. That's why we are trying to make
 a AJP14 protocol.
 
 Regards,
 Mladen.
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 


=
FROM SATALOGUE TECHNICAL DEPARTMENT...WE HAVE READ YOUR E-MAIL...

Please call our Duty Engineer on 01332 811564 - for a proper 'one to one' 
answer as further information and / or clarification is required from you in 
order to answer your question properly .
   He is available from 10am until 5pm Monday to Friday inclusive.

TO  RETURN TO  SATALOGUE WEBSITE: Click on to link below.

  http://www.satalogue.com/about.htm

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Jim Jagielski
[EMAIL PROTECTED] wrote:
 
 Yes, we'd like to balance on CPU usage of tomcat servers that Apache is
 load balancing.  Or, even, by having each tomcat app communicate with the
 balancer to tell it how busy it is.
 
 Our problem is that we receive a variety of requests, some of which are
 very resource intensive and tie up that tomcat for a good while.  Hence a
 round-robin or balance factors algorithm are not very effective.
 
 Do you have any ideas of a possible solution?
 

There's been talk, at least on the HTTPD side of things, to
have the balancer mechanism be open to external weighting
methods (for the httpd proxy module)... But it's only
gone so far as it sure would be nice.
-- 
===
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
There 10 types of people: those who read binary and everyone else.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Mladen Turk
[EMAIL PROTECTED] wrote:
Hi,
Thanks very much for the reply.
Ok, how is it possible?  What would we need to extend / where would we plug
it in?
Yes, we'd like to balance on CPU usage of tomcat servers that Apache is
load balancing.  Or, even, by having each tomcat app communicate with the
balancer to tell it how busy it is.
Our problem is that we receive a variety of requests, some of which are
very resource intensive and tie up that tomcat for a good while.  Hence a
round-robin or balance factors algorithm are not very effective.
Do you have any ideas of a possible solution?
Use custom headers, and update lb_factors according to that value.
During ajp demarshaling remove those headers so that clients are
unaware of that.
For example use 100/CpuUsage as lb_factor, so if CPU load is
high it's lb_factor will be smaller, thus lowering the load to that
node.
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Fwd: Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread TECHNICAL DIRECTOR
--- TECHNICAL DIRECTOR [EMAIL PROTECTED] wrote:

 Date: Wed, 9 Feb 2005 09:30:34 -0800 (PST)
 From: TECHNICAL DIRECTOR [EMAIL PROTECTED]
 Subject: Re: Custom load balancing algorithm and mod_jk???
 To: Tomcat Developers List tomcat-dev@jakarta.apache.org
 
 --- 
 HiWill you PLEASE stop sending us copies of all your e-mails!
 
 A.  We don't understand them
 
 B. You are all restricting our available K
 
 C. We don't mind the odd Spam, but 20 per day is a mite  OTT
 
 Mike Hancox...---...G4MJH...---...Technical Director
 Satellite Scene Group
 http://www.satalogue.com
 
 
 
 
 
 Mladen Turk [EMAIL PROTECTED] wrote:
 
  [EMAIL PROTECTED] wrote:
   Hi,
   
   We need to use Apache to load balance a set of Tomcat servers.
   
   However, we need to use a custom load-balancing algorithm, based on
  the
   usage of those servers.
   
   Is this possible with mod_jk?  Would it be easy to extend it?  Any
  other
   suggestions?
   
  
  Yes, it's possible, but I doubt it has any practical usage.
  Since you are using load balancer, then usage is proportional
  to it's balance factors.
  
  If you ment to balance on CPU usage of remote backends,
  then that'll be hard or even impossible due to AJP13
  protocol limitations. That's why we are trying to make
  a AJP14 protocol.
  
  Regards,
  Mladen.
  
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
  
  
 
 
 =
 FROM SATALOGUE TECHNICAL DEPARTMENT...WE HAVE READ YOUR E-MAIL...
 
 Please call our Duty Engineer on 01332 811564 - for a proper 'one to
 one' answer as further information and / or clarification is required
 from you in order to answer your question properly .
He is available from 10am until 5pm Monday to Friday
 inclusive.
 
 TO  RETURN TO  SATALOGUE WEBSITE: Click on to link below.
 
   http://www.satalogue.com/about.htm
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 


=
FROM SATALOGUE TECHNICAL DEPARTMENT...WE HAVE READ YOUR E-MAIL...

Please call our Duty Engineer on 01332 811564 - for a proper 'one to one' 
answer as further information and / or clarification is required from you in 
order to answer your question properly .
   He is available from 10am until 5pm Monday to Friday inclusive.

TO  RETURN TO  SATALOGUE WEBSITE: Click on to link below.

  http://www.satalogue.com/about.htm

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread dhay

Thanks for the reply, Jim...

So, do you know of any other solutions out there?  Surely there are many
other people who have been faced with a similar problem?

thanks,

David



|-+
| |   Jim Jagielski|
| |   [EMAIL PROTECTED]|
| ||
| |   02/09/2005 12:32 |
| |   PM   |
| |   Please respond to|
| |   Tomcat  |
| |   Developers List |
| ||
|-+
  
|
  | 
   |
  |   To:   tomcat-dev@jakarta.apache.org   
   |
  |   cc:   
   |
  |   Subject:  Re: Custom load balancing algorithm and mod_jk???   
   |
  
|




[EMAIL PROTECTED] wrote:

 Yes, we'd like to balance on CPU usage of tomcat servers that Apache is
 load balancing.  Or, even, by having each tomcat app communicate with the
 balancer to tell it how busy it is.

 Our problem is that we receive a variety of requests, some of which are
 very resource intensive and tie up that tomcat for a good while.  Hence a
 round-robin or balance factors algorithm are not very effective.

 Do you have any ideas of a possible solution?


There's been talk, at least on the HTTPD side of things, to
have the balancer mechanism be open to external weighting
methods (for the httpd proxy module)... But it's only
gone so far as it sure would be nice.
--
===
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
There 10 types of people: those who read binary and everyone else.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Mladen Turk
TECHNICAL DIRECTOR wrote:
--- 
HiWill you PLEASE stop sending us copies of all your e-mails!

Sure, once when you unsubscribe from the Tomcat Developer List.
You or someone that is using your account subscribed to this list,
so first clean up at your doorsteps.
Here is how-to
http://jakarta.apache.org/site/mail2.html#Tomcat
And, goodbye :)
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread dhay

Hi Mladen,

That sounds feasible...but I have no idea how to do that!!

Would you mind pointing me in the right direction?

- how do we create custom headers?  Where?
- how do we get access to the ajp demarshaling?

Sorry for the ignorance!  I haven't done any extending of tomcat before...

thanks very much,

David




|-+
| |   Mladen Turk  |
| |   [EMAIL PROTECTED]|
| |   |
| ||
| |   02/09/2005 12:33 |
| |   PM   |
| |   Please respond to|
| |   Tomcat  |
| |   Developers List |
| ||
|-+
  
|
  | 
   |
  |   To:   Tomcat Developers List tomcat-dev@jakarta.apache.org  
   |
  |   cc:   
   |
  |   Subject:  Re: Custom load balancing algorithm and mod_jk???   
   |
  
|




[EMAIL PROTECTED] wrote:
 Hi,

 Thanks very much for the reply.

 Ok, how is it possible?  What would we need to extend / where would we
plug
 it in?

 Yes, we'd like to balance on CPU usage of tomcat servers that Apache is
 load balancing.  Or, even, by having each tomcat app communicate with the
 balancer to tell it how busy it is.

 Our problem is that we receive a variety of requests, some of which are
 very resource intensive and tie up that tomcat for a good while.  Hence a
 round-robin or balance factors algorithm are not very effective.

 Do you have any ideas of a possible solution?


Use custom headers, and update lb_factors according to that value.
During ajp demarshaling remove those headers so that clients are
unaware of that.

For example use 100/CpuUsage as lb_factor, so if CPU load is
high it's lb_factor will be smaller, thus lowering the load to that
node.

Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Mladen Turk
Jim Jagielski wrote:
There's been talk, at least on the HTTPD side of things, to
have the balancer mechanism be open to external weighting
methods (for the httpd proxy module)... But it's only
gone so far as it sure would be nice.

But it is. You need to write your own mod_proxy_balancer.
Everything else from creating balancers and balancer members is
independat of algorithim itself.
The balancer module has to find and return the worker, what ever
algorithm used.
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Jim Jagielski
Mladen Turk wrote:
 
 Jim Jagielski wrote:
  
  There's been talk, at least on the HTTPD side of things, to
  have the balancer mechanism be open to external weighting
  methods (for the httpd proxy module)... But it's only
  gone so far as it sure would be nice.
 
 
 But it is. You need to write your own mod_proxy_balancer.
 Everything else from creating balancers and balancer members is
 independat of algorithim itself.
 The balancer module has to find and return the worker, what ever
 algorithm used.
 

I was referring to actually making better use of the tools that
httpd brings to the table. Ala balancer sub-modules and
optional functions. Not having to re-use/cut-paste a lot
of existing code :)

-- 
===
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
There 10 types of people: those who read binary and everyone else.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



lifecycleEvent() of LifecycleListener interface should should declare LifecycleException in throws clause?

2005-02-09 Thread Roytman, Alex
Dear tomcat developers,

Executing various lifecycle events is an essential part of tomcat
start/stop process. Often it is the only way to execute certain startup
sequence for a component at exactly right time. Lifecycle start() and
stop() method overriding do not quite give the same level of precision.
I am not sure it is possible to do it to LifecycleListener interface but
it would be nice if its lifecycleEvent() method woyld declare
LifecycleException thrown

Thank you

Alex

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Mladen Turk
[EMAIL PROTECTED] wrote:
Hi Mladen,
That sounds feasible...but I have no idea how to do that!!
Would you mind pointing me in the right direction?
- how do we create custom headers?  Where?
Inside Tomcat.
Not sure where, but some sort of filter should help.
Take a look at filter documentation if you don't wish
to hack the Tomcat code itself.
The filter will need to gather CPU usage and add some
header to outgoing headers.
- how do we get access to the ajp demarshaling?
Inside mod_jk.
jk_ajp_common.c - ajp_unmarshal_response
See how headers are parsed.
Then you will need to pass that back to lb_worker.
Sorry for the ignorance!  I haven't done any extending of tomcat before...
Then I wish you all the luck :).
Regards,
Mladen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread dhay

 Then I wish you all the luck :).
Thanks!  It seems a little daunting!

So, exploring other possibilities before I undertake it...

Is there any way to just make a call and update the load factors on the
fly?

Or does the JMX additions provide any way to update things dynamically?

Many thanks,

David



|-+
| |   Mladen Turk  |
| |   [EMAIL PROTECTED]|
| |   |
| ||
| |   02/09/2005 12:51 |
| |   PM   |
| |   Please respond to|
| |   Tomcat  |
| |   Developers List |
| ||
|-+
  
|
  | 
   |
  |   To:   Tomcat Developers List tomcat-dev@jakarta.apache.org  
   |
  |   cc:   
   |
  |   Subject:  Re: Custom load balancing algorithm and mod_jk???   
   |
  
|




[EMAIL PROTECTED] wrote:
 Hi Mladen,

 That sounds feasible...but I have no idea how to do that!!

 Would you mind pointing me in the right direction?

 - how do we create custom headers?  Where?

Inside Tomcat.
Not sure where, but some sort of filter should help.
Take a look at filter documentation if you don't wish
to hack the Tomcat code itself.
The filter will need to gather CPU usage and add some
header to outgoing headers.

 - how do we get access to the ajp demarshaling?


Inside mod_jk.
jk_ajp_common.c - ajp_unmarshal_response
See how headers are parsed.
Then you will need to pass that back to lb_worker.

 Sorry for the ignorance!  I haven't done any extending of tomcat
before...


Then I wish you all the luck :).

Regards,
Mladen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Mladen Turk
[EMAIL PROTECTED] wrote:
Then I wish you all the luck :).
Thanks!  It seems a little daunting!
So, exploring other possibilities before I undertake it...
Is there any way to just make a call and update the load factors on the
fly?
Not right now. The mod_jk 1.2.9 will have something Apache2.1
proxy_balancer has, and that is updating various options (and lb_factor)
using manger status page.
You may try the bleeding edge and use Apache2.1 instead.
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread dhay

ok...do you know if this can be done programmatically,  rather than through
the web page?

Also, is there a timeframe for mod_jk 1.2.9?  That sounds perfect if it can
be done programmatically there.  We would probably wait for that to be
released...

thanks!!

David




|-+
| |   Mladen Turk  |
| |   [EMAIL PROTECTED]|
| |   |
| ||
| |   02/09/2005 01:21 |
| |   PM   |
| |   Please respond to|
| |   Tomcat  |
| |   Developers List |
| ||
|-+
  
|
  | 
   |
  |   To:   Tomcat Developers List tomcat-dev@jakarta.apache.org  
   |
  |   cc:   
   |
  |   Subject:  Re: Custom load balancing algorithm and mod_jk???   
   |
  
|




[EMAIL PROTECTED] wrote:
Then I wish you all the luck :).

 Thanks!  It seems a little daunting!

 So, exploring other possibilities before I undertake it...

 Is there any way to just make a call and update the load factors on the
 fly?


Not right now. The mod_jk 1.2.9 will have something Apache2.1
proxy_balancer has, and that is updating various options (and lb_factor)
using manger status page.

You may try the bleeding edge and use Apache2.1 instead.

Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33474] New: - tcpListenPort=0 won't get actual local port for cluster membership

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33474.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33474

   Summary: tcpListenPort=0 won't get actual local port for
cluster membership
   Product: Tomcat 5
   Version: 5.5.7
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina:Cluster
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Binding to port 0 is perfectly valid.  Any port will do, and in my case, 
managing a list of over 1000 vhosts' ports is not acceptable.  Some configured 
ports may or may not be available.  It shouldn't matter what port is used for 
the listener in most cases.  The current code returns the port that is 
configured in the server.xml.  If that port is 0, 0 will be sent to the 
MembershipService.  Obviously, that's not going to work.  If we configure port 
0, get the local port that we actually bound to.

Index: ReplicationListener.java
===
RCS file: /home/cvspublic/jakarta-tomcat-
catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationLi
stener.java,v
retrieving revision 1.18
diff -u -r1.18 ReplicationListener.java
--- ReplicationListener.java27 Dec 2004 09:30:36 -  1.18
+++ ReplicationListener.java9 Feb 2005 20:13:51 -
@@ -101,6 +101,9 @@
 selector = Selector.open();
 // set the port the server channel will listen to
 serverSocket.bind (new InetSocketAddress (bind,tcpListenPort));
+if (tcpListenPort == 0) {
+   tcpListenPort = serverSocket.getLocalPort();
+}
 // set non-blocking mode for the listening socket
 serverChannel.configureBlocking (false);
 // register the ServerSocketChannel with the Selector

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-02-09 Thread Mark Thomas
Remy Maucherat wrote:
[EMAIL PROTECTED] wrote:
markt   2004/12/24 08:50:00
  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  Fix bug 32559. add call to context.clearAttributes()

I think 32559 was actually invalid. I disagree with this fix (which I 
fixed once already), as I think no bug existed in the first place: 
although it is ok to clear the attribute list to be nice for GC (the 
containing context is discarded, so it shouldn't be very useful), no 
notification of attribute removals should be sent.

Similarly, attributes addition notifications are not done on startup, as 
the spec seems to imply they are only to be sent for notifying 
modifications while the application is running.

Another issue caused by this change: 
http://issues.apache.org/bugzilla/show_bug.cgi?id=33463

Rémy
I have just re-read the spec and some of the statements in 32559 are 
certainly wrong. However, I agree with 32559 in that reload and 
stop/start should have the same effect. I'll put together a simple test 
case to investigate this. I'll then port this fix back to TC4 plus and 
further changes the test case throws up.

Mark
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 32424] - Redirecting directiories with missing trailing slash breaks web applications

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32424.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32424





--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 23:17 ---
 The behavior is not specified anywhere

Then isn't it clearly a bug? While the slash makes no sematic difference when
your using the default servlet it *can* and does make a difference for
applications that do not use the default servlet (like mine and clearly 
others). 

Also so much for interoperability between Servlet containers. Given that Tomcat
is the reference implementation of the Servlet spec should I raise a bug with
Jetty (and probably every other implementation) given that it does not exhibit
this behaviour?

 I regret it would prevent you from using Tomcat, but there's nothing 
 that I will change here.
 
I understand that I'm not going to persuade you to change this but at the very
least there should be a way to disable it. If you point me in the right
direction perhaps I could implement a patch?


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33308] - mod_jk 1.2.8 segfaults when ForwardDirectories is enabled

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33308.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33308





--- Additional Comments From [EMAIL PROTECTED]  2005-02-09 23:29 ---
I don't know why the handler isn't being set, but this patch remedies the 
segfault for now.

--- jakarta-tomcat-connectors-1.2.8-src.orig/jk/native/apache-1.3/mod_jk.c 
Fri Dec 24 05:18:10 2004
+++ jakarta-tomcat-connectors-1.2.8-src/jk/native/apache-1.3/mod_jk.c   Mon Jan 
31 16:41:58 2005
@@ -1933,7 +1933,8 @@
  * jk_fixups) and the request is for a directory:
  * -- forward to Tomcat, via default worker */
 if (!worker  (conf-options  JK_OPT_FWDDIRS) 
-r-prev  !strcmp(r-prev-handler, JK_HANDLER) 
+r-prev  r-prev-handler 
+!strcmp(r-prev-handler, JK_HANDLER) 
 r-uri[strlen(r-uri) - 1] == '/') {
 
 /* Nothing here to do but assign the first worker since we


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32424] - Redirecting directiories with missing trailing slash breaks web applications

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32424.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32424





--- Additional Comments From [EMAIL PROTECTED]  2005-02-10 00:04 ---
Unfortunately, I would have to veto your patch. I would appreciate if you were
not whining. Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32424] - Redirecting directiories with missing trailing slash breaks web applications

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32424.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32424





--- Additional Comments From [EMAIL PROTECTED]  2005-02-10 00:13 ---
If you want to modify the HTTP mapping behavior for your own purposes, the
mapping class is org.apache.tomcat.util.http.mapper.Mapper in
jakarta-tomcat-connectors/util. Rule 7 is the one which sends the HTTP redirect.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32424] - Redirecting directiories with missing trailing slash breaks web applications

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32424.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32424





--- Additional Comments From [EMAIL PROTECTED]  2005-02-10 01:28 ---
 I would appreciate if you were not whining.

I'm simply trying to get a decent explanation of why this is not a bug - which
you have failed to provide in any of your comments. I understand this behaviour
is solving some problem or other but that doesn't mean it not a bug and it's
certainly contrary to the spirit of the spec relating to filters and to the
mapping of requests. 

Anyway I'll shutup since I'm clearly wasting my time.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33474] - tcpListenPort=0 won't get actual local port for cluster membership

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33474.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33474


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-02-10 01:28 ---
running a cluster for over 1000 vhosts, isn't such a great idea.
the patch doesn't do anything, as there are other dependencies you haven't
considered.
 I'll add this item to the todo list to allow 0 or auto in the config, setting
this bug to invalid, as it is a todo item.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Proposed API change to the Manager interface

2005-02-09 Thread Rainer Jung
I have the impression you fixed the jvmRoute in the new Session(-Id) in
ManagerBase, but not in DeltaManager? Even when the context is
distributable one might prefer to stick the session to the node where it
now originates.

Furthermore: I did not really understand the use case of emptySessionPath,
but want to indicate 2 problematic areas:

1) If the cookie contains an expired session(-id) then you would allow a
new session to be started with the old id. That is not a naive security
problem, because the session is empty, so authentication has to be done
again etc.

But there is a more complex threat: Security of webapps relies on the
fact, that session ids are not easily guessable. Once you move into a
situation where a user might use the same session id for a very long time
(in fact different sessions) the id will loose it's security. Normally
it's hard to find out the id of a user session while the session is still
active. And the user can at every time end his session. If he is going to
use the same Id for many sessions you have a much better chance to get
knowledge about the id between sessions and then to just wait for a new
session to begin.

2) There might be problems by putting an arbitrary string coming from an
uncontrolled Cookie and using it as a session id inside tomcat. I don't
know, if there is a way related to cross site scrpting or injection of
malicious code for cookies (of course I know, that there is no scripting
inside Cookies, but atackers are very ingenious nowadays). At least one
should check the string for formal correctness (e.g. containing only
letters and numbers or something similar).



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2005-02-09 Thread keith
keith   2005/02/09 21:25:42

  Modified:http11/src/java/org/apache/coyote/http11/filters Tag:
TOMCAT_5_0 IdentityOutputFilter.java
   coyote/src/java/org/apache/coyote Tag: TOMCAT_5_0
Response.java
   util/java/org/apache/tomcat/util/buf Tag: TOMCAT_5_0
MessageBytes.java
   http11/src/java/org/apache/coyote/http11 Tag: TOMCAT_5_0
Http11Processor.java
  Log:
  Port fix from Mark Thomas for better Content-Length handling into the _5_0 
branch
  
  PR: 32585
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.7.2.1   +1 -1  
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters/IdentityOutputFilter.java
  
  Index: IdentityOutputFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters/IdentityOutputFilter.java,v
  retrieving revision 1.7
  retrieving revision 1.7.2.1
  diff -u -r1.7 -r1.7.2.1
  --- IdentityOutputFilter.java 24 Feb 2004 08:50:55 -  1.7
  +++ IdentityOutputFilter.java 10 Feb 2005 05:25:41 -  1.7.2.1
  @@ -141,7 +141,7 @@
* after the response header processing is complete.
*/
   public void setResponse(Response response) {
  -contentLength = response.getContentLength();
  +contentLength = response.getContentLengthLong();
   remaining = contentLength;
   }
   
  
  
  
  No   revision
  No   revision
  1.32.2.1  +11 -2 
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java
  
  Index: Response.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java,v
  retrieving revision 1.32
  retrieving revision 1.32.2.1
  diff -u -r1.32 -r1.32.2.1
  --- Response.java 24 Feb 2004 08:54:29 -  1.32
  +++ Response.java 10 Feb 2005 05:25:41 -  1.32.2.1
  @@ -100,7 +100,7 @@
   protected String contentType = null;
   protected String contentLanguage = null;
   protected String characterEncoding = 
Constants.DEFAULT_CHARACTER_ENCODING;
  -protected int contentLength = -1;
  +protected long contentLength = -1;
   private Locale locale = DEFAULT_LOCALE;
   
   // General informations
  @@ -529,7 +529,16 @@
   }
   
   public int getContentLength() {
  -return contentLength;
  +long length = getContentLengthLong();
  +
  +if (length  Integer.MAX_VALUE) {
  +return (int) length;
  +}
  +return -1;
  +}
  +
  +public long getContentLengthLong() {
  +  return contentLength;
   }
   
   
  
  
  
  No   revision
  No   revision
  1.14.2.2  +42 -0 
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/MessageBytes.java
  
  Index: MessageBytes.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/MessageBytes.java,v
  retrieving revision 1.14.2.1
  retrieving revision 1.14.2.2
  diff -u -r1.14.2.1 -r1.14.2.2
  --- MessageBytes.java 25 Aug 2004 20:44:15 -  1.14.2.1
  +++ MessageBytes.java 10 Feb 2005 05:25:41 -  1.14.2.2
  @@ -579,6 +579,48 @@
   type=T_BYTES;
   }
   
  +/** Set the buffer to the representation of an long
  + */
  +public void setLong(long l) {
  +byteC.allocate(32, 64);
  +long current = l;
  +byte[] buf = byteC.getBuffer();
  +int start = 0;
  +int end = 0;
  +if (l == 0) {
  +buf[end++] = (byte) '0';
  +}
  +if (l  0) {
  +current = -l;
  +buf[end++] = (byte) '-';
  +}
  +while (current  0) {
  +int digit = (int) (current % 10);
  +current = current / 10;
  +buf[end++] = HexUtils.HEX[digit];
  +}
  +byteC.setOffset(0);
  +byteC.setEnd(end);
  +// Inverting buffer
  +end--;
  +if (l  0) {
  +start++;
  +}
  +while (end  start) {
  +byte temp = buf[start];
  +buf[start] = buf[end];
  +buf[end] = temp;
  +start++;
  +end--;
  +}
  +longValue=l;
  +hasStrValue=false;
  +hasHashCode=false;
  +hasIntValue=false;
  +hasLongValue=true;
  +hasDateValue=false; 
  +type=T_BYTES;
  +}
   
   /**
*  @deprecated The buffer are general purpose, caching for headers 
should
  
  
  
  No   revision
  No   revision
  1.100.2.3 +2 -2

DO NOT REPLY [Bug 32424] - Redirecting directiories with missing trailing slash breaks web applications

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32424.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32424





--- Additional Comments From [EMAIL PROTECTED]  2005-02-10 06:58 ---
FWIW The redirect to add a trailing slash is required prior to any
authentication challenges for correct credential cacheing on the client.  The
container is correct to 302 + / the request as soon as possible, if the request
is missing a trailing slash.  When I tested Jetty about a year ago it did this
as well.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33117] - Deep link into Bugzilla broken on ROOT/index.jsp

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33117.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33117


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED




--- Additional Comments From [EMAIL PROTECTED]  2005-02-10 07:47 ---
Fix verified in Tomcat 5.5.7. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Albrecht Rieger

hi Mladen,

are you able to tell me, how to get rid of all this apache and tomcat
emails I get and I do definitely NOT want ?

best regards

albrecht

___
Proprietary and confidential. Distribution only by express authority of
Continental AG or its subsidiaries




  Mladen Turk   

  [EMAIL PROTECTED]To:   Tomcat Developers 
List tomcat-dev@jakarta.apache.org 
  cc:  

   Subject:  Re: Custom load 
balancing algorithm and mod_jk???  
  09.02.2005 18:51  

  Please respond to 

  Tomcat   

  Developers List  









[EMAIL PROTECTED] wrote:
 Hi Mladen,

 That sounds feasible...but I have no idea how to do that!!

 Would you mind pointing me in the right direction?

 - how do we create custom headers?  Where?

Inside Tomcat.
Not sure where, but some sort of filter should help.
Take a look at filter documentation if you don't wish
to hack the Tomcat code itself.
The filter will need to gather CPU usage and add some
header to outgoing headers.

 - how do we get access to the ajp demarshaling?


Inside mod_jk.
jk_ajp_common.c - ajp_unmarshal_response
See how headers are parsed.
Then you will need to pass that back to lb_worker.

 Sorry for the ignorance!  I haven't done any extending of tomcat
before...


Then I wish you all the luck :).

Regards,
Mladen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33308] - mod_jk 1.2.8 segfaults when ForwardDirectories is enabled

2005-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33308.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33308


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-02-10 08:19 ---
Hi,
This has already been fixed in the CVS. Take a look at:
http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-connectors/jk/native/apache-
1.3/mod_jk.c?r1=1.61r2=1.62diff_format=h



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Custom load balancing algorithm and mod_jk???

2005-02-09 Thread Mladen Turk
Albrecht Rieger wrote:
hi Mladen,
are you able to tell me, how to get rid of all this apache and tomcat
emails I get and I do definitely NOT want ?
Sure, unsibscribe from the Tomcat Developer List.
You or someone that is using your account subscribed to this list.
Here is how-to:
http://jakarta.apache.org/site/mail2.html#Tomcat
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]