[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-08-31 Thread Pat McGowan
BTW another undesirable symptom is that a user can uninstall an app only
to see it remain in their app scope

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-08-31 Thread Pat McGowan
I am more concerned with changing intended functionality, perhaps for
multiuser systems although its not clear that will ever be a real
requirement for click.

It seems fixing the logic that is unnecessarily  updating the timestamps
should be done

Should this behavior only be enabled on single user systems where it
seems to not make sense? Do we need a new path such as "click hook run-
singleuser"

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-08-11 Thread Kyle Fazzari
We think we have a way forward for fixing this, but want to get some
consensus before continuing.

First of all, as Colin mentioned, in order to make sure clicks in /opt
are updated when OTA updates install newer versions in /custom, `click
hook run-system` needs to be updated to compare those databases and
unregister the old versions as necessary.

This change has the side effect (a regression) of making it impossible
to sideload an older version of a click, since the system hooks are run
on boot: the older versions will be unregistered upon the next boot. We
believe this is fixable by comparing the timestamps of a user's
registrations with the newer version of the click included in the OTA
update, and only unregister if the user's registration is older than the
OTA update's.

Unfortunately, that hits another issue where the user registrations
timestamps seem to get updated upon every reboot, which means they'll
always be newer than the OTA update's. We believe we can resolve this by
making the user hooks a little smarter about touching registrations that
don't need to be touched, but it still requires a bit more
investigation.

Knowing the proposed changes and side effects, how does that sound? Are
we okay with the inability to sideload older versions, or should we make
sure that continues to work and update the hooks to be a bit smarter?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-08-11 Thread Rodney Dawes
While this is a slightly annoying bug, it is not new, nor a regression;
and requires a somewhat intimate knowledge of the system, to even
realize it is being hit. There also appear to be a couple of workarounds
for this issue. As such, I'd suggest possibly reducing the priority of
this from critical. The bug has existed for well over a year. I clearly
remember hitting this same issue in the past, but after working around
the problem, was unable to forcibly recreate it, and so didn't file a
bug at the time.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-08-11 Thread Alejandro J. Cura
I agree that this should not be Critical: after an OTA the user will
just see more updates available for the installed apps and scopes, they
will not look out of place and the workaround is to just install those.

** Changed in: click (Ubuntu)
   Importance: Critical = Medium

** Changed in: click (Ubuntu)
 Assignee: Michael Vogt (mvo) = Kyle Fazzari (kyrofa)

** Changed in: canonical-devices-system-image
 Assignee: Pat McGowan (pat-mcgowan) = Alejandro J. Cura (alecu)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-08-11 Thread Bill Filler
** Changed in: canonical-devices-system-image
Milestone: ww34-2015 = ww40-2015

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-08-10 Thread Kyle Fazzari
Correct me if I'm wrong, but this seems to be by design. Notice if you
go check for available updates, Ubuntu is listed as a separate update to
Facebook Photos. It seems reasonable to expect that if I update Ubuntu,
Facebook Photos will not be updated, since I didn't select it. Indeed,
after the OTA update, if you go back to view available updates, Facebook
Photos is still listed there, and if you update there, the user will now
be on 1.26.

Colin, are you suggesting adding another system hook, then? Aren't those
run on each boot? I can't think of a way to write a system hook that
will only force-ably update user-installed apps upon OTA and not on each
boot. Thoughts?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-07-31 Thread Ɓukasz Zemczak
** Tags added: lt-category-visible

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-07-31 Thread Colin Watson
I'd rather strongly recommend against changing the fundamental database
design; I think that if you take that road then you will find yourself
playing whack-a-mole with conflicting requirements.  Instead, my
suggestion would be to arrange for click hook run-system-hooks to
garbage-collect user registrations in the overlay database that have
been superseded by versions in a lower database; that way it's still
possible for somebody to temporarily revert a package for testing, but
an OTA update would pull them back to the latest version.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-07-30 Thread Pat McGowan
Based on the doc

When click is asked to list the set of packages for a given user, it
walks its way down the list of databases from top (default) to bottom
(core). For each database, it checks registrations for that user,
followed by registrations for @all. It takes the first registration for
any given package name that it finds.

This does not mention selecting the most recent version which could be
seen as a feature if the user wants to use an earlier version. However
since installing older packages is not supported from the UI I would
argue we should always default to the latest version and not the first
match found.

This seems a fundamental incompatibility between image updates and click
installs.

FWIW uninstalling the user version (via the UI) is all that is needed to
enable the updated version. After the uninstall the store UI incorrectly
shows the option to install, but returning to the list refreshes with
the correct installed state.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-07-30 Thread Pat McGowan
I reproduced it by installing a dummy 1.24 version which goes into /opt/click
After an update to ota5 /custom/click contained the latest 1.26 version but the 
system still reported 1.24 as the active version

click pkgdir com.canonical.scopes.fbphotos
/opt/click.ubuntu.com/.click/users/phablet/com.canonical.scopes.fbphotos



** Also affects: click (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: canonical-devices-system-image
   Importance: Undecided = Critical

** Changed in: canonical-devices-system-image
   Status: Incomplete = Confirmed

** Changed in: canonical-devices-system-image
Milestone: None = ww34-2015

** Changed in: canonical-devices-system-image
 Assignee: Kyle Nitzsche (knitzsche) = Pat McGowan (pat-mcgowan)

** Changed in: click (Ubuntu)
   Status: New = Confirmed

** Changed in: click (Ubuntu)
   Importance: Undecided = Critical

** Changed in: click (Ubuntu)
 Assignee: (unassigned) = Michael Vogt (mvo)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1479001] Re: OTA update: lower user click not updated by custom tarball higher click

2015-07-30 Thread Kyle Nitzsche
So, when I flash ota4 then use system settings to update to ota5,
fbphotos is 1.26 (correct from the custom tarball).

However, this user had fbphotos 1.24 after OTA update..

So yeah, I guess they installed 1.24 from store (which perhaps should
not be allowed since it is a lower version than 1.26 from ota5).

What was internally reproduced:
1) install ota4

ubuntu-device-flash \
--revision 23 \
touch \
--channel=ubuntu-touch/stable/bq-aquaris.en \
--wipe --bootstrap \
--device krillin \
--developer-mode --password= \
--recovery-image ~/bzr/recovery-images/krillin/recovery.img

2. check fbphoto revision:
click list | grep fbphoto = 1.23

3. U1 creds -  Install fbphotos 1.24 from store

4. reboot

5.  install OTA5 from  settings.

6. check fbphoto version

click list | grep fbphoto = 1.24
 But it *should* be 1.26

So it seems the custom tarball fails to update to higher version when
the click was installed from the store.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1479001

Title:
  OTA update: lower user click not updated by custom tarball higher
  click

Status in Canonical System Image:
  Confirmed
Status in click package in Ubuntu:
  Confirmed

Bug description:
  A user in the field has OTA5 installed. But one click in OTA 5
  (com.canonical.scopes.fbphotos_fbphotos 1.26) did not get updated and
  is at the pre OTA5 version: 1.24.

  Expectations: if OTA custom tarball has a higher version click package
  than the user's, that higher click package is installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1479001/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp