RE: [PATCH v6 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support
Svyatoslav, I've got your V6 patches applied, and buildman tegra is OK. I've never run the CI tests before, so I'll have to look into that. I'll update u-boot-tegra/master TOT today, though. TomR & Simon - I'm retiring the first week in July, so I won't be the Tegra custodian going forward - we've yet to assign that job to another engineer here, hopefully that'll get done before I leave & you can help them get up-to-speed on custodial duties w/the Tegra repo, if needed. Tom -Original Message- From: Svyatoslav Ryhel Sent: Tuesday, June 13, 2023 2:51 AM To: Tom Warren Cc: u-boot@lists.denx.de; Tom Rini ; Simon Glass ; Svyatoslav Ryhel Subject: Re: [PATCH v6 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments 9 червня 2023 р. 07:34:41 GMT+03:00, Svyatoslav Ryhel написав(-ла): >This patchset adds support for native use of U-Boot on: >- ASUS T30 Transformers (7 devices, all models); >- ASUS/Google Nexus 7 (2012), both grouper and tilapia >- LG Optimus 4X HD (P880) and Optimus Vu (P895) >- HTC One X (endeavoru) >as a replacement for the vendor bootloader. > >Current commits are designed to work on re-crypted devices but can be >used on clean unmodified devices with slight restrictions (like no >booting/mounting emmc and no self updating feature). > >All device setup commits fall under the same pattern. Alongside device >bringup tegra requires few small patches: > - add gpio keyboard as stdin device > - make networking boot options optional > - add a small tool to generate SoC UID > >Commits passed ./tools/buildman/buildman tegra Building current source >for 30 boards (12 threads, 1 job per thread) > 3000 /30 0:00:06 : apalis_t30 >Completed: 30 total built, 30 newly), duration 0:05:23, rate 0.09 > >Passed 50/53 GitLab CI Pipelines and then I ran off CI minures. > >--- >Changes from v5: >- fixed maintained files inclusion > >Changes from v4: >- fixed documentation >- fixed CONFIG_* definitions > >Changes from v3: >- extended amount of devices supported > >Changes from v2: > - fuse build is excluded for T186 (it is not supported in it anyway) > >Changes from v1: > - fix fuse headers for newer Tegra generations > - allow grouper_common_defconfig to pass without fragments >--- > >Jonas Schwöbel (1): > configs: tegra-common-post: make PXE and DHCP boot targets optional > >Svyatoslav Ryhel (6): > configs: tegra-common-post: add GPIO keyboard as STDIN device > ARM: tegra: add SoC UID calculation function > board: asus: transformer: add ASUS Transformer T30 family support > board: asus: grouper: add Google Nexus 7 (2012) support > board: lg: x3: add Optimus 4X HD and Optimus Vu support > board: htc: endeavoru: add One X support > > arch/arm/dts/Makefile | 12 + > arch/arm/dts/tegra30-asus-grouper-common.dtsi | 157 ++ > .../dts/tegra30-asus-nexus7-grouper-E1565.dts | 43 ++ > .../dts/tegra30-asus-nexus7-grouper-PM269.dts | 36 ++ > .../dts/tegra30-asus-nexus7-tilapia-E1565.dts | 62 +++ > arch/arm/dts/tegra30-asus-p1801-t.dts | 17 + > arch/arm/dts/tegra30-asus-tf201.dts | 9 + > arch/arm/dts/tegra30-asus-tf300t.dts | 18 + > arch/arm/dts/tegra30-asus-tf300tg.dts | 9 + > arch/arm/dts/tegra30-asus-tf300tl.dts | 9 + > arch/arm/dts/tegra30-asus-tf600t.dts | 89 > arch/arm/dts/tegra30-asus-tf700t.dts | 13 + > arch/arm/dts/tegra30-asus-transformer.dtsi| 211 > arch/arm/dts/tegra30-htc-endeavoru.dts| 166 +++ > arch/arm/dts/tegra30-lg-p880.dts | 40 ++ > arch/arm/dts/tegra30-lg-p895.dts | 50 ++ > arch/arm/dts/tegra30-lg-x3.dtsi | 180 +++ > arch/arm/include/asm/arch-tegra/fuse.h| 7 + > arch/arm/mach-tegra/Makefile | 4 + > arch/arm/mach-tegra/fuse.c| 151 ++ > arch/arm/mach-tegra/tegra30/Kconfig | 20 + > board/asus/grouper/Kconfig| 22 + > board/asus/grouper/MAINTAINERS| 10 + > board/asus/grouper/Makefile | 14 + > board/asus/grouper/grouper-spl-max.c | 45 ++ > board/asus/grouper/grouper-spl-ti.c | 41 ++ > board/asus/grouper/grouper.c | 202 > board/asus/grouper/pinmux-config-grouper.h| 362 ++ > board/asus/transformer-t30/Kconfig| 23 + > board/asus/transformer-t30/MAINTAINERS| 15 + > board/asus/transformer-t30/Makefile | 11 + > .../pinmux-config-transformer.h | 365 ++ > .../transformer-t30/transformer-t30-spl.c | 41 ++ > board/asus
RE: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support
Pull request sent to TomR for TOT u-boot-tegra/master. -Original Message- From: Tom Warren Sent: Monday, June 5, 2023 9:28 AM To: Svyatoslav Ryhel ; Tom Rini ; Simon Glass Cc: Jonas Schwöbel ; u-boot@lists.denx.de; Thierry Reding Subject: RE: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support I may have 'fixed' my buildman problems (with a series of python3/pip updates), testing now. If I can get it pushed to u-boot-tegra, I'll post a PR today or tomorrow. Fingers crossed. Tom -Original Message- From: Svyatoslav Ryhel Sent: Sunday, June 4, 2023 10:40 PM To: Tom Rini ; Simon Glass Cc: Tom Warren ; Jonas Schwöbel ; u-boot@lists.denx.de Subject: Re: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments чт, 1 черв. 2023 р. о 00:09 Tom Warren пише: > > Svyatoslav, > > I'm still stuck with not being able to run buildman on my local dev > laptop(s), both 18.04 and 20.04 Ubuntu. So without that, I can't really send > TomR a PR. > I could try running 'make *defconfig; make' for each Tegra board and see if > that works, I'll try to do that later today/tomorrow. > > Perhaps someone else (Tom, Simon, or some other custodian) can take these in > to their repo and get them merged to TOT u-boot/master. > > Tom > Tom Rini and Simon Glass, may you assist? How to resolve this situation? Tom Warren struggles with verifying buildability so this patches may hang indefinitely. Best regards Svyatoslav R. > -Original Message- > From: Svyatoslav Ryhel > Sent: Wednesday, May 31, 2023 12:11 PM > To: Tom Warren > Cc: Simon Glass ; Jonas Schwöbel > ; Svyatoslav Ryhel ; > u-boot@lists.denx.de > Subject: Re: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) > support > > External email: Use caution opening links or attachments > > > So what should I do? Re-uploading patches will do nothing I suppose? > > Best regards > Svyatoslav R. > > вт, 25 квіт. 2023 р. о 11:23 Svyatoslav Ryhel пише: > > > > This patchset adds support for native use of U-Boot on: > > - ASUS T30 Transformers (7 devices, all models); > > - ASUS/Google Nexus 7 (2012), both grouper and tilapia > > - LG Optimus 4X HD (P880) and Optimus Vu (P895) > > - HTC One X (endeavoru) > > as a replacement for the vendor bootloader. > > > > Current commits are designed to work on re-crypted devices but can > > be used on clean unmodified devices with slight restrictions (like > > no booting/mounting emmc and no self updating feature). > > > > All device setup commits fall under the same pattern. Alongside > > device bringup tegra requires few small patches: > > - add gpio keyboard as stdin device > > - make networking boot options optional > > - add a small tool to generate SoC UID > > > > Commits passed './tools/buildman/buildman tegra' (30 boards) without > > errors. > > > > --- > > Changes from v3: > > - extended amount of devices supported > > > > Changes from v2: > > - fuse build is excluded for T186 (it is not supported in it > > anyway) > > > > Changes from v1: > > - fix fuse headers for newer Tegra generations > > - allow grouper_common_defconfig to pass without fragments > > --- > > > > Jonas Schwöbel (1): > > configs: tegra-common-post: make PXE and DHCP boot targets > > optional > > > > Svyatoslav Ryhel (6): > > configs: tegra-common-post: add GPIO keyboard as STDIN device > > ARM: tegra: add SoC UID calculation function > > board: asus: transformer: add ASUS Transformer T30 family support > > board: asus: grouper: add Google Nexus 7 (2012) support > > board: lg: x3: add Optimus 4X HD and Optimus Vu support > > board: htc: endeavoru: add One X support > > > > arch/arm/dts/Makefile | 12 + > > arch/arm/dts/tegra30-asus-grouper-common.dtsi | 157 ++ > > .../dts/tegra30-asus-nexus7-grouper-E1565.dts | 43 ++ > > .../dts/tegra30-asus-nexus7-grouper-PM269.dts | 36 ++ > > .../dts/tegra30-asus-nexus7-tilapia-E1565.dts | 62 +++ > > arch/arm/dts/tegra30-asus-p1801-t.dts | 17 + > > arch/arm/dts/tegra30-asus-tf201.dts | 9 + > > arch/arm/dts/tegra30-asus-tf300t.dts | 18 + > > arch/arm/dts/tegra30-asus-tf300tg.dts | 9 + > > arch/arm/dts/tegra30-asus-tf300tl.dts | 9 + > > arch/arm/dts/tegra30-asus-tf600t.dts | 89 > > arch/arm/dts/tegra30-asus-tf700t.dts | 13 + > > arch/arm/dts/tegra30-asus-transformer.dtsi| 211 > > arch/arm/dts/tegra30-htc
Pull request, u-boot-tegra/master
Tom, please pull u-boot-tegra/master into u-boot/master. Thanks. It's passed 'buildman tegra' w/o error, and Svyatoslav has tested it on his boards. The following changes since commit 26659d426548d1c395ef878c3b820e53a6e3b346: Merge tag 'efi-2023-07-rc4' of https://source.denx.de/u-boot/custodians/u-boot-efi (2023-06-02 12:13:01 -0400) are available in the git repository at: https://source.denx.de/u-boot/custodians/u-boot-tegra.git master for you to fetch changes up to 28731540f9427d5d58ee2a554d0f2a0c5702ab80: board: htc: endeavoru: add One X support (2023-06-05 10:23:30 -0700) Jonas Schwöbel (1): configs: tegra-common-post: make PXE and DHCP boot targets optional Svyatoslav Ryhel (6): configs: tegra-common-post: add GPIO keyboard as STDIN device ARM: tegra: add SoC UID calculation function board: asus: transformer: add ASUS Transformer T30 family support board: asus: grouper: add Google Nexus 7 (2012) support board: lg: x3: add Optimus 4X HD and Optimus Vu support board: htc: endeavoru: add One X support Thierry Reding (2): ARM: tegra: Enable poweroff command on Jetson TX1 and Jetson Nano ARM: tegra: Enable poweroff command on Jetson TX2 Tomasz Maciej Nowak (1): ARM: dts: trimslice: sync SPI node with Linux dts arch/arm/dts/Makefile | 12 + arch/arm/dts/tegra20-trimslice.dts | 8 +- arch/arm/dts/tegra30-asus-grouper-common.dtsi | 157 +++ arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts | 43 ++ arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts | 36 ++ arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts | 62 +++ arch/arm/dts/tegra30-asus-p1801-t.dts | 17 + arch/arm/dts/tegra30-asus-tf201.dts| 9 + arch/arm/dts/tegra30-asus-tf300t.dts | 18 + arch/arm/dts/tegra30-asus-tf300tg.dts | 9 + arch/arm/dts/tegra30-asus-tf300tl.dts | 9 + arch/arm/dts/tegra30-asus-tf600t.dts | 89 arch/arm/dts/tegra30-asus-tf700t.dts | 13 + arch/arm/dts/tegra30-asus-transformer.dtsi | 211 ++ arch/arm/dts/tegra30-htc-endeavoru.dts | 166 arch/arm/dts/tegra30-lg-p880.dts | 40 ++ arch/arm/dts/tegra30-lg-p895.dts | 50 +++ arch/arm/dts/tegra30-lg-x3.dtsi| 180 + arch/arm/include/asm/arch-tegra/fuse.h | 7 + arch/arm/mach-tegra/Makefile | 4 + arch/arm/mach-tegra/fuse.c | 151 +++ arch/arm/mach-tegra/tegra30/Kconfig| 20 + board/asus/grouper/Kconfig | 22 + board/asus/grouper/MAINTAINERS | 6 + board/asus/grouper/Makefile| 14 + board/asus/grouper/grouper-spl-max.c | 45 +++ board/asus/grouper/grouper-spl-ti.c| 41 ++ board/asus/grouper/grouper.c | 202 + board/asus/grouper/pinmux-config-grouper.h | 362 + board/asus/transformer-t30/Kconfig | 35 ++ board/asus/transformer-t30/MAINTAINERS | 6 + board/asus/transformer-t30/Makefile| 11 + .../transformer-t30/pinmux-config-transformer.h| 365 + board/asus/transformer-t30/transformer-t30-spl.c | 41 ++ board/asus/transformer-t30/transformer-t30.c | 201 + board/htc/endeavoru/Kconfig| 12 + board/htc/endeavoru/MAINTAINERS| 6 + board/htc/endeavoru/Makefile | 11 + board/htc/endeavoru/endeavoru-spl.c| 47 +++ board/htc/endeavoru/endeavoru.c| 116 ++ board/htc/endeavoru/pinmux-config-endeavoru.h | 362 + board/lg/x3-t30/Kconfig| 26 ++ board/lg/x3-t30/MAINTAINERS| 6 + board/lg/x3-t30/Makefile | 11 + board/lg/x3-t30/pinmux-config-x3.h | 449 + board/lg/x3-t30/x3-t30-spl.c | 48 +++ board/lg/x3-t30/x3-t30.c | 176 configs/endeavoru_defconfig| 82 configs/grouper_E1565.config | 2 + configs/grouper_PM269.config | 2 + configs/grouper_common_defconfig | 82 configs/p1801-t.config | 2 + configs/p2371-2180_defconfig | 1 + configs/p2771--000_defconfig | 1 + configs/p2771--500_defconfig | 1 + configs/p3450-_defconfig | 1 + configs/p880.config| 4 + configs/p895.config
RE: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support
I may have 'fixed' my buildman problems (with a series of python3/pip updates), testing now. If I can get it pushed to u-boot-tegra, I'll post a PR today or tomorrow. Fingers crossed. Tom -Original Message- From: Svyatoslav Ryhel Sent: Sunday, June 4, 2023 10:40 PM To: Tom Rini ; Simon Glass Cc: Tom Warren ; Jonas Schwöbel ; u-boot@lists.denx.de Subject: Re: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments чт, 1 черв. 2023 р. о 00:09 Tom Warren пише: > > Svyatoslav, > > I'm still stuck with not being able to run buildman on my local dev > laptop(s), both 18.04 and 20.04 Ubuntu. So without that, I can't really send > TomR a PR. > I could try running 'make *defconfig; make' for each Tegra board and see if > that works, I'll try to do that later today/tomorrow. > > Perhaps someone else (Tom, Simon, or some other custodian) can take these in > to their repo and get them merged to TOT u-boot/master. > > Tom > Tom Rini and Simon Glass, may you assist? How to resolve this situation? Tom Warren struggles with verifying buildability so this patches may hang indefinitely. Best regards Svyatoslav R. > -Original Message- > From: Svyatoslav Ryhel > Sent: Wednesday, May 31, 2023 12:11 PM > To: Tom Warren > Cc: Simon Glass ; Jonas Schwöbel > ; Svyatoslav Ryhel ; > u-boot@lists.denx.de > Subject: Re: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) > support > > External email: Use caution opening links or attachments > > > So what should I do? Re-uploading patches will do nothing I suppose? > > Best regards > Svyatoslav R. > > вт, 25 квіт. 2023 р. о 11:23 Svyatoslav Ryhel пише: > > > > This patchset adds support for native use of U-Boot on: > > - ASUS T30 Transformers (7 devices, all models); > > - ASUS/Google Nexus 7 (2012), both grouper and tilapia > > - LG Optimus 4X HD (P880) and Optimus Vu (P895) > > - HTC One X (endeavoru) > > as a replacement for the vendor bootloader. > > > > Current commits are designed to work on re-crypted devices but can > > be used on clean unmodified devices with slight restrictions (like > > no booting/mounting emmc and no self updating feature). > > > > All device setup commits fall under the same pattern. Alongside > > device bringup tegra requires few small patches: > > - add gpio keyboard as stdin device > > - make networking boot options optional > > - add a small tool to generate SoC UID > > > > Commits passed './tools/buildman/buildman tegra' (30 boards) without > > errors. > > > > --- > > Changes from v3: > > - extended amount of devices supported > > > > Changes from v2: > > - fuse build is excluded for T186 (it is not supported in it > > anyway) > > > > Changes from v1: > > - fix fuse headers for newer Tegra generations > > - allow grouper_common_defconfig to pass without fragments > > --- > > > > Jonas Schwöbel (1): > > configs: tegra-common-post: make PXE and DHCP boot targets > > optional > > > > Svyatoslav Ryhel (6): > > configs: tegra-common-post: add GPIO keyboard as STDIN device > > ARM: tegra: add SoC UID calculation function > > board: asus: transformer: add ASUS Transformer T30 family support > > board: asus: grouper: add Google Nexus 7 (2012) support > > board: lg: x3: add Optimus 4X HD and Optimus Vu support > > board: htc: endeavoru: add One X support > > > > arch/arm/dts/Makefile | 12 + > > arch/arm/dts/tegra30-asus-grouper-common.dtsi | 157 ++ > > .../dts/tegra30-asus-nexus7-grouper-E1565.dts | 43 ++ > > .../dts/tegra30-asus-nexus7-grouper-PM269.dts | 36 ++ > > .../dts/tegra30-asus-nexus7-tilapia-E1565.dts | 62 +++ > > arch/arm/dts/tegra30-asus-p1801-t.dts | 17 + > > arch/arm/dts/tegra30-asus-tf201.dts | 9 + > > arch/arm/dts/tegra30-asus-tf300t.dts | 18 + > > arch/arm/dts/tegra30-asus-tf300tg.dts | 9 + > > arch/arm/dts/tegra30-asus-tf300tl.dts | 9 + > > arch/arm/dts/tegra30-asus-tf600t.dts | 89 > > arch/arm/dts/tegra30-asus-tf700t.dts | 13 + > > arch/arm/dts/tegra30-asus-transformer.dtsi| 211 > > arch/arm/dts/tegra30-htc-endeavoru.dts| 166 +++ > > arch/arm/dts/tegra30-lg-p880.dts | 40 ++ > > arch/arm/dts/tegra30-lg-p895.dts | 50 ++ > > arch/arm/dts/tegra30-lg-x3.dtsi | 180 +++ > > arch/arm/include/asm/arch-tegra/fuse.h| 7 + > > arch/arm
RE: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support
Svyatoslav, I'm still stuck with not being able to run buildman on my local dev laptop(s), both 18.04 and 20.04 Ubuntu. So without that, I can't really send TomR a PR. I could try running 'make *defconfig; make' for each Tegra board and see if that works, I'll try to do that later today/tomorrow. Perhaps someone else (Tom, Simon, or some other custodian) can take these in to their repo and get them merged to TOT u-boot/master. Tom -Original Message- From: Svyatoslav Ryhel Sent: Wednesday, May 31, 2023 12:11 PM To: Tom Warren Cc: Simon Glass ; Jonas Schwöbel ; Svyatoslav Ryhel ; u-boot@lists.denx.de Subject: Re: [PATCH v4 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments So what should I do? Re-uploading patches will do nothing I suppose? Best regards Svyatoslav R. вт, 25 квіт. 2023 р. о 11:23 Svyatoslav Ryhel пише: > > This patchset adds support for native use of U-Boot on: > - ASUS T30 Transformers (7 devices, all models); > - ASUS/Google Nexus 7 (2012), both grouper and tilapia > - LG Optimus 4X HD (P880) and Optimus Vu (P895) > - HTC One X (endeavoru) > as a replacement for the vendor bootloader. > > Current commits are designed to work on re-crypted devices but can be > used on clean unmodified devices with slight restrictions (like no > booting/mounting emmc and no self updating feature). > > All device setup commits fall under the same pattern. Alongside device > bringup tegra requires few small patches: > - add gpio keyboard as stdin device > - make networking boot options optional > - add a small tool to generate SoC UID > > Commits passed './tools/buildman/buildman tegra' (30 boards) without > errors. > > --- > Changes from v3: > - extended amount of devices supported > > Changes from v2: > - fuse build is excluded for T186 (it is not supported in it anyway) > > Changes from v1: > - fix fuse headers for newer Tegra generations > - allow grouper_common_defconfig to pass without fragments > --- > > Jonas Schwöbel (1): > configs: tegra-common-post: make PXE and DHCP boot targets optional > > Svyatoslav Ryhel (6): > configs: tegra-common-post: add GPIO keyboard as STDIN device > ARM: tegra: add SoC UID calculation function > board: asus: transformer: add ASUS Transformer T30 family support > board: asus: grouper: add Google Nexus 7 (2012) support > board: lg: x3: add Optimus 4X HD and Optimus Vu support > board: htc: endeavoru: add One X support > > arch/arm/dts/Makefile | 12 + > arch/arm/dts/tegra30-asus-grouper-common.dtsi | 157 ++ > .../dts/tegra30-asus-nexus7-grouper-E1565.dts | 43 ++ > .../dts/tegra30-asus-nexus7-grouper-PM269.dts | 36 ++ > .../dts/tegra30-asus-nexus7-tilapia-E1565.dts | 62 +++ > arch/arm/dts/tegra30-asus-p1801-t.dts | 17 + > arch/arm/dts/tegra30-asus-tf201.dts | 9 + > arch/arm/dts/tegra30-asus-tf300t.dts | 18 + > arch/arm/dts/tegra30-asus-tf300tg.dts | 9 + > arch/arm/dts/tegra30-asus-tf300tl.dts | 9 + > arch/arm/dts/tegra30-asus-tf600t.dts | 89 > arch/arm/dts/tegra30-asus-tf700t.dts | 13 + > arch/arm/dts/tegra30-asus-transformer.dtsi| 211 > arch/arm/dts/tegra30-htc-endeavoru.dts| 166 +++ > arch/arm/dts/tegra30-lg-p880.dts | 40 ++ > arch/arm/dts/tegra30-lg-p895.dts | 50 ++ > arch/arm/dts/tegra30-lg-x3.dtsi | 180 +++ > arch/arm/include/asm/arch-tegra/fuse.h| 7 + > arch/arm/mach-tegra/Makefile | 4 + > arch/arm/mach-tegra/fuse.c| 151 ++ > arch/arm/mach-tegra/tegra30/Kconfig | 20 + > board/asus/grouper/Kconfig| 22 + > board/asus/grouper/MAINTAINERS| 6 + > board/asus/grouper/Makefile | 14 + > board/asus/grouper/grouper-spl-max.c | 45 ++ > board/asus/grouper/grouper-spl-ti.c | 41 ++ > board/asus/grouper/grouper.c | 202 > board/asus/grouper/pinmux-config-grouper.h| 362 ++ > board/asus/transformer-t30/Kconfig| 35 ++ > board/asus/transformer-t30/MAINTAINERS| 6 + > board/asus/transformer-t30/Makefile | 11 + > .../pinmux-config-transformer.h | 365 ++ > .../transformer-t30/transformer-t30-spl.c | 41 ++ > board/asus/transformer-t30/transformer-t30.c | 201 > board/htc/endeavoru/Kconfig | 12 + > board/htc/endeavoru/MAINTAINERS | 6 + > board/htc/endeavoru/Makefile | 11 + > board/htc/endeavoru/endeavoru-spl.c | 47
RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
Thanks, Svyatoslav. I do all my testing on top of TOT u-boot-tegra/master, as that's what I'll use to send a PR to TomR. Before I apply any patches, I usually sync to TOT u-boot/master, via 'git rebase', then apply the patches, then build/test. But in this case, rebasing to TOT u-boot/master has resulted in my dev laptop not being able to run buildman. It fails w/a python error. So I've been applying your patches to TOT u-boot-tegra/master, and trying to build there. That should still build, IMO. I'll set up another laptop w/a more recent Ubuntu distro & try using buildman there w/u-boot/master. Otherwise, I'll have to do a git bisect of u-boot/master to see where it begins to fail to support buildman. (Adding TomR for vis, buildman error below:) tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ buildman tegra Traceback (most recent call last): File "/home/tom/denx/uboot-tegra/tools/buildman/buildman", line 24, in from buildman import control File "/home/tom/denx/uboot-tegra/tools/buildman/../buildman/control.py", line 6, in import importlib.resources ModuleNotFoundError: No module named 'importlib.resources' Tom -Original Message- From: Svyatoslav Ryhel Sent: Tuesday, April 18, 2023 12:32 AM To: Tom Warren Cc: Jonas Schwöbel ; u-boot@lists.denx.de Subject: Re: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments I have run buildman on top of u-boot master with 4 commits from the current patchset + 4 more boards bringup (Asus Transformer T20, Asus Transformer T30, LG X3, HTC endeavoru). I have totally 8 commits. Here is log of buildman: clamor@xeon:/u-boot$ ./tools/buildman/buildman tegra Building current source for 31 boards (12 threads, 1 job per thread) arm: w+ dalmore +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ venice2 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ jetson-tk1 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ apalis-tk1 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ cei-tk1-som +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ nyan-big +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ plutux +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ tec +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ ventana +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ transformer_t20 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ paz00 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ trimslice +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ medcom-wide +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ seaboard +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ harmony +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ grouper_common +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ colibri_t20 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ transformer_t30 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ tec-ng +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ endeavoru +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ cardhu +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ x3_t30 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ beaver +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ colibri_t30 +arm-none-eabi-ld.bfd: warning: -z norelro ignored arm: w+ apalis_t30 +arm-none-eabi-ld.bfd: warning: -z norelro ignored 6 250 /31 apalis_t30 Completed: 31 total built, 31 newly), duration 0:05:13, rate 0.10 As you can see there are no failures, and warnings are about gcc I use for arm. I assume that the tegra branch you are using may not be up-to-date. Best regards, Svyatoslav R. пн, 17 квіт. 2023 р. о 18:08 Tom Warren пише: > > This patchset is specific to the Nexus 7, IIUC. If the new devices also fall > under that umbrella, then I see no problem with adding them here. But if they > don't, maybe an ancillary patchset on top of this one would be better. > > Note that I still can't build with your latest (v3) patchset - grouper fails > buildman and make. And I don't know where you are getting the '-Pr' argument > w/buildman, my version doesn't support a -r option AFAICT. > > tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ buildman tegra30 Building > current source for 6 boards (6 threads, 2 jobs per thread) >arm: + grouper_common > +drivers/video/tegra.c:24:30: fatal error: asm/arch/display.h: No such > +file or directory #include > + ^ > +compilation terminated. > +make[3]: *** [drive
RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
This patchset is specific to the Nexus 7, IIUC. If the new devices also fall under that umbrella, then I see no problem with adding them here. But if they don't, maybe an ancillary patchset on top of this one would be better. Note that I still can't build with your latest (v3) patchset - grouper fails buildman and make. And I don't know where you are getting the '-Pr' argument w/buildman, my version doesn't support a -r option AFAICT. tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ buildman tegra30 Building current source for 6 boards (6 threads, 2 jobs per thread) arm: + grouper_common +drivers/video/tegra.c:24:30: fatal error: asm/arch/display.h: No such file or directory + #include + ^ +compilation terminated. +make[3]: *** [drivers/video/tegra.o] Error 1 +make[2]: *** [drivers/video] Error 2 +make[1]: *** [drivers] Error 2 +make: *** [sub-make] Error 2 501 /6 0:00:14 : beaver Completed: 6 total built, 6 newly), duration 0:01:26, rate 0.07 Tom -Original Message- From: Svyatoslav Ryhel Sent: Sunday, April 16, 2023 4:56 AM To: Tom Warren Cc: Jonas Schwöbel ; u-boot@lists.denx.de Subject: RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments Mailing list reduction. Tom, May I extend this patchset with adding commits for other t20/t30 devices bringup. They are all typical and look like grouper bringup. This should decrease quantity of separate patches sent involving your assist. Devices in interest are Asus Transformers, LG P880/P895 and Htc One X. Best regards, Svyatoslav R. 13 квітня 2023 р. 20:13:25 GMT+03:00, Tom Warren написав(-ла): >Svyatoslav, > >I tried to build w/V2 of your Nexus patches applied to TOT >u-boot-tegra/master, and I get these errors from 'buildman tegra': > > aarch64: + p2771--000 >+In file included from arch/arm/mach-tegra/fuse.c:16:0: >+arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: >+asm/arch/clock-tables.h: No such file or directory #include > >+ ^ >+compilation terminated. >+make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1 >+make[1]: *** [arch/arm/mach-tegra] Error 2 >+make: *** [sub-make] Error 2 > aarch64: + p2771--500 >+In file included from arch/arm/mach-tegra/fuse.c:16:0: >+arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: >+asm/arch/clock-tables.h: No such file or directory #include > >+ ^ >+compilation terminated. >+make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1 >+make[1]: *** [arch/arm/mach-tegra] Error 2 >+make: *** [sub-make] Error 2 > >These are the two T186 builds, they don't have or use a clock-tables.h . > >Please test building your patchset on TOT u-boot-tegra/master _before_ >posting. Use buildman (preferred) or 'make xxx_defconfig && make' for each >Tegra board (cumbersome). > >I won't take any future patches from you unless they're marked w/'passes >buildman' or 'each Tegra board builds OK w/make', etc. I certainly can't push >a PR to TomR if it fails to build. > >Tom > >-Original Message- >From: Svyatoslav Ryhel >Sent: Wednesday, April 12, 2023 11:05 PM >To: Tom Warren >Cc: Marek Vasut ; Philippe Reynes >; Marcel Ziswiler >; Fabio Estevam ; Simon >Glass ; Jonas Schwöbel ; >u-boot@lists.denx.de >Subject: Re: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) >support > >External email: Use caution opening links or attachments > > >чт, 13 квіт. 2023 р. о 02:07 Tom Warren пише: >> >> Svyatoslav, >> >> This series (patches 3 & 4, in particular) fails when applied to >> u-boot-tegra/master TOT. Error snippet is below (from make >> p2771--500_defconfig && make): >> >> CC arch/arm/mach-tegra/fuse.o >> arch/arm/mach-tegra/fuse.c:14:10: fatal error: asm/arch/clock.h: No >> such file or directory #include >> ^~ >> compilation terminated. >> scripts/Makefile.build:256: recipe for target >> 'arch/arm/mach-tegra/fuse.o' failed >> make[1]: *** [arch/arm/mach-tegra/fuse.o] Error 1 >> Makefile:1845: recipe for target 'arch/arm/mach-tegra' failed >> make: *** [arch/arm/mach-tegra] Error 2 > >Hello Tom. > >Thanks for your check. Issue was caused by non exposed headers for T186. >I have fixed that in v2, I hope buildman will pass. Additionally I have >modified grouper defconfig in such a way that it should pass even without >device fragment. > >Best regards, >Svyatoslav R. > >> >> buildman/tegra also fails for that board, and 2 others. Removing those two >> patches (3 & 4 in your Ne
RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
Svyatoslav, I tried to build w/V2 of your Nexus patches applied to TOT u-boot-tegra/master, and I get these errors from 'buildman tegra': aarch64: + p2771--000 +In file included from arch/arm/mach-tegra/fuse.c:16:0: +arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: asm/arch/clock-tables.h: No such file or directory + #include + ^ +compilation terminated. +make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1 +make[1]: *** [arch/arm/mach-tegra] Error 2 +make: *** [sub-make] Error 2 aarch64: + p2771--500 +In file included from arch/arm/mach-tegra/fuse.c:16:0: +arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: asm/arch/clock-tables.h: No such file or directory + #include + ^ +compilation terminated. +make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1 +make[1]: *** [arch/arm/mach-tegra] Error 2 +make: *** [sub-make] Error 2 These are the two T186 builds, they don't have or use a clock-tables.h . Please test building your patchset on TOT u-boot-tegra/master _before_ posting. Use buildman (preferred) or 'make xxx_defconfig && make' for each Tegra board (cumbersome). I won't take any future patches from you unless they're marked w/'passes buildman' or 'each Tegra board builds OK w/make', etc. I certainly can't push a PR to TomR if it fails to build. Tom -Original Message- From: Svyatoslav Ryhel Sent: Wednesday, April 12, 2023 11:05 PM To: Tom Warren Cc: Marek Vasut ; Philippe Reynes ; Marcel Ziswiler ; Fabio Estevam ; Simon Glass ; Jonas Schwöbel ; u-boot@lists.denx.de Subject: Re: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments чт, 13 квіт. 2023 р. о 02:07 Tom Warren пише: > > Svyatoslav, > > This series (patches 3 & 4, in particular) fails when applied to > u-boot-tegra/master TOT. Error snippet is below (from make > p2771--500_defconfig && make): > > CC arch/arm/mach-tegra/fuse.o > arch/arm/mach-tegra/fuse.c:14:10: fatal error: asm/arch/clock.h: No > such file or directory #include > ^~ > compilation terminated. > scripts/Makefile.build:256: recipe for target > 'arch/arm/mach-tegra/fuse.o' failed > make[1]: *** [arch/arm/mach-tegra/fuse.o] Error 1 > Makefile:1845: recipe for target 'arch/arm/mach-tegra' failed > make: *** [arch/arm/mach-tegra] Error 2 Hello Tom. Thanks for your check. Issue was caused by non exposed headers for T186. I have fixed that in v2, I hope buildman will pass. Additionally I have modified grouper defconfig in such a way that it should pass even without device fragment. Best regards, Svyatoslav R. > > buildman/tegra also fails for that board, and 2 others. Removing those two > patches (3 & 4 in your Nexus7 patchset) gets make & buildman working again. > Buildman/tegra worked fine on the base u-boot-tegra/master repo (before I > applied your patchset w/git am). > > PTAL, > > Tom > > -Original Message- > From: Svyatoslav Ryhel > Sent: Wednesday, April 12, 2023 12:50 PM > To: Tom Warren ; Svyatoslav Ryhel > ; Marek Vasut ; Philippe Reynes > ; Marcel Ziswiler > ; Fabio Estevam ; Simon > Glass ; Jonas Schwöbel > Cc: u-boot@lists.denx.de > Subject: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support > > External email: Use caution opening links or attachments > > > This patchset adds support for native use of U-Boot on ASUS/Google Nexus 7 > (2012), aka grouper/tilapia as a replacement of vendor bootloader. Alongside > device bringup tegra requires few small patches: > - add gpio keyboard as stdin device > - make networking boot options optional > - add a small tool to generate SoC UID > > Jonas Schwöbel (1): > configs: tegra-common-post: make PXE and DHCP boot targets optional > > Svyatoslav Ryhel (3): > configs: tegra-common-post: add GPIO keyboard as STDIN device > ARM: tegra: add SoC UID calculation function > board: asus: grouper: add Google Nexus 7 (2012) support > > arch/arm/dts/Makefile | 3 + > arch/arm/dts/tegra30-asus-grouper-common.dtsi | 125 ++ > .../dts/tegra30-asus-nexus7-grouper-E1565.dts | 40 ++ > .../dts/tegra30-asus-nexus7-grouper-PM269.dts | 65 > .../dts/tegra30-asus-nexus7-tilapia-E1565.dts | 40 ++ > arch/arm/include/asm/arch-tegra/fuse.h| 7 + > arch/arm/mach-tegra/Makefile | 2 +- > arch/arm/mach-tegra/fuse.c| 151 > arch/arm/mach-tegra/tegra30/Kconfig | 5 + > board/asus/grouper/Kconfig| 20 + > board/asus/grouper/MAINTAINERS| 6 + > board/asus/grouper/Makefil
RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
Svyatoslav, This series (patches 3 & 4, in particular) fails when applied to u-boot-tegra/master TOT. Error snippet is below (from make p2771--500_defconfig && make): CC arch/arm/mach-tegra/fuse.o arch/arm/mach-tegra/fuse.c:14:10: fatal error: asm/arch/clock.h: No such file or directory #include ^~ compilation terminated. scripts/Makefile.build:256: recipe for target 'arch/arm/mach-tegra/fuse.o' failed make[1]: *** [arch/arm/mach-tegra/fuse.o] Error 1 Makefile:1845: recipe for target 'arch/arm/mach-tegra' failed make: *** [arch/arm/mach-tegra] Error 2 buildman/tegra also fails for that board, and 2 others. Removing those two patches (3 & 4 in your Nexus7 patchset) gets make & buildman working again. Buildman/tegra worked fine on the base u-boot-tegra/master repo (before I applied your patchset w/git am). PTAL, Tom -Original Message- From: Svyatoslav Ryhel Sent: Wednesday, April 12, 2023 12:50 PM To: Tom Warren ; Svyatoslav Ryhel ; Marek Vasut ; Philippe Reynes ; Marcel Ziswiler ; Fabio Estevam ; Simon Glass ; Jonas Schwöbel Cc: u-boot@lists.denx.de Subject: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support External email: Use caution opening links or attachments This patchset adds support for native use of U-Boot on ASUS/Google Nexus 7 (2012), aka grouper/tilapia as a replacement of vendor bootloader. Alongside device bringup tegra requires few small patches: - add gpio keyboard as stdin device - make networking boot options optional - add a small tool to generate SoC UID Jonas Schwöbel (1): configs: tegra-common-post: make PXE and DHCP boot targets optional Svyatoslav Ryhel (3): configs: tegra-common-post: add GPIO keyboard as STDIN device ARM: tegra: add SoC UID calculation function board: asus: grouper: add Google Nexus 7 (2012) support arch/arm/dts/Makefile | 3 + arch/arm/dts/tegra30-asus-grouper-common.dtsi | 125 ++ .../dts/tegra30-asus-nexus7-grouper-E1565.dts | 40 ++ .../dts/tegra30-asus-nexus7-grouper-PM269.dts | 65 .../dts/tegra30-asus-nexus7-tilapia-E1565.dts | 40 ++ arch/arm/include/asm/arch-tegra/fuse.h| 7 + arch/arm/mach-tegra/Makefile | 2 +- arch/arm/mach-tegra/fuse.c| 151 arch/arm/mach-tegra/tegra30/Kconfig | 5 + board/asus/grouper/Kconfig| 20 + board/asus/grouper/MAINTAINERS| 6 + board/asus/grouper/Makefile | 14 + board/asus/grouper/grouper-spl-max.c | 46 +++ board/asus/grouper/grouper-spl-ti.c | 42 ++ board/asus/grouper/grouper.c | 209 ++ board/asus/grouper/pinmux-config-grouper.h| 362 ++ configs/grouper_E1565.config | 2 + configs/grouper_PM269.config | 2 + configs/grouper_common_defconfig | 85 configs/tilapia.config| 3 + include/configs/grouper.h | 68 include/configs/tegra-common-post.h | 28 +- 22 files changed, 1319 insertions(+), 6 deletions(-) create mode 100644 arch/arm/dts/tegra30-asus-grouper-common.dtsi create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts create mode 100644 arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts create mode 100644 arch/arm/mach-tegra/fuse.c create mode 100644 board/asus/grouper/Kconfig create mode 100644 board/asus/grouper/MAINTAINERS create mode 100644 board/asus/grouper/Makefile create mode 100644 board/asus/grouper/grouper-spl-max.c create mode 100644 board/asus/grouper/grouper-spl-ti.c create mode 100644 board/asus/grouper/grouper.c create mode 100644 board/asus/grouper/pinmux-config-grouper.h create mode 100644 configs/grouper_E1565.config create mode 100644 configs/grouper_PM269.config create mode 100644 configs/grouper_common_defconfig create mode 100644 configs/tilapia.config create mode 100644 include/configs/grouper.h -- 2.37.2
Pull request, u-boot-tegra/master
Tom,
Please pull u-boot-tegra/master into U-Boot/master. Thanks.
It has passed 'buildman tegra' w/o error, and Thierry has tested it on his
Tegra boards.
The following changes since commit 8c3acb726ef083d3d5de12f20318ee0e5070:
Merge branch 'master' of
https://source.denx.de/u-boot/custodians/u-boot-usb (2023-02-22 13:36:29
-0500)
are available in the git repository at:
https://source.denx.de/u-boot/custodians/u-boot-tegra.git master
for you to fetch changes up to 5a8fe1ee818e0f8a74fa088f6a3d705a01b6afbe:
ARM: tegra20: implement BCT patching (2023-02-23 12:55:37 -0700)
Maxim Schwalm (1):
ARM: tegra: provide default USB gadget setup
Ramin Khonsari (1):
ARM: tegra30: implement BCT patching
Svyatoslav Ryhel (14):
tegra30: clock: add EXTPERIPH
ARM: t20/t30: swap host1x and disp1 clock parents
ARM: tegra: clock: add clk_id_to_pll_id helper
ARM: tegra: clock: add clock_decode_pair helper
ARM: tegra30: add PLLD to pll setup
ARM: tegra: Fix Tegra PWM parent clock
spi: tegra20_slink: accept any word length
ARM: tegra: add late init support
ARM: tegra: create common pre-dm i2c write
board: tegra124: switch to updated pre-dm i2c write
board: tegra30: switch to updated pre-dm i2c write
ARM: tegra: expose crypto module for all Tegra SoCs
ARM: tegra: crypto: extend crypto functional
ARM: tegra20: implement BCT patching
arch/arm/dts/tegra114.dtsi | 2 +-
arch/arm/dts/tegra124.dtsi | 2 +-
arch/arm/include/asm/arch-tegra/clock.h | 21 ++
arch/arm/include/asm/arch-tegra/crypto.h | 47 +
arch/arm/include/asm/arch-tegra/sys_proto.h | 6 ++
arch/arm/include/asm/arch-tegra/tegra_i2c.h | 17 +
arch/arm/include/asm/arch-tegra30/clock-tables.h | 6 +-
arch/arm/mach-tegra/Kconfig | 14
arch/arm/mach-tegra/Makefile | 1 +
arch/arm/mach-tegra/board2.c | 2 +
arch/arm/mach-tegra/clock.c | 23 ++
arch/arm/mach-tegra/cpu.h| 1 -
arch/arm/mach-tegra/{tegra20 => }/crypto.c | 63 -
arch/arm/mach-tegra/tegra114/clock.c | 39 +-
arch/arm/mach-tegra/tegra124/clock.c | 40 ++-
arch/arm/mach-tegra/tegra124/cpu.c | 4 ++
arch/arm/mach-tegra/tegra20/Kconfig | 1 +
arch/arm/mach-tegra/tegra20/Makefile | 7 +-
arch/arm/mach-tegra/tegra20/bct.c| 79 +
arch/arm/mach-tegra/tegra20/bct.h| 42 +++
arch/arm/mach-tegra/tegra20/clock.c | 43 ++-
arch/arm/mach-tegra/tegra20/crypto.h | 19 -
arch/arm/mach-tegra/tegra210/clock.c | 39 +-
arch/arm/mach-tegra/tegra30/Kconfig | 8 ---
arch/arm/mach-tegra/tegra30/Makefile | 1 +
arch/arm/mach-tegra/tegra30/bct.c| 79 +
arch/arm/mach-tegra/tegra30/bct.h| 42 +++
arch/arm/mach-tegra/tegra30/clock.c | 90
++--
arch/arm/mach-tegra/tegra30/cpu.c| 55 +--
board/avionic-design/tec-ng/Makefile | 4 +-
board/avionic-design/tec-ng/tec-ng-spl.c | 34 +
board/nvidia/beaver/Makefile | 2 +
board/nvidia/beaver/beaver-spl.c | 43 +++
board/nvidia/cardhu/Makefile | 4 +-
board/nvidia/cardhu/cardhu-spl.c | 43 +++
board/nvidia/venice2/as3722_init.c | 65 ++---
board/nvidia/venice2/as3722_init.h | 43 ---
board/toradex/apalis-tk1/as3722_init.c | 85
--
board/toradex/apalis-tk1/as3722_init.h | 40 ---
board/toradex/apalis_t30/Makefile| 2 +
board/toradex/apalis_t30/apalis_t30-spl.c| 34 +
board/toradex/colibri_t30/Makefile | 2 +
board/toradex/colibri_t30/colibri_t30-spl.c | 34 +
configs/beaver_defconfig | 3 -
configs/cei-tk1-som_defconfig| 3 -
configs/dalmore_defconfig| 3 -
configs/jetson-tk1_defconfig | 3 -
configs/nyan-big_defconfig | 3 -
configs/p2371-_defconfig | 3 -
configs/p2371-2180_defconfig | 3 -
configs/p2571_defconfig | 3 -
configs/p3450-_defconfig | 3 -
configs/venice2_defconfig| 3 -
doc/usage/cmd/ebtupdate.rst | 69 ++
drivers/pwm/tegra_pwm.c | 10 +--
drivers/spi/tegra20_slink.c
RE: [PATCH v4 00/16] General Tegra improvements
Buildman ran fine on TOT u-boot-tegra/master rebased w/TOT u-boot/master on Friday. I'll send a PR today. I'll look at merging your new DC 11-patch series later in the week. If we could get any ACKs/Tested-By/Reviewed-By's in ASAP that would be great. Tom -Original Message- From: Svyatoslav Ryhel Sent: Tuesday, February 21, 2023 1:00 AM To: Tom Warren Cc: u-boot@lists.denx.de Subject: Re: [PATCH v4 00/16] General Tegra improvements External email: Use caution opening links or attachments Greetings! Did buildman run smoothly? I have fixed DSI support and DC related patches are already sent. Best regards, Svyatoslav R. пт, 17 лют. 2023 р. о 18:27 Tom Warren пише: > > OK, now it's working fine on top of u-boot-tegra/master, and rebasing that > result against u-boot/master TOT is fine, too. Sorry - don't know what I did > wrong before. > I'll run buildman on it and then get a PR out to TomR if it all looks good. > > Thanks! > > -Original Message- > From: Tom Warren > Sent: Friday, February 17, 2023 9:22 AM > To: Svyatoslav Ryhel > Cc: u-boot@lists.denx.de > Subject: RE: [PATCH v4 00/16] General Tegra improvements > > OK, let me retry on u-boot-tegra/master. > > -Original Message- > From: Svyatoslav Ryhel > Sent: Friday, February 17, 2023 9:07 AM > To: Tom Warren > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH v4 00/16] General Tegra improvements > > External email: Use caution opening links or attachments > > > I was able to git am it on top of u-boot/master without any errors > > clamor@xeon:/media/clamor/work/u-boot$ git am > bundle-23303-Svyatoslav-16-v4.mbox > Застосування: tegra30: clock: add EXTPERIPH > Застосування: ARM: t20/t30: swap host1x and disp1 clock parents > Застосування: ARM: tegra: clock: add clk_id_to_pll_id helper > Застосування: ARM: tegra: clock: add clock_decode_pair helper > Застосування: ARM: tegra30: add PLLD to pll setup > Застосування: ARM: tegra: Fix Tegra PWM parent clock > Застосування: spi: tegra20_slink: accept any word length > Застосування: ARM: tegra: provide default USB gadget setup > Застосування: ARM: tegra: add late init support > Застосування: ARM: tegra: create common pre-dm i2c write > Застосування: board: tegra124: switch to updated pre-dm i2c write > Застосування: board: tegra30: switch to updated pre-dm i2c write > Застосування: ARM: tegra: expose crypto module for all Tegra SoCs > Застосування: ARM: tegra: crypto: extend crypto functional > Застосування: ARM: tegra30: implement BCT patching > Застосування: ARM: tegra20: implement BCT patching > .git/rebase-apply/patch:249: new blank line at EOF. > + > warning: 1 рядок додав помилки в пробільних символах. > clamor@xeon:/media/clamor/work/u-boot$ > > пт, 17 лют. 2023 р. о 17:57 Tom Warren пише: > > > > I've got a bundle with your 16 patches, created using PatchWork/U-Boot, and > > the patches are ordered correctly within that bundle. Attached here - see > > if it works for you. > > > > Tom > > > > -Original Message- > > From: Svyatoslav Ryhel > > Sent: Friday, February 17, 2023 1:39 AM > > To: Tom Warren > > Cc: u-boot@lists.denx.de > > Subject: Re: [PATCH v4 00/16] General Tegra improvements > > > > External email: Use caution opening links or attachments > > > > > > You have NOT applied patch 13 ARM: tegra: expose crypto module for all > > Tegra SoCs or applied it after patch 14 which brakes order. PTAL. > > > > вт, 14 лют. 2023 р. о 23:45 Tom Warren пише: > > > > > > > > > > > > Svyatoslav, > > > > > > Taking TOT u-boot-tegra/master, and fast-forwarding to TOT u-boot/master, > > > I then try to apply your 16 patch series and get the following failures > > > (using patch). Note that I retargeted the crypto.c patch by hand to point > > > to tegra20/crypto.c, which I believe one of your patches moves to > > > arch/arm/tegra. PTAL. > > > > > > tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ patch -p1 -i > > > ~/Downloads/bundle-23303-Svyatoslav-16-v4.mbox --dry-run checking > > > file arch/arm/include/asm/arch-tegra30/clock-tables.h > > > checking file arch/arm/mach-tegra/tegra30/clock.c > > > checking file arch/arm/mach-tegra/tegra20/clock.c > > > checking file arch/arm/mach-tegra/tegra30/clock.c > > > checking file arch/arm/include/asm/arch-tegra/clock.h > > > checking file arch/arm/mach-tegra/tegra114/clock.c > > > checking file arch/arm/mach-tegra/tegra124/clock.c > > > checking file arch/arm/mach-tegra/tegra20/clock.c > > > checking file arch/arm/mach-tegra/tegra21
RE: [PATCH v4 00/16] General Tegra improvements
OK, now it's working fine on top of u-boot-tegra/master, and rebasing that result against u-boot/master TOT is fine, too. Sorry - don't know what I did wrong before. I'll run buildman on it and then get a PR out to TomR if it all looks good. Thanks! -Original Message- From: Tom Warren Sent: Friday, February 17, 2023 9:22 AM To: Svyatoslav Ryhel Cc: u-boot@lists.denx.de Subject: RE: [PATCH v4 00/16] General Tegra improvements OK, let me retry on u-boot-tegra/master. -Original Message- From: Svyatoslav Ryhel Sent: Friday, February 17, 2023 9:07 AM To: Tom Warren Cc: u-boot@lists.denx.de Subject: Re: [PATCH v4 00/16] General Tegra improvements External email: Use caution opening links or attachments I was able to git am it on top of u-boot/master without any errors clamor@xeon:/media/clamor/work/u-boot$ git am bundle-23303-Svyatoslav-16-v4.mbox Застосування: tegra30: clock: add EXTPERIPH Застосування: ARM: t20/t30: swap host1x and disp1 clock parents Застосування: ARM: tegra: clock: add clk_id_to_pll_id helper Застосування: ARM: tegra: clock: add clock_decode_pair helper Застосування: ARM: tegra30: add PLLD to pll setup Застосування: ARM: tegra: Fix Tegra PWM parent clock Застосування: spi: tegra20_slink: accept any word length Застосування: ARM: tegra: provide default USB gadget setup Застосування: ARM: tegra: add late init support Застосування: ARM: tegra: create common pre-dm i2c write Застосування: board: tegra124: switch to updated pre-dm i2c write Застосування: board: tegra30: switch to updated pre-dm i2c write Застосування: ARM: tegra: expose crypto module for all Tegra SoCs Застосування: ARM: tegra: crypto: extend crypto functional Застосування: ARM: tegra30: implement BCT patching Застосування: ARM: tegra20: implement BCT patching .git/rebase-apply/patch:249: new blank line at EOF. + warning: 1 рядок додав помилки в пробільних символах. clamor@xeon:/media/clamor/work/u-boot$ пт, 17 лют. 2023 р. о 17:57 Tom Warren пише: > > I've got a bundle with your 16 patches, created using PatchWork/U-Boot, and > the patches are ordered correctly within that bundle. Attached here - see if > it works for you. > > Tom > > -Original Message- > From: Svyatoslav Ryhel > Sent: Friday, February 17, 2023 1:39 AM > To: Tom Warren > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH v4 00/16] General Tegra improvements > > External email: Use caution opening links or attachments > > > You have NOT applied patch 13 ARM: tegra: expose crypto module for all Tegra > SoCs or applied it after patch 14 which brakes order. PTAL. > > вт, 14 лют. 2023 р. о 23:45 Tom Warren пише: > > > > > > > > Svyatoslav, > > > > Taking TOT u-boot-tegra/master, and fast-forwarding to TOT u-boot/master, I > > then try to apply your 16 patch series and get the following failures > > (using patch). Note that I retargeted the crypto.c patch by hand to point > > to tegra20/crypto.c, which I believe one of your patches moves to > > arch/arm/tegra. PTAL. > > > > tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ patch -p1 -i > > ~/Downloads/bundle-23303-Svyatoslav-16-v4.mbox --dry-run checking > > file arch/arm/include/asm/arch-tegra30/clock-tables.h > > checking file arch/arm/mach-tegra/tegra30/clock.c > > checking file arch/arm/mach-tegra/tegra20/clock.c > > checking file arch/arm/mach-tegra/tegra30/clock.c > > checking file arch/arm/include/asm/arch-tegra/clock.h > > checking file arch/arm/mach-tegra/tegra114/clock.c > > checking file arch/arm/mach-tegra/tegra124/clock.c > > checking file arch/arm/mach-tegra/tegra20/clock.c > > checking file arch/arm/mach-tegra/tegra210/clock.c > > checking file arch/arm/mach-tegra/tegra30/clock.c > > checking file arch/arm/include/asm/arch-tegra/clock.h > > checking file arch/arm/mach-tegra/clock.c checking file > > arch/arm/mach-tegra/tegra30/clock.c > > Hunk #1 succeeded at 632 (offset -37 lines). > > checking file arch/arm/dts/tegra114.dtsi checking file > > arch/arm/dts/tegra124.dtsi checking file > > arch/arm/mach-tegra/tegra114/clock.c > > Hunk #1 succeeded at 745 (offset -37 lines). > > checking file arch/arm/mach-tegra/tegra124/clock.c > > Hunk #1 succeeded at 1170 (offset -38 lines). > > checking file arch/arm/mach-tegra/tegra20/clock.c > > Hunk #1 succeeded at 767 (offset -37 lines). > > checking file arch/arm/mach-tegra/tegra210/clock.c > > Hunk #1 succeeded at 1241 (offset -37 lines). > > checking file arch/arm/mach-tegra/tegra30/clock.c > > Hunk #1 succeeded at 806 (offset -78 lines). > > checking file drivers/pwm/tegra_pwm.c checking file > > drivers/spi/tegra20_slink.c checking file configs/beaver_defconfig > > checking file configs/cei-tk1
RE: [PATCH v4 00/16] General Tegra improvements
OK, let me retry on u-boot-tegra/master. -Original Message- From: Svyatoslav Ryhel Sent: Friday, February 17, 2023 9:07 AM To: Tom Warren Cc: u-boot@lists.denx.de Subject: Re: [PATCH v4 00/16] General Tegra improvements External email: Use caution opening links or attachments I was able to git am it on top of u-boot/master without any errors clamor@xeon:/media/clamor/work/u-boot$ git am bundle-23303-Svyatoslav-16-v4.mbox Застосування: tegra30: clock: add EXTPERIPH Застосування: ARM: t20/t30: swap host1x and disp1 clock parents Застосування: ARM: tegra: clock: add clk_id_to_pll_id helper Застосування: ARM: tegra: clock: add clock_decode_pair helper Застосування: ARM: tegra30: add PLLD to pll setup Застосування: ARM: tegra: Fix Tegra PWM parent clock Застосування: spi: tegra20_slink: accept any word length Застосування: ARM: tegra: provide default USB gadget setup Застосування: ARM: tegra: add late init support Застосування: ARM: tegra: create common pre-dm i2c write Застосування: board: tegra124: switch to updated pre-dm i2c write Застосування: board: tegra30: switch to updated pre-dm i2c write Застосування: ARM: tegra: expose crypto module for all Tegra SoCs Застосування: ARM: tegra: crypto: extend crypto functional Застосування: ARM: tegra30: implement BCT patching Застосування: ARM: tegra20: implement BCT patching .git/rebase-apply/patch:249: new blank line at EOF. + warning: 1 рядок додав помилки в пробільних символах. clamor@xeon:/media/clamor/work/u-boot$ пт, 17 лют. 2023 р. о 17:57 Tom Warren пише: > > I've got a bundle with your 16 patches, created using PatchWork/U-Boot, and > the patches are ordered correctly within that bundle. Attached here - see if > it works for you. > > Tom > > -Original Message- > From: Svyatoslav Ryhel > Sent: Friday, February 17, 2023 1:39 AM > To: Tom Warren > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH v4 00/16] General Tegra improvements > > External email: Use caution opening links or attachments > > > You have NOT applied patch 13 ARM: tegra: expose crypto module for all Tegra > SoCs or applied it after patch 14 which brakes order. PTAL. > > вт, 14 лют. 2023 р. о 23:45 Tom Warren пише: > > > > > > > > Svyatoslav, > > > > Taking TOT u-boot-tegra/master, and fast-forwarding to TOT u-boot/master, I > > then try to apply your 16 patch series and get the following failures > > (using patch). Note that I retargeted the crypto.c patch by hand to point > > to tegra20/crypto.c, which I believe one of your patches moves to > > arch/arm/tegra. PTAL. > > > > tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ patch -p1 -i > > ~/Downloads/bundle-23303-Svyatoslav-16-v4.mbox --dry-run checking > > file arch/arm/include/asm/arch-tegra30/clock-tables.h > > checking file arch/arm/mach-tegra/tegra30/clock.c > > checking file arch/arm/mach-tegra/tegra20/clock.c > > checking file arch/arm/mach-tegra/tegra30/clock.c > > checking file arch/arm/include/asm/arch-tegra/clock.h > > checking file arch/arm/mach-tegra/tegra114/clock.c > > checking file arch/arm/mach-tegra/tegra124/clock.c > > checking file arch/arm/mach-tegra/tegra20/clock.c > > checking file arch/arm/mach-tegra/tegra210/clock.c > > checking file arch/arm/mach-tegra/tegra30/clock.c > > checking file arch/arm/include/asm/arch-tegra/clock.h > > checking file arch/arm/mach-tegra/clock.c checking file > > arch/arm/mach-tegra/tegra30/clock.c > > Hunk #1 succeeded at 632 (offset -37 lines). > > checking file arch/arm/dts/tegra114.dtsi checking file > > arch/arm/dts/tegra124.dtsi checking file > > arch/arm/mach-tegra/tegra114/clock.c > > Hunk #1 succeeded at 745 (offset -37 lines). > > checking file arch/arm/mach-tegra/tegra124/clock.c > > Hunk #1 succeeded at 1170 (offset -38 lines). > > checking file arch/arm/mach-tegra/tegra20/clock.c > > Hunk #1 succeeded at 767 (offset -37 lines). > > checking file arch/arm/mach-tegra/tegra210/clock.c > > Hunk #1 succeeded at 1241 (offset -37 lines). > > checking file arch/arm/mach-tegra/tegra30/clock.c > > Hunk #1 succeeded at 806 (offset -78 lines). > > checking file drivers/pwm/tegra_pwm.c checking file > > drivers/spi/tegra20_slink.c checking file configs/beaver_defconfig > > checking file configs/cei-tk1-som_defconfig checking file > > configs/dalmore_defconfig checking file configs/jetson-tk1_defconfig > > checking file configs/nyan-big_defconfig checking file > > configs/p2371-_defconfig checking file > > configs/p2371-2180_defconfig checking file configs/p2571_defconfig > > checking file configs/p3450-_defconfig checking file > > configs/venice2_defconfig checking file drivers/usb/gadget/Kcon
RE: [PATCH v4 00/16] General Tegra improvements
-ThinkPad-T580:~/denx/uboot-tegra$
-Original Message-
From: Svyatoslav Ryhel
Sent: Tuesday, February 14, 2023 10:35 AM
To: Tom Warren ; Marcel Ziswiler
; Allen Martin ; Jagan Teki
; Lukasz Majewski ; Marek Vasut
; Svyatoslav Ryhel ; Ramin Khonsari
; Thierry Reding ; Maxim
Schwalm ; Dmitry Osipenko ; Simon
Glass
Cc: u-boot@lists.denx.de
Subject: [PATCH v4 00/16] General Tegra improvements
External email: Use caution opening links or attachments
List of changes in patch set:
- add missing EXTPERIPH clocks for t30
- swap host1x and disp1 clock parents (as they should be)
- add clk_id_to_pll_id and clock_decode_pair helpers to use
dts deeper (in tegra clocks often go in pair child - parent)
- include PLLD setup in T30 (DISP1 may use it as parent on
some devices)
- fix Tegra PWM parent clock inline with linux
- Tegra SLINK: patch to accept any word length (unlike 8bit
aligned which was before)
- provide default USB gadget setup for existing Nvidia boards
- add late init function to be able to configure pre-boot stage
(like uncovering serial number or setting mac address)
- create common pre-dm i2c write for PMIC (used on T30 and T124
to configure basic PMIC voltages required to boot like cpu and
core voltages)
- expose crypto module for all Tegra SoCs and implement BCT patching
(ability to update bootloader from u-boot on production devices
without need in host PC)
---
Changelog from v3
- added tested-by
Changelog from v2
- fixed T114 TEGRA114_CLK_PLL_E_OUT0
- adjusted pre-dm i2c write commit description
- added description file for ebtupdate command
- minor improvements of bct.c comments
Changelog from v1
- rebased to latest u-boot master
- PLLD setup for T30 moved specifically into T30 area
---
Maxim Schwalm (1):
ARM: tegra: provide default USB gadget setup
Ramin Khonsari (1):
ARM: tegra30: implement BCT patching
Svyatoslav Ryhel (14):
tegra30: clock: add EXTPERIPH
ARM: t20/t30: swap host1x and disp1 clock parents
ARM: tegra: clock: add clk_id_to_pll_id helper
ARM: tegra: clock: add clock_decode_pair helper
ARM: tegra30: add PLLD to pll setup
ARM: tegra: Fix Tegra PWM parent clock
spi: tegra20_slink: accept any word length
ARM: tegra: add late init support
ARM: tegra: create common pre-dm i2c write
board: tegra124: switch to updated pre-dm i2c write
board: tegra30: switch to updated pre-dm i2c write
ARM: tegra: expose crypto module for all Tegra SoCs
ARM: tegra: crypto: extend crypto functional
ARM: tegra20: implement BCT patching
arch/arm/dts/tegra114.dtsi| 2 +-
arch/arm/dts/tegra124.dtsi| 2 +-
arch/arm/include/asm/arch-tegra/clock.h | 21 +
arch/arm/include/asm/arch-tegra/crypto.h | 47 ++
arch/arm/include/asm/arch-tegra/sys_proto.h | 6 ++
arch/arm/include/asm/arch-tegra/tegra_i2c.h | 17
.../include/asm/arch-tegra30/clock-tables.h | 6 +-
arch/arm/mach-tegra/Kconfig | 14 +++
arch/arm/mach-tegra/Makefile | 1 +
arch/arm/mach-tegra/board2.c | 2 +
arch/arm/mach-tegra/clock.c | 23 +
arch/arm/mach-tegra/cpu.h | 1 -
arch/arm/mach-tegra/{tegra20 => }/crypto.c| 63 +
arch/arm/mach-tegra/tegra114/clock.c | 39 +++-
arch/arm/mach-tegra/tegra124/clock.c | 40 -
arch/arm/mach-tegra/tegra124/cpu.c| 4 +
arch/arm/mach-tegra/tegra20/Kconfig | 1 +
arch/arm/mach-tegra/tegra20/Makefile | 7 +-
arch/arm/mach-tegra/tegra20/bct.c | 79
arch/arm/mach-tegra/tegra20/bct.h | 42 +
arch/arm/mach-tegra/tegra20/clock.c | 43 -
arch/arm/mach-tegra/tegra20/crypto.h | 19
arch/arm/mach-tegra/tegra210/clock.c | 39 +++-
arch/arm/mach-tegra/tegra30/Kconfig | 8 --
arch/arm/mach-tegra/tegra30/Makefile | 1 +
arch/arm/mach-tegra/tegra30/bct.c | 79
arch/arm/mach-tegra/tegra30/bct.h | 42 +
arch/arm/mach-tegra/tegra30/clock.c | 90 +--
arch/arm/mach-tegra/tegra30/cpu.c | 55 +---
board/avionic-design/tec-ng/Makefile | 4 +-
board/avionic-design/tec-ng/tec-ng-spl.c | 34 +++
board/nvidia/beaver/Makefile | 2 +
board/nvidia/beaver/beaver-spl.c | 43 +
board/nvidia/cardhu/Makefile | 4 +-
board/nvidia/cardhu/cardhu-spl.c | 43 +
board/nvidia/venice2/as3722_init.c| 65 +-
board/nvidia/venice2/as3722_init.h| 43 -
board/toradex/apalis-tk1/as3722_init.c| 85 ++
board/toradex/apalis-tk1/as3722_init.h| 40 -
board/toradex/apalis_t30/Makefile | 2 +
board/toradex/apalis_t30/apalis_t30-spl.c |
RE: [PATCH v3 00/16] General Tegra improvements
Usually best to have the original author make sure all of the patches have all
the attributes required, so if you wouldn't mind, I'll take v4 when it's ready.
Thanks!
Tom
-Original Message-
From: Svyatoslav Ryhel
Sent: Tuesday, February 14, 2023 7:15 AM
To: Thierry Reding ; Tom Warren
Cc: Marcel Ziswiler ; Allen Martin
; Jagan Teki ; Lukasz Majewski
; Marek Vasut ; Ramin Khonsari
; Maxim Schwalm ; Dmitry
Osipenko ; u-boot@lists.denx.de
Subject: Re: [PATCH v3 00/16] General Tegra improvements
External email: Use caution opening links or attachments
Thierry, thank you very much for a quick test.
Tom, should I amend patches and upload the next iteration of patchset with
Thierry's tested-by or, if no more objections/comments there are, you will add
Thierry's tested-by on your own?
Best regards.
Svyatoslav R.
вт, 14 лют. 2023 р. о 16:00 Thierry Reding пише:
>
> On Fri, Feb 03, 2023 at 11:26:24AM +0200, Svyatoslav Ryhel wrote:
> > List of changes in patch set:
> > - add missing EXTPERIPH clocks for t30
> > - swap host1x and disp1 clock parents (as they should be)
> > - add clk_id_to_pll_id and clock_decode_pair helpers to use
> >dts deeper (in tegra clocks often go in pair child - parent)
> > - include PLLD setup in T30 (DISP1 may use it as parent on
> >some device)
> > - fix Tegra PWM parent clock inline with linux
> > - Tegra SLINK: patch to accept any word length (unlike 8bit
> >aligned which was before)
> > - provide default USB gadget setup for existing Nvidia boards
> > - add late init function to be able to configure pre-boot stage
> >(like uncovering serial number or setting mac address)
> > - create common pre-dm i2c write for PMIC (used on T30 and T124
> >to configure basic PMIC voltages required to boot like cpu and
> >core voltages)
> > - expose crypto module for all Tegra SoCs and implement BCT patching
> >(ability to update bootloader from u-boot on production devices
> >without need in host PC)
> >
> > ---
> > Changelog from v2
> > - fixed T114 TEGRA114_CLK_PLL_E_OUT0
> > - adjusted pre-dm i2c write commit description
> > - added description file for ebtupdate command
> > - minor improvements of bct.c comments
> >
> > Changelog from v1
> > - rebased to latest u-boot master
> > - PLLD setup for T30 moved specifically into T30 area
> > ---
> >
> > Maxim Schwalm (1):
> > ARM: tegra: provide default USB gadget setup
> >
> > Ramin Khonsari (1):
> > ARM: tegra30: implement BCT patching
> >
> > Svyatoslav Ryhel (14):
> > tegra30: clock: add EXTPERIPH
> > ARM: t20/t30: swap host1x and disp1 clock parents
> > ARM: tegra: clock: add clk_id_to_pll_id helper
> > ARM: tegra: clock: add clock_decode_pair helper
> > ARM: tegra30: add PLLD to pll setup
> > ARM: tegra: Fix Tegra PWM parent clock
> > spi: tegra20_slink: accept any word length
> > ARM: tegra: add late init support
> > ARM: tegra: create common pre-dm i2c write
> > board: tegra124: switch to updated pre-dm i2c write
> > board: tegra30: switch to updated pre-dm i2c write
> > ARM: tegra: expose crypto module for all Tegra SoCs
> > ARM: tegra: crypto: extend crypto functional
> > ARM: tegra20: implement BCT patching
> >
> > arch/arm/dts/tegra114.dtsi| 2 +-
> > arch/arm/dts/tegra124.dtsi| 2 +-
> > arch/arm/include/asm/arch-tegra/clock.h | 21 +
> > arch/arm/include/asm/arch-tegra/crypto.h | 47 ++
> > arch/arm/include/asm/arch-tegra/sys_proto.h | 6 ++
> > arch/arm/include/asm/arch-tegra/tegra_i2c.h | 17
> > .../include/asm/arch-tegra30/clock-tables.h | 6 +-
> > arch/arm/mach-tegra/Kconfig | 14 +++
> > arch/arm/mach-tegra/Makefile | 1 +
> > arch/arm/mach-tegra/board2.c | 2 +
> > arch/arm/mach-tegra/clock.c | 23 +
> > arch/arm/mach-tegra/cpu.h | 1 -
> > arch/arm/mach-tegra/{tegra20 => }/crypto.c| 63 +
> > arch/arm/mach-tegra/tegra114/clock.c | 39 +++-
> > arch/arm/mach-tegra/tegra124/clock.c | 40 -
> > arch/arm/mach-tegra/tegra124/cpu.c| 4 +
> > arch/arm/mach-tegra/tegra20/Kconfig | 1 +
> > arch/arm/mach-tegra/tegra20/Makefile | 7 +-
> > arch/arm/mach-tegra/tegra20/bct.c | 79
> > arch/arm/mach-tegra/tegra20/bct.h | 42 +
> > arch/arm/mach-tegra/tegra20/clock.c
RE: [PATCH v3 00/16] General Tegra improvements
Where does testing/reviewing stand on these changes? I'd like to submit a PR early next week, but I can't until I know they won't break anything. -Original Message- From: Svyatoslav Ryhel Sent: Friday, February 3, 2023 10:40 AM To: Tom Warren ; Thierry Reding Cc: Ramin Khonsari ; Maxim Schwalm ; Dmitry Osipenko ; u-boot@lists.denx.de; Allen Martin ; Jagan Teki ; Lukasz Majewski ; Marcel Ziswiler ; Marek Vasut Subject: Re: [PATCH v3 00/16] General Tegra improvements External email: Use caution opening links or attachments Thanks! I will shrink mailing list in the next iteration. Thierry, may you check if these patches do not break anything on your boards. I have tested them on my devices (T20 and T30) without any issues. I am especially interested in T124 pre-dm i2c changes, iirc you have a board I have changed. Best Regards. Svyatoslav R. пт, 3 лют. 2023 р. о 19:30 Tom Warren пише: > > I've applied these (v3) to TOT u-boot-tegra/master OK, and 'buildman tegra' > is OK. > > I don't have the HW to test all of these combos (T20, T30, T114, T124) - > they're mothballed in favor of my current work on T210/T186/T194/T234 (the > last two w/no U-Boot). So I'd appreciate any 'Tested-by's from anyone > (Thierry, Marcel, Marek, etc.) that might be using these older boards still. > This is a substantive set of changes, and I don't want to break anything. > > BTW - you can remove Stephen Warren from your CC list - he's moved out of the > group that's concerned w/L4T & upstream bootloaders, and probably doesn't > want to see this in his inbox any longer. > > Thanks, > > Tom > > -Original Message- > From: Svyatoslav Ryhel > Sent: Friday, February 3, 2023 2:26 AM > To: Tom Warren ; Stephen Warren > ; Marcel Ziswiler ; > Allen Martin ; Jagan Teki > ; Lukasz Majewski ; Marek > Vasut ; Svyatoslav Ryhel ; Ramin > Khonsari ; Thierry Reding > ; Maxim Schwalm ; > Dmitry Osipenko > Cc: u-boot@lists.denx.de > Subject: [PATCH v3 00/16] General Tegra improvements > > External email: Use caution opening links or attachments > > > List of changes in patch set: > - add missing EXTPERIPH clocks for t30 > - swap host1x and disp1 clock parents (as they should be) > - add clk_id_to_pll_id and clock_decode_pair helpers to use >dts deeper (in tegra clocks often go in pair child - parent) > - include PLLD setup in T30 (DISP1 may use it as parent on >some device) > - fix Tegra PWM parent clock inline with linux > - Tegra SLINK: patch to accept any word length (unlike 8bit >aligned which was before) > - provide default USB gadget setup for existing Nvidia boards > - add late init function to be able to configure pre-boot stage >(like uncovering serial number or setting mac address) > - create common pre-dm i2c write for PMIC (used on T30 and T124 >to configure basic PMIC voltages required to boot like cpu and >core voltages) > - expose crypto module for all Tegra SoCs and implement BCT patching >(ability to update bootloader from u-boot on production devices >without need in host PC) > > --- > Changelog from v2 > - fixed T114 TEGRA114_CLK_PLL_E_OUT0 > - adjusted pre-dm i2c write commit description > - added description file for ebtupdate command > - minor improvements of bct.c comments > > Changelog from v1 > - rebased to latest u-boot master > - PLLD setup for T30 moved specifically into T30 area > --- > > Maxim Schwalm (1): > ARM: tegra: provide default USB gadget setup > > Ramin Khonsari (1): > ARM: tegra30: implement BCT patching > > Svyatoslav Ryhel (14): > tegra30: clock: add EXTPERIPH > ARM: t20/t30: swap host1x and disp1 clock parents > ARM: tegra: clock: add clk_id_to_pll_id helper > ARM: tegra: clock: add clock_decode_pair helper > ARM: tegra30: add PLLD to pll setup > ARM: tegra: Fix Tegra PWM parent clock > spi: tegra20_slink: accept any word length > ARM: tegra: add late init support > ARM: tegra: create common pre-dm i2c write > board: tegra124: switch to updated pre-dm i2c write > board: tegra30: switch to updated pre-dm i2c write > ARM: tegra: expose crypto module for all Tegra SoCs > ARM: tegra: crypto: extend crypto functional > ARM: tegra20: implement BCT patching > > arch/arm/dts/tegra114.dtsi| 2 +- > arch/arm/dts/tegra124.dtsi| 2 +- > arch/arm/include/asm/arch-tegra/clock.h | 21 + > arch/arm/include/asm/arch-tegra/crypto.h | 47 ++ > arch/arm/include/asm/arch-tegra/sys_proto.h | 6 ++ > arch/arm/include/asm/arch-tegra/tegra_i2c.h | 17 > .../include/asm/arch-tegra30/clock-tables.h | 6 +- > arch/arm/mach-tegra/Kconfig
RE: [PATCH v3 00/16] General Tegra improvements
I've applied these (v3) to TOT u-boot-tegra/master OK, and 'buildman tegra' is
OK.
I don't have the HW to test all of these combos (T20, T30, T114, T124) -
they're mothballed in favor of my current work on T210/T186/T194/T234 (the last
two w/no U-Boot). So I'd appreciate any 'Tested-by's from anyone (Thierry,
Marcel, Marek, etc.) that might be using these older boards still. This is a
substantive set of changes, and I don't want to break anything.
BTW - you can remove Stephen Warren from your CC list - he's moved out of the
group that's concerned w/L4T & upstream bootloaders, and probably doesn't want
to see this in his inbox any longer.
Thanks,
Tom
-Original Message-
From: Svyatoslav Ryhel
Sent: Friday, February 3, 2023 2:26 AM
To: Tom Warren ; Stephen Warren ;
Marcel Ziswiler ; Allen Martin
; Jagan Teki ; Lukasz Majewski
; Marek Vasut ; Svyatoslav Ryhel
; Ramin Khonsari ; Thierry Reding
; Maxim Schwalm ; Dmitry
Osipenko
Cc: u-boot@lists.denx.de
Subject: [PATCH v3 00/16] General Tegra improvements
External email: Use caution opening links or attachments
List of changes in patch set:
- add missing EXTPERIPH clocks for t30
- swap host1x and disp1 clock parents (as they should be)
- add clk_id_to_pll_id and clock_decode_pair helpers to use
dts deeper (in tegra clocks often go in pair child - parent)
- include PLLD setup in T30 (DISP1 may use it as parent on
some device)
- fix Tegra PWM parent clock inline with linux
- Tegra SLINK: patch to accept any word length (unlike 8bit
aligned which was before)
- provide default USB gadget setup for existing Nvidia boards
- add late init function to be able to configure pre-boot stage
(like uncovering serial number or setting mac address)
- create common pre-dm i2c write for PMIC (used on T30 and T124
to configure basic PMIC voltages required to boot like cpu and
core voltages)
- expose crypto module for all Tegra SoCs and implement BCT patching
(ability to update bootloader from u-boot on production devices
without need in host PC)
---
Changelog from v2
- fixed T114 TEGRA114_CLK_PLL_E_OUT0
- adjusted pre-dm i2c write commit description
- added description file for ebtupdate command
- minor improvements of bct.c comments
Changelog from v1
- rebased to latest u-boot master
- PLLD setup for T30 moved specifically into T30 area
---
Maxim Schwalm (1):
ARM: tegra: provide default USB gadget setup
Ramin Khonsari (1):
ARM: tegra30: implement BCT patching
Svyatoslav Ryhel (14):
tegra30: clock: add EXTPERIPH
ARM: t20/t30: swap host1x and disp1 clock parents
ARM: tegra: clock: add clk_id_to_pll_id helper
ARM: tegra: clock: add clock_decode_pair helper
ARM: tegra30: add PLLD to pll setup
ARM: tegra: Fix Tegra PWM parent clock
spi: tegra20_slink: accept any word length
ARM: tegra: add late init support
ARM: tegra: create common pre-dm i2c write
board: tegra124: switch to updated pre-dm i2c write
board: tegra30: switch to updated pre-dm i2c write
ARM: tegra: expose crypto module for all Tegra SoCs
ARM: tegra: crypto: extend crypto functional
ARM: tegra20: implement BCT patching
arch/arm/dts/tegra114.dtsi| 2 +-
arch/arm/dts/tegra124.dtsi| 2 +-
arch/arm/include/asm/arch-tegra/clock.h | 21 +
arch/arm/include/asm/arch-tegra/crypto.h | 47 ++
arch/arm/include/asm/arch-tegra/sys_proto.h | 6 ++
arch/arm/include/asm/arch-tegra/tegra_i2c.h | 17
.../include/asm/arch-tegra30/clock-tables.h | 6 +-
arch/arm/mach-tegra/Kconfig | 14 +++
arch/arm/mach-tegra/Makefile | 1 +
arch/arm/mach-tegra/board2.c | 2 +
arch/arm/mach-tegra/clock.c | 23 +
arch/arm/mach-tegra/cpu.h | 1 -
arch/arm/mach-tegra/{tegra20 => }/crypto.c| 63 +
arch/arm/mach-tegra/tegra114/clock.c | 39 +++-
arch/arm/mach-tegra/tegra124/clock.c | 40 -
arch/arm/mach-tegra/tegra124/cpu.c| 4 +
arch/arm/mach-tegra/tegra20/Kconfig | 1 +
arch/arm/mach-tegra/tegra20/Makefile | 7 +-
arch/arm/mach-tegra/tegra20/bct.c | 79
arch/arm/mach-tegra/tegra20/bct.h | 42 +
arch/arm/mach-tegra/tegra20/clock.c | 43 -
arch/arm/mach-tegra/tegra20/crypto.h | 19
arch/arm/mach-tegra/tegra210/clock.c | 39 +++-
arch/arm/mach-tegra/tegra30/Kconfig | 8 --
arch/arm/mach-tegra/tegra30/Makefile | 1 +
arch/arm/mach-tegra/tegra30/bct.c | 79
arch/arm/mach-tegra/tegra30/bct.h | 42 +
arch/arm/mach-tegra/tegra30/clock.c | 90 +--
arch/arm/mach-tegra/tegra30/cpu.c | 55 +---
board/avionic-design/tec-ng/Makefile | 4 +-
board/avionic-design/tec-ng/tec-ng-spl.c
RE: [PATCH v2 03/16] ARM: tegra: clock: add clk_id_to_pll_id helper
Svyatoslav,
I was able to apply all of your V2 'General Tegra' patches OK on top of current
u-boot-tegra/master. But buildman (and normal make dalmore_defconfig/make) fail
to build Dalmore (T114) with the following error:
CC arch/arm/mach-tegra/tegra114/clock.o
arch/arm/mach-tegra/tegra114/clock.c: In function 'clk_id_to_pll_id':
arch/arm/mach-tegra/tegra114/clock.c:676:7: error: 'TEGRA114_CLK_PLL_E'
undeclared (first use in this function)
case TEGRA114_CLK_PLL_E:
^~
PTAL.
Thanks,
Tom
-Original Message-
From: Svyatoslav Ryhel
Sent: Thursday, February 2, 2023 11:14 AM
To: Tom Warren ; Alban Bedel
; Stephen Warren ; Marcel
Ziswiler ; Allen Martin ;
Jagan Teki ; Lukasz Majewski ; Marek
Vasut ; Svyatoslav Ryhel ; Ramin Khonsari
; Thierry Reding ; Maxim
Schwalm ; Dmitry Osipenko
Cc: u-boot@lists.denx.de
Subject: [PATCH v2 03/16] ARM: tegra: clock: add clk_id_to_pll_id helper
External email: Use caution opening links or attachments
This function allows to convert a device tree clock ID to PLL ID.
Tested-by: Andreas Westman Dorcsak # ASUS TF T30
Tested-by: Robert Eckelmann # ASUS TF101 T20
Tested-by: Svyatoslav Ryhel # HTC One X
Signed-off-by: Svyatoslav Ryhel
---
arch/arm/include/asm/arch-tegra/clock.h | 8 ++
arch/arm/mach-tegra/tegra114/clock.c| 37
arch/arm/mach-tegra/tegra124/clock.c| 38 +
arch/arm/mach-tegra/tegra20/clock.c | 37
arch/arm/mach-tegra/tegra210/clock.c| 37
arch/arm/mach-tegra/tegra30/clock.c | 37
6 files changed, 194 insertions(+)
diff --git a/arch/arm/include/asm/arch-tegra/clock.h
b/arch/arm/include/asm/arch-tegra/clock.h
index 1dd5d0742c..2270501406 100644
--- a/arch/arm/include/asm/arch-tegra/clock.h
+++ b/arch/arm/include/asm/arch-tegra/clock.h
@@ -354,6 +354,14 @@ int get_periph_clock_source(enum periph_id periph_id,
*/
enum periph_id clk_id_to_periph_id(int clk_id);
+/*
+ * Convert a device tree clock ID to our PLL ID.
+ *
+ * @param clk_id Clock ID according to tegra device tree binding
+ * Return: clock ID, or CLOCK_ID_NONE if the clock ID is invalid */
+enum clock_id clk_id_to_pll_id(int clk_id);
+
/**
* Set the output frequency you want for each PLL clock.
* PLL output frequencies are programmed by setting their N, M and P values.
diff --git a/arch/arm/mach-tegra/tegra114/clock.c
b/arch/arm/mach-tegra/tegra114/clock.c
index 143f86863f..c019b2d0cd 100644
--- a/arch/arm/mach-tegra/tegra114/clock.c
+++ b/arch/arm/mach-tegra/tegra114/clock.c
@@ -19,6 +19,8 @@
#include
#include
+#include
+
/*
* Clock types that we can use as a source. The Tegra114 has muxes for the
* peripheral clocks, and in most cases there are four options for the clock
@@ -646,6 +648,41 @@ enum periph_id clk_id_to_periph_id(int clk_id)
return clk_id;
}
}
+
+/*
+ * Convert a device tree clock ID to our PLL ID.
+ *
+ * @param clk_id Clock ID according to tegra114 device tree binding
+ * Return: clock ID, or CLOCK_ID_NONE if the clock ID is invalid */
+enum clock_id clk_id_to_pll_id(int clk_id) {
+ switch (clk_id) {
+ case TEGRA114_CLK_PLL_C:
+ return CLOCK_ID_CGENERAL;
+ case TEGRA114_CLK_PLL_M:
+ return CLOCK_ID_MEMORY;
+ case TEGRA114_CLK_PLL_P:
+ return CLOCK_ID_PERIPH;
+ case TEGRA114_CLK_PLL_A:
+ return CLOCK_ID_AUDIO;
+ case TEGRA114_CLK_PLL_U:
+ return CLOCK_ID_USB;
+ case TEGRA114_CLK_PLL_D:
+ case TEGRA114_CLK_PLL_D_OUT0:
+ return CLOCK_ID_DISPLAY;
+ case TEGRA114_CLK_PLL_X:
+ return CLOCK_ID_XCPU;
+ case TEGRA114_CLK_PLL_E:
+ return CLOCK_ID_EPCI;
+ case TEGRA114_CLK_CLK_32K:
+ return CLOCK_ID_32KHZ;
+ case TEGRA114_CLK_CLK_M:
+ return CLOCK_ID_CLK_M;
+ default:
+ return CLOCK_ID_NONE;
+ }
+}
#endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
void clock_early_init(void)
diff --git a/arch/arm/mach-tegra/tegra124/clock.c
b/arch/arm/mach-tegra/tegra124/clock.c
index da38b26c27..415ba15e5d 100644
--- a/arch/arm/mach-tegra/tegra124/clock.c
+++ b/arch/arm/mach-tegra/tegra124/clock.c
@@ -19,6 +19,9 @@
#include
#include
+#include
+#include
+
/*
* Clock types that we can use as a source. The Tegra124 has muxes for the
* peripheral clocks, and in most cases there are four options for the clock
@@ -826,6 +829,41 @@ enum periph_id clk_id_to_periph_id(int clk_id)
return clk_id;
}
}
+
+/*
+ * Convert a device tree clock ID to our PLL ID.
+ *
+ * @param clk_id Clock ID according to tegra124 device tree binding
+ * Return: clock ID, or CLOCK_ID_NONE if the clock ID is invalid
+ */
+enum clock_id clk_id_to_pll_id(int clk_id)
+{
+ switch (clk_id) {
+ case
RE: [PATCH v7 0/3] Timer support for ARM Tegra
I've merged your 3 timer patches w/TOT u-boot-tegra, and sent a PR to Tom Rini. However, your v1 16-patch series here does no apply cleanly on top of the new u-boot-tegra/master (fast-forwarded to u-boot/master TOT, and then with your 3 timer patches applied on top). PTAL, git am error spew below: git am -s --whitespace=strip /home/tom/Downloads/bundle-23280-Svyatoslav-16-v1.mbox Applying: tegra30: clock: add EXTPERIPH Applying: ARM: t20/t30: swap host1x and disp1 clock parents Applying: ARM: tegra: clock: add clk_id_to_pll_id helper Applying: ARM: tegra: clock: add clock_decode_pair helper Applying: ARM: tegra30: add PLLD to pll setup error: patch failed: arch/arm/mach-tegra/clock.c:791 error: arch/arm/mach-tegra/clock.c: patch does not apply Patch failed at 0005 ARM: tegra30: add PLLD to pll setup The copy of the patch that failed is found in: /home/tom/denx/uboot-tegra/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Tom -Original Message- From: Svyatoslav Ryhel Sent: Tuesday, January 31, 2023 2:53 PM To: Tom Warren Cc: Thierry Reding ; Rayagonda Kokatanur ; Marek Vasut ; Maxim Schwalm ; Dmitry Osipenko ; Jonas Schwöbel ; Agneli ; Heinrich Schuchardt ; Michal Simek ; Stefan Roese ; Eugen Hristev ; Michael Walle ; Simon Glass ; Jim Liu ; William Zhang ; Rick Chen ; Stefan Herbrechtsmeier ; Andre Przywara ; Jaehoon Chung ; u-boot@lists.denx.de Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra External email: Use caution opening links or attachments I will upload v8 tomorrow once I have some time. Yes, Timer series should go first since some clock related commits of "General Tegra improvements" may conflict. Those are not direct dependencies but rather changed code overlaps. Thanks Best Regards. Svyatoslav R. вт, 31 січ. 2023 р. о 22:27 Tom Warren пише: > > OK, I'll wait for your v8 with the adjusted timer enabling. > > Does this series need to go in first before your recent 16-patch series > "General Tegra improvements"? i.e. are there any dependencies? > > Tom > -Original Message- > From: Svyatoslav Ryhel > Sent: Tuesday, January 31, 2023 8:26 AM > To: Tom Warren > Cc: Thierry Reding ; Rayagonda Kokatanur > ; Marek Vasut ; Maxim > Schwalm ; Dmitry Osipenko ; > Jonas Schwöbel ; Agneli > ; Heinrich Schuchardt ; > Michal Simek ; Stefan Roese ; Eugen > Hristev ; Michael Walle > ; Simon Glass ; Jim Liu > ; William Zhang ; > Rick Chen ; Stefan Herbrechtsmeier > ; Andre Przywara > ; Jaehoon Chung ; > u-boot@lists.denx.de > Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra > > External email: Use caution opening links or attachments > > > Yes, it works perfectly fine on the T20/T30/T124/T186 and T210, T114 board no > one has on hand. Timer enabling has to be adjusted as Thierry suggested. > > вт, 31 січ. 2023 р. о 17:18 Tom Warren пише: > > > > Has this been tested yet? I want to get it into the next PR, and I need a > > tested-by for V7 before I can do that. > > > > Thanks, > > > > Tom > > > > -Original Message- > > From: Svyatoslav R. > > Sent: Friday, January 27, 2023 1:28 PM > > To: Thierry Reding > > Cc: Rayagonda Kokatanur ; Tom > > Warren ; Marek Vasut ; Maxim > > Schwalm ; Dmitry Osipenko > > ; Jonas Schwöbel ; Agneli > > ; Heinrich Schuchardt ; > > Michal Simek ; Stefan Roese ; > > Eugen Hristev ; Michael Walle > > ; Simon Glass ; Jim Liu > > ; William Zhang ; > > Rick Chen ; Stefan Herbrechtsmeier > > ; Andre Przywara > > ; Jaehoon Chung ; > > u-boot@lists.denx.de > > Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra > > > > External email: Use caution opening links or attachments > > > > > > On 1/27/23 19:15, Thierry Reding wrote: > > > On Fri, Jan 27, 2023 at 09:13:09AM +0200, Svyatoslav Ryhel wrote: > > >> - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > >> clock_osc_freq was designed to use only with T20. > > >> This patch remaps it to use additional frequencies, added in > > >> T30+ SoC while maintaining backwards compatibility with T20. > > >> > > >> - drivers: timer: add timer driver for ARMv7 based Tegra devices > > >> Add timer support for T20/T30/T114/T124 and T210 based devices. > > >> Driver is based on DM, has device tree support and can be used on > > >> SPL and early boot stage. > > >> > > >> Arm64 Tegra (apart T210) accord
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. It has passed 'buildman tegra' w/o error, and Thierry has tested it on his Tegra boards. The following changes since commit 1e1cd8eb2d0c8e5b28b2dd6622ec9cbbd5eb61b8: Merge tag 'fsl-qoriq-2023-2-1' of https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq (2023-02-01 09:31:17 -0500) are available in the git repository at: https://source.denx.de/u-boot/custodians/u-boot-tegra.git refs/pipelines/15015 for you to fetch changes up to 412a4c6f1b94b5fea4c7ccb906de418bdaf9c058: ARM: tegra: include timer as default option (2023-02-02 10:16:41 -0700) Svyatoslav Ryhel (3): ARM: tegra: remap clock_osc_freq for all Tegra family drivers: timer: add driver for ARMv7 based Tegra devices and T210 ARM: tegra: include timer as default option arch/arm/Kconfig| 1 + arch/arm/include/asm/arch-tegra/clock.h | 9 ++- arch/arm/mach-tegra/Kconfig | 4 + arch/arm/mach-tegra/clock.c | 17 - arch/arm/mach-tegra/cpu.c | 70 + arch/arm/mach-tegra/tegra114/clock.c| 13 ++-- arch/arm/mach-tegra/tegra124/clock.c| 13 ++-- arch/arm/mach-tegra/tegra20/clock.c | 4 +- arch/arm/mach-tegra/tegra210/clock.c| 22 +- arch/arm/mach-tegra/tegra30/clock.c | 10 +-- drivers/timer/Kconfig | 8 ++ drivers/timer/Makefile | 1 + drivers/timer/tegra-timer.c | 130 drivers/usb/host/ehci-tegra.c | 46 --- include/configs/tegra-common.h | 6 -- 15 files changed, 275 insertions(+), 79 deletions(-) create mode 100644 drivers/timer/tegra-timer.c
RE: [PATCH v7 0/3] Timer support for ARM Tegra
Sure. Thierry - have you tested v8 of these patches on all of your Tegra boards? Tom -Original Message- From: Svyatoslav Ryhel Sent: Wednesday, February 1, 2023 1:59 AM To: Tom Warren Cc: Thierry Reding ; Rayagonda Kokatanur ; Marek Vasut ; Maxim Schwalm ; Dmitry Osipenko ; Jonas Schwöbel ; Agneli ; Heinrich Schuchardt ; Michal Simek ; Stefan Roese ; Eugen Hristev ; Michael Walle ; Simon Glass ; Jim Liu ; William Zhang ; Rick Chen ; Stefan Herbrechtsmeier ; Andre Przywara ; Jaehoon Chung ; u-boot@lists.denx.de Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra External email: Use caution opening links or attachments Greetings! This should be it. May you add Tested-by: Thierry Reding # T30, T124, T210 into drivers: timer: add driver for ARMv7 based Tegra devices and T210 once applying patches? Thanks вт, 31 січ. 2023 р. о 22:27 Tom Warren пише: > > OK, I'll wait for your v8 with the adjusted timer enabling. > > Does this series need to go in first before your recent 16-patch series > "General Tegra improvements"? i.e. are there any dependencies? > > Tom > -Original Message- > From: Svyatoslav Ryhel > Sent: Tuesday, January 31, 2023 8:26 AM > To: Tom Warren > Cc: Thierry Reding ; Rayagonda Kokatanur > ; Marek Vasut ; Maxim > Schwalm ; Dmitry Osipenko ; > Jonas Schwöbel ; Agneli > ; Heinrich Schuchardt ; > Michal Simek ; Stefan Roese ; Eugen > Hristev ; Michael Walle > ; Simon Glass ; Jim Liu > ; William Zhang ; > Rick Chen ; Stefan Herbrechtsmeier > ; Andre Przywara > ; Jaehoon Chung ; > u-boot@lists.denx.de > Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra > > External email: Use caution opening links or attachments > > > Yes, it works perfectly fine on the T20/T30/T124/T186 and T210, T114 board no > one has on hand. Timer enabling has to be adjusted as Thierry suggested. > > вт, 31 січ. 2023 р. о 17:18 Tom Warren пише: > > > > Has this been tested yet? I want to get it into the next PR, and I need a > > tested-by for V7 before I can do that. > > > > Thanks, > > > > Tom > > > > -Original Message- > > From: Svyatoslav R. > > Sent: Friday, January 27, 2023 1:28 PM > > To: Thierry Reding > > Cc: Rayagonda Kokatanur ; Tom > > Warren ; Marek Vasut ; Maxim > > Schwalm ; Dmitry Osipenko > > ; Jonas Schwöbel ; Agneli > > ; Heinrich Schuchardt ; > > Michal Simek ; Stefan Roese ; > > Eugen Hristev ; Michael Walle > > ; Simon Glass ; Jim Liu > > ; William Zhang ; > > Rick Chen ; Stefan Herbrechtsmeier > > ; Andre Przywara > > ; Jaehoon Chung ; > > u-boot@lists.denx.de > > Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra > > > > External email: Use caution opening links or attachments > > > > > > On 1/27/23 19:15, Thierry Reding wrote: > > > On Fri, Jan 27, 2023 at 09:13:09AM +0200, Svyatoslav Ryhel wrote: > > >> - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > >> clock_osc_freq was designed to use only with T20. > > >> This patch remaps it to use additional frequencies, added in > > >> T30+ SoC while maintaining backwards compatibility with T20. > > >> > > >> - drivers: timer: add timer driver for ARMv7 based Tegra devices > > >> Add timer support for T20/T30/T114/T124 and T210 based devices. > > >> Driver is based on DM, has device tree support and can be used on > > >> SPL and early boot stage. > > >> > > >> Arm64 Tegra (apart T210) according to comment in tegra-common.h > > >> use architected timer. > > >> > > >> - ARM: tegra: include timer as default option Enable TIMER as > > >> default option for all Tegra devices and enable TEGRA_TIMER for > > >> TEGRA_ARMV7_COMMON and TEGRA210. > > >> Additionally enable SPL_TIMER if build as SPL part and drop > > >> deprecated configs from common header. > > >> > > >> P. S. I have no arm64 Tegra and according to comment in > > >> tegra-common.h Use the Tegra US timer on ARMv7, but the > > >> architected timer on ARMv8. > > >> > > >> --- > > >> Changeog from V6 > > >> - use clk_m as timer calibration clock (this should properly fix T210) > > >> - enable timer for T210 > > >> > > >> Changed from v5: > > >> - added paz00 tester > > >> > > >> Changed from v4: > > >> - added comments > > >> > > >> Changed from v3: > > >> - r
RE: [PATCH v7 0/3] Timer support for ARM Tegra
OK, I'll wait for your v8 with the adjusted timer enabling. Does this series need to go in first before your recent 16-patch series "General Tegra improvements"? i.e. are there any dependencies? Tom -Original Message- From: Svyatoslav Ryhel Sent: Tuesday, January 31, 2023 8:26 AM To: Tom Warren Cc: Thierry Reding ; Rayagonda Kokatanur ; Marek Vasut ; Maxim Schwalm ; Dmitry Osipenko ; Jonas Schwöbel ; Agneli ; Heinrich Schuchardt ; Michal Simek ; Stefan Roese ; Eugen Hristev ; Michael Walle ; Simon Glass ; Jim Liu ; William Zhang ; Rick Chen ; Stefan Herbrechtsmeier ; Andre Przywara ; Jaehoon Chung ; u-boot@lists.denx.de Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra External email: Use caution opening links or attachments Yes, it works perfectly fine on the T20/T30/T124/T186 and T210, T114 board no one has on hand. Timer enabling has to be adjusted as Thierry suggested. вт, 31 січ. 2023 р. о 17:18 Tom Warren пише: > > Has this been tested yet? I want to get it into the next PR, and I need a > tested-by for V7 before I can do that. > > Thanks, > > Tom > > -Original Message- > From: Svyatoslav R. > Sent: Friday, January 27, 2023 1:28 PM > To: Thierry Reding > Cc: Rayagonda Kokatanur ; Tom Warren > ; Marek Vasut ; Maxim Schwalm > ; Dmitry Osipenko ; Jonas > Schwöbel ; Agneli ; > Heinrich Schuchardt ; Michal Simek > ; Stefan Roese ; Eugen Hristev > ; Michael Walle ; Simon > Glass ; Jim Liu ; William > Zhang ; Rick Chen ; > Stefan Herbrechtsmeier ; Andre > Przywara ; Jaehoon Chung > ; u-boot@lists.denx.de > Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra > > External email: Use caution opening links or attachments > > > On 1/27/23 19:15, Thierry Reding wrote: > > On Fri, Jan 27, 2023 at 09:13:09AM +0200, Svyatoslav Ryhel wrote: > >> - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > >> clock_osc_freq was designed to use only with T20. > >> This patch remaps it to use additional frequencies, added in > >> T30+ SoC while maintaining backwards compatibility with T20. > >> > >> - drivers: timer: add timer driver for ARMv7 based Tegra devices > >> Add timer support for T20/T30/T114/T124 and T210 based devices. > >> Driver is based on DM, has device tree support and can be used on > >> SPL and early boot stage. > >> > >> Arm64 Tegra (apart T210) according to comment in tegra-common.h use > >> architected timer. > >> > >> - ARM: tegra: include timer as default option Enable TIMER as > >> default option for all Tegra devices and enable TEGRA_TIMER for > >> TEGRA_ARMV7_COMMON and TEGRA210. > >> Additionally enable SPL_TIMER if build as SPL part and drop > >> deprecated configs from common header. > >> > >> P. S. I have no arm64 Tegra and according to comment in > >> tegra-common.h Use the Tegra US timer on ARMv7, but the architected > >> timer on ARMv8. > >> > >> --- > >> Changeog from V6 > >> - use clk_m as timer calibration clock (this should properly fix T210) > >> - enable timer for T210 > >> > >> Changed from v5: > >> - added paz00 tester > >> > >> Changed from v4: > >> - added comments > >> > >> Changed from v3: > >> - removed BOOTSTAGE ifdefs > >> - use early timer on boot stage unconditionally > >> --- > >> Svyatoslav Ryhel (3): > >>ARM: tegra: remap clock_osc_freq for all Tegra family > >>drivers: timer: add driver for ARMv7 based Tegra devices and T210 > >>ARM: tegra: include timer as default option > >> > >> arch/arm/Kconfig| 1 + > >> arch/arm/include/asm/arch-tegra/clock.h | 9 +- > >> arch/arm/mach-tegra/Kconfig | 3 + > >> arch/arm/mach-tegra/clock.c | 17 +++- > >> arch/arm/mach-tegra/cpu.c | 70 ++--- > >> arch/arm/mach-tegra/tegra114/clock.c| 13 +-- > >> arch/arm/mach-tegra/tegra124/clock.c| 13 +-- > >> arch/arm/mach-tegra/tegra20/clock.c | 4 +- > >> arch/arm/mach-tegra/tegra210/clock.c| 22 +--- > >> arch/arm/mach-tegra/tegra30/clock.c | 10 +- > >> drivers/timer/Kconfig | 8 ++ > >> drivers/timer/Makefile | 1 + > >> drivers/timer/tegra-timer.c | 130 > >> drivers/usb/host/ehci-tegra.c | 46 +++-- > >> include/configs/tegra-common.h | 6 -- >
RE: [PATCH v7 0/3] Timer support for ARM Tegra
Has this been tested yet? I want to get it into the next PR, and I need a tested-by for V7 before I can do that. Thanks, Tom -Original Message- From: Svyatoslav R. Sent: Friday, January 27, 2023 1:28 PM To: Thierry Reding Cc: Rayagonda Kokatanur ; Tom Warren ; Marek Vasut ; Maxim Schwalm ; Dmitry Osipenko ; Jonas Schwöbel ; Agneli ; Heinrich Schuchardt ; Michal Simek ; Stefan Roese ; Eugen Hristev ; Michael Walle ; Simon Glass ; Jim Liu ; William Zhang ; Rick Chen ; Stefan Herbrechtsmeier ; Andre Przywara ; Jaehoon Chung ; u-boot@lists.denx.de Subject: Re: [PATCH v7 0/3] Timer support for ARM Tegra External email: Use caution opening links or attachments On 1/27/23 19:15, Thierry Reding wrote: > On Fri, Jan 27, 2023 at 09:13:09AM +0200, Svyatoslav Ryhel wrote: >> - ARM: tegra: remap clock_osc_freq for all Tegra family Enum >> clock_osc_freq was designed to use only with T20. >> This patch remaps it to use additional frequencies, added in >> T30+ SoC while maintaining backwards compatibility with T20. >> >> - drivers: timer: add timer driver for ARMv7 based Tegra devices Add >> timer support for T20/T30/T114/T124 and T210 based devices. >> Driver is based on DM, has device tree support and can be used on SPL >> and early boot stage. >> >> Arm64 Tegra (apart T210) according to comment in tegra-common.h use >> architected timer. >> >> - ARM: tegra: include timer as default option Enable TIMER as default >> option for all Tegra devices and enable TEGRA_TIMER for >> TEGRA_ARMV7_COMMON and TEGRA210. >> Additionally enable SPL_TIMER if build as SPL part and drop >> deprecated configs from common header. >> >> P. S. I have no arm64 Tegra and according to comment in >> tegra-common.h Use the Tegra US timer on ARMv7, but the architected >> timer on ARMv8. >> >> --- >> Changeog from V6 >> - use clk_m as timer calibration clock (this should properly fix T210) >> - enable timer for T210 >> >> Changed from v5: >> - added paz00 tester >> >> Changed from v4: >> - added comments >> >> Changed from v3: >> - removed BOOTSTAGE ifdefs >> - use early timer on boot stage unconditionally >> --- >> Svyatoslav Ryhel (3): >>ARM: tegra: remap clock_osc_freq for all Tegra family >>drivers: timer: add driver for ARMv7 based Tegra devices and T210 >>ARM: tegra: include timer as default option >> >> arch/arm/Kconfig| 1 + >> arch/arm/include/asm/arch-tegra/clock.h | 9 +- >> arch/arm/mach-tegra/Kconfig | 3 + >> arch/arm/mach-tegra/clock.c | 17 +++- >> arch/arm/mach-tegra/cpu.c | 70 ++--- >> arch/arm/mach-tegra/tegra114/clock.c| 13 +-- >> arch/arm/mach-tegra/tegra124/clock.c| 13 +-- >> arch/arm/mach-tegra/tegra20/clock.c | 4 +- >> arch/arm/mach-tegra/tegra210/clock.c| 22 +--- >> arch/arm/mach-tegra/tegra30/clock.c | 10 +- >> drivers/timer/Kconfig | 8 ++ >> drivers/timer/Makefile | 1 + >> drivers/timer/tegra-timer.c | 130 >> drivers/usb/host/ehci-tegra.c | 46 +++-- >> include/configs/tegra-common.h | 6 -- >> 15 files changed, 274 insertions(+), 79 deletions(-) >> create mode 100644 drivers/timer/tegra-timer.c > Ugh... turns out I had completely messed up the testing on Tegra186 > and it wasn't working at all. The problem is that the selection of the > TIMER symbol for all of Tegra causes the driver model to be used, but > there is no DM driver for the architected timer that's used on Tegra186. > > The quickest fix would be to do this: > > --- >8 --- > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index b50eec5b8c9b..05c8ce0e08dd 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -56,7 +56,6 @@ config TEGRA_COMMON > select MISC > select OF_CONTROL > select SPI > - select TIMER > imply CMD_DM > imply CRC32_VERIFY > > @@ -83,6 +82,7 @@ config TEGRA_ARMV7_COMMON > select TEGRA_PINCTRL > select TEGRA_PMC > select TEGRA_TIMER > + select TIMER > > config TEGRA_ARMV8_COMMON > bool "Tegra 64-bit common options" > @@ -137,6 +137,7 @@ config TEGRA210 > select TEGRA_PMC > select TEGRA_PMC_SECURE > select TEGRA_TIMER > + select TIMER > > config TEGRA186 > bool "Tegra186 family" > --- >8 --- > > So basically make TIMER selected on everything except Tegra186, so > that on Tegra186 things are basically unmodified. I can propose to include 'select TIMER' directly into TEGRA_TIMER config option. This will eliminate need of including it into mach-tegra Kconfigs. BTW, may you check current patch set on T124 and T210 if those work properly. My T30 devices work fine and same as before after switch to clk_m as timer calibration clock. Best Regards, Svyatoslav R. > Thierry
RE: [PATCH v6 0/3] Timer support for ARM Tegra
Using your existing patches and generating a v7 to fix the T210 boards sounds like the right approach to me. Tom -Original Message- From: Svyatoslav Ryhel Sent: Thursday, January 26, 2023 11:11 AM To: Thierry Reding Cc: Tom Warren ; Rayagonda Kokatanur ; Marek Vasut ; Maxim Schwalm ; Dmitry Osipenko ; Heinrich Schuchardt ; Michal Simek ; Stefan Roese ; Eugen Hristev ; Michael Walle ; Simon Glass ; Jim Liu ; William Zhang ; Rick Chen ; Stefan Herbrechtsmeier ; Andre Przywara ; Jaehoon Chung ; u-boot@lists.denx.de Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra External email: Use caution opening links or attachments чт, 26 січ. 2023 р. о 19:58 Thierry Reding пише: > > On Thu, Jan 26, 2023 at 07:12:34PM +0200, Svyatoslav Ryhel wrote: > > I may implement changes of Thierry Reding in a proper form as a > > separate patch or include in existing (depends on his choice). > > I think it's ultimately better if this is properly integrated into the > series because the series would remain bisectible. > > If the existing series is applied as-is, we have a few patches in the > middle during which Tegra210 is unusable. So if we ever have to track > down a regression that might be problematic. > > It's not a big deal since we've rarely had regressions in U-Boot. It's > ultimately up to Tom to decide how he wants to handle this. > > If you send out another series, can you please add me on Cc so I don't > miss it? > > Thanks, > Thierry Thierry Reding thanks for your clarification. If you and Tom Warren are ok, I will modify existing patches and send them as v7 in final form. Then you can check if T210 works as intended and if everything is correct. We can apply it. P. S. You may be sure that I will include you in all my patches for u-boot since it is explicitly hard to find a person with boards you own. Best Regards. Svyatoslav R. > > The only thing I need to know is if ALL known T210 devices use > > 19.2MHz as calibration clock for timer? > > > > Best regards. > > Svyatoslav R. > > > > чт, 26 січ. 2023 р. о 18:50 Tom Warren пише: > > > > > > Thanks for testing T210/T186, Thierry. > > > > > > I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need > > > either a patch from you for the T210 changes that I can apply on top of > > > his, or I'll need Svyatoslav to adopt your changes as a 4th patch in his > > > series. Once I have that and can pass buildman OK, I'll be ready to send > > > a PR to TomR. > > > > > > Tom > > > > > > -Original Message- > > > From: Thierry Reding > > > Sent: Thursday, January 26, 2023 4:41 AM > > > To: Svyatoslav Ryhel > > > Cc: Rayagonda Kokatanur ; Tom > > > Warren ; Marek Vasut ; Maxim > > > Schwalm ; Dmitry Osipenko > > > ; Heinrich Schuchardt ; > > > Michal Simek ; Stefan Roese ; > > > Eugen Hristev ; Michael Walle > > > ; Simon Glass ; Jim Liu > > > ; William Zhang > > > ; Rick Chen ; > > > Stefan Herbrechtsmeier ; > > > Andre Przywara ; Jaehoon Chung > > > ; u-boot@lists.denx.de > > > Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra > > > > > > On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > > > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > > > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > > > > > clock_osc_freq was designed to use only with T20. > > > > > > This patch remaps it to use additional frequencies, added in > > > > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra > > > > > > devices Add timer support for T20/T30/T114 and T124 based devices. > > > > > > Driver is based on DM, has device tree support and can be > > > > > > used on SPL and early boot stage. > > > > > > > > > > > > - ARM: tegra: include timer as default option Enable TIMER > > > > > > as default option for all Tegra devices and enable > > > > > > TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally enable > > > > > > SPL_TIMER if build as SPL part and drop deprecated configs from > > > > > > common header. > > > > > > > > > > > > P. S. I have no arm64 Tegra and according to comment
RE: [PATCH v6 0/3] Timer support for ARM Tegra
Thanks for testing T210/T186, Thierry.
I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need either
a patch from you for the T210 changes that I can apply on top of his, or I'll
need Svyatoslav to adopt your changes as a 4th patch in his series. Once I have
that and can pass buildman OK, I'll be ready to send a PR to TomR.
Tom
-Original Message-
From: Thierry Reding
Sent: Thursday, January 26, 2023 4:41 AM
To: Svyatoslav Ryhel
Cc: Rayagonda Kokatanur ; Tom Warren
; Marek Vasut ; Maxim Schwalm
; Dmitry Osipenko ; Heinrich
Schuchardt ; Michal Simek ; Stefan
Roese ; Eugen Hristev ; Michael
Walle ; Simon Glass ; Jim Liu
; William Zhang ; Rick Chen
; Stefan Herbrechtsmeier
; Andre Przywara
; Jaehoon Chung ;
u-boot@lists.denx.de
Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra
On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote:
> On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote:
> > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote:
> > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum
> > > clock_osc_freq was designed to use only with T20.
> > > This patch remaps it to use additional frequencies, added in
> > > T30+ SoC while maintaining backwards compatibility with T20.
> > >
> > > - drivers: timer: add timer driver for ARMv7 based Tegra devices
> > > Add timer support for T20/T30/T114 and T124 based devices.
> > > Driver is based on DM, has device tree support and can be used on
> > > SPL and early boot stage.
> > >
> > > - ARM: tegra: include timer as default option Enable TIMER as
> > > default option for all Tegra devices and enable TEGRA_TIMER for
> > > TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL
> > > part and drop deprecated configs from common header.
> > >
> > > P. S. I have no arm64 Tegra and according to comment in
> > > tegra-common.h Use the Tegra US timer on ARMv7, but the
> > > architected timer on ARMv8.
> > >
> > > Svyatoslav Ryhel (3):
> > > ARM: tegra: remap clock_osc_freq for all Tegra family
> > > drivers: timer: add timer driver for ARMv7 based Tegra devices
> > > ARM: tegra: include timer as default option
> >
> > This causes a regression on Tegra210 (Jetson TX1). I'm trying to
> > investigate, but it's complicated by the fact that I'm not getting
> > out any debug prints, so I suspect the issue is happening quite early.
>
> Alright, I managed to make this work on Tegra210 using the following
> patch on top of this series:
>
> --- >8 ---
> diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi
> index a521a43d6cfd..ccb5a927da89 100644
> --- a/arch/arm/dts/tegra210.dtsi
> +++ b/arch/arm/dts/tegra210.dtsi
> @@ -318,7 +318,7 @@
> };
>
> timer@60005000 {
> - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer";
> + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer",
> +"nvidia,tegra20-timer";
> reg = <0x0 0x60005000 0x0 0x400>;
> interrupts = ,
>, diff --git
> a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index
> cc3f00e50128..b50eec5b8c9b 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -136,6 +136,7 @@ config TEGRA210
> select TEGRA_PINCTRL
> select TEGRA_PMC
> select TEGRA_PMC_SECURE
> + select TEGRA_TIMER
>
> config TEGRA186
> bool "Tegra186 family"
> diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c
> index d2d163cf3fef..235532ba8926 100644
> --- a/drivers/timer/tegra-timer.c
> +++ b/drivers/timer/tegra-timer.c
> @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct
> udevice *dev) static int tegra_timer_probe(struct udevice *dev) {
> struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev);
> + enum clock_osc_freq freq;
> u32 usec_config, value;
>
> /* Timer rate has to be set unconditionally */
> uc_priv->clock_rate = TEGRA_TIMER_RATE;
>
> + /*
> + * The microsecond timer runs off of clk_m on Tegra210, and clk_m
> + * runs at half the OSC, so fake this up.
> + */
> + freq = clock_get_osc_freq();
> + if (freq == CLOCK_OSC_FREQ_38_4)
> + freq = CLOCK_OSC_FREQ_19_2;
> +
> /*
>* Configure microsecond timers to have 1MHz clock
>* Config register is 0xqqww, where qq is "dividend", ww is "divisor
Trouble pushing to u-boot-tegra
Tom, I haven't had to push an update to master on u-boot-tegra in several months, but I've got a new PR that needs to go in. I've tried my normal 'git push ssh://gu-te...@git.denx.de/u-boot-tegra master', but it's not working. I get: gu-te...@git.denx.de: Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Has something changed in the last (several) months? I've also just upgraded from 16.04 Ubuntu to 18.04, but everything else is working OK, so I'm not sure it's all my fault, but it may well be. :) Thanks, Tom
RE: [PATCH v3 3/3] ARM: tegra: include timer as default option
Svyatoslav, I was able to apply the first 2 patches OK to TOT u-boot-tegra/master, but not the this one (file offsets seem wrong). PTAL. I also would like someone who's using or has used T20/T30 lately to take a look, as I haven't had any interaction with those boards or builds for years, and don't know that I can rule on the fitness of these patches. Once they get ACK'd by someone that's still using T20/T30, I can apply them and get a PR in to TomR. Thanks, Tom -Original Message- From: Svyatoslav Ryhel Sent: Tuesday, January 17, 2023 9:53 AM To: Bharat Gooty ; Rayagonda Kokatanur ; Tom Warren ; Marek Vasut ; Svyatoslav Ryhel ; Maxim Schwalm ; Heinrich Schuchardt ; Michal Simek ; Stefan Roese ; Eugen Hristev ; Michael Walle ; Simon Glass ; Jim Liu ; William Zhang ; Rick Chen ; Stefan Herbrechtsmeier ; Andre Przywara ; Jaehoon Chung Cc: u-boot@lists.denx.de Subject: [PATCH v3 3/3] ARM: tegra: include timer as default option External email: Use caution opening links or attachments Enable TIMER as default option for add Tegra devices and enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL part and drop deprecated configs from common header. Signed-off-by: Svyatoslav Ryhel --- arch/arm/Kconfig | 1 + arch/arm/mach-tegra/Kconfig| 2 ++ include/configs/tegra-common.h | 6 -- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 3f68d0988b..4fce820350 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1334,6 +1334,7 @@ config ARCH_TEGRA select GPIO_EXTRA_HEADER imply DISTRO_DEFAULTS imply FAT_WRITE + imply SPL_TIMER if SPL config ARCH_VEXPRESS64 bool "Support ARMv8 Arm Ltd. VExpress based boards and models" diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index 1bef2fb233..173be3c439 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -62,6 +62,7 @@ config TEGRA_COMMON select MISC select OF_CONTROL select SPI + select TIMER imply CMD_DM imply CRC32_VERIFY @@ -87,6 +88,7 @@ config TEGRA_ARMV7_COMMON select TEGRA_NO_BPMP select TEGRA_PINCTRL select TEGRA_PMC + select TEGRA_TIMER config TEGRA_ARMV8_COMMON bool "Tegra 64-bit common options" diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h index 2915db7f8b..390a2387ea 100644 --- a/include/configs/tegra-common.h +++ b/include/configs/tegra-common.h @@ -15,12 +15,6 @@ #include /* get chip and board defs */ -/* Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. */ -#ifndef CONFIG_ARM64 -#define CONFIG_SYS_TIMER_RATE 100 -#define CONFIG_SYS_TIMER_COUNTER NV_PA_TMRUS_BASE -#endif - /* Environment */ /* -- 2.37.2
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. The following changes since commit 92a8bc6b419f548230f10a924db2b3ef10a5edad: Merge tag 'efi-2022-07-rc5' of https://source.denx.de/u-boot/custodians/u-boot-efi (2022-06-13 09:33:37 -0400) are available in the git repository at: https://source.denx.de/u-boot/custodians/u-boot-tegra.git master for you to fetch changes up to 8f27bf114ef48e681f00fcb38ad48d4ab581d0ca: board: apalis_t30/tk1/colibri_t20/t30: integrate mac address via dt (2022-06-13 15:31:15 -0700) Marcel Ziswiler (1): board: apalis_t30/tk1/colibri_t20/t30: integrate mac address via dt Peter Robinson (3): ARM: tegra: XUSB padctl: Add new lines for errors pci: tegra: Update error prints with new lines arm: tegra: Update some DT compatibles arch/arm/mach-tegra/xusb-padctl-common.c | 12 ++-- board/toradex/apalis-tk1/apalis-tk1.c| 19 +++ board/toradex/apalis_t30/apalis_t30.c| 20 board/toradex/colibri_t20/colibri_t20.c | 19 +++ board/toradex/colibri_t30/colibri_t30.c | 20 drivers/i2c/tegra_i2c.c | 1 + drivers/pci/pci_tegra.c | 4 ++-- drivers/video/tegra124/dp.c | 1 + 8 files changed, 88 insertions(+), 8 deletions(-)
RE: [PATCH v1] board: apalis_t30/tk1/colibri_t20/t30: integrate mac address via dt
Thanks, Marcel. Been OOTO, I'll take a look and get a PR up this week.
-Original Message-
From: Marcel Ziswiler
Sent: Wednesday, May 25, 2022 1:20 AM
To: u-boot@lists.denx.de
Cc: Tom Warren
Subject: Re: [PATCH v1] board: apalis_t30/tk1/colibri_t20/t30: integrate mac
address via dt
External email: Use caution opening links or attachments
Hi Tom (Warren that is)
On Sat, 2022-05-21 at 12:42 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler
>
> Use device tree to set MAC address of the Ethernet chip.
Don't want to rush anything but this one would fix booting regular mainline
upstream Linux kernel on those good oldé Tegra boards. Thanks!
Cheers
Marcel
> Signed-off-by: Marcel Ziswiler
>
> ---
>
> board/toradex/apalis-tk1/apalis-tk1.c | 19 +++
> board/toradex/apalis_t30/apalis_t30.c | 20
> board/toradex/colibri_t20/colibri_t20.c | 19 +++
> board/toradex/colibri_t30/colibri_t30.c | 20
> 4 files changed, 78 insertions(+)
>
> diff --git a/board/toradex/apalis-tk1/apalis-tk1.c
> b/board/toradex/apalis-tk1/apalis-tk1.c
> index ccf665b2118..86b10400ffa 100644
> --- a/board/toradex/apalis-tk1/apalis-tk1.c
> +++ b/board/toradex/apalis-tk1/apalis-tk1.c
> @@ -14,6 +14,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> #include
> @@ -99,6 +100,24 @@ int checkboard(void) #if
> defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) int
> ft_board_setup(void *blob, struct bd_info *bd) {
> + u8 enetaddr[6];
> +
> + /* MAC addr */
> + if (eth_env_get_enetaddr("ethaddr", enetaddr)) {
> + int err = fdt_find_and_setprop(blob,
> +
> "/pcie@1003000/pci@2,0/ethernet@0,0",
> + "local-mac-address",
> + enetaddr, 6, 0);
> +
> + /* Older device trees might have used a different node name */
> + if (err < 0)
> + err = fdt_find_and_setprop(blob,
> +
> "/pcie@1003000/pci@2,0/pcie@0",
> +
> + "local-mac-address", enetaddr, 6, 0);
> +
> + if (err >= 0)
> + puts(" MAC address updated...\n");
> + }
> +
> return ft_common_board_setup(blob, bd); } #endif diff --git
> a/board/toradex/apalis_t30/apalis_t30.c
> b/board/toradex/apalis_t30/apalis_t30.c
> index 0396eea56b5..ef71270d9f2 100644
> --- a/board/toradex/apalis_t30/apalis_t30.c
> +++ b/board/toradex/apalis_t30/apalis_t30.c
> @@ -5,6 +5,7 @@
> */
>
> #include
> +#include
> #include
> #include
> #include
> @@ -16,6 +17,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> #include "../common/tdx-common.h"
> @@ -54,6 +56,24 @@ int checkboard(void) #if defined(CONFIG_OF_LIBFDT)
> && defined(CONFIG_OF_BOARD_SETUP) int ft_board_setup(void *blob,
> struct bd_info *bd) {
> + u8 enetaddr[6];
> +
> + /* MAC addr */
> + if (eth_env_get_enetaddr("ethaddr", enetaddr)) {
> + int err = fdt_find_and_setprop(blob,
> +
> "/pcie@3000/pci@3,0/ethernet@0,0",
> + "local-mac-address",
> + enetaddr, 6, 0);
> +
> + /* Older device trees might have used a different node name */
> + if (err < 0)
> + err = fdt_find_and_setprop(blob,
> +
> "/pcie@3000/pci@3,0/pcie@0",
> +
> + "local-mac-address", enetaddr, 6, 0);
> +
> + if (err >= 0)
> + puts(" MAC address updated...\n");
> + }
> +
> return ft_common_board_setup(blob, bd); } #endif diff --git
> a/board/toradex/colibri_t20/colibri_t20.c
> b/board/toradex/colibri_t20/colibri_t20.c
> index 73ef4d2db32..c58d2021cd3 100644
> --- a/board/toradex/colibri_t20/colibri_t20.c
> +++ b/board/toradex/colibri_t20/colibri_t20.c
> @@ -4,6 +4,7 @@
> */
>
> #include
> +#include
> #include
> #include
> #include
> @@ -81,6 +82,24 @@ int checkboard(void) #if defined(CONFIG_OF_LIBFDT)
> && defined(CONFIG_OF_BOARD_SETUP) int ft_board_setup(void *blob,
> struct bd_info *bd) {
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. The following changes since commit 10cd8efe1a7eacd63907ba95bd8442bc2cdce461: Merge branch '2021-10-12-assorted-fixes-and-updates' (2021-10-13 10:14:35 -0400) are available in the git repository at: https://source.denx.de/u-boot/custodians/u-boot-tegra.git master for you to fetch changes up to a0ba216ed420a8953f57f777256f310370b95338: ARM: tegra: Copy memory-region-names property (2021-10-13 14:18:30 -0700) Thierry Reding (9): fdtdec: Allow using fdtdec_get_carveout() in loops fdtdec: Support retrieving the name of a carveout fdtdec: Support compatible string list for reserved memory fdtdec: Reorder fdtdec_set_carveout() parameters for consistency fdtdec: Support reserved-memory flags ARM: tegra: Support multiple reserved memory regions ARM: tegra: Support EMC frequency tables on Tegra210 ARM: tegra: Refactor DT update helpers ARM: tegra: Copy memory-region-names property arch/arm/cpu/armv8/fsl-layerscape/soc.c | 3 +- arch/arm/include/asm/arch-tegra/board.h | 10 +++ arch/arm/mach-tegra/dt-setup.c | 147 arch/riscv/lib/fdt_fixup.c | 2 +- board/nvidia/p2371-2180/p2371-2180.c| 94 ++-- board/nvidia/p2771-/p2771-.c| 98 ++--- board/nvidia/p3450-/p3450-.c| 96 ++--- include/configs/tegra210-common.h | 2 +- include/fdtdec.h| 39 ++--- lib/fdtdec.c| 99 ++--- lib/fdtdec_test.c | 7 +- lib/optee/optee.c | 4 +- test/dm/fdtdec.c| 28 +++--- 13 files changed, 321 insertions(+), 308 deletions(-)
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. The following changes since commit a0da2dda4ed9d0aee5265e9cd8876734f9f80e09: Prepare v2021.10-rc2 (2021-08-16 14:18:45 -0400) are available in the git repository at: ssh://twarren@git-mirror-santaclara:12001/m/denx.de/u-boot-tegra.git for you to fetch changes up to 5e39e20a1af916fee3aabd61eedafadf29a9edb9: board: apalis-tk1: launch toradex easy installer in usb recovery (2021-08-16 12:17:07 -0700) Marcel Ziswiler (1): board: apalis-tk1: launch toradex easy installer in usb recovery board/toradex/apalis-tk1/apalis-tk1.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-)
RE: [PATCH v3] board: apalis-tk1: launch toradex easy installer in usb recovery
> The rest of that series which was i.MX specific was already applied by
> Stefano. So if you could take this one as a singleton that would be great.
> Thanks!
Will do, but it won't happen until at least next Monday as I'm OOTO til then.
Tom
--
nvpublic
-Original Message-
From: Marcel Ziswiler
Sent: Wednesday, August 11, 2021 12:56 PM
To: u-boot@lists.denx.de; Tom Warren ; sba...@denx.de
Cc: s...@chromium.org; Oleksandr Suvorov
Subject: Re: [PATCH v3] board: apalis-tk1: launch toradex easy installer in usb
recovery
External email: Use caution opening links or attachments
On Wed, 2021-08-11 at 16:45 +0000, Tom Warren wrote:
> I'm fine with someone else taking this tegra patch in if it's part of
> a larger series. If not, let me know and I'll take it as a singleton.
The rest of that series which was i.MX specific was already applied by Stefano.
So if you could take this one as a singleton that would be great. Thanks!
> Tom
Cheers
Marcel
> --
> nvpublic
>
> -Original Message-
> From: Stefano Babic
> Sent: Wednesday, August 11, 2021 6:24 AM
> To: Marcel Ziswiler ; u-boot@lists.denx.de
> Cc: Stefano Babic ; Simon Glass ;
> Marcel Ziswiler ; Oleksandr Suvorov
> ; Tom Warren
> Subject: Re: [PATCH v3] board: apalis-tk1: launch toradex easy
> installer in usb recovery
>
> External email: Use caution opening links or attachments
>
>
> Hallo Marcel,
>
> On 11.08.21 15:12, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler
> >
> > The USB recovery mode is used by Toradex to load the Toradex Easy
> > Installer image which supports further system images installation.
> > Prepare for loading and launching the Toradex Easy Installer if the
> > USB Recovery mode is activated.
> >
> > Signed-off-by: Marcel Ziswiler
> > Signed-off-by: Oleksandr Suvorov
> >
> > ---
> >
>
> Added Tom in CC as he's in charge for Tegra (I have just reviewed V2 because
> it was part of i.MX series).
>
> Best regards,
> Stefano
>
> > Changes in v3:
> > - Switch very long lines to multiline to make checkpatch happy as
> >suggested by Stefano.
> >
> > board/toradex/apalis-tk1/apalis-tk1.c | 20 ++--
> > 1 file changed, 18 insertions(+), 2 deletions(-)
> >
> > diff --git a/board/toradex/apalis-tk1/apalis-tk1.c
> > b/board/toradex/apalis-tk1/apalis-tk1.c
> > index b97617cfca3..2769b546010 100644
> > --- a/board/toradex/apalis-tk1/apalis-tk1.c
> > +++ b/board/toradex/apalis-tk1/apalis-tk1.c
> > @@ -38,8 +38,24 @@
> > int arch_misc_init(void)
> > {
> > if (readl(NV_PA_BASE_SRAM + NVBOOTINFOTABLE_BOOTTYPE) ==
> > - NVBOOTTYPE_RECOVERY)
> > - printf("USB recovery mode\n");
> > + NVBOOTTYPE_RECOVERY) {
> > + printf("USB recovery mode, attempting to boot Toradex Easy "
> > +"Installer\n");
> > + env_set("bootdelay", "-2");
> > + env_set("defargs", "pcie_aspm=off user_debug=30");
> > + env_set("fdt_high", "");
> > + env_set("initrd_high", "");
> > +
> > + env_set("setup", "env set setupargs igb_mac=${ethaddr} "
> > + "consoleblank=0 no_console_suspend=1 "
> > + "console=${console},${baudrate}n8 ${memargs}");
> > + env_set("teziargs", "rootfstype=squashfs root=/dev/ram quiet "
> > + "autoinstall");
> > + env_set("vidargs", "video=HDMI-A-1:640x480-16@60D");
> > + env_set("bootcmd", "run setup; env set bootargs ${defargs} "
> > + "${setupargs} ${vidargs} ${teziargs}; bootm
> > 0x80208000"
> > + "#config@${soc}-${fdt_module}-${fdt_board}.dtb");
> > + }
> >
> > /* PCB Version Indication: V1.2 and later have GPIO_PV0 wired to GND
> > */
> > gpio_request(TEGRA_GPIO(V, 0), "PCB Version Indication");
RE: [PATCH v3] board: apalis-tk1: launch toradex easy installer in usb recovery
I'm fine with someone else taking this tegra patch in if it's part of a larger
series. If not, let me know and I'll take it as a singleton.
Tom
--
nvpublic
-Original Message-
From: Stefano Babic
Sent: Wednesday, August 11, 2021 6:24 AM
To: Marcel Ziswiler ; u-boot@lists.denx.de
Cc: Stefano Babic ; Simon Glass ; Marcel
Ziswiler ; Oleksandr Suvorov
; Tom Warren
Subject: Re: [PATCH v3] board: apalis-tk1: launch toradex easy installer in usb
recovery
External email: Use caution opening links or attachments
Hallo Marcel,
On 11.08.21 15:12, Marcel Ziswiler wrote:
> From: Marcel Ziswiler
>
> The USB recovery mode is used by Toradex to load the Toradex Easy
> Installer image which supports further system images installation.
> Prepare for loading and launching the Toradex Easy Installer if the
> USB Recovery mode is activated.
>
> Signed-off-by: Marcel Ziswiler
> Signed-off-by: Oleksandr Suvorov
>
> ---
>
Added Tom in CC as he's in charge for Tegra (I have just reviewed V2 because it
was part of i.MX series).
Best regards,
Stefano
> Changes in v3:
> - Switch very long lines to multiline to make checkpatch happy as
>suggested by Stefano.
>
> board/toradex/apalis-tk1/apalis-tk1.c | 20 ++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/board/toradex/apalis-tk1/apalis-tk1.c
> b/board/toradex/apalis-tk1/apalis-tk1.c
> index b97617cfca3..2769b546010 100644
> --- a/board/toradex/apalis-tk1/apalis-tk1.c
> +++ b/board/toradex/apalis-tk1/apalis-tk1.c
> @@ -38,8 +38,24 @@
> int arch_misc_init(void)
> {
> if (readl(NV_PA_BASE_SRAM + NVBOOTINFOTABLE_BOOTTYPE) ==
> - NVBOOTTYPE_RECOVERY)
> - printf("USB recovery mode\n");
> + NVBOOTTYPE_RECOVERY) {
> + printf("USB recovery mode, attempting to boot Toradex Easy "
> +"Installer\n");
> + env_set("bootdelay", "-2");
> + env_set("defargs", "pcie_aspm=off user_debug=30");
> + env_set("fdt_high", "");
> + env_set("initrd_high", "");
> +
> + env_set("setup", "env set setupargs igb_mac=${ethaddr} "
> + "consoleblank=0 no_console_suspend=1 "
> + "console=${console},${baudrate}n8 ${memargs}");
> + env_set("teziargs", "rootfstype=squashfs root=/dev/ram quiet "
> + "autoinstall");
> + env_set("vidargs", "video=HDMI-A-1:640x480-16@60D");
> + env_set("bootcmd", "run setup; env set bootargs ${defargs} "
> + "${setupargs} ${vidargs} ${teziargs}; bootm 0x80208000"
> + "#config@${soc}-${fdt_module}-${fdt_board}.dtb");
> + }
>
> /* PCB Version Indication: V1.2 and later have GPIO_PV0 wired to GND */
> gpio_request(TEGRA_GPIO(V, 0), "PCB Version Indication");
>
--
=
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
RE: [PATCHv2 2/4] tegra: Test on CONFIG_CMD_USB being enabled for distro bootcmd
Acked-by twar...@nvidia.com -Original Message- From: Tom Rini Sent: Friday, July 9, 2021 7:12 AM To: u-boot@lists.denx.de Cc: Tom Warren Subject: [PATCHv2 2/4] tegra: Test on CONFIG_CMD_USB being enabled for distro bootcmd External email: Use caution opening links or attachments Reuse the common logic to allow for BOOT_TARGET_DEVICES to list USB as a possibility if we're building for a platform that will have USB but not if we don't, so that we don't hit the link-time check for trying to have USB boot on a non-USB system. Cc: Tom Warren Signed-off-by: Tom Rini --- Changes in v2: - New patch. This problem shows up later in the series when we stop building USB framework without a host controller of some sort also enabled. --- include/configs/tegra-common-post.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/configs/tegra-common-post.h b/include/configs/tegra-common-post.h index fae0e761fb42..dd7a75ae4674 100644 --- a/include/configs/tegra-common-post.h +++ b/include/configs/tegra-common-post.h @@ -21,11 +21,18 @@ #define CONFIG_SYS_NONCACHED_MEMORY(1 << 20) /* 1 MiB */ #ifndef CONFIG_SPL_BUILD + +#if CONFIG_IS_ENABLED(CMD_USB) +# define BOOT_TARGET_USB(func) func(USB, usb, 0) #else # define +BOOT_TARGET_USB(func) #endif + #ifndef BOOT_TARGET_DEVICES #define BOOT_TARGET_DEVICES(func) \ func(MMC, mmc, 1) \ func(MMC, mmc, 0) \ - func(USB, usb, 0) \ + BOOT_TARGET_USB(func) \ func(PXE, pxe, na) \ func(DHCP, dhcp, na) #endif -- 2.17.1
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. All Tegra builds are OK on my system, and Stephen's test frame reports that all tests pass. The following changes since commit ee1e04558ff8c8ed812b986939447f129bb0b0bb: Merge branch '2020-12-02-master-imports' (2020-12-03 09:43:47 -0500) are available in the git repository at: ssh://twarren@git-mirror-santaclara:12001/m/denx.de/u-boot-tegra.git for you to fetch changes up to 4f5128ff899d0cb13a7b010f6dbffd0aba71bb25: configs: cei-tk1-som: remove CONFIG_ARMV7_PSCI in include file (2020-12-04 13:39:15 -0700) Marcel Ziswiler (5): apalis/colibri_t30: add comment about tristate and input vs. output pinmuxing colibri_t30: fix spi1 and uart2/3 resp. uartb/c pinmuxing apalis/colibri_t30: avoid uart input from floating pins apalis/colibri_t30: add note about colibri vs. nvidia uart mapping colibri_t30: disable rs232 serial transceiver forceoff pins Patrick Delaunay (1): configs: cei-tk1-som: remove CONFIG_ARMV7_PSCI in include file Peter Robinson (2): arm: tegra: define fdtfile option for distro boot arm: tegra: add options for BOOTENV_EFI_SET_FDTFILE_FALLBACK for tegra186 arch/arm/mach-tegra/tegra124/Kconfig | 1 + .../toradex/apalis_t30/pinmux-config-apalis_t30.h | 11 ++-- board/toradex/colibri_t30/colibri_t30.c| 11 .../colibri_t30/pinmux-config-colibri_t30.h| 32 -- configs/cei-tk1-som_defconfig | 1 + include/config_distro_bootcmd.h| 2 ++ include/configs/apalis_t30.h | 9 +- include/configs/cei-tk1-som.h | 2 -- include/configs/colibri_t30.h | 8 +- include/configs/tegra-common.h | 6 include/configs/tegra114-common.h | 1 + include/configs/tegra124-common.h | 1 + include/configs/tegra186-common.h | 6 include/configs/tegra20-common.h | 1 + include/configs/tegra210-common.h | 1 + include/configs/tegra30-common.h | 1 + 16 files changed, 73 insertions(+), 21 deletions(-)
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. All Tegra builds are OK on my system, and Stephen's test frame reports that all tests pass. The following changes since commit 9cb895203a46654f7ee6dd95be5c8ab05e4dfbd3: Merge tag 'u-boot-stm32-20200616' of https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2020-06-16 09:18:56 -0400) are available in the git repository at: ssh://twarren@git-mirror-santaclara:12001/m/denx.de/u-boot-tegra.git master for you to fetch changes up to 7b4f42b6cd5d8fa32f763b5ec03b7b8fdf7c4303: t210: Nano: Add NVME support (2020-06-18 15:12:34 -0700) Igor Opaniuk (1): colibri_t20: change maintainer Jon Hunter (2): firmware: PSCI: Fix PSCI support for OF live trees ARM: tegra: Enable PSCI support for Tegra210 and Tegra186 Tom Warren (1): t210: Nano: Add NVME support arch/arm/dts/tegra186.dtsi| 5 + arch/arm/dts/tegra210.dtsi| 5 + board/toradex/colibri_t20/MAINTAINERS | 2 +- configs/p3450-_defconfig | 1 + drivers/firmware/psci.c | 4 +--- 5 files changed, 13 insertions(+), 4 deletions(-)
RE: [PATCH 1/2] firmware: PSCI: Fix PSCI support for OF live trees
No worries, I can fix it when I add them to u-boot-tegra. I have some other
patches to add & generate a PR, I'll get it out by EOW. TomR - do you want me
to take this patch as well as the ARM: tegra: patch in my PR, or do you want
Jon's first patch to go thru a different repo?
Tom
--
nvpublic
-Original Message-
From: Jonathan Hunter
Sent: Thursday, June 18, 2020 8:47 AM
To: Tom Rini ; Tom Warren
Cc: Stephen Warren ; Thierry Reding ;
Peter Robinson ; Heinrich Schuchardt
; u-boot@lists.denx.de
Subject: Re: [PATCH 1/2] firmware: PSCI: Fix PSCI support for OF live trees
On 18/06/2020 12:54, Jon Hunter wrote:
> When CONFIG_OF_LIVE is enabled, dev_of_offset() cannot be used and if
> used returns an invalid offset. This causes the call to
> fdt_stringlist_get() in the psci_probe() to fail to read the 'method'
> property from the PSCI node for the device and hence prevents PSCI
> from working. Fix this by using the ofnode_read_string() API instead
> of the fdt_stringlist_get() because this will handle reading the
> property both when CONFIG_OF_LIVE is enabled or disabled.
>
> Due to the above problem and since commit 81ea00838c68 ("efi_loader:
> PSCI reset and shutdown") was added, the EFI system reset has been
> broken for Tegra210 and Tegra196 platforms. This also fixes the EFI
> system reset for these Tegra platforms.
Oops, just spotted the above typo. Should be Tegra186 and not Tegra196 (which
does not exist!). I can correct that.
Jon
--
nvpublic
RE: [PATCHv2 04/31] Convert CONFIG_ARMV7_PSCI et al to Kconfig
-Original Message- From: Tom Rini Sent: Tuesday, June 16, 2020 4:06 PM To: u-boot@lists.denx.de Cc: Tom Warren ; peter.ch...@data61.csiro.au Subject: [PATCHv2 04/31] Convert CONFIG_ARMV7_PSCI et al to Kconfig External email: Use caution opening links or attachments This converts the following to Kconfig: CONFIG_ARMV7_PSCI CONFIG_ARMV7_PSCI_NR_CPUS Cc: Tom Warren Cc: peter.ch...@data61.csiro.au Signed-off-by: Tom Rini --- arch/arm/mach-tegra/tegra124/Kconfig | 1 + include/configs/cei-tk1-som.h| 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig index 6fa31ea0a16c..fb016aa46c90 100644 --- a/arch/arm/mach-tegra/tegra124/Kconfig +++ b/arch/arm/mach-tegra/tegra124/Kconfig @@ -19,6 +19,7 @@ config TARGET_JETSON_TK1 config TARGET_CEI_TK1_SOM bool "Colorado Engineering Inc Tegra124 TK1-som board" + select ARCH_SUPPORT_PSCI select BOARD_LATE_INIT select CPU_V7_HAS_NONSEC if !SPL_BUILD select CPU_V7_HAS_VIRT if !SPL_BUILD diff --git a/include/configs/cei-tk1-som.h b/include/configs/cei-tk1-som.h index dbebef34e386..2541f2fc27c2 100644 --- a/include/configs/cei-tk1-som.h +++ b/include/configs/cei-tk1-som.h @@ -32,8 +32,6 @@ #include "tegra-common-usb-gadget.h" #include "tegra-common-post.h" -#define CONFIG_ARMV7_PSCI 1 -#define CONFIG_ARMV7_PSCI_NR_CPUS 4 /* Reserve top 1M for secure RAM */ #define CONFIG_ARMV7_SECURE_BASE 0xfff0 #define CONFIG_ARMV7_SECURE_RESERVE_SIZE 0x0010 -- 2.17.1 Acked-by: Tom Warren -- nvpublic
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. All Tegra builds are OK on my system, and Stephen's test frame reports that all tests pass. This adds support for Jetson Nano, plus miscellaneous other fixes found during Nano bringup. It also adds Igor's update_uboot wrapper patches. The following changes since commit e0718b3ab754860bd47677e6b4fc5b70da42c4ab: Merge tag 'dm-pull-1apr20' of git://git.denx.de/u-boot-dm (2020-04-01 14:29:21 -0400) are available in the git repository at: ssh://twarren@git-mirror-santaclara:12001/m/denx.de/u-boot-tegra.git master for you to fetch changes up to 7c02bc9649f6d3afd272ac4a94b280495473834c: ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support (2020-04-02 14:30:02 -0700) Igor Opaniuk (4): apalis-tk1: add update_uboot wrapper apalis_t30: add update_uboot wrapper colibri_t20: add update_uboot wrapper colibri_t30: add update_uboot wrapper JC Kuo (1): t210: do not enable PLLE and UPHY PLL HW PWRSEQ Stephen Warren (1): ARM: tegra: p2371-2180: add I2C nodes to DT Tom Warren (11): t210: pinmux: Remove pinmux/GPIO init from T210 boards i2c: t210: Add VI_I2C clock source support tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all Jetson boards mmc: t210: Add autocal and tap/trim updates for SDMMC1/3 mmc: t210: Fix 'bad' SD-card clock when doing 400KHz card detect qspi: t210: Fix claim_bus's use of the wrong bus/device qspi: t210: Fix QSPI clock and tap delays qspi: t210: Use dev_read calls to get FDT data like base, freq t210: Adjust ramdisk_addr_r/fdt_addr_r to allow for large kernels mtd: spi: Add Macronix MX25U3235F device ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support Vishruth (1): ARM: tegra: p2771-: enable PIE relocation arch/arm/cpu/armv8/cpu.c | 5 + arch/arm/dts/Makefile | 3 +- arch/arm/dts/tegra210-p2371-2180.dts | 12 + arch/arm/dts/tegra210-p3450-.dts | 147 +++ arch/arm/include/asm/arch-tegra/tegra_mmc.h| 20 +- arch/arm/include/asm/arch-tegra/xusb-padctl.h | 1 + arch/arm/mach-tegra/board2.c | 31 +++ arch/arm/mach-tegra/tegra210/Kconfig | 7 + arch/arm/mach-tegra/tegra210/Makefile | 3 +- arch/arm/mach-tegra/tegra210/clock.c | 27 +- arch/arm/mach-tegra/tegra210/pinmux.c | 194 -- arch/arm/mach-tegra/tegra210/xusb-padctl.c | 68 +++-- arch/arm/mach-tegra/xusb-padctl-dummy.c| 4 + board/nvidia/e2220-1170/e2220-1170.c | 21 +- board/nvidia/e2220-1170/pinmux-config-e2220-1170.h | 276 board/nvidia/p2371-/p2371-.c | 21 +- board/nvidia/p2371-/pinmux-config-p2371-.h | 267 board/nvidia/p2371-2180/p2371-2180.c | 21 +- board/nvidia/p2371-2180/pinmux-config-p2371-2180.h | 278 - board/nvidia/p2571/p2571.c | 21 +- board/nvidia/p2571/pinmux-config-p2571.h | 242 -- board/nvidia/p3450-/Kconfig| 12 + board/nvidia/p3450-/MAINTAINERS| 6 + board/nvidia/p3450-/Makefile | 8 + board/nvidia/p3450-/p3450-.c | 178 + configs/e2220-1170_defconfig | 1 + configs/p2371-_defconfig | 1 + configs/p2371-2180_defconfig | 1 + configs/p2571_defconfig| 1 + configs/p2771--000_defconfig | 2 + configs/p2771--500_defconfig | 2 + configs/p3450-_defconfig | 64 + drivers/mmc/tegra_mmc.c| 103 +++- drivers/mtd/spi/spi-nor-ids.c | 1 + drivers/spi/tegra210_qspi.c| 39 +-- include/configs/apalis-tk1.h | 9 + include/configs/apalis_t30.h | 11 + include/configs/colibri_t20.h | 8 +- include/configs/colibri_t30.h | 11 + include/configs/p3450-.h | 46 include/configs/tegra210-common.h | 4 +- 41 files changed, 757 insertions(+), 1420 deletions(-) create mode 100644 arch/arm/dts/tegra210-p3450-.dts delete mode 100644 arch/arm/mach-tegra/tegra210/pinmux.c delete mode 100644 board/nvidia/e2220-1170/pinmux-config-e2220-1170.h delete mode 100644 board/nvidia/p2371-/pinmux-config-p2371-.h delete mode 100644 board/nvidia/p2371-2180/pinmux-config-p2371-2180.h delete mode 100644 board/nvidia/p2571/pinmux-config-p2571.h create mode 100644 board/nvidia/p3450
RE: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support
-Original Message-
From: Peter Robinson
Sent: Wednesday, April 1, 2020 3:31 PM
To: tomcwarren3...@gmail.com
Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding
; Jonathan Hunter ; Tom Warren
Subject: Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support
External email: Use caution opening links or attachments
On Wed, Mar 25, 2020 at 6:22 PM wrote:
>
> From: Tom Warren
>
> The Jetson Nano Developer Kit is a Tegra X1-based development board.
> It is similar to Jetson TX1 but it is not pin compatible. It features
> 4GB of LPDDR4, a SPI NOR flash for early boot firmware and an SD card
> slot used for storage.
>
> HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB
> 2.0 and 1 USB 3.0) can be used to attach a variety of peripherals and
> a PCI Ethernet controller provides onboard network connectivity. NVMe
> support has also been added. Env save is at the end of QSPI (4MB-8K).
>
> A 40-pin header on the board can be used to extend the capabilities
> and exposed interfaces of the Jetson Nano.
>
> Signed-off-by: Thierry Reding
> Signed-off-by: Tom Warren
Tested-by: Peter Robinson
Tested with L4T R32.3.1 and Fedora 32. A query below.
> ---
> retry send-email to see if it shows up in Patchwork
>
> arch/arm/dts/Makefile| 3 +-
> arch/arm/dts/tegra210-p3450-.dts | 147 +
> arch/arm/mach-tegra/board2.c | 25 +
> arch/arm/mach-tegra/tegra210/Kconfig | 7 ++
> board/nvidia/p3450-/Kconfig | 12 +++
> board/nvidia/p3450-/MAINTAINERS | 6 ++
> board/nvidia/p3450-/Makefile | 8 ++
> board/nvidia/p3450-/p3450-.c | 178
> +++
> configs/p3450-_defconfig | 64 +
> include/configs/p3450-.h | 46 +
> 10 files changed, 495 insertions(+), 1 deletion(-) create mode
> 100644 arch/arm/dts/tegra210-p3450-.dts
> create mode 100644 board/nvidia/p3450-/Kconfig create mode
> 100644 board/nvidia/p3450-/MAINTAINERS
> create mode 100644 board/nvidia/p3450-/Makefile create mode
> 100644 board/nvidia/p3450-/p3450-.c
> create mode 100644 configs/p3450-_defconfig create mode 100644
> include/configs/p3450-.h
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> 9c593b2..820ee97 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -180,7 +180,8 @@ dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
> tegra210-e2220-1170.dtb \
> tegra210-p2371-.dtb \
> tegra210-p2371-2180.dtb \
> - tegra210-p2571.dtb
> + tegra210-p2571.dtb \
> + tegra210-p3450-.dtb
>
> dtb-$(CONFIG_ARCH_MVEBU) +=\
> armada-3720-db.dtb \
> diff --git a/arch/arm/dts/tegra210-p3450-.dts
> b/arch/arm/dts/tegra210-p3450-.dts
> new file mode 100644
> index 000..9ef744a
> --- /dev/null
> +++ b/arch/arm/dts/tegra210-p3450-.dts
> @@ -0,0 +1,147 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2019-2020 NVIDIA Corporation */
> +/dts-v1/;
> +
> +#include "tegra210.dtsi"
> +
> +/ {
> + model = "NVIDIA Jetson Nano Developer Kit";
> + compatible = "nvidia,p3450-", "nvidia,tegra210";
> +
> + chosen {
> + stdout-path =
> + };
> +
> + aliases {
> + ethernet = "/pcie@1003000/pci@2,0/ethernet@0,0";
> + i2c0 = "/i2c@7000d000";
> + i2c2 = "/i2c@7000c400";
> + i2c3 = "/i2c@7000c500";
> + i2c4 = "/i2c@7000c700";
> + mmc0 = "/sdhci@700b0600";
> + mmc1 = "/sdhci@700b";
> + spi0 = "/spi@7041";
> + usb0 = "/usb@7d00";
> + };
> +
> + memory {
> + reg = <0x0 0x8000 0x0 0xc000>;
> + };
> +
> + pcie@1003000 {
> + status = "okay";
> +
> + pci@1,0 {
> + status = "okay";
> + };
> +
> + pci@2,0 {
> + status = "okay";
> +
> + ethernet@0,0 {
> + reg = <0x00 0 0 0 0>;
> + local-mac-address = [ 00 00 00 00 00 00 ];
> + };
> + };
> + };
> +
> + serial@70006000 {
> + status = "okay";
>
RE: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT
-Original Message-
From: Thierry Reding
Sent: Wednesday, April 1, 2020 8:20 AM
To: Tom Warren
Cc: Peter Robinson ; tomcwarren3...@gmail.com;
u-boot@lists.denx.de; Stephen Warren ; Jonathan Hunter
; Vishruth Jain
Subject: Re: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT
On Wed, Apr 01, 2020 at 02:03:09AM +0200, Tom Warren wrote:
> -Original Message-
> From: Peter Robinson
> Sent: Tuesday, March 31, 2020 3:54 AM
> To: tomcwarren3...@gmail.com
> Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry
> Reding ; Jonathan Hunter ;
> Tom Warren ; Vishruth Jain
> Subject: Re: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT
>
> External email: Use caution opening links or attachments
>
>
> > From: Stephen Warren
> >
> > This adds to the DT the I2C controllers that connect to the board ID
> > EEPROM, camera board EEPROM, etc. With this change, you can now
> > probe all I2C devices on a TX1 board.
> >
> > Signed-off-by: Tom Warren
> > ---
> > arch/arm/dts/tegra210-p2371-2180.dts | 18 ++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/dts/tegra210-p2371-2180.dts
> > b/arch/arm/dts/tegra210-p2371-2180.dts
> > index c2f497c..d982b5f 100644
> > --- a/arch/arm/dts/tegra210-p2371-2180.dts
> > +++ b/arch/arm/dts/tegra210-p2371-2180.dts
> > @@ -12,6 +12,9 @@
> >
> > aliases {
> > i2c0 = "/i2c@7000d000";
> > + i2c2 = "/i2c@7000c400";
> > + i2c3 = "/i2c@7000c500";
> > + i2c5 = "/i2c@546c0c00";
>
> I don't think this is correct, it doesn't show up in U-Boot with the
> "i2c bus" command where the others do, looking in the tegra210.dtsi it
> looks like it should be i2c@546c?
> [Tom] That I2C address is working in downstream (L4T) TX1 U-Boot. The
> VI_I2C controller is a little weird, it's normal I2C registers are
> offset from base by 0xC00. A different driver is needed, but I
> haven't posted it yet upstream. I should probably drop if from the
> DTS for now until I post the VI_I2C driver.
I think the problem here is that the upstream U-Boot device tree doesn't
contain an i2c@546c0c00 node. Instead it has i2c@546c, which we also have
in the upstream kernel. My recollection is that that's also the address listed
in the Tegra210 system address map of the TRM and there are some registers
before the regular I2C interface at offset 0xc00.
I've been carrying a patch against the upstream Linux I2C controller driver to
special-case the VI/I2C to always add that 0xc00 offset when accessing
registers, which allows us to reuse the existing driver and at the same time
keeps all registers mapped so we can also access the VI/I2C specific registers.
My recollection is that the U-Boot driver is fairly similar to the Linux
driver, so I suspect something similar could be done.
Thierry
[Tom] Thanks, Thierry. That's my recollection, too, about the VI_I2C 0xC00
offset. I'll take a look at what we have in L4T U-Boot for T210 and address it
in a set of patches for upstream soon. That I2C controller isn't used for
anything on any Jetson board except on TX1, I believe, where it allows U-Boot
to talk to the camera add-in board to read the board ID. But we've moved all
that out to CBoot (board ID EEPROM reading), so there isn't a pressing need for
it in U-Boot anymore, IIRC.
--nvpublic
RE: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT
-Original Message-
From: Peter Robinson
Sent: Tuesday, March 31, 2020 3:54 AM
To: tomcwarren3...@gmail.com
Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding
; Jonathan Hunter ; Tom Warren
; Vishruth Jain
Subject: Re: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT
External email: Use caution opening links or attachments
> From: Stephen Warren
>
> This adds to the DT the I2C controllers that connect to the board ID
> EEPROM, camera board EEPROM, etc. With this change, you can now probe
> all I2C devices on a TX1 board.
>
> Signed-off-by: Tom Warren
> ---
> arch/arm/dts/tegra210-p2371-2180.dts | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/dts/tegra210-p2371-2180.dts
> b/arch/arm/dts/tegra210-p2371-2180.dts
> index c2f497c..d982b5f 100644
> --- a/arch/arm/dts/tegra210-p2371-2180.dts
> +++ b/arch/arm/dts/tegra210-p2371-2180.dts
> @@ -12,6 +12,9 @@
>
> aliases {
> i2c0 = "/i2c@7000d000";
> + i2c2 = "/i2c@7000c400";
> + i2c3 = "/i2c@7000c500";
> + i2c5 = "/i2c@546c0c00";
I don't think this is correct, it doesn't show up in U-Boot with the "i2c bus"
command where the others do, looking in the tegra210.dtsi it looks like it
should be i2c@546c?
[Tom] That I2C address is working in downstream (L4T) TX1 U-Boot. The VI_I2C
controller is a little weird, it's normal I2C registers are offset from base by
0xC00. A different driver is needed, but I haven't posted it yet upstream. I
should probably drop if from the DTS for now until I post the VI_I2C driver.
--nvpublic
> mmc0 = "/sdhci@700b0600";
> mmc1 = "/sdhci@700b";
> usb0 = "/usb@7d00"; @@ -33,6 +36,11 @@
> };
> };
>
> + i2c@546c0c00 {
> + status = "okay";
> + clock-frequency = <40>;
> + };
> +
> padctl@7009f000 {
> pinctrl-0 = <_default>;
> pinctrl-names = "default"; @@ -85,6 +93,16 @@
> non-removable;
> };
>
> + i2c@7000c400 {
> + status = "okay";
> + clock-frequency = <40>;
> + };
> +
> + i2c@7000c500 {
> + status = "okay";
> + clock-frequency = <40>;
> + };
> +
> i2c@7000d000 {
> status = "okay";
> clock-frequency = <40>;
> --
> 1.8.2.1.610.g562af5b
>
>
> --
> - This email message is for the sole use of the intended
> recipient(s) and may contain confidential information. Any
> unauthorized review, use, disclosure or distribution is prohibited.
> If you are not the intended recipient, please contact the sender by
> reply email and destroy all copies of the original message.
> --
> -
RE: [PATCH] mtd: spi: Add Macronix MX25U3235F device
-Original Message-
From: Peter Robinson
Sent: Tuesday, March 31, 2020 3:00 AM
To: tomcwarren3...@gmail.com
Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding
; Jonathan Hunter ; Tom Warren
; ja...@amarulasolutions.com
Subject: Re: [PATCH] mtd: spi: Add Macronix MX25U3235F device
External email: Use caution opening links or attachments
On Thu, Mar 26, 2020 at 9:59 PM wrote:
>
> From: Tom Warren
>
> Add Macronix MX25U3235F flash device description.
> This is a 4MiB part.
Is there potentially more than one part used on the Jetson nano as I get the
following on mine:
Loading Environment from SPI Flash... unrecognized JEDEC id bytes: 00, 40, ff
[Tom] No, just the Macronix 4MB part. You probably need the VI_I2C fix, there
was a problem with the index of the internal_id table. The Macronix part is
JEDEC C2, 25, 36 IIRC.
See "i2c: t210: Add VI_I2C clock source support", just posted a few days ago,
should be in tegra-next.
--nvpublic
> Signed-off-by: Tom Warren
> ---
> drivers/mtd/spi/spi-nor-ids.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c
> b/drivers/mtd/spi/spi-nor-ids.c index 973b6f8..abdf560 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -147,6 +147,7 @@ const struct flash_info spi_nor_ids[] = {
> { INFO("mx25l6405d", 0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> { INFO("mx25u2033e", 0xc22532, 0, 64 * 1024, 4, SECT_4K) },
> { INFO("mx25u1635e", 0xc22535, 0, 64 * 1024, 32, SECT_4K) },
> + { INFO("mx25u3235f", 0xc22536, 0, 4 * 1024, 1024, SECT_4K)
> + },
> { INFO("mx25u6435f", 0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, 0) },
> { INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) },
> --
> 1.8.2.1.610.g562af5b
>
>
> --
> - This email message is for the sole use of the intended
> recipient(s) and may contain confidential information. Any
> unauthorized review, use, disclosure or distribution is prohibited.
> If you are not the intended recipient, please contact the sender by
> reply email and destroy all copies of the original message.
> --
> -
RE: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support
-Original Message- From: Stephen Warren Sent: Wednesday, March 25, 2020 12:31 PM To: Tom Warren Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding ; Jonathan Hunter ; tomcwarren3...@gmail.com Subject: Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support External email: Use caution opening links or attachments On 3/24/20 1:03 PM, twar...@nvidia.com wrote: > From: Tom Warren > > The Jetson Nano Developer Kit is a Tegra X1-based development board. > It is similar to Jetson TX1 but it is not pin compatible. It features > 4GB of LPDDR4, a SPI NOR flash for early boot firmware and an SD card > slot used for storage. > > HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB > 2.0 and 1 USB 3.0) can be used to attach a variety of peripherals and > a PCI Ethernet controller provides onboard network connectivity. NVMe > support has also been added. Env save is at the end of QSPI (4MB-8K). > > A 40-pin header on the board can be used to extend the capabilities > and exposed interfaces of the Jetson Nano. > arch/arm/dts/tegra210-p3450-.dts | 147 > + This filename is consistent with other DT filenames in U-Boot, but there's been a movement downstream to name DT after baseboard plus module rather than combination, so tegra210-p3449-+p3448-.dts. Either is probably fine for now since this board was released before the push towards the more descriptive naming. [Tom] I'll stick with this naming, someone can float a change to move all Tegra boards to module+baseboard naming later if we so choose. This fits in the current U-Boot naming scheme. > diff --git a/arch/arm/mach-tegra/board2.c > b/arch/arm/mach-tegra/board2.c > +#if defined(CONFIG_DISABLE_SDMMC1_EARLY) > + /* > + * Turn off (reset/disable) SDMMC1 on Nano here, before GPIO INIT. > + * We do this because earlier bootloaders have enabled power to > + * SDMMC1 on Nano, and toggling power-gpio (PZ3) in pinmux_init() > + * results in power being back-driven into the SD-card and SDMMC1 > + * HW, which is 'bad' as per the HW team. > + * > + * From the HW team: "LDO2 from the PMIC has already been set to 3.3v in > + * nvtboot/CBoot on Nano (for SD-card boot). So when U-Boot's GPIO_INIT > + * table sets PZ3 to OUT0 as per the pinmux spreadsheet, it turns off > + * the loadswitch. When PZ3 is 0 and not driving, essentially the SDCard > + * voltage turns off. Since the SDCard voltage is no longer there, the > + * SDMMC CLK/DAT lines are backdriving into what essentially is a > + * powered-off SDCard, that's why the voltage drops from 3.3V to ~1.6V" > + * > + * Note that this can probably be removed when we change over to storing > + * all BL components on QSPI on Nano, and U-Boot then becomes the first > + * one to turn on SDMMC1 power. Another fix would be to have CBoot > + * disable power/gate SDMMC1 off before handing off to U-Boot/kernel. > + */ > + reset_set_enable(PERIPH_ID_SDMMC1, 1); > + clock_set_enable(PERIPH_ID_SDMMC1, 0); > +#endif /* CONFIG_DISABLE_SDMMC1_EARLY */ I imagine we can remove this completely now that cboot does 100% of the pinmux init, so the referenced pinmux_init() function in U-Boot no longer causes a problem? [Tom] That's a good point, but I'll have to engage w/the HW team to see if they can set up to measure the SD-card signals again w/o this change to see if the back-driving is gone. I'd like to leave it in, though, as a precaution so we don't damage anyone's SD-cards. If/when we can re-measure it, I can float a new patch to remove the SDMMC1_EARLY switch and/or just remove this code entirely. > diff --git a/board/nvidia/p3450-/p3450-.c > b/board/nvidia/p3450-/p3450-.c > +static void ft_carveout_setup(void *fdt) If/when we upstream the DT node/property copying feature, can this code be replaced by simply adding extra nodes/properties to the copy list? [Tom] Good question, I'll look into it. I still need to finesse the FDT copy feature a bit, I'll look at it then. > diff --git a/configs/p3450-_defconfig > b/configs/p3450-_defconfig > +CONFIG_DISABLE_SDMMC1_EARLY=y We can drop this assuming the code chunk I commented on above gets dropped. [Tom] When I can get the HW team to re-measure SD card voltages w/o this I'll float a patch to remove it, assuming it looks good. > +CONFIG_NVME=y Does this work already? I thought it was still under development for Tegra. [Tom] Yep, I bought a M.2 E key -> M.2 NVMe adapter for Nano & put a WD Black NVMe stick in it, and I can see/read/write the NVMe device in U-Boot using the 'nvme' commands. And it visible in the kernel. So for T210, it works (in U-Boot). Supporting NVMe in other bootloaders/SoCs that don’t use U-Boot is still a WIP. --nvpublic
RE: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support
-Original Message- From: Tom Rini Sent: Wednesday, March 25, 2020 11:26 AM To: Tom Warren Cc: Peter Robinson ; u-boot@lists.denx.de; Stephen Warren ; Thierry Reding ; Jonathan Hunter ; tomcwarren3...@gmail.com Subject: Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support On Wed, Mar 25, 2020 at 06:24:43PM +, Tom Warren wrote: > > That is strange, please re-post them and we'll see what happens. If they > > don't show up right away I can poke people. Thanks! > > Just resent the Nano patch via: > > git send-email 0001*.patch --to u-boot@lists.denx.de --confirm always > --annotate --from tomcwarren3...@gmail.com --cc swar...@nvidia.com > --cc tred...@nvidia.com --cc jonath...@nvidia.com --cc > twar...@nvidia.com > > This time I used my Gmail address in 'from' and put my work address in 'cc'. > > Let's see if it shows up in Patchwork. There's http://patchwork.ozlabs.org/patch/1261582/ now, just that one patch? [Tom] yes, the one I resent above, but using my gmail address (tomcwarren3959) instead of my work address (twar...@nvidia.com). Any idea why that would make any difference? I'll work on resending the others using that address. -- Tom --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support
> That is strange, please re-post them and we'll see what happens. If they > don't show up right away I can poke people. Thanks! Just resent the Nano patch via: git send-email 0001*.patch --to u-boot@lists.denx.de --confirm always --annotate --from tomcwarren3...@gmail.com --cc swar...@nvidia.com --cc tred...@nvidia.com --cc jonath...@nvidia.com --cc twar...@nvidia.com This time I used my Gmail address in 'from' and put my work address in 'cc'. Let's see if it shows up in Patchwork. Tom -Original Message- From: Tom Rini Sent: Wednesday, March 25, 2020 10:56 AM To: Tom Warren Cc: Peter Robinson ; u-boot@lists.denx.de; Stephen Warren ; Thierry Reding ; Jonathan Hunter ; tomcwarren3...@gmail.com Subject: Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support On Wed, Mar 25, 2020 at 05:44:25PM +0000, Tom Warren wrote: > -Original Message- > From: Peter Robinson > Sent: Wednesday, March 25, 2020 5:53 AM > To: Tom Warren > Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry > Reding ; Jonathan Hunter ; > tomcwarren3...@gmail.com > Subject: Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit > support > > External email: Use caution opening links or attachments > > > Hi Tom, > > Do you have this and the other patches you've posted on a git branch > somewhere, for some reason they're not showing up in patchwork [1] which > makes it less straight forward to test. > > Peter > [1] http://patchwork.ozlabs.org/project/uboot/list/?q=tegra > > [Tom] That's weird, I sent them all using git send-email to > u-boot@lists.denx.de. But you are right, I don't see any of them on > Patchwork. TomR - any idea why? That is strange, please re-post them and we'll see what happens. If they don't show up right away I can poke people. Thanks! -- Tom --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support
-Original Message-
From: Peter Robinson
Sent: Wednesday, March 25, 2020 5:53 AM
To: Tom Warren
Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding
; Jonathan Hunter ;
tomcwarren3...@gmail.com
Subject: Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support
External email: Use caution opening links or attachments
Hi Tom,
Do you have this and the other patches you've posted on a git branch somewhere,
for some reason they're not showing up in patchwork [1] which makes it less
straight forward to test.
Peter
[1] http://patchwork.ozlabs.org/project/uboot/list/?q=tegra
[Tom] That's weird, I sent them all using git send-email to
u-boot@lists.denx.de. But you are right, I don't see any of them on Patchwork.
TomR - any idea why?
Peter - you can find all of the patches (plus a WIP fix for a couple of load
address conflicts when loading an FDT from extlinux) in tegra/next upstream,
just updated today.
On Tue, Mar 24, 2020 at 7:03 PM wrote:
>
> From: Tom Warren
>
> The Jetson Nano Developer Kit is a Tegra X1-based development board.
> It is similar to Jetson TX1 but it is not pin compatible. It features
> 4GB of LPDDR4, a SPI NOR flash for early boot firmware and an SD card
> slot used for storage.
>
> HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB
> 2.0 and 1 USB 3.0) can be used to attach a variety of peripherals and
> a PCI Ethernet controller provides onboard network connectivity. NVMe
> support has also been added. Env save is at the end of QSPI (4MB-8K).
>
> A 40-pin header on the board can be used to extend the capabilities
> and exposed interfaces of the Jetson Nano.
>
> Signed-off-by: Thierry Reding
> Signed-off-by: Tom Warren
> ---
> arch/arm/dts/Makefile| 3 +-
> arch/arm/dts/tegra210-p3450-.dts | 147 +
> arch/arm/mach-tegra/board2.c | 25 +
> arch/arm/mach-tegra/tegra210/Kconfig | 7 ++
> board/nvidia/p3450-/Kconfig | 12 +++
> board/nvidia/p3450-/MAINTAINERS | 6 ++
> board/nvidia/p3450-/Makefile | 8 ++
> board/nvidia/p3450-/p3450-.c | 178
> +++
> configs/p3450-_defconfig | 64 +
> include/configs/p3450-.h | 46 +
> 10 files changed, 495 insertions(+), 1 deletion(-) create mode
> 100644 arch/arm/dts/tegra210-p3450-.dts
> create mode 100644 board/nvidia/p3450-/Kconfig create mode
> 100644 board/nvidia/p3450-/MAINTAINERS
> create mode 100644 board/nvidia/p3450-/Makefile create mode
> 100644 board/nvidia/p3450-/p3450-.c
> create mode 100644 configs/p3450-_defconfig create mode 100644
> include/configs/p3450-.h
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> 9c593b2..820ee97 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -180,7 +180,8 @@ dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
> tegra210-e2220-1170.dtb \
> tegra210-p2371-.dtb \
> tegra210-p2371-2180.dtb \
> - tegra210-p2571.dtb
> + tegra210-p2571.dtb \
> + tegra210-p3450-.dtb
>
> dtb-$(CONFIG_ARCH_MVEBU) +=\
> armada-3720-db.dtb \
> diff --git a/arch/arm/dts/tegra210-p3450-.dts
> b/arch/arm/dts/tegra210-p3450-.dts
> new file mode 100644
> index 000..9ef744a
> --- /dev/null
> +++ b/arch/arm/dts/tegra210-p3450-.dts
> @@ -0,0 +1,147 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2019-2020 NVIDIA Corporation */
> +/dts-v1/;
> +
> +#include "tegra210.dtsi"
> +
> +/ {
> + model = "NVIDIA Jetson Nano Developer Kit";
> + compatible = "nvidia,p3450-", "nvidia,tegra210";
> +
> + chosen {
> + stdout-path =
> + };
> +
> + aliases {
> + ethernet = "/pcie@1003000/pci@2,0/ethernet@0,0";
> + i2c0 = "/i2c@7000d000";
> + i2c2 = "/i2c@7000c400";
> + i2c3 = "/i2c@7000c500";
> + i2c4 = "/i2c@7000c700";
> + mmc0 = "/sdhci@700b0600";
> + mmc1 = "/sdhci@700b";
> + spi0 = "/spi@7041";
> + usb0 = "/usb@7d00";
> + };
> +
> + memory {
> + reg = <0x0 0x8000 0x0 0xc000>;
> + };
> +
> + pcie@1003000 {
> + status = "okay";
> +
> + pci@1,0 {
> + status = "okay";
> +
RE: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot
-Original Message- From: Thierry Reding Sent: Thursday, March 19, 2020 1:04 AM To: Tom Warren Cc: u-boot@lists.denx.de; Stephen Warren ; Jonathan Hunter ; tomcwarren3...@gmail.com Subject: Re: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot On Tue, Mar 17, 2020 at 01:07:15PM -0700, twar...@nvidia.com wrote: > From: Tom Warren > > This is a WAR for DHCP failure after rebooting from the L4T kernel. > The r8169.c kernel driver is setting bit 19 of the rt816x HW register > 0xF0, which goes by FuncEvent and MISC in various driver source/datasheets. > That bit is called RxDv_Gated_En in the r8169.c kernel driver. Clear > it here at the end of probe to ensure that U-Boot can get an IP > assigned via DHCP. > > Signed-off-by: Tom Warren > --- > drivers/net/rtl8169.c | 16 > 1 file changed, 16 insertions(+) Is this still needed? In my old p3450 branch that I worked on to get Porg up and running I don't have this patch. It's also not in my local development tree that I typically use to boot Tegra186 and earlier boards. That branch works fine on the Jetson Nano, so I don't think this is needed anymore. I vaguely recall that I determined that this was fixed some other way, but unfortunately I don't remember the exact details. Thierry [Tom] I'll retest as part of my Nano rework of your original patch, Thierry. So you've done network boot, then rebooted from the kernel (sudo reboot), and attempted net boot again and seen it work OK, w/an IP assigned by DHCP, etc.? (not static IP). It's also possible that something in the kernel RT8169 driver has changed, and it's not setting the bit anymore. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH 2/2] tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all boards
-Original Message- From: Stephen Warren Sent: Wednesday, March 18, 2020 4:31 PM To: Tom Warren Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding ; Jonathan Hunter ; tomcwarren3...@gmail.com Subject: Re: [PATCH 2/2] tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all boards External email: Use caution opening links or attachments On 3/17/20 2:07 PM, twar...@nvidia.com wrote: > From: Tom Warren > > This allows the user to set $serverip in the environment before > executing a DHCP request. If they do, U-Boot will use that IP rather > than using the IP in the DHCP response. Acked-by: Stephen Warren I wonder if this should be applied to more Tegra boards, so they all work consistently? E.g. T20/30/114/124 boards. [Tom] I can certainly do that, but I don't really test on anything
RE: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot
-Original Message-
From: Stephen Warren
Sent: Wednesday, March 18, 2020 4:30 PM
To: Tom Warren
Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding
; Jonathan Hunter ;
tomcwarren3...@gmail.com
Subject: Re: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel
boot/reboot
External email: Use caution opening links or attachments
On 3/17/20 2:07 PM, twar...@nvidia.com wrote:
> From: Tom Warren
>
> This is a WAR for DHCP failure after rebooting from the L4T kernel.
> The r8169.c kernel driver is setting bit 19 of the rt816x HW register
> 0xF0, which goes by FuncEvent and MISC in various driver source/datasheets.
> That bit is called RxDv_Gated_En in the r8169.c kernel driver. Clear
> it here at the end of probe to ensure that U-Boot can get an IP
> assigned via DHCP.
Is there a way to reset the entire chip back to power-on state instead, just to
make sure there aren't any other register bits that might cause issues in the
future?
[Tom] Maybe, I'll have to look at the RTL spec, it's been awhile since I came
up with this WAR.
Does this bit exist in all the different chips that the driver supports?
IIRC at least the Linux r8169 driver supports many different similar chips; I'm
not sure if the U-Boot driver does too. Since this driver is shared between
many boards in U-Boot, we need to make sure this change doesn't break anyone
using a different Realtek chip to the exact one we use on Jetson.
[Tom] I'll look into it after I get Nano patches all in place upstream. If
anyone runs into the problem described here w/no IP on net boot, they can use
this as a WAR until I try for a more robust fix.
We need to send this patch to the network maintainers so they're aware of it,
and they'll probably want to apply it.
[Tom] Will do.
> @@ -1207,6 +1210,19 @@ static int rtl8169_eth_probe(struct udevice
> *dev)
> + u32 val = RTL_R32(FuncEvent);
> + debug("%s: FuncEvent/Misc (0xF0) = 0x%08X\n", __func__, val);
> + val &= ~RxDv_Gated_En;
> + RTL_W32(FuncEvent, val);
I vagueley recall that U-Boot coding style wants variables declared at the
start of the block, but perhaps that's no longer true. What does
scripts/checkpatch.pl say?
[Tom] I don't recall, I'll run it again and see.
---
This email message is for the sole use of the intended recipient(s) and may
contain
confidential information. Any unauthorized review, use, disclosure or
distribution
is prohibited. If you are not the intended recipient, please contact the
sender by
reply email and destroy all copies of the original message.
---
RE: [PATCH] t210: pinmux: Remove pinmux/GPIO init from T210 boards
-Original Message- From: Stephen Warren Sent: Wednesday, March 18, 2020 4:14 PM To: Tom Warren Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding ; Jonathan Hunter ; tomcwarren3...@gmail.com Subject: Re: [PATCH] t210: pinmux: Remove pinmux/GPIO init from T210 boards External email: Use caution opening links or attachments On 3/17/20 3:55 PM, twar...@nvidia.com wrote: > From: Tom Warren > > T210 CBoot is now doing the full pinmux and GPIO init, based on the > DTB tables. Remove pinmux/GPIO init tables & code from all T210-based > builds > below: > > p2371-2180 aka TX1 > p2371- > e2220-1170 > p2571 Acked-by: Stephen Warren It may be worth updating the commit description to mention explicitly which L4T release's FW is required when using a U-Boot that has this patch applied. [Tom] I'll do that for v2, thanks. Can we remove the T210 pinmux driver from U-Boot with this patch applied? [Tom] Good idea, I'll look at it. Seems like it should work if I excise arch/arm/mach-tegra/pinmux.c. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH 1/2] mmc: t210: Add autocal and tap/trim updates for SDMMC1/3
[Tom] see below
-Original Message-
From: Jaehoon Chung
Sent: Tuesday, March 17, 2020 4:48 PM
To: Tom Warren ; u-boot@lists.denx.de
Subject: Re: [PATCH 1/2] mmc: t210: Add autocal and tap/trim updates for
SDMMC1/3
External email: Use caution opening links or attachments
On 3/17/20 6:59 AM, twar...@nvidia.com wrote:
> From: Tom Warren
>
> As per the T210 TRM, when running at 3.3v, the SDMMC1 tap/trim and
> autocal values need to be set to condition the signals correctly
> before talking to the SD-card. This is the same as what's being done
> in CBoot, but it gets reset when the SDMMC1 HW is soft-reset during SD
> driver init, so needs to be repeated here. Also set autocal and
> tap/trim for SDMMC3, although no T210 boards use it for SD-card at this time.
>
> Signed-off-by: Tom Warren
> ---
> arch/arm/include/asm/arch-tegra/tegra_mmc.h | 20 +--
> drivers/mmc/tegra_mmc.c | 84
> ++---
> 2 files changed, 92 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-tegra/tegra_mmc.h
> b/arch/arm/include/asm/arch-tegra/tegra_mmc.h
> index a2b6f63..a8bfa46 100644
> --- a/arch/arm/include/asm/arch-tegra/tegra_mmc.h
> +++ b/arch/arm/include/asm/arch-tegra/tegra_mmc.h
> @@ -2,7 +2,7 @@
> /*
> * (C) Copyright 2009 SAMSUNG Electronics
> * Minkyu Kang
> - * Portions Copyright (C) 2011-2012 NVIDIA Corporation
> + * Portions Copyright (C) 2011-2012,2019 NVIDIA Corporation
> */
>
> #ifndef __TEGRA_MMC_H_
> @@ -52,7 +52,7 @@ struct tegra_mmc {
> unsigned char admaerr;/* offset 54h */
> unsigned char res4[3];/* RESERVED, offset 55h-57h */
> unsigned long admaaddr; /* offset 58h-5Fh */
> - unsigned char res5[0xa0]; /* RESERVED, offset 60h-FBh */
> + unsigned char res5[0x9c]; /* RESERVED, offset 60h-FBh */
Is comment right? "RESERVED, offset 60h-FBh"..
[Tom] yes, the comment was/is correct, it's the number of reserved bytes that
was wrong - 0x9C is correct.
> unsigned short slotintstatus; /* offset FCh */
> unsigned short hcver; /* HOST Version */
> unsigned intvenclkctl; /* _VENDOR_CLOCK_CNTRL_0,100h */
> @@ -127,11 +127,23 @@ struct tegra_mmc {
>
> #define TEGRA_MMC_NORINTSIGEN_XFER_COMPLETE (1 << 1)
>
> -/* SDMMC1/3 settings from section 24.6 of T30 TRM */
> +/* SDMMC1/3 settings from SDMMCx Initialization Sequence of TRM */
> #define MEMCOMP_PADCTRL_VREF 7
> -#define AUTO_CAL_ENABLED (1 << 29)
> +#define AUTO_CAL_ENABLE (1 << 29)
> +#if defined(CONFIG_TEGRA210)
> +#define AUTO_CAL_ACTIVE (1 << 31)
> +#define AUTO_CAL_START (1 << 31)
> +#define AUTO_CAL_PD_OFFSET (0x7D << 8)
> +#define AUTO_CAL_PU_OFFSET (0 << 0)
> +#define IO_TRIM_BYPASS_MASK (1 << 2)
> +#define TRIM_VAL_SHIFT 24
> +#define TRIM_VAL_MASK(0x1F << TRIM_VAL_SHIFT)
> +#define TAP_VAL_SHIFT16
> +#define TAP_VAL_MASK (0xFF << TAP_VAL_SHIFT)
> +#else
> #define AUTO_CAL_PD_OFFSET (0x70 << 8)
> #define AUTO_CAL_PU_OFFSET (0x62 << 0)
> +#endif
>
> #endif /* __ASSEMBLY__ */
> #endif /* __TEGRA_MMC_H_ */
> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c index
> f022e93..a4bd679 100644
> --- a/drivers/mmc/tegra_mmc.c
> +++ b/drivers/mmc/tegra_mmc.c
> @@ -3,7 +3,7 @@
> * (C) Copyright 2009 SAMSUNG Electronics
> * Minkyu Kang
> * Jaehoon Chung
> - * Portions Copyright 2011-2016 NVIDIA Corporation
> + * Portions Copyright 2011-2019 NVIDIA Corporation
> */
>
> #include
> @@ -15,6 +15,9 @@
> #include
> #include #include
> +#if defined(CONFIG_TEGRA210)
> +#include
> +#endif
>
> struct tegra_mmc_plat {
> struct mmc_config cfg;
> @@ -30,6 +33,7 @@ struct tegra_mmc_priv {
> struct gpio_desc wp_gpio; /* Write Protect GPIO */
> unsigned int version; /* SDHCI spec. version */
> unsigned int clock; /* Current clock (MHz) */
> + int mmc_id; /* peripheral id */
> };
>
> static void tegra_mmc_set_power(struct tegra_mmc_priv *priv, @@
> -446,16 +450,19 @@ static int tegra_mmc_set_ios(struct udevice *dev)
>
> static void tegra_mmc_pad_init(struct tegra_mmc_priv *priv) { -#if
> defined(CONFIG_TEGRA30)
> +#if defined(CONFIG_TEGRA30) || defined(CONFIG_TEGRA210)
> u32 val;
> + u16 clk_con;
> + int timeout;
> + int id = priv->mmc_id;
>
> - debug("%s: sdmmc address = %08x\n", __func__, (unsigned int)priv->reg);
>
RE: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one
-Original Message- From: Tom Warren Sent: Tuesday, March 17, 2020 10:43 AM To: Stephen Warren Cc: u-boot@lists.denx.de; Stephen Warren ; tomcwarren3...@gmail.com Subject: RE: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one -Original Message- From: Stephen Warren Sent: Tuesday, March 17, 2020 10:18 AM To: Tom Warren Cc: u-boot@lists.denx.de; Stephen Warren Subject: Re: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one External email: Use caution opening links or attachments On 3/17/20 11:16 AM, Stephen Warren wrote: > On 3/16/20 1:40 PM, twar...@nvidia.com wrote: >> From: Stephen Warren >> >> Reword fdt_serial_tag_setup_one() so that the types it uses aren't >> tied to CONFIG_SERIAL_TAG, and rename the function to better indicate >> its purpose. This will allow it to be re-used by future board info >> related code. > >> arch/arm/mach-tegra/ft_board_info.c | 77 >> + >> arch/arm/mach-tegra/ft_board_info.h | 23 +++ > > I don't think this series was based on upstream, or there are missing > patches in between upstream and this series; those files don't exist > upstream. Oh. This patch adds those files. But the commit description says it's reworking some existing logic. I guess the description is from some squashed patch, and doesn't describe what the patch actually does? Also, the new file isn't added to any Makefile, and no edits are made to any other file in order to call the newly added functionality. [Tom] Yeah, this got messed up when I squashed/edited the transition from nvtboot to cboot support files in arch/arm/mach-tegra. I'll have to revisit this, as the code isn't called anywhere currently in my upstream work, nor build by a Makefile. [Tom] OK, so this work (adding board info (proc/pmu/display) is already done by CBoot on T210 before we get to U-Boot, so it's not needed. Mea culpa - lots of churn w/these patches, trying to get them squashed/optimized for upstreaming, and I mistakenly kept this one around from the nvtboot->U-Boot days. I'll drop it. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH 5/5] ARM: Tegra: Use calc env var feature on all boards
-Original Message- From: Stephen Warren Sent: Tuesday, March 17, 2020 10:38 AM To: Tom Warren Cc: u-boot@lists.denx.de Subject: Re: [PATCH 5/5] ARM: Tegra: Use calc env var feature on all boards External email: Use caution opening links or attachments On 3/16/20 1:40 PM, twar...@nvidia.com wrote: > From: Tom Warren > > Large kernels (>32MB) can fail to boot because they overwrite the FDT > address, corrupting the DTB. Stephen Warren had created a fix to > dynamically adjust the fdt/ramdisk/pxefile/kernel addr vars at boot > time for T186, which allows a large kernel to load and boot. That was actually done to support holes in the RAM map; it's not actually required in order to support large kernels at all. We could just as easily directly modify the existing hard-coded load addresses. > This is based on his commit, but applied to the tegraXXX-common.h > headers so it's used on all T186 and T210 Jetson boards. Note that > I've put the kernel 'size' param at 0x0300, or 48MB, to leave room > for kernel growth. Current L4T kernels are running at about 32MB. I had completely forgotten that we had the calculated env vars feature upstream already! I thought we went with 96 or 128MB space for the kernel downstream, to make sure there'd "never" any future problem as the kernel grows? But this patch seems OK for now I guess. [Tom] Yes, we have a large (128MB) kernel size in downstream L4T U-Boot, but only because of the need to test GCOV kernels - I didn't think that excessive allocation was required upstream, so I backed it off to 48MB. As to your point about just fixing the hard-coding of the kernel/ramdisk/fdt_addr_r in T210, I can do that, but it seemed more elegant and future-proof to use the calc env vars code you'd added for T186, plus it brings the two builds in sync, using the same allocation strategy for these 'load' vars. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH 4/5] fdt: Fix 'system' command
-Original Message- From: Stephen Warren Sent: Tuesday, March 17, 2020 10:33 AM To: Tom Warren Cc: u-boot@lists.denx.de Subject: Re: [PATCH 4/5] fdt: Fix 'system' command External email: Use caution opening links or attachments On 3/16/20 1:40 PM, twar...@nvidia.com wrote: > From: Tom Warren > > 'fdt systemsetup' wasn't working, due to the fact that the 'set' > command was being parsed in do_fdt() by only testing for the leading > 's' instead of "se", which kept the "sys" test further down from > executing. Changed to test for "se" instead, now 'fdt systemsetup' > works (to test the ft_system_setup proc w/o having to boot a kernel). Reviewed-by: Stephen Warren (Although I wonder if this shouldn't just test the entire string to avoid any possible future ambiguity if more sub-commands are added later. Or doesn't U-Boot already have some sub-command table infra-structure this could use?) [Tom] I usually take the path of least rework approach, so I just fixed the systemsetup command, which is what I was interested in. Let's see if any other Denxians chime in w/their opinion, and I can rework it if needed. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH 2/5] t210: do not enable PLLE and UPHY PLL HW PWRSEQ
-Original Message- From: Stephen Warren Sent: Tuesday, March 17, 2020 10:30 AM To: Tom Warren Cc: u-boot@lists.denx.de; Jui Chang Kuo Subject: Re: [PATCH 2/5] t210: do not enable PLLE and UPHY PLL HW PWRSEQ External email: Use caution opening links or attachments On 3/16/20 1:40 PM, twar...@nvidia.com wrote: > From: JC Kuo > > This commit removes the programming sequence that enables PLLE and > UPHY PLL hardware power sequencers. Per TRM, boot software should > enable PLLE and UPHY PLLs in software controlled power-on state and > should power down PLL before jumping into kernel or the next stage boot > software. > > Adds call to board_cleanup_before_linux to facilitate this. This directly contradicts what's in Tegra_X1_TRM_DP07225001_v1.3p.pdf, pages 1340/1341, which is what the code currently implements. Was a newer internal-only TRM published that changed the recommended programming flow? [Tom] JC wrote this, I'll let him answer, but I'll check my TRM to see what the most recent version is. This code is exactly what we have in downstream T210 U-Boot. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
RE: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one
-Original Message- From: Stephen Warren Sent: Tuesday, March 17, 2020 10:18 AM To: Tom Warren Cc: u-boot@lists.denx.de; Stephen Warren Subject: Re: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one External email: Use caution opening links or attachments On 3/17/20 11:16 AM, Stephen Warren wrote: > On 3/16/20 1:40 PM, twar...@nvidia.com wrote: >> From: Stephen Warren >> >> Reword fdt_serial_tag_setup_one() so that the types it uses aren't >> tied to CONFIG_SERIAL_TAG, and rename the function to better indicate >> its purpose. This will allow it to be re-used by future board info >> related code. > >> arch/arm/mach-tegra/ft_board_info.c | 77 >> + >> arch/arm/mach-tegra/ft_board_info.h | 23 +++ > > I don't think this series was based on upstream, or there are missing > patches in between upstream and this series; those files don't exist > upstream. Oh. This patch adds those files. But the commit description says it's reworking some existing logic. I guess the description is from some squashed patch, and doesn't describe what the patch actually does? Also, the new file isn't added to any Makefile, and no edits are made to any other file in order to call the newly added functionality. [Tom] Yeah, this got messed up when I squashed/edited the transition from nvtboot to cboot support files in arch/arm/mach-tegra. I'll have to revisit this, as the code isn't called anywhere currently in my upstream work, nor build by a Makefile. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ---
Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. The following changes since commit 88366b96ee0d8640b2af53e4026dbaeed0fab5e0: travis: Switch to QEMU v4.2.0 globally (2020-01-11 08:07:03 -0500) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to fddfe8735908553c26dff221cb154c8d7ddab463: tegra: fdt: Add tegra186-u-boot.dtsi (2020-01-14 10:35:19 -0700) Stephen Warren (1): tegra: fdt: Add tegra186-u-boot.dtsi arch/arm/dts/tegra186-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 arch/arm/dts/tegra186-u-boot.dtsi
RE: [PATCH] tegra: fdt: Add tegra186-u-boot.dtsi
I'll apply it and try to get a PR out today, sorry for the delay.
-Original Message-
From: Stephen Warren
Sent: Tuesday, January 14, 2020 9:59 AM
To: Tom Rini ; Simon Glass
Cc: u-boot@lists.denx.de; Stephen Warren ; Tom Warren
Subject: Re: [PATCH] tegra: fdt: Add tegra186-u-boot.dtsi
External email: Use caution opening links or attachments
On 1/7/20 11:17 AM, Stephen Warren wrote:
> From: Stephen Warren
>
> All Tegra chips except Tegra186 have a tegraNNN-u-boot.dtsi. Duplicate
> Tegra210's copy of this file for Tegra186. This ensures that a /binman
> node exists in U-Boot's control DT. Subsequent to 3c10dc95bdd0
> ("binman: Add a library to access binman entries") this appears to be
> required. I haven't really investigated why all this is necessary or
> how it works, but simply observed the boot failure listed below,
> bisected it, noticed the inconsistency in DT files, and found that
> fixing it resolved the boot issue.
>
> U-Boot 2020.01-rc4-00256-g3c10dc95bdd0 (Jan 07 2020 - 10:25:00
> -0700)
>
> SoC: tegra186
> Model: NVIDIA P2771--500
> Board: NVIDIA P2771-
> DRAM: 7.8 GiB
> initcall sequence fffb7858 failed at call 800955a8
> (err=-22)
> ### ERROR ### Please RESET the board ###
>
> Fixes: 3c10dc95bdd0 ("binman: Add a library to access binman entries")
> Fixes: f2faffecb016 ("binman: tegra: Convert to use binman")
> Signed-off-by: Stephen Warren
Can we please apply this? All Tegra186 systems (i.e. Jetson TX2) can't boot
without this patch. Thank.s
---
This email message is for the sole use of the intended recipient(s) and may
contain
confidential information. Any unauthorized review, use, disclosure or
distribution
is prohibited. If you are not the intended recipient, please contact the
sender by
reply email and destroy all copies of the original message.
---
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK on my system, and Igor has verified the Apalis patches. The following changes since commit 163bc1e4da425015000dd3f8f128aec994da9586: Merge tag 'mmc-8-9' of https://gitlab.denx.de/u-boot/custodians/u-boot-mmc (2019-08-09 07:29:54 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to bd20266d1923f1230ed15020fbb12aa56f3f46b7: apalis-tk1: configs: remove legacy usbboot command (2019-08-09 10:01:35 -0700) Dominik Sliwa (2): apalis-tk1/t30: colibri_t30: display reset reason apalis-tk1: remove non-essential power rails on boot Igor Opaniuk (7): colibri/apalis tegra: drop DFU support apalis-tk1: set apalis gpio 8 aka fan_en apalis-tk1: provide proper USB vendor id apalis-tk1: enable user debug by default apalis-tk1: add pcie_aspm=off to defargs apalis-tk1: switch to zImage apalis-tk1: configs: remove legacy usbboot command Marcel Ziswiler (3): apalis-tk1: do not explicitly release reset_moci# apalis-tk1: remove default vesa vga mode from vidargs apalis-tk1: support v1.2 hardware revision Simon Glass (3): sound: snow: Add the binding file for snow sound: tegra: Add the binding file for tegra-audio sound: Add codec enable to the sound bindings Trent Piepho (1): mmc: Move tegra loopback disable option to be under tegra arch/arm/dts/tegra124-apalis.dts | 89 -- arch/arm/mach-tegra/sys_info.c | 32 +--- arch/arm/mach-tegra/tegra124/cpu.c | 45 +++ board/toradex/apalis-tk1/apalis-tk1.c | 47 board/toradex/apalis-tk1/as3722_init.c | 23 ++ .../toradex/apalis-tk1/pinmux-config-apalis-tk1.h | 21 +++-- configs/apalis-tk1_defconfig | 7 +- configs/apalis_t30_defconfig | 3 - configs/colibri_t20_defconfig | 3 - configs/colibri_t30_defconfig | 3 - doc/device-tree-bindings/sound/intel-hda.txt | 1 + .../sound/nvidia,tegra-audio-max98090.txt | 54 + doc/device-tree-bindings/sound/snow.txt| 32 drivers/mmc/Kconfig| 22 +++--- include/configs/apalis-tk1.h | 44 --- 15 files changed, 310 insertions(+), 116 deletions(-) create mode 100644 doc/device-tree-bindings/sound/nvidia,tegra-audio-max98090.txt create mode 100644 doc/device-tree-bindings/sound/snow.txt ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1] apalis-tk1: support v1.2 hardware revision
Igor,
-Original Message-
From: Igor Opaniuk
Sent: Friday, August 9, 2019 3:38 AM
To: Tom Warren
Cc: Marcel Ziswiler ; Philippe Schenker
; Oleksandr Suvorov
; Dominik Sliwa ;
Igor Opaniuk ; Albert Aribaud
; Thierry Reding ; U-Boot
Mailing List
Subject: Re: [PATCH v1] apalis-tk1: support v1.2 hardware revision
Hi Tom,
On Fri, Aug 9, 2019 at 1:22 PM Igor Opaniuk wrote:
>
> From: Marcel Ziswiler
>
> Support the V1.2 hardware revision with the following pin muxing
> changes:
>
> Ddc_scl_pv4 and ddc_sda_pv5 previously used as Apalis GPIO3 and GPIO4
> are now used as DDC pins.
>
> Gen2_i2c_scl_pt5 and gen2_i2c_sda_pt6 previously used as DDC pins are
> now used as USB power enable signals.
>
> Usb_vbus_en0_pn4 and usb_vbus_en1_pn5 previously used as USB power
> enable signals are now used as GPIO3 and GPIO4.
>
> Additionally a new device tree file tegra124-apalis-v1.2-eval.dtb is
> loaded on V1.2 and later modules and resp. USB power enable signals
> activated.
>
> Signed-off-by: Marcel Ziswiler
> Signed-off-by: Igor Opaniuk
> ---
>
> arch/arm/dts/tegra124-apalis.dts | 89 ++-
> board/toradex/apalis-tk1/apalis-tk1.c | 37
> .../apalis-tk1/pinmux-config-apalis-tk1.h | 19 ++--
> configs/apalis-tk1_defconfig | 2 +-
> include/configs/apalis-tk1.h | 12 ++-
> 5 files changed, 103 insertions(+), 56 deletions(-)
>
> diff --git a/arch/arm/dts/tegra124-apalis.dts
> b/arch/arm/dts/tegra124-apalis.dts
> index a962c0a2f0..08184ab3ac 100644
> --- a/arch/arm/dts/tegra124-apalis.dts
> +++ b/arch/arm/dts/tegra124-apalis.dts
> @@ -1,5 +1,5 @@
> /*
> - * Copyright 2016 Toradex AG
> + * Copyright 2016-2019 Toradex AG
> *
> * This file is dual-licensed: you can use it either under the terms
> * of the GPL or the X11 license, at your option. Note that this dual
> @@ -230,19 +230,21 @@
> };
>
> /* Apalis GPIO */
> - ddc_scl_pv4 {
> - nvidia,pins = "ddc_scl_pv4";
> + usb_vbus_en0_pn4 {
> + nvidia,pins = "usb_vbus_en0_pn4";
> nvidia,function = "rsvd2";
> nvidia,pull = ;
> nvidia,tristate = ;
> nvidia,enable-input =
> ;
> + nvidia,open-drain =
> + ;
> };
> - ddc_sda_pv5 {
> - nvidia,pins = "ddc_sda_pv5";
> + usb_vbus_en1_pn5 {
> + nvidia,pins = "usb_vbus_en1_pn5";
> nvidia,function = "rsvd2";
> nvidia,pull = ;
> nvidia,tristate = ;
> nvidia,enable-input =
> ;
> + nvidia,open-drain =
> + ;
> };
> pex_l0_rst_n_pdd1 {
> nvidia,pins = "pex_l0_rst_n_pdd1"; @@
> -333,40 +335,40 @@
> nvidia,open-drain = ;
> };
>
> - /* Apalis I2C2 (DDC) */
> - gen2_i2c_scl_pt5 {
> - nvidia,pins = "gen2_i2c_scl_pt5";
> - nvidia,function = "i2c2";
> + /* Apalis I2C3 (CAM) */
> + cam_i2c_scl_pbb1 {
> + nvidia,pins = "cam_i2c_scl_pbb1";
> + nvidia,function = "i2c3";
> nvidia,pull = ;
> nvidia,tristate = ;
> nvidia,enable-input = ;
> nvidia,open-drain = ;
> };
> - gen2_i2c_sda_pt6 {
> - nvidia,pins = "gen2_i2c_sda_pt6";
> - nvidia,function = "i2c2";
> + cam_i2c_sda_pbb2 {
> + nvidia,pins = "cam_i2c_sda_pbb2";
> + nvidia,function = "i2c3";
> nvidia,pull = ;
> nvidia,tristate = ;
> nvidia,enable-input = ;
> nvidia,open-drain = ;
>
[U-Boot] binman failures for uboot_video-master and tegra-master builds
We're seeing a lot of this lately in our test frame builds: COPYspl/u-boot-spl.bin BINMAN u-boot-tegra.bin binman: Unknown entry type 'u-boot-spl' in node '/binman/image1/u-boot-spl' u-boot-video/master and just recently 32-bit builds for tegra/master. I don't use binman much, and I'm not seeing those errors with my local tegra builds using MAKEALL (I know, I should move over to binman/buildman, but ...). Stephen is out on vacation. Anyone have any ideas of what could be wrong here? Tom -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1 0/9] apalis-tk1: fixes/updates for v2019.10
The 'switch to zImage' patch fails to apply using git am, either in the complete (9-patch) bundle, or as part of the 5-patch Igor Opaniuk bundle, or even as a stand-alone patch. This is using the current TOT u-boot-tegra/master. Please ensure the entire bundle of Apalis-TK1 patches can be applied to u-boot-tegra/master. Thanks, Tom -- nvpublic -Original Message- From: Igor Opaniuk Sent: Wednesday, July 31, 2019 5:05 AM To: u-boot@lists.denx.de Cc: Marcel Ziswiler ; Philippe Schenker ; Oleksandr Suvorov ; Dominik Sliwa ; Igor Opaniuk ; Albert Aribaud ; Igor Opaniuk ; Tom Warren Subject: [PATCH v1 0/9] apalis-tk1: fixes/updates for v2019.10 Misc. fixes related to pinmux configuration (fan), default bootargs, reset reason output and power rail configuration. Dominik Sliwa (2): apalis-tk1/t30: colibri_t30: display reset reason apalis-tk1: remove non-esential power rails on boot Igor Opaniuk (5): apalis-tk1: set apalis gpio 8 aka fan_en apalis-tk1: provide proper USB vendor id apalis-tk1: enable user debug by default apalis-tk1: add pcie_aspm=off to defargs apalis-tk1: switch to zImage Marcel Ziswiler (2): apalis-tk1: do not explicitly release reset_moci# apalis-tk1: remove default vesa vga mode from vidargs arch/arm/mach-tegra/sys_info.c| 32 - arch/arm/mach-tegra/tegra124/cpu.c| 45 +++ board/toradex/apalis-tk1/apalis-tk1.c | 10 + board/toradex/apalis-tk1/as3722_init.c| 23 ++ .../apalis-tk1/pinmux-config-apalis-tk1.h | 2 +- configs/apalis-tk1_defconfig | 2 +- include/configs/apalis-tk1.h | 17 +++ 7 files changed, 111 insertions(+), 20 deletions(-) -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Pull request, u-boot-tegra/master
> Thanks for explaining. Can you please add a few line summary of these > changes and I'll grab them today/tomorrow? Sure, here's Thierry's comment from the 00 patch for this series (Thierry, please comment if that's not adequate/accurate): From: Thierry Reding The bulk of these changes are an effort to unify Tegra186 builds with builds of prior 64-bit Tegra generations. On top of that there are various improvements that allow data (such as the MAC address and boot arguments) to be passed through from early firmware to the kernel on boot. Tom -Original Message- From: Tom Rini Sent: Friday, June 7, 2019 8:40 AM To: Tom Warren Cc: Tom Warren ; u-boot@lists.denx.de; Thierry Reding Subject: Re: Pull request, u-boot-tegra/master On Fri, Jun 07, 2019 at 03:28:19PM +0000, Tom Warren wrote: > Hi, Tom. > > -Original Message- > From: Tom Rini > Sent: Thursday, June 6, 2019 6:32 PM > To: Tom Warren > Cc: u-boot@lists.denx.de; Thierry Reding ; > Tom Warren > Subject: Re: Pull request, u-boot-tegra/master > > On Wed, Jun 05, 2019 at 01:50:59PM -0700, Tom Warren wrote: > > > Tom, > > > > Please pull u-boot-tegra/master into U-Boot/master. Thanks! > > > > All Tegra builds are OK, and Stephen's automated test system reports > > that all tests pass. > > > > The following changes since commit 6d93d245c148f10f15724601650fab3a665f102c: > > > > Merge git://git.denx.de/u-boot-riscv (2019-06-05 10:07:31 -0400) > > > > are available in the git repository at: > > > > git://git.denx.de/u-boot-tegra.git master > > > > for you to fetch changes up to 879a3bc1c2f3e2aadd6f05e6427cf4d97a272f9a: > > > > ARM: tegra: Mark built-in Ethernet as default on Jetson TX2 > > (2019-06-05 > > 09:16:35 -0700) > > This feels like a lot of change this late in the cycle. Are you sure this is > the right time for it? Thanks! > > [TomW] I've been trying to get Thierry's Tegra misc. patches in for several > weeks, but they needed to wait on a change from Thierry that had to go thru > JoeH's repo (net: eth-uclass), otherwise TX2 network testing was failing. > Once you merged Joe's changes, I added Thierry's 26 patches and tested > locally and pushed a PR. We need these in so we can push support for our new > Jetson Nano board upstream. > > If they need to wait for the next cycle, that's your call - we've tested them > here on Stephen's testframe, but it doesn't include every Tegra board. When > would be the earliest they could get merged if they miss this cycle? Thanks for explaining. Can you please add a few line summary of these changes and I'll grab them today/tomorrow? -- Tom --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Pull request, u-boot-tegra/master
Hi, Tom. -Original Message- From: Tom Rini Sent: Thursday, June 6, 2019 6:32 PM To: Tom Warren Cc: u-boot@lists.denx.de; Thierry Reding ; Tom Warren Subject: Re: Pull request, u-boot-tegra/master On Wed, Jun 05, 2019 at 01:50:59PM -0700, Tom Warren wrote: > Tom, > > Please pull u-boot-tegra/master into U-Boot/master. Thanks! > > All Tegra builds are OK, and Stephen's automated test system reports > that all tests pass. > > The following changes since commit 6d93d245c148f10f15724601650fab3a665f102c: > > Merge git://git.denx.de/u-boot-riscv (2019-06-05 10:07:31 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-tegra.git master > > for you to fetch changes up to 879a3bc1c2f3e2aadd6f05e6427cf4d97a272f9a: > > ARM: tegra: Mark built-in Ethernet as default on Jetson TX2 > (2019-06-05 > 09:16:35 -0700) This feels like a lot of change this late in the cycle. Are you sure this is the right time for it? Thanks! [TomW] I've been trying to get Thierry's Tegra misc. patches in for several weeks, but they needed to wait on a change from Thierry that had to go thru JoeH's repo (net: eth-uclass), otherwise TX2 network testing was failing. Once you merged Joe's changes, I added Thierry's 26 patches and tested locally and pushed a PR. We need these in so we can push support for our new Jetson Nano board upstream. If they need to wait for the next cycle, that's your call - we've tested them here on Stephen's testframe, but it doesn't include every Tegra board. When would be the earliest they could get merged if they miss this cycle? Tom -- nvpublic -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom,
Please pull u-boot-tegra/master into U-Boot/master. Thanks!
All Tegra builds are OK, and Stephen's automated test system reports that
all tests pass.
The following changes since commit 6d93d245c148f10f15724601650fab3a665f102c:
Merge git://git.denx.de/u-boot-riscv (2019-06-05 10:07:31 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-tegra.git master
for you to fetch changes up to 879a3bc1c2f3e2aadd6f05e6427cf4d97a272f9a:
ARM: tegra: Mark built-in Ethernet as default on Jetson TX2 (2019-06-05
09:16:35 -0700)
Thierry Reding (26):
fdtdec: Add fdtdec_set_ethernet_mac_address()
lib: Implement strndup()
ARM: tegra: Fix mux type for disp1 and disp2 clocks on Tegra210
ARM: tegra: Remove disp1 clock initialization on Tegra210
ARM: tegra: Use common header for PMU declarations
ARM: tegra: Guard clock code with a Kconfig symbol
ARM: tegra: Guard GP pad control code with a Kconfig symbol
ARM: tegra: Guard memory controller code with a Kconfig symbol
ARM: tegra: Guard pin controller code with a Kconfig symbol
ARM: tegra: Guard powergate code with a Kconfig symbol
ARM: tegra: Fix save_boot_params() prototype
ARM: tegra: Allow boards to override boot target devices
ARM: tegra: Support TZ-only access to PMC
ARM: tegra: Workaround UDC boot issues only if necessary
ARM: tegra: Restore DRAM bank count
ARM: tegra: Unify Tegra186 builds
ARM: tegra: Implement cboot_save_boot_params() in C
ARM: tegra: Implement cboot_get_ethaddr()
ARM: tegra: Import cbootargs value from cboot DTB
ARM: tegra: Enable position independent build for 64-bit
p2371-2180: Pass Ethernet MAC to the kernel
p2771-: Pass Ethernet MAC to the kernel
p2371-2180: Add support for framebuffer carveouts
p2771-: Add support for framebuffer carveouts
ARM: tegra: Rename pcie-controller to pcie
ARM: tegra: Mark built-in Ethernet as default on Jetson TX2
arch/arm/dts/tegra124-apalis.dts | 2 +-
arch/arm/dts/tegra124-cei-tk1-som.dts | 2 +-
arch/arm/dts/tegra124-jetson-tk1.dts | 2 +-
arch/arm/dts/tegra124.dtsi | 2 +-
arch/arm/dts/tegra186-p2771--000.dts | 2 +-
arch/arm/dts/tegra186-p2771--500.dts | 2 +-
arch/arm/dts/tegra186-p2771-.dtsi | 2 +
arch/arm/dts/tegra186.dtsi | 2 +-
arch/arm/dts/tegra20-harmony.dts | 2 +-
arch/arm/dts/tegra20-trimslice.dts | 2 +-
arch/arm/dts/tegra20.dtsi | 2 +-
arch/arm/dts/tegra210-p2371-2180.dts | 2 +-
arch/arm/dts/tegra210.dtsi | 2 +-
arch/arm/dts/tegra30-apalis.dts| 2 +-
arch/arm/dts/tegra30-beaver.dts| 2 +-
arch/arm/dts/tegra30-cardhu.dts| 2 +-
arch/arm/dts/tegra30.dtsi | 2 +-
arch/arm/include/asm/arch-tegra/cboot.h| 45 ++
arch/arm/include/asm/arch-tegra/pmc.h | 20 +-
.../include/asm/{arch-tegra20 => arch-tegra}/pmu.h | 6 +-
arch/arm/include/asm/arch-tegra/tegra.h| 6 +
arch/arm/include/asm/arch-tegra114/pmu.h | 12 -
arch/arm/include/asm/arch-tegra124/pmu.h | 13 -
arch/arm/include/asm/arch-tegra210/pmu.h | 13 -
arch/arm/include/asm/arch-tegra30/pmu.h| 12 -
arch/arm/mach-tegra/Kconfig| 32 ++
arch/arm/mach-tegra/Makefile | 16 +-
arch/arm/mach-tegra/board.c| 41 +-
arch/arm/mach-tegra/board186.c | 32 --
arch/arm/mach-tegra/board2.c | 37 +-
arch/arm/mach-tegra/cache.c| 2 +
arch/arm/mach-tegra/cboot.c| 620
+
arch/arm/mach-tegra/clock.c| 13 +-
arch/arm/mach-tegra/cmd_enterrcm.c | 6 +-
arch/arm/mach-tegra/cpu.c | 20 +-
arch/arm/mach-tegra/emc.c | 2 +-
arch/arm/mach-tegra/lowlevel_init.S| 39 --
arch/arm/mach-tegra/pmc.c | 92 +++
arch/arm/mach-tegra/powergate.c| 11 +-
arch/arm/mach-tegra/tegra186/Makefile | 4 -
arch/arm/mach-tegra/tegra186/nvtboot_board.c | 332 ---
arch/arm/mach-tegra/tegra186/nvtboot_ll.S | 20 -
arch/arm/mach-tegra/tegra186/nvtboot_mem.c | 172 --
arch/arm/mach-tegra/tegra210/clock.c | 11 +-
board/nvidia/p2371-2180/p2371-2180.c | 97
board/nvidia/p2771-/p2771-.c | 111 +++-
configs/e2220-1170_defconfig | 2 +-
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit 40920bdecc4e1b7096de6f546d7b5c2185554ba6: Merge tag 'dm-pull-22may19' of git://git.denx.de/u-boot-dm (2019-05-22 12:58:58 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 430cfc861be2e5aada26cd96d97f3b9911782b16: tegra: nyan-big: Enable sound (2019-05-24 10:14:22 -0700) Simon Glass (7): tegra: Correct tegra124 clock name tegra: Add a delay in clock_start_periph_pll() tegra: sound: Add an audio hub driver tegra: sound: Add an I2S driver sound: tegra: Add a sound driver tegra: nyan: Add a README tegra: nyan-big: Enable sound arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 +++ arch/arm/include/asm/arch-tegra/tegra_i2s.h | 206 arch/arm/mach-tegra/clock.c | 1 + arch/arm/mach-tegra/tegra124/clock.c | 2 +- board/nvidia/nyan-big/README | 18 + board/nvidia/nyan-big/nyan-big.c | 2 +- configs/nyan-big_defconfig | 7 + drivers/sound/Kconfig| 9 + drivers/sound/Makefile | 1 + drivers/sound/tegra_ahub.c | 256 +++ drivers/sound/tegra_i2s.c| 123 +++ drivers/sound/tegra_i2s_priv.h | 29 ++ drivers/sound/tegra_sound.c | 100 ++ 13 files changed, 1227 insertions(+), 2 deletions(-) create mode 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h create mode 100644 arch/arm/include/asm/arch-tegra/tegra_i2s.h create mode 100644 board/nvidia/nyan-big/README create mode 100644 drivers/sound/tegra_ahub.c create mode 100644 drivers/sound/tegra_i2s.c create mode 100644 drivers/sound/tegra_i2s_priv.h create mode 100644 drivers/sound/tegra_sound.c ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] sound: Add sound support for Nyan
Simon, There were a couple of issues with your patches (two appear to be malformed - the README and the 'fifo_threshold' one, looked like a linewrap issue, and the defconfig changes just didn't match up exactly w/TOT tegra/master after rebasing against TomR's main master). I was able to fix them all, but you should pull down the latest u-boot-tegra/master and check that all of the nyan patches look correct. All Tegra builds are OK and is now in Stephen's Jenkins test framework. If it passes, and I get a thumbs-up from you, I'll send a PR to TomR. Tom -Original Message- From: Tom Warren Sent: Wednesday, May 22, 2019 8:51 AM To: Simon Glass ; U-Boot Mailing List Cc: Jonathan Hunter ; Stephen Warren ; Stephen Warren Subject: RE: [PATCH v2 0/7] sound: Add sound support for Nyan Simon, -Original Message- From: Simon Glass Sent: Wednesday, May 22, 2019 6:25 AM To: U-Boot Mailing List Cc: Jonathan Hunter ; Stephen Warren ; Stephen Warren ; Tom Warren Subject: Re: [PATCH v2 0/7] sound: Add sound support for Nyan Hi Tom, On Mon, 1 Apr 2019 at 14:38, Simon Glass wrote: > > This series adds sound support for Nyan. It allows simple beeps to be > generated in U-Boot. This requires the addition of an I2S driver, an > audio hub driver and a sound driver to pull things together. An > existing audio codec (MAX98090) is used. > > Changes in v2: > - Fix 'I2C' typo > - Drop setting of slot_ctrl from i2s_tx_init() > > Simon Glass (7): > tegra: Correct tegra124 clock name > tegra: Add a delay in clock_start_periph_pll() > tegra: sound: Add an audio hub driver > tegra: sound: Add an I2S driver > sound: tegra: Add a sound driver > tegra: nyan-big: Enable sound > tegra: nyan: Add a README > > arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 > +++ arch/arm/include/asm/arch-tegra/tegra_i2s.h | > +++ 206 > arch/arm/mach-tegra/clock.c | 1 + > arch/arm/mach-tegra/tegra124/clock.c | 2 +- > board/nvidia/nyan-big/README | 18 + > board/nvidia/nyan-big/nyan-big.c | 2 +- > configs/nyan-big_defconfig | 7 + > drivers/sound/Kconfig| 9 + > drivers/sound/Makefile | 1 + > drivers/sound/tegra_ahub.c | 256 ++ > drivers/sound/tegra_i2s.c| 123 + > drivers/sound/tegra_i2s_priv.h | 29 ++ > drivers/sound/tegra_sound.c | 100 > 13 files changed, 1227 insertions(+), 2 deletions(-) create mode > 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h > create mode 100644 arch/arm/include/asm/arch-tegra/tegra_i2s.h > create mode 100644 board/nvidia/nyan-big/README create mode 100644 > drivers/sound/tegra_ahub.c create mode 100644 > drivers/sound/tegra_i2s.c create mode 100644 > drivers/sound/tegra_i2s_priv.h create mode 100644 > drivers/sound/tegra_sound.c > This series still seems to be in limbo. How can this get applied? Yeah, sorry, I forgot about these. I'll try to get them applied this week. Tom Regards, Simon -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] sound: Add sound support for Nyan
Simon, -Original Message- From: Simon Glass Sent: Wednesday, May 22, 2019 6:25 AM To: U-Boot Mailing List Cc: Jonathan Hunter ; Stephen Warren ; Stephen Warren ; Tom Warren Subject: Re: [PATCH v2 0/7] sound: Add sound support for Nyan Hi Tom, On Mon, 1 Apr 2019 at 14:38, Simon Glass wrote: > > This series adds sound support for Nyan. It allows simple beeps to be > generated in U-Boot. This requires the addition of an I2S driver, an > audio hub driver and a sound driver to pull things together. An > existing audio codec (MAX98090) is used. > > Changes in v2: > - Fix 'I2C' typo > - Drop setting of slot_ctrl from i2s_tx_init() > > Simon Glass (7): > tegra: Correct tegra124 clock name > tegra: Add a delay in clock_start_periph_pll() > tegra: sound: Add an audio hub driver > tegra: sound: Add an I2S driver > sound: tegra: Add a sound driver > tegra: nyan-big: Enable sound > tegra: nyan: Add a README > > arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 > +++ arch/arm/include/asm/arch-tegra/tegra_i2s.h | 206 > > arch/arm/mach-tegra/clock.c | 1 + > arch/arm/mach-tegra/tegra124/clock.c | 2 +- > board/nvidia/nyan-big/README | 18 + > board/nvidia/nyan-big/nyan-big.c | 2 +- > configs/nyan-big_defconfig | 7 + > drivers/sound/Kconfig| 9 + > drivers/sound/Makefile | 1 + > drivers/sound/tegra_ahub.c | 256 ++ > drivers/sound/tegra_i2s.c| 123 + > drivers/sound/tegra_i2s_priv.h | 29 ++ > drivers/sound/tegra_sound.c | 100 > 13 files changed, 1227 insertions(+), 2 deletions(-) create mode > 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h > create mode 100644 arch/arm/include/asm/arch-tegra/tegra_i2s.h > create mode 100644 board/nvidia/nyan-big/README create mode 100644 > drivers/sound/tegra_ahub.c create mode 100644 > drivers/sound/tegra_i2s.c create mode 100644 > drivers/sound/tegra_i2s_priv.h create mode 100644 > drivers/sound/tegra_sound.c > This series still seems to be in limbo. How can this get applied? Yeah, sorry, I forgot about these. I'll try to get them applied this week. Tom Regards, Simon --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 00/27] ARM: tegra: Miscalleneous improvements
Thierry, I tried applying your 27 v5 patchset series here to my local u-boot-tegra/master + uboot/master (on the assumption that Simon's FDT patches had made it to TomR's master), and it failed on the first patch w/git-am. Using 'patch' allowed it to be applied w/minor fixups/fuzz. The rest of the patches then applied w/git-am OK. I'm building locally now (64-bit and 32-bit Tegra) and if all is well I'll send a new master to Denx (minus the Nano CL, since we're not yet ready to provide all the collateral docs) for Stephen's testframe to pick up, and if it all passes I can send it all to TomR in a PR later this week. Tom -Original Message- From: Thierry Reding Sent: Monday, April 15, 2019 2:32 AM To: Tom Warren ; Simon Glass Cc: Jonathan Hunter ; Stephen Warren ; u-boot@lists.denx.de Subject: [PATCH v5 00/27] ARM: tegra: Miscalleneous improvements From: Thierry Reding Hi Tom, Stephen, this in the fifth installment of this series of miscellaneous improvements for Tegra support. The main changes since the last version are: - Add two patches from the "framebuffer carveout" series since Simon has already picked up the libfdt and fdtdec specific parts. - Fix the MAC address regression found by Stephen's test system. This is done by writing the MAC address to U-Boot's control DTB rather than storing it in the environment and thereby confusing Ethernet drivers if more than one device are present in the system. - I've also added the Jetson Nano patch to the series since it has changed slightly. The issue of the pinmux spreadsheet is still open, so this isn't quite ready to be merged, but I wanted to solicit more feedback, so that this is already reviewed by the time the pinmux spreadsheet issue is resolved. Simon, I've included another patch for a new fdtdec function in this series because the first user is introduced here. It'd be great if you could provide an Acked-by on the first patch so that Tom can pick it up and send out as part of the PR for the entire series once it's been reviewed and passed Stephen's test system. The second patch is also required later in the series. There's no explicit maintainer for lib/string.c, but you show up in the output for scripts/get_maintainer.pl for the second patch, so perhaps you could also give an Acked-by on that? Alternatively you could pick up patches 1 and 2 so that Tom can base his PR on your tree (or master, later on), if that's what you guys prefer. Actually, this might be better anyway, since there might be a tiny merge conflict between the fdtdec patch in this series and the other ones that I sent out earlier. Thanks, Thierry Thierry Reding (27): fdtdec: Add fdtdec_set_ethernet_mac_address() lib: Implement strndup() ARM: tegra: Fix mux type for disp1 and disp2 clocks on Tegra210 ARM: tegra: Remove disp1 clock initialization on Tegra210 ARM: tegra: Use common header for PMU declarations ARM: tegra: Guard clock code with a Kconfig symbol ARM: tegra: Guard GP pad control code with a Kconfig symbol ARM: tegra: Guard memory controller code with a Kconfig symbol ARM: tegra: Guard pin controller code with a Kconfig symbol ARM: tegra: Guard powergate code with a Kconfig symbol ARM: tegra: Fix save_boot_params() prototype ARM: tegra: Allow boards to override boot target devices ARM: tegra: Support TZ-only access to PMC ARM: tegra: Workaround UDC boot issues only if necessary ARM: tegra: Restore DRAM bank count ARM: tegra: Unify Tegra186 builds ARM: tegra: Implement cboot_save_boot_params() in C ARM: tegra: Implement cboot_get_ethaddr() ARM: tegra: Import cbootargs value from cboot DTB ARM: tegra: Enable position independent build for 64-bit p2371-2180: Pass Ethernet MAC to the kernel p2771-: Pass Ethernet MAC to the kernel p2371-2180: Add support for framebuffer carveouts p2771-: Add support for framebuffer carveouts ARM: tegra: Rename pcie-controller to pcie ARM: tegra: Mark built-in Ethernet as default on Jetson TX2 ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support arch/arm/dts/Makefile | 3 +- arch/arm/dts/tegra124-apalis.dts | 2 +- arch/arm/dts/tegra124-cei-tk1-som.dts | 2 +- arch/arm/dts/tegra124-jetson-tk1.dts | 2 +- arch/arm/dts/tegra124.dtsi| 2 +- arch/arm/dts/tegra186-p2771--000.dts | 2 +- arch/arm/dts/tegra186-p2771--500.dts | 2 +- arch/arm/dts/tegra186-p2771-.dtsi | 2 + arch/arm/dts/tegra186.dtsi| 2 +- arch/arm/dts/tegra20-harmony.dts | 2 +- arch/arm/dts/tegra20-trimslice.dts| 2 +- arch/arm/dts/tegra20.dtsi | 2 +- arch/arm/dts/tegra210-p2371-2180.dts | 2 +- arch/arm/dts/tegra210-p3450-.dts | 135 arch/arm/dts/tegra210.dtsi| 2 +- arch/arm/d
Re: [U-Boot] [PATCH 2/4] Kconfig: tegra: Migrate USB_EHCI_TEGRA
-Original Message- From: Peter Robinson Sent: Wednesday, February 20, 2019 10:23 AM To: Marek Vasut Cc: Tom Warren ; u-boot@lists.denx.de; Stephen Warren ; Marcel Ziswiler ; peter.ch...@data61.csiro.au; Lucas Stach ; Stefan Agner ; Alban Bedel ; Allen Martin Subject: Re: [PATCH 2/4] Kconfig: tegra: Migrate USB_EHCI_TEGRA On Wed, Feb 20, 2019 at 5:17 PM Marek Vasut wrote: > > On 2/20/19 1:17 PM, Peter Robinson wrote: > > Migrate USB_EHCI_TEGRA from headers to Kconfig > > > > Signed-off-by: Peter Robinson > > Cc: Tom Warren > > Cc: Stephen Warren > > Cc: Marek Vasut > > Cc: Marcel Ziswiler > > Cc: peter.ch...@data61.csiro.au > > Cc: Lucas Stach > > Cc: Stefan Agner > > Cc: Alban Bedel > > Cc: Allen Martin > > Looks good to me, > Reviewed-by: Marek Vasut > > Is there a tegra maintainer or shall I take it via -usb ? That would be Tom Warren and I believe he's already queued it in a PR Sorry, yes, I've sent an updated PR to TomR for u-boot-tegra/master w/all of Peter's changes. Tom -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. NOTE: This PR should supersede the previous one, sent yesterday. Thanks. The following changes since commit 97f9830849c64d60d0cf2fd69e87dfe4557d02a4: Merge branch '2019-02-19-master-imports' (2019-02-19 20:48:11 -0500) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to a3c9021771608f5b514c75874fa0d8fbee2873d6: board: toradex: turn off lcd backlight before OS handover (2019-02-20 09:01:45 -0700) Gerard Salvatella (1): board: toradex: turn off lcd backlight before OS handover Jonathan Hunter (1): ARM: tegra: Reserve 32MB for the Linux kernel Peter Robinson (6): tegra: cleanup dangling comments in include/configs tegra20: common: fix USB_EHCI_TXFIFO_THRESH value Kconfig: tegra: Migrate SYS_I2C_TEGRA Kconfig: tegra: Migrate USB_EHCI_TEGRA Kconfig: tegra: Migrate TEGRA_KEYBOARD nyan-big: drop CONFIG_KEYBOARD Tristan Bastian (3): nyan-big: change spi delay nyan-big: add padding to its file ARM: tegra: enable ums on nyan boards arch/arm/dts/tegra124-nyan-big-u-boot.dtsi | 2 +- arch/arm/dts/tegra124-nyan.dtsi| 1 + board/toradex/apalis-tk1/apalis-tk1.c | 9 + board/toradex/apalis_imx6/apalis_imx6.c| 9 + board/toradex/apalis_t30/apalis_t30.c | 9 + board/toradex/colibri_imx6/colibri_imx6.c | 9 + board/toradex/colibri_imx7/colibri_imx7.c | 9 + board/toradex/colibri_t20/colibri_t20.c| 9 + board/toradex/colibri_t30/colibri_t30.c| 9 + board/toradex/colibri_vf/colibri_vf.c | 12 +++- configs/apalis-tk1_defconfig | 2 ++ configs/apalis_t30_defconfig | 2 ++ configs/beaver_defconfig | 2 ++ configs/cardhu_defconfig | 2 ++ configs/cei-tk1-som_defconfig | 2 ++ configs/colibri_t20_defconfig | 2 ++ configs/colibri_t30_defconfig | 2 ++ configs/dalmore_defconfig | 2 ++ configs/e2220-1170_defconfig | 2 ++ configs/harmony_defconfig | 1 + configs/jetson-tk1_defconfig | 2 ++ configs/medcom-wide_defconfig | 1 + configs/nyan-big_defconfig | 2 ++ configs/p2371-_defconfig | 2 ++ configs/p2371-2180_defconfig | 2 ++ configs/p2571_defconfig| 2 ++ configs/p2771--000_defconfig | 1 + configs/p2771--500_defconfig | 1 + configs/paz00_defconfig| 1 + configs/plutux_defconfig | 1 + configs/seaboard_defconfig | 3 +++ configs/tec-ng_defconfig | 2 ++ configs/tec_defconfig | 1 + configs/trimslice_defconfig| 2 ++ configs/venice2_defconfig | 2 ++ configs/ventana_defconfig | 1 + doc/chromium/nyan-big.its | 2 +- drivers/i2c/Kconfig| 6 ++ drivers/input/Kconfig | 6 ++ drivers/usb/host/Kconfig | 6 ++ include/configs/apalis-tk1.h | 8 include/configs/apalis_t30.h | 10 -- include/configs/beaver.h | 12 include/configs/cardhu.h | 12 include/configs/cei-tk1-som.h | 12 include/configs/colibri_t20.h | 13 - include/configs/colibri_t30.h | 8 include/configs/dalmore.h | 10 -- include/configs/e2220-1170.h | 10 -- include/configs/harmony.h | 7 --- include/configs/jetson-tk1.h | 12 include/configs/medcom-wide.h | 5 - include/configs/nyan-big.h | 12 include/configs/p2371-.h | 10 -- include/configs/p2371-2180.h | 12 include/configs/p2571.h| 10 -- include/configs/p2771-.h | 5 - include/configs/paz00.h| 5 - include/configs/plutux.h | 7 --- include/configs/seaboard.h | 12 include/configs/tec-ng.h | 10 -- include/configs/tec.h | 5 - include/configs/tegra-common.h | 6 -- include/configs/tegra114-common.h | 14 +++--- include/configs/tegra124-common.h | 14 +++--- include/configs/tegra20-common.h | 16
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit f14de0014c56093feecf42ca38b8ae5b3878f176: Prepare v2019.04-rc2 (2019-02-18 21:36:39 -0500) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 283573fe7b93430e70d9f42f104a91738ea9eb60: ARM: tegra: Reserve 32MB for the Linux kernel (2019-02-19 14:38:08 -0800) Jonathan Hunter (1): ARM: tegra: Reserve 32MB for the Linux kernel Peter Robinson (2): tegra: cleanup dangling comments in include/configs tegra20: common: fix USB_EHCI_TXFIFO_THRESH value Tristan Bastian (3): nyan-big: change spi delay nyan-big: add padding to its file ARM: tegra: enable ums on nyan boards arch/arm/dts/tegra124-nyan-big-u-boot.dtsi | 2 +- arch/arm/dts/tegra124-nyan.dtsi| 1 + doc/chromium/nyan-big.its | 2 +- include/configs/apalis-tk1.h | 2 -- include/configs/apalis_t30.h | 4 include/configs/beaver.h | 6 -- include/configs/cardhu.h | 6 -- include/configs/cei-tk1-som.h | 6 -- include/configs/colibri_t20.h | 6 -- include/configs/colibri_t30.h | 2 -- include/configs/dalmore.h | 4 include/configs/e2220-1170.h | 4 include/configs/harmony.h | 4 include/configs/jetson-tk1.h | 6 -- include/configs/medcom-wide.h | 2 -- include/configs/nyan-big.h | 4 include/configs/p2371-.h | 4 include/configs/p2371-2180.h | 6 -- include/configs/p2571.h| 4 include/configs/p2771-.h | 2 -- include/configs/paz00.h| 2 -- include/configs/plutux.h | 4 include/configs/seaboard.h | 2 -- include/configs/tec-ng.h | 4 include/configs/tec.h | 2 -- include/configs/tegra-common.h | 6 -- include/configs/tegra114-common.h | 14 +++--- include/configs/tegra124-common.h | 14 +++--- include/configs/tegra20-common.h | 16 include/configs/tegra210-common.h | 4 include/configs/tegra30-common.h | 18 +++--- include/configs/trimslice.h| 6 -- include/configs/venice2.h | 4 include/configs/ventana.h | 2 -- 34 files changed, 32 insertions(+), 143 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 00/11] sound: Add sound support for Nyan
Let's have Jon Hunter take a look, I'll take it in to tegra/master if he acks it. -Original Message- From: Simon Glass Sent: Sunday, January 20, 2019 1:32 PM To: U-Boot Mailing List Cc: Mario Six ; Tom Warren ; Stephen Warren ; Albert Aribaud ; Allen Martin ; Minkyu Kang ; Stephen Warren Subject: Re: [PATCH 00/11] sound: Add sound support for Nyan Hi Tom Warren, On Fri, 28 Dec 2018 at 09:24, Simon Glass wrote: > > This series adds sound support for Nyan. It allows simple beeps to be > generated in U-Boot. This requires the addition of an I2S driver, an > audio hub driver and a sound driver to pull things together. An > existing audio codec (MAX98090) is used. > > > Simon Glass (11): > misc: Allow child devices > sound: samsung: Fix 'regiter' typo > sound: i2s: Tidy up a few comments > sound: Allow audio codecs to be used by other SoCs > tegra: Correct tegra124 clock name > tegra: Add a delay in clock_start_periph_pll() > tegra: sound: Add an audio hub driver > tegra: sound: Add an I2S driver > sound: tegra: Add a sound driver > tegra: nyan-big: Enable sound > tegra: nyan: Add a README > > arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 > +++ arch/arm/include/asm/arch-tegra/tegra_i2s.h | 206 > > arch/arm/mach-tegra/clock.c | 1 + > arch/arm/mach-tegra/tegra124/clock.c | 2 +- > board/nvidia/nyan-big/README | 18 + > board/nvidia/nyan-big/nyan-big.c | 2 +- > configs/nyan-big_defconfig | 8 +- > drivers/misc/misc-uclass.c | 1 + > drivers/sound/Kconfig| 17 +- > drivers/sound/Makefile | 1 + > drivers/sound/max98088.c | 7 - > drivers/sound/max98090.c | 7 - > drivers/sound/max98095.c | 7 - > drivers/sound/maxim_codec.c | 3 - > drivers/sound/samsung-i2s.c | 16 +- > drivers/sound/samsung_sound.c| 4 + > drivers/sound/tegra_ahub.c | 256 ++ > drivers/sound/tegra_i2s.c| 124 + > drivers/sound/tegra_i2s_priv.h | 29 ++ > drivers/sound/tegra_sound.c | 100 > include/i2s.h| 11 +- > 21 files changed, 1246 insertions(+), 49 deletions(-) create mode > 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h > create mode 100644 arch/arm/include/asm/arch-tegra/tegra_i2s.h > create mode 100644 board/nvidia/nyan-big/README create mode 100644 > drivers/sound/tegra_ahub.c create mode 100644 > drivers/sound/tegra_i2s.c create mode 100644 > drivers/sound/tegra_i2s_priv.h create mode 100644 > drivers/sound/tegra_sound.c > > -- > 2.20.1.415.g653613c723-goog > Are there any comments on this series please? I would like to get it applied before the merge window closes if possible as I have another series that builds on it. Regards, Simon --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Some tegra cleanups and Kconfig migrations
Peter, The SYS_I2C patch doesn't apply cleanly to TOT u-boot-tegra/master (see below git am spew). Please take a look & let me know when you've resent a fixed patchset and I'll retry. Tom tom@tom-lt2:~/denx/uboot-tegra$ git am -s --whitespace=strip ~/Downloads/bundle-17667-Peter-cleanup-6.mbox Applying: tegra: cleanup dangling comments in include/configs Applying: tegra20: common: fix USB_EHCI_TXFIFO_THRESH value Applying: Kconfig: tegra: Migrate SYS_I2C_TEGRA error: patch failed: configs/apalis-tk1_defconfig:29 error: configs/apalis-tk1_defconfig: patch does not apply error: patch failed: configs/apalis_t30_defconfig:26 error: configs/apalis_t30_defconfig: patch does not apply error: patch failed: configs/beaver_defconfig:26 error: configs/beaver_defconfig: patch does not apply error: patch failed: configs/cardhu_defconfig:23 error: configs/cardhu_defconfig: patch does not apply error: patch failed: configs/cei-tk1-som_defconfig:25 error: configs/cei-tk1-som_defconfig: patch does not apply error: patch failed: configs/colibri_t20_defconfig:33 error: configs/colibri_t20_defconfig: patch does not apply error: patch failed: configs/colibri_t30_defconfig:25 error: configs/colibri_t30_defconfig: patch does not apply error: patch failed: configs/dalmore_defconfig:25 error: configs/dalmore_defconfig: patch does not apply error: patch failed: configs/jetson-tk1_defconfig:26 error: configs/jetson-tk1_defconfig: patch does not apply error: patch failed: configs/nyan-big_defconfig:41 error: configs/nyan-big_defconfig: patch does not apply error: patch failed: configs/p2771--000_defconfig:20 error: configs/p2771--000_defconfig: patch does not apply error: patch failed: configs/p2771--500_defconfig:20 error: configs/p2771--500_defconfig: patch does not apply error: patch failed: configs/seaboard_defconfig:22 error: configs/seaboard_defconfig: patch does not apply error: patch failed: configs/tec-ng_defconfig:23 error: configs/tec-ng_defconfig: patch does not apply error: patch failed: configs/trimslice_defconfig:24 error: configs/trimslice_defconfig: patch does not apply error: patch failed: configs/venice2_defconfig:24 error: configs/venice2_defconfig: patch does not apply Patch failed at 0003 Kconfig: tegra: Migrate SYS_I2C_TEGRA The copy of the patch that failed is found in: /home/tom/denx/uboot-tegra/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -----Original Message- From: Tom Warren Sent: Wednesday, November 7, 2018 8:17 AM To: Peter Robinson ; u-boot@lists.denx.de; Tom Rini Subject: RE: Some tegra cleanups and Kconfig migrations Sorry, Peter. I missed these. I'll take a look today and get a PR out to Tom before EOW. -Original Message- From: Peter Robinson Sent: Wednesday, November 7, 2018 7:12 AM To: u-boot@lists.denx.de; Tom Warren ; Tom Rini Subject: Re: Some tegra cleanups and Kconfig migrations Tom or Tom, Any chance we could get these reviewed and merged, mostly generic cleanups so I don't think most of them are controversial. Peter On Sun, Sep 16, 2018 at 6:23 PM Peter Robinson wrote: > > The following patches are a few cleanups to dangling comments from > Kconfig cleanups and migrations of SYS_I2C_TEGRA, USB_EHCI_TEGRA and > TEGRA_KEYBOARD. > There's also a couple of other minors fixes and cleanups as well. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Some tegra cleanups and Kconfig migrations
Sorry, Peter. I missed these. I'll take a look today and get a PR out to Tom before EOW. -Original Message- From: Peter Robinson Sent: Wednesday, November 7, 2018 7:12 AM To: u-boot@lists.denx.de; Tom Warren ; Tom Rini Subject: Re: Some tegra cleanups and Kconfig migrations Tom or Tom, Any chance we could get these reviewed and merged, mostly generic cleanups so I don't think most of them are controversial. Peter On Sun, Sep 16, 2018 at 6:23 PM Peter Robinson wrote: > > The following patches are a few cleanups to dangling comments from > Kconfig cleanups and migrations of SYS_I2C_TEGRA, USB_EHCI_TEGRA and > TEGRA_KEYBOARD. > There's also a couple of other minors fixes and cleanups as well. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit b71d9e8b3805305ea4116733f515061710ad7081: Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-08-20 13:41:56 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 3d186cf3f3ab5c18ede0f0a4ff85ffe99839bc7b: ARM: tegra: avoid more operations in non-secure world (2018-08-21 08:41:00 -0700) Nicolas Chauvet (1): arm: tegra: Restore host1x/dc dm-pre-reloc properties Stephen Warren (1): ARM: tegra: avoid more operations in non-secure world arch/arm/dts/tegra20-u-boot.dtsi | 10 ++ arch/arm/mach-tegra/ap.c | 9 +++-- arch/arm/mach-tegra/gpu.c| 18 -- 3 files changed, 29 insertions(+), 8 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: tegra: align carveout size
I can add this to my PR list (but probably won't get one out until tomorrow morning), or: Acked-by: Tom Warren If that'll get it in sooner. Tom -Original Message- From: Tom Rini Sent: Wednesday, August 1, 2018 4:47 PM To: Stephen Warren Cc: Tom Warren ; u-boot@lists.denx.de; Simon Glass ; Stephen Warren ; Mark Kettenis ; Alexander Graf Subject: Re: [U-Boot] [PATCH] ARM: tegra: align carveout size On Wed, Aug 01, 2018 at 05:26:10PM -0600, Stephen Warren wrote: > On 07/31/2018 12:38 PM, Stephen Warren wrote: > >From: Stephen Warren > > > >Align the size of the carveout region to 2M. This ensures that the > >size can be accurately represented by an LPAE page table that uses sections. > > > >This solves a bug (hang at boot time soon after printing the DRAM > >size) that only shows up when the following two commits are merged together: > >d32e86bde8a3 ARM: HYP/non-sec: enable ARMV7_LPAE if HYP mode is > >supported > >6e584e633d10 ARM: tegra: avoid using secure carveout RAM > > > >Cc: Mark Kettenis > >Cc: Alexander Graf > >Signed-off-by: Stephen Warren > >--- > >This should be applied quickly since it fixes a regression that > >causes all boots to fail, which in turn causes test/py to reset and > >"reflash" the target board for each test, which causes the test to take eons. > > Could we apply this please? My Jenkins system will love you because of > it:-) I'm looking for one more person to Ack this, thanks! -- Tom --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit 2547e91dc15e5203e15d4ebde9172174743b14a7: tegra: Indicate that binman makes all three output files (2018-07-26 15:49:40 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 2eea1269166fd3dccc319629e612edddcd650803: tegra: beaver/apalis: Fix DTC warning (2018-07-26 13:15:31 -0700) Bibek Basu (1): ARM: tegra: implement RAM repair Stephen Warren (5): Revert "tegra: Introduce SRAM repair on tegra124" ARM: define MON_MODE ARM: PSCI: Support PSCI v0.2 ARM: PSCI: Enable the PSCI node ARM: tegra: avoid using secure carveout RAM Tom Warren (1): tegra: beaver/apalis: Fix DTC warning arch/arm/dts/tegra30-apalis.dts | 3 --- arch/arm/dts/tegra30-beaver.dts | 3 --- arch/arm/include/asm/arch-tegra124/flow.h | 10 +++- arch/arm/include/asm/proc-armv/ptrace.h | 1 + arch/arm/lib/psci-dt.c| 6 + arch/arm/mach-tegra/board2.c | 4 +++ arch/arm/mach-tegra/powergate.c | 20 +-- arch/arm/mach-tegra/tegra124/cpu.c| 42 +-- scripts/config_whitelist.txt | 1 + 9 files changed, 57 insertions(+), 33 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] Revert "tegra: Introduce SRAM repair on tegra124"
Sure, let me take a look. -Original Message- From: Stephen Warren Sent: Thursday, July 26, 2018 12:40 PM To: Tom Warren Cc: u-boot@lists.denx.de; Simon Glass ; Stephen Warren Subject: Re: [U-Boot] [PATCH 1/2] Revert "tegra: Introduce SRAM repair on tegra124" On 06/22/2018 01:02 PM, Stephen Warren wrote: > From: Stephen Warren > > This reverts commit 701b7b1d2cf657d435d2bd6caf43d0247d37220d. It will > be immediately replaced by a different implementation that is more > complete and runs are more targetted times. Tom, can we please apply this series, and the 4-long series I sent just after starting with "ARM: define MON_MODE". Thanks. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra: Indicate that binman makes all three output files
I don't usually weigh in on makefile issues, but if Stephen says it's needed, let's get it in. -Original Message- From: Tom Rini Sent: Thursday, July 26, 2018 12:40 PM To: Stephen Warren Cc: Simon Glass ; U-Boot Mailing List ; Stephen Warren ; Tom Warren Subject: Re: [PATCH] tegra: Indicate that binman makes all three output files On Thu, Jul 26, 2018 at 01:37:31PM -0600, Stephen Warren wrote: > On 07/23/2018 09:27 AM, Stephen Warren wrote: > >On 07/20/2018 07:49 PM, Simon Glass wrote: > >>Use GNU make pattern rules to indicate that a single run of binman > >>produces all three Tegra output files. The avoids make running > >>binman three times (perhaps in parallel) and those instances > >>inteferring with each other. > >> > >>See http://patchwork.ozlabs.org/patch/944611/ for the bug report. > > > >Tested-by: Stephen Warren > > > >(This make feature is very odd; specifying n targets without a % > >means they're separate rules, but specifying n targets with a % means > >it's a single rule that generates n targets. Nice inconsistency on > >make's part!) > > Any chance we can apply this ASAP to the main u-boot.git master branch? > Pretty much all my Jenkins builds are failing some random subset of > boards because of this issue. Thanks. If Tom W is fine, I'm happy to pick it up directly. -- Tom --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit 4ac5df4b41ba46d7e635bdd8d500721c642b0a0d: Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-07-03 23:09:34 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 84996795c2f81cbfac210b6f2c168c5fb06a7a20: tegra: nyan-big: Update CONFIG_SYS_TEXT to the default in README.chromium (2018-07-06 09:12:39 -0700) Peter Robinson (1): tegra: nyan-big: Update CONFIG_SYS_TEXT to the default in README.chromium configs/nyan-big_defconfig | 2 +- doc/README.chromium| 27 +++ 2 files changed, 8 insertions(+), 21 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] tegra: nyan-big: Update CONFIG_SYS_TEXT to the default in README.chromium
Applied to tegra-master, just waiting on our automated build/test framework to give it a green light, then I'll issue a PR to TomR. Sorry for the delay. Tom -Original Message- From: Peter Robinson Sent: Thursday, July 5, 2018 11:38 PM To: Allen Martin ; Simon Glass ; Tom Warren ; u-boot@lists.denx.de Cc: Peter Robinson Subject: Re: [PATCH v3] tegra: nyan-big: Update CONFIG_SYS_TEXT to the default in README.chromium Tom, Ping, could we get this applied please? Peter On Sun, Jun 10, 2018 at 6:17 AM, Peter Robinson wrote: > To build U-Boot on a Nyan Big Chromebook the docs outline adjusting > the Tegra124 defined CONFIG_SYS_TEXT_BASE but this has since been > moved to individual config files. We should have the default required > for U-Boot chain loading on the chromebook as the default > CONFIG_SYS_TEXT_BASE and update the docs to remove this now non required step. > > Signed-off-by: Peter Robinson > --- > > v3: Update commit message > v2: Update to 2018.07 RC1 > > configs/nyan-big_defconfig | 2 +- > doc/README.chromium| 27 +++ > 2 files changed, 8 insertions(+), 21 deletions(-) > > diff --git a/configs/nyan-big_defconfig b/configs/nyan-big_defconfig > index 8868d1f9e10..3b64c643716 100644 > --- a/configs/nyan-big_defconfig > +++ b/configs/nyan-big_defconfig > @@ -1,6 +1,6 @@ > CONFIG_ARM=y > CONFIG_TEGRA=y > -CONFIG_SYS_TEXT_BASE=0x8011 > +CONFIG_SYS_TEXT_BASE=0x81000100 > CONFIG_DEBUG_UART_BASE=0x70006000 > CONFIG_DEBUG_UART_CLOCK=40800 > CONFIG_TEGRA124=y > diff --git a/doc/README.chromium b/doc/README.chromium index > 7bf4d874474..45eaeced2da 100644 > --- a/doc/README.chromium > +++ b/doc/README.chromium > @@ -43,26 +43,13 @@ > https://git.collabora.com/cgit/user/tomeu/u-boot.git/commit/?h=nyan-bi > g https://lists.denx.de/pipermail/u-boot/2017-May/289491.html > > https://github.com/chromeos-nvidia-androidtv/gnu-linux-on-acer-chromeb > ook-13#copy-data-to-the-sd-card > > -1. Patch U-Boot > - > -Open include/configs/tegra124-common.h > - > -Change: > - > -#define CONFIG_SYS_TEXT_BASE 0x8011 > - > -to: > - > -#define CONFIG_SYS_TEXT_BASE 0x81000100 > - > - > -2. Build U-Boot > +1. Build U-Boot > > mkdir b > make -j8 O=b/nyan-big CROSS_COMPILE=arm-linux-gnueabi- > nyan-big_defconfig all > > > -3. Select a .its file > +2. Select a .its file > > Select something from doc/chromium which matches your board, or > create your own. > @@ -72,7 +59,7 @@ used by U-Boot. This is because the Chromebook > expects to pass it to the kernel, and crashes if it is not present. > > > -4. Build and sign an image > +3. Build and sign an image > > ./b/nyan-big/tools/mkimage -f doc/chromium/nyan-big.its > u-boot-chromium.fit > echo test >dummy.txt > @@ -82,7 +69,7 @@ kernel, and crashes if it is not present. > --bootloader dummy.txt --pack u-boot.kpart > > > -5. Prepare an SD card > +4. Prepare an SD card > > DISK=/dev/sdc # Replace with your actual SD card device > sudo cgpt create $DISK > @@ -91,12 +78,12 @@ kernel, and crashes if it is not present. > sudo gdisk $DISK # Enter command 'w' to write a protective MBR to the > disk > > > -6. Write U-Boot to the SD card > +5. Write U-Boot to the SD card > > sudo dd if=u-boot.kpart of=/dev/sdc1; sync > > > -7. Start it up > +6. Start it up > > Reboot the device in dev mode. Make sure that you have USB booting > enabled. To do this, login as root (via Ctrl-Alt-forward_arrow) and > type @@ -115,7 +102,7 @@ mode screen. It should show something like the > following on the display: > Tegra124 (Nyan-big) # > > > -8. Known problems > +7. Known problems > > On the serial console the word MMC is chopped at the start of the line: > > -- > 2.17.1 > -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit da342f06b30399fbbebbb53aadfc018713c65c24: Merge git://git.denx.de/u-boot-ubi (2018-05-10 07:17:14 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 71cb3d7c7897cd02ca731f4c510fff49705b84b7: apalis_t30: fix optional pcie port reset for reliable pcie operation (2018-05-10 16:34:30 -0700) Marcel Ziswiler (11): mtd: nand: tegra: convert to driver model and live tree configs: harmony: enable live tree, mtd and ubi configs: colibri_t20: enable mtd apalis-tk1: add missing as3722 gpio0 configuration power: as3722: fix ldo_get/set_enable for ldo index bigger than 7 pci: tegra: introduce weak tegra_pcie_board_port_reset() function power: as3722: add as3722_ldo_set_voltage signature to header file apalis-tk1: fix pcie reset for reliable gigabit ethernet operation apalis_t30: describe pcie ports apalis_t30: fix pcie port 0 and 1 pin muxing apalis_t30: fix optional pcie port reset for reliable pcie operation Sanchayan Maity (1): configs: apalis-tk1: fix boot failure using ext4 rootfs arch/arm/dts/tegra124-apalis.dts | 6 +- arch/arm/dts/tegra30-apalis.dts| 3 + board/toradex/apalis-tk1/Kconfig | 8 + board/toradex/apalis-tk1/apalis-tk1.c | 252 + board/toradex/apalis_t30/Kconfig | 9 + board/toradex/apalis_t30/apalis_t30.c | 57 - .../toradex/apalis_t30/pinmux-config-apalis_t30.h | 16 +- configs/colibri_t20_defconfig | 1 + configs/harmony_defconfig | 6 + drivers/mtd/nand/tegra_nand.c | 98 drivers/pci/pci_tegra.c| 17 +- drivers/power/regulator/as3722_regulator.c | 18 +- include/configs/apalis-tk1.h | 4 +- include/configs/harmony.h | 4 + include/pci_tegra.h| 10 + include/power/as3722.h | 4 +- 16 files changed, 356 insertions(+), 157 deletions(-) create mode 100644 include/pci_tegra.h ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tegra U-Boot Patches
>Tom, do you have time for Tegra stuff still? Thanks! Yeah, I do. It just got pushed to the back of the line the last few weeks, but that surge should be over and I can get back to my usual round-robin scheduling of my task list. Thanks, Tom -Original Message- From: Tom Rini <tr...@konsulko.com> Sent: Thursday, May 10, 2018 3:44 PM To: Marcel Ziswiler <mar...@ziswiler.com>; Tom Warren <twar...@nvidia.com> Cc: u-boot@lists.denx.de; Marcel Ziswiler <marcel.ziswi...@toradex.com> Subject: Re: Tegra U-Boot Patches * PGP Signed by an unknown key On Fri, May 11, 2018 at 12:40:45AM +0200, Marcel Ziswiler wrote: > Hi Tom > > I have 3 patch sets [1, 2, 3] more or less long since (e.g. the > longest almost one full year now) awaiting inclusion. Could you please > consider pulling those in during current merge window? > > Good news two more patches [4, 5] long since got applied and may be > removed (resp. status changes) in patchwork. Thanks for the update on [4, 5], I was wondering about those when cleaning up patchwork earlier today. Tom, do you have time for Tegra stuff still? Thanks! -- Tom * Unknown Key * 0xD31D7652 --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tegra U-Boot Patches
Hi, Marcel. I had it on my TODO list to send you an email asking for a list of pending patches today! Sorry for the delay - things have heated up here and I don’t get to give my upstream tasks as much attention as I'd like. I'll pull them down first thing tomorrow and get a PR up for TomR to apply. Are they in order as you have them listed here? i.e. I can apply #1, then #2, then #3? Or are there no dependencies? Thanks for your patience, Tom -Original Message- From: Marcel Ziswiler <mar...@ziswiler.com> Sent: Thursday, May 10, 2018 3:41 PM To: Tom Warren <twar...@nvidia.com> Cc: Tom Rini <tr...@konsulko.com>; u-boot@lists.denx.de; Marcel Ziswiler <marcel.ziswi...@toradex.com> Subject: Tegra U-Boot Patches Hi Tom I have 3 patch sets [1, 2, 3] more or less long since (e.g. the longest almost one full year now) awaiting inclusion. Could you please consider pulling those in during current merge window? Good news two more patches [4, 5] long since got applied and may be removed (resp. status changes) in patchwork. [1] https://patchwork.ozlabs.org/project/uboot/list/?series=43045 [2] https://patchwork.ozlabs.org/project/uboot/list/?series=43210 [3] https://patchwork.ozlabs.org/project/uboot/list/?series=43290 [4] https://patchwork.ozlabs.org/patch/797890/ [5] https://patchwork.ozlabs.org/patch/797887/ Thanks! Cheers Marcel --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] How to test new bootloaders on Jetson TX1?
-Original Message-
From: Jonathan Hunter
Sent: Thursday, February 15, 2018 8:39 AM
To: Andreas Färber <afaer...@suse.de>
Cc: linux-te...@vger.kernel.org; U-Boot <u-boot@lists.denx.de>; Alexander Graf
<ag...@suse.de>; Mian Yousaf Kaukab <yousaf.kau...@suse.com>; Tom Warren
<twar...@nvidia.com>; Varun Wadekar <vwade...@nvidia.com>
Subject: Re: How to test new bootloaders on Jetson TX1?
On 15/02/18 15:12, Andreas Färber wrote:
> Hi Jon,
>
> Am 15.02.2018 um 15:01 schrieb Jon Hunter:
>> On 15/02/18 12:32, Andreas Färber wrote:
>>> Am 15.02.2018 um 10:22 schrieb Jon Hunter:
>>>> On 15/02/18 01:51, Andreas Färber wrote:
>>>>> I would like to test the latest version of U-Boot on the Jetson TX1.
>>> [...]
>>>>> Here's what I have tried:
>>>>>
>>>>> $ sudo ./flash.sh p2371-2180-devkit mmcblk0p1
>>>> This should work. Which u-boot binary are you copying and where are
>>>> you copying it?
>>>>
>>>> I copy the u-boot-dtb.bin over u-boot.bin in the L4T directory
>>>> Linux_for_Tegra/bootloader/t186ref/p2771-/500/u-boot.bin.
>>>
>>> I downloaded the .rpm from
>>> https://build.opensuse.org/package/show/hardware:boot/u-boot-p2371-2
>>> 180 extracting all of u-boot, u-boot.bin, u-boot.dtb and
>>> u-boot-dtb.bin to bootloader/t210ref/p2371-2180/ - and as described
>>> it makes a difference in that it then ceases to boot to a U-Boot
>>> prompt.
>>
>> Sorry, looks like I mixed TX1 and TX2. I see you are using TX1.
>> However, I believe you are still booting the wrong u-boot file.
>>
>> If you look at the p2371-2180-devkit.conf you will see that it has ...
>>
>> DFLT_KERNEL_IMAGE="bootloader/${target_board}/p2371-2180/u-boot.bin
>>
>> For using the upstream u-boot, we need to use the u-boot-dtb.bin and
>> not the u-boot.bin. So you can either ...
>>
>> 1. Update the p2371-2180-devkit.conf to use the u-boot-dtb.bin that
>> you copied.
>> 2. Move the u-boot-dtb.bin from your rpm to
>> bootloader/t210ref/p2371-2180/u-boot.bin.
>
> Both in the Nvidia tarball and in our upstream based package builds,
> u-boot.bin and u-boot-dtb.bin are identical. Since some time
> u-boot-dtb.bin gets copied over as u-boot.bin for consistency upstream.
Good to know!
> Should this work with the vanilla upstream files, or do they need any
> headers or signatures or something?
Yes should work fine with vanilla upstream.
> Do any of you have that upstream version booting successfully, or
> might it be an upstream U-Boot regression? I was so far assuming it's
> a user error, so haven't tried bisecting yet.
I am using "U-Boot 2017.03". However, I realise that I am currently based upon
L4T rel24.2.1 (as rel28.1 was not available when I started using L4T for
testing upstream). I hope it would not matter, but you never know. I plan to
move to rel28.2 once it is released. If we think it is a problem with rel28.1 I
should be able to test my side.
[Tom] Current (R28.x) U-Boot requires CBoot to load - we no longer use NVTBoot
as we did in R24.x. Hence, upstream U-Boot needs some modifications to be able
to be loaded by CBoot instead of NVTBoot. I haven't done that work yet
(patches to convert upstream Denx U-Boot source for T210/T186 to use CBoot as
the loader - don't know how I'll structure it so old (NVTBoot) bootflow will
still work as well as the new (CBoot) bootflow). I've got it on my plate, but
other priorities have prevented me from working on it. I'll try to get it into
the queue. Until then, you won't be able to load/run upstream U-Boot using the
boot flow in R28.x. Sorry.
Cheers
Jon
--
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b: Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 5fed97af20da955625cc06563a725b49cebb99eb: Makefile: ensure DTB doesn't overflow into initial stack (2018-01-12 10:12:32 -0700) Stephen Warren (14): ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no SPL ARM: tegra: remove SPL config for non-SPL SoCs ARMv8: Allow dynamic early stack pointer ARM: tegra: use CONFIG_SYS_INIT_SP_BSS_OFFSET ARMv8: add optional Linux kernel image header ARM: tegra: use LINUX_KERNEL_IMAGE_HEADER ARM: Tegra186: mem parsing fixes from downstream ARM: bootm: don't assume sp is in DRAM bank 0 ARM: Tegra186: search for best RAM bank ARM: tegra: p2771-000: increase max DRAM bank count ARM: Tegra186: don't map memory not in RAM banks ARM: Tegra186: calculate load addresses at boot ARM: Tegra: p2771-: use calculate env var feature Makefile: ensure DTB doesn't overflow into initial stack Makefile | 31 +++ arch/arm/Kconfig | 30 +++ .../arm/cpu/armv8/linux-kernel-image-header-vars.h | 86 +++ arch/arm/cpu/armv8/start.S | 4 +- arch/arm/cpu/armv8/u-boot.lds | 4 + arch/arm/dts/tegra-u-boot.dtsi | 15 +- arch/arm/include/asm/boot0-linux-kernel-header.h | 49 arch/arm/lib/bootm.c | 15 +- arch/arm/lib/crt0_64.S | 3 + arch/arm/mach-tegra/Kconfig| 6 + arch/arm/mach-tegra/arm64-mmu.c| 3 +- arch/arm/mach-tegra/tegra186/Kconfig | 3 + arch/arm/mach-tegra/tegra186/nvtboot_board.c | 265 - arch/arm/mach-tegra/tegra186/nvtboot_mem.c | 144 --- arch/arm/mach-tegra/tegra210/Kconfig | 3 + include/configs/p2771-.h | 23 ++ include/configs/tegra-common.h | 4 + include/configs/tegra186-common.h | 10 - include/configs/tegra210-common.h | 10 - 19 files changed, 646 insertions(+), 62 deletions(-) create mode 100644 arch/arm/cpu/armv8/linux-kernel-image-header-vars.h create mode 100644 arch/arm/include/asm/boot0-linux-kernel-header.h Thanks, Tom ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: ensure DTB doesn't overflow into initial stack
Stephen,
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Tuesday, January 9, 2018 12:52 PM
To: u-boot@lists.denx.de; Simon Glass <s...@chromium.org>; Tom Warren
<twar...@nvidia.com>; Stephen Warren <swar...@nvidia.com>
Cc: Tom Rini <tr...@konsulko.com>
Subject: [PATCH] Makefile: ensure DTB doesn't overflow into initial stack
From: Stephen Warren <swar...@nvidia.com>
With CONFIG_SYS_INIT_SP_BSS_OFFSET enabled, the initial (pre-relocation) stack
is placed some distance after bss_start. The control DTB is appended to the
U-Boot binary at bss_start. If the DTB is too large, or the SP BSS offset too
small, then the initial stack could corrupt the DTB. Enhance the Makefile to
check whether this is likely to occur.
Signed-off-by: Stephen Warren <swar...@nvidia.com>
---
This builds on top of my previous patch "ARMv8: Allow dynamic early stack
pointer". However, since all the logic is conditional and only activated if
CONFIG_SYS_INIT_SP_BSS_OFFSET is defined, it can be applied with or without
that other patch. It'd make sense to apply it afterwards and in the same branch
though, or the change won't make a lot of sense to someone reading history in
order.
I've got this in my TOT u-boot-tegra/master, ready to send a PR to TomR. But
it's delegated to him in Patchwork. Do you want me to remove it from my PR, or
leave it in?
Tom
Makefile | 31 +++
1 file changed, 31 insertions(+)
diff --git a/Makefile b/Makefile
index d8f419bcd900..52cd6ea72161 100644
--- a/Makefile
+++ b/Makefile
@@ -811,6 +811,10 @@ ifneq ($(CONFIG_BUILD_TARGET),) ALL-y +=
$(CONFIG_BUILD_TARGET:"%"=%) endif
+ifneq ($(CONFIG_SYS_INIT_SP_BSS_OFFSET),)
+ALL-y += init_sp_bss_offset_check
+endif
+
LDFLAGS_u-boot += $(LDFLAGS_FINAL)
# Avoid 'Not enough room for program headers' error on binutils 2.28 onwards.
@@ -939,6 +943,33 @@ binary_size_check: u-boot-nodtb.bin FORCE
fi \
fi
+ifneq ($(CONFIG_SYS_INIT_SP_BSS_OFFSET),)
+ifneq ($(CONFIG_SYS_MALLOC_F_LEN),)
+subtract_sys_malloc_f_len = space=$$(($${space} -
+$(CONFIG_SYS_MALLOC_F_LEN))) else subtract_sys_malloc_f_len = true
+endif # The 1/4 margin below is somewhat arbitrary. The likely initial
+SP usage is # so low that the DTB could probably use 90%+ of the
+available space, for # current values of CONFIG_SYS_INIT_SP_BSS_OFFSET
+at least. However, let's be # safe for now and tweak this later if
+space becomes tight.
+# A rejected alternative would be to check that some absolute minimum
+stack # space was available. However, since
+CONFIG_SYS_INIT_SP_BSS_OFFSET is # deliberately build-specific, to take
+account of build-to-build stack usage # differences due to different
+feature sets, there is no common absolute value # to check against.
+init_sp_bss_offset_check: u-boot.dtb FORCE
+ @dtb_size=$(shell wc -c u-boot.dtb | awk '{print $$1}') ; \
+ space=$(CONFIG_SYS_INIT_SP_BSS_OFFSET) ; \
+ $(subtract_sys_malloc_f_len) ; \
+ quarter_space=$$(($${space} / 4)) ; \
+ if [ $${dtb_size} -gt $${quarter_space} ]; then \
+ echo "u-boot.dtb is larger than 1 quarter of " >&2 ; \
+ echo "(CONFIG_SYS_INIT_SP_BSS_OFFSET -
CONFIG_SYS_MALLOC_F_LEN)" >&2 ; \
+ exit 1 ; \
+ fi
+endif
+
u-boot-nodtb.bin: u-boot FORCE
$(call if_changed,objcopy)
$(call DO_STATIC_RELA,$<,$@,$(CONFIG_SYS_TEXT_BASE))
--
2.15.1
--
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no SPL
-Original Message- From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Wednesday, January 3, 2018 3:44 PM To: Tom Warren <twar...@nvidia.com> Cc: Simon Glass <s...@chromium.org>; Tom Rini <tr...@konsulko.com>; U-Boot Mailing List <u-boot@lists.denx.de>; Stephen Warren <swar...@nvidia.com> Subject: Re: [PATCH 1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no SPL On 01/03/2018 03:43 PM, Tom Warren wrote: > Stephen, > > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Thursday, December 28, 2017 8:14 PM > To: Stephen Warren <swar...@wwwdotorg.org> > Cc: Tom Warren <twar...@nvidia.com>; Tom Rini <tr...@konsulko.com>; > U-Boot Mailing List <u-boot@lists.denx.de>; Stephen Warren > <swar...@nvidia.com> > Subject: Re: [PATCH 1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE > when no SPL > > On 19 December 2017 at 18:30, Stephen Warren <swar...@wwwdotorg.org> wrote: >> From: Stephen Warren <swar...@nvidia.com> >> >> 64-bit Tegra don't use SPL, and soon won't define >> CONFIG_SPL_TEXT_BASE when building. Fix the binman .dts file so that >> it doesn't use undefined values. >> >> Signed-off-by: Stephen Warren <swar...@nvidia.com> >> --- >> arch/arm/dts/tegra-u-boot.dtsi | 15 +-- >> 1 file changed, 9 insertions(+), 6 deletions(-) > > Reviewed-by: Simon Glass <s...@chromium.org> > > I've applied this series to u-boot-tegra/master. I'll wait a bit to see how > your new series (RAM bank/mem parsing) is received and then I'll apply it, > too, and post a PR. > I assume you expect the Linux kernel image header patches to go in thru TomR? I think it's best to push them all through the Tegra path, since there will be a stream of common and Tegra patches all intermixed. OK, I'll apply them as they get reviewed/ACK'd. Thanks. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no SPL
Stephen, -Original Message- From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass Sent: Thursday, December 28, 2017 8:14 PM To: Stephen Warren <swar...@wwwdotorg.org> Cc: Tom Warren <twar...@nvidia.com>; Tom Rini <tr...@konsulko.com>; U-Boot Mailing List <u-boot@lists.denx.de>; Stephen Warren <swar...@nvidia.com> Subject: Re: [PATCH 1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no SPL On 19 December 2017 at 18:30, Stephen Warren <swar...@wwwdotorg.org> wrote: > From: Stephen Warren <swar...@nvidia.com> > > 64-bit Tegra don't use SPL, and soon won't define CONFIG_SPL_TEXT_BASE > when building. Fix the binman .dts file so that it doesn't use > undefined values. > > Signed-off-by: Stephen Warren <swar...@nvidia.com> > --- > arch/arm/dts/tegra-u-boot.dtsi | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Simon Glass <s...@chromium.org> I've applied this series to u-boot-tegra/master. I'll wait a bit to see how your new series (RAM bank/mem parsing) is received and then I'll apply it, too, and post a PR. I assume you expect the Linux kernel image header patches to go in thru TomR? Tom -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no SPL
Stephen,
> -Original Message-
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Tuesday, December 19, 2017 6:31 PM
> To: Tom Warren <twar...@nvidia.com>
> Cc: Simon Glass <s...@chromium.org>; Tom Rini <tr...@konsulko.com>; u-
> b...@lists.denx.de; Stephen Warren <swar...@nvidia.com>
> Subject: [PATCH 1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no
> SPL
>
> From: Stephen Warren <swar...@nvidia.com>
>
> 64-bit Tegra don't use SPL, and soon won't define CONFIG_SPL_TEXT_BASE
> when building. Fix the binman .dts file so that it doesn't use undefined
> values.
>
> Signed-off-by: Stephen Warren <swar...@nvidia.com>
> ---
> arch/arm/dts/tegra-u-boot.dtsi | 15 +++++--
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
This series: Reviewed-by: Tom Warren <twar...@nvidia.com>
I'll wait a bit for other reviews & apply it to u-boot-tegra today or tomorrow.
Tom
> diff --git a/arch/arm/dts/tegra-u-boot.dtsi b/arch/arm/dts/tegra-u-boot.dtsi
> index cde591c5fca4..4f692ee97572 100644
> --- a/arch/arm/dts/tegra-u-boot.dtsi
> +++ b/arch/arm/dts/tegra-u-boot.dtsi
> @@ -1,5 +1,11 @@
> #include
>
> +#ifdef CONFIG_SPL_TEXT_BASE
> +#define U_BOOT_OFFSET (CONFIG_SYS_TEXT_BASE -
> CONFIG_SPL_TEXT_BASE)
> +#else #define U_BOOT_OFFSET 0 #endif
> +
> / {
> binman {
> multiple-images;
> @@ -9,8 +15,7 @@
> u-boot-spl {
> };
> u-boot {
> - pos = <(CONFIG_SYS_TEXT_BASE -
> - CONFIG_SPL_TEXT_BASE)>;
> + pos = <(U_BOOT_OFFSET)>;
> };
> };
>
> @@ -21,8 +26,7 @@
> u-boot-spl {
> };
> u-boot {
> - pos = <(CONFIG_SYS_TEXT_BASE -
> - CONFIG_SPL_TEXT_BASE)>;
> + pos = <(U_BOOT_OFFSET)>;
> };
> };
>
> @@ -32,8 +36,7 @@
> u-boot-spl {
> };
> u-boot-nodtb {
> - pos = <(CONFIG_SYS_TEXT_BASE -
> - CONFIG_SPL_TEXT_BASE)>;
> + pos = <(U_BOOT_OFFSET)>;
> };
> };
> };
> --
> 2.15.1
--
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit 2d3c4ae350fe8c196698681ab9410733bf9017e0: Prepare v2017.09-rc2 (2017-08-14 20:02:11 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 33848eb53e00156bb6bade1955b09d12daeffdc6: apalis_t30/tk1, colibri_t20/t30: fix i2c bus frequencies (2017-08-15 14:51:18 -0700) Marcel Ziswiler (4): apalis_t30: fix usb otg power enable dm: tegra: move apalis t30/tk1, colibri t20/t30 to livetree apalis-tk1: remove duplicate hdmi_ddc device tree node apalis_t30/tk1, colibri_t20/t30: fix i2c bus frequencies arch/arm/dts/tegra124-apalis.dts| 10 +++--- arch/arm/dts/tegra20-colibri.dts| 4 ++-- arch/arm/dts/tegra30-apalis.dts | 6 +++--- arch/arm/dts/tegra30-colibri.dts| 4 ++-- board/toradex/apalis_t30/pinmux-config-apalis_t30.h | 4 ++-- configs/apalis-tk1_defconfig| 4 configs/apalis_t30_defconfig| 1 + configs/colibri_t20_defconfig | 1 + configs/colibri_t30_defconfig | 1 + 9 files changed, 19 insertions(+), 16 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 00/12] tegra: nyan-big: Support chainloading and add documentation
I'm on vacation until Monday, 17 July. I can look at it then. -- nvpublic > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Saturday, July 08, 2017 9:09 AM > To: Thomas Hoff <thomashoff...@gmail.com> > Cc: Stephen Warren <swar...@wwwdotorg.org>; Marek Vasut > <ma...@denx.de>; Stephen Warren <swar...@nvidia.com>; Stefan Agner > <stefan.ag...@toradex.com>; Jagan Teki <ja...@openedev.com>; U-Boot > Mailing List <u-boot@lists.denx.de>; Tom Warren <twar...@nvidia.com>; > Riley Baird <ri...@openmailbox.org> > Subject: Re: [U-Boot] [PATCH 00/12] tegra: nyan-big: Support chainloading and > add documentation > > Hi, > > On 7 July 2017 at 01:27, Thomas Hoff <thomashoff...@gmail.com> wrote: > > Are you asking me or Tom Warren? > > > > On Thu, Jul 6, 2017 at 8:58 PM, Simon Glass <s...@chromium.org> wrote: > >> > >> Hi Tom, > >> > >> On 27 June 2017 at 14:09, Thomas Hoff <thomashoff...@gmail.com> wrote: > >> > Thanks a bunch Simon (and everyone else who contributed)! > >> > > >> > I followed the instructions and was able to get uboot to boot > >> > successfully. > >> > :D > >> > > >> > Now I just got to figure out how to get the kernel to boot in HYP mode. > >> > > >> > Cheers, > >> > > >> > Thomas > >> > > >> > > >> > > >> > > >> > > >> > On Fri, Jun 9, 2017 at 5:27 AM, Simon Glass <s...@chromium.org> wrote: > >> >> > >> >> Hi Stephen, > >> >> > >> >> On 7 June 2017 at 09:41, Stephen Warren <swar...@wwwdotorg.org> > wrote: > >> >> > On 06/07/2017 09:32 AM, Tom Warren wrote: > >> >> >> > >> >> >> Simon, > >> >> >> > >> >> >>> From: Simon Glass > >> >> > > >> >> > ... > >> >> >>> > >> >> >>> On 1 June 2017 at 07:52, Matthew Gorski > >> >> >>> <matt.gor...@gmail.com> > >> >> >>> wrote: > >> >> >>>> > >> >> >>>> > >> >> >>>> On Wed, May 31, 2017 at 2:28 PM, Matthew Gorski > >> >> >>>> <matt.gor...@gmail.com> wrote: > >> >> >>>>> > >> >> >>>>> On Mon, May 22, 2017 at 7:17 AM, Simon Glass > >> >> >>>>> <s...@chromium.org>> > >> >> >>>>> wrote: > >> >> >>>>>> > >> >> >>>>>> > >> >> >>>>>> Every now and then someone wants to chain-load U-Boot on a > >> >> >>>>>> Chromebook. > >> >> >>>>>> The procedure is not very complicated but there are some > >> >> >>>>>> oddities. > >> >> >>>>>> > >> >> >>>>>> This series updates a few things with allow U-Boot to start > >> >> >>>>>> on nyan-big in this way and adds documentation on how to do it. > >> >> >>>>>> This > >> >> >>>>>> provides a central place where the procedure on different > >> >> >>>>>> devices can be documented. > >> >> > > >> >> > ... > >> >> >>>>> > >> >> >>>>> Thank You for this Simon! Very much appreciated! I am > >> >> >>>>> going to give this a try later tonight and report back my > >> >> >>>>> personal results... > >> >> > > >> >> > ... > >> >> > > >> >> >>>> Confirmed! Chain-loading working on my nyan_big. I > >> >> >>>> appreciate this very much Simon and all who contributed. > >> >> >>> > >> >> >>> > >> >> >>> I'd like to pull in this series. Are there any comments / reviews? > >> >> >>> If > >> >> >>> affects both > >> >> >>> tegra and rockchip. > >> >> >> > >> >> >> I'm fine with it - I assume you'll pull it in to one of your repos > >> >> >> and > >> >> >> post a PR to get it into mainstream U-Boot? > >> >> >> I don't have the HW to test on (my nyan-big has been shelved), but > >> >> >> trust > >> >> >> in Matthew's testing, and that Stephen's U-Boot test scripts will > >> >> >> catch > >> >> >> any > >> >> >> problems, so LGTM. > >> >> > >> >> Thanks for looking at this. > >> >> > >> >> > > >> >> > > >> >> > Yes, my testing should catch most issues with any patches, although > >> >> > there > >> >> > are still some coverage holes: > >> >> > > >> >> > 1) I don't test cold boot; U-boot is always loaded over USB RCM which > >> >> > may > >> >> > hide bugs specific to cold booting. > >> >> > >> >> I tested cold bold on Nyan, but I use USB RCM also so don't normally > >> >> test cold boot. > >> >> > >> >> > > >> >> > 2) I only test on a few HW platforms (beaver, dalmore, Jetson TK1, > >> >> > p2371-, Jetson TX1) > >> >> > >> >> That's plenty :-) > >> >> > >> >> > > >> >> > 3) Obviously I don't test the new features introduced by this patch; > >> >> > chain-loading. > >> >> > >> >> It's OK I can rely on others for that so long as the changes are > >> >> acceptable to the normal boot case. > >> > >> Is this ready to be applied at some point? > > Tom Warren - he is the Tegra maintainer. > > >> > >> Regards, > >> Simon > > > > > > Regards, > Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. This is a bug fix, so please try to get it in to the next RC. Thanks. The following changes since commit e2351d5cf1e97408b4c52bafeaa85e0ca85c920c: Prepare v2017.07--rc2 (2017-06-19 20:41:27 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 542b5f85674b297f0d9aee7e6e50801f6c24bb45: tegra: mmc: Set the bus width correctly (2017-06-20 09:47:59 -0700) Simon Glass (1): tegra: mmc: Set the bus width correctly drivers/mmc/tegra_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra: mmc: Set the bus width correctly
Thanks, Simon. I'll take it in to u-boot-tegra/master for the next PR.
> -Original Message-
> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
> Sent: Wednesday, June 14, 2017 4:32 AM
> To: Peter Chubb <peter.ch...@data61.csiro.au>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Tom Warren
> <twar...@nvidia.com>; Stephen Warren <swar...@wwwdotorg.org>;
> Jaehoon Chung <jh80.ch...@samsung.com>; Stephen Warren
> <swar...@nvidia.com>
> Subject: Re: [PATCH] tegra: mmc: Set the bus width correctly
>
> Hi,
>
> On 7 June 2017 at 22:03, <peter.ch...@data61.csiro.au> wrote:
> >>>>>> "Simon" == Simon Glass <s...@chromium.org> writes:
> >
> > Simon> The driver currently does not reset bit 5 of the hostctl
> > Simon> register even if the MMC stack requests it. Then means that
> > Simon> once a bus width of 8 is selected it is not possible to change
> > Simon> it back to 1. This breaks 'mmc rescan' which needs to start off
> > Simon> with a bus width of 1.
> >
> > Simon> The problem was surfaced by enabling CONFIG_DM_MMC_OPS on
> > Simon> tegra. Without this option the MMC stack fully reinits the
> > Simon> driver on a 'mmc rescan'. But with this option driver model
> > Simon> does not re-probe a driver once it has been probed once.
> >
> > Simon> Fix the driver to honour the request.
> >
> > Simon> Signed-off-by: Simon Glass <s...@chromium.org> ---
> >
> > Tested-by: Peter Chubb <peter.ch...@data61.csiro.au>
> >
> > Simon> drivers/mmc/tegra_mmc.c | 2 +- 1 file changed, 1 insertion(+),
> > Simon> 1 deletion(-)
> >
> > Simon> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
> > Simon> index 338e42b528..7d945a172e 100644 ---
> > Simon> a/drivers/mmc/tegra_mmc.c +++ b/drivers/mmc/tegra_mmc.c @@
> > Simon> -438,7 +438,7 @@ static int tegra_mmc_set_ios(struct udevice
> > Simon> *dev) else if (mmc->bus_width == 4) ctrl |= (1 << 1); else -
> > Simon> ctrl &= ~(1 << 1); + ctrl &= ~(1 << 1 | 1 << 5);
> >
> > Simon> writeb(ctrl, >reg->hostctl); debug("mmc_set_ios:
> > Simon> hostctl = %08X\n", ctrl); -- 2.13.0.506.g27d5fe0cd-goog
>
> Thanks for testing this.
>
> Tom please note this is a bug fix.
>
> - Simon
--
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] Pull request, u-boot-tegra/master
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit 8cb3ce64f936f5dedbcfc1935c5caf31bb682474: Merge git://git.denx.de/u-boot-dm (2017-06-10 18:01:22 -0400) are available in the git repository at: git://git.denx.de/u-boot-tegra.git master for you to fetch changes up to 2eb3e28b2c69261d274bc22321f688c193985e7b: ARM: tegra: remove Whistler support (2017-06-12 13:03:50 -0700) Stephen Warren (1): ARM: tegra: remove Whistler support arch/arm/dts/Makefile | 1 - arch/arm/dts/tegra20-whistler.dts | 77 --- arch/arm/mach-tegra/tegra20/Kconfig | 5 --- board/nvidia/whistler/Kconfig | 12 -- board/nvidia/whistler/MAINTAINERS | 7 board/nvidia/whistler/Makefile | 8 board/nvidia/whistler/whistler.c| 80 - configs/whistler_defconfig | 29 -- include/configs/whistler.h | 49 --- 9 files changed, 268 deletions(-) delete mode 100644 arch/arm/dts/tegra20-whistler.dts delete mode 100644 board/nvidia/whistler/Kconfig delete mode 100644 board/nvidia/whistler/MAINTAINERS delete mode 100644 board/nvidia/whistler/Makefile delete mode 100644 board/nvidia/whistler/whistler.c delete mode 100644 configs/whistler_defconfig delete mode 100644 include/configs/whistler.h ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/31] dm: tegra: Move nyan-big and beaver to livetree
Simon, > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Thursday, June 08, 2017 8:06 PM > To: U-Boot Mailing List <u-boot@lists.denx.de> > Cc: Tom Rini <tr...@konsulko.com>; Marcel Ziswiler > <marcel.ziswi...@toradex.com>; Simon Glass <s...@chromium.org>; Heiko > Schocher <h...@denx.de>; Tom Warren <twar...@nvidia.com>; Jagannadha > Sutradharudu Teki <jagannadh.t...@gmail.com>; Stephen Warren > <swar...@wwwdotorg.org>; Jagan Teki <ja...@openedev.com>; Marek Vasut > <marek.va...@gmail.com>; Marek Vasut <ma...@denx.de>; Anatolij > Gustschin <ag...@denx.de>; Lukasz Majewski <l.majew...@samsung.com>; > Jerry Van Baren <vanba...@cideas.com>; Pavel Herrmann > <morpheus.i...@gmail.com>; Jaehoon Chung <jh80.ch...@samsung.com>; > Stephen Warren <swar...@nvidia.com> > Subject: Re: [PATCH v2 00/31] dm: tegra: Move nyan-big and beaver to livetree > > Hi Tom (Warren) / Marcel, > > On 2 June 2017 at 21:03, Simon Glass <s...@chromium.org> wrote: > > > > This moves an entire board to use a live device tree as an example of > > the impact. > > > > Nyan-big was chosen because I can easily and boot U-Boot without any > > media swapping, etc. Beaver is enabled as well since it failed to boot > > with serial v1 due to a disabled console node. > > > > Have you been able to test this v2 series? Some problems were reported with > v1 and I have found a few more since I discovered my jetson-tk1 board. I'm > planning to send a v3 soon, but please let me know if you see any issues. > I have neither a nyan-big setup right now, nor an beaver boards. Stephen's test harness should catch any gross build/boot failures if you apply it to a repo he supports (dm, etc.) Tom > Regards, > Simon -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 00/12] tegra: nyan-big: Support chainloading and add documentation
Simon, > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Wednesday, June 07, 2017 4:59 AM > To: Matthew Gorski <matt.gor...@gmail.com> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Sjoerd Simons > <sjoerd.sim...@collabora.co.uk>; Tomeu Vizoso > <tomeu.viz...@collabora.com>; Riley Baird <ri...@openmailbox.org>; Heiko > Schocher <h...@denx.de>; Patrick Delaunay <patrick.delau...@st.com>; > Masahiro Yamada <yamada.masah...@socionext.com>; Tom Warren > <twar...@nvidia.com>; Anatolij Gustschin <ag...@denx.de>; Jagannadha > Sutradharudu Teki <jagannadh.t...@gmail.com>; Keerthy <j-keer...@ti.com>; > Stephen Warren <swar...@wwwdotorg.org>; Jagan Teki > <ja...@openedev.com>; Marek Vasut <ma...@denx.de>; Albert Aribaud > <albert.u.b...@aribaud.net>; Stefan Agner <stefan.ag...@toradex.com>; > Allen Martin <amar...@nvidia.com>; Alexander Graf <ag...@suse.de>; > Jaehoon Chung <jh80.ch...@samsung.com>; Stephen Warren > <swar...@nvidia.com> > Subject: Re: [PATCH 00/12] tegra: nyan-big: Support chainloading and add > documentation > > Hi, > > On 1 June 2017 at 07:52, Matthew Gorski <matt.gor...@gmail.com> wrote: > > > > On Wed, May 31, 2017 at 2:28 PM, Matthew Gorski > > <matt.gor...@gmail.com> > > wrote: > >> > >> > >> > >> On Mon, May 22, 2017 at 7:17 AM, Simon Glass <s...@chromium.org> > wrote: > >>> > >>> Every now and then someone wants to chain-load U-Boot on a > Chromebook. > >>> The procedure is not very complicated but there are some oddities. > >>> > >>> This series updates a few things with allow U-Boot to start on > >>> nyan-big in this way and adds documentation on how to do it. This > >>> provides a central place where the procedure on different devices can be > documented. > >>> > >>> > >>> Simon Glass (12): > >>> arm: arm720t: Support CONFIG_SKIP_LOWLEVEL_INIT_ONLY > >>> tegra: Init clocks even when SPL did not run > >>> tegra: dts: Add cros-ec SPI settings > >>> arm: Rename HCTR to HTCR > >>> arm: Don't try to support CONFIG_ARMV7_LPAE on ARMv4T > >>> arm: Disable LPAE if not enabled > >>> tegra: spi: Wait a little after setting the clocks > >>> tegra: nyan-big: Enable the dhrystone benchmark > >>> tegra: video: Don't power up the SOR twice > >>> tegra: Enable CP15 init > >>> tegra: clock: Avoid a divide-by-zero error > >>> README: Add instructions for chain-loading U-Boot > >>> > >>> arch/arm/cpu/arm720t/start.S | 6 +- > >>> arch/arm/dts/tegra124-nyan-big-u-boot.dtsi | 9 ++ > >>> arch/arm/include/asm/arch-tegra/clock.h | 3 + > >>> arch/arm/lib/cache-cp15.c| 13 +- > >>> arch/arm/mach-tegra/board2.c | 3 + > >>> arch/arm/mach-tegra/clock.c | 10 +- > >>> arch/arm/mach-tegra/tegra124/clock.c | 18 +++ > >>> configs/nyan-big_defconfig | 2 + > >>> doc/README.chromium | 222 > >>> +++ > >>> doc/chromium/devkeys/kernel.keyblock | Bin 0 -> 1208 bytes > >>> doc/chromium/devkeys/kernel_data_key.vbprivk | Bin 0 -> 1199 bytes > >>> drivers/spi/tegra114_spi.c | 1 + > >>> drivers/video/tegra124/sor.c | 9 ++ > >>> include/configs/tegra-common-post.h | 2 +- > >>> 14 files changed, 292 insertions(+), 6 deletions(-) create mode > >>> 100644 doc/README.chromium create mode 100644 > >>> doc/chromium/devkeys/kernel.keyblock > >>> create mode 100644 doc/chromium/devkeys/kernel_data_key.vbprivk > >>> > >> Thank You for this Simon! Very much appreciated! I am going to give > >> this a try later tonight and report back my personal results... > >>> > >>> -- > >>> 2.13.0.303.g4ebf302169-goog > >>> > >> > > Confirmed! Chain-loading working on my nyan_big. I appreciate this > > very much Simon and all who contributed. > > I'd like to pull in this series. Are there any comments / reviews? If affects > both > tegra and rockchip. I'm fine with it - I assume you'll pull it in to one of your repos and post a PR to get it into mainstream U-Boot? I don't have the HW to test on (my nyan-big has been shelved), but trust in Matthew's testing, and that Stephen's U-Boot test scripts will catch any problems, so LGTM. Tom > > Regards, > Simon -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 8/8] tegra: Convert MMC to use driver model for operations
Simon, What testing did you do? Tom -- nvpublic > -Original Message- > From: s...@google.com [mailto:s...@google.com] > Sent: Thursday, May 18, 2017 9:01 AM > To: Simon Glass <s...@chromium.org> > Cc: Alban Bedel <alban.be...@avionic-design.de>; Max Krummenacher > <max.krummenac...@toradex.com>; Masahiro Yamada > <yamada.masah...@socionext.com>; Tom Warren <twar...@nvidia.com>; > peter.ch...@data61.csiro.au; Stephen Warren <swar...@wwwdotorg.org>; > Stefan Agner <stefan.ag...@toradex.com>; Lucas Stach <d...@lynxeye.de>; > Allen Martin <amar...@nvidia.com>; Marcel Ziswiler > <marcel.ziswi...@toradex.com>; Jaehoon Chung <jh80.ch...@samsung.com>; > Stephen Warren <swar...@nvidia.com>; U-Boot Mailing List b...@lists.denx.de> > Subject: Re: [PATCH 8/8] tegra: Convert MMC to use driver model for > operations > > Enable CONFIG_DM_MMC_OPS and CONFIG_BLK for all Tegra devices. This > moves Tegra to use driver model fully for MMC. > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > board/toradex/common/tdx-cfg-block.c | 2 +- > configs/apalis-tk1_defconfig | 2 - > configs/apalis_t30_defconfig | 2 - > configs/beaver_defconfig | 2 - > configs/cardhu_defconfig | 2 - > configs/cei-tk1-som_defconfig| 2 - > configs/colibri_t20_defconfig| 2 - > configs/colibri_t30_defconfig| 2 - > configs/dalmore_defconfig| 2 - > configs/e2220-1170_defconfig | 2 - > configs/harmony_defconfig| 2 - > configs/jetson-tk1_defconfig | 2 - > configs/medcom-wide_defconfig| 2 - > configs/nyan-big_defconfig | 2 - > configs/p2371-_defconfig | 2 - > configs/p2371-2180_defconfig | 2 - > configs/p2571_defconfig | 2 - > configs/p2771--000_defconfig | 2 - > configs/p2771--500_defconfig | 2 - > configs/paz00_defconfig | 2 - > configs/plutux_defconfig | 2 - > configs/seaboard_defconfig | 2 - > configs/tec-ng_defconfig | 2 - > configs/tec_defconfig| 2 - > configs/trimslice_defconfig | 2 - > configs/venice2_defconfig| 2 - > configs/ventana_defconfig| 2 - > configs/whistler_defconfig | 2 - > drivers/mmc/tegra_mmc.c | 72 > > 29 files changed, 42 insertions(+), 86 deletions(-) > > Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
