Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-18 Thread Rolf Ahrenberg

On Wed, 16 May 2007, Petri Helin wrote:

I have briefly tested the remux and spids patches and found one major 
problem. Somehow the "voice subtitling" or "audio subtitling" or "spoken 
subtitling" (whatever the correct naming might be) which is used on YLE's 
channels, is not correctly recognized. Normally there is the actual spoken 
language + dutch in the audio selection list, but with these patches I always 
end up with three options: 1, 2 and 33. In addition entries like this started 
to appear to the log: "switching to pre 1.3.19 Dolby Digital compatibility 
mode" and I've never seen them before.


I've uploaded a new of my patches that hopefully should correct the 
above mentioned problems.


--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-16 Thread Rolf Ahrenberg

On Wed, 16 May 2007, Petri Helin wrote:

language + dutch in the audio selection list, but with these patches I always 
end up with three options: 1, 2 and 33. In addition entries like this started 
to appear to the log: "switching to pre 1.3.19 Dolby Digital compatibility 
mode" and I've never seen them before.


Ok. There seems to be a bug while remuxing subtitle streams that get 
tagged with wrong id and VDR sets compatibility mode on and clear audio 
tracks.. So, the remux patch should be rewritten to support a real 
cSubtitleRepacker class. However, subtitles works for me in both live tv

and recordings, so the patch isn't completely broken :)

--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


[vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-16 Thread Arthur Konovalov

Arthur Konovalov wrote:

Pekka Virtanen wrote:

The problem is most likely caused by the fact that the PIDs for
subtitles are different than at the time the recording started.
Current implementation doesn't detect if PIDs change during recording.


I don't think so. Tried manual recording in the middle of program as well.



I discovered that only "primary" language saved with recording.
For example if set primary language to "eesti" and secondary to "suomi" and 
record YLE2 channel so result will be without subtitles.


If set primary to "suomi" - subtitles saved.

Br,
AK


___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-15 Thread Petri Helin

Rolf Ahrenberg wrote:

On Tue, 15 May 2007, Petri Helin wrote:


Rolf Ahrenberg wrote:
 Yes, you shouldn't need the remux.c and menu.c hunks anymore. The spids 


Hmm. It looks like menu.c needs to be patched?


Sorry about the misinformation. I don't use ttxtsubs, so I didn't check 
the combined patch.




No problem, just wanted to be sure I didn't miss something.

I have briefly tested the remux and spids patches and found one major 
problem. Somehow the "voice subtitling" or "audio subtitling" or "spoken 
subtitling" (whatever the correct naming might be) which is used on 
YLE's channels, is not correctly recognized. Normally there is the 
actual spoken language + dutch in the audio selection list, but with 
these patches I always end up with three options: 1, 2 and 33. In 
addition entries like this started to appear to the log: "switching to 
pre 1.3.19 Dolby Digital compatibility mode" and I've never seen them 
before.


-Petri

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-15 Thread Rolf Ahrenberg

On Tue, 15 May 2007, Petri Helin wrote:


Rolf Ahrenberg wrote:
 Yes, you shouldn't need the remux.c and menu.c hunks anymore. The spids 


Hmm. It looks like menu.c needs to be patched?


Sorry about the misinformation. I don't use ttxtsubs, so I didn't check 
the combined patch.


--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Petri Helin

Rolf Ahrenberg wrote:

On Mon, 14 May 2007, Petri Helin wrote:

So, I should just remove the part regarding remux.c from 
vdr-1.5.2-subtitles-0.5.0-and-ttxtsubs-0.0.5.diff patch to test these 
patches with 1.5.2, or do you have a matching subtitles&ttxtsubs patch 
to be used with the remux patch already?


Yes, you shouldn't need the remux.c and menu.c hunks anymore. The spids 


Hmm. It looks like menu.c needs to be patched?

menu.c: In constructor ‘cRecordControl::cRecordControl(cDevice*, 
cTimer*, bool)’:
menu.c:3846: error: no matching function for call to 
‘cRecorder::cRecorder(char*&, tChannelID, int, int, const int*, const 
int*, const int*)’
recorder.h:32: note: candidates are: cRecorder::cRecorder(const char*, 
tChannelID, int, int, const int*, const int*, const int*, 
cTtxtSubsRecorderBase*)

recorder.h:22: note: cRecorder::cRecorder(const cRecorder&)
make: *** [menu.o] Error 1


-Petri

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Rolf Ahrenberg

On Mon, 14 May 2007, Petri Helin wrote:

So, I should just remove the part regarding remux.c from 
vdr-1.5.2-subtitles-0.5.0-and-ttxtsubs-0.0.5.diff patch to test these patches 
with 1.5.2, or do you have a matching subtitles&ttxtsubs patch to be used 
with the remux patch already?


Yes, you shouldn't need the remux.c and menu.c hunks anymore. The spids 
patch doesn't save found pids into channels.conf yet and therefore it 
takes awhile until pids are found when you're tuning to a channel first 
time.


--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Petri Helin

Rolf Ahrenberg wrote:
I've done and using (and sent to Klaus) two patches (spids & remux) that 
detects automatically changes in subtitle pids as it's done nowadays 
with audio pids and records all available subtitle tracks. I don't see 
any benefits using fixed pids...




So, I should just remove the part regarding remux.c from 
vdr-1.5.2-subtitles-0.5.0-and-ttxtsubs-0.0.5.diff patch to test these 
patches with 1.5.2, or do you have a matching subtitles&ttxtsubs patch 
to be used with the remux patch already?


-Petri

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Petri Helin

Rolf Ahrenberg wrote:

On Mon, 14 May 2007, Petri Helin wrote:

Since the subtitle pids are always the same (at least I think they are 
on Finnish channels: Finnish subtitles can be found from 1027 for TV1, 
2027 for TV2, 3027 for FST, 4027 for Teema and 5027 for Extra), would 
it be hard to add a possibility to fix the pids per channel? Maybe 
through setup.


I've done and using (and sent to Klaus) two patches (spids & remux) that 
detects automatically changes in subtitle pids as it's done nowadays 
with audio pids and records all available subtitle tracks. I don't see 
any benefits using fixed pids...




Of course that is the preferred way to go. I was just thinking "a quick 
fix" type of solution...


Also all OSD opening problems should be fixed hopefully in the latest 
versions of my subtitles patches. Sorry, cannot remember the exact 
version, but atleast vdr-1.5.2-subtitles-0.5.0.diff should contain the fix.




I'll have to check which patches I have applied and come back to this if 
 the latest ones still have the OSD opening problem.


-Petri

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Rolf Ahrenberg

On Mon, 14 May 2007, Petri Helin wrote:

Since the subtitle pids are always the same (at least I think they are on 
Finnish channels: Finnish subtitles can be found from 1027 for TV1, 2027 for 
TV2, 3027 for FST, 4027 for Teema and 5027 for Extra), would it be hard to 
add a possibility to fix the pids per channel? Maybe through setup.


I've done and using (and sent to Klaus) two patches (spids & remux) that 
detects automatically changes in subtitle pids as it's done nowadays 
with audio pids and records all available subtitle tracks. I don't see 
any benefits using fixed pids...


Also all OSD opening problems should be fixed hopefully in the latest 
versions of my subtitles patches. Sorry, cannot remember the exact 
version, but atleast vdr-1.5.2-subtitles-0.5.0.diff should contain the 
fix.


--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


[vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Arthur Konovalov

Pekka Virtanen wrote:

The problem is most likely caused by the fact that the PIDs for
subtitles are different than at the time the recording started.
Current implementation doesn't detect if PIDs change during recording.


I don't think so. Tried manual recording in the middle of program as well.

Br,
AK


___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Petri Helin

Pekka Virtanen wrote:

On 5/14/07, Arthur Konovalov <[EMAIL PROTECTED]> wrote:

Ville Aakko wrote:
> Wathing the program in real-time has no problems, there I can see the
> subtitles without problems. Only the recordings have problems.

I have similar issue with YLE1 and YLE2. Sometimes subtitles saved, 
sometimes

not. ProjectX shows same: no subtitles- no DVB stream. And vice versa.


The problem is most likely caused by the fact that the PIDs for
subtitles are different than at the time the recording started.
Current implementation doesn't detect if PIDs change during recording.
As a workaround you can set your time e.g. 1 minute after the program
has begun.



Since the subtitle pids are always the same (at least I think they are 
on Finnish channels: Finnish subtitles can be found from 1027 for TV1, 
2027 for TV2, 3027 for FST, 4027 for Teema and 5027 for Extra), would it 
be hard to add a possibility to fix the pids per channel? Maybe through 
setup.


-Petri

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Pekka Virtanen

On 5/14/07, Arthur Konovalov <[EMAIL PROTECTED]> wrote:

Ville Aakko wrote:
> Wathing the program in real-time has no problems, there I can see the
> subtitles without problems. Only the recordings have problems.

I have similar issue with YLE1 and YLE2. Sometimes subtitles saved, sometimes
not. ProjectX shows same: no subtitles- no DVB stream. And vice versa.


The problem is most likely caused by the fact that the PIDs for
subtitles are different than at the time the recording started.
Current implementation doesn't detect if PIDs change during recording.
As a workaround you can set your time e.g. 1 minute after the program
has begun.

--
pekka

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


[vdr] Re: Problem with multiple audio channels and DVB subtitles in recordings (YLE Teema)

2007-05-14 Thread Arthur Konovalov

Ville Aakko wrote:

Wathing the program in real-time has no problems, there I can see the
subtitles without problems. Only the recordings have problems.


I have similar issue with YLE1 and YLE2. Sometimes subtitles saved, sometimes 
not. ProjectX shows same: no subtitles- no DVB stream. And vice versa.


At moment using vdr-1.4.6-1, subtitles-0.5, and ttxtsubs-0.0.5-LHE plugins 
patched with vdr-1.4.4-subtitles-0.4.0-and-ttxtsubs-0.0.5.diff.


Br,
AK


___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr