Change in vdsm[master]: vm: discover volume path from xml definition
Vinzenz Feenstra has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 1: Code-Review+1 (1 comment) Event though I think this would have deserved two patches http://gerrit.ovirt.org/#/c/24202/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3219: # Filter volumes related to this image Line 3220: imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys() Line 3221: imgPath = dom.activateVolumes(imgUUID, imgVolumes) Line 3222: if spUUID and spUUID != sd.BLANK_UUID: Line 3223: runImgPath = dom.linkBCImage(imgUUID, imgPath) This change is not really required... The order was changed, so to me this seems to be required Line 3224: else: Line 3225: runImgPath = imgPath Line 3226: Line 3227: leafPath = os.path.join(runImgPath, leafUUID) -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
Sergey Gotliv has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24202/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3219: # Filter volumes related to this image Line 3220: imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys() Line 3221: imgPath = dom.activateVolumes(imgUUID, imgVolumes) Line 3222: if spUUID and spUUID != sd.BLANK_UUID: Line 3223: runImgPath = dom.linkBCImage(imgUUID, imgPath) The order was changed, so to me this seems to be required I see that the order was changed :-). The question is why? This file can stay unchanged if the old order will be restored :-). Line 3224: else: Line 3225: runImgPath = imgPath Line 3226: Line 3227: leafPath = os.path.join(runImgPath, leafUUID) -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect numa information
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Collect numa information .. Patch Set 4: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6272/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7162/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7051/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/23703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add initial tests for timeOffset handling
Francesco Romani has uploaded a new change for review.
Change subject: tests: add initial tests for timeOffset handling
..
tests: add initial tests for timeOffset handling
the handling of timeOffset has been a source of issues
recently and deserves more testing.
Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3
Signed-off-by: Francesco Romani from...@redhat.com
---
M tests/vmTests.py
1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/24252/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 1e0a3f6..30c6745 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -24,7 +24,9 @@
import vm
from vdsm import constants
+from vdsm import define
from testrunner import VdsmTestCase as TestCaseBase
+from testrunner import permutations, expandPermutations
import caps
from vdsm import utils
from vdsm import libvirtconnection
@@ -629,3 +631,30 @@
lambda: fc25cbbe-5520-4f83-b82e-1541914753d9)
def testBuildCmdLinePPC64(self):
self.assertBuildCmdLine(CONF_TO_DOMXML_PPC64)
+
+
+@expandPermutations
+class TestVmOperations(TestCaseBase):
+BASE_OFFSET = 42
+UPDATE_OFFSET = 3200 # just a number, no particular meaning
+
+@MonkeyPatch(constants, 'P_VDSM_RUN', '/tmp/')
+@MonkeyPatch(libvirtconnection, 'get', lambda x: ConnectionMock())
+@permutations([[define.NORMAL], [define.ERROR]])
+def testTimeOffsetRoundtrip(self, exitCode):
+fake = vm.Vm(None, {'vmId': 'TESTING1',
+'timeOffset': self.BASE_OFFSET})
+fake.setDownStatus(exitCode, testing)
+assert fake.getStats()['timeOffset'] == self.BASE_OFFSET
+
+@MonkeyPatch(constants, 'P_VDSM_RUN', '/tmp/')
+@MonkeyPatch(libvirtconnection, 'get', lambda x: ConnectionMock())
+@permutations([[define.NORMAL], [define.ERROR]])
+def testTimeOffsetUpdate(self, exitCode):
+# bz956741
+fake = vm.Vm(None, {'vmId': 'TESTING1',
+'timeOffset': self.BASE_OFFSET})
+fake._rtcUpdate(self.UPDATE_OFFSET)
+fake.setDownStatus(exitCode, testing)
+assert fake.getStats()['timeOffset'] == str(
+self.BASE_OFFSET + self.UPDATE_OFFSET)
--
To view, visit http://gerrit.ovirt.org/24252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add initial tests for timeOffset handling
Francesco Romani has posted comments on this change. Change subject: tests: add initial tests for timeOffset handling .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
Federico Simoncelli has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24202/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3219: # Filter volumes related to this image Line 3220: imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys() Line 3221: imgPath = dom.activateVolumes(imgUUID, imgVolumes) Line 3222: if spUUID and spUUID != sd.BLANK_UUID: Line 3223: runImgPath = dom.linkBCImage(imgUUID, imgPath) I see that the order was changed :-). The question is why? Yeah sorry for this, I changed the order because the required argument here is imgUUID. The additional imgPath argument is in the interface only to satisfy one of the specific implementations (block domains). I think we can plan to remove it later on. I'll try to add a comment on this in the commit message. Line 3224: else: Line 3225: runImgPath = imgPath Line 3226: Line 3227: leafPath = os.path.join(runImgPath, leafUUID) -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: document the launchPaused parameter
Francesco Romani has posted comments on this change. Change subject: schema: document the launchPaused parameter .. Patch Set 1: Verified+1 schema is translated correctly, thus marking as verified. -- To view, visit http://gerrit.ovirt.org/24144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I279e68c7e6b2cca8496a5dbec6e3895d531bce97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add initial tests for timeOffset handling
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add initial tests for timeOffset handling .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7163/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7052/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: client: update the help of `create` command
Francesco Romani has posted comments on this change. Change subject: client: update the help of `create` command .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a1f755d3586a232e3645afc2ebe6613814225cc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
Sergey Gotliv has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect
Nir Soffer has posted comments on this change. Change subject: sp: stop all poolMonitoredDomains on disconnect .. Patch Set 1: (2 comments) Looks good but needs a commit message. http://gerrit.ovirt.org/#/c/24088/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-02-04 06:54:00 -0500 Line 4: Commit: Federico Simoncelli fsimo...@redhat.com Line 5: CommitDate: 2014-02-04 17:37:05 -0500 Line 6: Line 7: sp: stop all poolMonitoredDomains on disconnect Not clear Can you add more context? why the previous code was not stopping all the monitored domains? How the new code ensure that all domains owned by the pool are stopped? Line 8: Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1059757 Line 10: Change-Id: Ibc77988b01491f687fd7afa6bb34512b5f2451af http://gerrit.ovirt.org/#/c/24088/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 628: return True Line 629: Line 630: @unsecured Line 631: def stopMonitoringDomains(self): Line 632: for sdUUID in self.domainMonitor.poolMonitoredDomains: and reversing it? Looks correct - we want to stop all monitors for domains that belong to this pool. It is not clear why getDomains does not return the same list though. Ayal: your questions is not clear Line 633: self.domainMonitor.stopMonitoring(sdUUID) Line 634: return True Line 635: Line 636: @unsecured -- To view, visit http://gerrit.ovirt.org/24088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc77988b01491f687fd7afa6bb34512b5f2451af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add initial tests for timeOffset handling
Martin Polednik has posted comments on this change. Change subject: tests: add initial tests for timeOffset handling .. Patch Set 1: I'm not sure we need to test it at this moment: according to Michal, timeOffset is mostly legacy and will remain unused, maybe eventually be removed in future. -- To view, visit http://gerrit.ovirt.org/24252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add initial tests for timeOffset handling
Francesco Romani has posted comments on this change. Change subject: tests: add initial tests for timeOffset handling .. Patch Set 1: I'm OK with this, the only problem is when this will be removed (I guess not before 4.0) In the meantime, I thought a bit of testing won't hurt, but of course discussion is welcome. -- To view, visit http://gerrit.ovirt.org/24252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Nest try-finally for temporary secure change
Ayal Baron has posted comments on this change. Change subject: sp: Nest try-finally for temporary secure change .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9054063db0eeacd156a8e586681496515f80e2b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add initial tests for timeOffset handling
Martin Polednik has posted comments on this change. Change subject: tests: add initial tests for timeOffset handling .. Patch Set 1: Code-Review+1 Definitely +1 on the code if the test itself is desired. -- To view, visit http://gerrit.ovirt.org/24252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
Martin Polednik has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
Francesco Romani has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 1: Code-Review+1 Looks good, and just for the record I agree the optimal solution would have been to have two patches. -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Fix connection reset on Python 2.6
Antoni Segura Puimedon has posted comments on this change. Change subject: xmlrpc: Fix connection reset on Python 2.6 .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24026/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 159: bind_and_activate) Line 160: Line 161: # Fix for connection reset issue when running on Python 2.6. This happens Line 162: # when request is aborted before the reading the entire request. Closing Line 163: # the socket cause the other side to receive connection reset, and loose s/loose/lose/ Line 164: # the response data. Python 2.7 introduced the shutdown_request method, Line 165: # fixing this issue. If we run on a version without this method, we will do Line 166: # a clean shutdown in close_request instead. Line 167: if not hasattr(SimpleXMLRPCServer, 'shutdown_request'): -- To view, visit http://gerrit.ovirt.org/24026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id77a32bb0d4fff13ee680eade52a2f60e4e808b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: fix RTC offset
Hello Dan Kenigsberg, Peter V. Saveliev,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24260
to review the following change.
Change subject: vdsm: fix RTC offset
..
vdsm: fix RTC offset
Upon RTC update (hwclock --systohc) on the guest side, libvirt sends the event
with RTC offset from the qemu start -rtc value in seconds. The received offset
should not replace the previous value, but should be added to it. Since the
time update event is relative to the qemu start time, we should store the
initial value and use it for the calculation.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956741
Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Signed-off-by: Peter V. Saveliev p...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/14750
Tested-by: Martin Polednik mpole...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/24260/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 475f6ce..eabb276 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1742,6 +1742,7 @@
self.id = self.conf['vmId']
self._volPrepareLock = threading.Lock()
self._initTimePauseCode = None
+self._initTimeRTC = long(self.conf.get('timeOffset', 0))
self.guestAgent = None
self._guestEvent = 'Powering up'
self._guestEventTime = 0
@@ -2268,9 +2269,10 @@
timer.start()
def _rtcUpdate(self, timeOffset):
-self.log.debug('new rtc offset %s', timeOffset)
+newTimeOffset = str(self._initTimeRTC + long(timeOffset))
+self.log.debug('new rtc offset %s', newTimeOffset)
with self._confLock:
-self.conf['timeOffset'] = timeOffset
+self.conf['timeOffset'] = newTimeOffset
def extendDriveVolume(self, vmDrive):
if not vmDrive.blockDev:
--
To view, visit http://gerrit.ovirt.org/24260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: fix RTC offset
Francesco Romani has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Require format attribute for drives
Federico Simoncelli has posted comments on this change.
Change subject: vm: Require format attribute for drives
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24234/1/vdsm/vm.py
File vdsm/vm.py:
Line 1441: VOLWM_FREE_PCT = 100 - config.getint('irs',
'volume_utilization_percent')
Line 1442: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during
replication
Line 1443:
Line 1444: def __init__(self, conf, log, **kwargs):
Line 1445: if 'format' not in kwargs:
We can, but this will hide the faulty code calling us without a required pa
Setting a default is wrong and failing is harsh.
There's also another case that we want to fix: what if the parameter is wrong?
(e.g. format passed by engine == 'raw' but volume is cow? or the other way
around).
On creation:
* if the parameter is missing it should be filled in with a value taken from
the metadata (e.g. getVolumeInfo)
* if the parameter is present and wrong we want to fail
Later on (e.g. migration or vdsm restart):
* if the parameter is missing it should be filled in with a value taken from
getVolumeInfo or using what libvirt reports in its xml (but we probably want to
log this as there's a bug somewhere)
Basically the format passed by engine instead of being mandatory should be
optional and validated for correctness if present.
Line 1446: raise InvalidDeviceParameters('format attribute is
required:'
Line 1447: ' %r' % kwargs)
Line 1448: if not kwargs.get('serial'):
Line 1449: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit http://gerrit.ovirt.org/24234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Meital Bourvine mbour...@redhat.com
Gerrit-Reviewer: Meital bourvine meitalbourv...@gmail.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vdsm: fix RTC offset
Martin Polednik has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Verified+1 Behaves same as master. -- To view, visit http://gerrit.ovirt.org/24196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
Dan Kenigsberg has posted comments on this change.
Change subject: vm: discover volume path from xml definition
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/24202/1//COMMIT_MSG
Commit Message:
Line 22: domain
Line 23:
Line 24: In this patch:
Line 25:
Line 26: - revert to the previous path for virtual machine images
Is this really necessary? could you explain why? I think that the former change
was not inadvertent - it was an attempt to remove a reference to the pool.
Line 27: - inspect libvirt xml during live migration and vdsm restart to
Line 28: identify if it is necessary to update the path cached in the
Line 29: drive object (provided by prepareImage)
Line 30:
http://gerrit.ovirt.org/#/c/24202/1/vdsm/vm.py
File vdsm/vm.py:
Line 4980: d.address = address
Line 4981: d.readonly = readonly
Line 4982: if bootOrder:
Line 4983: d.bootOrder = bootOrder
Line 4984: self.log.debug('Matched %s',
mergeDicts(deviceDict, d))
imo, the previous added block would have been slightly more readable on an
elif block here.
Line 4985: # Update vm's conf with address for known disk devices
Line 4986: knownDev = False
Line 4987: for dev in self.conf['devices']:
Line 4988: # See comment in previous loop. This part is used to
update
--
To view, visit http://gerrit.ovirt.org/24202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: fix RTC offset
Martin Polednik has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Verified+1 Time reported correctly (fortunately no modification required). -- To view, visit http://gerrit.ovirt.org/24260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vdsm: fix RTC offset
Francesco Romani has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Thanks Martin for the verification! I was installing things to give it a try but you were faster! -- To view, visit http://gerrit.ovirt.org/24196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Fix missing MAX_DOMAINS constant
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Fix missing MAX_DOMAINS constant .. hsm: Fix missing MAX_DOMAINS constant Commit ab6014b394 moved MAX_DOMAINS from sp to spbackends without updating all users, breaking creation of a pool on block storage using old storage domain format. This patch fix the error by importing the name from its new module. Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11 Bug-Url: https://bugzilla.redhat.com/1059108 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24242 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use same constants for configuring and check configure of sa...
Federico Simoncelli has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 1: (3 comments) I think we can improve this further. http://gerrit.ovirt.org/#/c/24011/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 104: return True Line 105: except RuntimeError: Line 106: return False Line 107: Line 108: Let's make the entire thing more explicit then: SANLOCK_GROUPS = (QEMU_PROCESS_GROUP, VDSM_GROUP) Line 109: class SanlockModuleConfigure(_ModuleConfigure): Line 110: def __init__(self): Line 111: super(SanlockModuleConfigure, self).__init__() Line 112: Line 126: rc, out, err = utils.execCmd( Line 127: ( Line 128: '/usr/sbin/usermod', Line 129: '-a', Line 130: '-G', and here: ,.join(self.SANLOCK_GROUPS) Line 131: '%s,%s' % (QEMU_PROCESS_GROUP, VDSM_GROUP), Line 132: 'sanlock' Line 133: ), Line 134: raw=True, Line 158: break Line 159: else: Line 160: raise RuntimeError(Unable to find sanlock service groups) Line 161: configured = grp.getgrnam(QEMU_PROCESS_GROUP)[2] in groups and \ Line 162: grp.getgrnam(VDSM_GROUP)[2] in groups Use SANLOCK_GROUPS here for verification as well. Line 163: except IOError as e: Line 164: if e.errno == os.errno.ENOENT: Line 165: sys.stdout.write(sanlock service is not running\n) Line 166: # if sanlock service is not running we cannot check if -- To view, visit http://gerrit.ovirt.org/24011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: add __slots__ to devices
Michal Skrivanek has posted comments on this change. Change subject: vmDevices: add __slots__ to devices .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/21036/5//COMMIT_MSG Commit Message: Line 8: Line 9: VDSM devices are created using setattr over **kwargs, making the Line 10: initialization implicit. Implementing __slots__ does define which Line 11: attributes does the device accept and also slightly improves memory footprint. Line 12: Please add related bug: well, it's not really part of the patch, it's just an example of why we want to introduce this patch. I'd add a normal reference in commit message as an example of issues Line 13: Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a -- To view, visit http://gerrit.ovirt.org/21036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
Michal Skrivanek has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/22194/2/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 272: deviceDef['hotplugDisk']),
timeout=10)
Line 273:
Line 274: @permutations([['self'], ['specParams'], ['vmPayload']])
Line 275: def testVmWithCdrom(self, pathLocation):
Line 276: fd, path = tempfile.mkstemp()
do we remove the file on failures?
Line 277: os.chmod(path, 0o644)
Line 278:
Line 279: cdrom = {'index': '2', 'iface': 'ide', 'specParams':
Line 280: {}, 'readonly': 'true', 'path':
--
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/22194/2/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 272: deviceDef['hotplugDisk']),
timeout=10)
Line 273:
Line 274: @permutations([['self'], ['specParams'], ['vmPayload']])
Line 275: def testVmWithCdrom(self, pathLocation):
Line 276: fd, path = tempfile.mkstemp()
you should use the temporaryPath contextmanager from tests/testrunner.py
Line 277: os.chmod(path, 0o644)
Line 278:
Line 279: cdrom = {'index': '2', 'iface': 'ide', 'specParams':
Line 280: {}, 'readonly': 'true', 'path':
--
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
Federico Simoncelli has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/22194/2/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 283:
Line 284: customization = {'vmId':
'----',
Line 285: 'vmName': 'testVm', 'devices': [cdrom]}
Line 286:
Line 287: if (pathLocation == 'self'):
Can you look at the previous test (deviceDef). Maybe you can use the same
approach here as well.
Line 288: cdrom['path'] = path
Line 289: cdrom['specParams']['path'] = '/dev/null'
Line 290: elif (pathLocation == 'specParams'):
Line 291: cdrom['path'] = ''
--
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Michal Skrivanek has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/22631/7/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 5388: user make it a bit clearer the admin shutdown is the one triggered from the UI, user shutdown is when run from within the guest -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Antoni Segura Puimedon has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 7: Code-Review-1 (1 comment) constants should go in UPPER_CASE http://gerrit.ovirt.org/#/c/22631/7/vdsm/vm.py File vdsm/vm.py: Line 88: MigrationSucceeded = 4 Line 89: SaveStateSucceeded = 5 Line 90: AdminShutdown = 6 Line 91: UserShutdown = 7 Line 92: MigrationFailed = 8 All these are constants. They should be completely uppercase: SUCCESS GENERIC_ERROR ... MIGRATION_FAILED And I would probably not have a class for it but a module (for consistency with the error code declaration of vdsm/neterrors.py) Line 93: Line 94: Line 95: def isVdsmImage(drive): Line 96: -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Federico Simoncelli has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 7: Code-Review+1 Ok for me when you address Antoni's request. -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Antoni Segura Puimedon has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/22631/7/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 5388: user make it a bit clearer the admin shutdown is the one triggered from the UI, If I'm not mistaken: s/an user/a user/ As the u in this case has a consonant behavior in its first phoneme. -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/135/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7164/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/74/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7053/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Michal Skrivanek has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py File vdsm/clientIF.py: Line 284: shoaw_bug typo shoaw -- To view, visit http://gerrit.ovirt.org/22928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Antoni Segura Puimedon has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 315: self.log.info(prepared volume path: %s, volPath)
Line 316: return volPath
Line 317:
Line 318: def _prepareVolumeFromPayload(self, vmId, drive, device, payload):
Line 319: '''
s/'''//
Line 320: vmPayload is a key in params
Line 321: 'vmPayload': {'volId': 'volume id', # volId is optional
Line 322: 'file': {'filename': 'content', ...}}
Line 323: '''
Line 330:
Line 331: try:
Line 332: mkFsFunction = getattr(supervdsm.getProxy(),
Line 333:mkFsNames[device])
Line 334: except RuntimeError:
Can you elaborate on the change of checking for RuntimeError (very generic)
instead of AttributeError
Line 335: raise vm.VolumeError(Supervdsm call failed for %s in
Line 336: drive: %s % (device, drive))
Line 337:
Line 338: return mkFsFunction(vmId, payload['file'],
payload.get('volId'))
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Michal Skrivanek has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py File vdsm/clientIF.py: Line 334: RuntimeError can you please add this to commit msg that we're do extra check for the supervdsm call -- To view, visit http://gerrit.ovirt.org/22928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Require format attribute for drives
Nir Soffer has posted comments on this change.
Change subject: vm: Require format attribute for drives
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24234/1/vdsm/vm.py
File vdsm/vm.py:
Line 1441: VOLWM_FREE_PCT = 100 - config.getint('irs',
'volume_utilization_percent')
Line 1442: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during
replication
Line 1443:
Line 1444: def __init__(self, conf, log, **kwargs):
Line 1445: if 'format' not in kwargs:
Setting a default is wrong and failing is harsh.
This is too complicated and has too much heuristics. Do you see any reason why
the parameter is missing when creating a drive?
Line 1446: raise InvalidDeviceParameters('format attribute is
required:'
Line 1447: ' %r' % kwargs)
Line 1448: if not kwargs.get('serial'):
Line 1449: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit http://gerrit.ovirt.org/24234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Meital Bourvine mbour...@redhat.com
Gerrit-Reviewer: Meital bourvine meitalbourv...@gmail.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: Fix missing MAX_DOMAINS constant
Hello Yaniv Bronhaim, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24264 to review the following change. Change subject: hsm: Fix missing MAX_DOMAINS constant .. hsm: Fix missing MAX_DOMAINS constant Commit ab6014b394 moved MAX_DOMAINS from sp to spbackends without updating all users, breaking creation of a pool on block storage using old storage domain format. This patch fix the error by importing the name from its new module. Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11 Bug-Url: https://bugzilla.redhat.com/1059108 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24242 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/24264/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 53c9dd0..5efa4ec 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -40,7 +40,7 @@ from vdsm.config import config import sp -from spbackends import MAX_POOL_DESCRIPTION_SIZE +from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS from spbackends import StoragePoolDiskBackend from spbackends import StoragePoolMemoryBackend import domainMonitor @@ -948,7 +948,7 @@ msdVersion = msd.getVersion() if (msdType in sd.BLOCK_DOMAIN_TYPES and msdVersion in blockSD.VERS_METADATA_LV and -len(domList) sp.MAX_DOMAINS): +len(domList) MAX_DOMAINS): raise se.TooManyDomainsInStoragePoolError() for sdUUID in domList: -- To view, visit http://gerrit.ovirt.org/24264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: Fix missing MAX_DOMAINS constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix missing MAX_DOMAINS constant .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/136/ : FAILURE http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/75/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
Martin Polednik has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 7: Verified+1 Jenkins messages seem unrelated; tested by functional test and on oVirt setup with GA installed. -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guest: Add support for guest cpu topology
oVirt Jenkins CI Server has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7166/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7055/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I827ab095ee9270faf27f44e91c7bc998e133351e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6275/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/137/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7165/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/76/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7054/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Require format attribute for drives
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Require format attribute for drives
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24234/1/vdsm/vm.py
File vdsm/vm.py:
Line 1441: VOLWM_FREE_PCT = 100 - config.getint('irs',
'volume_utilization_percent')
Line 1442: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during
replication
Line 1443:
Line 1444: def __init__(self, conf, log, **kwargs):
Line 1445: if 'format' not in kwargs:
This is too complicated and has too much heuristics. Do you see any reason
And most importantly, for base images guessing the format is a known security
problem (the owner of a VM with raw format can mess with his image too look
like a qcow, and gain read/write on any other image on next boot).
Line 1446: raise InvalidDeviceParameters('format attribute is
required:'
Line 1447: ' %r' % kwargs)
Line 1448: if not kwargs.get('serial'):
Line 1449: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit http://gerrit.ovirt.org/24234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Meital Bourvine mbour...@redhat.com
Gerrit-Reviewer: Meital bourvine meitalbourv...@gmail.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Francesco Romani has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 7: Verified+1 Patch Set 7: addressed reviewers comment. No code changes. -- To view, visit http://gerrit.ovirt.org/22928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(3 comments)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 284: shoaw_bug
typo shoaw
Done (tnx for spotting this!)
Line 315: self.log.info(prepared volume path: %s, volPath)
Line 316: return volPath
Line 317:
Line 318: def _prepareVolumeFromPayload(self, vmId, drive, device, payload):
Line 319: '''
s/'''//
Done
Line 320: vmPayload is a key in params
Line 321: 'vmPayload': {'volId': 'volume id', # volId is optional
Line 322: 'file': {'filename': 'content', ...}}
Line 323: '''
Line 330:
Line 331: try:
Line 332: mkFsFunction = getattr(supervdsm.getProxy(),
Line 333:mkFsNames[device])
Line 334: except RuntimeError:
Can you elaborate on the change of checking for RuntimeError (very generic)
Here I was trying to comply to Nir's comment in revision 4
(http://gerrit.ovirt.org/#/c/22928/4/vdsm/clientIF.py,cm)
For the sake of review, I'm quoting myself here:
supervdsm.ProxyCaller wraps a multiprocessing' RemoteError into a RuntimeError
and then retries to ensure the connection.
Then I handled RuntimeError here and changed the message in the exception.
I'll add (an amended version of) the above in the code as comment to explain
why I catch a such generic error.
Line 335: raise vm.VolumeError(Supervdsm call failed for %s in
Line 336: drive: %s % (device, drive))
Line 337:
Line 338: return mkFsFunction(vmId, payload['file'],
payload.get('volId'))
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7167/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7056/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Francesco Romani has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/22631/7/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 5388: user make it a bit clearer the admin shutdown is the one triggered from the UI, Done both -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect numa information
Francesco Romani has posted comments on this change. Change subject: caps: Collect numa information .. Patch Set 4: (2 comments) Just a couple of things in the commit message and it is good for me. http://gerrit.ovirt.org/#/c/23703/4//COMMIT_MSG Commit Message: Line 8: Line 9: This patch modifies the caps module to add function of collect Line 10: host numa information and report to ovirt engine. Line 11: It will add a key named numaNodes in the xml rpc response of Line 12: getCapabilities whose value is the host's numa information. Add one blank line here for readability, please. Line 13: An example of the value: 0:0,1:10240:9500;1:2,3:10240:9700 Line 14: The items are separated by semicolon, the fields in each item Line 15: are separated by colon. Line 16: Take the first item above to explain the meaning of each field: Line 14: The items are separated by semicolon, the fields in each item Line 15: are separated by colon. Line 16: Take the first item above to explain the meaning of each field: Line 17: 0 - The index of numa node Line 18: 0,1- The index of cpu which belong to this numa node Thanks, we're almost there. Is this socket_id,core_id? If so, I'd change the text as something like that The index of cpu (socket, core) which belong to this numa node. Line 19: 10240 - The total memory of this numa node Line 20: 9500 - The free memory of this numa node Line 21: Line 22: Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd -- To view, visit http://gerrit.ovirt.org/23703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: ifcfg configurator static methods and list handling
Itamar Heim has posted comments on this change. Change subject: cleanup: ifcfg configurator static methods and list handling .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/20536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83051a07d3b907ba31a01f75e64f01f3f2e7a165 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: only warn when failing to deactivate lvs after ali...
Itamar Heim has posted comments on this change. Change subject: clientIF: only warn when failing to deactivate lvs after alignment scan .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/18882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove block size validation from blockSD instantiation.
Itamar Heim has posted comments on this change. Change subject: Remove block size validation from blockSD instantiation. .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/14514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwtab: Add /var/run/vdsm
Itamar Heim has posted comments on this change. Change subject: rwtab: Add /var/run/vdsm .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/18829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26d15b38cde216eff378fc4095663732302cc8ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add server uuid into volume brick info list
Itamar Heim has posted comments on this change. Change subject: gluster: add server uuid into volume brick info list .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/18492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]blockSD: do not umount if not all processes were killed
Itamar Heim has posted comments on this change. Change subject: [WIP]blockSD: do not umount if not all processes were killed .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/18876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I899aa033436bb41d8bef5ec18091c3d9c9566efc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: typo in guest agent channel timeout handling
Itamar Heim has posted comments on this change. Change subject: typo in guest agent channel timeout handling .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/17456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63a8a5aa098101ebb3e3c4de2b2dddae4c158490 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Require format attribute for drives
Federico Simoncelli has posted comments on this change.
Change subject: vm: Require format attribute for drives
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24234/1/vdsm/vm.py
File vdsm/vm.py:
Line 1441: VOLWM_FREE_PCT = 100 - config.getint('irs',
'volume_utilization_percent')
Line 1442: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during
replication
Line 1443:
Line 1444: def __init__(self, conf, log, **kwargs):
Line 1445: if 'format' not in kwargs:
And most importantly, for base images guessing the format is a known securi
Dan, in fact I proposed to use getVolumeInfo, after that for simplicity if you
want you *can* use what's in the xml.
Line 1446: raise InvalidDeviceParameters('format attribute is
required:'
Line 1447: ' %r' % kwargs)
Line 1448: if not kwargs.get('serial'):
Line 1449: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit http://gerrit.ovirt.org/24234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Meital Bourvine mbour...@redhat.com
Gerrit-Reviewer: Meital bourvine meitalbourv...@gmail.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
Francesco Romani has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/22194/3/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 283:
Line 284: # echo -n testPayload | md5sum
Line 285: # d37e46c24c78b1aed33496107afdb44b
Line 286: vmPayloadName =
('/var/run/vdsm/payload/{}.d37e46c24c78b1aed33496'
Line 287:
'107afdb44b.img').format(customization['vmId'])
nit: I'd not break the md5sum as it is done now, but it is personal taste so it
can stay like that.
Line 288:
Line 289: cdrom = {'index': '2', 'iface': 'ide', 'specParams':
Line 290: {}, 'readonly': 'true', 'path':
Line 291: '', 'device': 'cdrom', 'shared':
Line 290: {}, 'readonly': 'true', 'path':
Line 291: '', 'device': 'cdrom', 'shared':
Line 292: 'false', 'type': 'disk'}
Line 293:
Line 294: with temporaryPath(0x666) as path:
nit: octal is probably better here: 0o666 like elsewhere temporaryPath is used.
Line 295: cdromPaths = {'self': {'path': path, 'specParams':
Line 296:{'path': '/dev/null'}},
Line 297: 'specParams': {'path': '', 'specParams':
Line 298: {'path': path}},
--
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Fix connection reset on Python 2.6
Antoni Segura Puimedon has posted comments on this change. Change subject: xmlrpc: Fix connection reset on Python 2.6 .. Patch Set 1: Code-Review+1 It would be good to mention that it was found out with the new upload image in the commit message, as it gives more information as to what might be happening. -- To view, visit http://gerrit.ovirt.org/24026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id77a32bb0d4fff13ee680eade52a2f60e4e808b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
Federico Simoncelli has posted comments on this change.
Change subject: vm: discover volume path from xml definition
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/24202/1//COMMIT_MSG
Commit Message:
Line 22: domain
Line 23:
Line 24: In this patch:
Line 25:
Line 26: - revert to the previous path for virtual machine images
Is this really necessary? could you explain why? I think that the former ch
If it was intentional it should have been explicitly stated in the commit
message so we could have discussed it before reaching this issue. Patch was:
http://gerrit.ovirt.org/19825
There's nothing backward compatible in changing the image path.
More over if you want run independently from the pool the correct way to do it
is sending spUUID=BLANK_UUID (as introduced by the same patch).
I will add a note on why we should revert.
Line 27: - inspect libvirt xml during live migration and vdsm restart to
Line 28: identify if it is necessary to update the path cached in the
Line 29: drive object (provided by prepareImage)
Line 30:
http://gerrit.ovirt.org/#/c/24202/1/vdsm/vm.py
File vdsm/vm.py:
Line 4980: d.address = address
Line 4981: d.readonly = readonly
Line 4982: if bootOrder:
Line 4983: d.bootOrder = bootOrder
Line 4984: self.log.debug('Matched %s',
mergeDicts(deviceDict, d))
imo, the previous added block would have been slightly more readable on an
That would have been wrong, point of updating the path is to check if we're
able to match it at 4975.
Line 4985: # Update vm's conf with address for known disk devices
Line 4986: knownDev = False
Line 4987: for dev in self.conf['devices']:
Line 4988: # See comment in previous loop. This part is used to
update
--
To view, visit http://gerrit.ovirt.org/24202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 8: -Code-Review Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6278/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/138/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7168/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/77/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7057/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/337/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Require format attribute for drives
Nir Soffer has posted comments on this change. Change subject: vm: Require format attribute for drives .. Patch Set 1: Turns out that Federico has this patch http://gerrit.ovirt.org/24202 which should fix the root cause of this error, so we don't need this patch for debugging this issue. More then that, Federico suggest that using the image format from __init__ is not good enough, and we must always check the format using the disk meta data, so requiring the format from in __init__ is not what we want. So the proper solution will: 1. Initialize format to None if not set in __init__ 2. In prepareVolumePath, use getVolumeInfo to get the real format, and update disk format, logging a warning if the previous format was different 3. In vm.Vm._getUnderlyingDriveInfo, we will get the format from libvirt, and update drive format, logging a warning if the format was different -- To view, visit http://gerrit.ovirt.org/24234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Meital Bourvine mbour...@redhat.com Gerrit-Reviewer: Meital bourvine meitalbourv...@gmail.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Enable config of VM serial number
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Enable config of VM serial number
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Enable config of VM serial number
..
vdsm: Enable config of VM serial number
Added support for passing explicit serial number
as a part of vmParams from the engine.
In case this new 'serial' param is not passed we fall back to the old
behavior when we use the host UUID.
Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6
Signed-off-by: Martin Betak mbe...@redhat.com
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/24274/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index aae8bd6..540834c 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1014,7 +1014,7 @@
if self.arch == caps.Architecture.X86_64:
oselem.appendChildWithArgs('smbios', mode='sysinfo')
-def appendSysinfo(self, osname, osversion, hostUUID):
+def appendSysinfo(self, osname, osversion, serial):
Add sysinfo element to domain:
@@ -1045,7 +1045,7 @@
appendEntry('manufacturer', constants.SMBIOS_MANUFACTURER)
appendEntry('product', osname)
appendEntry('version', osversion)
-appendEntry('serial', hostUUID)
+appendEntry('serial', serial)
appendEntry('uuid', self.conf['vmId'])
def appendFeatures(self):
@@ -2922,11 +2922,12 @@
osd = caps.osversion()
osVersion = osd.get('version', '') + '-' + osd.get('release', '')
+serialNumber = self.conf.get('serial', utils.getHostUUID())
domxml.appendSysinfo(
osname=constants.SMBIOS_OSNAME,
osversion=osVersion,
-hostUUID=utils.getHostUUID())
+serial=serialNumber)
domxml.appendClock()
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: ifcfg configurator static methods and list handling
Antoni Segura Puimedon has abandoned this change. Change subject: cleanup: ifcfg configurator static methods and list handling .. Abandoned Even though it is only missing verification, I think it'd be better to move to module level methods. Will resubmit later. -- To view, visit http://gerrit.ovirt.org/20536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I83051a07d3b907ba31a01f75e64f01f3f2e7a165 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Enable config of VM serial number
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6279/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7169/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7058/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Enable config of VM serial number
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 1:
(1 comment)
proposing different parameter name for clarity.
http://gerrit.ovirt.org/#/c/24274/1/vdsm/vm.py
File vdsm/vm.py:
Line 1013:
Line 1014: if self.arch == caps.Architecture.X86_64:
Line 1015: oselem.appendChildWithArgs('smbios', mode='sysinfo')
Line 1016:
Line 1017: def appendSysinfo(self, osname, osversion, serial):
I'd rather have serialNumber than serial.
Line 1018:
Line 1019: Add sysinfo element to domain:
Line 1020:
Line 1021: sysinfo type=smbios
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Update LUN size when starting a vm
Federico Simoncelli has posted comments on this change. Change subject: vm: Update LUN size when starting a vm .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/24235/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 266: # Update size for LUN volume Line 267: drive[truesize] = res['truesize'] Line 268: drive[apparentsize] = res['apparentsize'] Line 269: Line 270: volPath = os.path.join(/dev/mapper, drive[GUID]) Can you send a patch (on top of this one) to get this as well? volPath should be returned by appropriateDevice. Line 271: Line 272: # UUID drive format Line 273: elif UUID in drive: Line 274: volPath = self._getUUIDSpecPath(drive[UUID]) -- To view, visit http://gerrit.ovirt.org/24235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4988212f7f96078e774d2a4e7b5cd1681383cb0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Vdsm changes
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 25: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: fix RTC offset
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: fix RTC offset
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: fix RTC offset .. vdsm: fix RTC offset Upon RTC update (hwclock --systohc) on the guest side, libvirt sends the event with RTC offset from the qemu start -rtc value in seconds. The received offset should not replace the previous value, but should be added to it. Since the time update event is relative to the qemu start time, we should store the initial value and use it for the calculation. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956741 Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Signed-off-by: Peter V. Saveliev p...@redhat.com Reviewed-on: http://gerrit.ovirt.org/14750 Tested-by: Martin Polednik mpole...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24260 Reviewed-by: Francesco Romani from...@redhat.com --- M vdsm/vm.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/24260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vdsm: fix RTC offset
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: fix RTC offset .. vdsm: fix RTC offset Upon RTC update (hwclock --systohc) on the guest side, libvirt sends the event with RTC offset from the qemu start -rtc value in seconds. The received offset should not replace the previous value, but should be added to it. Since the time update event is relative to the qemu start time, we should store the initial value and use it for the calculation. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956741 Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Signed-off-by: Peter V. Saveliev p...@redhat.com Reviewed-on: http://gerrit.ovirt.org/14750 Tested-by: Martin Polednik mpole...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24196 Reviewed-by: Martin Polednik mpole...@redhat.com --- M vdsm/vm.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Update LUN size when starting a vm
Daniel Erez has posted comments on this change. Change subject: vm: Update LUN size when starting a vm .. Patch Set 2: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/24235/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 266: # Update size for LUN volume Line 267: drive[truesize] = res['truesize'] Line 268: drive[apparentsize] = res['apparentsize'] Line 269: Line 270: volPath = os.path.join(/dev/mapper, drive[GUID]) Can you send a patch (on top of this one) to get this as well? volPath shou sure, I'll send it in a following patch Line 271: Line 272: # UUID drive format Line 273: elif UUID in drive: Line 274: volPath = self._getUUIDSpecPath(drive[UUID]) -- To view, visit http://gerrit.ovirt.org/24235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4988212f7f96078e774d2a4e7b5cd1681383cb0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Francesco Romani has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 8: Patch Set 8: * renamed constants and moved to a module * made exitReason mandatory in ExitedVmStats * added very basic tests -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6281/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7171/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7060/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Enable config of VM serial number
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Enable config of VM serial number
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24274/1/vdsm/vm.py
File vdsm/vm.py:
Line 1013:
Line 1014: if self.arch == caps.Architecture.X86_64:
Line 1015: oselem.appendChildWithArgs('smbios', mode='sysinfo')
Line 1016:
Line 1017: def appendSysinfo(self, osname, osversion, serial):
I'd rather have serialNumber than serial.
Done
Line 1018:
Line 1019: Add sysinfo element to domain:
Line 1020:
Line 1021: sysinfo type=smbios
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Enable config of VM serial number
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7170/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7059/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Francesco Romani has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 8: patch set 9: fix spacing -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 9: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6282/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7172/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7061/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing capabillity to stream data to image
Yaniv Bronhaim has posted comments on this change. Change subject: introducing capabillity to stream data to image .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Use correct base class for parsing request
Nir Soffer has uploaded a new change for review. Change subject: xmlrpc: Use correct base class for parsing request .. xmlrpc: Use correct base class for parsing request Previously we always used SecureXMLRPCServer.parse_request, even when using SimpleXMLRPCServer. That happened to work since both inherit parse_request from BaseHTTPServer. This patch use the correct base class, so if one of them will override parse_request, we use the correct method. Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f Signed-off-by: Nir Soffer nsof...@redhat.com --- M vdsm/BindingXMLRPC.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/24289/1 diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py index b71dae5..7308c5c 100644 --- a/vdsm/BindingXMLRPC.py +++ b/vdsm/BindingXMLRPC.py @@ -109,8 +109,7 @@ return basehandler.setup(self) def parse_request(self): -r = (SecureXMLRPCServer.SecureXMLRPCRequestHandler. - parse_request(self)) +r = basehandler.parse_request(self) threadLocal.flowID = self.headers.get(HTTP_HEADER_FLOWID) return r -- To view, visit http://gerrit.ovirt.org/24289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: discover volume path from xml definition
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6283/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7173/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7062/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Use correct base class for parsing request
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Use correct base class for parsing request .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7174/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7063/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 9: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6285/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7175/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7064/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
Nir Soffer has uploaded a new change for review. Change subject: xmlrpc: Support HTTP 1.1 .. xmlrpc: Support HTTP 1.1 Supporting HTTP 1.1 allow using keep-alive on the client side, decreasing the latency and load on the engine and increasing the number of host that engine can support. This patch override do_POST and report_404 methods that wrongly shutdown the connection at the end of the do_POST request. This is the responsibility of the server, and not the request handler. The fixed methods are used only on Python 2.6. Python 2.7 already include these changes. Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Signed-off-by: Nir Soffer nsof...@redhat.com --- M lib/vdsm/utils.py 1 file changed, 77 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/24294/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index 8a3bb64..62b7c0d 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -146,7 +146,83 @@ else: raise -IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler + +class IPXMLRPCRequestHandler(SimpleXMLRPCRequestHandler): + +# Override Python 2.6 version to support HTTP 1.1. +# +# This is the same code as Python 2.6, not shutting down the connection +# when a request is finished. The server is responsible for closing the +# connection, based on the http version and keep-alive and connection: +# close headers. +# +# Additionally, add Content-Length: 0 header on internal errors, when we +# don't send any content. This is required by HTTP 1.1, otherwise the +# client does not have any clue that the response was finished. +# +# These changes were taken from Python.7 version of this class. If we are +# running on Python 2.7, these changes are not needed, hence we override +# the methods only on Python 2.6. + +if sys.version_info[:2] == (2, 6): + +def do_POST(self): +# Check that the path is legal +if not self.is_rpc_path_valid(): +self.report_404() +return + +try: +# Get arguments by reading body of request. +# We read this in chunks to avoid straining +# socket.read(); around the 10 or 15Mb mark, some platforms +# begin to have problems (bug #792570). +max_chunk_size = 10*1024*1024 +size_remaining = int(self.headers[content-length]) +L = [] +while size_remaining: +chunk_size = min(size_remaining, max_chunk_size) +chunk = self.rfile.read(chunk_size) +if not chunk: +break +L.append(chunk) +size_remaining -= len(L[-1]) +data = ''.join(L) + +# In previous versions of SimpleXMLRPCServer, _dispatch +# could be overridden in this class, instead of in +# SimpleXMLRPCDispatcher. To maintain backwards compatibility, +# check to see if a subclass implements _dispatch and dispatch +# using that method if present. +response = self.server._marshaled_dispatch( +data, getattr(self, '_dispatch', None)) +except Exception, e: +# This should only happen if the module is buggy +# internal error, report as HTTP server error +self.send_response(500) + +# Send information about the exception if requested +if getattr(self.server, '_send_traceback_header', False): +self.send_header(X-exception, str(e)) +self.send_header(X-traceback, traceback.format_exc()) + +self.send_header(Content-length, '0') +self.end_headers() +else: +# got a valid XML RPC response +self.send_response(200) +self.send_header(Content-type, text/xml) +self.send_header(Content-length, str(len(response))) +self.end_headers() +self.wfile.write(response) + +def report_404(self): +self.send_response(404) +response = 'No such page' +self.send_header(Content-type, text/plain) +self.send_header(Content-length, str(len(response))) +self.end_headers() +self.wfile.write(response) class IPXMLRPCServer(SimpleXMLRPCServer): -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6286/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7176/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7065/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 1: Verified+1 Seems to work, tested lightly with engine version 3.4. Not sure how to test if engine uses keep alive as we use https. -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use Requires %{name}
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: use Requires %{name}
..
Patch Set 1:
From: https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
Packagers are strongly encouraged to use macros instead of hard-coded
directory names
--
To view, visit http://gerrit.ovirt.org/24301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use Requires %{name}
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: use Requires %{name}
..
spec: use Requires %{name}
We should use macros instead of static names in the spec.
If in the future we decide to use different name for vdsm package
it's a matter to put the new package name in Name session.
Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M vdsm.spec.in
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/24301/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6efd430..08bfae5 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -353,7 +353,7 @@
%package debug-plugin
Summary:VDSM Debug Plugin
-Requires: vdsm
+Requires: %{name}
Requires: %{name}-xmlrpc = %{version}-%{release}
BuildArch: noarch
@@ -362,7 +362,7 @@
%package tests
Summary:VDSM Test Suite
-Requires: vdsm = %{version}-%{release}
+Requires: %{name} = %{version}-%{release}
Requires: dracut
Requires: python-nose
BuildArch: noarch
@@ -373,7 +373,7 @@
%package hook-checkimages
Summary:Qcow2 disk image format check hook for VDSM
BuildArch: noarch
-Requires: vdsm
+Requires: %{name}
%description hook-checkimages
VDSM hook used to perform consistency check on a qcow2 format disk image
@@ -392,7 +392,7 @@
%package hook-faqemu
Summary:Fake qemu process for VDSM quality assurance
BuildArch: noarch
-Requires: vdsm
+Requires: %{name}
%description hook-faqemu
VDSM hook used for testing VDSM with multiple fake virtual machines without
@@ -420,7 +420,7 @@
%package hook-extnet
Summary:Force a vNIC to connect to a specific libvirt network
BuildArch: noarch
-Requires: vdsm = %{version}-%{release}
+Requires: %{name} = %{version}-%{release}
%description hook-extnet
VDSM hook which allows to connect a vNIC to a libvirt network that is managed
@@ -511,7 +511,7 @@
%package hook-qemucmdline
Summary:QEMU cmdline hook for VDSM
BuildArch: noarch
-Requires: vdsm
+Requires: %{name}
%description hook-qemucmdline
Provides support for injecting QEMU cmdline via VDSM hook.
@@ -565,7 +565,7 @@
%package hook-vmfex-dev
Summary:VM-FEX vNIC support for VDSM
BuildArch: noarch
-Requires: vdsm = %{version}-%{release}
+Requires: %{name} = %{version}-%{release}
Conflicts: hook-vmfex
%description hook-vmfex-dev
--
To view, visit http://gerrit.ovirt.org/24301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use Requires %{name}
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: use Requires %{name}
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use Requires %{name}
Kiril Nesenko has posted comments on this change.
Change subject: spec: use Requires %{name}
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use Requires %{name}
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: use Requires %{name}
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6287/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7177/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7066/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/338/ :
SUCCESS
--
To view, visit http://gerrit.ovirt.org/24301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing capabillity to stream data to image
Nir Soffer has posted comments on this change. Change subject: introducing capabillity to stream data to image .. Patch Set 9: (1 comment) Minor cleanup. http://gerrit.ovirt.org/#/c/23281/9/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 152: Line 153: def do_PUT(self): Line 154: try: Line 155: contentType, pt = cgi.parse_header(self.headers.getheader( Line 156: self.HEADER_CONTENT_TYPE)) You can replace these lines with: contentType = self.headers.gettype() And remove the cgi import. See http://docs.python.org/2/library/mimetools.html#mimetools.Message.gettype Line 157: if contentType != self.CONTENT_STREAM_TYPE: Line 158: self.send_error(httplib.UNSUPPORTED_MEDIA_TYPE, Line 159: unsupported content type: %r % Line 160: contentType) -- To view, visit http://gerrit.ovirt.org/23281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: return additional Hosted Engine information from vdsStats
Adam Litke has posted comments on this change.
Change subject: API: return additional Hosted Engine information from vdsStats
..
Patch Set 4:
(1 comment)
Please see comment
http://gerrit.ovirt.org/#/c/23263/4/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 1556: # Since: 4.14.0
Line 1557: ##
Line 1558: {'type': 'HostedEngineStatus',
Line 1559: 'data': {'active': 'bool', 'globalMaintenance': 'bool',
Line 1560: 'localMaintenance': 'bool', 'score': 'uint'}}
Did you miss 'configured' here too?
Line 1561:
Line 1562: ##
Line 1563: # @HostStats:
Line 1564: #
--
To view, visit http://gerrit.ovirt.org/23263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaee2756d0652dc56439b8004e9260fcea927b708
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: setHaMaintenanceMode command
Adam Litke has posted comments on this change.
Change subject: API: setHaMaintenanceMode command
..
Patch Set 5:
(1 comment)
Please see comment.
http://gerrit.ovirt.org/#/c/23264/5/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 486: # Since: 4.14.0
Line 487: ##
Line 488: {'command': {'class': 'Host', 'name': 'setHaMaintenanceMode'},
Line 489: 'data': {'mode': 'HaMaintenanceMode', 'enabled': 'bool'}}
Line 490:
Does this mean a host can be in both global and local maintenance modes at the
same time? If not, should we instead have a third HaMaintenanceMode: @ACTIVE
that means 'not in maintenance mode? Then this call would take a single
parameter to set one of the modes.
Line 491: ##
Line 492: # @TaskDetails:
Line 493: #
Line 494: # A collection of information about a task.
--
To view, visit http://gerrit.ovirt.org/23264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic08c5edb0e9b8cc11eb70ef6a66301335c42aad3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 2: Verified+1 Setting protocol_version to HTTP/1.1 enabling automatic keep-alive. -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
