Change in vdsm[master]: stomp: reroute messages to different process
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: reroute messages to different process
..
stomp: reroute messages to different process
When a client subscribes it can define which messages should be rerouted
to it based on a custom stomp header. Whenever vdsm receives message for
a verb specified it sends it to that client instead of processing it.
Change-Id: I622cb7f3b39a19314b7de4c325a62fa47faeaa4d
Signed-off-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
---
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/stompAdapterTests.py
3 files changed, 161 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/65846/1
diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py
index 558c519..99d09ac 100644
--- a/lib/yajsonrpc/stomp.py
+++ b/lib/yajsonrpc/stomp.py
@@ -563,6 +563,7 @@
self._valid = True
self._message_handler = message_handler
self._destination = destination
+self._redirects = []
def handle_message(self, frame):
self._message_handler(self, frame)
@@ -576,6 +577,13 @@
def set_message_handler(self, handler):
self._message_handler = handler
+def set_redirects(self, redirects):
+self._redirects = redirects
+
+@property
+def redirects(self):
+return self._redirects
+
@property
def id(self):
return self._subid
diff --git a/lib/yajsonrpc/stompreactor.py b/lib/yajsonrpc/stompreactor.py
index 42d7d01..61bb98c 100644
--- a/lib/yajsonrpc/stompreactor.py
+++ b/lib/yajsonrpc/stompreactor.py
@@ -15,7 +15,7 @@
from __future__ import absolute_import
import logging
-from collections import deque
+from collections import deque, defaultdict
from uuid import uuid4
import functools
@@ -68,6 +68,7 @@
self._outbox = deque()
self._sub_dests = sub_map
self._req_dest = req_dest
+self._redirects = defaultdict(list)
self._sub_ids = {}
request_queues = config.get('addresses', 'request_queues')
self.request_queues = request_queues.split(",")
@@ -128,6 +129,7 @@
self.log.info("Subscribe command received")
destination = frame.headers.get("destination", None)
sub_id = frame.headers.get("id", None)
+redirect_value = frame.headers.get("redirect", None)
if not destination or not sub_id:
self._send_error("Missing destination or subscription id header",
@@ -145,6 +147,12 @@
self._sub_dests[destination].append(subscription)
self._sub_ids[sub_id] = subscription
+
+if redirect_value:
+redirects = redirect_value.split(",")
+subscription.set_redirects(redirects)
+for redirect in redirects:
+self._redirects[redirect].append(subscription)
def _send_error(self, msg, connection):
res = stomp.Frame(
@@ -188,17 +196,26 @@
subs = self._sub_dests[subscription.destination]
if len(subs) == 1:
del self._sub_dests[subscription.destination]
+self._remove_redirects(subscription)
else:
if subscription in subs:
subs.remove(subscription)
+self._remove_redirects(subscription)
+
+def _remove_redirects(self, subscription):
+if subscription.redirects:
+for redirect in subscription.redirects:
+reds = self._redirects[redirect]
+if len(reds) == 1:
+del self._redirects[redirect]
+else:
+reds.remove(subscription)
def _cmd_send(self, dispatcher, frame):
destination = frame.headers.get(stomp.Headers.DESTINATION, None)
if destination in self.request_queues:
# default subscription
-self._handle_internal(dispatcher,
- frame.headers.get(stomp.Headers.REPLY_TO),
- frame.body)
+self._handle_internal(dispatcher, frame)
return
else:
try:
@@ -224,31 +241,42 @@
)
subscription.client.send_raw(res)
-def _handle_internal(self, dispatcher, req_dest, request):
+def _handle_internal(self, dispatcher, frame):
"""
We need to build response dictionary which maps message id
with destination. For legacy mode we use known 3.5 destination
or for standard mode we use 'reply-to' header.
"""
+requests = []
try:
-self._handle_destination(dispatcher, req_dest, json.loads(request))
+req_dest = frame.headers.get(stomp.Headers.REPLY_TO)
+requests = self._handle_destination(dispatcher, req_dest,
Change in vdsm[master]: stomp: reroute messages to different process
Piotr Kliczewski has posted comments on this change. Change subject: stomp: reroute messages to different process .. Patch Set 1: Verified that changes do not break functionality and by running UT. Now need external client to make sure it works as it should. -- To view, visit https://gerrit.ovirt.org/65846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I622cb7f3b39a19314b7de4c325a62fa47faeaa4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: fix integration tests
Piotr Kliczewski has posted comments on this change. Change subject: tests: fix integration tests .. Patch Set 6: Verified+1 Verified by running the tests -- To view, visit https://gerrit.ovirt.org/55871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: infra tests: added functional test for upgrading vdsm
Piotr Kliczewski has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm .. Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: caps: report realtime kernel status
Piotr Kliczewski has posted comments on this change. Change subject: caps: report realtime kernel status .. Patch Set 3: Code-Review+1 api change looks good -- To view, visit https://gerrit.ovirt.org/65715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: caps: report nested virtualization capabilities
Piotr Kliczewski has posted comments on this change. Change subject: caps: report nested virtualization capabilities .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/65717/3/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS3, Line 6505: string Like in previous patch. Why not to use boolean? -- To view, visit https://gerrit.ovirt.org/65717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: caps: report realtime kernel status
Piotr Kliczewski has posted comments on this change. Change subject: caps: report realtime kernel status .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65715/2/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS2, Line 6497: string Why not to use boolean directly here. I see that we make it a string ourselves. Is there any reason? -- To view, visit https://gerrit.ovirt.org/65715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Piotr Kliczewski has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 11: Code-Review+1 api changes looks good to me -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema
Piotr Kliczewski has posted comments on this change. Change subject: Fix API schema to align with runtime schema .. Patch Set 3: It should be enough to have it on master. -- To view, visit https://gerrit.ovirt.org/65288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Use Popen.poll() for running state
Piotr Kliczewski has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
Piotr Kliczewski has posted comments on this change. Change subject: rpc: keep listening on socket .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/65686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
Piotr Kliczewski has posted comments on this change. Change subject: rpc: keep listening on socket .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
Piotr Kliczewski has uploaded a new change for review.
Change subject: rpc: keep listening on socket
..
rpc: keep listening on socket
Some users are using Nessus scanner which seems to close vdsm socket.
Users are not willing to configure it not to break vdsm.
Due to this issue vdsm needs to be restarted to make it fully
operational again. We can intercept socket closure and to reopen it.
This fix was tested by using gdb to close the socket and observing that
the socket is still open.
Bug-Url: https://bugzilla.redhat.com/1326940
Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e
Signed-off-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
---
M lib/vdsm/protocoldetector.py
1 file changed, 22 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/65686/1
diff --git a/lib/vdsm/protocoldetector.py b/lib/vdsm/protocoldetector.py
index 196a2ab..f1450d7 100644
--- a/lib/vdsm/protocoldetector.py
+++ b/lib/vdsm/protocoldetector.py
@@ -51,8 +51,10 @@
class _AcceptorImpl(object):
log = logging.getLogger("ProtocolDetector.AcceptorImpl")
-def __init__(self, dispatcher_factory):
+def __init__(self, dispatcher_factory, listener):
self._dispatcher_factory = dispatcher_factory
+self.listener = listener
+self._keep_open = True
def readable(self, dispatcher):
return True
@@ -73,6 +75,11 @@
def handle_close(self, dispatcher):
dispatcher.close()
+if self._keep_open:
+self.listener.listen()
+
+def prepare_for_shutdown(self):
+self._keep_open = False
class _ProtocolDetector(object):
@@ -172,15 +179,20 @@
):
self._sslctx = sslctx
self._reactor = reactor
-sock = _create_socket(host, port)
-# TODO: Clean _host & _port, use sockaddr instead.
-self._host, self._port = sock.getsockname()[0:2]
-self.log.info("Listening at %s:%d", self._host, self._port)
-self._acceptor = self._reactor.create_dispatcher(
-sock, _AcceptorImpl(self.handle_accept))
-self._acceptor.listen(5)
+self.port = port
+self.host = host
+self.listen()
self._handlers = []
self.TIMEOUT = ssl_hanshake_timeout
+
+def listen(self):
+sock = _create_socket(self.host, self.port)
+# TODO: Clean _host & _port, use sockaddr instead.
+self._host, self._port = sock.getsockname()[0:2]
+self._acceptor = self._reactor.create_dispatcher(
+sock, _AcceptorImpl(self.handle_accept, self))
+self._acceptor.listen(5)
+self.log.info("Listening at %s:%d", self._host, self._port)
def handle_accept(self, client):
if self._sslctx is None:
@@ -208,6 +220,8 @@
def stop(self):
self.log.debug("Stopping Acceptor")
self._reactor.stop()
+
+self._acceptor.prepare_for_shutdown()
self._acceptor.close()
--
To view, visit https://gerrit.ovirt.org/65686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: broker cleanup
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: broker cleanup
..
stomp: broker cleanup
We can remove engine 3.5 supported queue names since we do not support
this version anymore.
Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca
Signed-off-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
---
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
2 files changed, 2 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/65681/1
diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py
index 41ac70f..558c519 100644
--- a/lib/yajsonrpc/stomp.py
+++ b/lib/yajsonrpc/stomp.py
@@ -22,11 +22,6 @@
from vdsm import utils
import re
-# REQUIRED_FOR: engine-3.5
-# safe to remove when 3.5 support is dropped
-LEGACY_SUBSCRIPTION_ID_REQUEST = "/queue/_local/vdsm/requests"
-LEGACY_SUBSCRIPTION_ID_RESPONSE = "/queue/_local/vdsm/reponses"
-
_RE_ESCAPE_SEQUENCE = re.compile(r"\\(.)")
_RE_ENCODE_CHARS = re.compile(r"[\r\n\\:]")
diff --git a/lib/yajsonrpc/stompreactor.py b/lib/yajsonrpc/stompreactor.py
index 233bee3..42d7d01 100644
--- a/lib/yajsonrpc/stompreactor.py
+++ b/lib/yajsonrpc/stompreactor.py
@@ -200,11 +200,6 @@
frame.headers.get(stomp.Headers.REPLY_TO),
frame.body)
return
-elif stomp.LEGACY_SUBSCRIPTION_ID_REQUEST == destination:
-self._handle_internal(dispatcher,
- stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE,
- frame.body)
-return
else:
try:
subs = self._sub_dests[destination]
@@ -323,7 +318,7 @@
"""
Sends message to all subscribes that subscribed to destination.
"""
-def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE):
+def send(self, message, destination):
resp = json.loads(message)
response_id = resp.get("id")
@@ -414,8 +409,7 @@
self._reactor.wakeup()
return sub
-def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE,
- headers=None):
+def send(self, message, destination, headers=None):
self.log.debug("Sending response")
self._aclient.send(
destination,
--
To view, visit https://gerrit.ovirt.org/65681
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: build: Run the tests with tox
Piotr Kliczewski has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I245a171940a5e869fd719a6410024ee77e8ad86c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Remove cPopenTests.py
Piotr Kliczewski has posted comments on this change. Change subject: tests: Remove cPopenTests.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dc384d6e84ce5f09573be32ea6247c6ef834836 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8
Piotr Kliczewski has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42430f045e4475c31cd370b4196214094c29cd1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: api: Speed up schema loading
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65452
to review the following change.
Change subject: api: Speed up schema loading
..
api: Speed up schema loading
Use yaml.CLoader for 13x speedup in vdsm schema loading.
Here is a comparison with other formats:
$ python bench.py
yaml: 1.053720 seconds per load
cyaml: 0.086472 seconds per load
json: 0.049521 seconds per load
pickle: 0.001516 seconds per load
$ python3 bench.py
yaml: 1.340607 seconds per load
cyaml: 0.100010 seconds per load
json: 0.026627 seconds per load
pickle: 0.002153 seconds per load
$ grep 'model name' /proc/cpuinfo | head -n1
model name : Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Clearly the best format is pickle, 700X times faster on python 2 and
638X times faster on python 3. However loading the schema in 100
milliseconds seems to be good enough for now.
The benchmark script:
https://bugzilla.redhat.com/attachment.cgi?id=1208141
Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Bug-Url: https://bugzilla.redhat.com/1381899
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Signed-off-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Reviewed-on: https://gerrit.ovirt.org/65230
Reviewed-by: Simone Tiraboschi <stira...@redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Tested-by: Simone Tiraboschi <stira...@redhat.com>
---
M lib/api/vdsmapi.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/65452/1
diff --git a/lib/api/vdsmapi.py b/lib/api/vdsmapi.py
index b340f73..635aedf 100755
--- a/lib/api/vdsmapi.py
+++ b/lib/api/vdsmapi.py
@@ -92,7 +92,7 @@
try:
for path in paths:
with open(path) as f:
-loaded_schema = yaml.load(f)
+loaded_schema = yaml.load(f, Loader=yaml.CLoader)
types = loaded_schema.pop('types')
self._types.update(types)
--
To view, visit https://gerrit.ovirt.org/65452
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add tests for poll and wait failures
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py
File tests/utilsTests.py:
Line 132: self.check_failure()
Line 133:
Line 134: def test_kill_failure(self):
Line 135: def fail():
Line 136: raise ExpectedFailure("Fake kill failure")
> 3 test, 3 fail texts, please suggest a simple and more clear code.
Why not to have fail method as top level and use it 138 and in 145 line. We do
not need to have it in two places.
Line 137:
Line 138: self.proc.kill = fail
Line 139: self.check_failure()
Line 140:
--
To view, visit https://gerrit.ovirt.org/65294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8674c9c3c2118041c74213cd8ce0d383086d6cbf
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add tests for waiting on a zombie process
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py
File tests/utilsTests.py:
Line 102: self.proc.terminate()
Line 103: wait_for_zombie(self.proc, 1)
Line 104:
Line 105: def fail():
Line 106: raise RuntimeError("Attempt to kill a zombie process")
> This raises rumtime error and will fail the test if raised.
In patch #65328 we use RuntimeError as well. We mentioned in commit message
reuse of this method so let's do it.
Line 107:
Line 108: self.proc.kill = fail
Line 109: with utils.terminating(self.proc):
Line 110: pass
--
To view, visit https://gerrit.ovirt.org/65327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I238d77213153b1fa98bb3f52b33a6fd78bb57bca
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Refine TerminationTests names
Piotr Kliczewski has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: Raise detectable error if termination fail
Piotr Kliczewski has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG Commit Message: Line 14: job running the process must stay in running state to prevent engine Line 15: from starting the same operation on another machine. Line 16: Line 17: Typically when we cannot handle an error we should not handle it. But Line 18: in this special case, letting the caller handle the error is not useful > Tried, I cannot see what is confusing and how to improve this. Please sugge My confusion is that we say handling error is not useful but later we say that by creating new Exception and passing pid is fine. So I would go with: But in this special case, letting the caller to handle the error without context is not useful. By adding new TrminatingFailure exception with pid we solve missing context issue. Line 19: since it does not have any context. Line 20: Line 21: To make it possible to handle this critical error, we raise now a new Line 22: TerminatingFallure exception with process pid and the original error. -- To view, visit https://gerrit.ovirt.org/65325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cfa5434ce011b9185550884233b5b233026d13c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make gluster_cli_tests pass
Piotr Kliczewski has posted comments on this change. Change subject: py3: make gluster_cli_tests pass .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: osinfo: drop package buildtime
Piotr Kliczewski has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacc9b0fe5446abd5405db6efff6b7f9f16468bc9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add tests for poll and wait failures
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 8: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py
File tests/utilsTests.py:
PS8, Line 135: def fail():
: raise ExpectedFailure("Fake kill failure")
Now we have it 3 times.
PS8, Line 158: timing
Wouldn't be better to wait to be sure that timing is correct instead of
removing it?
--
To view, visit https://gerrit.ovirt.org/65294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8674c9c3c2118041c74213cd8ce0d383086d6cbf
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add test for terminating a terminated process
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65328/6/tests/utilsTests.py
File tests/utilsTests.py:
PS6, Line 117: def fail():
: raise RuntimeError("Attempt to kill a terminated
process")
I see that copy and paste are our friends :)
--
To view, visit https://gerrit.ovirt.org/65328
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0f06c28857664cc49beb938f33ac3c9d07ca3b6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add tests for waiting on a zombie process
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py
File tests/utilsTests.py:
PS6, Line 105: def fail():
: raise RuntimeError("Attempt to kill a zombie
process")
in previous patch I though we wanted to reuse similar code but now I see that
we copied and pasted it here.
--
To view, visit https://gerrit.ovirt.org/65327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I238d77213153b1fa98bb3f52b33a6fd78bb57bca
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: Raise detectable error if termination fail
Piotr Kliczewski has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG Commit Message: PS5, Line 18: handle the error handling the error without knowing the context (pid) is not useful. That is way we use new exception to pass a context (pid). This commit message is confusing. -- To view, visit https://gerrit.ovirt.org/65325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cfa5434ce011b9185550884233b5b233026d13c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Refine TerminationTests names
Piotr Kliczewski has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/65326/5//COMMIT_MSG Commit Message: PS5, Line 9: Al For all the tests that test termination there is no need to repeat... PS5, Line 11: tests name test names PS5, Line 13: for other : failure tests what do you mean? how do you want to do it? (my questions based on the code in this patch) -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: Wait for terminated process
Piotr Kliczewski has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida04e2c7ba092efdc2927ed9f460b0098ba2ad94 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Use Popen.poll() for running state
Piotr Kliczewski has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/65323/4//COMMIT_MSG Commit Message: PS4, Line 9: exists works `exits` should be enough or we could use `exists/works` -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Wait for child process in tearDown
Piotr Kliczewski has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248fa0b1c2129f69164be447402276d7908ed768 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: Add missing Popen methods
Piotr Kliczewski has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d562663698d86b98b55d139e2691a0f51566ccf Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: osinfo: drop package buildtime
Piotr Kliczewski has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: I checked and it was not used on master, 3.6 and 4.0 engine. What you need to do is to remove following property from SoftwarePackageInfo type: - description: The time and date the software was built name: buildtime type: long -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacc9b0fe5446abd5405db6efff6b7f9f16468bc9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make gluster_cli_tests pass
Piotr Kliczewski has posted comments on this change. Change subject: py3: make gluster_cli_tests pass .. Patch Set 4: Code-Review+1 (3 comments) Minor date in copyrights update but the patch looks good. https://gerrit.ovirt.org/#/c/65008/4/lib/vdsm/kaxmlrpclib.py File lib/vdsm/kaxmlrpclib.py: PS4, Line 2: 2008-2011 please update https://gerrit.ovirt.org/#/c/65008/4/lib/vdsm/network/netlink/addr.py File lib/vdsm/network/netlink/addr.py: PS4, Line 1: 2014 please update https://gerrit.ovirt.org/#/c/65008/4/tests/gluster_cli_tests.py File tests/gluster_cli_tests.py: PS4, Line 2: 2012 please update -- To view, visit https://gerrit.ovirt.org/65008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: osinfo: drop package buildtime
Piotr Kliczewski has posted comments on this change. Change subject: osinfo: drop package buildtime .. Patch Set 3: Updating yml spec file should be enough. Before we will merge I will make sure that it was really not used on the engine side. -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacc9b0fe5446abd5405db6efff6b7f9f16468bc9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
Piotr Kliczewski has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
Piotr Kliczewski has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: protocoldetector: Fix random double close
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:
Line 206: self._handlers.append(detector)
Line 207:
Line 208: def stop(self):
Line 209: self.log.debug("Stopping Acceptor")
Line 210: self._acceptor.close()
> No, this creates broken stop method that stop the reactor instead of the ac
what is your definition of broken because it seems I have a different one.
Line 211: self._reactor.stop()
Line 212:
Line 213:
Line 214: class _CannotDetectProtocol(Exception):
--
To view, visit https://gerrit.ovirt.org/65187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: clientIF: Fix reactor life cycle
Piotr Kliczewski has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 110: self.acceptor_address = None Line 111: Line 112: def tearDown(self): Line 113: if self.acceptor: Line 114: self.acceptor.stop() > If we don't call acceptor close, and later we change the test so we don't c What hidden dependencies? Is it possible to use acceptor without reactor? Line 115: if self.reactor: Line 116: self.reactor.stop() Line 117: Line 118: # Testing -- To view, visit https://gerrit.ovirt.org/65188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema
Piotr Kliczewski has posted comments on this change. Change subject: Fix API schema to align with runtime schema .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: hooks: avoid redundant temporary list
Piotr Kliczewski has posted comments on this change. Change subject: hooks: avoid redundant temporary list .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6b0505ebabef0ec33a738c3698dc446e8849a2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: protocoldetector: Fix random double close
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:
Line 206: self._handlers.append(detector)
Line 207:
Line 208: def stop(self):
Line 209: self.log.debug("Stopping Acceptor")
Line 210: self._acceptor.close()
> But this patch did not add acceptor.close(), I'm just fixing the order so w
Minimal is to remove acceptor close line.
Line 211: self._reactor.stop()
Line 212:
Line 213:
Line 214: class _CannotDetectProtocol(Exception):
--
To view, visit https://gerrit.ovirt.org/65187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: clientIF: Fix reactor life cycle
Piotr Kliczewski has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 110: self.acceptor_address = None Line 111: Line 112: def tearDown(self): Line 113: if self.acceptor: Line 114: self.acceptor.stop() > This patch only add closing of the reactor, which should not be in the acce I am ok to fix the ownership but I think calling acceptor close is redundant. Line 115: if self.reactor: Line 116: self.reactor.stop() Line 117: Line 118: # Testing -- To view, visit https://gerrit.ovirt.org/65188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: api: Speed up schema loading
Piotr Kliczewski has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: api: Speed up schema loading
Piotr Kliczewski has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: schema: Change description of io tune parameters.
Piotr Kliczewski has posted comments on this change. Change subject: schema: Change description of io tune parameters. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb130c7182ba2d618a9618b324fa1537d616a966 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls
Piotr Kliczewski has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: clientIF: Fix reactor life cycle
Piotr Kliczewski has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: PS1, Line 113: if self.acceptor: : self.acceptor.stop() As I said in previous patch we do not need this when reactor is closed. -- To view, visit https://gerrit.ovirt.org/65188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Create all instance variables in setUp
Piotr Kliczewski has posted comments on this change. Change subject: tests: Create all instance variables in setUp .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0360932b3a7515fe8f87cd0ccc2cc4f6b2c90381 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: protocoldetector: Fix random double close
Piotr Kliczewski has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: PS1, Line 210: self._acceptor.close() this is run when vdsm is being shutdown. I do not see any value by calling acceptor close because reactor stop would close all the dispatchers including this one. -- To view, visit https://gerrit.ovirt.org/65187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: schema: fixing type of default values
Piotr Kliczewski has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: schema: fixing type of default values
Piotr Kliczewski has uploaded a new change for review. Change subject: schema: fixing type of default values .. schema: fixing type of default values Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294 Signed-off-by: Piotr Kliczewski <piotr.kliczew...@gmail.com> --- M lib/api/vdsm-api.yml 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/65113/1 diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml index 776b592..9ebac7a 100644 --- a/lib/api/vdsm-api.yml +++ b/lib/api/vdsm-api.yml @@ -2120,35 +2120,35 @@ description: I/O tune parameters for the VM disk device. name: VmDiskDeviceIoTuneParams properties: -- defaultvalue: 0 - means unlimited +- defaultvalue: 0 description: Total throughput limit in bytes per second. name: total_bytes_sec type: uint -- defaultvalue: 0 - means unlimited +- defaultvalue: 0 description: Read throughput limit in bytes per second. name: read_bytes_sec type: uint -- defaultvalue: 0 - means unlimited +- defaultvalue: 0 description: Write throughput limit in bytes per second. name: write_bytes_sec type: uint -- defaultvalue: 0 - means unlimited +- defaultvalue: 0 description: Total I/O operations limit per second. name: total_iops_sec type: uint -- defaultvalue: 0 - means unlimited +- defaultvalue: 0 description: Read I/O operations limit per second. name: read_iops_sec type: uint -- defaultvalue: 0 - means unlimited +- defaultvalue: 0 description: Write I/O operations limit per second. name: write_iops_sec type: uint -- To view, visit https://gerrit.ovirt.org/65113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: travis: Fix build using new docker image
Piotr Kliczewski has posted comments on this change. Change subject: travis: Fix build using new docker image .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65070/1/.travis.yml File .travis.yml: PS1, Line 12: nirs/vdsm-centos how is it different from what Edward created? Should we have something more official? -- To view, visit https://gerrit.ovirt.org/65070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I807adb49c7a653d9ca6e58ff40a82a270eaf3309 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: dockerfile: Install developer tools using pip
Piotr Kliczewski has posted comments on this change. Change subject: dockerfile: Install developer tools using pip .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65069/1/contrib/Dockerfile File contrib/Dockerfile: PS1, Line 24: python34-nose what about this one? -- To view, visit https://gerrit.ovirt.org/65069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4e10a727af5f75b6ede3cc271c2e32eac2fedd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: dockerfile: Use one package per line
Piotr Kliczewski has posted comments on this change. Change subject: dockerfile: Use one package per line .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ae78f149fc0042853c71c7f2f7bb8cf6300e1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: dockerfile: Add missing packages
Piotr Kliczewski has posted comments on this change. Change subject: dockerfile: Add missing packages .. Patch Set 1: (2 comments) Please make sure that we use the same set of depts in check-patch.packages.el7 and here. Not sure whether we should update one or the other. https://gerrit.ovirt.org/#/c/65067/1/contrib/Dockerfile File contrib/Dockerfile: PS1, Line 7: git > should be in separate line I saw it in another patch PS1, Line 12: mom > separate line I saw it in another patch -- To view, visit https://gerrit.ovirt.org/65067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I204be6a9b83af9d2b12abc8267d2d1ccd4fd746d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: dockerfile: Add missing packages
Piotr Kliczewski has posted comments on this change. Change subject: dockerfile: Add missing packages .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/65067/1/contrib/Dockerfile File contrib/Dockerfile: Line 1: FROM centos:7 I checked check-patch.packages.el7 and I can see packages like python-mock there. Line 2: RUN yum install -y http://resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm && \ Line 3: yum update -y && \ Line 4: yum install -y \ Line 5: PyYAML \ PS1, Line 7: git should be in separate line PS1, Line 12: mom separate line -- To view, visit https://gerrit.ovirt.org/65067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I204be6a9b83af9d2b12abc8267d2d1ccd4fd746d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: acceptor: stop to double close acceptor
Piotr Kliczewski has posted comments on this change. Change subject: acceptor: stop to double close acceptor .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/63685/2/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: Line 207 Line 208 Line 209 Line 210 Line 211 > Why do you want to remove stop? We know we do not want to close acceptor twice. It is enough to close reactor and acceptor will be closed together with other dispatchers. It is enough to close reactor so the method is not needed here. https://gerrit.ovirt.org/#/c/63685/2/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 109 Line 110 Line 111 Line 112 Line 113 > Why keep the acceptor running? Acceptor will be closed when reactor is closed. https://gerrit.ovirt.org/#/c/63685/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 285 Line 286 Line 287 Line 288 Line 289 > Why keep the acceptor running? I think this patch should only add the line Please see my other replies. -- To view, visit https://gerrit.ovirt.org/63685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Fix API schema to align with runtime schema
Piotr Kliczewski has posted comments on this change. Change subject: Fix API schema to align with runtime schema .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: acceptor: stop to double close acceptor
Piotr Kliczewski has posted comments on this change. Change subject: acceptor: stop to double close acceptor .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: Line 206 Line 207 Line 208 Line 209 Line 210 > If this class was the owner of the reactor, it was creating the reactor and My suggestion is to fix ownership in different patch. I hate adding responsibility to ClientIF because there is already too much done there. Reactor is used by clients like migration as well so we need to be careful with the change. In principal I agree with you that we should close were we create. I propose to fix the ownership in different patch. -- To view, visit https://gerrit.ovirt.org/63685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: acceptor: stop to double close acceptor
Piotr Kliczewski has posted comments on this change. Change subject: acceptor: stop to double close acceptor .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: Line 206 Line 207 Line 208 Line 209 Line 210 > I think the fix is to not close the reactor - this class does not own the r With the current code base reactor is owned by this class. I am not sure whether clientIf should be responsible to manege reactor life cycle. There are already too many responsibilities for cif. I do not see any other class which should own it. Btw changing the ownership of reactor should be not related to the fix for double close issue. -- To view, visit https://gerrit.ovirt.org/63685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: infra tests: added functional test for upgrading vdsm
Piotr Kliczewski has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/61186/14/tests/functional/upgrade_vdsm_test.py File tests/functional/upgrade_vdsm_test.py: PS14, Line 40: 4.17.10.1-0 why to downgrade to this specific version? -- To view, visit https://gerrit.ovirt.org/61186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Piotr Kliczewski has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/63748/10/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS10, Line 6031: 4.0 > This is going to be backported according to current PM priorities. If so we need to keep it as it is. -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Piotr Kliczewski has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/63748/10/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS10, Line 6031: 4.0 > This is a master patch, and 4.0.z is already out, so *here* must be 4.1 any This number means when the change was introduced so if we are going to backport 4.0 is OK. If we won't backport it should be 4.1. -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: More standard logging format
Piotr Kliczewski has posted comments on this change. Change subject: logging: More standard logging format .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Peter Portante <peter.porta...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Piotr Kliczewski has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/63748/10/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS10, Line 6031: 4.0 Dan, Francesco are we ok with backporting api change to stable branch? If not we should have 4.1 here. -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Piotr Kliczewski has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/63748/9/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS9, Line 7643: 4.0 Dan, Are we ok with changing api in z-stream? -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: API: modernize VM methods
Piotr Kliczewski has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: logging: add and use new devel logger
Piotr Kliczewski has posted comments on this change. Change subject: logging: add and use new devel logger .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: remove capsTests from blacklist
Piotr Kliczewski has posted comments on this change. Change subject: py3: remove capsTests from blacklist .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49264d5eaa19bb957c69461dfb1cdfe641294037 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt' Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@' Line 156: Line 157: # location of the certificates Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki', 'vdsm') > I just hate this constants.py junkyard. Good idea, let's do it Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem') Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem') -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: add migrate and migrateStatus .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
Piotr Kliczewski has posted comments on this change. Change subject: tests: inspect.getargspec() is deprecated in py3 .. Patch Set 2: Verified+1 Verified by running build on my f23. -- To view, visit https://gerrit.ovirt.org/64313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: add migrateStatus
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: add migrateStatus .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: acceptor: stop to double close acceptor
Piotr Kliczewski has posted comments on this change. Change subject: acceptor: stop to double close acceptor .. Patch Set 1: Verified+1 Verified by running tests several times. -- To view, visit https://gerrit.ovirt.org/63685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
Piotr Kliczewski has posted comments on this change. Change subject: tests: inspect.getargspec() is deprecated in py3 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64313/1/tests/testlib.py File tests/testlib.py: Line 45: import mock Line 46: mock Line 47: Line 48: try: Line 49: from inspect import getfullargspec as getargspec > gasp. I see in https://docs.python.org/3/library/inspect.html#inspect.getfu signature, is very compatible with get*argspec :/, will explore Line 50: except ImportError: # py2 Line 51: from inspect import getargspec as getargspec Line 52: getargspec Line 53: -- To view, visit https://gerrit.ovirt.org/64313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: inspect.getargspec() is deprecated in py3
..
tests: inspect.getargspec() is deprecated in py3
We do not want to see following warning during running tests:
DeprecationWarning: inspect.getargspec() is deprecated
Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Signed-off-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
---
M tests/api_test.py
M tests/schemaValidationTest.py
M tests/testlib.py
3 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/64313/1
diff --git a/tests/api_test.py b/tests/api_test.py
index 3c57381..b977415 100644
--- a/tests/api_test.py
+++ b/tests/api_test.py
@@ -18,12 +18,11 @@
# Refer to the README and COPYING files for full details of the license
#
-import inspect
-
from vdsm.common import api
from vdsm.common import exception
from vdsm.common import response
+from testlib import getargspec
from testlib import VdsmTestCase as TestCaseBase
@@ -31,10 +30,10 @@
def test_preserve_signature(self):
vm = FakeVM()
-args = inspect.getargspec(vm.fail)
+args = getargspec(vm.fail)
self.assertEqual(args.args, ['self', 'exc'])
self.assertEqual(args.varargs, None)
-self.assertEqual(args.keywords, None)
+self.assertEqual(getattr(args, 'keywords', None), None)
class TestResponse(TestCaseBase):
diff --git a/tests/schemaValidationTest.py b/tests/schemaValidationTest.py
index fd87724..13df62f 100644
--- a/tests/schemaValidationTest.py
+++ b/tests/schemaValidationTest.py
@@ -29,6 +29,7 @@
from vdsm.rpc import Bridge
from api import vdsmapi
+from testlib import getargspec
from testlib import VdsmTestCase as TestCaseBase
from contextlib import contextmanager
@@ -169,12 +170,12 @@
yield class_name, class_obj
def _get_args(self, method_obj):
-args = inspect.getargspec(method_obj).args
+args = getargspec(method_obj).args
args.remove('self')
return args
def _get_default_args(self, method_obj):
-argSpec = inspect.getargspec(method_obj)
+argSpec = getargspec(method_obj)
if argSpec.defaults:
return argSpec.args[- len(argSpec.defaults):]
else:
diff --git a/tests/testlib.py b/tests/testlib.py
index c341c24..7c63a38 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -45,6 +45,12 @@
import mock
mock
+try:
+from inspect import getfullargspec as getargspec
+except ImportError: # py2
+from inspect import getargspec as getargspec
+getargspec
+
from nose import config
from nose import core
from nose import result
--
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks
Piotr Kliczewski has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: simplified client
Piotr Kliczewski has posted comments on this change. Change subject: stomp: simplified client .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: contrib: Simple jsonrpc client
Piotr Kliczewski has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 20: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/35181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <toni+ov...@midokura.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: contrib: Simple jsonrpc client
Piotr Kliczewski has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 18: (3 comments) https://gerrit.ovirt.org/#/c/35181/18//COMMIT_MSG Commit Message: Line 27: # jsonrpc StorageDomain.activate -f sd-activate Line 28: ... Line 29: Line 30: where sd-activate file content is: Line 31: storagedomainID=75ab40e3-06b1-4a54-a825-2df7a40b93b2, Now we use json in the file. please update here as well. Line 32: storagepoolID=b3f6fa00-b315-4ad4-8108-f73da817b5c5 Line 33: Line 34: It is also possible to read parameters from standard input, creating Line 35: complex parameters interactively: Line 34: It is also possible to read parameters from standard input, creating Line 35: complex parameters interactively: Line 36: Line 37: # jsonrpc StorageDomain.activate -f - Line 38: storagedomainID=75ab40e3-06b1-4a54-a825-2df7a40b93b2, and here Line 39: storagepoolID=b3f6fa00-b315-4ad4-8108-f73da817b5c5 Line 40: (Press Ctrl + D to finish) Line 41: Line 42: Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 https://gerrit.ovirt.org/#/c/35181/18/contrib/jsonrpc File contrib/jsonrpc: PS18, Line 72: import six why do we need it? -- To view, visit https://gerrit.ovirt.org/35181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <toni+ov...@midokura.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: yml: generate api doc from the schema
Piotr Kliczewski has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 25: ping -- To view, visit https://gerrit.ovirt.org/56387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 84: self.addCopySpec("/etc/vdsm-reg/*")
Line 85: logsize = self.getOption('logsize')
Line 86: self.__addCopySpecLogLimit("/var/log/vdsm/*", logsize)
Line 87: self.__addCopySpecLogLimit("/var/log/vdsm-reg/*", logsize)
Line 88: self._addVdsmRunDir()
> I share Nir's worry - I think we should keep collecting the key directory.
Will check
Line 89: self.addCopySpec("@HOOKSDIR@")
Line 90: self.addCopySpec("@VDSMLIBDIR@")
Line 91: self.addCopySpec("/var/log/ovirt.log")
Line 92: self.addCopySpec("/var/log/sanlock.log")
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: drop the warnings module configuration
Piotr Kliczewski has posted comments on this change. Change subject: vdsm: drop the warnings module configuration .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
Piotr Kliczewski has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 2: Looks good to me but please add example to commit message as Milan suggests -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
Piotr Kliczewski has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Use same log format in the tests
Piotr Kliczewski has posted comments on this change. Change subject: logging: Use same log format in the tests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8a6c07442d3fb2dd86d08f5c71c3b640bbda43d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: API: modernize VM methods
Piotr Kliczewski has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: api: allow to return prebuilt responses
Piotr Kliczewski has posted comments on this change. Change subject: lib: api: allow to return prebuilt responses .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: response: helper to detect valid responses
Piotr Kliczewski has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Piotr Kliczewski has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Piotr Kliczewski has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS2, Line 7626: object
This is too generic. We need to specify type we return.
https://gerrit.ovirt.org/#/c/63748/2/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 257: """
Line 258: del ret['status']
Line 259: return ret
Line 260:
Line 261: def Host_getAllVmIoTunePolicies_Ret(ret):
This should be not needed.
Line 262: return ret
Line 263:
Line 264: def Host_getVMList_Call(api, args):
Line 265: """
Line 355: 'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 356: 'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
Line 357: 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret':
'vmList'},
Line 358: 'Host_getAllVmStats': {'ret': 'statsList'},
Line 359: 'Host_getAllVmIoTunePolicies': {'ret':
Host_getAllVmIoTunePolicies_Ret},
Same here.
Line 360: 'Host_setupNetworks': {'ret': 'status'},
Line 361: 'Host_setKsmTune': {'ret': 'status'},
Line 362: 'Image_cloneStructure': {'ret': 'uuid'},
Line 363: 'Image_delete': {'ret': 'uuid'},
--
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jto...@redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Roman Mohr <rm...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: stomp: use socket pending
Piotr Kliczewski has posted comments on this change. Change subject: stomp: use socket pending .. Patch Set 3: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/63482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Piotr Kliczewski has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: After rebase this patch is not needed anymore. There are new issues that I noticed in vdsm/static dir. Deleting this change. -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Piotr Kliczewski has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: sure -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: add and use new devel logger
Piotr Kliczewski has posted comments on this change. Change subject: logging: add and use new devel logger .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: move define.py under common
Piotr Kliczewski has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Piotr Kliczewski has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > Sure, documentation is a must, but it is not enough. Why is it not enough? We are talking about developers not users. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
