Change in vdsm[master]: v2v: add test for Xen block device

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: add test for Xen block device
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[fromani]

Francesco Romani has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

I for myself support this direction. This format is much much nicer and easier 
to work with.
The idea to have a log parser helper is also very nice.

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 1:

(1 comment)

Just a typo in commit message. Other than that LGTM.

https://gerrit.ovirt.org/#/c/64123/1//COMMIT_MSG
Commit Message:

PS1, Line 10: leaned
Typo?


-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Remove OVS bond implementation.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Remove OVS bond implementation.
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove useless volume size monitoring

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: Remove useless volume size monitoring
..


Patch Set 5: Verified-1

This does not work yet - we must replace the usage of Drive.apparentsize and 
Drive.truesize in vmstats.

The previous patch tried to replace it with libvirt bulk stats, but it does not 
work because the semantics of libvirt allocation do not match ovirt truesize.

-- 
To view, visit https://gerrit.ovirt.org/59801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1436c2968f3e408ce38a913c6ca3146a25a312d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 64: :param vol_path: path to the volume
Line 65: """
Line 66: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', 
vol_path]
Line 67: 
Line 68: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 
'direct'})
> Please also check if here we need the same fix as f9d1286
Good point, we need the same fix here.
Line 69: 
Line 70: if rc != 0:


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 33: Verified+1

trivial patch, covered by tests.

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[tnisan]

Tal Nisan has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64123/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: alignmentScan: Use proper environment
Line 8: 
Line 9: In commit f9d12864a404 (v2v: Running virt-v2v with some sane
Line 10: environment) we leaned that we should not use bare environment dict.
> Typo?
Yes, thanks for reading this
Line 11: This patch fixes the environment when running virt-alignment-scan.
Line 12: 
Line 13: Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e


-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 30:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Remove OVS bond implementation.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Remove OVS bond implementation.
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Relocate sysfs_bond_permission to nettestlib
..

net: Relocate sysfs_bond_permission to nettestlib

CI does not always allow access to sysfs and will fail the tests when
such access is attempted.

Linux bonds driver is using sysfs to configure bonds.
This patch locates the sysfs bond access permission check under
nettestlib in order to allow several test modules to use it when bonbs
are involved.

Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d
Signed-off-by: Edward Haas 
---
M tests/network/link_bond_test.py
M tests/network/nettestlib.py
2 files changed, 20 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/64131/1

diff --git a/tests/network/link_bond_test.py b/tests/network/link_bond_test.py
index a610f63..021fda8 100644
--- a/tests/network/link_bond_test.py
+++ b/tests/network/link_bond_test.py
@@ -21,21 +21,18 @@
 from contextlib import contextmanager
 
 from nose.plugins.attrib import attr
-from nose.plugins.skip import SkipTest
 
 from testlib import VdsmTestCase as TestCaseBase
 
-from .nettestlib import dummy_devices
+from .nettestlib import dummy_devices, check_sysfs_bond_permission
 
 from vdsm.network.link import iface
 from vdsm.network.link.bond import Bond
-from vdsm.network.link.bond import BondSysFS
 from vdsm.utils import random_iface_name
 
 
 def setup_module():
-if not _has_sysfs_bond_permission():
-raise SkipTest("This test requires sysfs bond write access")
+check_sysfs_bond_permission()
 
 
 @attr(type='integration')
@@ -112,13 +109,3 @@
 yield bond
 finally:
 bond.destroy()
-
-
-def _has_sysfs_bond_permission():
-bond = BondSysFS(random_iface_name('check_', max_length=11))
-try:
-bond.create()
-bond.destroy()
-except IOError:
-return False
-return True
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index df66d53..42673af 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -38,10 +38,10 @@
 from vdsm.network.ipwrapper import (
 addrAdd, linkSet, linkAdd, linkDel, IPRoute2Error, netns_add, netns_delete,
 netns_exec)
-from vdsm.network.link import iface as linkiface
+from vdsm.network.link import iface as linkiface, bond as linkbond
 from vdsm.network.netlink import monitor
 from vdsm.commands import execCmd
-from vdsm.utils import CommandPath, random_iface_name
+from vdsm.utils import CommandPath, memoized, random_iface_name
 
 from . import dhcp
 from . import firewall
@@ -480,3 +480,19 @@
 yield
 finally:
 shutil.copy2(RESOLV_CONF_BACKUP, RESOLV_CONF)
+
+
+def check_sysfs_bond_permission():
+if not _has_sysfs_bond_permission():
+raise SkipTest("This test requires sysfs bond write access")
+
+
+@memoized
+def _has_sysfs_bond_permission():
+bond = linkbond.BondSysFS(random_iface_name('check_', max_length=11))
+try:
+bond.create()
+bond.destroy()
+except IOError:
+return False
+return True


-- 
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Relocate sysfs_bond_permission to nettestlib
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Relocate sysfs_bond_permission to nettestlib
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG
Commit Message:

PS1, Line 14: bonbs
bonds


https://gerrit.ovirt.org/#/c/64131/1/tests/network/nettestlib.py
File tests/network/nettestlib.py:

PS1, Line 487: "
' please


-- 
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move exception.py under common

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: move exception.py under common
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: v2v: add test for Xen block device

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add test for Xen block device
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[automation]

gerrit-hooks has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 64: :param vol_path: path to the volume
Line 65: """
Line 66: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', 
vol_path]
Line 67: 
Line 68: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 
'direct'})
> Good point, we need the same fix here.
Also, do we have a virt-sparsify bug for this? We need a comment like this:
https://github.com/oVirt/vdsm/blob/master/vdsm/alignmentScan.py#L43
Line 69: 
Line 70: if rc != 0:


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: alignmentScan: Use proper environment
..

alignmentScan: Use proper environment

In commit f9d12864a404 (v2v: Running virt-v2v with some sane
environment) we leaned that we should not use bare environment dict.
This patch fixes the environment when running virt-alignment-scan.

Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Signed-off-by: Nir Soffer 
---
M vdsm/alignmentScan.py
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/64123/1

diff --git a/vdsm/alignmentScan.py b/vdsm/alignmentScan.py
index 0957c05..3c72a9b 100644
--- a/vdsm/alignmentScan.py
+++ b/vdsm/alignmentScan.py
@@ -19,6 +19,7 @@
 #
 
 
+import os
 from collections import namedtuple
 from vdsm.utils import CommandPath
 from vdsm.storage.misc import execCmd
@@ -40,10 +41,12 @@
 def runScanArgs(*args):
 cmd = [_virtAlignmentScan.cmd]
 cmd.extend(args)
-# TODO: remove the environment variable when the issue in
+# TODO: remove the environment when the issue in
 # virt-alignment-scan/libvirt is resolved
 # http://bugzilla.redhat.com/1151838
-return execCmd(cmd, env={'LIBGUESTFS_BACKEND': 'direct'})
+env = os.environ.copy()
+env['LIBGUESTFS_BACKEND'] = 'direct'
+return execCmd(cmd, env=env)
 
 
 def scanImage(image_path):


-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Rely on system for logrotation

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: vdsm: Rely on system for logrotation
..


Patch Set 3: Code-Review-1

Thanks Dan. Somehow I have missed this change when browsing through related 
history.

If we really can generate more than 15 MB of logs per day and we want to run 
logrotate hourly (as opposed to daily by the system) then it makes sense to 
stick with what we do now. In this case we can abandon this change.

-- 
To view, visit https://gerrit.ovirt.org/63682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Rely on system for logrotation

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Rely on system for logrotation
..


Patch Set 3:

Please send another patch documenting why we are not using logrotate in the 
standard way, with url to the relevant bugs.

-- 
To view, visit https://gerrit.ovirt.org/63682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 6: Verified+1

The added test fails without ifcfg changes, passes with them.

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 6:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Remove OVS bond implementation.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Remove OVS bond implementation.
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

Yaniv, you are trying to force your warnings on other developers.

We are trying to help developers using our software, not punish them or their 
users.

We can add python warnings, we can add warnings in documentation, add release 
notes etc.

We cannot spam people stderr or logs with unrelated warnings.

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

Maybe we need to have a library for parsing vdsm logs. We already have this 
code in some tools (e.g contrib/db). This will make it easy for people, they 
can use the current vdsm log parser and do not worry.

We cannot help people parsing logs with grep/awk etc. The only option to 
support this is to never change anything and keep the current horrible format.

I'll update logdb and other tools that depend on the logs if we have agreement 
to go in this direction.

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: **WIP** tool: reconfigure containers networks
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: filter out 'veth' devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: filter out 'veth' devices
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[automation]

gerrit-hooks has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move the response.py under common

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: move the response.py under common
..


Patch Set 3:

Junkins failure is unrelated:

DEBUG package_manager.py:96:  ['/usr/bin/yum-deprecated', '--installroot', 
'/var/lib/mock/epel-7-x86_64-dcebbf316d769782f44acc0ef5f2397b-31868/root/', 
'--releasever', '7', 'install', '@buildsys-build']
DEBUG util.py:567:  child environment: None
DEBUG util.py:499:  Executing command: ['/usr/bin/yum-deprecated', 
'--installroot', 
'/var/lib/mock/epel-7-x86_64-dcebbf316d769782f44acc0ef5f2397b-31868/root/', 
'--releasever', '7', 'install', '@buildsys-build', 
'--setopt=tsflags=nocontexts'] with env {'HOSTNAME': 'mock', 'PATH': 
'/usr/bin:/bin:/usr/sbin:/sbin', 'LD_PRELOAD': 
'/tmp/tmpg21g8hqp/$LIB/nosync.so', 'LANG': 'en_US.UTF-8', 'HOME': '/builddir', 
'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\\033]0;\\007"', 
'PS1': ' \\s-\\v\\$ ', 'TERM': 'vt100', 'LC_MESSAGES': 'C'} and 
shell False
DEBUG util.py:421:  Yum command has been deprecated, use dnf instead.
DEBUG util.py:421:  See 'man dnf' and 'man yum2dnf' for more information.
DEBUG util.py:421:  
http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/49b8ba752141a73495c14e1fbf11e910209fddf08caacef99d3bb5cbc979d339-updateinfo.xml.bz2:
 [Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:421:  Trying other mirror.
DEBUG util.py:421:  
http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz:
 [Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:421:  Trying other mirror.
DEBUG util.py:421:  
http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz:
 [Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:421:  Trying other mirror.
DEBUG util.py:421:  
http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz:
 [Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:421:  Trying other mirror.
DEBUG util.py:421:   One of the configured repositories failed ("Custom epel"),
DEBUG util.py:421:   and yum doesn't have enough cached data to continue. At 
this point the only
DEBUG util.py:421:   safe thing yum can do is fail. There are a few ways to 
work "fix" this:
DEBUG util.py:421:   1. Contact the upstream for the repository and get 
them to fix the problem.
DEBUG util.py:421:   2. Reconfigure the baseurl/etc. for the repository, to 
point to a working
DEBUG util.py:421:  upstream. This is most often useful if you are 
using a newer
DEBUG util.py:421:  distribution release than is supported by the 
repository (and the
DEBUG util.py:421:  packages for the previous distribution release 
still work).
DEBUG util.py:421:   3. Disable the repository, so yum won't use it by 
default. Yum will then
DEBUG util.py:421:  just ignore the repository until you permanently 
enable it again or use
DEBUG util.py:421:  --enablerepo for temporary usage:
DEBUG util.py:421:  yum-config-manager --disable epel
DEBUG util.py:421:   4. Configure the failing repository to be skipped, if 
it is unavailable.
DEBUG util.py:421:  Note that yum will try to contact the repo. when it 
runs most commands,
DEBUG util.py:421:  so will have to try and fail each time (and thus. 
yum will be be much
DEBUG util.py:421:  slower). If it is a very temporary problem though, 
this is often a nice
DEBUG util.py:421:  compromise:
DEBUG util.py:421:  yum-config-manager --save 
--setopt=epel.skip_if_unavailable=true
DEBUG util.py:421:  failure: 
repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz
 from epel: [Errno 256] No more mirrors to try.
DEBUG util.py:421:  
http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz:
 [Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:546:  Child return code was: 1

-- 
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Relocate sysfs_bond_permission to nettestlib
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG
Commit Message:

PS1, Line 14: bonbs
> bonds
Done


https://gerrit.ovirt.org/#/c/64131/1/tests/network/nettestlib.py
File tests/network/nettestlib.py:

PS1, Line 487: "
> ' please
Done


-- 
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

I'm ok with this approach, better than my https://gerrit.ovirt.org/#/c/64117/

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdscli: do not use the warnings module

[fromani]

Francesco Romani has abandoned this change.

Change subject: vdscli: do not use the warnings module
..


Abandoned

replaced by https://gerrit.ovirt.org/#/c/64100/2

-- 
To view, visit https://gerrit.ovirt.org/64117
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3481538292cf1a77329faf3d7701767b6e0bfd60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdscli: do not use the warnings module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdscli: do not use the warnings module
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/64117
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3481538292cf1a77329faf3d7701767b6e0bfd60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13: Code-Review+1

(1 comment)

Just one possible caveat - please check inline comments.
Looks good to me, let's just address the missing comments from storage team.

https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 64: :param vol_path: path to the volume
Line 65: """
Line 66: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', 
vol_path]
Line 67: 
Line 68: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 
'direct'})
> Please add documentation why this is needed, I know Richard is against usin
Please also check if here we need the same fix as f9d1286
Line 69: 
Line 70: if rc != 0:


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13: Code-Review-1

since there are pending comments, -1 for visibility is actually better :\

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: supervdsm: expose systemd utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: expose systemd utilities
..


Patch Set 29:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 29:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: containers: add the container support module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: core: containers: add the container support module
..


Patch Set 31:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[fromani]

Francesco Romani has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 29: Verified+1

verified running patched Vdsm, and using the tests.

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 42:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 42
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: virt: add optional container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: virt: add optional container support
..


Patch Set 49:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 49
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: **WIP** tool: reconfigure containers networks
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 33:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: filter out 'veth' devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: filter out 'veth' devices
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmxml: export container metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: export container metadata
..


Patch Set 21:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 18:

code coverage is pretty good:

00:08:20.964 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/__init__
 41  0   100%   
00:08:21.142 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/command
 120  794%   46, 185-186, 197, 205, 208, 211
00:08:21.143 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/config/__init__
  18  0   100%   
00:08:21.143 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/config/environ
   17  0   100%   
00:08:21.143 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/config/network
   17  0   100%   
00:08:21.144 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/connection
   47  296%   83, 86
00:08:21.144 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/domain
  100  0   100%   
00:08:21.144 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/doms
 20  0   100%   
00:08:21.144 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/errors
8  0   100%   
00:08:21.145 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/events
   50  0   100%   
00:08:21.145 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/fs
   16  288%   38-39
00:08:21.145 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/metrics/__init__
  2  0   100%   
00:08:21.146 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/metrics/cgroups
  88  298%   51, 172
00:08:21.146 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/monitoring
   13  0   100%   
00:08:21.146 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runner
   70  0   100%   
00:08:21.147 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtime
  64  0   100%   
00:08:21.147 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/__init__
   141  696%   119, 187, 216, 219, 223, 229
00:08:21.147 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/docker
  36  0   100%   
00:08:21.148 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/fake
35  0   100%   
00:08:21.148 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/rkt
133  298%   156, 168
00:08:21.148 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/xmlconstants
  9  0   100%   
00:08:21.148 
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/xmlfile
  33  0   100%

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 18: Verified+1

this patch adds only tests, so as long as juenkins is happy, so we are.

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[smelamud]

Shmuel Leib Melamud has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py
File vdsm/storage/sdm/api/sparsify_volume.py:

Line 22: 
Line 23: from vdsm import virtsparsify
Line 24: from vdsm.storage import guarded
Line 25: 
Line 26: from .copy_data import CopyDataDivEndpoint
> Importing from another verb is ugly. Since CopyDataDivEndpoint is reusable,
I've asked Adam in e-mail about this:

Me: It will not look good to import copy_data.py from sparsify_volume.py. So, 
we need to move CopyDataDIVEndpoint to some common place. What place should it 
be?

Adam: For your first patch could you just try and do:

from copy_data import CopyDataDIVEndpoint

I want to keep the same names as in the schema for clarity. Later on, we can 
move the implementation of CopyDataDIVEndpoint out to a common module if 
necessary but I don't want to delay your verb for this.  We are simultaneously 
making improvements to CopyDataDIVEndpoint (locking, etc) and it will be easier 
to continue development in its current location for now.
Line 27: 
Line 28: from . import base
Line 29: 
Line 30: 


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[fromani]

Francesco Romani has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1: Code-Review+1

I like this. We tried to change our log format in the past, without much luck. 
Let's try again.
There is a high chance this will break scripts/tools from GSS/QE/users, 
however, perhaps better advertise this ad give the users plenty of time to 
upgrade.

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Introduce the thinp module

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Introduce the thinp module
..


Patch Set 1: Code-Review+1

I like this direction, but I want too see how this evolves. Provisional +1

-- 
To view, visit https://gerrit.ovirt.org/64102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb627cc5a355f531502f9179e6a3863f4f98202
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[fromani]

Francesco Romani has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 142: 
Line 143: 
Line 144: _devel.warning(
Line 145: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 146: "vdsm.jsonrpcvdscli")
> master is 4.1 - logging warnings to a secret logger the user does not know 
For the moment I'll drop this change from my patch, so we can move forward
Line 147: 
Line 148: 
Line 149: if __name__ == '__main__':
Line 150: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 3:

* #1375076::Update tracker: OK
* Set MODIFIED::bug 1375076#1375076OK

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

And the initial discussion - 
https://www.redhat.com/archives/libguestfs/2015-November/msg00031.html

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2: Code-Review+2

looks good to me.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Code-Review+1

Looks ok, let me try to make jenkins happy.

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: -Verified

* #1375076::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1375076::OK, public bug
* Check Product::#1375076::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1375076::OK, correct target milestone ovirt-3.6.10
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Code-Review+2 Continuous-Integration+1

This failure is irrilevant:

00:06:31.819 
==
00:06:31.819 FAIL: test_events_keys (netlinkTests.NetlinkEventMonitorTests)
00:06:31.820 
--
00:06:31.820 Traceback (most recent call last):
00:06:31.820   File 
"/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
 line 105, in wrapper
00:06:31.820 return f(*args, **kwargs)
00:06:31.820   File 
"/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/netlinkTests.py",
 line 133, in test_events_keys
00:06:31.820 % (1 + len(expected_events)))
00:06:31.821 AssertionError: 5 expected events have not been caught (in the 
right order)
00:06:31.821  >> begin captured logging << 

00:06:31.821 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link add 
name dummy_lBtFM type dummy (cwd None)
00:06:31.821 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.821 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip -4 addr add 
dev dummy_lBtFM 192.0.2.1/24 (cwd None)
00:06:31.821 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.822 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link set dev 
dummy_lBtFM up (cwd None)
00:06:31.822 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.822 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link del dev 
dummy_lBtFM (cwd None)
00:06:31.822 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.822 - >> end captured logging << 
-

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: Live Merge: Refresh base volume before live merge
..


Live Merge: Refresh base volume before live merge

When live merging raw base volume, engine extends the base volume
if it is smaller than the top volume. However, on the host running
the vm, the lv is already active and does not reflect the new size
until we refresh it.  During the merge we don't know whether base
volume extended, so we always refresh it.

Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Bug-Url: https://bugzilla.redhat.com/1375076
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/63454
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63634
Tested-by: Allon Mureinik 
Reviewed-by: Francesco Romani 
Continuous-Integration: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Allon Mureinik: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests
  Ala Hino: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[msivak]

Martin Sivák has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

PS5, Line 40: _devel
I know you do no like long names and it makes PEP 8 compliance harder, but this 
really should be called log_devel or something like that (zen of python: 
explicit is better, readable counts, namespaces are good and so on).

Also I do not really understand the underscore either, it is common for class 
members, but there are other methods to hide module global symbols from 
importers (like __all__).


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Rely on system for logrotation

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Rely on system for logrotation
..


Patch Set 3:

I am not 100% that this still applies, but please discuss 
https://bugzilla.redhat.com/show_bug.cgi?id=1113264 and 
https://gerrit.ovirt.org/#/c/29624/ in your commit message, so we are sure that 
we do not reintroduce something that we used to have.

-- 
To view, visit https://gerrit.ovirt.org/63682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

I'm quite sure this is not the case. If it is only sparsifying the top layer, 
it is not very efficient - it may actually cause the overlay to become bigger.
See https://bugzilla.redhat.com/show_bug.cgi?id=1277705#c9

This is exactly why the feature was supposed to be implemented only in case you 
don't have a 'tree-like' structure.

I agree it is changing the past. We were hoping for a better future ;-)

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 3:

most developers run "make rpm" directly instead of "make check", as this is 
what we advice to do in [1]. with this patch developers will probably avoid 
running the tests at all

[1]https://www.ovirt.org/develop/developer-guide/vdsm/developers/

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> This will show warnings if you run python with warnings enabled.
and if you don't you'll never see it. so for what? you can just write it to 
syslog


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 8: Verified+1

Passed network/*_test.py and functional/networkTests.py OK.

Without introduced ifcfg.py change, new test fails.

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Remove OVS bond implementation.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Remove OVS bond implementation.
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: mount: Wait for systemd temporary mount unit
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove useless volume size monitoring

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: Remove useless volume size monitoring
..


Patch Set 5: Code-Review+1

Not 100% sure we can merge this, but I'd love to have this patch in.

-- 
To view, visit https://gerrit.ovirt.org/59801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1436c2968f3e408ce38a913c6ca3146a25a312d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: remove default route before adding a new one

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: remove default route before adding a new one
..


Patch Set 4:

With this path it is possible to overwrite existing default route. 
network/*_test.py passed OK.

-- 
To view, visit https://gerrit.ovirt.org/63220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie59c07845898630404ce517e5cc52048e50ed2dd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: remove default route before adding a new one

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: remove default route before adding a new one
..


Patch Set 4: -Code-Review Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie59c07845898630404ce517e5cc52048e50ed2dd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

I wonder if we don't want both the warning and a log print

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: remove default route before adding a new one

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: remove default route before adding a new one
..


Patch Set 4: Code-Review+1

With this path it is possible to overwrite existing default route. 
network/*_test.py passed OK.

-- 
To view, visit https://gerrit.ovirt.org/63220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie59c07845898630404ce517e5cc52048e50ed2dd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: mount: Wait for systemd temporary mount unit
..


mount: Wait for systemd temporary mount unit

Systemd is monitoring mountpoints created during runtime by creating a
temporary mount units. For example:

# systemctl status /tmp/mount-1.DUNxySxI2R/wrk
● tmp-mount\x2d1.DUNxySxI2R-wrk.mount - /tmp/mount-1.DUNxySxI2R/wrk
   Loaded: loaded (/proc/self/mountinfo)
   Active: active (mounted) since Sun 2016-04-24 22:37:55 IDT; 14ms ago
Where: /tmp/mount-1.DUNxySxI2R/wrk
 What: /dev/loop2

Mounting and unmounting quickly as we do in the tests, or when creating
a floppy image may confuse systemd, and lead to various errors:

- mountpoint is not mounted when trying to access files or unmount
- mountpoint is busy when trying to unmount

These are probably systemd or mount bugs. Until these issues are
resolve, we need to find a workaround to avoid failures in the tests or
when creating a floppy images.

This patch add udevadm.settle() call after successful mount and umount
operations.

Change-Id: I9b0318eb534f781f127882983527e1a221820478
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/56544
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M lib/vdsm/storage/mount.py
M tests/mkimageTests.py
M tests/mountTests.py
3 files changed, 18 insertions(+), 16 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Wait for systemd temporary mount unit
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 31:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Relocate sysfs_bond_permission to nettestlib
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook nic_libvirt_migration_destination, proposal 2

[automation]

gerrit-hooks has posted comments on this change.

Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63686
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60e4cc7f801033cc830aa1a0aad32afecafe4fea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: api.py: preserve signature in decorator

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: api.py: preserve signature in decorator
..


Patch Set 13: Verified+1

schemaValidation passes with this patch.

-- 
To view, visit https://gerrit.ovirt.org/63759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06205cf180229ea19ffc38a7b88346afc18f13e4
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove python-argparse requirement
..


Patch Set 1:

cstratak reached me in irc as python maintainer and asked to remove this 
requirement from our spec now when its part of stdlib. it used to be Provides 
by python2.7 so we it was redundant anyway. but now he wants to remove this 
Provides as he plans to rename it to python2-argparse and this will break our 
build

-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Remove python-argparse requirement
..

Remove python-argparse requirement

This package has been obsoleted in Fedora because it got in to stdlib.

Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Signed-off-by: Yaniv Bronhaim 
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/64162/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index c09b9a9..abe5f7e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -138,7 +138,6 @@
 Requires: PyYAML
 Requires: python-netaddr
 Requires: python-inotify
-Requires: python-argparse
 Requires: python-cpopen >= 1.4
 Requires: python-ioprocess >= 0.16.1-1
 Requires: python-pthreading >= 0.1.3-3


-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Remove python-argparse requirement
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: response: helper to detect valid responses

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: response: helper to detect valid responses
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py
File lib/vdsm/common/response.py:

Line 85: else:
Line 86: return code != doneCode["code"]
Line 87: 
Line 88: 
Line 89: def is_valid(res):
> Lets add the docstring?
Done, eventually.
Line 90: # catching AttributeError is even uglier
Line 91: if not isinstance(res, dict):
Line 92: return False
Line 93: try:


-- 
To view, visit https://gerrit.ovirt.org/63760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook nic_libvirt_migration_destination, proposal 2

[mmirecki]

Marcin Mirecki has abandoned this change.

Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63686
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I60e4cc7f801033cc830aa1a0aad32afecafe4fea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

[mmirecki]

Marcin Mirecki has abandoned this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: api: allow to return prebuilt responses

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: api: allow to return prebuilt responses
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/61474/12/lib/vdsm/common/api.py
File lib/vdsm/common/api.py:

Line 63: return ret
Line 64: else:
Line 65: _log.debug("FINISH %s response=%s", func.__name__, ret)
Line 66: if ret is None:
Line 67: return response.success()
> Here:
No real good reason, fixing
Line 68: else:


-- 
To view, visit https://gerrit.ovirt.org/61474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[stirabos]

Simone Tiraboschi has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2: Code-Review+1

+1 for me, I agree to take the python way for it.

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Start all VM related stuff after switching to post-cop...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Start all VM related stuff after switching to post-copy 
migration
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b17e58f63cbd9db09e4420871a562eaa0b3f3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bec2881040566261cc6ffaeb8df97eef477a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Relocate sysfs_bond_permission to nettestlib
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/64118/3//COMMIT_MSG
Commit Message:

PS3, Line 18: fixies
fixes


https://gerrit.ovirt.org/#/c/64118/3/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

PS3, Line 204: net_add_setup = 
ovs_switch.create_network_addition_setup(ovs_info)
 : net_add_setup.add(nets2add)
 : acq.acquire(net_add_setup.acquired_ifaces)
do we need to keep setup class here? it would be easier to read if it was a 
plain function:

acquired_ifaces = ovs_switch.add_networks(networks, ovs_info)


-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 19: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org