[webkit-changes] [161205] trunk/Source/WebCore
Title: [161205] trunk/Source/WebCore
Revision 161205
Author an...@apple.com
Date 2014-01-02 01:49:41 -0800 (Thu, 02 Jan 2014)
Log Message
Remove public attachRenderTree
https://bugs.webkit.org/show_bug.cgi?id=126368
Reviewed by Andreas Kling.
Remove the remaining explicit render tree construction.
* dom/Document.cpp:
(WebCore::Document::createRenderTree):
Use recalcStyle() instead of calling attachRenderTree directly.
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addText):
Remove forgotten attachTextRenderer.
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
Remove willAttachRenderers/didAttachRenderers hack.
* html/shadow/InsertionPoint.h:
(WebCore::toInsertionPoint):
* loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::createRenderTree):
Seriously, nothing to do here.
* style/StyleResolveTree.cpp:
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachChildren):
(WebCore::Style::detachDistributedChildren):
(WebCore::Style::detachChildren):
Making attaching and detaching distributed insertion point children part of ResolveTree internals.
* style/StyleResolveTree.h:
Remove interfaces with no clients.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLViewSourceDocument.cpp
trunk/Source/WebCore/html/shadow/InsertionPoint.cpp
trunk/Source/WebCore/html/shadow/InsertionPoint.h
trunk/Source/WebCore/loader/PlaceholderDocument.cpp
trunk/Source/WebCore/style/StyleResolveTree.cpp
trunk/Source/WebCore/style/StyleResolveTree.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (161204 => 161205)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 06:21:06 UTC (rev 161204)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 09:49:41 UTC (rev 161205)
@@ -1,3 +1,46 @@
+2014-01-01 Antti Koivisto an...@apple.com
+
+Remove public attachRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=126368
+
+Reviewed by Andreas Kling.
+
+Remove the remaining explicit render tree construction.
+
+* dom/Document.cpp:
+(WebCore::Document::createRenderTree):
+
+ Use recalcStyle() instead of calling attachRenderTree directly.
+
+* html/HTMLViewSourceDocument.cpp:
+(WebCore::HTMLViewSourceDocument::addText):
+
+Remove forgotten attachTextRenderer.
+
+* html/shadow/InsertionPoint.cpp:
+(WebCore::InsertionPoint::InsertionPoint):
+
+Remove willAttachRenderers/didAttachRenderers hack.
+
+* html/shadow/InsertionPoint.h:
+(WebCore::toInsertionPoint):
+* loader/PlaceholderDocument.cpp:
+(WebCore::PlaceholderDocument::createRenderTree):
+
+Seriously, nothing to do here.
+
+* style/StyleResolveTree.cpp:
+(WebCore::Style::attachDistributedChildren):
+(WebCore::Style::attachChildren):
+(WebCore::Style::detachDistributedChildren):
+(WebCore::Style::detachChildren):
+
+Making attaching and detaching distributed insertion point children part of ResolveTree internals.
+
+* style/StyleResolveTree.h:
+
+Remove interfaces with no clients.
+
2014-01-01 Seokju Kwon seo...@webkit.org
Remove stale ScriptProfiler methods
Modified: trunk/Source/WebCore/dom/Document.cpp (161204 => 161205)
--- trunk/Source/WebCore/dom/Document.cpp 2014-01-02 06:21:06 UTC (rev 161204)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-01-02 09:49:41 UTC (rev 161205)
@@ -1959,9 +1959,6 @@
#endif
recalcStyle(Style::Force);
-
-if (m_documentElement)
-Style::attachRenderTree(*m_documentElement);
}
static void pageWheelEventHandlerCountChanged(Page page)
Modified: trunk/Source/WebCore/html/HTMLViewSourceDocument.cpp (161204 => 161205)
--- trunk/Source/WebCore/html/HTMLViewSourceDocument.cpp 2014-01-02 06:21:06 UTC (rev 161204)
+++ trunk/Source/WebCore/html/HTMLViewSourceDocument.cpp 2014-01-02 09:49:41 UTC (rev 161205)
@@ -240,7 +240,6 @@
}
RefPtrText text = Text::create(*this, substring);
m_current-parserAppendChild(text);
-Style::attachTextRenderer(*text);
if (i size - 1)
finishLine();
}
Modified: trunk/Source/WebCore/html/shadow/InsertionPoint.cpp (161204 => 161205)
--- trunk/Source/WebCore/html/shadow/InsertionPoint.cpp 2014-01-02 06:21:06 UTC (rev 161204)
+++ trunk/Source/WebCore/html/shadow/InsertionPoint.cpp 2014-01-02 09:49:41 UTC (rev 161205)
@@ -43,44 +43,12 @@
: HTMLElement(tagName, document, CreateInsertionPoint)
, m_hasDistribution(false)
{
-setHasCustomStyleResolveCallbacks();
}
InsertionPoint::~InsertionPoint()
{
}
-void InsertionPoint::willAttachRenderers()
-{
-if (ShadowRoot* shadowRoot = containingShadowRoot())
-
[webkit-changes] [161206] trunk/Source/JavaScriptCore
Title: [161206] trunk/Source/_javascript_Core Revision 161206 Author benja...@webkit.org Date 2014-01-02 03:43:33 -0800 (Thu, 02 Jan 2014) Log Message Attempt to fix the build of WebCore's code generator on CMake based system https://bugs.webkit.org/show_bug.cgi?id=126271 Reviewed by Sam Weinig. * CMakeLists.txt: Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (161205 => 161206) --- trunk/Source/_javascript_Core/CMakeLists.txt 2014-01-02 09:49:41 UTC (rev 161205) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2014-01-02 11:43:33 UTC (rev 161206) @@ -631,6 +631,12 @@ API/_javascript_Core.h API/OpaqueJSString.h API/WebKitAvailability.h + +assembler/LinkBuffer.h +assembler/MacroAssembler.h +assembler/MacroAssemblerCodeRef.h +jit/GPRInfo.h +runtime/VM.h ) Modified: trunk/Source/_javascript_Core/ChangeLog (161205 => 161206) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-02 09:49:41 UTC (rev 161205) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-02 11:43:33 UTC (rev 161206) @@ -1,3 +1,12 @@ +2014-01-02 Benjamin Poulain benja...@webkit.org + +Attempt to fix the build of WebCore's code generator on CMake based system +https://bugs.webkit.org/show_bug.cgi?id=126271 + +Reviewed by Sam Weinig. + +* CMakeLists.txt: + 2013-12-30 Commit Queue commit-qu...@webkit.org Unreviewed, rolling out r161157, r161158, r161160, r161161, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161207] trunk/Source/WebCore
Title: [161207] trunk/Source/WebCore Revision 161207 Author an...@apple.com Date 2014-01-02 07:50:28 -0800 (Thu, 02 Jan 2014) Log Message Remove PlaceholderDocument https://bugs.webkit.org/show_bug.cgi?id=126382 Reviewed by Andreas Kling. Remove PlaceholderDocument class and replace it with a bit in Document. * WebCore.xcodeproj/project.pbxproj: * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createRenderTree): * dom/Document.h: Also make Synthesized a construction flag instead of a boolean parameter. (WebCore::Document::createNonRenderedPlaceholder): * html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): * html/HTMLDocument.h: (WebCore::HTMLDocument::create): (WebCore::HTMLDocument::createSynthesizedDocument): * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): * loader/PlaceholderDocument.cpp: Removed. * loader/PlaceholderDocument.h: Removed. * pdf/ios/PDFDocument.h: (WebCore::PDFDocument::PDFDocument): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/html/HTMLDocument.cpp trunk/Source/WebCore/html/HTMLDocument.h trunk/Source/WebCore/loader/DocumentWriter.cpp trunk/Source/WebCore/pdf/ios/PDFDocument.h Removed Paths trunk/Source/WebCore/loader/PlaceholderDocument.cpp trunk/Source/WebCore/loader/PlaceholderDocument.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (161206 => 161207) --- trunk/Source/WebCore/CMakeLists.txt 2014-01-02 11:43:33 UTC (rev 161206) +++ trunk/Source/WebCore/CMakeLists.txt 2014-01-02 15:50:28 UTC (rev 161207) @@ -1656,7 +1656,6 @@ loader/NavigationScheduler.cpp loader/NetscapePlugInStreamLoader.cpp loader/PingLoader.cpp -loader/PlaceholderDocument.cpp loader/PolicyCallback.cpp loader/PolicyChecker.cpp loader/ProgressTracker.cpp Modified: trunk/Source/WebCore/ChangeLog (161206 => 161207) --- trunk/Source/WebCore/ChangeLog 2014-01-02 11:43:33 UTC (rev 161206) +++ trunk/Source/WebCore/ChangeLog 2014-01-02 15:50:28 UTC (rev 161207) @@ -1,3 +1,33 @@ +2014-01-02 Antti Koivisto an...@apple.com + +Remove PlaceholderDocument +https://bugs.webkit.org/show_bug.cgi?id=126382 + +Reviewed by Andreas Kling. + +Remove PlaceholderDocument class and replace it with a bit in Document. + +* WebCore.xcodeproj/project.pbxproj: +* dom/Document.cpp: +(WebCore::Document::Document): +(WebCore::Document::createRenderTree): +* dom/Document.h: + +Also make Synthesized a construction flag instead of a boolean parameter. + +(WebCore::Document::createNonRenderedPlaceholder): +* html/HTMLDocument.cpp: +(WebCore::HTMLDocument::HTMLDocument): +* html/HTMLDocument.h: +(WebCore::HTMLDocument::create): +(WebCore::HTMLDocument::createSynthesizedDocument): +* loader/DocumentWriter.cpp: +(WebCore::DocumentWriter::createDocument): +* loader/PlaceholderDocument.cpp: Removed. +* loader/PlaceholderDocument.h: Removed. +* pdf/ios/PDFDocument.h: +(WebCore::PDFDocument::PDFDocument): + 2014-01-01 Antti Koivisto an...@apple.com Remove public attachRenderTree Modified: trunk/Source/WebCore/GNUmakefile.list.am (161206 => 161207) --- trunk/Source/WebCore/GNUmakefile.list.am 2014-01-02 11:43:33 UTC (rev 161206) +++ trunk/Source/WebCore/GNUmakefile.list.am 2014-01-02 15:50:28 UTC (rev 161207) @@ -4031,8 +4031,6 @@ Source/WebCore/loader/NetscapePlugInStreamLoader.h \ Source/WebCore/loader/PingLoader.cpp \ Source/WebCore/loader/PingLoader.h \ - Source/WebCore/loader/PlaceholderDocument.cpp \ - Source/WebCore/loader/PlaceholderDocument.h \ Source/WebCore/loader/PolicyCallback.cpp \ Source/WebCore/loader/PolicyCallback.h \ Source/WebCore/loader/PolicyChecker.cpp \ Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (161206 => 161207) --- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-01-02 11:43:33 UTC (rev 161206) +++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-01-02 15:50:28 UTC (rev 161207) @@ -7114,7 +7114,6 @@ ClCompile Include=..\loader\NavigationScheduler.cpp / ClCompile Include=..\loader\NetscapePlugInStreamLoader.cpp / ClCompile Include=..\loader\PingLoader.cpp / -ClCompile Include=..\loader\PlaceholderDocument.cpp / ClCompile Include=..\loader\PolicyCallback.cpp / ClCompile Include=..\loader\PolicyChecker.cpp / ClCompile Include=..\loader\ProgressTracker.cpp / @@ -19005,7 +19004,6 @@ ClInclude Include=..\loader\NavigationScheduler.h / ClInclude Include=..\loader\NetscapePlugInStreamLoader.h / ClInclude
[webkit-changes] [161208] trunk/Source/WebCore
Title: [161208] trunk/Source/WebCore
Revision 161208
Author an...@apple.com
Date 2014-01-02 07:51:59 -0800 (Thu, 02 Jan 2014)
Log Message
Always resolve style from root
https://bugs.webkit.org/show_bug.cgi?id=126380
Reviewed by Andreas Kling.
Forced style resolve that does not start from the root is never really correct.
Remove the few remaining instances.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setResetStyleInheritance):
Update style asynchronously.
* dom/ShadowRoot.h:
* dom/Text.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createElementRenderer):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
Delete the render tree synchronously on suspend and rebuild it asynchronously on resume.
No need for m_customStyleForPageCache hack.
* html/HTMLPlugInImageElement.h:
Remove m_customStyleForPageCache.
* style/StyleResolveTree.cpp:
* style/StyleResolveTree.h:
Remove Element version of resolveTree from the interface.
* svg/SVGUseElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/dom/Text.h
trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp
trunk/Source/WebCore/html/HTMLPlugInImageElement.h
trunk/Source/WebCore/style/StyleResolveTree.cpp
trunk/Source/WebCore/style/StyleResolveTree.h
trunk/Source/WebCore/svg/SVGUseElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (161207 => 161208)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 15:50:28 UTC (rev 161207)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 15:51:59 UTC (rev 161208)
@@ -1,5 +1,41 @@
2014-01-02 Antti Koivisto an...@apple.com
+Always resolve style from root
+https://bugs.webkit.org/show_bug.cgi?id=126380
+
+Reviewed by Andreas Kling.
+
+Forced style resolve that does not start from the root is never really correct.
+Remove the few remaining instances.
+
+* dom/ShadowRoot.cpp:
+(WebCore::ShadowRoot::setResetStyleInheritance):
+
+Update style asynchronously.
+
+* dom/ShadowRoot.h:
+* dom/Text.h:
+* html/HTMLPlugInImageElement.cpp:
+(WebCore::HTMLPlugInImageElement::createElementRenderer):
+(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
+(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
+
+Delete the render tree synchronously on suspend and rebuild it asynchronously on resume.
+No need for m_customStyleForPageCache hack.
+
+* html/HTMLPlugInImageElement.h:
+
+Remove m_customStyleForPageCache.
+
+* style/StyleResolveTree.cpp:
+* style/StyleResolveTree.h:
+
+Remove Element version of resolveTree from the interface.
+
+* svg/SVGUseElement.h:
+
+2014-01-02 Antti Koivisto an...@apple.com
+
Remove PlaceholderDocument
https://bugs.webkit.org/show_bug.cgi?id=126382
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (161207 => 161208)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2014-01-02 15:50:28 UTC (rev 161207)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2014-01-02 15:51:59 UTC (rev 161208)
@@ -140,8 +140,8 @@
if (value != m_resetStyleInheritance) {
m_resetStyleInheritance = value;
-if (renderer() hostElement())
-Style::resolveTree(*hostElement(), Style::Force);
+if (hostElement())
+setNeedsStyleRecalc();
}
}
Modified: trunk/Source/WebCore/dom/ShadowRoot.h (161207 => 161208)
--- trunk/Source/WebCore/dom/ShadowRoot.h 2014-01-02 15:50:28 UTC (rev 161207)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2014-01-02 15:51:59 UTC (rev 161208)
@@ -33,7 +33,6 @@
#include DocumentFragment.h
#include Element.h
#include ExceptionCode.h
-#include StyleResolveTree.h
#include TreeScope.h
namespace WebCore {
Modified: trunk/Source/WebCore/dom/Text.h (161207 => 161208)
--- trunk/Source/WebCore/dom/Text.h 2014-01-02 15:50:28 UTC (rev 161207)
+++ trunk/Source/WebCore/dom/Text.h 2014-01-02 15:51:59 UTC (rev 161208)
@@ -25,7 +25,6 @@
#include CharacterData.h
#include RenderPtr.h
-#include StyleResolveTree.h
namespace WebCore {
Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (161207 => 161208)
--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-01-02 15:50:28 UTC (rev 161207)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-01-02 15:51:59 UTC (rev 161208)
@@ -198,6 +198,8 @@
RenderPtrRenderElement HTMLPlugInImageElement::createElementRenderer(PassRefRenderStyle style)
{
+ASSERT(!document().inPageCache());
+
if (displayState() = PreparingPluginReplacement)
return HTMLPlugInElement::createElementRenderer(std::move(style));
@@ -309,32
[webkit-changes] [161209] trunk
Title: [161209] trunk Revision 161209 Author k...@webkit.org Date 2014-01-02 10:11:51 -0800 (Thu, 02 Jan 2014) Log Message Support box values computed style for 'clip-path' property https://bugs.webkit.org/show_bug.cgi?id=126148 Reviewed by Simon Fraser. Source/WebCore: Calculate computed style for 'clip-path' property. Updated tests to check for computed style. * css/BasicShapeFunctions.cpp: Add box value bounding-box. (WebCore::valueForBox): (WebCore::boxForValue): * css/CSSComputedStyleDeclaration.cpp: Return the computed style for 'clip-path'. (WebCore::ComputedStyleExtractor::propertyValue): * css/DeprecatedStyleBuilder.cpp: Create CSSValueLists for 'clip-th'. (WebCore::ApplyPropertyClipPath::applyValue): * rendering/ClipPathOperation.h: Add bounding-box value. (WebCore::ShapeClipPathOperation::pathForReferenceRect): (WebCore::ShapeClipPathOperation::setReferenceBox): (WebCore::ShapeClipPathOperation::referenceBox): (WebCore::BoxClipPathOperation::create): (WebCore::BoxClipPathOperation::pathForReferenceRect): (WebCore::BoxClipPathOperation::referenceBox): (WebCore::BoxClipPathOperation::BoxClipPathOperation): * rendering/shapes/ShapeInfo.h: Add bounding-box value. (WebCore::ShapeInfo::setShapeSize): (WebCore::ShapeInfo::logicalTopOffset): (WebCore::ShapeInfo::logicalLeftOffset): * rendering/style/BasicShapes.cpp: Add bounding-box value. (WebCore::BasicShape::referenceBoxSize): * rendering/style/BasicShapes.h: LayoutTests: Test computed style of 'clip-path' property. * fast/masking/parsing-clip-path-shape.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt trunk/LayoutTests/fast/masking/parsing-clip-path-shape.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/BasicShapeFunctions.cpp trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/rendering/ClipPathOperation.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/shapes/ShapeInfo.h trunk/Source/WebCore/rendering/style/BasicShapes.cpp trunk/Source/WebCore/rendering/style/BasicShapes.h trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp Diff Modified: trunk/LayoutTests/ChangeLog (161208 => 161209) --- trunk/LayoutTests/ChangeLog 2014-01-02 15:51:59 UTC (rev 161208) +++ trunk/LayoutTests/ChangeLog 2014-01-02 18:11:51 UTC (rev 161209) @@ -1,3 +1,14 @@ +2014-01-02 Dirk Schulze k...@webkit.org + +Support box values computed style for 'clip-path' property +https://bugs.webkit.org/show_bug.cgi?id=126148 + +Reviewed by Simon Fraser. + +Test computed style of 'clip-path' property. + +* fast/masking/parsing-clip-path-shape.html: + 2014-01-01 Antti Koivisto an...@apple.com Do less synchronous render tree construction Modified: trunk/LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt (161208 => 161209) --- trunk/LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt 2014-01-02 15:51:59 UTC (rev 161208) +++ trunk/LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt 2014-01-02 18:11:51 UTC (rev 161209) @@ -58,6 +58,16 @@ PASS innerStyle(-webkit-clip-path, margin-box circle(50% at 50% 50%)) is margin-box circle(50% at 50% 50%) PASS innerStyle(-webkit-clip-path, border-box circle(50% at 50% 50%)) is border-box circle(50% at 50% 50%) PASS innerStyle(-webkit-clip-path, circle(50% at 50% 50%) bounding-box) is circle(50% at 50% 50%) bounding-box +PASS computedStyle(-webkit-clip-path, content-box) is content-box +PASS computedStyle(-webkit-clip-path, padding-box) is padding-box +PASS computedStyle(-webkit-clip-path, border-box) is border-box +PASS computedStyle(-webkit-clip-path, margin-box) is margin-box +PASS computedStyle(-webkit-clip-path, bounding-box) is bounding-box +PASS computedStyle(-webkit-clip-path, circle(50% at 50% 50%) content-box) is circle(50% at 50% 50%) content-box +PASS computedStyle(-webkit-clip-path, circle(50% at 50% 50%) padding-box) is circle(50% at 50% 50%) padding-box +PASS computedStyle(-webkit-clip-path, margin-box circle(50% at 50% 50%)) is circle(50% at 50% 50%) margin-box +PASS computedStyle(-webkit-clip-path, border-box circle(50% at 50% 50%)) is circle(50% at 50% 50%) border-box +PASS computedStyle(-webkit-clip-path, circle(50% at 50% 50%) bounding-box) is circle(50% at 50% 50%) bounding-box PASS innerStyle(-webkit-clip-path, circle(1px, 1px, 1)) is null PASS computedStyle(-webkit-clip-path, circle(1px, 1px, 1)) is none PASS innerStyle(-webkit-clip-path, circle(1px, 1px, px)) is null Modified: trunk/LayoutTests/fast/masking/parsing-clip-path-shape.html (161208 => 161209) --- trunk/LayoutTests/fast/masking/parsing-clip-path-shape.html 2014-01-02 15:51:59 UTC (rev 161208) +++ trunk/LayoutTests/fast/masking/parsing-clip-path-shape.html 2014-01-02 18:11:51 UTC (rev 161209) @@
[webkit-changes] [161210] trunk/Source/WebCore
Title: [161210] trunk/Source/WebCore
Revision 161210
Author akl...@apple.com
Date 2014-01-02 10:45:33 -0800 (Thu, 02 Jan 2014)
Log Message
Simplify the insides of DocumentSharedObjectPool and reduce memory usage.
Merging Blink r164152 by Elliott Sprehn.
Instead of storing an OwnPtr to an object that has a pointer to the
ShareableElementData as well as a pointer into the ShareableElementData
and the length we can just store a RefPtr to the SharableElementData.
This also reduces the memory usage of the pool by 2 pointers per entry.
* dom/DocumentSharedObjectPool.h:
* dom/DocumentSharedObjectPool.cpp:
(WebCore::attributeHash):
(WebCore::hasSameAttributes):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DocumentSharedObjectPool.cpp
trunk/Source/WebCore/dom/DocumentSharedObjectPool.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (161209 => 161210)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 18:11:51 UTC (rev 161209)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 18:45:33 UTC (rev 161210)
@@ -1,3 +1,21 @@
+2014-01-02 Andreas Kling akl...@apple.com
+
+Simplify the insides of DocumentSharedObjectPool and reduce memory usage.
+
+Merging Blink r164152 by Elliott Sprehn.
+
+Instead of storing an OwnPtr to an object that has a pointer to the
+ShareableElementData as well as a pointer into the ShareableElementData
+and the length we can just store a RefPtr to the SharableElementData.
+
+This also reduces the memory usage of the pool by 2 pointers per entry.
+
+* dom/DocumentSharedObjectPool.h:
+* dom/DocumentSharedObjectPool.cpp:
+(WebCore::attributeHash):
+(WebCore::hasSameAttributes):
+(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
+
2014-01-02 Dirk Schulze k...@webkit.org
Support box values computed style for 'clip-path' property
Modified: trunk/Source/WebCore/dom/DocumentSharedObjectPool.cpp (161209 => 161210)
--- trunk/Source/WebCore/dom/DocumentSharedObjectPool.cpp 2014-01-02 18:11:51 UTC (rev 161209)
+++ trunk/Source/WebCore/dom/DocumentSharedObjectPool.cpp 2014-01-02 18:45:33 UTC (rev 161210)
@@ -31,64 +31,32 @@
namespace WebCore {
-class ShareableElementDataCacheKey {
-public:
-ShareableElementDataCacheKey(const Attribute* attributes, unsigned attributeCount)
-: m_attributes(attributes)
-, m_attributeCount(attributeCount)
-{ }
+inline unsigned attributeHash(const VectorAttribute attributes)
+{
+return StringHasher::hashMemory(attributes.data(), attributes.size() * sizeof(Attribute));
+}
-bool operator!=(const ShareableElementDataCacheKey other) const
-{
-if (m_attributeCount != other.m_attributeCount)
-return true;
-return memcmp(m_attributes, other.m_attributes, sizeof(Attribute) * m_attributeCount);
-}
+inline bool hasSameAttributes(const VectorAttribute attributes, ShareableElementData elementData)
+{
+if (attributes.size() != elementData.length())
+return false;
+return !memcmp(attributes.data(), elementData.m_attributeArray, attributes.size() * sizeof(Attribute));
+}
-unsigned hash() const
-{
-return StringHasher::hashMemory(m_attributes, m_attributeCount * sizeof(Attribute));
-}
-
-private:
-const Attribute* m_attributes;
-unsigned m_attributeCount;
-};
-
-class ShareableElementDataCacheEntry {
-public:
-ShareableElementDataCacheEntry(const ShareableElementDataCacheKey k, ShareableElementData v)
-: key(k)
-, value(v)
-{ }
-
-ShareableElementDataCacheKey key;
-RefShareableElementData value;
-};
-
PassRefShareableElementData DocumentSharedObjectPool::cachedShareableElementDataWithAttributes(const VectorAttribute attributes)
{
ASSERT(!attributes.isEmpty());
-ShareableElementDataCacheKey cacheKey(attributes.data(), attributes.size());
-unsigned cacheHash = cacheKey.hash();
+auto cachedData = m_shareableElementDataCache.add(attributeHash(attributes), nullptr).iterator-value;
-ShareableElementDataCache::iterator cacheIterator = m_shareableElementDataCache.add(cacheHash, nullptr).iterator;
-if (cacheIterator-value cacheIterator-value-key != cacheKey)
-cacheHash = 0;
+// FIXME: This prevents sharing when there's a hash collision.
+if (cachedData !hasSameAttributes(attributes, *cachedData))
+return ShareableElementData::createWithAttributes(attributes);
-RefPtrShareableElementData elementData;
-if (cacheHash cacheIterator-value)
-elementData = cacheIterator-value-value.get();
-else
-elementData = ShareableElementData::createWithAttributes(attributes);
+if (!cachedData)
+cachedData = ShareableElementData::createWithAttributes(attributes);
-if (!cacheHash || cacheIterator-value)
-return
[webkit-changes] [161211] branches/jsCStack/Source/JavaScriptCore
Title: [161211] branches/jsCStack/Source/_javascript_Core Revision 161211 Author fpi...@apple.com Date 2014-01-02 11:20:52 -0800 (Thu, 02 Jan 2014) Log Message Refactor LLInt C stack frame munging helpers so that 32-bit code paths can use them https://bugs.webkit.org/show_bug.cgi?id=126387 Not yet reviewed. This gets us closer to the 32-bit LLInt working on the C stack by enabling the 32-bit code paths to use the low-level stack/frame pointer munging helpers. This patch doesn't completely ensure that these helpers actually work - the 32-bit build is still broken - but it's a good change to land separately since it affects 64-bit code paths as well. * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter64.asm Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161210 => 161211) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 18:45:33 UTC (rev 161210) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 19:20:52 UTC (rev 161211) @@ -1,3 +1,20 @@ +2014-01-02 Filip Pizlo fpi...@apple.com + +Refactor LLInt C stack frame munging helpers so that 32-bit code paths can use them +https://bugs.webkit.org/show_bug.cgi?id=126387 + +Not yet reviewed. + +This gets us closer to the 32-bit LLInt working on the C stack by enabling the +32-bit code paths to use the low-level stack/frame pointer munging helpers. This +patch doesn't completely ensure that these helpers actually work - the 32-bit +build is still broken - but it's a good change to land separately since it affects +64-bit code paths as well. + +* llint/LowLevelInterpreter.asm: +* llint/LowLevelInterpreter32_64.asm: +* llint/LowLevelInterpreter64.asm: + 2013-12-31 Mark Lam mark@apple.com CStack: Need a separate stack limit for the JS stack and the C stack. Modified: branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm (161210 => 161211) --- branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-02 18:45:33 UTC (rev 161210) +++ branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-02 19:20:52 UTC (rev 161211) @@ -216,6 +216,14 @@ end end +macro checkStackPointerAlignment(tempReg, location) +andp sp, 0xf, tempReg +btpz tempReg, .stackPointerOkay +move location, tempReg +break +.stackPointerOkay: +end + macro preserveCallerPCAndCFR() if C_LOOP or ARM or ARMv7 or ARMv7_TRADITIONAL or ARM64 or MIPS or SH4 # In C_LOOP case, we're only preserving the bytecode vPC. @@ -229,7 +237,6 @@ end end - macro restoreCallerPCAndCFR() if C_LOOP or ARM or ARMv7 or ARMv7_TRADITIONAL or ARM64 or MIPS or SH4 # In C_LOOP case, we're only preserving the bytecode vPC. @@ -241,7 +248,6 @@ end end - macro preserveReturnAddressAfterCall(destinationRegister) if C_LOOP or ARM or ARMv7 or ARMv7_TRADITIONAL or ARM64 or MIPS or SH4 # In C_LOOP case, we're only preserving the bytecode vPC. @@ -264,6 +270,54 @@ end end +macro functionPrologue() +if X86 or X86_64 +push cfr +move sp, cfr +elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +pushLRAndFP +end +end + +macro functionEpilogue() +if X86 or X86_64 +pop cfr +elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +popLRAndFP +end +end + +macro callToJavaScriptPrologue() +if X86 or X86_64 +elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +pushLRAndFP +end +pushCalleeSaves +end + +macro callToJavaScriptEpilogue() +addp CallFrameHeaderSlots * 8, cfr, sp +loadp CallerFrame[cfr], cfr + +popCalleeSaves +if X86 or X86_64 +elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +popLRAndFP +end +end + +macro moveStackPointerForCodeBlock(codeBlock, scratch) +loadi CodeBlock::m_numCalleeRegisters[codeBlock], t2 +lshiftp 3, t2 +addp maxFrameExtentForSlowPathCall, t2 +subp cfr, t2, sp +end + +macro restoreStackPointerAfterCall() +loadp CodeBlock[cfr], t1 +moveStackPointerForCodeBlock(t1, t2) +end + macro traceExecution() if EXECUTION_TRACING callSlowPath(_llint_trace) @@ -375,9 +429,7 @@ end codeBlockSetter(t1) -loadi CodeBlock::m_numCalleeRegisters[t1], t2 -lshiftp 3, t2 -subp t2, sp +moveStackPointerForCodeBlock(t1, t2) # Set up the PC. if JSVALUE64 Modified: branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (161210 => 161211)
[webkit-changes] [161213] trunk/Tools
Title: [161213] trunk/Tools Revision 161213 Author a...@apple.com Date 2014-01-02 11:42:11 -0800 (Thu, 02 Jan 2014) Log Message https://bugs.webkit.org/show_bug.cgi?id=126391 Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials Rubber-stamped by Dan Bernstein. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: (loadXML): Quick and dirty fix, with a FIXME. Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js (161212 => 161213) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js 2014-01-02 19:41:45 UTC (rev 161212) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js 2014-01-02 19:42:11 UTC (rev 161213) @@ -67,6 +67,9 @@ }; request.open(GET, url); +// FIXME: It's not nice that one of the loading helpers here enables credentials, and +// others don't. Credentials are needed for some trac installations. +request.withCredentials = true; request.send(); }; Modified: trunk/Tools/ChangeLog (161212 => 161213) --- trunk/Tools/ChangeLog 2014-01-02 19:41:45 UTC (rev 161212) +++ trunk/Tools/ChangeLog 2014-01-02 19:42:11 UTC (rev 161213) @@ -1,3 +1,13 @@ +2014-01-02 Alexey Proskuryakov a...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=126391 +Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials + +Rubber-stamped by Dan Bernstein. + +* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: +(loadXML): Quick and dirty fix, with a FIXME. + 2014-01-01 Martin Robinson mrobin...@igalia.com [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161214] trunk/Tools
Title: [161214] trunk/Tools
Revision 161214
Author mrobin...@webkit.org
Date 2014-01-02 11:45:58 -0800 (Thu, 02 Jan 2014)
Log Message
[GTK] [CMake] run-gtk-tests should run with the cmake build
https://bugs.webkit.org/show_bug.cgi?id=126341
Reviewed by Carlos Garcia Campos.
* Scripts/run-gtk-tests:
(TestRunner.__init__): Use the new calling conventions for the common script.
(TestRunner._setup_testing_environment): Ditto.
* gtk/common.py:
(set_build_types): Added set_build_types, to avoid having build_type arguments
for all functions in common.
(binary_build_path): Added this function which gets the path to the built binaries.
(get_build_path): Removed the build_types argument.
(build_path): Removed the build_types argument and call get_build_path directly now.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
trunk/Tools/gtk/common.py
Diff
Modified: trunk/Tools/ChangeLog (161213 => 161214)
--- trunk/Tools/ChangeLog 2014-01-02 19:42:11 UTC (rev 161213)
+++ trunk/Tools/ChangeLog 2014-01-02 19:45:58 UTC (rev 161214)
@@ -1,3 +1,20 @@
+2014-01-02 Martin Robinson mrobin...@igalia.com
+
+[GTK] [CMake] run-gtk-tests should run with the cmake build
+https://bugs.webkit.org/show_bug.cgi?id=126341
+
+Reviewed by Carlos Garcia Campos.
+
+* Scripts/run-gtk-tests:
+(TestRunner.__init__): Use the new calling conventions for the common script.
+(TestRunner._setup_testing_environment): Ditto.
+* gtk/common.py:
+(set_build_types): Added set_build_types, to avoid having build_type arguments
+for all functions in common.
+(binary_build_path): Added this function which gets the path to the built binaries.
+(get_build_path): Removed the build_types argument.
+(build_path): Removed the build_types argument and call get_build_path directly now.
+
2014-01-02 Alexey Proskuryakov a...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=126391
Modified: trunk/Tools/Scripts/run-gtk-tests (161213 => 161214)
--- trunk/Tools/Scripts/run-gtk-tests 2014-01-02 19:42:11 UTC (rev 161213)
+++ trunk/Tools/Scripts/run-gtk-tests 2014-01-02 19:45:58 UTC (rev 161214)
@@ -91,9 +91,11 @@
def __init__(self, options, tests=[]):
self._options = options
+
self._build_type = Debug if self._options.debug else Release
+common.set_build_types((self._build_type,))
-self._programs_path = common.build_path_for_build_types((self._build_type,), Programs)
+self._programs_path = common.binary_build_path()
self._tests = self._get_tests(tests)
self._skipped_tests = TestRunner.SKIPPED
self._disabled_tests = []
@@ -194,7 +196,7 @@
self._test_env = os.environ
self._test_env['GSETTINGS_BACKEND'] = 'memory'
self._test_env[TEST_WEBKIT_API_WEBKIT2_RESOURCES_PATH] = common.top_level_path(Tools, TestWebKitAPI, Tests, WebKit2)
-self._test_env[TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH] = common.build_path_for_build_types((self._build_type,), Libraries)
+self._test_env[TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH] = common.library_build_path()
self._test_env[WEBKIT_EXEC_PATH] = self._programs_path
if not self._run_xvfb():
Modified: trunk/Tools/gtk/common.py (161213 => 161214)
--- trunk/Tools/gtk/common.py 2014-01-02 19:42:11 UTC (rev 161213)
+++ trunk/Tools/gtk/common.py 2014-01-02 19:45:58 UTC (rev 161214)
@@ -25,8 +25,14 @@
build_dir = None
library_build_dir = None
is_cmake = None
+build_types = ('Release', 'Debug')
+def set_build_types(new_build_types):
+global build_types
+build_types = new_build_types
+
+
def is_cmake_build():
global is_cmake
if is_cmake is None:
@@ -44,6 +50,16 @@
return library_build_dir
+def binary_build_path(*args):
+global library_build_dir
+if not library_build_dir:
+if is_cmake_build():
+library_build_dir = build_path('bin', *args)
+else:
+library_build_dir = build_path('Programs', *args)
+return library_build_dir
+
+
def script_path(*args):
global script_dir
if not script_dir:
@@ -55,7 +71,7 @@
return os.path.join(*((os.path.join(os.path.dirname(__file__), '..', '..'),) + args))
-def get_build_path(build_types=('Release', 'Debug'), fatal=True):
+def get_build_path(fatal=True):
global build_dir
if build_dir:
return build_dir
@@ -80,6 +96,7 @@
if is_valid_build_directory(build_dir):
return build_dir
+global build_types
for build_type in build_types:
build_dir = top_level_path('WebKitBuild', build_type)
if is_valid_build_directory(build_dir):
@@ -103,12 +120,8 @@
sys.exit(1)
-def build_path_for_build_types(build_types, *args):
-return os.path.join(*(get_build_path(build_types),) + args)
-
-
def build_path(*args):
-return build_path_for_build_types(('Release',
[webkit-changes] [161215] trunk/Tools
Title: [161215] trunk/Tools
Revision 161215
Author commit-qu...@webkit.org
Date 2014-01-02 12:03:36 -0800 (Thu, 02 Jan 2014)
Log Message
Unreviewed, rolling out r160846.
http://trac.webkit.org/changeset/160846
https://bugs.webkit.org/show_bug.cgi?id=126395
Breaks build scripts for Windows when Visual Studio is not
installed in Program Files (Requested by rfong on #webkit).
* Scripts/webkitdirs.pm:
(visualStudioInstallDir):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (161214 => 161215)
--- trunk/Tools/ChangeLog 2014-01-02 19:45:58 UTC (rev 161214)
+++ trunk/Tools/ChangeLog 2014-01-02 20:03:36 UTC (rev 161215)
@@ -1,3 +1,15 @@
+2014-01-02 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r160846.
+http://trac.webkit.org/changeset/160846
+https://bugs.webkit.org/show_bug.cgi?id=126395
+
+Breaks build scripts for Windows when Visual Studio is not
+installed in Program Files (Requested by rfong on #webkit).
+
+* Scripts/webkitdirs.pm:
+(visualStudioInstallDir):
+
2014-01-02 Martin Robinson mrobin...@igalia.com
[GTK] [CMake] run-gtk-tests should run with the cmake build
Modified: trunk/Tools/Scripts/webkitdirs.pm (161214 => 161215)
--- trunk/Tools/Scripts/webkitdirs.pm 2014-01-02 19:45:58 UTC (rev 161214)
+++ trunk/Tools/Scripts/webkitdirs.pm 2014-01-02 20:03:36 UTC (rev 161215)
@@ -432,8 +432,12 @@
{
return $vsInstallDir if defined $vsInstallDir;
-$vsInstallDir = File::Spec-catdir(programFilesPath(), Microsoft Visual Studio 12.0);
-
+if ($ENV{'VSINSTALLDIR'}) {
+$vsInstallDir = $ENV{'VSINSTALLDIR'};
+$vsInstallDir =~ s|[\\/]$||;
+} else {
+$vsInstallDir = File::Spec-catdir(programFilesPath(), Microsoft Visual Studio 12.0);
+}
chomp($vsInstallDir = `cygpath $vsInstallDir`) if isCygwin();
return $vsInstallDir;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161216] trunk/Tools
Title: [161216] trunk/Tools
Revision 161216
Author a...@apple.com
Date 2014-01-02 12:06:32 -0800 (Thu, 02 Jan 2014)
Log Message
Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
https://bugs.webkit.org/show_bug.cgi?id=126391
Reviewed by Dan Bernstein.
Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
One can request credentials use via Initialization.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac):
(Trac.prototype.update):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
(loadXML):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js (161215 => 161216)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2014-01-02 20:03:36 UTC (rev 161215)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2014-01-02 20:06:32 UTC (rev 161216)
@@ -23,13 +23,15 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-Trac = function(baseURL)
+Trac = function(baseURL, options)
{
BaseObject.call(this);
console.assert(baseURL);
this.baseURL = baseURL;
+this._needsAuthentication = (typeof options === object) options[Trac.NeedsAuthentication] === true;
+
this.recordedCommits = []; // Will be sorted in ascending order.
this.update();
@@ -38,6 +40,7 @@
BaseObject.addConstructorFunctions(Trac);
+Trac.NeedsAuthentication = needsAuthentication;
Trac.UpdateInterval = 45000; // 45 seconds
Trac.Event = {
@@ -130,6 +133,6 @@
this.recordedCommits = this.recordedCommits.concat(newCommits.reverse());
this.dispatchEventToListeners(Trac.Event.NewCommitsRecorded, {newCommits: newCommits});
-}.bind(this));
+}.bind(this), this._needsAuthentication ? { withCredentials: true } : {});
}
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js (161215 => 161216)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js 2014-01-02 20:03:36 UTC (rev 161215)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js 2014-01-02 20:06:32 UTC (rev 161216)
@@ -50,7 +50,7 @@
request.send();
};
-function loadXML(url, callback) {
+function loadXML(url, callback, options) {
console.assert(url);
if (!(callback instanceof Function))
@@ -67,9 +67,8 @@
};
request.open(GET, url);
-// FIXME: It's not nice that one of the loading helpers here enables credentials, and
-// others don't. Credentials are needed for some trac installations.
-request.withCredentials = true;
+if ((typeof options === object) options.hasOwnProperty(withCredentials))
+request.withCredentials = options.withCredentials;
request.send();
};
Modified: trunk/Tools/ChangeLog (161215 => 161216)
--- trunk/Tools/ChangeLog 2014-01-02 20:03:36 UTC (rev 161215)
+++ trunk/Tools/ChangeLog 2014-01-02 20:06:32 UTC (rev 161216)
@@ -1,3 +1,19 @@
+2014-01-02 Alexey Proskuryakov a...@apple.com
+
+Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
+https://bugs.webkit.org/show_bug.cgi?id=126391
+
+Reviewed by Dan Bernstein.
+
+Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
+One can request credentials use via Initialization.js.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
+(Trac):
+(Trac.prototype.update):
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
+(loadXML):
+
2014-01-02 Commit Queue commit-qu...@webkit.org
Unreviewed, rolling out r160846.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161217] branches/jsCStack/Source/JavaScriptCore
Title: [161217] branches/jsCStack/Source/_javascript_Core
Revision 161217
Author fpi...@apple.com
Date 2014-01-02 12:11:55 -0800 (Thu, 02 Jan 2014)
Log Message
Some crashes in C stack on Mountain Lion, for example on crypto-aes, due to misaligned stack
https://bugs.webkit.org/show_bug.cgi?id=126394
Not yet reviewed.
The specialized math thunks currently ensure that inside the thunk, the stack is aligned. But when they
call the wrapper, the wrapper previously didn't align the stack. This patch fixes that.
I think that we can drop the wrappers on X86-64 and maybe on other platforms as well. I'll leave that to
a future patch.
* jit/ThunkGenerators.cpp:
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161216 => 161217)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 20:06:32 UTC (rev 161216)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 20:11:55 UTC (rev 161217)
@@ -1,5 +1,20 @@
2014-01-02 Filip Pizlo fpi...@apple.com
+Some crashes in C stack on Mountain Lion, for example on crypto-aes, due to misaligned stack
+https://bugs.webkit.org/show_bug.cgi?id=126394
+
+Not yet reviewed.
+
+The specialized math thunks currently ensure that inside the thunk, the stack is aligned. But when they
+call the wrapper, the wrapper previously didn't align the stack. This patch fixes that.
+
+I think that we can drop the wrappers on X86-64 and maybe on other platforms as well. I'll leave that to
+a future patch.
+
+* jit/ThunkGenerators.cpp:
+
+2014-01-02 Filip Pizlo fpi...@apple.com
+
Refactor LLInt C stack frame munging helpers so that 32-bit code paths can use them
https://bugs.webkit.org/show_bug.cgi?id=126387
Modified: branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp (161216 => 161217)
--- branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp 2014-01-02 20:06:32 UTC (rev 161216)
+++ branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp 2014-01-02 20:11:55 UTC (rev 161217)
@@ -625,7 +625,9 @@
.globl SYMBOL_STRING(function##Thunk) \n \
HIDE_SYMBOL(function##Thunk) \n \
SYMBOL_STRING(function##Thunk) : \n \
+pushq %rax\n \
call GLOBAL_REFERENCE(function) \n \
+popq %rcx\n \
ret\n \
);\
extern C { \
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161218] trunk/Source/JavaScriptCore
Title: [161218] trunk/Source/_javascript_Core
Revision 161218
Author fpi...@apple.com
Date 2014-01-02 12:15:25 -0800 (Thu, 02 Jan 2014)
Log Message
Rationalize DFG DCE
https://bugs.webkit.org/show_bug.cgi?id=125523
Reviewed by Mark Hahnenberg.
Adds the ability to DCE more things. It's now the case that if a node is completely
pure, we clear NodeMustGenerate and the node becomes a DCE candidate.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreterAbstractStateType::executeEffects):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::cleanVariables):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::clobbersWorld):
* dfg/DFGNodeType.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileValueAdd):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGDCEPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (161217 => 161218)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-02 20:11:55 UTC (rev 161217)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-02 20:15:25 UTC (rev 161218)
@@ -1,3 +1,37 @@
+2014-01-01 Filip Pizlo fpi...@apple.com
+
+Rationalize DFG DCE
+https://bugs.webkit.org/show_bug.cgi?id=125523
+
+Reviewed by Mark Hahnenberg.
+
+Adds the ability to DCE more things. It's now the case that if a node is completely
+pure, we clear NodeMustGenerate and the node becomes a DCE candidate.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreterAbstractStateType::executeEffects):
+* dfg/DFGCSEPhase.cpp:
+(JSC::DFG::CSEPhase::performNodeCSE):
+* dfg/DFGClobberize.h:
+(JSC::DFG::clobberize):
+* dfg/DFGDCEPhase.cpp:
+(JSC::DFG::DCEPhase::cleanVariables):
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+* dfg/DFGGraph.h:
+(JSC::DFG::Graph::clobbersWorld):
+* dfg/DFGNodeType.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileAdd):
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileNode):
+(JSC::FTL::LowerDFGToLLVM::compileValueAdd):
+
2014-01-02 Benjamin Poulain benja...@webkit.org
Attempt to fix the build of WebCore's code generator on CMake based system
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (161217 => 161218)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2014-01-02 20:11:55 UTC (rev 161217)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2014-01-02 20:15:25 UTC (rev 161218)
@@ -340,7 +340,19 @@
break;
}
-case ValueAdd:
+case ValueAdd: {
+JSValue left = forNode(node-child1()).value();
+JSValue right = forNode(node-child2()).value();
+if (left right left.isNumber() right.isNumber()) {
+setConstant(node, JSValue(left.asNumber() + right.asNumber()));
+break;
+}
+ASSERT(node-binaryUseKind() == UntypedUse);
+clobberWorld(node-codeOrigin, clobberLimit);
+forNode(node).setType(SpecString | SpecBytecodeNumber);
+break;
+}
+
case ArithAdd: {
JSValue left = forNode(node-child1()).value();
JSValue right = forNode(node-child2()).value();
@@ -368,9 +380,7 @@
forNode(node).setType(SpecDouble);
break;
default:
-RELEASE_ASSERT(node-op() == ValueAdd);
-clobberWorld(node-codeOrigin, clobberLimit);
-forNode(node).setType(SpecString | SpecBytecodeNumber);
+RELEASE_ASSERT_NOT_REACHED();
break;
}
[webkit-changes] [161219] branches/jsCStack/Source/JavaScriptCore
Title: [161219] branches/jsCStack/Source/_javascript_Core Revision 161219 Author mark@apple.com Date 2014-01-02 12:42:13 -0800 (Thu, 02 Jan 2014) Log Message CStack: Get the C Loop LLINT to build again. https://bugs.webkit.org/show_bug.cgi?id=126393. Not yet reviewed. * jit/JITCode.cpp: (JSC::DirectJITCode::addressForCall): - #if ENABLE(JIT) out the use of RegisterPreservationWrappers. * llint/LLIntCLoop.cpp: (JSC::LLInt::CLoop::initialize): - Update CLoop::initialize() to call the new CLoop::execute(). * llint/LLIntCLoop.h: - CLoop::execute() now takes the arguments for callToJavaScript, and it effectively acts as the gateway for re-entering the VM in place for callToJavaScript (and callToNativeFunction). CLoop::execute() should set up the CPU execution environment i.e. CLoopRegisters should be initialized with the incoming args, stack pointer, base pointer, and return address. We'll take care of this part in a subsequent patch. * llint/LLIntOpcode.h: - Added C loop only llint opcodes llint_call_to_javascript, and llint_call_to_native_function. These will be used as the opcodeID for the llint interpreter blob for callToJavaScript and callToNativeFunction. Meanwhile, the LLINT thunk will provide C functions for callToJavaScript and callToNativeFunction which calls CLoop::execute() with the opcodeID for llint_call_to_javascript and llint_call_to_native_function respectively. * llint/LLIntSlowPaths.cpp: (JSC::LLInt::llint_throw_stack_overflow_error): - Changed llint_throw_stack_overflow_error()'s return type so that it is easier for the C Loop LLINT to generate boilerplate code to call it. The return value is not used by anyone. But since this is code that rarely executed, we'll opt to take this small hit of returning an unused value rather than having to spin some way to make the C Loop offlineasm smarter only for handling this one case. * llint/LLIntSlowPaths.h: * llint/LLIntThunks.cpp: (JSC::callToJavaScript): (JSC::callToNativeFunction): - Updated to call the new CLoop::execute(). We're going to try to use the doCallToJavaScript code defined in the LLINT assembly instead of spinning our own version in C++ as we did previously. * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter.cpp: (JSC::CLoopRegister::operator ExecState*): (JSC::CLoopRegister::operator Instruction*): (JSC::CLoopRegister::operator VM*): (JSC::CLoopRegister::operator ProtoCallFrame*): - Added these cast operators to the CLoopRegister to simplify the C Loop call slow path boilerplate. (JSC::CLoop::execute): * llint/LowLevelInterpreter64.asm: * offlineasm/cloop.rb: - Define C Loop registers to match ARM as expected by the code. - Replaced a #error with a RELEASE_ASSERT_NOT_REACHED(). - Reworked the call slow path boilerplate to take advantage of the CLoopRegister cast operators. We need this in order to be able to call slow path functions that take different argument types e.g. llint_throw_stack_overflow_error(). * runtime/CommonSlowPaths.cpp: (JSC::setupArityCheckData): * runtime/VM.cpp: (JSC::VM::getHostFunction): * runtime/VMEntryScope.cpp: (JSC::VMEntryScope::requiredCapacity): Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/jit/JITCode.cpp branches/jsCStack/Source/_javascript_Core/llint/LLIntCLoop.cpp branches/jsCStack/Source/_javascript_Core/llint/LLIntCLoop.h branches/jsCStack/Source/_javascript_Core/llint/LLIntOpcode.h branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.cpp branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.h branches/jsCStack/Source/_javascript_Core/llint/LLIntThunks.cpp branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.cpp branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter64.asm branches/jsCStack/Source/_javascript_Core/offlineasm/cloop.rb branches/jsCStack/Source/_javascript_Core/runtime/CommonSlowPaths.cpp branches/jsCStack/Source/_javascript_Core/runtime/VM.cpp branches/jsCStack/Source/_javascript_Core/runtime/VMEntryScope.cpp Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161218 => 161219) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 20:15:25 UTC (rev 161218) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 20:42:13 UTC (rev 161219) @@ -1,3 +1,83 @@ +2014-01-02 Mark Lam mark@apple.com + +CStack: Get the C Loop LLINT to build again. +https://bugs.webkit.org/show_bug.cgi?id=126393. + +Not yet reviewed. + +* jit/JITCode.cpp: +(JSC::DirectJITCode::addressForCall): +- #if ENABLE(JIT) out the use of RegisterPreservationWrappers. + +* llint/LLIntCLoop.cpp: +(JSC::LLInt::CLoop::initialize): +- Update CLoop::initialize() to call the new CLoop::execute(). + +* llint/LLIntCLoop.h: +-
[webkit-changes] [161221] trunk/Source/WebKit/gtk
Title: [161221] trunk/Source/WebKit/gtk Revision 161221 Author zandober...@gmail.com Date 2014-01-02 13:00:06 -0800 (Thu, 02 Jan 2014) Log Message [GTK] Fix mismatched header guards in private WK1 header files https://bugs.webkit.org/show_bug.cgi?id=126390 Reviewed by Martin Robinson. Fix three mismatched header guards that are producing warnings when building with Clang. * webkit/webkitsecurityoriginprivate.h: * webkit/webkitviewportattributesprivate.h: * webkit/webkitwebnavigationactionprivate.h: Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitsecurityoriginprivate.h trunk/Source/WebKit/gtk/webkit/webkitviewportattributesprivate.h trunk/Source/WebKit/gtk/webkit/webkitwebnavigationactionprivate.h Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (161220 => 161221) --- trunk/Source/WebKit/gtk/ChangeLog 2014-01-02 20:56:20 UTC (rev 161220) +++ trunk/Source/WebKit/gtk/ChangeLog 2014-01-02 21:00:06 UTC (rev 161221) @@ -1,3 +1,16 @@ +2014-01-02 Zan Dobersek zdober...@igalia.com + +[GTK] Fix mismatched header guards in private WK1 header files +https://bugs.webkit.org/show_bug.cgi?id=126390 + +Reviewed by Martin Robinson. + +Fix three mismatched header guards that are producing warnings when building with Clang. + +* webkit/webkitsecurityoriginprivate.h: +* webkit/webkitviewportattributesprivate.h: +* webkit/webkitwebnavigationactionprivate.h: + 2013-12-30 Martin Robinson mrobin...@igalia.com [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build Modified: trunk/Source/WebKit/gtk/webkit/webkitsecurityoriginprivate.h (161220 => 161221) --- trunk/Source/WebKit/gtk/webkit/webkitsecurityoriginprivate.h 2014-01-02 20:56:20 UTC (rev 161220) +++ trunk/Source/WebKit/gtk/webkit/webkitsecurityoriginprivate.h 2014-01-02 21:00:06 UTC (rev 161221) @@ -21,7 +21,7 @@ */ #ifndef webkitsecurityoriginprivate_h -#define webkitnavigationactionprivate_h +#define webkitsecurityoriginprivate_h #include SecurityOrigin.h #include webkitsecurityorigin.h Modified: trunk/Source/WebKit/gtk/webkit/webkitviewportattributesprivate.h (161220 => 161221) --- trunk/Source/WebKit/gtk/webkit/webkitviewportattributesprivate.h 2014-01-02 20:56:20 UTC (rev 161220) +++ trunk/Source/WebKit/gtk/webkit/webkitviewportattributesprivate.h 2014-01-02 21:00:06 UTC (rev 161221) @@ -21,7 +21,7 @@ */ #ifndef webkitviewportattributesprivate_h -#define webkitnavigationactionprivate_h +#define webkitviewportattributesprivate_h #include webkit/webkitviewportattributes.h Modified: trunk/Source/WebKit/gtk/webkit/webkitwebnavigationactionprivate.h (161220 => 161221) --- trunk/Source/WebKit/gtk/webkit/webkitwebnavigationactionprivate.h 2014-01-02 20:56:20 UTC (rev 161220) +++ trunk/Source/WebKit/gtk/webkit/webkitwebnavigationactionprivate.h 2014-01-02 21:00:06 UTC (rev 161221) @@ -21,7 +21,7 @@ */ #ifndef webkitwebnavigationactionprivate_h -#define webkitnavigationactionprivate_h +#define webkitwebnavigationactionprivate_h #include webkit/webkitwebnavigationaction.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161222] trunk/Source/WebCore
Title: [161222] trunk/Source/WebCore
Revision 161222
Author oli...@apple.com
Date 2014-01-02 13:34:51 -0800 (Thu, 02 Jan 2014)
Log Message
Update bindings test results
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161221 => 161222)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 21:00:06 UTC (rev 161221)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 21:34:51 UTC (rev 161222)
@@ -1,3 +1,40 @@
+2014-01-02 Oliver Hunt oli...@apple.com
+
+Update bindings test results
+
+* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
+(WebCore::jsTestActiveDOMObjectConstructor):
+* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
+(WebCore::jsTestCustomNamedGetterConstructor):
+* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+(WebCore::jsTestEventConstructorConstructor):
+* bindings/scripts/test/JS/JSTestEventTarget.cpp:
+(WebCore::jsTestEventTargetConstructor):
+* bindings/scripts/test/JS/JSTestException.cpp:
+(WebCore::jsTestExceptionConstructor):
+* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
+(WebCore::jsTestGenerateIsReachableConstructor):
+* bindings/scripts/test/JS/JSTestInterface.cpp:
+(WebCore::jsTestInterfaceConstructor):
+* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+(WebCore::jsTestMediaQueryListListenerConstructor):
+* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+(WebCore::jsTestNamedConstructorConstructor):
+* bindings/scripts/test/JS/JSTestNode.cpp:
+(WebCore::jsTestNodeConstructor):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::jsTestObjConstructor):
+* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+(WebCore::jsTestOverloadedConstructorsConstructor):
+* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
+* bindings/scripts/test/JS/JSTestTypedefs.cpp:
+(WebCore::jsTestTypedefsConstructor):
+* bindings/scripts/test/JS/JSattribute.cpp:
+(WebCore::jsattributeConstructor):
+* bindings/scripts/test/JS/JSreadonly.cpp:
+(WebCore::jsreadonlyConstructor):
+
2013-12-23 Oliver Hunt oli...@apple.com
Refactor PutPropertySlot to be aware of custom properties
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (161221 => 161222)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2014-01-02 21:00:06 UTC (rev 161221)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2014-01-02 21:34:51 UTC (rev 161222)
@@ -145,11 +145,13 @@
}
-EncodedJSValue jsTestActiveDOMObjectConstructor(ExecState* exec, EncodedJSValue slotBase, EncodedJSValue, PropertyName)
+EncodedJSValue jsTestActiveDOMObjectConstructor(ExecState* exec, EncodedJSValue thisValue, EncodedJSValue, PropertyName)
{
-JSTestActiveDOMObject* domObject = jsDynamicCastJSTestActiveDOMObject*(JSValue::decode(slotBase));
+JSTestActiveDOMObject* domObject = jsDynamicCastJSTestActiveDOMObject*(JSValue::decode(thisValue));
if (!domObject)
return throwVMTypeError(exec);
+if (!domObject)
+return throwVMTypeError(exec);
if (!BindingSecurity::shouldAllowAccessToDOMWindow(exec, domObject-impl()))
return JSValue::encode(jsUndefined());
return JSValue::encode(JSTestActiveDOMObject::getConstructor(exec-vm(), domObject-globalObject()));
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp (161221 => 161222)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2014-01-02 21:00:06 UTC (rev 161221)
+++
[webkit-changes] [161223] trunk/Source
Title: [161223] trunk/Source Revision 161223 Author barraclo...@apple.com Date 2014-01-02 14:06:14 -0800 (Thu, 02 Jan 2014) Log Message Merge didMoveOnscreen / page visibility to isVisible https://bugs.webkit.org/show_bug.cgi?id=126268 Reviewed by Tim Horton. The onscreen state most closely tracks view visibility (though currently also tracks a mix of in-window state). Make more consistent, simplify, and move all animation suspension logic to Page, so it can be controlled by the PageThrottler. Source/WebCore: * WebCore.exp.in: * page/EventHandler.cpp: (WebCore::EventHandler::fakeMouseMoveEventTimerFired): * page/FrameView.cpp: (WebCore::FrameView::shouldSetCursor): * page/Page.cpp: (WebCore::Page::Page): - initialize new variables. (WebCore::Page::setIsVisible): - merge setVisibilityState, didMoveOnscreen, willMoveOffscreen. (WebCore::Page::setIsPrerender): - switches visibility state from hidden to prerender. (WebCore::Page::visibilityState): - computed from m_isVisible, m_isPrerender. (WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): - m_visibilityState - m_isVisible. * page/Page.h: - remove didMoveOnscreen/willMoveOffscreen m_isOnscreen m_visibilityState - m_isVisible m_isPrerender setVisibilityState - setIsVisible setIsPrerender. (WebCore::Page::isVisible): - isOnscreen - isVisible. Source/WebKit/blackberry: * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState): - setVisibilityState - setIsVisible. Source/WebKit/efl: * ewk/ewk_view.cpp: (ewk_view_visibility_state_set): - setVisibilityState - setIsVisible/setIsPrerender. Source/WebKit/gtk: * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setPageVisibility): - setVisibilityState - setIsVisible/setIsPrerender. Source/WebKit/mac: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _updateVisibilityState]): - _setVisibilityState:isInitialState: - _setIsVisibile:isInitialState:. (-[WebView _setIsVisible:isInitialState:]): - added. (-[WebView _setVisibilityState:isInitialState:]): - setVisibilityState - setIsVisible/setIsPrerender. (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): - remove redundant calls to willMoveOffscreen/didMoveOnscreen (this is handled by _updateVisibilityState). Source/WebKit2: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::setViewIsVisible): - updateVisibilityState - setIsVisible. (WebKit::WebPage::setIsInWindow): - remove redundant willMoveOffscreen/didMoveOnscreen calls - this is handled by setIsVisible. (WebKit::WebPage::setMayStartMediaWhenInWindow): - isOnscreen - isInWindow. We start media when the view is in a window, not when the view is visible. (WebKit::WebPage::setVisibilityStatePrerender): - setVisibilityState - setIsPrerender. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebKit/blackberry/Api/WebPage.cpp trunk/Source/WebKit/blackberry/ChangeLog trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/ewk/ewk_view.cpp trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (161222 => 161223) --- trunk/Source/WebCore/ChangeLog 2014-01-02 21:34:51 UTC (rev 161222) +++ trunk/Source/WebCore/ChangeLog 2014-01-02 22:06:14 UTC (rev 161223) @@ -1,3 +1,38 @@ +2014-01-02 Gavin Barraclough barraclo...@apple.com + +Merge didMoveOnscreen / page visibility to isVisible +https://bugs.webkit.org/show_bug.cgi?id=126268 + +Reviewed by Tim Horton. + +The onscreen state most closely tracks view visibility (though currently +also tracks a mix of in-window state). Make more consistent, simplify, +and move all animation suspension logic to Page, so it can be controlled +by the PageThrottler. + +* WebCore.exp.in: +* page/EventHandler.cpp: +(WebCore::EventHandler::fakeMouseMoveEventTimerFired): +* page/FrameView.cpp: +(WebCore::FrameView::shouldSetCursor): +* page/Page.cpp: +(WebCore::Page::Page): +- initialize new variables. +(WebCore::Page::setIsVisible): +- merge setVisibilityState, didMoveOnscreen, willMoveOffscreen. +(WebCore::Page::setIsPrerender): +- switches visibility state from hidden to prerender. +(WebCore::Page::visibilityState): +- computed from m_isVisible,
[webkit-changes] [161224] trunk/Source/WebKit2
Title: [161224] trunk/Source/WebKit2 Revision 161224 Author a...@apple.com Date 2014-01-02 14:15:58 -0800 (Thu, 02 Jan 2014) Log Message Merge didMoveOnscreen / page visibility to isVisible https://bugs.webkit.org/show_bug.cgi?id=126268 Build fix. * UIProcess/WebContext.h: Removed some accidental input. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebContext.h Diff Modified: trunk/Source/WebKit2/ChangeLog (161223 => 161224) --- trunk/Source/WebKit2/ChangeLog 2014-01-02 22:06:14 UTC (rev 161223) +++ trunk/Source/WebKit2/ChangeLog 2014-01-02 22:15:58 UTC (rev 161224) @@ -1,3 +1,12 @@ +2014-01-02 Alexey Proskuryakov a...@apple.com + +Merge didMoveOnscreen / page visibility to isVisible +https://bugs.webkit.org/show_bug.cgi?id=126268 + +Build fix. + +* UIProcess/WebContext.h: Removed some accidental input. + 2014-01-02 Gavin Barraclough barraclo...@apple.com Merge didMoveOnscreen / page visibility to isVisible Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (161223 => 161224) --- trunk/Source/WebKit2/UIProcess/WebContext.h 2014-01-02 22:06:14 UTC (rev 161223) +++ trunk/Source/WebKit2/UIProcess/WebContext.h 2014-01-02 22:15:58 UTC (rev 161224) @@ -82,7 +82,7 @@ class WebNetworkInfoManagerProxy; #endif #if ENABLE(NETWORK_PROCESS) -struc t NetworkProcessCreationParameters; +struct NetworkProcessCreationParameters; #endif class WebContext : public API::ObjectImplAPI::Object::Type::Context, private IPC::MessageReceiver ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161225] branches/jsCStack/Source/JavaScriptCore
Title: [161225] branches/jsCStack/Source/_javascript_Core Revision 161225 Author fpi...@apple.com Date 2014-01-02 14:16:59 -0800 (Thu, 02 Jan 2014) Log Message Address review feedback in https://bugs.webkit.org/show_bug.cgi?id=126387#c3 * llint/LowLevelInterpreter.asm: Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161224 => 161225) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 22:15:58 UTC (rev 161224) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 22:16:59 UTC (rev 161225) @@ -1,3 +1,9 @@ +2014-01-02 Filip Pizlo fpi...@apple.com + +Address review feedback in https://bugs.webkit.org/show_bug.cgi?id=126387#c3 + +* llint/LowLevelInterpreter.asm: + 2014-01-02 Mark Lam mark@apple.com CStack: Get the C Loop LLINT to build again. @@ -83,7 +89,7 @@ Some crashes in C stack on Mountain Lion, for example on crypto-aes, due to misaligned stack https://bugs.webkit.org/show_bug.cgi?id=126394 -Not yet reviewed. +Reviewed by Michael Saboff. The specialized math thunks currently ensure that inside the thunk, the stack is aligned. But when they call the wrapper, the wrapper previously didn't align the stack. This patch fixes that. Modified: branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm (161224 => 161225) --- branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-02 22:15:58 UTC (rev 161224) +++ branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-02 22:16:59 UTC (rev 161225) @@ -274,23 +274,32 @@ if X86 or X86_64 push cfr move sp, cfr -elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +elsif ARM64 pushLRAndFP +elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +push cfr +push lr end end macro functionEpilogue() if X86 or X86_64 pop cfr -elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +elsif ARM64 popLRAndFP +elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +pop lr +pop cfr end end macro callToJavaScriptPrologue() if X86 or X86_64 -elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +elsif ARM64 pushLRAndFP +elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +push cfr +push lr end pushCalleeSaves end @@ -301,8 +310,11 @@ popCalleeSaves if X86 or X86_64 -elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +elsif ARM64 popLRAndFP +elsif ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS +pop lr +pop cfr end end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161226] trunk/Source/WebKit2
Title: [161226] trunk/Source/WebKit2
Revision 161226
Author barraclo...@apple.com
Date 2014-01-02 14:20:05 -0800 (Thu, 02 Jan 2014)
Log Message
Refactor ViewState handling for drawing area / plugins
https://bugs.webkit.org/show_bug.cgi?id=126272
Reviewed by Tim Horton.
Instead of all ViewState changes being handled by the WebPage, notify the DrawingArea PluginView to better encapsulate.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewStateDidChange):
(WebKit::PluginView::platformViewStateDidChange):
- added, handle changes in ViewState relevant to PluginView.
(WebKit::PluginView::didInitializePlugin):
- helper function removed.
* WebProcess/Plugins/PluginView.h:
- added/removed function declarations.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::viewStateDidChange):
- declare viewStateDidChange.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setActive):
- no need to notify plugin.
(WebKit::WebPage::setViewIsVisible):
- no need to notify drawing area.
(WebKit::WebPage::setViewState):
- send viewStateDidChange to drawing area / plugin.
(WebKit::WebPage::setWindowIsVisible):
- no need to notify plugin.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::layerHostingMode):
- removed setLayerHostingMode.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- declare viewStateDidChange.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):
- added, handle changes in ViewState relevant to DrawingArea.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (161225 => 161226)
--- trunk/Source/WebKit2/ChangeLog 2014-01-02 22:16:59 UTC (rev 161225)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-02 22:20:05 UTC (rev 161226)
@@ -1,3 +1,41 @@
+2014-01-02 Gavin Barraclough barraclo...@apple.com
+
+Refactor ViewState handling for drawing area / plugins
+https://bugs.webkit.org/show_bug.cgi?id=126272
+
+Reviewed by Tim Horton.
+
+Instead of all ViewState changes being handled by the WebPage, notify the DrawingArea PluginView to better encapsulate.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::viewStateDidChange):
+(WebKit::PluginView::platformViewStateDidChange):
+- added, handle changes in ViewState relevant to PluginView.
+(WebKit::PluginView::didInitializePlugin):
+- helper function removed.
+* WebProcess/Plugins/PluginView.h:
+- added/removed function declarations.
+* WebProcess/WebPage/DrawingArea.h:
+(WebKit::DrawingArea::viewStateDidChange):
+- declare viewStateDidChange.
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::setActive):
+- no need to notify plugin.
+(WebKit::WebPage::setViewIsVisible):
+- no need to notify drawing area.
+(WebKit::WebPage::setViewState):
+- send viewStateDidChange to drawing area / plugin.
+(WebKit::WebPage::setWindowIsVisible):
+- no need to notify plugin.
+* WebProcess/WebPage/WebPage.h:
+(WebKit::WebPage::layerHostingMode):
+- removed setLayerHostingMode.
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
+- declare viewStateDidChange.
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):
+- added, handle changes in ViewState relevant to DrawingArea.
+
2014-01-02 Alexey Proskuryakov a...@apple.com
Merge didMoveOnscreen / page visibility to isVisible
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (161225 => 161226)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-01-02 22:16:59 UTC (rev 161225)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-01-02 22:20:05 UTC (rev 161226)
@@ -481,21 +481,34 @@
m_webPage = 0;
}
-#if PLATFORM(MAC)
-void PluginView::setWindowIsVisible(bool windowIsVisible)
+void PluginView::viewStateDidChange(ViewState::Flags changed)
{
-if (!m_isInitialized || !m_plugin)
-return;
-
-m_plugin-windowVisibilityChanged(windowIsVisible);
+#if PLATFORM(MAC)
+platformViewStateDidChange(changed);
+#endif
}
-void PluginView::setWindowIsFocused(bool windowIsFocused)
+#if PLATFORM(MAC)
+void PluginView::platformViewStateDidChange(ViewState::Flags changed)
{
-if (!m_isInitialized
[webkit-changes] [161227] trunk/Source/WebCore
Title: [161227] trunk/Source/WebCore
Revision 161227
Author dba...@webkit.org
Date 2014-01-02 14:32:19 -0800 (Thu, 02 Jan 2014)
Log Message
[iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved()
(also crashes when scrolling certain sites)
https://bugs.webkit.org/show_bug.cgi?id=126401
rdar://problem/15739334
Reviewed by Tim Horton.
* page/ios/EventHandlerIOS.mm:
(WebCore::currentEventSlot): Make the shared variable have static-storage duration.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ios/EventHandlerIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (161226 => 161227)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 22:20:05 UTC (rev 161226)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 22:32:19 UTC (rev 161227)
@@ -1,3 +1,15 @@
+2014-01-02 Daniel Bates daba...@apple.com
+
+[iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved()
+(also crashes when scrolling certain sites)
+https://bugs.webkit.org/show_bug.cgi?id=126401
+rdar://problem/15739334
+
+Reviewed by Tim Horton.
+
+* page/ios/EventHandlerIOS.mm:
+(WebCore::currentEventSlot): Make the shared variable have static-storage duration.
+
2014-01-02 Gavin Barraclough barraclo...@apple.com
Merge didMoveOnscreen / page visibility to isVisible
Modified: trunk/Source/WebCore/page/ios/EventHandlerIOS.mm (161226 => 161227)
--- trunk/Source/WebCore/page/ios/EventHandlerIOS.mm 2014-01-02 22:20:05 UTC (rev 161226)
+++ trunk/Source/WebCore/page/ios/EventHandlerIOS.mm 2014-01-02 22:32:19 UTC (rev 161227)
@@ -53,7 +53,7 @@
static RetainPtrWebEvent currentEventSlot()
{
-NeverDestroyedRetainPtrWebEvent event;
+static NeverDestroyedRetainPtrWebEvent event;
return event;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161228] trunk/Source
Title: [161228] trunk/Source Revision 161228 Author barraclo...@apple.com Date 2014-01-02 14:35:58 -0800 (Thu, 02 Jan 2014) Log Message Source/WebCore: [iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved() (also crashes when scrolling certain sites) https://bugs.webkit.org/show_bug.cgi?id=126401 rdar://problem/15739334 Patch by Daniel Bates daba...@apple.com on 2014-01-02 Reviewed by Tim Horton. * page/ios/EventHandlerIOS.mm: (WebCore::currentEventSlot): Make the shared variable have static-storage duration. Source/WebKit/mac: Remove WindowIsVisible https://bugs.webkit.org/show_bug.cgi?id=126270 Reviewed by Tim Horton. We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible. The latter detects that the content is hidden in fewer cases than the former, and as such, the former is always preferable. This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to Plugin::windowVisibilityChanged. * WebView/WebView.mm: (-[WebView _windowWillOrderOnScreen:]): (-[WebView _windowWillOrderOffScreen:]): - rename ContainingWindowIsVisible - ContentIsVisible. Source/WebKit2: Remove WindowIsVisible https://bugs.webkit.org/show_bug.cgi?id=126270 Reviewed by Tim Horton. We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible. The latter detects that the content is hidden in fewer cases than the former, and as such, the former is always preferable. This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to Plugin::windowVisibilityChanged. * Shared/ViewState.h: - remove WindowIsVisible. * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: - remove isWindowVisible. * UIProcess/API/mac/WKView.mm: (-[WKView viewDidMoveToWindow]): (-[WKView _windowDidMiniaturize:]): (-[WKView _windowDidDeminiaturize:]): (-[WKView _windowDidOrderOffScreen:]): (-[WKView _windowDidOrderOnScreen:]): - remove ViewState::WindowIsVisible. * UIProcess/PageClient.h: - remove isWindowVisible. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateViewState): - remove handling of ViewState::WindowIsVisible. * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::setIsVisible): (WebKit::PluginView::didInitializePlugin): * WebProcess/Plugins/PluginView.h: - setWindowIsVisible - setIsVisible. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::setViewIsVisible): (WebKit::WebPage::setViewState): (WebKit::WebPage::windowAndWebPageAreFocused): * WebProcess/WebPage/WebPage.h: (WebKit::WebPage::isVisible): - remove m_windowIsVisible, setWindowIsVisible (implementation moved to setViewIsVisible). Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/FocusController.cpp trunk/Source/WebCore/page/FocusController.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/ViewState.h trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h Diff Modified: trunk/Source/WebCore/ChangeLog (161227 => 161228) --- trunk/Source/WebCore/ChangeLog 2014-01-02 22:32:19 UTC (rev 161227) +++ trunk/Source/WebCore/ChangeLog 2014-01-02 22:35:58 UTC (rev 161228) @@ -12,6 +12,27 @@ 2014-01-02 Gavin Barraclough barraclo...@apple.com +Remove WindowIsVisible +https://bugs.webkit.org/show_bug.cgi?id=126270 + +Reviewed by Tim Horton. + +We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible. +The latter detects that the content is hidden in fewer cases than the former, and as such, the +former is always preferable. + +This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to +Plugin::windowVisibilityChanged. + +* WebCore.exp.in: +* page/FocusController.cpp: +(WebCore::FocusController::FocusController): +(WebCore::FocusController::setContentIsVisible): +* page/FocusController.h: +- rename ContainingWindowIsVisible - ContentIsVisible. +
[webkit-changes] [161229] branches/jsCStack/Source/JavaScriptCore
Title: [161229] branches/jsCStack/Source/_javascript_Core
Revision 161229
Author mark@apple.com
Date 2014-01-02 14:43:57 -0800 (Thu, 02 Jan 2014)
Log Message
CStack: Interpreter::executeCall() should check for exceptions after calling callToNativeFunction().
https://bugs.webkit.org/show_bug.cgi?id=126405.
Not yet reviewed.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- executeCall() was expecting to return a non-null JSValue but neglected
to check if an exception was thrown during a call to callToNativeFunction.
We now check if an exception was thrown, and if so, we set the result to
jsNull() the same way that JITCode::execute() does.
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/interpreter/Interpreter.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161228 => 161229)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 22:35:58 UTC (rev 161228)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 22:43:57 UTC (rev 161229)
@@ -1,3 +1,17 @@
+2014-01-02 Mark Lam mark@apple.com
+
+CStack: Interpreter::executeCall() should check for exceptions after calling callToNativeFunction().
+https://bugs.webkit.org/show_bug.cgi?id=126405.
+
+Not yet reviewed.
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::executeCall):
+- executeCall() was expecting to return a non-null JSValue but neglected
+ to check if an exception was thrown during a call to callToNativeFunction.
+ We now check if an exception was thrown, and if so, we set the result to
+ jsNull() the same that JITCode::execute() does.
+
2014-01-02 Filip Pizlo fpi...@apple.com
Address review feedback in https://bugs.webkit.org/show_bug.cgi?id=126387#c3
Modified: branches/jsCStack/Source/_javascript_Core/interpreter/Interpreter.cpp (161228 => 161229)
--- branches/jsCStack/Source/_javascript_Core/interpreter/Interpreter.cpp 2014-01-02 22:35:58 UTC (rev 161228)
+++ branches/jsCStack/Source/_javascript_Core/interpreter/Interpreter.cpp 2014-01-02 22:43:57 UTC (rev 161229)
@@ -966,8 +966,11 @@
// Execute the code:
if (isJSCall)
result = callData.js.functionExecutable-generatedJITCodeForCall()-execute(vm, protoCallFrame);
-else
+else {
result = JSValue::decode(callToNativeFunction(reinterpret_castvoid*(callData.native.function), vm, protoCallFrame));
+if (callFrame-hadException())
+result = jsNull();
+}
}
if (LegacyProfiler* profiler = vm.enabledProfiler())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161230] trunk/Source/JavaScriptCore
Title: [161230] trunk/Source/_javascript_Core Revision 161230 Author mhahnenb...@apple.com Date 2014-01-02 14:57:14 -0800 (Thu, 02 Jan 2014) Log Message Storing new CopiedSpace memory into a JSObject should fire a write barrier https://bugs.webkit.org/show_bug.cgi?id=126025 Reviewed by Filip Pizlo. Technically this is creating a pointer between a (potentially) old generation object and a young generation chunk of memory, thus there needs to be a barrier. * _javascript_Core.xcodeproj/project.pbxproj: * dfg/DFGOperations.cpp: * heap/CopyWriteBarrier.h: Added. This class functions similarly to the WriteBarrier class. It acts as a proxy for pointers to CopiedSpace. Assignments to the field cause a write barrier to fire for the object that is the owner of the CopiedSpace memory. This is to ensure during nursery collections that objects with new backing stores are visited, even if they are old generation objects. (JSC::CopyWriteBarrier::CopyWriteBarrier): (JSC::CopyWriteBarrier::operator!): (JSC::CopyWriteBarrier::operator UnspecifiedBoolType*): (JSC::CopyWriteBarrier::get): (JSC::CopyWriteBarrier::operator*): (JSC::CopyWriteBarrier::operator-): (JSC::CopyWriteBarrier::set): (JSC::CopyWriteBarrier::setWithoutWriteBarrier): (JSC::CopyWriteBarrier::clear): * heap/Heap.h: * runtime/JSArray.cpp: (JSC::JSArray::unshiftCountSlowCase): (JSC::JSArray::shiftCountWithArrayStorage): (JSC::JSArray::unshiftCountWithArrayStorage): * runtime/JSCell.h: (JSC::JSCell::unvalidatedStructure): * runtime/JSGenericTypedArrayViewInlines.h: (JSC::JSGenericTypedArrayViewAdaptor::slowDownAndWasteMemory): * runtime/JSObject.cpp: (JSC::JSObject::copyButterfly): (JSC::JSObject::getOwnPropertySlotByIndex): (JSC::JSObject::putByIndex): (JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists): (JSC::JSObject::createInitialIndexedStorage): (JSC::JSObject::createArrayStorage): (JSC::JSObject::deletePropertyByIndex): (JSC::JSObject::getOwnPropertyNames): (JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes): (JSC::JSObject::countElements): (JSC::JSObject::increaseVectorLength): (JSC::JSObject::ensureLengthSlow): * runtime/JSObject.h: (JSC::JSObject::butterfly): (JSC::JSObject::setStructureAndButterfly): (JSC::JSObject::setButterflyWithoutChangingStructure): (JSC::JSObject::JSObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirectWithoutTransition): * runtime/MapData.cpp: (JSC::MapData::ensureSpaceForAppend): * runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/dfg/DFGOperations.cpp trunk/Source/_javascript_Core/runtime/JSArray.cpp trunk/Source/_javascript_Core/runtime/JSCell.h trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h trunk/Source/_javascript_Core/runtime/MapData.cpp trunk/Source/_javascript_Core/runtime/Structure.cpp Added Paths trunk/Source/_javascript_Core/heap/CopyWriteBarrier.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (161229 => 161230) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-02 22:43:57 UTC (rev 161229) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-02 22:57:14 UTC (rev 161230) @@ -1,3 +1,62 @@ +2014-01-02 Mark Hahnenberg mhahnenb...@apple.com + +Storing new CopiedSpace memory into a JSObject should fire a write barrier +https://bugs.webkit.org/show_bug.cgi?id=126025 + +Reviewed by Filip Pizlo. + +Technically this is creating a pointer between a (potentially) old generation object and a young +generation chunk of memory, thus there needs to be a barrier. + +* _javascript_Core.xcodeproj/project.pbxproj: +* dfg/DFGOperations.cpp: +* heap/CopyWriteBarrier.h: Added. This class functions similarly to the WriteBarrier class. It +acts as a proxy for pointers to CopiedSpace. Assignments to the field cause a write barrier to +fire for the object that is the owner of the CopiedSpace memory. This is to ensure during nursery +collections that objects with new backing stores are visited, even if they are old generation objects. +(JSC::CopyWriteBarrier::CopyWriteBarrier): +(JSC::CopyWriteBarrier::operator!): +(JSC::CopyWriteBarrier::operator UnspecifiedBoolType*): +(JSC::CopyWriteBarrier::get): +(JSC::CopyWriteBarrier::operator*): +(JSC::CopyWriteBarrier::operator-): +(JSC::CopyWriteBarrier::set): +(JSC::CopyWriteBarrier::setWithoutWriteBarrier): +(JSC::CopyWriteBarrier::clear): +
[webkit-changes] [161231] trunk/Source/WebCore
Title: [161231] trunk/Source/WebCore
Revision 161231
Author commit-qu...@webkit.org
Date 2014-01-02 15:14:07 -0800 (Thu, 02 Jan 2014)
Log Message
Video-seek-with-negative-playback was flaky.
https://bugs.webkit.org/show_bug.cgi?id=126379
Patch by Piotr Grad p.g...@samsung.com on 2014-01-02
Reviewed by Eric Carlson.
No new tests. Covered by existing tests.
m_player-setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends
on endedPlayback(), which checks m_playbackRate.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setPlaybackRate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161230 => 161231)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 22:57:14 UTC (rev 161230)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 23:14:07 UTC (rev 161231)
@@ -1,3 +1,18 @@
+2014-01-02 Piotr Grad p.g...@samsung.com
+
+Video-seek-with-negative-playback was flaky.
+https://bugs.webkit.org/show_bug.cgi?id=126379
+
+Reviewed by Eric Carlson.
+
+No new tests. Covered by existing tests.
+
+m_player-setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends
+on endedPlayback(), which checks m_playbackRate.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::setPlaybackRate):
+
2014-01-02 Daniel Bates daba...@apple.com
[iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved()
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (161230 => 161231)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-01-02 22:57:14 UTC (rev 161230)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-01-02 23:14:07 UTC (rev 161231)
@@ -2565,15 +2565,15 @@
void HTMLMediaElement::setPlaybackRate(double rate)
{
LOG(Media, HTMLMediaElement::setPlaybackRate(%f), rate);
-
+
+if (m_player potentiallyPlaying() m_player-rate() != rate !m_mediaController)
+m_player-setRate(rate);
+
if (m_playbackRate != rate) {
m_playbackRate = rate;
invalidateCachedTime();
scheduleEvent(eventNames().ratechangeEvent);
}
-
-if (m_player potentiallyPlaying() m_player-rate() != rate !m_mediaController)
-m_player-setRate(rate);
}
void HTMLMediaElement::updatePlaybackRate()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161232] branches/jsCStack/Source/JavaScriptCore/ChangeLog
Title: [161232] branches/jsCStack/Source/_javascript_Core/ChangeLog Revision 161232 Author mark@apple.com Date 2014-01-02 15:20:26 -0800 (Thu, 02 Jan 2014) Log Message Added a missing word in a change comment, and updated review status for: https://bugs.webkit.org/show_bug.cgi?id=126321 https://bugs.webkit.org/show_bug.cgi?id=126328 https://bugs.webkit.org/show_bug.cgi?id=126334 https://bugs.webkit.org/show_bug.cgi?id=126405 Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161231 => 161232) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:14:07 UTC (rev 161231) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:20:26 UTC (rev 161232) @@ -3,14 +3,14 @@ CStack: Interpreter::executeCall() should check for exceptions after calling callToNativeFunction(). https://bugs.webkit.org/show_bug.cgi?id=126405. -Not yet reviewed. +Reviewed by Michael Saboff. * interpreter/Interpreter.cpp: (JSC::Interpreter::executeCall): - executeCall() was expecting to return a non-null JSValue but neglected to check if an exception was thrown during a call to callToNativeFunction. We now check if an exception was thrown, and if so, we set the result to - jsNull() the same that JITCode::execute() does. + jsNull() the same way that JITCode::execute() does. 2014-01-02 Filip Pizlo fpi...@apple.com @@ -230,7 +230,7 @@ CStack: Introduce tracking of the top VMEntryScope. https://bugs.webkit.org/show_bug.cgi?id=126334. -Not yet reviewed. +Reviewed by Geoffrey Garen. When we start measuring the stack usage of each VMEntryScope, we'll need to know which VMEntryScope is the top (most recent) one, not just the @@ -281,7 +281,7 @@ CStack: Fix JSStack::ensureCapacity() to match LLINT and JIT stack checks. https://bugs.webkit.org/show_bug.cgi?id=126328. -Not yet reviewed. +Reviewed by Geoffrey Garen. Also removed the now unused JSSTack::topOfStackForCapacityCheck(). @@ -294,7 +294,7 @@ CStack: Introducing Options::maxStackSize(). https://bugs.webkit.org/show_bug.cgi?id=126321. -Not yet reviewed. +Reviewed by Geoffrey Garen. We need an option to limit the JS stack size. Currently, we just change the JSStack class to use this limit. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161233] trunk/Tools
Title: [161233] trunk/Tools
Revision 161233
Author a...@apple.com
Date 2014-01-02 15:24:34 -0800 (Thu, 02 Jan 2014)
Log Message
+ is very confusing at http://build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126400
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
source and internal counts separately, simply add them. One can always open a popover
for more detail.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (161232 => 161233)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2014-01-02 23:20:26 UTC (rev 161232)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2014-01-02 23:24:34 UTC (rev 161233)
@@ -79,9 +79,9 @@
if (!latestRecordedOpenSourceRevisionNumber)
return;
-var openSourceRevisionsBehind = latestRecordedOpenSourceRevisionNumber - latestProductiveIteration.openSourceRevision;
-if (openSourceRevisionsBehind 0)
-openSourceRevisionsBehind = 0;
+var totalRevisionsBehind = latestRecordedOpenSourceRevisionNumber - latestProductiveIteration.openSourceRevision;
+if (totalRevisionsBehind 0)
+totalRevisionsBehind = 0;
if (latestProductiveIteration.internalRevision) {
var latestRecordedInternalRevisionNumber = internalTrac.latestRecordedRevisionNumber;
@@ -89,18 +89,15 @@
return;
var internalRevisionsBehind = latestRecordedInternalRevisionNumber - latestProductiveIteration.internalRevision;
-if (internalRevisionsBehind 0)
-internalRevisionsBehind = 0;
-if (openSourceRevisionsBehind || internalRevisionsBehind)
-var messageText = openSourceRevisionsBehind + \uff0b + internalRevisionsBehind + revisions behind;
-} else if (openSourceRevisionsBehind)
-var messageText = openSourceRevisionsBehind + + (openSourceRevisionsBehind === 1 ? revision behind : revisions behind);
+if (internalRevisionsBehind 0)
+totalRevisionsBehind += internalRevisionsBehind;
+}
-if (!messageText)
+if (!totalRevisionsBehind)
return;
var messageElement = document.createElement(span); // We can't just pass text to StatusLineView here, because we need an element that perfectly fits the text for popover positioning.
-messageElement.textContent = messageText;
+messageElement.textContent = totalRevisionsBehind + + (totalRevisionsBehind === 1 ? revision behind : revisions behind);
var status = new StatusLineView(messageElement, StatusLineView.Status.NoBubble);
this.element.appendChild(status.element);
Modified: trunk/Tools/ChangeLog (161232 => 161233)
--- trunk/Tools/ChangeLog 2014-01-02 23:20:26 UTC (rev 161232)
+++ trunk/Tools/ChangeLog 2014-01-02 23:24:34 UTC (rev 161233)
@@ -1,5 +1,17 @@
2014-01-02 Alexey Proskuryakov a...@apple.com
++ is very confusing at http://build.webkit.org/dashboard
+https://bugs.webkit.org/show_bug.cgi?id=126400
+
+Reviewed by Tim Horton.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+(BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
+source and internal counts separately, simply add them. One can always open a popover
+for more detail.
+
+2014-01-02 Alexey Proskuryakov a...@apple.com
+
Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
https://bugs.webkit.org/show_bug.cgi?id=126391
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161234] branches/jsCStack/Source/JavaScriptCore
Title: [161234] branches/jsCStack/Source/_javascript_Core Revision 161234 Author fpi...@apple.com Date 2014-01-02 15:28:36 -0800 (Thu, 02 Jan 2014) Log Message CStack LLInt 32-bit should build https://bugs.webkit.org/show_bug.cgi?id=126409 Not yet reviewed. And the stuff we do to make it build should at least try to be correct. * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter64.asm Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161233 => 161234) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:24:34 UTC (rev 161233) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:28:36 UTC (rev 161234) @@ -1,3 +1,15 @@ +2014-01-02 Filip Pizlo fpi...@apple.com + +CStack LLInt 32-bit should build +https://bugs.webkit.org/show_bug.cgi?id=126409 + +Not yet reviewed. + +And the stuff we do to make it build should at least try to be correct. + +* llint/LowLevelInterpreter32_64.asm: +* llint/LowLevelInterpreter64.asm: + 2014-01-02 Mark Lam mark@apple.com CStack: Interpreter::executeCall() should check for exceptions after calling callToNativeFunction(). Modified: branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (161233 => 161234) --- branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-02 23:24:34 UTC (rev 161233) +++ branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-02 23:28:36 UTC (rev 161234) @@ -145,13 +145,12 @@ move t1, cfr end -macro doCallToJavaScript(makeCall, doReturn) +macro doCallToJavaScript(makeCall) if X86 const entry = t4 -const vmTopCallFrame = t2 +const vm = t2 const protoCallFrame = t5 -const extraStackSpace = 28 const previousCFR = t0 const previousPC = t1 const temp1 = t0 # Same as previousCFR @@ -160,9 +159,8 @@ const temp4 = t3 elsif ARM or ARMv7_TRADITIONAL const entry = a0 -const vmTopCallFrame = a1 +const vm = a1 const protoCallFrame = a2 -const topOfStack = a3 const extraStackSpace = 16 const previousCFR = t3 @@ -173,9 +171,8 @@ const temp4 = t4 elsif ARMv7 const entry = a0 -const vmTopCallFrame = a1 +const vm = a1 const protoCallFrame = a2 -const topOfStack = a3 const extraStackSpace = 28 const previousCFR = t3 @@ -216,45 +213,73 @@ loadp [sp], previousPC move cfr, previousCFR end -functionPrologue(extraStackSpace) if X86 -loadp extraStackSpace+20[sp], entry -loadp extraStackSpace+24[sp], vmTopCallFrame -loadp extraStackSpace+28[sp], protoCallFrame -loadp extraStackSpace+32[sp], cfr +loadp 20[sp], entry +loadp 24[sp], vm +loadp 28[sp], protoCallFrame else move cfr, previousCFR move topOfStack, cfr end +callToJavaScriptPrologue() + +checkStackPointerAlignment(temp2, 0xbad0dc01) -subp (CallFrameHeaderSlots-1)*8, cfr -storep 0, ArgumentCount+4[cfr] +# The jsStackLimit was previously computed in VMEntryScope using an +# estimated stackPointerAtVMEntry value. Adjust the jsStackLimit by +# the delta between the actual stackPointerAtVMEntry and the estimate +# that we used previously. +subp VM::stackPointerAtVMEntry[vm], sp, temp2 +subp VM::m_jsStackLimit[vm], temp2, temp2 +storep temp2, VM::m_jsStackLimit[vm] +storep sp, VM::stackPointerAtVMEntry[vm] + +# The stack host zone ensures that we have adequate space for the +# VMEntrySentinelFrame. Proceed with allocating and initializing the +# sentinel frame. +move sp, cfr +subp CallFrameHeaderSlots * 8, cfr storep 0, ArgumentCount[cfr] -storep 0, Callee+4[cfr] -storep vmTopCallFrame, Callee[cfr] -loadp [vmTopCallFrame], temp4 -storep 0, ScopeChain+4[cfr] -storep temp4, ScopeChain[cfr] -storep 0, CodeBlock+4[cfr] +storep vm, Callee[cfr] +loadp VM::topCallFrame[vm], temp2 +storep temp2, ScopeChain[cfr] storep 1, CodeBlock[cfr] storep previousPC, ReturnPC[cfr] storep previousCFR, CallerFrame[cfr] -move cfr, temp1 loadi ProtoCallFrame::paddedArgCount[protoCallFrame], temp2 addp CallFrameHeaderSlots, temp2, temp2 lshiftp 3, temp2 -subp temp2, cfr -storep temp1, CallerFrame[cfr] +subp cfr, temp2, temp1 +# Ensure that we have enough additional stack capacity for the incoming args, +# and the frame for the JS code we're executing. We need to do this check +
[webkit-changes] [161235] trunk
Title: [161235] trunk Revision 161235 Author mmaxfi...@apple.com Date 2014-01-02 15:32:47 -0800 (Thu, 02 Jan 2014) Log Message Allow ImageBuffer to re-use IOSurfaces https://bugs.webkit.org/show_bug.cgi?id=125477 Source/WebCore: Reviewed by Geoff Garen. Modifications reviewed by Tim Horton. This patch is taken from r160945, but the modifications to ImageBufferCG.cpp have been reverted. This test adds a static class, ImageBufferBackingStoreCache, that vends IOSurfaces. It remembers IOSurfaces that have been returned to it until a configurable timeout. The storage used by this class is in the form of a HashMap from a bucketed size to the IOSurface. There are many other data structures that could be used, but this implementation gives a 80% hit rate on normal browsing of some example sites with Canvas and text-decoration-skip: ink. Because the buckets are fairly small (rounding the width and height up to multiples of 8), traversing the bucket contents takes on average 2 steps. Test: fast/canvas/canvas-backing-store-reuse.html * WebCore.xcodeproj/project.pbxproj: Added new caching class * platform/graphics/cg/ImageBufferBackingStoreCache.cpp: Added. (WebCore::createIOSurface): Copied from ImageBufferCG.cpp (WebCore::ImageBufferBackingStoreCache::timerFired): Forget the cache contents (WebCore::ImageBufferBackingStoreCache::schedulePurgeTimer): (WebCore::ImageBufferBackingStoreCache::get): Static getter (WebCore::ImageBufferBackingStoreCache::ImageBufferBackingStoreCache): (WebCore::ImageBufferBackingStoreCache::insertIntoCache): Memory-management creation function (WebCore::ImageBufferBackingStoreCache::takeFromCache): Memory-management deletion function (WebCore::ImageBufferBackingStoreCache::isAcceptableSurface): Does this cached IOSurface fit the bill? (WebCore::ImageBufferBackingStoreCache::tryTakeFromCache): Lookup a bucket and walk through its contents (WebCore::ImageBufferBackingStoreCache::getOrAllocate): Public function for clients who want a IOSurface from the cache (WebCore::ImageBufferBackingStoreCache::deallocate): Public function for clients to return an IOSurface to the pool * platform/graphics/cg/ImageBufferBackingStoreCache.h: Added. (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::~ImageBuffer): PerformanceTests: Reviewed by Geoff Garen. This test times creating a variety of different sizes of canvases once some have already been created. The second creation of the canvases should re-use the existing IOSurfaces. * Canvas/reuse.html: Added. LayoutTests: Reviewed by Geoff Garen. Now that we're re-using the backing store of canvases, this test makes sure that if we draw to a canvas, then destroy it, then create a new canvas (which should share the same backing store) that it doesn't have the stale data in it * fast/canvas/canvas-backing-store-reuse-expected.txt: Added. * fast/canvas/canvas-backing-store-reuse.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/PerformanceTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj Added Paths trunk/LayoutTests/fast/canvas/canvas-backing-store-reuse-expected.txt trunk/LayoutTests/fast/canvas/canvas-backing-store-reuse.html trunk/PerformanceTests/Canvas/reuse.html trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.cpp trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.h Diff Modified: trunk/LayoutTests/ChangeLog (161234 => 161235) --- trunk/LayoutTests/ChangeLog 2014-01-02 23:28:36 UTC (rev 161234) +++ trunk/LayoutTests/ChangeLog 2014-01-02 23:32:47 UTC (rev 161235) @@ -1,3 +1,18 @@ +2014-01-02 Myles C. Maxfield mmaxfi...@apple.com + +Allow ImageBuffer to re-use IOSurfaces +https://bugs.webkit.org/show_bug.cgi?id=125477 + +Reviewed by Geoff Garen. + +Now that we're re-using the backing store of canvases, this +test makes sure that if we draw to a canvas, then destroy it, +then create a new canvas (which should share the same backing +store) that it doesn't have the stale data in it + +* fast/canvas/canvas-backing-store-reuse-expected.txt: Added. +* fast/canvas/canvas-backing-store-reuse.html: Added. + 2014-01-02 Dirk Schulze k...@webkit.org Support box values computed style for 'clip-path' property Added: trunk/LayoutTests/fast/canvas/canvas-backing-store-reuse-expected.txt (0 => 161235) --- trunk/LayoutTests/fast/canvas/canvas-backing-store-reuse-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/canvas-backing-store-reuse-expected.txt 2014-01-02 23:32:47 UTC (rev 161235) @@ -0,0 +1,5 @@ +PASS data.data is [0, 0, 0, 0] +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/canvas/canvas-backing-store-reuse.html (0 => 161235) --- trunk/LayoutTests/fast/canvas/canvas-backing-store-reuse.html (rev 0) +++
[webkit-changes] [161236] trunk/Tools
Title: [161236] trunk/Tools
Revision 161236
Author a...@apple.com
Date 2014-01-02 15:35:04 -0800 (Thu, 02 Jan 2014)
Log Message
Bindings tests results links are broken at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126402
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
since the beginning.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (161235 => 161236)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2014-01-02 23:32:47 UTC (rev 161235)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2014-01-02 23:35:04 UTC (rev 161236)
@@ -83,6 +83,6 @@
bindingsTestResultsURLForIteration: function(iteration)
{
-return this.baseURL + builders/ + encodeURIComponent(iteration.queue.id) + /builds/ + iteration.id + /steps/bindings-generation-test/logs/stdio;
+return this.baseURL + builders/ + encodeURIComponent(iteration.queue.id) + /builds/ + iteration.id + /steps/bindings-generation-tests/logs/stdio;
}
};
Modified: trunk/Tools/ChangeLog (161235 => 161236)
--- trunk/Tools/ChangeLog 2014-01-02 23:32:47 UTC (rev 161235)
+++ trunk/Tools/ChangeLog 2014-01-02 23:35:04 UTC (rev 161236)
@@ -1,5 +1,16 @@
2014-01-02 Alexey Proskuryakov a...@apple.com
+Bindings tests results links are broken at build.webkit.org/dashboard
+https://bugs.webkit.org/show_bug.cgi?id=126402
+
+Reviewed by Tim Horton.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+(Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
+since the beginning.
+
+2014-01-02 Alexey Proskuryakov a...@apple.com
+
+ is very confusing at http://build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126400
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161237] branches/jsCStack/Source/JavaScriptCore
Title: [161237] branches/jsCStack/Source/_javascript_Core Revision 161237 Author fpi...@apple.com Date 2014-01-02 15:50:20 -0800 (Thu, 02 Jan 2014) Log Message Address review comments in https://bugs.webkit.org/show_bug.cgi?id=126409#c3 * llint/LowLevelInterpreter32_64.asm: Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161236 => 161237) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:35:04 UTC (rev 161236) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:50:20 UTC (rev 161237) @@ -1,11 +1,24 @@ 2014-01-02 Filip Pizlo fpi...@apple.com +Address review comments in https://bugs.webkit.org/show_bug.cgi?id=126409#c3 + +* llint/LowLevelInterpreter32_64.asm: + +2014-01-02 Filip Pizlo fpi...@apple.com + CStack LLInt 32-bit should build https://bugs.webkit.org/show_bug.cgi?id=126409 -Not yet reviewed. +Reviewed by Michael Saboff. -And the stuff we do to make it build should at least try to be correct. +This attempst to get the 32-bit LLInt to do the same things that the 64-bit LLInt +does for the C stack. This was mostly just mechanical. + +Only one part of the code didn't port cleanly, and that was the use of t6 in +handleUncaughtException. I changed it to t5 because as far as I can tell, t5 is +not live at that point in either version of the LLInt. + +Note that we still can't build 32-bit yet so these changes are being done blind. * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: Modified: branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (161236 => 161237) --- branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-02 23:35:04 UTC (rev 161236) +++ branches/jsCStack/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-02 23:50:20 UTC (rev 161237) @@ -162,7 +162,6 @@ const vm = a1 const protoCallFrame = a2 -const extraStackSpace = 16 const previousCFR = t3 const previousPC = lr const temp1 = t3 # Same as previousCFR @@ -174,7 +173,6 @@ const vm = a1 const protoCallFrame = a2 -const extraStackSpace = 28 const previousCFR = t3 const previousPC = lr const temp1 = t3 # Same as previousCFR @@ -187,7 +185,6 @@ const protoCallFrame = a2 const topOfStack = a3 -const extraStackSpace = 36 const previousCFR = t2 const previousPC = lr const temp1 = t3 @@ -200,7 +197,6 @@ const protoCallFrame = a2 const topOfStack = a3 -const extraStackSpace = 20 const previousCFR = t3 const previousPC = lr const temp1 = t3 # Same as previousCFR ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161238] branches/jsCStack/Source/JavaScriptCore
Title: [161238] branches/jsCStack/Source/_javascript_Core Revision 161238 Author mark@apple.com Date 2014-01-02 15:58:16 -0800 (Thu, 02 Jan 2014) Log Message Addressed review comments in https://bugs.webkit.org/show_bug.cgi?id=126393#c5. Reviewed by Michael Saboff. * offlineasm/cloop.rb: Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/offlineasm/cloop.rb Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161237 => 161238) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:50:20 UTC (rev 161237) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-02 23:58:16 UTC (rev 161238) @@ -1,3 +1,10 @@ +2014-01-02 Mark Lam mark@apple.com + +Addressed review comments in https://bugs.webkit.org/show_bug.cgi?id=126393#c5. +Reviewed by Michael Saboff. + +* offlineasm/cloop.rb: + 2014-01-02 Filip Pizlo fpi...@apple.com Address review comments in https://bugs.webkit.org/show_bug.cgi?id=126409#c3 @@ -48,7 +55,7 @@ CStack: Get the C Loop LLINT to build again. https://bugs.webkit.org/show_bug.cgi?id=126393. -Not yet reviewed. +Reviewed by Michael Saboff. * jit/JITCode.cpp: (JSC::DirectJITCode::addressForCall): Modified: branches/jsCStack/Source/_javascript_Core/offlineasm/cloop.rb (161237 => 161238) --- branches/jsCStack/Source/_javascript_Core/offlineasm/cloop.rb 2014-01-02 23:50:20 UTC (rev 161237) +++ branches/jsCStack/Source/_javascript_Core/offlineasm/cloop.rb 2014-01-02 23:58:16 UTC (rev 161238) @@ -70,23 +70,14 @@ case name # The cloop is modelled on the ARM implementation. Hence, the a0-a3 # registers are aliases for r0-r3 i.e. t0-t3 in our case. -when a0 +when t0, a0 t0 -when a1 +when t1, a1 t1 -when a2 +when t2, a2 t2 -when a3 +when t3, a3 t3 - -when t0 -t0 -when t1 -t1 -when t2 -t2 -when t3 -t3 when t4 rPC when t5 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161239] trunk/Source/WebCore
Title: [161239] trunk/Source/WebCore
Revision 161239
Author timothy_hor...@apple.com
Date 2014-01-02 16:10:48 -0800 (Thu, 02 Jan 2014)
Log Message
ImageBufferBackingStoreCache should use DeferrableOneShotTimer
https://bugs.webkit.org/show_bug.cgi?id=126155
Reviewed by Anders Carlsson.
Since ImageBufferBackingStoreCache's purge timer is pushed out every time
a backing store is deallocated, we can easily waste a lot of time rescheduling
the timer. Since it's a cache purge timer and doesn't need that kind of precision,
adopt DeferrableOneShotTimer, which is much more performant when deferred frequently.
* platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
(WebCore::ImageBufferBackingStoreCache::ImageBufferBackingStoreCache):
(WebCore::ImageBufferBackingStoreCache::timerFired):
(WebCore::ImageBufferBackingStoreCache::schedulePurgeTimer):
* platform/graphics/cg/ImageBufferBackingStoreCache.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (161238 => 161239)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 23:58:16 UTC (rev 161238)
+++ trunk/Source/WebCore/ChangeLog 2014-01-03 00:10:48 UTC (rev 161239)
@@ -1,3 +1,21 @@
+2014-01-02 Tim Horton timothy_hor...@apple.com
+
+ImageBufferBackingStoreCache should use DeferrableOneShotTimer
+https://bugs.webkit.org/show_bug.cgi?id=126155
+
+Reviewed by Anders Carlsson.
+
+Since ImageBufferBackingStoreCache's purge timer is pushed out every time
+a backing store is deallocated, we can easily waste a lot of time rescheduling
+the timer. Since it's a cache purge timer and doesn't need that kind of precision,
+adopt DeferrableOneShotTimer, which is much more performant when deferred frequently.
+
+* platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
+(WebCore::ImageBufferBackingStoreCache::ImageBufferBackingStoreCache):
+(WebCore::ImageBufferBackingStoreCache::timerFired):
+(WebCore::ImageBufferBackingStoreCache::schedulePurgeTimer):
+* platform/graphics/cg/ImageBufferBackingStoreCache.h:
+
2014-01-02 Myles C. Maxfield mmaxfi...@apple.com
Allow ImageBuffer to re-use IOSurfaces
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.cpp (161238 => 161239)
--- trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.cpp 2014-01-02 23:58:16 UTC (rev 161238)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.cpp 2014-01-03 00:10:48 UTC (rev 161239)
@@ -29,6 +29,8 @@
#if USE(IOSURFACE_CANVAS_BACKING_STORE)
#include IOSurface/IOSurface.h
+static const double purgeInterval = 5;
+
namespace WebCore {
static RetainPtrIOSurfaceRef createIOSurface(const IntSize size)
@@ -69,6 +71,12 @@
return adoptCF(IOSurfaceCreate(dict.get()));
}
+ImageBufferBackingStoreCache::ImageBufferBackingStoreCache()
+: m_purgeTimer(this, ImageBufferBackingStoreCache::timerFired, purgeInterval)
+, m_pixelsCached(0)
+{
+}
+
ImageBufferBackingStoreCache ImageBufferBackingStoreCache::get()
{
DEFINE_STATIC_LOCAL(ImageBufferBackingStoreCache, cache, ());
@@ -200,7 +208,7 @@
schedulePurgeTimer();
}
-void ImageBufferBackingStoreCache::timerFired(TimerImageBufferBackingStoreCache*)
+void ImageBufferBackingStoreCache::timerFired(DeferrableOneShotTimerImageBufferBackingStoreCache*)
{
while (!m_cachedSurfaces.isEmpty()) {
CachedSurfaceMap::iterator iter = m_cachedSurfaces.begin();
@@ -210,11 +218,7 @@
void ImageBufferBackingStoreCache::schedulePurgeTimer()
{
-if (m_purgeTimer.isActive())
-m_purgeTimer.stop();
-
-static const double purgeInterval = 5;
-m_purgeTimer.startOneShot(purgeInterval);
+m_purgeTimer.restart();
}
}
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.h (161238 => 161239)
--- trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.h 2014-01-02 23:58:16 UTC (rev 161238)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageBufferBackingStoreCache.h 2014-01-03 00:10:48 UTC (rev 161239)
@@ -63,11 +63,7 @@
void deallocate(IOSurfaceRef);
private:
-ImageBufferBackingStoreCache()
-: m_purgeTimer(this, ImageBufferBackingStoreCache::timerFired)
-, m_pixelsCached(0)
-{
-}
+ImageBufferBackingStoreCache();
struct IOSurfaceAndContextWithCreationParams : public IOSurfaceAndContext, public DoublyLinkedListNodeIOSurfaceAndContextWithCreationParams {
IOSurfaceAndContextWithCreationParams()
@@ -102,10 +98,10 @@
bool tryTakeFromCache(const IntSize, CGColorSpaceRef, bool needExactSize, IOSurfaceAndContextWithCreationParams outInfo);
bool isAcceptableSurface(const IOSurfaceAndContextWithCreationParams, const IntSize,
[webkit-changes] [161240] trunk/Source/JavaScriptCore
Title: [161240] trunk/Source/_javascript_Core Revision 161240 Author mhahnenb...@apple.com Date 2014-01-02 16:24:14 -0800 (Thu, 02 Jan 2014) Log Message Add support for StoreBarrier and friends to the FTL https://bugs.webkit.org/show_bug.cgi?id=126040 Reviewed by Filip Pizlo. * ftl/FTLAbstractHeapRepository.h: * ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * ftl/FTLIntrinsicRepository.h: * ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::compileNode): (JSC::FTL::LowerDFGToLLVM::compileStoreBarrier): (JSC::FTL::LowerDFGToLLVM::compileConditionalStoreBarrier): (JSC::FTL::LowerDFGToLLVM::compileStoreBarrierWithNullCheck): (JSC::FTL::LowerDFGToLLVM::loadMarkByte): (JSC::FTL::LowerDFGToLLVM::emitStoreBarrier): * heap/Heap.cpp: (JSC::Heap::Heap): * heap/Heap.h: (JSC::Heap::writeBarrierBuffer): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/heap/Heap.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (161239 => 161240) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-03 00:10:48 UTC (rev 161239) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-03 00:24:14 UTC (rev 161240) @@ -1,5 +1,28 @@ 2014-01-02 Mark Hahnenberg mhahnenb...@apple.com +Add support for StoreBarrier and friends to the FTL +https://bugs.webkit.org/show_bug.cgi?id=126040 + +Reviewed by Filip Pizlo. + +* ftl/FTLAbstractHeapRepository.h: +* ftl/FTLCapabilities.cpp: +(JSC::FTL::canCompile): +* ftl/FTLIntrinsicRepository.h: +* ftl/FTLLowerDFGToLLVM.cpp: +(JSC::FTL::LowerDFGToLLVM::compileNode): +(JSC::FTL::LowerDFGToLLVM::compileStoreBarrier): +(JSC::FTL::LowerDFGToLLVM::compileConditionalStoreBarrier): +(JSC::FTL::LowerDFGToLLVM::compileStoreBarrierWithNullCheck): +(JSC::FTL::LowerDFGToLLVM::loadMarkByte): +(JSC::FTL::LowerDFGToLLVM::emitStoreBarrier): +* heap/Heap.cpp: +(JSC::Heap::Heap): +* heap/Heap.h: +(JSC::Heap::writeBarrierBuffer): + +2014-01-02 Mark Hahnenberg mhahnenb...@apple.com + Storing new CopiedSpace memory into a JSObject should fire a write barrier https://bugs.webkit.org/show_bug.cgi?id=126025 Modified: trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h (161239 => 161240) --- trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h 2014-01-03 00:10:48 UTC (rev 161239) +++ trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h 2014-01-03 00:24:14 UTC (rev 161240) @@ -37,7 +37,8 @@ #define FOR_EACH_ABSTRACT_HEAP(macro) \ macro(length) \ -macro(typedArrayProperties) +macro(typedArrayProperties) \ +macro(WriteBarrierBuffer_bufferContents) #define FOR_EACH_ABSTRACT_FIELD(macro) \ macro(Butterfly_publicLength, Butterfly::offsetOfPublicLength()) \ @@ -53,6 +54,7 @@ macro(JSString_value, JSString::offsetOfValue()) \ macro(JSVariableObject_registers, JSVariableObject::offsetOfRegisters()) \ macro(MarkedAllocator_freeListHead, MarkedAllocator::offsetOfFreeListHead()) \ +macro(MarkedBlock_markBits, MarkedBlock::offsetOfMarks()) \ macro(StringImpl_data, StringImpl::dataOffset()) \ macro(StringImpl_hashAndFlags, StringImpl::flagsOffset()) \ macro(Structure_classInfo, Structure::classInfoOffset()) \ Modified: trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp (161239 => 161240) --- trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-03 00:10:48 UTC (rev 161239) +++ trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-03 00:24:14 UTC (rev 161240) @@ -105,6 +105,9 @@ case TypedArrayWatchpoint: case VariableWatchpoint: case NotifyWrite: +case StoreBarrier: +case ConditionalStoreBarrier: +case StoreBarrierWithNullCheck: case ValueToInt32: case Branch: case LogicalNot: Modified: trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h (161239 => 161240) --- trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h 2014-01-03 00:10:48 UTC (rev 161239) +++ trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h 2014-01-03 00:24:14 UTC (rev 161240) @@ -71,6 +71,7 @@ macro(V_JITOperation_EJJJ, functionType(voidType, intPtr, int64, int64, int64)) \ macro(V_JITOperation_EOZD, functionType(voidType, intPtr, intPtr, int32, doubleType)) \ macro(V_JITOperation_EOZJ, functionType(voidType, intPtr, intPtr, int32, int64)) \ +macro(V_JITOperation_EC, functionType(voidType, intPtr, intPtr)) \ macro(V_JITOperation_EVws, functionType(voidType, intPtr, intPtr)) \ macro(Z_JITOperation_D, functionType(int32, doubleType)) Modified:
[webkit-changes] [161242] trunk/Source/WebCore
Title: [161242] trunk/Source/WebCore
Revision 161242
Author bfulg...@apple.com
Date 2014-01-02 17:18:29 -0800 (Thu, 02 Jan 2014)
Log Message
[WebGL] Correct symbol lookup logic to handle 1-element arrays
https://bugs.webkit.org/show_bug.cgi?id=126411
rdar://problem/15394564
Reviewed by Dean Jackson.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniformLocation): Revise code to handle the case of single-element
arrays.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161241 => 161242)
--- trunk/Source/WebCore/ChangeLog 2014-01-03 00:40:16 UTC (rev 161241)
+++ trunk/Source/WebCore/ChangeLog 2014-01-03 01:18:29 UTC (rev 161242)
@@ -1,3 +1,15 @@
+2014-01-02 Brent Fulgham bfulg...@apple.com
+
+[WebGL] Correct symbol lookup logic to handle 1-element arrays
+https://bugs.webkit.org/show_bug.cgi?id=126411
+rdar://problem/15394564
+
+Reviewed by Dean Jackson.
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::getUniformLocation): Revise code to handle the case of single-element
+arrays.
+
2014-01-02 Sam Weinig s...@webkit.org
Update Promises to the https://github.com/domenic/promises-unwrapping spec
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (161241 => 161242)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-01-03 00:40:16 UTC (rev 161241)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-01-03 01:18:29 UTC (rev 161242)
@@ -3162,7 +3162,7 @@
GC3Dint uniformLocation = m_context-getUniformLocation(objectOrZero(program), name);
if (uniformLocation == -1)
return 0;
-
+
GC3Dint activeUniforms = 0;
m_context-getProgramiv(objectOrZero(program), GraphicsContext3D::ACTIVE_UNIFORMS, activeUniforms);
for (GC3Dint i = 0; i activeUniforms; i++) {
@@ -3170,17 +3170,14 @@
if (!m_context-getActiveUniform(objectOrZero(program), i, info))
return 0;
// Strip [0] from the name if it's an array.
-if (info.size 1 info.name.endsWith([0]))
+if (info.name.endsWith([0]))
info.name = info.name.left(info.name.length() - 3);
// If it's an array, we need to iterate through each element, appending [index] to the name.
for (GC3Dint index = 0; index info.size; ++index) {
-String uniformName = info.name;
if (info.size 1) {
-uniformName.append('[');
-uniformName.append(String::number(index));
-uniformName.append(']');
-}
-if (info.size 1) {
+String arrayBrackets = [ + String::number(index) + ];
+String uniformName = info.name + arrayBrackets;
+
if (name == uniformName || name == info.name)
return WebGLUniformLocation::create(program, uniformLocation, info.type);
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161243] trunk/Tools
Title: [161243] trunk/Tools
Revision 161243
Author commit-qu...@webkit.org
Date 2014-01-02 17:19:50 -0800 (Thu, 02 Jan 2014)
Log Message
[GTK] fixing ycm_extra_conf.py file
https://bugs.webkit.org/show_bug.cgi?id=126371
It's an attempt to fix three problems with the current ycm_extra_conf file.
The current implementation assumes that it's a symlink, which is not true.
Usually python creates a pyc file, and this is what you get in __file__.
the .pyc is not a symlink, and the current implementation doesn't work
if that's the case.
It also assumes that the user is in the root folder.
If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
Last but not least, elif flag in FLAGS_PRECEDING_PATHS emits an
exception since flag doesn't exists.
All those things were fixed.
Patch by Danilo Cesar Lemes de Paula danilo.ce...@collabora.co.uk on 2014-01-02
Reviewed by Martin Robinson.
* gtk/ycm_extra_conf.py:
(transform_relative_paths_to_absolute_paths):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/gtk/ycm_extra_conf.py
Diff
Modified: trunk/Tools/ChangeLog (161242 => 161243)
--- trunk/Tools/ChangeLog 2014-01-03 01:18:29 UTC (rev 161242)
+++ trunk/Tools/ChangeLog 2014-01-03 01:19:50 UTC (rev 161243)
@@ -1,3 +1,27 @@
+2014-01-02 Danilo Cesar Lemes de Paula danilo.ce...@collabora.co.uk
+
+[GTK] fixing ycm_extra_conf.py file
+https://bugs.webkit.org/show_bug.cgi?id=126371
+
+It's an attempt to fix three problems with the current ycm_extra_conf file.
+The current implementation assumes that it's a symlink, which is not true.
+Usually python creates a pyc file, and this is what you get in __file__.
+the .pyc is not a symlink, and the current implementation doesn't work
+if that's the case.
+
+It also assumes that the user is in the root folder.
+If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
+
+Last but not least, elif flag in FLAGS_PRECEDING_PATHS emits an
+exception since flag doesn't exists.
+
+All those things were fixed.
+
+Reviewed by Martin Robinson.
+
+* gtk/ycm_extra_conf.py:
+(transform_relative_paths_to_absolute_paths):
+
2014-01-02 Alexey Proskuryakov a...@apple.com
Bindings tests results links are broken at build.webkit.org/dashboard
Modified: trunk/Tools/gtk/ycm_extra_conf.py (161242 => 161243)
--- trunk/Tools/gtk/ycm_extra_conf.py 2014-01-03 01:18:29 UTC (rev 161242)
+++ trunk/Tools/gtk/ycm_extra_conf.py 2014-01-03 01:19:50 UTC (rev 161243)
@@ -23,10 +23,14 @@
# It's very likely that this script is a symlink somewhere in the WebKit directory,
# so we try to find the actual script location so that we can locate the tools
# directory.
-if os.path.islink(__file__):
-__tools_directory = os.path.dirname(os.readlink(__file__))
+original_file = __file__[:-1] if __file__.endswith(.pyc) else __file__
+if os.path.islink(original_file):
+parent_folder = os.path.abspath(os.path.dirname(original_file))
+link_file = os.path.join(parent_folder, os.readlink(original_file))
+__tools_directory = os.path.dirname(link_file)
else:
-__tools_directory = os.path.dirname(__file__)
+__tools_directory = os.path.dirname(original_file)
+
sys.path.insert(0, os.path.abspath(__tools_directory))
import common
@@ -43,7 +47,7 @@
make_next_absolute = False
if not argument.startswith('/'):
argument = os.path.join(build_path, argument)
-elif flag in FLAGS_PRECEDING_PATHS:
+elif argument in FLAGS_PRECEDING_PATHS:
# Some flags precede the path in the list. For those we make the
# next argument absolute.
if argument == flag:
@@ -103,7 +107,7 @@
basename = os.path.basename(filename)
for line in lines:
-if line.find(basename) != -1 and line.find(CC) != -1 or line.find(CXX) != -1:
+if line.find(basename) != -1 and (line.find(CC) != -1 or line.find(CXX) != -1):
return get_compilation_flags_from_build_commandline(line, build_path)
print Could not find flags for %s % filename
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161244] trunk
Title: [161244] trunk Revision 161244 Author mmaxfi...@apple.com Date 2014-01-02 17:32:18 -0800 (Thu, 02 Jan 2014) Log Message Crash in WebCore::translateIntersectionPointsToSkipInkBoundaries https://bugs.webkit.org/show_bug.cgi?id=126252 Reviewed by Alexey Proskuryakov. Source/WebCore: lastIntermediate was a iterator pointing into a Vector, which was being re-used even while appending to the Vector. If any of the append operators triggered a realloc, the iterator would point to the old free'ed memory. Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps.html * rendering/InlineTextBox.cpp: (WebCore::translateIntersectionPointsToSkipInkBoundaries): LayoutTests: This test causes intermediateTuples, a Vector of tuples of floats, to have enough entries to cause a realloc. In my tests, the realloc seems to always allocate the next area of memory (without unmapping any old pages), so this test only crashes if guardMalloc is used. * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps-expected.txt: Added. * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/InlineTextBox.cpp Added Paths trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps-expected.txt trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps.html Diff Modified: trunk/LayoutTests/ChangeLog (161243 => 161244) --- trunk/LayoutTests/ChangeLog 2014-01-03 01:19:50 UTC (rev 161243) +++ trunk/LayoutTests/ChangeLog 2014-01-03 01:32:18 UTC (rev 161244) @@ -1,3 +1,18 @@ +2014-01-02 Myles C. Maxfield mmaxfi...@apple.com + +Crash in WebCore::translateIntersectionPointsToSkipInkBoundaries +https://bugs.webkit.org/show_bug.cgi?id=126252 + +Reviewed by Alexey Proskuryakov. + +This test causes intermediateTuples, a Vector of tuples of floats, to have enough +entries to cause a realloc. In my tests, the realloc seems to always allocate the +next area of memory (without unmapping any old pages), so this test only crashes +if guardMalloc is used. + +* fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps-expected.txt: Added. +* fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps.html: Added. + 2014-01-02 Sam Weinig s...@webkit.org Update Promises to the https://github.com/domenic/promises-unwrapping spec Added: trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps-expected.txt (0 => 161244) --- trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps-expected.txt (rev 0) +++ trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps-expected.txt 2014-01-03 01:32:18 UTC (rev 161244) @@ -0,0 +1 @@ +This tests for a crash that occurred in InlineTextBoxes with lots of underline breaks due to text-decoration-skip: ink.
[webkit-changes] [161246] trunk/Source/WebKit2
Title: [161246] trunk/Source/WebKit2 Revision 161246 Author barraclo...@apple.com Date 2014-01-02 18:09:25 -0800 (Thu, 02 Jan 2014) Log Message Propagate WindowServer modifications state to WebProcess https://bugs.webkit.org/show_bug.cgi?id=126356 Reviewed by Sam Weinig. This will be necessary to move control of process suppression to the WebProcess. IsVisuallyIdle implies the process has stopped painting, or painted rects are occluded and not actually being composited. State is provided on a per WindowServer connection basis, and as such may produce (safe) false positives. * Shared/ViewState.h: - added IsVisuallyIdle. * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isVisuallyIdle): - added, on mac checks WindowServerConnection. * UIProcess/PageClient.h: (WebKit::PageClient::isVisuallyIdle): - base implementation purely based on isViewVisible. * UIProcess/WebContext.cpp: (WebKit::WebContext::windowServerConnectionStateChanged): - broadcast the state change. * UIProcess/WebContext.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateViewState): (WebKit::WebPageProxy::viewStateDidChange): - propagate IsVisuallyIdle. * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::windowServerConnectionStateChanged): - broadcast the state change. * UIProcess/WebProcessProxy.h: - add windowServerConnectionStateChanged. * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::updateProcessSuppressionStateOfGlobalChildProcesses): - moved from static in fle to static member of class. (WebKit::WebContext::platformInitialize): - no need to enableOcclusionNotifications. (WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess): (WebKit::WebContext::canEnableProcessSuppressionForWebProcess): (WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses): - changed to call WindowServerConnection. (WebKit::WebContext::processSuppressionEnabledChanged): - don't remove/reregister occlusion notifications. * UIProcess/mac/WindowServerConnection.h: Added. (WebKit::WindowServerConnection::applicationIsOccluded): (WebKit::WindowServerConnection::applicationWindowModificationsHaveStopped): - accessors. * UIProcess/mac/WindowServerConnection.mm: Added. (WebKit::WindowServerConnection::applicationBecameOccluded): (WebKit::WindowServerConnection::applicationWindowModificationsStopped): (WebKit::WindowServerConnection::applicationBecameVisible): (WebKit::WindowServerConnection::applicationWindowModificationsStarted): - handle notifications from the WindowServer. (WebKit::WindowServerConnection::windowServerConnectionStateChanged): - broadcast the state change. (WebKit::WindowServerConnection::shared): - accessor for singleton object. (WebKit::WindowServerConnection::WindowServerConnection): - constructor inizializes fields register notification handlers. * WebKit2.xcodeproj/project.pbxproj: - added new files. * config.h: - added HAVE_WINDOW_SERVER_OCCLUSION_NOTIFICATIONS. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/ViewState.h trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.h trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/config.h Added Paths trunk/Source/WebKit2/UIProcess/mac/WindowServerConnection.h trunk/Source/WebKit2/UIProcess/mac/WindowServerConnection.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (161245 => 161246) --- trunk/Source/WebKit2/ChangeLog 2014-01-03 02:00:51 UTC (rev 161245) +++ trunk/Source/WebKit2/ChangeLog 2014-01-03 02:09:25 UTC (rev 161246) @@ -1,5 +1,71 @@ 2014-01-02 Gavin Barraclough barraclo...@apple.com +Propagate WindowServer modifications state to WebProcess +https://bugs.webkit.org/show_bug.cgi?id=126356 + +Reviewed by Sam Weinig. + +This will be necessary to move control of process suppression to the WebProcess. +IsVisuallyIdle implies the process has stopped painting, or painted rects are +occluded and not actually being composited. State is provided on a per +WindowServer connection basis, and as such may produce (safe) false positives. + +* Shared/ViewState.h: +- added IsVisuallyIdle. +* UIProcess/API/mac/PageClientImpl.h: +* UIProcess/API/mac/PageClientImpl.mm: +(WebKit::PageClientImpl::isVisuallyIdle): +- added, on mac checks WindowServerConnection. +* UIProcess/PageClient.h: +(WebKit::PageClient::isVisuallyIdle): +- base
[webkit-changes] [161247] trunk
Title: [161247] trunk
Revision 161247
Author bfulg...@apple.com
Date 2014-01-02 18:11:58 -0800 (Thu, 02 Jan 2014)
Log Message
[WebGL] Correct symbol lookup logic to handle 1-element arrays
https://bugs.webkit.org/show_bug.cgi?id=126411
rdar://problem/15394564
Reviewed by Dean Jackson.
Source/WebCore:
Tested by revisions to webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniformLocation): Revise to
handle access to zeroeth element of the array.
LayoutTests:
* webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Add test for accessing the
single-element array.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (161246 => 161247)
--- trunk/LayoutTests/ChangeLog 2014-01-03 02:09:25 UTC (rev 161246)
+++ trunk/LayoutTests/ChangeLog 2014-01-03 02:11:58 UTC (rev 161247)
@@ -1,3 +1,14 @@
+2014-01-02 Brent Fulgham bfulg...@apple.com
+
+[WebGL] Correct symbol lookup logic to handle 1-element arrays
+https://bugs.webkit.org/show_bug.cgi?id=126411
+rdar://problem/15394564
+
+Reviewed by Dean Jackson.
+
+* webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Add test for accessing the
+single-element array.
+
2014-01-02 Jinwoo Song jinwoo7.s...@samsung.com
Unreviewed EFL gardening. Rebaselining after r161140.
Modified: trunk/LayoutTests/webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html (161246 => 161247)
--- trunk/LayoutTests/webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html 2014-01-03 02:09:25 UTC (rev 161246)
+++ trunk/LayoutTests/webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html 2014-01-03 02:11:58 UTC (rev 161247)
@@ -109,6 +109,8 @@
var program = wtu.setupProgram(gl, [vshader, fshader-with-one-element-arrays], [a_position]);
var green_loc = gl.getUniformLocation(program, u_colors[0].color[0]);
+var zeroth_color = gl.getUniformLocation(program, u_colors[0].color);
+shouldBeTrue(zeroth_color != undefined);
gl.uniform4fv(green_loc, [0, 1, 0, 1]);
wtu.clearAndDrawUnitQuad(gl);
wtu.checkCanvas(gl, [0, 255, 0, 255], Should be green);
Modified: trunk/Source/WebCore/ChangeLog (161246 => 161247)
--- trunk/Source/WebCore/ChangeLog 2014-01-03 02:09:25 UTC (rev 161246)
+++ trunk/Source/WebCore/ChangeLog 2014-01-03 02:11:58 UTC (rev 161247)
@@ -1,3 +1,17 @@
+2014-01-02 Brent Fulgham bfulg...@apple.com
+
+[WebGL] Correct symbol lookup logic to handle 1-element arrays
+https://bugs.webkit.org/show_bug.cgi?id=126411
+rdar://problem/15394564
+
+Reviewed by Dean Jackson.
+
+Tested by revisions to webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::getUniformLocation): Revise to
+handle access to zeroeth element of the array.
+
2014-01-02 Myles C. Maxfield mmaxfi...@apple.com
Crash in WebCore::translateIntersectionPointsToSkipInkBoundaries
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (161246 => 161247)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-01-03 02:09:25 UTC (rev 161246)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-01-03 02:11:58 UTC (rev 161247)
@@ -3174,16 +3174,11 @@
info.name = info.name.left(info.name.length() - 3);
// If it's an array, we need to iterate through each element, appending [index] to the name.
for (GC3Dint index = 0; index info.size; ++index) {
-if (info.size 1) {
-String arrayBrackets = [ + String::number(index) + ];
-String uniformName = info.name + arrayBrackets;
+String arrayBrackets = [ + String::number(index) + ];
+String uniformName = info.name + arrayBrackets;
-if (name == uniformName || name == info.name)
-return WebGLUniformLocation::create(program, uniformLocation, info.type);
-} else {
-if (name == info.name)
-return WebGLUniformLocation::create(program, uniformLocation, info.type);
-}
+if (name == uniformName || name == info.name)
+return WebGLUniformLocation::create(program, uniformLocation, info.type);
}
}
return 0;
[webkit-changes] [161253] trunk/Source/WebKit2
Title: [161253] trunk/Source/WebKit2
Revision 161253
Author zandober...@gmail.com
Date 2014-01-02 23:40:40 -0800 (Thu, 02 Jan 2014)
Log Message
[GTK] Switch from WTF::Function to std::function in WebProcessTest
https://bugs.webkit.org/show_bug.cgi?id=126397
Reviewed by Anders Carlsson.
Use std::function and std::bind() instead of WTF::Function and WTF::bind,
following the effort of using STL concepts where possible.
* UIProcess/API/gtk/tests/WebProcessTest.cpp:
(WebProcessTest::add):
* UIProcess/API/gtk/tests/WebProcessTest.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (161252 => 161253)
--- trunk/Source/WebKit2/ChangeLog 2014-01-03 05:21:57 UTC (rev 161252)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-03 07:40:40 UTC (rev 161253)
@@ -1,3 +1,17 @@
+2014-01-02 Zan Dobersek zdober...@igalia.com
+
+[GTK] Switch from WTF::Function to std::function in WebProcessTest
+https://bugs.webkit.org/show_bug.cgi?id=126397
+
+Reviewed by Anders Carlsson.
+
+Use std::function and std::bind() instead of WTF::Function and WTF::bind,
+following the effort of using STL concepts where possible.
+
+* UIProcess/API/gtk/tests/WebProcessTest.cpp:
+(WebProcessTest::add):
+* UIProcess/API/gtk/tests/WebProcessTest.h:
+
2014-01-02 Gavin Barraclough barraclo...@apple.com
Propagate WindowServer modifications state to WebProcess
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp (161252 => 161253)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp 2014-01-03 05:21:57 UTC (rev 161252)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp 2014-01-03 07:40:40 UTC (rev 161253)
@@ -23,16 +23,16 @@
#include gio/gio.h
#include wtf/gobject/GOwnPtr.h
-typedef HashMapString, FunctionPassOwnPtrWebProcessTest() TestsMap;
+typedef HashMapString, std::functionPassOwnPtrWebProcessTest () TestsMap;
static TestsMap testsMap()
{
DEFINE_STATIC_LOCAL(TestsMap, s_testsMap, ());
return s_testsMap;
}
-void WebProcessTest::add(const String testName, FunctionPassOwnPtrWebProcessTest() closure)
+void WebProcessTest::add(const String testName, std::functionPassOwnPtrWebProcessTest () closure)
{
-testsMap().add(testName, closure);
+testsMap().add(testName, std::forwardstd::functionPassOwnPtrWebProcessTest ()(closure));
}
PassOwnPtrWebProcessTest WebProcessTest::create(const String testName)
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h (161252 => 161253)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h 2014-01-03 05:21:57 UTC (rev 161252)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h 2014-01-03 07:40:40 UTC (rev 161253)
@@ -18,7 +18,6 @@
*/
#include webkit2/webkit-web-extension.h
-#include wtf/Functional.h
#include wtf/HashMap.h
#include wtf/PassOwnPtr.h
#include wtf/gobject/GRefPtr.h
@@ -30,10 +29,10 @@
virtual ~WebProcessTest() { }
virtual bool runTest(const char* testName, WebKitWebExtension*, GVariant* args) = 0;
-static void add(const String testName, FunctionPassOwnPtrWebProcessTest());
+static void add(const String testName, std::functionPassOwnPtrWebProcessTest ());
static PassOwnPtrWebProcessTest create(const String testName);
};
#define REGISTER_TEST(ClassName, TestName) \
-WebProcessTest::add(String::fromUTF8(TestName), WTF::bind(ClassName::create))
+WebProcessTest::add(String::fromUTF8(TestName), ClassName::create)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161255] trunk
Title: [161255] trunk Revision 161255 Author carlo...@webkit.org Date 2014-01-02 23:56:55 -0800 (Thu, 02 Jan 2014) Log Message REGRESSION(r160304): [GTK] Disable libtool fast install https://bugs.webkit.org/show_bug.cgi?id=126381 Reviewed by Martin Robinson. .: After r160304 we are building some of our binaries that are installed with the -no-fast-install ld flag. This makes that the binaries are installed with the source code path hardcoded in binary RPATH. Disabling fast install globally, the libtool script always relinks the binaries right before being installed. * Source/autotools/SetupLibtool.m4: Add AC_DISABLE_FAST_INSTALL. Source/_javascript_Core: Remove -no-fast-install ld flag since fast install is now disabled globally. * GNUmakefile.am: Source/WebKit/gtk: * tests/GNUmakefile.am: Source/WebKit2: Remove -no-fast-install ld flag since fast install is now disabled globally. * GNUmakefile.am: * UIProcess/API/gtk/tests/GNUmakefile.am: Tools: Remove -no-fast-install ld flag since fast install is now disabled globally. * GNUmakefile.am: * GtkLauncher/GNUmakefile.am: * MiniBrowser/gtk/GNUmakefile.am: * TestWebKitAPI/GNUmakefile.am: * WebKitTestRunner/GNUmakefile.am: Modified Paths trunk/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.am trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/tests/GNUmakefile.am trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am trunk/Source/autotools/SetupLibtool.m4 trunk/Tools/ChangeLog trunk/Tools/GNUmakefile.am trunk/Tools/GtkLauncher/GNUmakefile.am trunk/Tools/MiniBrowser/gtk/GNUmakefile.am trunk/Tools/TestWebKitAPI/GNUmakefile.am trunk/Tools/WebKitTestRunner/GNUmakefile.am Diff Modified: trunk/ChangeLog (161254 => 161255) --- trunk/ChangeLog 2014-01-03 07:48:05 UTC (rev 161254) +++ trunk/ChangeLog 2014-01-03 07:56:55 UTC (rev 161255) @@ -1,3 +1,18 @@ +2014-01-02 Carlos Garcia Campos cgar...@igalia.com + +REGRESSION(r160304): [GTK] Disable libtool fast install +https://bugs.webkit.org/show_bug.cgi?id=126381 + +Reviewed by Martin Robinson. + +After r160304 we are building some of our binaries that are +installed with the -no-fast-install ld flag. This makes that the +binaries are installed with the source code path hardcoded in +binary RPATH. Disabling fast install globally, the libtool script +always relinks the binaries right before being installed. + +* Source/autotools/SetupLibtool.m4: Add AC_DISABLE_FAST_INSTALL. + 2014-01-02 Jaehun Lim ljaehun@samsung.com [CMake][EFL] Fix some typos in OptionsEfl.cmake Modified: trunk/Source/_javascript_Core/ChangeLog (161254 => 161255) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-03 07:48:05 UTC (rev 161254) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-03 07:56:55 UTC (rev 161255) @@ -1,3 +1,15 @@ +2014-01-02 Carlos Garcia Campos cgar...@igalia.com + +REGRESSION(r160304): [GTK] Disable libtool fast install +https://bugs.webkit.org/show_bug.cgi?id=126381 + +Reviewed by Martin Robinson. + +Remove -no-fast-install ld flag since fast install is now disabled +globally. + +* GNUmakefile.am: + 2014-01-02 Sam Weinig s...@webkit.org Update Promises to the https://github.com/domenic/promises-unwrapping spec Modified: trunk/Source/_javascript_Core/GNUmakefile.am (161254 => 161255) --- trunk/Source/_javascript_Core/GNUmakefile.am 2014-01-03 07:48:05 UTC (rev 161254) +++ trunk/Source/_javascript_Core/GNUmakefile.am 2014-01-03 07:56:55 UTC (rev 161255) @@ -131,8 +131,7 @@ -lstdc++ Programs_minidom_LDFLAGS = \ - -no-install \ - -no-fast-install + -no-install Programs_LLIntOffsetsExtractor_CPPFLAGS = \ $(global_cppflags) \ @@ -155,8 +154,7 @@ -lstdc++ Programs_LLIntOffsetsExtractor_LDFLAGS = \ - -no-install \ - -no-fast-install + -no-install # jsc Programs/jsc$(EXEEXT): Programs/jsc-@WEBKITGTK_API_MAJOR_VERSION@$(EXEEXT) Modified: trunk/Source/WebKit/gtk/ChangeLog (161254 => 161255) --- trunk/Source/WebKit/gtk/ChangeLog 2014-01-03 07:48:05 UTC (rev 161254) +++ trunk/Source/WebKit/gtk/ChangeLog 2014-01-03 07:56:55 UTC (rev 161255) @@ -1,3 +1,12 @@ +2014-01-02 Carlos Garcia Campos cgar...@igalia.com + +REGRESSION(r160304): [GTK] Disable libtool fast install +https://bugs.webkit.org/show_bug.cgi?id=126381 + +Reviewed by Martin Robinson. + +* tests/GNUmakefile.am: + 2014-01-02 Gavin Barraclough barraclo...@apple.com Merge didMoveOnscreen / page visibility to isVisible Modified: trunk/Source/WebKit/gtk/tests/GNUmakefile.am (161254 => 161255) --- trunk/Source/WebKit/gtk/tests/GNUmakefile.am 2014-01-03 07:48:05 UTC (rev 161254) +++ trunk/Source/WebKit/gtk/tests/GNUmakefile.am 2014-01-03 07:56:55 UTC (rev 161255) @@ -27,8 +27,7 @@ $(XRENDER_LIBS)
