[webkit-changes] [202540] trunk/Source/WebKit2

[simon . fraser]

Title: [202540] trunk/Source/WebKit2








Revision 202540
Author simon.fra...@apple.com
Date 2016-06-27 22:56:04 -0700 (Mon, 27 Jun 2016)


Log Message
Fix TestWebKitAPI crash introduced in r202532.

WebPageProxy::forceRepaint() could trigger a call to the didForceRepaintCallback()
after the WebPageProxy had been invalidated, causing a null de-ref of m_drawingArea.
Fix by checking for error and isValid().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (202539 => 202540)

--- trunk/Source/WebKit2/ChangeLog	2016-06-28 05:10:30 UTC (rev 202539)
+++ trunk/Source/WebKit2/ChangeLog	2016-06-28 05:56:04 UTC (rev 202540)
@@ -1,5 +1,16 @@
 2016-06-27  Simon Fraser  
 
+Fix TestWebKitAPI crash introduced in r202532.
+
+WebPageProxy::forceRepaint() could trigger a call to the didForceRepaintCallback()
+after the WebPageProxy had been invalidated, causing a null de-ref of m_drawingArea.
+Fix by checking for error and isValid().
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::forceRepaint):
+
+2016-06-27  Simon Fraser  
+
 [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
 https://bugs.webkit.org/show_bug.cgi?id=159077
 


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (202539 => 202540)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-06-28 05:10:30 UTC (rev 202539)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-06-28 05:56:04 UTC (rev 202540)
@@ -2889,6 +2889,16 @@
 }
 
 std::function didForceRepaintCallback = [this, callback](CallbackBase::Error error) {
+if (error != CallbackBase::Error::None) {
+callback->invalidate(error);
+return;
+}
+
+if (!isValid()) {
+callback->invalidate(CallbackBase::Error::OwnerWasInvalidated);
+return;
+}
+
 callAfterNextPresentationUpdate([callback](CallbackBase::Error error) {
 if (error != CallbackBase::Error::None) {
 callback->invalidate(error);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202539] trunk

[cdumez]

Title: [202539] trunk








Revision 202539
Author cdu...@apple.com
Date 2016-06-27 22:10:30 -0700 (Mon, 27 Jun 2016)


Log Message
HTMLElement / SVGElement should implement GlobalEventHandlers, not Element
https://bugs.webkit.org/show_bug.cgi?id=159191


Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

HTMLElement / SVGElement should implement GlobalEventHandlers, not Element:
- https://html.spec.whatwg.org/multipage/dom.html#htmlelement
- https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement

Firefox and Chrome behave as per the specification.

Fixing this also fixes rendering on http://survey123.arcgis.com/.

No new tests, covered by existing tests that were rebaselined.

* dom/Element.idl:
* html/HTMLElement.idl:
* svg/SVGElement.idl:

LayoutTests:

* fast/dom/event-handler-attributes-expected.txt:
Rebaseline tests now that more checks are passing.

* js/dom/dom-static-property-for-in-iteration-expected.txt:
Rebaseline test now that enumeration order is different.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/html/HTMLElement.idl
trunk/Source/WebCore/svg/SVGElement.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (202538 => 202539)

--- trunk/LayoutTests/ChangeLog	2016-06-28 04:04:48 UTC (rev 202538)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 05:10:30 UTC (rev 202539)
@@ -1,3 +1,17 @@
+2016-06-27  Chris Dumez  
+
+HTMLElement / SVGElement should implement GlobalEventHandlers, not Element
+https://bugs.webkit.org/show_bug.cgi?id=159191
+
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/event-handler-attributes-expected.txt:
+Rebaseline tests now that more checks are passing.
+
+* js/dom/dom-static-property-for-in-iteration-expected.txt:
+Rebaseline test now that enumeration order is different.
+
 2016-06-27  Simon Fraser  
 
 [iOS] -webkit-overflow-scrolling: touch prevents repaint with RTL


Modified: trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt (202538 => 202539)

--- trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt	2016-06-28 04:04:48 UTC (rev 202538)
+++ trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt	2016-06-28 05:10:30 UTC (rev 202539)
@@ -854,7 +854,7 @@
 
 Event names on a non-HTML element
 
-FAIL testElementAttribute(nonHTMLElement, "abort") should be none. Was script: target; content: none.
+PASS testElementAttribute(nonHTMLElement, "abort") is "none"
 FAIL testElementAttribute(nonHTMLElement, "animationend") should be none. Was script: target; content: none.
 FAIL testElementAttribute(nonHTMLElement, "animationiteration") should be none. Was script: target; content: none.
 FAIL testElementAttribute(nonHTMLElement, "animationstart") should be none. Was script: target; content: none.
@@ -863,48 +863,48 @@
 FAIL testElementAttribute(nonHTMLElement, "beforeload") should be none. Was script: target; content: none.
 FAIL testElementAttribute(nonHTMLElement, "beforepaste") should be none. Was script: target; content: none.
 PASS testElementAttribute(nonHTMLElement, "beforeunload") is "none"
-FAIL testElementAttribute(nonHTMLElement, "blur") should be none. Was script: target; content: none.
-FAIL testElementAttribute(nonHTMLElement, "canplay") should be none. Was script: target; content: none.
-FAIL testElementAttribute(nonHTMLElement, "canplaythrough") should be none. Was script: target; content: none.
-FAIL testElementAttribute(nonHTMLElement, "change") should be none. Was script: target; content: none.
-FAIL testElementAttribute(nonHTMLElement, "click") should be none. Was script: target; content: none.
-FAIL testElementAttribute(nonHTMLElement, "contextmenu") should be none. Was script: target; content: none.
+PASS testElementAttribute(nonHTMLElement, "blur") is "none"
+PASS testElementAttribute(nonHTMLElement, "canplay") is "none"
+PASS testElementAttribute(nonHTMLElement, "canplaythrough") is "none"
+PASS testElementAttribute(nonHTMLElement, "change") is "none"
+PASS testElementAttribute(nonHTMLElement, "click") is "none"
+PASS testElementAttribute(nonHTMLElement, "contextmenu") is "none"
 FAIL testElementAttribute(nonHTMLElement, "copy") should be none. Was script: target; content: none.
 FAIL testElementAttribute(nonHTMLElement, "cut") should be none. Was script: target; content: none.
-FAIL testElementAttribute(nonHTMLElement, "dblclick") should be none. Was script: target; content: none.
-FAIL testElementAttribute(nonHTMLElement, "drag") should be 

[webkit-changes] [202538] trunk/Source/WebCore

[mmaxfield]

Title: [202538] trunk/Source/WebCore








Revision 202538
Author mmaxfi...@apple.com
Date 2016-06-27 21:04:48 -0700 (Mon, 27 Jun 2016)


Log Message
[macOS] Test gardening: Generic font families should not map to fonts which aren't installed
https://bugs.webkit.org/show_bug.cgi?id=159111


Unreviewed.

Osaka-Mono does not come preinstalled on macOS Sierra. However, many Japanese users
will have the font installed. Before setting the generic font family, we should check
to see if the font is present.

* page/cocoa/SettingsCocoa.mm:
(WebCore::osakaMonoIsInstalled):
(WebCore::Settings::initializeDefaultFontFamilies):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/cocoa/SettingsCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (202537 => 202538)

--- trunk/Source/WebCore/ChangeLog	2016-06-28 03:25:47 UTC (rev 202537)
+++ trunk/Source/WebCore/ChangeLog	2016-06-28 04:04:48 UTC (rev 202538)
@@ -1,3 +1,19 @@
+2016-06-27  Myles C. Maxfield  
+
+[macOS] Test gardening: Generic font families should not map to fonts which aren't installed
+https://bugs.webkit.org/show_bug.cgi?id=159111
+
+
+Unreviewed.
+
+Osaka-Mono does not come preinstalled on macOS Sierra. However, many Japanese users
+will have the font installed. Before setting the generic font family, we should check
+to see if the font is present.
+
+* page/cocoa/SettingsCocoa.mm:
+(WebCore::osakaMonoIsInstalled):
+(WebCore::Settings::initializeDefaultFontFamilies):
+
 2016-06-24  Ryosuke Niwa  
 
 Don't keep all newly created potential custom elements alive when the feature is disabled


Modified: trunk/Source/WebCore/page/cocoa/SettingsCocoa.mm (202537 => 202538)

--- trunk/Source/WebCore/page/cocoa/SettingsCocoa.mm	2016-06-28 03:25:47 UTC (rev 202537)
+++ trunk/Source/WebCore/page/cocoa/SettingsCocoa.mm	2016-06-28 04:04:48 UTC (rev 202538)
@@ -51,6 +51,18 @@
 
 #if PLATFORM(MAC)
 
+static bool osakaMonoIsInstalled()
+{
+int _one_ = 1;
+RetainPtr yes = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, ));
+CFTypeRef keys[] = { kCTFontEnabledAttribute, kCTFontNameAttribute };
+CFTypeRef values[] = { yes.get(), CFSTR("Osaka-Mono") };
+RetainPtr attributes = adoptCF(CFDictionaryCreate(kCFAllocatorDefault, keys, values, WTF_ARRAY_LENGTH(values), , ));
+RetainPtr descriptor = adoptCF(CTFontDescriptorCreateWithAttributes(attributes.get()));
+RetainPtr mandatoryAttributes = adoptCF(CFSetCreate(kCFAllocatorDefault, keys, WTF_ARRAY_LENGTH(keys), ));
+return adoptCF(CTFontDescriptorCreateMatchingFontDescriptor(descriptor.get(), mandatoryAttributes.get()));
+}
+
 void Settings::initializeDefaultFontFamilies()
 {
 setStandardFontFamily("Songti TC", USCRIPT_TRADITIONAL_HAN);
@@ -64,7 +76,7 @@
 setSansSerifFontFamily(sansSerifSimplifiedHanFontFamily(), USCRIPT_SIMPLIFIED_HAN);
 
 setStandardFontFamily("Hiragino Mincho ProN", USCRIPT_KATAKANA_OR_HIRAGANA);
-setFixedFontFamily("Osaka-Mono", USCRIPT_KATAKANA_OR_HIRAGANA);
+setFixedFontFamily(osakaMonoIsInstalled() ? "Osaka-Mono" : "Hiragino Sans", USCRIPT_KATAKANA_OR_HIRAGANA);
 setSerifFontFamily("Hiragino Mincho ProN", USCRIPT_KATAKANA_OR_HIRAGANA);
 setSansSerifFontFamily("Hiragino Kaku Gothic ProN", USCRIPT_KATAKANA_OR_HIRAGANA);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202537] trunk/Source/WebCore

[rniwa]

Title: [202537] trunk/Source/WebCore








Revision 202537
Author rn...@webkit.org
Date 2016-06-27 20:25:47 -0700 (Mon, 27 Jun 2016)


Log Message
Don't keep all newly created potential custom elements alive when the feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=159113

Reviewed by Daniel Bates.

Don't keep all HTML unknown elements which has a valid custom element alive when the feature is turned off.

Ideally we want to conform to the behavior in the Custom Elements specification and only upgrade an element
that is inserted into the document. We'll implement that later.

* dom/Document.cpp:
(WebCore::createHTMLElementWithNameValidation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (202536 => 202537)

--- trunk/Source/WebCore/ChangeLog	2016-06-28 02:58:16 UTC (rev 202536)
+++ trunk/Source/WebCore/ChangeLog	2016-06-28 03:25:47 UTC (rev 202537)
@@ -1,3 +1,18 @@
+2016-06-24  Ryosuke Niwa  
+
+Don't keep all newly created potential custom elements alive when the feature is disabled
+https://bugs.webkit.org/show_bug.cgi?id=159113
+
+Reviewed by Daniel Bates.
+
+Don't keep all HTML unknown elements which has a valid custom element alive when the feature is turned off.
+
+Ideally we want to conform to the behavior in the Custom Elements specification and only upgrade an element
+that is inserted into the document. We'll implement that later.
+
+* dom/Document.cpp:
+(WebCore::createHTMLElementWithNameValidation):
+
 2016-06-27  Simon Fraser  
 
 [iOS] -webkit-overflow-scrolling: touch prevents repaint with RTL


Modified: trunk/Source/WebCore/dom/Document.cpp (202536 => 202537)

--- trunk/Source/WebCore/dom/Document.cpp	2016-06-28 02:58:16 UTC (rev 202536)
+++ trunk/Source/WebCore/dom/Document.cpp	2016-06-28 03:25:47 UTC (rev 202537)
@@ -896,7 +896,8 @@
 QualifiedName qualifiedName(nullAtom, localName, xhtmlNamespaceURI);
 
 #if ENABLE(CUSTOM_ELEMENTS)
-if (Document::validateCustomElementName(localName) == CustomElementNameValidationStatus::Valid) {
+if (RuntimeEnabledFeatures::sharedFeatures().customElementsEnabled()
+&& Document::validateCustomElementName(localName) == CustomElementNameValidationStatus::Valid) {
 Ref element = HTMLElement::create(qualifiedName, document);
 element->setIsUnresolvedCustomElement();
 document.ensureCustomElementDefinitions().addUpgradeCandidate(element.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202536] trunk

[simon . fraser]

Title: [202536] trunk








Revision 202536
Author simon.fra...@apple.com
Date 2016-06-27 19:58:16 -0700 (Mon, 27 Jun 2016)


Log Message
[iOS] -webkit-overflow-scrolling: touch prevents repaint with RTL
https://bugs.webkit.org/show_bug.cgi?id=159186
rdar://problem/26659341

Reviewed by Zalan Bujtas.
Source/WebCore:

There were two issues with repaints in -webkit-overflow-scrolling:touch scrolling
layers.

First, if the scrolled contents were inline (e.g. a ), then repaints were
broken because RenderInline didn't call shouldApplyClipAndScrollPositionForRepaint().
Fix by making shouldApplyClipAndScrollPositionForRepaint() a member function of RenderBox
and calling it from RenderBox::computeRectForRepaint() and RenderInline::clippedOverflowRectForRepaint().

Second, repaints were broken in RTL because RenderLayerBacking::setContentsNeedDisplayInRect()
confused scroll offset and scroll position; it needs to subtract scrollPosition.

Finally renamed to applyCachedClipAndScrollOffsetForRepaint() to applyCachedClipAndScrollPositionForRepaint()
to make it clear that it uses scrollPosition, not scrollOffset.

Tests: compositing/scrolling/touch-scrolling-repaint-spans.html
   compositing/scrolling/touch-scrolling-repaint.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollPositionForRepaint):
(WebCore::RenderBox::shouldApplyClipAndScrollPositionForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint): Deleted.
(WebCore::shouldApplyContainersClipAndOffset): Deleted.
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):

LayoutTests:

* compositing/scrolling/touch-scrolling-repaint-expected.html: Added.
* compositing/scrolling/touch-scrolling-repaint-spans-expected.html: Added.
* compositing/scrolling/touch-scrolling-repaint-spans.html: Added.
* compositing/scrolling/touch-scrolling-repaint.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp


Added Paths

trunk/LayoutTests/compositing/scrolling/touch-scrolling-repaint-expected.html
trunk/LayoutTests/compositing/scrolling/touch-scrolling-repaint-spans-expected.html
trunk/LayoutTests/compositing/scrolling/touch-scrolling-repaint-spans.html
trunk/LayoutTests/compositing/scrolling/touch-scrolling-repaint.html




Diff

Modified: trunk/LayoutTests/ChangeLog (202535 => 202536)

--- trunk/LayoutTests/ChangeLog	2016-06-28 02:47:23 UTC (rev 202535)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 02:58:16 UTC (rev 202536)
@@ -1,5 +1,18 @@
 2016-06-27  Simon Fraser  
 
+[iOS] -webkit-overflow-scrolling: touch prevents repaint with RTL
+https://bugs.webkit.org/show_bug.cgi?id=159186
+rdar://problem/26659341
+
+Reviewed by Zalan Bujtas.
+
+* compositing/scrolling/touch-scrolling-repaint-expected.html: Added.
+* compositing/scrolling/touch-scrolling-repaint-spans-expected.html: Added.
+* compositing/scrolling/touch-scrolling-repaint-spans.html: Added.
+* compositing/scrolling/touch-scrolling-repaint.html: Added.
+
+2016-06-27  Simon Fraser  
+
 [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
 https://bugs.webkit.org/show_bug.cgi?id=159077
 


Added: trunk/LayoutTests/compositing/scrolling/touch-scrolling-repaint-expected.html (0 => 202536)

--- trunk/LayoutTests/compositing/scrolling/touch-scrolling-repaint-expected.html	(rev 0)
+++ trunk/LayoutTests/compositing/scrolling/touch-scrolling-repaint-expected.html	2016-06-28 02:58:16 UTC (rev 202536)
@@ -0,0 +1,51 @@
+
+
+
+
+
+.scroller {
+margin: 10px;
+width: 300px;
+padding: 10px;
+overflow-y: hidden;
+overflow-x: scroll;
+border: 8px solid black;
+-webkit-overflow-scrolling: touch;
+}
+
+.contents {
+height: 100px;
+width: 480px;
+background-color: green;
+letter-spacing: 12px;
+color: white;
+font-size: 28pt;
+}
+
+
+function doTest()
+{
+document.getElementById('scroller2').scrollLeft = 120;
+document.getElementById('scroller4').scrollLeft = 

[webkit-changes] [202535] trunk/Tools

[mcatanzaro]

Title: [202535] trunk/Tools








Revision 202535
Author mcatanz...@igalia.com
Date 2016-06-27 19:47:23 -0700 (Mon, 27 Jun 2016)


Log Message
[GTK][EFL] Disable subtle-crypto in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=155073

Reviewed by Daniel Bates.

* Scripts/webkitperl/FeatureList.pm:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm




Diff

Modified: trunk/Tools/ChangeLog (202534 => 202535)

--- trunk/Tools/ChangeLog	2016-06-28 02:38:16 UTC (rev 202534)
+++ trunk/Tools/ChangeLog	2016-06-28 02:47:23 UTC (rev 202535)
@@ -1,3 +1,12 @@
+2016-06-27  Michael Catanzaro  
+
+[GTK][EFL] Disable subtle-crypto in FeatureList.pm
+https://bugs.webkit.org/show_bug.cgi?id=155073
+
+Reviewed by Daniel Bates.
+
+* Scripts/webkitperl/FeatureList.pm:
+
 2016-06-27  Simon Fraser  
 
 [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting


Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (202534 => 202535)

--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-06-28 02:38:16 UTC (rev 202534)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-06-28 02:47:23 UTC (rev 202535)
@@ -395,7 +395,7 @@
   define => "ENABLE_STREAMS_API", default => 1, value => \$streamsAPISupport },
 
 { option => "subtle-crypto", desc => "Toggle WebCrypto Subtle-Crypto support",
-  define => "ENABLE_SUBTLE_CRYPTO", default => (isGtk() || isEfl() || isAppleMacWebKit() || isIOSWebKit()), value => \$subtleCrypto },
+  define => "ENABLE_SUBTLE_CRYPTO", default => (isAppleMacWebKit() || isIOSWebKit()), value => \$subtleCrypto },
 
 { option => "svg-fonts", desc => "Toggle SVG Fonts support",
   define => "ENABLE_SVG_FONTS", default => 1, value => \$svgFontsSupport },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202534] trunk/Websites/webkit.org

[dino]

Title: [202534] trunk/Websites/webkit.org








Revision 202534
Author d...@apple.com
Date 2016-06-27 19:38:16 -0700 (Mon, 27 Jun 2016)


Log Message
Updated content for the color blog post.

* blog-files/color-gamut/Iceland-P3.jpg:
* blog-files/color-gamut/Iceland-oog.jpg:
* blog-files/color-gamut/Iceland-sRGB.jpg:
* blog-files/color-gamut/Italy-P3.jpg:
* blog-files/color-gamut/Italy-sRGB.jpg:
* blog-files/color-gamut/Sunset-P3.jpg:
* blog-files/color-gamut/Sunset-sRGB.jpg:
* blog-files/color-gamut/YellowFlower-P3.jpg:
* blog-files/color-gamut/YellowFlower-oog.jpg:
* blog-files/color-gamut/YellowFlower-sRGB.jpg:
* blog-files/color-gamut/index.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/blog-files/color-gamut/Iceland-P3.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/Iceland-oog.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/Iceland-sRGB.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/Italy-P3.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/Italy-sRGB.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/Sunset-P3.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/Sunset-sRGB.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/YellowFlower-P3.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/YellowFlower-oog.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/YellowFlower-sRGB.jpg
trunk/Websites/webkit.org/blog-files/color-gamut/index.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (202533 => 202534)

--- trunk/Websites/webkit.org/ChangeLog	2016-06-28 02:00:59 UTC (rev 202533)
+++ trunk/Websites/webkit.org/ChangeLog	2016-06-28 02:38:16 UTC (rev 202534)
@@ -1,3 +1,19 @@
+2016-06-27  Dean Jackson  
+
+Updated content for the color blog post.
+
+* blog-files/color-gamut/Iceland-P3.jpg:
+* blog-files/color-gamut/Iceland-oog.jpg:
+* blog-files/color-gamut/Iceland-sRGB.jpg:
+* blog-files/color-gamut/Italy-P3.jpg:
+* blog-files/color-gamut/Italy-sRGB.jpg:
+* blog-files/color-gamut/Sunset-P3.jpg:
+* blog-files/color-gamut/Sunset-sRGB.jpg:
+* blog-files/color-gamut/YellowFlower-P3.jpg:
+* blog-files/color-gamut/YellowFlower-oog.jpg:
+* blog-files/color-gamut/YellowFlower-sRGB.jpg:
+* blog-files/color-gamut/index.html:
+
 2016-06-27  Jon Davis  
 
 Set a default image for sharing webkit.org links via social.


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/Iceland-P3.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/Iceland-oog.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/Iceland-sRGB.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/Italy-P3.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/Italy-sRGB.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/Sunset-P3.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/Sunset-sRGB.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/YellowFlower-P3.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/YellowFlower-oog.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/YellowFlower-sRGB.jpg

(Binary files differ)


Modified: trunk/Websites/webkit.org/blog-files/color-gamut/index.html (202533 => 202534)

--- trunk/Websites/webkit.org/blog-files/color-gamut/index.html	2016-06-28 02:00:59 UTC (rev 202533)
+++ trunk/Websites/webkit.org/blog-files/color-gamut/index.html	2016-06-28 02:38:16 UTC (rev 202534)
@@ -194,10 +194,10 @@
   
 
 
-Comparision between normal and wide-gamut images
+Comparison between normal and wide-gamut images
 
 
-Here are some example images to demonstrate wide-gamut. There
+Below are example images to demonstrate wide-gamut. There
 are multiple versions of each image: one in sRGB, which is the
 typical color space we've been using on the Web for years, then
 some in other color spaces with a wider gamut, and then a version
@@ -217,9 +217,8 @@
 
 
 If you're not using a wide-gamut display to view these images,
-the different versions should look nearly identical. You'll have
-to rely on the version that highlights pixels to get an idea of
-what parts of the image would be different.
+the different versions should quite similar, although color
+matching might produce a small difference.
 
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202533] trunk/Source/WebCore

[commit-queue]

Title: [202533] trunk/Source/WebCore








Revision 202533
Author commit-qu...@webkit.org
Date 2016-06-27 19:00:59 -0700 (Mon, 27 Jun 2016)


Log Message
Unreviewed, rolling out r202436.
https://bugs.webkit.org/show_bug.cgi?id=159190

We don't need to make this change. (Requested by thorton on
#webkit).

Reverted changeset:

"Do not use iOS specific telephone detection on macOS."
https://bugs.webkit.org/show_bug.cgi?id=159096
http://trac.webkit.org/changeset/202436

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/TelephoneNumberDetectorCocoa.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (202532 => 202533)

--- trunk/Source/WebCore/ChangeLog	2016-06-28 01:44:41 UTC (rev 202532)
+++ trunk/Source/WebCore/ChangeLog	2016-06-28 02:00:59 UTC (rev 202533)
@@ -1,3 +1,17 @@
+2016-06-27  Commit Queue  
+
+Unreviewed, rolling out r202436.
+https://bugs.webkit.org/show_bug.cgi?id=159190
+
+We don't need to make this change. (Requested by thorton on
+#webkit).
+
+Reverted changeset:
+
+"Do not use iOS specific telephone detection on macOS."
+https://bugs.webkit.org/show_bug.cgi?id=159096
+http://trac.webkit.org/changeset/202436
+
 2016-06-27  Benjamin Poulain  
 
 Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch


Modified: trunk/Source/WebCore/platform/cocoa/TelephoneNumberDetectorCocoa.cpp (202532 => 202533)

--- trunk/Source/WebCore/platform/cocoa/TelephoneNumberDetectorCocoa.cpp	2016-06-28 01:44:41 UTC (rev 202532)
+++ trunk/Source/WebCore/platform/cocoa/TelephoneNumberDetectorCocoa.cpp	2016-06-28 02:00:59 UTC (rev 202533)
@@ -47,7 +47,6 @@
 
 static DDDFAScannerRef phoneNumbersScanner()
 {
-#if PLATFORM(IOS)
 if (!DataDetectorsCoreLibrary())
 return nullptr;
 
@@ -57,9 +56,6 @@
 
 static DDDFAScannerRef scanner = DDDFAScannerCreateFromCache(cache);
 return scanner;
-#else
-return nullptr;
-#endif
 }
 
 bool isSupported()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202532] trunk

[simon . fraser]

Title: [202532] trunk








Revision 202532
Author simon.fra...@apple.com
Date 2016-06-27 18:44:41 -0700 (Mon, 27 Jun 2016)


Log Message
[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
https://bugs.webkit.org/show_bug.cgi?id=159077

Reviewed by Tim Horton.

Source/WebKit2:

Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
which is necessary for UI-side compositing.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):

Tools:

Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.

Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
which is necessary for UI-side compositing.

Add some null checks to fix issues when the WKWebView gets resized to be empty, which
seems to happen for some tests that call window.resizeTo().

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Deleted.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpResults):
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
(WTR::computeMD5HashStringForContext):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage):

LayoutTests:

fast/harness/snapshot-captures-compositing.html passes now.

* platform/ios-simulator-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp
trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (202531 => 202532)

--- trunk/LayoutTests/ChangeLog	2016-06-28 01:13:53 UTC (rev 202531)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 01:44:41 UTC (rev 202532)
@@ -1,3 +1,14 @@
+2016-06-27  Simon Fraser  
+
+[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
+https://bugs.webkit.org/show_bug.cgi?id=159077
+
+Reviewed by Tim Horton.
+
+fast/harness/snapshot-captures-compositing.html passes now.
+
+* platform/ios-simulator-wk2/TestExpectations:
+
 2016-06-27  Benjamin Poulain  
 
 Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (202531 => 202532)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-06-28 01:13:53 UTC (rev 202531)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-06-28 01:44:41 UTC (rev 202532)
@@ -1899,5 +1899,3 @@
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
 
 webkit.org/b/157990 [ Release ] mathml/wbr-in-mroot-crash.html [ Pass Timeout ]
-
-webkit.org/b/159077 fast/harness/snapshot-captures-compositing.html [ ImageOnlyFailure ]


Modified: trunk/Source/WebKit2/ChangeLog (202531 => 202532)

--- trunk/Source/WebKit2/ChangeLog	2016-06-28 01:13:53 UTC (rev 202531)
+++ trunk/Source/WebKit2/ChangeLog	2016-06-28 01:44:41 UTC (rev 202532)
@@ -1,3 +1,16 @@
+2016-06-27  Simon Fraser  
+
+[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
+https://bugs.webkit.org/show_bug.cgi?id=159077
+
+Reviewed by Tim Horton.
+
+Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
+which is necessary for UI-side compositing.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::forceRepaint):
+
 2016-06-27  Joseph Pecoraro  
 
 Web Inspector: When modifying sessionStorage, localStorage gets updated


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (202531 => 202532)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-06-28 01:13:53 UTC (rev 202531)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-06-28 01:44:41 UTC (rev 202532)
@@ -2888,8 +2888,18 @@
 return;
 }
 
-uint64_t callbackID = callback->callbackID();
-m_callbacks.put(callback);
+std::function didForceRepaintCallback = [this, callback](CallbackBase::Error error) {
+callAfterNextPresentationUpdate([callback](CallbackBase::Error error) {
+if (error != CallbackBase::Error::None) {
+callback->invalidate(error);
+return;
+}
+
+callback->performCallback();
+});
+};
+
+uint64_t callbackID = m_callbacks.put(didForceRepaintCallback, m_process->throttler().backgroundActivityToken());
 

[webkit-changes] [202531] trunk

[benjamin]

Title: [202531] trunk








Revision 202531
Author benja...@webkit.org
Date 2016-06-27 18:13:53 -0700 (Mon, 27 Jun 2016)


Log Message
Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch
https://bugs.webkit.org/show_bug.cgi?id=159179
rdar://problem/27006387

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html
   fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html
   fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html
   fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html
   fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html
   fast/events/touch/ios/drag-block-without-overflow-scroll.html

* dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
(WebCore::Document::removeAllEventListeners):
* dom/Node.cpp:
(WebCore::Node::willBeDeletedFrom):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::registerForTouchEvents):
(WebCore::SliderThumbElement::unregisterForTouchEvents):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::registerAsTouchEventListenerForScrolling):
(WebCore::RenderLayer::unregisterAsTouchEventListenerForScrolling):

LayoutTests:

Several of those tests expose existing bugs with overflow scrolling.
They are not using PASS/FAIL at the moment, just dump the called listeners.

* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt: Added.
* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html: Added.
* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt: Added.
* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html: Added.
* fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt: Added.
* fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html: Added.
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt: Added.
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html: Added.
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt: Added.
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html: Added.
* fast/events/touch/ios/drag-block-without-overflow-scroll-expected.txt: Added.
* fast/events/touch/ios/drag-block-without-overflow-scroll.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html
trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt
trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html
trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt
trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html
trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-expected.txt
trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll.html




Diff

Modified: trunk/LayoutTests/ChangeLog (202530 => 202531)

--- trunk/LayoutTests/ChangeLog	2016-06-28 01:00:25 UTC (rev 202530)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 01:13:53 UTC (rev 202531)
@@ -1,3 +1,27 @@
+2016-06-27  Benjamin Poulain  
+
+Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch
+https://bugs.webkit.org/show_bug.cgi?id=159179
+rdar://problem/27006387
+
+Reviewed by Simon Fraser.
+
+Several of those tests expose existing bugs with overflow 

[webkit-changes] [202530] trunk/Source/WebCore

[achristensen]

Title: [202530] trunk/Source/WebCore








Revision 202530
Author achristen...@apple.com
Date 2016-06-27 18:00:25 -0700 (Mon, 27 Jun 2016)


Log Message
Fix Windows build.

* bindings/js/SerializedScriptValue.h:
WTF

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (202529 => 202530)

--- trunk/Source/WebCore/ChangeLog	2016-06-28 00:55:05 UTC (rev 202529)
+++ trunk/Source/WebCore/ChangeLog	2016-06-28 01:00:25 UTC (rev 202530)
@@ -1,3 +1,10 @@
+2016-06-27  Alex Christensen  
+
+Fix Windows build.
+
+* bindings/js/SerializedScriptValue.h:
+WTF
+
 2016-06-27  Commit Queue  
 
 Unreviewed, rolling out r202520.


Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.h (202529 => 202530)

--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.h	2016-06-28 00:55:05 UTC (rev 202529)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.h	2016-06-28 01:00:25 UTC (rev 202530)
@@ -87,7 +87,7 @@
 
 #if ENABLE(INDEXED_DATABASE)
 Vector blobURLsIsolatedCopy() const;
-void writeBlobsToDiskForIndexedDB(Function&& completionHandler);
+void writeBlobsToDiskForIndexedDB(WTF::Function&& completionHandler);
 IDBValue writeBlobsToDiskForIndexedDBSynchronously();
 #endif // ENABLE(INDEXED_DATABASE)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202529] trunk

[commit-queue]

Title: [202529] trunk








Revision 202529
Author commit-qu...@webkit.org
Date 2016-06-27 17:55:05 -0700 (Mon, 27 Jun 2016)


Log Message
Web Inspector: When modifying sessionStorage, localStorage gets updated
https://bugs.webkit.org/show_bug.cgi?id=159181


Patch by Joseph Pecoraro  on 2016-06-27
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

* UserInterface/Test/Test.js:
(WebInspector.loaded):
Add registration for StorageManager and StorageObserver.

Source/WebKit2:

* WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
This should be dispatching storage events.

LayoutTests:

* inspector/storage/domStorage-events-expected.txt: Added.
* inspector/storage/domStorage-events.html: Added.
Add a new test for DOMStorage domain events. Ensures that sessionStorage
and localStorage events are dispatched for the appropriate DOMStorageObject.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Test/Test.js
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp


Added Paths

trunk/LayoutTests/inspector/storage/
trunk/LayoutTests/inspector/storage/domStorage-events-expected.txt
trunk/LayoutTests/inspector/storage/domStorage-events.html




Diff

Modified: trunk/LayoutTests/ChangeLog (202528 => 202529)

--- trunk/LayoutTests/ChangeLog	2016-06-28 00:42:26 UTC (rev 202528)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 00:55:05 UTC (rev 202529)
@@ -1,3 +1,16 @@
+2016-06-27  Joseph Pecoraro  
+
+Web Inspector: When modifying sessionStorage, localStorage gets updated
+https://bugs.webkit.org/show_bug.cgi?id=159181
+
+
+Reviewed by Timothy Hatcher.
+
+* inspector/storage/domStorage-events-expected.txt: Added.
+* inspector/storage/domStorage-events.html: Added.
+Add a new test for DOMStorage domain events. Ensures that sessionStorage
+and localStorage events are dispatched for the appropriate DOMStorageObject.
+
 2016-06-27  Myles C. Maxfield  
 
 [Cocoa] Test gardening for the system font in macOS Sierra and iOS 10


Added: trunk/LayoutTests/inspector/storage/domStorage-events-expected.txt (0 => 202529)

--- trunk/LayoutTests/inspector/storage/domStorage-events-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/storage/domStorage-events-expected.txt	2016-06-28 00:55:05 UTC (rev 202529)
@@ -0,0 +1,36 @@
+Test for the DOMStorage events.
+
+
+== Running test suite: DOMStorage.Events
+-- Running test case: TestSessionStorage
+PASS: Should have a DOMStorageObject for sessionStorage.
+PASS: WebInspector.DOMStorageObject.Event.ItemAdded
+PASS: Should add key 'foo'.
+PASS: Should have value 'value1'.
+PASS: WebInspector.DOMStorageObject.Event.ItemAdded
+PASS: Should add key 'x'.
+PASS: Should have value 'xvalue'.
+PASS: WebInspector.DOMStorageObject.Event.ItemUpdated
+PASS: Should update key 'x'.
+PASS: Should have oldValue 'value1'.
+PASS: Should have new value 'value2'.
+PASS: WebInspector.DOMStorageObject.Event.ItemRemoved
+PASS: Should remove key 'x'.
+PASS: WebInspector.DOMStorageObject.Event.ItemsCleared
+
+-- Running test case: TestLocalStorage
+PASS: Should have a DOMStorageObject for localStorage.
+PASS: WebInspector.DOMStorageObject.Event.ItemAdded
+PASS: Should add key 'foo'.
+PASS: Should have value 'value1'.
+PASS: WebInspector.DOMStorageObject.Event.ItemAdded
+PASS: Should add key 'x'.
+PASS: Should have value 'xvalue'.
+PASS: WebInspector.DOMStorageObject.Event.ItemUpdated
+PASS: Should update key 'x'.
+PASS: Should have oldValue 'value1'.
+PASS: Should have new value 'value2'.
+PASS: WebInspector.DOMStorageObject.Event.ItemRemoved
+PASS: Should remove key 'x'.
+PASS: WebInspector.DOMStorageObject.Event.ItemsCleared
+


Added: trunk/LayoutTests/inspector/storage/domStorage-events.html (0 => 202529)

--- trunk/LayoutTests/inspector/storage/domStorage-events.html	(rev 0)
+++ trunk/LayoutTests/inspector/storage/domStorage-events.html	2016-06-28 00:55:05 UTC (rev 202529)
@@ -0,0 +1,95 @@
+
+
+
+
+function clearStorages() {
+sessionStorage.clear();
+localStorage.clear();
+}
+
+function triggerActions(storage) {
+storage.setItem("foo", "value1");
+storage.setItem("x", "xvalue");
+storage.setItem("foo", "value2");
+storage.removeItem("foo");
+storage.clear();
+}
+
+function test()
+{
+function testStorageEvents(storageObject, callback) {
+let count = 0;
+storageObject.addEventListener(WebInspector.DOMStorageObject.Event.ItemAdded, (event) => {
+count++;
+
+if (count === 1) {
+InspectorTest.pass("WebInspector.DOMStorageObject.Event.ItemAdded");
+InspectorTest.expectThat(event.data.key === "foo", "Should add key 'foo'.");
+InspectorTest.expectThat(event.data.value === 

[webkit-changes] [202528] trunk/Source/JavaScriptCore

[keith_miller]

Title: [202528] trunk/Source/_javascript_Core








Revision 202528
Author keith_mil...@apple.com
Date 2016-06-27 17:42:26 -0700 (Mon, 27 Jun 2016)


Log Message
Fix bad assert in StructureRareData::setObjectToStringValue
https://bugs.webkit.org/show_bug.cgi?id=159171


Reviewed by Mark Lam.

We should not have expected the generateConditionsForPrototypePropertyHit would succeed.
There are many reasons it might fail including that there is a proxy somewhere on the
prototype chain of the object.

* runtime/StructureRareData.cpp:
(JSC::StructureRareData::setObjectToStringValue):
* tests/stress/object-toString-with-proxy.js: Added.
(get target):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StructureRareData.cpp


Added Paths

trunk/Source/_javascript_Core/tests/stress/object-toString-with-proxy.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (202527 => 202528)

--- trunk/Source/_javascript_Core/ChangeLog	2016-06-28 00:36:40 UTC (rev 202527)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-06-28 00:42:26 UTC (rev 202528)
@@ -1,3 +1,20 @@
+2016-06-27  Keith Miller  
+
+Fix bad assert in StructureRareData::setObjectToStringValue
+https://bugs.webkit.org/show_bug.cgi?id=159171
+
+
+Reviewed by Mark Lam.
+
+We should not have expected the generateConditionsForPrototypePropertyHit would succeed.
+There are many reasons it might fail including that there is a proxy somewhere on the
+prototype chain of the object.
+
+* runtime/StructureRareData.cpp:
+(JSC::StructureRareData::setObjectToStringValue):
+* tests/stress/object-toString-with-proxy.js: Added.
+(get target):
+
 2016-06-27  Filip Pizlo  
 
 Crashing at an unreachable code trap in FTL should give more information


Modified: trunk/Source/_javascript_Core/runtime/StructureRareData.cpp (202527 => 202528)

--- trunk/Source/_javascript_Core/runtime/StructureRareData.cpp	2016-06-28 00:36:40 UTC (rev 202527)
+++ trunk/Source/_javascript_Core/runtime/StructureRareData.cpp	2016-06-28 00:42:26 UTC (rev 202528)
@@ -126,7 +126,7 @@
 // This will not create a condition for the current structure but that is good because we know the Symbol.toStringTag
 // is not on the ownStructure so we will transisition if one is added and this cache will no longer be used.
 conditionSet = generateConditionsForPrototypePropertyHit(vm, this, exec, ownStructure, toStringTagSymbolSlot.slotBase(), vm.propertyNames->toStringTagSymbol.impl());
-ASSERT(conditionSet.hasOneSlotBaseCondition());
+ASSERT(!conditionSet.isValid() || conditionSet.hasOneSlotBaseCondition());
 } else if (toStringTagSymbolSlot.isUnset())
 conditionSet = generateConditionsForPropertyMiss(vm, this, exec, ownStructure, vm.propertyNames->toStringTagSymbol.impl());
 else


Added: trunk/Source/_javascript_Core/tests/stress/object-toString-with-proxy.js (0 => 202528)

--- trunk/Source/_javascript_Core/tests/stress/object-toString-with-proxy.js	(rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/object-toString-with-proxy.js	2016-06-28 00:42:26 UTC (rev 202528)
@@ -0,0 +1,27 @@
+let foo = {};
+let properties = [];
+let p = new Proxy(foo, { get:(target, property) => {
+properties.push(property.toString());
+if (property === Symbol.toStringTag)
+return "bad things";
+return target[property];
+}});
+
+for (i = 0; i < 5; i++) {
+if (p != "[object bad things]")
+throw new Error("bad toString result.");
+
+if (properties[0] !== "Symbol(Symbol.toPrimitive)" || properties[1] !== "valueOf" || properties[2] !== "toString" || properties[3] !== "Symbol(Symbol.toStringTag)")
+throw new Error("bad property accesses.");
+
+properties = [];
+}
+
+p = createProxy(foo);
+
+for (i = 0; i < 5; i++) {
+let str = "bad things" + i;
+foo[Symbol.toStringTag] = str;
+if (p != "[object " + str + "]")
+throw new Error("bad toString result.");
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202527] trunk/Source/WebCore

[ryanhaddad]

Title: [202527] trunk/Source/WebCore








Revision 202527
Author ryanhad...@apple.com
Date 2016-06-27 17:36:40 -0700 (Mon, 27 Jun 2016)


Log Message
Unreviewed, rolling out r202520.
https://bugs.webkit.org/show_bug.cgi?id=159185

This change broke the 32-bit El Capitan build (Requested by
ryanhaddad on #webkit).

Reverted changeset:

"REGRESSION?(r202466): http/tests/security/canvas-remote-read-
remote-video-redirect.html failing on Sierra"
https://bugs.webkit.org/show_bug.cgi?id=159172
http://trac.webkit.org/changeset/202520

Patch by Commit Queue  on 2016-06-27

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h
trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (202526 => 202527)

--- trunk/Source/WebCore/ChangeLog	2016-06-28 00:36:03 UTC (rev 202526)
+++ trunk/Source/WebCore/ChangeLog	2016-06-28 00:36:40 UTC (rev 202527)
@@ -1,3 +1,18 @@
+2016-06-27  Commit Queue  
+
+Unreviewed, rolling out r202520.
+https://bugs.webkit.org/show_bug.cgi?id=159185
+
+This change broke the 32-bit El Capitan build (Requested by
+ryanhaddad on #webkit).
+
+Reverted changeset:
+
+"REGRESSION?(r202466): http/tests/security/canvas-remote-read-
+remote-video-redirect.html failing on Sierra"
+https://bugs.webkit.org/show_bug.cgi?id=159172
+http://trac.webkit.org/changeset/202520
+
 2016-06-27  Jer Noble  
 
 REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (202526 => 202527)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2016-06-28 00:36:03 UTC (rev 202526)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2016-06-28 00:36:40 UTC (rev 202527)
@@ -2241,18 +2241,7 @@
 
 Ref resolvedOrigin(SecurityOrigin::create(resolvedURL()));
 Ref requestedOrigin(SecurityOrigin::createFromString(assetURL()));
-if (!resolvedOrigin.get().isSameSchemeHostPort(()))
-return false;
-
-#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED > 101100
-AVAssetResourceLoader *resourceLoader = m_avAsset.get().resourceLoader;
-if (Settings::isAVFoundationNSURLSessionEnabled() && [resourceLoader respondsToSelector:@selector(URLSession)]) {
-WebCoreNSURLSession *session = (WebCoreNSURLSession *)resourceLoader.URLSession;
-if ([session respondsToSelector:@selector(hasSingleSecurityOrigin)])
-return session.hasSingleSecurityOrigin;
-}
-#endif
-return true;
+return resolvedOrigin.get().isSameSchemeHostPort(());
 }
 
 bool MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck() const


Modified: trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h (202526 => 202527)

--- trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h	2016-06-28 00:36:03 UTC (rev 202526)
+++ trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h	2016-06-28 00:36:40 UTC (rev 202527)
@@ -46,7 +46,6 @@
 class PlatformMediaResource;
 class PlatformMediaResourceLoader;
 class WebCoreNSURLSessionDataTaskClient;
-class SecurityOrigin;
 }
 
 enum class WebCoreNSURLSessionCORSAccessCheckResults {
@@ -64,11 +63,9 @@
 NSString *_sessionDescription;
 HashSet _dataTasks;
 BOOL _invalidated;
-BOOL _hasSingleSecurityOrigin;
 NSUInteger _nextTaskIdentifier;
 OSObjectPtr _internalQueue;
 WebCoreNSURLSessionCORSAccessCheckResults _corsResults;
-RefPtr _requestedOrigin;
 }
 - (id)initWithResourceLoader:(WebCore::PlatformMediaResourceLoader&)loader delegate:(id)delegate delegateQueue:(NSOperationQueue*)queue;
 @property (readonly, retain) NSOperationQueue *delegateQueue;
@@ -76,7 +73,6 @@
 @property (readonly, copy) NSURLSessionConfiguration *configuration;
 @property (copy) NSString *sessionDescription;
 @property (readonly) BOOL didPassCORSAccessChecks;
-@property (readonly) BOOL hasSingleSecurityOrigin;
 - (void)finishTasksAndInvalidate;
 - (void)invalidateAndCancel;
 


Modified: trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm (202526 => 202527)

--- trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm	2016-06-28 00:36:03 UTC (rev 202526)
+++ trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm	2016-06-28 00:36:40 UTC (rev 202527)
@@ -30,7 +30,6 @@
 
 #import "CachedResourceRequest.h"
 #import "PlatformMediaResourceLoader.h"
-#import "SecurityOrigin.h"
 #import "SubresourceLoader.h"
 
 using namespace WebCore;
@@ -45,7 +44,6 @@
 - 

[webkit-changes] [202526] trunk/LayoutTests

[mmaxfield]

Title: [202526] trunk/LayoutTests








Revision 202526
Author mmaxfi...@apple.com
Date 2016-06-27 17:36:03 -0700 (Mon, 27 Jun 2016)


Log Message
[Cocoa] Test gardening for the system font in macOS Sierra and iOS 10
https://bugs.webkit.org/show_bug.cgi?id=159175


Unreviewed.

* fast/text/trak-optimizeLegibility.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/trak-optimizeLegibility.html




Diff

Modified: trunk/LayoutTests/ChangeLog (202525 => 202526)

--- trunk/LayoutTests/ChangeLog	2016-06-28 00:34:10 UTC (rev 202525)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 00:36:03 UTC (rev 202526)
@@ -1,3 +1,13 @@
+2016-06-27  Myles C. Maxfield  
+
+[Cocoa] Test gardening for the system font in macOS Sierra and iOS 10
+https://bugs.webkit.org/show_bug.cgi?id=159175
+
+
+Unreviewed.
+
+* fast/text/trak-optimizeLegibility.html:
+
 2016-06-27  Alex Christensen  
 
 Fix flakiness on Sierra after r202511


Modified: trunk/LayoutTests/fast/text/trak-optimizeLegibility.html (202525 => 202526)

--- trunk/LayoutTests/fast/text/trak-optimizeLegibility.html	2016-06-28 00:34:10 UTC (rev 202525)
+++ trunk/LayoutTests/fast/text/trak-optimizeLegibility.html	2016-06-28 00:36:03 UTC (rev 202526)
@@ -7,8 +7,8 @@
 This test makes sure that you can opt-in to honoring the 'trak' table by specifying text-rendering: optimizeLegibility.
 The first and third lines below should have the same width. The middle one can (but doesn't have to) have a different width.
 hamburgefonstiv
-hamburgefonstiv
-hamburgefonstiv
+hamburgefonstiv
+hamburgefonstiv
 

[webkit-changes] [202525] trunk

[achristensen]

Title: [202525] trunk








Revision 202525
Author achristen...@apple.com
Date 2016-06-27 17:34:10 -0700 (Mon, 27 Jun 2016)


Log Message
Fix flakiness on Sierra after r202511
https://bugs.webkit.org/show_bug.cgi?id=159071

Source/WebKit2:

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::clearCredentials):
Replacing the NSURLSessions immediately caused assertions because the tasks are not always all stopped immediately when tearing down a test.
Stopping an NSURLSession needs to be done asynchronously.  I'll try a different testing technique for r202511.

LayoutTests:

* http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.
* http/tests/xmlhttprequest/sync-delegate-callbacks.html: Removed.
* platform/ios-simulator-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/wk2/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm


Removed Paths

trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt
trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks.html
trunk/LayoutTests/platform/wk2/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (202524 => 202525)

--- trunk/LayoutTests/ChangeLog	2016-06-28 00:33:28 UTC (rev 202524)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 00:34:10 UTC (rev 202525)
@@ -1,3 +1,14 @@
+2016-06-27  Alex Christensen  
+
+Fix flakiness on Sierra after r202511
+https://bugs.webkit.org/show_bug.cgi?id=159071
+
+* http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.
+* http/tests/xmlhttprequest/sync-delegate-callbacks.html: Removed.
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/wk2/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.
+
 2016-06-27  Brian Burg  
 
 Web Inspector: RuntimeManager should not use view object WebInspector.quickConsole


Deleted: trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt (202524 => 202525)

--- trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt	2016-06-28 00:33:28 UTC (rev 202524)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt	2016-06-28 00:34:10 UTC (rev 202525)
@@ -1,5 +0,0 @@
-ALERT: sending synchronous xhr
-ALERT: hello
-ALERT: sending synchronous xhr
-ALERT: hello
-


Deleted: trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks.html (202524 => 202525)

--- trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks.html	2016-06-28 00:33:28 UTC (rev 202524)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/sync-delegate-callbacks.html	2016-06-28 00:34:10 UTC (rev 202525)
@@ -1,19 +0,0 @@
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-// FIXME: http://webkit.org/b/65196
-if (testRunner.setShouldLogCanAuthenticateAgainstProtectionSpace)
-testRunner.setShouldLogCanAuthenticateAgainstProtectionSpace(true);
-}
-for (var i = 0; i < 2; i++) {
-alert("sending synchronous xhr");
-	try {
-		var req = new XMLHttpRequest();
-		req.open("GET", "https://127.0.0.1:8443/xmlhttprequest/resources/allow-any-origin.php", false);
-		req.send(null);
-	} catch (ex) {
-		alert(ex);
-	}
-	alert(req.responseText);
-}
-


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (202524 => 202525)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-06-28 00:33:28 UTC (rev 202524)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-06-28 00:34:10 UTC (rev 202525)
@@ -1836,9 +1836,6 @@
 webkit.org/b/148709 fast/events/wheelevent-basic.html [ Skip ]
 webkit.org/b/148709 fast/events/wheelevent-mousewheel-interaction.html [ Skip ]
 
-# NSURLConnection doesn't allow us to clear the TLS session cache.  This is flaky on iOS9.
-http/tests/xmlhttprequest/sync-delegate-callbacks.html [ Pass Failure ]
-
 # Flaky tests that need bugs
 fast/dom/Window/post-message-crash.html [ Pass Failure ]
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (202524 => 202525)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-06-28 00:33:28 UTC (rev 202524)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-06-28 00:34:10 UTC (rev 202525)
@@ -703,9 +703,6 @@
 # Always very slow, frequently timing out (only on bots, not locally).
 webkit.org/b/121331 [ Yosemite ElCapitan ] http/tests/misc/submit-post-keygen.html [ Pass Failure Timeout ]
 
-# NSURLConnection doesn't allow us to clear the TLS session cache.
-[ Yosemite ElCapitan ] 

[webkit-changes] [202524] trunk/Source/WebKit/mac

[timothy_horton]

Title: [202524] trunk/Source/WebKit/mac








Revision 202524
Author timothy_hor...@apple.com
Date 2016-06-27 17:33:28 -0700 (Mon, 27 Jun 2016)


Log Message
REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
https://bugs.webkit.org/show_bug.cgi?id=159184


Reviewed by Beth Dakin.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
* WebView/WebImmediateActionController.h:
* WebView/WebImmediateActionController.mm:
(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
(-[WebImmediateActionController _animationControllerForText]):
(dictionaryPopupInfoForRange): Deleted.
WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm
trunk/Source/WebKit/mac/WebView/WebImmediateActionController.h
trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (202523 => 202524)

--- trunk/Source/WebKit/mac/ChangeLog	2016-06-28 00:26:31 UTC (rev 202523)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-06-28 00:33:28 UTC (rev 202524)
@@ -1,3 +1,21 @@
+2016-06-27  Tim Horton  
+
+REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
+https://bugs.webkit.org/show_bug.cgi?id=159184
+
+
+Reviewed by Beth Dakin.
+
+* WebView/WebHTMLView.mm:
+(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
+* WebView/WebImmediateActionController.h:
+* WebView/WebImmediateActionController.mm:
+(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
+(-[WebImmediateActionController _animationControllerForText]):
+(dictionaryPopupInfoForRange): Deleted.
+WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
+from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
+
 2016-06-24  Jer Noble  
 
 Playback controls refer to wrong element when playing multiple items in a page.


Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (202523 => 202524)

--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2016-06-28 00:26:31 UTC (rev 202523)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2016-06-28 00:33:28 UTC (rev 202524)
@@ -6360,30 +6360,15 @@
 
 - (void)_lookUpInDictionaryFromMenu:(id)sender
 {
-// Dictionary API will accept a whitespace-only string and display UI as if it were real text,
-// so bail out early to avoid that.
-if ([[[self selectedString] _webkit_stringByTrimmingWhitespace] length] == 0)
-return;
-
-NSAttributedString *attrString = [self selectedAttributedString];
-
 Frame* coreFrame = core([self _frame]);
 if (!coreFrame)
 return;
 
-NSRect rect = coreFrame->selection().selectionBounds();
+RefPtr selectionRange = coreFrame->selection().selection().firstRange();
+if (!selectionRange)
+return;
 
-NSDictionary *attributes = [attrString fontAttributesInRange:NSMakeRange(0, 1)];
-NSFont *font = [attributes objectForKey:NSFontAttributeName];
-if (font)
-rect.origin.y += [font descender];
-
-DictionaryPopupInfo info;
-info.attributedString = attrString;
-info.origin = coreFrame->view()->contentsToWindow(enclosingIntRect(rect)).location();
-if (auto textIndicator = TextIndicator::createWithSelectionInFrame(*coreFrame, TextIndicatorOptionIncludeSnapshotWithSelectionHighlight, TextIndicatorPresentationTransition::BounceAndCrossfade))
-info.textIndicator = textIndicator->data();
-[[self _webView] _showDictionaryLookupPopup:info];
+[[self _webView] _showDictionaryLookupPopup:[WebImmediateActionController _dictionaryPopupInfoForRange:*selectionRange inFrame:coreFrame withLookupOptions:nil indicatorOptions:TextIndicatorOptionIncludeSnapshotWithSelectionHighlight transition:TextIndicatorPresentationTransition::BounceAndCrossfade]];
 }
 
 - (void)quickLookWithEvent:(NSEvent *)event


Modified: trunk/Source/WebKit/mac/WebView/WebImmediateActionController.h (202523 => 202524)

--- trunk/Source/WebKit/mac/WebView/WebImmediateActionController.h	2016-06-28 00:26:31 UTC (rev 202523)
+++ trunk/Source/WebKit/mac/WebView/WebImmediateActionController.h	2016-06-28 00:33:28 UTC (rev 202524)
@@ -28,12 +28,20 @@
 #import "WebUIDelegatePrivate.h"
 #import 
 #import 
+#import 
 #import 
 
 @class DDActionContext;
 @class QLPreviewMenuItem;
+@class NSDictionary;
 @class WebView;
 
+namespace WebCore {
+class Frame;
+class Range;
+struct DictionaryPopupInfo;
+};
+
 @interface WebImmediateActionController : NSObject  {
 @private
 

[webkit-changes] [202523] trunk/Tools

[gyuyoung . kim]

Title: [202523] trunk/Tools








Revision 202523
Author gyuyoung@webkit.org
Date 2016-06-27 17:26:31 -0700 (Mon, 27 Jun 2016)


Log Message
[EFL] Support to build on Debian linux
https://bugs.webkit.org/show_bug.cgi?id=159123

Reviewed by Antonio Gomes.

* efl/install-dependencies: Install libgnutls28-dev.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (202522 => 202523)

--- trunk/Tools/ChangeLog	2016-06-28 00:23:09 UTC (rev 202522)
+++ trunk/Tools/ChangeLog	2016-06-28 00:26:31 UTC (rev 202523)
@@ -1,3 +1,12 @@
+2016-06-27  Gyuyoung Kim  
+
+[EFL] Support to build on Debian linux
+https://bugs.webkit.org/show_bug.cgi?id=159123
+
+Reviewed by Antonio Gomes.
+
+* efl/install-dependencies: Install libgnutls28-dev.
+
 2016-06-27  Alex Christensen  
 
 Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess


Modified: trunk/Tools/efl/install-dependencies (202522 => 202523)

--- trunk/Tools/efl/install-dependencies	2016-06-28 00:23:09 UTC (rev 202522)
+++ trunk/Tools/efl/install-dependencies	2016-06-28 00:26:31 UTC (rev 202523)
@@ -70,7 +70,7 @@
 libgeoclue-dev \
 libgif-dev \
 libgl1-mesa-dev \
-libgnutls-dev \
+libgnutls28-dev \
 libgpg-error-dev \
 libhyphen-dev \
 libicu-dev \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202522] trunk

[bburg]

Title: [202522] trunk








Revision 202522
Author bb...@apple.com
Date 2016-06-27 17:23:09 -0700 (Mon, 27 Jun 2016)


Log Message
Web Inspector: RuntimeManager should not use view object WebInspector.quickConsole
https://bugs.webkit.org/show_bug.cgi?id=128092


Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

This is a layering violation which makes it harder to use RuntimeManager.evaluateInInspectedWindow
from a testing context where the QuickConsole view does not exist.

Store the selected execution context identifier on RuntimeManager and use it
when doing subsequent evaluations that act on the currently selected frame.

* UserInterface/Controllers/RuntimeManager.js:
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
(WebInspector.RuntimeManager.prototype.saveResult):
Use local state.

(WebInspector.RuntimeManager.prototype.get defaultExecutionContextIdentifier):
(WebInspector.RuntimeManager.prototype.set defaultExecutionContextIdentifier):
Added.

(WebInspector.RuntimeManager):
* UserInterface/Models/ExecutionContext.js:
(WebInspector.ExecutionContext):
Move the symbolic name for the top level execution context to RuntimeManager.

* UserInterface/Test/Test.js:
(WebInspector.loaded): No need to stub out WebInspector.QuickConsole any more.

* UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.prototype._framePageExecutionContextsChanged):
(WebInspector.QuickConsole.prototype._removeExecutionContextPathComponentForFrame):
(WebInspector.QuickConsole.prototype._updateExecutionContextPathComponentForFrame):
(WebInspector.QuickConsole.prototype._pathComponentSelected):
For now, set RuntimeManager's selected execution context whenever we set the
selected path component. In a future patch, we should invert the dependency and have
the selected component change whenever RuntimeManager.defaultExecutionContext changes.

LayoutTests:

Add some really basic coverage for RuntimeManager.defaultExecutionContextIdentifier
and using it in RuntimeManager.evaluateInInspectedWindow.

* inspector/runtime/change-execution-context-identifier-expected.txt: Added.
* inspector/runtime/change-execution-context-identifier.html: Added.
* inspector/runtime/resources/change-execution-context-identifier-subframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/ExecutionContext.js
trunk/Source/WebInspectorUI/UserInterface/Test/Test.js
trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js


Added Paths

trunk/LayoutTests/inspector/runtime/change-execution-context-identifier-expected.txt
trunk/LayoutTests/inspector/runtime/change-execution-context-identifier.html
trunk/LayoutTests/inspector/runtime/resources/
trunk/LayoutTests/inspector/runtime/resources/change-execution-context-identifier-subframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (202521 => 202522)

--- trunk/LayoutTests/ChangeLog	2016-06-27 23:59:50 UTC (rev 202521)
+++ trunk/LayoutTests/ChangeLog	2016-06-28 00:23:09 UTC (rev 202522)
@@ -1,3 +1,18 @@
+2016-06-27  Brian Burg  
+
+Web Inspector: RuntimeManager should not use view object WebInspector.quickConsole
+https://bugs.webkit.org/show_bug.cgi?id=128092
+
+
+Reviewed by Timothy Hatcher.
+
+Add some really basic coverage for RuntimeManager.defaultExecutionContextIdentifier
+and using it in RuntimeManager.evaluateInInspectedWindow.
+
+* inspector/runtime/change-execution-context-identifier-expected.txt: Added.
+* inspector/runtime/change-execution-context-identifier.html: Added.
+* inspector/runtime/resources/change-execution-context-identifier-subframe.html: Added.
+
 2016-06-27  Benjamin Poulain  
 
 Fix style invalidation for :active when the activated node has no renderer


Added: trunk/LayoutTests/inspector/runtime/change-execution-context-identifier-expected.txt (0 => 202522)

--- trunk/LayoutTests/inspector/runtime/change-execution-context-identifier-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/runtime/change-execution-context-identifier-expected.txt	2016-06-28 00:23:09 UTC (rev 202522)
@@ -0,0 +1,21 @@
+
+Test that RuntimeManager.evaluateInInspectedWindow respects the selected execution context.
+
+
+== Running test suite: RuntimeManager.defaultExecutionContextIdentifier
+-- Running test case: InitialScriptExecutionContext
+PASS: The default execution context should be the top level execution context initially.
+
+-- Running test case: ScriptExecutionContextMainFrame
+Passphrase in selected frame: coldwater
+PASS: The passphrase should match the phrase defined in the main frame.
+
+-- Running test case: ScriptExecutionContextSubFrame
+PASS: The test page should only have one sub-frame.
+Passphrase in selected frame: rosewater
+PASS: The passphrase 

[webkit-changes] [202521] trunk/Websites/webkit.org

[jond]

Title: [202521] trunk/Websites/webkit.org








Revision 202521
Author j...@apple.com
Date 2016-06-27 16:59:50 -0700 (Mon, 27 Jun 2016)


Log Message
Set a default image for sharing webkit.org links via social.
https://bugs.webkit.org/show_bug.cgi?id=159167

Reviewed by Timothy Hatcher.

* wp-content/plugins/social-meta.php:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/plugins/social-meta.php




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (202520 => 202521)

--- trunk/Websites/webkit.org/ChangeLog	2016-06-27 23:56:09 UTC (rev 202520)
+++ trunk/Websites/webkit.org/ChangeLog	2016-06-27 23:59:50 UTC (rev 202521)
@@ -1,3 +1,12 @@
+2016-06-27  Jon Davis  
+
+Set a default image for sharing webkit.org links via social.
+https://bugs.webkit.org/show_bug.cgi?id=159167
+
+Reviewed by Timothy Hatcher.
+
+* wp-content/plugins/social-meta.php:
+
 2016-06-24  Dean Jackson  
 
 More examples for the wide-gamut demo.


Modified: trunk/Websites/webkit.org/wp-content/plugins/social-meta.php (202520 => 202521)

--- trunk/Websites/webkit.org/wp-content/plugins/social-meta.php	2016-06-27 23:56:09 UTC (rev 202520)
+++ trunk/Websites/webkit.org/wp-content/plugins/social-meta.php	2016-06-27 23:59:50 UTC (rev 202521)
@@ -15,7 +15,7 @@
 
 $categories = array();
 $tags = array();
-$image_url = '';
+$image_url = get_stylesheet_directory_uri() . '/images/webkit.svg';
 $twitter_handle = '';
 
 if (is_front_page() || is_home()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202520] trunk/Source/WebCore

[jer . noble]

Title: [202520] trunk/Source/WebCore








Revision 202520
Author jer.no...@apple.com
Date 2016-06-27 16:56:09 -0700 (Mon, 27 Jun 2016)


Log Message
REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
https://bugs.webkit.org/show_bug.cgi?id=159172


Reviewed by Brent Fulgham.

Add a hasSingleSecurityOrigin property to WebCoreNSURLSession that gets updated each time one of that
sessions' tasks receieves a response or a redirect request. Check that property from the MediaPlayerPrivate.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
* platform/network/cocoa/WebCoreNSURLSession.h:
* platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession updateHasSingleSecurityOrigin:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h
trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (202519 => 202520)

--- trunk/Source/WebCore/ChangeLog	2016-06-27 23:26:41 UTC (rev 202519)
+++ trunk/Source/WebCore/ChangeLog	2016-06-27 23:56:09 UTC (rev 202520)
@@ -1,3 +1,24 @@
+2016-06-27  Jer Noble  
+
+REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
+https://bugs.webkit.org/show_bug.cgi?id=159172
+
+
+Reviewed by Brent Fulgham.
+
+Add a hasSingleSecurityOrigin property to WebCoreNSURLSession that gets updated each time one of that
+sessions' tasks receieves a response or a redirect request. Check that property from the MediaPlayerPrivate.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
+* platform/network/cocoa/WebCoreNSURLSession.h:
+* platform/network/cocoa/WebCoreNSURLSession.mm:
+(-[WebCoreNSURLSession updateHasSingleSecurityOrigin:]):
+(-[WebCoreNSURLSession dataTaskWithRequest:]):
+(-[WebCoreNSURLSession dataTaskWithURL:]):
+(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
+(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):
+
 2016-06-27  Benjamin Poulain  
 
 Fix style invalidation for :active when the activated node has no renderer


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (202519 => 202520)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2016-06-27 23:26:41 UTC (rev 202519)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2016-06-27 23:56:09 UTC (rev 202520)
@@ -2241,7 +2241,18 @@
 
 Ref resolvedOrigin(SecurityOrigin::create(resolvedURL()));
 Ref requestedOrigin(SecurityOrigin::createFromString(assetURL()));
-return resolvedOrigin.get().isSameSchemeHostPort(());
+if (!resolvedOrigin.get().isSameSchemeHostPort(()))
+return false;
+
+#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED > 101100
+AVAssetResourceLoader *resourceLoader = m_avAsset.get().resourceLoader;
+if (Settings::isAVFoundationNSURLSessionEnabled() && [resourceLoader respondsToSelector:@selector(URLSession)]) {
+WebCoreNSURLSession *session = (WebCoreNSURLSession *)resourceLoader.URLSession;
+if ([session respondsToSelector:@selector(hasSingleSecurityOrigin)])
+return session.hasSingleSecurityOrigin;
+}
+#endif
+return true;
 }
 
 bool MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck() const


Modified: trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h (202519 => 202520)

--- trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h	2016-06-27 23:26:41 UTC (rev 202519)
+++ trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h	2016-06-27 23:56:09 UTC (rev 202520)
@@ -46,6 +46,7 @@
 class PlatformMediaResource;
 class PlatformMediaResourceLoader;
 class WebCoreNSURLSessionDataTaskClient;
+class SecurityOrigin;
 }
 
 enum class WebCoreNSURLSessionCORSAccessCheckResults {
@@ -63,9 +64,11 @@
 NSString *_sessionDescription;
 HashSet _dataTasks;
 BOOL _invalidated;
+BOOL _hasSingleSecurityOrigin;
 NSUInteger _nextTaskIdentifier;
 OSObjectPtr _internalQueue;
 WebCoreNSURLSessionCORSAccessCheckResults _corsResults;
+RefPtr _requestedOrigin;
 }
 - 

[webkit-changes] [202517] trunk

[benjamin]

Title: [202517] trunk








Revision 202517
Author benja...@webkit.org
Date 2016-06-27 15:20:17 -0700 (Mon, 27 Jun 2016)


Log Message
Fix style invalidation for :active when the activated node has no renderer
https://bugs.webkit.org/show_bug.cgi?id=159125

Reviewed by Antti Koivisto.

Source/WebCore:

Same old bug: a style invalidation path was depending
on the style.

Here we really need both flags. An element can have
childrenAffectedByActive() false and renderStyle->affectedByActive() true
if it was subject to style sharing.

The element state "childrenAffectedByActive" should be renamed
"styleAffectedByActive" since it is not a parent invalidation flag.
That will be done separately.

Tests: fast/css/pseudo-active-on-labeled-control-without-renderer.html
   fast/css/pseudo-active-style-sharing-1.html
   fast/css/pseudo-active-style-sharing-2.html
   fast/css/pseudo-active-style-sharing-3.html
   fast/css/pseudo-active-style-sharing-4.html
   fast/css/pseudo-active-style-sharing-5.html
   fast/css/pseudo-active-style-sharing-6.html

* dom/Element.cpp:
(WebCore::Element::setActive):
* style/StyleRelations.cpp:
(WebCore::Style::commitRelationsToRenderStyle):

LayoutTests:

There was no bug with style sharing but I wanted that covered anyway.
Style sharing depends on 2 flags which is uncommon.
There was no test coverage whatsoever, breaking it did not fail any test.

* fast/css/pseudo-active-on-labeled-control-without-renderer-expected.txt: Added.
* fast/css/pseudo-active-on-labeled-control-without-renderer.html: Added.
* fast/css/pseudo-active-style-sharing-1-expected.txt: Added.
* fast/css/pseudo-active-style-sharing-1.html: Added.
* fast/css/pseudo-active-style-sharing-2-expected.txt: Added.
* fast/css/pseudo-active-style-sharing-2.html: Added.
* fast/css/pseudo-active-style-sharing-3-expected.txt: Added.
* fast/css/pseudo-active-style-sharing-3.html: Added.
* fast/css/pseudo-active-style-sharing-4-expected.txt: Added.
* fast/css/pseudo-active-style-sharing-4.html: Added.
* fast/css/pseudo-active-style-sharing-5-expected.txt: Added.
* fast/css/pseudo-active-style-sharing-5.html: Added.
* fast/css/pseudo-active-style-sharing-6-expected.txt: Added.
* fast/css/pseudo-active-style-sharing-6.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/style/StyleRelations.cpp


Added Paths

trunk/LayoutTests/fast/css/pseudo-active-on-labeled-control-without-renderer-expected.txt
trunk/LayoutTests/fast/css/pseudo-active-on-labeled-control-without-renderer.html
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-1-expected.txt
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-1.html
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-2-expected.txt
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-2.html
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-3-expected.txt
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-3.html
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-4-expected.txt
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-4.html
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-5-expected.txt
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-5.html
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-6-expected.txt
trunk/LayoutTests/fast/css/pseudo-active-style-sharing-6.html




Diff

Modified: trunk/LayoutTests/ChangeLog (202516 => 202517)

--- trunk/LayoutTests/ChangeLog	2016-06-27 22:13:16 UTC (rev 202516)
+++ trunk/LayoutTests/ChangeLog	2016-06-27 22:20:17 UTC (rev 202517)
@@ -1,3 +1,29 @@
+2016-06-27  Benjamin Poulain  
+
+Fix style invalidation for :active when the activated node has no renderer
+https://bugs.webkit.org/show_bug.cgi?id=159125
+
+Reviewed by Antti Koivisto.
+
+There was no bug with style sharing but I wanted that covered anyway.
+Style sharing depends on 2 flags which is uncommon.
+There was no test coverage whatsoever, breaking it did not fail any test.
+
+* fast/css/pseudo-active-on-labeled-control-without-renderer-expected.txt: Added.
+* fast/css/pseudo-active-on-labeled-control-without-renderer.html: Added.
+* fast/css/pseudo-active-style-sharing-1-expected.txt: Added.
+* fast/css/pseudo-active-style-sharing-1.html: Added.
+* fast/css/pseudo-active-style-sharing-2-expected.txt: Added.
+* fast/css/pseudo-active-style-sharing-2.html: Added.
+* fast/css/pseudo-active-style-sharing-3-expected.txt: Added.
+* fast/css/pseudo-active-style-sharing-3.html: Added.
+* fast/css/pseudo-active-style-sharing-4-expected.txt: Added.
+* fast/css/pseudo-active-style-sharing-4.html: Added.
+* fast/css/pseudo-active-style-sharing-5-expected.txt: Added.
+* fast/css/pseudo-active-style-sharing-5.html: Added.
+  

[webkit-changes] [202514] trunk

[ryanhaddad]

Title: [202514] trunk








Revision 202514
Author ryanhad...@apple.com
Date 2016-06-27 14:45:49 -0700 (Mon, 27 Jun 2016)


Log Message
Unreviewed, rolling out r202505.
https://bugs.webkit.org/show_bug.cgi?id=159169

The test added with this change is flaky and it caused an
existing test to time out on El Capitan. (Requested by
ryanhaddad on #webkit).

Reverted changeset:

"[iOS] Media controls are too cramped with small video"
https://bugs.webkit.org/show_bug.cgi?id=158815
http://trac.webkit.org/changeset/202505

Patch by Commit Queue  on 2016-06-27

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt
trunk/LayoutTests/platform/mac-yosemite/http/tests/media/hls/video-controls-live-stream-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js


Removed Paths

trunk/LayoutTests/media/video-controls-drop-and-restore-timeline-expected.txt
trunk/LayoutTests/media/video-controls-drop-and-restore-timeline.html




Diff

Modified: trunk/LayoutTests/ChangeLog (202513 => 202514)

--- trunk/LayoutTests/ChangeLog	2016-06-27 21:44:39 UTC (rev 202513)
+++ trunk/LayoutTests/ChangeLog	2016-06-27 21:45:49 UTC (rev 202514)
@@ -1,3 +1,18 @@
+2016-06-27  Commit Queue  
+
+Unreviewed, rolling out r202505.
+https://bugs.webkit.org/show_bug.cgi?id=159169
+
+The test added with this change is flaky and it caused an
+existing test to time out on El Capitan. (Requested by
+ryanhaddad on #webkit).
+
+Reverted changeset:
+
+"[iOS] Media controls are too cramped with small video"
+https://bugs.webkit.org/show_bug.cgi?id=158815
+http://trac.webkit.org/changeset/202505
+
 2016-06-27  Alex Christensen  
 
 Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess


Deleted: trunk/LayoutTests/media/video-controls-drop-and-restore-timeline-expected.txt (202513 => 202514)

--- trunk/LayoutTests/media/video-controls-drop-and-restore-timeline-expected.txt	2016-06-27 21:44:39 UTC (rev 202513)
+++ trunk/LayoutTests/media/video-controls-drop-and-restore-timeline-expected.txt	2016-06-27 21:45:49 UTC (rev 202514)
@@ -1,15 +0,0 @@
-
-Tests that the scrubber is dropped when a video is too narrow and restored when made wider.
-
-EXPECTED (video.controls != 'null') OK
-EVENT(canplaythrough)
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (timelineContainer = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-timeline-container') != 'null') OK
-Initital test at width = 200px
-EXPECTED (timelineChildrenAreDropped() == 'true') OK
-EXPECTED (timelineChildrenAreNotDisplayed() == 'true') OK
-Second test at width = 500px
-EXPECTED (timelineChildrenAreDropped() == 'false') OK
-EXPECTED (timelineChildrenAreNotDisplayed() == 'false') OK
-END OF TEST
-


Deleted: trunk/LayoutTests/media/video-controls-drop-and-restore-timeline.html (202513 => 202514)

--- trunk/LayoutTests/media/video-controls-drop-and-restore-timeline.html	2016-06-27 21:44:39 UTC (rev 202513)
+++ trunk/LayoutTests/media/video-controls-drop-and-restore-timeline.html	2016-06-27 21:45:49 UTC (rev 202514)
@@ -1,56 +0,0 @@
-
-
-Tests that the scrubber is dropped when a video is too narrow and restored when made wider
-
-
-
-
Tests that the scrubber is dropped when a video is too narrow and restored when made wider.
-