[webkit-changes] [213272] trunk
Title: [213272] trunk
Revision 213272
Author wenson_hs...@apple.com
Date 2017-03-01 23:43:41 -0800 (Wed, 01 Mar 2017)
Log Message
Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate method
https://bugs.webkit.org/show_bug.cgi?id=169013
Reviewed by Dan Bernstein.
Source/WebKit2:
Rather than introduce new SPI on WKWebView directly, we should follow convention and add the hook to the private
version of the UI delegate.
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _adjustedDataInteractionItemProviders:]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
Adjusts TestWebKitAPI for changes in WebKit2. See Source/WebKit2/ChangeLog for more details.
* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
(-[CustomItemProviderWebView _adjustedDataInteractionItemProviders:]): Deleted.
* TestWebKitAPI/ios/DataInteractionSimulator.h:
* TestWebKitAPI/ios/DataInteractionSimulator.mm:
(-[DataInteractionSimulator initWithWebView:]):
(-[DataInteractionSimulator dealloc]):
(-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h
trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (213271 => 213272)
--- trunk/Source/WebKit2/ChangeLog 2017-03-02 07:32:40 UTC (rev 213271)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-02 07:43:41 UTC (rev 213272)
@@ -1,3 +1,18 @@
+2017-03-01 Wenson Hsieh
+
+Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate method
+https://bugs.webkit.org/show_bug.cgi?id=169013
+
+Reviewed by Dan Bernstein.
+
+Rather than introduce new SPI on WKWebView directly, we should follow convention and add the hook to the private
+version of the UI delegate.
+
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _adjustedDataInteractionItemProviders:]): Deleted.
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
2017-03-01 Alex Christensen
Unreviewed, rolling out r213259.
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (213271 => 213272)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2017-03-02 07:32:40 UTC (rev 213271)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2017-03-02 07:43:41 UTC (rev 213272)
@@ -30,6 +30,7 @@
#import
#import
+@class UIItemProvider;
@class UIScrollView;
@class UIViewController;
@class _WKContextMenuElementInfo;
@@ -86,6 +87,7 @@
- (UIViewController *)_presentingViewControllerForWebView:(WKWebView *)webView WK_API_AVAILABLE(ios(10.0));
- (void)_webView:(WKWebView *)webView getAlternateURLFromImage:(UIImage *)image completionHandler:(void (^)(NSURL *alternateURL, NSDictionary *userInfo))completionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA));
- (NSURL *)_webView:(WKWebView *)webView alternateURLFromImage:(UIImage *)image userInfo:(NSDictionary **)userInfo WK_API_AVAILABLE(ios(WK_IOS_TBA));
+- (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA));
#else
- (NSMenu *)_webView:(WKWebView *)webView contextMenu:(NSMenu *)menu forElement:(_WKContextMenuElementInfo *)element WK_API_AVAILABLE(macosx(10.12));
- (NSMenu *)_webView:(WKWebView *)webView contextMenu:(NSMenu *)menu forElement:(_WKContextMenuElementInfo *)element userInfo:(id )userInfo WK_API_AVAILABLE(macosx(10.12));
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (213271 => 213272)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-03-02 07:32:40 UTC (rev 213271)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-03-02 07:43:41 UTC (rev 213272)
@@ -3726,11 +3726,6 @@
{
}
-- (NSArray *)_adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders
-{
-return originalItemProviders;
-}
-
#endif
- (void)_didRelaunchProcess
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (213271 => 213272)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2017-03-02 07:32:40 UTC (rev 213271)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2017-03-02 07:43:41 UTC (rev 213272)
@@ -188,8 +188,6 @@
- (void)_accessibilityRetrieveSpeakSelectionContent;
- (void)_accessibilityDidGetSpeakSelectionContent:(NSString *)content;
-- (NSArray *)_adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA));
-
#else
@property (readonly) NSColor *_page
[webkit-changes] [213271] trunk/Source
Title: [213271] trunk/Source
Revision 213271
Author achristen...@apple.com
Date 2017-03-01 23:32:40 -0800 (Wed, 01 Mar 2017)
Log Message
Actually fix Windows build.
Source/WebCore:
* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
Win32Handle is now in WTF namespace.
Source/WebKit/win:
* WebFrame.cpp:
(WebFrame::invalidate):
r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebFrame.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (213270 => 213271)
--- trunk/Source/WebCore/ChangeLog 2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebCore/ChangeLog 2017-03-02 07:32:40 UTC (rev 213271)
@@ -1,5 +1,12 @@
2017-03-01 Alex Christensen
+Actually fix Windows build.
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
+Win32Handle is now in WTF namespace.
+
+2017-03-01 Alex Christensen
+
Fix WinCairo build after r213214
https://bugs.webkit.org/show_bug.cgi?id=168908
Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (213270 => 213271)
--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2017-03-02 07:32:40 UTC (rev 213271)
@@ -245,9 +245,9 @@
Direct3DPresenter* m_presenter { nullptr };
DWORD m_threadID { 0 };
-Win32Handle m_schedulerThread;
-Win32Handle m_threadReadyEvent;
-Win32Handle m_flushEvent;
+WTF::Win32Handle m_schedulerThread;
+WTF::Win32Handle m_threadReadyEvent;
+WTF::Win32Handle m_flushEvent;
float m_playbackRate { 1.0f };
MFTIME m_frameDuration { 0 };
Modified: trunk/Source/WebKit/win/ChangeLog (213270 => 213271)
--- trunk/Source/WebKit/win/ChangeLog 2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebKit/win/ChangeLog 2017-03-02 07:32:40 UTC (rev 213271)
@@ -1,5 +1,13 @@
2017-03-01 Alex Christensen
+Actually fix Windows build.
+
+* WebFrame.cpp:
+(WebFrame::invalidate):
+r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
+
+2017-03-01 Alex Christensen
+
Fix Windows build after r213266
https://bugs.webkit.org/show_bug.cgi?id=169049
Modified: trunk/Source/WebKit/win/WebFrame.cpp (213270 => 213271)
--- trunk/Source/WebKit/win/WebFrame.cpp 2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebKit/win/WebFrame.cpp 2017-03-02 07:32:40 UTC (rev 213271)
@@ -1067,7 +1067,7 @@
ASSERT(coreFrame);
if (Document* document = coreFrame->document())
-document->resolveStyle(Style::Force);
+document->resolveStyle(WebCore::Document::ResolveStyleType::Rebuild);
}
HRESULT WebFrame::inViewSourceMode(BOOL* flag)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213270] trunk/Tools
Title: [213270] trunk/Tools
Revision 213270
Author pvol...@apple.com
Date 2017-03-01 23:20:12 -0800 (Wed, 01 Mar 2017)
Log Message
[Win] DRT should not dispatch messages after test is done.
https://bugs.webkit.org/show_bug.cgi?id=169026
Reviewed by Brent Fulgham.
Exiting the message loop with PostQuitMessage will leave room for
a few messages to be dispatched after the test is done.
* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
(runTest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp
Diff
Modified: trunk/Tools/ChangeLog (213269 => 213270)
--- trunk/Tools/ChangeLog 2017-03-02 07:07:44 UTC (rev 213269)
+++ trunk/Tools/ChangeLog 2017-03-02 07:20:12 UTC (rev 213270)
@@ -1,3 +1,17 @@
+2017-03-01 Per Arne Vollan
+
+[Win] DRT should not dispatch messages after test is done.
+https://bugs.webkit.org/show_bug.cgi?id=169026
+
+Reviewed by Brent Fulgham.
+
+Exiting the message loop with PostQuitMessage will leave room for
+a few messages to be dispatched after the test is done.
+
+* DumpRenderTree/win/DumpRenderTree.cpp:
+(dump):
+(runTest):
+
2017-03-01 Myles C. Maxfield
Implement font-stretch for installed fonts
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (213269 => 213270)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-03-02 07:07:44 UTC (rev 213269)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-03-02 07:20:12 UTC (rev 213270)
@@ -743,7 +743,6 @@
fail:
// This will exit from our message loop.
-::PostQuitMessage(0);
done = true;
}
@@ -1211,7 +1210,7 @@
request->setHTTPMethod(methodBStr);
frame->loadRequest(request.get());
-while (true) {
+while (!done) {
#if USE(CF)
CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0, true);
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213269] trunk/Source/WebCore
Title: [213269] trunk/Source/WebCore
Revision 213269
Author achristen...@apple.com
Date 2017-03-01 23:07:44 -0800 (Wed, 01 Mar 2017)
Log Message
Fix WinCairo build after r213214
https://bugs.webkit.org/show_bug.cgi?id=168908
* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (213268 => 213269)
--- trunk/Source/WebCore/ChangeLog 2017-03-02 07:02:54 UTC (rev 213268)
+++ trunk/Source/WebCore/ChangeLog 2017-03-02 07:07:44 UTC (rev 213269)
@@ -1,3 +1,10 @@
+2017-03-01 Alex Christensen
+
+Fix WinCairo build after r213214
+https://bugs.webkit.org/show_bug.cgi?id=168908
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
+
2017-03-01 Myles C. Maxfield
Implement font-stretch for installed fonts
Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (213268 => 213269)
--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2017-03-02 07:02:54 UTC (rev 213268)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2017-03-02 07:07:44 UTC (rev 213269)
@@ -24,8 +24,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef MediaPlayerPrivateMediaFoundation_h
-#define MediaPlayerPrivateMediaFoundation_h
+#pragma once
#include "COMPtr.h"
#include "MediaPlayerPrivate.h"
@@ -43,7 +42,7 @@
#include
#include
#include
-#include
+#include
namespace WebCore {
@@ -483,5 +482,3 @@
};
}
-
-#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213268] trunk/Source/WebKit/win
Title: [213268] trunk/Source/WebKit/win Revision 213268 Author achristen...@apple.com Date 2017-03-01 23:02:54 -0800 (Wed, 01 Mar 2017) Log Message Fix Windows build after r213266 https://bugs.webkit.org/show_bug.cgi?id=169049 * WebFrame.cpp: (WebFrame::invalidate): Modified Paths trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebFrame.cpp Diff Modified: trunk/Source/WebKit/win/ChangeLog (213267 => 213268) --- trunk/Source/WebKit/win/ChangeLog 2017-03-02 06:45:29 UTC (rev 213267) +++ trunk/Source/WebKit/win/ChangeLog 2017-03-02 07:02:54 UTC (rev 213268) @@ -1,3 +1,11 @@ +2017-03-01 Alex Christensen + +Fix Windows build after r213266 +https://bugs.webkit.org/show_bug.cgi?id=169049 + +* WebFrame.cpp: +(WebFrame::invalidate): + 2017-02-27 Per Arne Vollan [Win] Http preload tests are failing. Modified: trunk/Source/WebKit/win/WebFrame.cpp (213267 => 213268) --- trunk/Source/WebKit/win/WebFrame.cpp 2017-03-02 06:45:29 UTC (rev 213267) +++ trunk/Source/WebKit/win/WebFrame.cpp 2017-03-02 07:02:54 UTC (rev 213268) @@ -1067,7 +1067,7 @@ ASSERT(coreFrame); if (Document* document = coreFrame->document()) -document->recalcStyle(Style::Force); +document->resolveStyle(Style::Force); } HRESULT WebFrame::inViewSourceMode(BOOL* flag) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213266] trunk/Source/WebCore
Title: [213266] trunk/Source/WebCore
Revision 213266
Author an...@apple.com
Date 2017-03-01 22:19:04 -0800 (Wed, 01 Mar 2017)
Log Message
Rename recalcStyle to resolveStyle and clean up the signature
https://bugs.webkit.org/show_bug.cgi?id=169049
Reviewed by Sam Weinig.
Move to modern naming.
* dom/Document.cpp:
(WebCore::Document::resolveStyle):
Only two of the possible values are used so pass in a two-value enum.
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::createRenderTree):
(WebCore::Document::finishedParsing):
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::recalcStyle): Deleted.
* dom/Document.h:
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::reportDataReceived):
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::Parent::Parent):
(WebCore::Style::TreeResolver::resolve):
Remove the argument, Document invalidates the document element if everything needs to be re-resolved.
* style/StyleTreeResolver.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/style/StyleTreeResolver.cpp
trunk/Source/WebCore/style/StyleTreeResolver.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (213265 => 213266)
--- trunk/Source/WebCore/ChangeLog 2017-03-02 05:31:57 UTC (rev 213265)
+++ trunk/Source/WebCore/ChangeLog 2017-03-02 06:19:04 UTC (rev 213266)
@@ -1,3 +1,40 @@
+2017-03-01 Antti Koivisto
+
+Rename recalcStyle to resolveStyle and clean up the signature
+https://bugs.webkit.org/show_bug.cgi?id=169049
+
+Reviewed by Sam Weinig.
+
+Move to modern naming.
+
+* dom/Document.cpp:
+(WebCore::Document::resolveStyle):
+
+Only two of the possible values are used so pass in a two-value enum.
+
+(WebCore::Document::updateStyleIfNeeded):
+(WebCore::Document::updateLayoutIgnorePendingStylesheets):
+(WebCore::Document::createRenderTree):
+(WebCore::Document::finishedParsing):
+(WebCore::Document::webkitWillEnterFullScreenForElement):
+(WebCore::Document::recalcStyle): Deleted.
+* dom/Document.h:
+* inspector/InspectorOverlay.cpp:
+(WebCore::InspectorOverlay::update):
+* loader/DocumentWriter.cpp:
+(WebCore::DocumentWriter::reportDataReceived):
+* page/Frame.cpp:
+(WebCore::Frame::setPageAndTextZoomFactors):
+* page/Page.cpp:
+(WebCore::Page::setPageScaleFactor):
+* style/StyleTreeResolver.cpp:
+(WebCore::Style::TreeResolver::Parent::Parent):
+(WebCore::Style::TreeResolver::resolve):
+
+Remove the argument, Document invalidates the document element if everything needs to be re-resolved.
+
+* style/StyleTreeResolver.h:
+
2017-03-01 Alex Christensen
Unreviewed, rolling out r213259.
Modified: trunk/Source/WebCore/dom/Document.cpp (213265 => 213266)
--- trunk/Source/WebCore/dom/Document.cpp 2017-03-02 05:31:57 UTC (rev 213265)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-03-02 06:19:04 UTC (rev 213266)
@@ -1737,7 +1737,7 @@
return m_styleRecalcTimer.isActive() && m_pendingStyleRecalcShouldForce;
}
-void Document::recalcStyle(Style::Change change)
+void Document::resolveStyle(ResolveStyleType type)
{
ASSERT(!view() || !view()->isPainting());
@@ -1778,9 +1778,9 @@
WidgetHierarchyUpdatesSuspensionScope suspendWidgetHierarchyUpdates;
if (m_pendingStyleRecalcShouldForce)
-change = Style::Force;
+type = ResolveStyleType::Rebuild;
-if (change == Style::Force) {
+if (type == ResolveStyleType::Rebuild) {
// This may get set again during style resolve.
m_hasNodesWithPlaceholderStyle = false;
@@ -1794,10 +1794,13 @@
auto documentChange = Style::determineChange(documentStyle, m_renderView->style());
if (documentChange != Style::NoChange)
renderView()->setStyle(WTFMove(documentStyle));
+
+if (auto* documentElement = this->documentElement())
+documentElement->invalidateStyleForSubtree();
}
Style::TreeResolver resolver(*this);
-auto styleUpdate = resolver.resolve(change);
+auto styleUpdate = resolver.resolve();
m_lastStyleUpdateSizeForTesting = styleUpdate ? styleUpdate->size() : 0;
@@ -1867,7 +1870,7 @@
if (!needsStyleRecalc())
return;
-recalcStyle();
+resolveStyle();
}
[webkit-changes] [213265] trunk/LayoutTests
Title: [213265] trunk/LayoutTests
Revision 213265
Author grao...@webkit.org
Date 2017-03-01 21:31:57 -0800 (Wed, 01 Mar 2017)
Log Message
LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168378
Reviewed by Simon Fraser.
Use asynchronous assertions to improve robustness. Since this test should no longer be flaky, remove it
from the list of flaky tests.
* media/modern-media-controls/media-controller/media-controller-resize-expected.txt:
* media/modern-media-controls/media-controller/media-controller-resize.html:
* platform/mac-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize-expected.txt
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html
trunk/LayoutTests/platform/mac-wk1/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (213264 => 213265)
--- trunk/LayoutTests/ChangeLog 2017-03-02 05:26:21 UTC (rev 213264)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 05:31:57 UTC (rev 213265)
@@ -1,5 +1,20 @@
2017-03-01 Antoine Quint
+LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=168378
+
+
+Reviewed by Simon Fraser.
+
+Use asynchronous assertions to improve robustness. Since this test should no longer be flaky, remove it
+from the list of flaky tests.
+
+* media/modern-media-controls/media-controller/media-controller-resize-expected.txt:
+* media/modern-media-controls/media-controller/media-controller-resize.html:
+* platform/mac-wk1/TestExpectations:
+
+2017-03-01 Antoine Quint
+
[mac-wk1] LayoutTest media/modern-media-controls/tracks-button/tracks-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168476
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize-expected.txt (213264 => 213265)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize-expected.txt 2017-03-02 05:26:21 UTC (rev 213264)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize-expected.txt 2017-03-02 05:31:57 UTC (rev 213265)
@@ -8,11 +8,9 @@
PASS mediaControls.style.height is "240px"
Resizing to 400x300
+PASS mediaControls.style.width became "400px"
+PASS mediaControls.style.height became "300px"
-Shadow root received a resize event
-PASS mediaControls.style.width is "400px"
-PASS mediaControls.style.height is "300px"
-
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html (213264 => 213265)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html 2017-03-02 05:26:21 UTC (rev 213264)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html 2017-03-02 05:31:57 UTC (rev 213265)
@@ -16,24 +16,17 @@
shouldBeEqualToString("mediaControls.style.width", "320px");
shouldBeEqualToString("mediaControls.style.height", "240px");
-window.requestAnimationFrame(() => {
-shadowRoot.addEventListener("resize", () => {
-window.requestAnimationFrame(() => {
-debug("");
-debug("Shadow root received a resize event");
-shouldBeEqualToString("mediaControls.style.width", "400px");
-shouldBeEqualToString("mediaControls.style.height", "300px");
+debug("");
+debug("Resizing to 400x300");
+media.style.width = "400px";
+media.style.height = "300px";
-debug("");
-media.remove();
-finishJSTest();
-});
+shouldBecomeEqualToString("mediaControls.style.width", "400px", () => {
+shouldBecomeEqualToString("mediaControls.style.height", "300px", () => {
+debug("");
+media.remove();
+finishJSTest();
});
-
-debug("");
-debug("Resizing to 400x300");
-media.style.width = "400px";
-media.style.height = "300px";
});
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (213264 => 213265)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-02 05:26:21 UTC (rev 213264)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-02 05:31:57 UTC (rev 213265)
@@ -320,5 +320,3 @@
webkit.org/b/167127 pointer-lock/locked-element-removed-from-dom.html
webkit.org/b/167857 pageoverlay/overlay-remove-reinsert-view.html [ Skip ]
-
-webkit.org/b/168378 media/modern-media-controls/media-controller/media-controller-resize.html [ Pass Failure ]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213264] trunk/LayoutTests
Title: [213264] trunk/LayoutTests
Revision 213264
Author commit-qu...@webkit.org
Date 2017-03-01 21:26:21 -0800 (Wed, 01 Mar 2017)
Log Message
[mac-wk1] LayoutTest media/modern-media-controls/tracks-button/tracks-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168476
Patch by Antoine Quint on 2017-03-01
Reviewed by Jon Lee.
Write all tests as asynchronous assertions to improve robustness. Since this test should no longer be flaky,
mark it as Pass on platforms where it was marked as flaky.
* media/modern-media-controls/tracks-button/tracks-button-expected.txt:
* media/modern-media-controls/tracks-button/tracks-button.html:
* platform/mac-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt
trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html
trunk/LayoutTests/platform/mac-wk1/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (213263 => 213264)
--- trunk/LayoutTests/ChangeLog 2017-03-02 05:24:12 UTC (rev 213263)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 05:26:21 UTC (rev 213264)
@@ -1,5 +1,20 @@
2017-03-01 Antoine Quint
+[mac-wk1] LayoutTest media/modern-media-controls/tracks-button/tracks-button.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=168476
+
+
+Reviewed by Jon Lee.
+
+Write all tests as asynchronous assertions to improve robustness. Since this test should no longer be flaky,
+mark it as Pass on platforms where it was marked as flaky.
+
+* media/modern-media-controls/tracks-button/tracks-button-expected.txt:
+* media/modern-media-controls/tracks-button/tracks-button.html:
+* platform/mac-wk1/TestExpectations:
+
+2017-03-01 Antoine Quint
+
[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168409
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt (213263 => 213264)
--- trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt 2017-03-02 05:24:12 UTC (rev 213263)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt 2017-03-02 05:26:21 UTC (rev 213264)
@@ -7,8 +7,8 @@
PASS tracksButton.element.classList.contains("icon") is true
PASS tracksButton.element.classList.contains("tracks") is true
PASS tracksButton.iconName is "media-selection"
-PASS tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@") is true
-PASS fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@") is true
+PASS tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@") became true
+PASS fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@") became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html (213263 => 213264)
--- trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html 2017-03-02 05:24:12 UTC (rev 213263)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html 2017-03-02 05:26:21 UTC (rev 213264)
@@ -17,16 +17,10 @@
const fullscreenTracksButton = new TracksButton({ layoutTraits: LayoutTraits.macOS | LayoutTraits.Fullscreen });
-scheduler.frameDidFire = function()
-{
-if ([tracksButton, fullscreenTracksButton].some(button => button.width == 0))
-return;
+shouldBecomeEqual('tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@")', "true", () => {
+shouldBecomeEqual('fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@")', "true", finishJSTest);
+});
-shouldBeTrue('tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@")');
-shouldBeTrue('fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@")');
-finishMediaControlsTest();
-};
-
[webkit-changes] [213263] trunk/LayoutTests
Title: [213263] trunk/LayoutTests
Revision 213263
Author commit-qu...@webkit.org
Date 2017-03-01 21:24:12 -0800 (Wed, 01 Mar 2017)
Log Message
[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168409
Patch by Antoine Quint on 2017-03-01
Reviewed by Jon Lee.
Write all tests as asynchronous assertions to improve robustness. Since this test should no longer be flaky,
mark it as Pass on platforms where it was marked as flaky.
* media/modern-media-controls/airplay-button/airplay-button-expected.txt:
* media/modern-media-controls/airplay-button/airplay-button.html:
* platform/mac-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt
trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html
trunk/LayoutTests/platform/mac-wk1/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (213262 => 213263)
--- trunk/LayoutTests/ChangeLog 2017-03-02 05:10:56 UTC (rev 213262)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 05:24:12 UTC (rev 213263)
@@ -1,5 +1,20 @@
2017-03-01 Antoine Quint
+[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=168409
+
+
+Reviewed by Jon Lee.
+
+Write all tests as asynchronous assertions to improve robustness. Since this test should no longer be flaky,
+mark it as Pass on platforms where it was marked as flaky.
+
+* media/modern-media-controls/airplay-button/airplay-button-expected.txt:
+* media/modern-media-controls/airplay-button/airplay-button.html:
+* platform/mac-wk1/TestExpectations:
+
+2017-03-01 Antoine Quint
+
LayoutTest media/modern-media-controls/pip-button/pip-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167350
Modified: trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt (213262 => 213263)
--- trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt 2017-03-02 05:10:56 UTC (rev 213262)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt 2017-03-02 05:24:12 UTC (rev 213263)
@@ -7,9 +7,9 @@
PASS airplayButton.element.classList.contains("icon") is true
PASS airplayButton.element.classList.contains("airplay") is true
PASS airplayButton.iconName is "airplay"
-PASS airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@") is true
-PASS macOSFullscreenAirplayButton.element.style.webkitMaskImage.includes("macOS/airplay-fullscreen@") is true
-PASS iOSAirplayButton.element.style.webkitMaskImage.includes("iOS/airplay@") is true
+PASS airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@") became true
+PASS macOSFullscreenAirplayButton.element.style.webkitMaskImage.includes("macOS/airplay-fullscreen@") became true
+PASS iOSAirplayButton.element.style.webkitMaskImage.includes("iOS/airplay@") became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html (213262 => 213263)
--- trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html 2017-03-02 05:10:56 UTC (rev 213262)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html 2017-03-02 05:24:12 UTC (rev 213263)
@@ -19,18 +19,12 @@
const iOSAirplayButton = new AirplayButton({ layoutTraits: LayoutTraits.iOS });
-scheduler.frameDidFire = function()
-{
-if ([airplayButton, macOSFullscreenAirplayButton, iOSAirplayButton].some(button => button.width == 0))
-return;
+shouldBecomeEqual('airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@")', "true", () => {
+shouldBecomeEqual('macOSFullscreenAirplayButton.element.style.webkitMaskImage.includes("macOS/airplay-fullscreen@")', "true", () => {
+shouldBecomeEqual('iOSAirplayButton.element.style.webkitMaskImage.includes("iOS/airplay@")', "true", finishJSTest);
+});
+});
-shouldBeTrue('airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@")');
-shouldBeTrue('macOSFullscreenAirplayButton.element.style.webkitMaskImage.includes("macOS/airplay-fullscreen@")');
-shouldBeTrue('iOSAirplayButton.element.style.webkitMaskImage.includes("iOS/airplay@")');
-
-finishJSTest();
-};
-
[webkit-changes] [213262] trunk/LayoutTests
Title: [213262] trunk/LayoutTests
Revision 213262
Author commit-qu...@webkit.org
Date 2017-03-01 21:10:56 -0800 (Wed, 01 Mar 2017)
Log Message
LayoutTest media/modern-media-controls/pip-button/pip-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167350
Patch by Antoine Quint on 2017-03-01
Reviewed by Jon Lee.
Write both tests as asynchronous assertions to improve robustness.
* media/modern-media-controls/pip-button/pip-button-expected.txt:
* media/modern-media-controls/pip-button/pip-button.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button-expected.txt
trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html
Diff
Modified: trunk/LayoutTests/ChangeLog (213261 => 213262)
--- trunk/LayoutTests/ChangeLog 2017-03-02 04:37:55 UTC (rev 213261)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 05:10:56 UTC (rev 213262)
@@ -1,5 +1,18 @@
2017-03-01 Antoine Quint
+LayoutTest media/modern-media-controls/pip-button/pip-button.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=167350
+
+
+Reviewed by Jon Lee.
+
+Write both tests as asynchronous assertions to improve robustness.
+
+* media/modern-media-controls/pip-button/pip-button-expected.txt:
+* media/modern-media-controls/pip-button/pip-button.html:
+
+2017-03-01 Antoine Quint
+
[mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168934
Modified: trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button-expected.txt (213261 => 213262)
--- trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button-expected.txt 2017-03-02 04:37:55 UTC (rev 213261)
+++ trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button-expected.txt 2017-03-02 05:10:56 UTC (rev 213262)
@@ -7,8 +7,9 @@
PASS pipButton.element.classList.contains("icon") is true
PASS pipButton.element.classList.contains("pip") is true
PASS pipButton.iconName is "pip-in"
-PASS pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@") is true
-PASS iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@") is true
+PASS pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@") became true
+PASS iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@") became true
+
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html (213261 => 213262)
--- trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html 2017-03-02 04:37:55 UTC (rev 213261)
+++ trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html 2017-03-02 05:10:56 UTC (rev 213262)
@@ -17,16 +17,13 @@
const iOSPiPButton = new PiPButton({ layoutTraits: LayoutTraits.iOS });
-scheduler.frameDidFire = function()
-{
-if ([pipButton, iOSPiPButton].some(button => button.width == 0))
-return;
+shouldBecomeEqual('pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@")', "true", () => {
+shouldBecomeEqual('iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@")', "true", () => {
+debug("");
+finishJSTest();
+});
+});
-shouldBeTrue('pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@")');
-shouldBeTrue('iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@")');
-finishMediaControlsTest();
-};
-
[webkit-changes] [213261] trunk/LayoutTests
Title: [213261] trunk/LayoutTests Revision 213261 Author commit-qu...@webkit.org Date 2017-03-01 20:37:55 -0800 (Wed, 01 Mar 2017) Log Message [mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=168934 Patch by Antoine Quint on 2017-03-01 Reviewed by Jon Lee. Use asynchronous assertions to determine when it's safe to test button styles. We do this across a family of tests that are all essentially doing the same thing for various media controls configurations. Only one was reported as flaky, but others would show up on the flakiness dashboard. * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles-expected.txt: * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html: * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt: * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html: * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles-expected.txt: * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html: * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles-expected.txt: * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles-expected.txt trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles-expected.txt trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles-expected.txt trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles.html Diff Modified: trunk/LayoutTests/ChangeLog (213260 => 213261) --- trunk/LayoutTests/ChangeLog 2017-03-02 04:34:33 UTC (rev 213260) +++ trunk/LayoutTests/ChangeLog 2017-03-02 04:37:55 UTC (rev 213261) @@ -1,5 +1,26 @@ 2017-03-01 Antoine Quint +[mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=168934 + + +Reviewed by Jon Lee. + +Use asynchronous assertions to determine when it's safe to test button styles. We do this across a family of tests +that are all essentially doing the same thing for various media controls configurations. Only one was reported as +flaky, but others would show up on the flakiness dashboard. + +* media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles-expected.txt: +* media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html: +* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt: +* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html: +* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles-expected.txt: +* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html: +* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles-expected.txt: +* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles.html: + +2017-03-01 Antoine Quint + LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky https://bugs.webkit.org/show_bug.cgi?id=168935 Modified: trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles-expected.txt (213260 => 213261) --- trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles-expected.txt 2017-03-02 04:34
[webkit-changes] [213260] trunk
Title: [213260] trunk Revision 213260 Author achristen...@apple.com Date 2017-03-01 20:34:33 -0800 (Wed, 01 Mar 2017) Log Message Unreviewed, rolling out r213259. Broke an internal build Reverted changeset: "Continue enabling WebRTC" https://bugs.webkit.org/show_bug.cgi?id=169056 http://trac.webkit.org/changeset/213259 Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (213259 => 213260) --- trunk/Source/_javascript_Core/ChangeLog 2017-03-02 03:48:41 UTC (rev 213259) +++ trunk/Source/_javascript_Core/ChangeLog 2017-03-02 04:34:33 UTC (rev 213260) @@ -1,5 +1,17 @@ 2017-03-01 Alex Christensen +Unreviewed, rolling out r213259. + +Broke an internal build + +Reverted changeset: + +"Continue enabling WebRTC" +https://bugs.webkit.org/show_bug.cgi?id=169056 +http://trac.webkit.org/changeset/213259 + +2017-03-01 Alex Christensen + Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=169056 Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (213259 => 213260) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-03-02 03:48:41 UTC (rev 213259) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-03-02 04:34:33 UTC (rev 213260) @@ -165,9 +165,11 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS; ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios); -ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) -ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) -ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC; +ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) +ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) +ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC; +ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC; +ENABLE_WEB_RTC_ios_11_Production = ; ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx); ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION)); ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; Modified: trunk/Source/WebCore/ChangeLog (213259 => 213260) --- trunk/Source/WebCore/ChangeLog 2017-03-02 03:48:41 UTC (rev 213259) +++ trunk/Source/WebCore/ChangeLog 2017-03-02 04:34:33 UTC (rev 213260) @@ -1,5 +1,17 @@ 2017-03-01 Alex Christensen +Unreviewed, rolling out r213259. + +Broke an internal build + +Reverted changeset: + +"Continue enabling WebRTC" +https://bugs.webkit.org/show_bug.cgi?id=169056 +http://trac.webkit.org/changeset/213259 + +2017-03-01 Alex Christensen + Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=169056 Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (213259 => 213260) --- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-03-02 03:48:41 UTC (rev 213259) +++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-03-02 04:34:33 UTC (rev 213260) @@ -165,9 +165,11 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS; ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios); -ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) -ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) -ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC; +ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) +ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) +ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC; +ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC; +ENABLE_WEB_RTC_ios_11_Production = ; ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx); ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION)); ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; Modified: trunk/Source/WebCore/PAL/ChangeLog (213259 => 213260) --- trunk/Source/WebCore/PAL/ChangeLog 2017-03-02 03:48:41 UTC (rev 213259) +++ trunk/Source/WebCore/PAL/ChangeLog 2017-03-02 04:34:33 UTC (rev 213260) @@ -1,5 +1,17 @@ 2017-03-01 Alex Christensen +Unreviewed, rolling out r213259. + +Broke an internal build + +Reverted changeset: + +"Continue e
[webkit-changes] [213259] trunk
Title: [213259] trunk Revision 213259 Author achristen...@apple.com Date 2017-03-01 19:48:41 -0800 (Wed, 01 Mar 2017) Log Message Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=169056 Reviewed by Jon Lee. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Source/WebKit2: * Configurations/FeatureDefines.xcconfig: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (213258 => 213259) --- trunk/Source/_javascript_Core/ChangeLog 2017-03-02 03:46:01 UTC (rev 213258) +++ trunk/Source/_javascript_Core/ChangeLog 2017-03-02 03:48:41 UTC (rev 213259) @@ -1,3 +1,12 @@ +2017-03-01 Alex Christensen + +Continue enabling WebRTC +https://bugs.webkit.org/show_bug.cgi?id=169056 + +Reviewed by Jon Lee. + +* Configurations/FeatureDefines.xcconfig: + 2017-03-01 Michael Saboff Source/_javascript_Core/ChangeLog Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (213258 => 213259) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-03-02 03:46:01 UTC (rev 213258) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-03-02 03:48:41 UTC (rev 213259) @@ -165,11 +165,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS; ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios); -ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) -ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) -ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC; -ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC; -ENABLE_WEB_RTC_ios_11_Production = ; +ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) +ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) +ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC; ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx); ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION)); ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; Modified: trunk/Source/WebCore/ChangeLog (213258 => 213259) --- trunk/Source/WebCore/ChangeLog 2017-03-02 03:46:01 UTC (rev 213258) +++ trunk/Source/WebCore/ChangeLog 2017-03-02 03:48:41 UTC (rev 213259) @@ -1,3 +1,12 @@ +2017-03-01 Alex Christensen + +Continue enabling WebRTC +https://bugs.webkit.org/show_bug.cgi?id=169056 + +Reviewed by Jon Lee. + +* Configurations/FeatureDefines.xcconfig: + 2017-03-01 Chris Dumez [WK2][!NETWORK_SESSION] Failure to download when using a download attribute with no value on an anchor Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (213258 => 213259) --- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-03-02 03:46:01 UTC (rev 213258) +++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-03-02 03:48:41 UTC (rev 213259) @@ -165,11 +165,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS; ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios); -ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) -ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION)) -ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC; -ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC; -ENABLE_WEB_RTC_ios_11_Production = ; +ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) +ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)) +ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC; ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx); ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION)); ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; Modified: trunk/Source/WebCore/PAL/ChangeLog (213258 => 213259) --- trunk/Source/WebCore/PAL/ChangeLog 2017-03-02 03:46:01 UTC (rev 213258) +++ trunk/Source/WebCore/PAL/ChangeLog 2017-03-02 03:48:41 UTC (rev 213259) @@ -1,3 +1,12 @@ +2017-03-01 Alex Christensen + +Continue enabling WebRTC +
[webkit-changes] [213258] trunk/LayoutTests
Title: [213258] trunk/LayoutTests
Revision 213258
Author commit-qu...@webkit.org
Date 2017-03-01 19:46:01 -0800 (Wed, 01 Mar 2017)
Log Message
LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=168935
Patch by Antoine Quint on 2017-03-01
Reviewed by Dean Jackson.
Use asynchronous assertions to guarantee we've entered fullscreen and the volume down button
is present and leave a little room for error when checking the volume since we would sometime
see a value of 0.009 rather than 0.
* media/modern-media-controls/volume-down-support/volume-down-support-expected.txt:
* media/modern-media-controls/volume-down-support/volume-down-support.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt
trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html
Diff
Modified: trunk/LayoutTests/ChangeLog (213257 => 213258)
--- trunk/LayoutTests/ChangeLog 2017-03-02 02:44:58 UTC (rev 213257)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 03:46:01 UTC (rev 213258)
@@ -1,5 +1,20 @@
2017-03-01 Antoine Quint
+LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=168935
+
+
+Reviewed by Dean Jackson.
+
+Use asynchronous assertions to guarantee we've entered fullscreen and the volume down button
+is present and leave a little room for error when checking the volume since we would sometime
+see a value of 0.009 rather than 0.
+
+* media/modern-media-controls/volume-down-support/volume-down-support-expected.txt:
+* media/modern-media-controls/volume-down-support/volume-down-support.html:
+
+2017-03-01 Antoine Quint
+
[mac-wk1] LayoutTest media/modern-media-controls/seek-backward-support/seek-backward-support.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=165386
Modified: trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt (213257 => 213258)
--- trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt 2017-03-02 02:44:58 UTC (rev 213257)
+++ trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt 2017-03-02 03:46:01 UTC (rev 213258)
@@ -3,10 +3,12 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+PASS !!window.internals.shadowRoot(media).lastChild.querySelector("button.volume-down") became true
+PASS media.webkitDisplayingFullscreen is true
PASS media.volume is 1
Pressing on the volume down button
-PASS media.volume is 0
+PASS media.volume is within 0.1 of 0
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html (213257 => 213258)
--- trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html 2017-03-02 02:44:58 UTC (rev 213257)
+++ trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html 2017-03-02 03:46:01 UTC (rev 213258)
@@ -13,45 +13,26 @@
const media = document.querySelector("video");
const button = document.body.appendChild(document.createElement("button"));
-media.addEventListener("webkitfullscreenchange", function() {
-if (media.webkitDisplayingFullscreen) {
-window.requestAnimationFrame(() => {
-window.requestAnimationFrame(() => {
-shouldBe("media.volume", "1");
+button.addEventListener("click", () => media.webkitEnterFullscreen());
-media.addEventListener("volumechange", () => {
-shouldBe("media.volume", "0");
-debug("");
-media.remove();
-button.remove();
-finishJSTest();
-});
+media.addEventListener("loadedmetadata", () => {
+pressOnElement(button);
+shouldBecomeEqual('!!window.internals.shadowRoot(media).lastChild.querySelector("button.volume-down")', "true", () => {
+shouldBeTrue("media.webkitDisplayingFullscreen");
+shouldBe("media.volume", "1");
-debug("");
-debug("Pressing on the volume down button");
-pressOnElement(window.internals.shadowRoot(media).lastElementChild.lastElementChild.querySelector("button.volume-down"));
-});
+media.addEventListener("volumechange", () => {
+shouldBeCloseTo("media.volume", 0, 0.1);
+debug("");
+media.remove();
+button.remove();
+finishJSTest();
});
-}
-});
-media.addEventListener("loadedmetadata", () => {
-if (!("eventSender" in window)) {
-debug("This test is designed to run in
[webkit-changes] [213257] trunk/LayoutTests
Title: [213257] trunk/LayoutTests
Revision 213257
Author commit-qu...@webkit.org
Date 2017-03-01 18:44:58 -0800 (Wed, 01 Mar 2017)
Log Message
[mac-wk1] LayoutTest media/modern-media-controls/seek-backward-support/seek-backward-support.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=165386
Patch by Antoine Quint on 2017-03-01
Reviewed by Jon Lee.
We rewrite the test to use asynchronous assertions and key off the various steps needed to enter fullscreen
and start pressing the skip back button. We also no longer expect a specific currentTime to be reached but
only check that pressing the skip back button eventually gets us far enough in the past.
* media/modern-media-controls/seek-backward-support/seek-backward-support-expected.txt:
* media/modern-media-controls/seek-backward-support/seek-backward-support.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support-expected.txt
trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support.html
Diff
Modified: trunk/LayoutTests/ChangeLog (213256 => 213257)
--- trunk/LayoutTests/ChangeLog 2017-03-02 02:43:28 UTC (rev 213256)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 02:44:58 UTC (rev 213257)
@@ -1,5 +1,20 @@
2017-03-01 Antoine Quint
+[mac-wk1] LayoutTest media/modern-media-controls/seek-backward-support/seek-backward-support.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=165386
+
+
+Reviewed by Jon Lee.
+
+We rewrite the test to use asynchronous assertions and key off the various steps needed to enter fullscreen
+and start pressing the skip back button. We also no longer expect a specific currentTime to be reached but
+only check that pressing the skip back button eventually gets us far enough in the past.
+
+* media/modern-media-controls/seek-backward-support/seek-backward-support-expected.txt:
+* media/modern-media-controls/seek-backward-support/seek-backward-support.html:
+
+2017-03-01 Antoine Quint
+
LayoutTest media/modern-media-controls/seek-forward-support/seek-forward-support.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168943
Modified: trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support-expected.txt (213256 => 213257)
--- trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support-expected.txt 2017-03-02 02:43:28 UTC (rev 213256)
+++ trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support-expected.txt 2017-03-02 02:44:58 UTC (rev 213257)
@@ -3,13 +3,15 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-Media entered fullscreen
+PASS !!window.internals.shadowRoot(media).lastChild.querySelector("button.rewind") became true
+PASS media.webkitDisplayingFullscreen is true
+
Setting media.currentTime to 5s
PASS media.currentTime is 5
PASS media.paused is true
-Media was rewinded for 1 second
-PASS media.currentTime < 4 is true
+Starting to press on the skip back button
+PASS media.currentTime < 4.5 became true
PASS media.paused is true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support.html (213256 => 213257)
--- trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support.html 2017-03-02 02:43:28 UTC (rev 213256)
+++ trunk/LayoutTests/media/modern-media-controls/seek-backward-support/seek-backward-support.html 2017-03-02 02:44:58 UTC (rev 213257)
@@ -1,5 +1,6 @@
+