[webkit-changes] [239435] trunk

[commit-queue]

Title: [239435] trunk








Revision 239435
Author commit-qu...@webkit.org
Date 2018-12-19 23:36:00 -0800 (Wed, 19 Dec 2018)


Log Message
Unreviewed, rolling out r239377.
https://bugs.webkit.org/show_bug.cgi?id=192921

broke 32-bit JSC tests (Requested by keith_miller on #webkit).

Reverted changeset:

"[BigInt] We should enable CSE into arithmetic operations that
speculate BigIntUse"
https://bugs.webkit.org/show_bug.cgi?id=192723
https://trac.webkit.org/changeset/239377

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp


Removed Paths

trunk/PerformanceTests/BigIntBench/big-int-cse.js
trunk/PerformanceTests/BigIntBench/big-int-global-cse.js
trunk/PerformanceTests/BigIntBench/big-int-licm.js




Diff

Deleted: trunk/PerformanceTests/BigIntBench/big-int-cse.js (239434 => 239435)

--- trunk/PerformanceTests/BigIntBench/big-int-cse.js	2018-12-20 07:01:36 UTC (rev 239434)
+++ trunk/PerformanceTests/BigIntBench/big-int-cse.js	2018-12-20 07:36:00 UTC (rev 239435)
@@ -1,103 +0,0 @@
-function assert(a, e) {
-if (a !== e)
-throw new Error("Expected " + e + " but got: " + a);
-}
-
-function bigIntAdd(a, b) {
-let c = a + b;
-return b + a + c;
-}
-noInline(bigIntAdd);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntAdd(3n, 5n), 16n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntAdd(0xffn, 0xaaffn), 1624494070107157953511420n);
-}
-
-function bigIntMul(a, b) {
-let c = a * b;
-return b * a + c;
-}
-noInline(bigIntMul);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntMul(3n, 5n), 30n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntMul(0xffn, 0xaaffn), 7626854857897473114403591155175632477091790850n);
-}
-
-function bigIntDiv(a, b) {
-let c = a / b;
-return a / b + c;
-}
-noInline(bigIntDiv);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntDiv(15n, 5n), 6n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntDiv(0xaaffn, 0xffn), 342n);
-}
-
-function bigIntSub(a, b) {
-let c = a - b;
-return a - b + c;
-}
-noInline(bigIntSub);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntSub(15n, 5n), 20n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntSub(0xaaffn, 0xffn), 1605604604175679372656640n);
-}
-
-function bigIntBitOr(a, b) {
-let c = a | b;
-return (b | a) + c;
-}
-noInline(bigIntBitOr);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntBitOr(0b1101n, 0b0010n), 30n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntBitOr(0xaaffn, 0xffn), 1615049337141418663084030n);
-}
-
-function bigIntBitAnd(a, b) {
-let c = a & b;
-return (b & a) + c;
-}
-noInline(bigIntBitAnd);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntBitAnd(0b1101n, 0b0010n), 0n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntBitAnd(0xaaffn, 0xffn), 9444732965739290427390n);
-}
-
-function bigIntBitXor(a, b) {
-let c = a ^ b;
-return (b ^ a) + c;
-}
-noInline(bigIntBitXor);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntBitXor(0b1101n, 0b0010n), 30n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntBitXor(0xaaffn, 0xffn), 1605604604175679372656640n);
-}
-


Deleted: trunk/PerformanceTests/BigIntBench/big-int-global-cse.js (239434 => 239435)

--- trunk/PerformanceTests/BigIntBench/big-int-global-cse.js	2018-12-20 07:01:36 UTC (rev 239434)
+++ trunk/PerformanceTests/BigIntBench/big-int-global-cse.js	2018-12-20 07:36:00 UTC (rev 239435)
@@ -1,124 +0,0 @@
-function assert(a, e) {
-if (a !== e)
-throw new Error("Expected " + e + " but got: " + a);
-}
-
-function bigIntAdd(a, b) {
-let c = a + b;
-if (b) {
-assert(c, a + b);
-}
-return a + b + c;
-}
-noInline(bigIntAdd);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntAdd(3n, 5n), 16n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntAdd(0xffn, 0xaaffn), 1624494070107157953511420n);
-}
-
-function bigIntMul(a, b) {
-let c = a * b;
-if (b) {
-assert(c, a * b);
-}
-return a * b + c;
-}
-noInline(bigIntMul);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntMul(3n, 5n), 30n);
-}
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntMul(0xffn, 0xaaffn), 7626854857897473114403591155175632477091790850n);
-}
-
-function bigIntDiv(a, b) {
-let c = a / b;
-if (b) {
-assert(c, a / b);
-}
-return a / b + c;
-}
-noInline(bigIntDiv);
-
-for (let i = 0; i < 10; i++) {
-assert(bigIntDiv(15n, 5n), 6n);
-}
-
-for 

[webkit-changes] [239434] releases/Apple

[mitz]

Title: [239434] releases/Apple








Revision 239434
Author m...@apple.com
Date 2018-12-19 23:01:36 -0800 (Wed, 19 Dec 2018)


Log Message
Added a tag for Safari Technology Preview release 72.

Added Paths

releases/Apple/Safari Technology Preview 72/
releases/Apple/Safari Technology Preview 72/ANGLE/
releases/Apple/Safari Technology Preview 72/_javascript_Core/
releases/Apple/Safari Technology Preview 72/WTF/
releases/Apple/Safari Technology Preview 72/WebCore/
releases/Apple/Safari Technology Preview 72/WebInspectorUI/
releases/Apple/Safari Technology Preview 72/WebKit/
releases/Apple/Safari Technology Preview 72/WebKitLegacy/
releases/Apple/Safari Technology Preview 72/bmalloc/
releases/Apple/Safari Technology Preview 72/libwebrtc/




Diff
Index: releases/Apple/Safari Technology Preview 72/ANGLE
===
--- tags/Safari-607.1.17.1/Source/ThirdParty/ANGLE	2018-12-20 06:48:32 UTC (rev 239433)
+++ releases/Apple/Safari Technology Preview 72/ANGLE	2018-12-20 07:01:36 UTC (rev 239434)

Property changes: releases/Apple/Safari Technology Preview 72/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 72/_javascript_Core
===
--- tags/Safari-607.1.17.1/Source/_javascript_Core	2018-12-20 06:48:32 UTC (rev 239433)
+++ releases/Apple/Safari Technology Preview 72/_javascript_Core	2018-12-20 07:01:36 UTC (rev 239434)

Property changes: releases/Apple/Safari Technology Preview 72/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 72/WTF
===
--- tags/Safari-607.1.17.1/Source/WTF	2018-12-20 06:48:32 UTC (rev 239433)
+++ releases/Apple/Safari Technology Preview 72/WTF	2018-12-20 07:01:36 UTC (rev 239434)

Property changes: releases/Apple/Safari Technology Preview 72/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 72/WebInspectorUI
===
--- tags/Safari-607.1.17.1/Source/WebInspectorUI	2018-12-20 06:48:32 UTC (rev 239433)
+++ releases/Apple/Safari Technology Preview 72/WebInspectorUI	2018-12-20 07:01:36 UTC (rev 239434)

Property changes: releases/Apple/Safari Technology Preview 72/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 72/bmalloc
===
--- tags/Safari-607.1.17.1/Source/bmalloc	2018-12-20 06:48:32 UTC (rev 239433)
+++ releases/Apple/Safari Technology Preview 72/bmalloc	2018-12-20 07:01:36 UTC (rev 239434)

Property changes: releases/Apple/Safari Technology Preview 72/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 72/libwebrtc
===
--- tags/Safari-607.1.17.1/Source/ThirdParty/libwebrtc	2018-12-20 06:48:32 UTC (rev 239433)
+++ releases/Apple/Safari Technology Preview 72/libwebrtc	2018-12-20 07:01:36 UTC (rev 239434)

Property changes: releases/Apple/Safari Technology Preview 72/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239432] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [239432] trunk/Source/WebInspectorUI








Revision 239432
Author nvasil...@apple.com
Date 2018-12-19 22:39:19 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: "E" icon on debugger dashboard is too close to current function name
https://bugs.webkit.org/show_bug.cgi?id=192915

Reviewed by Matt Baker.

* UserInterface/Views/DebuggerDashboardView.css:
(.dashboard.debugger > .location):
(body[dir=ltr] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon)):
(body[dir=rtl] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon)):
(.dashboard.debugger > .location .function-icon): Deleted.
(body[dir=ltr] .dashboard.debugger > .location .function-icon): Deleted.
(body[dir=rtl] .dashboard.debugger > .location .function-icon): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239431 => 239432)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 06:24:05 UTC (rev 239431)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 06:39:19 UTC (rev 239432)
@@ -1,5 +1,20 @@
 2018-12-19  Nikita Vasilyev  
 
+Web Inspector: "E" icon on debugger dashboard is too close to current function name
+https://bugs.webkit.org/show_bug.cgi?id=192915
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/DebuggerDashboardView.css:
+(.dashboard.debugger > .location):
+(body[dir=ltr] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon)):
+(body[dir=rtl] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon)):
+(.dashboard.debugger > .location .function-icon): Deleted.
+(body[dir=ltr] .dashboard.debugger > .location .function-icon): Deleted.
+(body[dir=rtl] .dashboard.debugger > .location .function-icon): Deleted.
+
+2018-12-19  Nikita Vasilyev  
+
 Web Inspector: Dark Mode: ThreadTreeElement status icon is hard to see when hovered
 https://bugs.webkit.org/show_bug.cgi?id=192097
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css (239431 => 239432)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css	2018-12-20 06:24:05 UTC (rev 239431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css	2018-12-20 06:39:19 UTC (rev 239432)
@@ -157,15 +157,15 @@
 height: 16px;
 }
 
-.dashboard.debugger > .location .function-icon {
+.dashboard.debugger > .location {
 --debugger-dashboard-function-icon-margin-end: 3px;
 }
 
-body[dir=ltr] .dashboard.debugger > .location .function-icon {
+body[dir=ltr] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon) {
 margin-right: var(--debugger-dashboard-function-icon-margin-end);
 }
 
-body[dir=rtl] .dashboard.debugger > .location .function-icon {
+body[dir=rtl] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon) {
 margin-left: var(--debugger-dashboard-function-icon-margin-end);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239431] trunk/JSTests

[ross . kirsling]

Title: [239431] trunk/JSTests








Revision 239431
Author ross.kirsl...@sony.com
Date 2018-12-19 22:24:05 -0800 (Wed, 19 Dec 2018)


Log Message
Unreviewed follow-up to r192914.

* test262/expectations.yaml:
Add the last 20 missing expectations.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml




Diff

Modified: trunk/JSTests/ChangeLog (239430 => 239431)

--- trunk/JSTests/ChangeLog	2018-12-20 06:21:06 UTC (rev 239430)
+++ trunk/JSTests/ChangeLog	2018-12-20 06:24:05 UTC (rev 239431)
@@ -1,3 +1,10 @@
+2018-12-19  Ross Kirsling  
+
+Unreviewed follow-up to r192914.
+
+* test262/expectations.yaml:
+Add the last 20 missing expectations.
+
 2018-12-19  Keith Miller  
 
 Fix test262 expectations


Modified: trunk/JSTests/test262/expectations.yaml (239430 => 239431)

--- trunk/JSTests/test262/expectations.yaml	2018-12-20 06:21:06 UTC (rev 239430)
+++ trunk/JSTests/test262/expectations.yaml	2018-12-20 06:24:05 UTC (rev 239431)
@@ -2065,9 +2065,39 @@
 test/intl402/NumberFormat/prototype/format/format-significant-digits.js:
   default: 'Test262Error: Formatted value for -0, en-US-u-nu-arab and options {"useGrouping":false,"minimumSignificantDigits":3,"maximumSignificantDigits":5} is ٠٫٠٠; expected ؜-٠٫٠٠.'
   strict mode: 'Test262Error: Formatted value for -0, en-US-u-nu-arab and options {"useGrouping":false,"minimumSignificantDigits":3,"maximumSignificantDigits":5} is ٠٫٠٠; expected ؜-٠٫٠٠.'
+test/intl402/NumberFormat/prototype/formatToParts/default-parameter.js:
+  default: "TypeError: nf.formatToParts is not a function. (In 'nf.formatToParts()', 'nf.formatToParts' is undefined)"
+  strict mode: "TypeError: nf.formatToParts is not a function. (In 'nf.formatToParts()', 'nf.formatToParts' is undefined)"
+test/intl402/NumberFormat/prototype/formatToParts/formatToParts.js:
+  default: 'Test262Error: `typeof Intl.NumberFormat.prototype.formatToParts` is `function` Expected SameValue(«undefined», «function») to be true'
+  strict mode: 'Test262Error: `typeof Intl.NumberFormat.prototype.formatToParts` is `function` Expected SameValue(«undefined», «function») to be true'
+test/intl402/NumberFormat/prototype/formatToParts/length.js:
+  default: "TypeError: undefined is not an object (evaluating 'Intl.NumberFormat.prototype.formatToParts.length')"
+  strict mode: "TypeError: undefined is not an object (evaluating 'Intl.NumberFormat.prototype.formatToParts.length')"
+test/intl402/NumberFormat/prototype/formatToParts/main.js:
+  default: "TypeError: nf.formatToParts is not a function. (In 'nf.formatToParts(value)', 'nf.formatToParts' is undefined)"
+  strict mode: "TypeError: nf.formatToParts is not a function. (In 'nf.formatToParts(value)', 'nf.formatToParts' is undefined)"
+test/intl402/NumberFormat/prototype/formatToParts/name.js:
+  default: "TypeError: undefined is not an object (evaluating 'Intl.NumberFormat.prototype.formatToParts.name')"
+  strict mode: "TypeError: undefined is not an object (evaluating 'Intl.NumberFormat.prototype.formatToParts.name')"
+test/intl402/NumberFormat/prototype/formatToParts/prop-desc.js:
+  default: 'Test262Error: `typeof Intl.NumberFormat.prototype.formatToParts` is `function` Expected SameValue(«undefined», «function») to be true'
+  strict mode: 'Test262Error: `typeof Intl.NumberFormat.prototype.formatToParts` is `function` Expected SameValue(«undefined», «function») to be true'
+test/intl402/NumberFormat/prototype/formatToParts/return-abrupt-tonumber.js:
+  default: 'Test262Error: valueOf Expected a Test262Error but got a TypeError'
+  strict mode: 'Test262Error: valueOf Expected a Test262Error but got a TypeError'
+test/intl402/NumberFormat/prototype/formatToParts/value-tonumber.js:
+  default: "TypeError: nf.formatToParts is not a function. (In 'nf.formatToParts(value)', 'nf.formatToParts' is undefined)"
+  strict mode: "TypeError: nf.formatToParts is not a function. (In 'nf.formatToParts(value)', 'nf.formatToParts' is undefined)"
 test/intl402/NumberFormat/style-unit.js:
   default: 'RangeError: style must be either "decimal", "percent", or "currency"'
   strict mode: 'RangeError: style must be either "decimal", "percent", or "currency"'
+test/intl402/PluralRules/prototype/resolvedOptions/order.js:
+  default: 'Test262Error: Expected [locale, type, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits] and [locale, type, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits, pluralCategories] to have the same contents. undefined'
+  strict mode: 'Test262Error: Expected [locale, type, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits] and [locale, type, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits, 

[webkit-changes] [239430] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [239430] trunk/Source/WebInspectorUI








Revision 239430
Author nvasil...@apple.com
Date 2018-12-19 22:21:06 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: Dark Mode: ThreadTreeElement status icon is hard to see when hovered
https://bugs.webkit.org/show_bug.cgi?id=192097


Reviewed by Matt Baker.

* UserInterface/Views/ThreadTreeElement.css:
(.tree-outline > .item.thread .status-button.resume):
(.tree-outline > .item.thread .status-button.resume:active):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239429 => 239430)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 05:00:30 UTC (rev 239429)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 06:21:06 UTC (rev 239430)
@@ -1,3 +1,15 @@
+2018-12-19  Nikita Vasilyev  
+
+Web Inspector: Dark Mode: ThreadTreeElement status icon is hard to see when hovered
+https://bugs.webkit.org/show_bug.cgi?id=192097
+
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/ThreadTreeElement.css:
+(.tree-outline > .item.thread .status-button.resume):
+(.tree-outline > .item.thread .status-button.resume:active):
+
 2018-12-19  Devin Rousso  
 
 Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'effectiveDOMNode.enabledPseudoClasses')


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css (239429 => 239430)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css	2018-12-20 05:00:30 UTC (rev 239429)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css	2018-12-20 06:21:06 UTC (rev 239430)
@@ -33,13 +33,13 @@
 width: 11px;
 height: 11px;
 vertical-align: middle;
-fill: hsla(0, 0%, 0%, 0.5);
+fill: hsla(0, 0%, var(--foreground-lightness), 0.5);
 stroke: none;
 display: none;
 }
 
 .tree-outline > .item.thread .status-button.resume:active {
-fill: hsla(0, 0%, 0%, 0.7);
+fill: hsla(0, 0%, var(--foreground-lightness), 0.7);
 }
 
 .tree-outline:focus > .item.thread.selected .status-button.resume {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239429] trunk/JSTests

[keith_miller]

Title: [239429] trunk/JSTests








Revision 239429
Author keith_mil...@apple.com
Date 2018-12-19 21:00:30 -0800 (Wed, 19 Dec 2018)


Log Message
Fix test262 expectations
https://bugs.webkit.org/show_bug.cgi?id=192914

Unreviewed, when I imported the latest round of test262 tests I must have failed to update the test expectations.

* test262/expectations.yaml:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml




Diff

Modified: trunk/JSTests/ChangeLog (239428 => 239429)

--- trunk/JSTests/ChangeLog	2018-12-20 04:46:27 UTC (rev 239428)
+++ trunk/JSTests/ChangeLog	2018-12-20 05:00:30 UTC (rev 239429)
@@ -1,5 +1,14 @@
 2018-12-19  Keith Miller  
 
+Fix test262 expectations
+https://bugs.webkit.org/show_bug.cgi?id=192914
+
+Unreviewed, when I imported the latest round of test262 tests I must have failed to update the test expectations.
+
+* test262/expectations.yaml:
+
+2018-12-19  Keith Miller  
+
 Update test262 tests.
 https://bugs.webkit.org/show_bug.cgi?id=192907
 


Modified: trunk/JSTests/test262/expectations.yaml (239428 => 239429)

--- trunk/JSTests/test262/expectations.yaml	2018-12-20 04:46:27 UTC (rev 239428)
+++ trunk/JSTests/test262/expectations.yaml	2018-12-20 05:00:30 UTC (rev 239429)
@@ -1131,36 +1131,60 @@
 test/built-ins/RegExp/named-groups/unicode-property-names.js:
   default: 'SyntaxError: Invalid regular _expression_: invalid group specifier name'
   strict mode: 'SyntaxError: Invalid regular _expression_: invalid group specifier name'
+test/built-ins/RegExp/property-escapes/binary-properties-with-value.js:
+  default: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{ASCII=Yes}/u\")', 'assert.throws.early' is undefined)"
+  strict mode: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{ASCII=Yes}/u\")', 'assert.throws.early' is undefined)"
 test/built-ins/RegExp/property-escapes/character-class-range-end.js:
-  default: "ReferenceError: Can't find variable: $DONOTEVALUATE"
-  strict mode: "ReferenceError: Can't find variable: $DONOTEVALUATE"
+  default: 'Test262: This statement should not be evaluated.'
+  strict mode: 'Test262: This statement should not be evaluated.'
 test/built-ins/RegExp/property-escapes/character-class-range-no-dash-end.js:
-  default: "ReferenceError: Can't find variable: $DONOTEVALUATE"
-  strict mode: "ReferenceError: Can't find variable: $DONOTEVALUATE"
+  default: 'Test262: This statement should not be evaluated.'
+  strict mode: 'Test262: This statement should not be evaluated.'
 test/built-ins/RegExp/property-escapes/character-class-range-no-dash-start.js:
-  default: "ReferenceError: Can't find variable: $DONOTEVALUATE"
-  strict mode: "ReferenceError: Can't find variable: $DONOTEVALUATE"
+  default: 'Test262: This statement should not be evaluated.'
+  strict mode: 'Test262: This statement should not be evaluated.'
 test/built-ins/RegExp/property-escapes/character-class-range-start.js:
-  default: "ReferenceError: Can't find variable: $DONOTEVALUATE"
-  strict mode: "ReferenceError: Can't find variable: $DONOTEVALUATE"
+  default: 'Test262: This statement should not be evaluated.'
+  strict mode: 'Test262: This statement should not be evaluated.'
+test/built-ins/RegExp/property-escapes/grammar-extensions.js:
+  default: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{^General_Category=Letter}/u\")', 'assert.throws.early' is undefined)"
+  strict mode: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{^General_Category=Letter}/u\")', 'assert.throws.early' is undefined)"
+test/built-ins/RegExp/property-escapes/loose-matching.js:
+  default: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{any}/u\")', 'assert.throws.early' is undefined)"
+  strict mode: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{any}/u\")', 'assert.throws.early' is undefined)"
+test/built-ins/RegExp/property-escapes/non-binary-properties-without-value.js:
+  default: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{General_Category}/u\")', 'assert.throws.early' is undefined)"
+  strict mode: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{General_Category}/u\")', 'assert.throws.early' is undefined)"
+test/built-ins/RegExp/property-escapes/non-existent-properties.js:
+  default: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{UnknownBinaryProperty}/u\")', 'assert.throws.early' is undefined)"
+  strict mode: "TypeError: assert.throws.early is not a function. (In 'assert.throws.early(SyntaxError, \"/p{UnknownBinaryProperty}/u\")', 'assert.throws.early' is undefined)"
 

[webkit-changes] [239428] trunk/Source/WebCore

[mcatanzaro]

Title: [239428] trunk/Source/WebCore








Revision 239428
Author mcatanz...@igalia.com
Date 2018-12-19 20:46:27 -0800 (Wed, 19 Dec 2018)


Log Message
Unreviewed, fix GTK build after r239410

It added a new file to the build, breaking the unified sources magic that obscured a bug in
URLSoup.h. It forward-declares URL, but this never worked unless the URL.h header was
included via another source file in the unified source bundle.

* platform/network/soup/URLSoup.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/URLSoup.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (239427 => 239428)

--- trunk/Source/WebCore/ChangeLog	2018-12-20 04:41:11 UTC (rev 239427)
+++ trunk/Source/WebCore/ChangeLog	2018-12-20 04:46:27 UTC (rev 239428)
@@ -1,3 +1,13 @@
+2018-12-19  Michael Catanzaro  
+
+Unreviewed, fix GTK build after r239410
+
+It added a new file to the build, breaking the unified sources magic that obscured a bug in
+URLSoup.h. It forward-declares URL, but this never worked unless the URL.h header was
+included via another source file in the unified source bundle.
+
+* platform/network/soup/URLSoup.h:
+
 2018-12-19  Chris Dumez  
 
 wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from


Modified: trunk/Source/WebCore/platform/network/soup/URLSoup.h (239427 => 239428)

--- trunk/Source/WebCore/platform/network/soup/URLSoup.h	2018-12-20 04:41:11 UTC (rev 239427)
+++ trunk/Source/WebCore/platform/network/soup/URLSoup.h	2018-12-20 04:46:27 UTC (rev 239428)
@@ -32,6 +32,6 @@
 }
 
 namespace WebCore {
-URL soupURIToURL(SoupURI*);
+WTF::URL soupURIToURL(SoupURI*);
 GUniquePtr urlToSoupURI(const WTF::URL&);
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239426] trunk/Source/WebKit

[mcatanzaro]

Title: [239426] trunk/Source/WebKit








Revision 239426
Author mcatanz...@igalia.com
Date 2018-12-19 20:26:57 -0800 (Wed, 19 Dec 2018)


Log Message
Unreviewed, silence -Wpragmas warning

* WebProcess/WebCoreSupport/WebAlternativeTextClient.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebAlternativeTextClient.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (239425 => 239426)

--- trunk/Source/WebKit/ChangeLog	2018-12-20 04:17:37 UTC (rev 239425)
+++ trunk/Source/WebKit/ChangeLog	2018-12-20 04:26:57 UTC (rev 239426)
@@ -1,3 +1,9 @@
+2018-12-19  Michael Catanzaro  
+
+Unreviewed, silence -Wpragmas warning
+
+* WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
+
 2018-12-19  Vivek Seth  
 
 HTTPS Upgrade: Use full sqlite upgrade list


Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebAlternativeTextClient.h (239425 => 239426)

--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebAlternativeTextClient.h	2018-12-20 04:17:37 UTC (rev 239425)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebAlternativeTextClient.h	2018-12-20 04:26:57 UTC (rev 239426)
@@ -50,11 +50,11 @@
 
 private:
 #if !(USE(AUTOCORRECTION_PANEL) || USE(DICTATION_ALTERNATIVES))
-IGNORE_WARNINGS_BEGIN("unused-private-field")
+IGNORE_CLANG_WARNINGS_BEGIN("unused-private-field")
 #endif
 WebPage* m_page;
 #if !(USE(AUTOCORRECTION_PANEL) || USE(DICTATION_ALTERNATIVES))
-IGNORE_WARNINGS_END
+IGNORE_CLANG_WARNINGS_END
 #endif
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239424] trunk/LayoutTests

[ross . kirsling]

Title: [239424] trunk/LayoutTests








Revision 239424
Author ross.kirsl...@sony.com
Date 2018-12-19 20:11:15 -0800 (Wed, 19 Dec 2018)


Log Message
[WinCairo] Unreviewed test gardening.

* platform/wincairo/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wincairo/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (239423 => 239424)

--- trunk/LayoutTests/ChangeLog	2018-12-20 04:04:06 UTC (rev 239423)
+++ trunk/LayoutTests/ChangeLog	2018-12-20 04:11:15 UTC (rev 239424)
@@ -1,3 +1,9 @@
+2018-12-19  Ross Kirsling  
+
+[WinCairo] Unreviewed test gardening.
+
+* platform/wincairo/TestExpectations:
+
 2018-12-19  Alicia Boya García  
 
 [GTK][WPE] Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (239423 => 239424)

--- trunk/LayoutTests/platform/wincairo/TestExpectations	2018-12-20 04:04:06 UTC (rev 239423)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations	2018-12-20 04:11:15 UTC (rev 239424)
@@ -466,6 +466,10 @@
 canvas/philip/tests/2d.text.draw.space.collapse.start.html [ Failure ]
 canvas/philip/tests/2d.text.measure.width.space.html [ Failure ]
 
+# This only applies to file:// loading of ES6 Modules via the import syntax. When
+# Windows recognizes .mjs files as _javascript_, this will just work.
+js/dom/modules/import-mjs-module.html [ Failure ]
+
 #//
 # These areas are not implemented well on WinCairo
 #//
@@ -1007,7 +1011,7 @@
 #///
 
 
-##Accessibility Issues  
+###   Accessibility Issues   ###
 
 
 accessibility/win [ Pass ]
@@ -1271,12 +1275,12 @@
 [ Debug ] accessibility/win/focus-events.html [ Skip ]
 
 
-###   End Accessibility Issues   ###
+End Accessibility Issues
 
 
 
 
-# Animation Issues  
+#   Animation Issues   #
 
 
 webkit.org/b/49182 animations/stop-animation-on-suspend.html [ Pass Failure ]
@@ -1332,12 +1336,12 @@
 webkit.org/b/191584 legacy-animation-engine/animations/transform-non-accelerated.html [ Failure ]
 
 
-##   End Animation Issues ##
+###   End Animation Issues   ###
 
 
 
 
-   Compositing Issues   
+   Compositing Issues   
 
 
 # TODO LAYER_TREE_INCLUDES_VISIBLE_RECTS option to layerTreeAsText is only applicable to Mac.
@@ -1369,13 +1373,15 @@
 webkit.org/b/184482 legacy-animation-engine/compositing/layer-creation/translate-transition-overlap.html [ Failure ]
 webkit.org/b/184482 legacy-animation-engine/compositing/reflections/load-video-in-reflection.html [ Skip ]
 
+legacy-animation-engine/compositing/backing/backing-store-attachment-empty-keyframe.html [ Failure ]
+
 
-#   End Compositing Issues #
+##   End Compositing Issues   ##
 
 
 
 
-   CSS Issues   
+   CSS Issues   
 
 
 webkit.org/b/117322 fast/css/text-indent-first-line-006.html [ ImageOnlyFailure ]
@@ -1470,7 +1476,6 @@
 fast/css3-text/ [ Skip ]
 
 

[webkit-changes] [239423] trunk/Source/WebKit

[commit-queue]

Title: [239423] trunk/Source/WebKit








Revision 239423
Author commit-qu...@webkit.org
Date 2018-12-19 20:04:06 -0800 (Wed, 19 Dec 2018)


Log Message
HTTPS Upgrade: Use full sqlite upgrade list
https://bugs.webkit.org/show_bug.cgi?id=192736


Patch by Vivek Seth  on 2018-12-19
Reviewed by Chris Dumez.

* NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: Added.
(WebKit::NetworkHTTPSUpgradeCheckerDatabasePath):
(WebKit::NetworkHTTPSUpgradeChecker::NetworkHTTPSUpgradeChecker):
(WebKit::NetworkHTTPSUpgradeChecker::~NetworkHTTPSUpgradeChecker):
(WebKit::NetworkHTTPSUpgradeChecker::query):
(WebKit::NetworkHTTPSUpgradeChecker::isAlwaysOnLoggingAllowed const):
* NetworkProcess/NetworkHTTPSUpgradeChecker.h: Added.
(WebKit::NetworkHTTPSUpgradeChecker::didSetupCompleteSuccessfully const):
* NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const):
(WebKit::NetworkLoadChecker::checkRequest):
* NetworkProcess/NetworkLoadChecker.h:
* NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::networkHTTPSUpgradeChecker):
* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (239422 => 239423)

--- trunk/Source/WebKit/ChangeLog	2018-12-20 04:00:01 UTC (rev 239422)
+++ trunk/Source/WebKit/ChangeLog	2018-12-20 04:04:06 UTC (rev 239423)
@@ -1,3 +1,28 @@
+2018-12-19  Vivek Seth  
+
+HTTPS Upgrade: Use full sqlite upgrade list
+https://bugs.webkit.org/show_bug.cgi?id=192736
+
+
+Reviewed by Chris Dumez.
+
+* NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: Added.
+(WebKit::NetworkHTTPSUpgradeCheckerDatabasePath):
+(WebKit::NetworkHTTPSUpgradeChecker::NetworkHTTPSUpgradeChecker):
+(WebKit::NetworkHTTPSUpgradeChecker::~NetworkHTTPSUpgradeChecker):
+(WebKit::NetworkHTTPSUpgradeChecker::query):
+(WebKit::NetworkHTTPSUpgradeChecker::isAlwaysOnLoggingAllowed const):
+* NetworkProcess/NetworkHTTPSUpgradeChecker.h: Added.
+(WebKit::NetworkHTTPSUpgradeChecker::didSetupCompleteSuccessfully const):
+* NetworkProcess/NetworkLoadChecker.cpp:
+(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const):
+(WebKit::NetworkLoadChecker::checkRequest):
+* NetworkProcess/NetworkLoadChecker.h:
+* NetworkProcess/NetworkProcess.h:
+(WebKit::NetworkProcess::networkHTTPSUpgradeChecker):
+* Sources.txt:
+* WebKit.xcodeproj/project.pbxproj:
+
 2018-12-19  Tim Horton  
 
 Use delegate instead of drawingDelegate in WKDrawingView


Added: trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp (0 => 239423)

--- trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp	(rev 0)
+++ trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp	2018-12-20 04:04:06 UTC (rev 239423)
@@ -0,0 +1,116 @@
+/*
+ * Copyright (C) 2018 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "NetworkHTTPSUpgradeChecker.h"
+
+#if ENABLE(HTTPS_UPGRADE)
+
+#include "Logging.h"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#define RELEASE_LOG_IF_ALLOWED(sessionID, fmt, ...) 

[webkit-changes] [239422] trunk/Source/WebInspectorUI

[drousso]

Title: [239422] trunk/Source/WebInspectorUI








Revision 239422
Author drou...@apple.com
Date 2018-12-19 20:00:01 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'effectiveDOMNode.enabledPseudoClasses')
https://bugs.webkit.org/show_bug.cgi?id=192783

Reviewed by Joseph Pecoraro.

* UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
(WI.GeneralStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239421 => 239422)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 03:57:10 UTC (rev 239421)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 04:00:01 UTC (rev 239422)
@@ -1,5 +1,16 @@
 2018-12-19  Devin Rousso  
 
+Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'effectiveDOMNode.enabledPseudoClasses')
+https://bugs.webkit.org/show_bug.cgi?id=192783
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
+(WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
+(WI.GeneralStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):
+
+2018-12-19  Devin Rousso  
+
 Web Inspector: REGRESSION (r237195): Timelines: selecting a rendering frame row moves the time selection
 https://bugs.webkit.org/show_bug.cgi?id=192773
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (239421 => 239422)

--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js	2018-12-20 03:57:10 UTC (rev 239421)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js	2018-12-20 04:00:01 UTC (rev 239422)
@@ -272,6 +272,8 @@
 return;
 
 let effectiveDOMNode = this.domNode.isPseudoElement() ? this.domNode.parentNode : this.domNode;
+if (!effectiveDOMNode)
+return;
 
 effectiveDOMNode.setPseudoClassEnabled(pseudoClass, event.target.checked);
 
@@ -284,6 +286,8 @@
 return;
 
 let effectiveDOMNode = this.domNode.isPseudoElement() ? this.domNode.parentNode : this.domNode;
+if (!effectiveDOMNode)
+return;
 
 let enabledPseudoClasses = effectiveDOMNode.enabledPseudoClasses;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239421] trunk/Source/WebInspectorUI

[drousso]

Title: [239421] trunk/Source/WebInspectorUI








Revision 239421
Author drou...@apple.com
Date 2018-12-19 19:57:10 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: REGRESSION (r237195): Timelines: selecting a rendering frame row moves the time selection
https://bugs.webkit.org/show_bug.cgi?id=192773


Reviewed by Joseph Pecoraro.

* UserInterface/Views/TimelineOverview.js:
(WI.TimelineOverview.prototype._recordSelected):
The Frames timeline uses `frameIndex` instead of `startTime`/`endTime`, so when trying to
ensure that the selected record is within the filtered range, use `frameIndex` instead.
The associated `WI.TimelineRuler` will already be using an index-based approach for
selection, so this will match.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239420 => 239421)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 03:56:27 UTC (rev 239420)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 03:57:10 UTC (rev 239421)
@@ -1,5 +1,20 @@
 2018-12-19  Devin Rousso  
 
+Web Inspector: REGRESSION (r237195): Timelines: selecting a rendering frame row moves the time selection
+https://bugs.webkit.org/show_bug.cgi?id=192773
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/TimelineOverview.js:
+(WI.TimelineOverview.prototype._recordSelected):
+The Frames timeline uses `frameIndex` instead of `startTime`/`endTime`, so when trying to
+ensure that the selected record is within the filtered range, use `frameIndex` instead.
+The associated `WI.TimelineRuler` will already be using an index-based approach for
+selection, so this will match.
+
+2018-12-19  Devin Rousso  
+
 Web Inspector: Canvas: the recording auto-capture input shouldn't start focused
 https://bugs.webkit.org/show_bug.cgi?id=192454
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (239420 => 239421)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js	2018-12-20 03:56:27 UTC (rev 239420)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js	2018-12-20 03:57:10 UTC (rev 239421)
@@ -733,10 +733,13 @@
 lastRecord = recordBar.records.lastValue;
 }
 
-if (firstRecord.startTime < this.selectionStartTime || lastRecord.endTime > this.selectionStartTime + this.selectionDuration) {
+let startTime = firstRecord instanceof WI.RenderingFrameTimelineRecord ? firstRecord.frameIndex : firstRecord.startTime;
+let endTime = lastRecord instanceof WI.RenderingFrameTimelineRecord ? lastRecord.frameIndex : lastRecord.startTime;
+
+if (startTime < this.selectionStartTime || endTime > this.selectionStartTime + this.selectionDuration) {
 let selectionPadding = this.secondsPerPixel * 10;
-this.selectionStartTime = firstRecord.startTime - selectionPadding;
-this.selectionDuration = lastRecord.endTime - firstRecord.startTime + (selectionPadding * 2);
+this.selectionStartTime = startTime - selectionPadding;
+this.selectionDuration = endTime - startTime + (selectionPadding * 2);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239420] trunk/Source/WebInspectorUI

[drousso]

Title: [239420] trunk/Source/WebInspectorUI








Revision 239420
Author drou...@apple.com
Date 2018-12-19 19:56:27 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: Canvas: the recording auto-capture input shouldn't start focused
https://bugs.webkit.org/show_bug.cgi?id=192454

Reviewed by Joseph Pecoraro.

* UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239419 => 239420)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 03:24:28 UTC (rev 239419)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 03:56:27 UTC (rev 239420)
@@ -1,3 +1,14 @@
+2018-12-19  Devin Rousso  
+
+Web Inspector: Canvas: the recording auto-capture input shouldn't start focused
+https://bugs.webkit.org/show_bug.cgi?id=192454
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/CanvasOverviewContentView.js:
+(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
+(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):
+
 2018-12-19  Nikita Vasilyev  
 
 Web Inspector: Styles: shift-clicking a color-swatch to change formats starts editing the color


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js (239419 => 239420)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js	2018-12-20 03:24:28 UTC (rev 239419)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js	2018-12-20 03:56:27 UTC (rev 239420)
@@ -209,6 +209,7 @@
 
 let label = frameCount === 1 ? WI.UIString("Record first %s frame") : WI.UIString("Record first %s frames");
 
+let active = document.activeElement === this._recordingAutoCaptureFrameCountInputElement;
 let selectionStart = this._recordingAutoCaptureFrameCountInputElement.selectionStart;
 let selectionEnd = this._recordingAutoCaptureFrameCountInputElement.selectionEnd;
 let direction = this._recordingAutoCaptureFrameCountInputElement.direction;
@@ -221,9 +222,11 @@
 
 this._recordingAutoCaptureNavigationItem.label = fragment;
 
-this._recordingAutoCaptureFrameCountInputElement.selectionStart = selectionStart;
-this._recordingAutoCaptureFrameCountInputElement.selectionEnd = selectionEnd;
-this._recordingAutoCaptureFrameCountInputElement.direction = direction;
+if (active) {
+this._recordingAutoCaptureFrameCountInputElement.selectionStart = selectionStart;
+this._recordingAutoCaptureFrameCountInputElement.selectionEnd = selectionEnd;
+this._recordingAutoCaptureFrameCountInputElement.direction = direction;
+}
 }
 
 _updateRecordingAutoCaptureInputElementSize()
@@ -270,7 +273,9 @@
 
 _handleCanvasRecordingAutoCaptureFrameCountChanged(event)
 {
-this._recordingAutoCaptureFrameCountInputElement.value = WI.settings.canvasRecordingAutoCaptureFrameCount.value;
+// Only update the value if it is different to prevent mangling the selection.
+if (parseInt(this._recordingAutoCaptureFrameCountInputElement.value) !== WI.settings.canvasRecordingAutoCaptureFrameCount.value)
+this._recordingAutoCaptureFrameCountInputElement.value = WI.settings.canvasRecordingAutoCaptureFrameCount.value;
 
 this._updateRecordingAutoCaptureCheckboxLabel(WI.settings.canvasRecordingAutoCaptureFrameCount.value);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239419] trunk/Source/WebCore

[jer . noble]

Title: [239419] trunk/Source/WebCore








Revision 239419
Author jer.no...@apple.com
Date 2018-12-19 19:24:28 -0800 (Wed, 19 Dec 2018)


Log Message
Leak of MTAudioProcessingTap (304 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
https://bugs.webkit.org/show_bug.cgi?id=192896


Reviewed by Eric Carlson.

* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::initCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239418 => 239419)

--- trunk/Source/WebCore/ChangeLog	2018-12-20 01:45:29 UTC (rev 239418)
+++ trunk/Source/WebCore/ChangeLog	2018-12-20 03:24:28 UTC (rev 239419)
@@ -1,3 +1,14 @@
+2018-12-19  Jer Noble  
+
+Leak of MTAudioProcessingTap (304 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
+https://bugs.webkit.org/show_bug.cgi?id=192896
+
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
+(WebCore::AudioSourceProviderAVFObjC::initCallback):
+
 2018-12-19  Timothy Hatcher  
 
 REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm (239418 => 239419)

--- trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm	2018-12-20 01:45:29 UTC (rev 239418)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm	2018-12-20 03:24:28 UTC (rev 239419)
@@ -237,7 +237,7 @@
 {
 ASSERT(tap);
 AudioSourceProviderAVFObjC* _this = static_cast(clientInfo);
-_this->m_tap = tap;
+_this->m_tap = adoptCF(tap);
 _this->m_tapStorage = new TapStorage(_this);
 _this->init(clientInfo, tapStorageOut);
 *tapStorageOut = _this->m_tapStorage;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239417] trunk

[benjamin]

Title: [239417] trunk








Revision 239417
Author benja...@webkit.org
Date 2018-12-19 17:41:35 -0800 (Wed, 19 Dec 2018)


Log Message
 macOS: WebKit1 does not handle occlusion changes
https://bugs.webkit.org/show_bug.cgi?id=192821

Reviewed by Chris Dumez.

Source/WebKitLegacy/mac:

When a window becomes occluded, the window server informs the application.
This should be used to suspend any work that is not visible by the user.

WebKit2 handles it just fine, but WebKit1 did not handle the notification.
In some cases, that lead to performance impact (see radar).

This patch adds an observer for the occlusion notification. I tried to stick
with the same names used by WebKit2.

* WebView/WebView.mm:
(-[WebView _isViewVisible]):
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _windowDidChangeOcclusionState:]):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Source/WebKitLegacy/mac/WebView/WebViewData.h
trunk/Source/WebKitLegacy/mac/WebView/WebViewData.mm
trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (239416 => 239417)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-12-20 01:40:11 UTC (rev 239416)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-12-20 01:41:35 UTC (rev 239417)
@@ -1,3 +1,25 @@
+2018-12-19  Benjamin Poulain  
+
+ macOS: WebKit1 does not handle occlusion changes
+https://bugs.webkit.org/show_bug.cgi?id=192821
+
+Reviewed by Chris Dumez.
+
+When a window becomes occluded, the window server informs the application.
+This should be used to suspend any work that is not visible by the user.
+
+WebKit2 handles it just fine, but WebKit1 did not handle the notification.
+In some cases, that lead to performance impact (see radar).
+
+This patch adds an observer for the occlusion notification. I tried to stick
+with the same names used by WebKit2.
+
+* WebView/WebView.mm:
+(-[WebView _isViewVisible]):
+(-[WebView addWindowObserversForWindow:]):
+(-[WebView removeWindowObservers]):
+(-[WebView _windowDidChangeOcclusionState:]):
+
 2018-12-19  Megan Gardner  
 
 Allow clients to set the navigator platform


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (239416 => 239417)

--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2018-12-20 01:40:11 UTC (rev 239416)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2018-12-20 01:41:35 UTC (rev 239417)
@@ -4668,15 +4668,21 @@
 
 - (BOOL)_isViewVisible
 {
-if (![self window])
+NSWindow *window = [self window];
+if (!window)
 return false;
 
-if (![[self window] isVisible])
+if (![window isVisible])
 return false;
 
 if ([self isHiddenOrHasHiddenAncestor])
 return false;
 
+#if !PLATFORM(IOS_FAMILY)
+if (_private->windowOcclusionDetectionEnabled && (window.occlusionState & NSWindowOcclusionStateVisible) != NSWindowOcclusionStateVisible)
+return false;
+#endif
+
 return true;
 }
 
@@ -5065,6 +5071,18 @@
 }
 }
 
+#if !PLATFORM(IOS_FAMILY)
+- (BOOL)windowOcclusionDetectionEnabled
+{
+return _private->windowOcclusionDetectionEnabled;
+}
+
+- (void)setWindowOcclusionDetectionEnabled:(BOOL)flag
+{
+_private->windowOcclusionDetectionEnabled = flag;
+}
+#endif
+
 - (void)_setPaginationBehavesLikeColumns:(BOOL)behavesLikeColumns
 {
 Page* page = core(self);
@@ -6000,22 +6018,26 @@
 - (void)addWindowObserversForWindow:(NSWindow *)window
 {
 if (window) {
-[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(windowKeyStateChanged:)
+NSNotificationCenter *defaultNotificationCenter = [NSNotificationCenter defaultCenter];
+
+[defaultNotificationCenter addObserver:self selector:@selector(windowKeyStateChanged:)
 name:NSWindowDidBecomeKeyNotification object:window];
-[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(windowKeyStateChanged:)
+[defaultNotificationCenter addObserver:self selector:@selector(windowKeyStateChanged:)
 name:NSWindowDidResignKeyNotification object:window];
-[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowWillOrderOnScreen:)
+[defaultNotificationCenter addObserver:self selector:@selector(_windowWillOrderOnScreen:)
 name:NSWindowWillOrderOnScreenNotification object:window];
-[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowWillOrderOffScreen:)
+[defaultNotificationCenter addObserver:self selector:@selector(_windowWillOrderOffScreen:)
 name:NSWindowWillOrderOffScreenNotification 

[webkit-changes] [239416] trunk/LayoutTests

[aboya]

Title: [239416] trunk/LayoutTests








Revision 239416
Author ab...@igalia.com
Date 2018-12-19 17:40:11 -0800 (Wed, 19 Dec 2018)


Log Message
[GTK][WPE] Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=192904


* platform/gtk/TestExpectations:
* platform/gtk/animations/lineheight-animation-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt.
* platform/gtk/animations/simultaneous-start-transform-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt.
* platform/gtk/animations/width-using-ems-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt.
* platform/gtk/css1/font_properties/font-expected.txt:
* platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt:
* platform/gtk/fast/inline/inline-content-with-image-simple-expected.txt: Added.
* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
* platform/gtk/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Removed.
* platform/gtk/legacy-animation-engine/animations/lineheight-animation-expected.txt: Added.
* platform/gtk/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt.
* platform/gtk/legacy-animation-engine/animations/width-using-ems-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt.
* platform/wpe/TestExpectations:
* platform/wpe/css1/font_properties/font-expected.txt:
* platform/wpe/css1/pseudo/multiple_pseudo_elements-expected.txt:
* platform/wpe/css2.1/t1508-c527-font-00-b-expected.txt:
* platform/wpe/css2.1/t1508-c527-font-06-b-expected.txt:
* platform/wpe/css2.1/t1508-c527-font-10-c-expected.txt:
* platform/wpe/fast/inline/inline-content-with-image-simple-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Removed.
* platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt:
* platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt:
* platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/css1/font_properties/font-expected.txt
trunk/LayoutTests/platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt
trunk/LayoutTests/platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt
trunk/LayoutTests/platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt
trunk/LayoutTests/platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/LayoutTests/platform/wpe/css1/font_properties/font-expected.txt
trunk/LayoutTests/platform/wpe/css1/pseudo/multiple_pseudo_elements-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t1508-c527-font-00-b-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t1508-c527-font-06-b-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t1508-c527-font-10-c-expected.txt
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt
trunk/LayoutTests/platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt
trunk/LayoutTests/platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt
trunk/LayoutTests/platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt


Added Paths

trunk/LayoutTests/platform/gtk/animations/lineheight-animation-expected.txt
trunk/LayoutTests/platform/gtk/animations/simultaneous-start-transform-expected.txt
trunk/LayoutTests/platform/gtk/animations/width-using-ems-expected.txt
trunk/LayoutTests/platform/gtk/fast/inline/inline-content-with-image-simple-expected.txt
trunk/LayoutTests/platform/gtk/legacy-animation-engine/animations/lineheight-animation-expected.txt
trunk/LayoutTests/platform/gtk/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt
trunk/LayoutTests/platform/gtk/legacy-animation-engine/animations/width-using-ems-expected.txt
trunk/LayoutTests/platform/wpe/fast/inline/inline-content-with-image-simple-expected.txt


Removed Paths

[webkit-changes] [239414] trunk/Source/WebCore

[timothy]

Title: [239414] trunk/Source/WebCore








Revision 239414
Author timo...@apple.com
Date 2018-12-19 17:28:06 -0800 (Wed, 19 Dec 2018)


Log Message
REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent
https://bugs.webkit.org/show_bug.cgi?id=188891
rdar://problem/42344352

Reviewed by Simon Fraser.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
Don't return early when m_layerForOverhangAreas is null to avoid skipping
setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239413 => 239414)

--- trunk/Source/WebCore/ChangeLog	2018-12-20 01:22:39 UTC (rev 239413)
+++ trunk/Source/WebCore/ChangeLog	2018-12-20 01:28:06 UTC (rev 239414)
@@ -1,3 +1,16 @@
+2018-12-19  Timothy Hatcher  
+
+REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent
+https://bugs.webkit.org/show_bug.cgi?id=188891
+rdar://problem/42344352
+
+Reviewed by Simon Fraser.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
+Don't return early when m_layerForOverhangAreas is null to avoid skipping
+setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().
+
 2018-12-19  Justin Fan  
 
 [WebGPU] Add stubs for WebGPUPipelineLayout/Descriptor and device::createPipelineLayout


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (239413 => 239414)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2018-12-20 01:22:39 UTC (rev 239413)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2018-12-20 01:28:06 UTC (rev 239414)
@@ -3280,13 +3280,12 @@
 page().chrome().client().pageExtendedBackgroundColorDidChange(m_rootExtendedBackgroundColor);
 
 #if ENABLE(RUBBER_BANDING)
-if (!m_layerForOverhangAreas)
-return;
-
-m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
-
-if (!m_rootExtendedBackgroundColor.isValid())
-m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
+if (m_layerForOverhangAreas) {
+m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
+
+if (!m_rootExtendedBackgroundColor.isValid())
+m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
+}
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239413] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [239413] trunk/Source/WebInspectorUI








Revision 239413
Author nvasil...@apple.com
Date 2018-12-19 17:22:39 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: Styles: shift-clicking a color-swatch to change formats starts editing the color
https://bugs.webkit.org/show_bug.cgi?id=192784


Reviewed by Devin Rousso.

* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239412 => 239413)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 01:22:05 UTC (rev 239412)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 01:22:39 UTC (rev 239413)
@@ -1,3 +1,14 @@
+2018-12-19  Nikita Vasilyev  
+
+Web Inspector: Styles: shift-clicking a color-swatch to change formats starts editing the color
+https://bugs.webkit.org/show_bug.cgi?id=192784
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
+
 2018-12-19  Matt Baker  
 
 Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (239412 => 239413)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2018-12-20 01:22:05 UTC (rev 239412)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2018-12-20 01:22:39 UTC (rev 239413)
@@ -483,7 +483,7 @@
 
 // Prevent the value from editing when clicking on the swatch.
 swatch.element.addEventListener("click", (event) => {
-if (this._swatchActive)
+if (this._swatchActive || event.shiftKey)
 event.stop();
 });
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239412] branches/safari-606-branch/Source/WebKit/UIProcess/ ResourceLoadStatisticsMemoryStore.cpp

[alancoon]

Title: [239412] branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp








Revision 239412
Author alanc...@apple.com
Date 2018-12-19 17:22:05 -0800 (Wed, 19 Dec 2018)


Log Message
Apply patch. rdar://problem/46848447

Modified Paths

branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp




Diff

Modified: branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp (239411 => 239412)

--- branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp	2018-12-20 01:09:57 UTC (rev 239411)
+++ branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp	2018-12-20 01:22:05 UTC (rev 239412)
@@ -796,7 +796,7 @@
 {
 ASSERT(!RunLoop::isMain());
 
-#if ENABLE(RESOURCE_LOAD_STATISTICS)
+#if HAVE(CFNETWORK_STORAGE_PARTITIONING)
 RunLoop::main().dispatch([store = makeRef(m_store), seconds = m_parameters.clientSideCookiesAgeCapTime] () {
 if (auto* websiteDataStore = store->websiteDataStore())
 websiteDataStore->setAgeCapForClientSideCookies(seconds, [] { });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239411] trunk/Source/WebKit

[timothy_horton]

Title: [239411] trunk/Source/WebKit








Revision 239411
Author timothy_hor...@apple.com
Date 2018-12-19 17:09:57 -0800 (Wed, 19 Dec 2018)


Log Message
Use delegate instead of drawingDelegate in WKDrawingView
https://bugs.webkit.org/show_bug.cgi?id=192899


Reviewed by Wenson Hsieh.

* UIProcess/ios/WKDrawingView.mm:
(-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]):
Do the dance.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (239410 => 239411)

--- trunk/Source/WebKit/ChangeLog	2018-12-20 00:59:13 UTC (rev 239410)
+++ trunk/Source/WebKit/ChangeLog	2018-12-20 01:09:57 UTC (rev 239411)
@@ -1,3 +1,15 @@
+2018-12-19  Tim Horton  
+
+Use delegate instead of drawingDelegate in WKDrawingView
+https://bugs.webkit.org/show_bug.cgi?id=192899
+
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/ios/WKDrawingView.mm:
+(-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]):
+Do the dance.
+
 2018-12-19  Alex Christensen  
 
 Navigations away from the SafeBrowsing interstitial show a flash of old content


Modified: trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm (239410 => 239411)

--- trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm	2018-12-20 00:59:13 UTC (rev 239410)
+++ trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm	2018-12-20 01:09:57 UTC (rev 239411)
@@ -60,11 +60,8 @@
 [_pencilView setFingerDrawingEnabled:NO];
 [_pencilView setUserInteractionEnabled:YES];
 [_pencilView setOpaque:NO];
+[_pencilView setDelegate:self];
 
-ALLOW_DEPRECATED_DECLARATIONS_BEGIN
-[_pencilView setDrawingDelegate:self];
-ALLOW_DEPRECATED_DECLARATIONS_END
-
 [self addSubview:_pencilView.get()];
 
 return self;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239410] trunk

[justin_fan]

Title: [239410] trunk








Revision 239410
Author justin_...@apple.com
Date 2018-12-19 16:59:13 -0800 (Wed, 19 Dec 2018)


Log Message
[WebGPU] Add stubs for WebGPUPipelineLayout/Descriptor and device::createPipelineLayout
https://bugs.webkit.org/show_bug.cgi?id=192843


Reviewed by Myles Maxfield.

Source/WebCore:

Test: webgpu/pipeline-layouts.html

Implement the emtpy WebGPUPipelineLayout interface, and enable creation via WebGPUDevice::createPipelineLayout:
* Modules/webgpu/WebGPUBindGroupLayout.cpp:
(WebCore::WebGPUBindGroupLayout::WebGPUBindGroupLayout):
* Modules/webgpu/WebGPUBindGroupLayout.h:
(WebCore::WebGPUBindGroupLayout::bindGroupLayout const): Added getter.
* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createPipelineLayout const): Added.
* Modules/webgpu/WebGPUDevice.h:
* Modules/webgpu/WebGPUDevice.idl: Enable createPipelineLayout.
* Modules/webgpu/WebGPUPipelineLayout.cpp: Added.
(WebCore::WebGPUPipelineLayout::create):
(WebCore::WebGPUPipelineLayout::WebGPUPipelineLayout):
* Modules/webgpu/WebGPUPipelineLayout.h: Added.
* Modules/webgpu/WebGPUPipelineLayout.idl: Added.
* Modules/webgpu/WebGPUPipelineLayoutDescriptor.h: Added.
* Modules/webgpu/WebGPUPipelineLayoutDescriptor.idl: Added.
* platform/graphics/gpu/GPUDevice.cpp:
(WebCore::GPUDevice::createPipelineLayout const): Added.
* platform/graphics/gpu/GPUDevice.h:
* platform/graphics/gpu/GPUPipelineLayout.cpp: Added.
(WebCore::GPUPipelineLayout::create):
(WebCore::GPUPipelineLayout::GPUPipelineLayout):
* platform/graphics/gpu/GPUPipelineLayout.h: Added.
* platform/graphics/gpu/GPUPipelineLayoutDescriptor.h: Added.

Add files and symbols to project:
* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:

Add missing include:
* Modules/webgpu/WebGPUQueue.h:

LayoutTests:

Update bind-group-layouts and rename to match new PipelineLayout functionality.

* webgpu/bind-group-layouts-expected.txt: Removed.
* webgpu/pipeline-layouts-expected.txt: Added.
* webgpu/pipeline-layouts.html: Renamed from LayoutTests/webgpu/bind-group-layouts.html.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroupLayout.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroupLayout.h
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.h
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.idl
trunk/Source/WebCore/Modules/webgpu/WebGPUQueue.h
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupLayout.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupLayout.h
trunk/Source/WebCore/platform/graphics/gpu/GPUDevice.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUDevice.h


Added Paths

trunk/LayoutTests/webgpu/pipeline-layouts-expected.txt
trunk/LayoutTests/webgpu/pipeline-layouts.html
trunk/Source/WebCore/Modules/webgpu/WebGPUPipelineLayout.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUPipelineLayout.h
trunk/Source/WebCore/Modules/webgpu/WebGPUPipelineLayout.idl
trunk/Source/WebCore/Modules/webgpu/WebGPUPipelineLayoutDescriptor.h
trunk/Source/WebCore/Modules/webgpu/WebGPUPipelineLayoutDescriptor.idl
trunk/Source/WebCore/platform/graphics/gpu/GPUPipelineLayout.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUPipelineLayout.h
trunk/Source/WebCore/platform/graphics/gpu/GPUPipelineLayoutDescriptor.h


Removed Paths

trunk/LayoutTests/webgpu/bind-group-layouts-expected.txt
trunk/LayoutTests/webgpu/bind-group-layouts.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239409 => 239410)

--- trunk/LayoutTests/ChangeLog	2018-12-20 00:58:21 UTC (rev 239409)
+++ trunk/LayoutTests/ChangeLog	2018-12-20 00:59:13 UTC (rev 239410)
@@ -1,3 +1,17 @@
+2018-12-19  Justin Fan  
+
+[WebGPU] Add stubs for WebGPUPipelineLayout/Descriptor and device::createPipelineLayout
+https://bugs.webkit.org/show_bug.cgi?id=192843
+
+
+Reviewed by Myles Maxfield.
+
+Update bind-group-layouts and rename to match new PipelineLayout functionality.
+
+* webgpu/bind-group-layouts-expected.txt: Removed.
+* webgpu/pipeline-layouts-expected.txt: Added.
+* webgpu/pipeline-layouts.html: Renamed from LayoutTests/webgpu/bind-group-layouts.html.
+
 2018-12-19  Ryan Haddad  
 
 REGRESSION: [ iOS Sim ] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/update-missing-import-scripts.https.html is failing


Deleted: trunk/LayoutTests/webgpu/bind-group-layouts-expected.txt (239409 => 239410)

--- trunk/LayoutTests/webgpu/bind-group-layouts-expected.txt	2018-12-20 00:58:21 UTC (rev 239409)
+++ trunk/LayoutTests/webgpu/bind-group-layouts-expected.txt	2018-12-20 00:59:13 UTC (rev 239410)
@@ -1,4 

[webkit-changes] [239409] branches/safari-606-branch/Source

[alancoon]

Title: [239409] branches/safari-606-branch/Source








Revision 239409
Author alanc...@apple.com
Date 2018-12-19 16:58:21 -0800 (Wed, 19 Dec 2018)


Log Message
Apply patch. rdar://problem/46848447

Modified Paths

branches/safari-606-branch/Source/WebCore/ChangeLog
branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.cpp
branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.h
branches/safari-606-branch/Source/WebCore/platform/network/mac/CookieJarMac.mm
branches/safari-606-branch/Source/WebKit/ChangeLog
branches/safari-606-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-606-branch/Source/WebKit/NetworkProcess/NetworkProcess.h
branches/safari-606-branch/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm
branches/safari-606-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
branches/safari-606-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.h
branches/safari-606-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h
branches/safari-606-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h




Diff

Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (239408 => 239409)

--- branches/safari-606-branch/Source/WebCore/ChangeLog	2018-12-20 00:55:10 UTC (rev 239408)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog	2018-12-20 00:58:21 UTC (rev 239409)
@@ -4,6 +4,33 @@
 
 2018-12-19  Brent Fulgham  
 
+Add ability to configure document.cookie lifetime cap through user defaults
+https://bugs.webkit.org/show_bug.cgi?id=191480
+
+
+Reviewed by Chris Dumez.
+
+No new tests. Existing test makes sure we don't regress.
+
+This change makes the capped lifetime in seconds configurable through
+user defaults.
+
+* platform/network/NetworkStorageSession.cpp:
+(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies):
+(WebCore::NetworkStorageSession::ageCapForClientSideCookies const):
+(WebCore::NetworkStorageSession::setShouldCapLifetimeForClientSideCookies): Deleted.
+(WebCore::NetworkStorageSession::shouldCapLifetimeForClientSideCookies const): Deleted.
+* platform/network/NetworkStorageSession.h:
+* platform/network/mac/CookieJarMac.mm:
+(WebCore::filterCookies):
+(WebCore::setCookiesFromDOM):
+
+2018-12-19  Alan Coon  
+
+Apply patch. rdar://problem/46848447
+
+2018-12-19  Brent Fulgham  
+
 Only cap lifetime of persistent cookies created client-side through document.cookie when resource load statistics is enabled
 https://bugs.webkit.org/show_bug.cgi?id=190687
 


Modified: branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.cpp (239408 => 239409)

--- branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.cpp	2018-12-20 00:55:10 UTC (rev 239408)
+++ branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.cpp	2018-12-20 00:58:21 UTC (rev 239409)
@@ -74,14 +74,14 @@
 removeProcessPrivilege(ProcessPrivilege::CanAccessRawCookies);
 }
 
-void NetworkStorageSession::setShouldCapLifetimeForClientSideCookies(bool value)
+void NetworkStorageSession::setAgeCapForClientSideCookies(std::optional seconds)
 {
-m_shouldCapLifetimeForClientSideCookies = value;
+m_ageCapForClientSideCookies = seconds;
 }
 
-bool NetworkStorageSession::shouldCapLifetimeForClientSideCookies() const
+std::optional NetworkStorageSession::ageCapForClientSideCookies() const
 {
-return m_shouldCapLifetimeForClientSideCookies;
+return m_ageCapForClientSideCookies;
 }
 
 }


Modified: branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.h (239408 => 239409)

--- branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.h	2018-12-20 00:55:10 UTC (rev 239408)
+++ branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.h	2018-12-20 00:58:21 UTC (rev 239409)
@@ -101,8 +101,8 @@
 WEBCORE_EXPORT bool shouldBlockCookies(const URL& firstPartyForCookies, const URL& resource) const;
 WEBCORE_EXPORT String cookieStoragePartition(const URL& firstPartyForCookies, const URL& resource, std::optional frameID, std::optional pageID) const;
 WEBCORE_EXPORT void 

[webkit-changes] [239408] trunk

[achristensen]

Title: [239408] trunk








Revision 239408
Author achristen...@apple.com
Date 2018-12-19 16:55:10 -0800 (Wed, 19 Dec 2018)


Log Message
Navigations away from the SafeBrowsing interstitial show a flash of old content
https://bugs.webkit.org/show_bug.cgi?id=192676

Reviewed by Chris Dumez.

Source/WebKit:

When a user clicks through a safe browsing warning, do not remove the warning until content is drawn for the destination.
Otherwise, the user will confusingly see the page before the warning while the navigation happens.
We can only do this for warnings caused by main frame navigations, though.  Other warnings (such as those caused by iframes)
need to be cleared immediately, and we still need to clear the warning immediately if the user has said to go back.

This change is reflected in an updated API test.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
* UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:
(WebKit::SafeBrowsingWarning::SafeBrowsingWarning):
* UIProcess/Cocoa/WKSafeBrowsingWarning.h:
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
(-[WKSafeBrowsingWarning forMainFrameNavigation]):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::showSafeBrowsingWarning):
(WebKit::WebViewImpl::clearSafeBrowsingWarningIfForMainFrameNavigation):
* UIProcess/PageClient.h:
(WebKit::PageClient::clearSafeBrowsingWarningIfForMainFrameNavigation):
* UIProcess/SafeBrowsingWarning.h:
(WebKit::SafeBrowsingWarning::create):
(WebKit::SafeBrowsingWarning::forMainFrameNavigation const):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReachLayoutMilestone):
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/mac/PageClientImplMac.h:
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::clearSafeBrowsingWarningIfForMainFrameNavigation):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(safeBrowsingView):
(TEST):
(-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h
trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/SafeBrowsingWarning.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.h
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (239407 => 239408)

--- trunk/Source/WebKit/ChangeLog	2018-12-20 00:54:10 UTC (rev 239407)
+++ trunk/Source/WebKit/ChangeLog	2018-12-20 00:55:10 UTC (rev 239408)
@@ -1,3 +1,45 @@
+2018-12-19  Alex Christensen  
+
+Navigations away from the SafeBrowsing interstitial show a flash of old content
+https://bugs.webkit.org/show_bug.cgi?id=192676
+
+Reviewed by Chris Dumez.
+
+When a user clicks through a safe browsing warning, do not remove the warning until content is drawn for the destination.
+Otherwise, the user will confusingly see the page before the warning while the navigation happens.
+We can only do this for warnings caused by main frame navigations, though.  Other warnings (such as those caused by iframes)
+need to be cleared immediately, and we still need to clear the warning immediately if the user has said to go back.
+
+This change is reflected in an updated API test.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
+* UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:
+(WebKit::SafeBrowsingWarning::SafeBrowsingWarning):
+* UIProcess/Cocoa/WKSafeBrowsingWarning.h:
+* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
+(-[WKSafeBrowsingWarning forMainFrameNavigation]):
+* UIProcess/Cocoa/WebPageProxyCocoa.mm:
+(WebKit::WebPageProxy::beginSafeBrowsingCheck):
+* UIProcess/Cocoa/WebViewImpl.h:
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::showSafeBrowsingWarning):
+(WebKit::WebViewImpl::clearSafeBrowsingWarningIfForMainFrameNavigation):
+* 

[webkit-changes] [239407] trunk/LayoutTests

[ryanhaddad]

Title: [239407] trunk/LayoutTests








Revision 239407
Author ryanhad...@apple.com
Date 2018-12-19 16:54:10 -0800 (Wed, 19 Dec 2018)


Log Message
REGRESSION: [ iOS Sim ] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/update-missing-import-scripts.https.html is failing
https://bugs.webkit.org/show_bug.cgi?id=192250

Unreviewed test gardening.

* platform/ios/TestExpectations: Mark test as flaky.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (239406 => 239407)

--- trunk/LayoutTests/ChangeLog	2018-12-20 00:54:09 UTC (rev 239406)
+++ trunk/LayoutTests/ChangeLog	2018-12-20 00:54:10 UTC (rev 239407)
@@ -1,5 +1,14 @@
 2018-12-19  Ryan Haddad  
 
+REGRESSION: [ iOS Sim ] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/update-missing-import-scripts.https.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=192250
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations: Mark test as flaky.
+
+2018-12-19  Ryan Haddad  
+
 REGRESSION: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html is very flaky on iOS
 https://bugs.webkit.org/show_bug.cgi?id=192279
 


Modified: trunk/LayoutTests/platform/ios/TestExpectations (239406 => 239407)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-12-20 00:54:09 UTC (rev 239406)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-12-20 00:54:10 UTC (rev 239407)
@@ -3224,3 +3224,5 @@
 webkit.org/b/190764 editing/spelling/spelling-dots-position-3.html [ Skip ]
 
 webkit.org/b/192279 imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html [ Pass Failure ]
+
+webkit.org/b/192250 imported/w3c/web-platform-tests/service-workers/service-worker/update-missing-import-scripts.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239405] trunk/Source/WebInspectorUI

[mattbaker]

Title: [239405] trunk/Source/WebInspectorUI








Revision 239405
Author mattba...@apple.com
Date 2018-12-19 16:46:10 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element
https://bugs.webkit.org/show_bug.cgi?id=192871


Reviewed by Devin Rousso.

Undoing a DOM node removal reinserts the node into the DOMTreeOutline.
When the reinserted node precedes the selected node in the tree, the
SelectionController should update `_lastSelectedIndex`.

* UserInterface/Controllers/SelectionController.js:
(WI.SelectionController.prototype.didInsertItem):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239404 => 239405)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 00:31:27 UTC (rev 239404)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 00:46:10 UTC (rev 239405)
@@ -1,3 +1,18 @@
+2018-12-19  Matt Baker  
+
+Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element
+https://bugs.webkit.org/show_bug.cgi?id=192871
+
+
+Reviewed by Devin Rousso.
+
+Undoing a DOM node removal reinserts the node into the DOMTreeOutline.
+When the reinserted node precedes the selected node in the tree, the
+SelectionController should update `_lastSelectedIndex`.
+
+* UserInterface/Controllers/SelectionController.js:
+(WI.SelectionController.prototype.didInsertItem):
+
 2018-12-19  Devin Rousso  
 
 Web Inspector: Audit: provide localization support for % pass display


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js (239404 => 239405)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js	2018-12-20 00:31:27 UTC (rev 239404)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js	2018-12-20 00:46:10 UTC (rev 239405)
@@ -212,6 +212,11 @@
 
 current = this._selectedIndexes.indexLessThan(current);
 }
+
+if (this._lastSelectedIndex >= index)
+this._lastSelectedIndex += 1;
+if (this._shiftAnchorIndex >= index)
+this._shiftAnchorIndex += 1;
 }
 
 didRemoveItems(indexes)


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (239404 => 239405)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js	2018-12-20 00:31:27 UTC (rev 239404)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js	2018-12-20 00:46:10 UTC (rev 239405)
@@ -406,8 +406,10 @@
 this._cachedNumberOfDescendents++;
 
 let index = this._indexOfTreeElement(element);
-if (index >= 0)
+if (index >= 0) {
+console.assert(!element.selected, "TreeElement should not be selected before being inserted.");
 this._selectionController.didInsertItem(index);
+}
 }
 
 _forgetTreeElement(element)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239404] trunk/Source/WebInspectorUI

[drousso]

Title: [239404] trunk/Source/WebInspectorUI








Revision 239404
Author drou...@apple.com
Date 2018-12-19 16:31:27 -0800 (Wed, 19 Dec 2018)


Log Message
Web Inspector: Audit: provide localization support for % pass display
https://bugs.webkit.org/show_bug.cgi?id=192870


Reviewed by Brian Burg.

* UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.initialLayout):
(WI.AuditTestGroupContentView.prototype.layout):
* UserInterface/Views/AuditTestGroupContentView.css:
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .percentage-pass > span): Added.
(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass): Added.
(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass > span): Added.
(.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after): Deleted.

* Localizations/en.lproj/localizedStrings.js:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css
trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239403 => 239404)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 00:07:32 UTC (rev 239403)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 00:31:27 UTC (rev 239404)
@@ -1,3 +1,23 @@
+2018-12-19  Devin Rousso  
+
+Web Inspector: Audit: provide localization support for % pass display
+https://bugs.webkit.org/show_bug.cgi?id=192870
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/AuditTestGroupContentView.js:
+(WI.AuditTestGroupContentView.prototype.initialLayout):
+(WI.AuditTestGroupContentView.prototype.layout):
+* UserInterface/Views/AuditTestGroupContentView.css:
+(.content-view.audit-test-group > header > .percentage-pass):
+(.content-view.audit-test-group > header > .percentage-pass > span): Added.
+(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass): Added.
+(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass > span): Added.
+(.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after): Deleted.
+
+* Localizations/en.lproj/localizedStrings.js:
+
 2018-12-19  Nikita Vasilyev  
 
 Web Inspector: Computed: make UI more usable when the panel is narrow


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (239403 => 239404)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2018-12-20 00:07:32 UTC (rev 239403)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2018-12-20 00:31:27 UTC (rev 239404)
@@ -56,6 +56,7 @@
 localizedStrings["%s delay"] = "%s delay";
 localizedStrings["%s eval\n%s async"] = "%s eval\n%s async";
 localizedStrings["%s interval"] = "%s interval";
+localizedStrings["%s%%"] = "%s%%";
 localizedStrings["(Action %s)"] = "(Action %s)";
 localizedStrings["(Disk)"] = "(Disk)";
 localizedStrings["(Index)"] = "(Index)";


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css (239403 => 239404)

--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css	2018-12-20 00:07:32 UTC (rev 239403)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css	2018-12-20 00:31:27 UTC (rev 239404)
@@ -122,16 +122,17 @@
 .content-view.audit-test-group > header > .percentage-pass {
 width: var(--metadata-width);
 -webkit-margin-start: var(--audit-test-horizontal-space);
-font-size: 24px;
+font-size: 16px;
 text-align: center;
 font-weight: bold;
-opacity: 0.65;
+/* FIXME: Use CSS4 color blend functions once they're available. */
+color: hsla(0, 0%, 0%, 0.5);
 }
 
-.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after {
-content: "%";
-font-size: 16px;
-opacity: 0.75;
+.content-view.audit-test-group > header > .percentage-pass > span {
+font-size: 24px;
+/* FIXME: Use CSS4 color blend functions once they're available. */
+color: hsla(0, 0%, 0%, 0.65);
 }
 
 .content-view.audit-test-group > section > .audit-test-case:first-child,
@@ -143,3 +144,15 @@
 .content-view.audit-test-group > section > .audit-test-case:last-child {
 margin-bottom: var(--audit-test-vertical-space);
 }
+
+@media (prefers-dark-interface) {
+.content-view.audit-test-group > header > .percentage-pass {
+/* FIXME: Use CSS4 color blend functions once they're available. */
+color: hsla(0, 0%, 88%, 0.5);
+}
+
+.content-view.audit-test-group > header > .percentage-pass > span {
+/* FIXME: Use CSS4 color blend functions once 

[webkit-changes] [239403] branches/safari-606-branch

[alancoon]

Title: [239403] branches/safari-606-branch








Revision 239403
Author alanc...@apple.com
Date 2018-12-19 16:07:32 -0800 (Wed, 19 Dec 2018)


Log Message
Apply patch. rdar://problem/46848447

Modified Paths

branches/safari-606-branch/Source/WebCore/ChangeLog
branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.cpp
branches/safari-606-branch/Source/WebCore/platform/network/NetworkStorageSession.h
branches/safari-606-branch/Source/WebCore/platform/network/mac/CookieJarMac.mm
branches/safari-606-branch/Source/WebKit/ChangeLog
branches/safari-606-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-606-branch/Source/WebKit/NetworkProcess/NetworkProcess.h
branches/safari-606-branch/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
branches/safari-606-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
branches/safari-606-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
branches/safari-606-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h
branches/safari-606-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h


Added Paths

branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-expected.txt
branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js.html




Diff

Added: branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-expected.txt (0 => 239403)

--- branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-expected.txt	(rev 0)
+++ branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-expected.txt	2018-12-20 00:07:32 UTC (rev 239403)
@@ -0,0 +1,22 @@
+Check that cookies created by _javascript_ with max-age or expiry longer than a week get capped to a week.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS The two short-lived cookies don't expire after more than 172830 seconds.
+PASS The two long-lived cookies don't expire after more than 604830 seconds.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+Check that cookies created by _javascript_ with max-age or expiry longer than a week get capped to a week.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS The two short-lived cookies don't expire after more than 172830 seconds.
+PASS The two long-lived cookies don't expire after more than 604830 seconds.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js.html (0 => 239403)

--- branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js.html	(rev 0)
+++ branches/safari-606-branch/LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js.html	2018-12-20 00:07:32 UTC (rev 239403)
@@ -0,0 +1,158 @@
+
+
+
+
+
+