[webkit-changes] [256585] trunk/Source/WebCore
Title: [256585] trunk/Source/WebCore Revision 256585 Author hironori.fu...@sony.com Date 2020-02-13 22:50:25 -0800 (Thu, 13 Feb 2020) Log Message Unreviewed build fix for WebCore shared library builds. * crypto/openssl/SerializedCryptoKeyWrapOpenSSL.cpp: Include "SerializedCryptoKeyWrap.h". Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/crypto/openssl/SerializedCryptoKeyWrapOpenSSL.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (256584 => 256585) --- trunk/Source/WebCore/ChangeLog 2020-02-14 03:48:34 UTC (rev 256584) +++ trunk/Source/WebCore/ChangeLog 2020-02-14 06:50:25 UTC (rev 256585) @@ -1,3 +1,9 @@ +2020-02-13 Fujii Hironori + +Unreviewed build fix for WebCore shared library builds. + +* crypto/openssl/SerializedCryptoKeyWrapOpenSSL.cpp: Include "SerializedCryptoKeyWrap.h". + 2020-02-13 Jer Noble MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo() Modified: trunk/Source/WebCore/crypto/openssl/SerializedCryptoKeyWrapOpenSSL.cpp (256584 => 256585) --- trunk/Source/WebCore/crypto/openssl/SerializedCryptoKeyWrapOpenSSL.cpp 2020-02-14 03:48:34 UTC (rev 256584) +++ trunk/Source/WebCore/crypto/openssl/SerializedCryptoKeyWrapOpenSSL.cpp 2020-02-14 06:50:25 UTC (rev 256585) @@ -24,6 +24,8 @@ */ #include "config.h" +#include "SerializedCryptoKeyWrap.h" + #include "CryptoAlgorithmAES_CTR.h" #if ENABLE(WEB_CRYPTO) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256584] trunk/Source/WebCore
Title: [256584] trunk/Source/WebCore
Revision 256584
Author jer.no...@apple.com
Date 2020-02-13 19:48:34 -0800 (Thu, 13 Feb 2020)
Log Message
MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
https://bugs.webkit.org/show_bug.cgi?id=207733
Reviewed by Maciej Stachowiak.
* platform/mac/PlatformScreenMac.mm:
(WebCore::setShouldOverrideScreenSupportsHighDynamicRange):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (256583 => 256584)
--- trunk/Source/WebCore/ChangeLog 2020-02-14 03:41:06 UTC (rev 256583)
+++ trunk/Source/WebCore/ChangeLog 2020-02-14 03:48:34 UTC (rev 256584)
@@ -1,3 +1,14 @@
+2020-02-13 Jer Noble
+
+MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
+https://bugs.webkit.org/show_bug.cgi?id=207733
+
+
+Reviewed by Maciej Stachowiak.
+
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::setShouldOverrideScreenSupportsHighDynamicRange):
+
2020-02-13 Kate Cheney
Expose prevalent domains on a per-page basis
Modified: trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm (256583 => 256584)
--- trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-02-14 03:41:06 UTC (rev 256583)
+++ trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-02-14 03:48:34 UTC (rev 256584)
@@ -158,7 +158,7 @@
void setShouldOverrideScreenSupportsHighDynamicRange(bool shouldOverride, bool supportsHighDynamicRange)
{
-if (PAL::canLoad_MediaToolbox_MTOverrideShouldPlayHDRVideo())
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTOverrideShouldPlayHDRVideo())
PAL::softLink_MediaToolbox_MTOverrideShouldPlayHDRVideo(shouldOverride, supportsHighDynamicRange);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256583] trunk
Title: [256583] trunk Revision 256583 Author katherine_che...@apple.com Date 2020-02-13 19:41:06 -0800 (Thu, 13 Feb 2020) Log Message Source/WebCore: Expose prevalent domains on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=207523 Reviewed by Chris Dumez. Tests: http/tests/resourceLoadStatistics/prevalent-domains-per-page-database.html http/tests/resourceLoadStatistics/prevalent-domains-per-page.html Logs subresource loads in CachedResourceLoader::requestResource, and redirects in ResourceLoader::willSendRequestInternal, and reports domains to the Web Process. * loader/FrameLoaderClient.h: * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): * loader/cache/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): Source/WebKit: Expose prevalent domains on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=207523 Reviewed by Chris Dumez. Tests: http/tests/resourceLoadStatistics/prevalent-domains-per-page-database.html http/tests/resourceLoadStatistics/prevalent-domains-per-page.html Added an API to report prevalent domains. The Web Process sends all new loads to the Network Process, which determines if the resources are prevalent. When the API is queried, the Web Process reports these domains to the UI Process. The WebPage keeps a hash set of previously loaded domains to avoid spamming IPC with repeat domains. * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::requestStorageAccessUnderOpener): (WebKit::NetworkConnectionToWebProcess::reportSubresourceLoadToDomain): * NetworkProcess/NetworkConnectionToWebProcess.h: * NetworkProcess/NetworkConnectionToWebProcess.messages.in: * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _getPrevalentDomainsFor:completionHandler:]): (-[WKWebsiteDataStore _clearPrevalentDomainsFor:]): * UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): * UIProcess/WebPageProxy.h: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::addLoadedRegistrableDomain): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setIsSuspended): (WebKit::WebPage::addLoadedRegistrableDomain): (WebKit::WebPage::getPrevalentDomains): (WebKit::WebPage::clearPrevalentDomains): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Tools: Expose prevalent domains on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=207523 Reviewed by Chris Dumez. Added WebKitTestRunner functions so this functionality can be tested. clearPrevalentDomains should be called between tests to reset the state. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::getPrevalentDomains): (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::getPrevalentDomains): (WTR::TestController::clearPrevalentDomains): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::didReceivePrevalentDomains): * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::getPrevalentDomains): (WTR::TestController::clearPrevalentDomains): LayoutTests: Expose prevalent domains on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=207523 Reviewed by Chris Dumez. Added 2 new tests for the resource load statistics database and memory stores. Added a basic iframe that both tests can use to test if a resource load from a prevalent domain gets reported properly. * http/tests/resourceLoadStatistics/prevalent-domains-per-page-database-expected.txt: Added. * http/tests/resourceLoadStatistics/prevalent-domains-per-page-database.html: Added. * http/tests/resourceLoadStatistics/prevalent-domains-per-page-expected.txt: Added. * http/tests/resourceLoadStatistics/prevalent-domains-per-page.html: Added. * http/tests/resourceLoadStatistics/resources/basic-iframe.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/FrameLoaderClient.h trunk/Source/WebCore/loader/ResourceLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp trunk/Source/WebCore/platform/RegistrableDomain.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
[webkit-changes] [256582] trunk/LayoutTests
Title: [256582] trunk/LayoutTests Revision 256582 Author commit-qu...@webkit.org Date 2020-02-13 19:32:27 -0800 (Thu, 13 Feb 2020) Log Message [GTK] Gardening more flaky crashes https://bugs.webkit.org/show_bug.cgi?id=207738 Unreviewed test gardening. Patch by Lauro Moura on 2020-02-13 * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256581 => 256582) --- trunk/LayoutTests/ChangeLog 2020-02-14 03:13:34 UTC (rev 256581) +++ trunk/LayoutTests/ChangeLog 2020-02-14 03:32:27 UTC (rev 256582) @@ -1,3 +1,12 @@ +2020-02-13 Lauro Moura + +[GTK] Gardening more flaky crashes +https://bugs.webkit.org/show_bug.cgi?id=207738 + +Unreviewed test gardening. + +* platform/gtk/TestExpectations: + 2020-02-13 Ben Nham Flash of white can occur if JS forces an early layout Modified: trunk/LayoutTests/platform/gtk/TestExpectations (256581 => 256582) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-14 03:13:34 UTC (rev 256581) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-14 03:32:27 UTC (rev 256582) @@ -614,9 +614,8 @@ # No support for MPEG-4 caption support webkit.org/b/131546 media/track/track-forced-subtitles-in-band.html [ Timeout Failure ] webkit.org/b/131546 media/track/track-in-band-cues-added-once.html [ Timeout Crash ] -webkit.org/b/131546 media/track/track-in-band-style.html [ Timeout ] -# Crash with other tests in webkit.org/b/198830 -webkit.org/b/131546 media/track/track-in-band-legacy-api.html [ Failure Crash ] +webkit.org/b/131546 webkit.org/b/198830 media/track/track-in-band-style.html [ Timeout Crash ] +webkit.org/b/131546 webkit.org/b/198830 media/track/track-in-band-legacy-api.html [ Failure Crash ] webkit.org/b/131546 media/track/track-in-band-mode.html [ Skip ] # DataCue.value not enabled @@ -1443,6 +1442,8 @@ webkit.org/b/207605 [ Debug ] http/tests/websocket/tests/hybi/no-subprotocol.html [ Crash ] webkit.org/b/207605 [ Debug ] http/tests/workers/service/postmessage-after-terminate.https.html [ Crash ] +webkit.org/b/207737 imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html [ Pass Crash ] + # # End of Crashing tests # @@ -1678,9 +1679,9 @@ #Media controls webkit.org/b/132271 media/controls-styling-strict.html [ Failure Timeout Pass Crash ] webkit.org/b/132271 media/controls-strict.html [ ImageOnlyFailure Timeout Pass ] -webkit.org/b/132271 media/media-controls-timeline-updates.html [ Timeout Pass ] +webkit.org/b/132271 webkit.org/b/198830 media/media-controls-timeline-updates.html [ Timeout Pass Crash ] webkit.org/b/132271 media/media-controller-playbackrate.html [ Timeout Pass Crash ] -webkit.org/b/132271 media/media-controller-time-clamp.html [ Timeout Pass ] +webkit.org/b/132271 webkit.org/b/198830 media/media-controller-time-clamp.html [ Timeout Pass Crash ] webkit.org/b/132271 media/track/add-and-remove-track.html [ Timeout Pass ] webkit.org/b/132271 media/controls-without-preload.html [ Failure Timeout Pass ] webkit.org/b/145251 media/controls-right-click-on-timebar.html [ Timeout Pass Failure Crash ] @@ -1719,8 +1720,7 @@ webkit.org/b/134576 media/track/audio/audio-track-mkv-vorbis-language.html [ Failure Timeout Pass ] webkit.org/b/134576 media/track/track-cue-rendering.html [ Failure Timeout Pass ] webkit.org/b/134576 media/track/video/video-track-mkv-theora-selected.html [ Failure Timeout Pass Crash ] -# This one below is also crash with others in webkit.org/b/198830 -webkit.org/b/134576 media/track/video/video-track-mkv-theora-language.html [ Failure Timeout Pass Crash ] +webkit.org/b/134576 webkit.org/b/198830 media/track/video/video-track-mkv-theora-language.html [ Failure Timeout Pass Crash ] webkit.org/b/134577 svg/dom/svg-root-lengths.html [ Failure Timeout Pass ] webkit.org/b/103383 fast/css/counters/element-removal-crash.xhtml [ Failure Pass ] webkit.org/b/134579 fast/forms/state-restore-to-non-edited-controls.html [ Timeout Pass ] @@ -1853,8 +1853,7 @@ webkit.org/b/158913 media/media-controls-play-button-updates.html [ Failure Pass Crash ] -# Also flaky crash in webkit.org/b/198830 -webkit.org/b/158914 media/restore-from-page-cache.html [ Failure Pass Crash ] +webkit.org/b/158914 webkit.org/b/198830 media/restore-from-page-cache.html [ Failure Pass Crash ] webkit.org/b/158915 fast/forms/select/menulist-type-ahead-find.html [ Failure Pass ] @@ -2000,7 +1999,6 @@ webkit.org/b/186638 imported/w3c/web-platform-tests/mathml/relations/html5-tree/class-1.html [ Timeout Pass ] webkit.org/b/186638 media/video-remote-control-playpause.html [ Timeout Pass ] webkit.org/b/186638 media/video-zoom.html [ Failure Pass ] -webkit.org/b/186638
[webkit-changes] [256581] trunk/Tools
Title: [256581] trunk/Tools
Revision 256581
Author hironori.fu...@sony.com
Date 2020-02-13 19:13:34 -0800 (Thu, 13 Feb 2020)
Log Message
[Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
https://bugs.webkit.org/show_bug.cgi?id=207682
Reviewed by Ross Kirsling.
The toolbar placed button common controls as the toolbar buttons.
However, because these buttons are focusable, shortcut keys don't
work after clicking them.
Added Home button, Add to Bookmarks button, dropdown buttons of
back and forward buttons, but they aren't implemented yet. Just
placeholders at the moment.
* MiniBrowser/win/MainWindow.cpp:
(MainWindow::createToolbar): Added.
(MainWindow::resizeToolbar): Added.
(MainWindow::rescaleToolbar): Added.
(MainWindow::init):
(MainWindow::resizeSubViews):
(MainWindow::updateDeviceScaleFactor):
* MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/win/MainWindow.cpp
trunk/Tools/MiniBrowser/win/MainWindow.h
Diff
Modified: trunk/Tools/ChangeLog (256580 => 256581)
--- trunk/Tools/ChangeLog 2020-02-14 02:56:32 UTC (rev 256580)
+++ trunk/Tools/ChangeLog 2020-02-14 03:13:34 UTC (rev 256581)
@@ -1,3 +1,27 @@
+2020-02-13 Fujii Hironori
+
+[Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
+https://bugs.webkit.org/show_bug.cgi?id=207682
+
+Reviewed by Ross Kirsling.
+
+The toolbar placed button common controls as the toolbar buttons.
+However, because these buttons are focusable, shortcut keys don't
+work after clicking them.
+
+Added Home button, Add to Bookmarks button, dropdown buttons of
+back and forward buttons, but they aren't implemented yet. Just
+placeholders at the moment.
+
+* MiniBrowser/win/MainWindow.cpp:
+(MainWindow::createToolbar): Added.
+(MainWindow::resizeToolbar): Added.
+(MainWindow::rescaleToolbar): Added.
+(MainWindow::init):
+(MainWindow::resizeSubViews):
+(MainWindow::updateDeviceScaleFactor):
+* MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
+
2020-02-13 Ryosuke Niwa
Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
Modified: trunk/Tools/MiniBrowser/win/MainWindow.cpp (256580 => 256581)
--- trunk/Tools/MiniBrowser/win/MainWindow.cpp 2020-02-14 02:56:32 UTC (rev 256580)
+++ trunk/Tools/MiniBrowser/win/MainWindow.cpp 2020-02-14 03:13:34 UTC (rev 256581)
@@ -46,8 +46,9 @@
float deviceScaleFactorForWindow(HWND);
}
-static constexpr int controlButtonWidth = 24;
-static constexpr int urlBarHeight = 24;
+static constexpr int kToolbarImageSize = 24;
+static constexpr int kToolbarURLBarIndex = 4;
+static constexpr int kToolbarProgressIndicatorIndex = 6;
static WNDPROC DefEditProc = nullptr;
@@ -114,6 +115,88 @@
return adoptRef(*new MainWindow());
}
+void MainWindow::createToolbar(HINSTANCE hInstance)
+{
+m_hToolbarWnd = CreateWindowEx(0, TOOLBARCLASSNAME, nullptr,
+WS_CHILD | WS_BORDER | TBSTYLE_LIST | TBSTYLE_TOOLTIPS, 0, 0, 0, 0,
+m_hMainWnd, nullptr, hInstance, nullptr);
+
+if (!m_hToolbarWnd)
+return;
+
+const int ImageListID = 0;
+const int numButtons = 3;
+
+HIMAGELIST hImageList;
+hImageList = ImageList_Create(kToolbarImageSize, kToolbarImageSize, ILC_COLOR16 | ILC_MASK, numButtons, 0);
+
+SendMessage(m_hToolbarWnd, TB_SETIMAGELIST, ImageListID, reinterpret_cast(hImageList));
+SendMessage(m_hToolbarWnd, TB_LOADIMAGES, IDB_HIST_LARGE_COLOR, reinterpret_cast(HINST_COMMCTRL));
+SendMessage(m_hToolbarWnd, TB_SETEXTENDEDSTYLE, 0, TBSTYLE_EX_DRAWDDARROWS | TBSTYLE_EX_MIXEDBUTTONS);
+
+const DWORD buttonStyles = BTNS_AUTOSIZE;
+
+TBBUTTON tbButtons[] = {
+{ MAKELONG(HIST_BACK, ImageListID), IDM_HISTORY_BACKWARD, TBSTATE_ENABLED, buttonStyles | BTNS_DROPDOWN, { }, 0, (INT_PTR)L"Back" },
+{ MAKELONG(HIST_FORWARD, ImageListID), IDM_HISTORY_FORWARD, TBSTATE_ENABLED, buttonStyles | BTNS_DROPDOWN, { }, 0, (INT_PTR)L"Forward"},
+{ I_IMAGENONE, IDM_RELOAD, TBSTATE_ENABLED, buttonStyles | BTNS_SHOWTEXT, { }, 0, (INT_PTR)L"↺"},
+{ I_IMAGENONE, IDM_RELOAD, 0, buttonStyles | BTNS_SHOWTEXT, { }, 0, (INT_PTR)L"⌂"},
+{ 0, 0, TBSTATE_ENABLED, BTNS_SEP, { }, 0, 0}, // URL bar
+{ MAKELONG(HIST_ADDTOFAVORITES, ImageListID), IDM_ABOUT, 0, buttonStyles, { }, 0, (INT_PTR)L"Add to Bookmarks"},
+{ 0, 0, TBSTATE_ENABLED, BTNS_SEP, { }, 0, 0}, // Progress indicator
+};
+ASSERT(tbButtons[kToolbarURLBarIndex].fsStyle == BTNS_SEP);
+ASSERT(tbButtons[kToolbarProgressIndicatorIndex].fsStyle == BTNS_SEP);
+
+SendMessage(m_hToolbarWnd, TB_BUTTONSTRUCTSIZE, sizeof(TBBUTTON), 0);
+SendMessage(m_hToolbarWnd, TB_ADDBUTTONS, _countof(tbButtons), reinterpret_cast());
+SendMessage(m_hToolbarWnd, TB_AUTOSIZE, 0, 0);
+
[webkit-changes] [256580] trunk
Title: [256580] trunk
Revision 256580
Author rn...@webkit.org
Date 2020-02-13 18:56:32 -0800 (Thu, 13 Feb 2020)
Log Message
Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
https://bugs.webkit.org/show_bug.cgi?id=207676
Reviewed by Wenson Hsieh and Timothy Hatcher.
Source/WebCore:
The bug was caused by EditingStyle::inverseTransformColorIfNeeded converting -apple-system-label to
transparent color in ReplaceSelectionCommand when InsertListCommand invokes moveParagraphs.
This patch fixes the bug in EditingStyle::inverseTransformColorIfNeeded by treating any semantic color
name or semantic RGB color value as if the color was not specified.
It also fixes the bug that removeStyleFromRulesAndContext was incapable of removing superflous semantic
color names that appear in the inline since the context's computed style only contain RGB values by
replacing the inline style's color values with that of the computed style. This fix is necessary to
eliminate -apple-system-label in the pasted content, which can cause issues when such a content is
sync'ed to other devices via iCloud, etc...
Tests: PasteHTML.TransformColorsOfDarkContentButNotSemanticColor
PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::inverseTransformColorIfNeeded):
Tools:
Added regression tests for pasting content with -apple-system-label and outdenting content.
* TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
(PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
(PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (256579 => 256580)
--- trunk/Source/WebCore/ChangeLog 2020-02-14 02:25:04 UTC (rev 256579)
+++ trunk/Source/WebCore/ChangeLog 2020-02-14 02:56:32 UTC (rev 256580)
@@ -1,3 +1,29 @@
+2020-02-13 Ryosuke Niwa
+
+Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
+https://bugs.webkit.org/show_bug.cgi?id=207676
+
+Reviewed by Wenson Hsieh and Timothy Hatcher.
+
+The bug was caused by EditingStyle::inverseTransformColorIfNeeded converting -apple-system-label to
+transparent color in ReplaceSelectionCommand when InsertListCommand invokes moveParagraphs.
+
+This patch fixes the bug in EditingStyle::inverseTransformColorIfNeeded by treating any semantic color
+name or semantic RGB color value as if the color was not specified.
+
+It also fixes the bug that removeStyleFromRulesAndContext was incapable of removing superflous semantic
+color names that appear in the inline since the context's computed style only contain RGB values by
+replacing the inline style's color values with that of the computed style. This fix is necessary to
+eliminate -apple-system-label in the pasted content, which can cause issues when such a content is
+sync'ed to other devices via iCloud, etc...
+
+Tests: PasteHTML.TransformColorsOfDarkContentButNotSemanticColor
+ PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent
+
+* editing/EditingStyle.cpp:
+(WebCore::EditingStyle::removeStyleFromRulesAndContext):
+(WebCore::EditingStyle::inverseTransformColorIfNeeded):
+
2020-02-13 Brent Fulgham
REGRESSION (r255961): Default state for data URL handling is incorrect
Modified: trunk/Source/WebCore/editing/EditingStyle.cpp (256579 => 256580)
--- trunk/Source/WebCore/editing/EditingStyle.cpp 2020-02-14 02:25:04 UTC (rev 256579)
+++ trunk/Source/WebCore/editing/EditingStyle.cpp 2020-02-14 02:56:32 UTC (rev 256580)
@@ -1366,6 +1366,30 @@
if (!computedStyle->m_mutableStyle->getPropertyCSSValue(CSSPropertyBackgroundColor))
computedStyle->m_mutableStyle->setProperty(CSSPropertyBackgroundColor, CSSValueTransparent);
+RefPtr computedStyleOfElement;
+auto replaceSemanticColorWithComputedValue = [&](const CSSPropertyID id) {
+auto color = m_mutableStyle->propertyAsColor(id);
+if (!color || (color->isVisible() && !color->isSemantic()))
+return;
+
+if (!computedStyleOfElement)
+computedStyleOfElement = EditingStyle::create(, EditingPropertiesInEffect);
+
+if (!computedStyleOfElement->m_mutableStyle)
+return;
+
+auto computedValue = computedStyleOfElement->m_mutableStyle->getPropertyValue(id);
+if (!computedValue)
+return;
+
+m_mutableStyle->setProperty(id, computedValue);
+};
+
+// Replace semantic color identifiers like -apple-system-label with RGB values so that comparsions in
[webkit-changes] [256578] trunk/Source/WebKit
Title: [256578] trunk/Source/WebKit
Revision 256578
Author you...@apple.com
Date 2020-02-13 17:54:59 -0800 (Thu, 13 Feb 2020)
Log Message
Protect WebSWServerConnection::scheduleJobInServer from bad scopeURL
https://bugs.webkit.org/show_bug.cgi?id=207722
Reviewed by Chris Dumez.
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::scheduleJobInServer):
In case of bad scope, fail the job early on.
* WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::scheduleJobInServer):
Remove the RELEASE_ASSERT from now since we defend in Network process.
We will add it back in ServiceWorkerRegistration::getOrCreate as a follow-up.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (256577 => 256578)
--- trunk/Source/WebKit/ChangeLog 2020-02-14 01:31:05 UTC (rev 256577)
+++ trunk/Source/WebKit/ChangeLog 2020-02-14 01:54:59 UTC (rev 256578)
@@ -1,3 +1,18 @@
+2020-02-13 Youenn Fablet
+
+Protect WebSWServerConnection::scheduleJobInServer from bad scopeURL
+https://bugs.webkit.org/show_bug.cgi?id=207722
+
+Reviewed by Chris Dumez.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::scheduleJobInServer):
+In case of bad scope, fail the job early on.
+* WebProcess/Storage/WebSWClientConnection.cpp:
+(WebKit::WebSWClientConnection::scheduleJobInServer):
+Remove the RELEASE_ASSERT from now since we defend in Network process.
+We will add it back in ServiceWorkerRegistration::getOrCreate as a follow-up.
+
2020-02-13 Ben Nham
Flash of white can occur if JS forces an early layout
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256577 => 256578)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-14 01:31:05 UTC (rev 256577)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-14 01:54:59 UTC (rev 256578)
@@ -272,6 +272,12 @@
void WebSWServerConnection::scheduleJobInServer(ServiceWorkerJobData&& jobData)
{
+ASSERT(!jobData.scopeURL.isNull());
+if (jobData.scopeURL.isNull()) {
+rejectJobInClient(jobData.identifier().jobIdentifier, ExceptionData { InvalidStateError, "Scope URL is empty"_s });
+return;
+}
+
SWSERVERCONNECTION_RELEASE_LOG_IF_ALLOWED("Scheduling ServiceWorker job %s in server", jobData.identifier().loggingString().utf8().data());
ASSERT(identifier() == jobData.connectionIdentifier());
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp (256577 => 256578)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp 2020-02-14 01:31:05 UTC (rev 256577)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp 2020-02-14 01:54:59 UTC (rev 256578)
@@ -73,7 +73,6 @@
void WebSWClientConnection::scheduleJobInServer(const ServiceWorkerJobData& jobData)
{
-RELEASE_ASSERT(!jobData.scopeURL.isNull());
runOrDelayTaskForImport([this, jobData] {
send(Messages::WebSWServerConnection::ScheduleJobInServer { jobData });
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256577] trunk
Title: [256577] trunk Revision 256577 Author commit-qu...@webkit.org Date 2020-02-13 17:31:05 -0800 (Thu, 13 Feb 2020) Log Message Flash of white can occur if JS forces an early layout https://bugs.webkit.org/show_bug.cgi?id=207516 This causes us to wait for the first non-empty layout before we paint on Mac, which we already do on all other platforms. Patch by Ben Nham on 2020-02-13 Reviewed by Antti Koivisto. Source/WebKit: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone): LayoutTests: * fast/scrolling/rtl-scrollbars-listbox-scroll.html: Wait for document to load before scrolling. * platform/mac/TestExpectations: Skip before-load-001.html as we already do on iOS. This test depends on first paint timing and this patch makes the Mac behave like iOS in terms of first paint. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Diff Modified: trunk/LayoutTests/ChangeLog (256576 => 256577) --- trunk/LayoutTests/ChangeLog 2020-02-14 01:17:27 UTC (rev 256576) +++ trunk/LayoutTests/ChangeLog 2020-02-14 01:31:05 UTC (rev 256577) @@ -1,3 +1,16 @@ +2020-02-13 Ben Nham + +Flash of white can occur if JS forces an early layout +https://bugs.webkit.org/show_bug.cgi?id=207516 + +This causes us to wait for the first non-empty layout before we paint on Mac, which we +already do on all other platforms. + +Reviewed by Antti Koivisto. + +* fast/scrolling/rtl-scrollbars-listbox-scroll.html: Wait for document to load before scrolling. +* platform/mac/TestExpectations: Skip before-load-001.html as we already do on iOS. This test depends on first paint timing and this patch makes the Mac behave like iOS in terms of first paint. + 2020-02-13 Jason Lawrence [ Mac wk2 ] fast/scrolling/latching/iframe_in_iframe.html is flaky failing. Modified: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html (256576 => 256577) --- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html 2020-02-14 01:17:27 UTC (rev 256576) +++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html 2020-02-14 01:31:05 UTC (rev 256577) @@ -26,9 +26,11 @@if (window.eventSender) {-eventSender.mouseMoveTo(25, 5); -eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -20, "began", "none"); -eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, "ended", "none");+window.addEventListener('load', function() { +eventSender.mouseMoveTo(25, 5); +eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -20, "began", "none"); +eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, "ended", "none"); +}); } Modified: trunk/LayoutTests/platform/mac/TestExpectations (256576 => 256577) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-14 01:17:27 UTC (rev 256576) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-14 01:31:05 UTC (rev 256577) @@ -1883,6 +1883,8 @@ webkit.org/b/203171 inspector/layers/layers-for-node.html [ Pass Failure ] +webkit.org/b/203416 imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html [ Failure ] + webkit.org/b/203305 [ HighSierra Debug ] imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html [ Pass Failure ] webkit.org/b/203305 [ HighSierra Debug ] imported/w3c/web-platform-tests/css/css-transitions/properties-value-inherit-001.html [ Pass Failure ] webkit.org/b/203357 [ Debug ] imported/w3c/web-platform-tests/css/css-transitions/event-dispatch.tentative.html [ Pass Failure ] Modified: trunk/Source/WebKit/ChangeLog (256576 => 256577) --- trunk/Source/WebKit/ChangeLog 2020-02-14 01:17:27 UTC (rev 256576) +++ trunk/Source/WebKit/ChangeLog 2020-02-14 01:31:05 UTC (rev 256577) @@ -1,3 +1,16 @@ +2020-02-13 Ben Nham + +Flash of white can occur if JS forces an early layout +https://bugs.webkit.org/show_bug.cgi?id=207516 + +This causes us to wait for the first non-empty layout before we paint on Mac, which we +already do on all other platforms. + +Reviewed by Antti Koivisto. + +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone): + 2020-02-13 Brent Fulgham REGRESSION (r255961): Default state for data URL handling is incorrect Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (256576 => 256577) --- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2020-02-14 01:17:27 UTC (rev 256576) +++
[webkit-changes] [256576] branches/safari-610.1.3-branch/Source
Title: [256576] branches/safari-610.1.3-branch/Source Revision 256576 Author kocsen_ch...@apple.com Date 2020-02-13 17:17:27 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256571. rdar://problem/59443242 REGRESSION (r255961): Default state for data URL handling is incorrect https://bugs.webkit.org/show_bug.cgi?id=207719 Reviewed by Chris Dumez. The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in while we work through compatibility issues. Source/WebCore: Tested by existing test cases. * page/Settings.yaml: Source/WebKit: * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256571 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610.1.3-branch/Source/WebCore/ChangeLog branches/safari-610.1.3-branch/Source/WebCore/page/Settings.yaml branches/safari-610.1.3-branch/Source/WebKit/ChangeLog branches/safari-610.1.3-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm Diff Modified: branches/safari-610.1.3-branch/Source/WebCore/ChangeLog (256575 => 256576) --- branches/safari-610.1.3-branch/Source/WebCore/ChangeLog 2020-02-14 01:13:36 UTC (rev 256575) +++ branches/safari-610.1.3-branch/Source/WebCore/ChangeLog 2020-02-14 01:17:27 UTC (rev 256576) @@ -1,3 +1,44 @@ +2020-02-13 Kocsen Chung + +Cherry-pick r256571. rdar://problem/59443242 + +REGRESSION (r255961): Default state for data URL handling is incorrect +https://bugs.webkit.org/show_bug.cgi?id=207719 + + +Reviewed by Chris Dumez. + +The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in +while we work through compatibility issues. + +Source/WebCore: + +Tested by existing test cases. + +* page/Settings.yaml: + +Source/WebKit: + +* UIProcess/API/Cocoa/WKWebViewConfiguration.mm: +(-[WKWebViewConfiguration init]): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256571 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-13 Brent Fulgham + +REGRESSION (r255961): Default state for data URL handling is incorrect +https://bugs.webkit.org/show_bug.cgi?id=207719 + + +Reviewed by Chris Dumez. + +The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in +while we work through compatibility issues. + +Tested by existing test cases. + +* page/Settings.yaml: + 2020-02-13 Alan Coon Cherry-pick r256493. rdar://problem/59412867 Modified: branches/safari-610.1.3-branch/Source/WebCore/page/Settings.yaml (256575 => 256576) --- branches/safari-610.1.3-branch/Source/WebCore/page/Settings.yaml 2020-02-14 01:13:36 UTC (rev 256575) +++ branches/safari-610.1.3-branch/Source/WebCore/page/Settings.yaml 2020-02-14 01:17:27 UTC (rev 256576) @@ -108,7 +108,7 @@ allowCrossOriginSubresourcesToAskForCredentials: initial: false allowTopNavigationToDataURLs: - initial: false + initial: true needsStorageAccessFromFileURLsQuirk: initial: true needsFrameNameFallbackToIdQuirk: Modified: branches/safari-610.1.3-branch/Source/WebKit/ChangeLog (256575 => 256576) --- branches/safari-610.1.3-branch/Source/WebKit/ChangeLog 2020-02-14 01:13:36 UTC (rev 256575) +++ branches/safari-610.1.3-branch/Source/WebKit/ChangeLog 2020-02-14 01:17:27 UTC (rev 256576) @@ -1,3 +1,43 @@ +2020-02-13 Kocsen Chung + +Cherry-pick r256571. rdar://problem/59443242 + +REGRESSION (r255961): Default state for data URL handling is incorrect +https://bugs.webkit.org/show_bug.cgi?id=207719 + + +Reviewed by Chris Dumez. + +The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in +while we work through compatibility issues. + +Source/WebCore: + +Tested by existing test cases. + +* page/Settings.yaml: + +Source/WebKit: + +* UIProcess/API/Cocoa/WKWebViewConfiguration.mm: +(-[WKWebViewConfiguration init]): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256571 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-13 Brent Fulgham + +REGRESSION (r255961): Default state for data URL handling is incorrect +https://bugs.webkit.org/show_bug.cgi?id=207719 + + +Reviewed by Chris Dumez. + +The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in +while we work through compatibility issues. + +* UIProcess/API/Cocoa/WKWebViewConfiguration.mm: +(-[WKWebViewConfiguration init]): + 2020-02-13 Alan Coon Cherry-pick r256493. rdar://problem/59412867 Modified:
[webkit-changes] [256575] trunk/LayoutTests
Title: [256575] trunk/LayoutTests Revision 256575 Author lawrenc...@apple.com Date 2020-02-13 17:13:36 -0800 (Thu, 13 Feb 2020) Log Message [ Mac wk2 ] fast/scrolling/latching/iframe_in_iframe.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207732 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256574 => 256575) --- trunk/LayoutTests/ChangeLog 2020-02-14 00:36:09 UTC (rev 256574) +++ trunk/LayoutTests/ChangeLog 2020-02-14 01:13:36 UTC (rev 256575) @@ -1,5 +1,14 @@ 2020-02-13 Jason Lawrence +[ Mac wk2 ] fast/scrolling/latching/iframe_in_iframe.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=207732 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +2020-02-13 Jason Lawrence + [ Mac Release wk2 ] accessibility/press-targets-center-point.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207728 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256574 => 256575) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-14 00:36:09 UTC (rev 256574) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-14 01:13:36 UTC (rev 256575) @@ -1030,4 +1030,6 @@ webkit.org/b/207700 webgpu/whlsl/return-local-variable.html [ Pass Failure ] -webkit.org/b/207728 [ Release ] accessibility/press-targets-center-point.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207728 [ Release ] accessibility/press-targets-center-point.html [ Pass Failure ] + +webkit.org/b/207732 fast/scrolling/latching/iframe_in_iframe.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256574] branches/safari-609-branch/Source
Title: [256574] branches/safari-609-branch/Source
Revision 256574
Author repst...@apple.com
Date 2020-02-13 16:36:09 -0800 (Thu, 13 Feb 2020)
Log Message
Revert r256407. rdar://problem/59299143
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/PAL/ChangeLog
branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.cpp
branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h
branches/safari-609-branch/Source/WebCore/platform/PlatformScreen.h
branches/safari-609-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp
branches/safari-609-branch/Source/WebKit/WebProcess/WebProcess.cpp
branches/safari-609-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (256573 => 256574)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-14 00:35:50 UTC (rev 256573)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-14 00:36:09 UTC (rev 256574)
@@ -1,3 +1,7 @@
+2020-02-13 Russell Epstein
+
+Revert r256407. rdar://problem/59299143
+
2020-02-13 Alan Coon
Cherry-pick r256564. rdar://problem/59440718
Modified: branches/safari-609-branch/Source/WebCore/PAL/ChangeLog (256573 => 256574)
--- branches/safari-609-branch/Source/WebCore/PAL/ChangeLog 2020-02-14 00:35:50 UTC (rev 256573)
+++ branches/safari-609-branch/Source/WebCore/PAL/ChangeLog 2020-02-14 00:36:09 UTC (rev 256574)
@@ -1,3 +1,7 @@
+2020-02-13 Russell Epstein
+
+Revert r256407. rdar://problem/59299143
+
2020-02-11 Alan Coon
Cherry-pick r255881. rdar://problem/59299143
Modified: branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.cpp (256573 => 256574)
--- branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.cpp 2020-02-14 00:35:50 UTC (rev 256573)
+++ branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.cpp 2020-02-14 00:36:09 UTC (rev 256574)
@@ -33,6 +33,5 @@
SOFT_LINK_FRAMEWORK_FOR_SOURCE_WITH_EXPORT(PAL, MediaToolbox, PAL_EXPORT)
SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE_WITH_EXPORT(PAL, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList), PAL_EXPORT)
-SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE_WITH_EXPORT(PAL, MediaToolbox, MTOverrideShouldPlayHDRVideo, void, (Boolean override, Boolean playHDRVideo), (override, playHDRVideo), PAL_EXPORT)
#endif
Modified: branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h (256573 => 256574)
--- branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h 2020-02-14 00:35:50 UTC (rev 256573)
+++ branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h 2020-02-14 00:36:09 UTC (rev 256574)
@@ -33,6 +33,5 @@
SOFT_LINK_FRAMEWORK_FOR_HEADER(PAL, MediaToolbox)
SOFT_LINK_FUNCTION_MAY_FAIL_FOR_HEADER(PAL, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList))
-SOFT_LINK_FUNCTION_MAY_FAIL_FOR_HEADER(PAL, MediaToolbox, MTOverrideShouldPlayHDRVideo, void, (Boolean override, Boolean playHDRVideo), (override, playHDRVideo))
#endif
Modified: branches/safari-609-branch/Source/WebCore/platform/PlatformScreen.h (256573 => 256574)
--- branches/safari-609-branch/Source/WebCore/platform/PlatformScreen.h 2020-02-14 00:35:50 UTC (rev 256573)
+++ branches/safari-609-branch/Source/WebCore/platform/PlatformScreen.h 2020-02-14 00:36:09 UTC (rev 256574)
@@ -76,7 +76,7 @@
WEBCORE_EXPORT bool screenSupportsExtendedColor(Widget* = nullptr);
#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
-WEBCORE_EXPORT bool screenSupportsHighDynamicRange(Widget* = nullptr);
+bool screenSupportsHighDynamicRange(Widget* = nullptr);
#else
constexpr bool screenSupportsHighDynamicRange(Widget* = nullptr) { return false; }
#endif
@@ -105,8 +105,6 @@
WEBCORE_EXPORT ScreenProperties collectScreenProperties();
WEBCORE_EXPORT void setScreenProperties(const ScreenProperties&);
-WEBCORE_EXPORT void setShouldOverrideScreenSupportsHighDynamicRange(bool shouldOverride, bool supportsHighDynamicRange);
-
WEBCORE_EXPORT PlatformDisplayID primaryScreenDisplayID();
uint32_t primaryOpenGLDisplayMask();
Modified: branches/safari-609-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm (256573 => 256574)
--- branches/safari-609-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-02-14 00:35:50 UTC (rev 256573)
+++ branches/safari-609-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-02-14 00:36:09 UTC (rev 256574)
@@ -156,12 +156,6 @@
screenProperties() = properties;
}
-void setShouldOverrideScreenSupportsHighDynamicRange(bool shouldOverride, bool supportsHighDynamicRange)
-{
-if
[webkit-changes] [256573] trunk/LayoutTests
Title: [256573] trunk/LayoutTests Revision 256573 Author lawrenc...@apple.com Date 2020-02-13 16:35:50 -0800 (Thu, 13 Feb 2020) Log Message [ Mac Release wk2 ] accessibility/press-targets-center-point.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207728 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256572 => 256573) --- trunk/LayoutTests/ChangeLog 2020-02-14 00:35:02 UTC (rev 256572) +++ trunk/LayoutTests/ChangeLog 2020-02-14 00:35:50 UTC (rev 256573) @@ -1,5 +1,14 @@ 2020-02-13 Jason Lawrence +[ Mac Release wk2 ] accessibility/press-targets-center-point.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=207728 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +2020-02-13 Jason Lawrence + [ Mac ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207726 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256572 => 256573) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-14 00:35:02 UTC (rev 256572) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-14 00:35:50 UTC (rev 256573) @@ -1028,4 +1028,6 @@ webkit.org/b/206852 inspector/canvas/updateShader-webgpu-sharedVertexFragment.html [ Pass Failure ] -webkit.org/b/207700 webgpu/whlsl/return-local-variable.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207700 webgpu/whlsl/return-local-variable.html [ Pass Failure ] + +webkit.org/b/207728 [ Release ] accessibility/press-targets-center-point.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256572] branches/safari-609.1.17.0-branch/Source/WebCore/rendering/ InlineTextBox.cpp
Title: [256572] branches/safari-609.1.17.0-branch/Source/WebCore/rendering/InlineTextBox.cpp Revision 256572 Author alanc...@apple.com Date 2020-02-13 16:35:02 -0800 (Thu, 13 Feb 2020) Log Message Unreviewed build fix. rdar://problem/59430261 Modified Paths branches/safari-609.1.17.0-branch/Source/WebCore/rendering/InlineTextBox.cpp Diff Modified: branches/safari-609.1.17.0-branch/Source/WebCore/rendering/InlineTextBox.cpp (256571 => 256572) --- branches/safari-609.1.17.0-branch/Source/WebCore/rendering/InlineTextBox.cpp 2020-02-14 00:12:06 UTC (rev 256571) +++ branches/safari-609.1.17.0-branch/Source/WebCore/rendering/InlineTextBox.cpp 2020-02-14 00:35:02 UTC (rev 256572) @@ -32,6 +32,7 @@ #include "ElementRuleCollector.h" #include "EllipsisBox.h" #include "EventRegion.h" +#include "FloatRoundedRect.h" #include "Frame.h" #include "GraphicsContext.h" #include "HighlightMap.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256571] trunk/Source
Title: [256571] trunk/Source Revision 256571 Author bfulg...@apple.com Date 2020-02-13 16:12:06 -0800 (Thu, 13 Feb 2020) Log Message REGRESSION (r255961): Default state for data URL handling is incorrect https://bugs.webkit.org/show_bug.cgi?id=207719 Reviewed by Chris Dumez. The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in while we work through compatibility issues. Source/WebCore: Tested by existing test cases. * page/Settings.yaml: Source/WebKit: * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Settings.yaml trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm Diff Modified: trunk/Source/WebCore/ChangeLog (256570 => 256571) --- trunk/Source/WebCore/ChangeLog 2020-02-14 00:00:09 UTC (rev 256570) +++ trunk/Source/WebCore/ChangeLog 2020-02-14 00:12:06 UTC (rev 256571) @@ -1,3 +1,18 @@ +2020-02-13 Brent Fulgham + +REGRESSION (r255961): Default state for data URL handling is incorrect +https://bugs.webkit.org/show_bug.cgi?id=207719 + + +Reviewed by Chris Dumez. + +The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in +while we work through compatibility issues. + +Tested by existing test cases. + +* page/Settings.yaml: + 2020-02-13 Keith Rollin Add missing call to completionHandler Modified: trunk/Source/WebCore/page/Settings.yaml (256570 => 256571) --- trunk/Source/WebCore/page/Settings.yaml 2020-02-14 00:00:09 UTC (rev 256570) +++ trunk/Source/WebCore/page/Settings.yaml 2020-02-14 00:12:06 UTC (rev 256571) @@ -108,7 +108,7 @@ allowCrossOriginSubresourcesToAskForCredentials: initial: false allowTopNavigationToDataURLs: - initial: false + initial: true needsStorageAccessFromFileURLsQuirk: initial: true needsFrameNameFallbackToIdQuirk: Modified: trunk/Source/WebKit/ChangeLog (256570 => 256571) --- trunk/Source/WebKit/ChangeLog 2020-02-14 00:00:09 UTC (rev 256570) +++ trunk/Source/WebKit/ChangeLog 2020-02-14 00:12:06 UTC (rev 256571) @@ -1,3 +1,17 @@ +2020-02-13 Brent Fulgham + +REGRESSION (r255961): Default state for data URL handling is incorrect +https://bugs.webkit.org/show_bug.cgi?id=207719 + + +Reviewed by Chris Dumez. + +The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in +while we work through compatibility issues. + +* UIProcess/API/Cocoa/WKWebViewConfiguration.mm: +(-[WKWebViewConfiguration init]): + 2020-02-13 Commit Queue Unreviewed, rolling out r254557. Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (256570 => 256571) --- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2020-02-14 00:00:09 UTC (rev 256570) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2020-02-14 00:12:06 UTC (rev 256571) @@ -236,7 +236,7 @@ _convertsPositionStyleOnCopy = NO; _allowsMetaRefresh = YES; _allowUniversalAccessFromFileURLs = NO; -_allowTopNavigationToDataURLs = NO; +_allowTopNavigationToDataURLs = YES; _needsStorageAccessFromFileURLsQuirk = YES; #if PLATFORM(IOS_FAMILY) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256570] branches/safari-609-branch/Source/WebCore/rendering/ InlineTextBox.cpp
Title: [256570] branches/safari-609-branch/Source/WebCore/rendering/InlineTextBox.cpp Revision 256570 Author repst...@apple.com Date 2020-02-13 16:00:09 -0800 (Thu, 13 Feb 2020) Log Message Unreviewed Build Fix, rdar://problem/59430261 Modified Paths branches/safari-609-branch/Source/WebCore/rendering/InlineTextBox.cpp Diff Modified: branches/safari-609-branch/Source/WebCore/rendering/InlineTextBox.cpp (256569 => 256570) --- branches/safari-609-branch/Source/WebCore/rendering/InlineTextBox.cpp 2020-02-13 23:53:37 UTC (rev 256569) +++ branches/safari-609-branch/Source/WebCore/rendering/InlineTextBox.cpp 2020-02-14 00:00:09 UTC (rev 256570) @@ -32,6 +32,7 @@ #include "ElementRuleCollector.h" #include "EllipsisBox.h" #include "EventRegion.h" +#include "FloatRoundedRect.h" #include "Frame.h" #include "GraphicsContext.h" #include "HighlightMap.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256569] trunk/Source/WebCore
Title: [256569] trunk/Source/WebCore
Revision 256569
Author krol...@apple.com
Date 2020-02-13 15:53:37 -0800 (Thu, 13 Feb 2020)
Log Message
Add missing call to completionHandler
https://bugs.webkit.org/show_bug.cgi?id=207720
Reviewed by Chris Dumez.
Bug 179641 (r225702) updated
SubresourceLoader::willSendRequestInternal with a return call without
first calling the completionHandler. Address this by adding the call
to the completionHandler.
No new tests -- it's not possible to control execution into the
affected code path.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (256568 => 256569)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 23:51:25 UTC (rev 256568)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 23:53:37 UTC (rev 256569)
@@ -1,3 +1,22 @@
+2020-02-13 Keith Rollin
+
+Add missing call to completionHandler
+https://bugs.webkit.org/show_bug.cgi?id=207720
+
+
+Reviewed by Chris Dumez.
+
+Bug 179641 (r225702) updated
+SubresourceLoader::willSendRequestInternal with a return call without
+first calling the completionHandler. Address this by adding the call
+to the completionHandler.
+
+No new tests -- it's not possible to control execution into the
+affected code path.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::willSendRequestInternal):
+
2020-02-13 Tim Horton
iOS: Autoscrolling is too fast and way too aggressive
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (256568 => 256569)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2020-02-13 23:51:25 UTC (rev 256568)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2020-02-13 23:53:37 UTC (rev 256569)
@@ -239,7 +239,7 @@
m_resource->responseReceived(opaqueRedirectedResponse);
if (reachedTerminalState()) {
RELEASE_LOG_IF_ALLOWED("willSendRequestinternal: reached terminal state (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());
-return;
+return completionHandler(WTFMove(newRequest));
}
RELEASE_LOG_IF_ALLOWED("willSendRequestinternal: resource load completed (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256568] branches/safari-609-branch/Source/WebCore
Title: [256568] branches/safari-609-branch/Source/WebCore Revision 256568 Author alanc...@apple.com Date 2020-02-13 15:51:25 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256564. rdar://problem/59440718 iOS: Autoscrolling is too fast and way too aggressive https://bugs.webkit.org/show_bug.cgi?id=207717 Reviewed by Simon Fraser. * page/EventHandler.h: * page/ios/EventHandlerIOS.mm: (WebCore::EventHandler::startSelectionAutoscroll): (WebCore::EventHandler::cancelSelectionAutoscroll): (WebCore::adjustAutoscrollDestinationForInsetEdges): (WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const): (WebCore::autoscrollAdjustmentFactorForScreenBoundaries): Deleted. Make a few small changes to autoscrolling on iOS to make it feel better: - Store the autoscrolling position in "unscrolled" coordinates, and do all work in this space, converting back when it's time to actually scroll. This fixes the problem where you have to wiggle your finger to autoscroll, because now when the timer fires, the point actually moves (before, it was all stored in "content" coordinates, so wouldn't actually change until the client pushed a new point). - Reintroduce the macOS-style linear scaling of scrolling velocity in (and beyond) the inset region. We scale the fractional distance into the inset region to a 20pt/50ms scroll velocity; when you exit the inset it continues scaling up linearly from there. - Only apply insets in the direction that the autoscroll drag is occurring in. This avoids a problem where e.g. horizontally selecting text on the first visible line of a page would cause us to scroll up, as it sat within the top inset. Instead, we only apply an inset in the direction of the drag, and do not allow its magnitude to exceed the currently dragged distance. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256564 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/page/EventHandler.h branches/safari-609-branch/Source/WebCore/page/ios/EventHandlerIOS.mm Diff Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (256567 => 256568) --- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-13 23:44:20 UTC (rev 256567) +++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-13 23:51:25 UTC (rev 256568) @@ -1,3 +1,80 @@ +2020-02-13 Alan Coon + +Cherry-pick r256564. rdar://problem/59440718 + +iOS: Autoscrolling is too fast and way too aggressive +https://bugs.webkit.org/show_bug.cgi?id=207717 + + +Reviewed by Simon Fraser. + +* page/EventHandler.h: +* page/ios/EventHandlerIOS.mm: +(WebCore::EventHandler::startSelectionAutoscroll): +(WebCore::EventHandler::cancelSelectionAutoscroll): +(WebCore::adjustAutoscrollDestinationForInsetEdges): +(WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const): +(WebCore::autoscrollAdjustmentFactorForScreenBoundaries): Deleted. +Make a few small changes to autoscrolling on iOS to make it feel better: + +- Store the autoscrolling position in "unscrolled" coordinates, and do +all work in this space, converting back when it's time to actually scroll. +This fixes the problem where you have to wiggle your finger to autoscroll, +because now when the timer fires, the point actually moves (before, it was +all stored in "content" coordinates, so wouldn't actually change until +the client pushed a new point). + +- Reintroduce the macOS-style linear scaling of scrolling velocity +in (and beyond) the inset region. We scale the fractional distance into +the inset region to a 20pt/50ms scroll velocity; when you exit the inset +it continues scaling up linearly from there. + +- Only apply insets in the direction that the autoscroll drag is occurring +in. This avoids a problem where e.g. horizontally selecting text on the +first visible line of a page would cause us to scroll up, as it sat +within the top inset. Instead, we only apply an inset in the direction of +the drag, and do not allow its magnitude to exceed the currently dragged +distance. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256564 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-13 Tim Horton + +iOS: Autoscrolling is too fast and way too aggressive +https://bugs.webkit.org/show_bug.cgi?id=207717 + + +Reviewed by Simon Fraser. + +* page/EventHandler.h: +* page/ios/EventHandlerIOS.mm: +(WebCore::EventHandler::startSelectionAutoscroll): +(WebCore::EventHandler::cancelSelectionAutoscroll): +(WebCore::adjustAutoscrollDestinationForInsetEdges): +
[webkit-changes] [256567] branches/safari-609.1.17.0-branch/Source/WebCore
Title: [256567] branches/safari-609.1.17.0-branch/Source/WebCore Revision 256567 Author alanc...@apple.com Date 2020-02-13 15:44:20 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256564. rdar://problem/59440718 iOS: Autoscrolling is too fast and way too aggressive https://bugs.webkit.org/show_bug.cgi?id=207717 Reviewed by Simon Fraser. * page/EventHandler.h: * page/ios/EventHandlerIOS.mm: (WebCore::EventHandler::startSelectionAutoscroll): (WebCore::EventHandler::cancelSelectionAutoscroll): (WebCore::adjustAutoscrollDestinationForInsetEdges): (WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const): (WebCore::autoscrollAdjustmentFactorForScreenBoundaries): Deleted. Make a few small changes to autoscrolling on iOS to make it feel better: - Store the autoscrolling position in "unscrolled" coordinates, and do all work in this space, converting back when it's time to actually scroll. This fixes the problem where you have to wiggle your finger to autoscroll, because now when the timer fires, the point actually moves (before, it was all stored in "content" coordinates, so wouldn't actually change until the client pushed a new point). - Reintroduce the macOS-style linear scaling of scrolling velocity in (and beyond) the inset region. We scale the fractional distance into the inset region to a 20pt/50ms scroll velocity; when you exit the inset it continues scaling up linearly from there. - Only apply insets in the direction that the autoscroll drag is occurring in. This avoids a problem where e.g. horizontally selecting text on the first visible line of a page would cause us to scroll up, as it sat within the top inset. Instead, we only apply an inset in the direction of the drag, and do not allow its magnitude to exceed the currently dragged distance. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256564 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.17.0-branch/Source/WebCore/page/EventHandler.h branches/safari-609.1.17.0-branch/Source/WebCore/page/ios/EventHandlerIOS.mm Diff Modified: branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog (256566 => 256567) --- branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog 2020-02-13 23:40:01 UTC (rev 256566) +++ branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog 2020-02-13 23:44:20 UTC (rev 256567) @@ -1,5 +1,82 @@ 2020-02-13 Russell Epstein +Cherry-pick r256564. rdar://problem/59440718 + +iOS: Autoscrolling is too fast and way too aggressive +https://bugs.webkit.org/show_bug.cgi?id=207717 + + +Reviewed by Simon Fraser. + +* page/EventHandler.h: +* page/ios/EventHandlerIOS.mm: +(WebCore::EventHandler::startSelectionAutoscroll): +(WebCore::EventHandler::cancelSelectionAutoscroll): +(WebCore::adjustAutoscrollDestinationForInsetEdges): +(WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const): +(WebCore::autoscrollAdjustmentFactorForScreenBoundaries): Deleted. +Make a few small changes to autoscrolling on iOS to make it feel better: + +- Store the autoscrolling position in "unscrolled" coordinates, and do +all work in this space, converting back when it's time to actually scroll. +This fixes the problem where you have to wiggle your finger to autoscroll, +because now when the timer fires, the point actually moves (before, it was +all stored in "content" coordinates, so wouldn't actually change until +the client pushed a new point). + +- Reintroduce the macOS-style linear scaling of scrolling velocity +in (and beyond) the inset region. We scale the fractional distance into +the inset region to a 20pt/50ms scroll velocity; when you exit the inset +it continues scaling up linearly from there. + +- Only apply insets in the direction that the autoscroll drag is occurring +in. This avoids a problem where e.g. horizontally selecting text on the +first visible line of a page would cause us to scroll up, as it sat +within the top inset. Instead, we only apply an inset in the direction of +the drag, and do not allow its magnitude to exceed the currently dragged +distance. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256564 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-13 Tim Horton + +iOS: Autoscrolling is too fast and way too aggressive +https://bugs.webkit.org/show_bug.cgi?id=207717 + + +Reviewed by Simon Fraser. + +* page/EventHandler.h: +* page/ios/EventHandlerIOS.mm: +(WebCore::EventHandler::startSelectionAutoscroll): +(WebCore::EventHandler::cancelSelectionAutoscroll): +
[webkit-changes] [256566] trunk/LayoutTests
Title: [256566] trunk/LayoutTests Revision 256566 Author lawrenc...@apple.com Date 2020-02-13 15:40:01 -0800 (Thu, 13 Feb 2020) Log Message [ Mac ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207726 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256565 => 256566) --- trunk/LayoutTests/ChangeLog 2020-02-13 23:35:11 UTC (rev 256565) +++ trunk/LayoutTests/ChangeLog 2020-02-13 23:40:01 UTC (rev 256566) @@ -1,5 +1,14 @@ 2020-02-13 Jason Lawrence +[ Mac ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=207726 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2020-02-13 Jason Lawrence + [ Mac Debug ] http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207723 Modified: trunk/LayoutTests/platform/mac/TestExpectations (256565 => 256566) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 23:35:11 UTC (rev 256565) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 23:40:01 UTC (rev 256566) @@ -2020,4 +2020,6 @@ webkit.org/b/207718 fast/images/webp-as-image.html [ Pass ImageOnlyFailure ] -webkit.org/b/207723 http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207723 http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html [ Pass Failure ] + +webkit.org/b/207726 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256565] branches/safari-609-branch/Tools
Title: [256565] branches/safari-609-branch/Tools Revision 256565 Author ryanhad...@apple.com Date 2020-02-13 15:35:11 -0800 (Thu, 13 Feb 2020) Log Message Unreviewed attempt to fix the TestWebKitAPI build. * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm: Modified Paths branches/safari-609-branch/Tools/ChangeLog branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm Diff Modified: branches/safari-609-branch/Tools/ChangeLog (256564 => 256565) --- branches/safari-609-branch/Tools/ChangeLog 2020-02-13 23:23:04 UTC (rev 256564) +++ branches/safari-609-branch/Tools/ChangeLog 2020-02-13 23:35:11 UTC (rev 256565) @@ -1,3 +1,9 @@ +2020-02-13 Ryan Haddad + +Unreviewed attempt to fix the TestWebKitAPI build. + +* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm: + 2020-02-13 Russell Epstein Cherry-pick r256520. rdar://problem/59430255 Modified: branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm (256564 => 256565) --- branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm 2020-02-13 23:23:04 UTC (rev 256564) +++ branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm 2020-02-13 23:35:11 UTC (rev 256565) @@ -30,7 +30,7 @@ #import "TCPServer.h" #import "Test.h" #import "TestNavigationDelegate.h" -#import +#import "TestWKWebView.h" #import #import ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256564] trunk/Source/WebCore
Title: [256564] trunk/Source/WebCore
Revision 256564
Author timothy_hor...@apple.com
Date 2020-02-13 15:23:04 -0800 (Thu, 13 Feb 2020)
Log Message
iOS: Autoscrolling is too fast and way too aggressive
https://bugs.webkit.org/show_bug.cgi?id=207717
Reviewed by Simon Fraser.
* page/EventHandler.h:
* page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::startSelectionAutoscroll):
(WebCore::EventHandler::cancelSelectionAutoscroll):
(WebCore::adjustAutoscrollDestinationForInsetEdges):
(WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const):
(WebCore::autoscrollAdjustmentFactorForScreenBoundaries): Deleted.
Make a few small changes to autoscrolling on iOS to make it feel better:
- Store the autoscrolling position in "unscrolled" coordinates, and do
all work in this space, converting back when it's time to actually scroll.
This fixes the problem where you have to wiggle your finger to autoscroll,
because now when the timer fires, the point actually moves (before, it was
all stored in "content" coordinates, so wouldn't actually change until
the client pushed a new point).
- Reintroduce the macOS-style linear scaling of scrolling velocity
in (and beyond) the inset region. We scale the fractional distance into
the inset region to a 20pt/50ms scroll velocity; when you exit the inset
it continues scaling up linearly from there.
- Only apply insets in the direction that the autoscroll drag is occurring
in. This avoids a problem where e.g. horizontally selecting text on the
first visible line of a page would cause us to scroll up, as it sat
within the top inset. Instead, we only apply an inset in the direction of
the drag, and do not allow its magnitude to exceed the currently dragged
distance.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/page/ios/EventHandlerIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (256563 => 256564)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 23:21:13 UTC (rev 256563)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 23:23:04 UTC (rev 256564)
@@ -1,3 +1,39 @@
+2020-02-13 Tim Horton
+
+iOS: Autoscrolling is too fast and way too aggressive
+https://bugs.webkit.org/show_bug.cgi?id=207717
+
+
+Reviewed by Simon Fraser.
+
+* page/EventHandler.h:
+* page/ios/EventHandlerIOS.mm:
+(WebCore::EventHandler::startSelectionAutoscroll):
+(WebCore::EventHandler::cancelSelectionAutoscroll):
+(WebCore::adjustAutoscrollDestinationForInsetEdges):
+(WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const):
+(WebCore::autoscrollAdjustmentFactorForScreenBoundaries): Deleted.
+Make a few small changes to autoscrolling on iOS to make it feel better:
+
+- Store the autoscrolling position in "unscrolled" coordinates, and do
+all work in this space, converting back when it's time to actually scroll.
+This fixes the problem where you have to wiggle your finger to autoscroll,
+because now when the timer fires, the point actually moves (before, it was
+all stored in "content" coordinates, so wouldn't actually change until
+the client pushed a new point).
+
+- Reintroduce the macOS-style linear scaling of scrolling velocity
+in (and beyond) the inset region. We scale the fractional distance into
+the inset region to a 20pt/50ms scroll velocity; when you exit the inset
+it continues scaling up linearly from there.
+
+- Only apply insets in the direction that the autoscroll drag is occurring
+in. This avoids a problem where e.g. horizontally selecting text on the
+first visible line of a page would cause us to scroll up, as it sat
+within the top inset. Instead, we only apply an inset in the direction of
+the drag, and do not allow its magnitude to exceed the currently dragged
+distance.
+
2020-02-13 Commit Queue
Unreviewed, rolling out r254557.
Modified: trunk/Source/WebCore/page/EventHandler.h (256563 => 256564)
--- trunk/Source/WebCore/page/EventHandler.h 2020-02-13 23:21:13 UTC (rev 256563)
+++ trunk/Source/WebCore/page/EventHandler.h 2020-02-13 23:23:04 UTC (rev 256564)
@@ -626,8 +626,9 @@
#if PLATFORM(IOS_FAMILY)
bool m_shouldAllowMouseDownToStartDrag { false };
-IntPoint m_targetAutoscrollPositionInWindow;
bool m_isAutoscrolling { false };
+IntPoint m_targetAutoscrollPositionInUnscrolledRootViewCoordinates;
+Optional m_initialTargetAutoscrollPositionInUnscrolledRootViewCoordinates;
#endif
#if ENABLE(CURSOR_VISIBILITY)
Modified: trunk/Source/WebCore/page/ios/EventHandlerIOS.mm (256563 => 256564)
--- trunk/Source/WebCore/page/ios/EventHandlerIOS.mm 2020-02-13 23:21:13 UTC (rev 256563)
+++ trunk/Source/WebCore/page/ios/EventHandlerIOS.mm 2020-02-13 23:23:04 UTC (rev 256564)
@@ -585,8 +585,11 @@
{
Ref
[webkit-changes] [256563] trunk/Source
Title: [256563] trunk/Source
Revision 256563
Author commit-qu...@webkit.org
Date 2020-02-13 15:21:13 -0800 (Thu, 13 Feb 2020)
Log Message
Unreviewed, rolling out r254557.
https://bugs.webkit.org/show_bug.cgi?id=207725
The assert is correct, but unfortunately it will alwasy fail
since there is an existing bug in
HTMLTextFormControlElement::indexForPosition(). See bug
#207724 for more details. (Requested by dydz on #webkit).
Reverted changeset:
"Enable the offset assertion in
HTMLTextFormControlElement::indexForPosition"
https://bugs.webkit.org/show_bug.cgi?id=205706
https://trac.webkit.org/changeset/254557
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp
trunk/Source/WebCore/editing/CompositeEditCommand.cpp
trunk/Source/WebCore/editing/Editing.cpp
trunk/Source/WebCore/editing/Editing.h
trunk/Source/WebCore/editing/TextIterator.cpp
trunk/Source/WebCore/editing/TextIterator.h
trunk/Source/WebCore/editing/TextIteratorBehavior.h
trunk/Source/WebCore/editing/ios/DictationCommandIOS.cpp
trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (256562 => 256563)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 23:10:46 UTC (rev 256562)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 23:21:13 UTC (rev 256563)
@@ -1,3 +1,20 @@
+2020-02-13 Commit Queue
+
+Unreviewed, rolling out r254557.
+https://bugs.webkit.org/show_bug.cgi?id=207725
+
+The assert is correct, but unfortunately it will alwasy fail
+since there is an existing bug in
+HTMLTextFormControlElement::indexForPosition(). See bug
+#207724 for more details. (Requested by dydz on #webkit).
+
+Reverted changeset:
+
+"Enable the offset assertion in
+HTMLTextFormControlElement::indexForPosition"
+https://bugs.webkit.org/show_bug.cgi?id=205706
+https://trac.webkit.org/changeset/254557
+
2020-02-13 Eric Carlson
Rename SerializedPlatformRepresentation to SerializedPlatformDataCue
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (256562 => 256563)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2020-02-13 23:10:46 UTC (rev 256562)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2020-02-13 23:21:13 UTC (rev 256563)
@@ -1937,7 +1937,7 @@
return nullptr;
auto range = Range::create(m_document, startPosition, originalRange->startPosition());
-unsigned targetOffset = TextIterator::rangeLength(range.ptr(), { TextIteratorLengthOption::GenerateSpacesForReplacedElements });
+unsigned targetOffset = TextIterator::rangeLength(range.ptr(), true);
return findClosestPlainText(searchRange.get(), matchText, { }, targetOffset);
}
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (256562 => 256563)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2020-02-13 23:10:46 UTC (rev 256562)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2020-02-13 23:21:13 UTC (rev 256563)
@@ -2032,10 +2032,12 @@
#if USE(ATK)
// We need to consider replaced elements for GTK, as they will be
// presented with the 'object replacement character' (0xFFFC).
-return WebCore::indexForVisiblePosition(*node, position, { TextIteratorLengthOption::GenerateSpacesForReplacedElements });
+bool forSelectionPreservation = true;
#else
-return WebCore::indexForVisiblePosition(*node, position);
+bool forSelectionPreservation = false;
#endif
+
+return WebCore::indexForVisiblePosition(*node, position, forSelectionPreservation);
}
Element* AccessibilityRenderObject::rootEditableElementForPosition(const Position& position) const
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp (256562 => 256563)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp 2020-02-13 23:10:46 UTC (rev 256562)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp 2020-02-13 23:21:13 UTC (rev 256563)
@@ -154,7 +154,7 @@
static gint rangeLengthForObject(AccessibilityObject& obj, Range* range)
{
// This is going to be the actual length in most of the cases
-int baseLength = TextIterator::rangeLength(range, { TextIteratorLengthOption::GenerateSpacesForReplacedElements });
+int baseLength = TextIterator::rangeLength(range, true);
// Check whether the current hyperlink belongs to a list item.
// If so, we need to consider the length of
[webkit-changes] [256562] trunk
Title: [256562] trunk
Revision 256562
Author achristen...@apple.com
Date 2020-02-13 15:10:46 -0800 (Thu, 13 Feb 2020)
Log Message
_WKResourceLoadInfo should conform to NSSecureCoding
https://bugs.webkit.org/show_bug.cgi?id=207667
Reviewed by Brady Eidson.
Source/WebKit:
This makes rdar://problem/57132290 nicer.
Covered by API tests.
* UIProcess/API/Cocoa/_WKResourceLoadInfo.h:
* UIProcess/API/Cocoa/_WKResourceLoadInfo.mm:
(+[_WKResourceLoadInfo supportsSecureCoding]):
(-[_WKResourceLoadInfo initWithCoder:]):
(-[_WKResourceLoadInfo encodeWithCoder:]):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIResourceLoadInfo.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (256561 => 256562)
--- trunk/Source/WebKit/ChangeLog 2020-02-13 23:08:15 UTC (rev 256561)
+++ trunk/Source/WebKit/ChangeLog 2020-02-13 23:10:46 UTC (rev 256562)
@@ -1,5 +1,21 @@
2020-02-13 Alex Christensen
+_WKResourceLoadInfo should conform to NSSecureCoding
+https://bugs.webkit.org/show_bug.cgi?id=207667
+
+Reviewed by Brady Eidson.
+
+This makes rdar://problem/57132290 nicer.
+Covered by API tests.
+
+* UIProcess/API/Cocoa/_WKResourceLoadInfo.h:
+* UIProcess/API/Cocoa/_WKResourceLoadInfo.mm:
+(+[_WKResourceLoadInfo supportsSecureCoding]):
+(-[_WKResourceLoadInfo initWithCoder:]):
+(-[_WKResourceLoadInfo encodeWithCoder:]):
+
+2020-02-13 Alex Christensen
+
Deprecate _WKUserContentWorld replaced by WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=207514
Modified: trunk/Source/WebKit/UIProcess/API/APIResourceLoadInfo.h (256561 => 256562)
--- trunk/Source/WebKit/UIProcess/API/APIResourceLoadInfo.h 2020-02-13 23:08:15 UTC (rev 256561)
+++ trunk/Source/WebKit/UIProcess/API/APIResourceLoadInfo.h 2020-02-13 23:10:46 UTC (rev 256562)
@@ -37,16 +37,14 @@
return adoptRef(*new ResourceLoadInfo(WTFMove(info)));
}
+explicit ResourceLoadInfo(WebKit::ResourceLoadInfo&& info)
+: m_info(WTFMove(info)) { }
+
WebKit::NetworkResourceLoadIdentifier resourceLoadID() const { return m_info.resourceLoadID; }
Optional frameID() const { return m_info.frameID; }
Optional parentFrameID() const { return m_info.parentFrameID; }
private:
-explicit ResourceLoadInfo(WebKit::ResourceLoadInfo&& info)
-: m_info(WTFMove(info))
-{
-}
-
const WebKit::ResourceLoadInfo m_info;
};
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.h (256561 => 256562)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.h 2020-02-13 23:08:15 UTC (rev 256561)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.h 2020-02-13 23:10:46 UTC (rev 256562)
@@ -30,7 +30,7 @@
NS_ASSUME_NONNULL_BEGIN
WK_CLASS_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA))
-@interface _WKResourceLoadInfo : NSObject
+@interface _WKResourceLoadInfo : NSObject
+ (instancetype)new NS_UNAVAILABLE;
- (instancetype)init NS_UNAVAILABLE;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.mm (256561 => 256562)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.mm 2020-02-13 23:08:15 UTC (rev 256561)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.mm 2020-02-13 23:10:46 UTC (rev 256562)
@@ -28,6 +28,7 @@
#import "APIFrameHandle.h"
#import "APIResourceLoadInfo.h"
+#import "ResourceLoadInfo.h"
#import "_WKFrameHandleInternal.h"
#import "_WKResourceLoadInfoInternal.h"
@@ -63,5 +64,51 @@
return *_info;
}
++ (BOOL)supportsSecureCoding
+{
+return YES;
+}
+
+- (instancetype)initWithCoder:(NSCoder *)coder
+{
+if (!(self = [super init]))
+return nil;
+
+NSNumber *resourceLoadID = [coder decodeObjectOfClass:[NSNumber class] forKey:@"resourceLoadID"];
+if (!resourceLoadID) {
+[self release];
+return nil;
+}
+
+NSNumber *frame = [coder decodeObjectOfClass:[NSNumber class] forKey:@"frame"];
+if (!frame) {
+[self release];
+return nil;
+}
+
+NSNumber *parentFrame = [coder decodeObjectOfClass:[NSNumber class] forKey:@"parentFrame"];
+if (!parentFrame) {
+[self release];
+return nil;
+}
+
+WebKit::ResourceLoadInfo info {
+makeObjectIdentifier(resourceLoadID.unsignedLongLongValue),
+makeObjectIdentifier(frame.unsignedLongLongValue),
+makeObjectIdentifier(parentFrame.unsignedLongLongValue)
+};
+
+API::Object::constructInWrapper(self, WTFMove(info));
+
+return self;
+}
+
+- (void)encodeWithCoder:(NSCoder *)coder
+{
+[coder encodeObject:@(self.resourceLoadID)
[webkit-changes] [256561] trunk/Source/WebKit
Title: [256561] trunk/Source/WebKit
Revision 256561
Author achristen...@apple.com
Date 2020-02-13 15:08:15 -0800 (Thu, 13 Feb 2020)
Log Message
Deprecate _WKUserContentWorld replaced by WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=207514
Reviewed by Brady Eidson.
_WKUserContentWorld.contentWorld is not needed,
but WKContentWorld._userContentWorld needs to return an autoreleased object.
* UIProcess/API/APIContentWorld.cpp:
(API::ContentWorld::fromUserContentWorld): Deleted.
* UIProcess/API/APIContentWorld.h:
* UIProcess/API/Cocoa/WKContentWorld.mm:
(-[WKContentWorld _userContentWorld]):
* UIProcess/API/Cocoa/_WKUserContentWorld.h:
* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
(-[_WKUserContentWorld contentWorld]): Deleted.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp
trunk/Source/WebKit/UIProcess/API/APIContentWorld.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (256560 => 256561)
--- trunk/Source/WebKit/ChangeLog 2020-02-13 23:05:55 UTC (rev 256560)
+++ trunk/Source/WebKit/ChangeLog 2020-02-13 23:08:15 UTC (rev 256561)
@@ -1,3 +1,22 @@
+2020-02-13 Alex Christensen
+
+Deprecate _WKUserContentWorld replaced by WKContentWorld
+https://bugs.webkit.org/show_bug.cgi?id=207514
+
+Reviewed by Brady Eidson.
+
+_WKUserContentWorld.contentWorld is not needed,
+but WKContentWorld._userContentWorld needs to return an autoreleased object.
+
+* UIProcess/API/APIContentWorld.cpp:
+(API::ContentWorld::fromUserContentWorld): Deleted.
+* UIProcess/API/APIContentWorld.h:
+* UIProcess/API/Cocoa/WKContentWorld.mm:
+(-[WKContentWorld _userContentWorld]):
+* UIProcess/API/Cocoa/_WKUserContentWorld.h:
+* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
+(-[_WKUserContentWorld contentWorld]): Deleted.
+
2020-02-13 Per Arne Vollan
[iOS] Check if PIP is supported in the UI process
Modified: trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp (256560 => 256561)
--- trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp 2020-02-13 23:05:55 UTC (rev 256560)
+++ trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp 2020-02-13 23:08:15 UTC (rev 256561)
@@ -76,11 +76,6 @@
return *world.get();
}
-Ref ContentWorld::fromUserContentWorld(const UserContentWorld& userContentWorld)
-{
-return adoptRef(*new ContentWorld(userContentWorld));
-}
-
ContentWorld::ContentWorld(const WTF::String& name)
: ContentWorldBase(name)
{
Modified: trunk/Source/WebKit/UIProcess/API/APIContentWorld.h (256560 => 256561)
--- trunk/Source/WebKit/UIProcess/API/APIContentWorld.h 2020-02-13 23:05:55 UTC (rev 256560)
+++ trunk/Source/WebKit/UIProcess/API/APIContentWorld.h 2020-02-13 23:08:15 UTC (rev 256561)
@@ -61,7 +61,6 @@
static Ref sharedWorldWithName(const WTF::String&);
static ContentWorld& pageContentWorld();
static ContentWorld& defaultClientWorld();
-static Ref fromUserContentWorld(const UserContentWorld&);
virtual ~ContentWorld();
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.mm (256560 => 256561)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.mm 2020-02-13 23:05:55 UTC (rev 256560)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.mm 2020-02-13 23:08:15 UTC (rev 256561)
@@ -74,7 +74,7 @@
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
- (_WKUserContentWorld *)_userContentWorld
{
-return wrapper(API::UserContentWorld::fromContentWorld(*_contentWorld));
+return [[wrapper(API::UserContentWorld::fromContentWorld(*_contentWorld)) retain] autorelease];
}
ALLOW_DEPRECATED_DECLARATIONS_END
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h (256560 => 256561)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h 2020-02-13 23:05:55 UTC (rev 256560)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h 2020-02-13 23:08:15 UTC (rev 256561)
@@ -25,8 +25,6 @@
#import
-@class WKContentWorld;
-
NS_ASSUME_NONNULL_BEGIN
WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKContentWorld", macos(10.12, WK_MAC_TBA), ios(10.0, WK_IOS_TBA))
@@ -37,8 +35,6 @@
@property (nullable, nonatomic, readonly, copy) NSString *name;
-@property (nonatomic, copy, readonly) WKContentWorld *contentWorld WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
-
@end
NS_ASSUME_NONNULL_END
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm (256560 => 256561)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm 2020-02-13 23:05:55 UTC (rev 256560)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm 2020-02-13 23:08:15 UTC (rev 256561)
@@ -26,8 +26,6 @@
#import "config.h"
#import "_WKUserContentWorldInternal.h"
[webkit-changes] [256560] trunk/LayoutTests
Title: [256560] trunk/LayoutTests Revision 256560 Author lawrenc...@apple.com Date 2020-02-13 15:05:55 -0800 (Thu, 13 Feb 2020) Log Message [ Mac Debug ] http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207723 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256559 => 256560) --- trunk/LayoutTests/ChangeLog 2020-02-13 22:58:04 UTC (rev 256559) +++ trunk/LayoutTests/ChangeLog 2020-02-13 23:05:55 UTC (rev 256560) @@ -1,3 +1,12 @@ +2020-02-13 Jason Lawrence + +[ Mac Debug ] http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=207723 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2020-02-13 Youenn Fablet REGRESSION: (256381) [ macOS ] http/tests/workers/service/serviceworkerclients-claim.https.html is flaky failing Modified: trunk/LayoutTests/platform/mac/TestExpectations (256559 => 256560) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 22:58:04 UTC (rev 256559) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 23:05:55 UTC (rev 256560) @@ -2018,4 +2018,6 @@ webkit.org/b/207046 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html [ Pass Failure ] -webkit.org/b/207718 fast/images/webp-as-image.html [ Pass ImageOnlyFailure ] \ No newline at end of file +webkit.org/b/207718 fast/images/webp-as-image.html [ Pass ImageOnlyFailure ] + +webkit.org/b/207723 http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256559] branches/safari-609-branch
Title: [256559] branches/safari-609-branch Revision 256559 Author repst...@apple.com Date 2020-02-13 14:58:04 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256520. rdar://problem/59430255 [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor https://bugs.webkit.org/show_bug.cgi?id=207680 Reviewed by Tim Horton. Source/WebKit: Currently, WebPage::updateSelectionWithExtentPoint consults the value of m_selectionAnchor to determine whether it should attempt to modify the current selection using the hit-tested visible position. m_selectionAnchor is only set under WebPage::beginSelectionInDirection, which is only invoked when the user begins a floating cursor gesture. When attempting to perform an out-of-band selection update (i.e. without calling beginSelectionInDirection beforehand), we will end up consulting an arbitrary value for m_selectionAnchor (::Start by default; otherwise, the last value set by beginSelectionInDirection if it was previously called). This means that the selection can often only be extended in one direction (typically forwards) when an API client attempts to use -updateSelectionWithExtentPoint:completionHandler: to extend the current selection. To fix this, make it so that we only respect the selection anchor (m_selectionAnchor) in the case where the user is currently using the floating cursor; otherwise, allow the SPI to expand the selection, such that it contains the visible position for the given location. Test: UIWKInteractionViewProtocol.UpdateSelectionWithExtentPoint * Platform/spi/ios/UIKitSPI.h: * Scripts/webkit/messages.py: * Shared/ios/GestureTypes.h: Add a new flag to tell the web process whether it should limit selection extent updates to the current selection anchor. Also, remove an existing enum type, SelectionHandlePosition, that is unused (since we no longer support block text selection). * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[UITextInteractionAssistant _wk_hasFloatingCursor]): Add a helper method to determine (using the text interaction assistant) whether there's an active floating cursor gesture. In the case where floating cursor is active, the text interaction assistant will be in an active gesture but its UITextInteraction will not, since the gesture recognizer belongs to the keyboard or input view rather than the first responder (in this case, WKContentView). (-[WKContentView updateSelectionWithExtentPoint:completionHandler:]): Only respect the selection anchor if we're in floating cursor mode; otherwise, allow selection updates with an extent point to extend the current selection to include the new position. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::updateSelectionWithExtentPoint): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Plumb the RespectsSelectionAnchor flag over to the web process. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::updateSelectionWithExtentPoint): Tools: Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind the current selection works. * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: (-[TestWKWebView updateSelectionWithExtentPoint:]): * TestWebKitAPI/ios/UIKitSPI.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256520 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/Platform/spi/ios/UIKitSPI.h branches/safari-609-branch/Source/WebKit/Scripts/webkit/messages.py branches/safari-609-branch/Source/WebKit/Shared/ios/GestureTypes.h branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm branches/safari-609-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/WebPage.messages.in branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm branches/safari-609-branch/Tools/ChangeLog branches/safari-609-branch/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm branches/safari-609-branch/Tools/TestWebKitAPI/ios/UIKitSPI.h Diff Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (256558 => 256559) --- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-13 22:57:59 UTC (rev 256558) +++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-13 22:58:04 UTC (rev 256559) @@ -1,5 +1,131 @@ 2020-02-13 Russell Epstein +Cherry-pick r256520. rdar://problem/59430255 + +[iOS] -updateSelectionWithExtentPoint:completionHandler: should work without
[webkit-changes] [256558] branches/safari-609-branch
Title: [256558] branches/safari-609-branch Revision 256558 Author repst...@apple.com Date 2020-02-13 14:57:59 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256485. rdar://problem/59430261 Composition highlight rects should be rounded and inset https://bugs.webkit.org/show_bug.cgi?id=207655 Reviewed by Tim Horton. Source/WebCore: Apply a couple of minor adjustments to the appearance of composition highlight rects that appear behind marked text, in the case where the client specifies attributed marked text with background colors. Test: editing/input/composition-highlights.html * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintCompositionBackground): In the case where custom composition rects are specified, add a half-pixel inset to all sides of the background rect, and add a slight corner radius around each background rect. * rendering/InlineTextBox.h: Source/WebKit: Stitch adjacent highlight rects together if they have the same highlight color; this minimizes the number of composition highlight rects we hand to the web process when changing the marked text. * UIProcess/ios/WKContentViewInteraction.mm: (compositionHighlights): LayoutTests: Make this existing layout test work with the new composition highlight appearance by covering up the edges of the composition highlight rect with a black border. Due to subpixel insets around the composition highlight rect, the reference image would be offset by a half pixel without this change (even when changing the spans to have a `border-radius`). * editing/input/composition-highlights-expected.html: * editing/input/composition-highlights.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256485 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/editing/input/composition-highlights-expected.html branches/safari-609-branch/LayoutTests/editing/input/composition-highlights.html branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/rendering/InlineTextBox.cpp branches/safari-609-branch/Source/WebCore/rendering/InlineTextBox.h branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256557 => 256558) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-02-13 22:57:54 UTC (rev 256557) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-02-13 22:57:59 UTC (rev 256558) @@ -1,3 +1,65 @@ +2020-02-13 Russell Epstein + +Cherry-pick r256485. rdar://problem/59430261 + +Composition highlight rects should be rounded and inset +https://bugs.webkit.org/show_bug.cgi?id=207655 + + +Reviewed by Tim Horton. + +Source/WebCore: + +Apply a couple of minor adjustments to the appearance of composition highlight rects that appear behind marked +text, in the case where the client specifies attributed marked text with background colors. + +Test: editing/input/composition-highlights.html + +* rendering/InlineTextBox.cpp: +(WebCore::InlineTextBox::paintMarkedTextBackground): +(WebCore::InlineTextBox::paintCompositionBackground): + +In the case where custom composition rects are specified, add a half-pixel inset to all sides of the background +rect, and add a slight corner radius around each background rect. + +* rendering/InlineTextBox.h: + +Source/WebKit: + +Stitch adjacent highlight rects together if they have the same highlight color; this minimizes the number of +composition highlight rects we hand to the web process when changing the marked text. + +* UIProcess/ios/WKContentViewInteraction.mm: +(compositionHighlights): + +LayoutTests: + +Make this existing layout test work with the new composition highlight appearance by covering up the edges of +the composition highlight rect with a black border. Due to subpixel insets around the composition highlight +rect, the reference image would be offset by a half pixel without this change (even when changing the spans to +have a `border-radius`). + +* editing/input/composition-highlights-expected.html: +* editing/input/composition-highlights.html: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256485 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-12 Wenson Hsieh + +Composition highlight rects should be rounded and inset +https://bugs.webkit.org/show_bug.cgi?id=207655 + + +Reviewed by Tim Horton. + +Make this existing layout test work with the new composition highlight appearance by covering up the edges
[webkit-changes] [256557] branches/safari-609-branch/Source/WebKit
Title: [256557] branches/safari-609-branch/Source/WebKit Revision 256557 Author repst...@apple.com Date 2020-02-13 14:57:54 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256433. rdar://problem/59412971 macCatalyst: Unable to grab scrollbar on editable text field https://bugs.webkit.org/show_bug.cgi?id=207615 Reviewed by Tim Horton. In macCatalyst, hovering over the scrollbar (an instance of the internal UIKit class `_UIScrollViewScrollIndicator`) is required in order for a click and drag with the mouse to actually move the scrollbar. This is because UIKit depends on the cursor interaction added to this view to recognize and call its delegate methods. However, we override hit-testing in WebKit to skip over all children of scroll views, and instead force hit- testing to find the scroll view instead. This means that UIKit can never hit-test to the scroll indicator views embedded directly beneath each WKChildScrollView, so the cursor interactions described earlier will not recognize. To work around this, special case these scroll indicator views, such that we will allow -hitTest:withEvent: to find these views. * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: (WebKit::scrollViewScrollIndicatorClass): (-[UIView _web_findDescendantViewAtPoint:withEvent:]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256433 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm Diff Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (256556 => 256557) --- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-13 22:57:49 UTC (rev 256556) +++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-13 22:57:54 UTC (rev 256557) @@ -1,3 +1,54 @@ +2020-02-13 Russell Epstein + +Cherry-pick r256433. rdar://problem/59412971 + +macCatalyst: Unable to grab scrollbar on editable text field +https://bugs.webkit.org/show_bug.cgi?id=207615 + + +Reviewed by Tim Horton. + +In macCatalyst, hovering over the scrollbar (an instance of the internal UIKit class +`_UIScrollViewScrollIndicator`) is required in order for a click and drag with the mouse to actually move the +scrollbar. This is because UIKit depends on the cursor interaction added to this view to recognize and call its +delegate methods. + +However, we override hit-testing in WebKit to skip over all children of scroll views, and instead force hit- +testing to find the scroll view instead. This means that UIKit can never hit-test to the scroll indicator views +embedded directly beneath each WKChildScrollView, so the cursor interactions described earlier will not +recognize. To work around this, special case these scroll indicator views, such that we will allow +-hitTest:withEvent: to find these views. + +* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: +(WebKit::scrollViewScrollIndicatorClass): +(-[UIView _web_findDescendantViewAtPoint:withEvent:]): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256433 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-12 Wenson Hsieh + +macCatalyst: Unable to grab scrollbar on editable text field +https://bugs.webkit.org/show_bug.cgi?id=207615 + + +Reviewed by Tim Horton. + +In macCatalyst, hovering over the scrollbar (an instance of the internal UIKit class +`_UIScrollViewScrollIndicator`) is required in order for a click and drag with the mouse to actually move the +scrollbar. This is because UIKit depends on the cursor interaction added to this view to recognize and call its +delegate methods. + +However, we override hit-testing in WebKit to skip over all children of scroll views, and instead force hit- +testing to find the scroll view instead. This means that UIKit can never hit-test to the scroll indicator views +embedded directly beneath each WKChildScrollView, so the cursor interactions described earlier will not +recognize. To work around this, special case these scroll indicator views, such that we will allow +-hitTest:withEvent: to find these views. + +* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: +(WebKit::scrollViewScrollIndicatorClass): +(-[UIView _web_findDescendantViewAtPoint:withEvent:]): + 2020-02-12 Alan Coon Cherry-pick r254859. rdar://problem/59298172 Modified: branches/safari-609-branch/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm (256556 => 256557) --- branches/safari-609-branch/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm 2020-02-13 22:57:49 UTC (rev 256556) +++
[webkit-changes] [256556] branches/safari-609-branch/Source/WebCore
Title: [256556] branches/safari-609-branch/Source/WebCore
Revision 256556
Author repst...@apple.com
Date 2020-02-13 14:57:49 -0800 (Thu, 13 Feb 2020)
Log Message
Cherry-pick r256230. rdar://problem/59332513
Adjust the minor version number for the desktop user agent string.
https://bugs.webkit.org/show_bug.cgi?id=207498
Patch by Keith Rollin on 2020-02-10
Reviewed by Wenson Hsieh.
This helps with Netflix compatibility on the iPad.
No new tests -- no new or changed functionality.
* platform/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/platform/ios/UserAgentIOS.mm
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (256555 => 256556)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-13 22:52:54 UTC (rev 256555)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-13 22:57:49 UTC (rev 256556)
@@ -1,3 +1,38 @@
+2020-02-13 Russell Epstein
+
+Cherry-pick r256230. rdar://problem/59332513
+
+Adjust the minor version number for the desktop user agent string.
+https://bugs.webkit.org/show_bug.cgi?id=207498
+
+
+Patch by Keith Rollin on 2020-02-10
+Reviewed by Wenson Hsieh.
+
+This helps with Netflix compatibility on the iPad.
+
+No new tests -- no new or changed functionality.
+
+* platform/ios/UserAgentIOS.mm:
+(WebCore::standardUserAgentWithApplicationName):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-10 Keith Rollin
+
+Adjust the minor version number for the desktop user agent string.
+https://bugs.webkit.org/show_bug.cgi?id=207498
+
+
+Reviewed by Wenson Hsieh.
+
+This helps with Netflix compatibility on the iPad.
+
+No new tests -- no new or changed functionality.
+
+* platform/ios/UserAgentIOS.mm:
+(WebCore::standardUserAgentWithApplicationName):
+
2020-02-12 Alan Coon
Cherry-pick r254859. rdar://problem/59298172
Modified: branches/safari-609-branch/Source/WebCore/platform/ios/UserAgentIOS.mm (256555 => 256556)
--- branches/safari-609-branch/Source/WebCore/platform/ios/UserAgentIOS.mm 2020-02-13 22:52:54 UTC (rev 256555)
+++ branches/safari-609-branch/Source/WebCore/platform/ios/UserAgentIOS.mm 2020-02-13 22:57:49 UTC (rev 256556)
@@ -83,7 +83,7 @@
{
if (type == UserAgentType::Desktop) {
String appNameSuffix = applicationName.isEmpty() ? "" : makeString(" ", applicationName);
-return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);
+return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);
}
// FIXME: Is this needed any more? Mac doesn't have this check,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256552] branches/safari-609.1.17.0-branch/Source
Title: [256552] branches/safari-609.1.17.0-branch/Source
Revision 256552
Author alanc...@apple.com
Date 2020-02-13 14:52:43 -0800 (Thu, 13 Feb 2020)
Log Message
Cherry-pick r256005. rdar://problem/59299335
macCatalyst: Unnecessary I-beam over images in editable areas
https://bugs.webkit.org/show_bug.cgi?id=207370
Reviewed by Wenson Hsieh.
Source/WebCore:
* dom/Position.h:
Source/WebKit:
* Shared/ios/InteractionInformationAtPosition.h:
* Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::populateCaretContext):
Add a bit indicating whether the forced I-beam for editable contexts
should be used or not, based on whether it is adjacent to (or immediately
over) a replaced element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/dom/Position.h
branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h
branches/safari-609.1.17.0-branch/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm
branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog (256551 => 256552)
--- branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog 2020-02-13 22:52:39 UTC (rev 256551)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog 2020-02-13 22:52:43 UTC (rev 256552)
@@ -1,3 +1,42 @@
+2020-02-13 Russell Epstein
+
+Cherry-pick r256005. rdar://problem/59299335
+
+macCatalyst: Unnecessary I-beam over images in editable areas
+https://bugs.webkit.org/show_bug.cgi?id=207370
+
+
+Reviewed by Wenson Hsieh.
+
+Source/WebCore:
+
+* dom/Position.h:
+
+Source/WebKit:
+
+* Shared/ios/InteractionInformationAtPosition.h:
+* Shared/ios/InteractionInformationAtPosition.mm:
+(WebKit::InteractionInformationAtPosition::encode const):
+(WebKit::InteractionInformationAtPosition::decode):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::populateCaretContext):
+Add a bit indicating whether the forced I-beam for editable contexts
+should be used or not, based on whether it is adjacent to (or immediately
+over) a replaced element.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-06 Tim Horton
+
+macCatalyst: Unnecessary I-beam over images in editable areas
+https://bugs.webkit.org/show_bug.cgi?id=207370
+
+
+Reviewed by Wenson Hsieh.
+
+* dom/Position.h:
+
2020-02-11 Russell Epstein
Cherry-pick r256230. rdar://problem/59335800
Modified: branches/safari-609.1.17.0-branch/Source/WebCore/dom/Position.h (256551 => 256552)
--- branches/safari-609.1.17.0-branch/Source/WebCore/dom/Position.h 2020-02-13 22:52:39 UTC (rev 256551)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/dom/Position.h 2020-02-13 22:52:43 UTC (rev 256552)
@@ -106,8 +106,8 @@
RefPtr firstNode() const;
// These are convenience methods which are smart about whether the position is neighbor anchored or parent anchored
-Node* computeNodeBeforePosition() const;
-Node* computeNodeAfterPosition() const;
+WEBCORE_EXPORT Node* computeNodeBeforePosition() const;
+WEBCORE_EXPORT Node* computeNodeAfterPosition() const;
Node* anchorNode() const { return m_anchorNode.get(); }
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256551 => 256552)
--- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:39 UTC (rev 256551)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:43 UTC (rev 256552)
@@ -1,5 +1,52 @@
2020-02-13 Russell Epstein
+Cherry-pick r256005. rdar://problem/59299335
+
+macCatalyst: Unnecessary I-beam over images in editable areas
+https://bugs.webkit.org/show_bug.cgi?id=207370
+
+
+Reviewed by Wenson Hsieh.
+
+Source/WebCore:
+
+* dom/Position.h:
+
+Source/WebKit:
+
+* Shared/ios/InteractionInformationAtPosition.h:
+* Shared/ios/InteractionInformationAtPosition.mm:
+(WebKit::InteractionInformationAtPosition::encode const):
+(WebKit::InteractionInformationAtPosition::decode):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::populateCaretContext):
+Add a bit indicating whether the forced I-beam for editable contexts
+should be used or not, based on whether it is adjacent to (or immediately
+over) a
[webkit-changes] [256549] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256549] branches/safari-609.1.17.0-branch/Source/WebKit Revision 256549 Author alanc...@apple.com Date 2020-02-13 14:52:34 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r255827. rdar://problem/59299345 [macCatalyst] IBeam cursor doesn't show up when hovering over text form controls prior to editing https://bugs.webkit.org/show_bug.cgi?id=207268 Reviewed by Tim Horton. On macCatalyst, when hovering over textareas and input fields that have not been edited yet, the cursor fails to change to an IBeam and instead falls back to the default style. Even though `EventHandler::selectCursor()` returns `IBeam`, we end up not actually using an IBeam because the position information's `lineCaretExtent` is an empty rect, which means the caret height is 0 and, more importantly, the line rect will not contain the request point. The line rect is empty in text fields that have not been edited yet because the form control's inner plaintext contenteditable div (embedded in the shadow root) does not contain any child renderers with a non-zero height. Even if it did, however, the element may still be much taller than the combined height of the inner div's children, so the line rect may still not contain the position information request point (this is most easily noticeable when focusing a textarea, typing a few letters, and then moving the cursor to near the bottom of the textarea element). To fix this, add a fallback path for the scenario where we want to show an IBeam, but fail to find line rects that contain the request point. Instead, we still show an IBeam, but simply fake the lineCaretExtent to be an element-wide rect that is the height of the caret, and is also vertically centered about the request point. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::populateCaretContext): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255827 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Diff Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256548 => 256549) --- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:31 UTC (rev 256548) +++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:34 UTC (rev 256549) @@ -1,5 +1,66 @@ 2020-02-13 Russell Epstein +Cherry-pick r255827. rdar://problem/59299345 + +[macCatalyst] IBeam cursor doesn't show up when hovering over text form controls prior to editing +https://bugs.webkit.org/show_bug.cgi?id=207268 + + +Reviewed by Tim Horton. + +On macCatalyst, when hovering over textareas and input fields that have not been edited yet, the cursor fails to +change to an IBeam and instead falls back to the default style. Even though `EventHandler::selectCursor()` +returns `IBeam`, we end up not actually using an IBeam because the position information's `lineCaretExtent` is +an empty rect, which means the caret height is 0 and, more importantly, the line rect will not contain the +request point. + +The line rect is empty in text fields that have not been edited yet because the form control's inner plaintext +contenteditable div (embedded in the shadow root) does not contain any child renderers with a non-zero height. +Even if it did, however, the element may still be much taller than the combined height of the inner div's +children, so the line rect may still not contain the position information request point (this is most easily +noticeable when focusing a textarea, typing a few letters, and then moving the cursor to near the bottom of the +textarea element). + +To fix this, add a fallback path for the scenario where we want to show an IBeam, but fail to find line rects +that contain the request point. Instead, we still show an IBeam, but simply fake the lineCaretExtent to be an +element-wide rect that is the height of the caret, and is also vertically centered about the request point. + +* WebProcess/WebPage/ios/WebPageIOS.mm: +(WebKit::populateCaretContext): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255827 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-05 Wenson Hsieh + +[macCatalyst] IBeam cursor doesn't show up when hovering over text form controls prior to editing +https://bugs.webkit.org/show_bug.cgi?id=207268 + + +Reviewed by Tim Horton. + +On macCatalyst, when hovering over textareas and input fields that have not been edited yet, the cursor fails to +change to an IBeam and instead falls back to the default style. Even though `EventHandler::selectCursor()` +returns `IBeam`, we end up not actually using an IBeam because the
[webkit-changes] [256553] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256553] branches/safari-609.1.17.0-branch/Source/WebKit Revision 256553 Author alanc...@apple.com Date 2020-02-13 14:52:46 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256433. rdar://problem/59412971 macCatalyst: Unable to grab scrollbar on editable text field https://bugs.webkit.org/show_bug.cgi?id=207615 Reviewed by Tim Horton. In macCatalyst, hovering over the scrollbar (an instance of the internal UIKit class `_UIScrollViewScrollIndicator`) is required in order for a click and drag with the mouse to actually move the scrollbar. This is because UIKit depends on the cursor interaction added to this view to recognize and call its delegate methods. However, we override hit-testing in WebKit to skip over all children of scroll views, and instead force hit- testing to find the scroll view instead. This means that UIKit can never hit-test to the scroll indicator views embedded directly beneath each WKChildScrollView, so the cursor interactions described earlier will not recognize. To work around this, special case these scroll indicator views, such that we will allow -hitTest:withEvent: to find these views. * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: (WebKit::scrollViewScrollIndicatorClass): (-[UIView _web_findDescendantViewAtPoint:withEvent:]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256433 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm Diff Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256552 => 256553) --- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:43 UTC (rev 256552) +++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:46 UTC (rev 256553) @@ -1,5 +1,56 @@ 2020-02-13 Russell Epstein +Cherry-pick r256433. rdar://problem/59412971 + +macCatalyst: Unable to grab scrollbar on editable text field +https://bugs.webkit.org/show_bug.cgi?id=207615 + + +Reviewed by Tim Horton. + +In macCatalyst, hovering over the scrollbar (an instance of the internal UIKit class +`_UIScrollViewScrollIndicator`) is required in order for a click and drag with the mouse to actually move the +scrollbar. This is because UIKit depends on the cursor interaction added to this view to recognize and call its +delegate methods. + +However, we override hit-testing in WebKit to skip over all children of scroll views, and instead force hit- +testing to find the scroll view instead. This means that UIKit can never hit-test to the scroll indicator views +embedded directly beneath each WKChildScrollView, so the cursor interactions described earlier will not +recognize. To work around this, special case these scroll indicator views, such that we will allow +-hitTest:withEvent: to find these views. + +* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: +(WebKit::scrollViewScrollIndicatorClass): +(-[UIView _web_findDescendantViewAtPoint:withEvent:]): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256433 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-12 Wenson Hsieh + +macCatalyst: Unable to grab scrollbar on editable text field +https://bugs.webkit.org/show_bug.cgi?id=207615 + + +Reviewed by Tim Horton. + +In macCatalyst, hovering over the scrollbar (an instance of the internal UIKit class +`_UIScrollViewScrollIndicator`) is required in order for a click and drag with the mouse to actually move the +scrollbar. This is because UIKit depends on the cursor interaction added to this view to recognize and call its +delegate methods. + +However, we override hit-testing in WebKit to skip over all children of scroll views, and instead force hit- +testing to find the scroll view instead. This means that UIKit can never hit-test to the scroll indicator views +embedded directly beneath each WKChildScrollView, so the cursor interactions described earlier will not +recognize. To work around this, special case these scroll indicator views, such that we will allow +-hitTest:withEvent: to find these views. + +* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: +(WebKit::scrollViewScrollIndicatorClass): +(-[UIView _web_findDescendantViewAtPoint:withEvent:]): + +2020-02-13 Russell Epstein + Cherry-pick r256005. rdar://problem/59299335 macCatalyst: Unnecessary I-beam over images in editable areas Modified: branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm (256552 => 256553) ---
[webkit-changes] [256555] branches/safari-609.1.17.0-branch
Title: [256555] branches/safari-609.1.17.0-branch Revision 256555 Author alanc...@apple.com Date 2020-02-13 14:52:54 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256520. rdar://problem/59430255 [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor https://bugs.webkit.org/show_bug.cgi?id=207680 Reviewed by Tim Horton. Source/WebKit: Currently, WebPage::updateSelectionWithExtentPoint consults the value of m_selectionAnchor to determine whether it should attempt to modify the current selection using the hit-tested visible position. m_selectionAnchor is only set under WebPage::beginSelectionInDirection, which is only invoked when the user begins a floating cursor gesture. When attempting to perform an out-of-band selection update (i.e. without calling beginSelectionInDirection beforehand), we will end up consulting an arbitrary value for m_selectionAnchor (::Start by default; otherwise, the last value set by beginSelectionInDirection if it was previously called). This means that the selection can often only be extended in one direction (typically forwards) when an API client attempts to use -updateSelectionWithExtentPoint:completionHandler: to extend the current selection. To fix this, make it so that we only respect the selection anchor (m_selectionAnchor) in the case where the user is currently using the floating cursor; otherwise, allow the SPI to expand the selection, such that it contains the visible position for the given location. Test: UIWKInteractionViewProtocol.UpdateSelectionWithExtentPoint * Platform/spi/ios/UIKitSPI.h: * Scripts/webkit/messages.py: * Shared/ios/GestureTypes.h: Add a new flag to tell the web process whether it should limit selection extent updates to the current selection anchor. Also, remove an existing enum type, SelectionHandlePosition, that is unused (since we no longer support block text selection). * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[UITextInteractionAssistant _wk_hasFloatingCursor]): Add a helper method to determine (using the text interaction assistant) whether there's an active floating cursor gesture. In the case where floating cursor is active, the text interaction assistant will be in an active gesture but its UITextInteraction will not, since the gesture recognizer belongs to the keyboard or input view rather than the first responder (in this case, WKContentView). (-[WKContentView updateSelectionWithExtentPoint:completionHandler:]): Only respect the selection anchor if we're in floating cursor mode; otherwise, allow selection updates with an extent point to extend the current selection to include the new position. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::updateSelectionWithExtentPoint): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Plumb the RespectsSelectionAnchor flag over to the web process. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::updateSelectionWithExtentPoint): Tools: Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind the current selection works. * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: (-[TestWKWebView updateSelectionWithExtentPoint:]): * TestWebKitAPI/ios/UIKitSPI.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256520 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/Platform/spi/ios/UIKitSPI.h branches/safari-609.1.17.0-branch/Source/WebKit/Scripts/webkit/messages.py branches/safari-609.1.17.0-branch/Source/WebKit/Shared/ios/GestureTypes.h branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/WebPage.messages.in branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm branches/safari-609.1.17.0-branch/Tools/ChangeLog branches/safari-609.1.17.0-branch/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm branches/safari-609.1.17.0-branch/Tools/TestWebKitAPI/ios/UIKitSPI.h Diff Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256554 => 256555) --- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:49 UTC (rev 256554) +++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:54 UTC (rev 256555) @@ -1,5 +1,131 @@ 2020-02-13 Russell Epstein +
[webkit-changes] [256546] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256546] branches/safari-609.1.17.0-branch/Source/WebKit Revision 256546 Author alanc...@apple.com Date 2020-02-13 14:52:27 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r255664. rdar://problem/59299338 Add a WebKitAdditions hook to provide additional customizations to UIDragInteraction https://bugs.webkit.org/show_bug.cgi?id=207177 Reviewed by Tim Horton. Add a WebKitAdditions extension point that runs immediately after setting up UIDragInteraction and UIDropInteraction. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupDragAndDropInteractions]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255664 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256545 => 256546) --- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:24 UTC (rev 256545) +++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:27 UTC (rev 256546) @@ -1,5 +1,38 @@ 2020-02-13 Russell Epstein +Cherry-pick r255664. rdar://problem/59299338 + +Add a WebKitAdditions hook to provide additional customizations to UIDragInteraction +https://bugs.webkit.org/show_bug.cgi?id=207177 + + +Reviewed by Tim Horton. + +Add a WebKitAdditions extension point that runs immediately after setting up UIDragInteraction and +UIDropInteraction. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView setupDragAndDropInteractions]): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255664 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-03 Wenson Hsieh + +Add a WebKitAdditions hook to provide additional customizations to UIDragInteraction +https://bugs.webkit.org/show_bug.cgi?id=207177 + + +Reviewed by Tim Horton. + +Add a WebKitAdditions extension point that runs immediately after setting up UIDragInteraction and +UIDropInteraction. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView setupDragAndDropInteractions]): + +2020-02-13 Russell Epstein + Cherry-pick r255658. rdar://problem/59299333 Unreviewed, fix the internal build after Modified: branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (256545 => 256546) --- branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-13 22:52:24 UTC (rev 256545) +++ branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-13 22:52:27 UTC (rev 256546) @@ -6868,6 +6868,10 @@ [_dragInteraction _setLiftDelay:self.dragLiftDelay]; [_dragInteraction setEnabled:shouldEnableDragInteractionForPolicy(self.webView._dragInteractionPolicy)]; +#if USE(APPLE_INTERNAL_SDK) +[self _performAdditionalSetupDragAndDropInteractions]; +#endif + [self addInteraction:_dragInteraction.get()]; [self addInteraction:_dropInteraction.get()]; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256554] branches/safari-609.1.17.0-branch
Title: [256554] branches/safari-609.1.17.0-branch Revision 256554 Author alanc...@apple.com Date 2020-02-13 14:52:49 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256485. rdar://problem/59430261 Composition highlight rects should be rounded and inset https://bugs.webkit.org/show_bug.cgi?id=207655 Reviewed by Tim Horton. Source/WebCore: Apply a couple of minor adjustments to the appearance of composition highlight rects that appear behind marked text, in the case where the client specifies attributed marked text with background colors. Test: editing/input/composition-highlights.html * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintCompositionBackground): In the case where custom composition rects are specified, add a half-pixel inset to all sides of the background rect, and add a slight corner radius around each background rect. * rendering/InlineTextBox.h: Source/WebKit: Stitch adjacent highlight rects together if they have the same highlight color; this minimizes the number of composition highlight rects we hand to the web process when changing the marked text. * UIProcess/ios/WKContentViewInteraction.mm: (compositionHighlights): LayoutTests: Make this existing layout test work with the new composition highlight appearance by covering up the edges of the composition highlight rect with a black border. Due to subpixel insets around the composition highlight rect, the reference image would be offset by a half pixel without this change (even when changing the spans to have a `border-radius`). * editing/input/composition-highlights-expected.html: * editing/input/composition-highlights.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256485 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog branches/safari-609.1.17.0-branch/LayoutTests/editing/input/composition-highlights-expected.html branches/safari-609.1.17.0-branch/LayoutTests/editing/input/composition-highlights.html branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.17.0-branch/Source/WebCore/rendering/InlineTextBox.cpp branches/safari-609.1.17.0-branch/Source/WebCore/rendering/InlineTextBox.h branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256553 => 256554) --- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog 2020-02-13 22:52:46 UTC (rev 256553) +++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog 2020-02-13 22:52:49 UTC (rev 256554) @@ -1,5 +1,67 @@ 2020-02-13 Russell Epstein +Cherry-pick r256485. rdar://problem/59430261 + +Composition highlight rects should be rounded and inset +https://bugs.webkit.org/show_bug.cgi?id=207655 + + +Reviewed by Tim Horton. + +Source/WebCore: + +Apply a couple of minor adjustments to the appearance of composition highlight rects that appear behind marked +text, in the case where the client specifies attributed marked text with background colors. + +Test: editing/input/composition-highlights.html + +* rendering/InlineTextBox.cpp: +(WebCore::InlineTextBox::paintMarkedTextBackground): +(WebCore::InlineTextBox::paintCompositionBackground): + +In the case where custom composition rects are specified, add a half-pixel inset to all sides of the background +rect, and add a slight corner radius around each background rect. + +* rendering/InlineTextBox.h: + +Source/WebKit: + +Stitch adjacent highlight rects together if they have the same highlight color; this minimizes the number of +composition highlight rects we hand to the web process when changing the marked text. + +* UIProcess/ios/WKContentViewInteraction.mm: +(compositionHighlights): + +LayoutTests: + +Make this existing layout test work with the new composition highlight appearance by covering up the edges of +the composition highlight rect with a black border. Due to subpixel insets around the composition highlight +rect, the reference image would be offset by a half pixel without this change (even when changing the spans to +have a `border-radius`). + +* editing/input/composition-highlights-expected.html: +* editing/input/composition-highlights.html: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256485 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-12 Wenson Hsieh + +Composition highlight rects should be rounded and inset +https://bugs.webkit.org/show_bug.cgi?id=207655 + + +Reviewed by Tim Horton. + +Make this existing
[webkit-changes] [256550] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256550] branches/safari-609.1.17.0-branch/Source/WebKit Revision 256550 Author alanc...@apple.com Date 2020-02-13 14:52:36 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r255879. rdar://problem/59299329 [macCatalyst] Incorrect IBeam cursor when selecting text on Wikipedia https://bugs.webkit.org/show_bug.cgi?id=207299 Reviewed by Tim Horton. After r255827, if EventHandler selects an IBeam cursor at the position information request location, we will always attempt to show a caret at that location, whose height is the height of the editing caret for that visible position. However, this means that: - It's possible for the caret to be incorrectly sized if the caret is before a large replaced element, such as a table. Since the request location is also outside of any line rect, it doesn't make sense to use the caret height for the height of the cursor. Instead, fall back to computed line height. This fixes an issue on en.wikipedia.org where the line rect would sometimes update to an enormous size when selecting text, since the caret would temporarily hover over an editing position that is before a large table. - This fallback path completely negates certain cursor behaviors; partially restore this behavior by making it so that in the case where the cursor is in editable content and the line caret first line from the top of the hit-tested node already contains the request point, don't bother trying to recenter the line rect to be right over the request point. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::populateCaretContext): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255879 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Diff Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256549 => 256550) --- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:34 UTC (rev 256549) +++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:36 UTC (rev 256550) @@ -1,5 +1,61 @@ 2020-02-13 Russell Epstein +Cherry-pick r255879. rdar://problem/59299329 + +[macCatalyst] Incorrect IBeam cursor when selecting text on Wikipedia +https://bugs.webkit.org/show_bug.cgi?id=207299 + + +Reviewed by Tim Horton. + +After r255827, if EventHandler selects an IBeam cursor at the position information request location, we will +always attempt to show a caret at that location, whose height is the height of the editing caret for that +visible position. However, this means that: + +- It's possible for the caret to be incorrectly sized if the caret is before a large replaced element, such as +a table. Since the request location is also outside of any line rect, it doesn't make sense to use the caret +height for the height of the cursor. Instead, fall back to computed line height. This fixes an issue on +en.wikipedia.org where the line rect would sometimes update to an enormous size when selecting text, since +the caret would temporarily hover over an editing position that is before a large table. + +- This fallback path completely negates certain cursor behaviors; partially restore this behavior by making it +so that in the case where the cursor is in editable content and the line caret first line from the top of +the hit-tested node already contains the request point, don't bother trying to recenter the line rect to be +right over the request point. + +* WebProcess/WebPage/ios/WebPageIOS.mm: +(WebKit::populateCaretContext): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255879 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-05 Wenson Hsieh + +[macCatalyst] Incorrect IBeam cursor when selecting text on Wikipedia +https://bugs.webkit.org/show_bug.cgi?id=207299 + + +Reviewed by Tim Horton. + +After r255827, if EventHandler selects an IBeam cursor at the position information request location, we will +always attempt to show a caret at that location, whose height is the height of the editing caret for that +visible position. However, this means that: + +- It's possible for the caret to be incorrectly sized if the caret is before a large replaced element, such as +a table. Since the request location is also outside of any line rect, it doesn't make sense to use the caret +height for the height of the cursor. Instead, fall back to computed line height. This fixes an issue on +en.wikipedia.org where the line rect would sometimes update to an enormous size when selecting text, since +
[webkit-changes] [256551] branches/safari-609.1.17.0-branch
Title: [256551] branches/safari-609.1.17.0-branch
Revision 256551
Author alanc...@apple.com
Date 2020-02-13 14:52:39 -0800 (Thu, 13 Feb 2020)
Log Message
Cherry-pick r256000. rdar://problem/59299326
WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
https://bugs.webkit.org/show_bug.cgi?id=207350
Reviewed by Tim Horton.
Source/WebKit:
Handle the character granularity case in `WebPage::rangeForGranularityAtPoint` by just returning a collapsed
Range. Certain internal clients will have a need to place and update the text selection using character
granularity; see radar for more details.
Test: UIWKInteractionViewProtocol.SelectTextWithCharacterGranularity
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView supportsTextSelectionWithCharacterGranularity]):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rangeForGranularityAtPoint):
Tools:
Add a test to exercise the corner case in the SPI.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
branches/safari-609.1.17.0-branch/Tools/ChangeLog
branches/safari-609.1.17.0-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
branches/safari-609.1.17.0-branch/Tools/TestWebKitAPI/ios/UIKitSPI.h
Added Paths
branches/safari-609.1.17.0-branch/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm
Diff
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256550 => 256551)
--- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:36 UTC (rev 256550)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:39 UTC (rev 256551)
@@ -1,5 +1,57 @@
2020-02-13 Russell Epstein
+Cherry-pick r256000. rdar://problem/59299326
+
+WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
+https://bugs.webkit.org/show_bug.cgi?id=207350
+
+
+Reviewed by Tim Horton.
+
+Source/WebKit:
+
+Handle the character granularity case in `WebPage::rangeForGranularityAtPoint` by just returning a collapsed
+Range. Certain internal clients will have a need to place and update the text selection using character
+granularity; see radar for more details.
+
+Test: UIWKInteractionViewProtocol.SelectTextWithCharacterGranularity
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView supportsTextSelectionWithCharacterGranularity]):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::rangeForGranularityAtPoint):
+
+Tools:
+
+Add a test to exercise the corner case in the SPI.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-06 Wenson Hsieh
+
+WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
+https://bugs.webkit.org/show_bug.cgi?id=207350
+
+
+Reviewed by Tim Horton.
+
+Handle the character granularity case in `WebPage::rangeForGranularityAtPoint` by just returning a collapsed
+Range. Certain internal clients will have a need to place and update the text selection using character
+granularity; see radar for more details.
+
+Test: UIWKInteractionViewProtocol.SelectTextWithCharacterGranularity
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView supportsTextSelectionWithCharacterGranularity]):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::rangeForGranularityAtPoint):
+
+2020-02-13 Russell Epstein
+
Cherry-pick r255879. rdar://problem/59299329
[macCatalyst] Incorrect IBeam cursor when selecting text on Wikipedia
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (256550 => 256551)
--- branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-13 22:52:36 UTC (rev 256550)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-13 22:52:39 UTC (rev 256551)
@@ -6366,6 +6366,11 @@
return !_ignoreSelectionCommandFadeCount;
}
+- (BOOL)supportsTextSelectionWithCharacterGranularity
+{
+return YES;
+}
+
-
[webkit-changes] [256548] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256548] branches/safari-609.1.17.0-branch/Source/WebKit
Revision 256548
Author alanc...@apple.com
Date 2020-02-13 14:52:31 -0800 (Thu, 13 Feb 2020)
Log Message
Cherry-pick r255710. rdar://problem/59299340
macCatalyst: Shouldn't get text cursor on checkboxes
https://bugs.webkit.org/show_bug.cgi?id=207234
Reviewed by Wenson Hsieh.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::canForceCaretForPosition):
(WebKit::populateCaretContext):
(WebKit::lineCaretExtent): Deleted.
The I-beam forcing code was a bit too aggressive; it should consider
the style of the node that it ends up finding after searching, not just
assume it wants an I-beam because it's "texty".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256547 => 256548)
--- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:29 UTC (rev 256547)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:31 UTC (rev 256548)
@@ -1,5 +1,42 @@
2020-02-13 Russell Epstein
+Cherry-pick r255710. rdar://problem/59299340
+
+macCatalyst: Shouldn't get text cursor on checkboxes
+https://bugs.webkit.org/show_bug.cgi?id=207234
+
+
+Reviewed by Wenson Hsieh.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::canForceCaretForPosition):
+(WebKit::populateCaretContext):
+(WebKit::lineCaretExtent): Deleted.
+The I-beam forcing code was a bit too aggressive; it should consider
+the style of the node that it ends up finding after searching, not just
+assume it wants an I-beam because it's "texty".
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-04 Tim Horton
+
+macCatalyst: Shouldn't get text cursor on checkboxes
+https://bugs.webkit.org/show_bug.cgi?id=207234
+
+
+Reviewed by Wenson Hsieh.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::canForceCaretForPosition):
+(WebKit::populateCaretContext):
+(WebKit::lineCaretExtent): Deleted.
+The I-beam forcing code was a bit too aggressive; it should consider
+the style of the node that it ends up finding after searching, not just
+assume it wants an I-beam because it's "texty".
+
+2020-02-13 Russell Epstein
+
Cherry-pick r255691. rdar://problem/59299315
[macCatalyst] Missing custom cursors in subframes that are offset from the origin of the root view
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (256547 => 256548)
--- branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-02-13 22:52:29 UTC (rev 256547)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-02-13 22:52:31 UTC (rev 256548)
@@ -2760,25 +2760,50 @@
return nullptr;
}
-static FloatRect lineCaretExtent(const InteractionInformationRequest& request, const HitTestResult& hitTestResult)
+static bool canForceCaretForPosition(const VisiblePosition& position)
{
+auto* node = position.deepEquivalent().anchorNode();
+if (!node)
+return false;
+
+auto* renderer = node->renderer();
+auto* style = renderer ? >style() : nullptr;
+auto cursorType = style ? style->cursor() : CursorType::Auto;
+
+if (cursorType == CursorType::Text)
+return true;
+
+if (cursorType != CursorType::Auto)
+return false;
+
+if (node->hasEditableStyle())
+return true;
+
+if (!renderer)
+return false;
+
+return renderer->isText() && node->canStartSelection();
+}
+
+static void populateCaretContext(const HitTestResult& hitTestResult, const InteractionInformationRequest& request, InteractionInformationAtPosition& info)
+{
auto frame = makeRefPtr(hitTestResult.innerNodeFrame());
if (!frame)
-return { };
+return;
auto view = makeRefPtr(frame->view());
if (!view)
-return { };
+return;
auto* renderer = hitTestResult.innerNode()->renderer();
if (!renderer)
-return { };
+return;
while (renderer && !is(*renderer))
renderer = renderer->parent();
if (!renderer)
-return { };
+return;
// FIXME: We should be able to retrieve this geometry information without
// forcing the text to fall out of Simple Line Layout.
@@ -2786,24 +2811,12 @@
auto position = frame->visiblePositionForPoint(view->rootViewToContents(request.point));
auto lineRect =
[webkit-changes] [256547] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256547] branches/safari-609.1.17.0-branch/Source/WebKit
Revision 256547
Author alanc...@apple.com
Date 2020-02-13 14:52:29 -0800 (Thu, 13 Feb 2020)
Log Message
Cherry-pick r255691. rdar://problem/59299315
[macCatalyst] Missing custom cursors in subframes that are offset from the origin of the root view
https://bugs.webkit.org/show_bug.cgi?id=207215
Reviewed by Tim Horton.
r255046> added support for custom cursor styles when hovering over subframes. However,
we currently try to hit-test content in the subframe using the interaction information request's point, which is
in root view coordinates; as such, we only get the correct custom cursor styles when hovering over elements in a
subframe, if the subframe is also at the origin of the root view.
To fix this, simply convert from root view coordinates to frame coordinates when performing the hit-test.
Unfortunately, this change is currently untestable; see .
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::lineCaretExtent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256546 => 256547)
--- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:27 UTC (rev 256546)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:29 UTC (rev 256547)
@@ -1,5 +1,48 @@
2020-02-13 Russell Epstein
+Cherry-pick r255691. rdar://problem/59299315
+
+[macCatalyst] Missing custom cursors in subframes that are offset from the origin of the root view
+https://bugs.webkit.org/show_bug.cgi?id=207215
+
+
+Reviewed by Tim Horton.
+
+ added support for custom cursor styles when hovering over subframes. However,
+we currently try to hit-test content in the subframe using the interaction information request's point, which is
+in root view coordinates; as such, we only get the correct custom cursor styles when hovering over elements in a
+subframe, if the subframe is also at the origin of the root view.
+
+To fix this, simply convert from root view coordinates to frame coordinates when performing the hit-test.
+Unfortunately, this change is currently untestable; see .
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::lineCaretExtent):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-04 Wenson Hsieh
+
+[macCatalyst] Missing custom cursors in subframes that are offset from the origin of the root view
+https://bugs.webkit.org/show_bug.cgi?id=207215
+
+
+Reviewed by Tim Horton.
+
+ added support for custom cursor styles when hovering over subframes. However,
+we currently try to hit-test content in the subframe using the interaction information request's point, which is
+in root view coordinates; as such, we only get the correct custom cursor styles when hovering over elements in a
+subframe, if the subframe is also at the origin of the root view.
+
+To fix this, simply convert from root view coordinates to frame coordinates when performing the hit-test.
+Unfortunately, this change is currently untestable; see .
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::lineCaretExtent):
+
+2020-02-13 Russell Epstein
+
Cherry-pick r255664. rdar://problem/59299338
Add a WebKitAdditions hook to provide additional customizations to UIDragInteraction
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (256546 => 256547)
--- branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-02-13 22:52:27 UTC (rev 256546)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-02-13 22:52:29 UTC (rev 256547)
@@ -2762,10 +2762,14 @@
static FloatRect lineCaretExtent(const InteractionInformationRequest& request, const HitTestResult& hitTestResult)
{
-auto* frame = hitTestResult.innerNodeFrame();
+auto frame = makeRefPtr(hitTestResult.innerNodeFrame());
if (!frame)
return { };
+auto view = makeRefPtr(frame->view());
+if (!view)
+return { };
+
auto* renderer = hitTestResult.innerNode()->renderer();
if (!renderer)
return { };
@@ -2779,7 +2783,7 @@
// FIXME: We should be able to retrieve this geometry information without
// forcing the text to fall out of Simple Line Layout.
auto& blockFlow = downcast(*renderer);
-VisiblePosition position = frame->visiblePositionForPoint(request.point);
+
[webkit-changes] [256544] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256544] branches/safari-609.1.17.0-branch/Source/WebKit
Revision 256544
Author alanc...@apple.com
Date 2020-02-13 14:52:22 -0800 (Thu, 13 Feb 2020)
Log Message
Cherry-pick r255625. rdar://problem/59299317
Add a WebKitAdditions hook to override the behavior of -[WKContentView gestureRecognizer:shouldReceiveTouch:]
https://bugs.webkit.org/show_bug.cgi?id=207162
Reviewed by Tim Horton.
Allow an internal implementation of `-_allowGestureRecognizer:toReceiveTouch:` to prevent touches from being
routed to certain gesture recognizers, if necessary.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256543 => 256544)
--- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:19 UTC (rev 256543)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:22 UTC (rev 256544)
@@ -1,5 +1,38 @@
2020-02-13 Russell Epstein
+Cherry-pick r255625. rdar://problem/59299317
+
+Add a WebKitAdditions hook to override the behavior of -[WKContentView gestureRecognizer:shouldReceiveTouch:]
+https://bugs.webkit.org/show_bug.cgi?id=207162
+
+
+Reviewed by Tim Horton.
+
+Allow an internal implementation of `-_allowGestureRecognizer:toReceiveTouch:` to prevent touches from being
+routed to certain gesture recognizers, if necessary.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-03 Wenson Hsieh
+
+Add a WebKitAdditions hook to override the behavior of -[WKContentView gestureRecognizer:shouldReceiveTouch:]
+https://bugs.webkit.org/show_bug.cgi?id=207162
+
+
+Reviewed by Tim Horton.
+
+Allow an internal implementation of `-_allowGestureRecognizer:toReceiveTouch:` to prevent touches from being
+routed to certain gesture recognizers, if necessary.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
+
+2020-02-13 Russell Epstein
+
Cherry-pick r255603. rdar://problem/59299321
[iOS 13] Dragging on-screen volume control on a YouTube video selects text around the panel
Modified: branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (256543 => 256544)
--- branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-13 22:52:19 UTC (rev 256543)
+++ branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-13 22:52:22 UTC (rev 256544)
@@ -1506,7 +1506,6 @@
#endif
if (gestureRecognizer == _touchActionLeftSwipeGestureRecognizer || gestureRecognizer == _touchActionRightSwipeGestureRecognizer || gestureRecognizer == _touchActionUpSwipeGestureRecognizer || gestureRecognizer == _touchActionDownSwipeGestureRecognizer) {
-
// We update the enabled state of the various swipe gesture recognizers such that if we have a unidirectional touch-action
// specified (only pan-x or only pan-y) we enable the two recognizers in the opposite axis to prevent scrolling from starting
// if the initial gesture is such a swipe. Since the recognizers are specified to use a single finger for recognition, we don't
@@ -1517,7 +1516,11 @@
return touchActions == WebCore::TouchAction::PanX;
}
+#if USE(APPLE_INTERNAL_SDK)
+return [self _allowGestureRecognizer:gestureRecognizer toReceiveTouch:touch];
+#else
return YES;
+#endif
}
#pragma mark - WKTouchActionGestureRecognizerDelegate implementation
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256545] branches/safari-609.1.17.0-branch/Source/WebKit
Title: [256545] branches/safari-609.1.17.0-branch/Source/WebKit Revision 256545 Author alanc...@apple.com Date 2020-02-13 14:52:24 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r255658. rdar://problem/59299333 Unreviewed, fix the internal build after * UIProcess/ios/WKContentViewInteraction.h: Declare this helper in the header, now that it's consulted by some WebKitAdditions code. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255658 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h Diff Modified: branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog (256544 => 256545) --- branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:22 UTC (rev 256544) +++ branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog 2020-02-13 22:52:24 UTC (rev 256545) @@ -1,5 +1,23 @@ 2020-02-13 Russell Epstein +Cherry-pick r255658. rdar://problem/59299333 + +Unreviewed, fix the internal build after + +* UIProcess/ios/WKContentViewInteraction.h: Declare this helper in the header, now that it's consulted by some +WebKitAdditions code. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255658 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-03 Wenson Hsieh + +Unreviewed, fix the internal build after + +* UIProcess/ios/WKContentViewInteraction.h: Declare this helper in the header, now that it's consulted by some +WebKitAdditions code. + +2020-02-13 Russell Epstein + Cherry-pick r255625. rdar://problem/59299317 Add a WebKitAdditions hook to override the behavior of -[WKContentView gestureRecognizer:shouldReceiveTouch:] Modified: branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (256544 => 256545) --- branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2020-02-13 22:52:22 UTC (rev 256544) +++ branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2020-02-13 22:52:24 UTC (rev 256545) @@ -487,6 +487,7 @@ - (void)_updateChangedSelection; - (BOOL)_interpretKeyEvent:(::WebEvent *)theEvent isCharEvent:(BOOL)isCharEvent; - (void)_positionInformationDidChange:(const WebKit::InteractionInformationAtPosition&)info; +- (BOOL)_currentPositionInformationIsValidForRequest:(const WebKit::InteractionInformationRequest&)request; - (void)_attemptClickAtLocation:(CGPoint)location modifierFlags:(UIKeyModifierFlags)modifierFlags; - (void)_willStartScrollingOrZooming; - (void)_didScroll; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256543] branches/safari-609.1.17.0-branch
Title: [256543] branches/safari-609.1.17.0-branch Revision 256543 Author alanc...@apple.com Date 2020-02-13 14:52:19 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r255603. rdar://problem/59299321 [iOS 13] Dragging on-screen volume control on a YouTube video selects text around the panel https://bugs.webkit.org/show_bug.cgi?id=207140 Reviewed by Tim Horton. Source/WebKit: This bug occurs on iPadOS when long pressing the volume controls on the desktop version of YouTube, and then performing a pan gesture; this activates the highlight text selection gesture recognizer added in iOS 13, causing text to be selected while adjusting the volume using these custom controls. On macOS, we avoid this because `Node::canStartSelection()` returns `false`, due to a container node having both `user-drag: element` and `user-select: none`; in this scenario, we allow dragging to take precendence over text selection, so the volume slider can be moved using a mouse without simultaneously selecting text. This logic is currently absent on iOS, where UIKit text interaction gesture recognizers ask us for information about the DOM at given locations, and we determine whether to allow text interaction gestures (such as long pressing) to begin in `-textInteractionGesture:shouldBeginAtPoint:` and `-hasSelectablePositionAtPoint:`. Ideally, we'd want to eventually unify these two codepaths for triggering text selection (and preferably just have both go through EventHandler); in lieu of this, simply make the iOS codepath behave a little more like macOS by adding a bit to allow text interaction gestures to bail in the case where at least one container of the hit-tested element is both draggable and unselectable. Test: editing/selection/ios/prefer-drag-over-text-selection.html * Shared/ios/InteractionInformationAtPosition.h: * Shared/ios/InteractionInformationAtPosition.mm: (WebKit::InteractionInformationAtPosition::encode const): (WebKit::InteractionInformationAtPosition::decode): Add the new bit to InteractionInformationAtPosition. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView textInteractionGesture:shouldBeginAtPoint:]): Avoid beginning text selection if the bit is set. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::selectionPositionInformation): Move a comment about the ">= 97% of the document's visible area" heuristic next to the relevant code, and also leave a FIXME mentioning that we should reconsider whether this is really needed; it seems that this was originally intended to avoid ending up with an excessively large block selection, but block selection has been removed entirely since iOS 12. That said, this logic may still be helping avoid situations where the text selection is too aggressive on iOS and ends up selecting too much text. LayoutTests: Add a layout test to verify that we don't allow text selection gestures inside of containers that have both `user-drag: element` and `user-select: none`. * editing/selection/ios/prefer-drag-over-text-selection-expected.txt: Added. * editing/selection/ios/prefer-drag-over-text-selection.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255603 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/ChangeLog branches/safari-609.1.17.0-branch/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h branches/safari-609.1.17.0-branch/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm branches/safari-609.1.17.0-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm branches/safari-609.1.17.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Added Paths branches/safari-609.1.17.0-branch/LayoutTests/editing/selection/ios/prefer-drag-over-text-selection-expected.txt branches/safari-609.1.17.0-branch/LayoutTests/editing/selection/ios/prefer-drag-over-text-selection.html Diff Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256542 => 256543) --- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog 2020-02-13 22:39:41 UTC (rev 256542) +++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog 2020-02-13 22:52:19 UTC (rev 256543) @@ -1,3 +1,77 @@ +2020-02-13 Russell Epstein + +Cherry-pick r255603. rdar://problem/59299321 + +[iOS 13] Dragging on-screen volume control on a YouTube video selects text around the panel +https://bugs.webkit.org/show_bug.cgi?id=207140 + + +Reviewed by Tim Horton. + +Source/WebKit: + +This bug occurs on iPadOS when long pressing the volume controls on the desktop version of YouTube, and then +performing a pan gesture; this activates the highlight text selection gesture recognizer added in iOS 13, +causing text to be selected while
[webkit-changes] [256542] branches/safari-609.1.17.0-branch/Source
Title: [256542] branches/safari-609.1.17.0-branch/Source Revision 256542 Author alanc...@apple.com Date 2020-02-13 14:39:41 -0800 (Thu, 13 Feb 2020) Log Message Versioning. Modified Paths branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-609.1.17.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-609.1.17.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-609.1.17.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256541 => 256542) --- branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-13 21:59:12 UTC (rev 256541) +++ branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-13 22:39:41 UTC (rev 256542) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256541 => 256542) --- branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-13 21:59:12 UTC (rev 256541) +++ branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-13 22:39:41 UTC (rev 256542) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256541 => 256542) --- branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-13 21:59:12 UTC (rev 256541) +++ branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-13 22:39:41 UTC (rev 256542) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig (256541 => 256542) --- branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-13 21:59:12 UTC (rev 256541) +++ branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-13 22:39:41 UTC (rev 256542) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256541 => 256542) --- branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-13 21:59:12 UTC (rev 256541) +++ branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-13 22:39:41 UTC (rev 256542) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.17.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (256541 => 256542) --- branches/safari-609.1.17.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-02-13 21:59:12 UTC (rev 256541) +++ branches/safari-609.1.17.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-02-13 22:39:41 UTC (rev 256542) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [256539] branches/safari-610.1.3-branch
Title: [256539] branches/safari-610.1.3-branch Revision 256539 Author alanc...@apple.com Date 2020-02-13 13:49:48 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256317. rdar://problem/59398474 REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration https://bugs.webkit.org/show_bug.cgi?id=207521 Reviewed by Eric Carlson. Source/WebKit: Covered by debug assertion not hit in layout tests. * WebProcess/Network/webrtc/WebMDNSRegister.cpp: (WebKit::WebMDNSRegister::finishedRegisteringMDNSName): Call completion handler even if the document entry has been cleared, which can happen in suspend/destruction case. If the entry is not there, all MDNS names for the document have been unregistered. We then report a registration error. LayoutTests: * platform/mac-wk2/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256317 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610.1.3-branch/LayoutTests/ChangeLog branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations branches/safari-610.1.3-branch/Source/WebKit/ChangeLog branches/safari-610.1.3-branch/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp Diff Modified: branches/safari-610.1.3-branch/LayoutTests/ChangeLog (256538 => 256539) --- branches/safari-610.1.3-branch/LayoutTests/ChangeLog 2020-02-13 21:49:44 UTC (rev 256538) +++ branches/safari-610.1.3-branch/LayoutTests/ChangeLog 2020-02-13 21:49:48 UTC (rev 256539) @@ -1,5 +1,40 @@ 2020-02-13 Alan Coon +Cherry-pick r256317. rdar://problem/59398474 + +REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration +https://bugs.webkit.org/show_bug.cgi?id=207521 + + +Reviewed by Eric Carlson. + +Source/WebKit: + +Covered by debug assertion not hit in layout tests. + +* WebProcess/Network/webrtc/WebMDNSRegister.cpp: +(WebKit::WebMDNSRegister::finishedRegisteringMDNSName): +Call completion handler even if the document entry has been cleared, which can happen in suspend/destruction case. +If the entry is not there, all MDNS names for the document have been unregistered. We then report a registration error. + +LayoutTests: + +* platform/mac-wk2/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256317 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-11 Youenn Fablet + +REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration +https://bugs.webkit.org/show_bug.cgi?id=207521 + + +Reviewed by Eric Carlson. + +* platform/mac-wk2/TestExpectations: + +2020-02-13 Alan Coon + Cherry-pick r256231. rdar://problem/59398474 Regression: (r256009?) [ Mojave wk2 Debug ] webrtc/peerconnection-page-cache-long.html is crashing. Modified: branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations (256538 => 256539) --- branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 21:49:44 UTC (rev 256538) +++ branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 21:49:48 UTC (rev 256539) @@ -1001,4 +1001,3 @@ webkit.org/b/207385 http/tests/paymentrequest/page-cache-completed-payment-response.https.html [ Pass Failure ] -webkit.org/b/207521 [ Mojave Debug ] webrtc/peerconnection-page-cache-long.html [ Pass Crash ] Modified: branches/safari-610.1.3-branch/Source/WebKit/ChangeLog (256538 => 256539) --- branches/safari-610.1.3-branch/Source/WebKit/ChangeLog 2020-02-13 21:49:44 UTC (rev 256538) +++ branches/safari-610.1.3-branch/Source/WebKit/ChangeLog 2020-02-13 21:49:48 UTC (rev 256539) @@ -1,3 +1,43 @@ +2020-02-13 Alan Coon + +Cherry-pick r256317. rdar://problem/59398474 + +REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration +https://bugs.webkit.org/show_bug.cgi?id=207521 + + +Reviewed by Eric Carlson. + +Source/WebKit: + +Covered by debug assertion not hit in layout tests. + +* WebProcess/Network/webrtc/WebMDNSRegister.cpp: +(WebKit::WebMDNSRegister::finishedRegisteringMDNSName): +Call completion handler even if the document entry has been cleared, which can happen in suspend/destruction case. +If the entry is not there, all MDNS names for the document have been unregistered. We then report a registration error. + +LayoutTests: + +* platform/mac-wk2/TestExpectations: + +git-svn-id:
[webkit-changes] [256538] branches/safari-610.1.3-branch/LayoutTests
Title: [256538] branches/safari-610.1.3-branch/LayoutTests Revision 256538 Author alanc...@apple.com Date 2020-02-13 13:49:44 -0800 (Thu, 13 Feb 2020) Log Message Cherry-pick r256231. rdar://problem/59398474 Regression: (r256009?) [ Mojave wk2 Debug ] webrtc/peerconnection-page-cache-long.html is crashing. https://bugs.webkit.org/show_bug.cgi?id=207521 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256231 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610.1.3-branch/LayoutTests/ChangeLog branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: branches/safari-610.1.3-branch/LayoutTests/ChangeLog (256537 => 256538) --- branches/safari-610.1.3-branch/LayoutTests/ChangeLog 2020-02-13 21:41:56 UTC (rev 256537) +++ branches/safari-610.1.3-branch/LayoutTests/ChangeLog 2020-02-13 21:49:44 UTC (rev 256538) @@ -1,3 +1,25 @@ +2020-02-13 Alan Coon + +Cherry-pick r256231. rdar://problem/59398474 + +Regression: (r256009?) [ Mojave wk2 Debug ] webrtc/peerconnection-page-cache-long.html is crashing. +https://bugs.webkit.org/show_bug.cgi?id=207521 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256231 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-10 Jason Lawrence + +Regression: (r256009?) [ Mojave wk2 Debug ] webrtc/peerconnection-page-cache-long.html is crashing. +https://bugs.webkit.org/show_bug.cgi?id=207521 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-02-07 Wenson Hsieh [iOS] Double tapping shouldn't scroll the page when the body has `overflow: hidden` Modified: branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations (256537 => 256538) --- branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 21:41:56 UTC (rev 256537) +++ branches/safari-610.1.3-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 21:49:44 UTC (rev 256538) @@ -999,4 +999,6 @@ webkit.org/b/207303 loader/stateobjects/pushstate-size-iframe.html [ Pass Crash ] -webkit.org/b/207385 http/tests/paymentrequest/page-cache-completed-payment-response.https.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207385 http/tests/paymentrequest/page-cache-completed-payment-response.https.html [ Pass Failure ] + +webkit.org/b/207521 [ Mojave Debug ] webrtc/peerconnection-page-cache-long.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256537] trunk/LayoutTests
Title: [256537] trunk/LayoutTests
Revision 256537
Author you...@apple.com
Date 2020-02-13 13:41:56 -0800 (Thu, 13 Feb 2020)
Log Message
REGRESSION: (256381) [ macOS ] http/tests/workers/service/serviceworkerclients-claim.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207653
Reviewed by Chris Dumez.
console log message output was flaky.
Make sure to end the fetch and post a message so that the console log message will appear in the expected.txt reliably.
* http/tests/workers/service/serviceworkerclients-claim.https-expected.txt:
* http/tests/workers/service/serviceworkerclients-claim.https.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt
trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html
Diff
Modified: trunk/LayoutTests/ChangeLog (256536 => 256537)
--- trunk/LayoutTests/ChangeLog 2020-02-13 21:40:08 UTC (rev 256536)
+++ trunk/LayoutTests/ChangeLog 2020-02-13 21:41:56 UTC (rev 256537)
@@ -1,3 +1,17 @@
+2020-02-13 Youenn Fablet
+
+REGRESSION: (256381) [ macOS ] http/tests/workers/service/serviceworkerclients-claim.https.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=207653
+
+
+Reviewed by Chris Dumez.
+
+console log message output was flaky.
+Make sure to end the fetch and post a message so that the console log message will appear in the expected.txt reliably.
+
+* http/tests/workers/service/serviceworkerclients-claim.https-expected.txt:
+* http/tests/workers/service/serviceworkerclients-claim.https.html:
+
2020-02-13 Jason Lawrence
[ Mac ] fast/images/webp-as-image.html is failing.
Modified: trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt (256536 => 256537)
--- trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt 2020-02-13 21:40:08 UTC (rev 256536)
+++ trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt 2020-02-13 21:41:56 UTC (rev 256537)
@@ -1,6 +1,5 @@
CONSOLE MESSAGE: Origin null is not allowed by Access-Control-Allow-Origin.
CONSOLE MESSAGE: Fetch API cannot load https://127.0.0.1:8443/pinkelephant due to access control checks.
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: TypeError: Origin null is not allowed by Access-Control-Allow-Origin.
PASS Setup worker
Modified: trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html (256536 => 256537)
--- trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html 2020-02-13 21:40:08 UTC (rev 256536)
+++ trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html 2020-02-13 21:41:56 UTC (rev 256537)
@@ -54,18 +54,17 @@
'var text = await response.text();' +
'window.parent.postMessage(text, "*");' +
'}' +
- 'doTest();' +
+ 'doTest().catch(e => {' +
+ ' window.parent.postMessage("Fetch failed", "*");'+
+ '});' +
'';
promise_test(async (test) => {
-var promise = new Promise((resolve, reject) => {
-window.addEventListener("message", (event) => {
-reject("Received a message from iframe:" + event.data);
-}, false);
-setTimeout(resolve, 100);
+var promise = new Promise((resolve) => {
+window.addEventListener("message", (event) => resolve(event.data));
});
var frame = await withFrame("data:text/html," + htmlString);
-return promise;
+assert_equals(await promise, "Fetch failed");
}, "Test data URL frame");
promise_test(async (test) => {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256536] trunk/Source
Title: [256536] trunk/Source Revision 256536 Author eric.carl...@apple.com Date 2020-02-13 13:40:08 -0800 (Thu, 13 Feb 2020) Log Message Rename SerializedPlatformRepresentation to SerializedPlatformDataCue https://bugs.webkit.org/show_bug.cgi?id=207695 Reviewed by Youenn Fablet. No new tests, no functional change. * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * html/track/DataCue.cpp: (WebCore::DataCue::DataCue): (WebCore::DataCue::cueContentsMatch const): * html/track/DataCue.h: * html/track/InbandDataTextTrack.cpp: (WebCore::InbandDataTextTrack::addDataCue): (WebCore::InbandDataTextTrack::updateDataCue): (WebCore::InbandDataTextTrack::removeDataCue): (WebCore::InbandDataTextTrack::removeCue): * html/track/InbandDataTextTrack.h: * html/track/InbandTextTrack.h: * platform/SerializedPlatformDataCue.h: Renamed from Source/WebCore/platform/SerializedPlatformRepresentation.h. * platform/graphics/InbandTextTrackPrivateClient.h: * platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp: (WebCore::InbandMetadataTextTrackPrivateAVF::addDataCue): * platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive): * platform/mac/SerializedPlatformDataCueMac.h: Renamed from Source/WebCore/platform/mac/SerializedPlatformRepresentationMac.h. (WebCore::SerializedPlatformDataCueMac::nativeValue const): * platform/mac/SerializedPlatformDataCueMac.mm: Renamed from Source/WebCore/platform/mac/SerializedPlatformRepresentationMac.mm. (WebCore::SerializedPlatformDataCueMac::SerializedPlatformDataCueMac): (WebCore::SerializedPlatformDataCueMac::~SerializedPlatformDataCueMac): (WebCore::SerializedPlatformDataCueMac::create): (WebCore::SerializedPlatformDataCueMac::data const): (WebCore::SerializedPlatformDataCueMac::deserialize const): (WebCore::SerializedPlatformDataCueMac::isEqual const): (WebCore::toSerializedPlatformDataCueMac): (WebCore::jsValueWithValueInContext): (WebCore::jsValueWithDataInContext): (WebCore::jsValueWithArrayInContext): (WebCore::jsValueWithDictionaryInContext): (WebCore::jsValueWithAVMetadataItemInContext): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/PlatformMac.cmake trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/html/track/DataCue.cpp trunk/Source/WebCore/html/track/DataCue.h trunk/Source/WebCore/html/track/InbandDataTextTrack.cpp trunk/Source/WebCore/html/track/InbandDataTextTrack.h trunk/Source/WebCore/html/track/InbandTextTrack.h trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h trunk/Source/WebCore/platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp trunk/Source/WebCore/platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp trunk/Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.h trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in trunk/Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.cpp trunk/Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.h Added Paths trunk/Source/WebCore/platform/SerializedPlatformDataCue.h trunk/Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h trunk/Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm Removed Paths trunk/Source/WebCore/platform/SerializedPlatformRepresentation.h trunk/Source/WebCore/platform/mac/SerializedPlatformRepresentationMac.h trunk/Source/WebCore/platform/mac/SerializedPlatformRepresentationMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (256535 => 256536) --- trunk/Source/WebCore/ChangeLog 2020-02-13 21:26:33 UTC (rev 256535) +++ trunk/Source/WebCore/ChangeLog 2020-02-13 21:40:08 UTC (rev 256536) @@ -1,3 +1,49 @@ +2020-02-13 Eric Carlson + +Rename SerializedPlatformRepresentation to SerializedPlatformDataCue +https://bugs.webkit.org/show_bug.cgi?id=207695 + + +Reviewed by Youenn Fablet. + +No new tests, no functional change. + +* SourcesCocoa.txt: +* WebCore.xcodeproj/project.pbxproj: +* html/track/DataCue.cpp: +(WebCore::DataCue::DataCue): +(WebCore::DataCue::cueContentsMatch const): +* html/track/DataCue.h: +* html/track/InbandDataTextTrack.cpp: +(WebCore::InbandDataTextTrack::addDataCue): +(WebCore::InbandDataTextTrack::updateDataCue): +(WebCore::InbandDataTextTrack::removeDataCue): +(WebCore::InbandDataTextTrack::removeCue): +* html/track/InbandDataTextTrack.h: +* html/track/InbandTextTrack.h: +* platform/SerializedPlatformDataCue.h: Renamed from Source/WebCore/platform/SerializedPlatformRepresentation.h. +
[webkit-changes] [256534] trunk/LayoutTests
Title: [256534] trunk/LayoutTests Revision 256534 Author lawrenc...@apple.com Date 2020-02-13 13:25:24 -0800 (Thu, 13 Feb 2020) Log Message [ Mac ] fast/images/webp-as-image.html is failing. https://bugs.webkit.org/show_bug.cgi?id=207718 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256533 => 256534) --- trunk/LayoutTests/ChangeLog 2020-02-13 21:21:19 UTC (rev 256533) +++ trunk/LayoutTests/ChangeLog 2020-02-13 21:25:24 UTC (rev 256534) @@ -1,3 +1,12 @@ +2020-02-13 Jason Lawrence + +[ Mac ] fast/images/webp-as-image.html is failing. +https://bugs.webkit.org/show_bug.cgi?id=207718 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2020-02-13 Lauro Moura [GTK] Gardening debug mode timeouts. Modified: trunk/LayoutTests/platform/mac/TestExpectations (256533 => 256534) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 21:21:19 UTC (rev 256533) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 21:25:24 UTC (rev 256534) @@ -2016,4 +2016,6 @@ webkit.org/b/207710 svg/custom/animate-initial-pause-unpause.html [ Pass Failure ] -webkit.org/b/207046 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207046 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html [ Pass Failure ] + +webkit.org/b/207718 fast/images/webp-as-image.html [ Pass ImageOnlyFailure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256533] branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/ StorageAreaMap.h
Title: [256533] branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h
Revision 256533
Author repst...@apple.com
Date 2020-02-13 13:21:19 -0800 (Thu, 13 Feb 2020)
Log Message
Unreviewed build fix, rdar://problem/59298172
Modified Paths
branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h
Diff
Modified: branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h (256532 => 256533)
--- branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h 2020-02-13 21:11:03 UTC (rev 256532)
+++ branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h 2020-02-13 21:21:19 UTC (rev 256533)
@@ -100,6 +100,7 @@
uint64_t m_useCount { 0 };
uint64_t m_currentSeed { 0 };
+unsigned m_quotaInBytes;
WebCore::StorageType m_type;
bool m_hasPendingClear { false };
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256532] trunk/LayoutTests
Title: [256532] trunk/LayoutTests Revision 256532 Author commit-qu...@webkit.org Date 2020-02-13 13:11:03 -0800 (Thu, 13 Feb 2020) Log Message [GTK] Gardening debug mode timeouts. https://bugs.webkit.org/show_bug.cgi?id=207714 Also removed obsolete expectations as the tests are just timeouting in debug mode and have not crashed since 2018. Unreviewed test gardening. Patch by Lauro Moura on 2020-02-13 * platform/gtk-wayland/TestExpectations: * platform/gtk/TestExpectations: * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk-wayland/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256531 => 256532) --- trunk/LayoutTests/ChangeLog 2020-02-13 20:22:05 UTC (rev 256531) +++ trunk/LayoutTests/ChangeLog 2020-02-13 21:11:03 UTC (rev 256532) @@ -1,3 +1,17 @@ +2020-02-13 Lauro Moura + +[GTK] Gardening debug mode timeouts. +https://bugs.webkit.org/show_bug.cgi?id=207714 + +Also removed obsolete expectations as the tests are just timeouting in +debug mode and have not crashed since 2018. + +Unreviewed test gardening. + +* platform/gtk-wayland/TestExpectations: +* platform/gtk/TestExpectations: +* platform/wpe/TestExpectations: + 2020-02-13 Jacob Uphoff [ macOS ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html is flaky failing Modified: trunk/LayoutTests/platform/gtk/TestExpectations (256531 => 256532) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-13 20:22:05 UTC (rev 256531) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-13 21:11:03 UTC (rev 256532) @@ -1389,8 +1389,6 @@ webkit.org/b/183180 imported/blink/fast/forms/time-multiple-fields/time-multiple-fields-crash-by-focus-on-unload.html [ Crash Pass ] -webkit.org/b/183215 imported/w3c/web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-cseuckr.html [ Crash Pass ] - webkit.org/b/183401 fast/animation/request-animation-frame-during-modal.html [ Crash Pass ] webkit.org/b/185546 media/video-playbackrate.html [ Crash Pass Timeout ] @@ -1973,8 +1971,6 @@ webkit.org/b/182989 http/wpt/beacon/beacon-quota.html [ Pass Failure ] -webkit.org/b/183034 imported/w3c/web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-iso-ir-149.html [ Pass Crash ] - webkit.org/b/183035 imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-innerwidth-innerheight.html [ Failure Pass ] webkit.org/b/183036 fast/events/message-port.html [ Timeout Pass ] @@ -2050,11 +2046,11 @@ webkit.org/b/186750 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html [ Pass Failure ] webkit.org/b/186750 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html [ Pass Failure ] -webkit.org/b/186847 http/tests/inspector/network/resource-sizes-memory-cache.html [ Pass Failure ] +webkit.org/b/186847 [ Release ] http/tests/inspector/network/resource-sizes-memory-cache.html [ Pass Failure ] webkit.org/b/192407 http/tests/inspector/network/resource-security-connection.html [ Skip ] webkit.org/b/191497 http/tests/inspector/network/resource-security-certificate.html [ Skip ] webkit.org/b/191497 http/tests/inspector/network/getSerializedCertificate.html [ Skip ] -webkit.org/b/179173 http/tests/inspector/network/har/har-page.html [ Failure Pass ] +webkit.org/b/179173 [ Release ] http/tests/inspector/network/har/har-page.html [ Failure Pass ] webkit.org/b/186851 imported/w3c/web-platform-tests/xhr/formdata.htm [ Pass Failure ] webkit.org/b/186851 imported/w3c/web-platform-tests/xhr/formdata-blob.htm [ Pass Failure ] @@ -2082,7 +2078,7 @@ webkit.org/b/188044 webgl/1.0.3/conformance/glsl/constructors/glsl-construct-bvec4.html [ Timeout Pass ] -webkit.org/b/188046 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker.html [ Failure Pass ] +webkit.org/b/188046 [ Release ] imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker.html [ Failure Pass ] webkit.org/b/188100 imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-context.html [ Failure Pass ] @@ -2798,6 +2794,44 @@ webkit.org/b/206876 http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html [ Timeout ] +webkit.org/b/207711 http/tests/cookies/double-quoted-value-with-semi-colon.html [ Timeout ] +webkit.org/b/207711 [ Release ] fast/history/page-cache-webdatabase-pending-transaction.html [ Timeout ] +webkit.org/b/207711 [ Debug ] fast/history/page-cache-webdatabase-pending-transaction.html [ Pass Timeout ] +webkit.org/b/207711 [ Debug ]
[webkit-changes] [256531] trunk
Title: [256531] trunk
Revision 256531
Author pvol...@apple.com
Date 2020-02-13 12:22:05 -0800 (Thu, 13 Feb 2020)
Log Message
[iOS] Check if PIP is supported in the UI process
https://bugs.webkit.org/show_bug.cgi?id=207406
Reviewed by Brent Fulgham.
Source/WebCore:
This is currently being checked in the WebProcess, but since this check is initiating communication with the frontboard
service which will be blocked, this check should be moved to the UI process. In the UI process, this is checked when
starting a new WebContent process, and sent to the WebContent process as part of the process creation parameters. The
WebContent is storing the received value.
API test: WebKit.PictureInPictureSupport
* platform/PictureInPictureSupport.h:
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(WebCore::setSupportsPictureInPicture):
(WebCore::supportsPictureInPicture):
* testing/Internals.cpp:
(WebCore::Internals::supportsPictureInPicture):
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit:
When starting a new WebContent process, check if PIP is supported, and pass the results to the newly created
WebContent process.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
(TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PictureInPictureSupport.h
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (256530 => 256531)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 19:47:29 UTC (rev 256530)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 20:22:05 UTC (rev 256531)
@@ -1,3 +1,26 @@
+2020-02-13 Per Arne Vollan
+
+[iOS] Check if PIP is supported in the UI process
+https://bugs.webkit.org/show_bug.cgi?id=207406
+
+Reviewed by Brent Fulgham.
+
+This is currently being checked in the WebProcess, but since this check is initiating communication with the frontboard
+service which will be blocked, this check should be moved to the UI process. In the UI process, this is checked when
+starting a new WebContent process, and sent to the WebContent process as part of the process creation parameters. The
+WebContent is storing the received value.
+
+API test: WebKit.PictureInPictureSupport
+
+* platform/PictureInPictureSupport.h:
+* platform/ios/VideoFullscreenInterfaceAVKit.mm:
+(WebCore::setSupportsPictureInPicture):
+(WebCore::supportsPictureInPicture):
+* testing/Internals.cpp:
+(WebCore::Internals::supportsPictureInPicture):
+* testing/Internals.h:
+* testing/Internals.idl:
+
2020-02-13 Benjamin Nham
Allow use of proxies in MiniBrowser
Modified: trunk/Source/WebCore/platform/PictureInPictureSupport.h (256530 => 256531)
--- trunk/Source/WebCore/platform/PictureInPictureSupport.h 2020-02-13 19:47:29 UTC (rev 256530)
+++ trunk/Source/WebCore/platform/PictureInPictureSupport.h 2020-02-13 20:22:05 UTC (rev 256531)
@@ -28,6 +28,7 @@
namespace WebCore {
#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+WEBCORE_EXPORT void setSupportsPictureInPicture(bool);
WEBCORE_EXPORT bool supportsPictureInPicture();
#else
constexpr bool supportsPictureInPicture() { return false; }
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (256530 => 256531)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-02-13 19:47:29 UTC (rev 256530)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-02-13 20:22:05 UTC (rev 256531)
@@ -1503,9 +1503,18 @@
#endif // HAVE(AVKIT)
+static Optional isPictureInPictureSupported;
+
+void WebCore::setSupportsPictureInPicture(bool isSupported)
+{
+isPictureInPictureSupported = isSupported;
+}
+
bool WebCore::supportsPictureInPicture()
{
#if PLATFORM(IOS_FAMILY) && HAVE(AVKIT) && !PLATFORM(WATCHOS)
+if (isPictureInPictureSupported.hasValue())
[webkit-changes] [256530] trunk/Source
Title: [256530] trunk/Source
Revision 256530
Author commit-qu...@webkit.org
Date 2020-02-13 11:47:29 -0800 (Thu, 13 Feb 2020)
Log Message
Allow use of proxies in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=207598
For testing purposes, we allow Safari to use a custom HTTP/HTTPS proxy passed through
Source/WebCore:
command line arguments. This gives MiniBrowser the same ability.
$ run-minibrowser --release -WebKit2HTTPProxy "http://127.0.0.1:8080" \
-WebKit2HTTPSProxy "http://127.0.0.1:8080"
Patch by Benjamin Nham on 2020-02-13
Reviewed by Antti Koivisto.
* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::MacApplication::isMiniBrowser):
(WebCore::IOSApplication::isMiniBrowser):
Source/WebKit:
command line arguments. This gives MiniBrowser the same ability. Example invocation:
$ run-minibrowser --release -WebKit2HTTPProxy "http://127.0.0.1:8080" \
-WebKit2HTTPSProxy "http://127.0.0.1:8080"
Patch by Benjamin Nham on 2020-02-13
Reviewed by Antti Koivisto.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (256529 => 256530)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 19:43:53 UTC (rev 256529)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 19:47:29 UTC (rev 256530)
@@ -1,3 +1,21 @@
+2020-02-13 Benjamin Nham
+
+Allow use of proxies in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=207598
+
+For testing purposes, we allow Safari to use a custom HTTP/HTTPS proxy passed through
+command line arguments. This gives MiniBrowser the same ability.
+
+$ run-minibrowser --release -WebKit2HTTPProxy "http://127.0.0.1:8080" \
+-WebKit2HTTPSProxy "http://127.0.0.1:8080"
+
+Reviewed by Antti Koivisto.
+
+* platform/RuntimeApplicationChecks.h:
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::MacApplication::isMiniBrowser):
+(WebCore::IOSApplication::isMiniBrowser):
+
2020-02-13 Zalan Bujtas
[LFC][IFC] LineBreaker should not hold on to the lastWrapOpportunity inline item
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (256529 => 256530)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-02-13 19:43:53 UTC (rev 256529)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-02-13 19:47:29 UTC (rev 256530)
@@ -63,6 +63,7 @@
WEBCORE_EXPORT bool isMicrosoftMessenger();
WEBCORE_EXPORT bool isMicrosoftMyDay();
WEBCORE_EXPORT bool isMicrosoftOutlook();
+WEBCORE_EXPORT bool isMiniBrowser();
bool isQuickenEssentials();
WEBCORE_EXPORT bool isSafari();
bool isSolidStateNetworksDownloader();
@@ -86,6 +87,7 @@
WEBCORE_EXPORT bool isIMDb();
WEBCORE_EXPORT bool isWebBookmarksD();
WEBCORE_EXPORT bool isDumpRenderTree();
+WEBCORE_EXPORT bool isMiniBrowser();
bool isMobileStore();
bool isSpringBoard();
WEBCORE_EXPORT bool isWebProcess();
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (256529 => 256530)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-02-13 19:43:53 UTC (rev 256529)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-02-13 19:47:29 UTC (rev 256530)
@@ -166,6 +166,12 @@
return isMicrosoftOutlook;
}
+bool MacApplication::isMiniBrowser()
+{
+static bool isMiniBrowser = applicationBundleIsEqualTo("org.webkit.MiniBrowser"_s);
+return isMiniBrowser;
+}
+
bool MacApplication::isQuickenEssentials()
{
static bool isQuickenEssentials = applicationBundleIsEqualTo("com.intuit.QuickenEssentials"_s);
@@ -345,6 +351,12 @@
return isDataActivation;
}
+bool IOSApplication::isMiniBrowser()
+{
+static bool isMiniBrowser = applicationBundleIsEqualTo("org.webkit.MiniBrowser"_s);
+return isMiniBrowser;
+}
+
#endif
} // namespace WebCore
Modified: trunk/Source/WebKit/ChangeLog (256529 => 256530)
--- trunk/Source/WebKit/ChangeLog 2020-02-13 19:43:53 UTC (rev 256529)
+++ trunk/Source/WebKit/ChangeLog 2020-02-13 19:47:29 UTC (rev 256530)
@@ -1,3 +1,21 @@
+2020-02-13 Benjamin Nham
+
+Allow use of proxies in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=207598
+
+For testing purposes, we allow Safari to use a custom HTTP/HTTPS proxy passed through
+command line arguments. This gives MiniBrowser the same ability.
[webkit-changes] [256529] trunk/LayoutTests
Title: [256529] trunk/LayoutTests Revision 256529 Author jacob_uph...@apple.com Date 2020-02-13 11:43:53 -0800 (Thu, 13 Feb 2020) Log Message [ macOS ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207046 Corrected test expectations Unreviewed test gardening * platform/mac-wk1/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256528 => 256529) --- trunk/LayoutTests/ChangeLog 2020-02-13 19:42:56 UTC (rev 256528) +++ trunk/LayoutTests/ChangeLog 2020-02-13 19:43:53 UTC (rev 256529) @@ -1,5 +1,17 @@ 2020-02-13 Jacob Uphoff +[ macOS ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207046 + +Corrected test expectations + +Unreviewed test gardening + +* platform/mac-wk1/TestExpectations: +* platform/mac/TestExpectations: + +2020-02-13 Jacob Uphoff + [ macOS ] svg/custom/animate-initial-pause-unpause.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207710 Modified: trunk/LayoutTests/platform/mac/TestExpectations (256528 => 256529) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 19:42:56 UTC (rev 256528) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 19:43:53 UTC (rev 256529) @@ -2014,4 +2014,6 @@ webkit.org/b/207337 http/wpt/css/css-animations/start-animation-001.html [ Pass ImageOnlyFailure ] -webkit.org/b/207710 svg/custom/animate-initial-pause-unpause.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207710 svg/custom/animate-initial-pause-unpause.html [ Pass Failure ] + +webkit.org/b/207046 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html [ Pass Failure ] \ No newline at end of file Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256528 => 256529) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-02-13 19:42:56 UTC (rev 256528) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-02-13 19:43:53 UTC (rev 256529) @@ -870,8 +870,6 @@ webkit.org/b/206974 http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy.html [ Pass Failure ] -webkit.org/b/207046 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html [ Pass Failure ] - webkit.org/b/207059 imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html [ Pass Failure ] webkit.org/b/207066 editing/execCommand/insert-nested-lists.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256528] trunk/Tools
Title: [256528] trunk/Tools
Revision 256528
Author jbed...@apple.com
Date 2020-02-13 11:42:56 -0800 (Thu, 13 Feb 2020)
Log Message
TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=207397
Reviewed by Jer Noble.
* TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm
Diff
Modified: trunk/Tools/ChangeLog (256527 => 256528)
--- trunk/Tools/ChangeLog 2020-02-13 19:23:53 UTC (rev 256527)
+++ trunk/Tools/ChangeLog 2020-02-13 19:42:56 UTC (rev 256528)
@@ -1,5 +1,16 @@
2020-02-13 Jonathan Bedard
+TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
+https://bugs.webkit.org/show_bug.cgi?id=207397
+
+
+Reviewed by Jer Noble.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
+* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
+
+2020-02-13 Jonathan Bedard
+
TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
https://bugs.webkit.org/show_bug.cgi?id=207696
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm (256527 => 256528)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm 2020-02-13 19:23:53 UTC (rev 256527)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm 2020-02-13 19:42:56 UTC (rev 256528)
@@ -25,7 +25,7 @@
#include "config.h"
-#if !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if !PLATFORM(IOS_FAMILY_SIMULATOR) && ENABLE(FULLSCREEN_API)
#import "PlatformUtilities.h"
#import "Test.h"
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm (256527 => 256528)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm 2020-02-13 19:23:53 UTC (rev 256527)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm 2020-02-13 19:42:56 UTC (rev 256528)
@@ -57,6 +57,8 @@
EXPECT_STREQ([webView stringByEvaluatingJavaScript:@"document.querySelector('video').webkitPresentationMode"].UTF8String, "inline");
}
+#if ENABLE(FULLSCREEN_API)
+
TEST(WKWebViewCloseAllMediaPresentations, VideoFullscreen)
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
@@ -108,3 +110,5 @@
EXPECT_STREQ([webView stringByEvaluatingJavaScript:@"document.webkitFullscreenElement"].UTF8String, "");
}
+
+#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256527] trunk/LayoutTests
Title: [256527] trunk/LayoutTests Revision 256527 Author jacob_uph...@apple.com Date 2020-02-13 11:23:53 -0800 (Thu, 13 Feb 2020) Log Message [ macOS ] svg/custom/animate-initial-pause-unpause.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207710 Unreviewed test gardening * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256526 => 256527) --- trunk/LayoutTests/ChangeLog 2020-02-13 19:16:41 UTC (rev 256526) +++ trunk/LayoutTests/ChangeLog 2020-02-13 19:23:53 UTC (rev 256527) @@ -1,3 +1,12 @@ +2020-02-13 Jacob Uphoff + +[ macOS ] svg/custom/animate-initial-pause-unpause.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207710 + +Unreviewed test gardening + +* platform/mac/TestExpectations: + 2020-02-13 Said Abou-Hallawa WebP image format is not supported Modified: trunk/LayoutTests/platform/mac/TestExpectations (256526 => 256527) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 19:16:41 UTC (rev 256526) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 19:23:53 UTC (rev 256527) @@ -2013,3 +2013,5 @@ webkit.org/b/194162 storage/websql/read-transactions-running-concurrently.html [ Pass Failure ] webkit.org/b/207337 http/wpt/css/css-animations/start-animation-001.html [ Pass ImageOnlyFailure ] + +webkit.org/b/207710 svg/custom/animate-initial-pause-unpause.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256526] trunk/LayoutTests
Title: [256526] trunk/LayoutTests Revision 256526 Author s...@apple.com Date 2020-02-13 11:16:41 -0800 (Thu, 13 Feb 2020) Log Message WebP image format is not supported https://bugs.webkit.org/show_bug.cgi?id=192672 Unreviewed test gardening * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256525 => 256526) --- trunk/LayoutTests/ChangeLog 2020-02-13 19:10:27 UTC (rev 256525) +++ trunk/LayoutTests/ChangeLog 2020-02-13 19:16:41 UTC (rev 256526) @@ -1,3 +1,12 @@ +2020-02-13 Said Abou-Hallawa + +WebP image format is not supported +https://bugs.webkit.org/show_bug.cgi?id=192672 + +Unreviewed test gardening + +* platform/mac/TestExpectations: + 2020-02-13 Jacob Uphoff [ iOS ] imported/w3c/IndexedDB-private-browsing/close-in-upgradeneeded.html is flaky timing out Modified: trunk/LayoutTests/platform/mac/TestExpectations (256525 => 256526) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 19:10:27 UTC (rev 256525) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 19:16:41 UTC (rev 256526) @@ -1789,13 +1789,6 @@ [ Catalina+ ] fast/images/animated-heics-draw.html [ Pass ] [ Catalina+ ] fast/images/animated-heics-verify.html [ Pass ] -# -[ Catalina+ ] fast/images/webp-as-image.html [ Pass ] -[ Catalina+ ] fast/images/animated-webp-as-image.html [ Pass ] - -# -[ Catalina+ ] fast/images/animated-webp.html [ ImageOnlyFailure ] - # [ Catalina+ ] fast/text/font-collection.html [ ImageOnlyFailure ] [ Catalina+ ] fast/text/woff2.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256525] trunk/LayoutTests
Title: [256525] trunk/LayoutTests Revision 256525 Author jacob_uph...@apple.com Date 2020-02-13 11:10:27 -0800 (Thu, 13 Feb 2020) Log Message [ iOS ] imported/w3c/IndexedDB-private-browsing/close-in-upgradeneeded.html is flaky timing out https://bugs.webkit.org/show_bug.cgi?id=207709 Unreviewed test gardening * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256524 => 256525) --- trunk/LayoutTests/ChangeLog 2020-02-13 19:05:29 UTC (rev 256524) +++ trunk/LayoutTests/ChangeLog 2020-02-13 19:10:27 UTC (rev 256525) @@ -1,3 +1,12 @@ +2020-02-13 Jacob Uphoff + +[ iOS ] imported/w3c/IndexedDB-private-browsing/close-in-upgradeneeded.html is flaky timing out +https://bugs.webkit.org/show_bug.cgi?id=207709 + +Unreviewed test gardening + +* platform/ios-wk2/TestExpectations: + 2020-02-13 Nikos Mouchtaris Remove ApplePayBillingAddress.html from TestExpectations after fix for flaky failure Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256524 => 256525) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-02-13 19:05:29 UTC (rev 256524) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-02-13 19:10:27 UTC (rev 256525) @@ -1408,4 +1408,6 @@ webkit.org/b/207665 http/tests/cache-storage/cache-representation.https.html [ Slow ] -webkit.org/b/196300 fast/visual-viewport/ios/min-scale-greater-than-one.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/196300 fast/visual-viewport/ios/min-scale-greater-than-one.html [ Pass Failure ] + +webkit.org/b/207709 imported/w3c/IndexedDB-private-browsing/close-in-upgradeneeded.html [ Pass Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256524] trunk/Source/WebCore
Title: [256524] trunk/Source/WebCore
Revision 256524
Author za...@apple.com
Date 2020-02-13 11:05:29 -0800 (Thu, 13 Feb 2020)
Log Message
[LFC][IFC] LineBreaker should not hold on to the lastWrapOpportunity inline item
https://bugs.webkit.org/show_bug.cgi?id=207707
Reviewed by Antti Koivisto.
LineBreaker only needs a flag indicating that there's a wrapping opportunity on the line.
LineLayoutContext needs to know what the position is (as an InlineItem) so that it could initiate a revert if needed.
* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
(WebCore::Layout::LineBreaker::wordBreakBehavior const):
* layout/inlineformatting/InlineLineBreaker.h:
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineLayoutContext::layoutLine):
(WebCore::Layout::LineLayoutContext::tryAddingFloatItem):
(WebCore::Layout::LineLayoutContext::tryAddingInlineItems):
(WebCore::Layout::LineLayoutContext::rebuildLine):
(WebCore::Layout::LineLayoutContext::rebuildLineForRevert): Deleted.
* layout/inlineformatting/LineLayoutContext.h:
(WebCore::Layout::LineLayoutContext::InlineItemRange::size const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.h
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (256523 => 256524)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 18:47:44 UTC (rev 256523)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 19:05:29 UTC (rev 256524)
@@ -1,3 +1,28 @@
+2020-02-13 Zalan Bujtas
+
+[LFC][IFC] LineBreaker should not hold on to the lastWrapOpportunity inline item
+https://bugs.webkit.org/show_bug.cgi?id=207707
+
+
+Reviewed by Antti Koivisto.
+
+LineBreaker only needs a flag indicating that there's a wrapping opportunity on the line.
+LineLayoutContext needs to know what the position is (as an InlineItem) so that it could initiate a revert if needed.
+
+* layout/inlineformatting/InlineLineBreaker.cpp:
+(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
+(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
+(WebCore::Layout::LineBreaker::wordBreakBehavior const):
+* layout/inlineformatting/InlineLineBreaker.h:
+* layout/inlineformatting/LineLayoutContext.cpp:
+(WebCore::Layout::LineLayoutContext::layoutLine):
+(WebCore::Layout::LineLayoutContext::tryAddingFloatItem):
+(WebCore::Layout::LineLayoutContext::tryAddingInlineItems):
+(WebCore::Layout::LineLayoutContext::rebuildLine):
+(WebCore::Layout::LineLayoutContext::rebuildLineForRevert): Deleted.
+* layout/inlineformatting/LineLayoutContext.h:
+(WebCore::Layout::LineLayoutContext::InlineItemRange::size const):
+
2020-02-13 Adrian Perez de Castro
Non-unified build fixes mid February 2020 edition
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp (256523 => 256524)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp 2020-02-13 18:47:44 UTC (rev 256523)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp 2020-02-13 19:05:29 UTC (rev 256524)
@@ -139,9 +139,11 @@
return true;
return shouldKeepBeginningOfLineWhitespace(candidateItem.style());
};
-auto& inlineItem = candidateRuns[*lastLineWrapOpportunityIndex].inlineItem;
-if (isEligibleLineWrapOpportunity(inlineItem))
-m_lastWrapOpportunity =
+auto& lastWrapOpportunityCandidateItem = candidateRuns[*lastLineWrapOpportunityIndex].inlineItem;
+if (isEligibleLineWrapOpportunity(lastWrapOpportunityCandidateItem)) {
+result.lastWrapOpportunityItem =
+m_hasWrapOpportunityAtPreviousPosition = true;
+}
}
}
return result;
@@ -200,14 +202,14 @@
}
// If we are not allowed to break this overflowing content, we still need to decide whether keep it or push it to the next line.
if (lineStatus.lineIsEmpty) {
-ASSERT(!m_lastWrapOpportunity);
+ASSERT(!m_hasWrapOpportunityAtPreviousPosition);
return { Result::Action::Keep, IsEndOfLine::No };
}
// Now either wrap here or at an earlier position, or not wrap at all.
if (isContentWrappingAllowed(candidateContent))
return { Result::Action::Push, IsEndOfLine::Yes };
-if (m_lastWrapOpportunity)
-return { Result::Action::Revert, IsEndOfLine::Yes, { }, m_lastWrapOpportunity };
+if (m_hasWrapOpportunityAtPreviousPosition)
+return { Result::Action::RevertToLastWrapOpportunity,
[webkit-changes] [256523] trunk/Tools
Title: [256523] trunk/Tools
Revision 256523
Author jbed...@apple.com
Date 2020-02-13 10:47:44 -0800 (Thu, 13 Feb 2020)
Log Message
TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
https://bugs.webkit.org/show_bug.cgi?id=207696
Reviewed by Tim Horton.
* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm
Diff
Modified: trunk/Tools/ChangeLog (256522 => 256523)
--- trunk/Tools/ChangeLog 2020-02-13 18:36:40 UTC (rev 256522)
+++ trunk/Tools/ChangeLog 2020-02-13 18:47:44 UTC (rev 256523)
@@ -1,3 +1,12 @@
+2020-02-13 Jonathan Bedard
+
+TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
+https://bugs.webkit.org/show_bug.cgi?id=207696
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
+
2020-02-13 Wenson Hsieh
[iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm (256522 => 256523)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm 2020-02-13 18:36:40 UTC (rev 256522)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm 2020-02-13 18:47:44 UTC (rev 256523)
@@ -268,10 +268,17 @@
return [@(a.CGRectValue.origin.x) compare:@(b.CGRectValue.origin.x)];
}];
EXPECT_EQ(4UL, rects.count);
+#if PLATFORM(MACCATALYST)
+EXPECT_EQ(CGRectMake(0, -1, glyphWidth, glyphWidth + 1), rects[0].CGRectValue);
+EXPECT_EQ(CGRectMake(glyphWidth, -1, glyphWidth, glyphWidth + 1), rects[1].CGRectValue);
+EXPECT_EQ(CGRectMake(2 * glyphWidth, -1, glyphWidth, glyphWidth + 1), rects[2].CGRectValue);
+EXPECT_EQ(CGRectMake(3 * glyphWidth, -1, glyphWidth, glyphWidth + 1), rects[3].CGRectValue);
+#else
EXPECT_EQ(CGRectMake(0, 0, glyphWidth, glyphWidth), rects[0].CGRectValue);
EXPECT_EQ(CGRectMake(glyphWidth, 0, glyphWidth, glyphWidth), rects[1].CGRectValue);
EXPECT_EQ(CGRectMake(2 * glyphWidth, 0, glyphWidth, glyphWidth), rects[2].CGRectValue);
EXPECT_EQ(CGRectMake(3 * glyphWidth, 0, glyphWidth, glyphWidth), rects[3].CGRectValue);
+#endif
rects = [context characterRectsForCharacterRange:NSMakeRange(5, 1)];
EXPECT_EQ(0UL, rects.count);
@@ -279,10 +286,18 @@
EXPECT_NSSTRING_EQ(" MMM", context.contextAfter);
rects = [context characterRectsForCharacterRange:NSMakeRange(0, 1)];
EXPECT_EQ(1UL, rects.count);
+#if PLATFORM(MACCATALYST)
+EXPECT_EQ(CGRectMake(0, -1, glyphWidth, glyphWidth + 1), rects.firstObject.CGRectValue);
+#else
EXPECT_EQ(CGRectMake(0, 0, glyphWidth, glyphWidth), rects.firstObject.CGRectValue);
+#endif
rects = [context characterRectsForCharacterRange:NSMakeRange(6, 1)];
EXPECT_EQ(1UL, rects.count);
+#if PLATFORM(MACCATALYST)
+EXPECT_EQ(CGRectMake(6 * glyphWidth, -1, glyphWidth, glyphWidth + 1), rects.firstObject.CGRectValue);
+#else
EXPECT_EQ(CGRectMake(6 * glyphWidth, 0, glyphWidth, glyphWidth), rects.firstObject.CGRectValue);
+#endif
// Text Input Context
[webView synchronouslyLoadHTMLString:applyStyle(@"")];
@@ -411,11 +426,19 @@
auto context = retainPtr([webView synchronouslyRequestDocumentContext:request.get()]);
auto *rectValues = [context markedTextRects];
+#if PLATFORM(MACCATALYST)
+EXPECT_EQ(CGRectMake(165, 8, 26, 26), [rectValues[0] CGRectValue]);
+EXPECT_EQ(CGRectMake(190, 8, 26, 26), [rectValues[1] CGRectValue]);
+EXPECT_EQ(CGRectMake(215, 8, 26, 26), [rectValues[2] CGRectValue]);
+EXPECT_EQ(CGRectMake(240, 8, 26, 26), [rectValues[3] CGRectValue]);
+EXPECT_EQ(CGRectMake(265, 8, 26, 26), [rectValues[4] CGRectValue]);
+#else
EXPECT_EQ(CGRectMake(165, 8, 26, 25), [rectValues[0] CGRectValue]);
EXPECT_EQ(CGRectMake(190, 8, 26, 25), [rectValues[1] CGRectValue]);
EXPECT_EQ(CGRectMake(215, 8, 26, 25), [rectValues[2] CGRectValue]);
EXPECT_EQ(CGRectMake(240, 8, 26, 25), [rectValues[3] CGRectValue]);
EXPECT_EQ(CGRectMake(265, 8, 26, 25), [rectValues[4] CGRectValue]);
+#endif
}
TEST(DocumentEditingContext, SpatialRequestInTextField)
@@ -456,28 +479,37 @@
EXPECT_NSSTRING_EQ(" over the", context.contextAfter);
auto *textRects = [context textRects];
EXPECT_EQ(18U, textRects.count);
+
+#if PLATFORM(MACCATALYST)
+const size_t yPos = 2;
+const size_t height = 26;
+#else
+const size_t yPos = 3;
+const size_t height = 25;
+#endif
+
if (textRects.count >= 18) {
CGFloat x = 401;
-EXPECT_EQ(CGRectMake(x + 0 * glyphWidth, 3, 25, 25), textRects[0].CGRectValue); // f
-EXPECT_EQ(CGRectMake(x + 1 * glyphWidth, 3, 25, 25), textRects[1].CGRectValue); // o
-EXPECT_EQ(CGRectMake(x + 2 * glyphWidth, 3, 25, 25), textRects[2].CGRectValue); // x
-EXPECT_EQ(CGRectMake(x + 3 * glyphWidth,
[webkit-changes] [256522] trunk/LayoutTests
Title: [256522] trunk/LayoutTests Revision 256522 Author commit-qu...@webkit.org Date 2020-02-13 10:36:40 -0800 (Thu, 13 Feb 2020) Log Message Remove ApplePayBillingAddress.html from TestExpectations after fix for flaky failure https://bugs.webkit.org/show_bug.cgi?id=207704 Patch by Nikos Mouchtaris on 2020-02-13 Reviewed by Wenson Hsieh. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256521 => 256522) --- trunk/LayoutTests/ChangeLog 2020-02-13 18:25:38 UTC (rev 256521) +++ trunk/LayoutTests/ChangeLog 2020-02-13 18:36:40 UTC (rev 256522) @@ -1,3 +1,12 @@ +2020-02-13 Nikos Mouchtaris + +Remove ApplePayBillingAddress.html from TestExpectations after fix for flaky failure +https://bugs.webkit.org/show_bug.cgi?id=207704 + +Reviewed by Wenson Hsieh. + +* platform/mac-wk2/TestExpectations: + 2020-02-13 Jacob Uphoff REGRESSION: [iOS] Layout Test fast/visual-viewport/ios/caret-after-focus-in-fixed.html is a flaky failure Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256521 => 256522) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 18:25:38 UTC (rev 256521) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 18:36:40 UTC (rev 256522) @@ -1012,8 +1012,6 @@ webkit.rog/b/207571 http/tests/IndexedDB/collect-IDB-objects.https.html [ Pass Failure ] -webkit.org/b/207577 http/tests/ssl/applepay/ApplePayBillingAddress.html [ Pass Failure ] - webkit.org/b/207599 webgpu/whlsl/do-while-loop.html [ Pass ImageOnlyFailure ] webkit.org/b/207632 tiled-drawing/scrolling/sticky/sticky-during-rubberband.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256521] trunk/LayoutTests
Title: [256521] trunk/LayoutTests Revision 256521 Author jacob_uph...@apple.com Date 2020-02-13 10:25:38 -0800 (Thu, 13 Feb 2020) Log Message REGRESSION: [iOS] Layout Test fast/visual-viewport/ios/caret-after-focus-in-fixed.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=181821 Unreviewed test gardening * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256520 => 256521) --- trunk/LayoutTests/ChangeLog 2020-02-13 18:10:41 UTC (rev 256520) +++ trunk/LayoutTests/ChangeLog 2020-02-13 18:25:38 UTC (rev 256521) @@ -1,5 +1,14 @@ 2020-02-13 Jacob Uphoff +REGRESSION: [iOS] Layout Test fast/visual-viewport/ios/caret-after-focus-in-fixed.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=181821 + +Unreviewed test gardening + +* platform/ios-wk2/TestExpectations: + +2020-02-13 Jacob Uphoff + Flaky Test: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html https://bugs.webkit.org/show_bug.cgi?id=202003 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256520 => 256521) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-02-13 18:10:41 UTC (rev 256520) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-02-13 18:25:38 UTC (rev 256521) @@ -1225,7 +1225,7 @@ webkit.org/b/181392 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html [ Pass Failure ] -webkit.org/b/181821 fast/visual-viewport/ios/caret-after-focus-in-fixed.html [ Pass Failure ] +webkit.org/b/181821 fast/visual-viewport/ios/caret-after-focus-in-fixed.html [ Pass Failure Timeout ] webkit.org/b/182144 [ Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256520] trunk
Title: [256520] trunk Revision 256520 Author wenson_hs...@apple.com Date 2020-02-13 10:10:41 -0800 (Thu, 13 Feb 2020) Log Message [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor https://bugs.webkit.org/show_bug.cgi?id=207680 Reviewed by Tim Horton. Source/WebKit: Currently, WebPage::updateSelectionWithExtentPoint consults the value of m_selectionAnchor to determine whether it should attempt to modify the current selection using the hit-tested visible position. m_selectionAnchor is only set under WebPage::beginSelectionInDirection, which is only invoked when the user begins a floating cursor gesture. When attempting to perform an out-of-band selection update (i.e. without calling beginSelectionInDirection beforehand), we will end up consulting an arbitrary value for m_selectionAnchor (::Start by default; otherwise, the last value set by beginSelectionInDirection if it was previously called). This means that the selection can often only be extended in one direction (typically forwards) when an API client attempts to use -updateSelectionWithExtentPoint:completionHandler: to extend the current selection. To fix this, make it so that we only respect the selection anchor (m_selectionAnchor) in the case where the user is currently using the floating cursor; otherwise, allow the SPI to expand the selection, such that it contains the visible position for the given location. Test: UIWKInteractionViewProtocol.UpdateSelectionWithExtentPoint * Platform/spi/ios/UIKitSPI.h: * Scripts/webkit/messages.py: * Shared/ios/GestureTypes.h: Add a new flag to tell the web process whether it should limit selection extent updates to the current selection anchor. Also, remove an existing enum type, SelectionHandlePosition, that is unused (since we no longer support block text selection). * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[UITextInteractionAssistant _wk_hasFloatingCursor]): Add a helper method to determine (using the text interaction assistant) whether there's an active floating cursor gesture. In the case where floating cursor is active, the text interaction assistant will be in an active gesture but its UITextInteraction will not, since the gesture recognizer belongs to the keyboard or input view rather than the first responder (in this case, WKContentView). (-[WKContentView updateSelectionWithExtentPoint:completionHandler:]): Only respect the selection anchor if we're in floating cursor mode; otherwise, allow selection updates with an extent point to extend the current selection to include the new position. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::updateSelectionWithExtentPoint): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Plumb the RespectsSelectionAnchor flag over to the web process. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::updateSelectionWithExtentPoint): Tools: Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind the current selection works. * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: (-[TestWKWebView updateSelectionWithExtentPoint:]): * TestWebKitAPI/ios/UIKitSPI.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h trunk/Source/WebKit/Scripts/webkit/messages.py trunk/Source/WebKit/Shared/ios/GestureTypes.h trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h Diff Modified: trunk/Source/WebKit/ChangeLog (256519 => 256520) --- trunk/Source/WebKit/ChangeLog 2020-02-13 18:10:20 UTC (rev 256519) +++ trunk/Source/WebKit/ChangeLog 2020-02-13 18:10:41 UTC (rev 256520) @@ -1,3 +1,58 @@ +2020-02-13 Wenson Hsieh + +[iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor +https://bugs.webkit.org/show_bug.cgi?id=207680 + + +Reviewed by Tim Horton. + +Currently, WebPage::updateSelectionWithExtentPoint consults the value of m_selectionAnchor to determine whether +it should attempt to modify the current selection using the hit-tested visible position. m_selectionAnchor is +only set under WebPage::beginSelectionInDirection, which is only invoked when the user begins a floating cursor +gesture. When attempting to perform an out-of-band selection update (i.e. without calling +beginSelectionInDirection beforehand), we will end up consulting an arbitrary value for m_selectionAnchor +(::Start by default; otherwise,
[webkit-changes] [256519] trunk/LayoutTests
Title: [256519] trunk/LayoutTests Revision 256519 Author jacob_uph...@apple.com Date 2020-02-13 10:10:20 -0800 (Thu, 13 Feb 2020) Log Message Flaky Test: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html https://bugs.webkit.org/show_bug.cgi?id=202003 Unreviewed test gardening * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256518 => 256519) --- trunk/LayoutTests/ChangeLog 2020-02-13 18:06:56 UTC (rev 256518) +++ trunk/LayoutTests/ChangeLog 2020-02-13 18:10:20 UTC (rev 256519) @@ -1,5 +1,14 @@ 2020-02-13 Jacob Uphoff +Flaky Test: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html +https://bugs.webkit.org/show_bug.cgi?id=202003 + +Unreviewed test gardening + +* platform/ios/TestExpectations: + +2020-02-13 Jacob Uphoff + [ iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207705 Modified: trunk/LayoutTests/platform/ios/TestExpectations (256518 => 256519) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 18:06:56 UTC (rev 256518) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 18:10:20 UTC (rev 256519) @@ -3504,4 +3504,6 @@ webkit.org/b/207703 imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html [ Pass Failure ] -webkit.org/b/207705 imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207705 imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html [ Pass Failure ] + +webkit.org/b/202003 imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256518] branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/ StorageAreaImpl.cpp
Title: [256518] branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp
Revision 256518
Author repst...@apple.com
Date 2020-02-13 10:06:56 -0800 (Thu, 13 Feb 2020)
Log Message
Revert "Unreviewed build fix. rdar://problem/59298172"
This reverts commit r256393.
Modified Paths
branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp
Diff
Modified: branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp (256517 => 256518)
--- branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp 2020-02-13 17:56:06 UTC (rev 256517)
+++ branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp 2020-02-13 18:06:56 UTC (rev 256518)
@@ -46,7 +46,7 @@
: m_identifier(Identifier::generate())
, m_storageAreaMap(makeWeakPtr(storageAreaMap))
{
-storageAreaMap->incrementUseCount();
+storageAreaMap.incrementUseCount();
}
StorageAreaImpl::~StorageAreaImpl()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256517] trunk/LayoutTests
Title: [256517] trunk/LayoutTests Revision 256517 Author jacob_uph...@apple.com Date 2020-02-13 09:56:06 -0800 (Thu, 13 Feb 2020) Log Message [ iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207705 Unreviewed test gardening * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256516 => 256517) --- trunk/LayoutTests/ChangeLog 2020-02-13 17:48:51 UTC (rev 256516) +++ trunk/LayoutTests/ChangeLog 2020-02-13 17:56:06 UTC (rev 256517) @@ -1,9 +1,18 @@ 2020-02-13 Jacob Uphoff +[ iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207705 + +Unreviewed test gardening + +* platform/ios/TestExpectations: + +2020-02-13 Jacob Uphoff + [ iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207703 -nreviewed test gardening +Unreviewed test gardening * platform/ios/TestExpectations: Modified: trunk/LayoutTests/platform/ios/TestExpectations (256516 => 256517) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 17:48:51 UTC (rev 256516) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 17:56:06 UTC (rev 256517) @@ -3502,4 +3502,6 @@ webkit.org/b/207702 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes.any.serviceworker.html [ Pass Failure ] -webkit.org/b/207703 imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207703 imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html [ Pass Failure ] + +webkit.org/b/207705 imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256516] trunk/LayoutTests
Title: [256516] trunk/LayoutTests Revision 256516 Author jacob_uph...@apple.com Date 2020-02-13 09:48:51 -0800 (Thu, 13 Feb 2020) Log Message [ iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207703 nreviewed test gardening * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256515 => 256516) --- trunk/LayoutTests/ChangeLog 2020-02-13 17:35:51 UTC (rev 256515) +++ trunk/LayoutTests/ChangeLog 2020-02-13 17:48:51 UTC (rev 256516) @@ -1,5 +1,14 @@ 2020-02-13 Jacob Uphoff +[ iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207703 + +nreviewed test gardening + +* platform/ios/TestExpectations: + +2020-02-13 Jacob Uphoff + [ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes.any.serviceworker.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207702 Modified: trunk/LayoutTests/platform/ios/TestExpectations (256515 => 256516) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 17:35:51 UTC (rev 256515) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 17:48:51 UTC (rev 256516) @@ -3500,4 +3500,6 @@ webkit.org/b/207652 imported/w3c/IndexedDB-private-browsing/idbcursor_delete_objectstore5.html [ Pass Timeout ] -webkit.org/b/207702 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes.any.serviceworker.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207702 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes.any.serviceworker.html [ Pass Failure ] + +webkit.org/b/207703 imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256515] trunk/LayoutTests
Title: [256515] trunk/LayoutTests Revision 256515 Author jacob_uph...@apple.com Date 2020-02-13 09:35:51 -0800 (Thu, 13 Feb 2020) Log Message [ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes.any.serviceworker.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207702 Unreviewed test gardening * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256514 => 256515) --- trunk/LayoutTests/ChangeLog 2020-02-13 17:24:15 UTC (rev 256514) +++ trunk/LayoutTests/ChangeLog 2020-02-13 17:35:51 UTC (rev 256515) @@ -1,3 +1,12 @@ +2020-02-13 Jacob Uphoff + +[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes.any.serviceworker.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207702 + +Unreviewed test gardening + +* platform/ios/TestExpectations: + 2020-02-13 Simon Fraser REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side Modified: trunk/LayoutTests/platform/ios/TestExpectations (256514 => 256515) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 17:24:15 UTC (rev 256514) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-02-13 17:35:51 UTC (rev 256515) @@ -3498,4 +3498,6 @@ webkit.org/b/207651 imported/w3c/IndexedDB-private-browsing/idbcursor_delete_objectstore4.html [ Pass Timeout ] -webkit.org/b/207652 imported/w3c/IndexedDB-private-browsing/idbcursor_delete_objectstore5.html [ Pass Timeout ] \ No newline at end of file +webkit.org/b/207652 imported/w3c/IndexedDB-private-browsing/idbcursor_delete_objectstore5.html [ Pass Timeout ] + +webkit.org/b/207702 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes.any.serviceworker.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256514] trunk/Source/WebCore
Title: [256514] trunk/Source/WebCore
Revision 256514
Author ape...@igalia.com
Date 2020-02-13 09:24:15 -0800 (Thu, 13 Feb 2020)
Log Message
Non-unified build fixes mid February 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=207693
Unreviewed build fix.
No new tests needed.
* html/parser/HTMLPreloadScanner.cpp: Add missing include.
* platform/wpe/ScrollbarThemeWPE.cpp: Ditto.
* rendering/InlineTextBox.cpp: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp
trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp
trunk/Source/WebCore/rendering/InlineTextBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (256513 => 256514)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 17:20:42 UTC (rev 256513)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 17:24:15 UTC (rev 256514)
@@ -1,3 +1,16 @@
+2020-02-13 Adrian Perez de Castro
+
+Non-unified build fixes mid February 2020 edition
+https://bugs.webkit.org/show_bug.cgi?id=207693
+
+Unreviewed build fix.
+
+No new tests needed.
+
+* html/parser/HTMLPreloadScanner.cpp: Add missing include.
+* platform/wpe/ScrollbarThemeWPE.cpp: Ditto.
+* rendering/InlineTextBox.cpp: Ditto.
+
2020-02-13 Simon Fraser
REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side
Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp (256513 => 256514)
--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2020-02-13 17:20:42 UTC (rev 256513)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2020-02-13 17:24:15 UTC (rev 256514)
@@ -43,6 +43,7 @@
#include "RenderView.h"
#include "RuntimeEnabledFeatures.h"
#include "SecurityPolicy.h"
+#include "Settings.h"
#include "SizesAttributeParser.h"
#include
Modified: trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp (256513 => 256514)
--- trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp 2020-02-13 17:20:42 UTC (rev 256513)
+++ trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp 2020-02-13 17:24:15 UTC (rev 256514)
@@ -30,6 +30,7 @@
#include "FloatRoundedRect.h"
#include "GraphicsContext.h"
#include "PlatformMouseEvent.h"
+#include "ScrollableArea.h"
#include "Scrollbar.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (256513 => 256514)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2020-02-13 17:20:42 UTC (rev 256513)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2020-02-13 17:24:15 UTC (rev 256514)
@@ -32,6 +32,7 @@
#include "ElementRuleCollector.h"
#include "EllipsisBox.h"
#include "EventRegion.h"
+#include "FloatRoundedRect.h"
#include "Frame.h"
#include "GraphicsContext.h"
#include "HighlightData.h"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256513] trunk
Title: [256513] trunk
Revision 256513
Author simon.fra...@apple.com
Date 2020-02-13 09:20:42 -0800 (Thu, 13 Feb 2020)
Log Message
REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side
https://bugs.webkit.org/show_bug.cgi?id=207674
rdar://problem/59404866
Reviewed by Antti Koivisto.
Source/WebCore:
Remove the early return in ScrollingStateScrollingNode::setRequestedScrollData(); comparing
with the last m_requestedScrollData is wrong, because requested scroll positions are not "state"
in the scrolling tree, they are requests to scroll. Ideally, they would be represented in some
different way in the scrolling tree.
Test: fast/scrolling/programmatic-scroll-to-zero-zero.html
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::setRequestedScrollData):
LayoutTests:
Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0,
which is expected to work.
* fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added.
* fast/scrolling/programmatic-scroll-to-zero-zero.html: Added.
* platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp
Added Paths
trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html
trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html
Diff
Modified: trunk/LayoutTests/ChangeLog (256512 => 256513)
--- trunk/LayoutTests/ChangeLog 2020-02-13 17:11:28 UTC (rev 256512)
+++ trunk/LayoutTests/ChangeLog 2020-02-13 17:20:42 UTC (rev 256513)
@@ -1,3 +1,18 @@
+2020-02-13 Simon Fraser
+
+REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side
+https://bugs.webkit.org/show_bug.cgi?id=207674
+rdar://problem/59404866
+
+Reviewed by Antti Koivisto.
+
+Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0,
+which is expected to work.
+
+* fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added.
+* fast/scrolling/programmatic-scroll-to-zero-zero.html: Added.
+* platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping.
+
2020-02-13 Said Abou-Hallawa
Unreviewed, rolling out r255158, 255405 and r255486
Added: trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html (0 => 256513)
--- trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html 2020-02-13 17:20:42 UTC (rev 256513)
@@ -0,0 +1,21 @@
+
+
+
+The page should scroll back to the top
+
+body {
+height: 2000px;
+background-image: repeating-linear-gradient(white, silver 200px);
+}
+
+.box {
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+
+
+
+
+
Added: trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html (0 => 256513)
--- trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html 2020-02-13 17:20:42 UTC (rev 256513)
@@ -0,0 +1,46 @@
+
+
+
+The page should scroll back to the top
+
+body {
+height: 2000px;
+background-image: repeating-linear-gradient(white, silver 200px);
+}
+
+.box {
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+
+ if (window.testRunner)
+testRunner.waitUntilDone();
+
+ function doTest()
+{
+document.scrollingElement.scrollTop = 20;
+document.scrollingElement.scrollTop = 0;
+
+eventSender.monitorWheelEvents();
+
+setTimeout(() => {
+eventSender.mouseMoveTo(20, 20);
+eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, "began", "none");
+eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -10, "changed", "none");
+eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, "ended", "none");
+eventSender.callAfterScrollingCompletes(() => {
+document.scrollingElement.scrollTop = 0;
+testRunner.notifyDone();
+});
+}, 0);
+}
+
+window.addEventListener('load', doTest, false);
+
+
+
+
+
+
Modified:
[webkit-changes] [256512] trunk
Title: [256512] trunk Revision 256512 Author s...@apple.com Date 2020-02-13 09:11:28 -0800 (Thu, 13 Feb 2020) Log Message Unreviewed, rolling out r255158, 255405 and r255486 Caused test flakiness and PLT regression. Patch by Said Abou-Hallawa on 2020-02-13 Source/WebCore: * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: * animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::updateThrottlingState): (WebCore::DocumentTimeline::animationInterval const): * animation/DocumentTimeline.h: * dom/Document.cpp: (WebCore::Document::requestAnimationFrame): (WebCore::Document::updateLastHandledUserGestureTimestamp): * dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::throttlingReasonToString): (WebCore::throttlingReasonsToString): (WebCore::ScriptedAnimationController::addThrottlingReason): (WebCore::ScriptedAnimationController::removeThrottlingReason): (WebCore::ScriptedAnimationController::isThrottled const): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceRequestAnimationFrameCallbacks): (WebCore::ScriptedAnimationController::interval const): (WebCore::ScriptedAnimationController::page const): (WebCore::ScriptedAnimationController::scheduleAnimation): (WebCore::ScriptedAnimationController::animationTimerFired): (WebCore::ScriptedAnimationController::preferredScriptedAnimationInterval const): Deleted. (WebCore::ScriptedAnimationController::isThrottledRelativeToPage const): Deleted. (WebCore::ScriptedAnimationController::shouldRescheduleRequestAnimationFrame const): Deleted. * dom/ScriptedAnimationController.h: (WebCore::ScriptedAnimationController::addThrottlingReason): Deleted. (WebCore::ScriptedAnimationController::removeThrottlingReason): Deleted. * page/FrameView.cpp: (WebCore::FrameView::updateScriptedAnimationsAndTimersThrottlingState): * page/Page.cpp: (WebCore::m_deviceOrientationUpdateProvider): (WebCore::Page::isLowPowerModeEnabled const): (WebCore::Page::setLowPowerModeEnabledOverrideForTesting): (WebCore::updateScriptedAnimationsThrottlingReason): (WebCore::Page::setIsVisuallyIdleInternal): (WebCore::Page::handleLowModePowerChange): (WebCore::Page::renderingUpdateThrottlingEnabled const): Deleted. (WebCore::Page::renderingUpdateThrottlingEnabledChanged): Deleted. (WebCore::Page::isRenderingUpdateThrottled const): Deleted. (WebCore::Page::preferredRenderingUpdateInterval const): Deleted. * page/Page.h: (WebCore::Page::isLowPowerModeEnabled const): Deleted. (WebCore::Page::canUpdateThrottlingReason const): Deleted. * page/RenderingUpdateScheduler.cpp: (WebCore::RenderingUpdateScheduler::scheduleTimedRenderingUpdate): (WebCore::RenderingUpdateScheduler::startTimer): (WebCore::RenderingUpdateScheduler::adjustFramesPerSecond): Deleted. (WebCore::RenderingUpdateScheduler::adjustRenderingUpdateFrequency): Deleted. * page/RenderingUpdateScheduler.h: * page/Settings.yaml: * page/SettingsBase.cpp: (WebCore::SettingsBase::renderingUpdateThrottlingEnabledChanged): Deleted. * page/SettingsBase.h: * platform/graphics/AnimationFrameRate.h: Removed. * platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::setPreferredFramesPerSecond): Deleted. * platform/graphics/DisplayRefreshMonitorManager.cpp: (WebCore::DisplayRefreshMonitorManager::createMonitorForClient): (WebCore::DisplayRefreshMonitorManager::registerClient): (WebCore::DisplayRefreshMonitorManager::scheduleAnimation): (WebCore::DisplayRefreshMonitorManager::windowScreenDidChange): (WebCore::DisplayRefreshMonitorManager::monitorForClient): Deleted. (WebCore::DisplayRefreshMonitorManager::setPreferredFramesPerSecond): Deleted. * platform/graphics/DisplayRefreshMonitorManager.h: (WebCore::DisplayRefreshMonitorManager::DisplayRefreshMonitorManager): * platform/graphics/GraphicsLayerUpdater.cpp: (WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater): * platform/graphics/ios/DisplayRefreshMonitorIOS.mm: (-[WebDisplayLinkHandler setPreferredFramesPerSecond:]): Deleted. Source/WebKit: * Shared/WebPreferences.yaml: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetRenderingUpdateThrottlingEnabled): Deleted. (WKPreferencesGetRenderingUpdateThrottlingEnabled): Deleted. * UIProcess/API/C/WKPreferencesRefPrivate.h: * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h: * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in: * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (-[WKOneShotDisplayLinkHandler setPreferredFramesPerSecond:]): Deleted. (WebKit::RemoteLayerTreeDrawingAreaProxy::setPreferredFramesPerSecond): Deleted. * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h: * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm: (WebKit::RemoteLayerTreeDisplayRefreshMonitor::setPreferredFramesPerSecond): Deleted. *
[webkit-changes] [256511] trunk/LayoutTests
Title: [256511] trunk/LayoutTests Revision 256511 Author jacob_uph...@apple.com Date 2020-02-13 09:08:46 -0800 (Thu, 13 Feb 2020) Log Message [ macOS wk2 ] webgpu/whlsl/return-local-variable.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207700 Unreviewed test gardening * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256510 => 256511) --- trunk/LayoutTests/ChangeLog 2020-02-13 16:40:18 UTC (rev 256510) +++ trunk/LayoutTests/ChangeLog 2020-02-13 17:08:46 UTC (rev 256511) @@ -1,5 +1,14 @@ 2020-02-13 Jacob Uphoff +[ macOS wk2 ] webgpu/whlsl/return-local-variable.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207700 + +Unreviewed test gardening + +* platform/mac-wk2/TestExpectations: + +2020-02-13 Jacob Uphoff + REGRESSION: [ Mac WK2 ] inspector/canvas/updateShader-webgpu-sharedVertexFragment.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=206852 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256510 => 256511) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 16:40:18 UTC (rev 256510) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 17:08:46 UTC (rev 256511) @@ -1030,4 +1030,6 @@ webkit.org/b/207688 fast/dom/attr_dead_doc.html [ Pass Failure ] -webkit.org/b/206852 inspector/canvas/updateShader-webgpu-sharedVertexFragment.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/206852 inspector/canvas/updateShader-webgpu-sharedVertexFragment.html [ Pass Failure ] + +webkit.org/b/207700 webgpu/whlsl/return-local-variable.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256510] trunk/LayoutTests
Title: [256510] trunk/LayoutTests Revision 256510 Author jacob_uph...@apple.com Date 2020-02-13 08:40:18 -0800 (Thu, 13 Feb 2020) Log Message REGRESSION: [ Mac WK2 ] inspector/canvas/updateShader-webgpu-sharedVertexFragment.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=206852 Unreviewed test gardening * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256509 => 256510) --- trunk/LayoutTests/ChangeLog 2020-02-13 16:28:28 UTC (rev 256509) +++ trunk/LayoutTests/ChangeLog 2020-02-13 16:40:18 UTC (rev 256510) @@ -1,5 +1,15 @@ 2020-02-13 Jacob Uphoff +REGRESSION: [ Mac WK2 ] inspector/canvas/updateShader-webgpu-sharedVertexFragment.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=206852 + +Unreviewed test gardening + +* platform/mac-wk2/TestExpectations: +* platform/mac/TestExpectations: + +2020-02-13 Jacob Uphoff + http/wpt/css/css-animations/start-animation-001.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207337 Modified: trunk/LayoutTests/platform/mac/TestExpectations (256509 => 256510) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 16:28:28 UTC (rev 256509) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 16:40:18 UTC (rev 256510) @@ -1729,7 +1729,6 @@ webkit.org/b/199275 [ HighSierra ] inspector/canvas/resolveContext-webgpu.html [ Skip ] webkit.org/b/199275 [ HighSierra ] inspector/canvas/shaderProgram-add-remove-webgpu.html [ Skip ] webkit.org/b/199275 [ HighSierra ] inspector/canvas/updateShader-webgpu.html [ Skip ] -webkit.org/b/199275 [ HighSierra ] inspector/canvas/updateShader-webgpu-sharedVertexFragment.html [ Skip ] webkit.org/b/189680 platform/mac/media/audio-session-category-video-paused.html [ Pass Timeout ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256509 => 256510) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 16:28:28 UTC (rev 256509) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-13 16:40:18 UTC (rev 256510) @@ -1028,4 +1028,6 @@ webkit.org/b/207638 webgpu/whlsl/whlsl.html [ Pass ImageOnlyFailure ] -webkit.org/b/207688 fast/dom/attr_dead_doc.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207688 fast/dom/attr_dead_doc.html [ Pass Failure ] + +webkit.org/b/206852 inspector/canvas/updateShader-webgpu-sharedVertexFragment.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256509] trunk/LayoutTests/platform/mac-wk1/TestExpectations
Title: [256509] trunk/LayoutTests/platform/mac-wk1/TestExpectations Revision 256509 Author jacob_uph...@apple.com Date 2020-02-13 08:28:28 -0800 (Thu, 13 Feb 2020) Log Message Need a short description (OOPS!). Need the bug URL (OOPS!). Reviewed by NOBODY (OOPS!). * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256508 => 256509) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-02-13 16:27:43 UTC (rev 256508) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-02-13 16:28:28 UTC (rev 256509) @@ -904,8 +904,6 @@ webkit.org/b/207278 imported/w3c/web-platform-tests/web-animations/timing-model/animations/finishing-an-animation.html [ Pass Failure ] -webkit.org/b/207337 http/wpt/css/css-animations/start-animation-001.html [ Pass ImageOnlyFailure - webkit.org/b/207469 [ Debug ] imported/w3c/web-platform-tests/svg/animations/slider-switch.html [ Pass Failure ] webkit.org/b/207470 [ Debug ] imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256508] trunk/LayoutTests
Title: [256508] trunk/LayoutTests Revision 256508 Author jacob_uph...@apple.com Date 2020-02-13 08:27:43 -0800 (Thu, 13 Feb 2020) Log Message http/wpt/css/css-animations/start-animation-001.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=207337 Correcting test expectations to include wk2 Unreviewed test gardening * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256507 => 256508) --- trunk/LayoutTests/ChangeLog 2020-02-13 16:22:10 UTC (rev 256507) +++ trunk/LayoutTests/ChangeLog 2020-02-13 16:27:43 UTC (rev 256508) @@ -1,5 +1,16 @@ 2020-02-13 Jacob Uphoff +http/wpt/css/css-animations/start-animation-001.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207337 + +Correcting test expectations to include wk2 + +Unreviewed test gardening + +* platform/mac/TestExpectations: + +2020-02-13 Jacob Uphoff + [ macOS ] Layout Test storage/websql/read-transactions-running-concurrently.html is flaky https://bugs.webkit.org/show_bug.cgi?id=194162 Modified: trunk/LayoutTests/platform/mac/TestExpectations (256507 => 256508) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 16:22:10 UTC (rev 256507) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 16:27:43 UTC (rev 256508) @@ -2018,4 +2018,6 @@ webkit.org/b/207642 inspector/runtime/getCollectionEntries.html [ Pass Failure ] -webkit.org/b/194162 storage/websql/read-transactions-running-concurrently.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/194162 storage/websql/read-transactions-running-concurrently.html [ Pass Failure ] + +webkit.org/b/207337 http/wpt/css/css-animations/start-animation-001.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256507] trunk/Source/WebCore
Title: [256507] trunk/Source/WebCore Revision 256507 Author za...@apple.com Date 2020-02-13 08:22:10 -0800 (Thu, 13 Feb 2020) Log Message [LFC][IFC] LineCandidateContent can have only one float item https://bugs.webkit.org/show_bug.cgi?id=207681 Reviewed by Antti Koivisto. Floats should not be considered as inline content. They shrink the available space but we never add them to the line. This patch decouples InlineContent and candidate floats. Also there can only be one float box per candidate content (since there's always a soft wrap opportunity before/after the float box). * layout/inlineformatting/LineLayoutContext.cpp: (WebCore::Layout::LineCandidate::InlineContent::runs const): (WebCore::Layout::LineCandidate::InlineContent::logicalWidth const): (WebCore::Layout::LineCandidate::InlineContent::trailingLineBreak const): (WebCore::Layout::LineCandidate::InlineContent::appendLineBreak): (WebCore::Layout::LineCandidate::InlineContent::setTrailingLineBreak): (WebCore::Layout::LineCandidate::InlineContent::appendInlineItem): (WebCore::Layout::LineCandidate::reset): (WebCore::Layout::LineCandidate::InlineContent::reset): (WebCore::Layout::LineLayoutContext::layoutLine): (WebCore::Layout::LineLayoutContext::nextContentForLine): (WebCore::Layout::LineLayoutContext::tryAddingFloatItem): (WebCore::Layout::LineLayoutContext::tryAddingInlineItems): (WebCore::Layout::LineCandidateContent::appendLineBreak): Deleted. (WebCore::Layout::LineCandidateContent::appendFloat): Deleted. (WebCore::Layout::LineCandidateContent::hasIntrusiveFloats const): Deleted. (WebCore::Layout::LineCandidateContent::inlineRuns const): Deleted. (WebCore::Layout::LineCandidateContent::inlineContentLogicalWidth const): Deleted. (WebCore::Layout::LineCandidateContent::floats const): Deleted. (WebCore::Layout::LineCandidateContent::trailingLineBreak const): Deleted. (WebCore::Layout::LineCandidateContent::setTrailingLineBreak): Deleted. (WebCore::Layout::LineCandidateContent::appendInlineContent): Deleted. (WebCore::Layout::LineCandidateContent::reset): Deleted. (WebCore::Layout::LineLayoutContext::tryAddingFloatItems): Deleted. * layout/inlineformatting/LineLayoutContext.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.h Diff Modified: trunk/Source/WebCore/ChangeLog (256506 => 256507) --- trunk/Source/WebCore/ChangeLog 2020-02-13 16:12:57 UTC (rev 256506) +++ trunk/Source/WebCore/ChangeLog 2020-02-13 16:22:10 UTC (rev 256507) @@ -1,3 +1,41 @@ +2020-02-13 Zalan Bujtas + +[LFC][IFC] LineCandidateContent can have only one float item +https://bugs.webkit.org/show_bug.cgi?id=207681 + + +Reviewed by Antti Koivisto. + +Floats should not be considered as inline content. They shrink the available space but we never +add them to the line. This patch decouples InlineContent and candidate floats. Also there can only be +one float box per candidate content (since there's always a soft wrap opportunity before/after the float box). + +* layout/inlineformatting/LineLayoutContext.cpp: +(WebCore::Layout::LineCandidate::InlineContent::runs const): +(WebCore::Layout::LineCandidate::InlineContent::logicalWidth const): +(WebCore::Layout::LineCandidate::InlineContent::trailingLineBreak const): +(WebCore::Layout::LineCandidate::InlineContent::appendLineBreak): +(WebCore::Layout::LineCandidate::InlineContent::setTrailingLineBreak): +(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem): +(WebCore::Layout::LineCandidate::reset): +(WebCore::Layout::LineCandidate::InlineContent::reset): +(WebCore::Layout::LineLayoutContext::layoutLine): +(WebCore::Layout::LineLayoutContext::nextContentForLine): +(WebCore::Layout::LineLayoutContext::tryAddingFloatItem): +(WebCore::Layout::LineLayoutContext::tryAddingInlineItems): +(WebCore::Layout::LineCandidateContent::appendLineBreak): Deleted. +(WebCore::Layout::LineCandidateContent::appendFloat): Deleted. +(WebCore::Layout::LineCandidateContent::hasIntrusiveFloats const): Deleted. +(WebCore::Layout::LineCandidateContent::inlineRuns const): Deleted. +(WebCore::Layout::LineCandidateContent::inlineContentLogicalWidth const): Deleted. +(WebCore::Layout::LineCandidateContent::floats const): Deleted. +(WebCore::Layout::LineCandidateContent::trailingLineBreak const): Deleted. +(WebCore::Layout::LineCandidateContent::setTrailingLineBreak): Deleted. +(WebCore::Layout::LineCandidateContent::appendInlineContent): Deleted. +(WebCore::Layout::LineCandidateContent::reset): Deleted. +(WebCore::Layout::LineLayoutContext::tryAddingFloatItems): Deleted. +* layout/inlineformatting/LineLayoutContext.h: + 2020-02-13 Chris Lord
[webkit-changes] [256506] trunk/LayoutTests
Title: [256506] trunk/LayoutTests Revision 256506 Author jacob_uph...@apple.com Date 2020-02-13 08:12:57 -0800 (Thu, 13 Feb 2020) Log Message [ macOS ] Layout Test storage/websql/read-transactions-running-concurrently.html is flaky https://bugs.webkit.org/show_bug.cgi?id=194162 Unreviewed test gardening * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256505 => 256506) --- trunk/LayoutTests/ChangeLog 2020-02-13 15:51:50 UTC (rev 256505) +++ trunk/LayoutTests/ChangeLog 2020-02-13 16:12:57 UTC (rev 256506) @@ -1,3 +1,12 @@ +2020-02-13 Jacob Uphoff + +[ macOS ] Layout Test storage/websql/read-transactions-running-concurrently.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=194162 + +Unreviewed test gardening + +* platform/mac/TestExpectations: + 2020-02-13 Chris Lord Implement OffscreenCanvas.copiedImage Modified: trunk/LayoutTests/platform/mac/TestExpectations (256505 => 256506) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 15:51:50 UTC (rev 256505) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-13 16:12:57 UTC (rev 256506) @@ -2016,4 +2016,6 @@ webkit.org/b/207517 [ Debug ] inspector/animation/lifecycle-css-transition.html [ Pass Failure ] -webkit.org/b/207642 inspector/runtime/getCollectionEntries.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207642 inspector/runtime/getCollectionEntries.html [ Pass Failure ] + +webkit.org/b/194162 storage/websql/read-transactions-running-concurrently.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256505] trunk
Title: [256505] trunk Revision 256505 Author commit-qu...@webkit.org Date 2020-02-13 07:51:50 -0800 (Thu, 13 Feb 2020) Log Message Implement OffscreenCanvas.copiedImage https://bugs.webkit.org/show_bug.cgi?id=206220 Patch by Chris Lord on 2020-02-13 Reviewed by Žan Doberšek. Source/WebCore: No new tests. Covered by existing tests. * html/OffscreenCanvas.cpp: (WebCore::OffscreenCanvas::didDraw): (WebCore::OffscreenCanvas::copiedImage const): (WebCore::OffscreenCanvas::clearCopiedImage const): (WebCore::OffscreenCanvas::takeImageBuffer const): (WebCore::OffscreenCanvas::reset): * html/OffscreenCanvas.h: LayoutTests: * platform/gtk/TestExpectations: * platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-flipY-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: * platform/wpe/TestExpectations: * platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-flipY-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-flipY-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt trunk/LayoutTests/platform/wpe/TestExpectations trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-flipY-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/OffscreenCanvas.cpp trunk/Source/WebCore/html/OffscreenCanvas.h Diff Modified: trunk/LayoutTests/ChangeLog (256504 => 256505) --- trunk/LayoutTests/ChangeLog 2020-02-13 11:14:57 UTC (rev 256504) +++ trunk/LayoutTests/ChangeLog 2020-02-13 15:51:50 UTC (rev 256505) @@ -1,3 +1,22 @@ +2020-02-13 Chris Lord + +Implement OffscreenCanvas.copiedImage +https://bugs.webkit.org/show_bug.cgi?id=206220 + +Reviewed by Žan Doberšek. + +* platform/gtk/TestExpectations: +* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-flipY-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: +* platform/wpe/TestExpectations: +* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: +* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-flipY-expected.txt: +* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: +* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: +* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt: + 2020-02-13 Diego Pino Garcia [GTK] Gardening, update TestExpectations and rebaselines Modified: trunk/LayoutTests/platform/gtk/TestExpectations (256504 => 256505) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-13 11:14:57 UTC (rev 256504) +++ trunk/LayoutTests/platform/gtk/TestExpectations
