[webkit-changes] [257767] trunk/Source

[commit-queue]

Title: [257767] trunk/Source








Revision 257767
Author commit-qu...@webkit.org
Date 2020-03-02 23:36:41 -0800 (Mon, 02 Mar 2020)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=208447
Make FrameLoadRequest ctor take move parameter

Patch by Rob Buis  on 2020-03-02
Reviewed by Simon Fraser.

Source/WebCore:

Make FrameLoadRequest ctor use move semantics for the
ResourceRequest parameter to avoid copies.

* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
* inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
* loader/FrameLoadRequest.cpp:
(WebCore::FrameLoadRequest::FrameLoadRequest):
* loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
* loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::scheduleLocationChange):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):

Source/WebKit:

Adapt to API change.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchCreatePage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp
trunk/Source/WebCore/loader/FrameLoadRequest.cpp
trunk/Source/WebCore/loader/FrameLoadRequest.h
trunk/Source/WebCore/loader/NavigationScheduler.cpp
trunk/Source/WebCore/page/ContextMenuController.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257766 => 257767)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 07:29:54 UTC (rev 257766)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 07:36:41 UTC (rev 257767)
@@ -1,3 +1,28 @@
+2020-03-02  Rob Buis  
+
+https://bugs.webkit.org/show_bug.cgi?id=208447
+Make FrameLoadRequest ctor take move parameter
+
+Reviewed by Simon Fraser.
+
+Make FrameLoadRequest ctor use move semantics for the
+ResourceRequest parameter to avoid copies.
+
+* inspector/InspectorFrontendClientLocal.cpp:
+(WebCore::InspectorFrontendClientLocal::openInNewTab):
+* inspector/agents/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::navigate):
+* loader/FrameLoadRequest.cpp:
+(WebCore::FrameLoadRequest::FrameLoadRequest):
+* loader/FrameLoadRequest.h:
+(WebCore::FrameLoadRequest::FrameLoadRequest):
+* loader/NavigationScheduler.cpp:
+(WebCore::NavigationScheduler::scheduleLocationChange):
+* page/ContextMenuController.cpp:
+(WebCore::ContextMenuController::contextMenuItemSelected):
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::createWindow):
+
 2020-03-02  Chris Dumez  
 
 Reduce size of PerformanceResourceTiming


Modified: trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp (257766 => 257767)

--- trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp	2020-03-03 07:29:54 UTC (rev 257766)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp	2020-03-03 07:36:41 UTC (rev 257767)
@@ -266,7 +266,7 @@
 
 // FIXME: Why do we compute the absolute URL with respect to |frame| instead of |mainFrame|?
 ResourceRequest resourceRequest { frame->document()->completeURL(url) };
-FrameLoadRequest frameLoadRequest2 { *mainFrame.document(), mainFrame.document()->securityOrigin(), resourceRequest, "_self"_s, LockHistory::No, LockBackForwardList::No, ReferrerPolicy::EmptyString, AllowNavigationToInvalidURL::Yes, NewFrameOpenerPolicy::Allow, ShouldOpenExternalURLsPolicy::ShouldNotAllow, InitiatedByMainFrame::Unknown };
+FrameLoadRequest frameLoadRequest2 { *mainFrame.document(), mainFrame.document()->securityOrigin(), WTFMove(resourceRequest), "_self"_s, LockHistory::No, LockBackForwardList::No, ReferrerPolicy::EmptyString, AllowNavigationToInvalidURL::Yes, NewFrameOpenerPolicy::Allow, ShouldOpenExternalURLsPolicy::ShouldNotAllow, InitiatedByMainFrame::Unknown };
 frame->loader().changeLocation(WTFMove(frameLoadRequest2));
 }
 


Modified: trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp (257766 => 257767)

--- trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp	2020-03-03 07:29:54 UTC (rev 257766)
+++ trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp	2020-03-03 07:36:41 UTC (rev 257767)
@@ -421,7 +421,7 @@
 Frame& frame = m_inspectedPage.mainFrame();
 
 ResourceRequest resourceRequest { frame.document()->completeURL(url) };
-FrameLoadRequest frameLoadRequest { *frame.document(), frame.document()->securityOrigin(), resourceRequest, "_self"_s, LockHistory::No, LockBackForwardList::No, ReferrerPolicy::EmptyString, AllowNavigationToInvalidURL::No, NewFrameOpenerPolicy::Allow, ShouldOpenExternalURLsPolicy::ShouldNotAllow, 

[webkit-changes] [257766] trunk/Source

[cdumez]

Title: [257766] trunk/Source








Revision 257766
Author cdu...@apple.com
Date 2020-03-02 23:29:54 -0800 (Mon, 02 Mar 2020)


Log Message
Reduce size of PerformanceResourceTiming
https://bugs.webkit.org/show_bug.cgi?id=208466

Reviewed by Ryosuke Niwa.

Reduce size of PerformanceResourceTiming when not storing non-timing data.
To achieve this, I moved the timing data to a
NetworkLoadMetricsWithoutNonTimingData base class, out of NetworkLoadMetrics.
PerformanceResourceTiming's m_networkLoadMetrics data member is now of type
NetworkLoadMetricsWithoutNonTimingData.

* page/PerformanceResourceTiming.cpp:
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
* page/PerformanceResourceTiming.h:
* platform/network/NetworkLoadMetrics.h:
(WebCore::NetworkLoadMetricsWithoutNonTimingData::isComplete const):
(WebCore::NetworkLoadMetricsWithoutNonTimingData::markComplete):
(WebCore::NetworkLoadMetrics::NetworkLoadMetrics):
(WebCore::NetworkLoadMetrics::reset): Deleted.
(WebCore::NetworkLoadMetrics::clearNonTimingData): Deleted.
(WebCore::NetworkLoadMetrics::isComplete const): Deleted.
(WebCore::NetworkLoadMetrics::markComplete): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PerformanceResourceTiming.cpp
trunk/Source/WebCore/page/PerformanceResourceTiming.h
trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257765 => 257766)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 06:41:30 UTC (rev 257765)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 07:29:54 UTC (rev 257766)
@@ -1,3 +1,28 @@
+2020-03-02  Chris Dumez  
+
+Reduce size of PerformanceResourceTiming
+https://bugs.webkit.org/show_bug.cgi?id=208466
+
+Reviewed by Ryosuke Niwa.
+
+Reduce size of PerformanceResourceTiming when not storing non-timing data.
+To achieve this, I moved the timing data to a
+NetworkLoadMetricsWithoutNonTimingData base class, out of NetworkLoadMetrics.
+PerformanceResourceTiming's m_networkLoadMetrics data member is now of type
+NetworkLoadMetricsWithoutNonTimingData.
+
+* page/PerformanceResourceTiming.cpp:
+(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
+* page/PerformanceResourceTiming.h:
+* platform/network/NetworkLoadMetrics.h:
+(WebCore::NetworkLoadMetricsWithoutNonTimingData::isComplete const):
+(WebCore::NetworkLoadMetricsWithoutNonTimingData::markComplete):
+(WebCore::NetworkLoadMetrics::NetworkLoadMetrics):
+(WebCore::NetworkLoadMetrics::reset): Deleted.
+(WebCore::NetworkLoadMetrics::clearNonTimingData): Deleted.
+(WebCore::NetworkLoadMetrics::isComplete const): Deleted.
+(WebCore::NetworkLoadMetrics::markComplete): Deleted.
+
 2020-03-02  Ben Nham  
 
 Add performance probes for HTML parsing


Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.cpp (257765 => 257766)

--- trunk/Source/WebCore/page/PerformanceResourceTiming.cpp	2020-03-03 06:41:30 UTC (rev 257765)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.cpp	2020-03-03 07:29:54 UTC (rev 257766)
@@ -88,7 +88,6 @@
 , m_shouldReportDetails(resourceTiming.allowTimingDetails())
 , m_serverTiming(resourceTiming.populateServerTiming())
 {
-m_networkLoadMetrics.clearNonTimingData();
 }
 
 PerformanceResourceTiming::~PerformanceResourceTiming() = default;


Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.h (257765 => 257766)

--- trunk/Source/WebCore/page/PerformanceResourceTiming.h	2020-03-03 06:41:30 UTC (rev 257765)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.h	2020-03-03 07:29:54 UTC (rev 257766)
@@ -75,7 +75,7 @@
 AtomString m_initiatorType;
 MonotonicTime m_timeOrigin;
 LoadTiming m_loadTiming;
-NetworkLoadMetrics m_networkLoadMetrics;
+NetworkLoadMetricsWithoutNonTimingData m_networkLoadMetrics;
 bool m_shouldReportDetails;
 Vector> m_serverTiming;
 };


Modified: trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h (257765 => 257766)

--- trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h	2020-03-03 06:41:30 UTC (rev 257765)
+++ trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h	2020-03-03 07:29:54 UTC (rev 257766)
@@ -47,12 +47,35 @@
 Unknown,
 };
 
-class NetworkLoadMetrics {
-WTF_MAKE_FAST_ALLOCATED(NetworkLoadMetrics);
+class NetworkLoadMetricsWithoutNonTimingData {
+WTF_MAKE_FAST_ALLOCATED(NetworkLoadMetricsWithoutNonTimingData);
 public:
+NetworkLoadMetricsWithoutNonTimingData() = default;
+
+bool isComplete() const { return complete; }
+void markComplete() { complete = true; }
+
+// These should be treated as deltas to LoadTiming's fetchStart.
+// They should be in ascending order as listed here.
+Seconds domainLookupStart { -1 }; // -1 if no DNS.
+Seconds domainLookupEnd { 

[webkit-changes] [257765] trunk/Source/WebInspectorUI

[drousso]

Title: [257765] trunk/Source/WebInspectorUI








Revision 257765
Author drou...@apple.com
Date 2020-03-02 22:41:30 -0800 (Mon, 02 Mar 2020)


Log Message
Web Inspector: visual artifacts in the corner of selected tabs when docked in dark mode
https://bugs.webkit.org/show_bug.cgi?id=208498

Reviewed by Timothy Hatcher.

* UserInterface/Views/TabBar.css:
(@media (prefers-color-scheme: dark) body:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body.docked .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body.docked:matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
The `background-color` set by `body.docked .tab-bar > .tabs > .item:not(.disabled).selected`
in light mode was also being applied in dark mode. When docked, don't use `background-image`
and instead exclusively use `background-color` so nothing is still applied.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (257764 => 257765)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-03-03 06:05:59 UTC (rev 257764)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-03-03 06:41:30 UTC (rev 257765)
@@ -1,5 +1,21 @@
 2020-03-02  Devin Rousso  
 
+Web Inspector: visual artifacts in the corner of selected tabs when docked in dark mode
+https://bugs.webkit.org/show_bug.cgi?id=208498
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TabBar.css:
+(@media (prefers-color-scheme: dark) body:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
+(@media (prefers-color-scheme: dark) body.docked .tab-bar > .tabs > .item:not(.disabled).selected): Added.
+(@media (prefers-color-scheme: dark) body.docked:matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
+(@media (prefers-color-scheme: dark) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
+The `background-color` set by `body.docked .tab-bar > .tabs > .item:not(.disabled).selected`
+in light mode was also being applied in dark mode. When docked, don't use `background-image`
+and instead exclusively use `background-color` so nothing is still applied.
+
+2020-03-02  Devin Rousso  
+
 Web Inspector: Items in the toolbar take up to much vertical space
 https://bugs.webkit.org/show_bug.cgi?id=204627
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css (257764 => 257765)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2020-03-03 06:05:59 UTC (rev 257764)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2020-03-03 06:41:30 UTC (rev 257765)
@@ -394,7 +394,7 @@
 background-image: linear-gradient(to bottom, hsl(0, 0%, 12%), hsl(0, 0%, 10%));
 }
 
-.tab-bar > .tabs > .item:not(.disabled).selected {
+body:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected {
 background-image: linear-gradient(to bottom, hsl(0, 0%, 23%), hsl(0, 0%, 21%)) !important;
 }
 
@@ -406,6 +406,14 @@
 background-color: hsl(0, 0%, 15%);
 }
 
+body.docked .tab-bar > .tabs > .item:not(.disabled).selected {
+background-color: var(--background-color);
+}
+
+body.docked:matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs > .item:not(.disabled).selected {
+background-color: hsl(0, 0%, 20%);
+}
+
 .tab-bar > .tabs > .item > .icon {
 filter: var(--filter-invert);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257764] trunk/LayoutTests

[zalan]

Title: [257764] trunk/LayoutTests








Revision 257764
Author za...@apple.com
Date 2020-03-02 22:05:59 -0800 (Mon, 02 Mar 2020)


Log Message
[LayoutTests] Transition animations/cross-fade-* tests to non-pixel-tests
https://bugs.webkit.org/show_bug.cgi?id=208495


Reviewed by Simon Fraser.

These tests are designed to be a dumpAsText() tests (their render tree outputs are flaky).

* animations/cross-fade-border-image-source-expected.txt: Added.
* animations/cross-fade-border-image-source.html:
* animations/cross-fade-list-style-image-expected.txt: Added.
* animations/cross-fade-list-style-image.html:
* animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
* animations/cross-fade-webkit-mask-box-image.html:
* animations/cross-fade-webkit-mask-image-expected.txt: Added.
* animations/cross-fade-webkit-mask-image.html:
* platform/gtk/animations/cross-fade-border-image-source-expected.png: Removed.
* platform/gtk/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/gtk/animations/cross-fade-list-style-image-expected.png: Removed.
* platform/gtk/animations/cross-fade-list-style-image-expected.txt: Removed.
* platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.png: Removed.
* platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.txt: Removed.
* platform/gtk/animations/cross-fade-webkit-mask-image-expected.png: Removed.
* platform/gtk/animations/cross-fade-webkit-mask-image-expected.txt: Removed.
* platform/ios/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/ios/animations/cross-fade-list-style-image-expected.txt: Removed.
* platform/ios/animations/cross-fade-webkit-mask-box-image-expected.txt: Removed.
* platform/ios/animations/cross-fade-webkit-mask-image-expected.txt: Removed.
* platform/mac/animations/cross-fade-border-image-source-expected.png: Removed.
* platform/mac/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/mac/animations/cross-fade-list-style-image-expected.png: Removed.
* platform/mac/animations/cross-fade-list-style-image-expected.txt: Removed.
* platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png: Removed.
* platform/mac/animations/cross-fade-webkit-mask-box-image-expected.txt: Removed.
* platform/mac/animations/cross-fade-webkit-mask-image-expected.png: Removed.
* platform/mac/animations/cross-fade-webkit-mask-image-expected.txt: Removed.
* platform/win/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/win/animations/cross-fade-list-style-image-expected.txt: Removed.
* platform/win/animations/cross-fade-webkit-mask-box-image-expected.txt: Removed.
* platform/wincairo/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/wincairo/animations/cross-fade-list-style-image-expected.txt: Removed.
* platform/wincairo/animations/cross-fade-webkit-mask-box-image-expected.txt: Removed.
* platform/wincairo/animations/cross-fade-webkit-mask-image-expected.txt: Removed.
* platform/wpe/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/wpe/animations/cross-fade-list-style-image-expected.txt: Removed.
* platform/wpe/animations/cross-fade-webkit-mask-box-image-expected.txt: Removed.
* platform/wpe/animations/cross-fade-webkit-mask-image-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/cross-fade-border-image-source.html
trunk/LayoutTests/animations/cross-fade-list-style-image.html
trunk/LayoutTests/animations/cross-fade-webkit-mask-box-image.html
trunk/LayoutTests/animations/cross-fade-webkit-mask-image.html


Added Paths

trunk/LayoutTests/animations/cross-fade-border-image-source-expected.txt
trunk/LayoutTests/animations/cross-fade-list-style-image-expected.txt
trunk/LayoutTests/animations/cross-fade-webkit-mask-box-image-expected.txt
trunk/LayoutTests/animations/cross-fade-webkit-mask-image-expected.txt


Removed Paths

trunk/LayoutTests/platform/gtk/animations/cross-fade-border-image-source-expected.png
trunk/LayoutTests/platform/gtk/animations/cross-fade-border-image-source-expected.txt
trunk/LayoutTests/platform/gtk/animations/cross-fade-list-style-image-expected.png
trunk/LayoutTests/platform/gtk/animations/cross-fade-list-style-image-expected.txt
trunk/LayoutTests/platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.png
trunk/LayoutTests/platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.txt
trunk/LayoutTests/platform/gtk/animations/cross-fade-webkit-mask-image-expected.png
trunk/LayoutTests/platform/gtk/animations/cross-fade-webkit-mask-image-expected.txt
trunk/LayoutTests/platform/ios/animations/cross-fade-border-image-source-expected.txt
trunk/LayoutTests/platform/ios/animations/cross-fade-list-style-image-expected.txt
trunk/LayoutTests/platform/ios/animations/cross-fade-webkit-mask-box-image-expected.txt
trunk/LayoutTests/platform/ios/animations/cross-fade-webkit-mask-image-expected.txt

[webkit-changes] [257763] trunk

[nham]

Title: [257763] trunk








Revision 257763
Author n...@apple.com
Date 2020-03-02 21:18:04 -0800 (Mon, 02 Mar 2020)


Log Message
Add performance probes for HTML parsing
https://bugs.webkit.org/show_bug.cgi?id=208271

Reviewed by Daniel Bates.

This adds probes that show which lines of HTML are have been parsed.

Source/WebCore:

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:

Source/WTF:

* wtf/SystemTracing.h:

Tools:

* Tracing/SystemTracePoints.plist:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/SystemTracing.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.h
trunk/Tools/ChangeLog
trunk/Tools/Tracing/SystemTracePoints.plist




Diff

Modified: trunk/Source/WTF/ChangeLog (257762 => 257763)

--- trunk/Source/WTF/ChangeLog	2020-03-03 05:14:21 UTC (rev 257762)
+++ trunk/Source/WTF/ChangeLog	2020-03-03 05:18:04 UTC (rev 257763)
@@ -1,5 +1,16 @@
 2020-03-02  Ben Nham  
 
+Add performance probes for HTML parsing
+https://bugs.webkit.org/show_bug.cgi?id=208271
+
+Reviewed by Daniel Bates.
+
+This adds probes that show which lines of HTML are have been parsed.
+
+* wtf/SystemTracing.h:
+
+2020-03-02  Ben Nham  
+
 [WTF] Add signpost API
 https://bugs.webkit.org/show_bug.cgi?id=208395
 


Modified: trunk/Source/WTF/wtf/SystemTracing.h (257762 => 257763)

--- trunk/Source/WTF/wtf/SystemTracing.h	2020-03-03 05:14:21 UTC (rev 257762)
+++ trunk/Source/WTF/wtf/SystemTracing.h	2020-03-03 05:18:04 UTC (rev 257763)
@@ -86,6 +86,8 @@
 CompositingUpdateEnd,
 DispatchTouchEventsStart,
 DispatchTouchEventsEnd,
+ParseHTMLStart,
+ParseHTMLEnd,
 
 WebKitRange = 1,
 WebHTMLViewPaintStart,


Modified: trunk/Source/WebCore/ChangeLog (257762 => 257763)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 05:14:21 UTC (rev 257762)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 05:18:04 UTC (rev 257763)
@@ -1,3 +1,16 @@
+2020-03-02  Ben Nham  
+
+Add performance probes for HTML parsing
+https://bugs.webkit.org/show_bug.cgi?id=208271
+
+Reviewed by Daniel Bates.
+
+This adds probes that show which lines of HTML are have been parsed.
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::pumpTokenizer):
+* html/parser/HTMLDocumentParser.h:
+
 2020-03-02  Andres Gonzalez  
 
 REGRESSION (257739) [ Mac wk2 Release ] multiple tests crashing in WebCore::postUserInfoForChanges


Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (257762 => 257763)

--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2020-03-03 05:14:21 UTC (rev 257762)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2020-03-03 05:18:04 UTC (rev 257763)
@@ -45,6 +45,8 @@
 #include "ScriptElement.h"
 #include "ThrowOnDynamicMarkupInsertionCountIncrementer.h"
 
+#include 
+
 namespace WebCore {
 
 using namespace HTMLNames;
@@ -51,6 +53,11 @@
 
 DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(HTMLDocumentParser);
 
+static bool isMainDocumentLoadingFromHTTP(const Document& document)
+{
+return !document.ownerElement() && document.url().protocolIsInHTTPFamily();
+}
+
 HTMLDocumentParser::HTMLDocumentParser(HTMLDocument& document)
 : ScriptableDocumentParser(document)
 , m_options(document)
@@ -60,6 +67,7 @@
 , m_parserScheduler(makeUnique(*this))
 , m_xssAuditorDelegate(document)
 , m_preloader(makeUnique(document))
+, m_shouldEmitTracePoints(isMainDocumentLoadingFromHTTP(document))
 {
 }
 
@@ -74,6 +82,7 @@
 , m_tokenizer(m_options)
 , m_treeBuilder(makeUnique(*this, fragment, contextElement, parserContentPolicy(), m_options))
 , m_xssAuditorDelegate(fragment.document())
+, m_shouldEmitTracePoints(false) // Avoid emitting trace points when parsing fragments like outerHTML.
 {
 // https://html.spec.whatwg.org/multipage/syntax.html#parsing-html-fragments
 if (contextElement.isHTMLElement())
@@ -302,7 +311,17 @@
 
 m_xssAuditor.init(document(), _xssAuditorDelegate);
 
+auto emitTracePoint = [this](TracePointCode code) {
+if (!m_shouldEmitTracePoints)
+return;
+
+auto position = textPosition();
+tracePoint(code, position.m_line.oneBasedInt(), position.m_column.oneBasedInt());
+};
+
+emitTracePoint(ParseHTMLStart);
 bool shouldResume = pumpTokenizerLoop(mode, isParsingFragment(), session);
+emitTracePoint(ParseHTMLEnd);
 
 // Ensure we haven't been totally deref'ed after pumping. Any caller of this
 // function should be holding a RefPtr to this to ensure we weren't deleted.


Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.h (257762 => 257763)

--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.h	2020-03-03 05:14:21 UTC (rev 257762)
+++ 

[webkit-changes] [257762] trunk/Source

[nham]

Title: [257762] trunk/Source








Revision 257762
Author n...@apple.com
Date 2020-03-02 21:14:21 -0800 (Mon, 02 Mar 2020)


Log Message
[WTF] Add signpost API
https://bugs.webkit.org/show_bug.cgi?id=208395

Reviewed by Alex Christensen.

We want to start using os_signpost instead of kdebug_trace when emitting performance events,
because it is usually cheaper (doesn't require a system call unless the log buffer is full)
and allows for richer tracepoints (allows for logging strings as well as integers).

To facilitate this, this moves the os_signpost wrappers in NetworkDataTaskCocoa to
WTF. Since signposts can contain sensitive strings (like URLs), currently we only enable
them on Apple-internal devices when an environment variable is set.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/PlatformMac.cmake:
* spi/darwin/OSVariantSPI.h: Renamed to wtf/spi/darwin/OSVariantSPI.h.

Source/WebKit:

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::didSendData):
(WebKit::NetworkDataTaskCocoa::didReceiveChallenge):
(WebKit::NetworkDataTaskCocoa::didCompleteWithError):
(WebKit::NetworkDataTaskCocoa::didReceiveData):
(WebKit::NetworkDataTaskCocoa::didReceiveResponse):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
(WebKit::NetworkDataTaskCocoa::cancel):
(WebKit::NetworkDataTaskCocoa::resume):
(signpostLogHandle): Deleted.
(signpostsEnabled): Deleted.

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/PlatformMac.cmake:
* wtf/SystemTracing.h:
* wtf/cocoa/SystemTracingCocoa.cpp: Added.
(WTFSignpostsEnabled):
(WTFSignpostLogHandle):
* wtf/spi/darwin/OSVariantSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/OSVariantSPI.h.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/PlatformMac.cmake
trunk/Source/WTF/wtf/SystemTracing.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/PlatformMac.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm


Added Paths

trunk/Source/WTF/wtf/cocoa/SystemTracingCocoa.cpp
trunk/Source/WTF/wtf/spi/darwin/OSVariantSPI.h


Removed Paths

trunk/Source/WebCore/PAL/pal/spi/cocoa/OSVariantSPI.h




Diff

Modified: trunk/Source/WTF/ChangeLog (257761 => 257762)

--- trunk/Source/WTF/ChangeLog	2020-03-03 04:57:34 UTC (rev 257761)
+++ trunk/Source/WTF/ChangeLog	2020-03-03 05:14:21 UTC (rev 257762)
@@ -1,3 +1,26 @@
+2020-03-02  Ben Nham  
+
+[WTF] Add signpost API
+https://bugs.webkit.org/show_bug.cgi?id=208395
+
+Reviewed by Alex Christensen.
+
+We want to start using os_signpost instead of kdebug_trace when emitting performance events,
+because it is usually cheaper (doesn't require a system call unless the log buffer is full)
+and allows for richer tracepoints (allows for logging strings as well as integers).
+
+To facilitate this, this moves the os_signpost wrappers in NetworkDataTaskCocoa to
+WTF. Since signposts can contain sensitive strings (like URLs), currently we only enable
+them on Apple-internal devices when an environment variable is set.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/PlatformMac.cmake:
+* wtf/SystemTracing.h:
+* wtf/cocoa/SystemTracingCocoa.cpp: Added.
+(WTFSignpostsEnabled):
+(WTFSignpostLogHandle):
+* wtf/spi/darwin/OSVariantSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/OSVariantSPI.h.
+
 2020-03-02  Alan Coon  
 
 Add new Mac target numbers


Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (257761 => 257762)

--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2020-03-03 04:57:34 UTC (rev 257761)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2020-03-03 05:14:21 UTC (rev 257762)
@@ -181,6 +181,7 @@
 		E3A32BC41FC830E2007D7E76 /* JSValueMalloc.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E3A32BC21FC830E2007D7E76 /* JSValueMalloc.cpp */; };
 		E4A0AD391A96245500536DF6 /* WorkQueue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E4A0AD371A96245500536DF6 /* WorkQueue.cpp */; };
 		E4A0AD3D1A96253C00536DF6 /* WorkQueueCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E4A0AD3C1A96253C00536DF6 /* WorkQueueCocoa.cpp */; };
+		EB61EDC72409CCC1001EFE36 /* SystemTracingCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = EB61EDC62409CCC0001EFE36 /* SystemTracingCocoa.cpp */; };
 		FE05FAFF1FE5007500093230 /* WTFAssertions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FE05FAFE1FE5007500093230 /* WTFAssertions.cpp */; };
 		FE1E2C3B2240C06600F6B729 /* PtrTag.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FE1E2C392240C05400F6B729 /* PtrTag.cpp */; };
 		FE1E2C42224187C600F6B729 /* PlatformRegisters.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FE1E2C41224187C600F6B729 /* PlatformRegisters.cpp */; };
@@ -728,7 

[webkit-changes] [257761] trunk/Source/WebCore

[andresg_22]

Title: [257761] trunk/Source/WebCore








Revision 257761
Author andresg...@apple.com
Date 2020-03-02 20:57:34 -0800 (Mon, 02 Mar 2020)


Log Message
REGRESSION (257739) [ Mac wk2 Release ] multiple tests crashing in WebCore::postUserInfoForChanges
https://bugs.webkit.org/show_bug.cgi?id=208488


Reviewed by Chris Fleizach.

Ensure that we have a root web area before de-referencing it.

* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (257760 => 257761)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 04:07:42 UTC (rev 257760)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 04:57:34 UTC (rev 257761)
@@ -1,5 +1,19 @@
 2020-03-02  Andres Gonzalez  
 
+REGRESSION (257739) [ Mac wk2 Release ] multiple tests crashing in WebCore::postUserInfoForChanges
+https://bugs.webkit.org/show_bug.cgi?id=208488
+
+
+Reviewed by Chris Fleizach.
+
+Ensure that we have a root web area before de-referencing it.
+
+* accessibility/mac/AXObjectCacheMac.mm:
+(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
+(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):
+
+2020-03-02  Andres Gonzalez  
+
 Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html in IsolatedTree mode.
 https://bugs.webkit.org/show_bug.cgi?id=208462
 


Modified: trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (257760 => 257761)

--- trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm	2020-03-03 04:07:42 UTC (rev 257760)
+++ trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm	2020-03-03 04:57:34 UTC (rev 257761)
@@ -490,7 +490,9 @@
 [changes addObject:change];
 if (NSDictionary *change = textReplacementChangeDictionary(*object, insertionType, insertedText, position))
 [changes addObject:change];
-postUserInfoForChanges(*rootWebArea(), *object, changes);
+
+if (auto* root = rootWebArea())
+postUserInfoForChanges(*root, *object, changes);
 [changes release];
 }
 
@@ -507,7 +509,9 @@
 [changes addObject:change];
 if (NSDictionary *change = textReplacementChangeDictionary(*object, AXTextEditTypeInsert, insertedText, textControl))
 [changes addObject:change];
-postUserInfoForChanges(*rootWebArea(), *object, changes);
+
+if (auto* root = rootWebArea())
+postUserInfoForChanges(*root, *object, changes);
 [changes release];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257760] trunk/Source/WebCore

[andresg_22]

Title: [257760] trunk/Source/WebCore








Revision 257760
Author andresg...@apple.com
Date 2020-03-02 20:07:42 -0800 (Mon, 02 Mar 2020)


Log Message
Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html in IsolatedTree mode.
https://bugs.webkit.org/show_bug.cgi?id=208462

Reviewed by Chris Fleizach.

Covered by LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html.

- Updates the IsolatedTree on the TextStateChange notification.
- Renamed isAccessibilityScrollView to isAccessibilityScrollViewInstance
and used isScrollView instead everywhere it's appropriate. This makes
code like AXObjectCache::rootWebArea work for both AXObjects and IsolatedObjects.
- Moved several utility functions from WebAccessibilityObjectWrapperMac.mm
to AXObjectCacheMac.mm where they belong, so that they can be used by
AXObjectCache implementation in addition to by the wrapper.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::rootWebArea):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isOnScreen const):
(WebCore::AccessibilityObject::scrollToGlobalPoint const):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityObjectInterface.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable const):
* accessibility/AccessibilityScrollView.h:
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::isAccessibilityScrollViewInstance const):
(WebCore::AXIsolatedObject::isAccessibilityScrollView const): Renamed.
* accessibility/isolatedtree/AXIsolatedObject.h:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postTextStateChangePlatformNotification): Uses
TextMarker utilities instead of calling into the wrapper. This fixes
the crash caused by the wrapper updating the backingObject that in turn
may change the wrapper.
(WebCore::AXTextMarkerRange): Moved from WebAccessibilityObjectWrapperMac.mm.
(WebCore::textMarkerRangeFromMarkers): Moved from WebAccessibilityObjectWrapperMac.mm.
(WebCore::textMarkerForVisiblePosition): Moved from WebAccessibilityObjectWrapperMac.mm.
(WebCore::textMarkerRangeFromVisiblePositions): Moved from WebAccessibilityObjectWrapperMac.mm.
* accessibility/mac/WebAccessibilityObjectWrapperMac.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXTextMarkerRange): Moved.
(textMarkerForVisiblePosition): Moved.
(textMarkerRangeFromMarkers): Moved.
(textMarkerRangeFromVisiblePositions): Moved.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityScrollView.h
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (257759 => 257760)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 03:22:01 UTC (rev 257759)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 04:07:42 UTC (rev 257760)
@@ -1,3 +1,53 @@
+2020-03-02  Andres Gonzalez  
+
+Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html in IsolatedTree mode.
+https://bugs.webkit.org/show_bug.cgi?id=208462
+
+Reviewed by Chris Fleizach.
+
+Covered by LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html.
+
+- Updates the IsolatedTree on the TextStateChange notification.
+- Renamed isAccessibilityScrollView to isAccessibilityScrollViewInstance
+and used isScrollView instead everywhere it's appropriate. This makes
+code like AXObjectCache::rootWebArea work for both AXObjects and IsolatedObjects.
+- Moved several utility functions from WebAccessibilityObjectWrapperMac.mm
+to AXObjectCacheMac.mm where they belong, so that they can be used by
+AXObjectCache implementation in addition to by the wrapper.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::postTextStateChangeNotification):
+(WebCore::AXObjectCache::rootWebArea):
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::isOnScreen const):
+

[webkit-changes] [257758] trunk/Source/WebKit

[bfulgham]

Title: [257758] trunk/Source/WebKit








Revision 257758
Author bfulg...@apple.com
Date 2020-03-02 19:11:06 -0800 (Mon, 02 Mar 2020)


Log Message
Add flag to indicate that ITP state was explicitly set
https://bugs.webkit.org/show_bug.cgi?id=208461


Reviewed by John Wilander.

Now that ITP is supported in Ephemeral sessions, we would like to move to a process-wide
concept of ITP being on or off, rather than controlling this at a website data level.
This patch takes the first step by adding a flag to the WebKit::NetworkSessionCreationParameters
structure that tracks whether the state of ITP (On or Off) was explicitly set by
SPI (primarily during testing).

This patch also ensures that we can communicate with TCC for the purpose of checking if
ITP is on or off.

* NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
* NetworkProcess/NetworkSessionCreationParameters.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Scripts/process-entitlements.sh:
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetResourceLoadStatisticsEnabled):
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _setResourceLoadStatisticsEnabled:]):
* UIProcess/Cocoa/VersionChecks.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):
* UIProcess/WebProcessPool.h:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setIsRunningResourceLoadStatisticsTest):
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::itpStateWasExplicitlySet const):
(WebKit::WebsiteDataStore::useExplicitITPState):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
trunk/Source/WebKit/Scripts/process-entitlements.sh
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
trunk/Source/WebKit/UIProcess/Cocoa/VersionChecks.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (257757 => 257758)

--- trunk/Source/WebKit/ChangeLog	2020-03-03 03:03:47 UTC (rev 257757)
+++ trunk/Source/WebKit/ChangeLog	2020-03-03 03:11:06 UTC (rev 257758)
@@ -1,3 +1,47 @@
+2020-03-02  Brent Fulgham  
+
+Add flag to indicate that ITP state was explicitly set
+https://bugs.webkit.org/show_bug.cgi?id=208461
+
+
+Reviewed by John Wilander.
+
+Now that ITP is supported in Ephemeral sessions, we would like to move to a process-wide
+concept of ITP being on or off, rather than controlling this at a website data level.
+This patch takes the first step by adding a flag to the WebKit::NetworkSessionCreationParameters
+structure that tracks whether the state of ITP (On or Off) was explicitly set by
+SPI (primarily during testing).
+
+This patch also ensures that we can communicate with TCC for the purpose of checking if
+ITP is on or off.
+
+* NetworkProcess/NetworkSessionCreationParameters.cpp:
+(WebKit::NetworkSessionCreationParameters::encode const):
+(WebKit::NetworkSessionCreationParameters::decode):
+* NetworkProcess/NetworkSessionCreationParameters.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+* Scripts/process-entitlements.sh:
+* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
+(WKWebsiteDataStoreSetResourceLoadStatisticsEnabled):
+* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
+(-[WKWebsiteDataStore _setResourceLoadStatisticsEnabled:]):
+* UIProcess/Cocoa/VersionChecks.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::WebProcessPool):
+(WebKit::WebProcessPool::ensureNetworkProcess):
+

[webkit-changes] [257756] trunk/Source/WebCore

[drousso]

Title: [257756] trunk/Source/WebCore








Revision 257756
Author drou...@apple.com
Date 2020-03-02 18:59:29 -0800 (Mon, 02 Mar 2020)


Log Message
Remove the required `LockHolder` when calling `WebAnimation::instances()`
https://bugs.webkit.org/show_bug.cgi?id=208493

Reviewed by Simon Fraser.

Since `WebAnimation`s are not accessible from `Worker`s (e.g. main thread only), there's no
reason to require that a lock be held in order to access `WebAnimation::instances()`.

* animation/WebAnimation.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::WebAnimation):
(WebCore::WebAnimation::~WebAnimation):
(WebCore::WebAnimation::instancesMutex): Deleted.

* inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::enable):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/WebAnimation.cpp
trunk/Source/WebCore/animation/WebAnimation.h
trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257755 => 257756)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 02:49:55 UTC (rev 257755)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 02:59:29 UTC (rev 257756)
@@ -1,3 +1,22 @@
+2020-03-02  Devin Rousso  
+
+Remove the required `LockHolder` when calling `WebAnimation::instances()`
+https://bugs.webkit.org/show_bug.cgi?id=208493
+
+Reviewed by Simon Fraser.
+
+Since `WebAnimation`s are not accessible from `Worker`s (e.g. main thread only), there's no
+reason to require that a lock be held in order to access `WebAnimation::instances()`.
+
+* animation/WebAnimation.h:
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::WebAnimation):
+(WebCore::WebAnimation::~WebAnimation):
+(WebCore::WebAnimation::instancesMutex): Deleted.
+
+* inspector/agents/InspectorAnimationAgent.cpp:
+(WebCore::InspectorAnimationAgent::enable):
+
 2020-03-02  Alan Coon  
 
 Add new Mac target numbers


Modified: trunk/Source/WebCore/animation/WebAnimation.cpp (257755 => 257756)

--- trunk/Source/WebCore/animation/WebAnimation.cpp	2020-03-03 02:49:55 UTC (rev 257755)
+++ trunk/Source/WebCore/animation/WebAnimation.cpp	2020-03-03 02:59:29 UTC (rev 257756)
@@ -45,7 +45,6 @@
 #include "StyledElement.h"
 #include "WebAnimationUtilities.h"
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -55,22 +54,12 @@
 
 WTF_MAKE_ISO_ALLOCATED_IMPL(WebAnimation);
 
-HashSet& WebAnimation::instances(const LockHolder&)
+HashSet& WebAnimation::instances()
 {
 static NeverDestroyed> instances;
 return instances;
 }
 
-Lock& WebAnimation::instancesMutex()
-{
-static LazyNeverDestroyed mutex;
-static std::once_flag initializeMutex;
-std::call_once(initializeMutex, [] {
-mutex.construct();
-});
-return mutex.get();
-}
-
 Ref WebAnimation::create(Document& document, AnimationEffect* effect)
 {
 auto result = adoptRef(*new WebAnimation(document));
@@ -102,8 +91,7 @@
 m_readyPromise->resolve(*this);
 suspendIfNeeded();
 
-LockHolder lock(instancesMutex());
-instances(lock).add(this);
+instances().add(this);
 }
 
 WebAnimation::~WebAnimation()
@@ -113,9 +101,8 @@
 if (m_timeline)
 m_timeline->forgetAnimation(this);
 
-LockHolder lock(instancesMutex());
-ASSERT(instances(lock).contains(this));
-instances(lock).remove(this);
+ASSERT(instances().contains(this));
+instances().remove(this);
 }
 
 void WebAnimation::contextDestroyed()


Modified: trunk/Source/WebCore/animation/WebAnimation.h (257755 => 257756)

--- trunk/Source/WebCore/animation/WebAnimation.h	2020-03-03 02:49:55 UTC (rev 257755)
+++ trunk/Source/WebCore/animation/WebAnimation.h	2020-03-03 02:59:29 UTC (rev 257756)
@@ -57,8 +57,7 @@
 static Ref create(Document&, AnimationEffect*, AnimationTimeline*);
 ~WebAnimation();
 
-static HashSet& instances(const LockHolder&);
-static Lock& instancesMutex();
+static HashSet& instances();
 
 virtual bool isDeclarativeAnimation() const { return false; }
 virtual bool isCSSAnimation() const { return false; }


Modified: trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp (257755 => 257756)

--- trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp	2020-03-03 02:49:55 UTC (rev 257755)
+++ trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp	2020-03-03 02:59:29 UTC (rev 257756)
@@ -263,8 +263,7 @@
 };
 
 {
-LockHolder lock(WebAnimation::instancesMutex());
-for (auto* animation : WebAnimation::instances(lock)) {
+for (auto* animation : WebAnimation::instances()) {
 if (existsInCurrentPage(animation->scriptExecutionContext()))
 bindAnimation(*animation, false);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257755] trunk

[alancoon]

Title: [257755] trunk








Revision 257755
Author alanc...@apple.com
Date 2020-03-02 18:49:55 -0800 (Mon, 02 Mar 2020)


Log Message
Add new Mac target numbers
https://bugs.webkit.org/show_bug.cgi?id=208398

Reviewed by Alexey Proskuryakov.

Source/bmalloc:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:

Source/_javascript_Core:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty/libwebrtc:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore:

No new tests: adding target numbers doesn't necessitate any new testing.

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKit:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:

Modified Paths

trunk/PerformanceTests/MediaTime/Configurations/Base.xcconfig
trunk/PerformanceTests/MediaTime/Configurations/DebugRelease.xcconfig
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/_javascript_Core/Configurations/DebugRelease.xcconfig
trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/_javascript_Core/Configurations/WebKitTargetConditionals.xcconfig
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/WebKitTargetConditionals.xcconfig
trunk/Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/WebKitTargetConditionals.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Configurations/Base.xcconfig
trunk/Source/WTF/Configurations/DebugRelease.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/Base.xcconfig
trunk/Source/WebCore/Configurations/DebugRelease.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/WebKitTargetConditionals.xcconfig
trunk/Source/WebCore/PAL/Configurations/Base.xcconfig
trunk/Source/WebCore/PAL/Configurations/DebugRelease.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/WebKitTargetConditionals.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/Base.xcconfig
trunk/Source/WebKit/Configurations/DebugRelease.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/WebKitTargetConditionals.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/DebugRelease.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/WebKitTargetConditionals.xcconfig
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/Configurations/Base.xcconfig
trunk/Source/bmalloc/Configurations/DebugRelease.xcconfig
trunk/Tools/ContentExtensionTester/Configurations/Base.xcconfig
trunk/Tools/ContentExtensionTester/Configurations/DebugRelease.xcconfig
trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
trunk/Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig
trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig
trunk/Tools/ImageDiff/cg/Configurations/DebugRelease.xcconfig
trunk/Tools/MiniBrowser/Configurations/Base.xcconfig
trunk/Tools/MiniBrowser/Configurations/DebugRelease.xcconfig
trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig
trunk/Tools/TestWebKitAPI/Configurations/DebugRelease.xcconfig
trunk/Tools/TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig
trunk/Tools/WebEditingTester/Configurations/Base.xcconfig
trunk/Tools/WebEditingTester/Configurations/DebugRelease.xcconfig
trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig

[webkit-changes] [257754] trunk

[pvollan]

Title: [257754] trunk








Revision 257754
Author pvol...@apple.com
Date 2020-03-02 18:37:35 -0800 (Mon, 02 Mar 2020)


Log Message
[Cocoa] Mapping from MIME type to UTI type should be done in the UI process
https://bugs.webkit.org/show_bug.cgi?id=208415

Reviewed by Brent Fulgham.

Source/WebCore:

This is currently done in the WebContent process, but since this is using a system service which will be closed,
this mapping should be moved to the UI process. The UI process will create this mapping for a set of mime types,
and send it to the WebContent process.

API test: WebKit.UTIFromMIMEType

* platform/network/mac/UTIUtilities.h:
* platform/network/mac/UTIUtilities.mm:
(WebCore::mapUTIFromMIMEType):
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::cacheUTIFromMimeType):
(WebCore::UTIFromMIMEType):
(WebCore::mimeTypes):
(WebCore::createUTIFromMIMETypeMap):
(WebCore::setUTIFromMIMETypeMap):
* testing/Internals.cpp:
(WebCore::Internals::getUTIFromMIMEType):
* testing/Internals.mm:
(WebCore::Internals::getUTIFromMIMEType):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

Send the mapping between MIME types and UTI types to the WebContent process as part of the Web
process creation parameters.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/UTIUtilities.h
trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/testing/Internals.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (257753 => 257754)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 02:33:23 UTC (rev 257753)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 02:37:35 UTC (rev 257754)
@@ -1,3 +1,32 @@
+2020-03-02  Per Arne Vollan  
+
+[Cocoa] Mapping from MIME type to UTI type should be done in the UI process
+https://bugs.webkit.org/show_bug.cgi?id=208415
+
+Reviewed by Brent Fulgham.
+
+This is currently done in the WebContent process, but since this is using a system service which will be closed,
+this mapping should be moved to the UI process. The UI process will create this mapping for a set of mime types,
+and send it to the WebContent process.
+
+API test: WebKit.UTIFromMIMEType
+
+* platform/network/mac/UTIUtilities.h:
+* platform/network/mac/UTIUtilities.mm:
+(WebCore::mapUTIFromMIMEType):
+(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
+(WebCore::cacheUTIFromMimeType):
+(WebCore::UTIFromMIMEType):
+(WebCore::mimeTypes):
+(WebCore::createUTIFromMIMETypeMap):
+(WebCore::setUTIFromMIMETypeMap):
+* testing/Internals.cpp:
+(WebCore::Internals::getUTIFromMIMEType):
+* testing/Internals.mm:
+(WebCore::Internals::getUTIFromMIMEType):
+* testing/Internals.h:
+* testing/Internals.idl:
+
 2020-03-02  Zalan Bujtas  
 
 Frame::layerTreeAsText should make sure that all the frames are clean and up-to-date


Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.h (257753 => 257754)

--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-03 02:33:23 UTC (rev 257753)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-03 02:37:35 UTC (rev 257754)
@@ -23,17 +23,18 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef UTIUtilities_h
-#define UTIUtilities_h
+#pragma once
 
-#import 
-#import 
+#include 
 
 namespace WebCore {
+
 WEBCORE_EXPORT String MIMETypeFromUTI(const String&);
 String MIMETypeFromUTITree(const String&);
 WEBCORE_EXPORT String UTIFromMIMEType(const String&);
 bool isDeclaredUTI(const String&);
+
+WEBCORE_EXPORT void setUTIFromMIMETypeMap(HashMap&&);
+WEBCORE_EXPORT const HashMap& createUTIFromMIMETypeMap();
+WEBCORE_EXPORT const Vector& mimeTypes();
 }
-
-#endif // UTIUtilities_h


Modified: 

[webkit-changes] [257753] trunk/Source/WebInspectorUI

[jond]

Title: [257753] trunk/Source/WebInspectorUI








Revision 257753
Author j...@apple.com
Date 2020-03-02 18:33:23 -0800 (Mon, 02 Mar 2020)


Log Message
Update the resource override button icon
https://bugs.webkit.org/show_bug.cgi?id=208459

Reviewed by Devin Rousso.

* UserInterface/Images/NavigationItemNetworkOverride.svg:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Images/NavigationItemNetworkOverride.svg




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (257752 => 257753)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-03-03 02:19:13 UTC (rev 257752)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-03-03 02:33:23 UTC (rev 257753)
@@ -1,3 +1,12 @@
+2020-03-02  Jon Davis  
+
+Update the resource override button icon
+https://bugs.webkit.org/show_bug.cgi?id=208459
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Images/NavigationItemNetworkOverride.svg:
+
 2020-02-28  Nikita Vasilyev  
 
 REGRESSION(r257411): Web Inspector: Can't add a breakpoint by pressing the plus button


Modified: trunk/Source/WebInspectorUI/UserInterface/Images/NavigationItemNetworkOverride.svg (257752 => 257753)

--- trunk/Source/WebInspectorUI/UserInterface/Images/NavigationItemNetworkOverride.svg	2020-03-03 02:19:13 UTC (rev 257752)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/NavigationItemNetworkOverride.svg	2020-03-03 02:33:23 UTC (rev 257753)
@@ -1,6 +1,6 @@
-
-
-
-
-
-
+
+
+
+
+
+
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257752] trunk/Source/WebCore

[zalan]

Title: [257752] trunk/Source/WebCore








Revision 257752
Author za...@apple.com
Date 2020-03-02 18:19:13 -0800 (Mon, 02 Mar 2020)


Log Message
Frame::layerTreeAsText should make sure that all the frames are clean and up-to-date
https://bugs.webkit.org/show_bug.cgi?id=208484


Reviewed by Simon Fraser.

window.internals.layerTreeAsText() is designed to dump the layer structure of the current page content.
It calls updateLayout() on the mainframe's document to make sure we collect the layer information on a clear tree.
However Document::updateLayout is scoped to the current document's frame (the mainframe in this case) and
leaves all the other frames dirty.

* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Frame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257751 => 257752)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 01:49:16 UTC (rev 257751)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 02:19:13 UTC (rev 257752)
@@ -1,3 +1,19 @@
+2020-03-02  Zalan Bujtas  
+
+Frame::layerTreeAsText should make sure that all the frames are clean and up-to-date
+https://bugs.webkit.org/show_bug.cgi?id=208484
+
+
+Reviewed by Simon Fraser.
+
+window.internals.layerTreeAsText() is designed to dump the layer structure of the current page content.
+It calls updateLayout() on the mainframe's document to make sure we collect the layer information on a clear tree.
+However Document::updateLayout is scoped to the current document's frame (the mainframe in this case) and
+leaves all the other frames dirty.
+
+* page/Frame.cpp:
+(WebCore::Frame::layerTreeAsText const):
+
 2020-03-02  Daniel Bates  
 
 Annotate editable elements with hit test order


Modified: trunk/Source/WebCore/page/Frame.cpp (257751 => 257752)

--- trunk/Source/WebCore/page/Frame.cpp	2020-03-03 01:49:16 UTC (rev 257751)
+++ trunk/Source/WebCore/page/Frame.cpp	2020-03-03 02:19:13 UTC (rev 257752)
@@ -859,10 +859,12 @@
 
 String Frame::layerTreeAsText(LayerTreeFlags flags) const
 {
-document()->updateLayout();
+if (!m_view)
+return { };
 
+m_view->updateLayoutAndStyleIfNeededRecursive();
 if (!contentRenderer())
-return String();
+return { };
 
 return contentRenderer()->compositor().layerTreeAsText(flags);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257751] trunk/LayoutTests

[lawrence . j]

Title: [257751] trunk/LayoutTests








Revision 257751
Author lawrenc...@apple.com
Date 2020-03-02 17:49:16 -0800 (Mon, 02 Mar 2020)


Log Message
[ iOS wk2 ] http/tests/workers/service/postmessage-after-sw-process-crash.https.html is flaky failing, timing out and crashing.
https://bugs.webkit.org/show_bug.cgi?id=208491

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257750 => 257751)

--- trunk/LayoutTests/ChangeLog	2020-03-03 01:01:51 UTC (rev 257750)
+++ trunk/LayoutTests/ChangeLog	2020-03-03 01:49:16 UTC (rev 257751)
@@ -1,3 +1,12 @@
+2020-03-02  Jason Lawrence  
+
+[ iOS wk2 ] http/tests/workers/service/postmessage-after-sw-process-crash.https.html is flaky failing, timing out and crashing.
+https://bugs.webkit.org/show_bug.cgi?id=208491
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2020-03-02  Saam Barati  
 
 Don't skip tests unnecessarily on arm64


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (257750 => 257751)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-03-03 01:01:51 UTC (rev 257750)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-03-03 01:49:16 UTC (rev 257751)
@@ -1426,4 +1426,6 @@
 
 webkit.org/b/208401 compositing/absolute-inside-out-of-view-fixed.html [ Pass Crash Timeout ]
 
-webkit.org/b/208467 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/208467 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html [ Pass Failure ]
+
+webkit.org/b/208491 http/tests/workers/service/postmessage-after-sw-process-crash.https.html [ Skip ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257750] trunk/Source/WebKit

[pvollan]

Title: [257750] trunk/Source/WebKit








Revision 257750
Author pvol...@apple.com
Date 2020-03-02 17:01:51 -0800 (Mon, 02 Mar 2020)


Log Message
Unreviewed sandbox compile fix.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (257749 => 257750)

--- trunk/Source/WebKit/ChangeLog	2020-03-03 00:59:09 UTC (rev 257749)
+++ trunk/Source/WebKit/ChangeLog	2020-03-03 01:01:51 UTC (rev 257750)
@@ -1,3 +1,9 @@
+2020-03-02  Per Arne Vollan  
+
+Unreviewed sandbox compile fix.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-03-02  Daniel Bates  
 
 Annotate editable elements with hit test order


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (257749 => 257750)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-03-03 00:59:09 UTC (rev 257749)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-03-03 01:01:51 UTC (rev 257750)
@@ -538,7 +538,7 @@
 (global-name "com.apple.logd.events")
 )
 
-(deny mach-lookup (with report) (with telemetry)
+(deny mach-lookup (with telemetry)
 (global-name "com.apple.distributed_notifications@1v3"))
 
 (allow ipc-posix-shm-read*






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257749] trunk/Source

[dbates]

Title: [257749] trunk/Source








Revision 257749
Author dba...@webkit.org
Date 2020-03-02 16:59:09 -0800 (Mon, 02 Mar 2020)


Log Message
Annotate editable elements with hit test order
https://bugs.webkit.org/show_bug.cgi?id=208463


Reviewed by Wenson Hsieh.

Source/WebCore:

Until  is fixed, annotate editable elements with their hit test order
towards fixing .

* dom/ElementContext.h:
(WebCore::ElementContext::encode const):
(WebCore::ElementContext::decode):
Encode and decode the optional hit test order.

Source/WebKit:

Until  is fixed, annotate editable elements with their hit test
order towards fixing . Only element contexts created as a result
of calling WebPage::textInputContextsInRect() have a meaningful hit test order.

Note that the hit test order of an element can only be meaningfully compared to the hit test
order of other elements returned in the same invocation of WebPage::textInputContextsInRect().
That is, the hit test order is not render tree-unique. So, the same element returned by two
different invocations of WebPage::textInputContextsInRect() cannot be compared to any other
element outside of the list it was returned in even if its order is the same in both lists.

* UIProcess/API/Cocoa/_WKTextInputContext.mm:
(-[_WKTextInputContext _hitTestOrder]): Added. If the context does not have a hit test order
(e.g. returned form WebPage::contextForElement()) then I chose to return 0 – treat it as the
frontmost element.
* UIProcess/API/Cocoa/_WKTextInputContextInternal.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::textInputContextsInRect): Assign each element's hit test order. Following
r257722 the elements are already ordered by hit test order (frontmost to backmost). So, we can
simply assign monotonically increasing numbers.
(WebKit::WebPage::contextForElement const): Pass WTF::nullopt for the hit test order as I do
not have a need to support hit test order for individual elements.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementContext.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKTextInputContext.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKTextInputContextInternal.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257748 => 257749)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 00:57:09 UTC (rev 257748)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 00:59:09 UTC (rev 257749)
@@ -1,3 +1,19 @@
+2020-03-02  Daniel Bates  
+
+Annotate editable elements with hit test order
+https://bugs.webkit.org/show_bug.cgi?id=208463
+
+
+Reviewed by Wenson Hsieh.
+
+Until  is fixed, annotate editable elements with their hit test order
+towards fixing .
+
+* dom/ElementContext.h:
+(WebCore::ElementContext::encode const):
+(WebCore::ElementContext::decode):
+Encode and decode the optional hit test order.
+
 2020-03-02  Ross Kirsling  
 
 Unreviewed restabilization of non-unified build.


Modified: trunk/Source/WebCore/dom/ElementContext.h (257748 => 257749)

--- trunk/Source/WebCore/dom/ElementContext.h	2020-03-03 00:57:09 UTC (rev 257748)
+++ trunk/Source/WebCore/dom/ElementContext.h	2020-03-03 00:59:09 UTC (rev 257749)
@@ -35,6 +35,10 @@
 struct ElementContext {
 FloatRect boundingRect;
 
+// Lower ordinal means the element is visually closer to a person's face.
+// FIXME: Remove this once  is fixed.
+Optional hitTestOrder;
+
 PageIdentifier webPageIdentifier;
 DocumentIdentifier documentIdentifier;
 ElementIdentifier elementIdentifier;
@@ -58,6 +62,7 @@
 template
 void ElementContext::encode(Encoder& encoder) const
 {
+encoder << hitTestOrder;
 encoder << boundingRect;
 encoder << webPageIdentifier;
 encoder << documentIdentifier;
@@ -69,6 +74,9 @@
 {
 ElementContext context;
 
+if (!decoder.decode(context.hitTestOrder))
+return WTF::nullopt;
+
 if (!decoder.decode(context.boundingRect))
 return WTF::nullopt;
 


Modified: trunk/Source/WebKit/ChangeLog (257748 => 257749)

--- trunk/Source/WebKit/ChangeLog	2020-03-03 00:57:09 UTC (rev 257748)
+++ trunk/Source/WebKit/ChangeLog	2020-03-03 00:59:09 UTC (rev 257749)
@@ -1,3 +1,33 @@
+2020-03-02  Daniel Bates  
+
+Annotate editable elements with hit test order
+https://bugs.webkit.org/show_bug.cgi?id=208463
+
+
+Reviewed by Wenson Hsieh.
+
+Until  is fixed, annotate editable elements with their hit test
+order towards fixing . Only element contexts created as a result
+of calling WebPage::textInputContextsInRect() have a meaningful hit test order.
+
+Note that the hit test order of an element can only be meaningfully compared to the hit test
+order of other elements returned in the same invocation of WebPage::textInputContextsInRect().
+That is, the hit test order is not render tree-unique. So, the 

[webkit-changes] [257748] trunk/Source/WebCore

[ross . kirsling]

Title: [257748] trunk/Source/WebCore








Revision 257748
Author ross.kirsl...@sony.com
Date 2020-03-02 16:57:09 -0800 (Mon, 02 Mar 2020)


Log Message
Unreviewed restabilization of non-unified build.

* css/parser/CSSSelectorParser.cpp:
* css/parser/CSSSelectorParser.h:
* layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
trunk/Source/WebCore/css/parser/CSSSelectorParser.h
trunk/Source/WebCore/layout/blockformatting/PrecomputedBlockMarginCollapse.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257747 => 257748)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 00:39:24 UTC (rev 257747)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 00:57:09 UTC (rev 257748)
@@ -1,3 +1,11 @@
+2020-03-02  Ross Kirsling  
+
+Unreviewed restabilization of non-unified build.
+
+* css/parser/CSSSelectorParser.cpp:
+* css/parser/CSSSelectorParser.h:
+* layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:
+
 2020-03-02  Said Abou-Hallawa  
 Implement canvas remote rendering
 https://bugs.webkit.org/show_bug.cgi?id=204955


Modified: trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp (257747 => 257748)

--- trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp	2020-03-03 00:39:24 UTC (rev 257747)
+++ trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp	2020-03-03 00:57:09 UTC (rev 257748)
@@ -32,9 +32,11 @@
 
 #include "CSSParserContext.h"
 #include "CSSParserSelector.h"
+#include "CSSParserTokenRange.h"
 #include "CSSSelectorList.h"
 #include "StyleSheetContents.h"
 #include 
+#include 
 
 namespace WebCore {
 


Modified: trunk/Source/WebCore/css/parser/CSSSelectorParser.h (257747 => 257748)

--- trunk/Source/WebCore/css/parser/CSSSelectorParser.h	2020-03-03 00:39:24 UTC (rev 257747)
+++ trunk/Source/WebCore/css/parser/CSSSelectorParser.h	2020-03-03 00:57:09 UTC (rev 257748)
@@ -32,6 +32,7 @@
 namespace WebCore {
 
 class CSSParserTokenRange;
+class CSSSelectorList;
 class StyleSheetContents;
 
 struct CSSParserContext;


Modified: trunk/Source/WebCore/layout/blockformatting/PrecomputedBlockMarginCollapse.cpp (257747 => 257748)

--- trunk/Source/WebCore/layout/blockformatting/PrecomputedBlockMarginCollapse.cpp	2020-03-03 00:39:24 UTC (rev 257747)
+++ trunk/Source/WebCore/layout/blockformatting/PrecomputedBlockMarginCollapse.cpp	2020-03-03 00:57:09 UTC (rev 257748)
@@ -28,8 +28,10 @@
 
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 
+#include "BlockFormattingState.h"
 #include "LayoutBox.h"
 #include "LayoutContainerBox.h"
+#include "LayoutState.h"
 #include "LayoutUnit.h"
 #include "RenderStyle.h"
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257747] trunk/Source

[commit-queue]

Title: [257747] trunk/Source








Revision 257747
Author commit-qu...@webkit.org
Date 2020-03-02 16:39:24 -0800 (Mon, 02 Mar 2020)


Log Message
Implement canvas remote rendering
https://bugs.webkit.org/show_bug.cgi?id=204955

Patch by Said Abou-Hallawa  on 2020-03-02
Reviewed by Jon Lee.

Source/WebCore:

Prepare ConcreteImageBuffer to be created without immediate backend.
RemoteImageBuffer, which is a superclass of ConcreteImageBuffer, will be
created initially without a backend. It will be created when its twin
RemoteImageBufferProxy in the GPUProcess shares its backend.

* platform/graphics/ConcreteImageBuffer.h:
(WebCore::ConcreteImageBuffer::ensureBackendCreated const):
(WebCore::ConcreteImageBuffer::ensureBackend const): Deleted.

Source/WebKit:

* WebProcess/GPU/graphics/RemoteImageBuffer.h:
* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp:
(WebKit::RemoteImageBufferMessageHandler::waitForCreateImageBufferBackend):
(WebKit::RemoteImageBufferMessageHandler::waitForCommitImageBufferFlushContext):
Synchronize the RemoteImageBuffer backend such that the context and the
DrawingContext are flushed to the backend in the GPUProcess only when
its pixels are needed in the WebProcess.

* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h:
(WebKit::RemoteImageBufferMessageHandler::isPendingFlush const):
Tells whether the pixels of the backend is ready to use or a flushing is
being committed.

* WebProcess/GPU/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::waitForCreateImageBufferBackend):
(WebKit::RemoteRenderingBackend::waitForCommitImageBufferFlushContext):
* WebProcess/GPU/graphics/RemoteRenderingBackend.h:
They block execution till certain RemoteRenderingBackendProxy messages
are received.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBuffer.h
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackend.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackend.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (257746 => 257747)

--- trunk/Source/WebCore/ChangeLog	2020-03-03 00:16:02 UTC (rev 257746)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 00:39:24 UTC (rev 257747)
@@ -1,3 +1,18 @@
+2020-03-02  Said Abou-Hallawa  
+Implement canvas remote rendering
+https://bugs.webkit.org/show_bug.cgi?id=204955
+
+Reviewed by Jon Lee.
+
+Prepare ConcreteImageBuffer to be created without immediate backend.
+RemoteImageBuffer, which is a superclass of ConcreteImageBuffer, will be
+created initially without a backend. It will be created when its twin
+RemoteImageBufferProxy in the GPUProcess shares its backend.
+
+* platform/graphics/ConcreteImageBuffer.h:
+(WebCore::ConcreteImageBuffer::ensureBackendCreated const):
+(WebCore::ConcreteImageBuffer::ensureBackend const): Deleted.
+
 2020-03-02  Mark Lam  
 
 ScriptController::executeIfJavaScriptURL() uses wrong JSGlobalObject.


Modified: trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h (257746 => 257747)

--- trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h	2020-03-03 00:16:02 UTC (rev 257746)
+++ trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h	2020-03-03 00:39:24 UTC (rev 257747)
@@ -59,7 +59,7 @@
 
 ConcreteImageBuffer() = default;
 
-virtual BackendType* ensureBackend() const { return m_backend.get(); }
+virtual BackendType* ensureBackendCreated() const { return m_backend.get(); }
 
 GraphicsContext& context() const override
 {
@@ -69,110 +69,186 @@
 
 void flushContext() override
 {
-flushDrawingContext();
-m_backend->flushContext();
+if (auto* backend = ensureBackendCreated()) {
+flushDrawingContext();
+backend->flushContext();
+}
 }
 
-AffineTransform baseTransform() const override { return m_backend->baseTransform(); }
-IntSize logicalSize() const override { return m_backend->logicalSize(); }
-IntSize backendSize() const override { return m_backend->backendSize(); }
-float resolutionScale() const override { return m_backend->resolutionScale(); }
+AffineTransform baseTransform() const override
+{
+if (auto* backend = ensureBackendCreated())
+return backend->baseTransform();
+return { };
+}
 
-size_t memoryCost() const override { return m_backend->memoryCost(); }
-size_t externalMemoryCost() const override { return m_backend->externalMemoryCost(); }
+IntSize logicalSize() const override
+{
+if (auto* backend = ensureBackendCreated())
+return backend->logicalSize();
+return { };
+}
 
+

[webkit-changes] [257746] trunk/Source/WebCore

[mark . lam]

Title: [257746] trunk/Source/WebCore








Revision 257746
Author mark@apple.com
Date 2020-03-02 16:16:02 -0800 (Mon, 02 Mar 2020)


Log Message
ScriptController::executeIfJavaScriptURL() uses wrong JSGlobalObject.
https://bugs.webkit.org/show_bug.cgi?id=208290


Reviewed by Chris Dumez.

The call to executeScriptIgnoringException() may have changed the current global
object of the window.  We should be using the original global object that produced
the result string.

Also added a missing exception check needed after a potential rope resolution.

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257745 => 257746)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 23:58:56 UTC (rev 257745)
+++ trunk/Source/WebCore/ChangeLog	2020-03-03 00:16:02 UTC (rev 257746)
@@ -1,3 +1,20 @@
+2020-03-02  Mark Lam  
+
+ScriptController::executeIfJavaScriptURL() uses wrong JSGlobalObject.
+https://bugs.webkit.org/show_bug.cgi?id=208290
+
+
+Reviewed by Chris Dumez.
+
+The call to executeScriptIgnoringException() may have changed the current global
+object of the window.  We should be using the original global object that produced
+the result string.
+
+Also added a missing exception check needed after a potential rope resolution.
+
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::executeIfJavaScriptURL):
+
 2020-03-02  Jacob Uphoff  
 
 Unreviewed, rolling out r257725.


Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (257745 => 257746)

--- trunk/Source/WebCore/bindings/js/ScriptController.cpp	2020-03-02 23:58:56 UTC (rev 257745)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp	2020-03-03 00:16:02 UTC (rev 257746)
@@ -811,8 +811,13 @@
 
 const int _javascript_SchemeLength = sizeof("_javascript_:") - 1;
 
+JSDOMGlobalObject* globalObject = jsWindowProxy(mainThreadNormalWorld()).window();
+VM& vm = globalObject->vm();
+auto throwScope = DECLARE_THROW_SCOPE(vm);
+
 String decodedURL = decodeURLEscapeSequences(url.string());
 auto result = executeScriptIgnoringException(decodedURL.substring(_javascript_SchemeLength));
+RELEASE_ASSERT( == (mainThreadNormalWorld()).window()->vm());
 
 // If executing script caused this frame to be removed from the page, we
 // don't want to try to replace its document!
@@ -819,8 +824,14 @@
 if (!m_frame.page())
 return true;
 
+if (!result)
+return true;
+
 String scriptResult;
-if (!result || !result.getString(jsWindowProxy(mainThreadNormalWorld()).window(), scriptResult))
+bool isString = result.getString(globalObject, scriptResult);
+RETURN_IF_EXCEPTION(throwScope, true);
+
+if (!isString)
 return true;
 
 // FIXME: We should always replace the document, but doing so






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257745] trunk

[jacob_uphoff]

Title: [257745] trunk








Revision 257745
Author jacob_uph...@apple.com
Date 2020-03-02 15:58:56 -0800 (Mon, 02 Mar 2020)


Log Message
Unreviewed, rolling out r257725.

This commit caused 10 API tests to fail

Reverted changeset:

"[Cocoa] Mapping from MIME type to UTI type should be done in
the UI process"
https://bugs.webkit.org/show_bug.cgi?id=208415
https://trac.webkit.org/changeset/257725

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/UTIUtilities.h
trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/testing/Internals.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Removed Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (257744 => 257745)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 23:56:29 UTC (rev 257744)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 23:58:56 UTC (rev 257745)
@@ -1,3 +1,16 @@
+2020-03-02  Jacob Uphoff  
+
+Unreviewed, rolling out r257725.
+
+This commit caused 10 API tests to fail
+
+Reverted changeset:
+
+"[Cocoa] Mapping from MIME type to UTI type should be done in
+the UI process"
+https://bugs.webkit.org/show_bug.cgi?id=208415
+https://trac.webkit.org/changeset/257725
+
 2020-03-02  Andres Gonzalez  
 
 Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.


Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.h (257744 => 257745)

--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-02 23:56:29 UTC (rev 257744)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-02 23:58:56 UTC (rev 257745)
@@ -23,18 +23,17 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
+#ifndef UTIUtilities_h
+#define UTIUtilities_h
 
-#include 
+#import 
+#import 
 
 namespace WebCore {
-
 WEBCORE_EXPORT String MIMETypeFromUTI(const String&);
 String MIMETypeFromUTITree(const String&);
 WEBCORE_EXPORT String UTIFromMIMEType(const String&);
 bool isDeclaredUTI(const String&);
+}
 
-WEBCORE_EXPORT void setUTIFromMIMETypeMap(HashMap&&);
-WEBCORE_EXPORT const HashMap& createUTIFromMIMETypeMap();
-WEBCORE_EXPORT const Vector& mimeTypes();
-}
+#endif // UTIUtilities_h


Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm (257744 => 257745)

--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm	2020-03-02 23:56:29 UTC (rev 257744)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm	2020-03-02 23:58:56 UTC (rev 257745)
@@ -40,8 +40,6 @@
 #define ADDITIONAL_UTI_MAPPINGS
 #endif
 
-#define EMPTY_MIME_TYPE_STRING "emptyMimeType"_s
-
 namespace WebCore {
 
 String MIMETypeFromUTI(const String& uti)
@@ -115,26 +113,10 @@
 return mapEntry->value;
 }
 
-static Optional>& mapUTIFromMIMEType()
-{
-static NeverDestroyed>> map;
-return map;
-}
-
 struct UTIFromMIMETypeCachePolicy : TinyLRUCachePolicy {
 public:
-static String createValueForKey(const String& mimeType)
+static String createValueForKey(const String& key)
 {
-String key = mimeType;
-if (mapUTIFromMIMEType().hasValue()) {
-if (key.isEmpty())
-key = EMPTY_MIME_TYPE_STRING;
-const auto& it = mapUTIFromMIMEType()->find(key);
-if (it != mapUTIFromMIMEType()->end())
-return it->value;
-WTFLogAlways("UTI for MIME type %s not found.", key.utf8().data());
-ASSERT_NOT_REACHED();
-}
 auto type = adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, key.createCFString().get(), 0));
 if (type)
 return type.get();
@@ -142,16 +124,11 @@
 }
 };
 
-static TinyLRUCache& cacheUTIFromMimeType()
-{
-static NeverDestroyed> cache;
-return cache;
-}
-
 String UTIFromMIMEType(const String& mimeType)
 {
 ASSERT(isMainThread());
-return cacheUTIFromMimeType().get(mimeType);
+static NeverDestroyed> cache;
+return cache.get().get(mimeType);
 }
 
 bool isDeclaredUTI(const String& UTI)
@@ -159,77 +136,4 @@
 return UTTypeIsDeclared(UTI.createCFString().get());
 }
 
-const Vector& mimeTypes()
-{
-static NeverDestroyed> mimeTypes = std::initializer_list {
-"application/ogg"_s,
-"audio/ogg"_s,
-"video/ogg"_s,
-"application/annodex"_s,
-"audio/annodex"_s,
-"video/annodex"_s,
-"audio/speex"_s,
-"video/webm"_s,
-"audio/webm"_s,

[webkit-changes] [257744] tags/Safari-610.1.5.1/

[alancoon]

Title: [257744] tags/Safari-610.1.5.1/








Revision 257744
Author alanc...@apple.com
Date 2020-03-02 15:56:29 -0800 (Mon, 02 Mar 2020)


Log Message
Tag Safari-610.1.5.1.

Added Paths

tags/Safari-610.1.5.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257743] trunk

[sbarati]

Title: [257743] trunk








Revision 257743
Author sbar...@apple.com
Date 2020-03-02 15:53:40 -0800 (Mon, 02 Mar 2020)


Log Message
Don't skip tests unnecessarily on arm64
https://bugs.webkit.org/show_bug.cgi?id=208470


Reviewed by Tadeu Zagallo.

JSTests:

* microbenchmarks/bit-test-constant.js:
* microbenchmarks/bit-test-nonconstant.js:
* microbenchmarks/memcpy-typed-loop-large.js:
* microbenchmarks/memcpy-typed-loop-small.js:
* microbenchmarks/mul-immediate-sub.js:
* stress/dont-range-based-iterate-vector-that-is-mutated.js:
* stress/dont-reserve-huge-capacity-lexer.js:
* stress/new-largeish-contiguous-array-with-size.js:
* stress/sampling-profiler-richards.js:
* typeProfiler/deltablue-for-of.js:
* typeProfiler/getter-richards.js:
* wasm/regress/llint-callee-saves-with-fast-memory.js:

Tools:

* Scripts/run-jsc-stress-tests:

LayoutTests:

* js/script-tests/array-from.js:
* js/script-tests/function-apply-many-args.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/microbenchmarks/bit-test-constant.js
trunk/JSTests/microbenchmarks/bit-test-nonconstant.js
trunk/JSTests/microbenchmarks/memcpy-typed-loop-large.js
trunk/JSTests/microbenchmarks/memcpy-typed-loop-small.js
trunk/JSTests/microbenchmarks/mul-immediate-sub.js
trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js
trunk/JSTests/stress/dont-reserve-huge-capacity-lexer.js
trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js
trunk/JSTests/stress/sampling-profiler-richards.js
trunk/JSTests/typeProfiler/deltablue-for-of.js
trunk/JSTests/typeProfiler/getter-richards.js
trunk/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/array-from.js
trunk/LayoutTests/js/script-tests/function-apply-many-args.js
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/JSTests/ChangeLog (257742 => 257743)

--- trunk/JSTests/ChangeLog	2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/ChangeLog	2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,3 +1,24 @@
+2020-03-02  Saam Barati  
+
+Don't skip tests unnecessarily on arm64
+https://bugs.webkit.org/show_bug.cgi?id=208470
+
+
+Reviewed by Tadeu Zagallo.
+
+* microbenchmarks/bit-test-constant.js:
+* microbenchmarks/bit-test-nonconstant.js:
+* microbenchmarks/memcpy-typed-loop-large.js:
+* microbenchmarks/memcpy-typed-loop-small.js:
+* microbenchmarks/mul-immediate-sub.js:
+* stress/dont-range-based-iterate-vector-that-is-mutated.js:
+* stress/dont-reserve-huge-capacity-lexer.js:
+* stress/new-largeish-contiguous-array-with-size.js:
+* stress/sampling-profiler-richards.js:
+* typeProfiler/deltablue-for-of.js:
+* typeProfiler/getter-richards.js:
+* wasm/regress/llint-callee-saves-with-fast-memory.js:
+
 2020-03-02  Justin Michaud  
 
 Delete by val caching does not keep the subscript alive


Modified: trunk/JSTests/microbenchmarks/bit-test-constant.js (257742 => 257743)

--- trunk/JSTests/microbenchmarks/bit-test-constant.js	2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/bit-test-constant.js	2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
 let glob = 0
 
 function doTest(number) {


Modified: trunk/JSTests/microbenchmarks/bit-test-nonconstant.js (257742 => 257743)

--- trunk/JSTests/microbenchmarks/bit-test-nonconstant.js	2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/bit-test-nonconstant.js	2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
 let glob = 0
 
 function doTest(number, bit) {


Modified: trunk/JSTests/microbenchmarks/memcpy-typed-loop-large.js (257742 => 257743)

--- trunk/JSTests/microbenchmarks/memcpy-typed-loop-large.js	2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/memcpy-typed-loop-large.js	2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and 

[webkit-changes] [257742] branches/safari-610.1.5-branch/Source

[alancoon]

Title: [257742] branches/safari-610.1.5-branch/Source








Revision 257742
Author alanc...@apple.com
Date 2020-03-02 15:42:22 -0800 (Mon, 02 Mar 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.5-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.5-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (257741 => 257742)

--- branches/safari-610.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-02 22:56:38 UTC (rev 257741)
+++ branches/safari-610.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-02 23:42:22 UTC (rev 257742)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (257741 => 257742)

--- branches/safari-610.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-02 22:56:38 UTC (rev 257741)
+++ branches/safari-610.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-02 23:42:22 UTC (rev 257742)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (257741 => 257742)

--- branches/safari-610.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-02 22:56:38 UTC (rev 257741)
+++ branches/safari-610.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-02 23:42:22 UTC (rev 257742)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (257741 => 257742)

--- branches/safari-610.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-02 22:56:38 UTC (rev 257741)
+++ branches/safari-610.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-02 23:42:22 UTC (rev 257742)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (257741 => 257742)

--- branches/safari-610.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-02 22:56:38 UTC (rev 257741)
+++ branches/safari-610.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-02 23:42:22 UTC (rev 257742)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));

[webkit-changes] [257741] trunk/LayoutTests

[lawrence . j]

Title: [257741] trunk/LayoutTests








Revision 257741
Author lawrenc...@apple.com
Date 2020-03-02 14:56:38 -0800 (Mon, 02 Mar 2020)


Log Message
[ Mac wk2 ] is css3/shapes/shape-outside/shape-image/shape-image-025.html flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208476

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257740 => 257741)

--- trunk/LayoutTests/ChangeLog	2020-03-02 22:50:52 UTC (rev 257740)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 22:56:38 UTC (rev 257741)
@@ -1,3 +1,12 @@
+2020-03-02  Jason Lawrence  
+
+[ Mac wk2 ] is css3/shapes/shape-outside/shape-image/shape-image-025.html flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=208476
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2020-03-02  Andres Gonzalez  
 
 Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (257740 => 257741)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 22:50:52 UTC (rev 257740)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 22:56:38 UTC (rev 257741)
@@ -1084,4 +1084,6 @@
 
 webkit.org/b/208394 imported/w3c/web-platform-tests/dom/nodes/Document-characterSet-normalization.html [ Pass Failure ]
 
-webkit.org/b/208471 tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/208471 tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html [ Pass Failure ]
+
+webkit.org/b/208476 css3/shapes/shape-outside/shape-image/shape-image-025.html [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257739] trunk

[andresg_22]

Title: [257739] trunk








Revision 257739
Author andresg...@apple.com
Date 2020-03-02 14:50:30 -0800 (Mon, 02 Mar 2020)


Log Message
Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
https://bugs.webkit.org/show_bug.cgi?id=208434

Reviewed by Chris Fleizach.

Source/WebCore:

Covered by LayoutTests/accessibility/mac/search-text/search-text.html

- Updates IsolatedTree for AXSelectedTextChanged notifications.
- Exposes webAreaObject through the AXCoreObject interface.
- AXIsolatedObject implementation for hasApplePDFAnnotationAttribute,
webAreaObject and stringForRange.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::updateIsolatedTree):
(WebCore::AXObjectCache::rootWebArea):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityObjectInterface.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isLoaded const):
(WebCore::AccessibilityRenderObject::accessKey const):
* accessibility/AccessibilityScrollView.h:
* accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::stringForRange const):
(WebCore::AXIsolatedObject::hasApplePDFAnnotationAttribute const): Deleted.
* accessibility/isolatedtree/AXIsolatedObject.h:
* accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::removeNode):
(WebCore::AXIsolatedTree::applyPendingChanges):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::addTextMarkerFor):
(WebCore::textReplacementChangeDictionary):
(WebCore::postUserInfoForChanges):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapper associatedPluginParent]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
(WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
* WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::accessibleElementById): Same as above.

LayoutTests:

* accessibility/mac/aria-expanded-notifications.html:
With this change, we now get the FocusChanged notification when the
script sets focus to a tree item.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/aria-expanded-notifications.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityScrollView.h
trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (257738 => 257739)

--- trunk/LayoutTests/ChangeLog	2020-03-02 22:26:17 UTC (rev 257738)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 22:50:30 UTC (rev 257739)
@@ -1,3 +1,14 @@
+2020-03-02  Andres Gonzalez  
+
+Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
+https://bugs.webkit.org/show_bug.cgi?id=208434
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/aria-expanded-notifications.html:
+With this change, we now get the FocusChanged notification when the
+script sets focus to a tree item.
+
 2020-03-02  Jason Lawrence  
 
 [ Mac wk2 ] 

[webkit-changes] [257740] trunk/Source

[megan_gardner]

Title: [257740] trunk/Source








Revision 257740
Author megan_gard...@apple.com
Date 2020-03-02 14:50:52 -0800 (Mon, 02 Mar 2020)


Log Message
Add date/time style to macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=208456

Reviewed by Wenson Hsieh.

Source/WebKit:

Add style flag for date/time pickers on macCatalyst.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/forms/WKFormInputControl.mm:
(-[WKDateTimePicker datePickerStyle]):
(-[WKDateTimePicker initWithView:datePickerMode:]):

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/ios/forms/WKFormInputControl.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (257739 => 257740)

--- trunk/Source/WTF/ChangeLog	2020-03-02 22:50:30 UTC (rev 257739)
+++ trunk/Source/WTF/ChangeLog	2020-03-02 22:50:52 UTC (rev 257740)
@@ -1,3 +1,12 @@
+2020-03-02  Megan Gardner  
+
+Add date/time style to macCatalyst
+https://bugs.webkit.org/show_bug.cgi?id=208456
+
+Reviewed by Wenson Hsieh.
+
+* wtf/PlatformHave.h:
+
 2020-03-02  Paulo Matos  
 
 Fix JSC 32bit alignment increase gcc warning


Modified: trunk/Source/WTF/wtf/PlatformHave.h (257739 => 257740)

--- trunk/Source/WTF/wtf/PlatformHave.h	2020-03-02 22:50:30 UTC (rev 257739)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2020-03-02 22:50:52 UTC (rev 257740)
@@ -479,6 +479,7 @@
 #if PLATFORM(MACCATALYST)
 #define HAVE_HOVER_GESTURE_RECOGNIZER 1
 #define HAVE_LOOKUP_GESTURE_RECOGNIZER 1
+#define HAVE_UIDATEPICKER_STYLE 1
 #endif
 
 #if PLATFORM(MACCATALYST)


Modified: trunk/Source/WebKit/ChangeLog (257739 => 257740)

--- trunk/Source/WebKit/ChangeLog	2020-03-02 22:50:30 UTC (rev 257739)
+++ trunk/Source/WebKit/ChangeLog	2020-03-02 22:50:52 UTC (rev 257740)
@@ -1,3 +1,17 @@
+2020-03-02  Megan Gardner  
+
+Add date/time style to macCatalyst
+https://bugs.webkit.org/show_bug.cgi?id=208456
+
+Reviewed by Wenson Hsieh.
+
+Add style flag for date/time pickers on macCatalyst.
+
+* Platform/spi/ios/UIKitSPI.h:
+* UIProcess/ios/forms/WKFormInputControl.mm:
+(-[WKDateTimePicker datePickerStyle]):
+(-[WKDateTimePicker initWithView:datePickerMode:]):
+
 2020-03-02  Said Abou-Hallawa  
 
 Implement the remote ImageBuffer


Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (257739 => 257740)

--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2020-03-02 22:50:30 UTC (rev 257739)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2020-03-02 22:50:52 UTC (rev 257740)
@@ -189,8 +189,17 @@
 UIDatePickerModeYearAndMonth = 4269,
 };
 
+#if HAVE(UIDATEPICKER_STYLE)
+typedef NS_ENUM(NSInteger, UIDatePickerStyle) {
+UIDatePickerStyleAutomatic = 0
+}
+#endif
+
 @interface UIDatePicker ()
 @property (nonatomic, readonly, getter=_contentWidth) CGFloat contentWidth;
+#if HAVE(UIDATEPICKER_STYLE)
+@property (nonatomic, readwrite, assign) UIDatePickerStyle preferredDatePickerStyle;
+#endif
 @end
 
 @interface UIDevice ()


Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormInputControl.mm (257739 => 257740)

--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormInputControl.mm	2020-03-02 22:50:30 UTC (rev 257739)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormInputControl.mm	2020-03-02 22:50:52 UTC (rev 257740)
@@ -68,6 +68,10 @@
 
 @end
 
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#endif
+
 @implementation WKDateTimePicker
 
 static NSString * const kDateFormatString = @"-MM-dd"; // "2011-01-27".
@@ -80,6 +84,13 @@
 return _datePicker.get();
 }
 
+#if !USE(APPLE_INTERNAL_SDK) && HAVE(UIDATEPICKER_STYLE)
+- (UIDatePickerStyle)datePickerStyle
+{
+return UIDatePickerStyleAutomatic;
+}
+#endif
+
 - (id)initWithView:(WKContentView *)view datePickerMode:(UIDatePickerMode)mode
 {
 if (!(self = [super init]))
@@ -109,6 +120,9 @@
 auto size = currentUserInterfaceIdiomIsPad() ? [UIPickerView defaultSizeForCurrentOrientation] : [UIKeyboard defaultSizeForInterfaceOrientation:view.interfaceOrientation];
 
 _datePicker = adoptNS([[UIDatePicker alloc] initWithFrame:CGRectMake(0, 0, size.width, size.height)]);
+#if HAVE(UIDATEPICKER_STYLE)
+[_datePicker setPreferredDatePickerStyle:[self datePickerStyle]];
+#endif
 _datePicker.get().datePickerMode = mode;
 _datePicker.get().hidden = NO;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257738] trunk/LayoutTests

[lawrence . j]

Title: [257738] trunk/LayoutTests








Revision 257738
Author lawrenc...@apple.com
Date 2020-03-02 14:26:17 -0800 (Mon, 02 Mar 2020)


Log Message
[ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208471

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257737 => 257738)

--- trunk/LayoutTests/ChangeLog	2020-03-02 22:03:08 UTC (rev 257737)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 22:26:17 UTC (rev 257738)
@@ -1,5 +1,14 @@
 2020-03-02  Jason Lawrence  
 
+[ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=208471
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2020-03-02  Jason Lawrence  
+
 [ macOS wk2 ] webgpu/whlsl/textures-sample-level.html is flaky failing and crashing
 https://bugs.webkit.org/show_bug.cgi?id=207078
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (257737 => 257738)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 22:03:08 UTC (rev 257737)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 22:26:17 UTC (rev 257738)
@@ -1082,4 +1082,6 @@
 
 webkit.org/b/208396 http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm [ Pass Failure ]
 
-webkit.org/b/208394 imported/w3c/web-platform-tests/dom/nodes/Document-characterSet-normalization.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/208394 imported/w3c/web-platform-tests/dom/nodes/Document-characterSet-normalization.html [ Pass Failure ]
+
+webkit.org/b/208471 tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257736] trunk/LayoutTests

[lawrence . j]

Title: [257736] trunk/LayoutTests








Revision 257736
Author lawrenc...@apple.com
Date 2020-03-02 14:02:57 -0800 (Mon, 02 Mar 2020)


Log Message
[ macOS wk2 ] webgpu/whlsl/textures-sample-level.html is flaky failing and crashing
https://bugs.webkit.org/show_bug.cgi?id=207078

Unreviewed test gardening.

Corrected the expectations, so that they reflect the image failure issue and crashing.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257735 => 257736)

--- trunk/LayoutTests/ChangeLog	2020-03-02 22:02:10 UTC (rev 257735)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 22:02:57 UTC (rev 257736)
@@ -1,5 +1,16 @@
 2020-03-02  Jason Lawrence  
 
+[ macOS wk2 ] webgpu/whlsl/textures-sample-level.html is flaky failing and crashing
+https://bugs.webkit.org/show_bug.cgi?id=207078
+
+Unreviewed test gardening.
+
+Corrected the expectations, so that they reflect the image failure issue and crashing.
+
+* platform/mac-wk2/TestExpectations:
+
+2020-03-02  Jason Lawrence  
+
 [ iOS wk2 Debug and Mac Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html is flaky failing.
 https://bugs.webkit.org/show_bug.cgi?id=208467
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (257735 => 257736)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 22:02:10 UTC (rev 257735)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 22:02:57 UTC (rev 257736)
@@ -948,7 +948,7 @@
 
 webkit.org/b/207063 fast/scrolling/latching/scroll-div-with-nested-nonscrollable-iframe.html [ Pass Failure ]
 
-webkit.org/b/207078 webgpu/whlsl/textures-sample-level.html [ Pass Failure ]
+webkit.org/b/207078 webgpu/whlsl/textures-sample-level.html [ Pass ImageOnlyFailure Crash ]
 
 webkit.org/b/207117 webgpu/whlsl/nested-loop.html [ Pass ImageOnlyFailure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257737] tags/Safari-609.1.20.111.8/

[repstein]

Title: [257737] tags/Safari-609.1.20.111.8/








Revision 257737
Author repst...@apple.com
Date 2020-03-02 14:03:08 -0800 (Mon, 02 Mar 2020)


Log Message
Tag Safari-609.1.20.111.8.

Added Paths

tags/Safari-609.1.20.111.8/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257735] tags/Safari-609.1.20.0.9/

[repstein]

Title: [257735] tags/Safari-609.1.20.0.9/








Revision 257735
Author repst...@apple.com
Date 2020-03-02 14:02:10 -0800 (Mon, 02 Mar 2020)


Log Message
Tag Safari-609.1.20.0.9.

Added Paths

tags/Safari-609.1.20.0.9/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257734] branches/safari-609.1.20.111-branch/Source

[repstein]

Title: [257734] branches/safari-609.1.20.111-branch/Source








Revision 257734
Author repst...@apple.com
Date 2020-03-02 13:55:12 -0800 (Mon, 02 Mar 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig (257733 => 257734)

--- branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
+++ branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-02 21:55:12 UTC (rev 257734)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (257733 => 257734)

--- branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
+++ branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-02 21:55:12 UTC (rev 257734)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (257733 => 257734)

--- branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
+++ branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-02 21:55:12 UTC (rev 257734)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig (257733 => 257734)

--- branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
+++ branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-02 21:55:12 UTC (rev 257734)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (257733 => 257734)

--- branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
+++ branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-02 21:55:12 UTC (rev 257734)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (257733 => 257734)

--- branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
+++ branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-03-02 21:55:12 UTC (rev 257734)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 

[webkit-changes] [257733] branches/safari-609.1.20.0-branch/Source

[repstein]

Title: [257733] branches/safari-609.1.20.0-branch/Source








Revision 257733
Author repst...@apple.com
Date 2020-03-02 13:55:04 -0800 (Mon, 02 Mar 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609.1.20.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609.1.20.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (257732 => 257733)

--- branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-02 21:25:57 UTC (rev 257732)
+++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (257732 => 257733)

--- branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-02 21:25:57 UTC (rev 257732)
+++ branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (257732 => 257733)

--- branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-02 21:25:57 UTC (rev 257732)
+++ branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig (257732 => 257733)

--- branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-02 21:25:57 UTC (rev 257732)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (257732 => 257733)

--- branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-02 21:25:57 UTC (rev 257732)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (257732 => 257733)

--- branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-03-02 21:25:57 UTC (rev 257732)
+++ branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-03-02 21:55:04 UTC (rev 257733)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = 

[webkit-changes] [257732] trunk/Source/WebCore

[wenson_hsieh]

Title: [257732] trunk/Source/WebCore








Revision 257732
Author wenson_hs...@apple.com
Date 2020-03-02 13:25:57 -0800 (Mon, 02 Mar 2020)


Log Message
Make Path::Path(const Path&) and Path::operator=(const Path&) cheap
https://bugs.webkit.org/show_bug.cgi?id=208265


Reviewed by Darin Adler.

Make WebCore::Path's copy constructor and copy assignment operator cheaper. See below for more details; there
should be no observable change in behavior. This gives us approximately 6% back on the canvas lines subtest on
MotionMark, when the GPU process is used to render canvases (tested against macOS 10.15.3, on a 10-core iMac).

* platform/graphics/Path.h:
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::~Path):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::Path):

Update move constructors to set m_copyPathBeforeMutation to false on the given (moved) path.

(WebCore::Path::swap):
(WebCore::Path::initializeOrCopyPlatformPathIfNeeded):

Whenever we need to ensure the platform CGPath (i.e. prior to appending to it), check the new flag to see
whether it's necessary to apply the subsequent mutation on a copy of m_path, rather than m_path itself. The
exception to this is when m_path only has a retain count of 1, which implies that all other copies of this path
have been mutated (and have copied their platform CGPath as a result); this means it's safe to apply changes to
m_path, since this path is now the sole owner of the CGPath.

(WebCore::Path::operator=):

The copy constructor and copy assignment operators currently call CGPathCreateMutableCopy on the given path's
platform CGPath; this is to ensure that if either path is mutated in the future, the mutation won't also affect
the other copy of the WebCore::Path.

However, this call to CGPathCreateMutableCopy isn't needed in the case where a path is copied, but neither of
the paths are mutated. To avoid this extra copy, we can instead introduce a dirty bit (m_copyPathBeforeMutation)
that is set when a path is copied (either via the constructor, or through assignment) and proceed to simply copy
the path pointer to the new path. Only if either path is mutated do we then call CGPathCreateMutableCopy.

(WebCore::Path::transform):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addPath):
(WebCore::Path::clear):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Path.h
trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257731 => 257732)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 21:21:58 UTC (rev 257731)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 21:25:57 UTC (rev 257732)
@@ -1,3 +1,49 @@
+2020-03-02  Wenson Hsieh  
+
+Make Path::Path(const Path&) and Path::operator=(const Path&) cheap
+https://bugs.webkit.org/show_bug.cgi?id=208265
+
+
+Reviewed by Darin Adler.
+
+Make WebCore::Path's copy constructor and copy assignment operator cheaper. See below for more details; there
+should be no observable change in behavior. This gives us approximately 6% back on the canvas lines subtest on
+MotionMark, when the GPU process is used to render canvases (tested against macOS 10.15.3, on a 10-core iMac).
+
+* platform/graphics/Path.h:
+* platform/graphics/cg/PathCG.cpp:
+(WebCore::Path::~Path):
+(WebCore::Path::ensurePlatformPath):
+(WebCore::Path::Path):
+
+Update move constructors to set m_copyPathBeforeMutation to false on the given (moved) path.
+
+(WebCore::Path::swap):
+(WebCore::Path::initializeOrCopyPlatformPathIfNeeded):
+
+Whenever we need to ensure the platform CGPath (i.e. prior to appending to it), check the new flag to see
+whether it's necessary to apply the subsequent mutation on a copy of m_path, rather than m_path itself. The
+exception to this is when m_path only has a retain count of 1, which implies that all other copies of this path
+have been mutated (and have copied their platform CGPath as a result); this means it's safe to apply changes to
+m_path, since this path is now the sole owner of the CGPath.
+
+(WebCore::Path::operator=):
+
+The copy constructor and copy assignment operators currently call CGPathCreateMutableCopy on the given path's
+platform CGPath; this is to ensure that if either path is mutated in the future, the mutation won't also affect
+the other copy of the WebCore::Path.
+
+However, this call to CGPathCreateMutableCopy isn't needed in the case where a path is copied, but neither of
+the paths are mutated. To avoid this extra copy, we can instead introduce a dirty bit (m_copyPathBeforeMutation)
+that is set when a path is copied (either via the constructor, or through assignment) and proceed to simply copy
+the path pointer to the new path. Only if either path is mutated do we then call 

[webkit-changes] [257731] trunk/LayoutTests

[lawrence . j]

Title: [257731] trunk/LayoutTests








Revision 257731
Author lawrenc...@apple.com
Date 2020-03-02 13:21:58 -0800 (Mon, 02 Mar 2020)


Log Message
[ iOS wk2 Debug and Mac Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208467

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257730 => 257731)

--- trunk/LayoutTests/ChangeLog	2020-03-02 21:12:40 UTC (rev 257730)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 21:21:58 UTC (rev 257731)
@@ -1,3 +1,13 @@
+2020-03-02  Jason Lawrence  
+
+[ iOS wk2 Debug and Mac Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=208467
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
 2020-03-02  John Wilander  
 
 ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (257730 => 257731)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-03-02 21:12:40 UTC (rev 257730)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-03-02 21:21:58 UTC (rev 257731)
@@ -1424,4 +1424,6 @@
 
 webkit.org/b/208355 [ Debug ] imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html [ Slow ]
 
-webkit.org/b/208401 compositing/absolute-inside-out-of-view-fixed.html [ Pass Crash Timeout ]
\ No newline at end of file
+webkit.org/b/208401 compositing/absolute-inside-out-of-view-fixed.html [ Pass Crash Timeout ]
+
+webkit.org/b/208467 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html [ Pass Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac/TestExpectations (257730 => 257731)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-03-02 21:12:40 UTC (rev 257730)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-03-02 21:21:58 UTC (rev 257731)
@@ -2051,4 +2051,6 @@
 
 webkit.org/b/208078 [ Debug ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Pass Timeout ]
 
-webkit.org/b/208450 webanimations/accelerated-animation-renderer-change.html [ Pass ImageOnlyFailure ]
\ No newline at end of file
+webkit.org/b/208450 webanimations/accelerated-animation-renderer-change.html [ Pass ImageOnlyFailure ]
+
+webkit.org/b/208467 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257730] trunk/Source

[commit-queue]

Title: [257730] trunk/Source








Revision 257730
Author commit-qu...@webkit.org
Date 2020-03-02 13:12:40 -0800 (Mon, 02 Mar 2020)


Log Message
Implement the remote ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=207221

Patch by Said Abou-Hallawa  on 2020-03-02
Reviewed by Jon Lee.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ConcreteImageBuffer.h:
(WebCore::ConcreteImageBuffer::create):
ConcreteImageBuffer::create returns the derived class which it creates.

* platform/graphics/displaylists/DisplayList.h:
This using statement gives compilation error when referencing DisplayList
from WebKit.

* platform/graphics/displaylists/DisplayListDrawingContext.h:
RemoteImageBuffer inherits DisplayList::ImageBuffer so these methods
need to be exported.

* platform/graphics/displaylists/DisplayListImageBuffer.h:
(WebCore::DisplayList::ImageBuffer::ImageBuffer):
Make it possible for RemoteImageBuffer to be created with no backend. It
will be created later when RemoteImageBufferProxy shares its backend with
RemoteImageBuffer.

Source/WebKit:

RemoteImageBuffer and RemoteImageBufferProxy represent a single remote
ImageBuffer. The back end should be created by RemoteImageBufferProxy in
GPUProcess and shared with the RemoteImageBuffer in the WebProcess.
Flushing the DrawingContext will be done in GPUProcess. But creating the
native image out of the back end will be in GPUProcess.

RemoteRenderingBackend and RemoteRenderingBackendProxy are central points
for receiving and sending all the messages of the RemoteImageBuffer and
RemoteImageBufferProxy.

* GPUProcess/graphics/PlatformRemoteImageBufferProxy.h: Added.
Defines the platform types of RemoteImageBufferProxy.

* GPUProcess/graphics/RemoteImageBufferMessageHandlerProxy.cpp: Added.
(WebKit::RemoteImageBufferMessageHandlerProxy::RemoteImageBufferMessageHandlerProxy):
(WebKit::RemoteImageBufferMessageHandlerProxy::createBackend):
(WebKit::RemoteImageBufferMessageHandlerProxy::commitFlushContext):
* GPUProcess/graphics/RemoteImageBufferMessageHandlerProxy.h: Added.
Manages sending and receiving the messages of RemoteImageBufferProxy

* GPUProcess/graphics/RemoteImageBufferProxy.h: Added.
(WebKit::RemoteImageBufferProxy::create):
(WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):
It is responsible for creating a shared back end and replaying back drawing
commands.

* GPUProcess/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::releaseImageBuffer):
(WebKit::RemoteRenderingBackendProxy::flushImageBufferDrawingContext):
* GPUProcess/graphics/RemoteRenderingBackendProxy.h:
(WebKit::RemoteRenderingBackendProxy::renderingBackendIdentifier const):
* GPUProcess/graphics/RemoteRenderingBackendProxy.messages.in:
Handle or dispatch messages received from RemoteRenderingBackend.

* Scripts/webkit/messages.py:
* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/GPU/graphics/ImageBufferFlushIdentifier.h: Added.

* WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
(WebKit::ImageBufferShareableBitmapBackend::create):
* WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
Although hostWindow isn't used, this is what ConcreteImageBuffer::create
expects from the creator of the backend.

* WebProcess/GPU/graphics/PlatformRemoteImageBuffer.h: Added.
Defines the platform types of RemoteImageBuffer.

* WebProcess/GPU/graphics/RemoteImageBuffer.h: Added.
(WebKit::RemoteImageBuffer::create):
(WebKit::RemoteImageBuffer::RemoteImageBuffer):
It is responsible for creating RemoteImageBufferProxy and performing the
drawing commands in the GPUProcess.

* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp: Added.
(WebKit::RemoteImageBufferMessageHandler::RemoteImageBufferMessageHandler):
(WebKit::RemoteImageBufferMessageHandler::~RemoteImageBufferMessageHandler):
(WebKit::RemoteImageBufferMessageHandler::flushDrawingContext):
(WebKit::RemoteImageBufferMessageHandler::commitFlushContext):
* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h: Added.
(WebKit::RemoteImageBufferMessageHandler::imageBufferIdentifier const):
Manages sending and receiving the messages of RemoteImageBuffer.

* WebProcess/GPU/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::releaseImageBuffer):
(WebKit::RemoteRenderingBackend::createImageBufferBackend):
(WebKit::RemoteRenderingBackend::commitImageBufferFlushContext):
* WebProcess/GPU/graphics/RemoteRenderingBackend.h:
(WebKit::RemoteRenderingBackend::renderingBackendIdentifier const):
* WebProcess/GPU/graphics/RemoteRenderingBackend.messages.in:
Handle or dispatch messages received from RemoteRenderingBackendProxy.

* WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp:
(WebKit::ImageBufferShareableIOSurfaceBackend::create):
* WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.h:
Although 

[webkit-changes] [257729] trunk

[commit-queue]

Title: [257729] trunk








Revision 257729
Author commit-qu...@webkit.org
Date 2020-03-02 13:07:55 -0800 (Mon, 02 Mar 2020)


Log Message
Fix behavior of pings regarding Origin header
https://bugs.webkit.org/show_bug.cgi?id=207102

Patch by Rob Buis  on 2020-03-02
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Import relevant tests.

* web-platform-tests/html/semantics/links/downloading-resources/header-origin-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer-when-downgrade-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer-when-downgrade.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-origin-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-origin-when-cross-origin-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-origin-when-cross-origin.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-origin.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-same-origin-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-same-origin.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-strict-origin-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-strict-origin-when-cross-origin-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-strict-origin-when-cross-origin.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-strict-origin.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-unsafe-url-expected.txt: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin-unsafe-url.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin.html: Added.
* web-platform-tests/html/semantics/links/downloading-resources/header-origin.js: Added.
(testOriginHeader):
(pollResult.return.new.Promise.):
(pollResult.return.new.Promise):
* web-platform-tests/html/semantics/links/downloading-resources/w3c-import.log:

Source/WebCore:

Fix behavior of pings regarding Origin header by using the
"append a request Origin header" algorithm [1]. This patch
also sets the origin before calling addExtraFieldsToSubresourceRequest
since the latter forces the origin to "null".

Tests: imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer-when-downgrade.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-origin-when-cross-origin.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-origin.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-same-origin.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-strict-origin-when-cross-origin.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-strict-origin.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-unsafe-url.html
   imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin.html

[1] https://fetch.spec.whatwg.org/#append-a-request-origin-header

* loader/PingLoader.cpp:
(WebCore::PingLoader::sendPing):
* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::generateOriginHeader):
* page/SecurityPolicy.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/PingLoader.cpp
trunk/Source/WebCore/page/SecurityPolicy.cpp
trunk/Source/WebCore/page/SecurityPolicy.h


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/downloading-resources/header-origin-no-referrer-when-downgrade-expected.txt

[webkit-changes] [257728] trunk

[justin_michaud]

Title: [257728] trunk








Revision 257728
Author justin_mich...@apple.com
Date 2020-03-02 12:58:22 -0800 (Mon, 02 Mar 2020)


Log Message
Delete by val caching does not keep the subscript alive
https://bugs.webkit.org/show_bug.cgi?id=208393

Reviewed by Yusuke Suzuki.

JSTests:

* stress/delete-property-ic-stress.js: Added.

Source/_javascript_Core:

Before, the provided test case crashed with asan because we did not keep deleteByVal
subscripts alive. This patch changes CacheableIdentifier to make this mistake harder
to make again, by making the constructor calls more explicit when CacheableIdentifier
will not keep an Identifier alive.

* jit/JITOperations.cpp:
* jit/Repatch.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheDeleteBy):
(JSC::repatchDeleteBy):
(JSC::tryCacheInByID):
(JSC::tryCacheInstanceOf):
(JSC::tryCacheDelBy): Deleted.
(JSC::repatchDelBy): Deleted.
* jit/Repatch.h:
* runtime/CacheableIdentifier.h:
* runtime/CacheableIdentifierInlines.h:
(JSC::CacheableIdentifier::createFromIdentifierOwnedByCodeBlock):
(JSC::CacheableIdentifier::createFromCell):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/jit/Repatch.h
trunk/Source/_javascript_Core/runtime/CacheableIdentifier.h
trunk/Source/_javascript_Core/runtime/CacheableIdentifierInlines.h


Added Paths

trunk/JSTests/stress/delete-property-ic-stress.js




Diff

Modified: trunk/JSTests/ChangeLog (257727 => 257728)

--- trunk/JSTests/ChangeLog	2020-03-02 20:45:16 UTC (rev 257727)
+++ trunk/JSTests/ChangeLog	2020-03-02 20:58:22 UTC (rev 257728)
@@ -1,3 +1,12 @@
+2020-03-02  Justin Michaud  
+
+Delete by val caching does not keep the subscript alive
+https://bugs.webkit.org/show_bug.cgi?id=208393
+
+Reviewed by Yusuke Suzuki.
+
+* stress/delete-property-ic-stress.js: Added.
+
 2020-02-27  Justin Michaud  
 
 Poly proto should work with property delete transitions


Added: trunk/JSTests/stress/delete-property-ic-stress.js (0 => 257728)

--- trunk/JSTests/stress/delete-property-ic-stress.js	(rev 0)
+++ trunk/JSTests/stress/delete-property-ic-stress.js	2020-03-02 20:58:22 UTC (rev 257728)
@@ -0,0 +1,5 @@
+let x = {};
+for (let i=0; i<1000; ++i) {
+gc();
+delete x["h" + 5];
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (257727 => 257728)

--- trunk/Source/_javascript_Core/ChangeLog	2020-03-02 20:45:16 UTC (rev 257727)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-03-02 20:58:22 UTC (rev 257728)
@@ -1,3 +1,30 @@
+2020-03-02  Justin Michaud  
+
+Delete by val caching does not keep the subscript alive
+https://bugs.webkit.org/show_bug.cgi?id=208393
+
+Reviewed by Yusuke Suzuki.
+
+Before, the provided test case crashed with asan because we did not keep deleteByVal
+subscripts alive. This patch changes CacheableIdentifier to make this mistake harder
+to make again, by making the constructor calls more explicit when CacheableIdentifier
+will not keep an Identifier alive.
+
+* jit/JITOperations.cpp:
+* jit/Repatch.cpp:
+(JSC::tryCachePutByID):
+(JSC::tryCacheDeleteBy):
+(JSC::repatchDeleteBy):
+(JSC::tryCacheInByID):
+(JSC::tryCacheInstanceOf):
+(JSC::tryCacheDelBy): Deleted.
+(JSC::repatchDelBy): Deleted.
+* jit/Repatch.h:
+* runtime/CacheableIdentifier.h:
+* runtime/CacheableIdentifierInlines.h:
+(JSC::CacheableIdentifier::createFromIdentifierOwnedByCodeBlock):
+(JSC::CacheableIdentifier::createFromCell):
+
 2020-03-02  Paulo Matos  
 
 Fix JSC 32bit alignment increase gcc warning


Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (257727 => 257728)

--- trunk/Source/_javascript_Core/jit/JITOperations.cpp	2020-03-02 20:45:16 UTC (rev 257727)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp	2020-03-02 20:58:22 UTC (rev 257728)
@@ -214,7 +214,7 @@
 
 CodeBlock* codeBlock = callFrame->codeBlock();
 if (stubInfo->considerCaching(vm, codeBlock, baseValue.structureOrNull()) && !slot.isTaintedByOpaqueObject() && (slot.isCacheableValue() || slot.isCacheableGetter() || slot.isUnset()))
-repatchGetBy(globalObject, codeBlock, baseValue, ident, slot, *stubInfo, GetByKind::Try);
+repatchGetBy(globalObject, codeBlock, baseValue, CacheableIdentifier::createFromIdentifierOwnedByCodeBlock(ident), slot, *stubInfo, GetByKind::Try);
 
 return JSValue::encode(slot.getPureResult());
 }
@@ -270,7 +270,7 @@
 
 CodeBlock* codeBlock = callFrame->codeBlock();
 if (stubInfo->considerCaching(vm, codeBlock, baseValue.structureOrNull()))
-repatchGetBy(globalObject, codeBlock, baseValue, ident, slot, *stubInfo, GetByKind::Direct);
+repatchGetBy(globalObject, codeBlock, baseValue, 

[webkit-changes] [257727] trunk/Source/WebCore

[cdumez]

Title: [257727] trunk/Source/WebCore








Revision 257727
Author cdu...@apple.com
Date 2020-03-02 12:45:16 -0800 (Mon, 02 Mar 2020)


Log Message
Reduce size of PerformanceEntry
https://bugs.webkit.org/show_bug.cgi?id=208452

Reviewed by Devin Rousso.

Reduce size of PerformanceEntry by leveraging the fact that it is polymorphic.

* page/PerformanceEntry.cpp:
(WebCore::PerformanceEntry::PerformanceEntry):
* page/PerformanceEntry.h:
(WebCore::PerformanceEntry::name const):
(WebCore::PerformanceEntry::isResource const):
(WebCore::PerformanceEntry::isMark const):
(WebCore::PerformanceEntry::isMeasure const):
(WebCore::PerformanceEntry::entryType const): Deleted.
(WebCore::PerformanceEntry::type const): Deleted.
* page/PerformanceMark.h:
* page/PerformanceMeasure.h:
* page/PerformanceResourceTiming.cpp:
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::nextHopProtocol const):
* page/PerformanceResourceTiming.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PerformanceEntry.cpp
trunk/Source/WebCore/page/PerformanceEntry.h
trunk/Source/WebCore/page/PerformanceMark.h
trunk/Source/WebCore/page/PerformanceMeasure.h
trunk/Source/WebCore/page/PerformanceResourceTiming.cpp
trunk/Source/WebCore/page/PerformanceResourceTiming.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (257726 => 257727)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 20:24:04 UTC (rev 257726)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 20:45:16 UTC (rev 257727)
@@ -1,3 +1,28 @@
+2020-03-02  Chris Dumez  
+
+Reduce size of PerformanceEntry
+https://bugs.webkit.org/show_bug.cgi?id=208452
+
+Reviewed by Devin Rousso.
+
+Reduce size of PerformanceEntry by leveraging the fact that it is polymorphic.
+
+* page/PerformanceEntry.cpp:
+(WebCore::PerformanceEntry::PerformanceEntry):
+* page/PerformanceEntry.h:
+(WebCore::PerformanceEntry::name const):
+(WebCore::PerformanceEntry::isResource const):
+(WebCore::PerformanceEntry::isMark const):
+(WebCore::PerformanceEntry::isMeasure const):
+(WebCore::PerformanceEntry::entryType const): Deleted.
+(WebCore::PerformanceEntry::type const): Deleted.
+* page/PerformanceMark.h:
+* page/PerformanceMeasure.h:
+* page/PerformanceResourceTiming.cpp:
+(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
+(WebCore::PerformanceResourceTiming::nextHopProtocol const):
+* page/PerformanceResourceTiming.h:
+
 2020-03-02  John Wilander  
 
 ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions


Modified: trunk/Source/WebCore/page/PerformanceEntry.cpp (257726 => 257727)

--- trunk/Source/WebCore/page/PerformanceEntry.cpp	2020-03-02 20:24:04 UTC (rev 257726)
+++ trunk/Source/WebCore/page/PerformanceEntry.cpp	2020-03-02 20:45:16 UTC (rev 257727)
@@ -38,12 +38,10 @@
 
 DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(PerformanceEntry);
 
-PerformanceEntry::PerformanceEntry(Type type, const String& name, const String& entryType, double startTime, double finishTime)
+PerformanceEntry::PerformanceEntry(const String& name, double startTime, double finishTime)
 : m_name(name)
-, m_entryType(entryType)
 , m_startTime(startTime)
 , m_duration(finishTime - startTime)
-, m_type(type)
 {
 }
 


Modified: trunk/Source/WebCore/page/PerformanceEntry.h (257726 => 257727)

--- trunk/Source/WebCore/page/PerformanceEntry.h	2020-03-02 20:24:04 UTC (rev 257726)
+++ trunk/Source/WebCore/page/PerformanceEntry.h	2020-03-02 20:45:16 UTC (rev 257727)
@@ -43,8 +43,7 @@
 public:
 virtual ~PerformanceEntry();
 
-String name() const { return m_name; }
-String entryType() const { return m_entryType; }
+const String& name() const { return m_name; }
 double startTime() const { return m_startTime; }
 double duration() const { return m_duration; }
 
@@ -55,13 +54,14 @@
 Resource = 1 << 3,
 };
 
-Type type() const { return m_type; }
+virtual Type type() const = 0;
+virtual ASCIILiteral entryType() const = 0;
 
 static Optional parseEntryTypeString(const String& entryType);
 
-bool isResource() const { return m_type == Type::Resource; }
-bool isMark() const { return m_type == Type::Mark; }
-bool isMeasure() const { return m_type == Type::Measure; }
+bool isResource() const { return type() == Type::Resource; }
+bool isMark() const { return type() == Type::Mark; }
+bool isMeasure() const { return type() == Type::Measure; }
 
 static bool startTimeCompareLessThan(const RefPtr& a, const RefPtr& b)
 {
@@ -69,14 +69,12 @@
 }
 
 protected:
-PerformanceEntry(Type, const String& name, const String& entryType, double startTime, double finishTime);
+PerformanceEntry(const String& name, double startTime, double finishTime);
 
 private:
 const String m_name;
-const 

[webkit-changes] [257725] trunk

[pvollan]

Title: [257725] trunk








Revision 257725
Author pvol...@apple.com
Date 2020-03-02 12:21:33 -0800 (Mon, 02 Mar 2020)


Log Message
[Cocoa] Mapping from MIME type to UTI type should be done in the UI process
https://bugs.webkit.org/show_bug.cgi?id=208415

Reviewed by Brent Fulgham.

Source/WebCore:

This is currently done in the WebContent process, but since this is using a system service which will be closed,
this mapping should be moved to the UI process. The UI process will create this mapping for a set of mime types,
and send it to the WebContent process.

API test: WebKit.UTIFromMIMEType

* platform/network/mac/UTIUtilities.h:
* platform/network/mac/UTIUtilities.mm:
(WebCore::mapUTIFromMIMEType):
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::cacheUTIFromMimeType):
(WebCore::UTIFromMIMEType):
(WebCore::mimeTypes):
(WebCore::createUTIFromMIMETypeMap):
(WebCore::setUTIFromMIMETypeMap):
* testing/Internals.cpp:
(WebCore::Internals::getUTIFromMIMEType):
* testing/Internals.mm:
(WebCore::Internals::getUTIFromMIMEType):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

Send the mapping between MIME types and UTI types to the WebContent process as part of the Web
process creation parameters.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/UTIUtilities.h
trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/testing/Internals.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (257724 => 257725)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 20:07:42 UTC (rev 257724)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 20:21:33 UTC (rev 257725)
@@ -1,3 +1,32 @@
+2020-03-02  Per Arne Vollan  
+
+[Cocoa] Mapping from MIME type to UTI type should be done in the UI process
+https://bugs.webkit.org/show_bug.cgi?id=208415
+
+Reviewed by Brent Fulgham.
+
+This is currently done in the WebContent process, but since this is using a system service which will be closed,
+this mapping should be moved to the UI process. The UI process will create this mapping for a set of mime types,
+and send it to the WebContent process.
+
+API test: WebKit.UTIFromMIMEType
+
+* platform/network/mac/UTIUtilities.h:
+* platform/network/mac/UTIUtilities.mm:
+(WebCore::mapUTIFromMIMEType):
+(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
+(WebCore::cacheUTIFromMimeType):
+(WebCore::UTIFromMIMEType):
+(WebCore::mimeTypes):
+(WebCore::createUTIFromMIMETypeMap):
+(WebCore::setUTIFromMIMETypeMap):
+* testing/Internals.cpp:
+(WebCore::Internals::getUTIFromMIMEType):
+* testing/Internals.mm:
+(WebCore::Internals::getUTIFromMIMEType):
+* testing/Internals.h:
+* testing/Internals.idl:
+
 2020-03-02  Daniel Bates  
 
 Page::editableElementsInRect() should find nested editable elements and return found elements in paint order


Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.h (257724 => 257725)

--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-02 20:07:42 UTC (rev 257724)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-02 20:21:33 UTC (rev 257725)
@@ -23,17 +23,18 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef UTIUtilities_h
-#define UTIUtilities_h
+#pragma once
 
-#import 
-#import 
+#include 
 
 namespace WebCore {
+
 WEBCORE_EXPORT String MIMETypeFromUTI(const String&);
 String MIMETypeFromUTITree(const String&);
 WEBCORE_EXPORT String UTIFromMIMEType(const String&);
 bool isDeclaredUTI(const String&);
+
+WEBCORE_EXPORT void setUTIFromMIMETypeMap(HashMap&&);
+WEBCORE_EXPORT const HashMap& createUTIFromMIMETypeMap();
+WEBCORE_EXPORT const Vector& mimeTypes();
 }
-
-#endif // UTIUtilities_h


Modified: 

[webkit-changes] [257724] trunk/Source/WebKit

[eric . carlson]

Title: [257724] trunk/Source/WebKit








Revision 257724
Author eric.carl...@apple.com
Date 2020-03-02 12:07:42 -0800 (Mon, 02 Mar 2020)


Log Message
[GPUP] Plumb through more MediaPlayer methods
https://bugs.webkit.org/show_bug.cgi?id=208423


Unreviewed, remove an invalid ASSERT that causes some tests to crash.


* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::load):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (257723 => 257724)

--- trunk/Source/WebKit/ChangeLog	2020-03-02 19:57:15 UTC (rev 257723)
+++ trunk/Source/WebKit/ChangeLog	2020-03-02 20:07:42 UTC (rev 257724)
@@ -1,3 +1,14 @@
+2020-03-02  Eric Carlson  
+
+[GPUP] Plumb through more MediaPlayer methods
+https://bugs.webkit.org/show_bug.cgi?id=208423
+
+
+Unreviewed, remove an invalid ASSERT that causes some tests to crash.
+
+* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
+(WebKit::MediaPlayerPrivateRemote::load):
+
 2020-03-02  Per Arne Vollan  
 
 [iOS] Deny mach lookup access to distributed notifications in the WebContent process


Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (257723 => 257724)

--- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp	2020-03-02 19:57:15 UTC (rev 257723)
+++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp	2020-03-02 20:07:42 UTC (rev 257724)
@@ -605,8 +605,6 @@
 #if ENABLE(MEDIA_STREAM)
 void MediaPlayerPrivateRemote::load(MediaStreamPrivate&)
 {
-ASSERT_NOT_REACHED();
-
 callOnMainThread([weakThis = makeWeakPtr(*this), this] {
 if (!weakThis)
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257723] trunk

[pvollan]

Title: [257723] trunk








Revision 257723
Author pvol...@apple.com
Date 2020-03-02 11:57:15 -0800 (Mon, 02 Mar 2020)


Log Message
[iOS] Deny mach lookup access to distributed notifications in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=208455

Reviewed by Brent Fulgham.

Source/WebKit:

On iOS, deny mach lookup access to the service "com.apple.distributed_notifications@1v3" in the WebContent process.

Test: fast/sandbox/ios/sandbox-mach-lookup.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
* fast/sandbox/ios/sandbox-mach-lookup.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: trunk/LayoutTests/ChangeLog (257722 => 257723)

--- trunk/LayoutTests/ChangeLog	2020-03-02 19:54:43 UTC (rev 257722)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 19:57:15 UTC (rev 257723)
@@ -1,3 +1,13 @@
+2020-03-02  Per Arne Vollan  
+
+[iOS] Deny mach lookup access to distributed notifications in the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=208455
+
+Reviewed by Brent Fulgham.
+
+* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
+* fast/sandbox/ios/sandbox-mach-lookup.html:
+
 2020-03-02  Doug Kelly  
 
 ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (257722 => 257723)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-03-02 19:54:43 UTC (rev 257722)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-03-02 19:57:15 UTC (rev 257723)
@@ -20,3 +20,4 @@
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.tccd") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.uikit.viewservice") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.analyticsd") is false
+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.distributed_notifications@1v3") is false


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (257722 => 257723)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-03-02 19:54:43 UTC (rev 257722)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-03-02 19:57:15 UTC (rev 257723)
@@ -23,6 +23,7 @@
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.tccd\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.uikit.viewservice\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.analyticsd\")");
+shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.distributed_notifications@1v3\")");
 }
 
 


Modified: trunk/Source/WebKit/ChangeLog (257722 => 257723)

--- trunk/Source/WebKit/ChangeLog	2020-03-02 19:54:43 UTC (rev 257722)
+++ trunk/Source/WebKit/ChangeLog	2020-03-02 19:57:15 UTC (rev 257723)
@@ -1,3 +1,16 @@
+2020-03-02  Per Arne Vollan  
+
+[iOS] Deny mach lookup access to distributed notifications in the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=208455
+
+Reviewed by Brent Fulgham.
+
+On iOS, deny mach lookup access to the service "com.apple.distributed_notifications@1v3" in the WebContent process.
+
+Test: fast/sandbox/ios/sandbox-mach-lookup.html
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-03-02  Jacob Uphoff  
 
 Unreviewed, rolling out r257687.


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (257722 => 257723)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-03-02 19:54:43 UTC (rev 257722)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-03-02 19:57:15 UTC (rev 257723)
@@ -538,7 +538,7 @@
 (global-name "com.apple.logd.events")
 )
 
-(allow mach-lookup (with report) (with telemetry)
+(deny mach-lookup (with report) (with telemetry)
 (global-name "com.apple.distributed_notifications@1v3"))
 
 (allow ipc-posix-shm-read*






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257722] trunk

[dbates]

Title: [257722] trunk








Revision 257722
Author dba...@webkit.org
Date 2020-03-02 11:54:43 -0800 (Mon, 02 Mar 2020)


Log Message
Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
https://bugs.webkit.org/show_bug.cgi?id=208352


Reviewed by Wenson Hsieh.

Source/WebCore:

Use the existing rect-based hit testing machinery to collect all the editable elements on
the page that a person can hit. This makes it possible to find nested editable elements
(e.g. an  inside a ), ignore elements with CSS "pointer-events: none",
and return elements in paint order (closest to farthest to a person's face). The latter
makes it possible for a caller to know what element is frontmost, especially when two
editable elements overlap.

* page/Page.cpp:
(WebCore::Page::editableElementsInRect const): Implement in terms of hit testing machinery.
* rendering/HitTestLocation.cpp:
(WebCore::HitTestLocation::HitTestLocation):
* rendering/HitTestLocation.h:
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
* rendering/HitTestResult.h:
Added convenience constructors that take a LayoutRect.

Tools:

Update test results to reflect the new behavior. To do this I also need to fix up the test code
to actually scroll the web content. This also means we now execute the same code on both Mac and
iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
the requested rect; should not be included." to use a 1px height  so that you can scroll
to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.

* TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/rendering/HitTestLocation.cpp
trunk/Source/WebCore/rendering/HitTestLocation.h
trunk/Source/WebCore/rendering/HitTestResult.cpp
trunk/Source/WebCore/rendering/HitTestResult.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (257721 => 257722)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 19:46:55 UTC (rev 257721)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 19:54:43 UTC (rev 257722)
@@ -1,3 +1,28 @@
+2020-03-02  Daniel Bates  
+
+Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
+https://bugs.webkit.org/show_bug.cgi?id=208352
+
+
+Reviewed by Wenson Hsieh.
+
+Use the existing rect-based hit testing machinery to collect all the editable elements on
+the page that a person can hit. This makes it possible to find nested editable elements
+(e.g. an  inside a ), ignore elements with CSS "pointer-events: none",
+and return elements in paint order (closest to farthest to a person's face). The latter
+makes it possible for a caller to know what element is frontmost, especially when two
+editable elements overlap.
+
+* page/Page.cpp:
+(WebCore::Page::editableElementsInRect const): Implement in terms of hit testing machinery.
+* rendering/HitTestLocation.cpp:
+(WebCore::HitTestLocation::HitTestLocation):
+* rendering/HitTestLocation.h:
+* rendering/HitTestResult.cpp:
+(WebCore::HitTestResult::HitTestResult):
+* rendering/HitTestResult.h:
+Added convenience constructors that take a LayoutRect.
+
 2020-03-02  Doug Kelly  
 
 ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore


Modified: trunk/Source/WebCore/page/Page.cpp (257721 => 257722)

--- trunk/Source/WebCore/page/Page.cpp	2020-03-02 19:46:55 UTC (rev 257721)
+++ trunk/Source/WebCore/page/Page.cpp	2020-03-02 19:54:43 UTC (rev 257722)
@@ -128,7 +128,6 @@
 #include "VoidCallback.h"
 #include "WheelEventDeltaFilter.h"
 #include "Widget.h"
-#include 
 #include 
 #include 
 #include 
@@ -927,26 +926,29 @@
 
 Vector> Page::editableElementsInRect(const FloatRect& searchRectInRootViewCoordinates) const
 {
-Vector> result;
-forEachDocument([&] (Document& document) {
-Deque nodesToSearch;
-nodesToSearch.append();
-while (!nodesToSearch.isEmpty()) {
-auto* node = nodesToSearch.takeFirst();
+auto frameView = makeRefPtr(mainFrame().view());
+if (!frameView)
+return { };
 
-// It is possible to have nested text input contexts (e.g.  inside contenteditable) but
-// in this case we just take the outermost context and skip the rest.
-if (!is(node) || !isEditableTextInputElement(downcast(*node))) {
-for (auto* child = node->firstChild(); child; child = child->nextSibling())
-nodesToSearch.append(child);
-continue;
-}
+auto document = makeRefPtr(mainFrame().document());
+if (!document)
+return 

[webkit-changes] [257720] trunk

[commit-queue]

Title: [257720] trunk








Revision 257720
Author commit-qu...@webkit.org
Date 2020-03-02 11:10:53 -0800 (Mon, 02 Mar 2020)


Log Message
ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore
https://bugs.webkit.org/show_bug.cgi?id=208397

Patch by Doug Kelly  on 2020-03-02
Reviewed by Zalan Bujtas.

Source/WebCore:

When inserting a cell into a table row which is not visible, this can lead to attempting to compute the repaint
rects during tree building.  Instead, mark the layer as dirty using dirtyVisibleContentStatus(), and the visibility
will be recomputed at a later time.

Test: fast/table/insert-cell-invisible-parent.html

* rendering/RenderElement.cpp:
(WebCore::RenderElement::insertedIntoTree):

LayoutTests:

* fast/table/insert-cell-invisible-parent-expected.txt: Added.
* fast/table/insert-cell-invisible-parent.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp


Added Paths

trunk/LayoutTests/fast/table/insert-cell-invisible-parent-expected.txt
trunk/LayoutTests/fast/table/insert-cell-invisible-parent.html




Diff

Modified: trunk/LayoutTests/ChangeLog (257719 => 257720)

--- trunk/LayoutTests/ChangeLog	2020-03-02 18:53:39 UTC (rev 257719)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 19:10:53 UTC (rev 257720)
@@ -1,3 +1,13 @@
+2020-03-02  Doug Kelly  
+
+ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore
+https://bugs.webkit.org/show_bug.cgi?id=208397
+
+Reviewed by Zalan Bujtas.
+
+* fast/table/insert-cell-invisible-parent-expected.txt: Added.
+* fast/table/insert-cell-invisible-parent.html: Added.
+
 2020-03-02  Jason Lawrence  
 
 [ Mac ] webanimations/accelerated-animation-renderer-change.html is flaky failing.


Added: trunk/LayoutTests/fast/table/insert-cell-invisible-parent-expected.txt (0 => 257720)

--- trunk/LayoutTests/fast/table/insert-cell-invisible-parent-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/table/insert-cell-invisible-parent-expected.txt	2020-03-02 19:10:53 UTC (rev 257720)
@@ -0,0 +1 @@
+Tests if a newly-inserted cell is properly added when parent element is not visible. Test passes if WebKit does not crash. PASS


Added: trunk/LayoutTests/fast/table/insert-cell-invisible-parent.html (0 => 257720)

--- trunk/LayoutTests/fast/table/insert-cell-invisible-parent.html	(rev 0)
+++ trunk/LayoutTests/fast/table/insert-cell-invisible-parent.html	2020-03-02 19:10:53 UTC (rev 257720)
@@ -0,0 +1,16 @@
+
+td { visibility: initial; }
+#row { visibility: collapse; -webkit-backface-visibility: hidden; }
+
+
+
+
+document.body.offsetHeight;
+window.scrollBy();
+row.insertCell();
+document.body.offsetWidth;
+if (window.testRunner) {
+document.body.innerText = "Tests if a newly-inserted cell is properly added when parent element is not visible.  Test passes if WebKit does not crash.  PASS";
+testRunner.dumpAsText();
+}
+


Modified: trunk/Source/WebCore/ChangeLog (257719 => 257720)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 18:53:39 UTC (rev 257719)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 19:10:53 UTC (rev 257720)
@@ -1,3 +1,19 @@
+2020-03-02  Doug Kelly  
+
+ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore
+https://bugs.webkit.org/show_bug.cgi?id=208397
+
+Reviewed by Zalan Bujtas.
+
+When inserting a cell into a table row which is not visible, this can lead to attempting to compute the repaint
+rects during tree building.  Instead, mark the layer as dirty using dirtyVisibleContentStatus(), and the visibility
+will be recomputed at a later time.
+
+Test: fast/table/insert-cell-invisible-parent.html
+
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::insertedIntoTree):
+
 2020-03-02  Zalan Bujtas  
 
 [BFC][MarginCollapsing] Sometimes precomputed margin values are just plain wrong.


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (257719 => 257720)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2020-03-02 18:53:39 UTC (rev 257719)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2020-03-02 19:10:53 UTC (rev 257720)
@@ -885,7 +885,7 @@
 if (!layer)
 layer = parent()->enclosingLayer();
 if (layer)
-layer->setHasVisibleContent();
+layer->dirtyVisibleContentStatus();
 }
 
 RenderObject::insertedIntoTree();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257719] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [257719] trunk/Source/_javascript_Core








Revision 257719
Author ysuz...@apple.com
Date 2020-03-02 10:53:39 -0800 (Mon, 02 Mar 2020)


Log Message
Unreviewed, fix wrong assertion
https://bugs.webkit.org/show_bug.cgi?id=208404


* runtime/CachedTypes.cpp:
(JSC::CachedUniquedStringImplBase::decode const):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/CachedTypes.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (257718 => 257719)

--- trunk/Source/_javascript_Core/ChangeLog	2020-03-02 18:00:01 UTC (rev 257718)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-03-02 18:53:39 UTC (rev 257719)
@@ -1,3 +1,12 @@
+2020-03-02  Yusuke Suzuki  
+
+Unreviewed, fix wrong assertion
+https://bugs.webkit.org/show_bug.cgi?id=208404
+
+
+* runtime/CachedTypes.cpp:
+(JSC::CachedUniquedStringImplBase::decode const):
+
 2020-03-01  Charles Turner  
 
 undefined reference to `JSC::ExecutableBase::hasJITCodeForCall() const'


Modified: trunk/Source/_javascript_Core/runtime/CachedTypes.cpp (257718 => 257719)

--- trunk/Source/_javascript_Core/runtime/CachedTypes.cpp	2020-03-02 18:00:01 UTC (rev 257718)
+++ trunk/Source/_javascript_Core/runtime/CachedTypes.cpp	2020-03-02 18:53:39 UTC (rev 257719)
@@ -752,9 +752,9 @@
 StringImpl* impl = str.releaseImpl().get();
 ASSERT(impl->isSymbol());
 if (m_isWellKnownSymbol)
+ASSERT(!static_cast(impl)->isPrivate());
+else
 ASSERT(static_cast(impl)->isPrivate());
-else
-ASSERT(!static_cast(impl)->isPrivate());
 return static_cast(impl);
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257718] trunk/Source/WebCore

[zalan]

Title: [257718] trunk/Source/WebCore








Revision 257718
Author za...@apple.com
Date 2020-03-02 10:00:01 -0800 (Mon, 02 Mar 2020)


Log Message
[BFC][MarginCollapsing] Sometimes precomputed margin values are just plain wrong.
https://bugs.webkit.org/show_bug.cgi?id=208448


Reviewed by Antti Koivisto.

Consider the following content:


  
  
  
  
  
 


In order to compute the position of the second float we need be able to intersect it with all
the other floats in the same floating context. The float positioning starts with the box's static vertical position
which is the position the box would be taking if it wasn't floating positioned.
This vertical position needs to be in the same coordinate system as all the other floats to be able to intersect properly.
The coordinate system is the formatting root's content box.
When the second float box is being positioned, we don't yet have final margins for its ancestors, so the box's vertical
position at this point is only computed relative to its containing block.
In most cases we could just walk the ancestor chain all the way to the formatting root and pre-compute the margin before values.
However in some not-so-rare cases, the ancestor margin before value depends on some content after the float box and to be able
to figure out the exact margin values, we actually need to lay out the rest of the content.
In the example above, the second float's final position depends on whether the  has white-space: pre or not (whether the parent
div produces empty content or not).

This patch computes margin before values only for the ancestors ignoring margin collapsing (and margin after values).

* layout/MarginTypes.h:
(WebCore::Layout::PrecomputedMarginBefore::usedValue const):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::setPrecomputedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::hasPrecomputedMarginBefore const): Deleted.
* layout/blockformatting/BlockFormattingContext.h:
* layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeValues const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeMarginBefore const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedMarginBefore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/MarginTypes.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h
trunk/Source/WebCore/layout/blockformatting/PrecomputedBlockMarginCollapse.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257717 => 257718)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 17:44:17 UTC (rev 257717)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 18:00:01 UTC (rev 257718)
@@ -1,3 +1,50 @@
+2020-03-02  Zalan Bujtas  
+
+[BFC][MarginCollapsing] Sometimes precomputed margin values are just plain wrong.
+https://bugs.webkit.org/show_bug.cgi?id=208448
+
+
+Reviewed by Antti Koivisto.
+
+Consider the following content:
+
+
+  
+  
+  
+  
+  
+ 
+
+
+In order to compute the position of the second float we need be able to intersect it with all
+the other floats in the same floating context. The float positioning starts with the box's static vertical position
+which is the position the box would be taking if it wasn't floating positioned.
+This vertical position needs to be in the same coordinate system as all the other floats to be able to intersect properly.
+The coordinate system is the formatting root's content box.
+When the second float box is being positioned, we don't yet have final margins for its ancestors, so the box's vertical
+position at this point is only computed relative to its containing block.
+In most cases we could just walk the ancestor chain all the way to the formatting root and pre-compute the margin before values.
+However in some not-so-rare cases, the ancestor margin before value depends on some content after the float box and to be able
+to figure out the exact margin values, we actually need to lay out the rest of the content.
+In the example above, the second float's final position depends on whether the  has white-space: pre or not (whether the parent
+div produces empty content or not).
+
+This patch computes margin before values only for the ancestors ignoring margin collapsing (and margin after values).
+
+* layout/MarginTypes.h:
+(WebCore::Layout::PrecomputedMarginBefore::usedValue const):
+* 

[webkit-changes] [257717] trunk/LayoutTests

[lawrence . j]

Title: [257717] trunk/LayoutTests








Revision 257717
Author lawrenc...@apple.com
Date 2020-03-02 09:44:17 -0800 (Mon, 02 Mar 2020)


Log Message
[ Mac ] webanimations/accelerated-animation-renderer-change.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208450

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257716 => 257717)

--- trunk/LayoutTests/ChangeLog	2020-03-02 17:37:30 UTC (rev 257716)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 17:44:17 UTC (rev 257717)
@@ -1,3 +1,12 @@
+2020-03-02  Jason Lawrence  
+
+[ Mac ] webanimations/accelerated-animation-renderer-change.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=208450
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2020-03-02  Dean Jackson  
 
 maps.google.com is not loading properly, screen flickers when zooming


Modified: trunk/LayoutTests/platform/mac/TestExpectations (257716 => 257717)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-03-02 17:37:30 UTC (rev 257716)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-03-02 17:44:17 UTC (rev 257717)
@@ -2049,4 +2049,6 @@
 webkit.org/b/208053 imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-effects.sub.html [ Skip ]
 webkit.org/b/208053 imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-occlusion.sub.html [ Skip ]
 
-webkit.org/b/208078 [ Debug ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/208078 [ Debug ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Pass Timeout ]
+
+webkit.org/b/208450 webanimations/accelerated-animation-renderer-change.html [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257716] trunk

[dino]

Title: [257716] trunk








Revision 257716
Author d...@apple.com
Date 2020-03-02 09:37:30 -0800 (Mon, 02 Mar 2020)


Log Message
maps.google.com is not loading properly, screen flickers when zooming
https://bugs.webkit.org/show_bug.cgi?id=208331


Reviewed by Antoine Quint.

Source/WebCore:

When using ANGLE, we don't need the GL_ANGLE_depth_texture extension.
We were mistakenly checking for it and deciding to not allow
combined depth+stencil framebuffer attachments.

Test: webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
(now passes on iOS)

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::setupFlags):

LayoutTests:

* platform/ios/TestExpectations: remove failing expectation for:
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (257715 => 257716)

--- trunk/LayoutTests/ChangeLog	2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 17:37:30 UTC (rev 257716)
@@ -1,3 +1,14 @@
+2020-03-02  Dean Jackson  
+
+maps.google.com is not loading properly, screen flickers when zooming
+https://bugs.webkit.org/show_bug.cgi?id=208331
+
+
+Reviewed by Antoine Quint.
+
+* platform/ios/TestExpectations: remove failing expectation for:
+webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
+
 2020-03-02  Jason Lawrence  
 
 [ Mac wk1 Debug ] mathml/presentation/attributes-accent-accentunder-dynamic.html is flaky failing.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (257715 => 257716)

--- trunk/LayoutTests/platform/ios/TestExpectations	2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-03-02 17:37:30 UTC (rev 257716)
@@ -3525,7 +3525,6 @@
 webkit.org/b/207858 webgl/1.0.3/conformance/misc/delayed-drawing.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/misc/uninitialized-test.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/programs/program-test.html [ Failure ]
-webkit.org/b/207858 webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/state/state-uneffected-after-compositing.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/textures/default-texture.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html [ Pass Failure ]


Modified: trunk/Source/WebCore/ChangeLog (257715 => 257716)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 17:37:30 UTC (rev 257716)
@@ -1,3 +1,21 @@
+2020-03-02  Dean Jackson  
+
+maps.google.com is not loading properly, screen flickers when zooming
+https://bugs.webkit.org/show_bug.cgi?id=208331
+
+
+Reviewed by Antoine Quint.
+
+When using ANGLE, we don't need the GL_ANGLE_depth_texture extension.
+We were mistakenly checking for it and deciding to not allow
+combined depth+stencil framebuffer attachments.
+
+Test: webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
+(now passes on iOS)
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::setupFlags):
+
 2020-03-02  Chris Dumez  
 
 Add quirk to disable to back/forward cache on docs.google.com


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (257715 => 257716)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-03-02 17:37:30 UTC (rev 257716)
@@ -795,13 +795,20 @@
 m_synthesizedErrorsToConsole = page->settings().webGLErrorsToConsoleEnabled();
 }
 
+// FIXME: With ANGLE as a backend this probably isn't needed any more. Unfortunately
+// turning it off causes problems.
 m_isGLES2Compliant = m_context->isGLES2Compliant();
 if (m_isGLES2Compliant) {
 m_isGLES2NPOTStrict = !m_context->getExtensions().isEnabled("GL_OES_texture_npot");
 m_isDepthStencilSupported = m_context->getExtensions().isEnabled("GL_OES_packed_depth_stencil") || m_context->getExtensions().isEnabled("GL_ANGLE_depth_texture");
 } else {
+#if USE(ANGLE)
+m_isGLES2NPOTStrict = true;
+m_isDepthStencilSupported = true;
+#else
 m_isGLES2NPOTStrict = !m_context->getExtensions().isEnabled("GL_ARB_texture_non_power_of_two");
 m_isDepthStencilSupported = m_context->getExtensions().isEnabled("GL_EXT_packed_depth_stencil") || 

[webkit-changes] [257715] trunk/LayoutTests

[lawrence . j]

Title: [257715] trunk/LayoutTests








Revision 257715
Author lawrenc...@apple.com
Date 2020-03-02 08:47:59 -0800 (Mon, 02 Mar 2020)


Log Message
[ Mac wk1 Debug ] mathml/presentation/attributes-accent-accentunder-dynamic.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208449

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257714 => 257715)

--- trunk/LayoutTests/ChangeLog	2020-03-02 16:25:23 UTC (rev 257714)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 16:47:59 UTC (rev 257715)
@@ -1,3 +1,12 @@
+2020-03-02  Jason Lawrence  
+
+[ Mac wk1 Debug ] mathml/presentation/attributes-accent-accentunder-dynamic.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=208449
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2020-03-02  Eric Carlson  
 
 [GPUP] Plumb through more MediaPlayer methods


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (257714 => 257715)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-03-02 16:25:23 UTC (rev 257714)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-03-02 16:47:59 UTC (rev 257715)
@@ -956,4 +956,6 @@
 
 webkit.org/b/208345 fast/canvas/webgl/canvas-webgl-page-cache.html [ Pass Crash ]
 
-webkit.org/b/208384 imported/w3c/web-platform-tests/requestidlecallback/callback-timeout-when-busy.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/208384 imported/w3c/web-platform-tests/requestidlecallback/callback-timeout-when-busy.html [ Pass Failure ]
+
+webkit.org/b/208449 [ Debug ] mathml/presentation/attributes-accent-accentunder-dynamic.html [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257714] trunk/Source/WebCore

[cdumez]

Title: [257714] trunk/Source/WebCore








Revision 257714
Author cdu...@apple.com
Date 2020-03-02 08:25:23 -0800 (Mon, 02 Mar 2020)


Log Message
Add quirk to disable to back/forward cache on docs.google.com
https://bugs.webkit.org/show_bug.cgi?id=208381


Reviewed by Ryosuke Niwa.

Google Docs used to bypass the back/forward cache by serving "Cache-Control: no-store"
over HTTPS. We started caching such content in r250437 but the Google Docs content
unfortunately is not currently compatible because it puts an overlay over the page and
starts an animation when navigating away and fails to remove those when coming back from
the back/forward cache (e.g. in 'pageshow' event handler).

* page/Quirks.cpp:
(WebCore::Quirks::shouldBypassBackForwardCache const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Quirks.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257713 => 257714)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 16:13:32 UTC (rev 257713)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 16:25:23 UTC (rev 257714)
@@ -1,3 +1,20 @@
+2020-03-02  Chris Dumez  
+
+Add quirk to disable to back/forward cache on docs.google.com
+https://bugs.webkit.org/show_bug.cgi?id=208381
+
+
+Reviewed by Ryosuke Niwa.
+
+Google Docs used to bypass the back/forward cache by serving "Cache-Control: no-store"
+over HTTPS. We started caching such content in r250437 but the Google Docs content
+unfortunately is not currently compatible because it puts an overlay over the page and
+starts an animation when navigating away and fails to remove those when coming back from
+the back/forward cache (e.g. in 'pageshow' event handler).
+
+* page/Quirks.cpp:
+(WebCore::Quirks::shouldBypassBackForwardCache const):
+
 2020-03-02  Jacob Uphoff  
 
 Unreviewed, rolling out r257687.


Modified: trunk/Source/WebCore/page/Quirks.cpp (257713 => 257714)

--- trunk/Source/WebCore/page/Quirks.cpp	2020-03-02 16:13:32 UTC (rev 257713)
+++ trunk/Source/WebCore/page/Quirks.cpp	2020-03-02 16:25:23 UTC (rev 257714)
@@ -34,6 +34,7 @@
 #include "EventNames.h"
 #include "FrameLoader.h"
 #include "HTMLBodyElement.h"
+#include "HTMLDivElement.h"
 #include "HTMLMetaElement.h"
 #include "HTMLObjectElement.h"
 #include "JSEventListener.h"
@@ -627,6 +628,19 @@
 return documentLoader->response().cacheControlContainsNoStore();
 }
 
+// Google Docs used to bypass the back/forward cache by serving "Cache-Control: no-store" over HTTPS.
+// We started caching such content in r250437 but the Google Docs index page unfortunately is not currently compatible
+// because it puts an overlay (with class "docs-homescreen-freeze-el-full") over the page when navigating away and fails
+// to remove it when coming back from the back/forward cache (e.g. in 'pageshow' event handler). See .
+// Note that this does not check for docs.google.com host because of hosted G Suite apps.
+static NeverDestroyed googleDocsOverlayDivClass("docs-homescreen-freeze-el-full", AtomString::ConstructFromLiteral);
+auto* firstChildInBody = m_document->body() ? m_document->body()->firstChild() : nullptr;
+if (is(firstChildInBody)) {
+auto& div = downcast(*firstChildInBody);
+if (div.hasClass() && div.classNames().contains(googleDocsOverlayDivClass))
+return true;
+}
+
 return false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257713] trunk

[jacob_uphoff]

Title: [257713] trunk








Revision 257713
Author jacob_uph...@apple.com
Date 2020-03-02 08:13:32 -0800 (Mon, 02 Mar 2020)


Log Message
Unreviewed, rolling out r257687.

This commit caused debug tests to crash for macOS & iOS

Reverted changeset:

"[Cocoa] Mapping from MIME type to UTI type should be done in
the UI process"
https://bugs.webkit.org/show_bug.cgi?id=208415
https://trac.webkit.org/changeset/257687

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/UTIUtilities.h
trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/testing/Internals.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Removed Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (257712 => 257713)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 15:57:15 UTC (rev 257712)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 16:13:32 UTC (rev 257713)
@@ -1,3 +1,16 @@
+2020-03-02  Jacob Uphoff  
+
+Unreviewed, rolling out r257687.
+
+This commit caused debug tests to crash for macOS & iOS
+
+Reverted changeset:
+
+"[Cocoa] Mapping from MIME type to UTI type should be done in
+the UI process"
+https://bugs.webkit.org/show_bug.cgi?id=208415
+https://trac.webkit.org/changeset/257687
+
 2020-03-02  Philippe Normand  
 
 [GStreamer] Get rid of custom GCD implementation


Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.h (257712 => 257713)

--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-02 15:57:15 UTC (rev 257712)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.h	2020-03-02 16:13:32 UTC (rev 257713)
@@ -23,18 +23,17 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
+#ifndef UTIUtilities_h
+#define UTIUtilities_h
 
-#include 
+#import 
+#import 
 
 namespace WebCore {
-
 WEBCORE_EXPORT String MIMETypeFromUTI(const String&);
 String MIMETypeFromUTITree(const String&);
 WEBCORE_EXPORT String UTIFromMIMEType(const String&);
 bool isDeclaredUTI(const String&);
+}
 
-WEBCORE_EXPORT void setUTIFromMIMETypeMap(HashMap&&);
-WEBCORE_EXPORT const HashMap& createUTIFromMIMETypeMap();
-WEBCORE_EXPORT const Vector& mimeTypes();
-}
+#endif // UTIUtilities_h


Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm (257712 => 257713)

--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm	2020-03-02 15:57:15 UTC (rev 257712)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm	2020-03-02 16:13:32 UTC (rev 257713)
@@ -40,8 +40,6 @@
 #define ADDITIONAL_UTI_MAPPINGS
 #endif
 
-#define EMPTY_MIME_TYPE_STRING "emptyMimeType"_s
-
 namespace WebCore {
 
 String MIMETypeFromUTI(const String& uti)
@@ -115,26 +113,10 @@
 return mapEntry->value;
 }
 
-static Optional>& mapUTIFromMIMEType()
-{
-static NeverDestroyed>> map;
-return map;
-}
-
 struct UTIFromMIMETypeCachePolicy : TinyLRUCachePolicy {
 public:
-static String createValueForKey(const String& mimeType)
+static String createValueForKey(const String& key)
 {
-String key = mimeType;
-if (mapUTIFromMIMEType().hasValue()) {
-if (key.isEmpty())
-key = EMPTY_MIME_TYPE_STRING;
-const auto& it = mapUTIFromMIMEType()->find(key);
-if (it != mapUTIFromMIMEType()->end())
-return it->value;
-WTFLogAlways("UTI for MIME type %s not found.", key.utf8().data());
-ASSERT_NOT_REACHED();
-}
 auto type = adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, key.createCFString().get(), 0));
 if (type)
 return type.get();
@@ -142,16 +124,11 @@
 }
 };
 
-static TinyLRUCache& cacheUTIFromMimeType()
-{
-static NeverDestroyed> cache;
-return cache;
-}
-
 String UTIFromMIMEType(const String& mimeType)
 {
 ASSERT(isMainThread());
-return cacheUTIFromMimeType().get(mimeType);
+static NeverDestroyed> cache;
+return cache.get().get(mimeType);
 }
 
 bool isDeclaredUTI(const String& UTI)
@@ -159,66 +136,4 @@
 return UTTypeIsDeclared(UTI.createCFString().get());
 }
 
-const Vector& mimeTypes()
-{
-static NeverDestroyed> mimeTypes = std::initializer_list {
-"application/ogg"_s,
-"audio/ogg"_s,
-"video/ogg"_s,
-"application/annodex"_s,
-"audio/annodex"_s,
-"video/annodex"_s,
-"audio/speex"_s,
-"video/webm"_s,
-"audio/webm"_s,
-  

[webkit-changes] [257712] trunk/Source/WebCore

[philn]

Title: [257712] trunk/Source/WebCore








Revision 257712
Author ph...@webkit.org
Date 2020-03-02 07:57:15 -0800 (Mon, 02 Mar 2020)


Log Message
[GStreamer] Get rid of custom GCD implementation
https://bugs.webkit.org/show_bug.cgi?id=208446

Reviewed by Xabier Rodriguez-Calvar.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::naturalSize const):
(WebCore::greatestCommonDivisor): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (257711 => 257712)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 15:54:29 UTC (rev 257711)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 15:57:15 UTC (rev 257712)
@@ -1,3 +1,14 @@
+2020-03-02  Philippe Normand  
+
+[GStreamer] Get rid of custom GCD implementation
+https://bugs.webkit.org/show_bug.cgi?id=208446
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::naturalSize const):
+(WebCore::greatestCommonDivisor): Deleted.
+
 2020-03-02  Eric Carlson  
 
 [GPUP] Plumb through more MediaPlayer methods


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (257711 => 257712)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2020-03-02 15:54:29 UTC (rev 257711)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2020-03-02 15:57:15 UTC (rev 257712)
@@ -162,17 +162,6 @@
 static const FloatSize s_holePunchDefaultFrameSize(1280, 720);
 #endif
 
-static int greatestCommonDivisor(int a, int b)
-{
-while (b) {
-int temp = a;
-a = b;
-b = temp % b;
-}
-
-return ABS(a);
-}
-
 static void busMessageCallback(GstBus*, GstMessage* message, MediaPlayerPrivateGStreamer* player)
 {
 player->handleMessage(message);
@@ -1923,7 +1912,7 @@
 int displayHeight = originalSize.height() * pixelAspectRatioDenominator;
 
 // Divide display width and height by their GCD to avoid possible overflows.
-int displayAspectRatioGCD = greatestCommonDivisor(displayWidth, displayHeight);
+int displayAspectRatioGCD = gst_util_greatest_common_divisor(displayWidth, displayHeight);
 displayWidth /= displayAspectRatioGCD;
 displayHeight /= displayAspectRatioGCD;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257710] trunk/Source

[youenn]

Title: [257710] trunk/Source








Revision 257710
Author you...@apple.com
Date 2020-03-02 07:41:30 -0800 (Mon, 02 Mar 2020)


Log Message
Enable capture in GPUProcess by default for recent platforms only
https://bugs.webkit.org/show_bug.cgi?id=208437

Reviewed by Eric Carlson.

Source/WebKit:

No change of behavior.

* Shared/WebPreferencesDefaultValues.h:

Source/WTF:

* wtf/PlatformUse.h:
Introduce USE(GPU_PROCESS)

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformUse.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h




Diff

Modified: trunk/Source/WTF/ChangeLog (257709 => 257710)

--- trunk/Source/WTF/ChangeLog	2020-03-02 15:34:07 UTC (rev 257709)
+++ trunk/Source/WTF/ChangeLog	2020-03-02 15:41:30 UTC (rev 257710)
@@ -1,3 +1,13 @@
+2020-03-02  youenn fablet  
+
+Enable capture in GPUProcess by default for recent platforms only
+https://bugs.webkit.org/show_bug.cgi?id=208437
+
+Reviewed by Eric Carlson.
+
+* wtf/PlatformUse.h:
+Introduce USE(GPU_PROCESS)
+
 2020-02-29  Yusuke Suzuki  
 
 Remove std::lock_guard


Modified: trunk/Source/WTF/wtf/PlatformUse.h (257709 => 257710)

--- trunk/Source/WTF/wtf/PlatformUse.h	2020-03-02 15:34:07 UTC (rev 257709)
+++ trunk/Source/WTF/wtf/PlatformUse.h	2020-03-02 15:41:30 UTC (rev 257710)
@@ -323,3 +323,9 @@
 #if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101600)
 #define USE_CTFONTTRANSFORMGLYPHSWITHLANGUAGE 1
 #endif
+
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 14)
+#define USE_GPU_PROCESS 1
+#else
+#define USE_GPU_PROCESS 0
+#endif


Modified: trunk/Source/WebKit/ChangeLog (257709 => 257710)

--- trunk/Source/WebKit/ChangeLog	2020-03-02 15:34:07 UTC (rev 257709)
+++ trunk/Source/WebKit/ChangeLog	2020-03-02 15:41:30 UTC (rev 257710)
@@ -1,3 +1,14 @@
+2020-03-02  youenn fablet  
+
+Enable capture in GPUProcess by default for recent platforms only
+https://bugs.webkit.org/show_bug.cgi?id=208437
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+
+* Shared/WebPreferencesDefaultValues.h:
+
 2020-03-02  Youenn Fablet  
 
 LocalSampleBufferDisplayLayer is not computing the correct bounds/position in GPUProcess


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (257709 => 257710)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-03-02 15:34:07 UTC (rev 257709)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-03-02 15:41:30 UTC (rev 257710)
@@ -232,7 +232,7 @@
 #define DEFAULT_CONIC_GRADIENT_ENABLED false
 #endif
 
-#if PLATFORM(COCOA)
+#if USE(GPU_PROCESS)
 #define DEFAULT_CAPTURE_AUDIO_IN_GPUPROCESS true
 #define DEFAULT_CAPTURE_AUDIO_IN_UIPROCESS false
 #define DEFAULT_CAPTURE_VIDEO_IN_GPUPROCESS true
@@ -240,7 +240,12 @@
 #define DEFAULT_WEBRTC_CODECS_IN_GPUPROCESS true
 #else
 #define DEFAULT_CAPTURE_AUDIO_IN_GPUPROCESS false
+#if PLATFORM(MAC)
+#define DEFAULT_CAPTURE_AUDIO_IN_UIPROCESS true
+#else
 #define DEFAULT_CAPTURE_AUDIO_IN_UIPROCESS false
+#endif
+
 #define DEFAULT_CAPTURE_VIDEO_IN_GPUPROCESS false
 #define DEFAULT_CAPTURE_VIDEO_IN_UIPROCESS false
 #define DEFAULT_WEBRTC_CODECS_IN_GPUPROCESS false






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257709] trunk/Source

[youenn]

Title: [257709] trunk/Source








Revision 257709
Author you...@apple.com
Date 2020-03-02 07:34:07 -0800 (Mon, 02 Mar 2020)


Log Message
LocalSampleBufferDisplayLayer is not computing the correct bounds/position in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=208370

Reviewed by Eric Carlson.

Source/WebCore:

When in GPUProcess, we need to update the bounds of the remote LocalSampleBufferDisplayLayer.
In case of samples with rotation, the computation was wrong.
Move the rotation logic from MediaPLayerPrivateMediaStreamAVFObjC to LocalSampleBufferDisplayLayer.
This allows in WebKit2 to send the rotation information with the bounds information.
Remove the bounds getter since it is no longer used.
Covered by manual tests.

* platform/graphics/avfoundation/SampleBufferDisplayLayer.h:
* platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h:
* platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::updateBoundsAndPosition):
(WebCore::LocalSampleBufferDisplayLayer::updateRootLayerBoundsAndPosition):
(WebCore::LocalSampleBufferDisplayLayer::enqueueSample):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayLayer):
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):

Source/WebKit:

Remove the bounds getter logic.
Make use of new LocalSampleBufferDisplayLayer routine to properly update the layer bounds.

* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::updateBoundsAndPosition):
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::SampleBufferDisplayLayer):
(WebKit::SampleBufferDisplayLayer::updateBoundsAndPosition):
* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (257708 => 257709)

--- trunk/Source/WebCore/ChangeLog	2020-03-02 15:04:56 UTC (rev 257708)
+++ trunk/Source/WebCore/ChangeLog	2020-03-02 15:34:07 UTC (rev 257709)
@@ -1,3 +1,28 @@
+2020-03-02  Youenn Fablet  
+
+LocalSampleBufferDisplayLayer is not computing the correct bounds/position in GPUProcess
+https://bugs.webkit.org/show_bug.cgi?id=208370
+
+Reviewed by Eric Carlson.
+
+When in GPUProcess, we need to update the bounds of the remote LocalSampleBufferDisplayLayer.
+In case of samples with rotation, the computation was wrong.
+Move the rotation logic from MediaPLayerPrivateMediaStreamAVFObjC to LocalSampleBufferDisplayLayer.
+This allows in WebKit2 to send the rotation information with the bounds information.
+Remove the bounds getter since it is no longer used.
+Covered by manual tests.
+
+* platform/graphics/avfoundation/SampleBufferDisplayLayer.h:
+* platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h:
+* platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
+(WebCore::LocalSampleBufferDisplayLayer::updateBoundsAndPosition):
+(WebCore::LocalSampleBufferDisplayLayer::updateRootLayerBoundsAndPosition):
+(WebCore::LocalSampleBufferDisplayLayer::enqueueSample):
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayLayer):
+* platform/mediastream/mac/AVVideoCaptureSource.mm:
+(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
+
 2020-03-02  Rob Buis  
 
 Add referrerpolicy attribute support for anchors

[webkit-changes] [257708] trunk/Source/WebKit

[youenn]

Title: [257708] trunk/Source/WebKit








Revision 257708
Author you...@apple.com
Date 2020-03-02 07:04:56 -0800 (Mon, 02 Mar 2020)


Log Message
Enable audio MediaStreamTrack rendering in GPUProcess if audio capture happens in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=208435

Reviewed by Eric Carlson.

Instead of enabling audio track rendering in GPUProcess based on media flag,
use the audio capture flag.
This makes sure things work properly on iOS, where an audio session might interrupt other sessions.

* WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::updatePreferences):
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::setupCaptureProcesses):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (257707 => 257708)

--- trunk/Source/WebKit/ChangeLog	2020-03-02 11:36:00 UTC (rev 257707)
+++ trunk/Source/WebKit/ChangeLog	2020-03-02 15:04:56 UTC (rev 257708)
@@ -1,3 +1,19 @@
+2020-03-02  youenn fablet  
+
+Enable audio MediaStreamTrack rendering in GPUProcess if audio capture happens in GPUProcess
+https://bugs.webkit.org/show_bug.cgi?id=208435
+
+Reviewed by Eric Carlson.
+
+Instead of enabling audio track rendering in GPUProcess based on media flag,
+use the audio capture flag.
+This makes sure things work properly on iOS, where an audio session might interrupt other sessions.
+
+* WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
+(WebKit::RemoteMediaPlayerManager::updatePreferences):
+* WebProcess/cocoa/UserMediaCaptureManager.cpp:
+(WebKit::UserMediaCaptureManager::setupCaptureProcesses):
+
 2020-03-02  Rob Buis  
 
 Add referrerpolicy attribute support for anchors


Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp (257707 => 257708)

--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp	2020-03-02 11:36:00 UTC (rev 257707)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp	2020-03-02 15:04:56 UTC (rev 257708)
@@ -28,9 +28,7 @@
 
 #if ENABLE(GPU_PROCESS)
 
-#include "AudioMediaStreamTrackRenderer.h"
 #include "MediaPlayerPrivateRemote.h"
-#include "RemoteAudioMediaStreamTrackRenderer.h"
 #include "RemoteMediaPlayerConfiguration.h"
 #include "RemoteMediaPlayerMIMETypeCache.h"
 #include "RemoteMediaPlayerManagerProxyMessages.h"
@@ -253,7 +251,6 @@
 
 #if PLATFORM(COCOA) && ENABLE(VIDEO_TRACK) && ENABLE(MEDIA_STREAM)
 if (settings.useGPUProcessForMedia()) {
-WebCore::AudioMediaStreamTrackRenderer::setCreator(WebKit::AudioMediaStreamTrackRenderer::create);
 WebCore::SampleBufferDisplayLayer::setCreator([](auto& client, bool hideRootLayer, auto size) {
 return WebProcess::singleton().ensureGPUProcessConnection().sampleBufferDisplayLayerManager().createLayer(client, hideRootLayer, size);
 });


Modified: trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp (257707 => 257708)

--- trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp	2020-03-02 11:36:00 UTC (rev 257707)
+++ trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp	2020-03-02 15:04:56 UTC (rev 257708)
@@ -28,7 +28,8 @@
 
 #if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)
 
-#include  "GPUProcessConnection.h"
+#include "AudioMediaStreamTrackRenderer.h"
+#include "GPUProcessConnection.h"
 #include "SharedRingBufferStorage.h"
 #include "UserMediaCaptureManagerMessages.h"
 #include "UserMediaCaptureManagerProxyMessages.h"
@@ -274,6 +275,9 @@
 m_audioFactory.setShouldCaptureInGPUProcess(shouldCaptureAudioInGPUProcess);
 m_videoFactory.setShouldCaptureInGPUProcess(shouldCaptureVideoInGPUProcess);
 
+if (shouldCaptureAudioInGPUProcess)
+WebCore::AudioMediaStreamTrackRenderer::setCreator(WebKit::AudioMediaStreamTrackRenderer::create);
+
 if (shouldCaptureAudioInUIProcess || shouldCaptureAudioInGPUProcess)
 RealtimeMediaSourceCenter::singleton().setAudioCaptureFactory(m_audioFactory);
 if (shouldCaptureVideoInUIProcess || shouldCaptureVideoInGPUProcess)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257706] trunk/LayoutTests

[youenn]

Title: [257706] trunk/LayoutTests








Revision 257706
Author you...@apple.com
Date 2020-03-02 02:52:03 -0800 (Mon, 02 Mar 2020)


Log Message
ASSERTION FAILED: Completion handler should always be called on inspector/dom-debugger/attribute-modified-style.html
https://bugs.webkit.org/show_bug.cgi?id=208167


Unreviewed.


* platform/mac-wk2/TestExpectations:
Removed flaky expectation.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257705 => 257706)

--- trunk/LayoutTests/ChangeLog	2020-03-02 10:27:42 UTC (rev 257705)
+++ trunk/LayoutTests/ChangeLog	2020-03-02 10:52:03 UTC (rev 257706)
@@ -1,3 +1,14 @@
+2020-03-02  youenn fablet  
+
+ASSERTION FAILED: Completion handler should always be called on inspector/dom-debugger/attribute-modified-style.html
+https://bugs.webkit.org/show_bug.cgi?id=208167
+
+
+Unreviewed.
+
+* platform/mac-wk2/TestExpectations:
+Removed flaky expectation.
+
 2020-03-01  Diego Pino Garcia  
 
 [WPE] Gardening, update TestExpectations and baselines


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (257705 => 257706)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 10:27:42 UTC (rev 257705)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-02 10:52:03 UTC (rev 257706)
@@ -1068,8 +1068,6 @@
 
 webkit.org/b/208160 fast/scrolling/overflow-scroll-past-max.html [ Pass Failure ]
 
-webkit.org/b/208167 [ Debug ] inspector/dom-debugger/attribute-modified-style.html [ Pass Crash ]
-
 webkit.org/b/208222 [ Release ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https.html [ Pass Failure ]
 
 webkit.org/b/208264 [ Release ] fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257705] trunk/Source/WebCore

[carlosgc]

Title: [257705] trunk/Source/WebCore








Revision 257705
Author carlo...@webkit.org
Date 2020-03-02 02:27:42 -0800 (Mon, 02 Mar 2020)


Log Message
[GTK][WPE] Stop using mediaControlsBase.js
https://bugs.webkit.org/show_bug.cgi?id=208374

Reviewed by Xabier Rodriguez-Calvar.

Move the required base functionality to mediaControlsAdwaita.js and use that single file.

* Modules/mediacontrols/mediaControlsAdwaita.js:
(createControls):
(Controller):
(Controller.prototype.listenFor):
(Controller.prototype.stopListeningFor):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.handleEvent):
(Controller.prototype.createBase):
(Controller.prototype.isAudio):
(Controller.prototype.isFullScreen):
(Controller.prototype.shouldHaveControls):
(Controller.prototype.updateBase):
(Controller.prototype.createControls):
(Controller.prototype.configureControls):
(Controller.prototype.disconnectControls):
(Controller.prototype.reconnectControls):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.resetHideControlsTimer):
(Controller.prototype.clearHideControlsTimer):
(Controller.prototype.controlsAreAlwaysVisible):
(Controller.prototype.controlsAreHidden):
(Controller.prototype.addControls):
(Controller.prototype.removeControls):
(Controller.prototype.updateControls):
(Controller.prototype.setIsLive):
(Controller.prototype.updateDuration):
(Controller.prototype.formatTime):
(Controller.prototype.setPlaying):
(Controller.prototype.updatePlaying):
(Controller.prototype.updateCaptionButton):
(Controller.prototype.updateCaptionContainer):
(Controller.prototype.updateFullscreenButton):
(Controller.prototype.updateVolume):
(Controller.prototype.updateHasVideo):
(Controller.prototype.handleReadyStateChange):
(Controller.prototype.handleTimeUpdate):
(Controller.prototype.handleDurationChange):
(Controller.prototype.handlePlay):
(Controller.prototype.handlePause):
(Controller.prototype.handleVolumeChange):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleTextTrackChange):
(Controller.prototype.handleTextTrackAdd):
(Controller.prototype.handleTextTrackRemove):
(Controller.prototype.handleControlsChange):
(Controller.prototype.handleWrapperMouseMove):
(Controller.prototype.handleWrapperMouseOut):
(Controller.prototype.handleWrapperMouseUp):
(Controller.prototype.handlePanelMouseDown):
(Controller.prototype.handlePanelTransitionEnd):
(Controller.prototype.handlePanelClick):
(Controller.prototype.canPlay):
(Controller.prototype.handlePlayButtonClicked):
(Controller.prototype.handleTimelineChange):
(Controller.prototype.handleTimelineMouseUp):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMuteButtonMouseOver):
(Controller.prototype.handleVolumeBoxMouseOut):
(Controller.prototype.handleVolumeSliderInput):
(Controller.prototype.handleFullscreenButtonClicked):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.captionItemSelected):
(Controller.prototype.focusSiblingCaptionItem):
(Controller.prototype.handleCaptionItemKeyUp):
(Controller.prototype.showCaptionMenu):
(Controller.prototype.captionMenuTransitionEnd):
(Controller.prototype.captionMenuContainsNode):
(Controller.prototype.handleCaptionButtonClicked):
(Controller.prototype.handleCaptionButtonMouseOver):
(Controller.prototype.handleCaptionButtonMouseOut):
(Controller.prototype.handleCaptionMenuMouseOut):
(ControllerAdwaita): Deleted.
(contains): Deleted.
(ControllerAdwaita.prototype.createControls): Deleted.
(ControllerAdwaita.prototype.configureInlineControls): Deleted.
(ControllerAdwaita.prototype.shouldHaveControls): Deleted.
(ControllerAdwaita.prototype.reconnectControls): Deleted.
(ControllerAdwaita.prototype.setStatusHidden): Deleted.
(ControllerAdwaita.prototype.updateTime): Deleted.
(ControllerAdwaita.prototype.handleTimeUpdate): Deleted.
(ControllerAdwaita.prototype.updateHasAudio): Deleted.
(ControllerAdwaita.prototype.handleMuteButtonMouseOver): Deleted.
(ControllerAdwaita.prototype.handleVolumeBoxMouseOut): Deleted.
(ControllerAdwaita.prototype.removeControls): Deleted.
(ControllerAdwaita.prototype.addControls): Deleted.
(ControllerAdwaita.prototype.updateFullscreenButton): Deleted.
(ControllerAdwaita.prototype.updateReadyState): Deleted.
(ControllerAdwaita.prototype.updateDuration): Deleted.
(ControllerAdwaita.prototype.setIsLive): Deleted.
(ControllerAdwaita.prototype.updatePlaying): Deleted.
(ControllerAdwaita.prototype.updateProgress): Deleted.
(ControllerAdwaita.prototype.handleCaptionButtonClicked): Deleted.
(ControllerAdwaita.prototype.buildCaptionMenu): Deleted.
(ControllerAdwaita.prototype.destroyCaptionMenu): Deleted.
(ControllerAdwaita.prototype.showCaptionMenu): Deleted.
(ControllerAdwaita.prototype.hideCaptionMenu): Deleted.
(ControllerAdwaita.prototype.captionMenuTransitionEnd): Deleted.
(ControllerAdwaita.prototype.handleCaptionButtonMouseOver): Deleted.

[webkit-changes] [257704] releases/WebKitGTK/webkit-2.28/Source/JavaScriptCore

[aperez]

Title: [257704] releases/WebKitGTK/webkit-2.28/Source/_javascript_Core








Revision 257704
Author ape...@igalia.com
Date 2020-03-02 00:41:07 -0800 (Mon, 02 Mar 2020)


Log Message
Merge r257695 - undefined reference to `JSC::ExecutableBase::hasJITCodeForCall() const'
https://bugs.webkit.org/show_bug.cgi?id=207890

Reviewed by Yusuke Suzuki.

Encountered on arm-buildroot-linux-gnueabihf with GCC 9.2.0.

* runtime/NativeExecutable.cpp: Inclusion of
ExecutableBaseInlines.h resolves the issue for me.

Modified Paths

releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/runtime/NativeExecutable.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/ChangeLog (257703 => 257704)

--- releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/ChangeLog	2020-03-02 08:36:52 UTC (rev 257703)
+++ releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/ChangeLog	2020-03-02 08:41:07 UTC (rev 257704)
@@ -1,3 +1,15 @@
+2020-03-01  Charles Turner  
+
+undefined reference to `JSC::ExecutableBase::hasJITCodeForCall() const'
+https://bugs.webkit.org/show_bug.cgi?id=207890
+
+Reviewed by Yusuke Suzuki.
+
+Encountered on arm-buildroot-linux-gnueabihf with GCC 9.2.0.
+
+* runtime/NativeExecutable.cpp: Inclusion of
+ExecutableBaseInlines.h resolves the issue for me.
+
 2020-02-26  Mark Lam  
 
 Enhance JSObjectGetProperty() to mitigate against null object pointers.


Modified: releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/runtime/NativeExecutable.cpp (257703 => 257704)

--- releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/runtime/NativeExecutable.cpp	2020-03-02 08:36:52 UTC (rev 257703)
+++ releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/runtime/NativeExecutable.cpp	2020-03-02 08:41:07 UTC (rev 257704)
@@ -28,6 +28,7 @@
 #include "BatchedTransitionOptimizer.h"
 #include "CodeBlock.h"
 #include "Debugger.h"
+#include "ExecutableBaseInlines.h"
 #include "JIT.h"
 #include "JSCInlines.h"
 #include "LLIntEntrypoint.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257702] releases/WebKitGTK/webkit-2.28/Source/WebKit

[aperez]

Title: [257702] releases/WebKitGTK/webkit-2.28/Source/WebKit








Revision 257702
Author ape...@igalia.com
Date 2020-03-02 00:36:42 -0800 (Mon, 02 Mar 2020)


Log Message
Merge r257700 - [GTK] Fix the build when Wayland target is disabled
https://bugs.webkit.org/show_bug.cgi?id=208407

Patch by Ting-Wei Lan  on 2020-03-01
Reviewed by Darin Adler.

Values in the enum WebCore::PlatformDisplay::Type are only defined when
their corresponding platform targets are enabled, so we need #if checks
around uses of them.

* UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU):
* UIProcess/API/glib/WebKitUIClient.cpp:
(UIClient::windowConfigureEventCallback):

Modified Paths

releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog (257701 => 257702)

--- releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog	2020-03-02 04:29:10 UTC (rev 257701)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog	2020-03-02 08:36:42 UTC (rev 257702)
@@ -1,3 +1,19 @@
+2020-03-01  Ting-Wei Lan  
+
+[GTK] Fix the build when Wayland target is disabled
+https://bugs.webkit.org/show_bug.cgi?id=208407
+
+Reviewed by Darin Adler.
+
+Values in the enum WebCore::PlatformDisplay::Type are only defined when
+their corresponding platform targets are enabled, so we need #if checks
+around uses of them.
+
+* UIProcess/API/glib/WebKitProtocolHandler.cpp:
+(WebKit::WebKitProtocolHandler::handleGPU):
+* UIProcess/API/glib/WebKitUIClient.cpp:
+(UIClient::windowConfigureEventCallback):
+
 2020-02-27  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.91 release


Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp (257701 => 257702)

--- releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp	2020-03-02 04:29:10 UTC (rev 257701)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp	2020-03-02 08:36:42 UTC (rev 257702)
@@ -286,8 +286,15 @@
 "  Type"
 "  %s"
 " ",
-PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland ? "Wayland" : "X11");
+#if PLATFORM(WAYLAND)
+PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland ? "Wayland" :
 #endif
+#if PLATFORM(X11)
+PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::X11 ? "X11" :
+#endif
+"Unknown"
+);
+#endif
 
 auto rect = IntRect(screenRect(nullptr));
 g_string_append_printf(html,


Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp (257701 => 257702)

--- releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2020-03-02 04:29:10 UTC (rev 257701)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2020-03-02 08:36:42 UTC (rev 257702)
@@ -144,7 +144,10 @@
 {
 GdkRectangle geometry = { 0, 0, 0, 0 };
 // Position a toplevel window is not supported under wayland.
-if (WebCore::PlatformDisplay::sharedDisplay().type() != WebCore::PlatformDisplay::Type::Wayland) {
+#if PLATFORM(WAYLAND)
+if (WebCore::PlatformDisplay::sharedDisplay().type() != WebCore::PlatformDisplay::Type::Wayland)
+#endif
+{
 gtk_window_get_position(window, , );
 if (geometry.x != targetGeometry->x || geometry.y != targetGeometry->y)
 return FALSE;
@@ -172,7 +175,10 @@
 if (webkit_web_view_is_controlled_by_automation(m_webView) && WebCore::widgetIsOnscreenToplevelWindow(window) && gtk_widget_get_visible(window)) {
 bool needsMove = false;
 // Position a toplevel window is not supported under wayland.
-if (WebCore::PlatformDisplay::sharedDisplay().type() != WebCore::PlatformDisplay::Type::Wayland) {
+#if PLATFORM(WAYLAND)
+if (WebCore::PlatformDisplay::sharedDisplay().type() != WebCore::PlatformDisplay::Type::Wayland)
+#endif
+{
 if (geometry.x >= 0 && geometry.y >= 0) {
 int x, y;
 gtk_window_get_position(GTK_WINDOW(window), , );






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257703] releases/WebKitGTK/webkit-2.28/Source/WebCore

[aperez]

Title: [257703] releases/WebKitGTK/webkit-2.28/Source/WebCore








Revision 257703
Author ape...@igalia.com
Date 2020-03-02 00:36:52 -0800 (Mon, 02 Mar 2020)


Log Message
Merge r256706 - [GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
https://bugs.webkit.org/show_bug.cgi?id=207757

Unreviewed build fix.

No new tests needed.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::dataReceived): Add std:: namespace to overloaded
std::isnan() function call to ensure that the overloaded version for WTF::WallTime
is used.

Modified Paths

releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (257702 => 257703)

--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog	2020-03-02 08:36:42 UTC (rev 257702)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog	2020-03-02 08:36:52 UTC (rev 257703)
@@ -1,3 +1,17 @@
+2020-02-15  Adrian Perez de Castro  
+
+[GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
+https://bugs.webkit.org/show_bug.cgi?id=207757
+
+Unreviewed build fix.
+
+No new tests needed.
+
+* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+(CachedResourceStreamingClient::dataReceived): Add std:: namespace to overloaded
+std::isnan() function call to ensure that the overloaded version for WTF::WallTime
+is used.
+
 2020-02-26  Jack Lee  
 
 Nullptr crash in WebCore::canHaveChildrenForEditing via CompositeEditCommand::insertNode


Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (257702 => 257703)

--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2020-03-02 08:36:42 UTC (rev 257702)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2020-03-02 08:36:52 UTC (rev 257703)
@@ -1152,7 +1152,7 @@
 // Rough bandwidth calculation. We ignore here the first data package because we would have to reset the counters when we issue the request and
 // that first package delivery would include the time of sending out the request and getting the data back. Since we can't distinguish the
 // sending time from the receiving time, it is better to ignore it.
-if (!isnan(priv->downloadStartTime)) {
+if (!std::isnan(priv->downloadStartTime)) {
 priv->totalDownloadedBytes += length;
 double timeSinceStart = (WallTime::now() - priv->downloadStartTime).seconds();
 GST_TRACE_OBJECT(src, "downloaded %" G_GUINT64_FORMAT " bytes in %f seconds =~ %1.0f bytes/second", priv->totalDownloadedBytes, timeSinceStart






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes