[webkit-changes] [254563] trunk/Tools
Title: [254563] trunk/Tools
Revision 254563
Author ab...@igalia.com
Date 2020-01-15 03:45:50 -0800 (Wed, 15 Jan 2020)
Log Message
[WTF] Remove MediaTime.cpp test warning in GCC
https://bugs.webkit.org/show_bug.cgi?id=206238
Reviewed by Xabier Rodriguez-Calvar.
GCC emits warnings when it finds clang pragmas, so I'm wrapping them
in #if COMPILER(CLANG) to reduce the noise.
* TestWebKitAPI/Tests/WTF/MediaTime.cpp:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp
Diff
Modified: trunk/Tools/ChangeLog (254562 => 254563)
--- trunk/Tools/ChangeLog 2020-01-15 11:30:52 UTC (rev 254562)
+++ trunk/Tools/ChangeLog 2020-01-15 11:45:50 UTC (rev 254563)
@@ -1,3 +1,15 @@
+2020-01-15 Alicia Boya García
+
+[WTF] Remove MediaTime.cpp test warning in GCC
+https://bugs.webkit.org/show_bug.cgi?id=206238
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+GCC emits warnings when it finds clang pragmas, so I'm wrapping them
+in #if COMPILER(CLANG) to reduce the noise.
+
+* TestWebKitAPI/Tests/WTF/MediaTime.cpp:
+
2020-01-14 Commit Queue
Unreviewed, rolling out r254480, r254496, and r254517.
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp (254562 => 254563)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp 2020-01-15 11:30:52 UTC (rev 254562)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp 2020-01-15 11:45:50 UTC (rev 254563)
@@ -58,10 +58,14 @@
// MediaTime values should be able to be declared static anywhere, just like you can do so with integers.
// This should not require global constructors or destructors.
+#if COMPILER(CLANG)
#pragma clang diagnostic push
#pragma clang diagnostic error "-Wglobal-constructors"
+#endif
static const MediaTime oneSecond(1, 1);
+#if COMPILER(CLANG)
#pragma clang diagnostic pop
+#endif
TEST(WTF, MediaTime)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254566] trunk/Source/WebCore
Title: [254566] trunk/Source/WebCore Revision 254566 Author andresg...@apple.com Date 2020-01-15 06:42:44 -0800 (Wed, 15 Jan 2020) Log Message Implementation of AXIsolatedObject::press(). https://bugs.webkit.org/show_bug.cgi?id=206177 Reviewed by Chris Fleizach. - Implemented AXIsolatedObject::press(). - For link objects, press causes the destruction and re-creation of the isolated tree. Thus also added AXIsolatedTree:removeTreeForPageID. - AXIsolatedTree::applyPendingChanges now also properly detaches isolated objects that have been removed. - Moved set and get wrapper to AXCoreObject so that it can be used for both isolated and live objects. * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::~AXObjectCache): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::createIsolatedTreeHierarchy): * accessibility/AXObjectCache.h: (WebCore::AXObjectCache::detachWrapper): * accessibility/AccessibilityObject.h: * accessibility/AccessibilityObjectInterface.h: (WebCore::AXCoreObject::wrapper const): (WebCore::AXCoreObject::setWrapper): * accessibility/atk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::detachWrapper): * accessibility/ios/AXObjectCacheIOS.mm: (WebCore::AXObjectCache::detachWrapper): * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::removeTreeForPageID): (WebCore::AXIsolatedTree::applyPendingChanges): * accessibility/isolatedtree/AXIsolatedTree.h: * accessibility/isolatedtree/AXIsolatedTreeNode.cpp: (WebCore::AXIsolatedObject::detach): (WebCore::AXIsolatedObject::detachFromParent): (WebCore::AXIsolatedObject::children): (WebCore::AXIsolatedObject::isDetachedFromParent): (WebCore::AXIsolatedObject::performFunctionOnMainThread): (WebCore::AXIsolatedObject::findTextRanges const): (WebCore::AXIsolatedObject::performTextOperation): (WebCore::AXIsolatedObject::press): (WebCore::AXIsolatedObject::widget const): (WebCore::AXIsolatedObject::page const): (WebCore::AXIsolatedObject::document const): (WebCore::AXIsolatedObject::documentFrameView const): * accessibility/isolatedtree/AXIsolatedTreeNode.h: * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::detachWrapper): * accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::detachWrapper): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AXObjectCache.h trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (254565 => 254566) --- trunk/Source/WebCore/ChangeLog 2020-01-15 14:40:01 UTC (rev 254565) +++ trunk/Source/WebCore/ChangeLog 2020-01-15 14:42:44 UTC (rev 254566) @@ -1,3 +1,55 @@ +2020-01-15 Andres Gonzalez + +Implementation of AXIsolatedObject::press(). +https://bugs.webkit.org/show_bug.cgi?id=206177 + +Reviewed by Chris Fleizach. + +- Implemented AXIsolatedObject::press(). +- For link objects, press causes the destruction and re-creation of the +isolated tree. Thus also added AXIsolatedTree:removeTreeForPageID. +- AXIsolatedTree::applyPendingChanges now also properly detaches isolated +objects that have been removed. +- Moved set and get wrapper to AXCoreObject so that it can be used for +both isolated and live objects. + +* accessibility/AXObjectCache.cpp: +(WebCore::AXObjectCache::~AXObjectCache): +(WebCore::AXObjectCache::remove): +(WebCore::AXObjectCache::createIsolatedTreeHierarchy): +* accessibility/AXObjectCache.h: +(WebCore::AXObjectCache::detachWrapper): +* accessibility/AccessibilityObject.h: +* accessibility/AccessibilityObjectInterface.h: +(WebCore::AXCoreObject::wrapper const): +(WebCore::AXCoreObject::setWrapper): +* accessibility/atk/AXObjectCacheAtk.cpp: +(WebCore::AXObjectCache::detachWrapper): +* accessibility/ios/AXObjectCacheIOS.mm: +(WebCore::AXObjectCache::detachWrapper): +* accessibility/isolatedtree/AXIsolatedTree.cpp: +(WebCore::AXIsolatedTree::removeTreeForPageID): +(WebCore::AXIsolatedTree::applyPendingChanges): +* accessibility/isolatedtree/AXIsolatedTree.h: +* accessibility/isolatedtree/AXIsolatedTreeNode.cpp: +(WebCore::AXIsolatedObject::detach): +(WebCore::AXIsolatedObject::detachFromParent): +
[webkit-changes] [254562] trunk
Title: [254562] trunk Revision 254562 Author you...@apple.com Date 2020-01-15 03:30:52 -0800 (Wed, 15 Jan 2020) Log Message Add support for MediaStream audio track rendering in GPUProcess https://bugs.webkit.org/show_bug.cgi?id=206175 Reviewed by Eric Carlson. Source/WebCore: Simplify model to use start/stop instead of setPaused. Simplify and fix issue in computation of the muted state of the renderer. Covered by existing tests run with GPU process enabled and manual testing * platform/mediastream/AudioMediaStreamTrackRenderer.h: * platform/mediastream/AudioTrackPrivateMediaStream.cpp: (WebCore::AudioTrackPrivateMediaStream::playInternal): (WebCore::AudioTrackPrivateMediaStream::pause): (WebCore::AudioTrackPrivateMediaStream::audioSamplesAvailable): (WebCore::AudioTrackPrivateMediaStream::updateRendererMutedState): * platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp: (WebCore::AudioMediaStreamTrackRendererCocoa::start): (WebCore::AudioMediaStreamTrackRendererCocoa::stop): (WebCore::AudioMediaStreamTrackRendererCocoa::clear): (WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples): (WebCore::AudioMediaStreamTrackRendererCocoa::render): * platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h: Source/WebKit: Implement an AudioMediaStreamTrackRenderer at WebKit level by creating a remote renderer in GPUProcess and sending IPC to pass audio data as well as orders (start/stop/setMuted). Implement the remote renderer using WebCore audio track renderer. Enable WebKit remote renderer F GPU process for media is enabled. * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::audioTrackRendererManager): (WebKit::GPUConnectionToWebProcess::didReceiveMessage): * GPUProcess/GPUConnectionToWebProcess.h: * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp: Added. (WebKit::nextLogIdentifier): (WebKit::nullLogger): (WebKit::RemoteAudioMediaStreamTrackRenderer::RemoteAudioMediaStreamTrackRenderer): (WebKit::RemoteAudioMediaStreamTrackRenderer::~RemoteAudioMediaStreamTrackRenderer): (WebKit::RemoteAudioMediaStreamTrackRenderer::storage): (WebKit::RemoteAudioMediaStreamTrackRenderer::start): (WebKit::RemoteAudioMediaStreamTrackRenderer::stop): (WebKit::RemoteAudioMediaStreamTrackRenderer::clear): (WebKit::RemoteAudioMediaStreamTrackRenderer::setMuted): (WebKit::RemoteAudioMediaStreamTrackRenderer::setVolume): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesAvailable): * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h: Added. * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in: Added. * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp: Added. (WebKit::RemoteAudioMediaStreamTrackRendererManager::didReceiveRendererMessage): (WebKit::RemoteAudioMediaStreamTrackRendererManager::createRenderer): (WebKit::RemoteAudioMediaStreamTrackRendererManager::releaseRenderer): * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h: Added. (WebKit::RemoteAudioMediaStreamTrackRendererManager::didReceiveMessageFromWebProcess): * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.messages.in: Added. * Scripts/webkit/messages.py: * Sources.txt: * SourcesCocoa.txt: * WebKit.xcodeproj/project.pbxproj: * WebProcess/GPU/media/RemoteMediaPlayerManager.cpp: (WebKit::RemoteMediaPlayerManager::updatePreferences): * WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp: Added. (WebKit::AudioMediaStreamTrackRenderer::create): (WebKit::AudioMediaStreamTrackRenderer::AudioMediaStreamTrackRenderer): (WebKit::AudioMediaStreamTrackRenderer::~AudioMediaStreamTrackRenderer): (WebKit::AudioMediaStreamTrackRenderer::start): (WebKit::AudioMediaStreamTrackRenderer::stop): (WebKit::AudioMediaStreamTrackRenderer::clear): (WebKit::AudioMediaStreamTrackRenderer::setMuted): (WebKit::AudioMediaStreamTrackRenderer::setVolume): (WebKit::AudioMediaStreamTrackRenderer::pushSamples): (WebKit::AudioMediaStreamTrackRenderer::storageChanged): * WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h: Added. (WebKit::AudioMediaStreamTrackRenderer::identifier const): * WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererIdentifier.h: Added. LayoutTests: * gpu-process/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/gpu-process/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mediastream/AudioMediaStreamTrackRenderer.h trunk/Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp trunk/Source/WebCore/platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp trunk/Source/WebCore/platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/DerivedSources-input.xcfilelist trunk/Source/WebKit/DerivedSources-output.xcfilelist
[webkit-changes] [254567] trunk
Title: [254567] trunk Revision 254567 Author clo...@igalia.com Date 2020-01-15 06:44:06 -0800 (Wed, 15 Jan 2020) Log Message [GTK] Turn off antialiasing when rendering with Ahem https://bugs.webkit.org/show_bug.cgi?id=204671 Reviewed by Carlos Garcia Campos. Source/WebCore: Many CSS related tests use the "Ahem" font to compare its special squared glyphs with the positioned elements of the test. But if we enable antialiasing for this font, then the antialiasing of the glyphs causes small pixel differences with the reference test. So, this patch disables antialiasing for the Ahem font in GTK and WPE ports. This commit its pretty much like r252701 for the Mac/iOS ports. Covered by existing tests. * platform/graphics/cairo/GraphicsContextImplCairo.cpp: (WebCore::GraphicsContextImplCairo::drawGlyphs): * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): * platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::Font::platformInit): LayoutTests: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.cpp trunk/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp Diff Modified: trunk/LayoutTests/ChangeLog (254566 => 254567) --- trunk/LayoutTests/ChangeLog 2020-01-15 14:42:44 UTC (rev 254566) +++ trunk/LayoutTests/ChangeLog 2020-01-15 14:44:06 UTC (rev 254567) @@ -1,3 +1,12 @@ +2020-01-15 Carlos Alberto Lopez Perez + +[GTK] Turn off antialiasing when rendering with Ahem +https://bugs.webkit.org/show_bug.cgi?id=204671 + +Reviewed by Carlos Garcia Campos. + +* platform/gtk/TestExpectations: + 2020-01-15 youenn fablet Add support for MediaStream audio track rendering in GPUProcess Modified: trunk/LayoutTests/platform/gtk/TestExpectations (254566 => 254567) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-01-15 14:42:44 UTC (rev 254566) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-01-15 14:44:06 UTC (rev 254567) @@ -3218,17 +3218,6 @@ webkit.org/b/152788 imported/mozilla/svg/filter-scaled-02.html [ ImageOnlyFailure Pass ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-001.html [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-002.html [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-003.html [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-004.html [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-002.xht [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-px-001.xht [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-stacking-001.xht [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-shorthand-001.xht [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-span-all-block-sibling-003.xht [ ImageOnlyFailure ] -webkit.org/b/152821 imported/w3c/web-platform-tests/css/css-multicol/multicol-span-all-margin-nested-firstchild-001.xht [ ImageOnlyFailure ] - webkit.org/b/152908 pageoverlay/overlay-installation.html [ Failure ] webkit.org/b/152908 pageoverlay/overlay-large-document-scrolled.html [ Failure ] webkit.org/b/152908 pageoverlay/overlay-large-document.html [ Failure ] @@ -3943,42 +3932,7 @@ webkit.org/b/99036 pointer-lock/locked-element-iframe-removed-from-dom.html [ Failure ] webkit.org/b/99036 pointer-lock/pointerlockchange-pointerlockerror-events.html [ Failure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-fraction-003.xht [ ImageOnlyFailure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-shorthand-2.xht [ ImageOnlyFailure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-001.html [ ImageOnlyFailure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-002.html [ ImageOnlyFailure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-003.html [ ImageOnlyFailure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-004.html [ ImageOnlyFailure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-005.html [ ImageOnlyFailure ] -webkit.org/b/204671 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-006.html [ ImageOnlyFailure
[webkit-changes] [254564] trunk/Source/WebCore
Title: [254564] trunk/Source/WebCore Revision 254564 Author you...@apple.com Date 2020-01-15 06:24:12 -0800 (Wed, 15 Jan 2020) Log Message Introduce an abstract SampleBufferDisplayLayer https://bugs.webkit.org/show_bug.cgi?id=206066 Reviewed by Eric Carlson. Move use of display layers in MediaPlayerPrivateMediaStreamAVFObjC to a new class LocalSampleBufferDisplayLayer that implements an interface named SampleBufferDisplayLayer. A future patch will implement this interface by IPCing to GPUProcess. We move both layers and handling of the sample queue to LocalSampleBufferDisplayLayer. Contrary to previously, we do not call again enqueueVideoSample in case we enqueued a sample for later use in the display layer. Instead, we directly render it, which should not change much since this is a realtime track and in the future the buffer will be in GPUProcess anyway. * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/avfoundation/SampleBufferDisplayLayer.h: Added. (WebCore::SampleBufferDisplayLayer::SampleBufferDisplayLayer): * platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h: Added. * platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm: Added. (-[WebAVSampleBufferStatusChangeListener initWithParent:]): (-[WebAVSampleBufferStatusChangeListener dealloc]): (-[WebAVSampleBufferStatusChangeListener invalidate]): (-[WebAVSampleBufferStatusChangeListener beginObservingLayers]): (-[WebAVSampleBufferStatusChangeListener stopObservingLayers]): (-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]): (WebCore::runWithoutAnimations): (WebCore::LocalSampleBufferDisplayLayer::LocalSampleBufferDisplayLayer): (WebCore::LocalSampleBufferDisplayLayer::~LocalSampleBufferDisplayLayer): (WebCore::LocalSampleBufferDisplayLayer::layerStatusDidChange): (WebCore::LocalSampleBufferDisplayLayer::layerErrorDidChange): (WebCore::LocalSampleBufferDisplayLayer::rootLayerBoundsDidChange): (WebCore::LocalSampleBufferDisplayLayer::displayLayer): (WebCore::LocalSampleBufferDisplayLayer::rootLayer): (WebCore::LocalSampleBufferDisplayLayer::didFail const): (WebCore::LocalSampleBufferDisplayLayer::updateDisplayMode): (WebCore::LocalSampleBufferDisplayLayer::bounds const): (WebCore::LocalSampleBufferDisplayLayer::updateAffineTransform): (WebCore::LocalSampleBufferDisplayLayer::updateBoundsAndPosition): (WebCore::LocalSampleBufferDisplayLayer::ensureLayers): (WebCore::LocalSampleBufferDisplayLayer::flush): (WebCore::LocalSampleBufferDisplayLayer::flushAndRemoveImage): (WebCore::LocalSampleBufferDisplayLayer::enqueueSample): (WebCore::LocalSampleBufferDisplayLayer::removeOldSamplesFromPendingQueue): (WebCore::LocalSampleBufferDisplayLayer::addSampleToPendingQueue): (WebCore::LocalSampleBufferDisplayLayer::clearEnqueuedSamples): (WebCore::LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData): * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueCorrectedVideoSample): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferDisplayLayerStatusDidChange): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::applicationDidBecomeActive): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::flushRenderers): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayers): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformLayer const): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::displayLayer): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setBufferingPolicy): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayLayer): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferDisplayLayerBoundsDidChange): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm Added Paths trunk/Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm Diff Modified: trunk/Source/WebCore/ChangeLog (254563 => 254564) --- trunk/Source/WebCore/ChangeLog 2020-01-15 11:45:50 UTC (rev 254563) +++ trunk/Source/WebCore/ChangeLog 2020-01-15 14:24:12
[webkit-changes] [254565] trunk/Source/WebCore
Title: [254565] trunk/Source/WebCore
Revision 254565
Author commit-qu...@webkit.org
Date 2020-01-15 06:40:01 -0800 (Wed, 15 Jan 2020)
Log Message
[GStreamer] Several buffering fixes
https://bugs.webkit.org/show_bug.cgi?id=206234
Patch by Thibault Saunier on 2020-01-15
Reviewed by Xabier Rodriguez-Calvar.
No new tests as this is already tested.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::durationChanged): Minor typo fix
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Query buffering on the pipeline not the source
otherwise GstBaseSrc returns some useless values before `downloadbuffer` actually gives us the
info about DOWNLOAD buffering status. Also ignores response if they are not in DOWNLOAD mode as those
will end up screwing our buffering management algorithm.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- Detect when DOWNLOAD is done by using the `downloadbuffer` `GstCacheDownloadComplete`
element message which is what is supposed to be used for that purpose.
- Fix the way we detect that buffering is done (mostly when using a `downloadbuffer`) by relying on a
buffering query to check if it is still buffering.
(WebCore::MediaPlayerPrivateGStreamer::updateBufferingStatus): Ensure that we properly pause the pipeline when
restarting buffering. There were cases when not using `downloadbuffer` where we didn't pause the pipeline
leading to pretty bad user experience.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Buffering should happen only on **non live** pipelines.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (254564 => 254565)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 14:24:12 UTC (rev 254564)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 14:40:01 UTC (rev 254565)
@@ -1,3 +1,28 @@
+2020-01-15 Thibault Saunier
+
+[GStreamer] Several buffering fixes
+https://bugs.webkit.org/show_bug.cgi?id=206234
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+No new tests as this is already tested.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::durationChanged): Minor typo fix
+(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Query buffering on the pipeline not the source
+otherwise GstBaseSrc returns some useless values before `downloadbuffer` actually gives us the
+info about DOWNLOAD buffering status. Also ignores response if they are not in DOWNLOAD mode as those
+will end up screwing our buffering management algorithm.
+(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+- Detect when DOWNLOAD is done by using the `downloadbuffer` `GstCacheDownloadComplete`
+ element message which is what is supposed to be used for that purpose.
+- Fix the way we detect that buffering is done (mostly when using a `downloadbuffer`) by relying on a
+ buffering query to check if it is still buffering.
+(WebCore::MediaPlayerPrivateGStreamer::updateBufferingStatus): Ensure that we properly pause the pipeline when
+restarting buffering. There were cases when not using `downloadbuffer` where we didn't pause the pipeline
+leading to pretty bad user experience.
+(WebCore::MediaPlayerPrivateGStreamer::updateStates): Buffering should happen only on **non live** pipelines.
+
2020-01-15 youenn fablet
Introduce an abstract SampleBufferDisplayLayer
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (254564 => 254565)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-01-15 14:24:12 UTC (rev 254564)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-01-15 14:40:01 UTC (rev 254565)
@@ -1053,7 +1053,7 @@
MediaTime previousDuration = durationMediaTime();
m_cachedDuration = MediaTime::invalidTime();
-// Avoid emiting durationchanged in the case where the previous
+// Avoid emitting durationChanged in the case where the previous
// duration was 0 because that case is already handled by the
// HTMLMediaElement.
if (previousDuration && durationMediaTime() != previousDuration)
@@ -1456,7 +1456,7 @@
double fillStatus = 100.0;
GstBufferingMode mode = GST_BUFFERING_DOWNLOAD;
-if (gst_element_query(m_source.get(), query.get())) {
+if (gst_element_query(pipeline(), query.get())) {
gst_query_parse_buffering_stats(query.get(), , nullptr, nullptr, nullptr);
int percentage;
@@ -1470,7 +1470,10 @@
return;
}
-updateBufferingStatus(mode, fillStatus);
+if (mode != GST_BUFFERING_DOWNLOAD)
+
[webkit-changes] [254569] trunk/Source/WebKit
Title: [254569] trunk/Source/WebKit
Revision 254569
Author ddkil...@apple.com
Date 2020-01-15 08:18:17 -0800 (Wed, 15 Jan 2020)
Log Message
[Cocoa] Create a simulated crash log when the UI Process receives an invalid CoreIPC message
Reviewed by Chris Dumez.
* UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::logInvalidMessage):
- Extract common logging code to new method that calls
RELEASE_LOG_FAULT().
* UIProcess/AuxiliaryProcessProxy.h:
(WebKit::AuxiliaryProcessProxy::logInvalidMessage):
(WebKit::AuxiliaryProcessProxy::processName):
- Add method declarations.
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::didReceiveInvalidMessage):
- Use new AuxiliaryProcessProxy::logInvalidMessage().
* UIProcess/GPU/GPUProcessProxy.h:
(WebKit::GPUProcessProxy::processName const):
- Add implementation.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
- Use new AuxiliaryProcessProxy::logInvalidMessage().
* UIProcess/Network/NetworkProcessProxy.h:
(WebKit::NetworkProcessProxy::processName const):
- Add implementation.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
- Use new AuxiliaryProcessProxy::logInvalidMessage().
* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit::PluginProcessProxy::processName const):
- Add implementation.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
- Use new AuxiliaryProcessProxy::logInvalidMessage().
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::processName const):
- Add implementation.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (254568 => 254569)
--- trunk/Source/WebKit/ChangeLog 2020-01-15 15:46:09 UTC (rev 254568)
+++ trunk/Source/WebKit/ChangeLog 2020-01-15 16:18:17 UTC (rev 254569)
@@ -1,3 +1,48 @@
+2020-01-15 David Kilzer
+
+[Cocoa] Create a simulated crash log when the UI Process receives an invalid CoreIPC message
+
+
+
+Reviewed by Chris Dumez.
+
+* UIProcess/AuxiliaryProcessProxy.cpp:
+(WebKit::AuxiliaryProcessProxy::logInvalidMessage):
+- Extract common logging code to new method that calls
+ RELEASE_LOG_FAULT().
+* UIProcess/AuxiliaryProcessProxy.h:
+(WebKit::AuxiliaryProcessProxy::logInvalidMessage):
+(WebKit::AuxiliaryProcessProxy::processName):
+- Add method declarations.
+
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::didReceiveInvalidMessage):
+- Use new AuxiliaryProcessProxy::logInvalidMessage().
+* UIProcess/GPU/GPUProcessProxy.h:
+(WebKit::GPUProcessProxy::processName const):
+- Add implementation.
+
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
+- Use new AuxiliaryProcessProxy::logInvalidMessage().
+* UIProcess/Network/NetworkProcessProxy.h:
+(WebKit::NetworkProcessProxy::processName const):
+- Add implementation.
+
+* UIProcess/Plugins/PluginProcessProxy.cpp:
+(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
+- Use new AuxiliaryProcessProxy::logInvalidMessage().
+* UIProcess/Plugins/PluginProcessProxy.h:
+(WebKit::PluginProcessProxy::processName const):
+- Add implementation.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::didReceiveInvalidMessage):
+- Use new AuxiliaryProcessProxy::logInvalidMessage().
+* UIProcess/WebProcessProxy.h:
+(WebKit::WebProcessProxy::processName const):
+- Add implementation.
+
2020-01-15 youenn fablet
Add support for MediaStream audio track rendering in GPUProcess
Modified: trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp (254568 => 254569)
--- trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2020-01-15 15:46:09 UTC (rev 254568)
+++ trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2020-01-15 16:18:17 UTC (rev 254569)
@@ -271,4 +271,9 @@
{
}
+void AuxiliaryProcessProxy::logInvalidMessage(IPC::Connection& connection, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
+{
+RELEASE_LOG_FAULT(IPC, "Received an invalid message '%{public}s::%{public}s' from the %{public}s process.",
[webkit-changes] [254572] trunk/Source/WTF
Title: [254572] trunk/Source/WTF
Revision 254572
Author wei...@apple.com
Date 2020-01-15 09:48:50 -0800 (Wed, 15 Jan 2020)
Log Message
Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out of Platform.h and into a new PlatformLegacy.h
https://bugs.webkit.org/show_bug.cgi?id=206272
Reviewed by Anders Carlsson.
As a another step towards cleaning up Platform.h, split out all the legacy platform
macros into their own file.
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/Platform.h:
* wtf/PlatformLegacy.h: Copied from Source/WTF/wtf/Platform.h.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WTF/wtf/Platform.h
Added Paths
trunk/Source/WTF/wtf/PlatformLegacy.h
Diff
Modified: trunk/Source/WTF/ChangeLog (254571 => 254572)
--- trunk/Source/WTF/ChangeLog 2020-01-15 17:18:19 UTC (rev 254571)
+++ trunk/Source/WTF/ChangeLog 2020-01-15 17:48:50 UTC (rev 254572)
@@ -1,5 +1,20 @@
2020-01-14 Sam Weinig
+Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out of Platform.h and into a new PlatformLegacy.h
+https://bugs.webkit.org/show_bug.cgi?id=206272
+
+Reviewed by Anders Carlsson.
+
+As a another step towards cleaning up Platform.h, split out all the legacy platform
+macros into their own file.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/CMakeLists.txt:
+* wtf/Platform.h:
+* wtf/PlatformLegacy.h: Copied from Source/WTF/wtf/Platform.h.
+
+2020-01-14 Sam Weinig
+
Plaform.h helper files should have a consistent naming scheme
https://bugs.webkit.org/show_bug.cgi?id=206240
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (254571 => 254572)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-01-15 17:18:19 UTC (rev 254571)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-01-15 17:48:50 UTC (rev 254572)
@@ -447,6 +447,7 @@
7C42307123CE2D8A006E54D0 /* PlatformEnable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformEnable.h; sourceTree = ""; };
7C42307223CE2D8A006E54D0 /* PlatformCPU.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformCPU.h; sourceTree = ""; };
7C42307323CE2D8B006E54D0 /* PlatformOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformOS.h; sourceTree = ""; };
+ 7C42307423CEB187006E54D0 /* PlatformLegacy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformLegacy.h; sourceTree = ""; };
7C9692941F66306E00267A9E /* KeyValuePair.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KeyValuePair.h; sourceTree = ""; };
7CBBA07319BB7FDC00BBF025 /* OSObjectPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSObjectPtr.h; sourceTree = ""; };
7CD0D5A71D55322A000CC9E1 /* Variant.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Variant.h; sourceTree = ""; };
@@ -1127,6 +1128,7 @@
A876DBD7151816E500DADB95 /* Platform.h */,
7C42307223CE2D8A006E54D0 /* PlatformCPU.h */,
7C42307123CE2D8A006E54D0 /* PlatformEnable.h */,
+7C42307423CEB187006E54D0 /* PlatformLegacy.h */,
7C42307323CE2D8B006E54D0 /* PlatformOS.h */,
FE1E2C41224187C600F6B729 /* PlatformRegisters.cpp */,
E3200AB41E9A536D003B59D2 /* PlatformRegisters.h */,
Modified: trunk/Source/WTF/wtf/CMakeLists.txt (254571 => 254572)
--- trunk/Source/WTF/wtf/CMakeLists.txt 2020-01-15 17:18:19 UTC (rev 254571)
+++ trunk/Source/WTF/wtf/CMakeLists.txt 2020-01-15 17:48:50 UTC (rev 254572)
@@ -173,6 +173,7 @@
Platform.h
PlatformCPU.h
PlatformEnable.h
+PlatformLegacy.h
PlatformOS.h
PlatformRegisters.h
PointerComparison.h
Modified: trunk/Source/WTF/wtf/Platform.h (254571 => 254572)
--- trunk/Source/WTF/wtf/Platform.h 2020-01-15 17:18:19 UTC (rev 254571)
+++ trunk/Source/WTF/wtf/Platform.h 2020-01-15 17:48:50 UTC (rev 254572)
@@ -30,20 +30,20 @@
/* Include compiler specific macros */
#include
-/* Include CPU specific macros */
+/* Platform adaptation macros: these describe properties of the target environment. */
+
+/* CPU() - the target CPU architecture */
#include
-/* Include underlying operating system specific macros */
+/* OS() - underlying operating system; only to be used for mandated low-level services like
+ virtual memory, not to choose a GUI toolkit */
#include
-/* PLATFORM handles OS, operating environment, graphics API, and
+/* PLATFORM() - handles OS, operating environment, graphics API, and
CPU. This macro will be phased out in favor of platform adaptation
- macros, policy decision macros, and top-level port definitions. */
-#define
[webkit-changes] [254574] trunk
Title: [254574] trunk
Revision 254574
Author jer.no...@apple.com
Date 2020-01-15 09:59:39 -0800 (Wed, 15 Jan 2020)
Log Message
Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
https://bugs.webkit.org/show_bug.cgi?id=206206
Reviewed by Eric Carlson.
Source/WebCore:
Test: fullscreen/fullscreen-user-agent-style.html
Add the "width:100%;height:100%;" from the modern Fullscreen API spec to our own
fullscreen stylesheet, and revert the quirk for reddit.com.
* css/fullscreen.css:
(:-webkit-full-screen):
* page/Quirks.cpp:
(WebCore::Quirks::needsFullWidthHeightFullscreenStyleQuirk const): Deleted.
* page/Quirks.h:
* style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
LayoutTests:
* fullscreen/full-screen-test.js:
(waitFor):
* fullscreen/fullscreen-user-agent-style-expected.txt: Added.
* fullscreen/fullscreen-user-agent-style.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fullscreen/full-screen-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/fullscreen.css
trunk/Source/WebCore/page/Quirks.cpp
trunk/Source/WebCore/page/Quirks.h
trunk/Source/WebCore/style/UserAgentStyle.cpp
Added Paths
trunk/LayoutTests/fullscreen/fullscreen-user-agent-style-expected.txt
trunk/LayoutTests/fullscreen/fullscreen-user-agent-style.html
Diff
Modified: trunk/LayoutTests/ChangeLog (254573 => 254574)
--- trunk/LayoutTests/ChangeLog 2020-01-15 17:50:58 UTC (rev 254573)
+++ trunk/LayoutTests/ChangeLog 2020-01-15 17:59:39 UTC (rev 254574)
@@ -1,3 +1,15 @@
+2020-01-15 Jer Noble
+
+Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
+https://bugs.webkit.org/show_bug.cgi?id=206206
+
+Reviewed by Eric Carlson.
+
+* fullscreen/full-screen-test.js:
+(waitFor):
+* fullscreen/fullscreen-user-agent-style-expected.txt: Added.
+* fullscreen/fullscreen-user-agent-style.html: Added.
+
2020-01-15 Truitt Savell
REGRESSION: [ Mac iOS ] storage/websql/statement-error-callback.html is timing out flakily
Modified: trunk/LayoutTests/fullscreen/full-screen-test.js (254573 => 254574)
--- trunk/LayoutTests/fullscreen/full-screen-test.js 2020-01-15 17:50:58 UTC (rev 254573)
+++ trunk/LayoutTests/fullscreen/full-screen-test.js 2020-01-15 17:59:39 UTC (rev 254574)
@@ -144,6 +144,16 @@
element.addEventListener(eventName, _eventCallback);
}
+function waitFor(element, type, silent) {
+return new Promise(resolve => {
+element.addEventListener(type, event => {
+if (!silent)
+consoleWrite(`EVENT(${event.type})`);
+resolve(event);
+}, { once: true });
+});
+}
+
function waitForEventTestAndEnd(element, eventName, testFuncString)
{
waitForEventAndTest(element, eventName, testFuncString, true);
@@ -173,3 +183,5 @@
return;
logConsole().innerHTML += text + "";
}
+
+
Added: trunk/LayoutTests/fullscreen/fullscreen-user-agent-style-expected.txt (0 => 254574)
--- trunk/LayoutTests/fullscreen/fullscreen-user-agent-style-expected.txt (rev 0)
+++ trunk/LayoutTests/fullscreen/fullscreen-user-agent-style-expected.txt 2020-01-15 17:59:39 UTC (rev 254574)
@@ -0,0 +1,12 @@
+EXPECTED (document.defaultView.getComputedStyle(span, null).getPropertyValue('width') == 'auto') OK
+EXPECTED (document.defaultView.getComputedStyle(span, null).getPropertyValue('height') == 'auto') OK
+RUN(span.webkitRequestFullscreen())
+EVENT(webkitfullscreenchange)
+EXPECTED (document.defaultView.getComputedStyle(span, null).getPropertyValue('width') == '100%') OK
+EXPECTED (document.defaultView.getComputedStyle(span, null).getPropertyValue('height') == '100%') OK
+RUN(document.webkitExitFullscreen())
+EVENT(webkitfullscreenchange)
+EXPECTED (document.defaultView.getComputedStyle(span, null).getPropertyValue('width') == 'auto') OK
+EXPECTED (document.defaultView.getComputedStyle(span, null).getPropertyValue('height') == 'auto') OK
+END OF TEST
+
Added: trunk/LayoutTests/fullscreen/fullscreen-user-agent-style.html (0 => 254574)
--- trunk/LayoutTests/fullscreen/fullscreen-user-agent-style.html (rev 0)
+++ trunk/LayoutTests/fullscreen/fullscreen-user-agent-style.html 2020-01-15 17:59:39 UTC (rev 254574)
@@ -0,0 +1,32 @@
+
+
+
+fullscreen-user-agent-style
+
+window.addEventListener('load', async event => {
+window.span = document.querySelector('span');
+
+testExpected("document.defaultView.getComputedStyle(span, null).getPropertyValue('width')", "auto");
+testExpected("document.defaultView.getComputedStyle(span, null).getPropertyValue('height')", "auto");
+
+runWithKeyDown(() => { run("span.webkitRequestFullscreen()") });
+await waitFor(span, 'webkitfullscreenchange');
+
+
[webkit-changes] [254576] trunk
Title: [254576] trunk
Revision 254576
Author achristen...@apple.com
Date 2020-01-15 10:40:56 -0800 (Wed, 15 Jan 2020)
Log Message
Null Ptr Deref @ WebCore::DocumentLoader::clearMainResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=206204
Source/WebCore:
Patch by Pinki Gyanchandani on 2020-01-15
Reviewed by Alex Christensen.
Test: loader/change-src-during-iframe-load-crash.html
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::frameLoader const):
(WebCore::DocumentLoader::clearMainResourceLoader):
LayoutTests:
Added a NULL pointer check for FrameLoader. If FramLoader is NULL then return instead of
accessing activeDocumentLoader.
Patch by Pinki Gyanchandani on 2020-01-15
Reviewed by Alex Christensen.
* loader/change-src-during-iframe-load-crash-expected.txt: Added.
* loader/change-src-during-iframe-load-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
Added Paths
trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt
trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (254575 => 254576)
--- trunk/LayoutTests/ChangeLog 2020-01-15 18:22:16 UTC (rev 254575)
+++ trunk/LayoutTests/ChangeLog 2020-01-15 18:40:56 UTC (rev 254576)
@@ -1,3 +1,16 @@
+2020-01-15 Pinki Gyanchandani
+
+Null Ptr Deref @ WebCore::DocumentLoader::clearMainResourceLoader
+https://bugs.webkit.org/show_bug.cgi?id=206204
+
+Added a NULL pointer check for FrameLoader. If FramLoader is NULL then return instead of
+accessing activeDocumentLoader.
+
+Reviewed by Alex Christensen.
+
+* loader/change-src-during-iframe-load-crash-expected.txt: Added.
+* loader/change-src-during-iframe-load-crash.html: Added.
+
2020-01-15 Jer Noble
Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
Modified: trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt (254575 => 254576)
--- trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt 2020-01-15 18:22:16 UTC (rev 254575)
+++ trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt 2020-01-15 18:40:56 UTC (rev 254576)
@@ -1,2 +1,3 @@
+asdf
ALERT: PASS
Added: trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt (0 => 254576)
--- trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt 2020-01-15 18:40:56 UTC (rev 254576)
@@ -0,0 +1 @@
+The test is declared pass if there is no crash observed.
Added: trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html (0 => 254576)
--- trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html (rev 0)
+++ trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html 2020-01-15 18:40:56 UTC (rev 254576)
@@ -0,0 +1,20 @@
+
+
+function load() {
+document.body.innerHTML = 'The test is declared pass if there is no crash observed.';
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+}
+
+function eventhandler3() {
+iframe1.srcdoc = "x";
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (254575 => 254576)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 18:22:16 UTC (rev 254575)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 18:40:56 UTC (rev 254576)
@@ -1,3 +1,16 @@
+2020-01-15 Pinki Gyanchandani
+
+Null Ptr Deref @ WebCore::DocumentLoader::clearMainResourceLoader
+https://bugs.webkit.org/show_bug.cgi?id=206204
+
+Reviewed by Alex Christensen.
+
+Test: loader/change-src-during-iframe-load-crash.html
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::frameLoader const):
+(WebCore::DocumentLoader::clearMainResourceLoader):
+
2020-01-15 Jer Noble
Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (254575 => 254576)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-01-15 18:22:16 UTC (rev 254575)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-01-15 18:40:56 UTC (rev 254576)
@@ -1272,7 +1272,11 @@
{
m_loadingMainResource = false;
-if (this == frameLoader()->activeDocumentLoader())
+auto* frameLoader = this->frameLoader();
+if (!frameLoader)
+return;
+
+if (this == frameLoader->activeDocumentLoader())
checkLoadComplete();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254568] trunk/Source/WebCore
Title: [254568] trunk/Source/WebCore
Revision 254568
Author an...@apple.com
Date 2020-01-15 07:46:09 -0800 (Wed, 15 Jan 2020)
Log Message
[LFC][Integration] Call SimpleLineLayout::canUseFor only once
https://bugs.webkit.org/show_bug.cgi?id=206281
Reviewed by Sam Weinig.
It can be somewhat costly.
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::canUseFor):
* layout/integration/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::canUseFor):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (254567 => 254568)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 14:44:06 UTC (rev 254567)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 15:46:09 UTC (rev 254568)
@@ -1,3 +1,19 @@
+2020-01-15 Antti Koivisto
+
+[LFC][Integration] Call SimpleLineLayout::canUseFor only once
+https://bugs.webkit.org/show_bug.cgi?id=206281
+
+Reviewed by Sam Weinig.
+
+It can be somewhat costly.
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::canUseFor):
+* layout/integration/LayoutIntegrationLineLayout.h:
+(WebCore::LayoutIntegration::LineLayout::canUseFor):
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::layoutInlineChildren):
+
2020-01-15 Carlos Alberto Lopez Perez
[GTK] Turn off antialiasing when rendering with Ahem
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (254567 => 254568)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2020-01-15 14:44:06 UTC (rev 254567)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2020-01-15 15:46:09 UTC (rev 254568)
@@ -58,13 +58,17 @@
LineLayout::~LineLayout() = default;
-bool LineLayout::canUseFor(const RenderBlockFlow& flow)
+bool LineLayout::canUseFor(const RenderBlockFlow& flow, Optional couldUseSimpleLineLayout)
{
if (!RuntimeEnabledFeatures::sharedFeatures().layoutFormattingContextIntegrationEnabled())
return false;
// Initially only a subset of SLL features is supported.
-if (!SimpleLineLayout::canUseFor(flow))
+auto passesSimpleLineLayoutTest = valueOrCompute(couldUseSimpleLineLayout, [&] {
+return SimpleLineLayout::canUseFor(flow);
+});
+
+if (!passesSimpleLineLayoutTest)
return false;
if (flow.containsFloats())
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h (254567 => 254568)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h 2020-01-15 14:44:06 UTC (rev 254567)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h 2020-01-15 15:46:09 UTC (rev 254568)
@@ -58,7 +58,7 @@
LineLayout(const RenderBlockFlow&);
~LineLayout();
-static bool canUseFor(const RenderBlockFlow&);
+static bool canUseFor(const RenderBlockFlow&, Optional couldUseSimpleLineLayout = { });
void updateStyle();
void layout();
Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (254567 => 254568)
--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2020-01-15 14:44:06 UTC (rev 254567)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2020-01-15 15:46:09 UTC (rev 254568)
@@ -669,12 +669,14 @@
void RenderBlockFlow::layoutInlineChildren(bool relayoutChildren, LayoutUnit& repaintLogicalTop, LayoutUnit& repaintLogicalBottom)
{
auto computeLineLayoutPath = [&] {
+bool canUseSimpleLines = SimpleLineLayout::canUseFor(*this);
#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
-if (LayoutIntegration::LineLayout::canUseFor(*this))
+if (LayoutIntegration::LineLayout::canUseFor(*this, canUseSimpleLines))
return LayoutFormattingContextPath;
#endif
-if (SimpleLineLayout::canUseFor(*this))
+if (canUseSimpleLines)
return SimpleLinesPath;
+
return LineBoxesPath;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254573] trunk/LayoutTests
Title: [254573] trunk/LayoutTests Revision 254573 Author tsav...@apple.com Date 2020-01-15 09:50:58 -0800 (Wed, 15 Jan 2020) Log Message REGRESSION: [ Mac iOS ] storage/websql/statement-error-callback.html is timing out flakily https://bugs.webkit.org/show_bug.cgi?id=206291 Unreviewed test gardening. * platform/ios/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (254572 => 254573) --- trunk/LayoutTests/ChangeLog 2020-01-15 17:48:50 UTC (rev 254572) +++ trunk/LayoutTests/ChangeLog 2020-01-15 17:50:58 UTC (rev 254573) @@ -1,3 +1,13 @@ +2020-01-15 Truitt Savell + +REGRESSION: [ Mac iOS ] storage/websql/statement-error-callback.html is timing out flakily +https://bugs.webkit.org/show_bug.cgi?id=206291 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: + 2020-01-15 Carlos Alberto Lopez Perez [GTK] Turn off antialiasing when rendering with Ahem Modified: trunk/LayoutTests/platform/ios/TestExpectations (254572 => 254573) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-01-15 17:48:50 UTC (rev 254572) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-01-15 17:50:58 UTC (rev 254573) @@ -3462,3 +3462,5 @@ webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageOnlyFailure ] webkit.org/b/200043 fast/text/international/system-language/navigator-language [ Pass Failure ] + +webkit.org/b/206291 storage/websql/statement-error-callback.html [ Pass Timeout ] \ No newline at end of file Modified: trunk/LayoutTests/platform/mac/TestExpectations (254572 => 254573) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-01-15 17:48:50 UTC (rev 254572) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-01-15 17:50:58 UTC (rev 254573) @@ -1933,3 +1933,5 @@ # Locale-specific shaping is only enabled on certain OSes. webkit.org/b/77568 [ Sierra HighSierra Mojave ] fast/text/locale-shaping.html [ ImageOnlyFailure ] webkit.org/b/77568 [ Sierra HighSierra Mojave ] fast/text/locale-shaping-complex.html [ ImageOnlyFailure ] + +webkit.org/b/206291 storage/websql/statement-error-callback.html [ Pass Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254570] branches/safari-610.1.1-branch/Source
Title: [254570] branches/safari-610.1.1-branch/Source
Revision 254570
Author alanc...@apple.com
Date 2020-01-15 09:14:33 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254551. rdar://problem/58508705
Build ANGLE as a dynamic library
https://bugs.webkit.org/show_bug.cgi?id=204708
rdar://57349384
Rolling this out for the 2nd time.
Source/ThirdParty/ANGLE:
- it caused issues with the shared dyld cache, because the
cache doesn't know to include the libary until it already
exists in the build
- probably related to the above, we saw some performance
regressions directly related to this change
* ANGLE.xcodeproj/project.pbxproj:
* Configurations/ANGLE.xcconfig:
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* include/CMakeLists.txt:
* include/GLSLANG/ShaderLang.h:
* include/GLSLANG/ShaderVars.h:
* src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
(rx::DisplayCGL::isValidNativeWindow const):
* src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:
(rx::WindowSurfaceCGL::WindowSurfaceCGL):
(rx::WindowSurfaceCGL::~WindowSurfaceCGL):
* src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:
(rx::DisplayEAGL::terminate):
(rx::DisplayEAGL::isValidNativeWindow const):
(rx::WorkerContextEAGL::~WorkerContextEAGL):
* src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm:
(rx::WindowSurfaceEAGL::WindowSurfaceEAGL):
(rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):
Source/WebCore:
* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::ANGLEWebKitBridge::angleAvailable): Deleted.
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/include/CMakeLists.txt
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/DisplayCGL.mm
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm
branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm
branches/safari-610.1.1-branch/Source/WebCore/ChangeLog
branches/safari-610.1.1-branch/Source/WebCore/Configurations/WebCore.xcconfig
branches/safari-610.1.1-branch/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
branches/safari-610.1.1-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-610.1.1-branch/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp
branches/safari-610.1.1-branch/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h
branches/safari-610.1.1-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm
Diff
Modified: branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (254569 => 254570)
--- branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-15 16:18:17 UTC (rev 254569)
+++ branches/safari-610.1.1-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-15 17:14:33 UTC (rev 254570)
@@ -455,6 +455,7 @@
5CB301461DE39F1A00D2C405 /* VertexArrayGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301131DE39F1A00D2C405 /* VertexArrayGL.h */; };
5CB3014F1DE39F4700D2C405 /* DisplayCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301491DE39F4700D2C405 /* DisplayCGL.h */; };
5CB301511DE39F4700D2C405 /* PbufferSurfaceCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB3014B1DE39F4700D2C405 /* PbufferSurfaceCGL.h */; };
+ 5CB304921DE4156200D2C405 /* OpenGL.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048D1DE4144400D2C405 /* OpenGL.framework */; };
5CB304931DE4156B00D2C405 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048F1DE4145500D2C405 /* QuartzCore.framework
[webkit-changes] [254571] branches/safari-609.1.14-branch/Source
Title: [254571] branches/safari-609.1.14-branch/Source
Revision 254571
Author alanc...@apple.com
Date 2020-01-15 09:18:19 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254551. rdar://problem/58508705
Build ANGLE as a dynamic library
https://bugs.webkit.org/show_bug.cgi?id=204708
rdar://57349384
Rolling this out for the 2nd time.
Source/ThirdParty/ANGLE:
- it caused issues with the shared dyld cache, because the
cache doesn't know to include the libary until it already
exists in the build
- probably related to the above, we saw some performance
regressions directly related to this change
* ANGLE.xcodeproj/project.pbxproj:
* Configurations/ANGLE.xcconfig:
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* include/CMakeLists.txt:
* include/GLSLANG/ShaderLang.h:
* include/GLSLANG/ShaderVars.h:
* src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
(rx::DisplayCGL::isValidNativeWindow const):
* src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:
(rx::WindowSurfaceCGL::WindowSurfaceCGL):
(rx::WindowSurfaceCGL::~WindowSurfaceCGL):
* src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:
(rx::DisplayEAGL::terminate):
(rx::DisplayEAGL::isValidNativeWindow const):
(rx::WorkerContextEAGL::~WorkerContextEAGL):
* src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm:
(rx::WindowSurfaceEAGL::WindowSurfaceEAGL):
(rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):
Source/WebCore:
* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::ANGLEWebKitBridge::angleAvailable): Deleted.
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/include/CMakeLists.txt
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/DisplayCGL.mm
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm
branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm
branches/safari-609.1.14-branch/Source/WebCore/ChangeLog
branches/safari-609.1.14-branch/Source/WebCore/Configurations/WebCore.xcconfig
branches/safari-609.1.14-branch/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
branches/safari-609.1.14-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-609.1.14-branch/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp
branches/safari-609.1.14-branch/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h
branches/safari-609.1.14-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm
Diff
Modified: branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (254570 => 254571)
--- branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-15 17:14:33 UTC (rev 254570)
+++ branches/safari-609.1.14-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-15 17:18:19 UTC (rev 254571)
@@ -455,6 +455,7 @@
5CB301461DE39F1A00D2C405 /* VertexArrayGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301131DE39F1A00D2C405 /* VertexArrayGL.h */; };
5CB3014F1DE39F4700D2C405 /* DisplayCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301491DE39F4700D2C405 /* DisplayCGL.h */; };
5CB301511DE39F4700D2C405 /* PbufferSurfaceCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB3014B1DE39F4700D2C405 /* PbufferSurfaceCGL.h */; };
+ 5CB304921DE4156200D2C405 /* OpenGL.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048D1DE4144400D2C405 /* OpenGL.framework */; };
5CB304931DE4156B00D2C405 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048F1DE4145500D2C405 /*
[webkit-changes] [254575] trunk/Websites/webkit.org
Title: [254575] trunk/Websites/webkit.org Revision 254575 Author j...@apple.com Date 2020-01-15 10:22:16 -0800 (Wed, 15 Jan 2020) Log Message Ensure UAs update the stylesheet https://bugs.webkit.org/show_bug.cgi?id=206292 Reviewed by Devin Rousso. * wp-content/themes/webkit/header.php: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/wp-content/themes/webkit/header.php Diff Modified: trunk/Websites/webkit.org/ChangeLog (254574 => 254575) --- trunk/Websites/webkit.org/ChangeLog 2020-01-15 17:59:39 UTC (rev 254574) +++ trunk/Websites/webkit.org/ChangeLog 2020-01-15 18:22:16 UTC (rev 254575) @@ -1,3 +1,12 @@ +2020-01-15 Jon Davis + +Ensure UAs update the stylesheet +https://bugs.webkit.org/show_bug.cgi?id=206292 + +Reviewed by Devin Rousso. + +* wp-content/themes/webkit/header.php: + 2020-01-14 Jon Davis Display authors of a Web Inspector reference article Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/header.php (254574 => 254575) --- trunk/Websites/webkit.org/wp-content/themes/webkit/header.php 2020-01-15 17:59:39 UTC (rev 254574) +++ trunk/Websites/webkit.org/wp-content/themes/webkit/header.php 2020-01-15 18:22:16 UTC (rev 254575) @@ -11,7 +11,7 @@ -?20181220" media="all"> +?20200115" media="all"> ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254577] trunk/LayoutTests
Title: [254577] trunk/LayoutTests Revision 254577 Author tsav...@apple.com Date 2020-01-15 10:58:42 -0800 (Wed, 15 Jan 2020) Log Message REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html is a flaky failure on Mac wk2 https://bugs.webkit.org/show_bug.cgi?id=206296 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (254576 => 254577) --- trunk/LayoutTests/ChangeLog 2020-01-15 18:40:56 UTC (rev 254576) +++ trunk/LayoutTests/ChangeLog 2020-01-15 18:58:42 UTC (rev 254577) @@ -1,3 +1,12 @@ +2020-01-15 Truitt Savell + +REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html is a flaky failure on Mac wk2 +https://bugs.webkit.org/show_bug.cgi?id=206296 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-01-15 Pinki Gyanchandani Null Ptr Deref @ WebCore::DocumentLoader::clearMainResourceLoader Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (254576 => 254577) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-01-15 18:40:56 UTC (rev 254576) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-01-15 18:58:42 UTC (rev 254577) @@ -927,3 +927,5 @@ webkit.org/b/205301 [ Mojave+ ] inspector/canvas/requestShaderSource-webgpu.html [ Pass Failure ] webkit.org/b/205808 fast/text/international/unicode-bidi-other-neutrals.html [ Pass Failure ] + +webkit.org/b/206296 [ Debug ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254579] trunk/Websites/webkit.org
Title: [254579] trunk/Websites/webkit.org
Revision 254579
Author drou...@apple.com
Date 2020-01-15 11:12:20 -0800 (Wed, 15 Jan 2020)
Log Message
Web Inspector Reference: the meta info at the end of the article should always be on its own line
https://bugs.webkit.org/show_bug.cgi?id=206277
Reviewed by Timothy Hatcher.
* wp-content/themes/webkit/style.css:
(article .bodycopy, article .meta):
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/style.css
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (254578 => 254579)
--- trunk/Websites/webkit.org/ChangeLog 2020-01-15 19:11:23 UTC (rev 254578)
+++ trunk/Websites/webkit.org/ChangeLog 2020-01-15 19:12:20 UTC (rev 254579)
@@ -1,5 +1,15 @@
2020-01-15 Devin Rousso
+Web Inspector Reference: the meta info at the end of the article should always be on its own line
+https://bugs.webkit.org/show_bug.cgi?id=206277
+
+Reviewed by Timothy Hatcher.
+
+* wp-content/themes/webkit/style.css:
+(article .bodycopy, article .meta):
+
+2020-01-15 Devin Rousso
+
Web Inspector Reference: put the original author and last modified author on separate lines
https://bugs.webkit.org/show_bug.cgi?id=206274
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/style.css (254578 => 254579)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2020-01-15 19:11:23 UTC (rev 254578)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2020-01-15 19:12:20 UTC (rev 254579)
@@ -1645,6 +1645,7 @@
article .bodycopy,
article .meta {
+clear: both;
width: 66%;
margin: 0 auto;
position: relative;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254578] trunk/Websites/webkit.org
Title: [254578] trunk/Websites/webkit.org
Revision 254578
Author drou...@apple.com
Date 2020-01-15 11:11:23 -0800 (Wed, 15 Jan 2020)
Log Message
Web Inspector Reference: put the original author and last modified author on separate lines
https://bugs.webkit.org/show_bug.cgi?id=206274
Reviewed by Timothy Hatcher.
* wp-content/themes/webkit/single-web_inspector_page.php:
* wp-content/themes/webkit/style.css:
(article .meta .written): Added.
(article .meta .written, article .meta .updated): Added.
(article .meta .updated): Deleted.
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/single-web_inspector_page.php
trunk/Websites/webkit.org/wp-content/themes/webkit/style.css
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (254577 => 254578)
--- trunk/Websites/webkit.org/ChangeLog 2020-01-15 18:58:42 UTC (rev 254577)
+++ trunk/Websites/webkit.org/ChangeLog 2020-01-15 19:11:23 UTC (rev 254578)
@@ -1,3 +1,16 @@
+2020-01-15 Devin Rousso
+
+Web Inspector Reference: put the original author and last modified author on separate lines
+https://bugs.webkit.org/show_bug.cgi?id=206274
+
+Reviewed by Timothy Hatcher.
+
+* wp-content/themes/webkit/single-web_inspector_page.php:
+* wp-content/themes/webkit/style.css:
+(article .meta .written): Added.
+(article .meta .written, article .meta .updated): Added.
+(article .meta .updated): Deleted.
+
2020-01-15 Jon Davis
Ensure UAs update the stylesheet
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/single-web_inspector_page.php (254577 => 254578)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/single-web_inspector_page.php 2020-01-15 18:58:42 UTC (rev 254577)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/single-web_inspector_page.php 2020-01-15 19:11:23 UTC (rev 254578)
@@ -14,7 +14,8 @@
-Written by . Last updated by
+Written by
+Last updated by
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/style.css (254577 => 254578)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2020-01-15 18:58:42 UTC (rev 254577)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2020-01-15 19:11:23 UTC (rev 254578)
@@ -1603,6 +1603,11 @@
font-style: italic;
}
+article .meta .written {
+margin-bottom: 1em;
+}
+
+article .meta .written,
article .meta .updated {
text-align: right;
font-size: 1.2rem;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254605] branches/safari-609-branch/LayoutTests
Title: [254605] branches/safari-609-branch/LayoutTests
Revision 254605
Author alanc...@apple.com
Date 2020-01-15 11:15:30 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254260. rdar://problem/58552882
REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205893
Reviewed by Eric Carlson.
* webrtc/video-autoplay.html:
Speculative fix as I am not able to reproduce locally.
Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
We should therefore ensure that the video element is paused before calling getUserMedia.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html
Diff
Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254604 => 254605)
--- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:27 UTC (rev 254604)
+++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:30 UTC (rev 254605)
@@ -1,5 +1,36 @@
2020-01-14 Alan Coon
+Cherry-pick r254260. rdar://problem/58552882
+
+REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205893
+
+
+Reviewed by Eric Carlson.
+
+* webrtc/video-autoplay.html:
+Speculative fix as I am not able to reproduce locally.
+Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
+We should therefore ensure that the video element is paused before calling getUserMedia.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-09 Youenn Fablet
+
+REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205893
+
+
+Reviewed by Eric Carlson.
+
+* webrtc/video-autoplay.html:
+Speculative fix as I am not able to reproduce locally.
+Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
+We should therefore ensure that the video element is paused before calling getUserMedia.
+
+2020-01-14 Alan Coon
+
Cherry-pick r254201. rdar://problem/58552859
[Web Animations] Stop creating CSS Animations for elements
Modified: branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html (254604 => 254605)
--- branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html 2020-01-15 19:15:27 UTC (rev 254604)
+++ branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html 2020-01-15 19:15:30 UTC (rev 254605)
@@ -102,12 +102,17 @@
let removedVideo2 = video2;
removedVideo2.remove();
+let cptr = 0;
+while (++cptr < 20 && !removedVideo2.paused)
+await new Promise(resolve => setTimeout(resolve, 50));
+assert_true(removedVideo2.paused, "out of DOM video should get paused");
+
video4.srcObject = await navigator.mediaDevices.getUserMedia({ video : true });
while (video4.paused)
await new Promise(resolve => setTimeout(resolve, 50));
-assert_true(removedVideo2.paused, "out of DOM video");
+assert_true(removedVideo2.paused, "out of DOM video should not restart after getUserMedia call");
}, "Granting getUserMedia should not start paused media 2");
promise_test(async (test) => {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254611] branches/safari-609-branch/Source/WebKit
Title: [254611] branches/safari-609-branch/Source/WebKit
Revision 254611
Author alanc...@apple.com
Date 2020-01-15 11:15:47 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254310. rdar://problem/58552856
Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled()
https://bugs.webkit.org/show_bug.cgi?id=206035
Reviewed by Brent Fulgham.
No new tests.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setResourceLoadStatisticsEnabled):
Added a check that m_sessionID exists.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254610 => 254611)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:44 UTC (rev 254610)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:47 UTC (rev 254611)
@@ -1,5 +1,38 @@
2020-01-14 Alan Coon
+Cherry-pick r254310. rdar://problem/58552856
+
+Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled()
+https://bugs.webkit.org/show_bug.cgi?id=206035
+
+
+Reviewed by Brent Fulgham.
+
+No new tests.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::setResourceLoadStatisticsEnabled):
+Added a check that m_sessionID exists.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-09 John Wilander
+
+Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled()
+https://bugs.webkit.org/show_bug.cgi?id=206035
+
+
+Reviewed by Brent Fulgham.
+
+No new tests.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::setResourceLoadStatisticsEnabled):
+Added a check that m_sessionID exists.
+
+2020-01-14 Alan Coon
+
Cherry-pick r254293. rdar://problem/58549084
Resource Load Statistics: Flip experimental website data removal setting from an enable to a disable
Modified: branches/safari-609-branch/Source/WebKit/WebProcess/WebProcess.cpp (254610 => 254611)
--- branches/safari-609-branch/Source/WebKit/WebProcess/WebProcess.cpp 2020-01-15 19:15:44 UTC (rev 254610)
+++ branches/safari-609-branch/Source/WebKit/WebProcess/WebProcess.cpp 2020-01-15 19:15:47 UTC (rev 254611)
@@ -1634,7 +1634,7 @@
void WebProcess::setResourceLoadStatisticsEnabled(bool enabled)
{
-if (WebCore::DeprecatedGlobalSettings::resourceLoadStatisticsEnabled() == enabled || m_sessionID->isEphemeral())
+if (WebCore::DeprecatedGlobalSettings::resourceLoadStatisticsEnabled() == enabled || (m_sessionID && m_sessionID->isEphemeral()))
return;
WebCore::DeprecatedGlobalSettings::setResourceLoadStatisticsEnabled(enabled);
#if ENABLE(RESOURCE_LOAD_STATISTICS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254597] branches/safari-609-branch
Title: [254597] branches/safari-609-branch
Revision 254597
Author alanc...@apple.com
Date 2020-01-15 11:15:05 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254188. rdar://problem/58553146
AI rule for ValueMod/ValueDiv produce constants with the wrong format when the result can be an int32
https://bugs.webkit.org/show_bug.cgi?id=205906
Reviewed by Yusuke Suzuki.
JSTests:
* stress/ai-value-div-should-result-in-constant-int-where-possible.js: Added.
(foo.bar.f):
(foo.):
(foo):
* stress/ai-value-mod-should-result-in-constant-int-where-possible.js: Added.
(foo.bar.f):
(foo.):
(foo):
Source/_javascript_Core:
The runtime code for ValueMod and ValueDiv produces an int32 when the result
is of int32 value. However, the AI was saying the result is in double format.
This patch fixes AI to produce a JSValue in the right format.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::handleConstantDivOp):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/JSTests/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
Added Paths
branches/safari-609-branch/JSTests/stress/ai-value-div-should-result-in-constant-int-where-possible.js
branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js
Diff
Modified: branches/safari-609-branch/JSTests/ChangeLog (254596 => 254597)
--- branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:15:02 UTC (rev 254596)
+++ branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:15:05 UTC (rev 254597)
@@ -1,3 +1,53 @@
+2020-01-14 Alan Coon
+
+Cherry-pick r254188. rdar://problem/58553146
+
+AI rule for ValueMod/ValueDiv produce constants with the wrong format when the result can be an int32
+https://bugs.webkit.org/show_bug.cgi?id=205906
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/ai-value-div-should-result-in-constant-int-where-possible.js: Added.
+(foo.bar.f):
+(foo.):
+(foo):
+* stress/ai-value-mod-should-result-in-constant-int-where-possible.js: Added.
+(foo.bar.f):
+(foo.):
+(foo):
+
+Source/_javascript_Core:
+
+The runtime code for ValueMod and ValueDiv produces an int32 when the result
+is of int32 value. However, the AI was saying the result is in double format.
+This patch fixes AI to produce a JSValue in the right format.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::handleConstantDivOp):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-07 Saam Barati
+
+AI rule for ValueMod/ValueDiv produce constants with the wrong format when the result can be an int32
+https://bugs.webkit.org/show_bug.cgi?id=205906
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/ai-value-div-should-result-in-constant-int-where-possible.js: Added.
+(foo.bar.f):
+(foo.):
+(foo):
+* stress/ai-value-mod-should-result-in-constant-int-where-possible.js: Added.
+(foo.bar.f):
+(foo.):
+(foo):
+
2020-01-13 Alan Coon
Cherry-pick r254349. rdar://problem/58529720
Added: branches/safari-609-branch/JSTests/stress/ai-value-div-should-result-in-constant-int-where-possible.js (0 => 254597)
--- branches/safari-609-branch/JSTests/stress/ai-value-div-should-result-in-constant-int-where-possible.js (rev 0)
+++ branches/safari-609-branch/JSTests/stress/ai-value-div-should-result-in-constant-int-where-possible.js 2020-01-15 19:15:05 UTC (rev 254597)
@@ -0,0 +1,21 @@
+//@ runDefault("--useRandomizingFuzzerAgent=1", "--validateAbstractInterpreterState=1", "--jitPolicyScale=0", "--useConcurrentJIT=0")
+
+function foo() {
+for (let i = 0; i < 3; i++) {
+const o = {};
+function bar(a0) {
+let x;
+do {
+function f() { z; }
+x = o;
+const y = typeof x === a0;
+[a0, 0.1];
+const z = 0 + y;
+const c = z / 1.0 + 0;
+} while (!x);
+}
+bar(0);
+}
+}
+
+foo();
Added: branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js (0 => 254597)
--- branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js (rev 0)
+++ branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js 2020-01-15 19:15:05 UTC (rev 254597)
@@ -0,0 +1,21 @@
+//@
[webkit-changes] [254610] branches/safari-609-branch/Source
Title: [254610] branches/safari-609-branch/Source Revision 254610 Author alanc...@apple.com Date 2020-01-15 11:15:44 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254293. rdar://problem/58549084 Resource Load Statistics: Flip experimental website data removal setting from an enable to a disable https://bugs.webkit.org/show_bug.cgi?id=205966 Reviewed by Brent Fulgham. To get default on behavior, experimental features in the network process need to be turned from enable flags to disable flags. This patch does that for the experimental website data removal flag. Source/WebCore: No new tests. This change just reverses the interpretation of a flag. * page/Settings.yaml: Source/WebKit: This change also aligns the init values of the setting to match the default. * NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: * NetworkProcess/NetworkSession.h: * NetworkProcess/NetworkSessionCreationParameters.h: * Shared/WebPreferences.yaml: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess): * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254293 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/page/Settings.yaml branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h branches/safari-609-branch/Source/WebKit/NetworkProcess/NetworkSession.h branches/safari-609-branch/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h branches/safari-609-branch/Source/WebKit/Shared/WebPreferences.yaml branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessPool.cpp branches/safari-609-branch/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm Diff Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254609 => 254610) --- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:40 UTC (rev 254609) +++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:44 UTC (rev 254610) @@ -1,5 +1,57 @@ 2020-01-14 Alan Coon +Cherry-pick r254293. rdar://problem/58549084 + +Resource Load Statistics: Flip experimental website data removal setting from an enable to a disable +https://bugs.webkit.org/show_bug.cgi?id=205966 + + +Reviewed by Brent Fulgham. + +To get default on behavior, experimental features in the network process need to be +turned from enable flags to disable flags. This patch does that for the experimental +website data removal flag. + +Source/WebCore: + +No new tests. This change just reverses the interpretation of a flag. + +* page/Settings.yaml: + +Source/WebKit: + +This change also aligns the init values of the setting to match the default. + +* NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: +* NetworkProcess/NetworkSession.h: +* NetworkProcess/NetworkSessionCreationParameters.h: +* Shared/WebPreferences.yaml: +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::ensureNetworkProcess): +* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: +(WebKit::WebsiteDataStore::parameters): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254293 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-09 John Wilander + +Resource Load Statistics: Flip experimental website data removal setting from an enable to a disable +https://bugs.webkit.org/show_bug.cgi?id=205966 + + +Reviewed by Brent Fulgham. + +To get default on behavior, experimental features in the network process need to be +turned from enable flags to disable flags. This patch does that for the experimental +website data removal flag. + +No new tests. This change just reverses the interpretation of a flag. + +* page/Settings.yaml: + +2020-01-14 Alan Coon + Cherry-pick r254288. rdar://problem/58548984 [Cocoa] persistent-usage-record message fails first time; succeeds subsequent times Modified: branches/safari-609-branch/Source/WebCore/page/Settings.yaml (254609 => 254610) --- branches/safari-609-branch/Source/WebCore/page/Settings.yaml 2020-01-15 19:15:40 UTC (rev 254609) +++ branches/safari-609-branch/Source/WebCore/page/Settings.yaml 2020-01-15 19:15:44 UTC (rev 254610) @@ -889,8 +889,8 @@ isThirdPartyCookieBlockingDisabled: initial: false -isFirstPartyWebsiteDataRemovalEnabled: - initial: true +isFirstPartyWebsiteDataRemovalDisabled: + initial: false isFirstPartyWebsiteDataRemovalLiveOnTestingEnabled: initial: false Modified:
[webkit-changes] [254608] branches/safari-609-branch/Source/WebCore
Title: [254608] branches/safari-609-branch/Source/WebCore Revision 254608 Author alanc...@apple.com Date 2020-01-15 11:15:37 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254288. rdar://problem/58548984 [Cocoa] persistent-usage-record message fails first time; succeeds subsequent times https://bugs.webkit.org/show_bug.cgi?id=205970 Reviewed by Eric Carlson. The AVContentKeySession is created too early; before the CDM has a chance to provide the storage path for persistent usage records. Delay creation of the AVCKS until it's actually needed during the first license request. Drive-by fix: fix the exceptional case where a PUR session is closed but PUR data isn't available; send a null message rather than an empty array. * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceFairPlayStreamingAVFObjC::contentKeySession): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC): Deleted. (WebCore::CDMInstanceFairPlayStreamingAVFObjC::ensureSession): Deleted. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254288 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm Diff Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254607 => 254608) --- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:34 UTC (rev 254607) +++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:37 UTC (rev 254608) @@ -1,5 +1,54 @@ 2020-01-14 Alan Coon +Cherry-pick r254288. rdar://problem/58548984 + +[Cocoa] persistent-usage-record message fails first time; succeeds subsequent times +https://bugs.webkit.org/show_bug.cgi?id=205970 + + +Reviewed by Eric Carlson. + +The AVContentKeySession is created too early; before the CDM has a chance to provide the storage path +for persistent usage records. Delay creation of the AVCKS until it's actually needed during the first +license request. + +Drive-by fix: fix the exceptional case where a PUR session is closed but PUR data isn't available; send +a null message rather than an empty array. + +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::contentKeySession): +(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC): Deleted. +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::ensureSession): Deleted. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254288 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-09 Jer Noble + +[Cocoa] persistent-usage-record message fails first time; succeeds subsequent times +https://bugs.webkit.org/show_bug.cgi?id=205970 + + +Reviewed by Eric Carlson. + +The AVContentKeySession is created too early; before the CDM has a chance to provide the storage path +for persistent usage records. Delay creation of the AVCKS until it's actually needed during the first +license request. + +Drive-by fix: fix the exceptional case where a PUR session is closed but PUR data isn't available; send +a null message rather than an empty array. + +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::contentKeySession): +(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC): Deleted. +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::ensureSession): Deleted. + +2020-01-14 Alan Coon + Cherry-pick r254239. rdar://problem/58549100 Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable Modified: branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h (254607 => 254608) --- branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h 2020-01-15 19:15:34 UTC (rev 254607) +++
[webkit-changes] [254598] branches/safari-609-branch
Title: [254598] branches/safari-609-branch Revision 254598 Author alanc...@apple.com Date 2020-01-15 11:15:10 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254201. rdar://problem/58552859 [Web Animations] Stop creating CSS Animations for elements https://bugs.webkit.org/show_bug.cgi?id=205925 Reviewed by Antti Koivisto. Source/WebCore: Test: webanimations/no-css-animation-on-noscript.html It makes no sense to create CSS Animations for a element and it has the side effect of potential crashes. Indeed, AnimationTimeline::updateCSSAnimationsForElement() may be called without a currentStyle and so we never have a list of previously-applied animations to compare to the list of animations in afterChangeStyle. So on each call we end up creating a new CSSAnimation and the previous animation for the same name is never explicitly removed from the effect stack and is eventually destroyed and the WeakPtr for it in the stack ends up being null, which would cause a crash under KeyframeEffectStack::ensureEffectsAreSorted(). We now prevent elements such as from being considered for CSS Animations in TreeResolver::resolveElement(). * dom/Element.cpp: (WebCore::Element::rendererIsNeeded): * dom/Element.h: (WebCore::Element::rendererIsEverNeeded): * html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsEverNeeded): (WebCore::HTMLElement::rendererIsNeeded): Deleted. * html/HTMLElement.h: * style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): LayoutTests: Add a new test that checks that setting the `animation` property on a element does not yield the creation of a CSSAnimation object. * webanimations/no-css-animation-on-noscript-expected.txt: Added. * webanimations/no-css-animation-on-noscript.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254201 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/dom/Element.cpp branches/safari-609-branch/Source/WebCore/dom/Element.h branches/safari-609-branch/Source/WebCore/html/HTMLElement.cpp branches/safari-609-branch/Source/WebCore/html/HTMLElement.h branches/safari-609-branch/Source/WebCore/style/StyleTreeResolver.cpp Added Paths branches/safari-609-branch/LayoutTests/webanimations/no-css-animation-on-noscript-expected.txt branches/safari-609-branch/LayoutTests/webanimations/no-css-animation-on-noscript.html Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254597 => 254598) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:05 UTC (rev 254597) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:10 UTC (rev 254598) @@ -1,5 +1,61 @@ 2020-01-14 Alan Coon +Cherry-pick r254201. rdar://problem/58552859 + +[Web Animations] Stop creating CSS Animations for elements +https://bugs.webkit.org/show_bug.cgi?id=205925 + + +Reviewed by Antti Koivisto. + +Source/WebCore: + +Test: webanimations/no-css-animation-on-noscript.html + +It makes no sense to create CSS Animations for a element and it has the side effect of potential crashes. +Indeed, AnimationTimeline::updateCSSAnimationsForElement() may be called without a currentStyle and so we never have +a list of previously-applied animations to compare to the list of animations in afterChangeStyle. So on each call we +end up creating a new CSSAnimation and the previous animation for the same name is never explicitly removed from the +effect stack and is eventually destroyed and the WeakPtr for it in the stack ends up being null, which would cause a +crash under KeyframeEffectStack::ensureEffectsAreSorted(). + +We now prevent elements such as from being considered for CSS Animations in TreeResolver::resolveElement(). + +* dom/Element.cpp: +(WebCore::Element::rendererIsNeeded): +* dom/Element.h: +(WebCore::Element::rendererIsEverNeeded): +* html/HTMLElement.cpp: +(WebCore::HTMLElement::rendererIsEverNeeded): +(WebCore::HTMLElement::rendererIsNeeded): Deleted. +* html/HTMLElement.h: +* style/StyleTreeResolver.cpp: +(WebCore::Style::TreeResolver::resolveElement): + +LayoutTests: + +Add a new test that checks that setting the `animation` property on a element does not yield the creation of a CSSAnimation object. + +* webanimations/no-css-animation-on-noscript-expected.txt: Added. +* webanimations/no-css-animation-on-noscript.html: Added. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254201 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-08 Antoine Quint + +[Web Animations] Stop creating CSS Animations for elements +
[webkit-changes] [254596] branches/safari-609-branch/Source/WebKitLegacy
Title: [254596] branches/safari-609-branch/Source/WebKitLegacy
Revision 254596
Author alanc...@apple.com
Date 2020-01-15 11:15:02 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254169. rdar://problem/58552876
REGRESSION (r248734): different threads write m_storageMap of StorageAreaImpl at the same time
https://bugs.webkit.org/show_bug.cgi?id=205764
Reviewed by Maciej Stachowiak.
In StorageAreaImpl, we avoid modifying m_storageMap from different threads at the same time by blocking main
thread access to it until the writes(importing items) of storage thread is done.
In r248734 we introduced a new case where the main thread could modify m_storageMap for session change, but we
didn't add the wait there.
* Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::importItems):
(WebKit::StorageAreaImpl::sessionChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKitLegacy/ChangeLog
branches/safari-609-branch/Source/WebKitLegacy/Storage/StorageAreaImpl.cpp
Diff
Modified: branches/safari-609-branch/Source/WebKitLegacy/ChangeLog (254595 => 254596)
--- branches/safari-609-branch/Source/WebKitLegacy/ChangeLog 2020-01-15 19:15:00 UTC (rev 254595)
+++ branches/safari-609-branch/Source/WebKitLegacy/ChangeLog 2020-01-15 19:15:02 UTC (rev 254596)
@@ -1,3 +1,44 @@
+2020-01-14 Alan Coon
+
+Cherry-pick r254169. rdar://problem/58552876
+
+REGRESSION (r248734): different threads write m_storageMap of StorageAreaImpl at the same time
+https://bugs.webkit.org/show_bug.cgi?id=205764
+
+
+Reviewed by Maciej Stachowiak.
+
+In StorageAreaImpl, we avoid modifying m_storageMap from different threads at the same time by blocking main
+thread access to it until the writes(importing items) of storage thread is done.
+
+In r248734 we introduced a new case where the main thread could modify m_storageMap for session change, but we
+didn't add the wait there.
+
+* Storage/StorageAreaImpl.cpp:
+(WebKit::StorageAreaImpl::importItems):
+(WebKit::StorageAreaImpl::sessionChanged):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-07 Sihui Liu
+
+REGRESSION (r248734): different threads write m_storageMap of StorageAreaImpl at the same time
+https://bugs.webkit.org/show_bug.cgi?id=205764
+
+
+Reviewed by Maciej Stachowiak.
+
+In StorageAreaImpl, we avoid modifying m_storageMap from different threads at the same time by blocking main
+thread access to it until the writes(importing items) of storage thread is done.
+
+In r248734 we introduced a new case where the main thread could modify m_storageMap for session change, but we
+didn't add the wait there.
+
+* Storage/StorageAreaImpl.cpp:
+(WebKit::StorageAreaImpl::importItems):
+(WebKit::StorageAreaImpl::sessionChanged):
+
2020-01-03 Simon Fraser
Add some shared schemes to the WebKit.xcworkspace
Modified: branches/safari-609-branch/Source/WebKitLegacy/Storage/StorageAreaImpl.cpp (254595 => 254596)
--- branches/safari-609-branch/Source/WebKitLegacy/Storage/StorageAreaImpl.cpp 2020-01-15 19:15:00 UTC (rev 254595)
+++ branches/safari-609-branch/Source/WebKitLegacy/Storage/StorageAreaImpl.cpp 2020-01-15 19:15:02 UTC (rev 254596)
@@ -197,6 +197,7 @@
void StorageAreaImpl::importItems(HashMap&& items)
{
ASSERT(!m_isShutdown);
+ASSERT(!isMainThread());
m_storageMap->importItems(WTFMove(items));
}
@@ -296,6 +297,9 @@
{
ASSERT(isMainThread());
+// If import is not completed, background storage thread may be modifying m_storageMap.
+blockUntilImportComplete();
+
unsigned quota = m_storageMap->quota();
m_storageMap = StorageMap::create(quota);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254606] branches/safari-609-branch/LayoutTests
Title: [254606] branches/safari-609-branch/LayoutTests
Revision 254606
Author alanc...@apple.com
Date 2020-01-15 11:15:32 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254261. rdar://problem/58549081
REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205886
Reviewed by Chris Dumez.
Make sure registrations are stored on disk before crashing the network process.
* http/wpt/service-workers/persistent-importScripts.html:
* platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/http/wpt/service-workers/persistent-importScripts.html
Diff
Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254605 => 254606)
--- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:30 UTC (rev 254605)
+++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:32 UTC (rev 254606)
@@ -1,5 +1,35 @@
2020-01-14 Alan Coon
+Cherry-pick r254261. rdar://problem/58549081
+
+REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205886
+
+
+Reviewed by Chris Dumez.
+
+Make sure registrations are stored on disk before crashing the network process.
+
+* http/wpt/service-workers/persistent-importScripts.html:
+* platform/mac-wk2/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-09 youenn fablet
+
+REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205886
+
+
+Reviewed by Chris Dumez.
+
+Make sure registrations are stored on disk before crashing the network process.
+
+* http/wpt/service-workers/persistent-importScripts.html:
+* platform/mac-wk2/TestExpectations:
+
+2020-01-14 Alan Coon
+
Cherry-pick r254260. rdar://problem/58552882
REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
Modified: branches/safari-609-branch/LayoutTests/http/wpt/service-workers/persistent-importScripts.html (254605 => 254606)
--- branches/safari-609-branch/LayoutTests/http/wpt/service-workers/persistent-importScripts.html 2020-01-15 19:15:30 UTC (rev 254605)
+++ branches/safari-609-branch/LayoutTests/http/wpt/service-workers/persistent-importScripts.html 2020-01-15 19:15:32 UTC (rev 254606)
@@ -36,6 +36,9 @@
let randomId = await getRandomIdFromWorker(worker);
if (!window.location.hash.length) {
+if (window.internals)
+await internals.storeRegistrationsOnDisk();
+
if (window.testRunner)
testRunner.terminateNetworkProcess();
await waitFor(100);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254604] branches/safari-609-branch
Title: [254604] branches/safari-609-branch
Revision 254604
Author alanc...@apple.com
Date 2020-01-15 11:15:27 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254254. rdar://problem/58548978
WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared
Reviewed by Joseph Pecoraro.
Source/WebKit:
* UIProcess/mac/WebPreferencesMac.mm:
(WebKit::WebPreferences::platformInitializeStore):
- Add an @autoreleasepool block around the contents of
this method since it generates numerous autoreleased
objects when run.
Tools:
* WebKitTestRunner/ios/mainIOS.mm:
(main):
- Add an @autoreleasepool block around a line of code
that generates autoreleased objects. These objects
would never be released for the life of the process
prior to this change.
* WebKitTestRunner/mac/main.mm:
(main):
- Move instantiation of WTR::TestController outside of
@autoreleasepool block so the pool can be drained
while running tests. Prior to this change, this
autoreleasePool would never be drained.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm
branches/safari-609-branch/Tools/ChangeLog
branches/safari-609-branch/Tools/WebKitTestRunner/ios/mainIOS.mm
branches/safari-609-branch/Tools/WebKitTestRunner/mac/main.mm
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254603 => 254604)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:24 UTC (rev 254603)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:27 UTC (rev 254604)
@@ -1,5 +1,55 @@
2020-01-14 Alan Coon
+Cherry-pick r254254. rdar://problem/58548978
+
+WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared
+
+
+
+Reviewed by Joseph Pecoraro.
+
+Source/WebKit:
+
+* UIProcess/mac/WebPreferencesMac.mm:
+(WebKit::WebPreferences::platformInitializeStore):
+- Add an @autoreleasepool block around the contents of
+ this method since it generates numerous autoreleased
+ objects when run.
+
+Tools:
+
+* WebKitTestRunner/ios/mainIOS.mm:
+(main):
+- Add an @autoreleasepool block around a line of code
+ that generates autoreleased objects. These objects
+ would never be released for the life of the process
+ prior to this change.
+* WebKitTestRunner/mac/main.mm:
+(main):
+- Move instantiation of WTR::TestController outside of
+ @autoreleasepool block so the pool can be drained
+ while running tests. Prior to this change, this
+ autoreleasePool would never be drained.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-09 David Kilzer
+
+WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared
+
+
+
+Reviewed by Joseph Pecoraro.
+
+* UIProcess/mac/WebPreferencesMac.mm:
+(WebKit::WebPreferences::platformInitializeStore):
+- Add an @autoreleasepool block around the contents of
+ this method since it generates numerous autoreleased
+ objects when run.
+
+2020-01-14 Alan Coon
+
Cherry-pick r254239. rdar://problem/58549100
Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm (254603 => 254604)
--- branches/safari-609-branch/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm 2020-01-15 19:15:24 UTC (rev 254603)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm 2020-01-15 19:15:27 UTC (rev 254604)
@@ -138,24 +138,26 @@
void WebPreferences::platformInitializeStore()
{
+@autoreleasepool {
#define INITIALIZE_DEBUG_PREFERENCE_FROM_NSUSERDEFAULTS(KeyUpper, KeyLower, TypeName, Type, DefaultValue, HumanReadableName, HumanReadableDescription) \
-setDebug##TypeName##ValueIfInUserDefaults(m_identifier, m_keyPrefix, m_globalDebugKeyPrefix, WebPreferencesKey::KeyLower##Key(), m_store);
+setDebug##TypeName##ValueIfInUserDefaults(m_identifier, m_keyPrefix, m_globalDebugKeyPrefix, WebPreferencesKey::KeyLower##Key(), m_store);
-FOR_EACH_WEBKIT_DEBUG_PREFERENCE(INITIALIZE_DEBUG_PREFERENCE_FROM_NSUSERDEFAULTS)
+FOR_EACH_WEBKIT_DEBUG_PREFERENCE(INITIALIZE_DEBUG_PREFERENCE_FROM_NSUSERDEFAULTS)
#undef INITIALIZE_DEBUG_PREFERENCE_FROM_NSUSERDEFAULTS
-if (!m_identifier)
-return;
+if (!m_identifier)
+return;
#define INITIALIZE_PREFERENCE_FROM_NSUSERDEFAULTS(KeyUpper, KeyLower, TypeName, Type,
[webkit-changes] [254609] branches/safari-609-branch/Source/WebKit
Title: [254609] branches/safari-609-branch/Source/WebKit
Revision 254609
Author alanc...@apple.com
Date 2020-01-15 11:15:40 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254292. rdar://problem/58552868
Set the title for images so it will be correctly displayed in UIContextMenus
https://bugs.webkit.org/show_bug.cgi?id=205980
Reviewed by Dean Jackson.
Need to set the title text for images.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView continueContextMenuInteraction:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254608 => 254609)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:37 UTC (rev 254608)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:40 UTC (rev 254609)
@@ -1,5 +1,36 @@
2020-01-14 Alan Coon
+Cherry-pick r254292. rdar://problem/58552868
+
+Set the title for images so it will be correctly displayed in UIContextMenus
+https://bugs.webkit.org/show_bug.cgi?id=205980
+
+
+Reviewed by Dean Jackson.
+
+Need to set the title text for images.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView continueContextMenuInteraction:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-09 Megan Gardner
+
+Set the title for images so it will be correctly displayed in UIContextMenus
+https://bugs.webkit.org/show_bug.cgi?id=205980
+
+
+Reviewed by Dean Jackson.
+
+Need to set the title text for images.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView continueContextMenuInteraction:]):
+
+2020-01-14 Alan Coon
+
Cherry-pick r254287. rdar://problem/58552886
Fullscreen videos do not enter PiP in first tap
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (254608 => 254609)
--- branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-15 19:15:37 UTC (rev 254608)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-15 19:15:40 UTC (rev 254609)
@@ -8480,7 +8480,7 @@
RetainPtr> defaultActionsFromAssistant = [strongSelf->_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];
auto actions = menuElementsFromDefaultActions(defaultActionsFromAssistant, elementInfo);
-return [UIMenu menuWithTitle:@"" children:actions];
+return [UIMenu menuWithTitle:strongSelf->_positionInformation.title children:actions];
};
UIContextMenuContentPreviewProvider contentPreviewProvider = [weakSelf, cgImage, elementInfo] () -> UIViewController * {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254623] branches/safari-609-branch/JSTests
Title: [254623] branches/safari-609-branch/JSTests
Revision 254623
Author alanc...@apple.com
Date 2020-01-15 11:16:41 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254496. rdar://problem/58553161
Unreviewed. Change useLLInt=0 to forceBaseline=1
* stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/JSTests/ChangeLog
branches/safari-609-branch/JSTests/stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js
Diff
Modified: branches/safari-609-branch/JSTests/ChangeLog (254622 => 254623)
--- branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:16:38 UTC (rev 254622)
+++ branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:16:41 UTC (rev 254623)
@@ -1,5 +1,23 @@
2020-01-15 Alan Coon
+Cherry-pick r254496. rdar://problem/58553161
+
+Unreviewed. Change useLLInt=0 to forceBaseline=1
+
+* stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-13 Saam Barati
+
+Unreviewed. Change useLLInt=0 to forceBaseline=1
+
+* stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js:
+
+2020-01-15 Alan Coon
+
Cherry-pick r254464. rdar://problem/58553161
Replace uses of Box with a new CacheableIdentifier class.
Modified: branches/safari-609-branch/JSTests/stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js (254622 => 254623)
--- branches/safari-609-branch/JSTests/stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js 2020-01-15 19:16:38 UTC (rev 254622)
+++ branches/safari-609-branch/JSTests/stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js 2020-01-15 19:16:41 UTC (rev 254623)
@@ -1,4 +1,4 @@
-//@ runDefault("--numberOfGCMarkers=1", "--useDFGJIT=false", "--useLLInt=false")
+//@ runDefault("--numberOfGCMarkers=1", "--useDFGJIT=false", "--forceBaseline=true")
function foo() {
gc();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254628] trunk
Title: [254628] trunk
Revision 254628
Author aakash_j...@apple.com
Date 2020-01-15 12:21:53 -0800 (Wed, 15 Jan 2020)
Log Message
Unreviewed, rolling out r254576.
https://bugs.webkit.org/show_bug.cgi?id=206306
Introduced failing test loader/change-src-during-iframe-load-
crash.html (Requested by aakashja_ on #webkit).
Reverted changeset:
"Null Ptr Deref @
WebCore::DocumentLoader::clearMainResourceLoader"
https://bugs.webkit.org/show_bug.cgi?id=206204
https://trac.webkit.org/changeset/254576
Patch by Commit Queue on 2020-01-15
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
Removed Paths
trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt
trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (254627 => 254628)
--- trunk/LayoutTests/ChangeLog 2020-01-15 20:18:57 UTC (rev 254627)
+++ trunk/LayoutTests/ChangeLog 2020-01-15 20:21:53 UTC (rev 254628)
@@ -1,3 +1,18 @@
+2020-01-15 Commit Queue
+
+Unreviewed, rolling out r254576.
+https://bugs.webkit.org/show_bug.cgi?id=206306
+
+Introduced failing test loader/change-src-during-iframe-load-
+crash.html (Requested by aakashja_ on #webkit).
+
+Reverted changeset:
+
+"Null Ptr Deref @
+WebCore::DocumentLoader::clearMainResourceLoader"
+https://bugs.webkit.org/show_bug.cgi?id=206204
+https://trac.webkit.org/changeset/254576
+
2020-01-15 Truitt Savell
REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html is a flaky failure on Mac wk2
Modified: trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt (254627 => 254628)
--- trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt 2020-01-15 20:18:57 UTC (rev 254627)
+++ trunk/LayoutTests/http/tests/security/http-0.9/xhr-blocked-expected.txt 2020-01-15 20:21:53 UTC (rev 254628)
@@ -1,3 +1,2 @@
-asdf
ALERT: PASS
Deleted: trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt (254627 => 254628)
--- trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt 2020-01-15 20:18:57 UTC (rev 254627)
+++ trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt 2020-01-15 20:21:53 UTC (rev 254628)
@@ -1 +0,0 @@
-The test is declared pass if there is no crash observed.
Deleted: trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html (254627 => 254628)
--- trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html 2020-01-15 20:18:57 UTC (rev 254627)
+++ trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html 2020-01-15 20:21:53 UTC (rev 254628)
@@ -1,20 +0,0 @@
-
-
-function load() {
-document.body.innerHTML = 'The test is declared pass if there is no crash observed.';
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-}
-
-function eventhandler3() {
-iframe1.srcdoc = "x";
-if (window.testRunner)
-testRunner.notifyDone();
-}
-
-
-
-
Modified: trunk/Source/WebCore/ChangeLog (254627 => 254628)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 20:18:57 UTC (rev 254627)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 20:21:53 UTC (rev 254628)
@@ -1,3 +1,18 @@
+2020-01-15 Commit Queue
+
+Unreviewed, rolling out r254576.
+https://bugs.webkit.org/show_bug.cgi?id=206306
+
+Introduced failing test loader/change-src-during-iframe-load-
+crash.html (Requested by aakashja_ on #webkit).
+
+Reverted changeset:
+
+"Null Ptr Deref @
+WebCore::DocumentLoader::clearMainResourceLoader"
+https://bugs.webkit.org/show_bug.cgi?id=206204
+https://trac.webkit.org/changeset/254576
+
2020-01-15 Pinki Gyanchandani
Null Ptr Deref @ WebCore::DocumentLoader::clearMainResourceLoader
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (254627 => 254628)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-01-15 20:18:57 UTC (rev 254627)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-01-15 20:21:53 UTC (rev 254628)
@@ -1272,11 +1272,7 @@
{
m_loadingMainResource = false;
-auto* frameLoader = this->frameLoader();
-if (!frameLoader)
-return;
-
-if (this == frameLoader->activeDocumentLoader())
+if (this == frameLoader()->activeDocumentLoader())
checkLoadComplete();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254629] trunk/Source/WebCore
Title: [254629] trunk/Source/WebCore
Revision 254629
Author za...@apple.com
Date 2020-01-15 12:42:34 -0800 (Wed, 15 Jan 2020)
Log Message
[LFC][IFC] ContinuousContent should not need a copy of RunList
https://bugs.webkit.org/show_bug.cgi?id=206293
Reviewed by Antti Koivisto.
~4% progression on PerformanceTests/Layout/line-layout-simple.html.
* layout/inlineformatting/InlineLineBreaker.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (254628 => 254629)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 20:21:53 UTC (rev 254628)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 20:42:34 UTC (rev 254629)
@@ -1,3 +1,15 @@
+2020-01-15 Zalan Bujtas
+
+[LFC][IFC] ContinuousContent should not need a copy of RunList
+https://bugs.webkit.org/show_bug.cgi?id=206293
+
+
+Reviewed by Antti Koivisto.
+
+~4% progression on PerformanceTests/Layout/line-layout-simple.html.
+
+* layout/inlineformatting/InlineLineBreaker.cpp:
+
2020-01-15 Commit Queue
Unreviewed, rolling out r254576.
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp (254628 => 254629)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp 2020-01-15 20:21:53 UTC (rev 254628)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp 2020-01-15 20:42:34 UTC (rev 254629)
@@ -70,7 +70,7 @@
Optional lastContentRunIndex() const;
private:
-LineBreaker::RunList m_runs;
+const LineBreaker::RunList& m_runs;
struct TrailingCollapsibleContent {
void reset();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254633] trunk/Source/WebInspectorUI
Title: [254633] trunk/Source/WebInspectorUI
Revision 254633
Author drou...@apple.com
Date 2020-01-15 13:41:50 -0800 (Wed, 15 Jan 2020)
Log Message
Web Inspector: collapsing a virtualized folder in a `WI.TreeOutline` doesn't updated the DOM
https://bugs.webkit.org/show_bug.cgi?id=206302
Reviewed by Timothy Hatcher.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._updateVirtualizedElements):
When collapsing a currently visible `WI.TreeElement`, it will still be in the cached set of
visible and attached `WI.TreeElement`s, meaning that `_updateVirtualizedElements` will early
return since it thinks that the same `WI.TreeElement` are being shown. Add another check to
ensure that it only thinks that if the same number of `WI.TreeElement` are visible.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (254632 => 254633)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-01-15 21:30:57 UTC (rev 254632)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-01-15 21:41:50 UTC (rev 254633)
@@ -1,3 +1,17 @@
+2020-01-15 Devin Rousso
+
+Web Inspector: collapsing a virtualized folder in a `WI.TreeOutline` doesn't updated the DOM
+https://bugs.webkit.org/show_bug.cgi?id=206302
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TreeOutline.js:
+(WI.TreeOutline.prototype._updateVirtualizedElements):
+When collapsing a currently visible `WI.TreeElement`, it will still be in the cached set of
+visible and attached `WI.TreeElement`s, meaning that `_updateVirtualizedElements` will early
+return since it thinks that the same `WI.TreeElement` are being shown. Add another check to
+ensure that it only thinks that if the same number of `WI.TreeElement` are visible.
+
2020-01-13 Devin Rousso
Web Inspector: "Enable Local Override" and "Delete Local Override" are displayed twice in the contextual menu
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (254632 => 254633)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2020-01-15 21:30:57 UTC (rev 254632)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2020-01-15 21:41:50 UTC (rev 254633)
@@ -1042,11 +1042,14 @@
// Redraw if we are about to scroll.
if (!shouldScroll) {
-// Redraw if all of the previously centered `WI.TreeElement` are no longer centered.
-if (visibleTreeElements.intersects(this._virtualizedVisibleTreeElements)) {
-// Redraw if there is a `WI.TreeElement` that should be shown that isn't attached.
-if (visibleTreeElements.isSubsetOf(this._virtualizedAttachedTreeElements))
-return;
+// Redraw if there are a different number of items to show.
+if (visibleTreeElements.size === this._virtualizedVisibleTreeElements.size) {
+// Redraw if all of the previously centered `WI.TreeElement` are no longer centered.
+if (visibleTreeElements.intersects(this._virtualizedVisibleTreeElements)) {
+// Redraw if there is a `WI.TreeElement` that should be shown that isn't attached.
+if (visibleTreeElements.isSubsetOf(this._virtualizedAttachedTreeElements))
+return;
+}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254636] trunk/Tools
Title: [254636] trunk/Tools
Revision 254636
Author ddkil...@apple.com
Date 2020-01-15 14:04:45 -0800 (Wed, 15 Jan 2020)
Log Message
Enable -Wconditional-uninitialized in DumpRenderTree, WebKitTestRunner
Reviewed by Brent Fulgham.
* DumpRenderTree/mac/Configurations/Base.xcconfig:
(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
Initialize `imageRef` stack variable to `nullptr`.
* WebKitTestRunner/Configurations/Base.xcconfig:
(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
trunk/Tools/DumpRenderTree/mac/UIDelegate.mm
trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig
Diff
Modified: trunk/Tools/ChangeLog (254635 => 254636)
--- trunk/Tools/ChangeLog 2020-01-15 22:03:10 UTC (rev 254635)
+++ trunk/Tools/ChangeLog 2020-01-15 22:04:45 UTC (rev 254636)
@@ -1,3 +1,19 @@
+2020-01-15 David Kilzer
+
+Enable -Wconditional-uninitialized in DumpRenderTree, WebKitTestRunner
+
+
+
+Reviewed by Brent Fulgham.
+
+* DumpRenderTree/mac/Configurations/Base.xcconfig:
+(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
+* DumpRenderTree/mac/UIDelegate.mm:
+(-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
+Initialize `imageRef` stack variable to `nullptr`.
+* WebKitTestRunner/Configurations/Base.xcconfig:
+(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
+
2020-01-15 Keith Miller
Revert bytecode checkpoints since it breaks watch
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (254635 => 254636)
--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2020-01-15 22:03:10 UTC (rev 254635)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2020-01-15 22:04:45 UTC (rev 254636)
@@ -80,7 +80,7 @@
// FIXME: DumpRenderTree should build with -Wshorten-64-to-32
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
-WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
+WARNING_CFLAGS = -Wall -W -Wconditional-uninitialized -Wno-unused-parameter -Wundef;
DEBUG_DEFINES_debug = ;
DEBUG_DEFINES_normal = NDEBUG;
Modified: trunk/Tools/DumpRenderTree/mac/UIDelegate.mm (254635 => 254636)
--- trunk/Tools/DumpRenderTree/mac/UIDelegate.mm 2020-01-15 22:03:10 UTC (rev 254635)
+++ trunk/Tools/DumpRenderTree/mac/UIDelegate.mm 2020-01-15 22:04:45 UTC (rev 254636)
@@ -389,7 +389,7 @@
NSURL *firstURL = [NSURL fileURLWithPath:[NSString stringWithUTF8String:openPanelFiles[0].c_str()] relativeToURL:baseURL];
NSString *displayString = firstURL.lastPathComponent;
const std::vector& iconData = gTestRunner->openPanelFilesMediaIcon();
-CGImageRef imageRef;
+CGImageRef imageRef = nullptr;
if (!iconData.empty()) {
RetainPtr dataRef = adoptCF(CFDataCreate(nullptr, (unsigned char *)iconData.data(), iconData.size()));
RetainPtr imageProviderRef = adoptCF(CGDataProviderCreateWithCFData(dataRef.get()));
Modified: trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig (254635 => 254636)
--- trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2020-01-15 22:03:10 UTC (rev 254635)
+++ trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2020-01-15 22:04:45 UTC (rev 254636)
@@ -72,7 +72,7 @@
GCC_WARN_UNUSED_VARIABLE = YES
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
-WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
+WARNING_CFLAGS = -Wall -W -Wconditional-uninitialized -Wno-unused-parameter -Wundef;
GCC_PREFIX_HEADER = WebKitTestRunnerPrefix.h
DEBUG_DEFINES_debug = ;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254635] tags/Safari-609.1.14.1/
Title: [254635] tags/Safari-609.1.14.1/ Revision 254635 Author alanc...@apple.com Date 2020-01-15 14:03:10 -0800 (Wed, 15 Jan 2020) Log Message Tag Safari-609.1.14.1. Added Paths tags/Safari-609.1.14.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254638] branches/safari-609-branch/Source
Title: [254638] branches/safari-609-branch/Source Revision 254638 Author alanc...@apple.com Date 2020-01-15 14:15:43 -0800 (Wed, 15 Jan 2020) Log Message Apply patch. rdar://problem/58610979 Modified Paths branches/safari-609-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig branches/safari-609-branch/Source/WebKit/Shared/WebPreferences.yaml Diff Modified: branches/safari-609-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (254637 => 254638) --- branches/safari-609-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2020-01-15 22:15:38 UTC (rev 254637) +++ branches/safari-609-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2020-01-15 22:15:43 UTC (rev 254638) @@ -190,7 +190,7 @@ ENABLE_GEOLOCATION_maccatalyst = ENABLE_GEOLOCATION; ENABLE_GEOLOCATION_macosx = ENABLE_GEOLOCATION; -ENABLE_GPU_PROCESS = ENABLE_GPU_PROCESS; +ENABLE_GPU_PROCESS = ; ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE; Modified: branches/safari-609-branch/Source/WebKit/Shared/WebPreferences.yaml (254637 => 254638) --- branches/safari-609-branch/Source/WebKit/Shared/WebPreferences.yaml 2020-01-15 22:15:38 UTC (rev 254637) +++ branches/safari-609-branch/Source/WebKit/Shared/WebPreferences.yaml 2020-01-15 22:15:43 UTC (rev 254638) @@ -1881,7 +1881,7 @@ IsInAppBrowserPrivacyEnabled: type: bool -defaultValue: true +defaultValue: false humanReadableName: "In-App Browser Privacy" humanReadableDescription: "Enable In-App Browser Privacy" webcoreBinding: RuntimeEnabledFeatures ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254637] trunk/Source/JavaScriptCore
Title: [254637] trunk/Source/_javascript_Core
Revision 254637
Author ape...@igalia.com
Date 2020-01-15 14:15:38 -0800 (Wed, 15 Jan 2020)
Log Message
Offlineasm warnings with newer Ruby versions
https://bugs.webkit.org/show_bug.cgi?id=206233
Reviewed by Yusuke Suzuki.
Avoid a warning about using Object#=~ on Annotation instances, which
has been deprecated in Ruby 2.7.
* offlineasm/parser.rb: Swap checks to prevent applying the =~ operator
to Annotation instances, which do not define it.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/offlineasm/parser.rb
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (254636 => 254637)
--- trunk/Source/_javascript_Core/ChangeLog 2020-01-15 22:04:45 UTC (rev 254636)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-01-15 22:15:38 UTC (rev 254637)
@@ -1,3 +1,16 @@
+2020-01-15 Adrian Perez de Castro
+
+Offlineasm warnings with newer Ruby versions
+https://bugs.webkit.org/show_bug.cgi?id=206233
+
+Reviewed by Yusuke Suzuki.
+
+Avoid a warning about using Object#=~ on Annotation instances, which
+has been deprecated in Ruby 2.7.
+
+* offlineasm/parser.rb: Swap checks to prevent applying the =~ operator
+to Annotation instances, which do not define it.
+
2020-01-15 Keith Miller
Revert bytecode checkpoints since it breaks watch
Modified: trunk/Source/_javascript_Core/offlineasm/parser.rb (254636 => 254637)
--- trunk/Source/_javascript_Core/offlineasm/parser.rb 2020-01-15 22:04:45 UTC (rev 254636)
+++ trunk/Source/_javascript_Core/offlineasm/parser.rb 2020-01-15 22:15:38 UTC (rev 254637)
@@ -628,9 +628,7 @@
firstCodeOrigin = @tokens[@idx].codeOrigin
list = []
loop {
-if (@idx == @tokens.length and not final) or (final and @tokens[@idx] =~ final)
-break
-elsif @tokens[@idx].is_a? Annotation
+if @tokens[@idx].is_a? Annotation
# This is the only place where we can encounter a global
# annotation, and hence need to be able to distinguish between
# them.
@@ -644,6 +642,8 @@
list << Instruction.new(codeOrigin, annotationOpcode, [], @tokens[@idx].string)
@annotation = nil
@idx += 2 # Consume the newline as well.
+elsif (@idx == @tokens.length and not final) or (final and @tokens[@idx] =~ final)
+break
elsif @tokens[@idx] == "\n"
# ignore
@idx += 1
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254639] trunk/Websites/webkit.org
Title: [254639] trunk/Websites/webkit.org
Revision 254639
Author j...@apple.com
Date 2020-01-15 14:23:31 -0800 (Wed, 15 Jan 2020)
Log Message
Add Web Inspector Reference notice to Web Inspector blog posts
https://bugs.webkit.org/show_bug.cgi?id=206308
Reviewed by Devin Rousso.
* wp-content/themes/webkit/functions.php:
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/functions.php
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (254638 => 254639)
--- trunk/Websites/webkit.org/ChangeLog 2020-01-15 22:15:43 UTC (rev 254638)
+++ trunk/Websites/webkit.org/ChangeLog 2020-01-15 22:23:31 UTC (rev 254639)
@@ -1,3 +1,12 @@
+2020-01-15 Jon Davis
+
+Add Web Inspector Reference notice to Web Inspector blog posts
+https://bugs.webkit.org/show_bug.cgi?id=206308
+
+Reviewed by Devin Rousso.
+
+* wp-content/themes/webkit/functions.php:
+
2020-01-15 Devin Rousso
Web Inspector Reference: the meta info at the end of the article should always be on its own line
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/functions.php (254638 => 254639)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/functions.php 2020-01-15 22:15:43 UTC (rev 254638)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/functions.php 2020-01-15 22:23:31 UTC (rev 254639)
@@ -141,6 +141,22 @@
return $content;
});
+// Add Web Inspector Reference notice to Web Inspector blog posts
+add_filter('the_content', function($content) {
+if (!has_term('web-inspector', 'category', get_post()))
+return $content;
+
+$note = 'Note: Learn more about Web Inspector from the documentation.';
+$position = get_post_meta(get_the_ID(), 'web-inspector-reference-note', true);
+
+if ($position === 'before')
+$content = $note . $content;
+else
+$content .= $note;
+
+return $content;
+});
+
add_action('wp_head', function () {
if (!is_single()) return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254585] branches/safari-609-branch/Source/WebCore
Title: [254585] branches/safari-609-branch/Source/WebCore
Revision 254585
Author alanc...@apple.com
Date 2020-01-15 11:14:34 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254067. rdar://problem/58552878
REGRESSION(r247626): Introduced memory regression
https://bugs.webkit.org/show_bug.cgi?id=205815
Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::prewarmGlobally):
(WebCore::fontFamiliesForPrewarming): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254584 => 254585)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:14:31 UTC (rev 254584)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:14:34 UTC (rev 254585)
@@ -1,5 +1,33 @@
2020-01-14 Alan Coon
+Cherry-pick r254067. rdar://problem/58552878
+
+REGRESSION(r247626): Introduced memory regression
+https://bugs.webkit.org/show_bug.cgi?id=205815
+
+Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::FontCache::prewarmGlobally):
+(WebCore::fontFamiliesForPrewarming): Deleted.
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-06 Per Arne Vollan
+
+REGRESSION(r247626): Introduced memory regression
+https://bugs.webkit.org/show_bug.cgi?id=205815
+
+Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::FontCache::prewarmGlobally):
+(WebCore::fontFamiliesForPrewarming): Deleted.
+
+2020-01-14 Alan Coon
+
Cherry-pick r254054. rdar://problem/58549108
REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019'
Modified: branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (254584 => 254585)
--- branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2020-01-15 19:14:31 UTC (rev 254584)
+++ branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2020-01-15 19:14:34 UTC (rev 254585)
@@ -1688,9 +1688,12 @@
});
}
-static Vector& fontFamiliesForPrewarming()
+void FontCache::prewarmGlobally()
{
-static NeverDestroyed> families = std::initializer_list {
+if (MemoryPressureHandler::singleton().isUnderMemoryPressure())
+return;
+
+Vector families = std::initializer_list {
".SF NS Text"_s,
".SF NS Display"_s,
"Arial"_s,
@@ -1700,17 +1703,9 @@
"Times"_s,
"Times New Roman"_s,
};
-return families;
-}
-void FontCache::prewarmGlobally()
-{
-if (MemoryPressureHandler::singleton().isUnderMemoryPressure())
-return;
-
FontCache::PrewarmInformation prewarmInfo;
-prewarmInfo.seenFamilies = fontFamiliesForPrewarming();
-prewarmInfo.fontNamesRequiringSystemFallback = fontFamiliesForPrewarming();
+prewarmInfo.seenFamilies = WTFMove(families);
FontCache::singleton().prewarm(prewarmInfo);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254586] branches/safari-609-branch/LayoutTests
Title: [254586] branches/safari-609-branch/LayoutTests Revision 254586 Author alanc...@apple.com Date 2020-01-15 11:14:37 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254074. rdar://problem/58549078 REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1 https://bugs.webkit.org/show_bug.cgi?id=205810 Unreviewed test gardening. Page Overlay test in WK1 now dump one or more repaint rects after r254042. * platform/mac-wk1/pageoverlay/overlay-installation-expected.txt: * platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt: * platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt: * platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt: * platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254074 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254585 => 254586) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:34 UTC (rev 254585) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:37 UTC (rev 254586) @@ -1,5 +1,37 @@ 2020-01-14 Alan Coon +Cherry-pick r254074. rdar://problem/58549078 + +REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1 +https://bugs.webkit.org/show_bug.cgi?id=205810 + +Unreviewed test gardening. Page Overlay test in WK1 now dump one or more repaint rects after r254042. + + +* platform/mac-wk1/pageoverlay/overlay-installation-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254074 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-06 Simon Fraser + +REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1 +https://bugs.webkit.org/show_bug.cgi?id=205810 + +Unreviewed test gardening. Page Overlay test in WK1 now dump one or more repaint rects after r254042. + +* platform/mac-wk1/pageoverlay/overlay-installation-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt: +* platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt: + +2020-01-14 Alan Coon + Cherry-pick r254059. rdar://problem/58552861 REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure Modified: branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt (254585 => 254586) --- branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt 2020-01-15 19:14:34 UTC (rev 254585) +++ branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt 2020-01-15 19:14:37 UTC (rev 254586) @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 0, 800, 600) View-relative: (GraphicsLayer (children 1 Modified: branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt (254585 => 254586) --- branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt 2020-01-15 19:14:34 UTC (rev 254585) +++ branches/safari-609-branch/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt 2020-01-15 19:14:37 UTC (rev 254586) @@ -1,3 +1,7 @@ +CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (512, 512, 512, 512) +CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 512, 512, 512) +CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (512, 0, 512, 512) +CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 0, 512, 512) View-relative: (GraphicsLayer (children 1 Modified:
[webkit-changes] [254587] branches/safari-609-branch/Source/WebKit
Title: [254587] branches/safari-609-branch/Source/WebKit Revision 254587 Author alanc...@apple.com Date 2020-01-15 11:14:39 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254078. rdar://problem/58549073 Reformat WebPage logging https://bugs.webkit.org/show_bug.cgi?id=205709 Reviewed by Brent Fulgham. Update the format used by WebPage in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: - [] ::: So, for example: 0x4a1df5000 - WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (frame=0x4a1db0220, priority=0, webPageID=15, frameID=3, resourceID=32)', becomes: 0x4a1df5000 - [resourceLoader=0x1418b7200, frameLoader=0x1326d7340, frame=0x4a1db0220, webPageID=15, frameID=3, resourceID=32] WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (priority=2) This new form is a lot more verbose, but it really helps in tracing activity from the top of our page/frame/resource load stack to the bottom. No new tests - no added or changed functionality. * WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoad): (WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler): (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): (WebKit::WebLoaderStrategy::networkProcessCrashed): (WebKit::WebLoaderStrategy::loadResourceSynchronously): * WebProcess/Network/WebLoaderStrategy.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254078 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp branches/safari-609-branch/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h Diff Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254586 => 254587) --- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:14:37 UTC (rev 254586) +++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:14:39 UTC (rev 254587) @@ -1,5 +1,82 @@ 2020-01-14 Alan Coon +Cherry-pick r254078. rdar://problem/58549073 + +Reformat WebPage logging +https://bugs.webkit.org/show_bug.cgi?id=205709 + + +Reviewed by Brent Fulgham. + +Update the format used by WebPage in its RELEASE_LOG logging. Use the +format used by WebPageProxy and NetworkResourceLoader, which is +generally of the form: + + - [] ::: + +So, for example: + +0x4a1df5000 - WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (frame=0x4a1db0220, priority=0, webPageID=15, frameID=3, resourceID=32)', + +becomes: + +0x4a1df5000 - [resourceLoader=0x1418b7200, frameLoader=0x1326d7340, frame=0x4a1db0220, webPageID=15, frameID=3, resourceID=32] WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (priority=2) + +This new form is a lot more verbose, but it really helps in tracing +activity from the top of our page/frame/resource load stack to the +bottom. + +No new tests - no added or changed functionality. + +* WebProcess/Network/WebLoaderStrategy.cpp: +(WebKit::WebLoaderStrategy::scheduleLoad): +(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler): +(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): +(WebKit::WebLoaderStrategy::networkProcessCrashed): +(WebKit::WebLoaderStrategy::loadResourceSynchronously): +* WebProcess/Network/WebLoaderStrategy.h: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254078 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-06 Keith Rollin + +Reformat WebPage logging +https://bugs.webkit.org/show_bug.cgi?id=205709 + + +Reviewed by Brent Fulgham. + +Update the format used by WebPage in its RELEASE_LOG logging. Use the +format used by WebPageProxy and NetworkResourceLoader, which is +generally of the form: + + - [] ::: + +So, for example: + +0x4a1df5000 - WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (frame=0x4a1db0220, priority=0, webPageID=15, frameID=3, resourceID=32)', + +becomes: + +0x4a1df5000 - [resourceLoader=0x1418b7200, frameLoader=0x1326d7340, frame=0x4a1db0220, webPageID=15, frameID=3, resourceID=32] WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (priority=2) + +This new form is a lot more verbose, but it really helps in tracing +activity from the top of our page/frame/resource load stack to the +bottom. + +No new tests - no added or changed
[webkit-changes] [254592] branches/safari-609-branch/Source/WebKit
Title: [254592] branches/safari-609-branch/Source/WebKit Revision 254592 Author alanc...@apple.com Date 2020-01-15 11:14:53 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254147. rdar://problem/58549096 Reformat WebFrameLoaderClient logging https://bugs.webkit.org/show_bug.cgi?id=205869 Reviewed by Brent Fulgham. Update the format used by WebFrameLoaderClient in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: - [] ::: So, for example: 0x4a1d7c310 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition, page = 0x7f83ba009208 becomes: 0x4a1d7c310 - [webFrame=0x7ff703f03b68, webFrameID=3, webPage=0x7ff704831808, webPageID=15] WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition No new tests - no added or changed functionality. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailLoad): (WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254147 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Diff Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254591 => 254592) --- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:14:50 UTC (rev 254591) +++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:14:53 UTC (rev 254592) @@ -1,5 +1,70 @@ 2020-01-14 Alan Coon +Cherry-pick r254147. rdar://problem/58549096 + +Reformat WebFrameLoaderClient logging +https://bugs.webkit.org/show_bug.cgi?id=205869 + + +Reviewed by Brent Fulgham. + +Update the format used by WebFrameLoaderClient in its RELEASE_LOG +logging. Use the format used by WebPageProxy and +NetworkResourceLoader, which is generally of the form: + + - [] ::: + +So, for example: + +0x4a1d7c310 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition, page = 0x7f83ba009208 + +becomes: + +0x4a1d7c310 - [webFrame=0x7ff703f03b68, webFrameID=3, webPage=0x7ff704831808, webPageID=15] WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition + +No new tests - no added or changed functionality. + +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): +(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad): +(WebKit::WebFrameLoaderClient::dispatchDidFailLoad): +(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254147 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-07 Keith Rollin + +Reformat WebFrameLoaderClient logging +https://bugs.webkit.org/show_bug.cgi?id=205869 + + +Reviewed by Brent Fulgham. + +Update the format used by WebFrameLoaderClient in its RELEASE_LOG +logging. Use the format used by WebPageProxy and +NetworkResourceLoader, which is generally of the form: + + - [] ::: + +So, for example: + +0x4a1d7c310 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition, page = 0x7f83ba009208 + +becomes: + +0x4a1d7c310 - [webFrame=0x7ff703f03b68, webFrameID=3, webPage=0x7ff704831808, webPageID=15] WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition + +No new tests - no added or changed functionality. + +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): +(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad): +(WebKit::WebFrameLoaderClient::dispatchDidFailLoad): +(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone): + +2020-01-14 Alan Coon + Cherry-pick r254092. rdar://problem/58552872 NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions Modified: branches/safari-609-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (254591 => 254592) --- branches/safari-609-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2020-01-15 19:14:50 UTC (rev 254591) +++
[webkit-changes] [254601] branches/safari-609-branch/Source
Title: [254601] branches/safari-609-branch/Source Revision 254601 Author alanc...@apple.com Date 2020-01-15 11:15:19 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254239. rdar://problem/58549100 Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable https://bugs.webkit.org/show_bug.cgi?id=205963 Reviewed by Brent Fulgham. To get default on behavior, experimental features in the network process need to be turned from enable flags to disable flags. This patch does that for the experimental cookie blocking flag. Source/WebCore: No new tests. This change just reverses the interpretation of a flag. * page/Settings.yaml: Source/WebKit: This change also aligns the init values of the setting to match the default. * NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: * NetworkProcess/NetworkSession.h: * NetworkProcess/NetworkSessionCreationParameters.h: * Shared/WebPreferences.yaml: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess): * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254239 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/page/Settings.yaml branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h branches/safari-609-branch/Source/WebKit/NetworkProcess/NetworkSession.h branches/safari-609-branch/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h branches/safari-609-branch/Source/WebKit/Shared/WebPreferences.yaml branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessPool.cpp branches/safari-609-branch/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm Diff Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254600 => 254601) --- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:15 UTC (rev 254600) +++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:19 UTC (rev 254601) @@ -1,5 +1,57 @@ 2020-01-14 Alan Coon +Cherry-pick r254239. rdar://problem/58549100 + +Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable +https://bugs.webkit.org/show_bug.cgi?id=205963 + + +Reviewed by Brent Fulgham. + +To get default on behavior, experimental features in the network process need to be +turned from enable flags to disable flags. This patch does that for the experimental +cookie blocking flag. + +Source/WebCore: + +No new tests. This change just reverses the interpretation of a flag. + +* page/Settings.yaml: + +Source/WebKit: + +This change also aligns the init values of the setting to match the default. + +* NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: +* NetworkProcess/NetworkSession.h: +* NetworkProcess/NetworkSessionCreationParameters.h: +* Shared/WebPreferences.yaml: +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::ensureNetworkProcess): +* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: +(WebKit::WebsiteDataStore::parameters): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254239 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-08 John Wilander + +Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable +https://bugs.webkit.org/show_bug.cgi?id=205963 + + +Reviewed by Brent Fulgham. + +To get default on behavior, experimental features in the network process need to be +turned from enable flags to disable flags. This patch does that for the experimental +cookie blocking flag. + +No new tests. This change just reverses the interpretation of a flag. + +* page/Settings.yaml: + +2020-01-14 Alan Coon + Cherry-pick r254201. rdar://problem/58552859 [Web Animations] Stop creating CSS Animations for elements Modified: branches/safari-609-branch/Source/WebCore/page/Settings.yaml (254600 => 254601) --- branches/safari-609-branch/Source/WebCore/page/Settings.yaml 2020-01-15 19:15:15 UTC (rev 254600) +++ branches/safari-609-branch/Source/WebCore/page/Settings.yaml 2020-01-15 19:15:19 UTC (rev 254601) @@ -886,8 +886,8 @@ initial: true inspectorOverride: true -isThirdPartyCookieBlockingEnabled: - initial: true +isThirdPartyCookieBlockingDisabled: + initial: false isFirstPartyWebsiteDataRemovalEnabled: initial: true Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254600 => 254601) --- branches/safari-609-branch/Source/WebKit/ChangeLog
[webkit-changes] [254594] branches/safari-609-branch/Source/WebCore
Title: [254594] branches/safari-609-branch/Source/WebCore
Revision 254594
Author alanc...@apple.com
Date 2020-01-15 11:14:58 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254155. rdar://problem/58552864
Add a move constructor to IDBResultData
https://bugs.webkit.org/show_bug.cgi?id=205833
Reviewed by Youenn Fablet.
* Modules/indexeddb/shared/IDBResultData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254593 => 254594)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:14:55 UTC (rev 254593)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:14:58 UTC (rev 254594)
@@ -1,5 +1,30 @@
2020-01-14 Alan Coon
+Cherry-pick r254155. rdar://problem/58552864
+
+Add a move constructor to IDBResultData
+https://bugs.webkit.org/show_bug.cgi?id=205833
+
+
+Reviewed by Youenn Fablet.
+
+* Modules/indexeddb/shared/IDBResultData.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-07 Sihui Liu
+
+Add a move constructor to IDBResultData
+https://bugs.webkit.org/show_bug.cgi?id=205833
+
+
+Reviewed by Youenn Fablet.
+
+* Modules/indexeddb/shared/IDBResultData.h:
+
+2020-01-14 Alan Coon
+
Cherry-pick r254099. rdar://problem/58552889
[iOS] Only prewarm fonts with valid font names
Modified: branches/safari-609-branch/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h (254593 => 254594)
--- branches/safari-609-branch/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h 2020-01-15 19:14:55 UTC (rev 254593)
+++ branches/safari-609-branch/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h 2020-01-15 19:14:58 UTC (rev 254594)
@@ -88,6 +88,7 @@
static IDBResultData iterateCursorSuccess(const IDBResourceIdentifier&, const IDBGetResult&);
WEBCORE_EXPORT IDBResultData(const IDBResultData&);
+IDBResultData(IDBResultData&&) = default;
IDBResultData& operator=(IDBResultData&&) = default;
enum IsolatedCopyTag { IsolatedCopy };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254590] branches/safari-609-branch/Source/WebCore/PAL
Title: [254590] branches/safari-609-branch/Source/WebCore/PAL
Revision 254590
Author alanc...@apple.com
Date 2020-01-15 11:14:47 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254141. rdar://problem/58559202
Flaky API Test: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
https://bugs.webkit.org/show_bug.cgi?id=194340
Reviewed by Eric Carlson.
Workaround for AVFoundation crash for OS versions prior to platform fix. This crash occurrs infrequently
while triggering KVO due to an internal @property change. Work around the crash by disabling KVO for that
property at runtime, by injecting a new class method +automaticallyNotifiesObserversOfSuppressesVideoLayers
immediately after soft linking the AVFoundation library.
* pal/cocoa/AVFoundationSoftLink.mm:
(PAL::justReturnsNO):
(PAL::AVFoundationLibrary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/PAL/ChangeLog
branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm
Diff
Modified: branches/safari-609-branch/Source/WebCore/PAL/ChangeLog (254589 => 254590)
--- branches/safari-609-branch/Source/WebCore/PAL/ChangeLog 2020-01-15 19:14:45 UTC (rev 254589)
+++ branches/safari-609-branch/Source/WebCore/PAL/ChangeLog 2020-01-15 19:14:47 UTC (rev 254590)
@@ -1,5 +1,44 @@
2020-01-14 Alan Coon
+Cherry-pick r254141. rdar://problem/58559202
+
+Flaky API Test: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
+https://bugs.webkit.org/show_bug.cgi?id=194340
+
+
+Reviewed by Eric Carlson.
+
+Workaround for AVFoundation crash for OS versions prior to platform fix. This crash occurrs infrequently
+while triggering KVO due to an internal @property change. Work around the crash by disabling KVO for that
+property at runtime, by injecting a new class method +automaticallyNotifiesObserversOfSuppressesVideoLayers
+immediately after soft linking the AVFoundation library.
+
+* pal/cocoa/AVFoundationSoftLink.mm:
+(PAL::justReturnsNO):
+(PAL::AVFoundationLibrary):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-07 Jer Noble
+
+Flaky API Test: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
+https://bugs.webkit.org/show_bug.cgi?id=194340
+
+
+Reviewed by Eric Carlson.
+
+Workaround for AVFoundation crash for OS versions prior to platform fix. This crash occurrs infrequently
+while triggering KVO due to an internal @property change. Work around the crash by disabling KVO for that
+property at runtime, by injecting a new class method +automaticallyNotifiesObserversOfSuppressesVideoLayers
+immediately after soft linking the AVFoundation library.
+
+* pal/cocoa/AVFoundationSoftLink.mm:
+(PAL::justReturnsNO):
+(PAL::AVFoundationLibrary):
+
+2020-01-14 Alan Coon
+
Cherry-pick r254042. rdar://problem/58549102
Source/WebCore/PAL:
Modified: branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm (254589 => 254590)
--- branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm 2020-01-15 19:14:45 UTC (rev 254589)
+++ branches/safari-609-branch/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm 2020-01-15 19:14:47 UTC (rev 254590)
@@ -30,8 +30,38 @@
#import
#import
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13)
SOFT_LINK_FRAMEWORK_FOR_SOURCE_WITH_EXPORT(PAL, AVFoundation, PAL_EXPORT)
+#else
+@interface AVPlayerItem (DisableKVOOnSupressesVideoLayers)
++ (BOOL)automaticallyNotifiesObserversOfSuppressesVideoLayers;
+@end
+namespace PAL {
+
+static BOOL justReturnsNO()
+{
+return NO;
+}
+
+PAL_EXPORT void* AVFoundationLibrary(bool isOptional = false);
+void* AVFoundationLibrary(bool isOptional)
+{
+static void* frameworkLibrary;
+static dispatch_once_t once;
+dispatch_once(, ^{
+frameworkLibrary = dlopen("/System/Library/Frameworks/AVFoundation.framework/AVFoundation", RTLD_NOW);
+if (!isOptional)
+RELEASE_ASSERT_WITH_MESSAGE(frameworkLibrary, "%s", dlerror());
+
+class_addMethod(objc_getClass("AVPlayerItem"), @selector(automaticallyNotifiesObserversOfSuppressesVideoLayers), (IMP)justReturnsNO, "B@:");
+});
+return frameworkLibrary;
+}
+
+}
+#endif
+
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(PAL, AVFoundation, AVAssetCache, PAL_EXPORT)
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(PAL, AVFoundation, AVAssetImageGenerator, PAL_EXPORT)
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(PAL, AVFoundation, AVAssetReader, PAL_EXPORT)
___
webkit-changes
[webkit-changes] [254581] branches/safari-609-branch
Title: [254581] branches/safari-609-branch Revision 254581 Author alanc...@apple.com Date 2020-01-15 11:14:21 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254042. rdar://problem/58549102 Source/WebCore/PAL: DumpRenderTree doesn't always call updateRendering() when a test completes https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Add -[CATransaction synchronize]. * pal/spi/cocoa/QuartzCoreSPI.h: Source/WebKit: DumpRenderTree doesn't always call updateRendering() when a test completes https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Use the QuartzCore SPI header. * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: Source/WebKitLegacy/mac: Fix a souce of WebKit1 test flakiness https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Some animation tests (and possibly many others) are flakey or broken in WK1 because there was no code to guarantee that Page::updateRendering() was called at notifyDone() time. WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, and flushes a CATransaction. In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, and just called [webView display] to make this happen. However, with layer backing, AppKit behavior changes, and WebCore changes that make more things happen with HTML event loop timing, this approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what WK2 is doing. * WebView/WebView.mm: (-[WebView _forceRepaintForTesting]): * WebView/WebViewPrivate.h: Tools: DumpRenderTree doesn't always call updateRendering() when a test completes https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Some animation tests (and possibly many others) are flakey or broken in WK1 because there was no code to guarantee that Page::updateRendering() was called at notifyDone() time. WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, and flushes a CATransaction. In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, and just called [webView display] to make this happen. However, with layer backing, AppKit behavior changes, and WebCore changes that make more things happen with HTML event loop timing, this approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what WK2 is doing. * DumpRenderTree/mac/DumpRenderTree.mm: (updateDisplay): * DumpRenderTree/mac/PixelDumpSupportMac.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254042 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/platform/mac-wk1/TestExpectations branches/safari-609-branch/Source/WebCore/PAL/ChangeLog branches/safari-609-branch/Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm branches/safari-609-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebView.mm branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h branches/safari-609-branch/Tools/ChangeLog branches/safari-609-branch/Tools/DumpRenderTree/mac/DumpRenderTree.mm branches/safari-609-branch/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm Diff Modified: branches/safari-609-branch/LayoutTests/platform/mac-wk1/TestExpectations (254580 => 254581) --- branches/safari-609-branch/LayoutTests/platform/mac-wk1/TestExpectations 2020-01-15 19:14:14 UTC (rev 254580) +++ branches/safari-609-branch/LayoutTests/platform/mac-wk1/TestExpectations 2020-01-15 19:14:21 UTC (rev 254581) @@ -809,6 +809,7 @@ # No support for reftest-wait in DRT. imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-setattribute-value.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ ImageOnlyFailure ] # REGRESSION (Mojave): 12 fast/images tests timing out on WK1 [ Mojave+ ] fast/images/animated-heics-draw.html [ Skip ] Modified: branches/safari-609-branch/Source/WebCore/PAL/ChangeLog (254580 => 254581) --- branches/safari-609-branch/Source/WebCore/PAL/ChangeLog 2020-01-15 19:14:14 UTC (rev 254580) +++ branches/safari-609-branch/Source/WebCore/PAL/ChangeLog 2020-01-15 19:14:21 UTC (rev 254581) @@ -1,3 +1,86 @@ +2020-01-14 Alan Coon + +Cherry-pick r254042. rdar://problem/58549102 + +Source/WebCore/PAL: +DumpRenderTree doesn't always call updateRendering() when a test completes +https://bugs.webkit.org/show_bug.cgi?id=205761 + +Reviewed by Darin Adler. + +Add -[CATransaction synchronize].
[webkit-changes] [254625] trunk
Title: [254625] trunk
Revision 254625
Author jbed...@apple.com
Date 2020-01-15 11:33:52 -0800 (Wed, 15 Jan 2020)
Log Message
webkitpy: Remove self assignments
https://bugs.webkit.org/show_bug.cgi?id=206294
Reviewed by Aakash Jain.
Source/_javascript_Core:
* inspector/scripts/codegen/generator.py:
(Generator.js_name_for_parameter_type):
Tools:
* Scripts/webkitpy/common/webkit_finder.py:
(WebKitFinder.webkit_base):
* Scripts/webkitpy/port/factory.py:
(_builder_options):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/webkit_finder.py
trunk/Tools/Scripts/webkitpy/port/factory.py
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (254624 => 254625)
--- trunk/Source/_javascript_Core/ChangeLog 2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-01-15 19:33:52 UTC (rev 254625)
@@ -1,3 +1,13 @@
+2020-01-15 Jonathan Bedard
+
+webkitpy: Remove self assignments
+https://bugs.webkit.org/show_bug.cgi?id=206294
+
+Reviewed by Aakash Jain.
+
+* inspector/scripts/codegen/generator.py:
+(Generator.js_name_for_parameter_type):
+
2020-01-14 Commit Queue
Unreviewed, rolling out r254480, r254496, and r254517.
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py (254624 => 254625)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py 2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py 2020-01-15 19:33:52 UTC (rev 254625)
@@ -295,7 +295,6 @@
@staticmethod
def js_name_for_parameter_type(_type):
-_type = _type
if isinstance(_type, AliasedType):
_type = _type.aliased_type # Fall through.
if isinstance(_type, EnumType):
Modified: trunk/Tools/ChangeLog (254624 => 254625)
--- trunk/Tools/ChangeLog 2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Tools/ChangeLog 2020-01-15 19:33:52 UTC (rev 254625)
@@ -1,3 +1,15 @@
+2020-01-15 Jonathan Bedard
+
+webkitpy: Remove self assignments
+https://bugs.webkit.org/show_bug.cgi?id=206294
+
+Reviewed by Aakash Jain.
+
+* Scripts/webkitpy/common/webkit_finder.py:
+(WebKitFinder.webkit_base):
+* Scripts/webkitpy/port/factory.py:
+(_builder_options):
+
2020-01-15 Alicia Boya García
[WTF] Remove MediaTime.cpp test warning in GCC
Modified: trunk/Tools/Scripts/webkitpy/common/webkit_finder.py (254624 => 254625)
--- trunk/Tools/Scripts/webkitpy/common/webkit_finder.py 2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Tools/Scripts/webkitpy/common/webkit_finder.py 2020-01-15 19:33:52 UTC (rev 254625)
@@ -44,7 +44,6 @@
# (the chromium test bots, for example), might only check out subdirectories like
# Tools/Scripts. This code will also work if there is no SCM system at all.
if not self._webkit_base:
-self._webkit_base = self._webkit_base
module_path = self._filesystem.path_to_module(self.__module__)
tools_index = module_path.rfind('Tools')
assert tools_index != -1, "could not find location of this checkout from %s" % module_path
Modified: trunk/Tools/Scripts/webkitpy/port/factory.py (254624 => 254625)
--- trunk/Tools/Scripts/webkitpy/port/factory.py 2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Tools/Scripts/webkitpy/port/factory.py 2020-01-15 19:33:52 UTC (rev 254625)
@@ -91,7 +91,6 @@
def _builder_options(builder_name):
configuration = "Debug" if re.search(r"[d|D](ebu|b)g", builder_name) else "Release"
is_webkit2 = builder_name.find("WK2") != -1
-builder_name = builder_name
return optparse.Values({'builder_name': builder_name, 'configuration': configuration, 'webkit_test_runner': is_webkit2})
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254626] trunk
Title: [254626] trunk
Revision 254626
Author shvaikal...@gmail.com
Date 2020-01-15 11:57:38 -0800 (Wed, 15 Jan 2020)
Log Message
Object.preventExtensions should throw if not successful
https://bugs.webkit.org/show_bug.cgi?id=206131
Reviewed by Ross Kirsling.
JSTests:
* test262/expectations.yaml: Mark 2 test cases as passing.
Source/_javascript_Core:
With this change, Object.preventExtensions throws TypeError if [[PreventExtensions]]
returns `false`. This is possible if Object.preventExtensions is called on a Proxy object.
(step 3 of https://tc39.es/ecma262/#sec-object.preventextensions)
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorPreventExtensions):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ObjectConstructor.cpp
Diff
Modified: trunk/JSTests/ChangeLog (254625 => 254626)
--- trunk/JSTests/ChangeLog 2020-01-15 19:33:52 UTC (rev 254625)
+++ trunk/JSTests/ChangeLog 2020-01-15 19:57:38 UTC (rev 254626)
@@ -1,3 +1,12 @@
+2020-01-15 Alexey Shvayka
+
+Object.preventExtensions should throw if not successful
+https://bugs.webkit.org/show_bug.cgi?id=206131
+
+Reviewed by Ross Kirsling.
+
+* test262/expectations.yaml: Mark 2 test cases as passing.
+
2020-01-14 Commit Queue
Unreviewed, rolling out r254480, r254496, and r254517.
Modified: trunk/JSTests/test262/expectations.yaml (254625 => 254626)
--- trunk/JSTests/test262/expectations.yaml 2020-01-15 19:33:52 UTC (rev 254625)
+++ trunk/JSTests/test262/expectations.yaml 2020-01-15 19:57:38 UTC (rev 254626)
@@ -1165,9 +1165,6 @@
test/built-ins/Object/internals/DefineOwnProperty/consistent-value-regexp-dollar1.js:
default: 'Test262Error: Expected SameValue(«», «x») to be true'
strict mode: 'Test262Error: Expected SameValue(«», «x») to be true'
-test/built-ins/Object/preventExtensions/throws-when-false.js:
- default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
- strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
test/built-ins/Object/proto-from-ctor-realm.js:
default: 'Test262Error: Expected SameValue(«[object Object]», «[object Object]») to be true'
strict mode: 'Test262Error: Expected SameValue(«[object Object]», «[object Object]») to be true'
Modified: trunk/Source/_javascript_Core/ChangeLog (254625 => 254626)
--- trunk/Source/_javascript_Core/ChangeLog 2020-01-15 19:33:52 UTC (rev 254625)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-01-15 19:57:38 UTC (rev 254626)
@@ -1,3 +1,17 @@
+2020-01-15 Alexey Shvayka
+
+Object.preventExtensions should throw if not successful
+https://bugs.webkit.org/show_bug.cgi?id=206131
+
+Reviewed by Ross Kirsling.
+
+With this change, Object.preventExtensions throws TypeError if [[PreventExtensions]]
+returns `false`. This is possible if Object.preventExtensions is called on a Proxy object.
+(step 3 of https://tc39.es/ecma262/#sec-object.preventextensions)
+
+* runtime/ObjectConstructor.cpp:
+(JSC::objectConstructorPreventExtensions):
+
2020-01-15 Jonathan Bedard
webkitpy: Remove self assignments
Modified: trunk/Source/_javascript_Core/runtime/ObjectConstructor.cpp (254625 => 254626)
--- trunk/Source/_javascript_Core/runtime/ObjectConstructor.cpp 2020-01-15 19:33:52 UTC (rev 254625)
+++ trunk/Source/_javascript_Core/runtime/ObjectConstructor.cpp 2020-01-15 19:57:38 UTC (rev 254626)
@@ -836,11 +836,16 @@
EncodedJSValue JSC_HOST_CALL objectConstructorPreventExtensions(JSGlobalObject* globalObject, CallFrame* callFrame)
{
VM& vm = globalObject->vm();
+auto scope = DECLARE_THROW_SCOPE(vm);
+
JSValue argument = callFrame->argument(0);
if (!argument.isObject())
return JSValue::encode(argument);
JSObject* object = asObject(argument);
-object->methodTable(vm)->preventExtensions(object, globalObject);
+bool status = object->methodTable(vm)->preventExtensions(object, globalObject);
+RETURN_IF_EXCEPTION(scope, { });
+if (UNLIKELY(!status))
+return throwVMTypeError(globalObject, scope, "Unable to prevent extension in Object.preventExtensions"_s);
return JSValue::encode(object);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254631] trunk/Source/WebCore
Title: [254631] trunk/Source/WebCore
Revision 254631
Author simon.fra...@apple.com
Date 2020-01-15 13:22:55 -0800 (Wed, 15 Jan 2020)
Log Message
Add more mousewheel-scrolling logging and improve the latching code
https://bugs.webkit.org/show_bug.cgi?id=206298
Reviewed by Tim Horton.
Make PlatformWheelEvent TextStream-loggable, and add more Scrolling logging in some places
related to mouseWheel scrolling and latching.
Make the ownership of Elements and Nodes given to ScrollLatchingState more explicit by passing in
RefPtr<>&&.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* page/EventHandler.cpp:
(WebCore::handleWheelEventInAppropriateEnclosingBox):
(WebCore::EventHandler::defaultWheelEventHandler):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents):
(WebCore::EventHandler::platformCompleteWheelEvent):
* page/scrolling/ScrollLatchingState.cpp:
(WebCore::ScrollLatchingState::setWheelEventElement):
(WebCore::ScrollLatchingState::setPreviousWheelScrolledElement):
(WebCore::ScrollLatchingState::setScrollableContainer):
* page/scrolling/ScrollLatchingState.h:
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
* platform/PlatformWheelEvent.cpp: Copied from Source/WebCore/page/scrolling/ScrollLatchingState.cpp.
(WebCore::operator<<):
* platform/PlatformWheelEvent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/mac/EventHandlerMac.mm
trunk/Source/WebCore/page/scrolling/ScrollLatchingState.cpp
trunk/Source/WebCore/page/scrolling/ScrollLatchingState.h
trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp
trunk/Source/WebCore/platform/PlatformWheelEvent.h
Added Paths
trunk/Source/WebCore/platform/PlatformWheelEvent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (254630 => 254631)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 21:17:50 UTC (rev 254630)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 21:22:55 UTC (rev 254631)
@@ -1,3 +1,35 @@
+2020-01-15 Simon Fraser
+
+Add more mousewheel-scrolling logging and improve the latching code
+https://bugs.webkit.org/show_bug.cgi?id=206298
+
+Reviewed by Tim Horton.
+
+Make PlatformWheelEvent TextStream-loggable, and add more Scrolling logging in some places
+related to mouseWheel scrolling and latching.
+
+Make the ownership of Elements and Nodes given to ScrollLatchingState more explicit by passing in
+RefPtr<>&&.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* page/EventHandler.cpp:
+(WebCore::handleWheelEventInAppropriateEnclosingBox):
+(WebCore::EventHandler::defaultWheelEventHandler):
+* page/mac/EventHandlerMac.mm:
+(WebCore::EventHandler::platformPrepareForWheelEvents):
+(WebCore::EventHandler::platformCompleteWheelEvent):
+* page/scrolling/ScrollLatchingState.cpp:
+(WebCore::ScrollLatchingState::setWheelEventElement):
+(WebCore::ScrollLatchingState::setPreviousWheelScrolledElement):
+(WebCore::ScrollLatchingState::setScrollableContainer):
+* page/scrolling/ScrollLatchingState.h:
+* page/scrolling/ScrollingTree.cpp:
+(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
+* platform/PlatformWheelEvent.cpp: Copied from Source/WebCore/page/scrolling/ScrollLatchingState.cpp.
+(WebCore::operator<<):
+* platform/PlatformWheelEvent.h:
+
2020-01-15 Zalan Bujtas
[LFC][IFC] LineLayoutContext::nextContentForLine should take LineCandidateContent&
Modified: trunk/Source/WebCore/Sources.txt (254630 => 254631)
--- trunk/Source/WebCore/Sources.txt 2020-01-15 21:17:50 UTC (rev 254630)
+++ trunk/Source/WebCore/Sources.txt 2020-01-15 21:22:55 UTC (rev 254631)
@@ -1753,6 +1753,7 @@
platform/PlatformSpeechSynthesisVoice.cpp
platform/PlatformSpeechSynthesizer.cpp
platform/PlatformStrategies.cpp
+platform/PlatformWheelEvent.cpp
platform/PreviewConverter.cpp
platform/ProcessIdentifier.cpp
platform/ReferrerPolicy.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (254630 => 254631)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-01-15 21:17:50 UTC (rev 254630)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-01-15 21:22:55 UTC (rev 254631)
@@ -5822,6 +5822,7 @@
0FD41E6721F80282000C006D /* ScrollingTreeFrameHostingNode.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = ScrollingTreeFrameHostingNode.cpp; sourceTree = ""; };
0FD723800EC8BD9300CA5DD7 /* FloatQuad.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FloatQuad.h; sourceTree = ""; };
0FD723810EC8BD9300CA5DD7 /* FloatQuad.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
[webkit-changes] [254634] trunk/Source/WebCore
Title: [254634] trunk/Source/WebCore
Revision 254634
Author an...@apple.com
Date 2020-01-15 13:49:37 -0800 (Wed, 15 Jan 2020)
Log Message
[LFC] Cache display box for the first LayoutState to Layout::Box
https://bugs.webkit.org/show_bug.cgi?id=206288
Reviewed by Zalan Bujtas.
Add a single item cache for the common case to avoid using the hash.
* layout/FormattingState.cpp:
(WebCore::Layout::FormattingState::displayBox):
* layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::displayBoxForRootLayoutBox):
(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBoxSlow):
(WebCore::Layout::LayoutState::displayBoxForLayoutBox): Deleted.
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const): Deleted.
* layout/LayoutState.h:
(WebCore::Layout::Box::cachedDisplayBoxForLayoutState const):
(WebCore::Layout::LayoutState::hasDisplayBox const):
(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBox):
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const):
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::setCachedDisplayBoxForLayoutState const):
* layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::hasCachedDisplayBox const):
* layout/layouttree/LayoutTreeBuilder.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingState.cpp
trunk/Source/WebCore/layout/LayoutState.cpp
trunk/Source/WebCore/layout/LayoutState.h
trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp
trunk/Source/WebCore/layout/layouttree/LayoutBox.h
trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (254633 => 254634)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 21:41:50 UTC (rev 254633)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 21:49:37 UTC (rev 254634)
@@ -1,3 +1,30 @@
+2020-01-15 Antti Koivisto
+
+[LFC] Cache display box for the first LayoutState to Layout::Box
+https://bugs.webkit.org/show_bug.cgi?id=206288
+
+Reviewed by Zalan Bujtas.
+
+Add a single item cache for the common case to avoid using the hash.
+
+* layout/FormattingState.cpp:
+(WebCore::Layout::FormattingState::displayBox):
+* layout/LayoutState.cpp:
+(WebCore::Layout::LayoutState::displayBoxForRootLayoutBox):
+(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBoxSlow):
+(WebCore::Layout::LayoutState::displayBoxForLayoutBox): Deleted.
+(WebCore::Layout::LayoutState::displayBoxForLayoutBox const): Deleted.
+* layout/LayoutState.h:
+(WebCore::Layout::Box::cachedDisplayBoxForLayoutState const):
+(WebCore::Layout::LayoutState::hasDisplayBox const):
+(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBox):
+(WebCore::Layout::LayoutState::displayBoxForLayoutBox const):
+* layout/layouttree/LayoutBox.cpp:
+(WebCore::Layout::Box::setCachedDisplayBoxForLayoutState const):
+* layout/layouttree/LayoutBox.h:
+(WebCore::Layout::Box::hasCachedDisplayBox const):
+* layout/layouttree/LayoutTreeBuilder.h:
+
2020-01-15 Simon Fraser
Add more mousewheel-scrolling logging and improve the latching code
Modified: trunk/Source/WebCore/layout/FormattingState.cpp (254633 => 254634)
--- trunk/Source/WebCore/layout/FormattingState.cpp 2020-01-15 21:41:50 UTC (rev 254633)
+++ trunk/Source/WebCore/layout/FormattingState.cpp 2020-01-15 21:49:37 UTC (rev 254634)
@@ -51,7 +51,7 @@
{
// Should never need to mutate a display box outside of the formatting context.
ASSERT(().establishedFormattingState(layoutBox.formattingContextRoot()) == this);
-return layoutState().displayBoxForLayoutBox(layoutBox);
+return layoutState().ensureDisplayBoxForLayoutBox(layoutBox);
}
}
Modified: trunk/Source/WebCore/layout/LayoutState.cpp (254633 => 254634)
--- trunk/Source/WebCore/layout/LayoutState.cpp 2020-01-15 21:41:50 UTC (rev 254633)
+++ trunk/Source/WebCore/layout/LayoutState.cpp 2020-01-15 21:49:37 UTC (rev 254634)
@@ -60,22 +60,24 @@
Display::Box& LayoutState::displayBoxForRootLayoutBox()
{
-return displayBoxForLayoutBox(m_layoutTreeContent->rootLayoutBox());
+return ensureDisplayBoxForLayoutBox(m_layoutTreeContent->rootLayoutBox());
}
-Display::Box& LayoutState::displayBoxForLayoutBox(const Box& layoutBox)
+Display::Box& LayoutState::ensureDisplayBoxForLayoutBoxSlow(const Box& layoutBox)
{
+if (layoutBox.canCacheForLayoutState(*this)) {
+ASSERT(!layoutBox.cachedDisplayBoxForLayoutState(*this));
+auto newBox = makeUnique();
+auto& newBoxPtr = *newBox;
+layoutBox.setCachedDisplayBoxForLayoutState(*this, WTFMove(newBox));
+return newBoxPtr;
+}
+
return *m_layoutToDisplayBox.ensure(, [] {
return makeUnique();
}).iterator->value;
}
-const Display::Box& LayoutState::displayBoxForLayoutBox(const Box& layoutBox) const
-{
-ASSERT(hasDisplayBox(layoutBox));
-return
[webkit-changes] [254591] branches/safari-609-branch
Title: [254591] branches/safari-609-branch
Revision 254591
Author alanc...@apple.com
Date 2020-01-15 11:14:50 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254145. rdar://problem/58552861
REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205807
Reviewed by Dean Jackson.
Source/WebInspectorUI:
* UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.async createBootstrapScript):
(WI.NetworkManager.prototype._handleBootstrapScriptContentDidChange):
Ensure that `Page.setBootstrapScript` is called when restoring the bootstrap script from the
IndexedDB storage. Otherwise, in situations like when Web Inspector is first opened, we will
show the Inspector Bootstrap Script in the UI, but not actually set it on the inspected page.
LayoutTests:
* inspector/page/setBootstrapScript-main-frame.html:
In addition to waiting for `Page.reload`, we should also wait for the page to actually load.
Set the content of the bootstrap script during its creation instead of as a two step process.
Avoid an assertion by setting the enabled state after the bootstrap script is initalized.
* platform/mac/TestExpectations:
Remove expectation added in r254059.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/inspector/page/setBootstrapScript-main-frame.html
branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-609-branch/Source/WebInspectorUI/ChangeLog
branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js
Diff
Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254590 => 254591)
--- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:47 UTC (rev 254590)
+++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:50 UTC (rev 254591)
@@ -1,5 +1,52 @@
2020-01-14 Alan Coon
+Cherry-pick r254145. rdar://problem/58552861
+
+REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205807
+
+
+Reviewed by Dean Jackson.
+
+Source/WebInspectorUI:
+
+* UserInterface/Controllers/NetworkManager.js:
+(WI.NetworkManager.prototype.async createBootstrapScript):
+(WI.NetworkManager.prototype._handleBootstrapScriptContentDidChange):
+Ensure that `Page.setBootstrapScript` is called when restoring the bootstrap script from the
+IndexedDB storage. Otherwise, in situations like when Web Inspector is first opened, we will
+show the Inspector Bootstrap Script in the UI, but not actually set it on the inspected page.
+
+LayoutTests:
+
+* inspector/page/setBootstrapScript-main-frame.html:
+In addition to waiting for `Page.reload`, we should also wait for the page to actually load.
+Set the content of the bootstrap script during its creation instead of as a two step process.
+Avoid an assertion by setting the enabled state after the bootstrap script is initalized.
+
+* platform/mac/TestExpectations:
+Remove expectation added in r254059.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-07 Devin Rousso
+
+REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205807
+
+
+Reviewed by Dean Jackson.
+
+* inspector/page/setBootstrapScript-main-frame.html:
+In addition to waiting for `Page.reload`, we should also wait for the page to actually load.
+Set the content of the bootstrap script during its creation instead of as a two step process.
+Avoid an assertion by setting the enabled state after the bootstrap script is initalized.
+
+* platform/mac/TestExpectations:
+Remove expectation added in r254059.
+
+2020-01-14 Alan Coon
+
Cherry-pick r254074. rdar://problem/58549078
REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1
Modified: branches/safari-609-branch/LayoutTests/inspector/page/setBootstrapScript-main-frame.html (254590 => 254591)
--- branches/safari-609-branch/LayoutTests/inspector/page/setBootstrapScript-main-frame.html 2020-01-15 19:14:47 UTC (rev 254590)
+++ branches/safari-609-branch/LayoutTests/inspector/page/setBootstrapScript-main-frame.html 2020-01-15 19:14:50 UTC (rev 254591)
@@ -11,19 +11,21 @@
name: "Page.setBootstrapScript.MainFrame",
description: "Test that the bootstrap script is executed in the main frame.",
async test() {
+
[webkit-changes] [254580] branches/safari-609-branch/Source/WebKit
Title: [254580] branches/safari-609-branch/Source/WebKit
Revision 254580
Author alanc...@apple.com
Date 2020-01-15 11:14:14 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254033. rdar://problem/58548645
Reformat WebPage logging
https://bugs.webkit.org/show_bug.cgi?id=205705
Reviewed by Alex Christensen.
Update the format used by WebPage in its RELEASE_LOG logging. Use the
format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:
- [] :::
So, for example:
0x7f83ba009208 - WebPage (webPageID=15) - Adding a reason 1 to freeze layer tree (now 1); old reasons were 0
becomes:
0x7f83ba009208 - [webPageID=15] WebPage::freezeLayerTree: Adding a reason to freeze layer tree (reason=1, new=1, old=0)
No new tests - no added or changed functionality.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_overriddenMediaType):
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):
(WebKit::WebPage::markLayersVolatile):
(WebKit::WebPage::cancelMarkLayersVolatile):
(WebKit::WebPage::touchEventSync):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254579 => 254580)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:12:20 UTC (rev 254579)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:14:14 UTC (rev 254580)
@@ -1,3 +1,74 @@
+2020-01-14 Alan Coon
+
+Cherry-pick r254033. rdar://problem/58548645
+
+Reformat WebPage logging
+https://bugs.webkit.org/show_bug.cgi?id=205705
+
+
+Reviewed by Alex Christensen.
+
+Update the format used by WebPage in its RELEASE_LOG logging. Use the
+format used by WebPageProxy and NetworkResourceLoader, which is
+generally of the form:
+
+ - [] :::
+
+So, for example:
+
+0x7f83ba009208 - WebPage (webPageID=15) - Adding a reason 1 to freeze layer tree (now 1); old reasons were 0
+
+becomes:
+
+0x7f83ba009208 - [webPageID=15] WebPage::freezeLayerTree: Adding a reason to freeze layer tree (reason=1, new=1, old=0)
+
+No new tests - no added or changed functionality.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::m_overriddenMediaType):
+(WebKit::WebPage::createPlugin):
+(WebKit::WebPage::freezeLayerTree):
+(WebKit::WebPage::unfreezeLayerTree):
+(WebKit::WebPage::markLayersVolatile):
+(WebKit::WebPage::cancelMarkLayersVolatile):
+(WebKit::WebPage::touchEventSync):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-04 Keith Rollin
+
+Reformat WebPage logging
+https://bugs.webkit.org/show_bug.cgi?id=205705
+
+
+Reviewed by Alex Christensen.
+
+Update the format used by WebPage in its RELEASE_LOG logging. Use the
+format used by WebPageProxy and NetworkResourceLoader, which is
+generally of the form:
+
+ - [] :::
+
+So, for example:
+
+0x7f83ba009208 - WebPage (webPageID=15) - Adding a reason 1 to freeze layer tree (now 1); old reasons were 0
+
+becomes:
+
+0x7f83ba009208 - [webPageID=15] WebPage::freezeLayerTree: Adding a reason to freeze layer tree (reason=1, new=1, old=0)
+
+No new tests - no added or changed functionality.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::m_overriddenMediaType):
+(WebKit::WebPage::createPlugin):
+(WebKit::WebPage::freezeLayerTree):
+(WebKit::WebPage::unfreezeLayerTree):
+(WebKit::WebPage::markLayersVolatile):
+(WebKit::WebPage::cancelMarkLayersVolatile):
+(WebKit::WebPage::touchEventSync):
+
2020-01-13 Alan Coon
Cherry-pick r254101. rdar://problem/58535157
Modified: branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp (254579 => 254580)
--- branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-01-15 19:12:20 UTC (rev 254579)
+++ branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-01-15 19:14:14 UTC (rev 254580)
@@ -325,8 +325,8 @@
static const Seconds initialLayerVolatilityTimerInterval { 20_ms };
static const Seconds maximumLayerVolatilityTimerInterval { 2_s };
-#define RELEASE_LOG_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_IF(isAlwaysOnLoggingAllowed(), channel, "%p - WebPage::" fmt, this, ##__VA_ARGS__)
-#define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...)
[webkit-changes] [254584] branches/safari-609-branch/Source/WebKitLegacy/mac
Title: [254584] branches/safari-609-branch/Source/WebKitLegacy/mac Revision 254584 Author alanc...@apple.com Date 2020-01-15 11:14:31 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254063. rdar://problem/58559198 [Web Animations] Enable CSS Animations via Web Animations for WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=205791 Patch by Antoine Quint on 2020-01-06 Reviewed by Dean Jackson. It was an oversight that it had not been done along with the WebKit change. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254063 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm Diff Modified: branches/safari-609-branch/Source/WebKitLegacy/mac/ChangeLog (254583 => 254584) --- branches/safari-609-branch/Source/WebKitLegacy/mac/ChangeLog 2020-01-15 19:14:29 UTC (rev 254583) +++ branches/safari-609-branch/Source/WebKitLegacy/mac/ChangeLog 2020-01-15 19:14:31 UTC (rev 254584) @@ -1,5 +1,34 @@ 2020-01-14 Alan Coon +Cherry-pick r254063. rdar://problem/58559198 + +[Web Animations] Enable CSS Animations via Web Animations for WebKitLegacy +https://bugs.webkit.org/show_bug.cgi?id=205791 + +Patch by Antoine Quint on 2020-01-06 +Reviewed by Dean Jackson. + +It was an oversight that it had not been done along with the WebKit change. + +* WebView/WebPreferences.mm: +(+[WebPreferences initialize]): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254063 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-06 Antoine Quint + +[Web Animations] Enable CSS Animations via Web Animations for WebKitLegacy +https://bugs.webkit.org/show_bug.cgi?id=205791 + +Reviewed by Dean Jackson. + +It was an oversight that it had not been done along with the WebKit change. + +* WebView/WebPreferences.mm: +(+[WebPreferences initialize]): + +2020-01-14 Alan Coon + Cherry-pick r254042. rdar://problem/58549102 Source/WebCore/PAL: Modified: branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (254583 => 254584) --- branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-01-15 19:14:29 UTC (rev 254583) +++ branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-01-15 19:14:31 UTC (rev 254584) @@ -633,7 +633,7 @@ @NO, WebKitDialogElementEnabledPreferenceKey, @NO, WebKitHighlightAPIEnabledPreferenceKey, @YES, WebKitModernMediaControlsEnabledPreferenceKey, -@NO, WebKitWebAnimationsCSSIntegrationEnabledPreferenceKey, +@YES, WebKitWebAnimationsCSSIntegrationEnabledPreferenceKey, #if ENABLE(WEBGL2) @NO, WebKitWebGL2EnabledPreferenceKey, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254588] branches/safari-609-branch/Source/WebKit
Title: [254588] branches/safari-609-branch/Source/WebKit
Revision 254588
Author alanc...@apple.com
Date 2020-01-15 11:14:42 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254092. rdar://problem/58552872
NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions
https://bugs.webkit.org/show_bug.cgi?id=205824
Patch by Alex Christensen on 2020-01-06
Reviewed by Chris Dumez.
Classic iterator use after mutating iterated container was causing crashes by returning a null SessionWrapper&
This was introduced in r252185 or r248640.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::isolatedSession):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254587 => 254588)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:14:39 UTC (rev 254587)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:14:42 UTC (rev 254588)
@@ -1,5 +1,38 @@
2020-01-14 Alan Coon
+Cherry-pick r254092. rdar://problem/58552872
+
+NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions
+https://bugs.webkit.org/show_bug.cgi?id=205824
+
+
+Patch by Alex Christensen on 2020-01-06
+Reviewed by Chris Dumez.
+
+Classic iterator use after mutating iterated container was causing crashes by returning a null SessionWrapper&
+This was introduced in r252185 or r248640.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::isolatedSession):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-06 Alex Christensen
+
+NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions
+https://bugs.webkit.org/show_bug.cgi?id=205824
+
+
+Reviewed by Chris Dumez.
+
+Classic iterator use after mutating iterated container was causing crashes by returning a null SessionWrapper&
+This was introduced in r252185 or r248640.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::isolatedSession):
+
+2020-01-14 Alan Coon
+
Cherry-pick r254078. rdar://problem/58549073
Reformat WebPage logging
Modified: branches/safari-609-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (254587 => 254588)
--- branches/safari-609-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-01-15 19:14:39 UTC (rev 254587)
+++ branches/safari-609-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-01-15 19:14:42 UTC (rev 254588)
@@ -1194,6 +1194,21 @@
entry->lastUsed = WallTime::now();
+auto& sessionWrapper = [&] (auto storedCredentialsPolicy) -> SessionWrapper& {
+switch (storedCredentialsPolicy) {
+case WebCore::StoredCredentialsPolicy::Use:
+LOG(NetworkSession, "Using isolated NSURLSession with credential storage.");
+return entry->sessionWithCredentialStorage;
+case WebCore::StoredCredentialsPolicy::DoNotUse:
+LOG(NetworkSession, "Using isolated NSURLSession without credential storage.");
+return entry->sessionWithoutCredentialStorage;
+case WebCore::StoredCredentialsPolicy::EphemeralStateless:
+if (!m_ephemeralStatelessSession.session)
+initializeEphemeralStatelessSession();
+return m_ephemeralStatelessSession;
+}
+} (storedCredentialsPolicy);
+
if (m_isolatedSessions.size() > maxNumberOfIsolatedSessions) {
WebCore::RegistrableDomain keyToRemove;
auto oldestTimestamp = WallTime::now();
@@ -1210,18 +1225,7 @@
RELEASE_ASSERT(m_isolatedSessions.size() <= maxNumberOfIsolatedSessions);
-switch (storedCredentialsPolicy) {
-case WebCore::StoredCredentialsPolicy::Use:
-LOG(NetworkSession, "Using isolated NSURLSession with credential storage.");
-return entry->sessionWithCredentialStorage;
-case WebCore::StoredCredentialsPolicy::DoNotUse:
-LOG(NetworkSession, "Using isolated NSURLSession without credential storage.");
-return entry->sessionWithoutCredentialStorage;
-case WebCore::StoredCredentialsPolicy::EphemeralStateless:
-if (!m_ephemeralStatelessSession.session)
-initializeEphemeralStatelessSession();
-return m_ephemeralStatelessSession;
-}
+return sessionWrapper;
}
bool NetworkSessionCocoa::hasIsolatedSession(const WebCore::RegistrableDomain domain) const
[webkit-changes] [254589] branches/safari-609-branch/Source/WebCore
Title: [254589] branches/safari-609-branch/Source/WebCore
Revision 254589
Author alanc...@apple.com
Date 2020-01-15 11:14:45 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254099. rdar://problem/58552889
[iOS] Only prewarm fonts with valid font names
https://bugs.webkit.org/show_bug.cgi?id=205822
Reviewed by Brent Fulgham.
The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.
No new tests, no behavior change.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::prewarmGlobally):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254588 => 254589)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:14:42 UTC (rev 254588)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:14:45 UTC (rev 254589)
@@ -1,5 +1,38 @@
2020-01-14 Alan Coon
+Cherry-pick r254099. rdar://problem/58552889
+
+[iOS] Only prewarm fonts with valid font names
+https://bugs.webkit.org/show_bug.cgi?id=205822
+
+Reviewed by Brent Fulgham.
+
+The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.
+
+No new tests, no behavior change.
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::FontCache::prewarmGlobally):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-06 Per Arne Vollan
+
+[iOS] Only prewarm fonts with valid font names
+https://bugs.webkit.org/show_bug.cgi?id=205822
+
+Reviewed by Brent Fulgham.
+
+The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.
+
+No new tests, no behavior change.
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::FontCache::prewarmGlobally):
+
+2020-01-14 Alan Coon
+
Cherry-pick r254067. rdar://problem/58552878
REGRESSION(r247626): Introduced memory regression
Modified: branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (254588 => 254589)
--- branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2020-01-15 19:14:42 UTC (rev 254588)
+++ branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2020-01-15 19:14:45 UTC (rev 254589)
@@ -1694,8 +1694,10 @@
return;
Vector families = std::initializer_list {
+#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
".SF NS Text"_s,
".SF NS Display"_s,
+#endif
"Arial"_s,
"Helvetica"_s,
"Helvetica Neue"_s,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254583] branches/safari-609-branch/LayoutTests
Title: [254583] branches/safari-609-branch/LayoutTests Revision 254583 Author alanc...@apple.com Date 2020-01-15 11:14:29 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254059. rdar://problem/58552861 REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=205807 Unreviewed test gardening. * platform/mac/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254059 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254582 => 254583) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:26 UTC (rev 254582) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:29 UTC (rev 254583) @@ -1,5 +1,27 @@ 2020-01-14 Alan Coon +Cherry-pick r254059. rdar://problem/58552861 + +REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=205807 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254059 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-06 Truitt Savell + +REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=205807 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2020-01-14 Alan Coon + Cherry-pick r254054. rdar://problem/58549108 REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019' Modified: branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations (254582 => 254583) --- branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations 2020-01-15 19:14:26 UTC (rev 254582) +++ branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations 2020-01-15 19:14:29 UTC (rev 254583) @@ -1965,4 +1965,6 @@ webkit.org/b/202064 webaudio/silent-audio-interrupted-in-background.html [ Pass Crash ] -webkit.org/b/205757 webgl/1.0.3/conformance/textures/texture-upload-size.html [ Pass Timeout ] \ No newline at end of file +webkit.org/b/205757 webgl/1.0.3/conformance/textures/texture-upload-size.html [ Pass Timeout ] + +webkit.org/b/205807 [ Debug ] inspector/page/setBootstrapScript-main-frame.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254582] branches/safari-609-branch
Title: [254582] branches/safari-609-branch Revision 254582 Author alanc...@apple.com Date 2020-01-15 11:14:26 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254054. rdar://problem/58549108 REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019' https://bugs.webkit.org/show_bug.cgi?id=205694 Reviewed by Zalan Bujtas. Source/WebCore: After r252724, which separated 'used' from 'specified' z-index in style, we need to copy the specified to the used z-index in animated styles, while preserving the existing 'forceStackingContext' behavior which set the used z-index to 0. Do so by creating Adjuster::adjustAnimatedStyle(), which is called from TreeResolver::createAnimatedElementUpdate() if any animations could have affected the style. We need to pass back information about whether the animation should force stacking context. Test: animations/z-index-in-keyframe.html * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::apply): * animation/KeyframeEffect.h: (WebCore::KeyframeEffect::triggersStackingContext const): * dom/Element.cpp: (WebCore::Element::applyKeyframeEffects): * dom/Element.h: * page/animation/CSSAnimationController.h: (): Deleted. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::animate): * style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjustAnimatedStyle): * style/StyleAdjuster.h: * style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): LayoutTests: * animations/z-index-in-keyframe-expected.html: Added. * animations/z-index-in-keyframe.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254054 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/animation/KeyframeEffect.cpp branches/safari-609-branch/Source/WebCore/animation/KeyframeEffect.h branches/safari-609-branch/Source/WebCore/dom/Element.cpp branches/safari-609-branch/Source/WebCore/dom/Element.h branches/safari-609-branch/Source/WebCore/page/animation/AnimationBase.h branches/safari-609-branch/Source/WebCore/page/animation/CSSAnimationController.h branches/safari-609-branch/Source/WebCore/page/animation/CompositeAnimation.cpp branches/safari-609-branch/Source/WebCore/style/StyleAdjuster.cpp branches/safari-609-branch/Source/WebCore/style/StyleAdjuster.h branches/safari-609-branch/Source/WebCore/style/StyleTreeResolver.cpp Added Paths branches/safari-609-branch/LayoutTests/animations/z-index-in-keyframe-expected.html branches/safari-609-branch/LayoutTests/animations/z-index-in-keyframe.html Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254581 => 254582) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:21 UTC (rev 254581) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:26 UTC (rev 254582) @@ -1,3 +1,60 @@ +2020-01-14 Alan Coon + +Cherry-pick r254054. rdar://problem/58549108 + +REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019' +https://bugs.webkit.org/show_bug.cgi?id=205694 + + +Reviewed by Zalan Bujtas. + +Source/WebCore: + +After r252724, which separated 'used' from 'specified' z-index in style, we need to copy +the specified to the used z-index in animated styles, while preserving the existing 'forceStackingContext' +behavior which set the used z-index to 0. + +Do so by creating Adjuster::adjustAnimatedStyle(), which is called from TreeResolver::createAnimatedElementUpdate() +if any animations could have affected the style. We need to pass back information about whether the animation should +force stacking context. + +Test: animations/z-index-in-keyframe.html + +* animation/KeyframeEffect.cpp: +(WebCore::KeyframeEffect::apply): +* animation/KeyframeEffect.h: +(WebCore::KeyframeEffect::triggersStackingContext const): +* dom/Element.cpp: +(WebCore::Element::applyKeyframeEffects): +* dom/Element.h: +* page/animation/CSSAnimationController.h: +(): Deleted. +* page/animation/CompositeAnimation.cpp: +(WebCore::CompositeAnimation::animate): +* style/StyleAdjuster.cpp: +(WebCore::Style::Adjuster::adjustAnimatedStyle): +* style/StyleAdjuster.h: +* style/StyleTreeResolver.cpp: +(WebCore::Style::TreeResolver::createAnimatedElementUpdate): + +LayoutTests: + +* animations/z-index-in-keyframe-expected.html: Added. +* animations/z-index-in-keyframe.html: Added. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254054 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-05 Simon Fraser + +REGRESSION (r252724):
[webkit-changes] [254607] branches/safari-609-branch/Source/WebKit
Title: [254607] branches/safari-609-branch/Source/WebKit Revision 254607 Author alanc...@apple.com Date 2020-01-15 11:15:34 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254287. rdar://problem/58552886 Fullscreen videos do not enter PiP in first tap https://bugs.webkit.org/show_bug.cgi?id=205986 Reviewed by Eric Carlson. This patch essentially reverts the fix for webkit.org/b/204461. The fix for webkit.org/b/204461 depends on a fix in AVKit along with a corresponding update in WebKit (webkit.org/b/204979). We will need to reapply the fix for webkit.org/b/204461 after they are landed. * WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): (WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254287 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Diff Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254606 => 254607) --- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:32 UTC (rev 254606) +++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:34 UTC (rev 254607) @@ -1,5 +1,42 @@ 2020-01-14 Alan Coon +Cherry-pick r254287. rdar://problem/58552886 + +Fullscreen videos do not enter PiP in first tap +https://bugs.webkit.org/show_bug.cgi?id=205986 + +Reviewed by Eric Carlson. + +This patch essentially reverts the fix for webkit.org/b/204461. +The fix for webkit.org/b/204461 depends on a fix in AVKit along +with a corresponding update in WebKit (webkit.org/b/204979). +We will need to reapply the fix for webkit.org/b/204461 after they are landed. + +* WebProcess/cocoa/VideoFullscreenManager.mm: +(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): +(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254287 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-09 Peng Liu + +Fullscreen videos do not enter PiP in first tap +https://bugs.webkit.org/show_bug.cgi?id=205986 + +Reviewed by Eric Carlson. + +This patch essentially reverts the fix for webkit.org/b/204461. +The fix for webkit.org/b/204461 depends on a fix in AVKit along +with a corresponding update in WebKit (webkit.org/b/204979). +We will need to reapply the fix for webkit.org/b/204461 after they are landed. + +* WebProcess/cocoa/VideoFullscreenManager.mm: +(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): +(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement): + +2020-01-14 Alan Coon + Cherry-pick r254254. rdar://problem/58548978 WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared Modified: branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm (254606 => 254607) --- branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm 2020-01-15 19:15:32 UTC (rev 254606) +++ branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm 2020-01-15 19:15:34 UTC (rev 254607) @@ -249,8 +249,6 @@ auto [model, interface] = ensureModelAndInterface(contextId); HTMLMediaElementEnums::VideoFullscreenMode oldMode = interface->fullscreenMode(); -if (oldMode == mode) -return; addClientForContext(contextId); if (!interface->layerHostingContext()) @@ -299,14 +297,10 @@ uint64_t contextId = m_videoElements.get(); auto& interface = ensureInterface(contextId); -HTMLMediaElementEnums::VideoFullscreenMode oldMode = interface.fullscreenMode(); -if (oldMode == HTMLMediaElementEnums::VideoFullscreenModeNone) -return; - interface.setTargetIsFullscreen(false); - if (interface.animationState() != VideoFullscreenInterfaceContext::AnimationType::None) return; + interface.setAnimationState(VideoFullscreenInterfaceContext::AnimationType::FromFullscreen); m_page->send(Messages::VideoFullscreenManagerProxy::ExitFullscreen(contextId, inlineVideoFrame(videoElement))); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254595] branches/safari-609-branch/LayoutTests
Title: [254595] branches/safari-609-branch/LayoutTests Revision 254595 Author alanc...@apple.com Date 2020-01-15 11:15:00 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254157. rdar://problem/58549081 REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=205886 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254157 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254594 => 254595) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:14:58 UTC (rev 254594) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:00 UTC (rev 254595) @@ -1,5 +1,27 @@ 2020-01-14 Alan Coon +Cherry-pick r254157. rdar://problem/58549081 + +REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=205886 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254157 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-07 Truitt Savell + +REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=205886 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +2020-01-14 Alan Coon + Cherry-pick r254145. rdar://problem/58552861 REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure Modified: branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations (254594 => 254595) --- branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-01-15 19:14:58 UTC (rev 254594) +++ branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-01-15 19:15:00 UTC (rev 254595) @@ -927,3 +927,5 @@ webkit.org/b/205301 [ Mojave+ ] inspector/canvas/requestShaderSource-webgpu.html [ Pass Failure ] webkit.org/b/171784 fast/shadow-dom/link-element-in-shadow-tree.html [ Pass Failure ] + +webkit.org/b/205886 http/wpt/service-workers/persistent-importScripts.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254600] branches/safari-609-branch/Source/JavaScriptCore
Title: [254600] branches/safari-609-branch/Source/_javascript_Core
Revision 254600
Author alanc...@apple.com
Date 2020-01-15 11:15:15 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254218. rdar://problem/58553153
JSArrayBufferView.h: Multiplication result converted to larger type
https://bugs.webkit.org/show_bug.cgi?id=205943
Reviewed by Saam Barati.
Added cast to size_t to make the whole calculation size_t.
* runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::sizeOf):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h
Diff
Modified: branches/safari-609-branch/Source/_javascript_Core/ChangeLog (254599 => 254600)
--- branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-01-15 19:15:13 UTC (rev 254599)
+++ branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-01-15 19:15:15 UTC (rev 254600)
@@ -1,5 +1,34 @@
2020-01-14 Alan Coon
+Cherry-pick r254218. rdar://problem/58553153
+
+JSArrayBufferView.h: Multiplication result converted to larger type
+https://bugs.webkit.org/show_bug.cgi?id=205943
+
+Reviewed by Saam Barati.
+
+Added cast to size_t to make the whole calculation size_t.
+
+* runtime/JSArrayBufferView.h:
+(JSC::JSArrayBufferView::sizeOf):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-08 Michael Saboff
+
+JSArrayBufferView.h: Multiplication result converted to larger type
+https://bugs.webkit.org/show_bug.cgi?id=205943
+
+Reviewed by Saam Barati.
+
+Added cast to size_t to make the whole calculation size_t.
+
+* runtime/JSArrayBufferView.h:
+(JSC::JSArrayBufferView::sizeOf):
+
+2020-01-14 Alan Coon
+
Cherry-pick r254188. rdar://problem/58553146
AI rule for ValueMod/ValueDiv produce constants with the wrong format when the result can be an int32
Modified: branches/safari-609-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h (254599 => 254600)
--- branches/safari-609-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h 2020-01-15 19:15:13 UTC (rev 254599)
+++ branches/safari-609-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h 2020-01-15 19:15:15 UTC (rev 254600)
@@ -108,7 +108,7 @@
static size_t sizeOf(uint32_t length, uint32_t elementSize)
{
-return (length * elementSize + sizeof(EncodedJSValue) - 1)
+return (static_cast(length) * elementSize + sizeof(EncodedJSValue) - 1)
& ~(sizeof(EncodedJSValue) - 1);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254602] branches/safari-609-branch/Source/JavaScriptCore
Title: [254602] branches/safari-609-branch/Source/_javascript_Core
Revision 254602
Author alanc...@apple.com
Date 2020-01-15 11:15:22 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254244. rdar://problem/58553148
Instruction.h: Multiplication result converted to larger type
https://bugs.webkit.org/show_bug.cgi?id=205945
Reviewed by Mark Lam.
* bytecode/Instruction.h:
(JSC::BaseInstruction::size const):
Changed the types to size_t so that the computation is computed accordingly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/bytecode/Instruction.h
Diff
Modified: branches/safari-609-branch/Source/_javascript_Core/ChangeLog (254601 => 254602)
--- branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-01-15 19:15:19 UTC (rev 254601)
+++ branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-01-15 19:15:22 UTC (rev 254602)
@@ -1,5 +1,33 @@
2020-01-14 Alan Coon
+Cherry-pick r254244. rdar://problem/58553148
+
+Instruction.h: Multiplication result converted to larger type
+https://bugs.webkit.org/show_bug.cgi?id=205945
+
+Reviewed by Mark Lam.
+
+* bytecode/Instruction.h:
+(JSC::BaseInstruction::size const):
+Changed the types to size_t so that the computation is computed accordingly.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-08 Michael Saboff
+
+Instruction.h: Multiplication result converted to larger type
+https://bugs.webkit.org/show_bug.cgi?id=205945
+
+Reviewed by Mark Lam.
+
+* bytecode/Instruction.h:
+(JSC::BaseInstruction::size const):
+Changed the types to size_t so that the computation is computed accordingly.
+
+
+2020-01-14 Alan Coon
+
Cherry-pick r254218. rdar://problem/58553153
JSArrayBufferView.h: Multiplication result converted to larger type
Modified: branches/safari-609-branch/Source/_javascript_Core/bytecode/Instruction.h (254601 => 254602)
--- branches/safari-609-branch/Source/_javascript_Core/bytecode/Instruction.h 2020-01-15 19:15:19 UTC (rev 254601)
+++ branches/safari-609-branch/Source/_javascript_Core/bytecode/Instruction.h 2020-01-15 19:15:22 UTC (rev 254602)
@@ -118,8 +118,8 @@
size_t size() const
{
auto sizeShiftAmount = this->sizeShiftAmount();
-auto prefixSize = sizeShiftAmount ? 1 : 0;
-auto operandSize = 1 << sizeShiftAmount;
+size_t prefixSize = sizeShiftAmount ? 1 : 0;
+size_t operandSize = static_cast(1) << sizeShiftAmount;
size_t sizeOfBytecode = 1;
return sizeOfBytecode + (Traits::opcodeLengths[opcodeID()] - 1) * operandSize + prefixSize;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254621] branches/safari-609-branch/LayoutTests
Title: [254621] branches/safari-609-branch/LayoutTests Revision 254621 Author alanc...@apple.com Date 2020-01-15 11:16:27 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254415. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale https://bugs.webkit.org/show_bug.cgi?id=200043 Make iOS bots green until they can be updated. Unreviewed. * platform/ios/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254415 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254620 => 254621) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:16:25 UTC (rev 254620) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:16:27 UTC (rev 254621) @@ -1,5 +1,31 @@ 2020-01-15 Alan Coon +Cherry-pick r254415. rdar://problem/58548648 + +REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale +https://bugs.webkit.org/show_bug.cgi?id=200043 + +Make iOS bots green until they can be updated. + +Unreviewed. + +* platform/ios/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254415 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-12 Myles C. Maxfield + +REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale +https://bugs.webkit.org/show_bug.cgi?id=200043 + +Make iOS bots green until they can be updated. + +Unreviewed. + +* platform/ios/TestExpectations: + +2020-01-15 Alan Coon + Cherry-pick r254412. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale Modified: branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations (254620 => 254621) --- branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations 2020-01-15 19:16:25 UTC (rev 254620) +++ branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations 2020-01-15 19:16:27 UTC (rev 254621) @@ -3458,4 +3458,6 @@ webkit.org/b/204757 imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html [ Pass Failure ] -webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageonlyFailure ] \ No newline at end of file +webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageOnlyFailure ] + +webkit.org/b/200043 fast/text/international/system-language/navigator-language [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254593] branches/safari-609-branch/Source/JavaScriptCore
Title: [254593] branches/safari-609-branch/Source/_javascript_Core
Revision 254593
Author alanc...@apple.com
Date 2020-01-15 11:14:55 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254152. rdar://problem/58552854
[JSC] Remove vm accessor in JSVirtualMachine to reduce binary size
https://bugs.webkit.org/show_bug.cgi?id=205880
Reviewed by Mark Lam.
Objective-C has reflection mechanism. This means that fields, methods, and their types
need to hold its string representations in binary even if we are using release build.
While typical Objective-C class does not have large size of type names, C++ struct / class
has very large one, and putting them in Objective-C method names, parameter types, or fields
makes binary size very large.
By analyzing _javascript_Core binary, I found that Objective-C method type symbols are taking 200~KB
binary size. (Section __objc_methtype: 235081 (addr 0x105e9a3 offset 17164707)). And it is due to
JSC::VM type included in `[JSVirtualMachine vm]` accessor.
This patch removes this accessor and gets 200KB binary size reduction.
* API/JSScript.mm:
(-[JSScript readCache]):
(-[JSScript sourceCode]):
(-[JSScript jsSourceCode]):
(-[JSScript writeCache:]):
* API/JSVirtualMachine.mm:
(-[JSVirtualMachine JSContextGroupRef]):
(-[JSVirtualMachine isWebThreadAware]):
(-[JSVirtualMachine vm]): Deleted.
* API/JSVirtualMachineInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/_javascript_Core/API/JSScript.mm
branches/safari-609-branch/Source/_javascript_Core/API/JSVirtualMachine.mm
branches/safari-609-branch/Source/_javascript_Core/API/JSVirtualMachineInternal.h
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
Diff
Modified: branches/safari-609-branch/Source/_javascript_Core/API/JSScript.mm (254592 => 254593)
--- branches/safari-609-branch/Source/_javascript_Core/API/JSScript.mm 2020-01-15 19:14:53 UTC (rev 254592)
+++ branches/safari-609-branch/Source/_javascript_Core/API/JSScript.mm 2020-01-15 19:14:55 UTC (rev 254593)
@@ -167,7 +167,7 @@
Ref cachedBytecode = JSC::CachedBytecode::create(WTFMove(mappedFile));
-JSC::VM& vm = [m_virtualMachine vm];
+JSC::VM& vm = *toJS([m_virtualMachine JSContextGroupRef]);
JSC::SourceCode sourceCode = [self sourceCode];
JSC::SourceCodeKey key = m_type == kJSScriptTypeProgram ? sourceCodeKeyForSerializedProgram(vm, sourceCode) : sourceCodeKeyForSerializedModule(vm, sourceCode);
if (isCachedBytecodeStillValid(vm, cachedBytecode.copyRef(), key, m_type == kJSScriptTypeProgram ? JSC::SourceCodeType::ProgramType : JSC::SourceCodeType::ModuleType))
@@ -235,7 +235,7 @@
- (JSC::SourceCode)sourceCode
{
-JSC::VM& vm = [m_virtualMachine vm];
+JSC::VM& vm = *toJS([m_virtualMachine JSContextGroupRef]);
JSC::JSLockHolder locker(vm);
TextPosition startPosition { };
@@ -248,7 +248,7 @@
- (JSC::JSSourceCode*)jsSourceCode
{
-JSC::VM& vm = [m_virtualMachine vm];
+JSC::VM& vm = *toJS([m_virtualMachine JSContextGroupRef]);
JSC::JSLockHolder locker(vm);
JSC::JSSourceCode* jsSourceCode = JSC::JSSourceCode::create(vm, [self sourceCode]);
return jsSourceCode;
@@ -277,12 +277,13 @@
JSC::BytecodeCacheError cacheError;
JSC::SourceCode sourceCode = [self sourceCode];
+JSC::VM& vm = *toJS([m_virtualMachine JSContextGroupRef]);
switch (m_type) {
case kJSScriptTypeModule:
-m_cachedBytecode = JSC::generateModuleBytecode([m_virtualMachine vm], sourceCode, fd, cacheError);
+m_cachedBytecode = JSC::generateModuleBytecode(vm, sourceCode, fd, cacheError);
break;
case kJSScriptTypeProgram:
-m_cachedBytecode = JSC::generateProgramBytecode([m_virtualMachine vm], sourceCode, fd, cacheError);
+m_cachedBytecode = JSC::generateProgramBytecode(vm, sourceCode, fd, cacheError);
break;
}
Modified: branches/safari-609-branch/Source/_javascript_Core/API/JSVirtualMachine.mm (254592 => 254593)
--- branches/safari-609-branch/Source/_javascript_Core/API/JSVirtualMachine.mm 2020-01-15 19:14:53 UTC (rev 254592)
+++ branches/safari-609-branch/Source/_javascript_Core/API/JSVirtualMachine.mm 2020-01-15 19:14:55 UTC (rev 254593)
@@ -298,14 +298,15 @@
#endif // ENABLE(DFG_JIT)
-- (JSC::VM&)vm
+- (JSContextGroupRef)JSContextGroupRef
{
-return *toJS(m_group);
+return m_group;
}
- (BOOL)isWebThreadAware
{
-return [self vm].apiLock().isWebThreadAware();
+JSC::VM* vm = toJS(m_group);
+return vm->apiLock().isWebThreadAware();
}
+ (void)setCrashOnVMCreation:(BOOL)shouldCrash
Modified: branches/safari-609-branch/Source/_javascript_Core/API/JSVirtualMachineInternal.h (254592 => 254593)
--- branches/safari-609-branch/Source/_javascript_Core/API/JSVirtualMachineInternal.h 2020-01-15
[webkit-changes] [254603] branches/safari-609-branch/JSTests
Title: [254603] branches/safari-609-branch/JSTests Revision 254603 Author alanc...@apple.com Date 2020-01-15 11:15:24 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254247. rdar://problem/58553146 Unreviewed follow up on r254188. I accidentally included the same test twice instead of including the two different variants. * stress/ai-value-mod-should-result-in-constant-int-where-possible.js: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254247 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/JSTests/ChangeLog branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js Diff Modified: branches/safari-609-branch/JSTests/ChangeLog (254602 => 254603) --- branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:15:22 UTC (rev 254602) +++ branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:15:24 UTC (rev 254603) @@ -1,5 +1,25 @@ 2020-01-14 Alan Coon +Cherry-pick r254247. rdar://problem/58553146 + +Unreviewed follow up on r254188. I accidentally included the same test +twice instead of including the two different variants. + +* stress/ai-value-mod-should-result-in-constant-int-where-possible.js: + + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254247 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-08 Saam Barati + +Unreviewed follow up on r254188. I accidentally included the same test +twice instead of including the two different variants. + +* stress/ai-value-mod-should-result-in-constant-int-where-possible.js: + +2020-01-14 Alan Coon + Cherry-pick r254188. rdar://problem/58553146 AI rule for ValueMod/ValueDiv produce constants with the wrong format when the result can be an int32 Modified: branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js (254602 => 254603) --- branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js 2020-01-15 19:15:22 UTC (rev 254602) +++ branches/safari-609-branch/JSTests/stress/ai-value-mod-should-result-in-constant-int-where-possible.js 2020-01-15 19:15:24 UTC (rev 254603) @@ -11,7 +11,7 @@ const y = typeof x === a0; [a0, 0.1]; const z = 0 + y; -const c = z / 1.0 + 0; +const c = z % 1.0 + 0; } while (!x); } bar(0); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254599] branches/safari-609-branch/Source/WebKit
Title: [254599] branches/safari-609-branch/Source/WebKit Revision 254599 Author alanc...@apple.com Date 2020-01-15 11:15:13 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254208. rdar://problem/58559193 IPC::Connection::sendMessage() should use CRASH_WITH_INFO() Reviewed by Mark Lam. * Platform/IPC/cocoa/ConnectionCocoa.mm: (IPC::Connection::sendMessage): - Switch from CRASH() to CRASH_WITH_INFO(). git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254208 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm Diff Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254598 => 254599) --- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:10 UTC (rev 254598) +++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:13 UTC (rev 254599) @@ -1,5 +1,34 @@ 2020-01-14 Alan Coon +Cherry-pick r254208. rdar://problem/58559193 + +IPC::Connection::sendMessage() should use CRASH_WITH_INFO() + + + +Reviewed by Mark Lam. + +* Platform/IPC/cocoa/ConnectionCocoa.mm: +(IPC::Connection::sendMessage): +- Switch from CRASH() to CRASH_WITH_INFO(). + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254208 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-08 David Kilzer + +IPC::Connection::sendMessage() should use CRASH_WITH_INFO() + + + +Reviewed by Mark Lam. + +* Platform/IPC/cocoa/ConnectionCocoa.mm: +(IPC::Connection::sendMessage): +- Switch from CRASH() to CRASH_WITH_INFO(). + +2020-01-14 Alan Coon + Cherry-pick r254147. rdar://problem/58549096 Reformat WebFrameLoaderClient logging Modified: branches/safari-609-branch/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm (254598 => 254599) --- branches/safari-609-branch/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm 2020-01-15 19:15:10 UTC (rev 254598) +++ branches/safari-609-branch/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm 2020-01-15 19:15:13 UTC (rev 254599) @@ -39,6 +39,7 @@ #import #import #import +#import #if PLATFORM(IOS_FAMILY) #import "ProcessAssertion.h" @@ -272,8 +273,9 @@ return false; default: -WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s::%s'", kr, message->messageReceiverName().data(), message->messageName().data()]); -CRASH(); +CString messageName = makeString(message->messageReceiverName().data(), "::", message->messageName().data()).utf8(); +WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s', hash %d", kr, messageName.data(), messageName.hash()]); +CRASH_WITH_INFO(kr, messageName.hash()); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254619] branches/safari-609-branch
Title: [254619] branches/safari-609-branch Revision 254619 Author alanc...@apple.com Date 2020-01-15 11:16:22 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254412. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale https://bugs.webkit.org/show_bug.cgi?id=200043 Unreviewed. Addressing additional review comments. Source/WTF: * wtf/cocoa/LanguageCocoa.mm: (WTF::canMinimizeLanguages): LayoutTests: * fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: * fast/text/international/system-language/navigator-language/navigator-language-en-US.html: * fast/text/international/system-language/navigator-language/navigator-language-en.html: * fast/text/international/system-language/navigator-language/navigator-language-es-419.html: * fast/text/international/system-language/navigator-language/navigator-language-es-ES.html: * fast/text/international/system-language/navigator-language/navigator-language-es-MX.html: * fast/text/international/system-language/navigator-language/navigator-language-es.html: * fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html: * fast/text/international/system-language/navigator-language/navigator-language-fr.html: * fast/text/international/system-language/navigator-language/navigator-language-hi.html: * fast/text/international/system-language/navigator-language/navigator-language-ja.html: * fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html: * fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html: * fast/text/international/system-language/navigator-language/navigator-language-ru.html: * fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html: * fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html: * fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html: * fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html: * fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254412 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-en-GB.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-en-US.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-en.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-es-419.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-es-ES.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-es-MX.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-es.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-fr.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-hi.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-ja.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-ru.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html branches/safari-609-branch/LayoutTests/fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html branches/safari-609-branch/Source/WTF/ChangeLog
[webkit-changes] [254615] branches/safari-609-branch
Title: [254615] branches/safari-609-branch Revision 254615 Author alanc...@apple.com Date 2020-01-15 11:16:08 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254389. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale https://bugs.webkit.org/show_bug.cgi?id=200043 Source/WTF: Reviewed by Dean Jackson. We ask the system for the current locale using CFLocaleCopyPreferredLanguages(), and then round-trip it through CFBundleGetLocalizationInfoForLocalization() / CFBundleCopyLocalizationForLocalizationInfo(). This was to work around the fact that CFLocaleCopyPreferredLanguages() previously didn't report BCP47 language codes. However, that round-tripping was introducing errors, such as "zh-Hant-HK" was getting turned into "zh-Hant-TW" which is clearly wrong. The CFBundle functions were never supposed to be used in this way. Instead, we can use CFLocaleCreateCanonicalLanguageIdentifierFromString() which is intended to canonicalize locale identifiers, and does return BCP47 language codes. However, this function preserves more fingerprinting entropy than the old code path, so we pass the input through new NSLocale SPI to minimize the entropy revealed. * WTF.xcodeproj/project.pbxproj: * wtf/Language.h: * wtf/Platform.h: * wtf/PlatformMac.cmake: * wtf/cf/LanguageCF.cpp: (WTF::httpStyleLanguageCode): (WTF::platformUserPreferredLanguages): * wtf/cocoa/LanguageCocoa.mm: Added. (WTF::minimizedLanguagesFromLanguages): * wtf/spi/cocoa/NSLocaleSPI.h: Added. Tools: Reviewed by Dean Jackson. Migrate system language tests to LayoutTests, to match the rest of our system language tests. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Removed. LayoutTests: Reviewed by Dean Jackson. Migrate and update tests from TestWebKitAPI to LayoutTests, to match the rest of our system language tests. * platform/mac/TestExpectations: Mark these tests as possibly failing on older versions of macOS. * fast/text/international/system-language/navigator-language/navigator-language-en-GB-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-en-US.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-en.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-es-419-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-es-419.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-es-ES.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-es-MX.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-es.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-fr-CA-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-fr.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-hi.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-ja-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-ja.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html: Added. * fast/text/international/system-language/navigator-language/navigator-language-pt-PT-expected.txt: Added. * fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html: Added. *
[webkit-changes] [254617] branches/safari-609-branch
Title: [254617] branches/safari-609-branch
Revision 254617
Author alanc...@apple.com
Date 2020-01-15 11:16:14 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254393. rdar://problem/58553158
[JSC] Flush old tables in End phase
https://bugs.webkit.org/show_bug.cgi?id=206120
Reviewed by Mark Lam.
JSTests:
* stress/create-many-realms.js: Added.
(foo):
Source/_javascript_Core:
stopThePeriphery is stopping compiler threads and main thread (mutator), which means making m_worldIsStopped = true.
It is not for stopping all heap threads including a concurrent marker. The concurrent collector can work while executing
stopThePeriphery. This means that concurrent collectors can access to the old StructureIDTable while it is destroyed
in stopThePeriphery. Destroying old StructureIDTable in GC End phase, this is appropriate phase that we can ensure no
other threads (accessing to heap) are working including concurrent markers, mutator, and compiler threads.
* heap/Heap.cpp:
(JSC::Heap::runEndPhase):
(JSC::Heap::stopThePeriphery):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/JSTests/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/heap/Heap.cpp
Added Paths
branches/safari-609-branch/JSTests/stress/create-many-realms.js
Diff
Modified: branches/safari-609-branch/JSTests/ChangeLog (254616 => 254617)
--- branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:16:11 UTC (rev 254616)
+++ branches/safari-609-branch/JSTests/ChangeLog 2020-01-15 19:16:14 UTC (rev 254617)
@@ -1,3 +1,43 @@
+2020-01-15 Alan Coon
+
+Cherry-pick r254393. rdar://problem/58553158
+
+[JSC] Flush old tables in End phase
+https://bugs.webkit.org/show_bug.cgi?id=206120
+
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* stress/create-many-realms.js: Added.
+(foo):
+
+Source/_javascript_Core:
+
+stopThePeriphery is stopping compiler threads and main thread (mutator), which means making m_worldIsStopped = true.
+It is not for stopping all heap threads including a concurrent marker. The concurrent collector can work while executing
+stopThePeriphery. This means that concurrent collectors can access to the old StructureIDTable while it is destroyed
+in stopThePeriphery. Destroying old StructureIDTable in GC End phase, this is appropriate phase that we can ensure no
+other threads (accessing to heap) are working including concurrent markers, mutator, and compiler threads.
+
+* heap/Heap.cpp:
+(JSC::Heap::runEndPhase):
+(JSC::Heap::stopThePeriphery):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-10 Yusuke Suzuki
+
+[JSC] Flush old tables in End phase
+https://bugs.webkit.org/show_bug.cgi?id=206120
+
+
+Reviewed by Mark Lam.
+
+* stress/create-many-realms.js: Added.
+(foo):
+
2020-01-14 Alan Coon
Cherry-pick r254247. rdar://problem/58553146
Added: branches/safari-609-branch/JSTests/stress/create-many-realms.js (0 => 254617)
--- branches/safari-609-branch/JSTests/stress/create-many-realms.js (rev 0)
+++ branches/safari-609-branch/JSTests/stress/create-many-realms.js 2020-01-15 19:16:14 UTC (rev 254617)
@@ -0,0 +1,9 @@
+ //@ runDefault("--collectContinuously=1", "--collectContinuouslyPeriodMS=20", "--useGenerationalGC=0", "--useStochasticMutatorScheduler=0", "--useDFGJIT=0", "--useFTLJIT=0", "--maxPerThreadStackUsage=100")
+
+function foo(count) {
+const x = createGlobalObject();
+if (count === 100)
+return;
+return foo(count + 1);
+}
+foo(0);
Modified: branches/safari-609-branch/Source/_javascript_Core/ChangeLog (254616 => 254617)
--- branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-01-15 19:16:11 UTC (rev 254616)
+++ branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-01-15 19:16:14 UTC (rev 254617)
@@ -1,3 +1,50 @@
+2020-01-15 Alan Coon
+
+Cherry-pick r254393. rdar://problem/58553158
+
+[JSC] Flush old tables in End phase
+https://bugs.webkit.org/show_bug.cgi?id=206120
+
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* stress/create-many-realms.js: Added.
+(foo):
+
+Source/_javascript_Core:
+
+stopThePeriphery is stopping compiler threads and main thread (mutator), which means making m_worldIsStopped = true.
+It is not for stopping all heap threads including a concurrent marker. The concurrent collector can work while executing
+stopThePeriphery. This means that concurrent collectors can access to the old StructureIDTable while it is destroyed
+in stopThePeriphery. Destroying old
[webkit-changes] [254616] branches/safari-609-branch/LayoutTests
Title: [254616] branches/safari-609-branch/LayoutTests Revision 254616 Author alanc...@apple.com Date 2020-01-15 11:16:11 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254391. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale https://bugs.webkit.org/show_bug.cgi?id=200043 Temporarily mark the navigator-language tests as flakey until I can figure out what to do with them. Unreviewed. * platform/mac/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254391 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254615 => 254616) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:16:08 UTC (rev 254615) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:16:11 UTC (rev 254616) @@ -1,5 +1,31 @@ 2020-01-15 Alan Coon +Cherry-pick r254391. rdar://problem/58548648 + +REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale +https://bugs.webkit.org/show_bug.cgi?id=200043 + +Temporarily mark the navigator-language tests as flakey until I can figure out what to do with them. + +Unreviewed. + +* platform/mac/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254391 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-10 Myles C. Maxfield + +REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale +https://bugs.webkit.org/show_bug.cgi?id=200043 + +Temporarily mark the navigator-language tests as flakey until I can figure out what to do with them. + +Unreviewed. + +* platform/mac/TestExpectations: + +2020-01-15 Alan Coon + Cherry-pick r254389. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale Modified: branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations (254615 => 254616) --- branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations 2020-01-15 19:16:08 UTC (rev 254615) +++ branches/safari-609-branch/LayoutTests/platform/mac/TestExpectations 2020-01-15 19:16:11 UTC (rev 254616) @@ -1968,4 +1968,4 @@ webkit.org/b/205757 webgl/1.0.3/conformance/textures/texture-upload-size.html [ Pass Timeout ] # The navigator.language tests rely on functionality only available in recent releases of macOS Catalina and onward. -webkit.org/b/200043 [ Sierra HighSierra Mojave ] fast/text/international/system-language/navigator-language [ Pass Failure ] +webkit.org/b/200043 [ Sierra HighSierra Mojave Catalina ] fast/text/international/system-language/navigator-language [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254613] branches/safari-609-branch
Title: [254613] branches/safari-609-branch Revision 254613 Author alanc...@apple.com Date 2020-01-15 11:15:55 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254344. rdar://problem/58559189 Add SPI to enable TLS 1.0 and 1.1 in WKWebViews https://bugs.webkit.org/show_bug.cgi?id=206046 Patch by Alex Christensen on 2020-01-10 Reviewed by Youenn Fablet. Source/WebKit: This is needed for Covered by API tests. * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: (-[_WKWebsiteDataStoreConfiguration legacyTLSEnabled]): (-[_WKWebsiteDataStoreConfiguration setLegacyTLSEnabled:]): * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::copy const): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: (WebKit::WebsiteDataStoreConfiguration::legacyTLSEnabled const): (WebKit::WebsiteDataStoreConfiguration::setLegacyTLSEnabled): Tools: * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254344 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h branches/safari-609-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm branches/safari-609-branch/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm branches/safari-609-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp branches/safari-609-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h branches/safari-609-branch/Tools/ChangeLog branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm Diff Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254612 => 254613) --- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:51 UTC (rev 254612) +++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:55 UTC (rev 254613) @@ -1,5 +1,61 @@ 2020-01-14 Alan Coon +Cherry-pick r254344. rdar://problem/58559189 + +Add SPI to enable TLS 1.0 and 1.1 in WKWebViews +https://bugs.webkit.org/show_bug.cgi?id=206046 + +Patch by Alex Christensen on 2020-01-10 +Reviewed by Youenn Fablet. + +Source/WebKit: + +This is needed for +Covered by API tests. + +* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: +* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: +(-[_WKWebsiteDataStoreConfiguration legacyTLSEnabled]): +(-[_WKWebsiteDataStoreConfiguration setLegacyTLSEnabled:]): +* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: +(WebKit::WebsiteDataStore::parameters): +* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: +(WebKit::WebsiteDataStoreConfiguration::copy const): +* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: +(WebKit::WebsiteDataStoreConfiguration::legacyTLSEnabled const): +(WebKit::WebsiteDataStoreConfiguration::setLegacyTLSEnabled): + +Tools: + +* TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: +(TestWebKitAPI::TEST): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254344 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-10 Alex Christensen + +Add SPI to enable TLS 1.0 and 1.1 in WKWebViews +https://bugs.webkit.org/show_bug.cgi?id=206046 + +Reviewed by Youenn Fablet. + +This is needed for +Covered by API tests. + +* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: +* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: +(-[_WKWebsiteDataStoreConfiguration legacyTLSEnabled]): +(-[_WKWebsiteDataStoreConfiguration setLegacyTLSEnabled:]): +* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: +(WebKit::WebsiteDataStore::parameters): +* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: +(WebKit::WebsiteDataStoreConfiguration::copy const): +* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: +(WebKit::WebsiteDataStoreConfiguration::legacyTLSEnabled const): +(WebKit::WebsiteDataStoreConfiguration::setLegacyTLSEnabled): + +2020-01-14 Alan Coon + Cherry-pick r254310. rdar://problem/58552856 Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled() Modified: branches/safari-609-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h (254612 => 254613) ---
[webkit-changes] [254618] branches/safari-609-branch/Source/WTF
Title: [254618] branches/safari-609-branch/Source/WTF Revision 254618 Author alanc...@apple.com Date 2020-01-15 11:16:16 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254411. rdar://problem/58548648 Fix internal Apple builds after r254389 https://bugs.webkit.org/show_bug.cgi?id=206135 Rubber stamped by Zalan Bujtas. * wtf/spi/cocoa/NSLocaleSPI.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254411 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WTF/ChangeLog branches/safari-609-branch/Source/WTF/wtf/spi/cocoa/NSLocaleSPI.h Diff Modified: branches/safari-609-branch/Source/WTF/ChangeLog (254617 => 254618) --- branches/safari-609-branch/Source/WTF/ChangeLog 2020-01-15 19:16:14 UTC (rev 254617) +++ branches/safari-609-branch/Source/WTF/ChangeLog 2020-01-15 19:16:16 UTC (rev 254618) @@ -1,5 +1,28 @@ 2020-01-15 Alan Coon +Cherry-pick r254411. rdar://problem/58548648 + +Fix internal Apple builds after r254389 +https://bugs.webkit.org/show_bug.cgi?id=206135 + +Rubber stamped by Zalan Bujtas. + +* wtf/spi/cocoa/NSLocaleSPI.h: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254411 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-11 Myles C. Maxfield + +Fix internal Apple builds after r254389 +https://bugs.webkit.org/show_bug.cgi?id=206135 + +Rubber stamped by Zalan Bujtas. + +* wtf/spi/cocoa/NSLocaleSPI.h: + +2020-01-15 Alan Coon + Cherry-pick r254389. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale Modified: branches/safari-609-branch/Source/WTF/wtf/spi/cocoa/NSLocaleSPI.h (254617 => 254618) --- branches/safari-609-branch/Source/WTF/wtf/spi/cocoa/NSLocaleSPI.h 2020-01-15 19:16:14 UTC (rev 254617) +++ branches/safari-609-branch/Source/WTF/wtf/spi/cocoa/NSLocaleSPI.h 2020-01-15 19:16:16 UTC (rev 254618) @@ -25,14 +25,13 @@ #import -#if PLATFORM(MAC) && USE(APPLE_INTERNAL_SDK) +#if USE(APPLE_INTERNAL_SDK) #import -#else +#endif @interface NSLocale () + (nonnull NSArray *)minimizedLanguagesFromLanguages:(nonnull NSArray *)languages; @end -#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254624] branches/safari-609-branch/Source
Title: [254624] branches/safari-609-branch/Source
Revision 254624
Author alanc...@apple.com
Date 2020-01-15 11:16:47 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254551. rdar://problem/58508705
Build ANGLE as a dynamic library
https://bugs.webkit.org/show_bug.cgi?id=204708
rdar://57349384
Rolling this out for the 2nd time.
Source/ThirdParty/ANGLE:
- it caused issues with the shared dyld cache, because the
cache doesn't know to include the libary until it already
exists in the build
- probably related to the above, we saw some performance
regressions directly related to this change
* ANGLE.xcodeproj/project.pbxproj:
* Configurations/ANGLE.xcconfig:
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* include/CMakeLists.txt:
* include/GLSLANG/ShaderLang.h:
* include/GLSLANG/ShaderVars.h:
* src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
(rx::DisplayCGL::isValidNativeWindow const):
* src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:
(rx::WindowSurfaceCGL::WindowSurfaceCGL):
(rx::WindowSurfaceCGL::~WindowSurfaceCGL):
* src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:
(rx::DisplayEAGL::terminate):
(rx::DisplayEAGL::isValidNativeWindow const):
(rx::WorkerContextEAGL::~WorkerContextEAGL):
* src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm:
(rx::WindowSurfaceEAGL::WindowSurfaceEAGL):
(rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):
Source/WebCore:
* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::ANGLEWebKitBridge::angleAvailable): Deleted.
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
branches/safari-609-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig
branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig
branches/safari-609-branch/Source/ThirdParty/ANGLE/include/CMakeLists.txt
branches/safari-609-branch/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
branches/safari-609-branch/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h
branches/safari-609-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/DisplayCGL.mm
branches/safari-609-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm
branches/safari-609-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm
branches/safari-609-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/Configurations/WebCore.xcconfig
branches/safari-609-branch/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
branches/safari-609-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-609-branch/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp
branches/safari-609-branch/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h
branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm
Diff
Modified: branches/safari-609-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (254623 => 254624)
--- branches/safari-609-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-15 19:16:41 UTC (rev 254623)
+++ branches/safari-609-branch/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-15 19:16:47 UTC (rev 254624)
@@ -455,6 +455,7 @@
5CB301461DE39F1A00D2C405 /* VertexArrayGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301131DE39F1A00D2C405 /* VertexArrayGL.h */; };
5CB3014F1DE39F4700D2C405 /* DisplayCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301491DE39F4700D2C405 /* DisplayCGL.h */; };
5CB301511DE39F4700D2C405 /* PbufferSurfaceCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB3014B1DE39F4700D2C405 /* PbufferSurfaceCGL.h */; };
+ 5CB304921DE4156200D2C405 /* OpenGL.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048D1DE4144400D2C405 /* OpenGL.framework */; };
5CB304931DE4156B00D2C405 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048F1DE4145500D2C405 /* QuartzCore.framework */; };
5CB304941DE4157200D2C405 /* CoreGraphics.framework in Frameworks */ = {isa =
[webkit-changes] [254614] branches/safari-609-branch/Source/WebCore
Title: [254614] branches/safari-609-branch/Source/WebCore
Revision 254614
Author alanc...@apple.com
Date 2020-01-15 11:15:58 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254374. rdar://problem/58549092
Resource Load Statistics: Align WebCore::NetworkStorageSession's m_thirdPartyCookieBlockingMode init value with r254239
https://bugs.webkit.org/show_bug.cgi?id=206082
Unreviewed minor, follow-up fix.
* platform/network/NetworkStorageSession.h:
The init value of m_thirdPartyCookieBlockingMode was changed to
ThirdPartyCookieBlockingMode::All to align it with r254239.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/platform/network/NetworkStorageSession.h
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254613 => 254614)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:55 UTC (rev 254613)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 19:15:58 UTC (rev 254614)
@@ -1,5 +1,35 @@
2020-01-14 Alan Coon
+Cherry-pick r254374. rdar://problem/58549092
+
+Resource Load Statistics: Align WebCore::NetworkStorageSession's m_thirdPartyCookieBlockingMode init value with r254239
+https://bugs.webkit.org/show_bug.cgi?id=206082
+
+
+Unreviewed minor, follow-up fix.
+
+
+* platform/network/NetworkStorageSession.h:
+The init value of m_thirdPartyCookieBlockingMode was changed to
+ThirdPartyCookieBlockingMode::All to align it with r254239.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-10 John Wilander
+
+Resource Load Statistics: Align WebCore::NetworkStorageSession's m_thirdPartyCookieBlockingMode init value with r254239
+https://bugs.webkit.org/show_bug.cgi?id=206082
+
+
+Unreviewed minor, follow-up fix.
+
+* platform/network/NetworkStorageSession.h:
+The init value of m_thirdPartyCookieBlockingMode was changed to
+ThirdPartyCookieBlockingMode::All to align it with r254239.
+
+2020-01-14 Alan Coon
+
Cherry-pick r254322. rdar://problem/58549088
Block cross-site top-frame navigations from untrusted iframes
Modified: branches/safari-609-branch/Source/WebCore/platform/network/NetworkStorageSession.h (254613 => 254614)
--- branches/safari-609-branch/Source/WebCore/platform/network/NetworkStorageSession.h 2020-01-15 19:15:55 UTC (rev 254613)
+++ branches/safari-609-branch/Source/WebCore/platform/network/NetworkStorageSession.h 2020-01-15 19:15:58 UTC (rev 254614)
@@ -203,7 +203,7 @@
Optional m_ageCapForClientSideCookiesShort { };
HashMap m_navigatedToWithLinkDecorationByPrevalentResource;
bool m_navigationWithLinkDecorationTestMode = false;
-ThirdPartyCookieBlockingMode m_thirdPartyCookieBlockingMode { ThirdPartyCookieBlockingMode::AllOnSitesWithoutUserInteraction };
+ThirdPartyCookieBlockingMode m_thirdPartyCookieBlockingMode { ThirdPartyCookieBlockingMode::All };
#endif
#if PLATFORM(COCOA)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254620] branches/safari-609-branch/Source/WTF
Title: [254620] branches/safari-609-branch/Source/WTF
Revision 254620
Author alanc...@apple.com
Date 2020-01-15 11:16:25 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254413. rdar://problem/58548648
REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043
Unreviewed.
Fix build.
* wtf/cocoa/LanguageCocoa.mm:
(WTF::canMinimizeLanguages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WTF/ChangeLog
branches/safari-609-branch/Source/WTF/wtf/cocoa/LanguageCocoa.mm
Diff
Modified: branches/safari-609-branch/Source/WTF/ChangeLog (254619 => 254620)
--- branches/safari-609-branch/Source/WTF/ChangeLog 2020-01-15 19:16:22 UTC (rev 254619)
+++ branches/safari-609-branch/Source/WTF/ChangeLog 2020-01-15 19:16:25 UTC (rev 254620)
@@ -1,5 +1,33 @@
2020-01-15 Alan Coon
+Cherry-pick r254413. rdar://problem/58548648
+
+REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
+https://bugs.webkit.org/show_bug.cgi?id=200043
+
+Unreviewed.
+
+Fix build.
+
+* wtf/cocoa/LanguageCocoa.mm:
+(WTF::canMinimizeLanguages):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-11 Myles C. Maxfield
+
+REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
+https://bugs.webkit.org/show_bug.cgi?id=200043
+
+Unreviewed.
+
+Fix build.
+
+* wtf/cocoa/LanguageCocoa.mm:
+(WTF::canMinimizeLanguages):
+
+2020-01-15 Alan Coon
+
Cherry-pick r254412. rdar://problem/58548648
REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
Modified: branches/safari-609-branch/Source/WTF/wtf/cocoa/LanguageCocoa.mm (254619 => 254620)
--- branches/safari-609-branch/Source/WTF/wtf/cocoa/LanguageCocoa.mm 2020-01-15 19:16:22 UTC (rev 254619)
+++ branches/safari-609-branch/Source/WTF/wtf/cocoa/LanguageCocoa.mm 2020-01-15 19:16:25 UTC (rev 254620)
@@ -34,7 +34,7 @@
bool canMinimizeLanguages()
{
static bool result = [NSLocale respondsToSelector:@selector(minimizedLanguagesFromLanguages:)];
-return result.get();
+return result;
}
RetainPtr minimizedLanguagesFromLanguages(CFArrayRef languages)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254612] branches/safari-609-branch
Title: [254612] branches/safari-609-branch Revision 254612 Author alanc...@apple.com Date 2020-01-15 11:15:51 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254322. rdar://problem/58549088 Block cross-site top-frame navigations from untrusted iframes https://bugs.webkit.org/show_bug.cgi?id=206027 Reviewed by Geoffrey Garen. Source/WebCore: Block cross-site top-frame navigations from untrusted iframes, unless they have a user gesture. We already consider third-party iframes as untrusted, we now also treat first-party iframes as untrusted if they are loaded both third-party scripts & iframes. Test: http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html * dom/Document.cpp: (WebCore::Document::canNavigate): (WebCore::Document::willLoadScriptElement): (WebCore::Document::willLoadFrameElement): (WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking): * dom/Document.h: * dom/ScriptElement.cpp: (WebCore::ScriptElement::requestClassicScript): * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): LayoutTests: Add layout test coverage. * http/tests/security/block-top-level-navigations-by-third-party-iframes-expected.txt: * http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes-expected.txt: Added. * http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html: Added. * http/tests/security/resources/navigate-top-level-frame-to-failure-page-untrusted-iframe.html: Added. * http/tests/security/resources/navigate-top-to-error-page.js: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254322 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/http/tests/security/block-top-level-navigations-by-third-party-iframes-expected.txt branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/dom/Document.cpp branches/safari-609-branch/Source/WebCore/dom/Document.h branches/safari-609-branch/Source/WebCore/dom/ScriptElement.cpp branches/safari-609-branch/Source/WebCore/html/HTMLFrameElementBase.cpp Added Paths branches/safari-609-branch/LayoutTests/http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes-expected.txt branches/safari-609-branch/LayoutTests/http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html branches/safari-609-branch/LayoutTests/http/tests/security/resources/navigate-top-level-frame-to-failure-page-untrusted-iframe.html branches/safari-609-branch/LayoutTests/http/tests/security/resources/navigate-top-to-error-page.js Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254611 => 254612) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:47 UTC (rev 254611) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 19:15:51 UTC (rev 254612) @@ -1,5 +1,63 @@ 2020-01-14 Alan Coon +Cherry-pick r254322. rdar://problem/58549088 + +Block cross-site top-frame navigations from untrusted iframes +https://bugs.webkit.org/show_bug.cgi?id=206027 + + +Reviewed by Geoffrey Garen. + +Source/WebCore: + +Block cross-site top-frame navigations from untrusted iframes, unless they have a user gesture. +We already consider third-party iframes as untrusted, we now also treat first-party iframes +as untrusted if they are loaded both third-party scripts & iframes. + +Test: http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html + +* dom/Document.cpp: +(WebCore::Document::canNavigate): +(WebCore::Document::willLoadScriptElement): +(WebCore::Document::willLoadFrameElement): +(WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking): +* dom/Document.h: +* dom/ScriptElement.cpp: +(WebCore::ScriptElement::requestClassicScript): +* html/HTMLFrameElementBase.cpp: +(WebCore::HTMLFrameElementBase::openURL): + +LayoutTests: + +Add layout test coverage. + +* http/tests/security/block-top-level-navigations-by-third-party-iframes-expected.txt: +* http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes-expected.txt: Added. +* http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html: Added. +* http/tests/security/resources/navigate-top-level-frame-to-failure-page-untrusted-iframe.html: Added. +* http/tests/security/resources/navigate-top-to-error-page.js: Added. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254322 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-09 Chris Dumez + +Block cross-site top-frame navigations from untrusted iframes +
[webkit-changes] [254630] trunk/Source/WebCore
Title: [254630] trunk/Source/WebCore
Revision 254630
Author za...@apple.com
Date 2020-01-15 13:17:50 -0800 (Wed, 15 Jan 2020)
Log Message
[LFC][IFC] LineLayoutContext::nextContentForLine should take LineCandidateContent&
https://bugs.webkit.org/show_bug.cgi?id=206300
Reviewed by Antti Koivisto.
~5% progression on PerformanceTests/Layout/line-layout-simple.html.
LineLayoutContext::nextContentForLine is hot and LineCandidateContent has Vector members (too heavy).
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineCandidateContent::reset):
(WebCore::Layout::LineLayoutContext::layoutLine):
(WebCore::Layout::LineLayoutContext::nextContentForLine):
* layout/inlineformatting/LineLayoutContext.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (254629 => 254630)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 20:42:34 UTC (rev 254629)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 21:17:50 UTC (rev 254630)
@@ -1,5 +1,22 @@
2020-01-15 Zalan Bujtas
+[LFC][IFC] LineLayoutContext::nextContentForLine should take LineCandidateContent&
+https://bugs.webkit.org/show_bug.cgi?id=206300
+
+
+Reviewed by Antti Koivisto.
+
+~5% progression on PerformanceTests/Layout/line-layout-simple.html.
+LineLayoutContext::nextContentForLine is hot and LineCandidateContent has Vector members (too heavy).
+
+* layout/inlineformatting/LineLayoutContext.cpp:
+(WebCore::Layout::LineCandidateContent::reset):
+(WebCore::Layout::LineLayoutContext::layoutLine):
+(WebCore::Layout::LineLayoutContext::nextContentForLine):
+* layout/inlineformatting/LineLayoutContext.h:
+
+2020-01-15 Zalan Bujtas
+
[LFC][IFC] ContinuousContent should not need a copy of RunList
https://bugs.webkit.org/show_bug.cgi?id=206293
Modified: trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp (254629 => 254630)
--- trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp 2020-01-15 20:42:34 UTC (rev 254629)
+++ trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp 2020-01-15 21:17:50 UTC (rev 254630)
@@ -185,6 +185,8 @@
const InlineItem* trailingLineBreak() const { return m_trailingLineBreak; }
+void reset();
+
private:
void setTrailingLineBreak(const InlineItem& lineBreakItem) { m_trailingLineBreak = }
@@ -203,6 +205,13 @@
m_inlineRuns.append({ inlineItem, *logicalWidth });
}
+void LineCandidateContent::reset()
+{
+m_inlineRuns.clear();
+m_floats.clear();
+m_trailingLineBreak = nullptr;
+}
+
static InlineLayoutUnit inlineItemWidth(const FormattingContext& formattingContext, const InlineItem& inlineItem, InlineLayoutUnit contentLogicalLeft)
{
if (inlineItem.isLineBreak())
@@ -258,12 +267,13 @@
auto lineBreaker = LineBreaker { };
auto currentItemIndex = leadingInlineItemIndex;
unsigned committedInlineItemCount = 0;
+auto candidateContent = LineCandidateContent { };
while (currentItemIndex < m_inlineItems.size()) {
// 1. Collect the set of runs that we can commit to the line as one entity e.g. text_and_span_start_span_end.
// 2. Apply floats and shrink the available horizontal space e.g. intru_sive_float.
// 3. Check if the content fits the line and commit the content accordingly (full, partial or not commit at all).
// 4. Return if we are at the end of the line either by not being able to fit more content or because of an explicit line break.
-auto candidateContent = nextContentForLine(currentItemIndex, partialLeadingContentLength, line.lineBox().logicalWidth());
+nextContentForLine(candidateContent, currentItemIndex, partialLeadingContentLength, line.lineBox().logicalWidth());
if (candidateContent.hasIntrusiveFloats()) {
// Add floats first because they shrink the available horizontal space for the rest of the content.
auto result = tryAddingFloatItems(line, candidateContent.floats());
@@ -328,9 +338,10 @@
return LineContent { trailingInlineItemIndex, partialContent, WTFMove(m_floats), line.close(isLastLineWithInlineContent), line.lineBox() };
}
-LineCandidateContent LineLayoutContext::nextContentForLine(unsigned inlineItemIndex, Optional partialLeadingContentLength, InlineLayoutUnit currentLogicalRight)
+void LineLayoutContext::nextContentForLine(LineCandidateContent& candidateContent, unsigned inlineItemIndex, Optional partialLeadingContentLength, InlineLayoutUnit currentLogicalRight)
{
ASSERT(inlineItemIndex < m_inlineItems.size());
+candidateContent.reset();
// 1. Simply add any overflow content from the previous line to the candidate content. It's always a text content.
// 2. Find the next soft wrap position or
[webkit-changes] [254646] branches/safari-609-branch/Source/WebCore
Title: [254646] branches/safari-609-branch/Source/WebCore Revision 254646 Author alanc...@apple.com Date 2020-01-15 15:07:25 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254179. rdar://problem/58606203 Reformat FrameLoader logging https://bugs.webkit.org/show_bug.cgi?id=205884 Reviewed by Brent Fulgham. Update the format used by FrameLoader in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: - [] ::: So, for example: 0x4aa2df000 - FrameLoader::allAllLoaders: Clearing provisional document loader (frame = 0x4a8ad3550, main = 0 m_provisionalDocumentLoader=0x0) becomes: 0x465fb61a0 - [frame=0x465c98a20, main=0] FrameLoader::stopAllLoaders: Clearing provisional document loader (m_provisionalDocumentLoader=0x0) No new tests -- no new or changed functionality. * loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadArchive): (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithNavigationAction): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::clearProvisionalLoadForPolicyCheck): (WebCore::FrameLoader::reloadWithOverrideEncoding): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::stopForBackForwardCache): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadDifferentDocumentItem): (WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254179 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/loader/FrameLoader.cpp Diff Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254645 => 254646) --- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:23 UTC (rev 254645) +++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:25 UTC (rev 254646) @@ -1,5 +1,118 @@ 2020-01-15 Alan Coon +Cherry-pick r254179. rdar://problem/58606203 + +Reformat FrameLoader logging +https://bugs.webkit.org/show_bug.cgi?id=205884 + + +Reviewed by Brent Fulgham. + +Update the format used by FrameLoader in its RELEASE_LOG logging. Use +the format used by WebPageProxy and NetworkResourceLoader, which is +generally of the form: + + - [] ::: + +So, for example: + +0x4aa2df000 - FrameLoader::allAllLoaders: Clearing provisional document loader (frame = 0x4a8ad3550, main = 0 m_provisionalDocumentLoader=0x0) + +becomes: + +0x465fb61a0 - [frame=0x465c98a20, main=0] FrameLoader::stopAllLoaders: Clearing provisional document loader (m_provisionalDocumentLoader=0x0) + +No new tests -- no new or changed functionality. + +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::urlSelected): +(WebCore::FrameLoader::finishedParsing): +(WebCore::FrameLoader::loadURLIntoChildFrame): +(WebCore::FrameLoader::loadArchive): +(WebCore::FrameLoader::loadInSameDocument): +(WebCore::FrameLoader::prepareForLoadStart): +(WebCore::FrameLoader::setupForReplace): +(WebCore::FrameLoader::loadFrameRequest): +(WebCore::FrameLoader::loadURL): +(WebCore::FrameLoader::load): +(WebCore::FrameLoader::loadWithNavigationAction): +(WebCore::FrameLoader::loadWithDocumentLoader): +(WebCore::FrameLoader::clearProvisionalLoadForPolicyCheck): +(WebCore::FrameLoader::reloadWithOverrideEncoding): +(WebCore::FrameLoader::reload): +(WebCore::FrameLoader::stopAllLoaders): +(WebCore::FrameLoader::stopForBackForwardCache): +(WebCore::FrameLoader::setProvisionalDocumentLoader): +(WebCore::FrameLoader::setState): +(WebCore::FrameLoader::clearProvisionalLoad): +(WebCore::FrameLoader::commitProvisionalLoad): +(WebCore::FrameLoader::transitionToCommitted): +(WebCore::FrameLoader::checkLoadCompleteForThisFrame): +(WebCore::FrameLoader::loadPostRequest): +
[webkit-changes] [254648] branches/safari-609-branch
Title: [254648] branches/safari-609-branch Revision 254648 Author alanc...@apple.com Date 2020-01-15 15:07:41 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254229. rdar://problem/58605950 .naturalWidth should return the density-corrected intrinsic width https://bugs.webkit.org/show_bug.cgi?id=150443 Patch by Noam Rosenthal on 2020-01-08 Reviewed by Simon Fraser. LayoutTests/imported/w3c: Updated expected results. * web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt: All tests now pass. * web-platform-tests/html/semantics/embedded-content/the-img-element/intrinsicsize/intrinsicsize-with-responsive-images.tentative-expected.txt: Still fails but failure values are different. Source/WebCore: Take image's density into account when requesting naturalWidth/naturalHeight, not in SVG. This now complies with the standard (https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-naturalwidth) It also matches the behavior on Chrome and on Firefox. Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html Updaded expected results * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::effectiveImageDevicePixelRatio const): (WebCore::HTMLImageElement::naturalWidth const): (WebCore::HTMLImageElement::naturalHeight const): * html/HTMLImageElement.h: Use effective image devicePixelRatio for naturalWidth/height calculation * loader/cache/CachedImage.cpp: (WebCore::CachedImage::unclampedImageSizeForRenderer const): (WebCore::CachedImage::imageSizeForRenderer const): * loader/cache/CachedImage.h: Don't clamp to 1 when calculating naturalWidth/naturalHeight, as this has nothing to do with zoomed images. Zoomed images behavior remains the same. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254229 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/intrinsicsize/intrinsicsize-with-responsive-images.tentative-expected.txt branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/html/HTMLImageElement.cpp branches/safari-609-branch/Source/WebCore/html/HTMLImageElement.h branches/safari-609-branch/Source/WebCore/loader/cache/CachedImage.cpp branches/safari-609-branch/Source/WebCore/loader/cache/CachedImage.h Property Changed branches/safari-609-branch/Source/WebCore/html/HTMLImageElement.cpp Diff Modified: branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog (254647 => 254648) --- branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog 2020-01-15 23:07:36 UTC (rev 254647) +++ branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog 2020-01-15 23:07:41 UTC (rev 254648) @@ -1,5 +1,66 @@ 2020-01-15 Alan Coon +Cherry-pick r254229. rdar://problem/58605950 + +.naturalWidth should return the density-corrected intrinsic width +https://bugs.webkit.org/show_bug.cgi?id=150443 + +Patch by Noam Rosenthal on 2020-01-08 +Reviewed by Simon Fraser. + +LayoutTests/imported/w3c: + +Updated expected results. + +* web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt: +All tests now pass. + +* web-platform-tests/html/semantics/embedded-content/the-img-element/intrinsicsize/intrinsicsize-with-responsive-images.tentative-expected.txt: +Still fails but failure values are different. + +Source/WebCore: + +Take image's density into account when requesting naturalWidth/naturalHeight, not in SVG. + +This now complies with the standard (https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-naturalwidth) +It also matches the behavior on Chrome and on Firefox. + +Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html +Updaded expected results + +* html/HTMLImageElement.cpp: +(WebCore::HTMLImageElement::effectiveImageDevicePixelRatio const): +(WebCore::HTMLImageElement::naturalWidth const): +(WebCore::HTMLImageElement::naturalHeight const): +* html/HTMLImageElement.h: +Use effective image devicePixelRatio for naturalWidth/height calculation + +* loader/cache/CachedImage.cpp: +(WebCore::CachedImage::unclampedImageSizeForRenderer const): +(WebCore::CachedImage::imageSizeForRenderer const): +*
[webkit-changes] [254643] branches/safari-609-branch
Title: [254643] branches/safari-609-branch Revision 254643 Author alanc...@apple.com Date 2020-01-15 15:07:16 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r254007. rdar://problem/58605939 REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing https://bugs.webkit.org/show_bug.cgi?id=201900 Reviewed by Eric Carlson. Source/WebCore: No change of behavior. * Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::registerMDNSName): Fix message typo (missing space). LayoutTests: * platform/ios/TestExpectations: Reenable test. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254007 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations branches/safari-609-branch/Source/WebCore/ChangeLog Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254642 => 254643) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 23:07:11 UTC (rev 254642) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 23:07:16 UTC (rev 254643) @@ -1,5 +1,41 @@ 2020-01-15 Alan Coon +Cherry-pick r254007. rdar://problem/58605939 + +REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing +https://bugs.webkit.org/show_bug.cgi?id=201900 + + +Reviewed by Eric Carlson. + +Source/WebCore: + +No change of behavior. + +* Modules/mediastream/PeerConnectionBackend.cpp: +(WebCore::PeerConnectionBackend::registerMDNSName): +Fix message typo (missing space). + +LayoutTests: + +* platform/ios/TestExpectations: +Reenable test. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254007 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-03 youenn fablet + +REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing +https://bugs.webkit.org/show_bug.cgi?id=201900 + + +Reviewed by Eric Carlson. + +* platform/ios/TestExpectations: +Reenable test. + +2020-01-15 Alan Coon + Cherry-pick r250024. rdar://problem/58605939 Unreviewed iOS 13 test gardening, update test expectations. Modified: branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations (254642 => 254643) --- branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations 2020-01-15 23:07:11 UTC (rev 254642) +++ branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations 2020-01-15 23:07:16 UTC (rev 254643) @@ -3351,7 +3351,6 @@ # fast/scrolling/ios/body-overflow-hidden.html is an Image failure fast/scrolling/ios/body-overflow-hidden.html [ Pass ImageOnlyFailure ] -<<< HEAD webkit.org/b/201901 svg/custom/glyph-selection-arabic-forms.svg [ Failure ] webkit.org/b/202328 fast/images/async-image-multiple-clients-repaint.html [ Pass Failure ] @@ -3467,6 +3466,4 @@ webkit.org/b/201899 editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html [ Failure ] -webkit.org/b/201900 webrtc/datachannel/mdns-ice-candidates.html [ Failure ] - webkit.org/b/201901 svg/custom/glyph-selection-arabic-forms.svg [ Failure ] Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254642 => 254643) --- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:11 UTC (rev 254642) +++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:16 UTC (rev 254643) @@ -1,5 +1,44 @@ 2020-01-15 Alan Coon +Cherry-pick r254007. rdar://problem/58605939 + +REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing +https://bugs.webkit.org/show_bug.cgi?id=201900 + + +Reviewed by Eric Carlson. + +Source/WebCore: + +No change of behavior. + +* Modules/mediastream/PeerConnectionBackend.cpp: +(WebCore::PeerConnectionBackend::registerMDNSName): +Fix message typo (missing space). + +LayoutTests: + +* platform/ios/TestExpectations: +Reenable test. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254007 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-01-03 youenn fablet + +REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing +https://bugs.webkit.org/show_bug.cgi?id=201900 + + +Reviewed by Eric Carlson. + +No change of behavior. + +* Modules/mediastream/PeerConnectionBackend.cpp: +(WebCore::PeerConnectionBackend::registerMDNSName): +Fix message typo (missing space). + +2020-01-15 Alan Coon + Cherry-pick r254551. rdar://problem/58508705 Build ANGLE as a dynamic library ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [254642] branches/safari-609-branch/LayoutTests
Title: [254642] branches/safari-609-branch/LayoutTests Revision 254642 Author alanc...@apple.com Date 2020-01-15 15:07:11 -0800 (Wed, 15 Jan 2020) Log Message Cherry-pick r250024. rdar://problem/58605939 Unreviewed iOS 13 test gardening, update test expectations. * platform/ios/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250024 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254641 => 254642) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 23:05:22 UTC (rev 254641) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-01-15 23:07:11 UTC (rev 254642) @@ -1,5 +1,21 @@ 2020-01-15 Alan Coon +Cherry-pick r250024. rdar://problem/58605939 + +Unreviewed iOS 13 test gardening, update test expectations. + +* platform/ios/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250024 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-09-17 Ryan Haddad + +Unreviewed iOS 13 test gardening, update test expectations. + +* platform/ios/TestExpectations: + +2020-01-15 Alan Coon + Cherry-pick r254415. rdar://problem/58548648 REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale Modified: branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations (254641 => 254642) --- branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations 2020-01-15 23:05:22 UTC (rev 254641) +++ branches/safari-609-branch/LayoutTests/platform/ios/TestExpectations 2020-01-15 23:07:11 UTC (rev 254642) @@ -3351,6 +3351,7 @@ # fast/scrolling/ios/body-overflow-hidden.html is an Image failure fast/scrolling/ios/body-overflow-hidden.html [ Pass ImageOnlyFailure ] +<<< HEAD webkit.org/b/201901 svg/custom/glyph-selection-arabic-forms.svg [ Failure ] webkit.org/b/202328 fast/images/async-image-multiple-clients-repaint.html [ Pass Failure ] @@ -3461,3 +3462,11 @@ webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageOnlyFailure ] webkit.org/b/200043 fast/text/international/system-language/navigator-language [ Pass Failure ] + +webkit.org/b/201898 editing/pasteboard/ios/dom-paste-same-origin.html [ Failure ] + +webkit.org/b/201899 editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html [ Failure ] + +webkit.org/b/201900 webrtc/datachannel/mdns-ice-candidates.html [ Failure ] + +webkit.org/b/201901 svg/custom/glyph-selection-arabic-forms.svg [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254668] trunk
Title: [254668] trunk Revision 254668 Author beid...@apple.com Date 2020-01-15 21:41:03 -0800 (Wed, 15 Jan 2020) Log Message Add WKContentWorld SPI, and use it in _javascript_ execution. https://bugs.webkit.org/show_bug.cgi?id=206310 Reviewed by Alex Christensen. Source/WebKit: Covered by API tests. _WKContentWorld is a UI Process wrapper for an InjectedBundleScriptWorld. Much like _WKUserContentWorld is. But different in that: - Its APIs are named different things - Only one unique instance per string name - It is used with evaluateJavascript: and callAsyncJavaScriptFunction: instead of WKUserContentController. But _WKContentWorld and _WKUserContentWorld do have to work together a little bit to avoid conflicts in the WebProcess. The new versions of evaluateJavascript: and callAsyncJavaScriptFunction: are also included, as well as API tests for all the new stuff. * Shared/API/APIObject.h: * Shared/Cocoa/APIObject.mm: (API::Object::newObject): * UIProcess/API/APIContentWorld.cpp: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.cpp. (API::ContentWorld::sharedWorldWithName): (API::ContentWorld::pageContentWorld): (API::ContentWorld::defaultClientWorld): (API::ContentWorld::ContentWorld): (API::ContentWorld::~ContentWorld): * UIProcess/API/APIContentWorld.h: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.h. * UIProcess/API/APIUserContentWorld.cpp: (API::UserContentWorld::generateIdentifier): (API::UserContentWorld::UserContentWorld): (API::generateIdentifier): Deleted. * UIProcess/API/APIUserContentWorld.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView evaluateJavaScript:completionHandler:]): (-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:completionHandler:inWorld:]): (-[WKWebView _callAsyncJavaScriptFunction:withArguments:inWorld:completionHandler:]): (-[WKWebView _evaluateJavaScript:inWorld:completionHandler:]): (-[WKWebView _evaluateJavaScriptWithoutUserGesture:completionHandler:]): (-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:completionHandler:]): Deleted. (-[WKWebView _callAsyncFunction:withArguments:completionHandler:]): Deleted. * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/API/Cocoa/_WKContentWorld.h: Added. * UIProcess/API/Cocoa/_WKContentWorld.mm: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.h. (+[_WKContentWorld pageContentWorld]): (+[_WKContentWorld defaultClientWorld]): (+[_WKContentWorld worldWithName:]): (-[_WKContentWorld dealloc]): (-[_WKContentWorld name]): (-[_WKContentWorld _apiObject]): * UIProcess/API/Cocoa/_WKContentWorldInternal.h: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.h. * UIProcess/UserContent/WebUserContentControllerProxy.cpp: * UIProcess/UserContent/WebUserContentControllerProxy.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptInMainFrame): (WebKit::WebPageProxy::runJavaScriptInMainFrameScriptWorld): * UIProcess/WebPageProxy.h: * WebProcess/UserContent/WebUserContentController.cpp: (WebKit::worldMap): (WebKit::WebUserContentController::worldForIdentifier): (WebKit::WebUserContentController::addUserContentWorld): (WebKit::WebUserContentController::addUserContentWorlds): * WebProcess/UserContent/WebUserContentController.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::runJavaScript): (WebKit::WebPage::runJavaScriptInMainFrameScriptWorld): (WebKit::WebPage::runJavaScriptInFrame): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * Sources.txt: * WebKit.xcodeproj/project.pbxproj: Tools: Update previous callAsyncFunction calls with the new signature. Add tests for new _WKContentWorld class and its behavior with regard to executing _javascript_. * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm: (TestWebKitAPI::tryGCPromise): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm: (TEST): * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/API/APIObject.h trunk/Source/WebKit/Shared/Cocoa/APIObject.mm trunk/Source/WebKit/Sources.txt trunk/Source/WebKit/UIProcess/API/APIUserContentWorld.cpp trunk/Source/WebKit/UIProcess/API/APIUserContentWorld.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
[webkit-changes] [254662] trunk
Title: [254662] trunk
Revision 254662
Author rn...@webkit.org
Date 2020-01-15 19:02:24 -0800 (Wed, 15 Jan 2020)
Log Message
Nullptr crash in DocumentLoader::clearMainResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=206204
Source/WebCore:
Patch by Pinki Gyanchandani on 2020-01-15
Reviewed by Ryosuke Niwa.
Test: loader/change-src-during-iframe-load-crash.html
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::frameLoader const):
(WebCore::DocumentLoader::clearMainResourceLoader):
LayoutTests:
Added a NULL pointer check for FrameLoader. If FramLoader is NULL then return instead of
accessing activeDocumentLoader.
Patch by Pinki Gyanchandani on 2020-01-15
Reviewed by Ryosuke Niwa.
* loader/change-src-during-iframe-load-crash-expected.txt: Added.
* loader/change-src-during-iframe-load-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
Added Paths
trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt
trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (254661 => 254662)
--- trunk/LayoutTests/ChangeLog 2020-01-16 02:23:39 UTC (rev 254661)
+++ trunk/LayoutTests/ChangeLog 2020-01-16 03:02:24 UTC (rev 254662)
@@ -1,3 +1,16 @@
+2020-01-15 Pinki Gyanchandani
+
+Nullptr crash in DocumentLoader::clearMainResourceLoader
+https://bugs.webkit.org/show_bug.cgi?id=206204
+
+Added a NULL pointer check for FrameLoader. If FramLoader is NULL then return instead of
+accessing activeDocumentLoader.
+
+Reviewed by Ryosuke Niwa.
+
+* loader/change-src-during-iframe-load-crash-expected.txt: Added.
+* loader/change-src-during-iframe-load-crash.html: Added.
+
2020-01-15 Said Abou-Hallawa
[SVG2]: Implement support for the 'pathLength' attribute
Added: trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt (0 => 254662)
--- trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/change-src-during-iframe-load-crash-expected.txt 2020-01-16 03:02:24 UTC (rev 254662)
@@ -0,0 +1 @@
+The test is declared pass if there is no crash observed.
Added: trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html (0 => 254662)
--- trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html (rev 0)
+++ trunk/LayoutTests/loader/change-src-during-iframe-load-crash.html 2020-01-16 03:02:24 UTC (rev 254662)
@@ -0,0 +1,27 @@
+
+
+
+let didLoad = false;
+let didFinishTesting = false;
+
+function load() {
+document.body.innerHTML = 'The test is declared pass if there is no crash observed.';
+didLoad =true;
+if (window.testRunner) {
+testRunner.dumpAsText();
+if(!didFinishTesting)
+testRunner.waitUntilDone();
+}
+}
+
+function didLoadFrame2() {
+iframe1.srcdoc = "x";
+didFinishTesting = true;
+if (window.testRunner && didLoad)
+testRunner.notifyDone();
+}
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (254661 => 254662)
--- trunk/Source/WebCore/ChangeLog 2020-01-16 02:23:39 UTC (rev 254661)
+++ trunk/Source/WebCore/ChangeLog 2020-01-16 03:02:24 UTC (rev 254662)
@@ -1,3 +1,16 @@
+2020-01-15 Pinki Gyanchandani
+
+Nullptr crash in DocumentLoader::clearMainResourceLoader
+https://bugs.webkit.org/show_bug.cgi?id=206204
+
+Reviewed by Ryosuke Niwa.
+
+Test: loader/change-src-during-iframe-load-crash.html
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::frameLoader const):
+(WebCore::DocumentLoader::clearMainResourceLoader):
+
2020-01-15 Zalan Bujtas
[LFC][IFC] LineBreaker::shouldWrapInlineContent should take the candidate content width
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (254661 => 254662)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-01-16 02:23:39 UTC (rev 254661)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-01-16 03:02:24 UTC (rev 254662)
@@ -1272,7 +1272,12 @@
{
m_loadingMainResource = false;
-if (this == frameLoader()->activeDocumentLoader())
+auto* frameLoader = this->frameLoader();
+
+if (!frameLoader)
+return;
+
+if (this == frameLoader->activeDocumentLoader())
checkLoadComplete();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254663] trunk/Source/WebKit
Title: [254663] trunk/Source/WebKit
Revision 254663
Author ross.kirsl...@sony.com
Date 2020-01-15 19:10:18 -0800 (Wed, 15 Jan 2020)
Log Message
[PlayStation] Add stubs for WebContextMenuClient
https://bugs.webkit.org/show_bug.cgi?id=206324
Reviewed by Don Olmstead.
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
(WebKit::WebContextMenuClient::lookUpInDictionary): Deleted.
(WebKit::WebContextMenuClient::isSpeaking): Deleted.
(WebKit::WebContextMenuClient::speak): Deleted.
(WebKit::WebContextMenuClient::stopSpeaking): Deleted.
Bring GTK/WPE stubs down for broader use.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesWPE.txt
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp
Removed Paths
trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (254662 => 254663)
--- trunk/Source/WebKit/ChangeLog 2020-01-16 03:02:24 UTC (rev 254662)
+++ trunk/Source/WebKit/ChangeLog 2020-01-16 03:10:18 UTC (rev 254663)
@@ -1,5 +1,24 @@
2020-01-15 Ross Kirsling
+[PlayStation] Add stubs for WebContextMenuClient
+https://bugs.webkit.org/show_bug.cgi?id=206324
+
+Reviewed by Don Olmstead.
+
+* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
+(WebKit::WebContextMenuClient::lookUpInDictionary):
+(WebKit::WebContextMenuClient::isSpeaking):
+(WebKit::WebContextMenuClient::speak):
+(WebKit::WebContextMenuClient::stopSpeaking):
+* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
+(WebKit::WebContextMenuClient::lookUpInDictionary): Deleted.
+(WebKit::WebContextMenuClient::isSpeaking): Deleted.
+(WebKit::WebContextMenuClient::speak): Deleted.
+(WebKit::WebContextMenuClient::stopSpeaking): Deleted.
+Bring GTK/WPE stubs down for broader use.
+
+2020-01-15 Ross Kirsling
+
[PlayStation] Add stub for WebPopupMenu::setUpPlatformData
https://bugs.webkit.org/show_bug.cgi?id=206323
Modified: trunk/Source/WebKit/SourcesWPE.txt (254662 => 254663)
--- trunk/Source/WebKit/SourcesWPE.txt 2020-01-16 03:02:24 UTC (rev 254662)
+++ trunk/Source/WebKit/SourcesWPE.txt 2020-01-16 03:10:18 UTC (rev 254663)
@@ -241,7 +241,6 @@
WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
-WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp
WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp
WebProcess/WebPage/AcceleratedSurface.cpp
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp (254662 => 254663)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp 2020-01-16 03:02:24 UTC (rev 254662)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp 2020-01-16 03:10:18 UTC (rev 254663)
@@ -70,6 +70,27 @@
page->mainFrame().loader().urlSelected(URL { URL { }, url }, { }, nullptr, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, ShouldOpenExternalURLsPolicy::ShouldNotAllow);
}
}
+
+void WebContextMenuClient::lookUpInDictionary(WebCore::Frame*)
+{
+notImplemented();
+}
+
+bool WebContextMenuClient::isSpeaking()
+{
+notImplemented();
+return false;
+}
+
+void WebContextMenuClient::speak(const String&)
+{
+notImplemented();
+}
+
+void WebContextMenuClient::stopSpeaking()
+{
+notImplemented();
+}
#endif
#if USE(ACCESSIBILITY_CONTEXT_MENUS)
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp (254662 => 254663)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp 2020-01-16 03:02:24 UTC (rev 254662)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp 2020-01-16 03:10:18 UTC (rev 254663)
@@ -30,32 +30,9 @@
#if ENABLE(CONTEXT_MENUS)
#include "WebPage.h"
-#include
namespace WebKit {
-using namespace WebCore;
-void WebContextMenuClient::lookUpInDictionary(Frame*)
-{
-notImplemented();
-}
-
-bool WebContextMenuClient::isSpeaking()
-{
-notImplemented();
-return false;
-}
-
-void WebContextMenuClient::speak(const String&)
-{
-notImplemented();
-}
-
-void WebContextMenuClient::stopSpeaking()
-{
-notImplemented();
-}
-
void WebContextMenuClient::insertEmoji(Frame& frame)
{
m_page->showEmojiPicker(frame);
Deleted: trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp (254662 => 254663)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp 2020-01-16 03:02:24 UTC (rev 254662)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp
[webkit-changes] [254664] trunk/LayoutTests
Title: [254664] trunk/LayoutTests Revision 254664 Author commit-qu...@webkit.org Date 2020-01-15 19:28:33 -0800 (Wed, 15 Jan 2020) Log Message [GTK] Gardening tests using language override https://bugs.webkit.org/show_bug.cgi?id=206333 Patch by Lauro Moura on 2020-01-15 Reviewed by Carlos Alberto Lopez Perez. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (254663 => 254664) --- trunk/LayoutTests/ChangeLog 2020-01-16 03:10:18 UTC (rev 254663) +++ trunk/LayoutTests/ChangeLog 2020-01-16 03:28:33 UTC (rev 254664) @@ -1,3 +1,12 @@ +2020-01-15 Lauro Moura + +[GTK] Gardening tests using language override +https://bugs.webkit.org/show_bug.cgi?id=206333 + +Reviewed by Carlos Alberto Lopez Perez. + +* platform/gtk/TestExpectations: + 2020-01-15 Pinki Gyanchandani Nullptr crash in DocumentLoader::clearMainResourceLoader Modified: trunk/LayoutTests/platform/gtk/TestExpectations (254663 => 254664) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-01-16 03:10:18 UTC (rev 254663) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-01-16 03:28:33 UTC (rev 254664) @@ -853,6 +853,25 @@ # The GTK+ test harness doesn't have support for overriding preferred languages. webkit.org/b/152618 fast/text/international/system-language/declarative-language.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-en-GB.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-en-US.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-en.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es-419.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es-ES.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es-MX.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-fr.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-hi.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-ja.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-ru.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html [ Failure ] +webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html [ Failure ] # This port doesn't support small-caps synthesis. webkit.org/b/152620 css3/font-variant-all.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254665] branches/safari-609-branch
Title: [254665] branches/safari-609-branch Revision 254665 Author alanc...@apple.com Date 2020-01-15 19:34:03 -0800 (Wed, 15 Jan 2020) Log Message Apply patch. rdar://problem/58353217 Modified Paths branches/safari-609-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig branches/safari-609-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig branches/safari-609-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig branches/safari-609-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: branches/safari-609-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig (254664 => 254665) --- branches/safari-609-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig 2020-01-16 03:28:33 UTC (rev 254664) +++ branches/safari-609-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig 2020-01-16 03:34:03 UTC (rev 254665) @@ -188,7 +188,7 @@ ENABLE_GEOLOCATION_maccatalyst = ENABLE_GEOLOCATION; ENABLE_GEOLOCATION_macosx = ENABLE_GEOLOCATION; -ENABLE_GPU_PROCESS = ENABLE_GPU_PROCESS; +ENABLE_GPU_PROCESS = ; ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE; Modified: branches/safari-609-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (254664 => 254665) --- branches/safari-609-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2020-01-16 03:28:33 UTC (rev 254664) +++ branches/safari-609-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2020-01-16 03:34:03 UTC (rev 254665) @@ -188,7 +188,7 @@ ENABLE_GEOLOCATION_maccatalyst = ENABLE_GEOLOCATION; ENABLE_GEOLOCATION_macosx = ENABLE_GEOLOCATION; -ENABLE_GPU_PROCESS = ENABLE_GPU_PROCESS; +ENABLE_GPU_PROCESS = ; ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE; Modified: branches/safari-609-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig (254664 => 254665) --- branches/safari-609-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig 2020-01-16 03:28:33 UTC (rev 254664) +++ branches/safari-609-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig 2020-01-16 03:34:03 UTC (rev 254665) @@ -188,7 +188,7 @@ ENABLE_GEOLOCATION_maccatalyst = ENABLE_GEOLOCATION; ENABLE_GEOLOCATION_macosx = ENABLE_GEOLOCATION; -ENABLE_GPU_PROCESS = ENABLE_GPU_PROCESS; +ENABLE_GPU_PROCESS = ; ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE; Modified: branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (254664 => 254665) --- branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2020-01-16 03:28:33 UTC (rev 254664) +++ branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2020-01-16 03:34:03 UTC (rev 254665) @@ -188,7 +188,7 @@ ENABLE_GEOLOCATION_maccatalyst = ENABLE_GEOLOCATION; ENABLE_GEOLOCATION_macosx = ENABLE_GEOLOCATION; -ENABLE_GPU_PROCESS = ENABLE_GPU_PROCESS; +ENABLE_GPU_PROCESS = ; ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE; Modified: branches/safari-609-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (254664 => 254665) --- branches/safari-609-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2020-01-16 03:28:33 UTC (rev 254664) +++ branches/safari-609-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2020-01-16 03:34:03 UTC (rev 254665) @@ -188,7 +188,7 @@ ENABLE_GEOLOCATION_maccatalyst = ENABLE_GEOLOCATION; ENABLE_GEOLOCATION_macosx = ENABLE_GEOLOCATION; -ENABLE_GPU_PROCESS = ENABLE_GPU_PROCESS; +ENABLE_GPU_PROCESS = ; ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254667] releases/Apple/Safari Technology Preview
Title: [254667] releases/Apple/Safari Technology Preview Revision 254667 Author m...@apple.com Date 2020-01-15 21:08:48 -0800 (Wed, 15 Jan 2020) Log Message Added a tag for Safari Technology Preview release 98. Added Paths releases/Apple/Safari Technology Preview/Safari Technology Preview 98/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/ANGLE/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/_javascript_Core/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WTF/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WebCore/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WebInspectorUI/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WebKit/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WebKitLegacy/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/bmalloc/ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/libwebrtc/ Diff Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/ANGLE === --- tags/Safari-609.1.13.4/Source/ThirdParty/ANGLE 2020-01-16 03:50:29 UTC (rev 254666) +++ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/ANGLE 2020-01-16 05:08:48 UTC (rev 254667) Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/_javascript_Core === --- tags/Safari-609.1.13.4/Source/_javascript_Core 2020-01-16 03:50:29 UTC (rev 254666) +++ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/_javascript_Core 2020-01-16 05:08:48 UTC (rev 254667) Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WTF === --- tags/Safari-609.1.13.4/Source/WTF 2020-01-16 03:50:29 UTC (rev 254666) +++ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WTF 2020-01-16 05:08:48 UTC (rev 254667) Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WebInspectorUI === --- tags/Safari-609.1.13.4/Source/WebInspectorUI 2020-01-16 03:50:29 UTC (rev 254666) +++ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WebInspectorUI 2020-01-16 05:08:48 UTC (rev 254667) Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/WebInspectorUI Added: svn:mergeinfo +/trunk/Source/WebInspectorUI:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/bmalloc === --- tags/Safari-609.1.13.4/Source/bmalloc 2020-01-16 03:50:29 UTC (rev 254666) +++ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/bmalloc 2020-01-16 05:08:48 UTC (rev 254667) Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/libwebrtc === --- tags/Safari-609.1.13.4/Source/ThirdParty/libwebrtc 2020-01-16 03:50:29 UTC (rev 254666) +++ releases/Apple/Safari Technology Preview/Safari Technology Preview 98/libwebrtc 2020-01-16 05:08:48 UTC (rev 254667) Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 98/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254640] trunk/Source/WebCore
Title: [254640] trunk/Source/WebCore
Revision 254640
Author simon.fra...@apple.com
Date 2020-01-15 14:48:09 -0800 (Wed, 15 Jan 2020)
Log Message
Unreviewed cleanup.
TextStream is used outside #if ENABLE(KINETIC_SCROLLING) lower down, so remove
these guards.
* platform/PlatformWheelEvent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformWheelEvent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (254639 => 254640)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 22:23:31 UTC (rev 254639)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 22:48:09 UTC (rev 254640)
@@ -1,3 +1,12 @@
+2020-01-15 Simon Fraser
+
+Unreviewed cleanup.
+
+TextStream is used outside #if ENABLE(KINETIC_SCROLLING) lower down, so remove
+these guards.
+
+* platform/PlatformWheelEvent.h:
+
2020-01-15 Antti Koivisto
[LFC] Cache display box for the first LayoutState to Layout::Box
Modified: trunk/Source/WebCore/platform/PlatformWheelEvent.h (254639 => 254640)
--- trunk/Source/WebCore/platform/PlatformWheelEvent.h 2020-01-15 22:23:31 UTC (rev 254639)
+++ trunk/Source/WebCore/platform/PlatformWheelEvent.h 2020-01-15 22:48:09 UTC (rev 254640)
@@ -34,11 +34,9 @@
typedef struct _GdkEventScroll GdkEventScroll;
#endif
-#if ENABLE(KINETIC_SCROLLING)
namespace WTF {
class TextStream;
}
-#endif
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254649] branches/safari-609-branch/Source/WebCore
Title: [254649] branches/safari-609-branch/Source/WebCore
Revision 254649
Author alanc...@apple.com
Date 2020-01-15 15:07:43 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254267. rdar://problem/58606290
Reformat FrameView logging
https://bugs.webkit.org/show_bug.cgi?id=205984
Reviewed by Brent Fulgham.
Update the format used by FrameView in its RELEASE_LOG logging. Use
the format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:
- [] :::
So, for example:
0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame
becomes:
0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame
No new tests -- no new or changed functionality.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/page/FrameView.cpp
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254648 => 254649)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:41 UTC (rev 254648)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:43 UTC (rev 254649)
@@ -1,5 +1,66 @@
2020-01-15 Alan Coon
+Cherry-pick r254267. rdar://problem/58606290
+
+Reformat FrameView logging
+https://bugs.webkit.org/show_bug.cgi?id=205984
+
+
+Reviewed by Brent Fulgham.
+
+Update the format used by FrameView in its RELEASE_LOG logging. Use
+the format used by WebPageProxy and NetworkResourceLoader, which is
+generally of the form:
+
+ - [] :::
+
+So, for example:
+
+0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame
+
+becomes:
+
+0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame
+
+No new tests -- no new or changed functionality.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::paintContents):
+(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-09 Keith Rollin
+
+Reformat FrameView logging
+https://bugs.webkit.org/show_bug.cgi?id=205984
+
+
+Reviewed by Brent Fulgham.
+
+Update the format used by FrameView in its RELEASE_LOG logging. Use
+the format used by WebPageProxy and NetworkResourceLoader, which is
+generally of the form:
+
+ - [] :::
+
+So, for example:
+
+0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame
+
+becomes:
+
+0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame
+
+No new tests -- no new or changed functionality.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::paintContents):
+(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
+
+2020-01-15 Alan Coon
+
Cherry-pick r254229. rdar://problem/58605950
.naturalWidth should return the density-corrected intrinsic width
Modified: branches/safari-609-branch/Source/WebCore/page/FrameView.cpp (254648 => 254649)
--- branches/safari-609-branch/Source/WebCore/page/FrameView.cpp 2020-01-15 23:07:41 UTC (rev 254648)
+++ branches/safari-609-branch/Source/WebCore/page/FrameView.cpp 2020-01-15 23:07:43 UTC (rev 254649)
@@ -132,7 +132,7 @@
#include "LayoutContext.h"
#endif
-#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(frame().page() && frame().page()->isAlwaysOnLoggingAllowed(), Layout, "%p - FrameView::" fmt, this, ##__VA_ARGS__)
+#define FRAMEVIEW_RELEASE_LOG_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_IF(frame().page() && frame().page()->isAlwaysOnLoggingAllowed(), channel, "%p - [frame=%p, main=%d] FrameView::" fmt, this, (), frame().isMainFrame(), ##__VA_ARGS__)
namespace WebCore {
@@ -4185,7 +4185,7 @@
ASSERT(!needsLayout());
if (needsLayout()) {
-RELEASE_LOG_IF_ALLOWED("FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)", frame().isMainFrame());
+FRAMEVIEW_RELEASE_LOG_IF_ALLOWED(Layout, "paintContents: Not painting because render tree
[webkit-changes] [254645] branches/safari-609-branch
Title: [254645] branches/safari-609-branch
Revision 254645
Author alanc...@apple.com
Date 2020-01-15 15:07:23 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254089. rdar://problem/58606252
XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
https://bugs.webkit.org/show_bug.cgi?id=205685
Reviewed by Alex Christensen.
Source/WebCore:
There is no blob registry in the UIProcess.
This should not matter since we do not yet support blobs in custom scheme handlers.
But we are calling the blob registry when creating a request body, which does not work in UIProcess.
Instead, pass a lambda that will be called in case of blobs.
Covered by API test.
* platform/network/FormData.cpp:
(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::resolveBlobReferences):
* platform/network/FormData.h:
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::createHTTPBodyCFReadStream):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/platform/network/FormData.cpp
branches/safari-609-branch/Source/WebCore/platform/network/FormData.h
branches/safari-609-branch/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp
branches/safari-609-branch/Tools/ChangeLog
branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254644 => 254645)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:19 UTC (rev 254644)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:23 UTC (rev 254645)
@@ -1,5 +1,56 @@
2020-01-15 Alan Coon
+Cherry-pick r254089. rdar://problem/58606252
+
+XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
+https://bugs.webkit.org/show_bug.cgi?id=205685
+
+Reviewed by Alex Christensen.
+
+Source/WebCore:
+
+There is no blob registry in the UIProcess.
+This should not matter since we do not yet support blobs in custom scheme handlers.
+But we are calling the blob registry when creating a request body, which does not work in UIProcess.
+Instead, pass a lambda that will be called in case of blobs.
+Covered by API test.
+
+* platform/network/FormData.cpp:
+(WebCore::FormDataElement::lengthInBytes const):
+(WebCore::FormData::resolveBlobReferences):
+* platform/network/FormData.h:
+* platform/network/cf/FormDataStreamCFNet.cpp:
+(WebCore::createHTTPBodyCFReadStream):
+
+Tools:
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-06 youenn fablet
+
+XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
+https://bugs.webkit.org/show_bug.cgi?id=205685
+
+Reviewed by Alex Christensen.
+
+There is no blob registry in the UIProcess.
+This should not matter since we do not yet support blobs in custom scheme handlers.
+But we are calling the blob registry when creating a request body, which does not work in UIProcess.
+Instead, pass a lambda that will be called in case of blobs.
+Covered by API test.
+
+* platform/network/FormData.cpp:
+(WebCore::FormDataElement::lengthInBytes const):
+(WebCore::FormData::resolveBlobReferences):
+* platform/network/FormData.h:
+* platform/network/cf/FormDataStreamCFNet.cpp:
+(WebCore::createHTTPBodyCFReadStream):
+
+2020-01-15 Alan Coon
+
Cherry-pick r254007. rdar://problem/58605939
REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing
Modified: branches/safari-609-branch/Source/WebCore/platform/network/FormData.cpp (254644 => 254645)
--- branches/safari-609-branch/Source/WebCore/platform/network/FormData.cpp 2020-01-15 23:07:19 UTC (rev 254644)
+++ branches/safari-609-branch/Source/WebCore/platform/network/FormData.cpp 2020-01-15 23:07:23 UTC (rev 254645)
@@ -123,9 +123,9 @@
return formData;
}
-static inline uint64_t computeLengthInBytes(const FormDataElement& element, const Function& blobSize)
+uint64_t FormDataElement::lengthInBytes(const Function& blobSize) const
{
-return switchOn(element.data,
+return switchOn(data,
[] (const Vector& bytes) {
return static_cast(bytes.size());
}, [] (const FormDataElement::EncodedFileData& fileData) {
@@ -141,16 +141,9 @@
);
}
-uint64_t FormDataElement::lengthInBytes(BlobRegistryImpl* blobRegistry) const
-{
-
[webkit-changes] [254644] branches/safari-609-branch/Source/WebInspectorUI
Title: [254644] branches/safari-609-branch/Source/WebInspectorUI
Revision 254644
Author alanc...@apple.com
Date 2020-01-15 15:07:19 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254058. rdar://problem/58606175
Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
https://bugs.webkit.org/show_bug.cgi?id=205659
Reviewed by Brian Burg.
Limit the height of the canvas and shader program tree a recording is selected.
* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
* UserInterface/Views/CanvasSidebarPanel.css:
(.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebInspectorUI/ChangeLog
branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css
branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
Diff
Modified: branches/safari-609-branch/Source/WebInspectorUI/ChangeLog (254643 => 254644)
--- branches/safari-609-branch/Source/WebInspectorUI/ChangeLog 2020-01-15 23:07:16 UTC (rev 254643)
+++ branches/safari-609-branch/Source/WebInspectorUI/ChangeLog 2020-01-15 23:07:19 UTC (rev 254644)
@@ -1,3 +1,36 @@
+2020-01-15 Alan Coon
+
+Cherry-pick r254058. rdar://problem/58606175
+
+Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
+https://bugs.webkit.org/show_bug.cgi?id=205659
+
+Reviewed by Brian Burg.
+
+Limit the height of the canvas and shader program tree a recording is selected.
+
+* UserInterface/Views/CanvasSidebarPanel.js:
+(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
+* UserInterface/Views/CanvasSidebarPanel.css:
+(.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-06 Devin Rousso
+
+Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
+https://bugs.webkit.org/show_bug.cgi?id=205659
+
+Reviewed by Brian Burg.
+
+Limit the height of the canvas and shader program tree a recording is selected.
+
+* UserInterface/Views/CanvasSidebarPanel.js:
+(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
+* UserInterface/Views/CanvasSidebarPanel.css:
+(.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.
+
2020-01-14 Alan Coon
Cherry-pick r254145. rdar://problem/58552861
Modified: branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css (254643 => 254644)
--- branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css 2020-01-15 23:07:16 UTC (rev 254643)
+++ branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css 2020-01-15 23:07:19 UTC (rev 254644)
@@ -52,6 +52,13 @@
overflow-y: scroll;
}
+.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas {
+flex-shrink: 0;
+height: fit-content;
+max-height: 110px;
+overflow-y: auto;
+}
+
.sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,
.sidebar > .panel.navigation.canvas:not(.has-recordings) > .content > :matches(.navigation-bar, .recording-content) {
display: none;
Modified: branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js (254643 => 254644)
--- branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2020-01-15 23:07:16 UTC (rev 254643)
+++ branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2020-01-15 23:07:19 UTC (rev 254644)
@@ -498,6 +498,7 @@
let hasRecordings = this._recording || (this._canvas && this._canvas.recordingCollection.size);
this.element.classList.toggle("has-recordings", hasRecordings);
+this.element.classList.toggle("showing-recording", !!this._recording);
if (!hasRecordings)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254654] trunk/Tools
Title: [254654] trunk/Tools
Revision 254654
Author jbed...@apple.com
Date 2020-01-15 16:35:55 -0800 (Wed, 15 Jan 2020)
Log Message
run-api-tests no longer supports wildcards in test names
https://bugs.webkit.org/show_bug.cgi?id=206319
Reviewed by Chris Dumez.
* Scripts/webkitpy/api_tests/manager.py:
(Manager._find_test_subset):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/api_tests/manager.py
Diff
Modified: trunk/Tools/ChangeLog (254653 => 254654)
--- trunk/Tools/ChangeLog 2020-01-16 00:09:50 UTC (rev 254653)
+++ trunk/Tools/ChangeLog 2020-01-16 00:35:55 UTC (rev 254654)
@@ -1,3 +1,14 @@
+2020-01-15 Jonathan Bedard
+
+run-api-tests no longer supports wildcards in test names
+https://bugs.webkit.org/show_bug.cgi?id=206319
+
+
+Reviewed by Chris Dumez.
+
+* Scripts/webkitpy/api_tests/manager.py:
+(Manager._find_test_subset):
+
2020-01-15 David Kilzer
Enable -Wconditional-uninitialized in DumpRenderTree, WebKitTestRunner
Modified: trunk/Tools/Scripts/webkitpy/api_tests/manager.py (254653 => 254654)
--- trunk/Tools/Scripts/webkitpy/api_tests/manager.py 2020-01-16 00:09:50 UTC (rev 254653)
+++ trunk/Tools/Scripts/webkitpy/api_tests/manager.py 2020-01-16 00:35:55 UTC (rev 254654)
@@ -22,6 +22,7 @@
import json
import logging
+import re
import time
from webkitpy.api_tests.runner import Runner
@@ -73,19 +74,28 @@
def _find_test_subset(superset, arg_filter):
result = []
for arg in arg_filter:
-split_arg = arg.split('.')
+# Might match .. or just .
+arg_re = re.compile('^{}$'.format(arg.replace('*', '.*')))
for test in superset:
-# Might match .. or just .
+if arg_re.match(test):
+result.append(test)
+continue
+
split_test = test.split('.')
-if len(split_arg) == 1:
-if test not in result and (arg == split_test[0] or arg == split_test[1]):
-result.append(test)
-elif len(split_arg) == 2:
-if test not in result and (split_arg == split_test[0:2] or split_arg == split_test[1:3]):
-result.append(test)
-else:
-if arg == test and test not in result:
-result.append(test)
+if len(split_test) == 1:
+continue
+if arg_re.match('.'.join(split_test[1:])):
+result.append(test)
+continue
+if arg_re.match('.'.join(split_test[:-1])):
+result.append(test)
+continue
+
+if len(split_test) == 2:
+continue
+if arg_re.match('.'.join(split_test[1:-1])):
+result.append(test)
+continue
return result
def _collect_tests(self, args):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254660] trunk/Source/WebCore
Title: [254660] trunk/Source/WebCore
Revision 254660
Author commit-qu...@webkit.org
Date 2020-01-15 18:09:56 -0800 (Wed, 15 Jan 2020)
Log Message
Unreviewed, rolling out r254565.
https://bugs.webkit.org/show_bug.cgi?id=206331
It caused many timeouts for the layout tests of the GTK port
(Requested by clopez on #webkit).
Reverted changeset:
"[GStreamer] Several buffering fixes"
https://bugs.webkit.org/show_bug.cgi?id=206234
https://trac.webkit.org/changeset/254565
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (254659 => 254660)
--- trunk/Source/WebCore/ChangeLog 2020-01-16 02:00:16 UTC (rev 254659)
+++ trunk/Source/WebCore/ChangeLog 2020-01-16 02:09:56 UTC (rev 254660)
@@ -1,3 +1,17 @@
+2020-01-15 Commit Queue
+
+Unreviewed, rolling out r254565.
+https://bugs.webkit.org/show_bug.cgi?id=206331
+
+It caused many timeouts for the layout tests of the GTK port
+(Requested by clopez on #webkit).
+
+Reverted changeset:
+
+"[GStreamer] Several buffering fixes"
+https://bugs.webkit.org/show_bug.cgi?id=206234
+https://trac.webkit.org/changeset/254565
+
2020-01-15 Alex Christensen
Keep RefPtr instead of raw pointer to message queue on WebCoreResourceHandleAsOperationQueueDelegate
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (254659 => 254660)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-01-16 02:00:16 UTC (rev 254659)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-01-16 02:09:56 UTC (rev 254660)
@@ -1053,7 +1053,7 @@
MediaTime previousDuration = durationMediaTime();
m_cachedDuration = MediaTime::invalidTime();
-// Avoid emitting durationChanged in the case where the previous
+// Avoid emiting durationchanged in the case where the previous
// duration was 0 because that case is already handled by the
// HTMLMediaElement.
if (previousDuration && durationMediaTime() != previousDuration)
@@ -1456,7 +1456,7 @@
double fillStatus = 100.0;
GstBufferingMode mode = GST_BUFFERING_DOWNLOAD;
-if (gst_element_query(pipeline(), query.get())) {
+if (gst_element_query(m_source.get(), query.get())) {
gst_query_parse_buffering_stats(query.get(), , nullptr, nullptr, nullptr);
int percentage;
@@ -1470,10 +1470,7 @@
return;
}
-if (mode != GST_BUFFERING_DOWNLOAD)
-GST_INFO_OBJECT(pipeline(), "Ignoring buffering in %s", enumToString(GST_TYPE_BUFFERING_MODE, mode).data());
-else
-updateBufferingStatus(mode, fillStatus);
+updateBufferingStatus(mode, fillStatus);
}
void MediaPlayerPrivateGStreamer::loadStateChanged()
@@ -2201,11 +2198,6 @@
if (const char* uri = gst_structure_get_string(structure, "uri"))
m_hasTaintedOrigin = webKitSrcWouldTaintOrigin(WEBKIT_WEB_SRC_CAST(m_source.get()), SecurityOrigin::create(URL(URL(), uri)));
}
-} else if (gst_structure_has_name(structure, "GstCacheDownloadComplete")) {
-GST_INFO_OBJECT(pipeline(), "Stream is fully downloaded, stopping monitoring downloading progress.");
-m_fillTimer.stop();
-m_bufferingPercentage = 100;
-updateStates();
} else
GST_DEBUG_OBJECT(pipeline(), "Unhandled element message: %" GST_PTR_FORMAT, structure);
break;
@@ -2300,23 +2292,17 @@
void MediaPlayerPrivateGStreamer::updateBufferingStatus(GstBufferingMode mode, double percentage)
{
-bool wasBuffering = m_isBuffering;
-
GST_DEBUG_OBJECT(pipeline(), "[Buffering] mode: %s, status: %f%%", enumToString(GST_TYPE_BUFFERING_MODE, mode).data(), percentage);
m_didDownloadFinish = percentage == 100;
m_isBuffering = !m_didDownloadFinish;
-if (!m_didDownloadFinish)
-m_isBuffering = true;
-
-m_bufferingPercentage = percentage;
switch (mode) {
case GST_BUFFERING_STREAM: {
updateMaxTimeLoaded(percentage);
m_bufferingPercentage = percentage;
-if (m_didDownloadFinish || (!wasBuffering && m_isBuffering))
+if (m_didDownloadFinish)
updateStates();
break;
@@ -2323,6 +2309,12 @@
}
case GST_BUFFERING_DOWNLOAD: {
updateMaxTimeLoaded(percentage);
+
+// Media is now fully loaded. It will play even if network connection is
+// cut. Buffering is done, remove the fill source from the main loop.
+if (m_didDownloadFinish)
+m_fillTimer.stop();
+
updateStates();
break;
}
@@ -2585,17 +2577,9 @@
FALLTHROUGH;
case GST_STATE_PLAYING:
if (m_isBuffering) {
-GRefPtr query =
[webkit-changes] [254651] branches/safari-610.1.1-branch
Title: [254651] branches/safari-610.1.1-branch
Revision 254651
Author alanc...@apple.com
Date 2020-01-15 15:25:16 -0800 (Wed, 15 Jan 2020)
Log Message
Revert r254379. rdar://problem/58542040
Modified Paths
branches/safari-610.1.1-branch/LayoutTests/ChangeLog
branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
branches/safari-610.1.1-branch/Source/WebKit/ChangeLog
branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
Diff
Modified: branches/safari-610.1.1-branch/LayoutTests/ChangeLog (254650 => 254651)
--- branches/safari-610.1.1-branch/LayoutTests/ChangeLog 2020-01-15 23:25:12 UTC (rev 254650)
+++ branches/safari-610.1.1-branch/LayoutTests/ChangeLog 2020-01-15 23:25:16 UTC (rev 254651)
@@ -1,3 +1,7 @@
+2020-01-15 Kocsen Chung
+
+Revert r254379. rdar://problem/58542040
+
2020-01-14 Kocsen Chung
Revert r254521. rdar://problem/58542040
Modified: branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (254650 => 254651)
--- branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt 2020-01-15 23:25:12 UTC (rev 254650)
+++ branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt 2020-01-15 23:25:16 UTC (rev 254651)
@@ -8,10 +8,6 @@
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.TextInput") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.awdd") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.cookied") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.cpeprotector.xpc") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.figcontentkeysession.xpc") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.routingsessionmanager.xpc") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.sts") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iohideventsystem") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.locationd.registration") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nehelper") is false
Modified: branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (254650 => 254651)
--- branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html 2020-01-15 23:25:12 UTC (rev 254650)
+++ branches/safari-610.1.1-branch/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html 2020-01-15 23:25:16 UTC (rev 254651)
@@ -11,10 +11,6 @@
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.TextInput\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.awdd\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.cookied\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.cpeprotector.xpc\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.figcontentkeysession.xpc\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.routingsessionmanager.xpc\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.sts\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.iohideventsystem\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.locationd.registration\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nehelper\")");
Modified: branches/safari-610.1.1-branch/Source/WebKit/ChangeLog (254650 => 254651)
--- branches/safari-610.1.1-branch/Source/WebKit/ChangeLog 2020-01-15 23:25:12 UTC (rev 254650)
+++ branches/safari-610.1.1-branch/Source/WebKit/ChangeLog 2020-01-15 23:25:16 UTC (rev 254651)
@@ -1,3 +1,7 @@
+2020-01-15 Kocsen Chung
+
+Revert r254379. rdar://problem/58542040
+
2020-01-14 Kocsen Chung
Revert r254521. rdar://problem/58542040
Modified:
[webkit-changes] [254650] branches/safari-610.1.1-branch
Title: [254650] branches/safari-610.1.1-branch
Revision 254650
Author alanc...@apple.com
Date 2020-01-15 15:25:12 -0800 (Wed, 15 Jan 2020)
Log Message
Revert r254537. rdar://problem/58542040
Modified Paths
branches/safari-610.1.1-branch/Source/WebCore/ChangeLog
branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.cpp
branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.h
branches/safari-610.1.1-branch/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp
branches/safari-610.1.1-branch/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h
branches/safari-610.1.1-branch/Tools/ChangeLog
branches/safari-610.1.1-branch/Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp
Diff
Modified: branches/safari-610.1.1-branch/Source/WebCore/ChangeLog (254649 => 254650)
--- branches/safari-610.1.1-branch/Source/WebCore/ChangeLog 2020-01-15 23:07:43 UTC (rev 254649)
+++ branches/safari-610.1.1-branch/Source/WebCore/ChangeLog 2020-01-15 23:25:12 UTC (rev 254650)
@@ -1,3 +1,7 @@
+2020-01-15 Kocsen Chung
+
+Revert r254537. rdar://problem/58542040
+
2020-01-15 Alan Coon
Cherry-pick r254551. rdar://problem/58508705
Modified: branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.cpp (254649 => 254650)
--- branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.cpp 2020-01-15 23:07:43 UTC (rev 254649)
+++ branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.cpp 2020-01-15 23:25:12 UTC (rev 254650)
@@ -29,7 +29,9 @@
#include "SharedBuffer.h"
#include
+#include
#include
+#include
#include
namespace WebCore {
@@ -132,6 +134,16 @@
return { element->segment.copyRef(), position - element->beginPosition };
}
+String SharedBuffer::toHexString() const
+{
+StringBuilder stringBuilder;
+for (unsigned byteOffset = 0; byteOffset < size(); byteOffset++) {
+const uint8_t byte = data()[byteOffset];
+stringBuilder.append(pad('0', 2, hex(byte)));
+}
+return stringBuilder.toString();
+}
+
RefPtr SharedBuffer::tryCreateArrayBuffer() const
{
auto arrayBuffer = ArrayBuffer::tryCreateUninitialized(static_cast(size()), sizeof(char));
Modified: branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.h (254649 => 254650)
--- branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.h 2020-01-15 23:07:43 UTC (rev 254649)
+++ branches/safari-610.1.1-branch/Source/WebCore/platform/SharedBuffer.h 2020-01-15 23:25:12 UTC (rev 254650)
@@ -198,6 +198,8 @@
// begin and end take O(1) time, this takes O(log(N)) time.
SharedBufferDataView getSomeData(size_t position) const;
+String toHexString() const;
+
void hintMemoryNotNeededSoon() const;
WTF::Persistence::Decoder decoder() const;
Modified: branches/safari-610.1.1-branch/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp (254649 => 254650)
--- branches/safari-610.1.1-branch/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp 2020-01-15 23:07:43 UTC (rev 254649)
+++ branches/safari-610.1.1-branch/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp 2020-01-15 23:25:12 UTC (rev 254650)
@@ -34,6 +34,7 @@
#include "CDMKeySystemConfiguration.h"
#include "CDMRestrictions.h"
#include "CDMSessionType.h"
+#include "Logging.h"
#include "SharedBuffer.h"
#include
#include
@@ -537,6 +538,35 @@
return adoptRef(new CDMInstanceSessionClearKey());
}
+String CDMInstanceClearKey::Key::keyIDAsString() const
+{
+return makeString("[", keyIDData->toHexString(), "]");
+}
+
+String CDMInstanceClearKey::Key::keyValueAsString() const
+{
+return makeString("[", keyValueData->toHexString(), "]");
+}
+
+bool operator==(const CDMInstanceClearKey::Key& k1, const CDMInstanceClearKey::Key& k2)
+{
+ASSERT(k1.keyIDData);
+ASSERT(k2.keyIDData);
+
+return *k1.keyIDData == *k2.keyIDData;
+}
+
+bool operator<(const CDMInstanceClearKey::Key& k1, const CDMInstanceClearKey::Key& k2)
+{
+ASSERT(k1.keyIDData);
+ASSERT(k2.keyIDData);
+
+if (k1.keyIDData->size() != k2.keyIDData->size())
+return k1.keyIDData->size() < k2.keyIDData->size();
+
+return memcmp(k1.keyIDData->data(), k2.keyIDData->data(), k1.keyIDData->size());
+}
+
void CDMInstanceSessionClearKey::requestLicense(LicenseType, const AtomString& initDataType, Ref&& initData, LicenseCallback&& callback)
{
static uint32_t s_sessionIdValue = 0;
@@ -572,7 +602,6 @@
});
};
-// Parse the response buffer as an JSON object.
RefPtr root = parseJSONObject(response);
if (!root) {
dispatchCallback(false, WTF::nullopt, SuccessValue::Failed);
@@ -579,65 +608,46 @@
return;
}
-// Parse the response using 'license' formatting, if possible.
+LOG(EME, "EME - ClearKey - updating license for session %s", sessionId.utf8().data());
+
if (auto decodedKeys = parseLicenseFormat(*root)) {
//
[webkit-changes] [254652] trunk
Title: [254652] trunk
Revision 254652
Author cdu...@apple.com
Date 2020-01-15 15:55:04 -0800 (Wed, 15 Jan 2020)
Log Message
Regression(r253213) Load hang and high CPU usage when trying to load myuhc.com
https://bugs.webkit.org/show_bug.cgi?id=206315
Reviewed by Geoffrey Garen.
Source/WebCore:
Starting in r253213, we now throw when trying to do a sync XHR during unload. Unfortunately, this is confusing the script
on myuhc.com and it ends up retrying the sync XHR in a tight loop. To address the issue, I am putting in a safety net which
ignores calls to XMLHttpRequest.send() instead of throwing, once we've reached 5 sync XHR failures during unload.
Throwing is useful because this gives a change for Web authors to fall back to using Beacon API or Fetch KeepAlive if the
sync XHR fails. There is already code out there doing just that. You could imagine content doing more than one sync XHR
during unload, each one with a good beacon API fallback. For this reason, I put in a limit of 5 sync failures before
we stop throwing. Having a limit is important to break bad loops when the content simply retries the same sync XHR load
when the sync XHR send() call throws.
Tests: fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html
fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload.html
* dom/Document.cpp:
(WebCore::Document::didRejectSyncXHRDuringPageDismissal):
(WebCore::Document::shouldIgnoreSyncXHRs const):
* dom/Document.h:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::prepareToSend):
LayoutTests:
Add layout test coverage.
* fast/xmlhttprequest/resources/xmlhttprequest-multiple-sync-xhr-during-unload-iframe.html: Added.
* fast/xmlhttprequest/resources/xmlhttprequest-sync-xhr-failure-loop-during-unload-iframe.html: Added.
* fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html: Added.
* fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
Added Paths
trunk/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-multiple-sync-xhr-during-unload-iframe.html
trunk/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-sync-xhr-failure-loop-during-unload-iframe.html
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload.html
Diff
Modified: trunk/LayoutTests/ChangeLog (254651 => 254652)
--- trunk/LayoutTests/ChangeLog 2020-01-15 23:25:16 UTC (rev 254651)
+++ trunk/LayoutTests/ChangeLog 2020-01-15 23:55:04 UTC (rev 254652)
@@ -1,3 +1,20 @@
+2020-01-15 Chris Dumez
+
+Regression(r253213) Load hang and high CPU usage when trying to load myuhc.com
+https://bugs.webkit.org/show_bug.cgi?id=206315
+
+
+Reviewed by Geoffrey Garen.
+
+Add layout test coverage.
+
+* fast/xmlhttprequest/resources/xmlhttprequest-multiple-sync-xhr-during-unload-iframe.html: Added.
+* fast/xmlhttprequest/resources/xmlhttprequest-sync-xhr-failure-loop-during-unload-iframe.html: Added.
+* fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-expected.txt: Added.
+* fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html: Added.
+* fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload-expected.txt: Added.
+* fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload.html: Added.
+
2020-01-15 Commit Queue
Unreviewed, rolling out r254576.
Added: trunk/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-multiple-sync-xhr-during-unload-iframe.html (0 => 254652)
--- trunk/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-multiple-sync-xhr-during-unload-iframe.html (rev 0)
+++ trunk/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-multiple-sync-xhr-during-unload-iframe.html 2020-01-15 23:55:04 UTC (rev 254652)
@@ -0,0 +1,22 @@
+
+let xhrExceptionCount = 0;
+
+function doSyncXHR(i)
+{
+try {
+var xhr = new XMLHttpRequest();
+xhr.open("GET", "xmlhttprequest-responsetype-json.json?" + i, false);
+xhr.send(null);
+} catch(e) {
+xhrExceptionCount++;
+
[webkit-changes] [254655] trunk/Source/WebKitLegacy/ios
Title: [254655] trunk/Source/WebKitLegacy/ios
Revision 254655
Author timothy_hor...@apple.com
Date 2020-01-15 16:56:23 -0800 (Wed, 15 Jan 2020)
Log Message
WebKit should not expose a unprefixed CGRectValue category method on NSValue
https://bugs.webkit.org/show_bug.cgi?id=206297
Reviewed by Wenson Hsieh.
* WebView/WebPDFViewPlaceholder.mm:
(-[NSValue CGRectValue]): Deleted.
Modified Paths
trunk/Source/WebKitLegacy/ios/ChangeLog
trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm
Diff
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (254654 => 254655)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2020-01-16 00:35:55 UTC (rev 254654)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2020-01-16 00:56:23 UTC (rev 254655)
@@ -1,3 +1,14 @@
+2020-01-15 Tim Horton
+
+WebKit should not expose a unprefixed CGRectValue category method on NSValue
+https://bugs.webkit.org/show_bug.cgi?id=206297
+
+
+Reviewed by Wenson Hsieh.
+
+* WebView/WebPDFViewPlaceholder.mm:
+(-[NSValue CGRectValue]): Deleted.
+
2020-01-03 Chris Dumez
Add support for DragEvent
Modified: trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm (254654 => 254655)
--- trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm 2020-01-16 00:35:55 UTC (rev 254654)
+++ trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm 2020-01-16 00:56:23 UTC (rev 254655)
@@ -71,7 +71,7 @@
return [NSValue valueWithBytes: objCType:@encode(CGRect)];
}
-- (CGRect)CGRectValue
+- (CGRect)_web_CGRectValue
{
CGRect result;
[self getValue:];
@@ -458,7 +458,7 @@
if ((!pageNumber) || (pageNumber > [_pageRects count]))
return CGRectNull;
-return [[_pageRects objectAtIndex:pageNumber - 1] CGRectValue];
+return [[_pageRects objectAtIndex:pageNumber - 1] _web_CGRectValue];
}
- (void)simulateClickOnLinkToURL:(NSURL *)URL
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254656] trunk/Source/WebKit
Title: [254656] trunk/Source/WebKit
Revision 254656
Author ross.kirsl...@sony.com
Date 2020-01-15 17:17:11 -0800 (Wed, 15 Jan 2020)
Log Message
[PlayStation] Add stubs for WebEditorClient
https://bugs.webkit.org/show_bug.cgi?id=206320
Reviewed by Don Olmstead.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (254655 => 254656)
--- trunk/Source/WebKit/ChangeLog 2020-01-16 00:56:23 UTC (rev 254655)
+++ trunk/Source/WebKit/ChangeLog 2020-01-16 01:17:11 UTC (rev 254656)
@@ -1,3 +1,12 @@
+2020-01-15 Ross Kirsling
+
+[PlayStation] Add stubs for WebEditorClient
+https://bugs.webkit.org/show_bug.cgi?id=206320
+
+Reviewed by Don Olmstead.
+
+* WebProcess/WebCoreSupport/WebEditorClient.cpp:
+
2020-01-15 Don Olmstead
Share WebInspector stubs for ports without local inspection
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp (254655 => 254656)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp 2020-01-16 00:56:23 UTC (rev 254655)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp 2020-01-16 01:17:11 UTC (rev 254656)
@@ -360,7 +360,7 @@
return m_page->requestDOMPasteAccess(originIdentifier);
}
-#if PLATFORM(WIN)
+#if !PLATFORM(COCOA) && !USE(GLIB)
void WebEditorClient::handleKeyboardEvent(KeyboardEvent& event)
{
if (m_page->handleEditingKeyboardEvent(event))
@@ -371,7 +371,7 @@
{
notImplemented();
}
-#endif // PLATFORM(WIN)
+#endif // !PLATFORM(COCOA) && !USE(GLIB)
void WebEditorClient::textFieldDidBeginEditing(Element* element)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254661] trunk/Source/WebCore
Title: [254661] trunk/Source/WebCore
Revision 254661
Author za...@apple.com
Date 2020-01-15 18:23:39 -0800 (Wed, 15 Jan 2020)
Log Message
[LFC][IFC] LineBreaker::shouldWrapInlineContent should take the candidate content width
https://bugs.webkit.org/show_bug.cgi?id=206305
Reviewed by Antti Koivisto.
We already have the width information of the candidate runs. Let's not loop through the runs just to re-collect the logical width.
~3% progression on PerformanceTests/Layout/line-layout-simple.html.
* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
(WebCore::Layout::ContinuousContent::ContinuousContent):
* layout/inlineformatting/InlineLineBreaker.h:
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineCandidateContent::inlineContentLogicalWidth const):
(WebCore::Layout::LineCandidateContent::append):
(WebCore::Layout::LineCandidateContent::reset):
(WebCore::Layout::LineLayoutContext::tryAddingInlineItems):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.h
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (254660 => 254661)
--- trunk/Source/WebCore/ChangeLog 2020-01-16 02:09:56 UTC (rev 254660)
+++ trunk/Source/WebCore/ChangeLog 2020-01-16 02:23:39 UTC (rev 254661)
@@ -1,3 +1,25 @@
+2020-01-15 Zalan Bujtas
+
+[LFC][IFC] LineBreaker::shouldWrapInlineContent should take the candidate content width
+https://bugs.webkit.org/show_bug.cgi?id=206305
+
+
+Reviewed by Antti Koivisto.
+
+We already have the width information of the candidate runs. Let's not loop through the runs just to re-collect the logical width.
+~3% progression on PerformanceTests/Layout/line-layout-simple.html.
+
+* layout/inlineformatting/InlineLineBreaker.cpp:
+(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
+(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
+(WebCore::Layout::ContinuousContent::ContinuousContent):
+* layout/inlineformatting/InlineLineBreaker.h:
+* layout/inlineformatting/LineLayoutContext.cpp:
+(WebCore::Layout::LineCandidateContent::inlineContentLogicalWidth const):
+(WebCore::Layout::LineCandidateContent::append):
+(WebCore::Layout::LineCandidateContent::reset):
+(WebCore::Layout::LineLayoutContext::tryAddingInlineItems):
+
2020-01-15 Commit Queue
Unreviewed, rolling out r254565.
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp (254660 => 254661)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp 2020-01-16 02:09:56 UTC (rev 254660)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp 2020-01-16 02:23:39 UTC (rev 254661)
@@ -50,8 +50,20 @@
return whitespace == WhiteSpace::Pre || whitespace == WhiteSpace::PreWrap || whitespace == WhiteSpace::BreakSpaces;
}
+static inline Optional lastWrapOpportunityIndex(const LineBreaker::RunList& runList)
+{
+// no_wrapyes wrapno_wrap.
+// [container start][no_wrap][container end][container start][yes] <- continuous content
+// [ ] <- continuous content
+// [wrap][container end][container start][no_wrap][container end] <- continuous content
+// Return #0 as the index where the second continuous content can wrap at.
+ASSERT(!runList.isEmpty());
+auto lastItemIndex = runList.size() - 1;
+return isWrappingAllowed(runList[lastItemIndex].inlineItem.style()) ? makeOptional(lastItemIndex) : WTF::nullopt;
+}
+
struct ContinuousContent {
-ContinuousContent(const LineBreaker::RunList&);
+ContinuousContent(const LineBreaker::RunList&, InlineLayoutUnit contentLogicalWidth);
const LineBreaker::RunList& runs() const { return m_runs; }
bool isEmpty() const { return m_runs.isEmpty(); }
@@ -64,7 +76,6 @@
bool hasTrailingCollapsibleContent() const { return !!m_trailingCollapsibleContent.width; }
bool isTrailingContentFullyCollapsible() const { return m_trailingCollapsibleContent.isFullyCollapsible; }
-Optional lastWrapOpportunityIndex() const;
Optional firstTextRunIndex() const;
Optional lastContentRunIndex() const;
@@ -104,40 +115,44 @@
return whitespace == WhiteSpace::Normal || whitespace == WhiteSpace::NoWrap || whitespace == WhiteSpace::PreWrap || whitespace == WhiteSpace::PreLine;
}
-LineBreaker::Result LineBreaker::shouldWrapInlineContent(const RunList& candidateRuns, const LineStatus& lineStatus)
+LineBreaker::Result LineBreaker::shouldWrapInlineContent(const RunList& candidateRuns, InlineLayoutUnit candidateContentLogicalWidth, const LineStatus& lineStatus)
{
-auto candidateContent = ContinuousContent { candidateRuns };
-
[webkit-changes] [254641] trunk/Source/WebCore
Title: [254641] trunk/Source/WebCore
Revision 254641
Author ross.kirsl...@sony.com
Date 2020-01-15 15:05:22 -0800 (Wed, 15 Jan 2020)
Log Message
Unreviewed build fix for ENABLE_ACCESSIBILITY=OFF following r254566.
* accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::wrapper const):
(WebCore::AXCoreObject::setWrapper):
Remove invalid override specifiers.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (254640 => 254641)
--- trunk/Source/WebCore/ChangeLog 2020-01-15 22:48:09 UTC (rev 254640)
+++ trunk/Source/WebCore/ChangeLog 2020-01-15 23:05:22 UTC (rev 254641)
@@ -1,3 +1,12 @@
+2020-01-15 Ross Kirsling
+
+Unreviewed build fix for ENABLE_ACCESSIBILITY=OFF following r254566.
+
+* accessibility/AccessibilityObjectInterface.h:
+(WebCore::AXCoreObject::wrapper const):
+(WebCore::AXCoreObject::setWrapper):
+Remove invalid override specifiers.
+
2020-01-15 Simon Fraser
Unreviewed cleanup.
Modified: trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h (254640 => 254641)
--- trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h 2020-01-15 22:48:09 UTC (rev 254640)
+++ trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h 2020-01-15 23:05:22 UTC (rev 254641)
@@ -1079,8 +1079,8 @@
AccessibilityObjectWrapper* wrapper() const { return m_wrapper.get(); }
void setWrapper(AccessibilityObjectWrapper* wrapper) { m_wrapper = wrapper; }
#else
-AccessibilityObjectWrapper* wrapper() const override { return nullptr; }
-void setWrapper(AccessibilityObjectWrapper*) override { }
+AccessibilityObjectWrapper* wrapper() const { return nullptr; }
+void setWrapper(AccessibilityObjectWrapper*) { }
#endif
virtual void overrideAttachmentParent(AXCoreObject* parent) = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254658] trunk/Source/WebKit
Title: [254658] trunk/Source/WebKit
Revision 254658
Author ross.kirsl...@sony.com
Date 2020-01-15 17:43:26 -0800 (Wed, 15 Jan 2020)
Log Message
[PlayStation] Add stub for WebPopupMenu::setUpPlatformData
https://bugs.webkit.org/show_bug.cgi?id=206323
Reviewed by Don Olmstead.
* SourcesGTK.txt:
* SourcesWPE.txt:
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Removed.
* WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp: Removed.
Bring GTK/WPE stub down for broader use.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesGTK.txt
trunk/Source/WebKit/SourcesWPE.txt
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp
Removed Paths
trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (254657 => 254658)
--- trunk/Source/WebKit/ChangeLog 2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/ChangeLog 2020-01-16 01:43:26 UTC (rev 254658)
@@ -1,5 +1,20 @@
2020-01-15 Ross Kirsling
+[PlayStation] Add stub for WebPopupMenu::setUpPlatformData
+https://bugs.webkit.org/show_bug.cgi?id=206323
+
+Reviewed by Don Olmstead.
+
+* SourcesGTK.txt:
+* SourcesWPE.txt:
+* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
+(WebKit::WebPopupMenu::setUpPlatformData):
+* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Removed.
+* WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp: Removed.
+Bring GTK/WPE stub down for broader use.
+
+2020-01-15 Ross Kirsling
+
[PlayStation] Add stubs for WebEditorClient
https://bugs.webkit.org/show_bug.cgi?id=206320
Modified: trunk/Source/WebKit/SourcesGTK.txt (254657 => 254658)
--- trunk/Source/WebKit/SourcesGTK.txt 2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/SourcesGTK.txt 2020-01-16 01:43:26 UTC (rev 254658)
@@ -404,7 +404,6 @@
WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp
WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp
WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp
-WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp
WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
Modified: trunk/Source/WebKit/SourcesWPE.txt (254657 => 254658)
--- trunk/Source/WebKit/SourcesWPE.txt 2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/SourcesWPE.txt 2020-01-16 01:43:26 UTC (rev 254658)
@@ -243,7 +243,6 @@
WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp
WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp
-WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp
WebProcess/WebPage/AcceleratedSurface.cpp
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp (254657 => 254658)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp 2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp 2020-01-16 01:43:26 UTC (rev 254658)
@@ -28,6 +28,7 @@
#include "WebPageProxyMessages.h"
#include "WebProcess.h"
#include
+#include
#include
namespace WebKit {
@@ -136,4 +137,11 @@
{
}
+#if !PLATFORM(COCOA) && !PLATFORM(WIN)
+void WebPopupMenu::setUpPlatformData(const WebCore::IntRect&, PlatformPopupMenuData&)
+{
+notImplemented();
+}
+#endif
+
} // namespace WebKit
Deleted: trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp (254657 => 254658)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp 2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp 2020-01-16 01:43:26 UTC (rev 254658)
@@ -1,41 +0,0 @@
-/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
- * Portions Copyright (c) 2010 Motorola Mobility, Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- *
[webkit-changes] [254659] trunk/Source/WebCore
Title: [254659] trunk/Source/WebCore Revision 254659 Author commit-qu...@webkit.org Date 2020-01-15 18:00:16 -0800 (Wed, 15 Jan 2020) Log Message Keep RefPtr instead of raw pointer to message queue on WebCoreResourceHandleAsOperationQueueDelegate https://bugs.webkit.org/show_bug.cgi?id=206261 Patch by Alex Christensen on 2020-01-15 Reviewed by David Kilzer. There's no reason to keep a raw pointer when we can keep a smart pointer. This will make this more robust against someone forgetting to clear this pointer value. * platform/network/ResourceHandle.h: * platform/network/SynchronousLoaderClient.cpp: (WebCore::SynchronousLoaderClient::SynchronousLoaderClient): (WebCore::SynchronousLoaderClient::didFinishLoading): (WebCore::SynchronousLoaderClient::didFail): * platform/network/SynchronousLoaderClient.h: (WebCore::SynchronousLoaderMessageQueue::create): (WebCore::SynchronousLoaderMessageQueue::append): (WebCore::SynchronousLoaderMessageQueue::kill): (WebCore::SynchronousLoaderMessageQueue::killed const): (WebCore::SynchronousLoaderMessageQueue::waitForMessage): * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::makeDelegate): * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h: * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: (-[WebCoreResourceHandleAsOperationQueueDelegate callFunctionOnMainThread:]): (-[WebCoreResourceHandleAsOperationQueueDelegate initWithHandle:messageQueue:]): (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/ResourceHandle.h trunk/Source/WebCore/platform/network/ResourceHandleInternal.h trunk/Source/WebCore/platform/network/SynchronousLoaderClient.cpp trunk/Source/WebCore/platform/network/SynchronousLoaderClient.h trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp trunk/Source/WebCore/platform/network/curl/CurlRequest.h trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm Diff Modified: trunk/Source/WebCore/ChangeLog (254658 => 254659) --- trunk/Source/WebCore/ChangeLog 2020-01-16 01:43:26 UTC (rev 254658) +++ trunk/Source/WebCore/ChangeLog 2020-01-16 02:00:16 UTC (rev 254659) @@ -1,3 +1,33 @@ +2020-01-15 Alex Christensen + +Keep RefPtr instead of raw pointer to message queue on WebCoreResourceHandleAsOperationQueueDelegate +https://bugs.webkit.org/show_bug.cgi?id=206261 + + +Reviewed by David Kilzer. + +There's no reason to keep a raw pointer when we can keep a smart pointer. +This will make this more robust against someone forgetting to clear this pointer value. + +* platform/network/ResourceHandle.h: +* platform/network/SynchronousLoaderClient.cpp: +(WebCore::SynchronousLoaderClient::SynchronousLoaderClient): +(WebCore::SynchronousLoaderClient::didFinishLoading): +(WebCore::SynchronousLoaderClient::didFail): +* platform/network/SynchronousLoaderClient.h: +(WebCore::SynchronousLoaderMessageQueue::create): +(WebCore::SynchronousLoaderMessageQueue::append): +(WebCore::SynchronousLoaderMessageQueue::kill): +(WebCore::SynchronousLoaderMessageQueue::killed const): +(WebCore::SynchronousLoaderMessageQueue::waitForMessage): +* platform/network/mac/ResourceHandleMac.mm: +(WebCore::ResourceHandle::makeDelegate): +* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h: +* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: +(-[WebCoreResourceHandleAsOperationQueueDelegate callFunctionOnMainThread:]): +(-[WebCoreResourceHandleAsOperationQueueDelegate initWithHandle:messageQueue:]): +(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]): + 2020-01-15 Said Abou-Hallawa [SVG2]: Implement support for the 'pathLength' attribute Modified: trunk/Source/WebCore/platform/network/ResourceHandle.h (254658 => 254659) --- trunk/Source/WebCore/platform/network/ResourceHandle.h 2020-01-16 01:43:26 UTC (rev 254658) +++ trunk/Source/WebCore/platform/network/ResourceHandle.h 2020-01-16 02:00:16 UTC (rev 254659) @@ -86,6 +86,7 @@ class ResourceRequest; class ResourceResponse; class SharedBuffer; +class SynchronousLoaderMessageQueue; class Timer; #if USE(CURL) @@ -123,7 +124,7 @@ #if
