Re: [Wikitech-l] Welcoming Jeremy Postlethwaite
On 25/08/11 00:15, Alolita Sharma wrote: snip Drop by and say hello to Jeremy online or in person at WMF in San Francisco. Looks like yet another ultra high IQ to join the team :-) Have a good code ! -- Ashar hashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki and a standard template library
On Sat, Aug 20, 2011 at 11:31 PM, go moko gom...@yahoo.com wrote: So, if I can express some simple opinion, perhaps what would be useful is a mean to easily export/import a template and all those which are necessary for it to work properly. I don't know if such a tool exist, but could it bea (partial) solution? This should not be too hard to program - what is needed is that one exports/imports not only the template but also all templates included in it. There is already functionality to get this list - they are shown on the edit page. Thus, all that is needed is some kind of interface to export this page and all templates directly or indirectly included in it. Also useful in case someone wants to fork with only a subset of the pages. -- André Engels, andreeng...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95436]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95436. Old Status: ok New Status: new User Raymond also posted a comment on MediaWiki.r95436. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95436#c21442 Commit summary: Partially revert r92245 per r92245 CR. Comment: Marking with 1.18: this revert is after 1.18 branch point. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki and a standard template library
On 25 August 2011 08:28, Andre Engels andreeng...@gmail.com wrote: On Sat, Aug 20, 2011 at 11:31 PM, go moko gom...@yahoo.com wrote: So, if I can express some simple opinion, perhaps what would be useful is a mean to easily export/import a template and all those which are necessary for it to work properly. I don't know if such a tool exist, but could it bea (partial) solution? This should not be too hard to program - what is needed is that one exports/imports not only the template but also all templates included in it. There is already functionality to get this list - they are shown on the edit page. Thus, all that is needed is some kind of interface to export this page and all templates directly or indirectly included in it. You mean like… checking the “Include templates” box on Special:Export? But the problem is more difficult than that. MediaWiki has no chance of knowing which templates are “necessary for it to work properly”, it can only detect those that are _actually used_ in a specific use case (as you say, those which are shown on the edit page), which is just a subset of those required in general. -- [[cs:User:Mormegil | Petr Kadlec]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95396. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21443 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Seen on Translatewiki: [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globalfileusage when searching for special page aliases for GlobalFileUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globaltemplateusage when searching for special page aliases for GlobalTemplateUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 [25-Aug-2011 08:03:08] PHP Fatal error: Call to undefined method Xml::hidden() in /www/w/includes/specials/SpecialGlobalFileUsage.php on line 46 [25-Aug-2011 08:03:09] PHP Fatal error: Call to undefined method Xml::hidden() in /www/w/includes/specials/SpecialGlobalTemplateUsage.php on line 49 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95461]: New comment added
User Raymond posted a comment on MediaWiki.r95461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95461#c21444 Commit summary: Fix calls to undefined Xml::hidden r95396 Comment: Is the removal of this line intended? Not mentioned in the commit message - $offset = $query-getOffsetString( ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95327]: Revision status changed
User Catrope changed the status of MediaWiki.r95327. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95327 Commit summary: (bug 30335) Fix for HTMLForms using GET breaking when non-friendly URLs are used ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki and a standard template library
On Thu, Aug 25, 2011 at 9:23 AM, Petr Kadlec petr.kad...@gmail.com wrote: You mean like… checking the “Include templates” box on Special:Export? I guess that's what I mean, it's been a few years since I last saw Special:Export - long enough that I have no idea whether that box is from before or after that time. But the problem is more difficult than that. MediaWiki has no chance of knowing which templates are “necessary for it to work properly”, it can only detect those that are _actually used_ in a specific use case (as you say, those which are shown on the edit page), which is just a subset of those required in general. No, but it does at least mean that exporting and importing any single template should be possible in a very short time indeed. -- André Engels, andreeng...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki and a standard template library
On 25 August 2011 10:47, Andre Engels andreeng...@gmail.com wrote:
But the problem is more difficult than that. MediaWiki has no chance
of knowing which templates are “necessary for it to work properly”, it
can only detect those that are _actually used_ in a specific use case
(as you say, those which are shown on the edit page), which is just a
subset of those required in general.
No, but it does at least mean that exporting and importing any single
template should be possible in a very short time indeed.
Well… no, generally not. Check for instance {{flagicon}}. There is no
way Special:Export could recognize it is required to export all 2556
(!) templates in [[Special:Prefixindex/Template:Country data]].
Of course, this does help for “simpler” template systems.
-- Petr Kadlec / Mormegil
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95462]: New comment added
User Raymond posted a comment on MediaWiki.r95462. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95462#c21445 Commit summary: Hopefully fix [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globalfileusage when searching for special page aliases for GlobalFileUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globaltemplateusage when searching for special page aliases for GlobalTemplateUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 r95396 Comment: Does not look like helpful: [10:37] [siebrand] updated translatewiki.net to r95462 [11:03] rakkaus (3 lines skipped) [25-Aug-2011 09:02:55] PHP Notice: Found alias defined for Globalfileusage when searching for special page aliases for GlobalFileUsage. Case mismatch? [Called fromSpecialPage::getTitl eFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki and a standard template library
It could frequently come out a big problem of collisions with existing templates with different code. I feel that synonimous templates, with different features, are a very subtle and harmful touble. This raises the long-standing problem of redundancy and coherence so deeply afflicting anything into wiki contents, but extension tags. It's impossible to leave to the willingness of bold, sometimes unexperienced users, the hard task to align templates. Exactly the same, for experienced users. But perhaps, a SharedTemplatesExtension could be built, ensuring a common repository of template routines, matched with common names. I can't imagine how this can be done. :-( Alex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95396]: Revision status changed
User Raymond changed the status of MediaWiki.r95396. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91734]: Revision status changed
User Catrope changed the status of MediaWiki.r91734. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91734 Commit summary: Migrate skins/common/search.js functionality to mediawiki.special.search.js. Make JS unobtrusive. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85951]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r85951. Old Status: new New Status: resolved User Catrope also posted a comment on MediaWiki.r85951. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85951#c21447 Commit summary: Implement user-is-blocked and wiki-is-read-only as exceptions. Comment: $user-mBlock was already being accessed by the same function under the same circumstances. This revision does not change this at all. You're right that it sucks and should be rewritten to use an accessor (which was attempted in r93237 and reverted due to breaking tests) but it's unrelated to the merits of this revision. Marking resolved because this is fine other than that UserBlockedError makes Chad feel icky, Brion raised a good but unrelated point and there was a typo in a message key that was fixed in r93303. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85994]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r85994. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r85994. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85994#c21448 Commit summary: Unbundle OutputPage::showErrorPage() in Exception.php to allow ErrorPageError objects to be passed a Message object for a more complicated display. Comment: Ping, it's been two weeks and no answer. I'm setting this back to fixme because of the code duplication. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85994]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r85994. Old Status: fixme New Status: resolved User Catrope also posted a comment on MediaWiki.r85994. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85994#c21449 Commit summary: Unbundle OutputPage::showErrorPage() in Exception.php to allow ErrorPageError objects to be passed a Message object for a more complicated display. Comment: Meh, never mind, eliminating the code duplication was easy. Done in r95470. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95472]: Revision status changed
User Catrope changed the status of MediaWiki.r95472. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95472 Commit summary: MFT r95471: (bug 30504) Core namespaces for Pali (pi). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95461]: New comment added
User Reedy posted a comment on MediaWiki.r95461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95461#c21450 Commit summary: Fix calls to undefined Xml::hidden r95396 Comment: Yeah, just removed it as the variable was unused ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95470]: Revision status changed
User Reedy changed the status of MediaWiki.r95470. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95470 Commit summary: Followup r85994: eliminate code duplication introduced by this revision, instead make OutputPage::showErrorPage() accept Message objects ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95470]: New comment added
User Catrope posted a comment on MediaWiki.r95470. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95470#c21452 Commit summary: Followup r85994: eliminate code duplication introduced by this revision, instead make OutputPage::showErrorPage() accept Message objects Comment: Fixed in r95475. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95475]: Revision status changed
User Siebrand changed the status of MediaWiki.r95475. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95475 Commit summary: Fix stupid copypaste mistake in r95470 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88972]: New comment added
User Siebrand posted a comment on MediaWiki.r88972. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88972#c21453 Commit summary: A couple of tweaks to SecurePoll: * Implement must-be-registered-before as a simple condition * Standardise format of list view table, with navigation links both above and below the table * Parse wikitext in radio-range column labels These have been sitting as core hacks on one of my production wikis for about two years now... :-) Comment: Addressed in r95476. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88972]: Revision status changed
User Siebrand changed the status of MediaWiki.r88972. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88972 Commit summary: A couple of tweaks to SecurePoll: * Implement must-be-registered-before as a simple condition * Standardise format of list view table, with navigation links both above and below the table * Parse wikitext in radio-range column labels These have been sitting as core hacks on one of my production wikis for about two years now... :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95445]: New comment added
User Krinkle posted a comment on MediaWiki.r95445. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95445#c21454 Commit summary: (bug 30499) Create jQuery replacements for injectSpinner and removeSpinner Comment: I had the same thought yesterday, see r95448. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95477]: Revision status changed
User Reedy changed the status of MediaWiki.r95477. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95477 Commit summary: Localization update for he. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95465]: Revision status changed
User Platonides changed the status of MediaWiki.r95465. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95465 Commit summary: Remove illegal Windows filesystem character from filename (follow-up r95418). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79941]: New comment added
User Catrope posted a comment on MediaWiki.r79941. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/79941#c21455 Commit summary: Follow up to r79905. Disabling resource inclusion of LQT api. Don't know how to fix this properly, seems undocumented for Resourceloader. Comment: Apparently the inline edit for needs extra JS/messages to be loaded. Previously, the JS URLs and messages were served in the API response, but now that everything is RLified the API response should just list module names that the client can then load. However, I'm not familiar enough with LQT to figure out which modules should be loaded here, so I can't fix this by myself. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95436]: Revision status changed
User Catrope changed the status of MediaWiki.r95436. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95436 Commit summary: Partially revert r92245 per r92245 CR. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95327]: New comment added
User Catrope posted a comment on MediaWiki.r95327. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95327#c21456 Commit summary: (bug 30335) Fix for HTMLForms using GET breaking when non-friendly URLs are used Comment: I was thinking maybe we should just set title= unconditionally. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95470]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95470. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95470 Commit summary: Followup r85994: eliminate code duplication introduced by this revision, instead make OutputPage::showErrorPage() accept Message objects ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95462]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95462. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95462 Commit summary: Hopefully fix [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globalfileusage when searching for special page aliases for GlobalFileUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globaltemplateusage when searching for special page aliases for GlobalTemplateUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 r95396 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95461]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95461. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95461 Commit summary: Fix calls to undefined Xml::hidden r95396 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95463]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r95463. Old Status: deferred New Status: ok User Nikerabbit also posted a comment on MediaWiki.r95463. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95463#c21457 Commit summary: Remove illegal Windows filesystem character from filename (follow-up r95418). Comment: Mime-type looks still incorrect. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94908]: Revision status changed
User Siebrand changed the status of MediaWiki.r94908. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94908 Commit summary: * (bug 30217) Make pt-br a fallback of pt Depends on r94907. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94991]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r94991. Old Status: new New Status: ok User Siebrand also posted a comment on MediaWiki.r94991. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94991#c21458 Commit summary: Fu r94907 - also update localisation cache, which accesses the fallback variable directly Fixes bug 30456 Comment: Issue is not confirmed fixed by the reporter. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94991]: New comment added
User Siebrand posted a comment on MediaWiki.r94991. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94991#c21459 Commit summary: Fu r94907 - also update localisation cache, which accesses the fallback variable directly Fixes bug 30456 Comment: Sorry: Issue is now confirmed fixed by the reporter. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95485]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95485. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95485 Commit summary: Update Wikia MediaWiki extension support. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90362]: Revision status changed
User Reedy changed the status of MediaWiki.r90362. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90362 Commit summary: Follow up r90361 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95075]: New comment added
User Ankitgarg posted a comment on MediaWiki.r95075. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95075#c21460 Commit summary: changing form color Comment: Yes, you are right. I will make this change ASAP. and apologies for not following up earlier. Was new to the CR Tool and the whole svn, hence all this mess. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95076]: New comment added
User Ankitgarg posted a comment on MediaWiki.r95076. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95076#c21461 Commit summary: changing color of fieldset Comment: Hi, I was quite new to using the svn, hence all this mess. Apologies. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94901]: New comment added
User Ankitgarg posted a comment on MediaWiki.r94901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94901#c21463 Commit summary: adding cosmetic changes. Comment: most of These changes are already fixed. Rest will be fixed soon. Thanks for pointing out. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90668]: New comment added
User Reedy posted a comment on MediaWiki.r90668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90668#c21464 Commit summary: Fix for r86722: pass the message 'dberrortext' unescaped to the output since it contains. I really don't like to pass unescaped messages to the output *sigh* Comment: Can you reproduce this on demand Raymond? If so, could you put a var_dump( $this-fname ); before line 271. I want to know if we should just work around it, or it's being setup incorrectly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95494]: Revision status changed
User ^demon changed the status of MediaWiki.r95494. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95494 Commit summary: added normplot.py ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95492]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95492. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95492 Commit summary: Swap json_encode() for FormatJson::encode() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90668]: New comment added
User Raymond posted a comment on MediaWiki.r90668.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90668#c21465
Commit summary:
Fix for r86722: pass the message 'dberrortext' unescaped to the output since it
contains. I really don't like to pass unescaped messages to the output *sigh*
Comment:
Running same revision as before:
array(1) {
[campaign_id]=
NULL
}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90668]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r90668. Old Status: fixme New Status: ok User Reedy also posted a comment on MediaWiki.r90668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90668#c21466 Commit summary: Fix for r86722: pass the message 'dberrortext' unescaped to the output since it contains. I really don't like to pass unescaped messages to the output *sigh* Comment: Marking ok again after fixing the actual issue in r95495 (which wasn't this rev) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95484]: Revision status changed
User ^demon changed the status of MediaWiki.r95484. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95484 Commit summary: Update punctuation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88252]: Revision status changed
User Reedy changed the status of MediaWiki.r88252. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88252 Commit summary: Remove verboseness (image and infobox) in Special:Contributions for diff size display as added in r88111. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88111]: Revision status changed
User Reedy changed the status of MediaWiki.r88111. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111 Commit summary: * added an option to toggle the display of diff size with a warning message. * in misermode this option is disabled ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88117]: Revision status changed
User Reedy changed the status of MediaWiki.r88117. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88117 Commit summary: * added alternative revison size display if diff size is not selected ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95327]: New comment added
User Johnduhart posted a comment on MediaWiki.r95327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95327#c21467 Commit summary: (bug 30335) Fix for HTMLForms using GET breaking when non-friendly URLs are used Comment: $wgRequest-getVal( 'title' ) is actually set no matter what with a call to $wgRequest-interpolateTitle() in Setup.php on line 436. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95449]: New comment added
User Catrope posted a comment on MediaWiki.r95449. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95449#c21468 Commit summary: Allow update to be passed an empty array for the WHERE condition Comment: This seems wrong? If code$conds/code is an array, won't code$conds != '*'/code be true? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95451]: Revision status changed
User Catrope changed the status of MediaWiki.r95451. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95451 Commit summary: Followup r95332 (bug 30441 fix) -- Roan pointed out that I forgot to do a global replace (d'oh!) Now works with parameters containing multiple spaces. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95332]: Revision status changed
User Catrope changed the status of MediaWiki.r95332. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95332 Commit summary: * (bug 30441) getParamValue must understand + encoding of space $.param() produces query string form encoding using the traditional '+' encoding for space; mediawiki.util.getParamValue() was using only decodeURIComponent() to do unescaping, which is not required by spec to handle '+'. Explicitly replacing '+' with '%20' before the decode nicely resolves this. Added a test case to qunit tests for mediawiki.util module. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95449]: New comment added
User Catrope posted a comment on MediaWiki.r95449.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95449#c21472
Commit summary:
Allow update to be passed an empty array for the WHERE condition
Comment:
Shorter by using strict comparison:
pre
if ( $conds !== array() $conds !== '*' ) {
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95449]: Revision status changed
User ^demon changed the status of MediaWiki.r95449. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95449 Commit summary: Allow update to be passed an empty array for the WHERE condition ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95497]: Revision status changed
User ^demon changed the status of MediaWiki.r95497. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95497 Commit summary: Followup r95449, fix the code to do what it was actually intended to do ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r421]: New comment added
User Khorn (WMF) posted a comment on Wikimedia.r421. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/421#c21473 Commit summary: Now printing raw $msg from queue when pulling from pending_paypal queue rather than try and json_decode it (since it's not actually a json object...). This /used/ to happen in production, although it appears to have stopped at the same time we upgrade Grosley, which incidentally is when I re-deployed the IPN listener - suggesting that it used to be a live hack _ This caused problems for the contribution log auditer as it was searching for transaction data from the raw json objects contained within the raw message output. ARGH. So this has been going on for about a month now, unnoticed. Let this be a lesson: DONT HACK LIVE unless you're prepared to suffer the consequences. FML. Comment: Looks OK to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Ramping up to 1.18 deployment
It looks like we've finally moved ahead of the curve with regard to FIXMEs. Today, Sam Reedy (and others) plowed through some of them and brought us up to where we need to be in order to deploy 1.18 in 3 weeks. We still need to keep up the pace, but we're in a better position now. There is one more area that we need to have work done, though, for 1.18 deployment and that is Bug #29068 (Bugs to be fixed for 1.18 WMF deployment): https://bugzilla.wikimedia.org/29068 In order to close this tracking bug we need to fix the following: https://bugzilla.wikimedia.org/29246 -- API errors occasionally with unknown error 231 https://bugzilla.wikimedia.org/30192 -- Thumbnails of archived images don't get deleted https://bugzilla.wikimedia.org/30352 -- jQuery.makeCollapsible.js should support 'autocollapse', 'innercollapse' and 'outercollapse' options https://bugzilla.wikimedia.org/30384 -- extra newlines in nested templates in tables [parser difference between 1.17 and 1.18] Thanks for any help you can give on these bugs, Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Raymond posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21474 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: Why adding a message in MessagesEn.php instead of removing the one from messages.inc? - 'sp-contributions-showsizediff', +'sp-contributions-showsizediff-warn' = 'This instance has recent changes log limited to $1 . If you use this option, pages not in this log will not be displayed', ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r431]: New comment added
User Khorn (WMF) posted a comment on Wikimedia.r431. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/431#c21475 Commit summary: Modified logging for paypal auditer to try and log to a more sensible location, or fail silently. Comment: This should probably be configurable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Reedy posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21476 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: God know, svn reverted it fine, feel free to delete both messages. I'm away from computer till later ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95043]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r95043. Old Status: fixme New Status: new User Hashar also posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c21477 Commit summary: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to replace the pre look'n feel, removing the first-child last-child selectors. * line numbers are not selected on mouse selection. Makes it easy to copy paste the patch. Note: old code left unchanged. To use it again, change the array_map callback in splitLines from 'parseLine' to 'colorLine'. Comment: Issues fixed by: - r95501 (private - protected) - r95502 (nbsp - #160) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Ramping up to MobileFrontend production switch over
After last weeks successful triage and the large amount of work that everyone has been doing were getting pretty close to having MobileFronted production ready. We've spent the last week not only resolving current bugs but also taking a couple of passes through the code so that its far similar to the rest of our extensions. I think our velocity is pretty good and were shooting to start switching over the week of 9/5. But we still have a couple more bugs that we could use some help with TestMe https://bugzilla.wikimedia.org/show_bug.cgi?id=27718 - Broken file description pages using Wikipedia Mobile Bugs https://bugzilla.wikimedia.org/show_bug.cgi?id=22014 - Caching problems with mobile_main_page https://bugzilla.wikimedia.org/show_bug.cgi?id=29505 - Removing dependance on jQuery for devices using NetFront https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 - MobileFrontend extension outputting invalid HTML in footer Feature https://bugzilla.wikimedia.org/show_bug.cgi?id=30551 - Create a simple feedback option for mobile users Blocking but being worked on https://bugzilla.wikimedia.org/show_bug.cgi?id=29517 - Allow client side folding in Opera Mini https://bugzilla.wikimedia.org/show_bug.cgi?id=30356 - New gateway has broken layout for opera mini Thanks for any help you can give on these bugs --tomasz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Ramping up to 1.18 deployment
On Thu, Aug 25, 2011 at 8:29 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: https://bugzilla.wikimedia.org/29246 -- API errors occasionally with unknown error 231 That one has kind of had my name on it for a while. I've assigned it to myself and will tackle it either tonight or tomorrow morning. https://bugzilla.wikimedia.org/30352 -- jQuery.makeCollapsible.js should support 'autocollapse', 'innercollapse' and 'outercollapse' options Timo? Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Ramping up to MobileFrontend production switch over
And for those wanting to simply track open issues. Here you go https://bugzilla.wikimedia.org/show_bug.cgi?id=30512 --tomasz On Thu, Aug 25, 2011 at 12:10 PM, Tomasz Finc tf...@wikimedia.org wrote: After last weeks successful triage and the large amount of work that everyone has been doing were getting pretty close to having MobileFronted production ready. We've spent the last week not only resolving current bugs but also taking a couple of passes through the code so that its far similar to the rest of our extensions. I think our velocity is pretty good and were shooting to start switching over the week of 9/5. But we still have a couple more bugs that we could use some help with TestMe https://bugzilla.wikimedia.org/show_bug.cgi?id=27718 - Broken file description pages using Wikipedia Mobile Bugs https://bugzilla.wikimedia.org/show_bug.cgi?id=22014 - Caching problems with mobile_main_page https://bugzilla.wikimedia.org/show_bug.cgi?id=29505 - Removing dependance on jQuery for devices using NetFront https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 - MobileFrontend extension outputting invalid HTML in footer Feature https://bugzilla.wikimedia.org/show_bug.cgi?id=30551 - Create a simple feedback option for mobile users Blocking but being worked on https://bugzilla.wikimedia.org/show_bug.cgi?id=29517 - Allow client side folding in Opera Mini https://bugzilla.wikimedia.org/show_bug.cgi?id=30356 - New gateway has broken layout for opera mini Thanks for any help you can give on these bugs --tomasz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94763]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r94763. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94763 Commit summary: Followup fixme for r85302; Removing the wfDeprecated call from new OutputPage in REL1_18 where RequestContext was first introduced. Editing the branch since we want the deprecated call in 1.19 which is in trunk. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r421]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r421. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/421 Commit summary: Now printing raw $msg from queue when pulling from pending_paypal queue rather than try and json_decode it (since it's not actually a json object...). This /used/ to happen in production, although it appears to have stopped at the same time we upgrade Grosley, which incidentally is when I re-deployed the IPN listener - suggesting that it used to be a live hack _ This caused problems for the contribution log auditer as it was searching for transaction data from the raw json objects contained within the raw message output. ARGH. So this has been going on for about a month now, unnoticed. Let this be a lesson: DONT HACK LIVE unless you're prepared to suffer the consequences. FML. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r428]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r428. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/428 Commit summary: Added a way to search logs for a given transaction by looking through the print_r output of contrib arrays in the IPN Listener logs. Previously we just looked trxn ids in JSON objects found in the logs, but do to a live hack getting overwritten after the grosley upgrade, there are no longer contributoin JSON objects showing up in the IPN Listener logs. So this is an alternative way to acheive the same result. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r429]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r429. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/429 Commit summary: Initializing 'fee' and 'net' keys in $trxn if they are not already set to make annoying undefined index notices go away. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r430]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r430. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/430 Commit summary: Adding some more key initialization to quiet down undefined index warnings... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r431]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r431. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/431 Commit summary: Modified logging for paypal auditer to try and log to a more sensible location, or fail silently. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r433]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r433. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/433 Commit summary: * Now properly fetching dirname of log dir to properly open/search through files * Now logging when a match is found from list of txn ids in log files. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r434]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r434. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/434 Commit summary: Partial revert of r433 (the dirname was already part of ...); added function to check for existence of a particular key and any value for an array to avoid doing if( isset([]) strlen( [])) AND avoid getting php errors in strict mode; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r435]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r435. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/435 Commit summary: MFT r388 - r434 - fixes to contrib auditing system to be able to parse print_r output in IPN logs rather than just json objects ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r437]: Revision status changed
User Khorn (WMF) changed the status of Wikimedia.r437. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/437 Commit summary: MFT r387 - r436, picking up changes for improved log handling in paypal audit framework ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Raymond posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21478 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: r95506 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95503]: Revision status changed
User Dantman changed the status of MediaWiki.r95503. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95503 Commit summary: 1.18: partial revert of r94763 -- no extra crap before the PHP starting tag, please. This caused IE's console to be flooded with warnings about how IE changed the document mode from Quirks mode to IE9 mode ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95496. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21479 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: PHP Notice: Undefined property: ContribsPager::$showSizeDiff in /www/w/includes/specials/SpecialContributions.php on line 681 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94856]: Revision status changed
User Awjrichards changed the status of MediaWiki.r94856. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94856 Commit summary: date range for campaign log filter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Ramping up to 1.18 deployment
https://bugzilla.wikimedia.org/30192 -- Thumbnails of archived images don't get deleted I've got my head down in this code. I'll have a go at it. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Ramping up to 1.18 deployment
On Thu, Aug 25, 2011 at 4:42 PM, Russell N. Nelson - rnnelson rnnel...@clarkson.edu wrote: https://bugzilla.wikimedia.org/30192 -- Thumbnails of archived images don't get deleted I've got my head down in this code. I'll have a go at it. I already partially resolved it in r94212. As Bryan points out, the fix is insufficient (and while we're under the hood there, those methods desperately need renaming and better docs). -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93836]: New comment added
User Hashar posted a comment on MediaWiki.r93836. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93836#c21480 Commit summary: Proper UI to add filtered article lists to Selections Comment: You really want to use the resource loader. Makes things easier to handle in the long term. The documentation is at: http://www.mediawiki.org/wiki/ResourceLoader/Documentation/Using_with_extensions Probably need a good 2 hours to read it and another 2 hours to migrate / test. Tip: put the file a new directory named 'modules'. Have a look at the WikiLove extension for a naming scheme. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85392]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r85392. Old Status: fixme New Status: reverted User Happy-melon also posted a comment on MediaWiki.r85392. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85392#c21481 Commit summary: Fix for catchable fatals thrown on invalid titles, follow-up to miscellaneous Context commit pulled out of a hat (let's go for r85252). We must always have a Title object, even on invalid titles, for the purposes of not melting the Skin. The previous method was to make that a barely-existent half-title from SpecialPage::getTitleFor( 'Badtitle' ), where that is a special page which is not actually defined, but exists in the localisation alias lists. Instead, subclass Title as an explicit BadTitle which we can test for. The badtitle error page, which has empty string for its name in all forms, would probably be quite a good test of our JavaScript error checking. Comment: Reverted in r95521. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93417]: New comment added, and revision status changed
User Dantman changed the status of MediaWiki.r93417.
Old Status: new
New Status: fixme
User Dantman also posted a comment on MediaWiki.r93417.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93417#c21482
Commit summary:
follow up r93397 — missed msgid
Comment:
Message-IDs like UserMailer4e56b856ae9867.11102601@http://yourwiki.com are
not valid, the @ portion is supposed to be in a domain format, not a full url.
I think we should probably introduce a new config, something like
$wgEnotifMessageIDDomain, and handle decision on what domain to use with
something like:
source lang=php
if ( $wgEnotifMessageIDDomain ) {
$domain = $wgEnotifMessageIDDomain;
} elseif ( isset($wgSMTP['IDHost']) $wgSMTP['IDHost'] ) {
$domain = $wgSMTP['IDHost'];
} else {
$url = wfParseUrl($wgServer);
$domain = $url['host'];
}
// [...]
return $msgid@$domain;
/source
Also, I don't really know about the 'UserMailer' prepend.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95506]: Revision status changed
User Reedy changed the status of MediaWiki.r95506. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95506 Commit summary: fu r95496: remove the messages really ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95510]: Revision status changed
User Catrope changed the status of MediaWiki.r95510. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95510 Commit summary: show all the possible licenses when configuring a campaign ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93417]: New comment added
User Dantman posted a comment on MediaWiki.r93417. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93417#c21483 Commit summary: follow up r93397 — missed msgid Comment: Rather than a 'UserMailer' prepend, perhaps wfWikiID would make more sense. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95523]: New comment added
User NeilK posted a comment on MediaWiki.r95523. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95523#c21485 Commit summary: merged r95510 from trunk Comment: eh, never mind... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95523]: Revision status changed
User NeilK changed the status of MediaWiki.r95523. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95523 Commit summary: merged r95510 from trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81074]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r81074.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r81074.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81074#c21486
Commit summary:
(bug 235) parser function for conversion of units of measurement.
[[Template:Convert]] on enwiki is a behemoth of a construction that just about
manages to do this sort of conversion, taking {{convert|5|mi|km}} and
outputting 5 miles (8 km), etc. To port this to another wiki requires
copying over three and a half thousand subtemplates. The additional load
produced by including numerous copies of this template is measurable on large
pages on enwiki, and it eats voraciously into the template limits.
This revision introduces {{#convert: 5 mi | km }}, outputting 8 km or
thereabouts. See http://www.mediawiki.org/wiki/User:Happy-melon/Convert for
more details, or look at the examples in the parser tests.
In a very rough profile, comparing 50 calls to {{convert}} verses the same 50
calls to the wrapper template shown at the link above, the parser function
implementation reduces page load time by 72%, preprocessor node count by 83%,
post-expand include size by 86% and template argument size by 97%. More
detailed profiling would probably reveal places where extra caching could
improve performance further.
The primary reason for putting it in ParserFunctions instead of its own
extension is availability: PFs are already available across the cluster, and
it's accepted as an essential extension for any wiki wishing to emulate or
mirror WMF content. One less separate extension installed on the cluster is
one less extension which has to be matched by reusers.
It's still missing a lot of units, which I ran out of patience to copy from
{{convert}}; I thought I'd get some feedback on the infrastructure first.
Comment:
Fixed in r95525.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91432]: New comment added
User SPQRobin posted a comment on MediaWiki.r91432. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91432#c21487 Commit summary: (see bug 29712) Removing the defaultUserOptionOverrides in MessagesXx.php because it is broken (and has been for a long time) and secondly, it is only used for things that can be done otherwise: * 'editfont' = 'sans-serif'; - trivial (can be set in CSS) * 'underline' = 0; by languages written in scripts that are hard to read with underlines - now set in shared.css, which makes it work also when they are used as interface language (note that [lang=xx] is not yet present on wikitext content by default but will be soon as part of my work on RTL improvements) * 'quickbar' = 2; by RTL languages. For this, I introduced a new option (5) that sets left/right according to the directionality of your interface language (and automatic is better than setting it in MessagesXx files!). Note that the broken feature was in this case corrected by CSS flipping, causing preferences to say left while it was actually right. This commit fixes that bug as well. Third, it actually would have made more sense to have it them load for wgLang instead of wgContLang, but that's not possible because wgLang is itself dependent on preferences Comment: editfont: No, I didn't add a replacement because imho it is not needed, as it didn't work (and I don't think it's that important) plus ln.wikipedia has added it on their MediaWiki:Common.css anyway. CSS underlining: Apparently setting the underline option to 'always' has no effect because it is overridden by the CSS. Users can however override the CSS in their personal CSS (or on site CSS). Maybe we should just leave out the CSS I added (or just remove the underline preference as it can/should be done in personal CSS)? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95513]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95513. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95513 Commit summary: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Yesterday's Collection triage
Yesterday I ran a triage with Tomasz Finc, PediaPress (PP), and members of the community on the Collection extension -- the tool that WMF sites use for creating PDFs as well as ZIM (http://openzim.org/) files. While Tomasz and I would have liked to get more MW developers to pick up bugs, I was happy that to actually have some feedback from the PP developers that will help us point to easier problems to solve in the extension. Also, due to personnel changes at PP, no one there had SVN commit access. We were able to begin the process of resolving this and, hopefully as a result, we'll get problems with the extension addressed much more quickly. You can find the lightly commented etherpad for the triage here: http://hexm.de/6b https://bugzilla.wikimedia.org/28206 -- PDF generation does not support Complex Script Wikis We started off talking about several bugs that can all be summed up under #28206. Since we support several different languages with not-very-well supported PDF creation tools and some without PDF creation support at all, we are pushing the limits of the current PDF creation tool. After we discussing this, Volker Haas (a PP developer) said that the underlying tool, ReportLab (http://www.reportlab.com/), was being pushed to its limits and needed to be rewritten from scratch. PP doesn't have the resources to work on this right now, so I updated the bug and assigned it to Tomasz so that he could begin to figure out how we could solve it. https://bugzilla.wikimedia.org/27462 -- noinclude showing in PDF After input from PP, this bug looks like a relatively easy to fix on the MW site. Sumana tagged it as such. https://bugzilla.wikimedia.org/28060 -- Collection extension should not add chapters in reverse order https://bugzilla.wikimedia.org/28118 -- The path to images Chris Kepper (a PP developer) said he would look at these, but also confirmed that #28118 should be easy. https://bugzilla.wikimedia.org/30511 -- Collection extension should place time stamp of revision extracted into the offline file Jessie Wild (Special Projects Manager in the Global Development at WMF) requested this so that it would be easy to date the time a collection was made. The PP developers also confirmed that this one would be easy for a MW developer to pick up -- and it doesn't involve PDF creation, making it a particularly juicy target. https://bugzilla.wikimedia.org/21653 -- Creating a PDF with collection extension does not render the pages tag hook from proofread page extension At first, I didn't understand why this was needed. Luckily helderwiki from ptwikibooks was in the triage and was able help me understand its real need. Ralf Schmitt (a PP developer) said he would work on this if time permits. https://bugzilla.wikimedia.org/22707 -- Cascading page protection for /Print template subpages Since this one can be solved by any MW programmer (but it involves hooks and permissions, so I hesitate to tag it easy), I unassigned it from the PP developers. Ralf Schmitt suggested that some of the concerns about hijacking a page could be addressed by having a See what this page looks like printed mode. https://bugzilla.wikimedia.org/28064 -- Collection extension needs some way to credit original authors of a work Since helderwiki (mybugs on bugzilla) was in the triage, xe took the chance to champion this bug. There is no established established way of tracking non-wiki authors in MW, so there wasn't anything that the Collection extension could do here right now. helderwiki tracked down Bug #27629 (https://bugzilla.wikimedia.org/27629 Summary of page editors/authors) and added it as a dependency for the bug. http://bugzilla.wikimedia.org/27952 -- openZim export should not drop categories There was some confusion about this one. I gave it back to Tomasz so he could get some clarification from ErikM for what was needed. https://bugzilla.wikimedia.org/21504 -- Collection PDF generation doesn't handle ruby elements Can't test since URL doesn't work. Tagged testme and asked if someone could attach a testcase to the bug for future reference. https://bugzilla.wikimedia.org/28061 -- Collection extension doesn't sort chapters when the user clicks on Sort alphabetically Volker Haas said this one was really a UI bug -- something the PP developers were currently working on. https://bugzilla.wikimedia.org/26533 -- Collection extension should accept lists of chapters generated by templates (e.g. expanding templates of a collection page before loading the collection) Resolved WONTFIX by Ralf Schmitt because of the complexity involved. https://bugzilla.wikimedia.org/20616 -- Name of excluded-in-print category cannot start with a namespace name Resolved WONTFIX by
Re: [Wikitech-l] Ramping up to 1.18 deployment
Unfortunately not. The problem is that when you delete all revisions of a file, it deletes the history *first*, getHistory() returns nothing, and the loop never executes. The work-around is to delete archived versions and then finally delete the file itself. The fix ... I'm still working on. Got a bit of a layering problem, but we'll see ... -russ From: wikitech-l-boun...@lists.wikimedia.org [wikitech-l-boun...@lists.wikimedia.org] on behalf of Chad [innocentkil...@gmail.com] Sent: Thursday, August 25, 2011 4:58 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Ramping up to 1.18 deployment On Thu, Aug 25, 2011 at 4:42 PM, Russell N. Nelson - rnnelson rnnel...@clarkson.edu wrote: https://bugzilla.wikimedia.org/30192 -- Thumbnails of archived images don't get deleted I've got my head down in this code. I'll have a go at it. I already partially resolved it in r94212. As Bryan points out, the fix is insufficient (and while we're under the hood there, those methods desperately need renaming and better docs). -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95535]: Revision status changed
User Awjrichards changed the status of MediaWiki.r95535. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95535 Commit summary: updating function name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95536]: Revision status changed
User Reedy changed the status of MediaWiki.r95536. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95536 Commit summary: MFT r95535 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95532]: Revision status changed
User Reedy changed the status of MediaWiki.r95532. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95532 Commit summary: removing UploadWizard to rebranch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95538]: Revision status changed
User Reedy changed the status of MediaWiki.r95538. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95538 Commit summary: Revert r95536, botched merge ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95476]: Revision status changed
User Reedy changed the status of MediaWiki.r95476. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95476 Commit summary: Improve i18n per CR comment on r88972. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
