[MediaWiki-CodeReview] [MediaWiki r110825]: New comment added
Dantman posted a comment on MediaWiki.r110825. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110825#c30539 Commit summary for MediaWiki.r110825: (bug 34237) Regenerate an empty user_token and save to the database when we try to set the user's cookies for login. This allows the entire user_token column to be regenerated after a leak by running `UPDATE user SET user_token = NULL;` and letting the user_tokens be regenerated as users try to log back in. Dantman's comment: Btw, anyone who wants to should feel free to update the user_token schema to remove the `NOT NULL`. This code still works when you use '' instead of NULL so I didn't bother writing a schema update. Especially considering you can't remove a `NOT NULL` without also specifying the column type. Tagged for a 1.19 revert since it's new code and we can just defer it to 1.20. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110762]: Revision status changed
Hashar changed the status of MediaWiki.r110762 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110762 Old status: ok New status: resolved Commit summary for MediaWiki.r110762: Recommit r110758 (again) now that the problem has been fixed in r110761 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110761]: New comment added
Hashar posted a comment on MediaWiki.r110761. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110761#c30540 Commit summary for MediaWiki.r110761: disable wgDebugToolbar when rebuilding file cache credits to iAlex :) Hashar's comment: Setting $wgDebugToolbar = false; was not disabling anything. Fixed with r110829. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110761]: Revision status changed
Hashar changed the status of MediaWiki.r110761 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110761 Old status: ok New status: new Commit summary for MediaWiki.r110761: disable wgDebugToolbar when rebuilding file cache credits to iAlex :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110750]: New comment added
MaxSem posted a comment on MediaWiki.r110750. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110750#c30541 Commit summary for MediaWiki.r110750: Fixed r63018: made it possible to delte half-baked images w/o descriptions, clearer error message MaxSem's comment: * Constants moved in r110831. * Function name was chosen by the almighty IRC cabal. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97658]: New comment added, and revision status changed
Bawolff changed the status of MediaWiki.r97658 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97658#c30542 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r97658: * Made IndexPager extend ContextSource * Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables * Call Linker methods statically * Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser() Bawolff's comment: causes [[bugzilla:34243]] - the pager in Special:Listusers now uses the RequestContext to determine title, which uses the actual title, where before this revision getTitle returned just the base page. This causes issues when the subpage can be a paramter, but can also be selected via a form field ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102160]: New comment added
Schnark posted a comment on MediaWiki.r102160. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160#c30543 Commit summary for MediaWiki.r102160: Merging ReferenceTooltips into Cite step 2: rename/register Schnark's comment: It's not a bug, it's a feature: code$(#cite_note-.C3.84-0)/code gets all elements with id codecite_note-/code and class codeC3/code and code84-0/code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97658]: Revision status changed
Johnduhart changed the status of MediaWiki.r97658 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97658 Old status: fixme New status: resolved Commit summary for MediaWiki.r97658: * Made IndexPager extend ContextSource * Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables * Call Linker methods statically * Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110789]: New comment added
Hashar posted a comment on MediaWiki.r110789. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110789#c30544 Commit summary for MediaWiki.r110789: comment about wgDebugToolbar disabling file cache Hashar's comment: Sure. added $wgShowIPinHeader comment with r110837 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110838]: Revision status changed
GWicke changed the status of MediaWiki.r110838 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110838 Old status: new New status: deferred Commit summary for MediaWiki.r110838: Clean up transform callback interface ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110822]: Revision status changed
Reedy changed the status of MediaWiki.r110822 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110822 Old status: fixme New status: new Commit summary for MediaWiki.r110822: * Fix for r81363: instead of giving a PHP notice when PATH_INFO is missing, show the informative error message used before that revision. * Revert the change to the relevant message made in r102612: it is plain text, not wikitext, a format which does not support protocol-relative URLs. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110828]: New comment added
Reedy posted a comment on MediaWiki.r110828. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110828#c30545 Commit summary for MediaWiki.r110828: Make extension not use global $wgOut where it can avoid it Reedy's comment: I was going to ask if this was 1.18 compatible, but I just won't bother merging it to 1.18wmf1 unless I have to for some reason later ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110826]: New comment added, and revision status changed
Reedy changed the status of MediaWiki.r110826 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110826#c30546 Old Status: new New Status: fixme Commit summary for MediaWiki.r110826: (bug 33551) - Make ShortUrl work properly with protocol relative urls. Reedy's comment: It no worky :( See https://test.wikipedia.org/wiki/Talk:Main_Page/test ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110839]: Revision status changed
GWicke changed the status of MediaWiki.r110839 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110839 Old status: new New status: deferred Commit summary for MediaWiki.r110839: Normalize the title in localurl. 232 tests passing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110828]: New comment added
Bawolff posted a comment on MediaWiki.r110828. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110828#c30547 Commit summary for MediaWiki.r110828: Make extension not use global $wgOut where it can avoid it Bawolff's comment: It is actually compatible with 1.18.1 (or at least should be, didn't test it on that version) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110826]: New comment added
Bawolff posted a comment on MediaWiki.r110826. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110826#c30548 Commit summary for MediaWiki.r110826: (bug 33551) - Make ShortUrl work properly with protocol relative urls. Bawolff's comment: Oh, I only made it work if someone explicitly set a url-relative $wgShortUrlPrefix. I guess i should make it default to a url relative thing to... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110826]: New comment added
Bawolff posted a comment on MediaWiki.r110826. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110826#c30549 Commit summary for MediaWiki.r110826: (bug 33551) - Make ShortUrl work properly with protocol relative urls. Bawolff's comment: Should be fixed in r110842 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110826]: Revision status changed
Bawolff changed the status of MediaWiki.r110826 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110826 Old status: fixme New status: new Commit summary for MediaWiki.r110826: (bug 33551) - Make ShortUrl work properly with protocol relative urls. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110843]: Revision status changed
Reedy changed the status of MediaWiki.r110843 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110843 Old status: new New status: ok Commit summary for MediaWiki.r110843: w/s ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110826]: New comment added
Reedy posted a comment on MediaWiki.r110826. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110826#c30550 Commit summary for MediaWiki.r110826: (bug 33551) - Make ShortUrl work properly with protocol relative urls. Reedy's comment: Looks good, had to purge the page for some reason, but it looks to work now. Thanks :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added, and revision status changed
Reedy changed the status of MediaWiki.r110772 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30551
Old Status: deferred
New Status: fixme
Commit summary for MediaWiki.r110772:
MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well)
Reedy's comment:
Fatal error: Call to undefined method OutputPage::clearAllModules() in
/home/reedy/mediawiki/trunk/extensions/MobileFrontend2/skins/Mobile.php on line
23 Call Stack: 0.0001 640448 1. {main}()
/home/reedy/mediawiki/trunk/phase3/index.php:0 0.1093 5042328 2.
MediaWiki-run() /home/reedy/mediawiki/trunk/phase3/index.php:58 0.1093 5042328
3. MediaWiki-main() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:503
0.2571 11746592 4. MediaWiki-finalCleanup()
/home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:594 0.2572 11746672 5.
OutputPage-output() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:406
0.2647 11940152 6. SkinMobile-outputPage()
/home/reedy/mediawiki/trunk/phase3/includes/OutputPage.php:1982
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110847]: Revision status changed
Reedy changed the status of MediaWiki.r110847 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110847 Old status: new New status: ok Commit summary for MediaWiki.r110847: Fix another typo in r110783 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110783]: Revision status changed
Reedy changed the status of MediaWiki.r110783 to resolved
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110783
Old status: ok
New status: resolved
Commit summary for MediaWiki.r110783:
r110749: use {{int:...}} syntax to ensure sync of wording
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110807]: New comment added
Jack Phoenix posted a comment on MediaWiki.r110807. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110807#c30552 Commit summary for MediaWiki.r110807: Follow-up r100165: * Fixed lack of $db-timestamp() formatting calls * Made a few w/s tweaks (to getAllowedParams, getParamDescription) * Broke some long lines Jack Phoenix's comment: pre - $this-dieUsage( 'Target user is not exists', 'nosuchuser' ); + $this-dieUsage( 'Target user does not exists', 'nosuchuser' ); /pre Still not quite right yet ;-) How about Target user does not '''exist'''? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110825]: New comment added
Reedy posted a comment on MediaWiki.r110825. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110825#c30553 Commit summary for MediaWiki.r110825: (bug 34237) Regenerate an empty user_token and save to the database when we try to set the user's cookies for login. This allows the entire user_token column to be regenerated after a leak by running `UPDATE user SET user_token = NULL;` and letting the user_tokens be regenerated as users try to log back in. Reedy's comment: I thought we were not adding new stuff to be backed out of 1.19 when branched? Except for older commits ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added
MaxSem posted a comment on MediaWiki.r110772. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30554 Commit summary for MediaWiki.r110772: MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well) MaxSem's comment: This thing should be in branches, not a separate extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added
Reedy posted a comment on MediaWiki.r110772. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30555 Commit summary for MediaWiki.r110772: MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well) Reedy's comment: Like AFTv5? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110840]: Revision status changed
MaxSem changed the status of MediaWiki.r110840 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110840 Old status: new New status: ok Commit summary for MediaWiki.r110840: Omg HTTPS Ping r110822 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110837]: Revision status changed
MaxSem changed the status of MediaWiki.r110837 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110837 Old status: new New status: ok Commit summary for MediaWiki.r110837: comment about wgShowIPinHeader disabling file cache ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added
MaxSem posted a comment on MediaWiki.r110772. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30556 Commit summary for MediaWiki.r110772: MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well) MaxSem's comment: Unlike AFT, there are no plans of MF het deployment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Language templates missing from Mediawiki dumps
Hi Mediawiki users, I have experienced a repeatable problem in which after importing a mediawiki database dump, I need to Export the language templates from the live site and import them into my local instance. I use MWDumper to build an SQL file which is read into my local MySql instance. The problem is that the language templates articles are not included in the dump. I am referring to all templates articles that have the following form: Template:EN EN in this could be any language code. This is not limited any particular Mediawiki dump, they all seem to have this problem. That being said, it is not much to simply import the missing templates manually, I was wondering if anyone had experienced this problem or has a quicker solution than the manual import/export. Best Regards, Nathan Day ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added
Johnduhart posted a comment on MediaWiki.r110772. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30557 Commit summary for MediaWiki.r110772: MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well) Johnduhart's comment: It's a full rewrite of an extension. I don't want to develop in a branch and worry about backwards compatibility later. Consider this a new extension. I will work with TWN staff to make sure translations get ported over, however. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110840]: Revision status changed
MarkAHershberger changed the status of MediaWiki.r110840 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110840 Old status: ok New status: new Commit summary for MediaWiki.r110840: Omg HTTPS Ping r110822 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110832]: Revision status changed
MarkAHershberger changed the status of MediaWiki.r110832 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110832 Old status: new New status: ok Commit summary for MediaWiki.r110832: svn ignore images/cache directory ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110833]: Revision status changed
MarkAHershberger changed the status of MediaWiki.r110833 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110833 Old status: new New status: ok Commit summary for MediaWiki.r110833: update Doxyfile default configuration ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110835]: Revision status changed
MarkAHershberger changed the status of MediaWiki.r110835 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110835 Old status: new New status: ok Commit summary for MediaWiki.r110835: Doxygen: show directories The inline trees make it easier to browse the directory hierarchy. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110837]: Revision status changed
MarkAHershberger changed the status of MediaWiki.r110837 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110837 Old status: ok New status: new Commit summary for MediaWiki.r110837: comment about wgShowIPinHeader disabling file cache ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Language templates missing from Mediawiki dumps
I can see that you made the same question 2 years ago and nobody helped you :( on that point. If I remember correctly, recreating the database is uncharted waters just now, and theres a call for anyone tryiing to do it, to document the problems and solutions. To help people tryiing it on the future. Hope somebody can help you :D, or give you some workaround, patch or idea. On 21 May 2010 21:35, Nathan Day nathanryan...@gmail.com wrote: 2. For the articles that do show up, the templates are not transcluding. For an article that has Template:Hat for example, where I can see that the page exists in the db, mediawiki is acting like the template doesn't exist. If anyone has any experience with these kinds of problems or importing database dumps in general, your help would be much appreciated. Thank you! Nathan Day On 7 February 2012 17:51, Nathan Day nathanryan...@gmail.com wrote: Hi Mediawiki users, I have experienced a repeatable problem in which after importing a mediawiki database dump, I need to Export the language templates from the live site and import them into my local instance. I use MWDumper to build an SQL file which is read into my local MySql instance. The problem is that the language templates articles are not included in the dump. I am referring to all templates articles that have the following form: Template:EN EN in this could be any language code. This is not limited any particular Mediawiki dump, they all seem to have this problem. That being said, it is not much to simply import the missing templates manually, I was wondering if anyone had experienced this problem or has a quicker solution than the manual import/export. Best Regards, Nathan Day -- -- ℱin del ℳensaje. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Language templates missing from Mediawiki dumps
It's not uncharted, it's just time consuming and undocumented. -Chad On Feb 7, 2012 12:05 PM, Tei oscar.vi...@gmail.com wrote: I can see that you made the same question 2 years ago and nobody helped you :( on that point. If I remember correctly, recreating the database is uncharted waters just now, and theres a call for anyone tryiing to do it, to document the problems and solutions. To help people tryiing it on the future. Hope somebody can help you :D, or give you some workaround, patch or idea. On 21 May 2010 21:35, Nathan Day nathanryan...@gmail.com wrote: 2. For the articles that do show up, the templates are not transcluding. For an article that has Template:Hat for example, where I can see that the page exists in the db, mediawiki is acting like the template doesn't exist. If anyone has any experience with these kinds of problems or importing database dumps in general, your help would be much appreciated. Thank you! Nathan Day On 7 February 2012 17:51, Nathan Day nathanryan...@gmail.com wrote: Hi Mediawiki users, I have experienced a repeatable problem in which after importing a mediawiki database dump, I need to Export the language templates from the live site and import them into my local instance. I use MWDumper to build an SQL file which is read into my local MySql instance. The problem is that the language templates articles are not included in the dump. I am referring to all templates articles that have the following form: Template:EN EN in this could be any language code. This is not limited any particular Mediawiki dump, they all seem to have this problem. That being said, it is not much to simply import the missing templates manually, I was wondering if anyone had experienced this problem or has a quicker solution than the manual import/export. Best Regards, Nathan Day -- -- ℱin del ℳensaje. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Language templates missing from Mediawiki dumps
You sure those aren't interwiki links and not templates? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r110856]: Revision status changed
Hashar changed the status of MediaWiki.r110856 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110856 Old status: new New status: ok Commit summary for MediaWiki.r110856: Merge r97508 changes to MessageCache.php and Skin.php into trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110849]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110849 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110849 Old status: new New status: ok Commit summary for MediaWiki.r110849: test FileRepo constructor ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110837]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110837 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110837 Old status: new New status: ok Commit summary for MediaWiki.r110837: comment about wgShowIPinHeader disabling file cache ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110829]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110829 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110829 Old status: new New status: ok Commit summary for MediaWiki.r110829: rebuildFileCache now really disable debugToolbar r110761 did not properly disabled the debug toolbar. It has to be done before Setup.php (MWDebug uses a private static to track that global variable). really fix r110758 / r110762 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110761]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110761 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110761 Old status: new New status: resolved Commit summary for MediaWiki.r110761: disable wgDebugToolbar when rebuilding file cache credits to iAlex :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110857]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110857 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110857 Old status: new New status: ok Commit summary for MediaWiki.r110857: Merge r109759, r106284 Fix whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110846]: Revision status changed
MarkAHershberger changed the status of MediaWiki.r110846 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110846
Old status: new
New status: ok
Commit summary for MediaWiki.r110846:
Fix strict errors
Strict standards: Non-static method MobileFrontend2_Detection::disable() should
not be called statically in
/home/reedy/mediawiki/trunk/extensions/MobileFrontend2/MobileFrontend2_Detection.php
on line 42 Call Stack: 0.0001 639984 1. {main}()
/home/reedy/mediawiki/trunk/phase3/index.php:0 0.0001 640552 2.
require('/home/reedy/mediawiki/trunk/phase3/includes/WebStart.php')
/home/reedy/mediawiki/trunk/phase3/index.php:54 0.0108 2658720 3.
require_once('/home/reedy/mediawiki/trunk/phase3/includes/Setup.php')
/home/reedy/mediawiki/trunk/phase3/includes/WebStart.php:157 0.0987 4978416 4.
call_user_func() /home/reedy/mediawiki/trunk/phase3/includes/Setup.php:523
0.0988 4981960 5. MobileFrontend2_Hooks::setup()
/home/reedy/mediawiki/trunk/phase3/includes/Setup.php:0 0.0988 4985992 6.
MobileFrontend2_Detection::isEnabled()
/home/reedy/mediawiki/trunk/extensions/MobileFrontend2/MobileFrontend2_Hooks.php:74
0.0988 4985992 7. MobileFrontend2_Detection::detect()
/home/reedy/mediawiki/trunk/extensions/MobileFrontend2/MobileFrontend2_Detection.php:25
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98698]: Revision status changed
Hashar changed the status of MediaWiki.r98698 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98698 Old status: new New status: resolved Commit summary for MediaWiki.r98698: FileCache: * Added FileCacheBase::*MissesRecent() functions for counting cache misses from different visitors. * Made ObjectFileCache more generic. * Cleaned up FileCacheBase::checkCacheDirs(). * Added FileCacheBase::typeSubdirectory() function and overwrote in HTMLFileCache. Fixes r98405 invalidating all existing cache due to directory change. * Simplified FileCacheBase::checkCacheDirs() a bit ResourceLoader: * Use ResourceFileCache to handle load() requests, if $wgUseFileCache. Only caches requests for default language and skins. Single modules requests are always cached, whereas others require a certain threshold of traffic. * Added ResourceFileCache class (functionality was initially to be in ObjectFileCache). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Language templates missing from Mediawiki dumps
They are template articles that are missing. Not interwiki links. :-) On Tue, Feb 7, 2012 at 9:15 AM, OQ overlo...@gmail.com wrote: You sure those aren't interwiki links and not templates? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Language templates missing from Mediawiki dumps
I did ask a closely related question several years ago and I did get a solution to that problem. :-) The difference is that last time I was having a problem of transclusion because the mechanism for substituting text from a template wasn't working. That problem was being caused by the $wgUseCapitalLinks setting. This time the transclusion is working fine, but there is no article for the template because it wasn't imported during the process for importing the dump. On Tue, Feb 7, 2012 at 9:04 AM, Tei oscar.vi...@gmail.com wrote: I can see that you made the same question 2 years ago and nobody helped you :( on that point. If I remember correctly, recreating the database is uncharted waters just now, and theres a call for anyone tryiing to do it, to document the problems and solutions. To help people tryiing it on the future. Hope somebody can help you :D, or give you some workaround, patch or idea. On 21 May 2010 21:35, Nathan Day nathanryan...@gmail.com wrote: 2. For the articles that do show up, the templates are not transcluding. For an article that has Template:Hat for example, where I can see that the page exists in the db, mediawiki is acting like the template doesn't exist. If anyone has any experience with these kinds of problems or importing database dumps in general, your help would be much appreciated. Thank you! Nathan Day On 7 February 2012 17:51, Nathan Day nathanryan...@gmail.com wrote: Hi Mediawiki users, I have experienced a repeatable problem in which after importing a mediawiki database dump, I need to Export the language templates from the live site and import them into my local instance. I use MWDumper to build an SQL file which is read into my local MySql instance. The problem is that the language templates articles are not included in the dump. I am referring to all templates articles that have the following form: Template:EN EN in this could be any language code. This is not limited any particular Mediawiki dump, they all seem to have this problem. That being said, it is not much to simply import the missing templates manually, I was wondering if anyone had experienced this problem or has a quicker solution than the manual import/export. Best Regards, Nathan Day -- -- ℱin del ℳensaje. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r110858]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110858 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110858 Old status: new New status: ok Commit summary for MediaWiki.r110858: add up comment for FileCache rewrite (r98698) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110851]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110851 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110851 Old status: new New status: ok Commit summary for MediaWiki.r110851: vasilievvv as an alias for vvv changed by r110184 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110840]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110840 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110840 Old status: new New status: ok Commit summary for MediaWiki.r110840: Omg HTTPS Ping r110822 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110822]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110822 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110822 Old status: new New status: resolved Commit summary for MediaWiki.r110822: * Fix for r81363: instead of giving a PHP notice when PATH_INFO is missing, show the informative error message used before that revision. * Revert the change to the relevant message made in r102612: it is plain text, not wikitext, a format which does not support protocol-relative URLs. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96546]: New comment added
Nikerabbit posted a comment on MediaWiki.r96546. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c30558 Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter - This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php - didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Nikerabbit's comment: I don't see how that is related. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96546]: New comment added
Aaron Schulz posted a comment on MediaWiki.r96546. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c30559 Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter - This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php - didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Aaron Schulz's comment: Should be bug 33167. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110831]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110831 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110831 Old status: new New status: ok Commit summary for MediaWiki.r110831: Follow-up r110750: move constants to a different class per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110750]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110750 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110750 Old status: new New status: resolved Commit summary for MediaWiki.r110750: Fixed r63018: made it possible to delte half-baked images w/o descriptions, clearer error message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96546]: New comment added
Nikerabbit posted a comment on MediaWiki.r96546. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c30560 Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter - This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php - didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Nikerabbit's comment: So who should see it? You know I've already seen it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110821]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110821 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110821 Old status: new New status: ok Commit summary for MediaWiki.r110821: Fixes bug 33165 - GlobalFunctions.php line 1312: Call to a member function getText() on a non-object ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96546]: New comment added
Aaron Schulz posted a comment on MediaWiki.r96546. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c30561 Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter - This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php - didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Aaron Schulz's comment: It's mostly there for reference (saw the bug # is on CR). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110863]: Revision status changed
Reedy changed the status of MediaWiki.r110863 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110863 Old status: new New status: ok Commit summary for MediaWiki.r110863: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108242]: New comment added
Event posted a comment on MediaWiki.r108242. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108242#c30562 Commit summary for MediaWiki.r108242: http://translatewiki.net/wiki/Thread:Support/Translation_of_SMW_datatypes Add nb translations Event's comment: It is preferable to use Størrelse as standard and Mål as alias. And introduce Post as standard translation for Record and Record as alias. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r63018]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r63018 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/63018 Old status: new New status: resolved Commit summary for MediaWiki.r63018: (bug 17560) Half-broken deletion moved image files to deletion archive without updating DB ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110864]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110864 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110864 Old status: new New status: ok Commit summary for MediaWiki.r110864: Select fields returned by Revision::selectPageFields() and call Title::newFromRow() instead of Title::makeTitle() in Revision::getTitle() so that it doesn't need a separate query to load the page id or the latest revision id. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] 1.19 Deployment blocker triage
What: 1.19 Deployment blocker triage When: Wednesday, February 8, 13:00 UTC Time zone conversion: http://hexm.de/ej Where: #wikimedia-dev on freenode Use http://webchat.freenode.net/?channels=wikimedia-dev if you don't have an IRC client Notes: http://etherpad.wikimedia.org/BugTriage-2012-02 With the 1.19 deployment fast approaching, I'm scheduling one last bug triage for 1.19 blocking issues. There are currently only 4 blocking bugs, but there are some issues on http://labs.wikimedia.beta.wmflabs.org/wiki/Problem_reports that may yet make their way into blocking bugs. If you haven't yet taken the time to try out the beta cluster now is a good time to give it a whirl, try out 1.19, and let us know of any bugs you find. Thanks, Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r110836]: New comment added
Aaron Schulz posted a comment on MediaWiki.r110836. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110836#c30563 Commit summary for MediaWiki.r110836: Fixes Bug 34243 - [Regression] Can't navigate from Special:ListUsers/sysop to other groups Followup r97658 Aaron Schulz's comment: I'm pretty sure there is a better way to do this using SpecialPage functions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98405]: New comment added
Hashar posted a comment on MediaWiki.r98405. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98405#c30564 Commit summary for MediaWiki.r98405: HTMLFileCache refactoring: * Rewrote class and split into three classes: a base class, and html cache and a more generic cache to be used later. * The new classes now use RequestContext. * Renamed fetchPageText() - fetchText(). * Split out new saveText() function from saveToFileCache(). * Various other cleanups and fixes. Also fixed backwards setting of $wgDisableCounters in rebuildFileCache.php. Hashar's comment: r110871 implements gzopen() + stream_get_contents() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110872]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110872 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110872 Old status: new New status: ok Commit summary for MediaWiki.r110872: drop comment about a removed parameter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110871]: New comment added
Aaron Schulz posted a comment on MediaWiki.r110871. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110871#c30565 Commit summary for MediaWiki.r110871: simplify FileCacheBase::fetchText Implements a proposal by Tim on r98405 CR Aaron Schulz's comment: Can you add the 'b' flag to gzopen() for good measure? ($fh = gzopen( $this-cachePath(), 'rb' );) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110826]: Revision status changed
Reedy changed the status of MediaWiki.r110826 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110826 Old status: new New status: resolved Commit summary for MediaWiki.r110826: (bug 33551) - Make ShortUrl work properly with protocol relative urls. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110828]: Revision status changed
Reedy changed the status of MediaWiki.r110828 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110828 Old status: new New status: ok Commit summary for MediaWiki.r110828: Make extension not use global $wgOut where it can avoid it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110842]: Revision status changed
Reedy changed the status of MediaWiki.r110842 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110842 Old status: new New status: ok Commit summary for MediaWiki.r110842: (follow-up r110826) Switch getCanonicalUrl to getFullUrl in the default value for $wgShortUrlPrefix. We want to use protocol relative urls as appropriate here. JS will de-relative it for user viewing so no caching issues with pretty user display. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110825]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r110825 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110825 Old status: new New status: ok Commit summary for MediaWiki.r110825: (bug 34237) Regenerate an empty user_token and save to the database when we try to set the user's cookies for login. This allows the entire user_token column to be regenerated after a leak by running `UPDATE user SET user_token = NULL;` and letting the user_tokens be regenerated as users try to log back in. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] 1.19 Deployment blocker triage
mhershber...@wikimedia.org (Mark A. Hershberger) writes: When: Wednesday, February 8, 13:00 UTC Time zone conversion: http://hexm.de/ej Grrr... I messed up the time again. It should say 22:00 UTC. Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] New committer: Chris McMahon (cmcmahon)
Hi everyone, Chris McMahon (cmcmahon) is our latest addition to the committer list. Rob On Tue, Jan 31, 2012 at 10:02 AM, Rob Lanphier ro...@wikimedia.org wrote: Hi everyone, I’d like to welcome Chris McMahon to the Platform Engineering team as our new QA Lead. Chris has a long history working in software testing, coming to us most recently from Sentry Data Systems where he was responsible for test automation. One particularly relevant bit of experience from Chris’s past was his work at Socialtext on their wiki product, expanding the Selenium-based automated test suite from 400 individual assertions to 10,000 over the span of two years. Chris is also active in the outside community. He leads the Writing About Testing group and annual conference, which he founded in 2009. He also helped design and build the SeleNesse testing framework, which is a wiki-based tool for building acceptance tests that get executed by Selenium. In his role as QA Lead here, Chris will be responsible for figuring out what sorts of testing process we can bring to MediaWiki development. His first task will to join in on the tail end of the 1.19 deployment process, helping us with whatever last minute testing that makes sense at this stage, but then he’ll have the much larger task of looking at our release and deployment process generally, and figure out which parts would most benefit from the injection of testing rigor. He’ll also be responsible for establishing a more coordinated volunteer effort around testing. Chris will be working remotely from his home in Durango, Colorado. Welcome, Chris! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r110883]: New comment added, and revision status changed
Bawolff changed the status of MediaWiki.r110883 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110883#c30566 Old Status: new New Status: ok Commit summary for MediaWiki.r110883: Adding my USERINFO file Bawolff's comment: Welcome to Wikimedia land! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110824]: Revision status changed
Reedy changed the status of MediaWiki.r110824 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110824 Old status: new New status: ok Commit summary for MediaWiki.r110824: Make it so that going to Special:ShortUrl/f'''o''' doesn't make the o bold (It doesn't really matter at all, since no one is going to go to a url like that, and if they did it wouldn't matter if the o was bold, but nonetheless...) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110779]: Revision status changed
Reedy changed the status of MediaWiki.r110779 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110779 Old status: new New status: deferred Commit summary for MediaWiki.r110779: * Update Ace * Fix JS code in order to make Ace work with new updates ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110867]: Revision status changed
Johnduhart changed the status of MediaWiki.r110867 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110867 Old status: new New status: deferred Commit summary for MediaWiki.r110867: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110867]: Revision status changed
MarkAHershberger changed the status of MediaWiki.r110867 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110867 Old status: deferred New status: new Commit summary for MediaWiki.r110867: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1314]: New comment added, and revision status changed
Jpostlethwaite changed the status of Wikimedia.r1314 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1314#c30567 Old Status: new New Status: fixme Commit summary for Wikimedia.r1314: Adding queue2civicrm_db_switcher to civicrm_recurring_globalcollect. Jpostlethwaite's comment: Selecting the wrong database. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1314]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1314 to new URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1314 Old status: fixme New status: new Commit summary for Wikimedia.r1314: Adding queue2civicrm_db_switcher to civicrm_recurring_globalcollect. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110807]: New comment added
Aaron Schulz posted a comment on MediaWiki.r110807. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110807#c30568 Commit summary for MediaWiki.r110807: Follow-up r100165: * Fixed lack of $db-timestamp() formatting calls * Made a few w/s tweaks (to getAllowedParams, getParamDescription) * Broke some long lines Aaron Schulz's comment: Do you have commit access? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1314]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1314. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1314#c30569 Commit summary for Wikimedia.r1314: Adding queue2civicrm_db_switcher to civicrm_recurring_globalcollect. Jpostlethwaite's comment: This is fixed in #1314. pre $dbs-use_civicrm(); // Do stuff // Restore the database connection. $dbs-use_default(); /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1237]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1237. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1237#c30570 Commit summary for Wikimedia.r1237: Building out tests for drush civicrm recurring payments. Jpostlethwaite's comment: I have not had a chance to learn how to do Drupal SimpleTest. StandaloneGlobalCollectAdapter definitely does not depend on anything. It is a self-inclusive class. It has a DrushTestCase to make sure that they it works with the Standalone adapter. I also had code written to quickly write up a test, Db and Network classes already existed from other projects. At this time I am not plan on writing any tests with SimpleTest. This has to do with the issue we do not know how we are going to use CiviCRM in this next Fundraiser. If we upgrade everything, I will write unit tests according to Drupal standards. I put placeholders in the limbo module to do testing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1212]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1212.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1212#c30571
Commit summary for Wikimedia.r1212:
Adding module for Global Collect recurring payments.
Jpostlethwaite's comment:
StandaloneGlobalCollectAdapter only converts to a IPADDRESS to a string.
It must be passed in the values.
Here is a test case:
pre
public function testIsVerifiedAndGetValidResponse() {
$options = array();
$instance = StandaloneGlobalCollectAdapter::getInstance(
$options );
$this-assertInstanceOf( 'StandaloneGlobalCollectAdapter',
$instance );
$instance-setUrl( TESTS_URL_RESOURCES .
'responses/curlTransaction.valid.response.xml' );
$values = $this-getPostDataForGlobalCollect();
$instance-setValues( $values );
$this-assertTrue( $instance-curlTransaction() );
}
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110716]: New comment added
Krinkle posted a comment on MediaWiki.r110716. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110716#c30572 Commit summary for MediaWiki.r110716: Please review carefully, I cannot see negative side effects from this patch. It gives extensions which use the (depreacted) UnknownAction hook a chance to see the original action= value. This fixes bug 34203 and bug 34161 UnknownAction hook problem: the hook must pass the unknown action to the callee and not the value nosuchaction Krinkle's comment: This is a follow-up to r109678. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109678]: New comment added, and revision status changed
Krinkle changed the status of MediaWiki.r109678 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109678#c30573
Old Status: fixme
New Status: new
Commit summary for MediaWiki.r109678:
Reinstate r109223 per CR + fixes
* Action/Context stuff is pretty deeply nested everywhere.
* Should be okay now, at last.
* Reverts reverting r109243
* Same as r109223, except adding this:
+ if ( !$context-canUseWikiPage() ) {
+ return 'view';
+ }
Krinkle's comment:
Fixed by r110716.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110321]: Revision status changed
Reedy changed the status of MediaWiki.r110321 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110321 Old status: ok New status: reverted Commit summary for MediaWiki.r110321: [Xml::encodeJsVar] Use FormatJson::encode / native json_encode instead * Follows-up r110320 * XmlTest.php passes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110900]: New comment added
Krinkle posted a comment on MediaWiki.r110900. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110900#c30574 Commit summary for MediaWiki.r110900: Revert r110321: introduces an XSS vulnerability because FormatJson::encode() does not prevent the termination of CDATA sections when JavaScript is embedded in HTML. Krinkle's comment: Aggregating from #mediawiki: http://toolserver.org/~mwbot/logs/%23mediawiki/20120208.txt pre [00:05:00] KrinkleTimStarling: Eh ? that looks worrying? Is this about Services_JSON or php's native json_encode ? [00:05:15] TimStarlingboth [00:06:02] TimStarlingthe issue is documented in Xml::escapeJsString [00:07:37] KrinkleTimStarling: So FormatJson::encode should only be used for complete javascript responses (rather than partial output in a script tag). [00:07:57] KrinkleTimStarling: In that case, do we need FormatJson::encode at all ? Or is it better performance wise when CDATA is not a concern (e.g. in a load.php response) [00:08:33] TimStarlingboth should be secure [00:08:49] TimStarlingwe need multiple lines of defense [00:10:35] KrinkleTimStarling: I mean if our (seemingly much simpler) json encoder in Xml.php is better and safer than Services_JSON, we might as well remove all body of FormatJson::encode and re-route it to Xml methods (instead of the other way around). [00:12:40] TimStarlingPHP 5.3 has a JSON_HEX_TAG option to json_encode() which addresses this issue, as I noted on that bug report [00:13:10] TimStarlingbut yes, it doesn't make sense to have two pure PHP implementations, one secure and one subtly flawed [00:13:24] KrinkleYeah [00:13:40] TimStarlingI mean, you're one of our best frontend developers, if you don't know about this issue, there's a pretty high chance that it will come up again [00:14:13] TimStarlingI should review all direct calls to json_encode and FormatJson::encode(), maybe there are vulnerabilities already [00:14:22] KrinkleTimStarling: Well, I obviously knew about and escapement being a problem when outputted in script [00:14:37] KrinkleTimStarling: I wrongly assumed it would be taken care of by the encoder we use all over the place [00:15:27] KrinkleTimStarling: I know there are no direct alls to json_encode in our codebase (other than FormatJson::encode itself), I ack'ed that before [00:15:55] KrinkleThere most likely are calls to FormatJson::encode [00:17:01] KrinkleTimStarling: So we should raise the requirements before handing off to json_encode to include support for JSON_HEX_TAG, and pass it. And then either fix the php implementation of Services_JSON or let it call Xml.php from FormatJson::encode [00:17:17] TimStarlingyes [00:17:21] Krinkleaight [00:17:21] TimStarlingmost of the code in Services_JSON deals with UTF-8 to UTF-16 conversion [00:18:10] TimStarlingwhich we don't need because we use a UTF-8 output format, so our strings can have literal unicode characters [00:18:29] KrinkleAside from using Services_JSON or the Xml-class methods, I'd prefer not having this Xml.php either way, but that's another issue. [00:18:29] TimStarlingif you were embedding unicode text in a latin-1 HTML document, it would matter [00:18:47] TimStarlingit can move, I don't mind [00:19:13] TimStarlingmaybe things like Xml::encodeJsCall() should move too [00:21:11] KrinkleTimStarling: I'm not too familiar with the encoding backgrounds. I noticed Xml uses \\x3c where JSON_HEX_TAG uses \u003C, that's just the same, right ? [00:21:25] TimStarlingyeah, it's the same [00:21:27] Krinklek [00:22:51] KrinkleTimStarling: Oh, Services_JSON of course also contains decode() which Xml.php does not [00:26:36] TimStarlingthe UTF-8 handling in Services_JSON::decode() is wrong and scary [00:27:41] TimStarlingit allows overshort characters to break the syntax /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] New committers
Two new committers with core access: Christian Aistleitner (qchris) is a new Wikimedia Foundation contractor working on the XML dump infrastructure, database access and testing thereof, and Labs. Elizabeth Smith (emsmith) works for OmniTI as a developer and is joining the AFTv5 project. (She doesn't yet have a mediawiki.org account - I've asked for one and will link when she does.) Welcome, Elizabeth and Christian! -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r110907]: New comment added
MZMcBride posted a comment on MediaWiki.r110907. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110907#c30575 Commit summary for MediaWiki.r110907: Fix bug MZMcBride's comment: Truncated commit summary? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110900]: New comment added
Tim Starling posted a comment on MediaWiki.r110900. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110900#c30576 Commit summary for MediaWiki.r110900: Revert r110321: introduces an XSS vulnerability because FormatJson::encode() does not prevent the termination of CDATA sections when JavaScript is embedded in HTML. Tim Starling's comment: Actually there is a difference between \x3c and \u003c: \x3c is not allowed in JSON, although it is allowed in JavaScript. Neither json_decode() nor Services_JSON::decode() recognises \x3c. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110900]: Revision status changed
Krinkle changed the status of MediaWiki.r110900 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110900 Old status: new New status: ok Commit summary for MediaWiki.r110900: Revert r110321: introduces an XSS vulnerability because FormatJson::encode() does not prevent the termination of CDATA sections when JavaScript is embedded in HTML. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110823]: Revision status changed
Tim Starling changed the status of MediaWiki.r110823 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110823 Old status: new New status: ok Commit summary for MediaWiki.r110823: Follow-up r102160: disable popups by default ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102160]: Revision status changed
Tim Starling changed the status of MediaWiki.r102160 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160 Old status: new New status: ok Commit summary for MediaWiki.r102160: Merging ReferenceTooltips into Cite step 2: rename/register ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110871]: Revision status changed
Tim Starling changed the status of MediaWiki.r110871 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110871 Old status: new New status: ok Commit summary for MediaWiki.r110871: simplify FileCacheBase::fetchText Implements a proposal by Tim on r98405 CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96546]: New comment added
Tim Starling posted a comment on MediaWiki.r96546. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c30577 Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter - This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php - didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Tim Starling's comment: Here is the query log for [[Special:Log/move]] on my test wiki: http://paste.tstarling.com/p/rQxouc.html ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96546]: New comment added
Tim Starling posted a comment on MediaWiki.r96546. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c30578 Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter - This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php - didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Tim Starling's comment: This broken code is still present, even after r110893. Leaving status as fixme because of that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
