[MediaWiki-CodeReview] [MediaWiki r111958]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111958 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111958 Old status: deferred New status: ok Commit summary for MediaWiki.r111958: bugfix (SFFormUtils::hiddenFieldHTML() does not exist) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] State of 1.18
Hi everyone, Here's where we are. We've got a lot of blockers listed below, though it's probably not as bad as it looks from the bug count. == Blocking stage 2 deployment (commons) == Javascript/Resource Loader Tim did a bunch of work in this general area today. I'm hopeful Roan will have some time to review this work and we can all verify that this cleans up a bunch of issues. http://bugzilla.wikimedia.org/34450 -- Probable Javascript loading issues (navigation and tabbing issues, multiple browsers) http://bugzilla.wikimedia.org/34409 -- 'mw.user.options' and 'mw.user.tokens' are sometimes empty on 1.19, breaking watchlist, gadgets, etc. http://bugzilla.wikimedia.org/34517 -- Sometimes scripts imported by mw.loader.load on common.js are not executed http://bugzilla.wikimedia.org/34504 -- [Regression] There should not be a mismatch between html and stylesheet version Logging and permissions Mark and Antoine made a fix to one logging issue, and I puttered around on the larger IRC problem. http://bugzilla.wikimedia.org/34508 -- [Regression] IRC string output for log messages no longer compatible http://bugzilla.wikimedia.org/34503 -- Users without the autopatrol right are being autopatrolled on simple.wikipedia == Blocking stage 3 deployment (all projects except Wikipedia) == No additional bugs. == Blocking stage 4 deployment (all Wikipedia except enwiki) == http://bugzilla.wikimedia.org/34104 -- Schema changes for MediaWiki 1.19 deployment to Wikimedia wikis There are some master switches that need to happen on s1, s5 and s6 prior to deploying to enwiki, dewiki, ruwiki, frwiki == Important to figure out, but not blocking == http://bugzilla.wikimedia.org/34458 -- Editing fails in IE7 http://bugzilla.wikimedia.org/34478 -- Special:MergeAccountaction=submit generates error http://bugzilla.wikimedia.org/34469 -- (un)watch button broken (only in debug mode now) == Administrivia == http://bugzilla.wikimedia.org/33994 -- MediaWiki 1.19 pre WMF deployment actions (tracking) == Query for 1.19 deploy blockers == https://bugzilla.wikimedia.org/buglist.cgi?query_format=advancedlist_id=91536resolution=---target_milestone=1.19wmf%20deploymentknown_name=1.19%20deploy%20blockersquery_based_on=1.19%20deploy%20blockers Etherpad: http://etherpad.wikimedia.org/119triage ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] State of 1.19 deploy
...and just for grins, we'll make that 1.19 -- Forwarded message -- From: Rob Lanphier ro...@wikimedia.org Date: Tue, Feb 21, 2012 at 12:02 AM Subject: State of 1.18 To: Wikimedia developers wikitech-l@lists.wikimedia.org Hi everyone, Here's where we are. We've got a lot of blockers listed below, though it's probably not as bad as it looks from the bug count. == Blocking stage 2 deployment (commons) == Javascript/Resource Loader Tim did a bunch of work in this general area today. I'm hopeful Roan will have some time to review this work and we can all verify that this cleans up a bunch of issues. http://bugzilla.wikimedia.org/34450 -- Probable Javascript loading issues (navigation and tabbing issues, multiple browsers) http://bugzilla.wikimedia.org/34409 -- 'mw.user.options' and 'mw.user.tokens' are sometimes empty on 1.19, breaking watchlist, gadgets, etc. http://bugzilla.wikimedia.org/34517 -- Sometimes scripts imported by mw.loader.load on common.js are not executed http://bugzilla.wikimedia.org/34504 -- [Regression] There should not be a mismatch between html and stylesheet version Logging and permissions Mark and Antoine made a fix to one logging issue, and I puttered around on the larger IRC problem. http://bugzilla.wikimedia.org/34508 -- [Regression] IRC string output for log messages no longer compatible http://bugzilla.wikimedia.org/34503 -- Users without the autopatrol right are being autopatrolled on simple.wikipedia == Blocking stage 3 deployment (all projects except Wikipedia) == No additional bugs. == Blocking stage 4 deployment (all Wikipedia except enwiki) == http://bugzilla.wikimedia.org/34104 -- Schema changes for MediaWiki 1.19 deployment to Wikimedia wikis There are some master switches that need to happen on s1, s5 and s6 prior to deploying to enwiki, dewiki, ruwiki, frwiki == Important to figure out, but not blocking == http://bugzilla.wikimedia.org/34458 -- Editing fails in IE7 http://bugzilla.wikimedia.org/34478 -- Special:MergeAccountaction=submit generates error http://bugzilla.wikimedia.org/34469 -- (un)watch button broken (only in debug mode now) == Administrivia == http://bugzilla.wikimedia.org/33994 -- MediaWiki 1.19 pre WMF deployment actions (tracking) == Query for 1.19 deploy blockers == https://bugzilla.wikimedia.org/buglist.cgi?query_format=advancedlist_id=91536resolution=---target_milestone=1.19wmf%20deploymentknown_name=1.19%20deploy%20blockersquery_based_on=1.19%20deploy%20blockers Etherpad: http://etherpad.wikimedia.org/119triage ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Using computer vision to categorize images at Commons
On Tue, Feb 21, 2012 at 8:09 AM, Antoine Musso hashar+...@free.fr wrote: Le 20/02/12 22:08, Maarten Dammers a écrit : Some time ago I played around with computer vision to get images categorized on Commons. I documented this at https://commons.wikimedia.org/wiki/User:Multichill/Using_OpenCV_to_categorize_files . I don't think I'm going to spend time on it soon, but the results were quite promising, so maybe someone else feels like working on this? Would probably be a pretty nice student project or just fun to do. Google used a game to add keywords to images. Two people (of of them could be a robot) were presented two pictures. The aim is to enter a keyword that best describe the picture and that the other people will choose too. If both people use the same keyword, you gain points :-) Imagine, you are being shown a picture whose main subject is a monkey, you enter monkey, the other one monkey too. You both earn points. The game host now know that the picture is of a monkey :-D The Google Image Labeler, there are (funny and offensive) videos of that online. It is a good idea. Mediawiki does not need a person to check it live, it has users that are reviewing the changes anyway. It would be nice to have a *simple* way to put people down and have them label images, I could find people if it was really simple. Right now it is not really simple. Most people just dont have the concentration to read the docs or learn how to use the wiki. mike ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Where to host wikimedia related software projects
In this case I am talking about sw related to wmf projects, so it needs hack in order to make it work on other wikis, however I support one wiki, so doesn't matter where it should be, but we should have all tools on one place, splitting wmf to meta and general to other wikis would not help much. On Tue, Feb 21, 2012 at 12:34 AM, K. Peachey p858sn...@gmail.com wrote: On Tue, Feb 21, 2012 at 7:42 AM, Gregory Varnum gregory.var...@gmail.com wrote: Hacks to MW core or to their software? Either If just their software (which I think is the case) - doesn't seem any different from extensions which need some additional configuring. Config Settings != Hacking to make it work. The only extensions that are on MediaWiki wiki that in theory would need hacking up/altering to work would be old and unloved one. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111963]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111963 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111963 Old status: new New status: ok Commit summary for MediaWiki.r111963: Use local context to get messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111965]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111965 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111965 Old status: ok New status: resolved Commit summary for MediaWiki.r111965: fix bug #34495 — patrol log credit the user patrolled, not the user patrolling ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111969]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111969 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111969 Old status: new New status: ok Commit summary for MediaWiki.r111969: MFT to 1.19wmf1 r111965 r11967 bug #34495 — patrol log credit the user patrolled, not the user patrolling ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111970]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111970 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111970 Old status: new New status: ok Commit summary for MediaWiki.r111970: Change for === Ping r111680 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] FW: Reminder: IRC office hours with the localization team 2011-02-21 18:00 UTC
-- Forwarded message -- From: Steven Walling swalling at wikimedia.org Date: Wed, Feb 1, 2012 at 10:46 AM Subject: IRC office hours with the localization team, on International Mother Language Day To: Wikimedia Foundation Mailing List foundation-l at lists.wikimedia.org Hi everyone, I just wanted to give some advance notice about IRC office hours with the localization team [1] at the Wikimedia Foundation, which will be aptly held on International Mother Language Day.[2] Date: 2011-02-21 Time: 18.00 UTC Venue: #wikimedia-office As usual, more logistical info and time conversion links are available on Meta.[3] For a taste of what the localization team has been up to, I highly recommend the blog posts they've been writing regularly.[4] Thanks, and we'll talk to you later this month! -- Steven Walling, Wikimedia Foundation 1. https://wikimediafoundation.org/wiki/Localisation_team 2. https://en.wikipedia.org/wiki/International_Mother_Language_Day 3. https://meta.wikimedia.org/wiki/IRC_office_hours 4. http://blog.wikimedia.org/c/technology/features/internationalization-and-localization/ -- Steven Walling https://wikimediafoundation.org/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] IRC office hours with the localization team on Februari 21
Hoi, Today at 18:00 UTC (see also the link below) there is a Wikimedia Office hour with the WMF localisation team. The subject is what more can we do for your language. On my blog I entered some of the things we can talk about. We also love to hear about how what we already do works for you and what we (both you and us) can do to extend it further. Joining our office hours is a great way to celebrate International Mother Language Day. Thanks, Gerard http://www.timeanddate.com/worldclock/fixedtime.html?hour=18min=00sec=0day=21month=02year=2012 http://ultimategerardm.blogspot.com/2012/02/international-mother-language-day-2012.html -- Forwarded message -- From: Steven Walling swall...@wikimedia.org Date: 20 February 2012 23:17 Subject: [Foundation-l] Reminder: IRC office hours with the localization team tomorrow To: Wikimedia Foundation Mailing List foundatio...@lists.wikimedia.org Hi all! Just a quick reminder that you're invited to join the WMF localization team at 1800 UTC tomorrow. -- Forwarded message -- From: Steven Walling swall...@wikimedia.org Date: Wed, Feb 1, 2012 at 10:46 AM Subject: IRC office hours with the localization team, on International Mother Language Day To: Wikimedia Foundation Mailing List foundatio...@lists.wikimedia.org Hi everyone, I just wanted to give some advance notice about IRC office hours with the localization team [1] at the Wikimedia Foundation, which will be aptly held on International Mother Language Day.[2] Date: 2011-02-21 Time: 18.00 UTC Venue: #wikimedia-office As usual, more logistical info and time conversion links are available on Meta.[3] For a taste of what the localization team has been up to, I highly recommend the blog posts they've been writing regularly.[4] Thanks, and we'll talk to you later this month! -- Steven Walling, Wikimedia Foundation 1. https://wikimediafoundation.org/wiki/Localisation_team 2. https://en.wikipedia.org/wiki/International_Mother_Language_Day 3. https://meta.wikimedia.org/wiki/IRC_office_hours 4. http://blog.wikimedia.org/c/technology/features/internationalization-and-localization/ -- Steven Walling https://wikimediafoundation.org/ ___ foundation-l mailing list foundatio...@lists.wikimedia.org Unsubscribe: https://lists.wikimedia.org/mailman/listinfo/foundation-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111984]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111984 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111984 Old status: new New status: ok Commit summary for MediaWiki.r111984: Bug 34538 again. Bug reproduced and fix tested. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111991]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111991 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111991 Old status: new New status: ok Commit summary for MediaWiki.r111991: Displaying the language name in the current user's language. Should work with cldr installed. Ping r111614. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111866]: New comment added, and revision status changed
Siebrand changed the status of MediaWiki.r111866 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111866#c31284 Old Status: fixme New Status: new Commit summary for MediaWiki.r111866: Remove 1.17 compatibility code. Siebrand's comment: I've rolled back the change in utils/TranslationHelpers.php which broke the diffs, without adding the 1.17 remark. AFAIK we're keeping BC for the latest stable version and trunk, so 1.17 had to go. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111914]: Revision status changed
Siebrand changed the status of MediaWiki.r111914 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111914 Old status: new New status: ok Commit summary for MediaWiki.r111914: $headers not used in this method, ping r111867 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111892]: Revision status changed
Siebrand changed the status of MediaWiki.r111892 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111892 Old status: new New status: ok Commit summary for MediaWiki.r111892: Opps, let's not break everything ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111999]: Revision status changed
Siebrand changed the status of MediaWiki.r111999 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111999 Old status: new New status: ok Commit summary for MediaWiki.r111999: Close button did not work for the embedded editor for the last item in the table. Bind the close callback to the close input unconditionally. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112000]: New comment added, and revision status changed
Siebrand changed the status of MediaWiki.r112000 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112000#c31285 Old Status: new New Status: ok Commit summary for MediaWiki.r112000: Testing a different style which should also work on monobook skin - only tested in chrome and IE9 Siebrand's comment: Additionally tested in FF3.6 on Windows, Safari and Opera on OSX. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Announcement: Terry Chay joins WMF as Director of Features Engineering
Oh my, I've been an admirer for many years ;-) Domas ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New cryptographic random number generator up for review
On Tue, Feb 21, 2012 at 2:01 AM, Antoine Musso hashar+...@free.fr wrote: Le 21/02/12 03:33, Daniel Friesen a écrit : The class was committed in r111964 but backed out till after the git migration: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/111964 If you want to try out and test the class yourself you can get it into your trunk svn checkout by using: $ svn merge -c 111964 . Chad will confirm, but I guess you can work on it in a branch and we can migrate that branch to git. That will keep trunk clean and let you work on this feature with other people. Please, no more branches. In fact, it would be super useful if everyone could find something else to do and stop committing entirely until after the migration ;-) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
On Tue, Feb 21, 2012 at 2:11 AM, Huib Laurens sterke...@gmail.com wrote: Hello, Please note that CentOS is still running PHP 5.2.x out of the box. The same goes for the cheap controlpanel DirectAdmin. With a test in cPanel users almost 90% is running CentOS 5.x with PHP 5.2.x With changing the minimum version we would stop a lot of users from using mediawik... Maybe it would convince people to stop using cPanel. I know it won't happen...but I can dream, can't I? ;-) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
Haha! Its a fact that cPanel will make the upgrade easy to php 5.3 or CentOS 6.* But I guess it will bring up a lot of questions when it would be bumped up right now, it seems that PHP 5.2.x is still widly in use.. Best, Huib Just checked, but parrelels plesk gives me a PHP 5.3 version, so all hosting companies should switch to Plesk :P On Tue, Feb 21, 2012 at 1:11 PM, Chad innocentkil...@gmail.com wrote: On Tue, Feb 21, 2012 at 2:11 AM, Huib Laurens sterke...@gmail.com wrote: Hello, Please note that CentOS is still running PHP 5.2.x out of the box. The same goes for the cheap controlpanel DirectAdmin. With a test in cPanel users almost 90% is running CentOS 5.x with PHP 5.2.x With changing the minimum version we would stop a lot of users from using mediawik... Maybe it would convince people to stop using cPanel. I know it won't happen...but I can dream, can't I? ;-) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Kind regards, Huib Laurens WickedWay.nl Webhosting the wicked way. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
On Tue, Feb 21, 2012 at 7:15 AM, Huib Laurens sterke...@gmail.com wrote: Haha! Its a fact that cPanel will make the upgrade easy to php 5.3 or CentOS 6.* If memory serves, nothing cPanel does is easy (read: pain free). But we're quickly digressing. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112005]: Revision status changed
Siebrand changed the status of MediaWiki.r112005 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112005 Old status: new New status: ok Commit summary for MediaWiki.r112005: Don't override certain headers unconditionally - let them be customised by a hook Reduce the number of headers added by default ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112003]: Revision status changed
Siebrand changed the status of MediaWiki.r112003 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112003 Old status: new New status: ok Commit summary for MediaWiki.r112003: Shorten and simplify version string in gettext files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112002]: Revision status changed
Siebrand changed the status of MediaWiki.r112002 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112002 Old status: new New status: ok Commit summary for MediaWiki.r112002: Just ids to find the elements, faster and less error prone ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112001]: Revision status changed
Siebrand changed the status of MediaWiki.r112001 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112001 Old status: new New status: ok Commit summary for MediaWiki.r112001: rebuild() was not dealing with recursion properly. This lead to infinite loop, when there was no message index yet and translate workflow states: * rebuild loads groups * workflow state group adds missing messages when it loads message keys * onSave hook gets run when those messages are credited * the hooks wants to know which message the page corresponds to * so it loads message index * which is messing, so rebuild() gets called again... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111614]: Revision status changed
Siebrand changed the status of MediaWiki.r111614 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111614 Old status: new New status: ok Commit summary for MediaWiki.r111614: live hack to deal with 500s on log/RC views ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
On 21 February 2012 12:11, Chad innocentkil...@gmail.com wrote: On Tue, Feb 21, 2012 at 2:11 AM, Huib Laurens sterke...@gmail.com wrote: Please note that CentOS is still running PHP 5.2.x out of the box. The same goes for the cheap controlpanel DirectAdmin. With a test in cPanel users almost 90% is running CentOS 5.x with PHP 5.2.x With changing the minimum version we would stop a lot of users from using mediawik... Maybe it would convince people to stop using cPanel. I know it won't happen...but I can dream, can't I? ;-) Presumably we have contacts at hosting companies and cPanel? It would be in order to warn them. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111997]: New comment added
Siebrand posted a comment on MediaWiki.r111997. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111997#c31286 Commit summary for MediaWiki.r111997: Committing this from git so that Siebrand can review it using CR tool. Siebrand's comment: Looks nice. We did forget a major requirement, though, which is that we should offer users the option to pick between one and three languages they can translate in. I think it's probably a good idea to set the first selector to the user interface language. I choice at least one filled out translation language should be mandatory, I think, because otherwise the messaging that we are to implement later on cannot be well targeted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111997]: New comment added, and revision status changed
Siebrand changed the status of MediaWiki.r111997 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111997#c31287 Old Status: new New Status: fixme Commit summary for MediaWiki.r111997: Committing this from git so that Siebrand can review it using CR tool. Siebrand's comment: This implements https://mingle.corp.wikimedia.org/projects/internationalization/cards/532 Failed the following acceptance criteria: 2. Which languages can you translate in? 2.1 Inputs for Maximum of three languages that a translator can indicate. Suggested is these are language selector dropdowns 2.2 the first selector is set to the user interface language when there are no user preferences yet. 2.3 Saving the form without having provided any language preference should not be possible. 3.5 I don’t want to be notified ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112007]: Revision status changed
Siebrand changed the status of MediaWiki.r112007 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112007 Old status: new New status: ok Commit summary for MediaWiki.r112007: Minor whitespace and typo fixes. ping r111934 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107309]: New comment added
Siebrand posted a comment on MediaWiki.r107309. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107309#c31288 Commit summary for MediaWiki.r107309: Localisation updates for namespace names for core from http://translatewiki.net. Siebrand's comment: Tim? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Nikerabbit posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31289 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Nikerabbit's comment: Because it doesn't work without legacy globals. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Krinkle posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31290 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Krinkle's comment: Cmon please branch code. You can't expect this to work all the way from 1.16 to 1.20. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Krinkle posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31291 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Krinkle's comment: 1.16 isn't even supported as major release any more. Legacy supported release is currently 1.17.2 according to [[Download]]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] New cryptographic random number generator up for review
Le 21/02/12 13:09, Chad a écrit : Please, no more branches. In fact, it would be super useful if everyone could find something else to do and stop committing entirely until after the migration;-) Hey guys, lets start an online encyclopedia written using a forum. I have started hacking PHPBB. -- The new Magnus -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109017]: Revision status changed
Krinkle changed the status of MediaWiki.r109017 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017 Old status: deferred New status: fixme Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
Le 21/02/12 13:28, David Gerard a écrit : Presumably we have contacts at hosting companies and cPanel? It would be in order to warn them. We can not contact / track PHP version of major hosting companies. Their customers will eventually ask them for an upgrade. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New cryptographic random number generator up for review
On Tue, Feb 21, 2012 at 1:51 PM, Antoine Musso hashar+...@free.fr wrote: I have started hacking PHPBB. -- The new Magnus Huh? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111934]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111934 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111934 Old status: new New status: ok Commit summary for MediaWiki.r111934: Avoid unconditional modification of original word in fi convertGrammar Do not call convertgrammar unless word and form are defined. Use a grammarForm that no other language use in jqueryMsg test to avoid conflict when test is executed with that language. Followup 111725 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112008]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112008 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112008 Old status: new New status: ok Commit summary for MediaWiki.r112008: Whitespace updates. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112009]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112009 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112009 Old status: new New status: ok Commit summary for MediaWiki.r112009: Fix typo and update whitespace. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112010]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112010 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112010 Old status: new New status: ok Commit summary for MediaWiki.r112010: Use the regular pattern for special page names. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112011]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112011 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112011 Old status: new New status: ok Commit summary for MediaWiki.r112011: Add to $wgSpecialPageGroups ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112012]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112012 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112012 Old status: new New status: ok Commit summary for MediaWiki.r112012: Tweak messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
On Tue, Feb 21, 2012 at 8:53 AM, Antoine Musso hashar+...@free.fr wrote: Le 21/02/12 13:28, David Gerard a écrit : Presumably we have contacts at hosting companies and cPanel? It would be in order to warn them. We can not contact / track PHP version of major hosting companies. Their customers will eventually ask them for an upgrade. Agreed. Trying to push people to upgrade to 5.3 will be a colossal waste of time. Remember the pushes for PHP5 and to get people to drop PHP4? Hosting companies only got on board when there was finally sufficient demand for it, not because a bunch of people said you're using old software, stop! The correct answer is I'm sorry this is inconvenient, ask your hosting provider or find a better one. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112014]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r112014 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112014#c31292 Old Status: new New Status: ok Commit summary for MediaWiki.r112014: Remove some no longer needed uses of User::getSkin(). Use static linker method instead. Nikerabbit's comment: Would you like to convert the instances of DummyLinker as well? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111994]: Revision status changed
Nikerabbit changed the status of MediaWiki.r111994 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111994 Old status: new New status: ok Commit summary for MediaWiki.r111994: Partial revert of r111866: utils\TranslationHelpers.php change was based on an incorrect comment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111866]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r111866 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111866#c31293 Old Status: new New Status: resolved Commit summary for MediaWiki.r111866: Remove 1.17 compatibility code. Nikerabbit's comment: I was extending it to two stable version, but maybe 1.5 stable versions is enough for now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Yaron Koren posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31294 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Yaron Koren's comment: Sorry - I don't know what you mean here. Does the latest MW no longer support globals? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Yaron Koren posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31295 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Yaron Koren's comment: I'm not going to branch the extension just for this one thing. If using JS globals no longer works with the latest MW, I'll just remove them. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Nikerabbit posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31296 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Nikerabbit's comment: It is a configuration setting I've enabled on translatewiki.net to catch and fix problems. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112016]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112016 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112016 Old status: new New status: ok Commit summary for MediaWiki.r112016: The grammar case is partitive and not accusative Follow up r111931 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Krinkle posted a comment on MediaWiki.r109017.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31297
Commit summary for MediaWiki.r109017:
Revert of r108255 - too early to get rid of JS globals, since SF still supports
MW 1.16. Hopefully these changes can be restored in the next six months or so,
though
Krinkle's comment:
... that is {{wg|LegacyJavaScriptGlobals}}.
What do you mean by removing them. ?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108912]: New comment added
^demon posted a comment on MediaWiki.r108912. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108912#c31298 Commit summary for MediaWiki.r108912: Bug 33713 - Show previous revisions in addition to follow-ups Add the followed-up list to CodeRevisionView ^demon's comment: Followed-up revisions is confusing. Perhaps This revision follows-up: ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108912]: New comment added
Krinkle posted a comment on MediaWiki.r108912. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108912#c31299 Commit summary for MediaWiki.r108912: Bug 33713 - Show previous revisions in addition to follow-ups Add the followed-up list to CodeRevisionView Krinkle's comment: I'd also like to try positioning this section above the diff rather than below the Follow-up revisions. What do you think? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
Hi! Agreed. Trying to push people to upgrade to 5.3 will be a colossal waste of time. Remember the pushes for PHP5 and to get people to drop PHP4? None of that frustration was around MediaWiki development - we dropped PHP4 swiftly, and I guess only Jeffrey Merkey complained. ;-) If MediaWiki is better on newer PHP, we should use newer PHP. Domas ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108912]: New comment added
Reedy posted a comment on MediaWiki.r108912. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108912#c31300 Commit summary for MediaWiki.r108912: Bug 33713 - Show previous revisions in addition to follow-ups Add the followed-up list to CodeRevisionView Reedy's comment: Indeed, it does become somewhat ambiguous with similar terminology. I couldn't think of anything better. Hey, at least it's only an i18n change. Krinkle: Sure, just remember we're not going to be using CodeReview for too long into the mysterious future... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108912]: New comment added
Krinkle posted a comment on MediaWiki.r108912. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108912#c31301 Commit summary for MediaWiki.r108912: Bug 33713 - Show previous revisions in addition to follow-ups Add the followed-up list to CodeRevisionView Krinkle's comment: True, but we'll be looking at it for a while still (in read-only) I guess. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
On Tue, Feb 21, 2012 at 10:08 AM, Domas Mituzas midom.li...@gmail.com wrote: Hi! Agreed. Trying to push people to upgrade to 5.3 will be a colossal waste of time. Remember the pushes for PHP5 and to get people to drop PHP4? None of that frustration was around MediaWiki development - we dropped PHP4 swiftly, and I guess only Jeffrey Merkey complained. ;-) I was speaking generally, not about MediaWiki. If MediaWiki is better on newer PHP, we should use newer PHP. It's better in that it's the active release branch and is supported. Although I'm less convinced that's the drive behind some people to want 5.3...I'm sure we'll get a ton of anonymous functions and LSB once the version's bumped. I can't wait ;-) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Problematic automated tweets
It's interesting to note that the text 'jfaritu' which began the problematic texts was precisely pointing to the abuser's nick. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] IRC office hours with the localization team on Februari 21
Dear Gerard, We are managing a wiki site on an old and renewed multilingual demographic dictionary based on the work of an International Commission on Terminology in the 50's at the United Nations and later by the International Union for the Scientific Study of Population (IUSSP). Multilingualism is 6 official languages at the UN, but for practical reasons is reduced to bilingualism in bilateral Scientific conferences (for example German-French) or still some rare International Scientific Conferences (English-French). Introducing Mother languages enlarges multilingualism to hundred of languages and thanks to Unicode, UNESCO (21st February 2000), Wikipedia, UN resolution (http://www.undemocracy.com/A-RES-61-266.pdf) etc. to make it real multilingualism possible while preserving diversity in this world. But here is my point. Could you discuss (at 6pm UTC for example) the need (or not) for Wikipedians to sign their articles using their mother languages (ie in Cyrillic, Thai, Russian, Arabic etc.) and no more using the English transliteration of their real name or even pseudos? We know that it is possible on Wikipedia and other Mediawikis to have a localized authorship (see Михаил Денисенко on http://ru-ii.demopaedia.org/w/index.php?title=90action=history for example) but the authentication with non English ASCII characters is difficult. Especially if you are abroad with an English keyboard only. Wouldn't be easier to allow authentication via username OR email like that: Username (or e-mail): |___| Password: |___| We recently proposed a patch which is currently discussed in a thread at http://lists.wikimedia.org/pipermail/wikitech-l/2012-February/058183.html but we need some support to make this new option a reality for Mediawikis and Wikipedia too. What is your opinion? Regards, -- Nicolas Le 21 févr. 2012 à 10:11, Gerard Meijssen a écrit : Hoi, Today at 18:00 UTC (see also the link below) there is a Wikimedia Office hour with the WMF localisation team. The subject is what more can we do for your language. On my blog I entered some of the things we can talk about. We also love to hear about how what we already do works for you and what we (both you and us) can do to extend it further. Joining our office hours is a great way to celebrate International Mother Language Day. Thanks, Gerard http://www.timeanddate.com/worldclock/fixedtime.html?hour=18min=00sec=0day=21month=02year=2012 http://ultimategerardm.blogspot.com/2012/02/international-mother-language-day-2012.html -- Forwarded message -- From: Steven Walling swall...@wikimedia.org Date: 20 February 2012 23:17 Subject: [Foundation-l] Reminder: IRC office hours with the localization team tomorrow To: Wikimedia Foundation Mailing List foundatio...@lists.wikimedia.org Hi all! Just a quick reminder that you're invited to join the WMF localization team at 1800 UTC tomorrow. -- Forwarded message -- From: Steven Walling swall...@wikimedia.org Date: Wed, Feb 1, 2012 at 10:46 AM Subject: IRC office hours with the localization team, on International Mother Language Day To: Wikimedia Foundation Mailing List foundatio...@lists.wikimedia.org Hi everyone, I just wanted to give some advance notice about IRC office hours with the localization team [1] at the Wikimedia Foundation, which will be aptly held on International Mother Language Day.[2] Date: 2011-02-21 Time: 18.00 UTC Venue: #wikimedia-office As usual, more logistical info and time conversion links are available on Meta.[3] For a taste of what the localization team has been up to, I highly recommend the blog posts they've been writing regularly.[4] Thanks, and we'll talk to you later this month! -- Steven Walling, Wikimedia Foundation 1. https://wikimediafoundation.org/wiki/Localisation_team 2. https://en.wikipedia.org/wiki/International_Mother_Language_Day 3. https://meta.wikimedia.org/wiki/IRC_office_hours 4. http://blog.wikimedia.org/c/technology/features/internationalization-and-localization/ -- Steven Walling https://wikimediafoundation.org/ ___ foundation-l mailing list foundatio...@lists.wikimedia.org Unsubscribe: https://lists.wikimedia.org/mailman/listinfo/foundation-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l Nicolas Brouard INED brou...@ined.fr ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112018]: New comment added
Nikerabbit posted a comment on MediaWiki.r112018. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112018#c31302 Commit summary for MediaWiki.r112018: Followup r111997 Remove unused $wgScript Fix missing brackets on the getUser() call Fix stuff and dbname typos $this-mGlobalUser isn't defined, use the $globalUser defined above Nikerabbit's comment: Anyway I can test that code easily? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112018]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112018 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112018 Old status: new New status: ok Commit summary for MediaWiki.r112018: Followup r111997 Remove unused $wgScript Fix missing brackets on the getUser() call Fix stuff and dbname typos $this-mGlobalUser isn't defined, use the $globalUser defined above ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112018]: New comment added
Reedy posted a comment on MediaWiki.r112018. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112018#c31303 Commit summary for MediaWiki.r112018: Followup r111997 Remove unused $wgScript Fix missing brackets on the getUser() call Fix stuff and dbname typos $this-mGlobalUser isn't defined, use the $globalUser defined above Reedy's comment: Your best bet is probably to use testwiki for things like this. Then if you need to put some debugging in for it, you can do var_dump(); die(); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105123]: Revision status changed
Johnduhart changed the status of MediaWiki.r105123 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105123 Old status: fixme New status: new Commit summary for MediaWiki.r105123: svn:eol-style native on all phase3 stuff, since I messed that up in r105122 Also adding the MWDebug class I missed there as well ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111947]: Revision status changed
Reedy changed the status of MediaWiki.r111947 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111947 Old status: new New status: ok Commit summary for MediaWiki.r111947: Show the username instead of 'The username $1 is not registered on this wiki, but it does exist in the unified login system.' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112019]: New comment added
Nikerabbit posted a comment on MediaWiki.r112019. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112019#c31304 Commit summary for MediaWiki.r112019: add basic utilities library going forward it would be nice to provide access to whatever library is used whether it is a basic set of functions for modules that cannot use jquery, jquery itself or something more minimal like zepto or xuijs the addClass and removeClass functions are needed for my next commit which will rewrite fullscreen search in the beta to use css Nikerabbit's comment: Reimplementing parts of jQuery? Isn't there any suitable small library that can be used? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Yaron Koren posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31305 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Yaron Koren's comment: Ah - I didn't know that having JS globals could cause problems. Well, that changes the situation - I guess we might as well drop support for MW 1.16 in SF already. So, I'll re-add your changes - or feel free to do that yourself. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109017]: New comment added
Yaron Koren posted a comment on MediaWiki.r109017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109017#c31306 Commit summary for MediaWiki.r109017: Revert of r108255 - too early to get rid of JS globals, since SF still supports MW 1.16. Hopefully these changes can be restored in the next six months or so, though Yaron Koren's comment: i.e., redo Nikerabbit's changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Problematic automated tweets
That's because the bot records the user's nick in the log message. On Tue, Feb 21, 2012 at 7:53 AM, Platonides platoni...@gmail.com wrote: It's interesting to note that the text 'jfaritu' which began the problematic texts was precisely pointing to the abuser's nick. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111796]: New comment added
Reedy posted a comment on MediaWiki.r111796. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111796#c31307 Commit summary for MediaWiki.r111796: fix for bug34431 - Disable the old toolbar if the new toolbar is enabled Reedy's comment: I'm not sure about using return false which will not allow any hooked functions after it to not be called... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112021]: Revision status changed
Reedy changed the status of MediaWiki.r112021 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112021 Old status: new New status: ok Commit summary for MediaWiki.r112021: Followup r105123, fix for MWDebug logging SQL queries on command line mode ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Git + Gerrit is a toughy
IMO you should ask Ryan to set up direct push access for your working branches Cool, will do. Does Ryan read this list? I'm not sure how MediaWiki should work, but maybe Gerrit should be set up like this by default? Either with a master + a production branch, or even just a master. Somewhere where only one branch needs review, and any other branches can be created and pushed at will, and review isn't needed until a merge to the master or production branch happens. Why did you merge master into your branch, rather than merging your branch into master? That doesn't make much sense to me. Hmm, maybe I did this wrong then. Is this something I should never do with git at all, or just with this Gerrit workflow? Isn't merging from master into my branches part of a regular workflow? Shouldn't I be merging in the code from master all the time as I work? Thanks Roan! We'll get this ironed out fo sho. -otto On Feb 18, 2012, at 2:31 AM, Roan Kattouw wrote: On Sat, Feb 18, 2012 at 2:47 AM, Andrew Otto o...@wikimedia.org wrote: 2. Do I need to rebase every time I push for review? I don't quite understand what is going on here. I've installed git-review and am using this to push to git. It does a rebase by default. I'm not sure if I should be turning that off or not. Rebases seem like a bad idea unless you really need to do them. I think git-review is doing a rebase by default so it can squash all of your local commits into one big review commit before pushing. Yuck! This would surely mean fewer commits to review in Gerrit, but it destroys real the history. It is making git work more like subversion, where you just work locally until everything is good and then have one big commit. I should be able to commit often and be able to share my commits with other developers before having everything reviewed. Yes, you need to rebase before you push. The rebase does not exist to squash multiple commits into one, but to ensure that your commit can be merged cleanly. This fits the gated trunk model, but it looks like you don't necessarily want to gate your working branch at all, just your master. IMO you should ask Ryan to set up direct push access for your working branches, so you can just git push into them directly, bypassing review. You can then merge your branch into master, and submit that merge commit for review. 3. How does Gerrit handle merges? Do all merge commits need to be re-approved? Yes. 4. What should I do in the following situation? I have a branch I recently made from master. I've made some changes and pushed them to gerrit. My changes have been approved. Now I want to sync master into my branch. I do git merge master Why did you merge master into your branch, rather than merging your branch into master? That doesn't make much sense to me. Then resolve any conflicts and commit. How should I push these changes? The commits that make up the merge have already been approved in gerrit on the master branch. Do I need to push for review using git-review? They've already been approved, so I would think not. But gerrit will currently not allow me to push without using git-review (is that because the commits need a Change-Id?). Yes, you need to submit the merge commit for review. If some commits don't have a Change-Id, git-review can't submit them, but I don't see how that could be the case. You said the commits were already approved in gerrit, *and* they don't have a Change-Id? Those things can't both be true. Since gerrit doesn't let me do a regular git push to push my master merge to the remote branch I am tracking, I do git-review. Perhaps you should ask for regular pushes to be allowed if you're not using the review workflow for that branch, see also above. This does rebase by default, so for some reason I am stuck having to resolve every single commit that was made to master in order to get the merge to push. This takes quite a while, but I did it, and once the interactive rebase was finished I was able to git-review to push the merge from master. Great. Now I that my branch is in sync with master again, I want to merge it into master. git checkout master git merge my_branch All good. Then what? Since I can't do just 'git push', I try git-review again. The same thing happens. I have to run through the whole interactive rebase routine and resolve each of my commits from my_branch manually. I do that, then run 'git-review' again. Now I get this error message: remote: Hint: A potential Change-Id was found, but it was not in the footer of the commit message. To ssh://o...@gerrit.wikimedia.org:29418/analytics/reportcard.git ! [remote rejected] HEAD - refs/for/master/master (missing Change-Id in commit message) error: failed to push some refs to 'ssh://o...@gerrit.wikimedia.org:29418/analytics/reportcard.git' Each of the commits I merged
[MediaWiki-CodeReview] [MediaWiki r112019]: New comment added
Jdlrobson posted a comment on MediaWiki.r112019. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112019#c31308 Commit summary for MediaWiki.r112019: add basic utilities library going forward it would be nice to provide access to whatever library is used whether it is a basic set of functions for modules that cannot use jquery, jquery itself or something more minimal like zepto or xuijs the addClass and removeClass functions are needed for my next commit which will rewrite fullscreen search in the beta to use css Jdlrobson's comment: Yes. There are several libraries including zepto [1] and xui [2]. I understand that several mobile devices cannot run jquery due to the payload of the library using up all their memory and crashing the browser and that these modules/plugins need to be able to run in native javascript or using a very slim library (I'm not sure if xui or zepto are slim enough as I am still new and familiarising myself with the problem space! ). Can anyone point me at links to these discussions? I know that the android app for wikipedia [1] currently uses jquery so I imagine a situation where the MobileFrontend extension could work with either jquery or some other library (in this case the utils library is a handwritten one which I agree is not a long term solution but would be interchangeable with jquery or zepto) and certain enhancements to the mobile frontend would only work in situations where a particular library was available. [1] https://github.com/madrobby/zepto [2] https://github.com/xui/xui [3] github.com/wikimedia/WikipediaMobile ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Problematic automated tweets
On 21/02/12 18:21, Ryan Lane wrote: That's because the bot records the user's nick in the log message. I know, but not everybody realised that. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git + Gerrit is a toughy
There is a bug in git that causes merge commits to not automatically get Change-IDs. After generating a merge commit, you need to run git commit --amend , then save without changing anything. That makes sure the commit-msg hook is run and the Change-ID is appended. Yeah, I tried this, but no luck :( waah. I'm googling and trying other things to commit, but I'm still a little lost. Also, any idea why git-review would say this every time I try to commit? [~/Projects/wm/analytics/reportcard] (master)[29c6b47]$ git-review You have more than one commit that you are about to submit. The outstanding commits are: 29c6b47 (HEAD, master) observation.py - comments 14a771a test commit for git branch push 73dd606 Buncha mini changes + hackiness to parse a few things. This really needs more work 2d37c13 pipeline/user_agent.py - adding comment that this file should not be used 5892eb8 Adding loader.py - first hacky loader, just so we can get some data into mysql to work with. e3fb30b Renaming the concept of variables to 'traits'. Allowing trait_sets to be specified so that we don't record HUGE amounts of data. d0de74b base.py - adding schema in comments. Got lots of work to do to make this prettier 328e55d Trying my darndest to clean things up here! I've cloned a new repo, and am checking in my non-committed (an non-approved?) changes into this new branch. Hopefully gerrit will be happier with me. This smells of me doing something really wrong. Thanks! -Ao On Feb 18, 2012, at 2:31 AM, Roan Kattouw wrote: On Sat, Feb 18, 2012 at 2:47 AM, Andrew Otto o...@wikimedia.org wrote: 2. Do I need to rebase every time I push for review? I don't quite understand what is going on here. I've installed git-review and am using this to push to git. It does a rebase by default. I'm not sure if I should be turning that off or not. Rebases seem like a bad idea unless you really need to do them. I think git-review is doing a rebase by default so it can squash all of your local commits into one big review commit before pushing. Yuck! This would surely mean fewer commits to review in Gerrit, but it destroys real the history. It is making git work more like subversion, where you just work locally until everything is good and then have one big commit. I should be able to commit often and be able to share my commits with other developers before having everything reviewed. Yes, you need to rebase before you push. The rebase does not exist to squash multiple commits into one, but to ensure that your commit can be merged cleanly. This fits the gated trunk model, but it looks like you don't necessarily want to gate your working branch at all, just your master. IMO you should ask Ryan to set up direct push access for your working branches, so you can just git push into them directly, bypassing review. You can then merge your branch into master, and submit that merge commit for review. 3. How does Gerrit handle merges? Do all merge commits need to be re-approved? Yes. 4. What should I do in the following situation? I have a branch I recently made from master. I've made some changes and pushed them to gerrit. My changes have been approved. Now I want to sync master into my branch. I do git merge master Why did you merge master into your branch, rather than merging your branch into master? That doesn't make much sense to me. Then resolve any conflicts and commit. How should I push these changes? The commits that make up the merge have already been approved in gerrit on the master branch. Do I need to push for review using git-review? They've already been approved, so I would think not. But gerrit will currently not allow me to push without using git-review (is that because the commits need a Change-Id?). Yes, you need to submit the merge commit for review. If some commits don't have a Change-Id, git-review can't submit them, but I don't see how that could be the case. You said the commits were already approved in gerrit, *and* they don't have a Change-Id? Those things can't both be true. Since gerrit doesn't let me do a regular git push to push my master merge to the remote branch I am tracking, I do git-review. Perhaps you should ask for regular pushes to be allowed if you're not using the review workflow for that branch, see also above. This does rebase by default, so for some reason I am stuck having to resolve every single commit that was made to master in order to get the merge to push. This takes quite a while, but I did it, and once the interactive rebase was finished I was able to git-review to push the merge from master. Great. Now I that my branch is in sync with master again, I want to merge it into master. git checkout master git merge my_branch All good. Then what? Since I can't do just 'git push', I try git-review again. The same thing happens. I have to run through
[MediaWiki-CodeReview] [MediaWiki r112030]: Revision status changed
GWicke changed the status of MediaWiki.r112030 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112030 Old status: new New status: deferred Commit summary for MediaWiki.r112030: Fix the bug in the inline_breaks replacement, and write another switch-based version, which is slightly faster and shorter. Performance is improved by about 5% for parserTests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] IRC office hours with the localization team on Februari 21
On Tue, Feb 21, 2012 at 1:11 AM, Gerard Meijssen gerard.meijs...@gmail.comwrote: Hoi, Today at 18:00 UTC (see also the link below) there is a Wikimedia Office hour with the WMF localisation team. The subject is what more can we do for your language. On my blog I entered some of the things we can talk about. We also love to hear about how what we already do works for you and what we (both you and us) can do to extend it further. Joining our office hours is a great way to celebrate International Mother Language Day. Thanks, Gerard http://www.timeanddate.com/worldclock/fixedtime.html?hour=18min=00sec=0day=21month=02year=2012 http://ultimategerardm.blogspot.com/2012/02/international-mother-language-day-2012.html This is happening now. :) Steven ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112029]: Revision status changed
MaxSem changed the status of MediaWiki.r112029 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112029 Old status: new New status: ok Commit summary for MediaWiki.r112029: MFT r111698, r111780 to attempt to shut up some of the warnings ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Using computer vision to categorize images at Commons
Hi MZMcBride, Op 20-2-2012 23:24, MZMcBride schreef: Maarten Dammers wrote: Some time ago I played around with computer vision to get images categorized on Commons. I documented this at https://commons.wikimedia.org/wiki/User:Multichill/Using_OpenCV_to_categorize_ files . I don't think I'm going to spend time on it soon, but the results were quite promising, so maybe someone else feels like working on this? Would probably be a pretty nice student project or just fun to do. Neat! :-) I've had some thoughts about the uses of this. Particularly doing fuzzy image matching to spot duplicates, rather than relying on the primitive hash of the contents of the file. If you want to find duplicate images you might want to play around with http://svn.wikimedia.org/viewvc/pywikipedia/trunk/pywikipedia/match_images.py?view=markup Maarten ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] About page ID
On Sun, Feb 19, 2012 at 5:49 AM, Sumana Harihareswara suma...@wikimedia.org wrote: On 02/19/2012 01:10 AM, John Erling Blad wrote: Some of the urls to Wikipedia will fail when converted by the mechanism in Twitter, so you either must use the ugly url in the tweet or use a short url. Because you usually want to control the overall length you must convert it to a short url before you know how long it will be. In my opinion it wold be better if there was a simple way to generate short urls that also identified Wikipedia as such. There is an extension for this: ShortURL: https://www.mediawiki.org/wiki/Extension:ShortUrl ShortUrl actually works by assigning a new ID number to represent a *page title*. This means that shortened links to a particular title will survive deletion/undeletion etc, and they still rely on redirects to handle page renames and things. I proposed using page id instead, but being a title-equivalent makes a lot of sense for linking since it'll retain the same semantics as linking with the full title URL. IIRC this ext was originally devised for the Indic-language wikis, which tend to have long illegible URLs because of the way characters are encoded (nine characters of URL for each character of title!). -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112025]: Revision status changed
Robmoen changed the status of MediaWiki.r112025 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112025 Old status: new New status: ok Commit summary for MediaWiki.r112025: lose focus on click bug and adjust search element and styling for iphone when you type in the search box and click back the text of the input is clipped on iphone. This seems to be because Safari adds padding to default styling. also fix issue where iphone/safari lose focus on click on clicking on the search area in safari/iphone the search box loses focus and the user must click again before typing this appears to be a glitch in Safari this can be remedied by changing the search input type from text to search ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112022]: Revision status changed
Robmoen changed the status of MediaWiki.r112022 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112022 Old status: new New status: ok Commit summary for MediaWiki.r112022: merge #nav definitions, also position relative declare position relative as otherwise a bug kicks in that renders the nav box incorrectly on iphone (top border does not show) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112031]: Revision status changed
GWicke changed the status of MediaWiki.r112031 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112031 Old status: new New status: deferred Commit summary for MediaWiki.r112031: Remove some more unused code and tidy up some more. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] 1.19 post-deployment bugs
On Fri, Feb 17, 2012 at 6:57 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: * Bug 34458: Editing fails in IE7 https://bugzilla.wikimedia.org/34458 This is has evidently been around a while so we don't *need* to block any deployments, but it would be nice to fix it This doesn't appear to actually block editing that I can tell; I get a JS error when the page loads but can still edit just fine (on meta where it's been reported to be an issue). -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111614]: New comment added
Awjrichards posted a comment on MediaWiki.r111614. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111614#c31309 Commit summary for MediaWiki.r111614: live hack to deal with 500s on log/RC views Awjrichards's comment: Should have mentioned this in my first comment, but I originally left this rev marked as 'New' rather than 'OK' since this change still is not reflected in trunk. The divergence might cause headaches/problems down the line. Perhaps there's a good reason for this, but no one has mentioned it yet - Aaron? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112032]: Revision status changed
GWicke changed the status of MediaWiki.r112032 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112032 Old status: new New status: deferred Commit summary for MediaWiki.r112032: Reduce debug print overhead, roughly a 10% speed-up on parserTests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112020]: New comment added, and revision status changed
Robmoen changed the status of MediaWiki.r112020 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112020#c31310 Old Status: new New Status: fixme Commit summary for MediaWiki.r112020: use css for the full screen search add full-screen-search class to body tag when conducting a full screen search make search width elastic so that when window resizes search size adjusts when writing results use javascript just to position and size results slight adjustment to fixtures to support positioning of results Robmoen's comment: preMobileFrontend.utils(document.body).removeClass(full-screen-search);/pre Please be sure to stay consistent with spacing conventions. pre+#remove-results/pre Please remove duplicate css property definitions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [GSoC 2012] Proposal - Realtime Collaboration on Visual Editor
I would be willing to mentor this project pending some further review so that we could scope it correctly. - Trevor On Sun, Feb 19, 2012 at 10:38 AM, Ashish Dubey ashish.dube...@gmail.comwrote: Hi Platonides You're right on the fact that its ambitious. And this is the reason I've started working early on this. The key part in the project to me would be to consolidate the concurrent transactions and avoid conflicts. I've been reading considerably on measures to do so, perhaps working to model basic concurrency control. Given, that I'm able to do so now, which I hope I will be, there should not be much problem prototyping the real thing. On Mon, Feb 20, 2012 at 12:04 AM, Platonides platoni...@gmail.com wrote: Are you confident you would be able to complete it in time? Looks too ambitious to me. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Ashish Dubey ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r98045]: New comment added
Brion VIBBER posted a comment on MediaWiki.r98045. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98045#c31311 Commit summary for MediaWiki.r98045: Improve the accessibility of our jump-to functionality - Stop hiding with display: none;, this hides our jump links from modern screen readers and users with motor disabilities (ie: nowadays, pratically everyone they are intended to help). - Instead hide with an overflow that will make the links viable tab targets. This alone is enough to help screen reader users. - Add in a script that will show the jump-links area on-focus for motor-impared users who can still see who have js enabled (this can't be done with css unfortunately) Brion VIBBER's comment: This causes a regression on cached pages, as the hiding doesn't get applied on the div. bug 34504 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98045]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r98045 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98045 Old status: ok New status: fixme Commit summary for MediaWiki.r98045: Improve the accessibility of our jump-to functionality - Stop hiding with display: none;, this hides our jump links from modern screen readers and users with motor disabilities (ie: nowadays, pratically everyone they are intended to help). - Instead hide with an overflow that will make the links viable tab targets. This alone is enough to help screen reader users. - Add in a script that will show the jump-links area on-focus for motor-impared users who can still see who have js enabled (this can't be done with css unfortunately) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111832]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r111832 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111832 Old status: new New status: ok Commit summary for MediaWiki.r111832: (bug 34421) duplicate Subject / wrong To: headers in mail This fixup our mail sending system which duplicated the Subject and To: header. In some conditions it used only the email address for the From: field skipping the username ($dest in old code only contains the email address). Mails sent to a single recipients will look alike with mail() or PEAR Mail. For multiple recipients: - php mail() will show the recipient email and 'undisclosed-recipients:' - PEAR Mail will only show 'undisclosed-recipients:' Reverts r111820 Follow r111819 Fixupr93397 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GSoC 2012 Ideas/Projects
On Mon, Feb 13, 2012 at 5:28 PM, Daniel Friesen li...@nadir-seen-fire.com wrote: The idea that login is secure because it's on a separate page than the rest of the site is actually an old mistake. If a script is included ANYWHERE on the site on the same domain then it's possible to inject in some code that will fake pageviews in a way that will let an attacker have a running script when the user follows the login link to the login page. So there isn't really any security advantage of a separate login page over an ajax login. (well ;) unless you're using the separate login page because you have js disabled, then you're safe, heh) Basically what the issue was is that if you're on an unencrypted HTTP pageview, you cannot trust the login form that gets AJAXed in, even if it submits to HTTPS. If the login form is transferred over HTTP (or the script that loads the login form is transferred over HTTP, or if *anything* comes on HTTP), it's not secure. Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Using computer vision to categorize images at Commons
I looked at perceptual hashing some time ago. A problem was that it had to keep the uncompressed image in memory, and it was slow for being applied on commons scale. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112034]: New comment added
Dantman posted a comment on MediaWiki.r112034. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112034#c31312 Commit summary for MediaWiki.r112034: Followup r98045: fix bug 34504 wrt Jump to links in cached pages showing unexpectedly after 1.19 upgrade Changed the updated styles to use the old (and still kept) id instead of the new (and thus not previously existing) class. Should work on both old and new pages now. Dantman's comment: The intent of the .mw-jump class was to replace the #jump-to-nav, just like the .mw-body. So that we don't have to force these id's on 3rd party skins. This'll break in 3rd party skins. It should contain both selectors. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112035]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112035 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112035 Old status: new New status: ok Commit summary for MediaWiki.r112035: Use local context to get messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112036]: New comment added
Aaron Schulz posted a comment on MediaWiki.r112036. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112036#c31313 Commit summary for MediaWiki.r112036: Pass __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit() Aaron Schulz's comment: rollback() does not have __METHOD__ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] New cryptographic random number generator up for review
On Tue, 21 Feb 2012 05:51:59 -0800, Antoine Musso hashar+...@free.fr wrote: Le 21/02/12 13:09, Chad a écrit : Please, no more branches. In fact, it would be super useful if everyone could find something else to do and stop committing entirely until after the migration;-) Hey guys, lets start an online encyclopedia written using a forum. I have started hacking PHPBB. -- The new Magnus No, no, not a wiki. Let's fork the basic core code we use in MediaWiki (routing code, WebRequest, database code, etc...) and turn it into a framework library that can be shared with other applications. And then use that to write a new blogging engine. Then we can ditch WordPress! -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
