Re: [Wireshark-dev] RPM generation

[Joakim Karlsson]

Hi,

>From what I notice when trying create rpm on RHEL7, is that CMake utilize
pkg-config, which is nice. But when ninja/make rpm-package is executed,
that part seems to stop. Instead we rely on rpm instead.

which cmake
/app/vbuild/RHEL7-x86_64/cmake/3.7.2-1/bin/cmake

cmake -G Ninja -DENABLE_GNUTLS=OFF -DENABLE_LZ4=OFF -DENABLE_CARES=OFF ../
..

ninja rpm-package
..
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.wOs6eR
..
+ /usr/bin/cmake -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG
-DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG
-DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG
-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_PREFIX:PATH=/usr/local
-DINCLUDE_INSTALL_DIR:PATH=/usr/local/include
-DLIB_INSTALL_DIR:PATH=/usr/local/lib64
-DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/local/share
-DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_wireshark=ON
-DENABLE_LUA=OFF -DBUILD_mmdbresolve=ON -DENABLE_LZ4=OFF
-DENABLE_SNAPPY=OFF -DENABLE_CARES=OFF -DENABLE_SPANDSP=ON
-DENABLE_BCG729=ON -DENABLE_LIBXML2=ON -DENABLE_NGHTTP2=OFF
-DDISABLE_WERROR=ON -G Ninja
CMake Error: CMake was unable to find a build program corresponding to
"Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a
different build tool.
CMake Error: Error required internal CMake variable not set, cmake may be
not be built correctly.
Missing variable is:
CMAKE_C_COMPILER_ENV_VAR
..
and more error...


Problem is the version of CMake, not the one I wanted.
/usr/bin/cmake --version
cmake version 2.8.12.2

What I found is in package/rpm/wireshark.spec.in:
BuildRequires: cmake
..
%cmake

This part will utilize rpm instead of what CMake setup for us, same for all
packages.
rpm --eval %cmake
..
  /usr/bin/cmake \
-DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \
-DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \
-DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \
-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
-DCMAKE_INSTALL_PREFIX:PATH=/usr \
-DINCLUDE_INSTALL_DIR:PATH=/usr/include \
-DLIB_INSTALL_DIR:PATH=/usr/lib64 \
-DSYSCONF_INSTALL_DIR:PATH=/etc \
-DSHARE_INSTALL_PREFIX:PATH=/usr/share \
%if "lib64" == "lib64"
-DLIB_SUFFIX=64 \
%endif
-DBUILD_SHARED_LIBS:BOOL=ON


A workaround I found was to create ~/.rpmmacros with content:
%__cmake %(which cmake)

Should we maybe have rpmmacros directly in package/rpm ?

And it doesn't seems that it respect the compile parameter check either,
same problem Anders had regarding
cc: error: unrecognized command line option '-Wheader-guard'
..
I see this faults too, but haven't found a solution for it


//Joakim




On 19 April 2018 at 22:09, Peter Wu  wrote:

> Hi Anders,
> On Thu, Apr 19, 2018 at 06:40:27PM +, Anders Broman wrote:
> > Hi,
> > Running cmake and make works
> > Cmake and make rpm-package fails on the make rpm-package part.
> > Included log from make rpm-package.
>
> I cannot see an obvious error, is it possible that you ran out of memory
> or disk space? Maybe there is something in CMakeError.log or something
> related to the custom CMake includes in your project.
> --
> Kind regards,
> Peter Wu
> https://lekensteyn.nl
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Peter Wu]

Hi Anders,
On Thu, Apr 19, 2018 at 06:40:27PM +, Anders Broman wrote:
> Hi,
> Running cmake and make works
> Cmake and make rpm-package fails on the make rpm-package part.
> Included log from make rpm-package.

I cannot see an obvious error, is it possible that you ran out of memory
or disk space? Maybe there is something in CMakeError.log or something
related to the custom CMake includes in your project.
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Peter Wu]

Hey Anders,

On Thu, Apr 19, 2018 at 05:59:18PM +, Anders Broman wrote:
> Hi,
> Logs included.

Could you include the normal CMake output? (Not the output or error log
file.)
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Peter Wu]

On Thu, Apr 19, 2018 at 10:46:19AM -0700, Guy Harris wrote:
> On Apr 19, 2018, at 9:44 AM, Peter Wu  wrote:
> 
> > Look for errors early in the process. For instance, without gcc-c++
> > installed on CentOS, I would get a very cryptic error down the road.
> 
> I.e., if you don't have C and C++ compilers installed, you get a very cryptic 
> error rather than a "hey, you need a C and C++ compiler to compile something 
> written in C and C++" error?  Or is it just an issue with the C++ compiler?
> 
> In either case, that's not good.

As far as I can remember, it did actually say that a C++ compiler was
missing, but it did not cause an immediate exit. A bit later, it started
complaining while checking for Qt.
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Guy Harris]

On Apr 19, 2018, at 9:44 AM, Peter Wu  wrote:

> Look for errors early in the process. For instance, without gcc-c++
> installed on CentOS, I would get a very cryptic error down the road.

I.e., if you don't have C and C++ compilers installed, you get a very cryptic 
error rather than a "hey, you need a C and C++ compiler to compile something 
written in C and C++" error?  Or is it just an issue with the C++ compiler?

In either case, that's not good.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Peter Wu]

On Thu, Apr 19, 2018 at 03:12:33PM +, Anders Broman wrote:
> Hi,
> I’m struggling with my local build now which is a SVN checkout. I have 
> managed to get the tarball built and the build continues from there but stops 
> with:
> 
> -- Found Subversion: /usr/bin/svn (found version "1.8.19")
> -- Configuring incomplete, errors occurred!
> See also 
> "/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeOutput.log".
> See also 
> "/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeError.log".
> error: Bad exit status from /var/tmp/rpm-tmp.RQPfyB (%prep)
> 
> RPM build errors:
> Bad exit status from /var/tmp/rpm-tmp.RQPfyB (%prep)
> CMakeFiles/rpm-package.dir/build.make:57: recipe for target 
> 'CMakeFiles/rpm-package' failed
> make[3]: *** [CMakeFiles/rpm-package] Error 1
> CMakeFiles/Makefile2:168: recipe for target 'CMakeFiles/rpm-package.dir/all' 
> failed
> make[2]: *** [CMakeFiles/rpm-package.dir/all] Error 2
> CMakeFiles/Makefile2:175: recipe for target 'CMakeFiles/rpm-package.dir/rule' 
> failed
> make[1]: *** [CMakeFiles/rpm-package.dir/rule] Error 2
> Makefile:201: recipe for target 'rpm-package' failed
> make: *** [rpm-package] Error 2
> 
> I don’t find anything obviously wrong in those log files, any tips what to 
> look for?
> In the error log there is:
> cc: error: unrecognized command line option '-Wheader-guard'

CMake is testing this option (like any other), if it only shows up in
the CMake logs, but not at compile time (make or ninja), it is harmless.

If it is not too large, can you provide the full cmake output?

Look for errors early in the process. For instance, without gcc-c++
installed on CentOS, I would get a very cryptic error down the road.
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Anders Broman]

Hi,
I’m struggling with my local build now which is a SVN checkout. I have managed 
to get the tarball built and the build continues from there but stops with:

-- Found Subversion: /usr/bin/svn (found version "1.8.19")
-- Configuring incomplete, errors occurred!
See also 
"/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeOutput.log".
See also 
"/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeError.log".
error: Bad exit status from /var/tmp/rpm-tmp.RQPfyB (%prep)

RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.RQPfyB (%prep)
CMakeFiles/rpm-package.dir/build.make:57: recipe for target 
'CMakeFiles/rpm-package' failed
make[3]: *** [CMakeFiles/rpm-package] Error 1
CMakeFiles/Makefile2:168: recipe for target 'CMakeFiles/rpm-package.dir/all' 
failed
make[2]: *** [CMakeFiles/rpm-package.dir/all] Error 2
CMakeFiles/Makefile2:175: recipe for target 'CMakeFiles/rpm-package.dir/rule' 
failed
make[1]: *** [CMakeFiles/rpm-package.dir/rule] Error 2
Makefile:201: recipe for target 'rpm-package' failed
make: *** [rpm-package] Error 2

I don’t find anything obviously wrong in those log files, any tips what to look 
for?
In the error log there is:
Run Build Command:"/usr/bin/gmake" "cmTC_ba3cc/fast"
gmake[4]: Entering directory 
'/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeTmp'
/usr/bin/gmake -f CMakeFiles/cmTC_ba3cc.dir/build.make 
CMakeFiles/cmTC_ba3cc.dir/build
gmake[5]: Entering directory 
'/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_ba3cc.dir/src.c.o
/usr/bin/cc-fexcess-precision=fast -std=gnu99 -O2 -g -m64 
-fmessage-length=0 -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables 
-fasynchronous-unwind-tables -DNDEBUG -DC__Wheader_guard_VALID -fPIE   
-fexcess-precision=fast -Wheader-guard -o CMakeFiles/cmTC_ba3cc.dir/src.c.o   
-c 
/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeTmp/src.c
cc: error: unrecognized command line option '-Wheader-guard'
CMakeFiles/cmTC_ba3cc.dir/build.make:65: recipe for target 
'CMakeFiles/cmTC_ba3cc.dir/src.c.o' failed
gmake[5]: *** [CMakeFiles/cmTC_ba3cc.dir/src.c.o] Error 1
gmake[5]: Leaving directory 
'/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeTmp'
Makefile:126: recipe for target 'cmTC_ba3cc/fast' failed
gmake[4]: *** [cmTC_ba3cc/fast] Error 2
gmake[4]: Leaving directory 
'/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeTmp'

Source file was:
int main(void) { return 0; }
Performing C SOURCE FILE Test C__Wunused_const_variable_VALID failed with the 
following output:
Change Dir: 
/home/ericsson/build-one/packaging/rpm/BUILD/wireshark-2.9-ESVN-4119/build/CMakeFiles/CMakeTmp

From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Dario Lombardo
Sent: den 11 april 2018 11:06
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Subject: Re: [Wireshark-dev] RPM generation

With the last changes I submitted, this is the current situation:

Centos:
ninja: works
make: works

openSUSE:
ninja/make: build now starts, but the compilation fails (cc: error: 
unrecognized command line option '-Wheader-guard'). This switch doesn't show up 
when running the straight 'ninja' command. Any idea?
Moreover I can't make regular compilation due to missing lz4-frame.h. Any idea 
on this as well?
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

On Mon, Apr 16, 2018 at 12:53 PM, Peter Wu  wrote:

>
> This seems to limit the rpm-package target to git trees, source tarballs
> seems unsupported, is that intentional? The autotools config did not
> have this limitation from what I can tell.
>

It _was_ limiting. Anders merged my last patch that fixed this. Now rpm
build is supported from anywhere.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Peter Wu]

On Mon, Apr 16, 2018 at 12:13:09PM +0200, Dario Lombardo wrote:
> I was just pointing out that sometimes (like the openSUSE %cmake
> macro) there is the general assumption that the build dir is under the
> source dir. This assumption can be found in wireshark/CMakeLists.txt,
> under the rpm-package target, where _git_description is set based on
> "git describe" output. This works if and only if the build dir is
> under the source dir and not if it's somewhere else.

This seems to limit the rpm-package target to git trees, source tarballs
seems unsupported, is that intentional? The autotools config did not
have this limitation from what I can tell.
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

On Mon, Apr 16, 2018 at 10:22 AM, Peter Wu  wrote:

>
> Which instructions? I looked for "cmake -" in the source tree, and all
> documentation in docbook/ suggest a build dir next to the source dir.
> The only example that creates a build dir in the source tree is the
> Gitlab CI configuration.
>

When searching on google about cmake, I usually find instructions like
"mkdir build;cd build;cmake ..;make". I didn't mean instructions related to
wireshark.


>
> The general recommendation is to do an out-of-tree build (where the
> build directory is not equal to the source tree). This could either be
> in-tree (mkdir build && cd build) or in a different location (mkdir
> /tmp/build && cd /tmp/build).
>

They are both perfectly fine, indeed. I was just pointing out that
sometimes (like the openSUSE %cmake macro) there is the general assumption
that the build dir is under the source dir. This assumption can be found in
wireshark/CMakeLists.txt, under the rpm-package target, where
_git_description is set based on "git describe" output. This works if and
only if the build dir is under the source dir and not if it's somewhere
else.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

Good! We can move forward autotools removal I guess. I'm working on it.

On Mon, Apr 16, 2018 at 10:57 AM, Anders Broman <anders.bro...@ericsson.com>
wrote:

> Hi,
> Building the RPMs works for me now - Thanks Dario!!!
> Regards
> Anders
>
> -Original Message-
> From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On
> Behalf Of Peter Wu
> Sent: den 16 april 2018 10:22
> To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
> Subject: Re: [Wireshark-dev] RPM generation
>
> On Mon, Apr 16, 2018 at 09:02:18AM +0200, Dario Lombardo wrote:
> > On Mon, Apr 16, 2018 at 5:32 AM, Anders Broman <a.broma...@gmail.com>
> wrote:
> >
> > >
> > > I followed the way I do it on Windows, which I think is the
> > > recommended way there :-)
> > >
> > >
> > The cmake instructions I found always suggest to have the build dir
> > under the source. For instance the openSUSE %cmake macro is an alias
> > for "cmake .. (plus options)"
>
> Which instructions? I looked for "cmake -" in the source tree, and all
> documentation in docbook/ suggest a build dir next to the source dir.
> The only example that creates a build dir in the source tree is the Gitlab
> CI configuration.
>
> The general recommendation is to do an out-of-tree build (where the build
> directory is not equal to the source tree). This could either be in-tree
> (mkdir build && cd build) or in a different location (mkdir /tmp/build &&
> cd /tmp/build).
>
> Personally I use both approaches: my main development has a source tree
> symlinked at /tmp/wireshark and a build directory at /tmp/wsbuild. When
> building from a temporary git worktree, I usually create a build directory
> within this tree for convenience:
>
> # Run from source directory, create a new source directory which
> # shares the same git repository:
> git worktree add /tmp/wireshark-2.4 master-2.4
> cd /tmp/wireshark-2.4
> # update master-2.4 branch
> git pull
> mkdir build && cd build && cmake -GNinja .. (other options here)
> # when done, go back to original source tree and wipe temp dir
> cd /tmp/wireshark
> rm -r /tmp/wireshark-2.4
> git worktree prune -v
> --
> Kind regards,
> Peter Wu
> https://lekensteyn.nl
> 
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
> 
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Anders Broman]

Hi,
Building the RPMs works for me now - Thanks Dario!!!
Regards
Anders

-Original Message-
From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Peter Wu
Sent: den 16 april 2018 10:22
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Subject: Re: [Wireshark-dev] RPM generation

On Mon, Apr 16, 2018 at 09:02:18AM +0200, Dario Lombardo wrote:
> On Mon, Apr 16, 2018 at 5:32 AM, Anders Broman <a.broma...@gmail.com> wrote:
> 
> >
> > I followed the way I do it on Windows, which I think is the 
> > recommended way there :-)
> >
> >
> The cmake instructions I found always suggest to have the build dir 
> under the source. For instance the openSUSE %cmake macro is an alias 
> for "cmake .. (plus options)"

Which instructions? I looked for "cmake -" in the source tree, and all 
documentation in docbook/ suggest a build dir next to the source dir.
The only example that creates a build dir in the source tree is the Gitlab CI 
configuration.

The general recommendation is to do an out-of-tree build (where the build 
directory is not equal to the source tree). This could either be in-tree (mkdir 
build && cd build) or in a different location (mkdir /tmp/build && cd 
/tmp/build).

Personally I use both approaches: my main development has a source tree 
symlinked at /tmp/wireshark and a build directory at /tmp/wsbuild. When 
building from a temporary git worktree, I usually create a build directory 
within this tree for convenience:

# Run from source directory, create a new source directory which
# shares the same git repository:
git worktree add /tmp/wireshark-2.4 master-2.4
cd /tmp/wireshark-2.4
# update master-2.4 branch
git pull
mkdir build && cd build && cmake -GNinja .. (other options here)
# when done, go back to original source tree and wipe temp dir
cd /tmp/wireshark
rm -r /tmp/wireshark-2.4
git worktree prune -v
--
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Peter Wu]

On Mon, Apr 16, 2018 at 09:02:18AM +0200, Dario Lombardo wrote:
> On Mon, Apr 16, 2018 at 5:32 AM, Anders Broman  wrote:
> 
> >
> > I followed the way I do it on Windows, which I think is the recommended
> > way there :-)
> >
> >
> The cmake instructions I found always suggest to have the build dir under
> the source. For instance the openSUSE %cmake macro is an alias for "cmake
> .. (plus options)"

Which instructions? I looked for "cmake -" in the source tree, and all
documentation in docbook/ suggest a build dir next to the source dir.
The only example that creates a build dir in the source tree is the
Gitlab CI configuration.

The general recommendation is to do an out-of-tree build (where the
build directory is not equal to the source tree). This could either be
in-tree (mkdir build && cd build) or in a different location (mkdir
/tmp/build && cd /tmp/build).

Personally I use both approaches: my main development has a source tree
symlinked at /tmp/wireshark and a build directory at /tmp/wsbuild. When
building from a temporary git worktree, I usually create a build
directory within this tree for convenience:

# Run from source directory, create a new source directory which
# shares the same git repository:
git worktree add /tmp/wireshark-2.4 master-2.4
cd /tmp/wireshark-2.4
# update master-2.4 branch
git pull
mkdir build && cd build && cmake -GNinja .. (other options here)
# when done, go back to original source tree and wipe temp dir
cd /tmp/wireshark
rm -r /tmp/wireshark-2.4
git worktree prune -v
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

On Mon, Apr 16, 2018 at 5:32 AM, Anders Broman  wrote:

>
> I followed the way I do it on Windows, which I think is the recommended
> way there :-)
>
>
The cmake instructions I found always suggest to have the build dir under
the source. For instance the openSUSE %cmake macro is an alias for "cmake
.. (plus options)"
But your method is perfectly fine, and that's the reason why I tried to fix
the rpm generation this way.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Anders Broman]

Den sön 15 apr. 2018 23:05Dario Lombardo 
skrev:

> Ok, I got the point. I always built the rpm from a build dir under the
> source dir.
> With your approach, the rpm-package target fails because of the lack of a
> parent git directory. It expects to retrieve the current version using 'git
> describe', and it can't because it has no clue on where the sources are.
> However I found a solution that leverages the fact that the export archive
> ships with the version number. This problem is not strictly openSUSE
> related, but shared across all platforms. It didn't pop up before because
> the common (suggested) approach is to have a build dir under the sources.
>

I followed the way I do it on Windows, which I think is the recommended way
there :-)


I'm pushing a new change that should solve your last issue, and you should
> be able to build the rpm again. Let me know.
> Dario.
>
> On Fri, Apr 13, 2018 at 4:35 PM, Anders Broman 
> wrote:
>
>> Hi,
>> I have the git repo in /home/ericsson/wireshark/
>> And build in
>> /home/ericsson/build/
>>
>> In the Build dir I run the cmake command with... /wireshark
>> And then make rpm-package
>>
>> Regards
>> Anders
>>
>>
>>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

Ok, I got the point. I always built the rpm from a build dir under the
source dir.
With your approach, the rpm-package target fails because of the lack of a
parent git directory. It expects to retrieve the current version using 'git
describe', and it can't because it has no clue on where the sources are.
However I found a solution that leverages the fact that the export archive
ships with the version number. This problem is not strictly openSUSE
related, but shared across all platforms. It didn't pop up before because
the common (suggested) approach is to have a build dir under the sources.
I'm pushing a new change that should solve your last issue, and you should
be able to build the rpm again. Let me know.
Dario.

On Fri, Apr 13, 2018 at 4:35 PM, Anders Broman  wrote:

> Hi,
> I have the git repo in /home/ericsson/wireshark/
> And build in
> /home/ericsson/build/
>
> In the Build dir I run the cmake command with... /wireshark
> And then make rpm-package
>
> Regards
> Anders
>
>
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Anders Broman]

According to git log the patches seems to be there…
Regards
Anders Broman
commit c369c295097f4377527e989df1658effb6497735
Author: Dario Lombardo <lom...@gmail.com>
Date:   Fri Apr 13 08:55:05 2018 +0200

RPM: restore the bindir in openSUSE before packing.

Change-Id: I6e60d1a299528c0f1603b56704a8c47f18c66d08

commit 93c23bf563d483e5a7d5d959b6f33a38099ee15e
Author: Dario Lombardo <lom...@gmail.com>
Date:   Thu Apr 12 18:07:00 2018 +0200

RPM: install wireshark.desktop in /usr/share/applications.

The presence of this file in /usr/share/applications in required by
suse_update_desktop_file, as described here:

https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros#.25suse_up
date_desktop_file

Change-Id: I88573afca2d4523a1b305bf4dc672c421c2fa1d1

commit 175c05234c2a5c05c651cf6d47772f8f3b389286
lines 1-22
date_desktop_file

Change-Id: I88573afca2d4523a1b305bf4dc672c421c2fa1d1

commit 175c05234c2a5c05c651cf6d47772f8f3b389286
Author: Dario Lombardo <lom...@gmail.com>
Date:   Thu Apr 12 17:55:22 2018 +0200

RPM: cd into build dir in openSUSE.

This step is needed because of the differences in the %cmake macro
between Fedora/Centos and openSUSE.

Change-Id: I7ac94e560b4c298934f78e96036a814f3eadc4a5

commit 638eb5ce66030d04916e934ebdd24e62f6b06f86
Author: Dario Lombardo <lom...@gmail.com>
Date:   Wed Apr 11 14:37:53 2018 +0200

kafka: raise the required version to 1.5.0 for lz4_frame.

Change-Id: I25619260572163872915c56bcf242e8ff8190b47

lines 18-40

From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Dario Lombardo
Sent: den 14 april 2018 09:36
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Subject: Re: [Wireshark-dev] RPM generation

It depends. Gerrit gives you few suggestions: cherry-pick takes just the 
current change, checkout and pull take all the changes in the branch.

On Sat, Apr 14, 2018, 07:45 Anders Broman 
<a.broma...@gmail.com<mailto:a.broma...@gmail.com>> wrote:
I thought picking the last one would include them all as the are in the same 
branch. I'll check, but I might not be able to until Monday.
Regards
Anders

Den fre 13 apr. 2018 21:57Dario Lombardo 
<dario.lombardo...@gmail.com<mailto:dario.lombardo...@gmail.com>> skrev:
Did you cherry-picked all my rpm changes? there are 3 not merged yet and you 
need them all.

On Fri, Apr 13, 2018, 16:35 Anders Broman 
<a.broma...@gmail.com<mailto:a.broma...@gmail.com>> wrote:
Hi,
I have the git repo in /home/ericsson/wireshark/
And build in
/home/ericsson/build/

In the Build dir I run the cmake command with... /wireshark
And then make rpm-package

Regards
Anders

Den fre 13 apr. 2018 15:55Dario Lombardo 
<dario.lombardo...@gmail.com<mailto:dario.lombardo...@gmail.com>> skrev:
Can you give me the steps you made?

On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman 
<anders.bro...@ericsson.com<mailto:anders.bro...@ericsson.com>> wrote:
Hi,
Checking out branch:
commit c369c295097f4377527e989df1658effb6497735
Author: Dario Lombardo <lom...@gmail.com<mailto:lom...@gmail.com>>
Date:   Fri Apr 13 08:55:05 2018 +0200

I still get:
-- The following OPTIONAL packages have not been found:

* BCG729 , G.729 decoder , 
<https://www.linphone.org/technical-corner/bcg729/overview>
   Support for G.729 codec in RTP player
* DOXYGEN
* MaxMindDB

fatal: Not a git repository (or any of the parent directories): .git
CMake Error at CMakeLists.txt:2934 (string):
  string begin index: 1 is out of range 0 - 0


-- Configuring incomplete, errors occurred!


Regards
Anders

From: Wireshark-dev 
[mailto:wireshark-dev-boun...@wireshark.org<mailto:wireshark-dev-boun...@wireshark.org>]
 On Behalf Of Dario Lombardo
Sent: den 13 april 2018 13:37
To: Developer support list for Wireshark 
<wireshark-dev@wireshark.org<mailto:wireshark-dev@wireshark.org>>
Subject: Re: [Wireshark-dev] RPM generation

With the last changes pushed, I'm able to make openSUSE work. Since this was 
pointed out as blocking for autotools removal, we can proceed, as soon as 
Anders confirms.
Anyone already working on autotools removal?

On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo 
<dario.lombardo...@gmail.com<mailto:dario.lombardo...@gmail.com>> wrote:
Perfect. Centos, Fedora and openSUSE are the three under testing. openSUSE is 
rather different from the others, and I'm pushing some changes specific for 
that, trying not to break the others :).

On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss 
<jeff.morriss...@gmail.com<mailto:jeff.morriss...@gmail.com>> wrote:
On 04/10/2018 09:14 AM, Dario Lombardo wrote:
Is the rpm build platform expected to be one? If yes, which one? If no, do we 
want to support all the flavors? It seems that different flavors require 
different package names (link in asciidoctor). I can be hard to be portable in 
this way.

The c

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

It depends. Gerrit gives you few suggestions: cherry-pick takes just the
current change, checkout and pull take all the changes in the branch.

On Sat, Apr 14, 2018, 07:45 Anders Broman <a.broma...@gmail.com> wrote:

> I thought picking the last one would include them all as the are in the
> same branch. I'll check, but I might not be able to until Monday.
> Regards
> Anders
>
> Den fre 13 apr. 2018 21:57Dario Lombardo <dario.lombardo...@gmail.com>
> skrev:
>
>> Did you cherry-picked all my rpm changes? there are 3 not merged yet and
>> you need them all.
>>
>> On Fri, Apr 13, 2018, 16:35 Anders Broman <a.broma...@gmail.com> wrote:
>>
>>> Hi,
>>> I have the git repo in /home/ericsson/wireshark/
>>> And build in
>>> /home/ericsson/build/
>>>
>>> In the Build dir I run the cmake command with... /wireshark
>>> And then make rpm-package
>>>
>>> Regards
>>> Anders
>>>
>>> Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo...@gmail.com>
>>> skrev:
>>>
>>>> Can you give me the steps you made?
>>>>
>>>> On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <
>>>> anders.bro...@ericsson.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Checking out branch:
>>>>>
>>>>> commit c369c295097f4377527e989df1658effb6497735
>>>>>
>>>>> Author: Dario Lombardo <lom...@gmail.com>
>>>>>
>>>>> Date:   Fri Apr 13 08:55:05 2018 +0200
>>>>>
>>>>>
>>>>>
>>>>> I still get:
>>>>>
>>>>> -- The following OPTIONAL packages have not been found:
>>>>>
>>>>>
>>>>>
>>>>> * BCG729 , G.729 decoder , <
>>>>> https://www.linphone.org/technical-corner/bcg729/overview>
>>>>>
>>>>>Support for G.729 codec in RTP player
>>>>>
>>>>> * DOXYGEN
>>>>>
>>>>> * MaxMindDB
>>>>>
>>>>>
>>>>>
>>>>> fatal: Not a git repository (or any of the parent directories): .git
>>>>>
>>>>> CMake Error at CMakeLists.txt:2934 (string):
>>>>>
>>>>>   string begin index: 1 is out of range 0 - 0
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -- Configuring incomplete, errors occurred!
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Regards
>>>>>
>>>>> Anders
>>>>>
>>>>>
>>>>>
>>>>> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
>>>>> Behalf Of *Dario Lombardo
>>>>> *Sent:* den 13 april 2018 13:37
>>>>> *To:* Developer support list for Wireshark <
>>>>> wireshark-dev@wireshark.org>
>>>>> *Subject:* Re: [Wireshark-dev] RPM generation
>>>>>
>>>>>
>>>>>
>>>>> With the last changes pushed, I'm able to make openSUSE work. Since
>>>>> this was pointed out as blocking for autotools removal, we can proceed, as
>>>>> soon as Anders confirms.
>>>>>
>>>>> Anyone already working on autotools removal?
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
>>>>> dario.lombardo...@gmail.com> wrote:
>>>>>
>>>>> Perfect. Centos, Fedora and openSUSE are the three under testing.
>>>>> openSUSE is rather different from the others, and I'm pushing some changes
>>>>> specific for that, trying not to break the others :).
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <
>>>>> jeff.morriss...@gmail.com> wrote:
>>>>>
>>>>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>>>>
>>>>> Is the rpm build platform expected to be one? If yes, which one? If
>>>>> no, do we want to support all the flavors? It seems that different flavors
>>>>> require different package names (link in asciidoctor). I can be hard to be
>>>>> portable in this way.
>>>>>
>>>>>
>>>>> Th

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

Did you cherry-picked all my rpm changes? there are 3 not merged yet and
you need them all.

On Fri, Apr 13, 2018, 16:35 Anders Broman <a.broma...@gmail.com> wrote:

> Hi,
> I have the git repo in /home/ericsson/wireshark/
> And build in
> /home/ericsson/build/
>
> In the Build dir I run the cmake command with... /wireshark
> And then make rpm-package
>
> Regards
> Anders
>
> Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo...@gmail.com>
> skrev:
>
>> Can you give me the steps you made?
>>
>> On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <
>> anders.bro...@ericsson.com> wrote:
>>
>>> Hi,
>>>
>>> Checking out branch:
>>>
>>> commit c369c295097f4377527e989df1658effb6497735
>>>
>>> Author: Dario Lombardo <lom...@gmail.com>
>>>
>>> Date:   Fri Apr 13 08:55:05 2018 +0200
>>>
>>>
>>>
>>> I still get:
>>>
>>> -- The following OPTIONAL packages have not been found:
>>>
>>>
>>>
>>> * BCG729 , G.729 decoder , <
>>> https://www.linphone.org/technical-corner/bcg729/overview>
>>>
>>>Support for G.729 codec in RTP player
>>>
>>> * DOXYGEN
>>>
>>> * MaxMindDB
>>>
>>>
>>>
>>> fatal: Not a git repository (or any of the parent directories): .git
>>>
>>> CMake Error at CMakeLists.txt:2934 (string):
>>>
>>>   string begin index: 1 is out of range 0 - 0
>>>
>>>
>>>
>>>
>>>
>>> -- Configuring incomplete, errors occurred!
>>>
>>>
>>>
>>>
>>>
>>> Regards
>>>
>>> Anders
>>>
>>>
>>>
>>> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
>>> Behalf Of *Dario Lombardo
>>> *Sent:* den 13 april 2018 13:37
>>> *To:* Developer support list for Wireshark <wireshark-dev@wireshark.org>
>>> *Subject:* Re: [Wireshark-dev] RPM generation
>>>
>>>
>>>
>>> With the last changes pushed, I'm able to make openSUSE work. Since this
>>> was pointed out as blocking for autotools removal, we can proceed, as soon
>>> as Anders confirms.
>>>
>>> Anyone already working on autotools removal?
>>>
>>>
>>>
>>> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
>>> dario.lombardo...@gmail.com> wrote:
>>>
>>> Perfect. Centos, Fedora and openSUSE are the three under testing.
>>> openSUSE is rather different from the others, and I'm pushing some changes
>>> specific for that, trying not to break the others :).
>>>
>>>
>>>
>>> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <jeff.morriss...@gmail.com>
>>> wrote:
>>>
>>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>>
>>> Is the rpm build platform expected to be one? If yes, which one? If no,
>>> do we want to support all the flavors? It seems that different flavors
>>> require different package names (link in asciidoctor). I can be hard to be
>>> portable in this way.
>>>
>>>
>>> The current RPM build tries to support SUSE and Red Hat/Fedora--the
>>> former for Anders and the latter for the rest of the world :-).  I don't
>>> recall seeing requests for other distributions.
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>> mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>>
>>>
>>>
>>>
>>>
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>>
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

It depends. Gerrit gives you few suggestions: cherry-pick takes just the
current change, checkout and pull take all the changes in the branch.

On Sat, Apr 14, 2018, 07:45 Anders Broman <a.broma...@gmail.com> wrote:

> I thought picking the last one would include them all as the are in the
> same branch. I'll check, but I might not be able to until Monday.
> Regards
> Anders
>
> Den fre 13 apr. 2018 21:57Dario Lombardo <dario.lombardo...@gmail.com>
> skrev:
>
>> Did you cherry-picked all my rpm changes? there are 3 not merged yet and
>> you need them all.
>>
>> On Fri, Apr 13, 2018, 16:35 Anders Broman <a.broma...@gmail.com> wrote:
>>
>>> Hi,
>>> I have the git repo in /home/ericsson/wireshark/
>>> And build in
>>> /home/ericsson/build/
>>>
>>> In the Build dir I run the cmake command with... /wireshark
>>> And then make rpm-package
>>>
>>> Regards
>>> Anders
>>>
>>> Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo...@gmail.com>
>>> skrev:
>>>
>>>> Can you give me the steps you made?
>>>>
>>>> On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <
>>>> anders.bro...@ericsson.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Checking out branch:
>>>>>
>>>>> commit c369c295097f4377527e989df1658effb6497735
>>>>>
>>>>> Author: Dario Lombardo <lom...@gmail.com>
>>>>>
>>>>> Date:   Fri Apr 13 08:55:05 2018 +0200
>>>>>
>>>>>
>>>>>
>>>>> I still get:
>>>>>
>>>>> -- The following OPTIONAL packages have not been found:
>>>>>
>>>>>
>>>>>
>>>>> * BCG729 , G.729 decoder , <
>>>>> https://www.linphone.org/technical-corner/bcg729/overview>
>>>>>
>>>>>Support for G.729 codec in RTP player
>>>>>
>>>>> * DOXYGEN
>>>>>
>>>>> * MaxMindDB
>>>>>
>>>>>
>>>>>
>>>>> fatal: Not a git repository (or any of the parent directories): .git
>>>>>
>>>>> CMake Error at CMakeLists.txt:2934 (string):
>>>>>
>>>>>   string begin index: 1 is out of range 0 - 0
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -- Configuring incomplete, errors occurred!
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Regards
>>>>>
>>>>> Anders
>>>>>
>>>>>
>>>>>
>>>>> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
>>>>> Behalf Of *Dario Lombardo
>>>>> *Sent:* den 13 april 2018 13:37
>>>>> *To:* Developer support list for Wireshark <
>>>>> wireshark-dev@wireshark.org>
>>>>> *Subject:* Re: [Wireshark-dev] RPM generation
>>>>>
>>>>>
>>>>>
>>>>> With the last changes pushed, I'm able to make openSUSE work. Since
>>>>> this was pointed out as blocking for autotools removal, we can proceed, as
>>>>> soon as Anders confirms.
>>>>>
>>>>> Anyone already working on autotools removal?
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
>>>>> dario.lombardo...@gmail.com> wrote:
>>>>>
>>>>> Perfect. Centos, Fedora and openSUSE are the three under testing.
>>>>> openSUSE is rather different from the others, and I'm pushing some changes
>>>>> specific for that, trying not to break the others :).
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <
>>>>> jeff.morriss...@gmail.com> wrote:
>>>>>
>>>>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>>>>
>>>>> Is the rpm build platform expected to be one? If yes, which one? If
>>>>> no, do we want to support all the flavors? It seems that different flavors
>>>>> require different package names (link in asciidoctor). I can be hard to be
>>>>> portable in this way.
>>>>>
>>>>>
>>>>> Th

Re: [Wireshark-dev] RPM generation

[Anders Broman]

I thought picking the last one would include them all as the are in the
same branch. I'll check, but I might not be able to until Monday.
Regards
Anders

Den fre 13 apr. 2018 21:57Dario Lombardo <dario.lombardo...@gmail.com>
skrev:

> Did you cherry-picked all my rpm changes? there are 3 not merged yet and
> you need them all.
>
> On Fri, Apr 13, 2018, 16:35 Anders Broman <a.broma...@gmail.com> wrote:
>
>> Hi,
>> I have the git repo in /home/ericsson/wireshark/
>> And build in
>> /home/ericsson/build/
>>
>> In the Build dir I run the cmake command with... /wireshark
>> And then make rpm-package
>>
>> Regards
>> Anders
>>
>> Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo...@gmail.com>
>> skrev:
>>
>>> Can you give me the steps you made?
>>>
>>> On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <
>>> anders.bro...@ericsson.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Checking out branch:
>>>>
>>>> commit c369c295097f4377527e989df1658effb6497735
>>>>
>>>> Author: Dario Lombardo <lom...@gmail.com>
>>>>
>>>> Date:   Fri Apr 13 08:55:05 2018 +0200
>>>>
>>>>
>>>>
>>>> I still get:
>>>>
>>>> -- The following OPTIONAL packages have not been found:
>>>>
>>>>
>>>>
>>>> * BCG729 , G.729 decoder , <
>>>> https://www.linphone.org/technical-corner/bcg729/overview>
>>>>
>>>>Support for G.729 codec in RTP player
>>>>
>>>> * DOXYGEN
>>>>
>>>> * MaxMindDB
>>>>
>>>>
>>>>
>>>> fatal: Not a git repository (or any of the parent directories): .git
>>>>
>>>> CMake Error at CMakeLists.txt:2934 (string):
>>>>
>>>>   string begin index: 1 is out of range 0 - 0
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> -- Configuring incomplete, errors occurred!
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Regards
>>>>
>>>> Anders
>>>>
>>>>
>>>>
>>>> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
>>>> Behalf Of *Dario Lombardo
>>>> *Sent:* den 13 april 2018 13:37
>>>> *To:* Developer support list for Wireshark <wireshark-dev@wireshark.org
>>>> >
>>>> *Subject:* Re: [Wireshark-dev] RPM generation
>>>>
>>>>
>>>>
>>>> With the last changes pushed, I'm able to make openSUSE work. Since
>>>> this was pointed out as blocking for autotools removal, we can proceed, as
>>>> soon as Anders confirms.
>>>>
>>>> Anyone already working on autotools removal?
>>>>
>>>>
>>>>
>>>> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
>>>> dario.lombardo...@gmail.com> wrote:
>>>>
>>>> Perfect. Centos, Fedora and openSUSE are the three under testing.
>>>> openSUSE is rather different from the others, and I'm pushing some changes
>>>> specific for that, trying not to break the others :).
>>>>
>>>>
>>>>
>>>> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <
>>>> jeff.morriss...@gmail.com> wrote:
>>>>
>>>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>>>
>>>> Is the rpm build platform expected to be one? If yes, which one? If no,
>>>> do we want to support all the flavors? It seems that different flavors
>>>> require different package names (link in asciidoctor). I can be hard to be
>>>> portable in this way.
>>>>
>>>>
>>>> The current RPM build tries to support SUSE and Red Hat/Fedora--the
>>>> former for Anders and the latter for the rest of the world :-).  I don't
>>>> recall seeing requests for other distributions.
>>>>
>>>> ___
>>>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>> mailto:wireshark-dev-requ...@wireshark.org
>>>> ?subject=unsubscribe
>>>>
>>&g

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

Did you cherry-picked all my rpm changes? there are 3 not merged yet and
you need them all.

On Fri, Apr 13, 2018, 16:35 Anders Broman <a.broma...@gmail.com> wrote:

> Hi,
> I have the git repo in /home/ericsson/wireshark/
> And build in
> /home/ericsson/build/
>
> In the Build dir I run the cmake command with... /wireshark
> And then make rpm-package
>
> Regards
> Anders
>
> Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo...@gmail.com>
> skrev:
>
>> Can you give me the steps you made?
>>
>> On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <
>> anders.bro...@ericsson.com> wrote:
>>
>>> Hi,
>>>
>>> Checking out branch:
>>>
>>> commit c369c295097f4377527e989df1658effb6497735
>>>
>>> Author: Dario Lombardo <lom...@gmail.com>
>>>
>>> Date:   Fri Apr 13 08:55:05 2018 +0200
>>>
>>>
>>>
>>> I still get:
>>>
>>> -- The following OPTIONAL packages have not been found:
>>>
>>>
>>>
>>> * BCG729 , G.729 decoder , <
>>> https://www.linphone.org/technical-corner/bcg729/overview>
>>>
>>>Support for G.729 codec in RTP player
>>>
>>> * DOXYGEN
>>>
>>> * MaxMindDB
>>>
>>>
>>>
>>> fatal: Not a git repository (or any of the parent directories): .git
>>>
>>> CMake Error at CMakeLists.txt:2934 (string):
>>>
>>>   string begin index: 1 is out of range 0 - 0
>>>
>>>
>>>
>>>
>>>
>>> -- Configuring incomplete, errors occurred!
>>>
>>>
>>>
>>>
>>>
>>> Regards
>>>
>>> Anders
>>>
>>>
>>>
>>> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
>>> Behalf Of *Dario Lombardo
>>> *Sent:* den 13 april 2018 13:37
>>> *To:* Developer support list for Wireshark <wireshark-dev@wireshark.org>
>>> *Subject:* Re: [Wireshark-dev] RPM generation
>>>
>>>
>>>
>>> With the last changes pushed, I'm able to make openSUSE work. Since this
>>> was pointed out as blocking for autotools removal, we can proceed, as soon
>>> as Anders confirms.
>>>
>>> Anyone already working on autotools removal?
>>>
>>>
>>>
>>> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
>>> dario.lombardo...@gmail.com> wrote:
>>>
>>> Perfect. Centos, Fedora and openSUSE are the three under testing.
>>> openSUSE is rather different from the others, and I'm pushing some changes
>>> specific for that, trying not to break the others :).
>>>
>>>
>>>
>>> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <jeff.morriss...@gmail.com>
>>> wrote:
>>>
>>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>>
>>> Is the rpm build platform expected to be one? If yes, which one? If no,
>>> do we want to support all the flavors? It seems that different flavors
>>> require different package names (link in asciidoctor). I can be hard to be
>>> portable in this way.
>>>
>>>
>>> The current RPM build tries to support SUSE and Red Hat/Fedora--the
>>> former for Anders and the latter for the rest of the world :-).  I don't
>>> recall seeing requests for other distributions.
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>> mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>>
>>>
>>>
>>>
>>>
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>>
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Anders Broman]

Hi,
I have the git repo in /home/ericsson/wireshark/
And build in
/home/ericsson/build/

In the Build dir I run the cmake command with... /wireshark
And then make rpm-package

Regards
Anders

Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo...@gmail.com>
skrev:

> Can you give me the steps you made?
>
> On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <anders.bro...@ericsson.com
> > wrote:
>
>> Hi,
>>
>> Checking out branch:
>>
>> commit c369c295097f4377527e989df1658effb6497735
>>
>> Author: Dario Lombardo <lom...@gmail.com>
>>
>> Date:   Fri Apr 13 08:55:05 2018 +0200
>>
>>
>>
>> I still get:
>>
>> -- The following OPTIONAL packages have not been found:
>>
>>
>>
>> * BCG729 , G.729 decoder , <
>> https://www.linphone.org/technical-corner/bcg729/overview>
>>
>>Support for G.729 codec in RTP player
>>
>> * DOXYGEN
>>
>> * MaxMindDB
>>
>>
>>
>> fatal: Not a git repository (or any of the parent directories): .git
>>
>> CMake Error at CMakeLists.txt:2934 (string):
>>
>>   string begin index: 1 is out of range 0 - 0
>>
>>
>>
>>
>>
>> -- Configuring incomplete, errors occurred!
>>
>>
>>
>>
>>
>> Regards
>>
>> Anders
>>
>>
>>
>> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
>> Behalf Of *Dario Lombardo
>> *Sent:* den 13 april 2018 13:37
>> *To:* Developer support list for Wireshark <wireshark-dev@wireshark.org>
>> *Subject:* Re: [Wireshark-dev] RPM generation
>>
>>
>>
>> With the last changes pushed, I'm able to make openSUSE work. Since this
>> was pointed out as blocking for autotools removal, we can proceed, as soon
>> as Anders confirms.
>>
>> Anyone already working on autotools removal?
>>
>>
>>
>> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
>> dario.lombardo...@gmail.com> wrote:
>>
>> Perfect. Centos, Fedora and openSUSE are the three under testing.
>> openSUSE is rather different from the others, and I'm pushing some changes
>> specific for that, trying not to break the others :).
>>
>>
>>
>> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <jeff.morriss...@gmail.com>
>> wrote:
>>
>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>
>> Is the rpm build platform expected to be one? If yes, which one? If no,
>> do we want to support all the flavors? It seems that different flavors
>> require different package names (link in asciidoctor). I can be hard to be
>> portable in this way.
>>
>>
>> The current RPM build tries to support SUSE and Red Hat/Fedora--the
>> former for Anders and the latter for the rest of the world :-).  I don't
>> recall seeing requests for other distributions.
>>
>> ___
>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>> mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>>
>>
>>
>>
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>>
>
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

Can you give me the steps you made?

On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <anders.bro...@ericsson.com>
wrote:

> Hi,
>
> Checking out branch:
>
> commit c369c295097f4377527e989df1658effb6497735
>
> Author: Dario Lombardo <lom...@gmail.com>
>
> Date:   Fri Apr 13 08:55:05 2018 +0200
>
>
>
> I still get:
>
> -- The following OPTIONAL packages have not been found:
>
>
>
> * BCG729 , G.729 decoder , <https://www.linphone.org/
> technical-corner/bcg729/overview>
>
>Support for G.729 codec in RTP player
>
> * DOXYGEN
>
> * MaxMindDB
>
>
>
> fatal: Not a git repository (or any of the parent directories): .git
>
> CMake Error at CMakeLists.txt:2934 (string):
>
>   string begin index: 1 is out of range 0 - 0
>
>
>
>
>
> -- Configuring incomplete, errors occurred!
>
>
>
>
>
> Regards
>
> Anders
>
>
>
> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
> Behalf Of *Dario Lombardo
> *Sent:* den 13 april 2018 13:37
> *To:* Developer support list for Wireshark <wireshark-dev@wireshark.org>
> *Subject:* Re: [Wireshark-dev] RPM generation
>
>
>
> With the last changes pushed, I'm able to make openSUSE work. Since this
> was pointed out as blocking for autotools removal, we can proceed, as soon
> as Anders confirms.
>
> Anyone already working on autotools removal?
>
>
>
> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
> dario.lombardo...@gmail.com> wrote:
>
> Perfect. Centos, Fedora and openSUSE are the three under testing. openSUSE
> is rather different from the others, and I'm pushing some changes specific
> for that, trying not to break the others :).
>
>
>
> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <jeff.morriss...@gmail.com>
> wrote:
>
> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>
> Is the rpm build platform expected to be one? If yes, which one? If no, do
> we want to support all the flavors? It seems that different flavors require
> different package names (link in asciidoctor). I can be hard to be portable
> in this way.
>
>
> The current RPM build tries to support SUSE and Red Hat/Fedora--the former
> for Anders and the latter for the rest of the world :-).  I don't recall
> seeing requests for other distributions.
> 
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
>
>
>
>
>
> 
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Anders Broman]

Hi,
Checking out branch:
commit c369c295097f4377527e989df1658effb6497735
Author: Dario Lombardo <lom...@gmail.com>
Date:   Fri Apr 13 08:55:05 2018 +0200

I still get:
-- The following OPTIONAL packages have not been found:

* BCG729 , G.729 decoder , 
<https://www.linphone.org/technical-corner/bcg729/overview>
   Support for G.729 codec in RTP player
* DOXYGEN
* MaxMindDB

fatal: Not a git repository (or any of the parent directories): .git
CMake Error at CMakeLists.txt:2934 (string):
  string begin index: 1 is out of range 0 - 0


-- Configuring incomplete, errors occurred!


Regards
Anders

From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Dario Lombardo
Sent: den 13 april 2018 13:37
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Subject: Re: [Wireshark-dev] RPM generation

With the last changes pushed, I'm able to make openSUSE work. Since this was 
pointed out as blocking for autotools removal, we can proceed, as soon as 
Anders confirms.
Anyone already working on autotools removal?

On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo 
<dario.lombardo...@gmail.com<mailto:dario.lombardo...@gmail.com>> wrote:
Perfect. Centos, Fedora and openSUSE are the three under testing. openSUSE is 
rather different from the others, and I'm pushing some changes specific for 
that, trying not to break the others :).

On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss 
<jeff.morriss...@gmail.com<mailto:jeff.morriss...@gmail.com>> wrote:
On 04/10/2018 09:14 AM, Dario Lombardo wrote:
Is the rpm build platform expected to be one? If yes, which one? If no, do we 
want to support all the flavors? It seems that different flavors require 
different package names (link in asciidoctor). I can be hard to be portable in 
this way.

The current RPM build tries to support SUSE and Red Hat/Fedora--the former for 
Anders and the latter for the rest of the world :-).  I don't recall seeing 
requests for other distributions.
___
Sent via:Wireshark-dev mailing list 
<wireshark-dev@wireshark.org<mailto:wireshark-dev@wireshark.org>>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev

mailto:wireshark-dev-requ...@wireshark.org<mailto:wireshark-dev-requ...@wireshark.org>?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

With the last changes pushed, I'm able to make openSUSE work. Since this
was pointed out as blocking for autotools removal, we can proceed, as soon
as Anders confirms.
Anyone already working on autotools removal?

On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo  wrote:

> Perfect. Centos, Fedora and openSUSE are the three under testing. openSUSE
> is rather different from the others, and I'm pushing some changes specific
> for that, trying not to break the others :).
>
> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss 
> wrote:
>
>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>
>>> Is the rpm build platform expected to be one? If yes, which one? If no,
>>> do we want to support all the flavors? It seems that different flavors
>>> require different package names (link in asciidoctor). I can be hard to be
>>> portable in this way.
>>>
>>
>> The current RPM build tries to support SUSE and Red Hat/Fedora--the
>> former for Anders and the latter for the rest of the world :-).  I don't
>> recall seeing requests for other distributions.
>> 
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscri
>> be
>
>
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

Perfect. Centos, Fedora and openSUSE are the three under testing. openSUSE
is rather different from the others, and I'm pushing some changes specific
for that, trying not to break the others :).

On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss 
wrote:

> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>
>> Is the rpm build platform expected to be one? If yes, which one? If no,
>> do we want to support all the flavors? It seems that different flavors
>> require different package names (link in asciidoctor). I can be hard to be
>> portable in this way.
>>
>
> The current RPM build tries to support SUSE and Red Hat/Fedora--the former
> for Anders and the latter for the rest of the world :-).  I don't recall
> seeing requests for other distributions.
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Jeff Morriss]

On 04/10/2018 09:14 AM, Dario Lombardo wrote:
Is the rpm build platform expected to be one? If yes, which one? If no, 
do we want to support all the flavors? It seems that different flavors 
require different package names (link in asciidoctor). I can be hard to 
be portable in this way.


The current RPM build tries to support SUSE and Red Hat/Fedora--the 
former for Anders and the latter for the rest of the world :-).  I don't 
recall seeing requests for other distributions.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

With the last changes I submitted, this is the current situation:

Centos:
ninja: works
make: works

openSUSE:
ninja/make: build now starts, but the compilation fails (cc: error:
unrecognized command line option '-Wheader-guard'). This switch doesn't
show up when running the straight 'ninja' command. Any idea?
Moreover I can't make regular compilation due to missing lz4-frame.h. Any
idea on this as well?
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Anders Broman]

Den tis 10 apr. 2018 23:11Dario Lombardo 
skrev:

>
>
> On Tue, Apr 10, 2018 at 4:53 PM, Anders Broman 
> wrote:
>
>>
>>
>> Den tis 10 apr. 2018 21:15Dario Lombardo 
>> skrev:
>>
>>> Update on building the RPM on centos:
>>>
>>> - asciidoctor pkg is called rubygem-asciidoctor.noarch
>>>
>>
>> I think we should add this name in Findasciidoctor.cmake
>>
>>
> Ok.
>
>
>> - ninja is called ninja-build both in pkg name (as in debian/ubuntu) and
>>> in executable (differs from debian/ubuntu)
>>> - the build script calls directly ninja, then the build fails. I've
>>> fixed this by adding a symlink from ninja-build to ninja
>>>
>>
>> Did you build with ninja rather than with "Unix makefiles"?
>>
>
> Yes. I don't think it's a big deal, but I use ninja for my regular build,
> so I took this way.
>

If you could try the Unix build that would be helpful to find out if that
fails.



>
>>
>>> Except from the manual actions above, the rpm build succeeded. I can try
>>> to fix some of them, but there are some issues still pending I can't figure
>>> out myself:
>>>
>>> Is the rpm build platform expected to be one? If yes, which one? If no,
>>> do we want to support all the flavors? It seems that different flavors
>>> require different package names (link in asciidoctor). I can be hard to be
>>> portable in this way.
>>>
>> I did not find an rpm with asciidoctor for suse12.2 so I downloaded the
>> gem files as descriptions from the asciidoctor site. I have not figured out
>> how to make cmake find it. Not sure if it's related to rpm- package failing.
>>
>
> I can give it a run on openSUSE.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

On Tue, Apr 10, 2018 at 4:53 PM, Anders Broman  wrote:

>
>
> Den tis 10 apr. 2018 21:15Dario Lombardo 
> skrev:
>
>> Update on building the RPM on centos:
>>
>> - asciidoctor pkg is called rubygem-asciidoctor.noarch
>>
>
> I think we should add this name in Findasciidoctor.cmake
>
>
Ok.


> - ninja is called ninja-build both in pkg name (as in debian/ubuntu) and
>> in executable (differs from debian/ubuntu)
>> - the build script calls directly ninja, then the build fails. I've fixed
>> this by adding a symlink from ninja-build to ninja
>>
>
> Did you build with ninja rather than with "Unix makefiles"?
>

Yes. I don't think it's a big deal, but I use ninja for my regular build,
so I took this way.


>
>> Except from the manual actions above, the rpm build succeeded. I can try
>> to fix some of them, but there are some issues still pending I can't figure
>> out myself:
>>
>> Is the rpm build platform expected to be one? If yes, which one? If no,
>> do we want to support all the flavors? It seems that different flavors
>> require different package names (link in asciidoctor). I can be hard to be
>> portable in this way.
>>
> I did not find an rpm with asciidoctor for suse12.2 so I downloaded the
> gem files as descriptions from the asciidoctor site. I have not figured out
> how to make cmake find it. Not sure if it's related to rpm- package failing.
>

I can give it a run on openSUSE.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

The target is actually called rpm-package.

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html

On Tue, Apr 10, 2018 at 2:20 PM, Dario Lombardo  wrote:

>
>
> On Tue, Apr 10, 2018 at 11:46 AM, Anders Broman <
> anders.bro...@ericsson.com> wrote:
>
>> Hi,
>>
>> What I did:
>>
>> On SuSe 12.2 git clone Wireshark
>>
>> Create a build dir
>>
>> In the Build dir run:
>>
>> cmake -G "Unix Makefiles" ../wireshark
>>
>>
>>
>> run:
>>
>> make rpm-build
>>
>>
>>
> I'm trying on centos 7, but this target doesn't seems to be present. Am I
> missing something?
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] RPM generation

[Dario Lombardo]

On Tue, Apr 10, 2018 at 11:46 AM, Anders Broman 
wrote:

> Hi,
>
> What I did:
>
> On SuSe 12.2 git clone Wireshark
>
> Create a build dir
>
> In the Build dir run:
>
> cmake -G "Unix Makefiles" ../wireshark
>
>
>
> run:
>
> make rpm-build
>
>
>
I'm trying on centos 7, but this target doesn't seems to be present. Am I
missing something?
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe