Re: [Zope-dev] Zope 4 release management
On Wed, Feb 01, 2012 at 02:21:32PM +0100, Lennart Regebro wrote: > > What we would like to do, of course, is to have a self-hosted github. > :-) (And that exists. Buuut... it costs $250 per commiter and > year, so that's not an option, obviously.) Just to be sure I keep the fire on: what about self-hosted Gitorious? It's not as neat as Github, but you still have the same (similar) forking/merging abilities than Github. Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Buggy zc.recipe.testrunner 1.4.0?
Hello, I noticed that some of our tests started to fail due to missing environment values in the test script generated by zc.recipe.testrunner. Switching back the version from 1.4.0 to 1.3.0 fixed the issue. So, I tried to run the tests of the 1.4.0 release (using the tarball from Pypi), and I have a bunch of failures, which are summed in the attached file (also available in http://pastebin.com/HtVk8sKX if the mailing list doesn't allow attachments). My problem reflects in the following test: = File "/tmp/sb/zc.recipe.testrunner-1.4.0/src/zc/recipe/testrunner/README.txt", line 487, in README.txt Failed example: cat(sample_buildout, 'bin', 'testdemo') Expected: #!python -S import sys sys.path[0:0] = [ '/sample-buildout/parts/testdemo/site-packages', ] import os path = sys.path[0] if os.environ.get('PYTHONPATH'): path = os.pathsep.join([path, os.environ['PYTHONPATH']]) os.environ['PYTHONPATH'] = path import site # imports custom buildout-generated site.py import os sys.argv[0] = os.path.abspath(sys.argv[0]) os.chdir('/sample-buildout/parts/testdemo/working-directory') os.environ['zc.recipe.testrunner'] = '42' import zope.testrunner if __name__ == '__main__': zope.testrunner.run([ '--test-path', '/sample-buildout/demo', ]) Got: #!python import sys sys.path[0:0] = [ '/sample-buildout/demo', '/sample-buildout/eggs/zope.testrunner-X-pyN.N.egg', '/sample-buildout/eggs/zope.interface-X-pyN.N.egg', '/sample-buildout/eggs/zope.exceptions-X-pyN.N.egg', '/sample-buildout/eggs/setuptools-X-pyN.N.egg', ] import zope.testrunner if __name__ == '__main__': zope.testrunner.run([ '--test-path', '/sample-buildout/demo', ]) = As you can see, the generated file misses the line ``os.environ['zc.recipe.testrunner'] = '42' ``. Here is the content of "bin/test" generated by Buildout in the zc.recipe.testrunner 1.4.0 directory (in case there are weird dependencies): = #!/tmp/sb/zc.recipe.testrunner-1.4.0/../bin/python import sys sys.path[0:0] = [ '/tmp/sb/zc.recipe.testrunner-1.4.0/src', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/zope.testrunner-4.0.0b5-py2.5.egg', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/zope.interface-3.6.1-py2.5-linux-x86_64.egg', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/zope.exceptions-3.6.1-py2.5.egg', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/setuptools-0.6c12dev_r85381-py2.5.egg', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/zope.testing-3.10.0-py2.5.egg', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/z3c.recipe.scripts-1.0.1-py2.5.egg', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/zc.buildout-1.5.2-py2.5.egg', '/tmp/sb/zc.recipe.testrunner-1.4.0/eggs/zc.recipe.egg-1.3.2-py2.5.egg', ] import zope.testrunner if __name__ == '__main__': zope.testrunner.run([ '--test-path', '/tmp/sb/zc.recipe.testrunner-1.4.0/src', ]) = It seems to be a serious regression, so I guess I have something wrong on my side, otherwise other people would have noticed it. What do I miss? Are there any public continuous integration reports for those projects? Thanks, Jonathan $ cd /tmp/ tmp$ virtualenv --no-site-packages --unzip-setuptools sb New python executable in sb/bin/python2.5 Also creating executable in sb/bin/python Installing setuptools.done. tmp$ cd sb sb$ wget http://pypi.python.org/packages/source/z/zc.recipe.testrunner/zc.recipe.testrunner-1.4.0.tar.gz --2010-10-13 17:45:14-- http://pypi.python.org/packages/source/z/zc.recipe.testrunner/zc.recipe.testrunner-1.4.0.tar.gz Résolution de pypi.python.org... 82.94.164.168, 2001:888:2000:d::a8 Connexion vers pypi.python.org|82.94.164.168|:80...connecté. requête HTTP transmise, en attente de la réponse...200 OK Longueur: 27973 (27K) [application/x-gzip] Sauvegarde en : «zc.recipe.testrunner-1.4.0.tar.gz» 100%[=>] 27 973 --.-K/s ds 0,08s 2010-10-13 17:45:14 (325 KB/s) - «zc.recipe.testrunner-1.4.0.tar.gz» sauvegardé [27973/27973] sb$ tar xf zc.recipe.testrunner-1.4.0.tar.gz sb$ cd zc.recipe.testrunner-1.4.0/ zc.recipe.testrunner-1.4.0$ ../bin/python bootstrap.py Creating directory '/tmp/sb/zc.recipe.testrunner-1.4.0/bin'. Creating directory '/tmp/sb/zc.recip
Re: [Zope-dev] zope.testrunner (Was: Circular dependency hell.)
Hi Lennart, On Mon, Apr 19, 2010 at 2:42 PM, Jonathan Ballet wrote: > Hi, > > On Mon, Apr 19, 2010 at 1:03 PM, Lennart Regebro wrote: >> OK, I made a branch of zope.testing that doesn't include the >> testrunner. That was easy peasy. >> >> http://svn.zope.org/zope.testing/branches/regebro-notestrunner/ >> >> And I made a zope.testrunner: >> >> http://svn.zope.org/zope.testrunner/trunk >> >> That was pretty easy too. Except one thing: The shuffle feature >> shuffles things differently in zope.testrunner compared to in >> zope.testing.testrunner, which seems to be because it finds the layers >> in a different order. I took some time to look at this yesterday, and it seems you were right: the order should have changed since the layers now have a different name. I can't speak for other people who are using the feature, but this will not affect us very much. We use the shuffle seed feature for two cases: * we want to reproduce on a developer computer a test run which has failed on the Buildbot; * while reviewing someone's code, if tests are failing on a computer but not on another, we want to provide a way for tests to fail the same way on both computers, by "pinning" the order. Both cases have a short life time (we don't need to reproduce a particular order from X months ago), so this change is OK for us. Regards, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] KGS 3.4.1 versions
On Thu, Apr 15, 2010 at 12:29 PM, Adam GROSZER wrote: > Hello, > > There is a sheet with versions for KGS 3.4.1 > http://spreadsheets.google.com/pub?key=tUE5Q72d4Kg1FXaacCA3EKQ&output=html > > Anyone for/against those versions? Tres Seaver just released zope.securitypolicy 3.4.4 (3.4.3 was buggy). There was a subtle bug, which was triggered if you used zope.securitypolicy's security policy without having zope.dublincore package already loaded. See https://bugs.launchpad.net/bugs/564525 for more informations. Could I suggest you to include this version (3.4.4) in Zope KGS 3.4.1 ? Thanks, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testrunner (Was: Circular dependency hell.)
Hi, On Mon, Apr 19, 2010 at 1:03 PM, Lennart Regebro wrote: > OK, I made a branch of zope.testing that doesn't include the > testrunner. That was easy peasy. > > http://svn.zope.org/zope.testing/branches/regebro-notestrunner/ > > And I made a zope.testrunner: > > http://svn.zope.org/zope.testrunner/trunk > > That was pretty easy too. Except one thing: The shuffle feature > shuffles things differently in zope.testrunner compared to in > zope.testing.testrunner, which seems to be because it finds the layers > in a different order. > > Anybody using the shuffle feature with seeds in their tests, so we can > make sure it still actually works? I wrote the shuffle feature in the first place and we are sometimes using it here. I won't have time today, but I can take a look tomorrow I guess (I need to catch up with the "Circular dependency hell" thread and with zope.testrunner first, though). Regards, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Summary of this weeks' meeting (2010-03-30)
Hi, On Wed, Mar 31, 2010 at 5:16 PM, Christian Theune wrote: > For those of you who can't/don't participate in those meetings, there's > the open question about how useful you consider my summaries to be. > Please tell! I like to read those summaries, since they gave me an quick insight of what's going on in Zope world. Thanks! Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
Hi, On Fri, Dec 18, 2009 at 1:51 PM, Christian Theune wrote: > > Reviewed and merged. > > I made some minor textual changes, otherwise that code was fine. Thank you Christian! BTW, the Pypi page for zope.testing is a bit broken currently (the HTML has not been generated), can you fix this too? Regards, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
Hello, On Tue, Nov 3, 2009 at 11:21 AM, Jonathan Ballet wrote: > Hello Christian, > > On Tue, Nov 3, 2009 at 11:07 AM, Christian Theune wrote: >> [...] btw: do you log the seed if >> you generated one?) > > Yep, the seed is displayed at the end of tests, so that it can be > reused to reproduce a failing test. > > $ ./bin/test --shuffle -cvvv > Running tests at level 1 > Running zope.testing.testrunner.layer.UnitTests tests: > Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds. > ... > Ran 257 tests with 0 failures and 0 errors in 21.908 seconds. > Tests were shuffled using seed number 321854366611 Any thoughts on this feature? Did someone try it? Is there any possibilities to merge this into trunk and to release a new version with this? Cheers, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Relative path support for z3c.recipe.paster?
Hi Roger, On Wed, Nov 4, 2009 at 5:15 PM, Roger Ineichen wrote: > Hi Jonathan > > In general any improvment is welcome as long as there is no bad > sideffect. I do not know this option and do not understand what > you mean with moving buildout around. By "moving buildout around", I mean: I generate a buildout in a directory, let's say /home/foo/prod/1.0 on the host FOO, and I would like to be able to copy the result of the buildout on the host BAR, in the directory /var/run/bar/ and be able to just run ./bin/paster and voilà! That's why I would like to have relative paths. > Anyway, if there is no sideffect like larger processing time > in prodction use just for provide a fancy feature, you are very > welcome to improve and implement usefull things ;-) Ok, I don't think the modification will have such side effects, so I will propose a patch for this then :) Cheers, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Relative path support for z3c.recipe.paster?
Hi, Since zc.recipe.egg 1.2.0, there's an option to generate scripts which contains relative paths to eggs installed in the eggs/ directory [1] This is very handy if you want to move your buildout around, without needing to relaunch the whole buildout process. What do maintainers of z3c.recipe.paster think if I propose a patch which add this option (or something else) to support the same thing for this recipe? Actually, this can be a relatively minor change, since the recipe already use zc.recipe.egg, which means it only has to pass the corresponding option to this one. Thoughts? Cheers, Jonathan [1] : http://pypi.python.org/pypi/zc.recipe.egg#relative-egg-paths ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
Hello Christian, On Tue, Nov 3, 2009 at 11:07 AM, Christian Theune wrote: > [...] btw: do you log the seed if > you generated one?) Yep, the seed is displayed at the end of tests, so that it can be reused to reproduce a failing test. $ ./bin/test --shuffle -cvvv Running tests at level 1 Running zope.testing.testrunner.layer.UnitTests tests: Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds. ... Ran 257 tests with 0 failures and 0 errors in 21.908 seconds. Tests were shuffled using seed number 321854366611 I already find it *very* useful ... Cheers, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
Hello there, as I mentioned by Sebastien, the patch has been commited into the sdouche-shuffle branch. It now has tests and a bit of documentation too. Regarding CLI arguments, I'm not sure this could be changed like Christian proposed. If you know how to do it, I'm listening, 'cause I don't know! :) I have one more thing I would like to discuss: how should this feature behave with the --repeat feature? Currently, the shuffling is done before the repeat feature. This means that tests will *not* get reordered for each loop (just once, at the very beginning of tests launching). I know how to do it, so that for each loop, tests will get a different order (basically, I would propose to wrap the __iter__() method of the TestSuite used to launch tests, and to shuffle here): class ShuffledTestSuite(unittest.TestSuite): def __iter__(self): tests = list(super(Shuffled, self)) seed = long(time.time() * 256) shuffler = random.Random() shuffler.shuffle(tests) return iter(tests) However, using this means we would loose the seed printing (which seems very convenient to me). I'm not sure if we could get it and print it for each loop... Reviews, comments and feedbacks are welcome! Cheers, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
Hi, On Fri, Oct 9, 2009 at 3:30 PM, Benji York wrote: > On Fri, Oct 9, 2009 at 8:51 AM, Jonathan Ballet > wrote: >> If I want this option to have an optional value, I think I must set a >> default value to the option. But then, how to make the distinction >> between the two first cases? I might miss something I don't know in >> option parsing, but I didn't find anything... > > I'd try the same approach as default options in Python functions. Make > the default None (which isn't a valid seed) and then you can tell the > difference. That's what I originally though, but then, how can I make the difference between 'the user has not set --shuffle' (the option's value is then None), and 'the user has set the --shuffle option, but without specifying a seed' (then the option's value is None again)? Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
Hey, On Fri, Oct 9, 2009 at 2:33 PM, Christian Theune wrote: >> * --shuffle to randomize the order of the tests in a layer (layers >> are not yet randomized, I didn't look at it yet); >> * --shuffle-seed XXX, to initialize the RNG with a specific value, >> which allows to reproduce a specific randomization of tests (inspired >> by this thread >> http://lists.idyll.org/pipermail/testing-in-python/2009-April/001812.html >> ) > > Sounds right. It could even be folded into a single option: > > --shuffle[=XXX] I'm not sure how to do that, considering those use cases: * the user doesn't want to shuffle its tests and so, doesn't set --shuffle * the user want to shuffle its tests, without specifying an order, and use --shuffle * the user want to shuffle its tests in specific order, and use --shuffle=42 If I want this option to have an optional value, I think I must set a default value to the option. But then, how to make the distinction between the two first cases? I might miss something I don't know in option parsing, but I didn't find anything... >> It's not yet ready-to-commit: it still misses tests (tricky to write) >> and more documentation. > > That's what working branches are for. You do have commit rights, don't you? I don't (personally) have commit rights, but my boss (sdouche) has. I'll see with him. Thanks for your advices! Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
Hi Christian, On Fri, Oct 2, 2009 at 2:00 PM, Christian Theune wrote: > Hi, > > I *thought* the test runner had a feature to run tests in randomized > order, but I can't find it. Is that something that Zope 2 had and that > was never ported to zope.testing? > > I couldn't find in the history either. > > /me is confused. I was about to send the same mail today, but I found out your mail before. I didn't find anything relative to random tests in Zope 2 (but I'm not familiar at all with Zope 2, so I'm pretty sure I could have missed something), and I ended up writing a new feature for zope.testing's testrunner. I made a branch 'shuffle-tests', available on the Mercurial repository at http://bitbucket.org/multani/zope.testing-shuffle/ , which adds two new options: * --shuffle to randomize the order of the tests in a layer (layers are not yet randomized, I didn't look at it yet); * --shuffle-seed XXX, to initialize the RNG with a specific value, which allows to reproduce a specific randomization of tests (inspired by this thread http://lists.idyll.org/pipermail/testing-in-python/2009-April/001812.html ) It's not yet ready-to-commit: it still misses tests (tricky to write) and more documentation. However, feedbacks are welcome! Cheers, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )