Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hello Jay Changes are good. Thanks Have a good day Prahalad N. From: Jayathirth D V Sent: Tuesday, April 17, 2018 2:23 PM To: Prahalad Kumar Narayanan; Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk Hi

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hello Jay The changes are fine. Just a minor observation: The image reader should be disposed in the test case. Thank you Have a good day Prahalad N. From: Jayathirth D V Sent: Friday, April 13, 2018 2:24 PM To: Philip Race; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Hello Jay Changes look good. Thanks Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Tuesday, April 10, 2018 11:49 AM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Friday, April 06, 2018 5:19 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hi Prahalad, Tha

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

ood day Prahalad N. -Original Message- From: Jayathirth D V Sent: Thursday, April 05, 2018 3:26 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hello Prahalad, Thank y

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Hello Jay Good day to you. I looked into the latest code changes. Please find my review observation & suggestions herewith. My understanding of problem statement: . As I understand, our PNGImageReader parses tRNS chunk information from metadata whenever ignoreMetadata is false or paletted

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

once again Have a good day Prahalad N. -Original Message- From: Philip Race Sent: Tuesday, March 27, 2018 2:40 AM To: Sergey Bylokhov Cc: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when

[OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

Hello Everyone Good day to you. Request your time to review a simple fix for the bug Bug: JDK-4954348 (https://bugs.openjdk.java.net/browse/JDK-4954348) Title: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values Root Cause: . As per ImageWriter

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

Hello Jay Good day to you. I looked into the code changes and they look good. Appreciate the links that you have posted on JBS. I see that - the only reference material on Bitmap V2/V3 Info Header header exists on Adobe Forums (https://forums.adobe.com/message/3272950#3272950) I could not

Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

Hello Phil Good day to you. Thank you for the explanation. I understand your point now. The code changes look good. Thank you Have a good day Prahalad N. - Original Message - From: Phil Race Sent: Wednesday, March 21, 2018 12:14 AM To: Prahalad Kumar Narayanan; 2d-dev Subject: Re

Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

Hello Phil Good day to you. I imported your patch and checked the resulting build. Warnings showed up as expected with use of "t2k" or "legacy" in the VM option -Dsun.java2d.font.scaler. However, I'm unable to interpret this line and its intended outcome. > It also adds a new value for

[OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes

Hello Everyone Good day to you. Request your time in reviewing a simple fix for . Bug : [JDK-6686236] https://bugs.openjdk.java.net/browse/JDK-6686236 . Title : GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes Root Cause: . As per the gif image format

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

Hello Sergey The change looks good to me. Thank you Have a good day Prahalad N. -Original Message- From: Sergey Bylokhov Sent: Thursday, March 08, 2018 9:02 AM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable Hello. Please review the

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8198613] Test cases result in failure or timeout when run with OpenGL backend

with xrender) Thank you for your time in review Have a good day Prahalad N. -Original Message- From: Prahalad Kumar Narayanan Sent: Wednesday, February 28, 2018 3:00 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] RFR: [JDK-8198613] Test cases result in failure or timeout when run

[OpenJDK 2D-Dev] [11] RFR: [JDK-8198613] Test cases result in failure or timeout when run with OpenGL backend

Hello Everyone Good day to you. Request your time in reviewing a minor fix for the bug . Bug: https://bugs.openjdk.java.net/browse/JDK-8198613 . Title: Test cases result in failure or timeout when run with OpenGL backend Root Cause: . OpenGL is not the default backend (or) the

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8196451] sun/java2d/OpenGL/DrawBufImgOp.java times out

- From: Sergey Bylokhov Sent: Wednesday, February 14, 2018 3:51 AM To: Phil Race; Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8196451] sun/java2d/OpenGL/DrawBufImgOp.java times out On 13/02/2018 13:44, Phil Race wrote: > In this case I can say that it

[OpenJDK 2D-Dev] [11] RFR: [JDK-8196451] sun/java2d/OpenGL/DrawBufImgOp.java times out

Hello Everyone Good day to you. Request your time in reviewing a minor change for a test bug [JDK-8196451] sun/java2d/OpenGL/DrawBufImgOp.java times out https://bugs.openjdk.java.net/browse/JDK-8196451 Observation: . The bug reports a test case- DrawBufImgOp, failing

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

Hello Jay The changes look good. Thanks Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Thursday, January 25, 2018 7:32 PM To: Prahalad Kumar Narayanan; Sergey Bylokhov; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

ileLength = chunkLength - keyword.length() > - 2; > 671 int textLength = chunkLength - keyword.length() - 2; Thanks Have a good day Prahalad N. -Original Message- From: Prahalad Kumar Narayanan Sent: Thursday, January 25, 2018 11:15 AM To: Sergey Bylokhov; Jayathirth D V;

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

Original Message- From: Sergey Bylokhov Sent: Thursday, January 25, 2018 5:44 AM To: Prahalad Kumar Narayanan; Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size On 22/01/2018 23:17, Prah

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

nt. Hope this helps. Thank you Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Tuesday, January 23, 2018 12:18 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

Hello Jay I looked into the bug and the fix. The root cause of the problem is mal-formed "chunk length" field. Thus the available chunk data to decode could either be larger (or) lesser than the value of "chunk length". The bug seems to target one specific case- where available data is larger

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8195131: Dead code removal for changes present in JDK-8176795

Hello Jay I understand that the last argument to XRColor.setColorValues (int pixel, boolean pre) is set to 'true' at all caller sites. This results in block of code within if (!pre) { ... } not being used at all. 97 if (!pre) { 98 double alphaMult =

Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

;Caused by" chain and we will be >> throwing proper exception as per ImageIO specification. >> Please find updated webrev for review: >> http://cr.openjdk.java.net/~jdv/8191174/webrev.02/ >> >> Thanks, >> Jay >> >> -Original Message-

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

Hello Jay The code change to fix the bug is good. Thanks Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Tuesday, January 16, 2018 12:21 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

-Original Message- From: Jayathirth D V Sent: Thursday, December 14, 2017 6:49 PM To: Prahalad Kumar Narayanan; Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. Hello Prahalad, T

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191073: JpegImageReader throws IndexOutOfBoundsException when trying to read image data from tables-only image

Hello Jay I imported your changes & tested the same. The change doesn't cause new regressions & attached test case passes. Looks good. Thank you Have a good day Prahalad N. - Original Message - From: Jayathirth D V Sent: Tuesday, January 09, 2018 2:00 PM To: Brian Burkhalter; 2d-dev

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer

jdk.java.net/~pnarayanan/8194489/webrev.01/ Kindly review at your convenience and share your thoughts. Thank you for your time in review Have a good day Prahalad N. - Original Message - From: Brian Burkhalter Sent: Saturday, January 06, 2018 4:22 AM To: Prahalad Kumar Narayanan Cc: 2

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-5064835] TextMeasurer/deleteChar function fails when deleting more than one characters

nan/5064835/webrev.01/ Thank you once again Have a good day Prahalad N. -Original Message- From: Sergey Bylokhov Sent: Saturday, January 06, 2018 3:04 PM To: Jayathirth D V; Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-5064835] TextMeasurer/deleteChar f

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer

. Thank you for your review & this discussion Have a good day Prahalad N. -Original Message- From: Sergey Bylokhov Sent: Saturday, January 06, 2018 2:13 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect s

[OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer

Hello Everyone Good day to you. Request your time to review the fix for the bug: JDK-8194489Incorrect size computation at BandedSampleModel . createDataBuffer Root Cause: . The method BandedSampleModel . createDataBuffer does not consider number of banks and band offsets while computing

[OpenJDK 2D-Dev] [11] RFR: [JDK-5064835] TextMeasurer/deleteChar function fails when deleting more than one characters

Hello Everyone Good day to you. Request your time in reviewing the fix for the bug: JDK-5064835TextMeasurer/deleteChar function fails when deleting more than one characters. Root Cause: . The spec clearly mentions that the concerned method is to be used to delete a single character. .

Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

So I think, this should be ok. I would like to know of others' opinion too. Thank you Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Thursday, December 28, 2017 3:43 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] RFR JDK-8191174: PngRe

Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

Hello Jay Good day to you. I don't think it's possible to fix this issue despite having intermediate " long " variable to hold intermediate bits per pixel. Here is a simple math that considers the worst case scenario with max values: . As per the PNG specification, the maximum permissible

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

Hello Jay I looked into the changes. Here are my views. > X Rendering extension expects pre-multiplied alpha color values, so we need > to convert the non-premultiplied alpha color values to pre-multiplied alpha > color values before give pixel value to XRender for drawing. > The main problem

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing

Hello Jay The fix looks good. Thanks Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Thursday, December 14, 2017 9:47 AM To: Sergey Bylokhov; Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing

Hello Jay I looked into the changes. The logic to check the presence of PLTE chunk is correct. Few minor changes . The if condition to check whether PLTE chunk exists would get executed every time an IDAT chunk is encountered. . For png images with multiple IDAT chunks, this is a

Re: [OpenJDK 2D-Dev] RFR: 8189809: Large performance regression in Swing text layout.

Hello Phil The change looks good to me. I found two interesting changes in your webrev. . The move to use FontDesignMetrics to compute width should be better than generating GlyphVector for the same. . Besides, the double conversion from chars[] to String and vice versa has been avoided as

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

: Tuesday, November 28, 2017 11:14 PM To: Prahalad Kumar Narayanan; 2d-dev Cc: Philip Race Subject: Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction The test can use any part of our API. It is a small part of the code which can confirm/verify

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

you once again Have a good day Prahalad -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 28, 2017 12:46 PM To: Prahalad Kumar Narayanan; 2d-dev Cc: Philip Race Subject: Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

rom the concerned method, will cause the test to fail upon time-out. Thank you once again for your time Have a good day Prahalad -Original Message- From: Sergey Bylokhov Sent: Monday, November 27, 2017 9:11 PM To: Prahalad Kumar Narayanan; 2d-dev Cc: Philip Race Subject: Re: [OpenJDK 2D-De

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

doesn’t contain additional image file. Kindly review the changes and provide your feedback. Thank you once again for your time in review Have a good day Prahalad -Original Message- From: Phil Race Sent: Friday, November 10, 2017 2:30 AM To: Prahalad Kumar Narayanan Cc: Sergey Bylokhov; 2d

Re: [OpenJDK 2D-Dev] [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java

AM To: Pankaj Bansal; Prahalad Kumar Narayanan; awt-...@openjdk.java.net; 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev] [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java Looks fine. Thank you. On 16/11/2017 01:53, Pankaj

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT chunk positions will cause IIOException

Hello Jay The change looks good. Thanks Have a good day Prahalad -Original Message- From: Jayathirth D V Sent: Tuesday, November 21, 2017 9:01 AM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT chunk positions will cause IIOException

) { 118 stream.close(); 119 } 120 Files.delete(output.toPath()); 121 } 122 } 123 } Thank you Have a good day Prahalad -Original Message- From: Jayathirth D V Sent: Monday, November 20, 2017 6:18 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: RE: [O

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT chunk positions will cause IIOException

Hello Jay The code change at PNGImageReader is correct. But the test wouldn't delete temporary files when exception occurs. Thank you Have a good day Prahalad - Original Message - From: Jayathirth D V Sent: Monday, November 20, 2017 4:34 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [10]

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

To: Prahalad Kumar Narayanan; Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large Hi Prahalad, Thanks for your inputs. I have updated comments in PNGImageReader and updated the jtreg comment

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

; Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large Hi, Thanks for the review Phil and Prahalad. Based on the suggestions I have updated the code to wrap underlying Exception/Error

Re: [OpenJDK 2D-Dev] [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java

Hello Pankaj Good day to you. I imported your changes and checked the build with the JTreg test file. . I tried random uiScales using -Dsun.java2d.uiScale and by adjusting DPI scale on Windows 10. . The test failed at uiScale set at 1.75 on all the pipelines- D3D, OpenGL and

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

Hello Jay Good day to you. I looked into the changes. Here are my views- . As per the code changes in the lines mentioned below, every "Throwable" (other than the 4 exceptions listed in the first catch block) is considered- "BufferOverflow/OOM". This is incorrect. . Say for

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

g the test. Kindly review by assessing the above information. If you believe, the fix could be approved, kindly review the CSR as well. Thank you once again for your time Have a good day Prahalad - Original Message - From: Philip Race Sent: Thursday, October 26, 2017 9:30 PM To: Prahalad

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

to cause deadlocks as Phil rightly pointed out. I shall respond with my findings soon. Thank you once again for your time Have a good day Prahalad N. -Original Message- From: Sergey Bylokhov Sent: Friday, October 27, 2017 10:21 AM To: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJD

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

To: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction Hi, Prahalad. Can you please add a stack trace which include a line numbers to the bug report? Currently it is unclear in what line an exception

[OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

Hello Everyone Good day to you. Kindly review a fix for the bug Bug ID: JDK-8188083 Description: Null Pointer Exception in java.awt.image.FilteredImageSource.startProduction Root Cause . FilteredImageSource implements ImageProducer interface . All the methods of

Re: [OpenJDK 2D-Dev] RFR: 8080084 : java/awt/Graphics2D/DrawString/DrawStringCrash.java fails with G1 GC

Hello Phil The code changes are appropriate. +1 Thanks Have a good day Prahalad N. -Original Message- From: Phil Race Sent: Monday, October 09, 2017 11:39 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] RFR: 8080084 : java/awt/Graphics2D/DrawString/DrawStringCrash.java fails with G1 GC A

Re: [OpenJDK 2D-Dev] [10] Review Request: 6238123 Typos at Serialized Form javadoc for java.awt.Polygon

Hello Sergey Your changes fix the Javadoc comments with appropriate usage. +1 Thanks Have a good day Prahalad N. -Original Message- From: Sergey Bylokhov Sent: Saturday, September 09, 2017 4:46 AM To: 2d-dev Subject: [OpenJDK 2D-Dev] [10] Review Request: 6238123 Typos at Serialized

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8186987:NullPointerException in RasterPrinterJob without PrinterResolution

Hello Prasanta Thanks for the explanation. Being new to the Printing subsystem, it helped get the context of the problem. As I understand, the problem is due to getDefaultPrinterSetings() returning negative values for defYRes and quality. And the fix evades such negative values with a

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8164971: PNG metadata does not handle ImageCreationTime

Sent: Tuesday, August 29, 2017 4:05 AM To: Prahalad Kumar Narayanan Cc: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8164971: PNG metadata does not handle ImageCreationTime Hello Prahalad, I think this looks OK. I wonder however whether it might not hurt to

Re: [OpenJDK 2D-Dev] RFR: 8186317: Cache font layout tables for use by harfbuzz

Hello Phil You are correct. I missed to take note of calloc() at Line 347. The changes are good. Thank you Have a good day Prahalad N. -Original Message- From: Phil Race Sent: Monday, August 28, 2017 11:34 PM To: Prahalad Kumar Narayanan; srl Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev

Re: [OpenJDK 2D-Dev] RFR: 8186317: Cache font layout tables for use by harfbuzz

Hello Phil The change looks good to me. Thank you for the observation in performance; It validates the fix. Just a minor observation in code which isn't a part of this fix. When we initialize TTLayoutTableCacheEntry within newLayoutTableCache(), we are not setting its pointer to NULL. File:

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8164971: PNG metadata does not handle ImageCreationTime

ew the changes at your convenience & provide your feedback. Thank you for your time in review Have a good day Prahalad N. - Original Message - From: Brian Burkhalter Sent: Saturday, August 19, 2017 12:57 AM To: Prahalad Kumar Narayanan Cc: Jayathirth D V; 2d-dev@openjdk.java.net Subject: R

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8164971: PNG metadata does not handle ImageCreationTime

ta with text chunks using Native tree. Kindly review the changes when your time permits and provide your feedback. Thank you Have a good day Prahalad N. --- From: Brian Burkhalter Sent: Thursday, June 08, 2017 4:20 AM To: Jayathirth D V Cc: Prahalad Kumar

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8183349: Better cleanup for jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java and WriteAfterAbort.java

Hello Jay Minor changes have been added. Looks good. Thank you Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Wednesday, July 12, 2017 4:05 PM To: Sergey Bylokhov; Prahalad Kumar Narayanan Cc: 2d-dev@openjdk.java.net Subject: RE: [OpenJDK 2D-Dev] [10] RFR

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8183349: Better cleanup for jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java and WriteAfterAbort.java

Hello Jay The changes look good and contains lesser code than the earlier revision. Thanks Have a good day Prahalad N. -Original Message- From: Jayathirth D V Sent: Wednesday, July 12, 2017 11:46 AM To: Sergey Bylokhov; Prahalad Kumar Narayanan Cc: 2d-dev@openjdk.java.net Subject: RE

Re: [OpenJDK 2D-Dev] [10]JDK-8183341:Better cleanup for javax/imageio/AllowSearch.java

Hello Sashi Good day to you. I looked into the changes. Here are my suggestions . You are deleting the files with Files.delete(filePath) only when the test succeeds Shouldn't you delete the temp file upon failure as well ? (before throwing RuntimeException in Line 70) Besides, the nature of

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8183349: Better cleanup for jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java and WriteAfterAbort.java

Hello Jay I looked into the changes. Please find my suggestions herewith. . Refer to the javadocs of File class. It mentions that a directory could be deleted only if it's empty. Hence, invoking directory.delete() will not work because a temp file would already exist in it. Besides why

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8180055: Upgrade the Marlin renderer in Java2D

Hello Lauren +1 for the code changes. Without going through the specifics, I imported the code & checked for successful build. The build succeeded with the patch from your latest webrev link. Just for knowledge: You would have checked for the performance improvement with your improved

[OpenJDK 2D-Dev] [10] RFR: JDK-8164971: PNG metadata does not handle ImageCreationTime

Hello Everyone Good day to you. Request your time in reviewing a fix for the bug . JDK-8164971PNG metadata does not handle ImageCreationTime Root Cause: . First, the PNGImageReader 's logic skips parsing of 'any' chunk once IDAT is found. . Hence, if the ancilliary text chunks appear after

Re: [OpenJDK 2D-Dev] JDK-8178091 : Bug I will workin on

Hello Pat I 'm not comfortable adding this check for os.name in a common code. It breaks the very foundation of having os specific code organized in different folders. >From the inference that 've got from this mail chain, I believe, the issue >appears to be from rendering pipeline (linux). So

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Hello Laurent The code changes look good. . The new method trimToSize effectively does the same operation (Arrays.copyOf) as done by the copy contructors. . The test file- Path2DCopyConstructor now tests after executing the methods pathObj.trimToSize and pathObj.clone With regard to

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8147002:[macosx] Arabic character cannot be rendered on MacOS X

gt; glyph. > > webrev: http://cr.openjdk.java.net/~psadhukhan/8147002/webrev.00/ > <http://cr.openjdk.java.net/%7Epsadhukhan/8147002/webrev.00/> > > Regards > Prasanta ------ next part -- An HTML attachment was scrubbed... URL: <http://mail.openjdk.java.

[OpenJDK 2D-Dev] [9] RFR JDK-8147002:[macosx] Arabic character cannot be rendered on MacOS X

The change looks good. +1. Minor observation: The copyright should be updated to 2017 in the CFont.java file. If you use any script to update the same, then ignore this observation. Thanks Have a good day Prahalad N. -Original Message- From: 2d-dev-requ...@openjdk.java.net

[OpenJDK 2D-Dev] [9] RFR: [JDK-6852563] ArrayOutOfBoundException when reading RLE8 compressed bitmap

Hello Everyone Good day to you. Request your time in reviewing the fix for the bug [JDK-6852563] ArrayOutOfBoundException when reading RLE8 compressed bitmap Root Cause . The issue is similar to JDK-8167278 except for the difference in the Bitmap's compression format. . The issue

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP

. Thank you for your time Have a good day Prahalad N. -Original Message- From: Phil Race Sent: Tuesday, January 24, 2017 2:06 AM To: Prahalad Kumar Narayanan; Brian Burkhalter Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP

ving put through this test, I believe, the code is stable now Thank you Have a good day Prahalad N. --- Original Message --- From: Brian Burkhalter Sent: Tuesday, January 24, 2017 1:16 AM To: Prahalad Kumar Narayanan Cc: Philip Race; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR:

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP

feedback. Thank you once again Have a good day Prahalad N. --- Original message --- From: Brian Burkhalter Sent: Saturday, January 21, 2017 6:05 AM To: Philip Race Cc: 2d-dev@openjdk.java.net; Prahalad Kumar Narayanan Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsExcept

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP

ng? If it is not needed we can remove "padding" parameter in decodeRLE4() and its calculation in readRLE4().If it is not under the scope of this bug you can raise a new bug for the same. Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Friday, January 13, 2017

Re: [OpenJDK 2D-Dev] RFR: 8172813 test/java/awt/font/JNICheck/JNICheck.sh fails on Linux

, 2017 5:36 AM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] RFR: 8172813 test/java/awt/font/JNICheck/JNICheck.sh fails on Linux A couple of updates made : http://cr.openjdk.java.net/~prr/8172813,2 Comments in-line below -phil. On 01/18/2017 09:51 AM

Re: [OpenJDK 2D-Dev] RFR: 8172813 test/java/awt/font/JNICheck/JNICheck.sh fails on Linux

Hello Phil The change looks good - Reduces the number of local references held by the JNI function. Here are some findings : 1. I found additional references that could be released. You can check the severity of the problem and decide to release or skip. Line: 1129Concerned

[OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP

Hello Everyone Good day to you. Request your time in reviewing the fix for bug . [JDK-8167278] : ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP Root Cause . The issue seems to stem from a mal-formed RLE4 Encoded Bitmap Image . Specifically -

Re: [OpenJDK 2D-Dev] [9] RFR 8170579: The "Banner page" checkbox is disabled

Looks good. Thanks & Have a good day Prahalad N. -Original Message- From: Prasanta Sadhukhan Sent: Friday, December 16, 2016 2:15 PM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Cc: Praveen Srivastava; Jayathirth D V Subject: Re: [OpenJDK 2D-Dev] [9] RFR 8170579: The &qu

Re: [OpenJDK 2D-Dev] [9] RFR 8170579: The "Banner page"

Hello Prasanta I believe the 'Banner Page' setting on Print dialog maps to the JobSheets attribute category. If this is right, the logic to check support for JobSheets attribute category is correct. Few corner cases that I observed with BannerTest: . The test-case does not bail-out when run

Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

in non EDT thread. I've seen many swing test-cases that deploy same logic ( Correct me if my understanding is wrong ). Thank you Have a good day Prahalad N. -Original Message- From: Prasanta Sadhukhan Sent: Monday, November 21, 2016 3:48 PM To: Prahalad Kumar Narayanan; Sergey Bylokhov

Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

v.01/ Kindly review the code at your convenience Thank you Have a good day Prahalad N. -Original Message- From: Sergey Bylokhov Sent: Friday, November 18, 2016 7:42 PM To: Prasanta Sadhukhan; Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] Review Request:

[OpenJDK 2D-Dev] [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

Hello Everyone Good day to you Request your time in reviewing the fix for an error that I introduced in my submission. Bug ID: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed Relates to: [JDK-8166003] [PIT][TEST_BUG] missing

Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003]: [PIT][TEST_BUG] missing helper for bug6427244.java

Thank you for your views Prasanta. Appreciate it...! Prahalad N. -Original Message- From: Prasanta Sadhukhan Sent: Thursday, November 10, 2016 10:25 AM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003

Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003]: [PIT][TEST_BUG] missing helper for bug6427244.java

on JBS Let me know your thoughts. Thank you once again for your time in review Have a good day Prahalad N. -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, November 08, 2016 10:56 AM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net; Philip Race Subject

[OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003]: [PIT][TEST_BUG] missing helper for bug6427244.java

Hello Everyone on Java2D Group Request your time in reviewing the fix for the bug- JDK-8166003 Link: https://bugs.openjdk.java.net/browse/JDK-8166003 Title: [PIT][TEST_BUG] missing helper for javax/swing/text/GlyphPainter2/6427244/bug6427244.java Root Cause: The test case requires

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8165212 VolatileImage should not be compatible with GraphicsConfiguration which transform is changed

Sent: Friday, October 28, 2016 4:57 PM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8165212 VolatileImage should not be compatible with GraphicsConfiguration which transform is changed  350 if (!isAccelerationEnabled()) {

[OpenJDK 2D-Dev] [9] Review Request: JDK-8165212 VolatileImage should not be compatible with GraphicsConfiguration which transform is changed

Hello Everyone Good day to you. Request your time in reviewing the fix for- Bug : JDK-8165212 Title : VolatileImage should not be compatible with GraphicsConfiguration which transform is changed Description on the bug- . As per the bug, Volatile Image's graphics

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8167281: IIOMetadataNode bugs in getElementsByTagName and NodeList.item methods

The change looks good. +1 - Prahalad N. >From: Phil Race >Sent: Wednesday, October 12, 2016 10:28 PM >To: Jayathirth D V; 2d-dev >Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8167281: IIOMetadataNode bugs in >getElementsByTagName and NodeList.item methods > >Looks fine to me. > >-phil. > >>On

Re: [OpenJDK 2D-Dev] RFR: 8166034: [macosx] Non-AA Serif font

+1 The wordings that mention: " ... absence of suitable platform fonts to implement a logical font ", is more appropriate. Thanks Have a good day Prahalad N. -- Message: 4 Date: Wed, 12 Oct 2016 10:32:59 -0700 From: Phil Race To: 2d-dev

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

To: Prahalad Kumar Narayanan; Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison On 12.08.16 16:06, Sergey Bylokhov wrote: > Looks fine. > Please add @key heedful

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

and share your views. Thank you Have a good day Prahalad N. -Original Message- From: Prasanta Sadhukhan Sent: Thursday, August 11, 2016 1:02 PM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Cc: Philip Race; Sergey Bylokhov Subject: Re: [OpenJDK 2D-Dev] [9] Review Request: JDK

[OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

Hello Everyone Good day to you. I 'm planning to add a test file into jdk/test/ repository. The webrev changes for the test file is presented herewith. Link: http://cr.openjdk.java.net/~pnarayanan/8158524/webrev.00/ Brief on the test & its objectives: . As we know,

Re: [OpenJDK 2D-Dev] RFR(XS): 8163177: Fix for 8152971 breaks builds with VS2010

, 2016 5:19 PM To: 2d-dev@openjdk.java.net Cc: Volker Simonis; Prahalad Kumar Narayanan Subject: RFR(XS): 8163177: Fix for 8152971 breaks builds with VS2010 Hi, please review this little fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8163177 Webrev: http://cr.openjdk.java.net/~clanger/webrevs

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

since the return will do that. And a little clean up .. the variable fontKeyName does not seem to be needed any more. Just directly use FONTKEY_NT. -phil. On 7/11/16, 12:02 PM, Prahalad Kumar Narayanan wrote: Hello Everyone Good day to you. A quick follow-up on the bug fix for : JDK-8152971

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

; effort in review Have a good day Prahalad N. From: Philip Race Sent: Wednesday, June 29, 2016 10:48 PM To: Prasanta Sadhukhan Cc: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net; Jayathirth D V; Praveen Srivastava Subject

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

Solaris is retained. Kindly take a look at the changes at your convenience & provide the suggestions. Thank you for your review Have a good day Prahalad N. From: Prasanta Sadhukhan Sent: Monday, June 27, 2016 11:51 AM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Cc: Philip Race; Ja

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

your convenience & provide your feedback. Thank you for your time in review Have a good day Prahalad N. -Original Message- From: Prahalad Kumar Narayanan Sent: Wednesday, June 22, 2016 3:20 PM To: 2d-dev@openjdk.java.net Cc: Philip Race; Prasanta Sadhukhan; Jayathirth D V; Praveen Srivastava

  1   2   >