Re: [OpenJDK 2D-Dev] RFR: 8197825: [Test] Intermiitent timeout with javax/swing JColorChooser Test [v3]

On Thu, 28 Jan 2021 05:53:05 GMT, Sergey Bylokhov wrote: >> My point is that this is not a test bug, so the test should not be changed. > > Please take a look at the "AwtToolkit::Dispose()" method, on how much stuff > should be done to properly shutdown the toolkit. This Dispose() method is >

Re: [OpenJDK 2D-Dev] RFR: 8197825: [Test] Intermiitent timeout with javax/swing JColorChooser Test [v3]

> This test was failing in our nightly mach5 testing. Appropriate stability > code in form of waitForIdle and delay is added. > mach5 job running for several iterations on all platforms is ok. Link in JBS. Prasanta Sadhukhan has updated the pull request incrementally with one addition

Re: [OpenJDK 2D-Dev] RFR: 8197825: [Test] Intermiitent timeout with javax/swing JColorChooser Test [v2]

On Wed, 27 Jan 2021 12:35:38 GMT, Prasanta Sadhukhan wrote: >> This test was failing in our nightly mach5 testing. Appropriate stability >> code in form of waitForIdle and delay is added. >> mach5 job running for several iterations on all platforms is ok. Link in JBS. >

Re: [OpenJDK 2D-Dev] RFR: 8197825: [Test] Intermiitent timeout with javax/swing JColorChooser Test [v2]

> This test was failing in our nightly mach5 testing. Appropriate stability > code in form of waitForIdle and delay is added. > mach5 job running for several iterations on all platforms is ok. Link in JBS. Prasanta Sadhukhan has updated the pull request incrementally with one addition

Re: [OpenJDK 2D-Dev] RFR: 6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative

On Thu, 21 Jan 2021 00:50:28 GMT, Sergey Bylokhov wrote: > The specification for Path2D.Double, Path2D.Float and GeneralPath > constructors is updated. NegativeArraySizeException, IllegalArgumentException > and NullPointerException are added. Marked as reviewed by psadhukhan (Reviewer).

Re: [OpenJDK 2D-Dev] RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote: >> Please review the application of @java.io.Serial annotation (JDK-8202385) to >> types in the desktop module to enable stricter compile-time checking of >> serialization-related declarations. >> >> This annotation can be applied to

[OpenJDK 2D-Dev] Withdrawn: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout

On Mon, 4 Jan 2021 08:15:37 GMT, Prasanta Sadhukhan wrote: > Test fails with timeout and it seems likely due to non-availability of > printer in the test system. We should just update the test to check for > default (or available) printers and return if there is no printer. This pul

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout

On Wed, 13 Jan 2021 06:28:34 GMT, Sergey Bylokhov wrote: >> OK. But it's a keyword for jtreg, not useful for standalone execution as you >> have seen that one can get the problem running on freshly installed windows >> system. Making it manual will overcome standalone execution problem too. >

Re: [OpenJDK 2D-Dev] RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote: >> Please review the application of @java.io.Serial annotation (JDK-8202385) to >> types in the desktop module to enable stricter compile-time checking of >> serialization-related declarations. >> >> This annotation can be applied to

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout

On Wed, 13 Jan 2021 02:55:46 GMT, Sergey Bylokhov wrote: >> That printer keyword seems to be just a hint/suggestion as it does not force >> user to do anything, so we can still get this kind of problem. Making it >> manual at least will let user choose which printer he actually wants to work

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout

On Tue, 12 Jan 2021 10:44:12 GMT, Sergey Bylokhov wrote: >>> IIUC, In windows there can be non-real printers like "Send To OneNote", >>> "Fax" which falls in Printers/Scanner list but not exactly printer so >>> PrinterException is not thrown. >> >> I am not sure that the fax is related here,

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout [v5]

> Test fails with timeout and it seems likely due to non-availability of > printer in the test system. We should just update the test to check for > default (or available) printers and return if there is no printer. Prasanta Sadhukhan has updated the pull request incrementally

Re: [OpenJDK 2D-Dev] [jdk16] RFR: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.

On Sat, 9 Jan 2021 12:47:48 GMT, Pankaj Bansal wrote: > Please review a fix for jdk16 > > Issue: In SwingSet2, if the user navigates through the demos, the demo gets > selected/starts on pressing left/right key only. There is no need to press > the "space" key. Earlier, on pressing the

Re: [OpenJDK 2D-Dev] RFR: 8259232: Bad JNI lookup during printing

On Wed, 6 Jan 2021 01:17:02 GMT, Phil Race wrote: > Didn't hit this because all the print testing I conducted used the swing > print + page dialog but the logging made it easy to find the source of the > problem. > I've also done an audit of GET_METHOD_* usages for this pattern - I had >

[OpenJDK 2D-Dev] [jdk16] Integrated: 8259007: This test printed a blank page

On Tue, 5 Jan 2021 08:28:28 GMT, Prasanta Sadhukhan wrote: > Backout JDK-8256264 fix. This pull request has now been integrated. Changeset: 80110dac Author: Prasanta Sadhukhan URL: https://git.openjdk.java.net/jdk16/commit/80110dac Stats: 470 lines in 4 files changed: 0 ins;

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout [v4]

On Wed, 6 Jan 2021 04:55:34 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix code > > test/jdk/java/awt/print/PrinterJob/LandscapeStackOverflow.

Re: [OpenJDK 2D-Dev] [jdk16] RFR: 8259007: This test printed a blank page

On Tue, 5 Jan 2021 16:29:23 GMT, Phil Race wrote: > > > I assume you tested this does indeed fix the regressipn ? > Approving on that understanding. Yes, it does fix in my testing and I also got confirmation from EG that this patch fix the issues. - PR:

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout [v4]

> Test fails with timeout and it seems likely due to non-availability of > printer in the test system. We should just update the test to check for > default (or available) printers and return if there is no printer. Prasanta Sadhukhan has updated the pull request incrementally

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout [v2]

On Tue, 5 Jan 2021 16:34:11 GMT, Phil Race wrote: >> test/jdk/java/awt/print/PrinterJob/LandscapeStackOverflow.java line 50: >> >>> 48: PrintService defaultPrtSrv = >>> PrintServiceLookup.lookupDefaultPrintService(); >>> 49: if (printjob.getPrintService() == null ||

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout [v3]

> Test fails with timeout and it seems likely due to non-availability of > printer in the test system. We should just update the test to check for > default (or available) printers and return if there is no printer. Prasanta Sadhukhan has updated the pull request incrementally

[OpenJDK 2D-Dev] [jdk16] RFR: 8259007: This test printed a blank page

Backout JDK-8256264 fix. - Commit messages: - 8259007: This test printed a blank page Changes: https://git.openjdk.java.net/jdk16/pull/80/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16=80=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259007 Stats: 470 lines

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout [v2]

> Test fails with timeout and it seems likely due to non-availability of > printer in the test system. We should just update the test to check for > default (or available) printers and return if there is no printer. Prasanta Sadhukhan has updated the pull request incrementally

Re: [OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout

On Mon, 4 Jan 2021 08:26:04 GMT, Sergey Bylokhov wrote: >> Test fails with timeout and it seems likely due to non-availability of >> printer in the test system. We should just update the test to check for >> default (or available) printers and return if there is no printer. > > If the printer

[OpenJDK 2D-Dev] RFR: 8215537: [TEST_BUG] java/awt/print/PrinterJob/LandscapeStackOverflow.java fails by timeout

Test fails with timeout and it seems likely due to non-availability of printer in the test system. We should just update the test to check for default (or available) printers and return if there is no printer. - Commit messages: - 8215537: [TEST_BUG]

[OpenJDK 2D-Dev] [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

Please review a fix for jdk16. On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the selected JTabbedPane tab title text is just a light gray outline of white text on a white background. The macOS 11 design inverted from dark background / light text to light background /

Re: [OpenJDK 2D-Dev] RFR: 8256321: Some "inactive" color profiles use the wrong profile class

On Thu, 19 Nov 2020 16:51:00 GMT, Sergey Bylokhov wrote: >> It will be good to know where, in spec or any link, it is mentioned to use >> CLASS_ABSTRACT/CLASS_COLORSPACECONVERSION instead of CLASS_DISPLAY? > >> It will be good to know where, in spec or any link, it is mentioned to use >>

Re: [OpenJDK 2D-Dev] RFR: 8256321: Some "inactive" color profiles use the wrong profile class

On Tue, 17 Nov 2020 18:27:06 GMT, Victor Dyakov wrote: >> The implementation of ICC_Profile tries to defer loading the data of the >> color profile, and it uses some predefined values for some profile >> properties for the standard profiles like sRGB, PYCC, etc. If the >> application requests

[OpenJDK 2D-Dev] Integrated: 8231231: The printing result is different from the case instruction

On Wed, 21 Oct 2020 11:50:37 GMT, Prasanta Sadhukhan wrote: > Please review a manual printing test failure where the instructions is not > matching the printing result > as the labels which are present in the test instruction frame is cut off in > printed result due to marg

Re: [OpenJDK 2D-Dev] RFR: 8231231: The printing result is different from the case instruction [v3]

e Print instruction is brought to top and 1st label is brought to > bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to > account for top margin cutoff, brought it lower so that those labels does not > get cut off. Prasanta Sadhukhan has updated the pull req

Re: [OpenJDK 2D-Dev] RFR: 8231231: The printing result is different from the case instruction [v2]

e Print instruction is brought to top and 1st label is brought to > bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to > account for top margin cutoff, brought it lower so that those labels does not > get cut off. Prasanta Sadhukhan has updated the pull request

Re: [OpenJDK 2D-Dev] RFR: 8231231: The printing result is different from the case instruction

On Sat, 24 Oct 2020 22:59:20 GMT, Phil Race wrote: >> Please review a manual printing test failure where the instructions is not >> matching the printing result >> as the labels which are present in the test instruction frame is cut off in >> printed result due to margin not being accounted

Re: [OpenJDK 2D-Dev] RFR: JDK-8234393: [macos] printing ignores printer tray [v2]

On Wed, 7 Oct 2020 14:30:26 GMT, Vipin Menon wrote: >> **Issue** >> >> [https://bugs.openjdk.java.net/browse/JDK-8234393](https://bugs.openjdk.java.net/browse/JDK-8234393) >> >> **Problem** >> >> On a multi tray printer, irrespective of what tray is set, Java always >> prints from the last

Re: [OpenJDK 2D-Dev] RFR: JDK-8234393: [macos] printing ignores printer tray

On Mon, 5 Oct 2020 16:58:06 GMT, Vipin Menon wrote: > **Issue** > > [https://bugs.openjdk.java.net/browse/JDK-8234393](https://bugs.openjdk.java.net/browse/JDK-8234393) > > **Problem** > > On a multi tray printer, irrespective of what tray is set, Java always prints > from the last tray

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.

On Thu, 24 Sep 2020 16:38:50 GMT, Phil Race wrote: > A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006 > > The fix is to propagate whatever is set as the Destination down to native and > set it on the native printing object. > > Also if using the native dialog,

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.

On Thu, 24 Sep 2020 16:38:50 GMT, Phil Race wrote: > A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006 > > The fix is to propagate whatever is set as the Destination down to native and > set it on the native printing object. > > Also if using the native dialog,

Re: [OpenJDK 2D-Dev] RFR: 8253322 : Update the specification in the newly added constructors

On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov wrote: > Looks like different people use a different style for the new constructors, > it will be good to unify them. > I have started from https://bugs.openjdk.java.net/browse/JDK-8252721 > See >

Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

eturn null in some specific DocumentsPropertyUI at http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/windows/classes/sun/print/Win32PrintService.java#l1692 Thanks, Jay On 17-Jul-2020, at 11:22 AM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>>

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

e specific DocumentsPropertyUI at http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/windows/classes/sun/print/Win32PrintService.java#l1692 Thanks, Jay On 17-Jul-2020, at 11:22 AM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Jay, I am usin

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

OLE”. Is creation of “JDIALOG_UI” restricted only to “MAIN_UIROLE”? Thanks, Jay On 15-Jul-2020, at 6:27 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Any reviewer for this? On 09-Jul-20 1:10 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Any reviewer for this? On 09-Jul-20 1:10 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where "Properties" button in ServiceUI.printDialog is enabled in windows but clicking it doesn't show any dialog. According to JDK-4673406 <https://bugs.openjdk.ja

[OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi All, Please review a fix for an issue where "Properties" button in ServiceUI.printDialog is enabled in windows but clicking it doesn't show any dialog. According to JDK-4673406 , the properties dialog isn't supported for direct uses with

Re: [OpenJDK 2D-Dev] RFR: 8244621: [macos10.15] Garbled FX printing plus CoreText warnings on Catalina when building with Xcode 11

, Prasanta Sadhukhan wrote: Hi Phil, I was reading somewhere that the warning is caused by JDK-8234916. Will we still get the problem if we remove 8234916? Regards Prasanta On 22-May-20 2:26 AM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8244621 Webrev : http

Re: [OpenJDK 2D-Dev] RFR: 8244621: [macos10.15] Garbled FX printing plus CoreText warnings on Catalina when building with Xcode 11

Hi Phil, I was reading somewhere that the warning is caused by JDK-8234916. Will we still get the problem if we remove 8234916? Regards Prasanta On 22-May-20 2:26 AM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8244621 Webrev : http://cr.openjdk.java.net/~prr/8244621/

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

;     } So overall in case of reader we throw exception when we have longer than 79 bytes strings and we follow same approach in writer as per specification. Thanks, Jay On 30-Apr-2020, at 3:35 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Jay, >> we w

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

pec complaint and not more than 79 bytes. Thanks, Jay On 30-Apr-2020, at 2:51 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Jay, But why reader will read more than 79 bytes from the chunk..It should also limit it's reading to 1st 79 bytes (if the chunks

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

tps://bugs.openjdk.java.net/browse/JDK-8195841> and JDK-8191023 <https://bugs.openjdk.java.net/browse/JDK-8191023>. Its better to be spec compliant than leaving things open for interpretation. Regards, Jay On 29-Apr-2020, at 1:22 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@ora

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

Hi Jay, Looks good to me . Although I have a question which is, instead of throwing Exception, can we proceed with 1st 79 bytes of these chunks and continue? Regards Prasanta On 27-Apr-20 10:51 PM, Philip Race wrote: I reviewed http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html and I

Re: [OpenJDK 2D-Dev] RFR: 8197797: Test java/awt/Graphics2D/DrawString/RotTransText.java fails

It seems in my windows 10 system, the test started failing on jdk11-b05 and started passing from jdk11-b17. +1 Regards Prasanta On 27-Apr-20 5:29 AM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8197797 webrev : http://cr.openjdk.java.net/~prr/8197797/ I can't reproduce

Re: [OpenJDK 2D-Dev] RFR: 8223090: Clean up obsolete logic & reference to Amble fonts.

Looks fine to me. Regards Prasanta On 05-Apr-20 11:08 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8223090 Webrev : http://cr.openjdk.java.net/~prr/8223090/ Removing obsolete dead code - it no longer has relevance. The disableHinting flag was discarded by the callees

Re: [OpenJDK 2D-Dev] RFR: 8240342: Custom composite is ignored when printing an opaque image to a page

Looks good to me too. Only minor nit is, probably in testcase, we can shift the BufferedImage creation code after the print service is found Regards Prasanta On 01-Apr-20 7:37 AM, Sergey Bylokhov wrote: On 3/31/20 5:42 pm, Philip Race wrote: On 3/31/20 1:37 pm, Philip Race wrote: The fix is

Re: [OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

On 01-Apr-20 3:51 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 3/30/20 7:46 am, Prasanta Sadhukhan wrote: I guess it is better if you directly pass NULL to OpenPrinter, rather than create an unnecessary variable. That was done only for documentation purposes. Also, I think it will be good

Re: [OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

Hi Sergey, I guess it is better if you directly pass NULL to OpenPrinter, rather than create an unnecessary variable. Also, I think it will be good if we do a ClosePrinter() if FindFirstPrinterChangeNotification() fails. Regards Prasanta On 30-Mar-20 7:13 PM, Sergey Bylokhov wrote: Hello.

Re: [OpenJDK 2D-Dev] RFR: 8232634: Problem List ICMColorDataTest.java

ok. Regards Prasanta On 21-Mar-20 11:16 AM, Philip Race wrote: Fair enough. But I'd still prefer to still p-l it on all platforms since there is no clear explanation of why this is worse on one platform than another. -phil. On 3/20/20, 9:30 PM, Prasanta Sadhukhan wrote: On 21-Mar-20 9:58

Re: [OpenJDK 2D-Dev] RFR: 8232634: Problem List ICMColorDataTest.java

On 21-Mar-20 9:58 AM, Prasanta Sadhukhan wrote: Shouldn't it be only on windows-all as the problem manifests now only in windows? linux-mac are working and as fast it can be. I mean it was mentioned it takes 3-4 minutes in linux-mac and 30-odd minutes in windows. Regards Prasanta On 21-Mar

Re: [OpenJDK 2D-Dev] RFR: 8232634: Problem List ICMColorDataTest.java

Shouldn't it be only on windows-all as the problem manifests now only in windows? linux-mac are working and as fast it can be. Regards Prasanta On 21-Mar-20 4:49 AM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8232634 This test ICMColorDataTest.java takes a very long time

Re: [OpenJDK 2D-Dev] RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print

+1 Regards Prasanta On 05-Mar-20 2:34 PM, Sergey Bylokhov wrote: (CC) 2d-dev, Looks fine. On 3/4/20 4:48 am, Toshio 5 Nakamura wrote: Hi, I'd like to ask review and sponsor of this fix. Issue: https://bugs.openjdk.java.net/browse/JDK-8240518 Fix:

Re: [OpenJDK 2D-Dev] RFR: 8214481: freetype path does not disable TrueType hinting with AA+FM hints

looks good to me. Regards Prasanta On 28-Nov-19 1:30 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8214481 Webrev: http://cr.openjdk.java.net/~prr/8214481/ This is a small change  so that when the RenderingHints for text antialiasing is specified together with fractional

Re: [OpenJDK 2D-Dev] RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Ja

Message- From: Prasanta Sadhukhan Sent: Dienstag, 26. November 2019 10:26 To: Baesken, Matthias ; Erik Joelsson ; 'build-...@openjdk.java.net' Cc: 2d-dev@openjdk.java.net; Lindenmaier, Goetz Subject: Re: RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build

Re: [OpenJDK 2D-Dev] RFR: 8234769: Duplicate attribution in freetype.md

+1 Regards Prasanta On 26-Nov-19 3:09 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8234769 Webrev: http://cr.openjdk.java.net/~prr/8234769/ It looks like the update for the legal file we were given has 2 copies of text about PSaux. I just need to remove one of them.

Re: [OpenJDK 2D-Dev] RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Ja

I have already raised a similar fix sometime back for JDK-8234786 Regards Prasanta On 26-Nov-19 2:49 PM, Baesken, Matthias wrote: Hello, here is a small adjustment that uses the typealias for NSTextInputSourceIdentifier . This fixes the build on macOS < 10.13 . Bug/webrev :

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

Only thing to be concerned about is the copyright of the ttf file. If it is not self-generated or GPL licensed or we are not sure of of its origin(most of will be copyrighted to Adobe or such, which are not ok to be checked in), It's better to reuse the A.ttf file already present in the repo

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8233910:java/awt/ColorClass/AlphaColorTest.java is failing intermittently in nightly lnux-x64 system

to create more technical debt. OK. Tried without EDT change and mach5 is still green for 3 iterations on all 3 platforms . http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.1/ Regards Prasanta -phil. On 11/11/19, 9:14 PM, Prasanta Sadhukhan wrote: I felt it was not needed

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8233910:java/awt/ColorClass/AlphaColorTest.java is failing intermittently in nightly lnux-x64 system

GUI(); -phil. On 11/11/19, 3:14 AM, Prasanta Sadhukhan wrote: Hi All, Please review a testfix for an issue seen to be failing intermittently in mach5 nightly linux system. The test uses robot to pick color from a frame's midpoint and check if the alpha is blended properly with the color but it se

[OpenJDK 2D-Dev] [14] RFR JDK-8233910:java/awt/ColorClass/AlphaColorTest.java is failing intermittently in nightly lnux-x64 system

Hi All, Please review a testfix for an issue seen to be failing intermittently in mach5 nightly linux system. The test uses robot to pick color from a frame's midpoint and check if the alpha is blended properly with the color but it seems the color is picked from wrong point. Proposed fix

Re: [OpenJDK 2D-Dev] RFR: 8233097: Fontmetrics for large Fonts has zero width

I believe 668 /* See the comments in getGlyphMetricsNative. They apply here too. */ should be getGlyphAdvanceNative Other than that, looks good to me. Regards Prasanta On 03-Nov-19 7:31 PM, Jayathirth Rao wrote: Changes are fine. Thanks, Jay On 01-Nov-2019, at 1:29 AM, Sergey Bylokhov

Re: [OpenJDK 2D-Dev] RFR [XS] : 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java

This test tests the newly added public API of BasicGraphicsUtils (exposing the functionality provided by internal class SwingUtilities2) for use by third party LAFs in JDK9 and beyond, so I guess we cannot ditch it completely. Regarding the test fragility, I actually incorporated the changes

Re: [OpenJDK 2D-Dev] [14] RFR: JDK-8223158: Docked MacBook cannot start any Java Swing applications

10/10/19 12:14 PM, Sergey Bylokhov wrote: On 10/9/19 11:05 pm, Prasanta Sadhukhan wrote: In that case, OK. this simplifies things, but I still don't understand why when what we are doing looks to be correct that the call fails. I do not have any definite answer to this but it seems getting disp

Re: [OpenJDK 2D-Dev] [14] RFR: JDK-8223158: Docked MacBook cannot start any Java Swing applications

On 09-Oct-19 9:31 PM, Phil Race wrote: So this means your speculation below that it was needed for the main display turns out to be untrue and we can definitely just drop it ? === On 9/25/19 11:13 PM, Prasanta Sadhukhan wrote: Hi Phil, On 25-Sep-19 9:58 PM, Philip Race wrote

Re: [OpenJDK 2D-Dev] [14] RFR: JDK-8223158: Docked MacBook cannot start any Java Swing applications

Hi Sergey, On 27-Sep-19 2:58 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 9/25/19 11:13 pm, Prasanta Sadhukhan wrote: 2) I guess we don't need to free "attrs" or "attrs1" since it is stack allocated .. Unfortunate that we have to repeat the entire initialisation minus gl

Re: [OpenJDK 2D-Dev] [14] RFR: JDK-8223158: Docked MacBook cannot start any Java Swing applications

alloc/init with a different list of attributes. */ } it is appropriate to try with another list, which is what I tried here. Regards Prasanta | -phil. On 9/25/19, 3:49 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that if a MacBookPro is attache

Re: [OpenJDK 2D-Dev] [14] Review request for 8227392: Colors with alpha are painted incorrectly on Linux, after JDK-8214579

+1 Regards Prasanta On 16-Jul-19 1:01 AM, Phil Race wrote: Looks good! -phil. On 7/15/19 10:26 AM, Anton Litvinov wrote: Hello Phil, Thank you for the reply. The second version of the fix with the described in the previous e-mail workaround for the regression test is created. Could you

Re: [OpenJDK 2D-Dev] JDK-8226654 Some swing gtk regression tests fail with "java.lang.InternalError: Unable to load native GTK libraries"

looks ok to me but the review should have been done in swing-dev alias. Regards Prasanta On 04-Jul-19 6:38 PM, Alexey Ushakov wrote: Hello, Here is a fix of the regression caused by JDK-8225118. Please, have a look. I’ve moved resolving gdk_window_get_scale_factor symbol under gtk version

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

/06/2019 11:34, Prasanta Sadhukhan wrote: Hi All, Please review a doc-fix to fix broken links in java.desktop files Bug: https://bugs.openjdk.java.net/browse/JDK-8225368 webrev: http://cr.openjdk.java.net/~psadhukhan/8225368/webrev.0/ Regards Prasanta

[OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

Hi All, Please review a doc-fix to fix broken links in java.desktop files Bug: https://bugs.openjdk.java.net/browse/JDK-8225368 webrev: http://cr.openjdk.java.net/~psadhukhan/8225368/webrev.0/ Regards Prasanta

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64

Gentle reminder... On 27-May-19 3:03 PM, Prasanta Sadhukhan wrote: Hi All, AlphaColorTest is failing in mach5 linux headful nightly system consistently and it seems to be a product bug, so needs to be problemlisted. diff -r cb2628a4f33f test/jdk/ProblemList.txt --- a/test/jdk

Re: [OpenJDK 2D-Dev] RFR: 8224778: test/jdk/demo/jfc/J2Ddemo/J2DdemoTest.java cannot find J2Ddemo.jar

+1 Regards Prasanta On 25-May-19 5:06 AM, Philip Race wrote: No other comments so far so here's that update : http://cr.openjdk.java.net/~prr/8224778.1/ -phil. On 5/24/19, 2:41 PM, Philip Race wrote: Yes, I just copied that line + edited it. I can update both lines if that is what you are

[OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64

Hi All, AlphaColorTest is failing in mach5 linux headful nightly system consistently and it seems to be a product bug, so needs to be problemlisted. diff -r cb2628a4f33f test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Wed May 15 15:17:24 2019 +0530 +++ b/test/jdk/ProblemList.txt  Mon

Re: [OpenJDK 2D-Dev] RFR: 8224705: Tests that need to be problem-listed or have printer resources

+1 Regards Prasanta On 24-May-19 3:11 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224705 Webrev: http://cr.openjdk.java.net/~prr/8224705/ There are open bugs and these can be problem listed as well as adding @key headful to the printer tests -phil.

Re: [OpenJDK 2D-Dev] Request for Sponsor: 8217735: awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong type

ngSet2 with Hotspot, possibly by luck of stack alignment. Many thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Prasanta Sadhukhan To: Andrew Leonard

[OpenJDK 2D-Dev] [13] JDK-8221411: NullPointerException in RasterPrinterJob without PrinterResolution

Hi All, Please review a fix for an issue where a NPE is seen when an attempt is made to print without PrinterResolution attributes in HP Deskjet 1510 printer. It seems when RasterPrinterJob#setAttributes() is called with no PrinterResolution attribute set, it first checks if

Re: [OpenJDK 2D-Dev] RFR: 8221304: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java

Shouldn't it be 8221305 in problemlist.txt as that is the actual bug which will solve the issue? Regards Prasanta On 22-Mar-19 9:50 AM, Philip Race wrote: Problem list a test that fails on Mac + Solaris on just those platforms : Bug: https://bugs.openjdk.java.net/browse/JDK-8221304 diff :

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

, Shashidhara Veerabhadraiah wrote: Hi Prasanta, I hope I have answered your questions satisfactorily. Please let me know if you have any more questions. Thanks and regards, Shashi *From:*Shashidhara Veerabhadraiah *Sent:* Friday, February 15, 2019 12:37 PM *To:* Prasanta Sadhukhan ; Philip Race

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

, Shashi *From:*Prasanta Sadhukhan *Sent:* Friday, February 15, 2019 12:11 PM *To:* Phil Race ; Shashidhara Veerabhadraiah *Cc:* 2d-dev@openjdk.java.net *Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732 Hi Shashi, I have one comment: doCompare

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

.openjdk.java.net/~sveerabhadra/8212202/webrev.06/ <http://cr.openjdk.java.net/%7Esveerabhadra/8212202/webrev.06/> Thanks and regards, Shashi *From:*Philip Race *Sent:* Saturday, February 9, 2019 2:25 AM *To:* Shashidhara Veerabhadraiah *Cc:* Prasanta Sadhukhan ; 2d-dev@openjdk.java.ne

Re: [OpenJDK 2D-Dev] RFR: [JDK12] 8218020 Fix version number in mesa.md 3rd party legal file

+1 Regards Prasanta On 30-Jan-19 10:59 PM, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8218020 This is a trivial fix to a license file for JDK 12 needed because v5.0 is what we are tracking as using, but the license file isn't updated from v4.1 The licensed header file

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214876: Add "intermittent" key for imageio/stream/StreamCloserLeak/run_test.sh

+1 Regards Prasanta On 05-Dec-18 6:49 PM, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214876 Webrev : http://cr.openjdk.java.net/~jdv/8214876/webrev.00/ I

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java

+1 Regards Prasanta On 07-Dec-18 2:52 PM, Jayathirth D V wrote: Hi Alexey, Thanks for the review. I will add space before pushing the change. Regards, Jay -Original Message- From: Alexey Ivanov Sent: Thursday, December 06, 2018 12:45 AM To: Jayathirth D V; 2d-dev Subject: Re:

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

(as well which are center-aligned by default anyway). If the content of the table is modified in the future, there will be no need to add style attributes to new cells which will have non-empty content. Does it look reasonable? Regards, Alexey On 30/11/2018 15:25, Prasanta Sadhukhan wrote:

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

o preserve the visual appearance? Do you mind updating the copyright? Otherwise, the change looks good to me. Regards, Alexey On 30/11/2018 07:41, Prasanta Sadhukhan wrote: Hi All, Please review a doc-fix to comply with HTML5 standard by removing the obsolete attribute "ali

[OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

Hi All, Please review a doc-fix to comply with HTML5 standard by removing the obsolete attribute "align" Bug: https://bugs.openjdk.java.net/browse/JDK-8213051 webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.0/ Regards Prasanta

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

are null and valid values and they can reach those states at any time either because of network disconnect or any other OS related changes. With that in mind, this fix tries to eliminate the possible NPE cases. Thanks and regards, Shashi *From:*Prasanta Sadhukhan *Sent:* Monday, November 26, 2018

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

ted with currentRemotePrinters. Regards Prasanta Thanks and regards, Shashi On 26/11/18 6:03 PM, Prasanta Sadhukhan wrote: Hi Shashi, I think l437 check of if-else if (prevRemotePrinters != null) {is not required. prevRemotePrinters null check is addressed in str1==null case in doCompare().

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213138: Update ProblemList.txt for mac

On 31-Oct-18 4:27 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 30/10/2018 02:58, Prasanta Sadhukhan wrote: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126 <https://bugs.openjdk.java.net/browse/JDK-8213126> The failure of the TestMainKeyWindow.java is not a bug, you

[OpenJDK 2D-Dev] [12] RFR JDK-8213138: Update ProblemList.txt for mac

Hi All, Please review an updation of ProblemList for mac jtreg run. Following tests were added in ProblemList. With this addition, mac10.13 jtreg run shows no failures/errors. java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213130: Update ProblemList after verification of jtreg tests in Win 7

looks ok. Regards Prasanta On 30-Oct-18 2:13 PM, Jayathirth D V wrote: Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213130 Webrev : http://cr.openjdk.java.net/~jdv/8213130/webrev.00/

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

Hi Fairoz, @bug tag should not spearate bugs by commas, just by spaces. other than that, looks ok to me. Regards Prasanta On 30-Oct-18 10:13 AM, Fairoz Matte wrote: Hi Prasanta, -Original Message- From: Prasanta Sadhukhan Sent: Monday, October 29, 2018 12:18 PM To: Fairoz Matte

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

please indent byte[] data ? Regards Prasanta On 26-Oct-18 10:03 PM, Fairoz Matte wrote: Hi Prasanta, Thanks for looking into it. -Original Message- From: Prasanta Sadhukhan Sent: Friday, October 26, 2018 8:56 AM To: Fairoz Matte ; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [8u

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212865: Broken external link to TIFF6.pdf in ImageIO package-info.java

looks fine. Regards Prasanta On 26-Oct-18 2:35 PM, Jayathirth Rao wrote: Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212865 Webrev : http://cr.openjdk.java.net/~jdv/8212865/webrev.00/

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

Hi Fairoz, Do you know if the bmp image file has Oracle copyright? If not, you cannot check it in. Alternatively, you may get a hexdump of the bmp file and create a byte[] array with that hex data and create ByteArrayInputStream with that and use that for ImageIO as an ImageInputStream.

<    1   2   3   4   5   6   >