[edk2] [MdeModulePkg][RegularExpressionDxe] Does not link NOOPT for Xcode clang.

2016-03-19 Thread Andrew Fish
or (fn = 0; fn < to->n; fn++) { cs[fn][0] = to->code[fn]; Contributed-under: TianoCore Contribution Agreement 1.0 Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

2016-03-19 Thread Andrew Fish
he usage, or really when the compiler detects the warning? For example how is this going to work on public interfaces? Protocols, PPIs, or library class definitions? There is a single definition of the function, but multiple implementations. Some implementatio

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

2016-03-19 Thread Andrew Fish
@intel.com > <mailto:liming@intel.com>>; Leif Lindholm <leif.lindh...@linaro.org > <mailto:leif.lindh...@linaro.org>> > Subject: Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h > > > > On Mar 16, 2016, at 10:06 AM, Laszlo Ersek wrote:

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

2016-03-19 Thread Andrew Fish
statements in the EDK II C Coding > Style document about use of the UNUSED macro, but that is likely its own > thread. > Mike, Sounds good to me. Thanks, Andrew Fish > Mike ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

2016-03-19 Thread Andrew Fish
dependent libraries to figure this out. I think the DebugLib is a special case since it is used by almost every other library, and it has the possibility of being complex and depend on a lot of other libraries. Thanks, Andrew Fish > Best Regards, > Peter Kirmeier > > -Or

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

2016-03-19 Thread Andrew Fish
way to disable > this warning for all APIs that are decorated with EFIAPI? > I think the point of __attribute__ ((unused)) is to suppress the warning if it is enabled. Since we suppress the diagnostic from the compiler we don't need this. Thanks, Andrew Fish > Thanks, > > Mike > >&

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

2016-03-19 Thread Andrew Fish
> On Mar 16, 2016, at 7:18 PM, Zeng, Star <star.z...@intel.com> wrote: > > On 2016/3/17 10:02, Andrew Fish wrote: >> >>> On Mar 16, 2016, at 6:59 PM, Zeng, Star <star.z...@intel.com> wrote: >>> >>> On 2016/3/17 7

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

2016-03-19 Thread Andrew Fish
conclusion. I'm making a local copy DxeDebugPrintErrorLevelLib that does the HOB accesses in the driver without the HobLib and that will solve our issue. I was just surprised the edk2 library was not very useful in the real world. Not to mention the build error message did not help find the real issue, the HOB l

[edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

2016-03-19 Thread Andrew Fish
it looks like the DxeDebugPrintErrorLevelLib depends on the Hob lib that depends on the DebugLib that depends on the DxeDebugPrintErrorLevelLib. How did this every work? The only place I see it used is the Nt32Pkg, and I don't have a system to test that on Any ideas? Thanks, Andrew Fish

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

2016-03-19 Thread Andrew Fish
sign/dev/test work > that requires cooperation of multiple subject matter experts and the PR > is re-directed to a feature branch in edk2-staging. I think David's point is any github repository can be used for this, if I understand David's point? So the only value to branches is an off

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

2016-03-19 Thread Andrew Fish
rf, then he/she > should be able to annotate the unused parameters with a macro that is > centrally defined. The macro definition should be universal, even though > its application might not be. > That sounds reasonable to me. I think in general you will find that Mike Kinney and I are

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

2016-03-18 Thread Andrew Fish
, the source lines between DEBUG_CODE_BEGIN() and DEBUG_CODE_END() are not included in a module. **/ #define DEBUG_CODE_END()__DebugCodeLocal = 0; __DebugCodeLocal++; } } while (FALSE) Note you only get the dead stripping if DebugPrintEnabled() or DebugCodeEnabled() resolve

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

2016-03-18 Thread Andrew Fish
> On Mar 18, 2016, at 5:13 PM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 03/19/16 00:27, Andrew Fish wrote: >> >>> On Mar 18, 2016, at 3:46 PM, Michael Brown <mc...@ipxe.org> wrote: >>> >>> On 18/03/16 22:30, Laszlo Ersek wrote: &g

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

2016-03-18 Thread Andrew Fish
) if mHobList is NULL. I agree enhancing the error message is a good idea. Thanks, Andrew Fish > Thanks > Liming > From: af...@apple.com [mailto:af...@apple.com] > Sent: Friday, March 18, 2016 2:06 AM > To: peter.kirme...@ts.fujitsu.com > Cc: Ard Biesheuvel <ard.bies

Re: [edk2] Is there any exiting way in edk2 to format a partition with FAT file system?

2016-03-18 Thread Andrew Fish
r > the second monopoly hint, is this EULA still needed? > Thanks, Andrew Fish PS I'm a little confused on why the web page talks about the EFI Driver Writer's Guide? Extensible Firmware Interface Disk utilities download agreement Before downloading the EFI Driver Writer's Guide

[edk2] [MdeModulePkg] char sign miss match

2016-03-15 Thread Andrew Fish
]; UINT32 Index; OnigUChar *Start; Contributed-under: TianoCore Contribution Agreement 1.0 Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [MdeModulePkg] Do we support redefinition of typedefs?

2016-03-15 Thread Andrew Fish
. Contributed-under: TianoCore Contribution Agreement 1.0 Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/4] free(NULL) and realloc(NULL, size) conformance improvements

2016-03-12 Thread Andrew Fish
MSFT:*_*_X64_ASM_FLAGS == /nologo /W3 /WX /c /Cx /Zd /W0 /Zi MSFT:*_*_X64_ASMLINK_FLAGS == /link /nologo INTEL:*_*_IA32_DLINK_FLAGS == /out:"$(BIN_DIR)\SecMain.exe" /base:0x1000 /pdb:"$(BIN_DIR)\SecMain.pdb" /LIBPATH:"C:\Prog

Re: [edk2] EDK2 Staging Repository

2016-03-09 Thread Andrew Fish
) to actually merge the feature seems perhaps >> unneccesary. >> >>> Proposal >>> >>> 1) Create a new repo called edk2-staging >>>a) edk2-staging is a fork of edk >>>b) edk2-staging/master tracks edk2/master >>&

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-08 Thread Andrew Fish
> I guess we could add an argument that enable/disables the behavior changes? Thanks, Andrew Fish > Thanks > Liming >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Andrew Fish >> Sent: Saturday, March 05, 2

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-04 Thread Andrew Fish
to setup the environment. Thus moving the Conf/ processing to build.py (build.exe) makes it more convenient to use the --conf flag, and helps make the setup scripts less complex. Thanks, Andrew Fish > if [ -n "$EDK_TOOLS_PATH" ] > then > . $EDK_TOOLS_PATH/BuildEnv $* &

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-04 Thread Andrew Fish
ource control? https://github.com/tianocore/edk2/tree/master/Conf Is this just syncing the behavior with Edk2Setup.bat? If so maybe that should be stated in the description of the patch. Do you need to update the copyright to 2016? Thanks, Andrew Fish > Contributed-under: TianoCore Contribution Ag

Re: [edk2] "echo" objcopy not needed doesn't actually work

2016-03-02 Thread Andrew Fish
;git blame -L4314,4316 BaseTools/Conf/tools_def.template 3b6c90a1 (eric_tian 2009-04-13 12:50:50 + 4314) *_*_*_OBJCOPY_PATH = echo 3b6c90a1 (eric_tian 2009-04-13 12:50:50 + 4315) *_*_*_OBJCOPY_FLAGS = objcopy not needed for 3b6c90a1 (eric_tian 2

Re: [edk2] [Patch] BaseTools: update the mail address for stack trace info

2016-02-29 Thread Andrew Fish
> On Feb 28, 2016, at 7:51 PM, Gao, Liming <liming@intel.com> wrote: > > Reviewed-by: Liming Gao <liming@intel.com> > Reviewed-by: Andrew Fish <af...@apple.com> Thanks, Andrew Fish >> -Original Message- >> From: edk2-devel [mailto:

Re: [edk2] best way to load a shell app to another address?

2016-02-26 Thread Andrew Fish
e you care about an EFI Runtime Driver, as it will likely get loaded at the top of memory with the rest of the firmware. The only difference between a Driver and an Application (other than the type in the PE/COFF image) is that an application always unloads on exit, while a driver only unloa

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-17 Thread Andrew Fish
ly the UEFI spec and the edk2 don't try to force platform policy. For example exposing some configuration information could be considered a security vulnerability on some platforms, so it should not be forced on a platform. Thanks, Andrew Fish > Also we collect the performance data from our r

Re: [edk2] Why is the tools_def.txt file parsed 47 times on my fds build?

2016-02-17 Thread Andrew Fish
onal packages that let you build call graphs, and do other interesting things on the pstats object. I've not tried those out. Thanks, Andrew Fish > Thanks > Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish &

Re: [edk2] Allocating Aligned Pages

2016-02-17 Thread Andrew Fish
ed on platforms like ARM and allow lesser > memory fragmentation > (though it has its own demerits). > I thought it did? 64K is a power of 2, so does not the current API work? FYI the EFI page size is not the size of the page tables, but just the quanta of memory you can allocate that

Re: [edk2] Allocating Aligned Pages

2016-02-17 Thread Andrew Fish
ave? Have you looked at the memory map in the shell to see how fragmented it is? Thanks, Andrew Fish > Here is the 'AllocateAlignedPages' function which calls > 'InternalAllocateAlignedPages' internally. > > /** > Allocates one or more 4KB pages of type EfiBootServicesData at a spec

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-16 Thread Andrew Fish
or string is changed. Also, platforms should > be able to decide if they want to offer this data to the OS. > +1 I would want to opt out to NOT take the memory away from the OS if the platform did not care about the feature. Thanks, Andrew Fish > Why not

[edk2] Why is the tools_def.txt file parsed 47 times on my fds build?

2016-02-16 Thread Andrew Fish
ome this information is not cached? Does anyone see a quick fix? Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Any interest in enabling building platforms in parallel?

2016-02-12 Thread Andrew Fish
restructure the makefiles to support parallel build, but that may only save a few seconds. #3 Someone could look a nmake as I've only looked at GNU make. Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman

Re: [edk2] BaseTools build number after transition to git

2016-02-10 Thread Andrew Fish
hash of the HEAD so you don't need an untracked file, or extra steps in the build process, to get this done. Thanks, Andrew Fish > Thanks > Laszlo > >> >> Felix >> >> >> The information contained in this message may be confidential and >> propriet

Re: [edk2] [PATCH] StdLib: add __noreturn attribute to __assert

2016-02-08 Thread Andrew Fish
7 +52,7 @@ __BEGIN_DECLS > the application was launched from. > **/ > extern void > -__assert(const char *file, const char *func, int line, const char > *failedexpr); > +__assert(const char *file, const char *func, int line, const char > *failedexpr) __noreturn;

Re: [edk2] manually booting efi file

2016-02-05 Thread Andrew Fish
:3351: EFI_REMOVABLE_MEDIA_FILE_NAME, Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c:3837: EFI_REMOVABLE_MEDIA_FILE_NAME, Thanks, Andrew Fish > Thanks for everyone's help :) > > Michael > > On Fri, Feb 5, 2016

Re: [edk2] Connecting all devices at boot

2016-02-05 Thread Andrew Fish
ent driver behavior. In general connecting all drivers on boot is a performance bug. How the BDS configures boot options is just implementation choice, so you can modify it to be what ever your platform needs. Thanks, Andrew Fish > I've been thinking about proposing an enhancement to the spec to cov

Re: [edk2] Connecting all devices at boot

2016-02-05 Thread Andrew Fish
;> fails. ("Link timeout in auto-negotiation".) >> > > Correct. > > >> (3) I think repeated BdsLibConnectAll() calls may only give more time to >> the NIC to bring itself into working shape. What if you keep only one >> BdsLibConnectAll(), a

Re: [edk2] Connecting all devices at boot

2016-02-05 Thread Andrew Fish
> On Feb 5, 2016, at 10:47 AM, Ryan Harkin <ryan.har...@linaro.org> wrote: > > Hi Andrew, > > On 5 February 2016 at 18:39, Andrew Fish <af...@apple.com> wrote: >> >>> On Feb 5, 2016, at 10:36 AM, Ryan Harkin <ryan.har...@linaro.org> wrote: >&

Re: [edk2] How do you get current timestamp in ms or ns ?

2016-02-04 Thread Andrew Fish
> If it is in a FV that the DXE Core knows about it will get dispatched. That driver has a Dependency Expression (depex) of TRUE so it should dispatch early in DXE. You should see DEBUG prints from the DXE core about what is getting dispatched. It will either show the driver name or the FILE_

Re: [edk2] UEFI Shell: Backspace doesn't work

2016-02-04 Thread Andrew Fish
e ConIn and ConOut default paths in my platform >>>>> .dsc with VenMsg(), and I still cannot get either Backspace or "Ctrl >>>>> + h" to work :( >>>>> >>> >>> Ah, assuming you corrected the missing trailing quotes to get i

Re: [edk2] [Patch] MdeModulePkg: Update DxeCore dispatcher to ignore PEI and SMM depex for FV.

2016-02-03 Thread Andrew Fish
Reviewed-by: Andrew Fish <af...@apple.com> > On Feb 3, 2016, at 6:01 AM, Liming Gao <liming@intel.com> wrote: > > If FV image without DXE depex, it will be dispatched by DxeCore. > If FV image with SMM depex, it is the invalid image. ASSERT will be trig. > >

[edk2] How to I get access to the "Project Tracker"?

2016-02-02 Thread Andrew Fish
Support -> Reporting Issues link not tell you how to access the bug database? Thanks, Andrew Fish https://github.com/tianocore/tianocore.github.io/wiki/Reporting_Issues The SourceForge Trac Application The bug tracking system used by the EFI and Framework Open Source Community Webs

Re: [edk2] How to I get access to the "Project Tracker"?

2016-02-02 Thread Andrew Fish
> On Feb 2, 2016, at 3:41 PM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/03/16 00:33, Andrew Fish wrote: >> It looks like Laszlo is doing maintenance on bugs, but I can't seem to find >> the location of the database? > > Ooops, been caught red-handed!

[edk2] Dxe Core support for EFI_SECTION_PEI_DEPEX section.

2016-02-01 Thread Andrew Fish
tus)) { // // If PEI depex section is found, this FV image will be ignored in DXE phase. // Now, DxeCore doesn't support FV image with more one type DEPEX section. // FreePool (DepexBuffer); continue; } Thanks, Andrew Fish

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-15 Thread Andrew Fish
pth >>>> explicitly, with a SetAttributes() call. A good value for that looks >>>> like zero (= device's default FIFO depth). I believe the value zero also >>>> happens to restore the previous behavior, in practice -- it's just not >>>> SerialDxe

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Andrew Fish
to extern "C" {} all the edk2 C include files. This should prevent the name mangling of the edk2 C code functions. I think folks have ported C++ code in the past, so I guess it is possible. >From a quick search of the internet I see that those relocations are for a >different mem

Re: [edk2] clang + ld build with .data section link error in X64 binary

2015-12-07 Thread Andrew Fish
n__TEXT,__cstring,cstring_literals L_.str1:## @.str1 .space 1 .section__DATA,__data .globl _Two ## @Two .align 3 _Two: .quad L_.str1 .comm _Three,8,3 ## @Three .

Re: [edk2] asm/S assembler files

2015-12-02 Thread Andrew Fish
"=d" (HighData) // %1 : "c" (Index) // %2 ); return (((UINT64)HighData) << 32) | LowData; } Not sure why the Vlv2TbltDevicePkg needed to add that assembly code? I would also point out that the inline assembly will optimize better as the compiler

Re: [edk2] asm/S assembler files

2015-12-02 Thread Andrew Fish
s part of the bitcode, so when the native code generation happens it is very easy for the compiler to optimize. Thanks, Andrew Fish ~/work/Compiler>cat bit.c #define IN typedef unsigned int UINT32; typedef unsigned long long UINT64; UINT64 AsmReadMsr64 ( IN UINT32

Re: [edk2] EDK2 and VS2015

2015-12-02 Thread Andrew Fish
You can try applying that patch. You will need to remove your Conf/boots_def.txt file to get the BaseTools/Conf/tools_def.template file copied over by the edksetup script. Thanks, Andrew Fish > ___ > edk2-devel mailing list > edk2-devel@lists

Re: [edk2] [PATCH v2 1/3] BaseTools RVCT: use scatter file to implement minimum section alignment

2015-12-01 Thread Andrew Fish
ch-O we ended up linking the image with the offset of the PE/COFF (0x240) so the tool that converts to PE/COFF does not have to apply relocations. Thanks, Andrew Fish > Reviewed-by: Eugene Cohen <eug...@hp.com> > > Eugene > >> -Original Message- >> From:

Re: [edk2] OvmfPkg: ASSERT hit when booting in QEMU with PcdShadowPeimOnS3Boot and PcdShadowPeimOnBoot set to FALSE

2015-11-30 Thread Andrew Fish
t; The strange thing about this is the failure is loading the DXE Core from the DXE IPL, so all of PEI has already run and been dispatched? #2 0x00822f0e in PeiLoadImageLoadImage at /home/miki/vcs/git/edk2/MdeModulePkg/Core/Pei/Image/Image.c:603 #3 0x00823326 in PeiLoadImageLoadIm

Re: [edk2] Strange behavior of the DS-5 debugger on AARCH64 with step-by-step debugging in uefi

2015-11-30 Thread Andrew Fish
2.git >> > > I am sorry, but since I don't have access to DS-5, I am not sure how > to debug this. > > Is there any way for you to figure how much the offset is between the > current and the correct location? I.e., by looking at the ELF asm dump > and the instructions

Re: [edk2] Dynamic PCD Variable Storage in PEI Phase

2015-11-23 Thread Andrew Fish
o the build command to look at a log of the build. So add -y build.log (or --report-file=build.log). It will show what library instances got picked for the driver and what PCD values that the driver is using. Thanks,

Re: [edk2] How to add /O1 (min size) compile option to edk2 apps ?

2015-11-20 Thread Andrew Fish
he build targets are being used. So: build -b RELEASE The optimization flags for VC++ are more complex than /O1, as it is uses a very specific /O1 variant and also uses other flags to turn on link time optimization. Thanks, Andrew Fish > How do I also add /O1 (that's capitol letter "O&

Re: [edk2] Dynamic PCD Variable Storage in PEI Phase

2015-11-20 Thread Andrew Fish
ce. The BasePcdLibNull instance will ASSERT on any calls. You want to use the instances of the library that call the PPI/Protocol. https://github.com/tianocore/edk2/tree/master/MdePkg/Library/PeiPcdLib https://github.com/tianocore/edk2/tree/master/MdePkg/Library/DxePcdLib Thanks, Andrew Fish &

Re: [edk2] It seems something wrong inGraphicsConsoleControllerDriverStart() when user defined resolution is notsupported

2015-11-17 Thread Andrew Fish
> On Nov 17, 2015, at 5:31 PM, winddy <winddy_zh...@foxmail.com> wrote: > > Hi RuiYu, > patch file is attached. I don't see the attachment. I've had trouble attaching patches to the mailing list too? Thanks, Andrew Fish > Thanks. > > >

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-16 Thread Andrew Fish
t;> Is it one of the edk2 timer libs? If so which one? > > Nope it's my own, platform specific one(my device hasn't been merged to the > official sources yet). > Most of the other TimerLib implementations use a free running counter. Thanks, Andrew Fish > Michael > > >

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-14 Thread Andrew Fish
tions of the > timerLib because they're not thread safe. > Is it one of the edk2 timer libs? If so which one? Thanks, Andrew Fish > The reason is that a hw counter gets reset and started for this and if this > happens from an interrupt(UART uses delay functions) while the thread mod

Re: [edk2] Alter OVMF/UEFI iSCSI settings outside of the OVMF UI

2015-11-13 Thread Andrew Fish
tianocore/edk2/tree/master/MdeModulePkg/Universal/Variable/RuntimeDxe Thanks, Andrew Fish > Thanks for your help! > > Kind regards, > > Pascal van Dam > > > ___ > edk2

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
lt;= TPL of your event from making forward progress. gBS->Stall() does not yield, it is no different than running code. So there is only one context, you can print it out any time you want. Thanks, Andrew Fish PS When folks yell at us for not having threads in EFI we point them at:

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
ld output directory and see what code it maps to. The X86 version of all this lives: https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c Thanks, Andrew Fish > On Thu, Nov 12, 2015 at 7:39 PM, Andrew Fish <af...@apple.com> wrote:

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
> On Nov 12, 2015, at 3:22 AM, Andrew Fish <af...@apple.com> wrote: > > >> On Nov 12, 2015, at 12:49 AM, Michael Zimmermann <sigmaepsilo...@gmail.com> >> wrote: >> >> Stall was just an example, I can also use DEBUG. My timer interval i

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
sed to implement the timer tick. Every thing else is an event that runs in the main EFI context. https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Event/Tpl.c#L126 Thanks, Andrew Fish > On Thu, Nov 12, 2015 at 9:27 AM, Andrew Fish <af...@apple.com> wrote: > >>

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
> On Nov 12, 2015, at 3:28 AM, Andrew Fish <af...@apple.com> wrote: > >> >> On Nov 12, 2015, at 3:22 AM, Andrew Fish <af...@apple.com> wrote: >> >> >>> On Nov 12, 2015, at 12:49 AM, Michael Zimmermann <sigmaepsilo...@gmail.com> >

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
at Emptor Assume it is your event and figure out if you are doing something slow at an elevated TPL, calling a service at too hight a TPL., or have TPL related deadlock based on the TPL restrictions. Thanks, Andrew Fish PS Sorry if this is more detail than you needed, but I figured other folks

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-11 Thread Andrew Fish
k the UEFI revision and "do the correct thing". So I think the objection >is the shell was written to strictly conform to the latest UEFI specification, >when it could have been made backward compatible with a range of UEFI >specification versions. Thanks, Andrew Fish

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
de-warnings-fix.patch 0003-MdeModulePkg-Variable-add-mising-VA_COPY.patch I attached again here: Thanks, Andrew Fish > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish > Sent: Tuesday, November 10, 2015 3:18 PM > To: edk2-devel > Cc: Tian,

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
> On Nov 10, 2015, at 7:04 AM, Andrew Fish <af...@apple.com> wrote: > > >> On Nov 10, 2015, at 12:06 AM, Gao, Liming <liming@intel.com> wrote: >> >> Andrew: >> The patch is missing. >> > > Liming, > > My sent mail shows

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
> On Nov 10, 2015, at 7:04 AM, Andrew Fish <af...@apple.com> wrote: > > >> On Nov 10, 2015, at 12:06 AM, Gao, Liming <liming@intel.com> wrote: >> >> Andrew: >> The patch is missing. >> > > Liming, > > My sent mail shows

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
> On Nov 10, 2015, at 7:04 AM, Andrew Fish <af...@apple.com> wrote: > >> >> On Nov 10, 2015, at 12:06 AM, Gao, Liming <liming@intel.com >> <mailto:liming@intel.com>> wrote: >> >> Andrew: >> The patch is missing. >> >

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Andrew Fish
thon/Common/DataType.py:435:TAB_TOD_DEFINES_BUILDRULEORDER = 'BUILDRULEORDER' I realize now that my previous test may have been flawed since I had NASM installed. Thanks, Andrew Fish > -Jordan > > On 2015-11-10 18:30:39, Gao, Liming wrote: >> This patch is committed at r18766. >&g

[edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-09 Thread Andrew Fish
Please review. To build with Xcode without installing NASM I had to make the following change. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-11-06 Thread Andrew Fish
> On Nov 6, 2015, at 1:51 AM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/23 14:04, Andrew Fish wrote: >> >>> On Oct 22, 2015, at 10:10 PM, Zeng, Star <star.z...@intel.com> wrote: >>> >>> On 2015/10/22 23:29, Andrew Fish wrot

Re: [edk2] I don't understand AllocatePages

2015-11-06 Thread Andrew Fish
assed to the OS are page aligned to make it easier for the OS to map. Thanks, Andrew Fish > Thanks, > Shubha > Shubha D. ramanishubharam...@gmail.com > shubharam...@yahoo.com > ___ > edk2-devel mailing list > ed

Re: [edk2] C Coding Standards Specification disappeared

2015-11-05 Thread Andrew Fish
and stay on a given official UDK 201* release for some time. Thus global formatting changes make diffing more challenging. Thanks, Andrew Fish > On Nov 5, 2015, at 10:26 AM, Kinney, Michael D <michael.d.kin...@intel.com> > wrote: > > Laszlo, > > I agree cast opera

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Andrew Fish
, changing system mappings, and for ARM DMA. So it would be good to make the common cases clear. For example the Cache Operations in the MdePkg started out as the set of operations you need to do generically for an x86 or Itanium processor. Thanks, Andrew Fish > Thanks, > Mark. > ___

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-11-03 Thread Andrew Fish
e local apic state in that case. > I've seen the SMI IPI in code, but I think it is mostly used to deal with the case that the processor is sitting in an INIT and the broadcast SMI was ignored. Thanks, Andrew Fish >> Actually, I was *de*prioritizing it because things _more or less_ wor

Re: edk2[18717] Revert "MdeModulePkg: Fix a PciBusDxe hot plug bug"

2015-11-02 Thread Andrew Fish
ulePkg: Fix a PciBusDxe hot plug bug" > > This reverts commit 73b7f115c653c807b9d0be97bf516871d8aff7ba. > Why was it reverted? Thanks, Andrew Fish > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Rev

Re: [edk2] [Patch 1/2] UefiCpuPkg/CpuDxe: Fix one dead lock issue in StartupThisAP()

2015-10-28 Thread Andrew Fish
to CpuStateReady -- this will prevent the AP > from changing the state from Idle to Sleep. > > Such state transitions should be atomic in general. > > (2) The last sentence of the commit message should be: > > The fix is to *hold* the lock till BSP finished setting the semaphore.

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-26 Thread Andrew Fish
> On Oct 25, 2015, at 6:04 PM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/23 22:11, Andrew Fish wrote: >> >>> On Oct 23, 2015, at 12:53 AM, Zeng, Star <star.z...@intel.com> wrote: >>> >>> On 2015/10/22 23:54, Andrew Fish wrote:

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-23 Thread Andrew Fish
> On Oct 23, 2015, at 12:53 AM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/22 23:54, Andrew Fish wrote: >> /Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28: >> error: for loop has empty body [-Werror,-Wempty-body]

[edk2] [BaseTools] I see main Python thread of build doing acquire thread.lock 87% of a single threaded build.

2015-10-23 Thread Andrew Fish
1010.0000.5150.000 Misc.py:1104(__contains__) Also is findall being called too much? Thanks, Andrew Fish PS This is how I turned on cProfile ~/work/src/edk2(master)>git diff BaseTools/BinWrappers/PosixLike/build diff --git a/BaseTools/BinWrappers/PosixLike/build b/BaseTools/BinWr

Re: [edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
> On Oct 21, 2015, at 6:34 PM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/22 7:02, Andrew Fish wrote: >> "/usr/bin/clang" -target x86_64-pc-win32-macho -c -g -Os -Wall -Werror >> -Wextra -include AutoGen.h -funsigned-char -fno-ms-extensions

[edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
Temp Heap : BaseAddress=0x%p Length=0x%X\n", Private->HobList.Raw, (UINT32)((UINTN) Private->HobList.HandoffInformationTable->EfiFreeMemoryBottom - (UINTN) Private->HobList.Raw))); Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish <af

[edk2] [MdeModulePkg] RegularExpressionDxe does not link with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish <af...@apple.com <mailto:af...@apple.com>> Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] style question/Omap3530Gpio

2015-10-21 Thread Andrew Fish
e/master/PcAtChipsetPkg/Include, there is an Include/Register/ but no IndustryStandard dir. The generic answer is the package really owns defining the public include structure. The important point is being really clear on what is public and what is private. The EDK was really bad about

[edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-10-21 Thread Andrew Fish
1.0 Reviewed-by: Andrew Fish <af...@apple.com> Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Is the edk2 FV INF format documented?

2015-10-20 Thread Andrew Fish
it's not too much trouble could someone who knows the GenFv tool please > consider documenting this? > Might as well add the *.Fv.map files to the list of please document too. I know I have debugger scripts that parse these files. Thanks, Andrew Fish > Thanks, > > Eugene >

[edk2] MdePkg include definition issue in UefiPxe.h?

2015-10-19 Thread Andrew Fish
/UefiPxe.h#L320 #define PXE_OPFLAGS_STATION_ADDRESS_READ 0x #define PXE_OPFLAGS_STATION_ADDRESS_WRITE 0x #define PXE_OPFLAGS_STATION_ADDRESS_RESET 0x0001 Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org

Re: [edk2] [PATCH v3 44/52] OvmfPkg: QemuFlashFvbServicesRuntimeDxe: no dual addressing needed

2015-10-18 Thread Andrew Fish
to a function is a pointer to a data structure (called PLABLE) that contains a register value, and the function pointer. Thanks, Andrew Fish > I've always seen it done this way, but likely this has been due to a > lot of "copy the old version and modify." > > -Jorda

Re: [edk2] How do you compile EDK2 git repo on Windows ?

2015-10-17 Thread Andrew Fish
of edk2 source. git is > a much nicer way to get the latest edk2 updates. > $ source edksetup.sh > $ make -C "$EDK_TOOLS_PATH” > make is a GNU command so would have to have GCC installed to have make. Thanks, Andrew Fish > Shubha D. ramanishubharam...@gmail.com > shubha

Re: [edk2] [EDK II] implementing EFI_SMART_CARD_EDGE_PROTOCOL.GetData

2015-10-15 Thread Andrew Fish
age/Include/Guid/NewGuid.h and update MyPackage/MyPackage.dec, assuming MyPackage is the name of the package you own, and NewGuid is the name of the GUID you defined. Thanks, Andrew Fish > > > Best Regards, > > Nilesh > > ___

Re: [edk2] [grub PATCH] efinet: disable MNP background polling

2015-10-15 Thread Andrew Fish
tack (iPXE) trying to make it as common as possible in all its various ports does not seem like an unreasonable goal, but you might not end up with the ideal implementation for each environment. Thanks, Andrew Fish > Laszlo > >> For information, the MNP driver in UEFI net

Re: [edk2] [grub PATCH] efinet: disable MNP background polling

2015-10-15 Thread Andrew Fish
tack (iPXE) trying to make it as common as possible in all its various ports does not seem like an unreasonable goal, but you might not end up with the ideal implementation for each environment. Thanks, Andrew Fish > Laszlo > >> For information, the MNP driver in UEFI net

Re: [edk2] apple efi

2015-10-13 Thread Andrew Fish
the earlier Simple Text Input Protocol > (not extended) and therefore can't detect the shift states and toggle states > of the key input. > (hence not detect ALT, CTRL etc, or OPTION.) > > so how does apple detect if OPTION is pressed to know to bring up Startup > Manager? Ext

Re: [edk2] [PATCH v2 11/41] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-10-13 Thread Andrew Fish
t; machine-wide rendezvous when it isn't necessary. Which is kind of scary since it takes a single CPU away from the OS, and the SMM code and OS would be running at the same time. Thanks, Andrew Fish > BIOS implementations may be lagging behind. > >> >> Second, if writing to i

Re: [edk2] [PATCH 7/7] UefiCpuPkg: Add missing UefiCpuPkgTokenSpace include

2015-10-08 Thread Andrew Fish
for explaining me the PcdGetEx__() family of functions at the > same time :) I've been wondering about both them, and how one could > resolve token name collisions between different token spaces. > Apparently, with the Ex family (but it remains unnecessary in practice). > It is only ne

Re: [edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64

2015-10-08 Thread Andrew Fish
ew: PcdDynamic means you use the PCD PPI/Protocol with the build generated Token PcdDynamicEx means you use the PCD PPI/Protocol with the fixed Token and EFI_GUID from the .DEC. The DSC file also has a knob that controls how dynamic PCDs are stored. So PcdsDynamicHii is a PcdDynamic form, but the drive

Re: [edk2] Is it possible to 'resume' and event?

2015-10-07 Thread Andrew Fish
vent to not take too much time. You will need to chop up the work in the event, or make the main code process an event loop. https://web.stanford.edu/~ouster/cgi-bin/papers/threads.pdf <https://web.stanford.edu/~ouster/cgi-bin/papers/threads.pdf> Thanks, Andrew Fish > > Than

<    6   7   8   9   10   11   12   13   14   15   >